)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8afa24f62669a213b9780983d316337754143c51","unresolved":true,"context_lines":[{"line_number":10,"context_line":"Kayobe, and templates Ironic PXE and Ironic Inspector kernel"},{"line_number":11,"context_line":"parameters to new variables in Kolla-Ansible and Bifrost."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I2ef63233eae661ed056bfa215b2875f44e0b6134, Ied8bc515fa33707eefcd9759251821ed83253a8b"},{"line_number":14,"context_line":"Change-Id: I97e1f5cf187299f6d1d287202fec436f53fbe0b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ef807ae3_8b19c1b6","line":13,"updated":"2023-11-02 11:07:50.000000000","message":"I think these need to be separate Depends-On lines:\n\nDepends-On: grsekln\nDepends-On: lgkewlk","commit_id":"17536040f4bcd958211732ad021377abf75da567"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"81a20409cee896767e18e601d9cdd5c4ea2888cd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Kayobe, and templates Ironic PXE and Ironic Inspector kernel"},{"line_number":11,"context_line":"parameters to new variables in Kolla-Ansible and Bifrost."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I2ef63233eae661ed056bfa215b2875f44e0b6134, Ied8bc515fa33707eefcd9759251821ed83253a8b"},{"line_number":14,"context_line":"Change-Id: I97e1f5cf187299f6d1d287202fec436f53fbe0b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"368571d1_2fb8fcc4","line":13,"in_reply_to":"ef807ae3_8b19c1b6","updated":"2023-12-20 13:47:40.000000000","message":"Done","commit_id":"17536040f4bcd958211732ad021377abf75da567"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8a9cf93c38c8a8cc201deb0637089d7a738401db","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Jake Hutchinson \u003cjake@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-02-07 13:12:53 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add NTP parameter configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds Ironic Python Agent (IPA) NTP configuration to"},{"line_number":10,"context_line":"Kayobe for Bifrost and Kolla-Ansible, and templates Ironic PXE"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"4c4ea1ba_969487c3","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":31},"updated":"2024-02-08 08:44:03.000000000","message":"Please mention that this is about IPA in the summary line.","commit_id":"572817d4cf782309ad0df7a56a7d758f8af801eb"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"09329390dc34ba6a17a1d448183dd977ae693a11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ac73458a_1aefdce3","updated":"2024-02-06 12:39:13.000000000","message":"recheck: docker devicemapper issues","commit_id":"959f614f2b55a2c87569e5e10f209ff58e479db1"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"0170156e42321b6644588d00bbb301e6c8bf3b13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"0b59f247_c1294682","updated":"2024-02-16 10:04:49.000000000","message":"Mostly looks good to me. Will +2 when other comments have been addressed.","commit_id":"572817d4cf782309ad0df7a56a7d758f8af801eb"}],"ansible/inventory/group_vars/all/ironic":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8afa24f62669a213b9780983d316337754143c51","unresolved":true,"context_lines":[{"line_number":128,"context_line":"kolla_ironic_pxe_append_params_extra: []"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# List of kernel parameters to append for baremetal PXE boot."},{"line_number":131,"context_line":"kolla_ironic_pxe_append_params: \u003e"},{"line_number":132,"context_line":"  {{ kolla_ironic_pxe_append_params_default +"},{"line_number":133,"context_line":"     kolla_ironic_pxe_append_params_extra }}"},{"line_number":134,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"f0ab3625_019238d4","side":"PARENT","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":30},"updated":"2023-11-02 11:07:50.000000000","message":"This is still referenced in ansible/roles/kolla-openstack/templates/kolla/config/ironic.conf.","commit_id":"93ab685241c4bf6d38f7c6eb37ea9189aafdcb21"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"81a20409cee896767e18e601d9cdd5c4ea2888cd","unresolved":true,"context_lines":[{"line_number":128,"context_line":"kolla_ironic_pxe_append_params_extra: []"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# List of kernel parameters to append for baremetal PXE boot."},{"line_number":131,"context_line":"kolla_ironic_pxe_append_params: \u003e"},{"line_number":132,"context_line":"  {{ kolla_ironic_pxe_append_params_default +"},{"line_number":133,"context_line":"     kolla_ironic_pxe_append_params_extra }}"},{"line_number":134,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3d39ea98_cd4ac117","side":"PARENT","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":30},"in_reply_to":"f0ab3625_019238d4","updated":"2023-12-20 13:47:40.000000000","message":"Removed this.\n\nWith default vars now being handled directly by kolla-ansible with only extra vars being exposed, I\u0027m not sure how we can get the complete list of kernel params on Kayobe\u0027s side.","commit_id":"93ab685241c4bf6d38f7c6eb37ea9189aafdcb21"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8afa24f62669a213b9780983d316337754143c51","unresolved":true,"context_lines":[{"line_number":119,"context_line":"# List of additional kernel parameters to append for baremetal PXE boot."},{"line_number":120,"context_line":"kolla_ironic_pxe_append_params_extra: []"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# The NTP server used by the Ironic Python Agent (IPA)"},{"line_number":123,"context_line":"kolla_ironic_ntp_server:"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"# Whether to check an NTP server is accessible by Ironic."},{"line_number":126,"context_line":"kolla_ironic_enable_ntp_precheck: true"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"###############################################################################"},{"line_number":129,"context_line":"# Ironic Node Configuration"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"a3f2a746_1c51c266","line":126,"range":{"start_line":122,"start_character":0,"end_line":126,"end_character":38},"updated":"2023-11-02 11:07:50.000000000","message":"I\u0027d prefer to avoid replicating every Kolla Ansible variable in Kayobe. It\u0027s possible to set them via etc/kayobe/kolla/globals.yml if necessary.\n\nA common exception is where we provide one option in kayobe that maps to multiple in kolla-ansible.","commit_id":"17536040f4bcd958211732ad021377abf75da567"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"81a20409cee896767e18e601d9cdd5c4ea2888cd","unresolved":false,"context_lines":[{"line_number":119,"context_line":"# List of additional kernel parameters to append for baremetal PXE boot."},{"line_number":120,"context_line":"kolla_ironic_pxe_append_params_extra: []"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# The NTP server used by the Ironic Python Agent (IPA)"},{"line_number":123,"context_line":"kolla_ironic_ntp_server:"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"# Whether to check an NTP server is accessible by Ironic."},{"line_number":126,"context_line":"kolla_ironic_enable_ntp_precheck: true"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"###############################################################################"},{"line_number":129,"context_line":"# Ironic Node Configuration"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"04b9a272_30bec006","line":126,"range":{"start_line":122,"start_character":0,"end_line":126,"end_character":38},"in_reply_to":"a3f2a746_1c51c266","updated":"2023-12-20 13:47:40.000000000","message":"Removed precheck/server config for Kayobe","commit_id":"17536040f4bcd958211732ad021377abf75da567"}],"ansible/roles/kolla-ansible/templates/kolla/globals.yml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"0170156e42321b6644588d00bbb301e6c8bf3b13","unresolved":true,"context_lines":[{"line_number":410,"context_line":"{% endif %}"},{"line_number":411,"context_line":"{% if kolla_ironic_pxe_append_params_extra %}"},{"line_number":412,"context_line":"ironic_pxe_append_params_extras:"},{"line_number":413,"context_line":"{{ kolla_ironic_pxe_append_params_extra | to_nice_yaml }}"},{"line_number":414,"context_line":"{% endif %}"},{"line_number":415,"context_line":"{% if kolla_inspector_extra_kernel_options %}"},{"line_number":416,"context_line":"ironic_inspector_kernel_params_extras:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"a9a4bdb6_87077b47","line":413,"updated":"2024-02-16 10:04:49.000000000","message":"Nit: I think this means we will lack indentation (meaning that it won\u0027t match the rest of the file, but should still work.","commit_id":"572817d4cf782309ad0df7a56a7d758f8af801eb"}],"ansible/roles/kolla-bifrost/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8afa24f62669a213b9780983d316337754143c51","unresolved":true,"context_lines":[{"line_number":23,"context_line":"# List of hardware types to enable for Bifrost\u0027s Ironic."},{"line_number":24,"context_line":"kolla_bifrost_enabled_hardware_types: []"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# NTP server for Ironic Python Agent (IPA)."},{"line_number":27,"context_line":"kolla_bifrost_ntp_server:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Specify whether the NTP precheck should run."},{"line_number":30,"context_line":"# Default is true."},{"line_number":31,"context_line":"kolla_bifrost_enable_ntp_precheck:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# List of extra kernel parameters for Bifrost\u0027s Ironic PXE configuration."},{"line_number":34,"context_line":"# Default is empty."},{"line_number":35,"context_line":"kolla_bifrost_extra_kernel_options: []"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fb31f3a_147ae1b3","line":32,"range":{"start_line":26,"start_character":0,"end_line":32,"end_character":0},"updated":"2023-11-02 11:07:50.000000000","message":"Again, better not to redefine defaults.","commit_id":"17536040f4bcd958211732ad021377abf75da567"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"81a20409cee896767e18e601d9cdd5c4ea2888cd","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# List of hardware types to enable for Bifrost\u0027s Ironic."},{"line_number":24,"context_line":"kolla_bifrost_enabled_hardware_types: []"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# NTP server for Ironic Python Agent (IPA)."},{"line_number":27,"context_line":"kolla_bifrost_ntp_server:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Specify whether the NTP precheck should run."},{"line_number":30,"context_line":"# Default is true."},{"line_number":31,"context_line":"kolla_bifrost_enable_ntp_precheck:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# List of extra kernel parameters for Bifrost\u0027s Ironic PXE configuration."},{"line_number":34,"context_line":"# Default is empty."},{"line_number":35,"context_line":"kolla_bifrost_extra_kernel_options: []"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"595abeff_4680fda6","line":32,"range":{"start_line":26,"start_character":0,"end_line":32,"end_character":0},"in_reply_to":"3fb31f3a_147ae1b3","updated":"2023-12-20 13:47:40.000000000","message":"Done","commit_id":"17536040f4bcd958211732ad021377abf75da567"}],"ansible/roles/kolla-bifrost/templates/kolla/config/bifrost/bifrost.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8afa24f62669a213b9780983d316337754143c51","unresolved":true,"context_lines":[{"line_number":16,"context_line":"{% if kolla_bifrost_extra_kernel_options %}"},{"line_number":17,"context_line":"# List of extra kernel parameters for Bifrost\u0027s Ironic PXE configuration."},{"line_number":18,"context_line":"# Default is empty."},{"line_number":19,"context_line":"pxe_kenrel_params_extras: \"{{ kolla_bifrost_extra_kernel_options if kolla_bifrost_extra_kernel_options is string else kolla_bifrost_extra_kernel_options | join(\u0027 \u0027) }}\""},{"line_number":20,"context_line":"{% endif %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% if kolla_bifrost_extra_kernel_options %}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e1e1ebfc_7e9c6c1b","line":19,"updated":"2023-11-02 11:07:50.000000000","message":"Spelling: kenrel","commit_id":"17536040f4bcd958211732ad021377abf75da567"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"81a20409cee896767e18e601d9cdd5c4ea2888cd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"{% if kolla_bifrost_extra_kernel_options %}"},{"line_number":17,"context_line":"# List of extra kernel parameters for Bifrost\u0027s Ironic PXE configuration."},{"line_number":18,"context_line":"# Default is empty."},{"line_number":19,"context_line":"pxe_kenrel_params_extras: \"{{ kolla_bifrost_extra_kernel_options if kolla_bifrost_extra_kernel_options is string else kolla_bifrost_extra_kernel_options | join(\u0027 \u0027) }}\""},{"line_number":20,"context_line":"{% endif %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% if kolla_bifrost_extra_kernel_options %}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"32c0a767_2f061581","line":19,"in_reply_to":"e1e1ebfc_7e9c6c1b","updated":"2023-12-20 13:47:40.000000000","message":"Done","commit_id":"17536040f4bcd958211732ad021377abf75da567"}]}