)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"cb9193a97a9b96b0e5abab6199c2ebc2607c6d24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bada3c44_6c61b31a","updated":"2023-09-28 08:14:24.000000000","message":"I ran into this issue just yesterday, thanks for providing a fix.\n\nI will +2 once I\u0027ve tested it successfully.","commit_id":"37a46b0f547494f052589af91a9be63e1d737969"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"e1c3e80b46ebe2ee12f1b209f5b325bc2bae49fc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"89584f8c_946470dd","updated":"2023-09-27 18:23:14.000000000","message":"really don\u0027t understand why this needed? if you use local registry credentials not needed, if you use an external registry without authorisation credentials not needed too, if you use the secure external registry than credential should be declared.","commit_id":"37a46b0f547494f052589af91a9be63e1d737969"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"28ce557d6ae53937acdd3acb8a1e622a56f73636","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8f5d36ad_592f6baa","in_reply_to":"30d0f723_6475a55d","updated":"2023-10-09 20:16:32.000000000","message":"thats all? an outdated blog post?) I\u0027ve seen it years ago. Thanks.","commit_id":"37a46b0f547494f052589af91a9be63e1d737969"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"605a4d2eac9645b1161d4056ff11816632668388","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a13b246e_71132def","in_reply_to":"8644635f_48173e82","updated":"2023-10-09 16:30:33.000000000","message":"very interesting. could you please share more info about Pulp integration with Kayobe? ansible playbooks?","commit_id":"37a46b0f547494f052589af91a9be63e1d737969"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"da967d1f313acd26a65b07d5825f74c83f2e3afa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8644635f_48173e82","in_reply_to":"89584f8c_946470dd","updated":"2023-10-09 15:00:20.000000000","message":"This is required to deploy a local registry (StackHPC uses Pulp) on the seed host.","commit_id":"37a46b0f547494f052589af91a9be63e1d737969"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e4c488f6d30f79cdeba049430caff6714e527c92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"30d0f723_6475a55d","in_reply_to":"a13b246e_71132def","updated":"2023-10-09 19:56:28.000000000","message":"https://www.stackhpc.com/all-aboard-the-release-train.html","commit_id":"37a46b0f547494f052589af91a9be63e1d737969"}],"ansible/inventory/group_vars/all/kolla":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"27d32a024cfdf394b5b950b3d3eb715b3b37847a","unresolved":true,"context_lines":[{"line_number":86,"context_line":"# Password to use to access a docker registry."},{"line_number":87,"context_line":"kolla_docker_registry_password:"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# Whether to skip the login step for a docker registry."},{"line_number":90,"context_line":"# Default is {{ kolla_docker_registry_username is truthy and"},{"line_number":91,"context_line":"# kolla_docker_registry_password is truthy }}"},{"line_number":92,"context_line":"kolla_docker_registry_attempt_login: \"{{ kolla_docker_registry_username is truthy and kolla_docker_registry_password is truthy }}\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"# Kolla OpenStack release version. This should be a Docker image tag."},{"line_number":95,"context_line":"# Default is {{ openstack_release }}."},{"line_number":96,"context_line":"kolla_openstack_release: \"{{ openstack_release }}\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"90ac0a8c_a7dfd205","line":93,"range":{"start_line":89,"start_character":0,"end_line":93,"end_character":0},"updated":"2023-09-28 13:39:52.000000000","message":"The logic looks good, but I think we need to reduce the scope a little. We\u0027re not preventing all registry logins, only the one before the seed deploy-containers role.\n\nSo IMO it should be a role variable in deploy-containers, e.g. deploy_containers_registry_attempt_login","commit_id":"37a46b0f547494f052589af91a9be63e1d737969"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"a8d1333219eeeb861cfe61db9bd8f4a39e6de2e1","unresolved":false,"context_lines":[{"line_number":86,"context_line":"# Password to use to access a docker registry."},{"line_number":87,"context_line":"kolla_docker_registry_password:"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# Whether to skip the login step for a docker registry."},{"line_number":90,"context_line":"# Default is {{ kolla_docker_registry_username is truthy and"},{"line_number":91,"context_line":"# kolla_docker_registry_password is truthy }}"},{"line_number":92,"context_line":"kolla_docker_registry_attempt_login: \"{{ kolla_docker_registry_username is truthy and kolla_docker_registry_password is truthy }}\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"# Kolla OpenStack release version. This should be a Docker image tag."},{"line_number":95,"context_line":"# Default is {{ openstack_release }}."},{"line_number":96,"context_line":"kolla_openstack_release: \"{{ openstack_release }}\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"e67f037b_2f3260ac","line":93,"range":{"start_line":89,"start_character":0,"end_line":93,"end_character":0},"in_reply_to":"27acf46a_856953c9","updated":"2023-10-10 08:33:46.000000000","message":"Done","commit_id":"37a46b0f547494f052589af91a9be63e1d737969"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"118376beb8ae0d100ec92e8ac5c88e049defc27d","unresolved":true,"context_lines":[{"line_number":86,"context_line":"# Password to use to access a docker registry."},{"line_number":87,"context_line":"kolla_docker_registry_password:"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"# Whether to skip the login step for a docker registry."},{"line_number":90,"context_line":"# Default is {{ kolla_docker_registry_username is truthy and"},{"line_number":91,"context_line":"# kolla_docker_registry_password is truthy }}"},{"line_number":92,"context_line":"kolla_docker_registry_attempt_login: \"{{ kolla_docker_registry_username is truthy and kolla_docker_registry_password is truthy }}\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"# Kolla OpenStack release version. This should be a Docker image tag."},{"line_number":95,"context_line":"# Default is {{ openstack_release }}."},{"line_number":96,"context_line":"kolla_openstack_release: \"{{ openstack_release }}\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"27acf46a_856953c9","line":93,"range":{"start_line":89,"start_character":0,"end_line":93,"end_character":0},"in_reply_to":"90ac0a8c_a7dfd205","updated":"2023-09-28 14:44:39.000000000","message":"this may be the case, all other cases I\u0027ve asked without an answer.","commit_id":"37a46b0f547494f052589af91a9be63e1d737969"}],"ansible/roles/deploy-containers/tasks/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"613bd043e464aac0da1dd17ceb8989646247c3b4","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    password: \"{{ kolla_docker_registry_password }}\""},{"line_number":7,"context_line":"    reauthorize: yes"},{"line_number":8,"context_line":"  when:"},{"line_number":9,"context_line":"    - kolla_docker_registry_username is truthy"},{"line_number":10,"context_line":"    - kolla_docker_registry_password is truthy"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Deploy containers (loop)"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9e56ab38_58f95925","side":"PARENT","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":36},"updated":"2023-10-10 08:59:12.000000000","message":"let\u0027s just document setting -e kolla_docker_registry_username\u003d\"\" on command line instead of creating another variable?","commit_id":"1847ad3f17a039f29e22f465508991fcb6e1cca7"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"68f70c3718aef99bdd30503c2a8f13da75e501b5","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    password: \"{{ kolla_docker_registry_password }}\""},{"line_number":7,"context_line":"    reauthorize: yes"},{"line_number":8,"context_line":"  when:"},{"line_number":9,"context_line":"    - kolla_docker_registry_username is truthy"},{"line_number":10,"context_line":"    - kolla_docker_registry_password is truthy"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Deploy containers (loop)"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6974cdf2_3ab89927","side":"PARENT","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":36},"in_reply_to":"373e8e8e_c7768ae0","updated":"2023-10-10 10:02:34.000000000","message":"Sure, we could achieve the same effect by moving docker login per container (inside the deploy containers loop) with an option to skip it - but whatever works.","commit_id":"1847ad3f17a039f29e22f465508991fcb6e1cca7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"bd3226e8edac9280bd778a6ea40319f27f05a3a1","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    password: \"{{ kolla_docker_registry_password }}\""},{"line_number":7,"context_line":"    reauthorize: yes"},{"line_number":8,"context_line":"  when:"},{"line_number":9,"context_line":"    - kolla_docker_registry_username is truthy"},{"line_number":10,"context_line":"    - kolla_docker_registry_password is truthy"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Deploy containers (loop)"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"373e8e8e_c7768ae0","side":"PARENT","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":36},"in_reply_to":"9e56ab38_58f95925","updated":"2023-10-10 09:48:39.000000000","message":"It would be better to have a variable that can be put in config so that you don\u0027t need to remember to do some magic steps the first time you run this. If we add a login step to the pulp post tasks file then it will be functionally the same and will \"just work\".","commit_id":"1847ad3f17a039f29e22f465508991fcb6e1cca7"}],"doc/source/configuration/reference/docker-registry.rst":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"27d32a024cfdf394b5b950b3d3eb715b3b37847a","unresolved":true,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"   kolla_docker_registry_username: \u003cregistry username\u003e"},{"line_number":138,"context_line":"   kolla_docker_registry_password: \u003cregistry password\u003e"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Basic authentication login attempts can be disabled by setting"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":".. code-block:: yaml"},{"line_number":143,"context_line":"   :caption: ``kolla.yml``"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"   kolla_docker_registry_attempt_login: false"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0c12b81e_1d79ba72","line":145,"range":{"start_line":139,"start_character":0,"end_line":145,"end_character":45},"updated":"2023-09-28 13:39:52.000000000","message":"This should move to a new section in https://docs.openstack.org/kayobe/latest/configuration/reference/seed-custom-containers.html","commit_id":"37a46b0f547494f052589af91a9be63e1d737969"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"a8d1333219eeeb861cfe61db9bd8f4a39e6de2e1","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"   kolla_docker_registry_username: \u003cregistry username\u003e"},{"line_number":138,"context_line":"   kolla_docker_registry_password: \u003cregistry password\u003e"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Basic authentication login attempts can be disabled by setting"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":".. code-block:: yaml"},{"line_number":143,"context_line":"   :caption: ``kolla.yml``"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"   kolla_docker_registry_attempt_login: false"}],"source_content_type":"text/x-rst","patch_set":1,"id":"72d74311_829394a6","line":145,"range":{"start_line":139,"start_character":0,"end_line":145,"end_character":45},"in_reply_to":"0c12b81e_1d79ba72","updated":"2023-10-10 08:33:46.000000000","message":"Done","commit_id":"37a46b0f547494f052589af91a9be63e1d737969"}],"doc/source/configuration/reference/seed-custom-containers.rst":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"61de1951991cd47a90a161bf41fbea6828a22a27","unresolved":true,"context_lines":[{"line_number":73,"context_line":"disabled by setting"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. code-block:: yaml"},{"line_number":76,"context_line":"   :caption: ``kolla.yml``"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"   deploy_containers_registry_attempt_login: false"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9986a42c_c567a4e6","line":76,"updated":"2023-10-12 19:42:29.000000000","message":"Sorry for the post-merge comment, but does this really belong in kolla.yml? The deploy-containers role is only used by the seed outside of kolla-ansible context.\n\nWould it make more sense to add it to seed.yml next to seed_containers?","commit_id":"57d7764114052b6f69c4eb58a1b6b206067cce74"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"3b36a017745b4ea0c54505a957a99fb748890ad4","unresolved":false,"context_lines":[{"line_number":73,"context_line":"disabled by setting"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. code-block:: yaml"},{"line_number":76,"context_line":"   :caption: ``kolla.yml``"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"   deploy_containers_registry_attempt_login: false"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"461629ab_7ddf8d96","line":76,"in_reply_to":"5fe49509_d2c42cb2","updated":"2023-10-18 12:08:52.000000000","message":"Done","commit_id":"57d7764114052b6f69c4eb58a1b6b206067cce74"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"b3310c1ad90496d891b4602fa20289bb97c63ac9","unresolved":true,"context_lines":[{"line_number":73,"context_line":"disabled by setting"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. code-block:: yaml"},{"line_number":76,"context_line":"   :caption: ``kolla.yml``"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"   deploy_containers_registry_attempt_login: false"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5fe49509_d2c42cb2","line":76,"in_reply_to":"9986a42c_c567a4e6","updated":"2023-10-18 12:08:38.000000000","message":"I\u0027ve made a new change to fix this here: https://review.opendev.org/c/openstack/kayobe/+/898437","commit_id":"57d7764114052b6f69c4eb58a1b6b206067cce74"}]}