)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e614f72aa13ac8a76d2d797ac2e851c5427061ad","unresolved":true,"context_lines":[{"line_number":20,"context_line":"\"\"Invalid input for gateway_ip. Reason: \u0027\u0027 is not a valid IP address.\""},{"line_number":21,"context_line":"Omitting by default."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Installing openstack.cloud collection, otherwise upgrade process was failing as Ansible in kayobe-venv was not upgraded."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Ia3550644e5fc3e83f792e46d42b4c35d5eec4705"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"76004d7a_4cb4d19a","line":23,"updated":"2023-11-06 15:57:29.000000000","message":"Please shorten line.","commit_id":"68a69654eaef0d06716c064e5bd0f3231a4763ad"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"127375dc9a2df0f035ca1a23dcbdc40b81cb4cc9","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\"\"Invalid input for gateway_ip. Reason: \u0027\u0027 is not a valid IP address.\""},{"line_number":21,"context_line":"Omitting by default."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Installing openstack.cloud collection, otherwise upgrade process was failing as Ansible in kayobe-venv was not upgraded."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Ia3550644e5fc3e83f792e46d42b4c35d5eec4705"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"32867c44_4878844a","line":23,"in_reply_to":"76004d7a_4cb4d19a","updated":"2023-11-07 17:33:25.000000000","message":"Done","commit_id":"68a69654eaef0d06716c064e5bd0f3231a4763ad"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8d4059f31e63a1dee6dc508b5cad5d7f22689b6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0a2c908d_0392eef4","updated":"2023-10-25 15:48:30.000000000","message":"Are you still working on this Greg?","commit_id":"e95fdcecf478db19de156cd70f735a5ef7bb8fa1"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"5b8eaadde3d878695ec25a31b62fe6344f099278","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5e232d26_2a272d84","in_reply_to":"0a2c908d_0392eef4","updated":"2023-10-25 15:53:38.000000000","message":"Yes, CI still needs fixing. Didn\u0027t have time yet.","commit_id":"e95fdcecf478db19de156cd70f735a5ef7bb8fa1"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"7c55f76691dc4b0a103c8acd9edb03dca9b7a31f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8e8a22bf_0c0f1c22","in_reply_to":"5e232d26_2a272d84","updated":"2023-10-30 10:33:17.000000000","message":"Ack","commit_id":"e95fdcecf478db19de156cd70f735a5ef7bb8fa1"},{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"b51440b27dd9b537f2a1e83b19ecc65bf8a1e303","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"107bdc8e_93865055","updated":"2023-11-08 10:06:36.000000000","message":"Looks good to me","commit_id":"80f6db34cd686bf9b5851fc421bcc41e00723e65"}],"ansible/provision-net.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"860e902532bb8dc5ad4a503ca6506be8e7a5c4f7","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      subnets:"},{"line_number":28,"context_line":"        - name: \"{{ kolla_ironic_provisioning_network }}\""},{"line_number":29,"context_line":"          cidr: \"{{ provision_wl_net_name | net_cidr }}\""},{"line_number":30,"context_line":"          gateway_ip: \"{{ provision_wl_net_name | net_neutron_gateway or provision_wl_net_name | net_gateway | default(omit, True) }}\""},{"line_number":31,"context_line":"          allocation_pool_start: \"{{ provision_wl_net_name | net_neutron_allocation_pool_start }}\""},{"line_number":32,"context_line":"          allocation_pool_end: \"{{ provision_wl_net_name | net_neutron_allocation_pool_end }}\""},{"line_number":33,"context_line":"    cleaning_net:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"2c202ddb_23e3dff3","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":134},"updated":"2023-11-03 14:11:14.000000000","message":"would be good to have a note in commit message why","commit_id":"ce227434972629d726d0e50b701f6a2ebd98e7be"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"7ab6212dcc0ffb2a2bf447cf2f26da175539c7fa","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      subnets:"},{"line_number":28,"context_line":"        - name: \"{{ kolla_ironic_provisioning_network }}\""},{"line_number":29,"context_line":"          cidr: \"{{ provision_wl_net_name | net_cidr }}\""},{"line_number":30,"context_line":"          gateway_ip: \"{{ provision_wl_net_name | net_neutron_gateway or provision_wl_net_name | net_gateway | default(omit, True) }}\""},{"line_number":31,"context_line":"          allocation_pool_start: \"{{ provision_wl_net_name | net_neutron_allocation_pool_start }}\""},{"line_number":32,"context_line":"          allocation_pool_end: \"{{ provision_wl_net_name | net_neutron_allocation_pool_end }}\""},{"line_number":33,"context_line":"    cleaning_net:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"0f937d6b_512b35f5","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":134},"in_reply_to":"2c202ddb_23e3dff3","updated":"2023-11-06 10:51:46.000000000","message":"Done","commit_id":"ce227434972629d726d0e50b701f6a2ebd98e7be"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"860e902532bb8dc5ad4a503ca6506be8e7a5c4f7","unresolved":true,"context_lines":[{"line_number":41,"context_line":"      subnets:"},{"line_number":42,"context_line":"        - name: \"{{ kolla_ironic_cleaning_network }}\""},{"line_number":43,"context_line":"          cidr: \"{{ cleaning_net_name | net_cidr }}\""},{"line_number":44,"context_line":"          gateway_ip: \"{{ cleaning_net_name | net_neutron_gateway or cleaning_net_name | net_gateway | default(omit, True) }}\""},{"line_number":45,"context_line":"          allocation_pool_start: \"{{ cleaning_net_name | net_neutron_allocation_pool_start }}\""},{"line_number":46,"context_line":"          allocation_pool_end: \"{{ cleaning_net_name | net_neutron_allocation_pool_end }}\""},{"line_number":47,"context_line":"    network_registrations: \"{{ [provision_net] + ([] if cleaning_net_name \u003d\u003d provision_wl_net_name else [cleaning_net]) }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"148e5639_3c02d013","line":44,"range":{"start_line":44,"start_character":1,"end_line":44,"end_character":126},"updated":"2023-11-03 14:11:14.000000000","message":"ditto","commit_id":"ce227434972629d726d0e50b701f6a2ebd98e7be"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"7ab6212dcc0ffb2a2bf447cf2f26da175539c7fa","unresolved":false,"context_lines":[{"line_number":41,"context_line":"      subnets:"},{"line_number":42,"context_line":"        - name: \"{{ kolla_ironic_cleaning_network }}\""},{"line_number":43,"context_line":"          cidr: \"{{ cleaning_net_name | net_cidr }}\""},{"line_number":44,"context_line":"          gateway_ip: \"{{ cleaning_net_name | net_neutron_gateway or cleaning_net_name | net_gateway | default(omit, True) }}\""},{"line_number":45,"context_line":"          allocation_pool_start: \"{{ cleaning_net_name | net_neutron_allocation_pool_start }}\""},{"line_number":46,"context_line":"          allocation_pool_end: \"{{ cleaning_net_name | net_neutron_allocation_pool_end }}\""},{"line_number":47,"context_line":"    network_registrations: \"{{ [provision_net] + ([] if cleaning_net_name \u003d\u003d provision_wl_net_name else [cleaning_net]) }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"5661eaa9_1ee8cbe2","line":44,"range":{"start_line":44,"start_character":1,"end_line":44,"end_character":126},"in_reply_to":"148e5639_3c02d013","updated":"2023-11-06 10:51:46.000000000","message":"Done","commit_id":"ce227434972629d726d0e50b701f6a2ebd98e7be"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"decd05e9e90e8b3c0175c067fcd85edbbc31eace","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      subnets:"},{"line_number":28,"context_line":"        - name: \"{{ kolla_ironic_provisioning_network }}\""},{"line_number":29,"context_line":"          cidr: \"{{ provision_wl_net_name | net_cidr }}\""},{"line_number":30,"context_line":"          gateway_ip: \"{{ provision_wl_net_name | net_neutron_gateway or provision_wl_net_name | net_gateway | default(omit, True) }}\""},{"line_number":31,"context_line":"          allocation_pool_start: \"{{ provision_wl_net_name | net_neutron_allocation_pool_start }}\""},{"line_number":32,"context_line":"          allocation_pool_end: \"{{ provision_wl_net_name | net_neutron_allocation_pool_end }}\""},{"line_number":33,"context_line":"    cleaning_net:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"88a37a98_ba2f2b6a","line":30,"updated":"2023-11-10 10:33:38.000000000","message":"There is a subtlety here to be aware of. In the openstack.cloud.subnet module there is a difference between not specifying a gateway_ip (one will be chosen for you) vs. specifying no_gateway_ip\u003dtrue or disable_gateway_ip\u003dtrue (the subnet has no gateway).\n\nIf no gateway is defined in Kayobe config then we need to ensure neutron does not allocate one for us.\n\nThe os-networks role has this logic:\n\n    gateway_ip: \"{{ item.1.gateway_ip | default(omit) }}\"\n    no_gateway_ip: \u003e-\n      {{ item.1.no_gateway_ip |\n         default(item.1.gateway_ip | default | ternary(omit, True)) }}\n\nSo if no gateway is defined in kayobe config, we will pass omit to the module\u0027s gateway_ip arg. This then gets passed through\n\nI wrote a playbook to test this:\n\n    - hosts: localhost\n      tasks:\n        - debug:\n            msg: \"{{ omit | default | ternary(\u0027true\u0027, \u0027false\u0027) }}\"\n\n\nAnd it prints \u0027true\u0027, which is not what we want, because that means we\u0027ll pass omit to the no_gateway_ip arg.\n\nSee https://github.com/stackhpc/ansible-role-os-networks/blob/c8cf98aaa42063a78c164a0c37b82da6a6e57f57/tasks/networks.yml#L48","commit_id":"80f6db34cd686bf9b5851fc421bcc41e00723e65"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"bae312bf26d4eed9343e555d515f387a845cbee1","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      subnets:"},{"line_number":28,"context_line":"        - name: \"{{ kolla_ironic_provisioning_network }}\""},{"line_number":29,"context_line":"          cidr: \"{{ provision_wl_net_name | net_cidr }}\""},{"line_number":30,"context_line":"          gateway_ip: \"{{ provision_wl_net_name | net_neutron_gateway or provision_wl_net_name | net_gateway | default(omit, True) }}\""},{"line_number":31,"context_line":"          allocation_pool_start: \"{{ provision_wl_net_name | net_neutron_allocation_pool_start }}\""},{"line_number":32,"context_line":"          allocation_pool_end: \"{{ provision_wl_net_name | net_neutron_allocation_pool_end }}\""},{"line_number":33,"context_line":"    cleaning_net:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"a731eca6_6628b78f","line":30,"in_reply_to":"3c760305_cc54a9ce","updated":"2023-11-14 12:22:07.000000000","message":"Do we need to update the version in requirements.yml?","commit_id":"80f6db34cd686bf9b5851fc421bcc41e00723e65"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"93d8201805ef252c0a7711d579a153c09cbcdacc","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      subnets:"},{"line_number":28,"context_line":"        - name: \"{{ kolla_ironic_provisioning_network }}\""},{"line_number":29,"context_line":"          cidr: \"{{ provision_wl_net_name | net_cidr }}\""},{"line_number":30,"context_line":"          gateway_ip: \"{{ provision_wl_net_name | net_neutron_gateway or provision_wl_net_name | net_gateway | default(omit, True) }}\""},{"line_number":31,"context_line":"          allocation_pool_start: \"{{ provision_wl_net_name | net_neutron_allocation_pool_start }}\""},{"line_number":32,"context_line":"          allocation_pool_end: \"{{ provision_wl_net_name | net_neutron_allocation_pool_end }}\""},{"line_number":33,"context_line":"    cleaning_net:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"3c760305_cc54a9ce","line":30,"in_reply_to":"74070ed9_877a24d2","updated":"2023-11-13 09:43:09.000000000","message":"Done.\n\nFixed with:\nhttps://github.com/stackhpc/ansible-role-os-networks/commit/14ceef02a7d4adf84593739c27cb9bbb4833f4e7","commit_id":"80f6db34cd686bf9b5851fc421bcc41e00723e65"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"2c784b492d48c23197d003f3f7b7fafcbbccc864","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      subnets:"},{"line_number":28,"context_line":"        - name: \"{{ kolla_ironic_provisioning_network }}\""},{"line_number":29,"context_line":"          cidr: \"{{ provision_wl_net_name | net_cidr }}\""},{"line_number":30,"context_line":"          gateway_ip: \"{{ provision_wl_net_name | net_neutron_gateway or provision_wl_net_name | net_gateway | default(omit, True) }}\""},{"line_number":31,"context_line":"          allocation_pool_start: \"{{ provision_wl_net_name | net_neutron_allocation_pool_start }}\""},{"line_number":32,"context_line":"          allocation_pool_end: \"{{ provision_wl_net_name | net_neutron_allocation_pool_end }}\""},{"line_number":33,"context_line":"    cleaning_net:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"9d997e44_161a8cf2","line":30,"in_reply_to":"88a37a98_ba2f2b6a","updated":"2023-11-10 11:53:28.000000000","message":"Seems like None, might work?\n\n  - hosts: localhost\n    tasks:\n      - debug:\n          msg: \"{{ None | default | ternary(\u0027true\u0027, \u0027false\u0027) }}\"\n\ngives false.","commit_id":"80f6db34cd686bf9b5851fc421bcc41e00723e65"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"f3f3639da5fd3ccee8b7770e17cf8d96fa0ebfcd","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      subnets:"},{"line_number":28,"context_line":"        - name: \"{{ kolla_ironic_provisioning_network }}\""},{"line_number":29,"context_line":"          cidr: \"{{ provision_wl_net_name | net_cidr }}\""},{"line_number":30,"context_line":"          gateway_ip: \"{{ provision_wl_net_name | net_neutron_gateway or provision_wl_net_name | net_gateway | default(omit, True) }}\""},{"line_number":31,"context_line":"          allocation_pool_start: \"{{ provision_wl_net_name | net_neutron_allocation_pool_start }}\""},{"line_number":32,"context_line":"          allocation_pool_end: \"{{ provision_wl_net_name | net_neutron_allocation_pool_end }}\""},{"line_number":33,"context_line":"    cleaning_net:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"74070ed9_877a24d2","line":30,"in_reply_to":"9d997e44_161a8cf2","updated":"2023-11-10 15:27:10.000000000","message":"OK, it didn\u0027t quite work, so I made this: https://github.com/stackhpc/ansible-role-os-networks/pull/47","commit_id":"80f6db34cd686bf9b5851fc421bcc41e00723e65"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"7db71c7e5ac2c31065b1596dfd5eb51e63ef789e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      subnets:"},{"line_number":28,"context_line":"        - name: \"{{ kolla_ironic_provisioning_network }}\""},{"line_number":29,"context_line":"          cidr: \"{{ provision_wl_net_name | net_cidr }}\""},{"line_number":30,"context_line":"          gateway_ip: \"{{ provision_wl_net_name | net_neutron_gateway or provision_wl_net_name | net_gateway | default(omit, True) }}\""},{"line_number":31,"context_line":"          allocation_pool_start: \"{{ provision_wl_net_name | net_neutron_allocation_pool_start }}\""},{"line_number":32,"context_line":"          allocation_pool_end: \"{{ provision_wl_net_name | net_neutron_allocation_pool_end }}\""},{"line_number":33,"context_line":"    cleaning_net:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"f5f7d8c5_ae3c87b4","line":30,"in_reply_to":"a731eca6_6628b78f","updated":"2023-11-14 12:25:42.000000000","message":"Ack.\nI\u0027ll update in follow-up change:\nhttps://review.opendev.org/c/openstack/kayobe/+/900753","commit_id":"80f6db34cd686bf9b5851fc421bcc41e00723e65"}],"ansible/roles/ipa-images/tasks/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"decd05e9e90e8b3c0175c067fcd85edbbc31eace","unresolved":true,"context_lines":[{"line_number":88,"context_line":"        extension: \"{{ item.created_at | replace(\u0027:\u0027, \u0027-\u0027) }}~\""},{"line_number":89,"context_line":"      with_items:"},{"line_number":90,"context_line":"        - name: \"{{ ipa_images_kernel_name }}\""},{"line_number":91,"context_line":"          created_at: \"{{ ipa_images_kernel.openstack_images[0].created_at | default }}\""},{"line_number":92,"context_line":"          checksum: \"{{ ipa_images_checksum.results[0].stat.checksum }}\""},{"line_number":93,"context_line":"          glance_checksum: \"{{ ipa_images_kernel.openstack_images[0].checksum | default }}\""},{"line_number":94,"context_line":"        - name: \"{{ ipa_images_ramdisk_name }}\""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"b153a90e_d4b19778","line":91,"updated":"2023-11-10 10:33:38.000000000","message":"I think openstack_images needs to be images here, same as in the next file.\n\n(and other references to ipa_images_kernel and ipa_images_ramdisk in here)","commit_id":"80f6db34cd686bf9b5851fc421bcc41e00723e65"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"cb1db3f9c98f21ee11a4be748c5b4595bf5a77ae","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        extension: \"{{ item.created_at | replace(\u0027:\u0027, \u0027-\u0027) }}~\""},{"line_number":89,"context_line":"      with_items:"},{"line_number":90,"context_line":"        - name: \"{{ ipa_images_kernel_name }}\""},{"line_number":91,"context_line":"          created_at: \"{{ ipa_images_kernel.openstack_images[0].created_at | default }}\""},{"line_number":92,"context_line":"          checksum: \"{{ ipa_images_checksum.results[0].stat.checksum }}\""},{"line_number":93,"context_line":"          glance_checksum: \"{{ ipa_images_kernel.openstack_images[0].checksum | default }}\""},{"line_number":94,"context_line":"        - name: \"{{ ipa_images_ramdisk_name }}\""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"8e49467e_fd3acb8f","line":91,"in_reply_to":"b153a90e_d4b19778","updated":"2023-11-13 09:41:27.000000000","message":"Done\n\nFollow up:\nhttps://review.opendev.org/c/openstack/kayobe/+/900753","commit_id":"80f6db34cd686bf9b5851fc421bcc41e00723e65"}],"ansible/roles/kolla-ansible/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8d4059f31e63a1dee6dc508b5cad5d7f22689b6b","unresolved":true,"context_lines":[{"line_number":25,"context_line":"# version of ansible used by kolla-ansible to avoid new releases from breaking"},{"line_number":26,"context_line":"# tested code. Changes to this limit should be tested."},{"line_number":27,"context_line":"kolla_ansible_venv_ansible: \u0027ansible\u003e\u003d7,\u003c9.0\u0027"},{"line_number":28,"context_line":"kolla_ansible_venv_ansible_core: \u0027ansible-core\u003e\u003d2.14.10,\u003c\u003d2.15.4\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Path to a requirements.yml file for Ansible collections."},{"line_number":31,"context_line":"kolla_ansible_requirements_yml: \"{{ kolla_ansible_venv }}/share/kolla-ansible/requirements.yml\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"03bda9cd_96efec85","line":28,"updated":"2023-10-25 15:48:30.000000000","message":"I\u0027d go with this unless there\u0027s a reason to specify the patch version:\n\n\u0027ansible-core\u003e\u003d2.14,\u003c\u003d2.15\u0027\n\n(If changing please update references to these versions)","commit_id":"e95fdcecf478db19de156cd70f735a5ef7bb8fa1"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"5b8eaadde3d878695ec25a31b62fe6344f099278","unresolved":true,"context_lines":[{"line_number":25,"context_line":"# version of ansible used by kolla-ansible to avoid new releases from breaking"},{"line_number":26,"context_line":"# tested code. Changes to this limit should be tested."},{"line_number":27,"context_line":"kolla_ansible_venv_ansible: \u0027ansible\u003e\u003d7,\u003c9.0\u0027"},{"line_number":28,"context_line":"kolla_ansible_venv_ansible_core: \u0027ansible-core\u003e\u003d2.14.10,\u003c\u003d2.15.4\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Path to a requirements.yml file for Ansible collections."},{"line_number":31,"context_line":"kolla_ansible_requirements_yml: \"{{ kolla_ansible_venv }}/share/kolla-ansible/requirements.yml\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5503ded6_6fccfc46","line":28,"in_reply_to":"03bda9cd_96efec85","updated":"2023-10-25 15:53:38.000000000","message":"At the time it was because of this k-a bug https://review.opendev.org/c/openstack/kolla-ansible/+/897926","commit_id":"e95fdcecf478db19de156cd70f735a5ef7bb8fa1"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"7c55f76691dc4b0a103c8acd9edb03dca9b7a31f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# version of ansible used by kolla-ansible to avoid new releases from breaking"},{"line_number":26,"context_line":"# tested code. Changes to this limit should be tested."},{"line_number":27,"context_line":"kolla_ansible_venv_ansible: \u0027ansible\u003e\u003d7,\u003c9.0\u0027"},{"line_number":28,"context_line":"kolla_ansible_venv_ansible_core: \u0027ansible-core\u003e\u003d2.14.10,\u003c\u003d2.15.4\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Path to a requirements.yml file for Ansible collections."},{"line_number":31,"context_line":"kolla_ansible_requirements_yml: \"{{ kolla_ansible_venv }}/share/kolla-ansible/requirements.yml\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"33d4c565_196ce4e6","line":28,"in_reply_to":"5503ded6_6fccfc46","updated":"2023-10-30 10:33:17.000000000","message":"Done","commit_id":"e95fdcecf478db19de156cd70f735a5ef7bb8fa1"}],"ansible/roles/kolla-openstack/molecule/default/create.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"860e902532bb8dc5ad4a503ca6506be8e7a5c4f7","unresolved":true,"context_lines":[{"line_number":29,"context_line":"        build:"},{"line_number":30,"context_line":"          path: \"{{ molecule_ephemeral_directory }}\""},{"line_number":31,"context_line":"          dockerfile: \"{{ item.item.dockerfile | default(item.invocation.module_args.dest) }}\""},{"line_number":32,"context_line":"          network: host"},{"line_number":33,"context_line":"        force_source: \"{{ item.item.force | default(true) }}\""},{"line_number":34,"context_line":"        force_tag: \"{{ item.item.force | default(true) }}\""},{"line_number":35,"context_line":"      with_items: \"{{ platforms.results }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"17c51ccf_b6bfcb37","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":23},"updated":"2023-11-03 14:11:14.000000000","message":"should we break that out into separate patch?","commit_id":"ce227434972629d726d0e50b701f6a2ebd98e7be"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"5712eee988a4dd9eeb7b01c01f054faecd5a6b9b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        build:"},{"line_number":30,"context_line":"          path: \"{{ molecule_ephemeral_directory }}\""},{"line_number":31,"context_line":"          dockerfile: \"{{ item.item.dockerfile | default(item.invocation.module_args.dest) }}\""},{"line_number":32,"context_line":"          network: host"},{"line_number":33,"context_line":"        force_source: \"{{ item.item.force | default(true) }}\""},{"line_number":34,"context_line":"        force_tag: \"{{ item.item.force | default(true) }}\""},{"line_number":35,"context_line":"      with_items: \"{{ platforms.results }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"21cfb460_6a8d8ddd","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":23},"in_reply_to":"17c51ccf_b6bfcb37","updated":"2023-11-06 09:59:32.000000000","message":"Done","commit_id":"ce227434972629d726d0e50b701f6a2ebd98e7be"}],"ansible/roles/kolla-openstack/molecule/default/molecule.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"860e902532bb8dc5ad4a503ca6506be8e7a5c4f7","unresolved":true,"context_lines":[{"line_number":10,"context_line":"platforms:"},{"line_number":11,"context_line":"  - name: centos-stream8"},{"line_number":12,"context_line":"    image: quay.io/centos/centos:stream8"},{"line_number":13,"context_line":"    network_mode: host"},{"line_number":14,"context_line":"provisioner:"},{"line_number":15,"context_line":"  name: ansible"},{"line_number":16,"context_line":"  lint:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"c5055dc4_b9a78697","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":22},"updated":"2023-11-03 14:11:14.000000000","message":"ditto","commit_id":"ce227434972629d726d0e50b701f6a2ebd98e7be"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"5712eee988a4dd9eeb7b01c01f054faecd5a6b9b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"platforms:"},{"line_number":11,"context_line":"  - name: centos-stream8"},{"line_number":12,"context_line":"    image: quay.io/centos/centos:stream8"},{"line_number":13,"context_line":"    network_mode: host"},{"line_number":14,"context_line":"provisioner:"},{"line_number":15,"context_line":"  name: ansible"},{"line_number":16,"context_line":"  lint:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"d7d6e927_c296a026","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":22},"in_reply_to":"c5055dc4_b9a78697","updated":"2023-11-06 09:59:32.000000000","message":"Done","commit_id":"ce227434972629d726d0e50b701f6a2ebd98e7be"}],"ansible/roles/kolla-openstack/molecule/enable-everything/create.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"860e902532bb8dc5ad4a503ca6506be8e7a5c4f7","unresolved":true,"context_lines":[{"line_number":30,"context_line":"        build:"},{"line_number":31,"context_line":"          path: \"{{ molecule_ephemeral_directory }}\""},{"line_number":32,"context_line":"          dockerfile: \"{{ item.item.dockerfile | default(item.invocation.module_args.dest) }}\""},{"line_number":33,"context_line":"          network: host"},{"line_number":34,"context_line":"        force_source: \"{{ item.item.force | default(true) }}\""},{"line_number":35,"context_line":"        force_tag: \"{{ item.item.force | default(true) }}\""},{"line_number":36,"context_line":"      with_items: \"{{ platforms.results }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3fdac0e0_7f72e936","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":23},"updated":"2023-11-03 14:11:14.000000000","message":"ditto","commit_id":"ce227434972629d726d0e50b701f6a2ebd98e7be"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"5712eee988a4dd9eeb7b01c01f054faecd5a6b9b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        build:"},{"line_number":31,"context_line":"          path: \"{{ molecule_ephemeral_directory }}\""},{"line_number":32,"context_line":"          dockerfile: \"{{ item.item.dockerfile | default(item.invocation.module_args.dest) }}\""},{"line_number":33,"context_line":"          network: host"},{"line_number":34,"context_line":"        force_source: \"{{ item.item.force | default(true) }}\""},{"line_number":35,"context_line":"        force_tag: \"{{ item.item.force | default(true) }}\""},{"line_number":36,"context_line":"      with_items: \"{{ platforms.results }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"52436ef7_50611172","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":23},"in_reply_to":"3fdac0e0_7f72e936","updated":"2023-11-06 09:59:32.000000000","message":"Done","commit_id":"ce227434972629d726d0e50b701f6a2ebd98e7be"}],"ansible/roles/kolla-openstack/molecule/enable-everything/molecule.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"860e902532bb8dc5ad4a503ca6506be8e7a5c4f7","unresolved":true,"context_lines":[{"line_number":10,"context_line":"platforms:"},{"line_number":11,"context_line":"  - name: centos-stream8"},{"line_number":12,"context_line":"    image: quay.io/centos/centos:stream8"},{"line_number":13,"context_line":"    network_mode: host"},{"line_number":14,"context_line":"provisioner:"},{"line_number":15,"context_line":"  name: ansible"},{"line_number":16,"context_line":"  inventory:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"e6a6e089_42f95ae7","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":22},"updated":"2023-11-03 14:11:14.000000000","message":"ditto","commit_id":"ce227434972629d726d0e50b701f6a2ebd98e7be"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"5712eee988a4dd9eeb7b01c01f054faecd5a6b9b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"platforms:"},{"line_number":11,"context_line":"  - name: centos-stream8"},{"line_number":12,"context_line":"    image: quay.io/centos/centos:stream8"},{"line_number":13,"context_line":"    network_mode: host"},{"line_number":14,"context_line":"provisioner:"},{"line_number":15,"context_line":"  name: ansible"},{"line_number":16,"context_line":"  inventory:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3761d75f_f15d78ec","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":22},"in_reply_to":"e6a6e089_42f95ae7","updated":"2023-11-06 09:59:32.000000000","message":"Done","commit_id":"ce227434972629d726d0e50b701f6a2ebd98e7be"}],"releasenotes/notes/ansible-bump-7-8-b8245f34bf436736.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e614f72aa13ac8a76d2d797ac2e851c5427061ad","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":" upgrade:"},{"line_number":3,"context_line":"   - |"},{"line_number":4,"context_line":"     Updates the maximum supported version of Ansible from 7.x (ansible-core"},{"line_number":5,"context_line":"     2.14) to 8.x (ansible-core 2.15). The minimum supported version is updated"},{"line_number":6,"context_line":"     from 6.x to 7.x. This is true for both Kayobe and Kolla Ansible."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"3c1af10c_4ff8df05","line":6,"range":{"start_line":2,"start_character":0,"end_line":6,"end_character":69},"updated":"2023-11-06 15:57:29.000000000","message":"Remove leading extra whitespace character.","commit_id":"68a69654eaef0d06716c064e5bd0f3231a4763ad"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"127375dc9a2df0f035ca1a23dcbdc40b81cb4cc9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":" upgrade:"},{"line_number":3,"context_line":"   - |"},{"line_number":4,"context_line":"     Updates the maximum supported version of Ansible from 7.x (ansible-core"},{"line_number":5,"context_line":"     2.14) to 8.x (ansible-core 2.15). The minimum supported version is updated"},{"line_number":6,"context_line":"     from 6.x to 7.x. This is true for both Kayobe and Kolla Ansible."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9db42cfc_24c1e426","line":6,"range":{"start_line":2,"start_character":0,"end_line":6,"end_character":69},"in_reply_to":"3c1af10c_4ff8df05","updated":"2023-11-07 17:33:25.000000000","message":"Done","commit_id":"68a69654eaef0d06716c064e5bd0f3231a4763ad"}],"requirements.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"860e902532bb8dc5ad4a503ca6506be8e7a5c4f7","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    version: master"},{"line_number":6,"context_line":"  - name: dellemc.os10"},{"line_number":7,"context_line":"    version: 1.1.1"},{"line_number":8,"context_line":"  - name: openstack.cloud"},{"line_number":9,"context_line":"    version: \u0027\u003c3\u0027"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"roles:"},{"line_number":12,"context_line":"  - src: ahuffman.resolv"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"c17f3481_de36f962","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":17},"updated":"2023-11-03 14:11:14.000000000","message":"We need a note here or in the commit message why","commit_id":"ce227434972629d726d0e50b701f6a2ebd98e7be"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"7ab6212dcc0ffb2a2bf447cf2f26da175539c7fa","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    version: master"},{"line_number":6,"context_line":"  - name: dellemc.os10"},{"line_number":7,"context_line":"    version: 1.1.1"},{"line_number":8,"context_line":"  - name: openstack.cloud"},{"line_number":9,"context_line":"    version: \u0027\u003c3\u0027"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"roles:"},{"line_number":12,"context_line":"  - src: ahuffman.resolv"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9878bf63_e3ff863b","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":17},"in_reply_to":"c17f3481_de36f962","updated":"2023-11-06 10:51:46.000000000","message":"Done","commit_id":"ce227434972629d726d0e50b701f6a2ebd98e7be"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"decd05e9e90e8b3c0175c067fcd85edbbc31eace","unresolved":true,"context_lines":[{"line_number":6,"context_line":"  - name: dellemc.os10"},{"line_number":7,"context_line":"    version: 1.1.1"},{"line_number":8,"context_line":"  - name: openstack.cloud"},{"line_number":9,"context_line":"    version: \u0027\u003c3\u0027"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"roles:"},{"line_number":12,"context_line":"  - src: ahuffman.resolv"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"98455e63_f90be5ca","line":9,"updated":"2023-11-10 10:33:38.000000000","message":"The loveliest version requirement :)","commit_id":"80f6db34cd686bf9b5851fc421bcc41e00723e65"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"cb1db3f9c98f21ee11a4be748c5b4595bf5a77ae","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  - name: dellemc.os10"},{"line_number":7,"context_line":"    version: 1.1.1"},{"line_number":8,"context_line":"  - name: openstack.cloud"},{"line_number":9,"context_line":"    version: \u0027\u003c3\u0027"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"roles:"},{"line_number":12,"context_line":"  - src: ahuffman.resolv"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"cf476098_1a8cb272","line":9,"in_reply_to":"98455e63_f90be5ca","updated":"2023-11-13 09:41:27.000000000","message":"Ack","commit_id":"80f6db34cd686bf9b5851fc421bcc41e00723e65"}]}