)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"a505008689cb2d31ee1f393a4ac4e17b4e2fc1ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7fb9befc_6878af8b","updated":"2023-11-29 08:22:13.000000000","message":"Can you add a release note please?","commit_id":"268b06b014912da7e4467f542a0a2be112a1f7dc"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"ae53491d6ccf9d03cb726eaa9b646be730d959bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"31b59f42_4dbf302b","updated":"2023-11-29 08:22:01.000000000","message":"Thanks for the fix.","commit_id":"268b06b014912da7e4467f542a0a2be112a1f7dc"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"1d4385d4ccf28237a51b8a6256c5654fce8c57d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7ce47a9e_0b0c903a","updated":"2023-11-29 08:23:18.000000000","message":"You can also reference the change that broke it in the commit message: Ib847d3420dee374cec067cd8af519b510be04120","commit_id":"268b06b014912da7e4467f542a0a2be112a1f7dc"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8db11b02866112285b000ef7c2cd628ebc8f30dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6a3fea2b_ff815e9e","in_reply_to":"7ce47a9e_0b0c903a","updated":"2023-12-07 22:23:41.000000000","message":"Done.","commit_id":"268b06b014912da7e4467f542a0a2be112a1f7dc"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8db11b02866112285b000ef7c2cd628ebc8f30dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4daf6c35_b89cd7ae","in_reply_to":"7fb9befc_6878af8b","updated":"2023-12-07 22:23:41.000000000","message":"I added one.","commit_id":"268b06b014912da7e4467f542a0a2be112a1f7dc"}],"ansible/kolla-bifrost-hostvars.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"ae53491d6ccf9d03cb726eaa9b646be730d959bf","unresolved":true,"context_lines":[{"line_number":22,"context_line":"      # If the admin network does not have a gateway defined and seed SNAT is"},{"line_number":23,"context_line":"      # enabled, use the seed as a gateway to allow external access until other"},{"line_number":24,"context_line":"      # networks have been configured. Otherwise, do not set any gateway."},{"line_number":25,"context_line":"      ipv4_gateway: \"{{ (admin_oc_net_name | net_ip(seed_host)) if (seed_enable_snat | bool) else (admin_oc_net_name | net_gateway) }}\""},{"line_number":26,"context_line":"      ipv4_nameserver: \"{{ resolv_nameservers }}\""},{"line_number":27,"context_line":"      network_mtu: \"{{ admin_oc_net_name | net_mtu or \u00271500\u0027 }}\""},{"line_number":28,"context_line":"      vlan_id: \"{{ \u0027\u0027 if admin_oc_net_name \u003d\u003d provision_oc_net_name else (admin_oc_net_name | net_vlan) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"637b8f73_ff3c4154","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":135},"updated":"2023-11-29 08:22:01.000000000","message":"I have checked that this could be written without the extra parentheses, which would match the style of other expressions throughout Kayobe.","commit_id":"268b06b014912da7e4467f542a0a2be112a1f7dc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"861f33d2e6866ca992db535cc6009d8b7d79d6a3","unresolved":true,"context_lines":[{"line_number":22,"context_line":"      # If the admin network does not have a gateway defined and seed SNAT is"},{"line_number":23,"context_line":"      # enabled, use the seed as a gateway to allow external access until other"},{"line_number":24,"context_line":"      # networks have been configured. Otherwise, do not set any gateway."},{"line_number":25,"context_line":"      ipv4_gateway: \"{{ (admin_oc_net_name | net_ip(seed_host)) if (seed_enable_snat | bool) else (admin_oc_net_name | net_gateway) }}\""},{"line_number":26,"context_line":"      ipv4_nameserver: \"{{ resolv_nameservers }}\""},{"line_number":27,"context_line":"      network_mtu: \"{{ admin_oc_net_name | net_mtu or \u00271500\u0027 }}\""},{"line_number":28,"context_line":"      vlan_id: \"{{ \u0027\u0027 if admin_oc_net_name \u003d\u003d provision_oc_net_name else (admin_oc_net_name | net_vlan) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"818143eb_5576ab05","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":135},"in_reply_to":"637b8f73_ff3c4154","updated":"2023-11-29 09:28:28.000000000","message":"Would it be preferable to use a gateway on the admin network if one is available?","commit_id":"268b06b014912da7e4467f542a0a2be112a1f7dc"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8db11b02866112285b000ef7c2cd628ebc8f30dd","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      # If the admin network does not have a gateway defined and seed SNAT is"},{"line_number":23,"context_line":"      # enabled, use the seed as a gateway to allow external access until other"},{"line_number":24,"context_line":"      # networks have been configured. Otherwise, do not set any gateway."},{"line_number":25,"context_line":"      ipv4_gateway: \"{{ (admin_oc_net_name | net_ip(seed_host)) if (seed_enable_snat | bool) else (admin_oc_net_name | net_gateway) }}\""},{"line_number":26,"context_line":"      ipv4_nameserver: \"{{ resolv_nameservers }}\""},{"line_number":27,"context_line":"      network_mtu: \"{{ admin_oc_net_name | net_mtu or \u00271500\u0027 }}\""},{"line_number":28,"context_line":"      vlan_id: \"{{ \u0027\u0027 if admin_oc_net_name \u003d\u003d provision_oc_net_name else (admin_oc_net_name | net_vlan) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"72807db2_4861f10b","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":135},"in_reply_to":"818143eb_5576ab05","updated":"2023-12-07 22:23:41.000000000","message":"I think so. That\u0027s actually what I had in mind, as the comment above says:\n\nIf the admin network does not have a gateway defined and seed SNAT is enabled, use the seed as a gateway to allow external access until other networks have been configured. Otherwise, do not set any gateway.\n\nI pushed an updated change.","commit_id":"268b06b014912da7e4467f542a0a2be112a1f7dc"}]}