)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"6d5e30156769ad424888ad7f7c520667e73f4402","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b86d398b_f6ded633","updated":"2023-12-04 09:58:06.000000000","message":"Marked WIP as needs testing","commit_id":"8fafced5c3d84fb75af663556a1f895f4f5eac5c"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"8ee76112c4931ce3110dba43eb8a0eaba2c6b1b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8147d832_32a250a4","updated":"2023-12-08 12:18:15.000000000","message":"Looks reasonable. Would it make sense to push it up into the role?","commit_id":"dea1013077a0341dcea09b080200b620e5393abe"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"ef53ae5229b89beeb65f99aa8f814c5558a59f78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"92d64f95_cad407a5","updated":"2023-12-08 11:28:47.000000000","message":"Should be backported to all releases which support Rocky Linux 9.","commit_id":"dea1013077a0341dcea09b080200b620e5393abe"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"84616462f97b9b77f276b7db198707e7a2a2e97d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2d7d1c56_c59966ca","in_reply_to":"04a92bdd_62224f74","updated":"2023-12-08 13:53:38.000000000","message":"And possibly use line in file in case similar config exists?","commit_id":"dea1013077a0341dcea09b080200b620e5393abe"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"fc5db8a63e5251edd3e10de57bb820f1b1437c46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e178fd3d_3b05b308","in_reply_to":"2d7d1c56_c59966ca","updated":"2023-12-08 15:35:47.000000000","message":"I\u0027d prefer to keep using blockinfile so that the kayobe-managed config is clearly independent from any other config. \n\nThe ``dns`` and ``rc-manager`` options are not present by default, so if an operator is configuring these outside of Kayobe then it seems a fair assumption that they would not also be using the ``resolv_is_managed`` option.","commit_id":"dea1013077a0341dcea09b080200b620e5393abe"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"611e46fc6fbae0ee88517fbea4838f21aba66fd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"04a92bdd_62224f74","in_reply_to":"6e82f820_f43a0825","updated":"2023-12-08 13:46:31.000000000","message":"One other suggestion is to remove the block when you toggle the flag the other way.","commit_id":"dea1013077a0341dcea09b080200b620e5393abe"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"0e7d867f5c927169192f883dfc549afb153dcbac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6e82f820_f43a0825","in_reply_to":"8128e6f8_28ce819d","updated":"2023-12-08 12:41:21.000000000","message":"\u003e To clarify, the interfaces role, as that already seems to manage the lifecycle of NetworkManager\n\nWould be nice to have the option to disable NM handling dns and rc from that role, yes. \n\n\n\u003e does NetworkManager not need to be restarted?\n\nI haven\u0027t needed to, the config seems to be picked up during the ``Bounce networkmanager devices`` handler.","commit_id":"dea1013077a0341dcea09b080200b620e5393abe"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"9bdc1044f6966a2dc0106640db4a610e5c666329","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8128e6f8_28ce819d","in_reply_to":"8147d832_32a250a4","updated":"2023-12-08 12:32:07.000000000","message":"The ``ahuffman.resolv`` role? Seems like a good idea.","commit_id":"dea1013077a0341dcea09b080200b620e5393abe"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"9800e8cef34f902d4b9be514255a0412d8095696","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"588676e5_daa61cda","in_reply_to":"8147d832_32a250a4","updated":"2023-12-08 12:32:00.000000000","message":"To clarify, the interfaces role, as that already seems to manage the lifecycle of NetworkManager: \n\nhttps://github.com/michaelrigart/ansible-role-interfaces/commit/d3a7982824dd1fd9b01e34a8df4ba3c541773976\n\nAlso, does NetworkManager not need to be restarted?","commit_id":"dea1013077a0341dcea09b080200b620e5393abe"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4c073df5fd0a43f46eff394271dc67c43d4379c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f5d9478e_d91c1d22","updated":"2023-12-11 10:27:39.000000000","message":"Release note?","commit_id":"81328a06391a9a578a3af55258b339eca0abaf53"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"eb497af94b7edd7ccf7cb0f2ae1937d7f03cf024","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d0fc9fbd_2791be79","in_reply_to":"f5d9478e_d91c1d22","updated":"2023-12-11 10:48:57.000000000","message":"Done.","commit_id":"81328a06391a9a578a3af55258b339eca0abaf53"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"9aaec31bb7c9ff00c29e8f61f0f5dec93431d182","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"73cd0e5e_9ab36d9d","updated":"2023-12-12 09:58:07.000000000","message":"Seem reasonable to me.","commit_id":"578a257c3858484cd26415f1490f3b4ce1b15ccb"}],"ansible/roles/network-redhat/tasks/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4c073df5fd0a43f46eff394271dc67c43d4379c7","unresolved":true,"context_lines":[{"line_number":4,"context_line":"  when: resolv_is_managed | bool"},{"line_number":5,"context_line":"  become: True"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Stop NetworkManager from overriding resolv.conf"},{"line_number":8,"context_line":"  become: true"},{"line_number":9,"context_line":"  blockinfile:"},{"line_number":10,"context_line":"    path: \"/etc/NetworkManager/NetworkManager.conf\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4f8f5eb2_12b995a0","line":7,"updated":"2023-12-11 10:27:39.000000000","message":"Did you see this module? https://docs.ansible.com/ansible/latest/collections/community/general/ini_file_module.html","commit_id":"81328a06391a9a578a3af55258b339eca0abaf53"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"eb497af94b7edd7ccf7cb0f2ae1937d7f03cf024","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  when: resolv_is_managed | bool"},{"line_number":5,"context_line":"  become: True"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Stop NetworkManager from overriding resolv.conf"},{"line_number":8,"context_line":"  become: true"},{"line_number":9,"context_line":"  blockinfile:"},{"line_number":10,"context_line":"    path: \"/etc/NetworkManager/NetworkManager.conf\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b468bee2_5f3d14fc","line":7,"in_reply_to":"4f8f5eb2_12b995a0","updated":"2023-12-11 10:48:57.000000000","message":"I had not seen this, have updated to use it.","commit_id":"81328a06391a9a578a3af55258b339eca0abaf53"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a39669167c6f0f97099aa5c828a5daca48c046e6","unresolved":true,"context_lines":[{"line_number":12,"context_line":"        path: /etc/NetworkManager/NetworkManager.conf"},{"line_number":13,"context_line":"        section: main"},{"line_number":14,"context_line":"        option: dns"},{"line_number":15,"context_line":"        value: none"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    - name: Stop NetworkManager from overriding resolv.conf"},{"line_number":18,"context_line":"      community.general.ini_file:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6047d8ac_08dc9930","line":15,"updated":"2023-12-11 11:29:31.000000000","message":"It would be slightly more efficient with single task and a loop:\n\nloop:\n  - option: dns\n    value: none\n  - option: rc-manager\n    value: unmanaged\n\nand setting the state based on the flag:\n\n  state: \"{{ \u0027present\u0027 if resolv_is_managed | bool else \u0027absent\u0027 }}\"","commit_id":"a99a4f4ed7166e58f56a36e37f1148604b9493f6"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"de9cbca9517c8d8eb9888f3a3e873302138abb4b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        path: /etc/NetworkManager/NetworkManager.conf"},{"line_number":13,"context_line":"        section: main"},{"line_number":14,"context_line":"        option: dns"},{"line_number":15,"context_line":"        value: none"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    - name: Stop NetworkManager from overriding resolv.conf"},{"line_number":18,"context_line":"      community.general.ini_file:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"acfda467_675b62aa","line":15,"in_reply_to":"6047d8ac_08dc9930","updated":"2023-12-11 11:40:28.000000000","message":"Done, cheers for the tips :)","commit_id":"a99a4f4ed7166e58f56a36e37f1148604b9493f6"}]}