)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1c4d7df66ae8b59a7aeb7e844b9c09159bb2348b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Rafal Lewandowski \u003crafal@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-01-31 11:04:19 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Redfish rules to Ironic introspection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I719fc8042742fe8b3b0312658aec39317a1bc358"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a85a09f_b38e0fc8","line":7,"range":{"start_line":7,"start_character":21,"end_line":7,"end_character":27},"updated":"2024-01-31 10:13:07.000000000","message":"Ironic and Bifrost","commit_id":"0d48eed039454445049430cc2695dfe869723780"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"c4ef6d4da85d3ce4764496c2985386dc6f6c2277","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rafal Lewandowski \u003crafal@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-01-31 11:04:19 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Redfish rules to Ironic introspection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I719fc8042742fe8b3b0312658aec39317a1bc358"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1785fc10_4a12985a","line":7,"range":{"start_line":7,"start_character":21,"end_line":7,"end_character":27},"in_reply_to":"1a85a09f_b38e0fc8","updated":"2024-01-31 14:32:36.000000000","message":"Done","commit_id":"0d48eed039454445049430cc2695dfe869723780"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"19897370e2d7ae0837586ccb67c3526c59191933","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3799aaa4_37cf00aa","updated":"2023-12-08 15:15:51.000000000","message":"Looks useful, thanks.","commit_id":"40576194dd95d196e9634e17833d870d012db323"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"616389d52f8e2d16d1f1565bd1b83c4bd049b7a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3dbddb3f_f95992a1","updated":"2023-12-11 15:47:16.000000000","message":"recheck (kayobe-overcloud-upgrade-rocky9)","commit_id":"f2537bb5b2ae2c5754dbcefe18fa63e119876813"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"680ebfaac6d8f76f5aef9605dc66e8862704d57f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"956b9829_379fa96c","updated":"2024-01-31 11:33:30.000000000","message":"dont forget \u0027kolla_bifrost_inspector_redfish_username\u0027 and \u0027kolla_bifrost_inspector_redfish_username\u0027 in the correct place:\n- etc/kayobe/bifrost.yml\n- ansible/inventory/group_vars/all/bifrost","commit_id":"df16e86eab784e9d4b0c4cd206df451d3c575eb6"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"c4ef6d4da85d3ce4764496c2985386dc6f6c2277","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"daf723f6_41a9e462","in_reply_to":"956b9829_379fa96c","updated":"2024-01-31 14:32:36.000000000","message":"Done","commit_id":"df16e86eab784e9d4b0c4cd206df451d3c575eb6"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"8d689694b97411cc30f931b49c024e5a21d881bd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b64452bb_9f1c08f2","updated":"2024-02-02 11:40:04.000000000","message":"please address last comments","commit_id":"96d4c3f2ce70441f1836e58f704bddb5acd85e18"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"ee97a93d5b99b88de99cc7fc5f0eae37ff903fd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e8771720_6dbc832d","updated":"2024-02-02 09:00:29.000000000","message":"recheck (kayobe-overcloud-ubuntu-jammy)","commit_id":"96d4c3f2ce70441f1836e58f704bddb5acd85e18"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"d66ac898dd1e4eff70d1d8e3ca2713a7e915d562","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ec17d717_f47e0b35","in_reply_to":"b64452bb_9f1c08f2","updated":"2024-02-02 14:24:20.000000000","message":"Done","commit_id":"96d4c3f2ce70441f1836e58f704bddb5acd85e18"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"2b89a314396a7584bba4b3a71dd57f3ab8ff2348","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"18c9505b_6072d847","updated":"2024-02-02 14:56:07.000000000","message":"I\u0027m happy for the rework of the ipmi_password variables to be reworked in a future patch as we seem to be abusing that elsewhere for any bmc related credentials.","commit_id":"3a04debd7c61a346a572379adac2622729f10e17"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c618099266f77d66294700bf2e89eedbe942ae67","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4ee548b0_fe90aa98","updated":"2024-02-02 15:51:24.000000000","message":"almost lgtm, lets fix reno","commit_id":"3a04debd7c61a346a572379adac2622729f10e17"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c618099266f77d66294700bf2e89eedbe942ae67","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4650c7c2_a3588603","in_reply_to":"18c9505b_6072d847","updated":"2024-02-02 15:51:24.000000000","message":"okay, what about to split ipmi/redfish to add ability provision some servers via ipmi another one via redfish in one run?","commit_id":"3a04debd7c61a346a572379adac2622729f10e17"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"294a67e63f3a076be13c7eff65a93a25f70e197c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ab3247c3_3115fb89","in_reply_to":"4650c7c2_a3588603","updated":"2024-02-06 08:44:29.000000000","message":"Closing","commit_id":"3a04debd7c61a346a572379adac2622729f10e17"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"5b43df78e1fd14f8d5d8087c87d7d4f256a78503","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"5a69ae4d_820a460d","in_reply_to":"4ee548b0_fe90aa98","updated":"2024-02-05 06:43:08.000000000","message":"Done","commit_id":"3a04debd7c61a346a572379adac2622729f10e17"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2e5a3a0b130010d40e17ce65b0d6843218d12134","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"369eb01a_3912bf89","updated":"2024-02-08 15:07:30.000000000","message":"docs missing as well","commit_id":"37bfd155855a998582ddb4a7443216e82823e04c"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"cd84a137a5ccb82122267987c2f37ccd1b7eaa0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"399779f2_34f0e10c","in_reply_to":"0f2abe37_04696c81","updated":"2024-02-22 09:21:07.000000000","message":"Done","commit_id":"37bfd155855a998582ddb4a7443216e82823e04c"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"9b79b288fae4747995803cf7e34c259a8422fa31","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f29667bd_d6f8094b","in_reply_to":"369eb01a_3912bf89","updated":"2024-02-13 07:15:21.000000000","message":"Would that be sufficient?\nhttps://review.opendev.org/c/openstack/kayobe/+/902772/14/etc/kayobe/inspector.yml#75","commit_id":"37bfd155855a998582ddb4a7443216e82823e04c"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"95d42f645b1bf185f7be17cc442567b2d5831b51","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"0f2abe37_04696c81","in_reply_to":"f29667bd_d6f8094b","updated":"2024-02-22 09:20:39.000000000","message":"Added to bifrost.rst.","commit_id":"37bfd155855a998582ddb4a7443216e82823e04c"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"21a20825022b2755d60428c8bd148e2de5729567","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"d64d85be_43a5e069","updated":"2024-02-23 17:51:39.000000000","message":"Looks reasonable to me. Might be nice to add a piece around determining the System ID. Also have a slight reservation about the default being Dell specific, but think we could potentially make the rule conditional on the vendor data from introspection.","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6ecea86ad93d83527128ed1870d8d648fbbada2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"87982fa0_d948216b","updated":"2024-03-05 08:10:57.000000000","message":"The main change looks good, I mostly have comments related to the docs.","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"9f02ce63164c792ea0a8e793a623f5186e9b47d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"29b16712_a1a3fc55","in_reply_to":"52d50857_3bea42c7","updated":"2024-02-28 08:26:55.000000000","message":"Acknowledged","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"848a0a095c18c5069ac8e4b33b86447c6c5e508d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":15,"id":"52d50857_3bea42c7","in_reply_to":"d64d85be_43a5e069","updated":"2024-02-23 18:32:20.000000000","message":"I think we don\u0027t need rely on introspection because it can be absent at all, for example user provide all the needed information for provision via configuration, or introspection did\u0027t work because of hardware/software misconfiguration. The good idea would be add the check task and fail with warning of absence of SystemID in configuration. This would be nice in pre-check too.","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b26d22bd6b2c64b3b19d6277bdbfdf692af2ad6b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":20,"id":"9e90fc01_cb313a71","updated":"2024-03-13 09:17:57.000000000","message":"I mean use of KAYOBE_CONFIG_PATH","commit_id":"bafcde83954aa63ed572c699c6df41cdd820d43a"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"deede8ecb6ea7b2b514da6b6fe228cbefc69b2d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"4b40ca32_3e5917e0","in_reply_to":"9e90fc01_cb313a71","updated":"2024-03-13 09:30:36.000000000","message":"Done","commit_id":"bafcde83954aa63ed572c699c6df41cdd820d43a"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"e9ae3c9562402b22f0acdab3fe626895956dc459","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"fb2ea74a_ebcd0f25","updated":"2024-03-22 17:27:05.000000000","message":"LGTM. Might be nice to add some documentation around introspection configuration for baremetal compute nodes at some point in the future (at least linking to inspector.yml).","commit_id":"e599dca1e8f51b7bf217b6bc0cf5bf9633262f06"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"3cb5cc911a61f97bdbc8948c641e2404b16f86d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"1e95ae99_dc8f9260","updated":"2024-03-22 07:57:29.000000000","message":"recheck (kayobe-overcloud-rocky9)","commit_id":"e599dca1e8f51b7bf217b6bc0cf5bf9633262f06"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"8777bf459896f3f84259ad77f84d8924cdb9aaa5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"eba89954_4664d2f9","updated":"2024-03-21 17:44:25.000000000","message":"recheck (kayobe-overcloud-rocky9)","commit_id":"e599dca1e8f51b7bf217b6bc0cf5bf9633262f06"}],"ansible/inventory/group_vars/all/bifrost":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"90e63b7b6b4642b85b94ae92c006cd64a568942e","unresolved":true,"context_lines":[{"line_number":109,"context_line":"kolla_bifrost_inspector_ipmi_password: \"{{ ipmi_password }}\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"# Ironic inspector Redfish username to set."},{"line_number":112,"context_line":"kolla_bifrost_inspector_redfish_username: \"{{ inspector_redfish_username }}\""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"# Ironic inspector Redfish password to set."},{"line_number":115,"context_line":"kolla_bifrost_inspector_redfish_password: \"{{ inspector_redfish_password }}\""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9d068363_4feecb2a","line":112,"range":{"start_line":112,"start_character":46,"end_line":112,"end_character":72},"updated":"2024-01-31 18:13:56.000000000","message":"create \u0027redfish_username\u0027 variable like for IPMI","commit_id":"96d4c3f2ce70441f1836e58f704bddb5acd85e18"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"294a67e63f3a076be13c7eff65a93a25f70e197c","unresolved":false,"context_lines":[{"line_number":109,"context_line":"kolla_bifrost_inspector_ipmi_password: \"{{ ipmi_password }}\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"# Ironic inspector Redfish username to set."},{"line_number":112,"context_line":"kolla_bifrost_inspector_redfish_username: \"{{ inspector_redfish_username }}\""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"# Ironic inspector Redfish password to set."},{"line_number":115,"context_line":"kolla_bifrost_inspector_redfish_password: \"{{ inspector_redfish_password }}\""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"99c90810_0959b9c1","line":112,"range":{"start_line":112,"start_character":46,"end_line":112,"end_character":72},"in_reply_to":"4c757aae_6f5c2416","updated":"2024-02-06 08:44:29.000000000","message":"Closing","commit_id":"96d4c3f2ce70441f1836e58f704bddb5acd85e18"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"d66ac898dd1e4eff70d1d8e3ca2713a7e915d562","unresolved":true,"context_lines":[{"line_number":109,"context_line":"kolla_bifrost_inspector_ipmi_password: \"{{ ipmi_password }}\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"# Ironic inspector Redfish username to set."},{"line_number":112,"context_line":"kolla_bifrost_inspector_redfish_username: \"{{ inspector_redfish_username }}\""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"# Ironic inspector Redfish password to set."},{"line_number":115,"context_line":"kolla_bifrost_inspector_redfish_password: \"{{ inspector_redfish_password }}\""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"4c757aae_6f5c2416","line":112,"range":{"start_line":112,"start_character":46,"end_line":112,"end_character":72},"in_reply_to":"9d068363_4feecb2a","updated":"2024-02-02 14:24:20.000000000","message":"That would entail writing additional modifications for node-discovery in order to decouple redfish from ipmi, imo it\u0027s better to leave it as is in transitory period and decouple that along with ``inspector_rule_ipmi_credentials``.","commit_id":"96d4c3f2ce70441f1836e58f704bddb5acd85e18"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"90e63b7b6b4642b85b94ae92c006cd64a568942e","unresolved":true,"context_lines":[{"line_number":112,"context_line":"kolla_bifrost_inspector_redfish_username: \"{{ inspector_redfish_username }}\""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"# Ironic inspector Redfish password to set."},{"line_number":115,"context_line":"kolla_bifrost_inspector_redfish_password: \"{{ inspector_redfish_password }}\""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"# Ironic inspector network interface name on which to check for an LLDP switch"},{"line_number":118,"context_line":"# port description to use as the node\u0027s name."}],"source_content_type":"application/octet-stream","patch_set":10,"id":"bd0df56a_0b5d56c8","line":115,"range":{"start_line":115,"start_character":46,"end_line":115,"end_character":72},"updated":"2024-01-31 18:13:56.000000000","message":"create \u0027redfish_password\u0027 variable like for IPMI","commit_id":"96d4c3f2ce70441f1836e58f704bddb5acd85e18"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"294a67e63f3a076be13c7eff65a93a25f70e197c","unresolved":false,"context_lines":[{"line_number":112,"context_line":"kolla_bifrost_inspector_redfish_username: \"{{ inspector_redfish_username }}\""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"# Ironic inspector Redfish password to set."},{"line_number":115,"context_line":"kolla_bifrost_inspector_redfish_password: \"{{ inspector_redfish_password }}\""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"# Ironic inspector network interface name on which to check for an LLDP switch"},{"line_number":118,"context_line":"# port description to use as the node\u0027s name."}],"source_content_type":"application/octet-stream","patch_set":10,"id":"51a28945_21bad39a","line":115,"range":{"start_line":115,"start_character":46,"end_line":115,"end_character":72},"in_reply_to":"7267981c_254d2741","updated":"2024-02-06 08:44:29.000000000","message":"Closing","commit_id":"96d4c3f2ce70441f1836e58f704bddb5acd85e18"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"d66ac898dd1e4eff70d1d8e3ca2713a7e915d562","unresolved":true,"context_lines":[{"line_number":112,"context_line":"kolla_bifrost_inspector_redfish_username: \"{{ inspector_redfish_username }}\""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"# Ironic inspector Redfish password to set."},{"line_number":115,"context_line":"kolla_bifrost_inspector_redfish_password: \"{{ inspector_redfish_password }}\""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"# Ironic inspector network interface name on which to check for an LLDP switch"},{"line_number":118,"context_line":"# port description to use as the node\u0027s name."}],"source_content_type":"application/octet-stream","patch_set":10,"id":"7267981c_254d2741","line":115,"range":{"start_line":115,"start_character":46,"end_line":115,"end_character":72},"in_reply_to":"bd0df56a_0b5d56c8","updated":"2024-02-02 14:24:20.000000000","message":"^ditto","commit_id":"96d4c3f2ce70441f1836e58f704bddb5acd85e18"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8331967598eb7e0558e4a36d3c999900e119ddc7","unresolved":true,"context_lines":[{"line_number":103,"context_line":"kolla_bifrost_inspector_rules: \"{{ inspector_rules + [inspector_rule_legacy_deploy_kernel] }}\""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"# Ironic inspector option to enable IPMI rules. Default is {{ inspector_rules_ipmi_enabled }}."},{"line_number":106,"context_line":"kolla_bifrost_inspector_rules_ipmi_enabled: \"{{ inspector_rules_ipmi_enabled }}\""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"# Ironic inspector IPMI username to set."},{"line_number":109,"context_line":"kolla_bifrost_inspector_ipmi_username: \"{{ ipmi_username }}\""}],"source_content_type":"application/octet-stream","patch_set":23,"id":"cea70128_a9dc4c16","line":106,"updated":"2024-03-25 11:50:38.000000000","message":"I see that these new variables follow the pattern of having separate options for bifrost, which could be useful. However, they are not currently referenced anywhere. kolla_bifrost_inspector_rules refers to inspector_rules which refers to the original variables.\n\nYou could build up a list of rules using a similar expression as that used in inspector_rules, but there would be implications for backwards compatibility because the bifrost rules would no longer reference inspector_rules (which someone may have overridden)...","commit_id":"e599dca1e8f51b7bf217b6bc0cf5bf9633262f06"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"77c1b0557fa2280b7abc9d6d1d929a0ca2dc8bed","unresolved":false,"context_lines":[{"line_number":103,"context_line":"kolla_bifrost_inspector_rules: \"{{ inspector_rules + [inspector_rule_legacy_deploy_kernel] }}\""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"# Ironic inspector option to enable IPMI rules. Default is {{ inspector_rules_ipmi_enabled }}."},{"line_number":106,"context_line":"kolla_bifrost_inspector_rules_ipmi_enabled: \"{{ inspector_rules_ipmi_enabled }}\""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"# Ironic inspector IPMI username to set."},{"line_number":109,"context_line":"kolla_bifrost_inspector_ipmi_username: \"{{ ipmi_username }}\""}],"source_content_type":"application/octet-stream","patch_set":23,"id":"3ba1dbab_97bb0b19","line":106,"in_reply_to":"cea70128_a9dc4c16","updated":"2024-03-26 11:35:00.000000000","message":"Removed.","commit_id":"e599dca1e8f51b7bf217b6bc0cf5bf9633262f06"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8331967598eb7e0558e4a36d3c999900e119ddc7","unresolved":true,"context_lines":[{"line_number":121,"context_line":"kolla_bifrost_inspector_redfish_password: \"{{ inspector_redfish_password }}\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# Redfish CA setting. Default is {{ inspector_rule_var_redfish_verify_ca }}."},{"line_number":124,"context_line":"kolla_bifrost_inspector_rule_var_redfish_verify_ca: \"{{ inspector_rule_var_redfish_verify_ca }}\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"# Ironic inspector network interface name on which to check for an LLDP switch"},{"line_number":127,"context_line":"# port description to use as the node\u0027s name."}],"source_content_type":"application/octet-stream","patch_set":23,"id":"1c3e6937_f31cbcb3","line":124,"updated":"2024-03-25 11:50:38.000000000","message":"You\u0027d need to have a separate verify CA rule defined for bifrost to make this work.","commit_id":"e599dca1e8f51b7bf217b6bc0cf5bf9633262f06"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"77c1b0557fa2280b7abc9d6d1d929a0ca2dc8bed","unresolved":false,"context_lines":[{"line_number":121,"context_line":"kolla_bifrost_inspector_redfish_password: \"{{ inspector_redfish_password }}\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# Redfish CA setting. Default is {{ inspector_rule_var_redfish_verify_ca }}."},{"line_number":124,"context_line":"kolla_bifrost_inspector_rule_var_redfish_verify_ca: \"{{ inspector_rule_var_redfish_verify_ca }}\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"# Ironic inspector network interface name on which to check for an LLDP switch"},{"line_number":127,"context_line":"# port description to use as the node\u0027s name."}],"source_content_type":"application/octet-stream","patch_set":23,"id":"6f4e60ed_5ccf9ad9","line":124,"in_reply_to":"1c3e6937_f31cbcb3","updated":"2024-03-26 11:35:00.000000000","message":"Removed.","commit_id":"e599dca1e8f51b7bf217b6bc0cf5bf9633262f06"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"70583e349bf4881d245758b12ae15f73b62a2a40","unresolved":true,"context_lines":[{"line_number":109,"context_line":"kolla_bifrost_inspector_ipmi_password: \"{{ ipmi_password }}\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"# Enable inspector Redfish rules."},{"line_number":112,"context_line":"kolla_bifrost_inspector_rules_redfish_enabled: \"{{ inspector_rules_redfish_enabled }}\""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"# Ironic inspector Redfish username to set."},{"line_number":115,"context_line":"kolla_bifrost_inspector_redfish_username: \"{{ inspector_redfish_username }}\""}],"source_content_type":"application/octet-stream","patch_set":25,"id":"8841cd4f_30b92fff","line":112,"updated":"2024-03-28 12:14:07.000000000","message":"This one is still unused","commit_id":"e1b59815a7ba122211a14baf630c1ca90e707c59"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"d0fe60d81e24266d5b7807b1ca4efe957c9c8049","unresolved":false,"context_lines":[{"line_number":109,"context_line":"kolla_bifrost_inspector_ipmi_password: \"{{ ipmi_password }}\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"# Enable inspector Redfish rules."},{"line_number":112,"context_line":"kolla_bifrost_inspector_rules_redfish_enabled: \"{{ inspector_rules_redfish_enabled }}\""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"# Ironic inspector Redfish username to set."},{"line_number":115,"context_line":"kolla_bifrost_inspector_redfish_username: \"{{ inspector_redfish_username }}\""}],"source_content_type":"application/octet-stream","patch_set":25,"id":"e1e49814_fad0f26c","line":112,"in_reply_to":"8841cd4f_30b92fff","updated":"2024-03-29 07:46:36.000000000","message":"Done","commit_id":"e1b59815a7ba122211a14baf630c1ca90e707c59"}],"ansible/inventory/group_vars/all/inspector":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"19897370e2d7ae0837586ccb67c3526c59191933","unresolved":true,"context_lines":[{"line_number":350,"context_line":"  actions:"},{"line_number":351,"context_line":"    - action: \"set-attribute\""},{"line_number":352,"context_line":"      path: \"driver_info/redfish_system_id\""},{"line_number":353,"context_line":"      value: \"/redfish/v1/Systems/System.Embedded.1\""},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"# Ironic inspector rule to set Redfish certificate authority."},{"line_number":356,"context_line":"inspector_rule_redfish_verify_ca:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"6e7a7a67_9b509a49","line":353,"updated":"2023-12-08 15:15:51.000000000","message":"Does this different between vendors? Perhaps make it a variable?","commit_id":"40576194dd95d196e9634e17833d870d012db323"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"60ce71c8b71361f5b2642bbaf56c328ce701265e","unresolved":true,"context_lines":[{"line_number":350,"context_line":"  actions:"},{"line_number":351,"context_line":"    - action: \"set-attribute\""},{"line_number":352,"context_line":"      path: \"driver_info/redfish_system_id\""},{"line_number":353,"context_line":"      value: \"/redfish/v1/Systems/System.Embedded.1\""},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"# Ironic inspector rule to set Redfish certificate authority."},{"line_number":356,"context_line":"inspector_rule_redfish_verify_ca:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"bf25904e_a2099282","line":353,"in_reply_to":"6e7a7a67_9b509a49","updated":"2023-12-11 08:48:55.000000000","message":"Good point, I\u0027ll change it.","commit_id":"40576194dd95d196e9634e17833d870d012db323"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"56eddf6f9b4ab43fa66812b079c5f0a895807bed","unresolved":false,"context_lines":[{"line_number":350,"context_line":"  actions:"},{"line_number":351,"context_line":"    - action: \"set-attribute\""},{"line_number":352,"context_line":"      path: \"driver_info/redfish_system_id\""},{"line_number":353,"context_line":"      value: \"/redfish/v1/Systems/System.Embedded.1\""},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"# Ironic inspector rule to set Redfish certificate authority."},{"line_number":356,"context_line":"inspector_rule_redfish_verify_ca:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"12df680a_e4350094","line":353,"in_reply_to":"bf25904e_a2099282","updated":"2023-12-11 12:44:16.000000000","message":"Done","commit_id":"40576194dd95d196e9634e17833d870d012db323"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"489319c3dc4bd699498d35290f4d9ffb4ed7b39c","unresolved":true,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":"# List of default ironic inspector rules."},{"line_number":367,"context_line":"inspector_rules_default:"},{"line_number":368,"context_line":"  - \"{{ inspector_rule_ipmi_credentials }}\""},{"line_number":369,"context_line":"  - \"{{ inspector_rule_redfish_credentials }}\""},{"line_number":370,"context_line":"  - \"{{ inspector_rule_redfish_address }}\""},{"line_number":371,"context_line":"  - \"{{ inspector_rule_redfish_system_id }}\""},{"line_number":372,"context_line":"  - \"{{ inspector_rule_redfish_verify_ca }}\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"e2d3db4b_de407bfb","line":369,"range":{"start_line":368,"start_character":0,"end_line":369,"end_character":46},"updated":"2023-12-07 23:17:46.000000000","message":"we shouldn\u0027t mix both ipmi and redfish credentials rules","commit_id":"40576194dd95d196e9634e17833d870d012db323"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"6826a17ada02e93a9d34eead7e5c8ffd4aaf1bee","unresolved":true,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":"# List of default ironic inspector rules."},{"line_number":367,"context_line":"inspector_rules_default:"},{"line_number":368,"context_line":"  - \"{{ inspector_rule_ipmi_credentials }}\""},{"line_number":369,"context_line":"  - \"{{ inspector_rule_redfish_credentials }}\""},{"line_number":370,"context_line":"  - \"{{ inspector_rule_redfish_address }}\""},{"line_number":371,"context_line":"  - \"{{ inspector_rule_redfish_system_id }}\""},{"line_number":372,"context_line":"  - \"{{ inspector_rule_redfish_verify_ca }}\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"14446a80_aaf98b4f","line":369,"range":{"start_line":368,"start_character":0,"end_line":369,"end_character":46},"in_reply_to":"1232d800_fadef618","updated":"2023-12-08 23:07:29.000000000","message":"what if no mix? but server have both ipmi and redfish enabled in bios?) there should be the \u0027if case\u0027 to enable rule or not","commit_id":"40576194dd95d196e9634e17833d870d012db323"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"60ce71c8b71361f5b2642bbaf56c328ce701265e","unresolved":true,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":"# List of default ironic inspector rules."},{"line_number":367,"context_line":"inspector_rules_default:"},{"line_number":368,"context_line":"  - \"{{ inspector_rule_ipmi_credentials }}\""},{"line_number":369,"context_line":"  - \"{{ inspector_rule_redfish_credentials }}\""},{"line_number":370,"context_line":"  - \"{{ inspector_rule_redfish_address }}\""},{"line_number":371,"context_line":"  - \"{{ inspector_rule_redfish_system_id }}\""},{"line_number":372,"context_line":"  - \"{{ inspector_rule_redfish_verify_ca }}\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"f26b9735_fa6e0594","line":369,"range":{"start_line":368,"start_character":0,"end_line":369,"end_character":46},"in_reply_to":"14446a80_aaf98b4f","updated":"2023-12-11 08:48:55.000000000","message":"I think it adds flexibility for customer use into the mix, however if setting both is not the right approach I could change it.","commit_id":"40576194dd95d196e9634e17833d870d012db323"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"19897370e2d7ae0837586ccb67c3526c59191933","unresolved":true,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":"# List of default ironic inspector rules."},{"line_number":367,"context_line":"inspector_rules_default:"},{"line_number":368,"context_line":"  - \"{{ inspector_rule_ipmi_credentials }}\""},{"line_number":369,"context_line":"  - \"{{ inspector_rule_redfish_credentials }}\""},{"line_number":370,"context_line":"  - \"{{ inspector_rule_redfish_address }}\""},{"line_number":371,"context_line":"  - \"{{ inspector_rule_redfish_system_id }}\""},{"line_number":372,"context_line":"  - \"{{ inspector_rule_redfish_verify_ca }}\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1232d800_fadef618","line":369,"range":{"start_line":368,"start_character":0,"end_line":369,"end_character":46},"in_reply_to":"e2d3db4b_de407bfb","updated":"2023-12-08 15:15:51.000000000","message":"You could have a mix of hardware. Some using ipmi and some using redfish.","commit_id":"40576194dd95d196e9634e17833d870d012db323"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"8c4eec3158abfcaea5916ca578aac21416927579","unresolved":false,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":"# List of default ironic inspector rules."},{"line_number":367,"context_line":"inspector_rules_default:"},{"line_number":368,"context_line":"  - \"{{ inspector_rule_ipmi_credentials }}\""},{"line_number":369,"context_line":"  - \"{{ inspector_rule_redfish_credentials }}\""},{"line_number":370,"context_line":"  - \"{{ inspector_rule_redfish_address }}\""},{"line_number":371,"context_line":"  - \"{{ inspector_rule_redfish_system_id }}\""},{"line_number":372,"context_line":"  - \"{{ inspector_rule_redfish_verify_ca }}\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9075d814_7360f0e2","line":369,"range":{"start_line":368,"start_character":0,"end_line":369,"end_character":46},"in_reply_to":"f26b9735_fa6e0594","updated":"2023-12-11 12:59:08.000000000","message":"Acknowledged","commit_id":"40576194dd95d196e9634e17833d870d012db323"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"8c4eec3158abfcaea5916ca578aac21416927579","unresolved":true,"context_lines":[{"line_number":353,"context_line":"  actions:"},{"line_number":354,"context_line":"    - action: \"set-attribute\""},{"line_number":355,"context_line":"      path: \"driver_info/redfish_system_id\""},{"line_number":356,"context_line":"      value: \"/redfish/v1/Systems/System.Embedded.1\""},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"# Ironic inspector rule to set Redfish certificate authority."},{"line_number":359,"context_line":"inspector_rule_redfish_verify_ca:"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"ffd907fb_2300834f","line":356,"range":{"start_line":356,"start_character":13,"end_line":356,"end_character":52},"updated":"2023-12-11 12:59:08.000000000","message":"hardcode","commit_id":"176b2890fc3f88479080d269b351c5c2c53a3210"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"ff7e6658c8ef8b0e33489db816cb9a137a336db5","unresolved":false,"context_lines":[{"line_number":353,"context_line":"  actions:"},{"line_number":354,"context_line":"    - action: \"set-attribute\""},{"line_number":355,"context_line":"      path: \"driver_info/redfish_system_id\""},{"line_number":356,"context_line":"      value: \"/redfish/v1/Systems/System.Embedded.1\""},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"# Ironic inspector rule to set Redfish certificate authority."},{"line_number":359,"context_line":"inspector_rule_redfish_verify_ca:"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3b44caec_6898ae03","line":356,"range":{"start_line":356,"start_character":13,"end_line":356,"end_character":52},"in_reply_to":"ffd907fb_2300834f","updated":"2023-12-11 13:02:00.000000000","message":"Done","commit_id":"176b2890fc3f88479080d269b351c5c2c53a3210"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c6e4b2a70c70875123127c3cf90ad6fa4d786d6f","unresolved":true,"context_lines":[{"line_number":369,"context_line":"# List of default ironic inspector rules."},{"line_number":370,"context_line":"inspector_rules_default:"},{"line_number":371,"context_line":"  - \"{{ inspector_rule_ipmi_credentials }}\""},{"line_number":372,"context_line":"  - \"{{ inspector_rule_redfish_credentials }}\""},{"line_number":373,"context_line":"  - \"{{ inspector_rule_redfish_address }}\""},{"line_number":374,"context_line":"  - \"{{ inspector_rule_redfish_system_id }}\""},{"line_number":375,"context_line":"  - \"{{ inspector_rule_redfish_verify_ca }}\""},{"line_number":376,"context_line":"  - \"{{ inspector_rule_deploy_kernel }}\""},{"line_number":377,"context_line":"  - \"{{ inspector_rule_deploy_ramdisk }}\""},{"line_number":378,"context_line":"  - \"{{ inspector_rule_root_hint_init }}\""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"4010da7b_0c0c33bc","line":375,"range":{"start_line":372,"start_character":0,"end_line":375,"end_character":44},"updated":"2023-12-20 15:50:55.000000000","message":"should we add those always?\nI assumed we would have a variable that allows the operator to choose a driver, that all new nodes would be enrolled with - and based on that driver we would define a set of default inspector rules (ipmi for ipmi, redfish for redfish, etc)","commit_id":"77ea23cac1f01922e949b9dc533e3bbd2912078d"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"5071997e0d60f85edca722a920e1288e55310e23","unresolved":true,"context_lines":[{"line_number":369,"context_line":"# List of default ironic inspector rules."},{"line_number":370,"context_line":"inspector_rules_default:"},{"line_number":371,"context_line":"  - \"{{ inspector_rule_ipmi_credentials }}\""},{"line_number":372,"context_line":"  - \"{{ inspector_rule_redfish_credentials }}\""},{"line_number":373,"context_line":"  - \"{{ inspector_rule_redfish_address }}\""},{"line_number":374,"context_line":"  - \"{{ inspector_rule_redfish_system_id }}\""},{"line_number":375,"context_line":"  - \"{{ inspector_rule_redfish_verify_ca }}\""},{"line_number":376,"context_line":"  - \"{{ inspector_rule_deploy_kernel }}\""},{"line_number":377,"context_line":"  - \"{{ inspector_rule_deploy_ramdisk }}\""},{"line_number":378,"context_line":"  - \"{{ inspector_rule_root_hint_init }}\""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"ee9f4b20_d53b585a","line":375,"range":{"start_line":372,"start_character":0,"end_line":375,"end_character":44},"in_reply_to":"4010da7b_0c0c33bc","updated":"2024-01-08 08:03:57.000000000","message":"My intention was to add redfish always whenever possible, as these these days it\u0027s becoming a bit of a standard and to give users the ability to have it out of the box. However if that\u0027s not right approach I can change the functionality to when enabled only.","commit_id":"77ea23cac1f01922e949b9dc533e3bbd2912078d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2ebf51d57ce24b9af47cfdd86a16e16af6ce9064","unresolved":true,"context_lines":[{"line_number":369,"context_line":"# List of default ironic inspector rules."},{"line_number":370,"context_line":"inspector_rules_default:"},{"line_number":371,"context_line":"  - \"{{ inspector_rule_ipmi_credentials }}\""},{"line_number":372,"context_line":"  - \"{{ inspector_rule_redfish_credentials }}\""},{"line_number":373,"context_line":"  - \"{{ inspector_rule_redfish_address }}\""},{"line_number":374,"context_line":"  - \"{{ inspector_rule_redfish_system_id }}\""},{"line_number":375,"context_line":"  - \"{{ inspector_rule_redfish_verify_ca }}\""},{"line_number":376,"context_line":"  - \"{{ inspector_rule_deploy_kernel }}\""},{"line_number":377,"context_line":"  - \"{{ inspector_rule_deploy_ramdisk }}\""},{"line_number":378,"context_line":"  - \"{{ inspector_rule_root_hint_init }}\""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"f47ef0a3_30f57027","line":375,"range":{"start_line":372,"start_character":0,"end_line":375,"end_character":44},"in_reply_to":"5209f6e3_e64d894c","updated":"2024-01-10 16:38:52.000000000","message":"So, basically how I see it:\nWe need a variable to set ironic-inspector enroll driver (as in how nodes get registered after discovery) and based on this variable add redfish/ipmi inspector rules - adding them all in irrespective of configured driver is going to be sort of a mess.","commit_id":"77ea23cac1f01922e949b9dc533e3bbd2912078d"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"0849a07b0a891c6436e241f7d77ecc92f9c6b9b7","unresolved":false,"context_lines":[{"line_number":369,"context_line":"# List of default ironic inspector rules."},{"line_number":370,"context_line":"inspector_rules_default:"},{"line_number":371,"context_line":"  - \"{{ inspector_rule_ipmi_credentials }}\""},{"line_number":372,"context_line":"  - \"{{ inspector_rule_redfish_credentials }}\""},{"line_number":373,"context_line":"  - \"{{ inspector_rule_redfish_address }}\""},{"line_number":374,"context_line":"  - \"{{ inspector_rule_redfish_system_id }}\""},{"line_number":375,"context_line":"  - \"{{ inspector_rule_redfish_verify_ca }}\""},{"line_number":376,"context_line":"  - \"{{ inspector_rule_deploy_kernel }}\""},{"line_number":377,"context_line":"  - \"{{ inspector_rule_deploy_ramdisk }}\""},{"line_number":378,"context_line":"  - \"{{ inspector_rule_root_hint_init }}\""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5209f6e3_e64d894c","line":375,"range":{"start_line":372,"start_character":0,"end_line":375,"end_character":44},"in_reply_to":"ee9f4b20_d53b585a","updated":"2024-01-08 16:22:37.000000000","message":"this will not break anything but adds more complex configuration when there is need to provision several servers part of which is redfish and other part is an old ipmi configurable. we need to think this way.","commit_id":"77ea23cac1f01922e949b9dc533e3bbd2912078d"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"c4ef6d4da85d3ce4764496c2985386dc6f6c2277","unresolved":false,"context_lines":[{"line_number":369,"context_line":"# List of default ironic inspector rules."},{"line_number":370,"context_line":"inspector_rules_default:"},{"line_number":371,"context_line":"  - \"{{ inspector_rule_ipmi_credentials }}\""},{"line_number":372,"context_line":"  - \"{{ inspector_rule_redfish_credentials }}\""},{"line_number":373,"context_line":"  - \"{{ inspector_rule_redfish_address }}\""},{"line_number":374,"context_line":"  - \"{{ inspector_rule_redfish_system_id }}\""},{"line_number":375,"context_line":"  - \"{{ inspector_rule_redfish_verify_ca }}\""},{"line_number":376,"context_line":"  - \"{{ inspector_rule_deploy_kernel }}\""},{"line_number":377,"context_line":"  - \"{{ inspector_rule_deploy_ramdisk }}\""},{"line_number":378,"context_line":"  - \"{{ inspector_rule_root_hint_init }}\""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5483939b_7843f623","line":375,"range":{"start_line":372,"start_character":0,"end_line":375,"end_character":44},"in_reply_to":"f47ef0a3_30f57027","updated":"2024-01-31 14:32:36.000000000","message":"Done","commit_id":"77ea23cac1f01922e949b9dc533e3bbd2912078d"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"6e9449a07a3c5e69ef8a9c12afb40f9b18424f92","unresolved":true,"context_lines":[{"line_number":393,"context_line":"inspector_rules_extra: []"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"# List of all ironic inspector rules."},{"line_number":396,"context_line":"inspector_rules: \"{{ inspector_rules_default + inspector_rules_extra | not inspector_rules_redfish_enabled | bool }}\""},{"line_number":397,"context_line":"inspector_rules: \"{{ inspector_rules_default + inspector_rules_extra + inspector_rules_redfish | inspector_rules_redfish_enabled | bool }}\""},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"###############################################################################"},{"line_number":400,"context_line":"# Dell switch LLDP workaround configuration."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"8a39bb03_d5358f2f","line":397,"range":{"start_line":396,"start_character":0,"end_line":397,"end_character":139},"updated":"2024-01-31 09:59:28.000000000","message":"just one line\n\ninspector_rules: \"{{ inspector_rules_default + inspector_rules_extra + (inspector_rules_redfish if inspector_rules_redfish_enabled | bool) }}\"","commit_id":"bb4dccda008615f184627824d0a69f9415918a9d"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"2df431641f8460b7298d7bf45d4eca7332f2d022","unresolved":false,"context_lines":[{"line_number":393,"context_line":"inspector_rules_extra: []"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"# List of all ironic inspector rules."},{"line_number":396,"context_line":"inspector_rules: \"{{ inspector_rules_default + inspector_rules_extra | not inspector_rules_redfish_enabled | bool }}\""},{"line_number":397,"context_line":"inspector_rules: \"{{ inspector_rules_default + inspector_rules_extra + inspector_rules_redfish | inspector_rules_redfish_enabled | bool }}\""},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"###############################################################################"},{"line_number":400,"context_line":"# Dell switch LLDP workaround configuration."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3d639909_fd2973b1","line":397,"range":{"start_line":396,"start_character":0,"end_line":397,"end_character":139},"in_reply_to":"4c5d7c5c_43a8686d","updated":"2024-01-31 10:05:00.000000000","message":"Thanks","commit_id":"bb4dccda008615f184627824d0a69f9415918a9d"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"c92a1f55dde628e322247fbf32cbe0cda309e7e9","unresolved":false,"context_lines":[{"line_number":393,"context_line":"inspector_rules_extra: []"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"# List of all ironic inspector rules."},{"line_number":396,"context_line":"inspector_rules: \"{{ inspector_rules_default + inspector_rules_extra | not inspector_rules_redfish_enabled | bool }}\""},{"line_number":397,"context_line":"inspector_rules: \"{{ inspector_rules_default + inspector_rules_extra + inspector_rules_redfish | inspector_rules_redfish_enabled | bool }}\""},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"###############################################################################"},{"line_number":400,"context_line":"# Dell switch LLDP workaround configuration."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"4c5d7c5c_43a8686d","line":397,"range":{"start_line":396,"start_character":0,"end_line":397,"end_character":139},"in_reply_to":"6cd06ad4_657d4830","updated":"2024-01-31 10:04:43.000000000","message":"Done","commit_id":"bb4dccda008615f184627824d0a69f9415918a9d"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"96e983a38c33dbd0a648bb90f128b4abe1880c3b","unresolved":true,"context_lines":[{"line_number":393,"context_line":"inspector_rules_extra: []"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"# List of all ironic inspector rules."},{"line_number":396,"context_line":"inspector_rules: \"{{ inspector_rules_default + inspector_rules_extra | not inspector_rules_redfish_enabled | bool }}\""},{"line_number":397,"context_line":"inspector_rules: \"{{ inspector_rules_default + inspector_rules_extra + inspector_rules_redfish | inspector_rules_redfish_enabled | bool }}\""},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"###############################################################################"},{"line_number":400,"context_line":"# Dell switch LLDP workaround configuration."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"6cd06ad4_657d4830","line":397,"range":{"start_line":396,"start_character":0,"end_line":397,"end_character":139},"in_reply_to":"8a39bb03_d5358f2f","updated":"2024-01-31 10:02:11.000000000","message":"inspector_rules: \"{{ inspector_rules_default + inspector_rules_extra + (inspector_rules_redfish if inspector_rules_redfish_enabled | bool else []) }}\"","commit_id":"bb4dccda008615f184627824d0a69f9415918a9d"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"31eb3edbfef73b32776926c2c6a7d9a4f369dca5","unresolved":true,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":"# List of default ironic inspector rules."},{"line_number":373,"context_line":"inspector_rules_default:"},{"line_number":374,"context_line":"  - \"{{ inspector_rule_ipmi_credentials }}\""},{"line_number":375,"context_line":"  - \"{{ inspector_rule_deploy_kernel }}\""},{"line_number":376,"context_line":"  - \"{{ inspector_rule_deploy_ramdisk }}\""},{"line_number":377,"context_line":"  - \"{{ inspector_rule_root_hint_init }}\""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"ef6d0dd1_599d1f32","line":374,"range":{"start_line":374,"start_character":0,"end_line":374,"end_character":43},"updated":"2024-01-31 10:19:52.000000000","message":"lets move this to the \u0027inspector_rules_ipmi\u0027 list and use it instead of [] in the \u0027inspector_rules\u0027","commit_id":"0d48eed039454445049430cc2695dfe869723780"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"475039ede9f1d2856423d03f5b39a5add78f48aa","unresolved":true,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":"# List of default ironic inspector rules."},{"line_number":373,"context_line":"inspector_rules_default:"},{"line_number":374,"context_line":"  - \"{{ inspector_rule_ipmi_credentials }}\""},{"line_number":375,"context_line":"  - \"{{ inspector_rule_deploy_kernel }}\""},{"line_number":376,"context_line":"  - \"{{ inspector_rule_deploy_ramdisk }}\""},{"line_number":377,"context_line":"  - \"{{ inspector_rule_root_hint_init }}\""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"94a43d25_c6e381a2","line":374,"range":{"start_line":374,"start_character":0,"end_line":374,"end_character":43},"in_reply_to":"0f44a462_04acd809","updated":"2024-02-02 13:07:10.000000000","message":"we agree not mix the feature and current settings","commit_id":"0d48eed039454445049430cc2695dfe869723780"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"c4ef6d4da85d3ce4764496c2985386dc6f6c2277","unresolved":true,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":"# List of default ironic inspector rules."},{"line_number":373,"context_line":"inspector_rules_default:"},{"line_number":374,"context_line":"  - \"{{ inspector_rule_ipmi_credentials }}\""},{"line_number":375,"context_line":"  - \"{{ inspector_rule_deploy_kernel }}\""},{"line_number":376,"context_line":"  - \"{{ inspector_rule_deploy_ramdisk }}\""},{"line_number":377,"context_line":"  - \"{{ inspector_rule_root_hint_init }}\""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"cf99d153_7428a5f4","line":374,"range":{"start_line":374,"start_character":0,"end_line":374,"end_character":43},"in_reply_to":"39a6e74e_3886ee26","updated":"2024-01-31 14:32:36.000000000","message":"It would be good to have a transitional period before we change the default behaviour or at least it should be done in separate patch imo.","commit_id":"0d48eed039454445049430cc2695dfe869723780"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"8d388748ffc39ccf4bf09c92963b9af8cb17f357","unresolved":true,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":"# List of default ironic inspector rules."},{"line_number":373,"context_line":"inspector_rules_default:"},{"line_number":374,"context_line":"  - \"{{ inspector_rule_ipmi_credentials }}\""},{"line_number":375,"context_line":"  - \"{{ inspector_rule_deploy_kernel }}\""},{"line_number":376,"context_line":"  - \"{{ inspector_rule_deploy_ramdisk }}\""},{"line_number":377,"context_line":"  - \"{{ inspector_rule_root_hint_init }}\""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"0f44a462_04acd809","line":374,"range":{"start_line":374,"start_character":0,"end_line":374,"end_character":43},"in_reply_to":"5876bdc3_adc02609","updated":"2024-02-02 12:54:10.000000000","message":"Happy for this to stay how it is for now. We could add a flag in a later change if necessary.","commit_id":"0d48eed039454445049430cc2695dfe869723780"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"d66ac898dd1e4eff70d1d8e3ca2713a7e915d562","unresolved":false,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":"# List of default ironic inspector rules."},{"line_number":373,"context_line":"inspector_rules_default:"},{"line_number":374,"context_line":"  - \"{{ inspector_rule_ipmi_credentials }}\""},{"line_number":375,"context_line":"  - \"{{ inspector_rule_deploy_kernel }}\""},{"line_number":376,"context_line":"  - \"{{ inspector_rule_deploy_ramdisk }}\""},{"line_number":377,"context_line":"  - \"{{ inspector_rule_root_hint_init }}\""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"1ea94785_80ad0de0","line":374,"range":{"start_line":374,"start_character":0,"end_line":374,"end_character":43},"in_reply_to":"94a43d25_c6e381a2","updated":"2024-02-02 14:24:20.000000000","message":"Acknowledged","commit_id":"0d48eed039454445049430cc2695dfe869723780"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"90e63b7b6b4642b85b94ae92c006cd64a568942e","unresolved":true,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":"# List of default ironic inspector rules."},{"line_number":373,"context_line":"inspector_rules_default:"},{"line_number":374,"context_line":"  - \"{{ inspector_rule_ipmi_credentials }}\""},{"line_number":375,"context_line":"  - \"{{ inspector_rule_deploy_kernel }}\""},{"line_number":376,"context_line":"  - \"{{ inspector_rule_deploy_ramdisk }}\""},{"line_number":377,"context_line":"  - \"{{ inspector_rule_root_hint_init }}\""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"5876bdc3_adc02609","line":374,"range":{"start_line":374,"start_character":0,"end_line":374,"end_character":43},"in_reply_to":"cf99d153_7428a5f4","updated":"2024-01-31 18:13:56.000000000","message":"we have the if case in the \u0027inspector_rules\u0027 so we didn\u0027t break anything and there is no need in transitional period. all the change will add the new feature.","commit_id":"0d48eed039454445049430cc2695dfe869723780"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"680ebfaac6d8f76f5aef9605dc66e8862704d57f","unresolved":true,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":"# List of default ironic inspector rules."},{"line_number":373,"context_line":"inspector_rules_default:"},{"line_number":374,"context_line":"  - \"{{ inspector_rule_ipmi_credentials }}\""},{"line_number":375,"context_line":"  - \"{{ inspector_rule_deploy_kernel }}\""},{"line_number":376,"context_line":"  - \"{{ inspector_rule_deploy_ramdisk }}\""},{"line_number":377,"context_line":"  - \"{{ inspector_rule_root_hint_init }}\""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"39a6e74e_3886ee26","line":374,"range":{"start_line":374,"start_character":0,"end_line":374,"end_character":43},"in_reply_to":"ef6d0dd1_599d1f32","updated":"2024-01-31 11:33:30.000000000","message":"forgot create \u0027inspector_rules_ipmi\u0027 with one rule and remove it from here","commit_id":"0d48eed039454445049430cc2695dfe869723780"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"31eb3edbfef73b32776926c2c6a7d9a4f369dca5","unresolved":true,"context_lines":[{"line_number":393,"context_line":"inspector_rules_extra: []"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"# List of all ironic inspector rules."},{"line_number":396,"context_line":"inspector_rules: \"{{ inspector_rules_default + inspector_rules_extra + (inspector_rules_redfish if inspector_rules_redfish_enabled | bool else []) }}\""},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"###############################################################################"},{"line_number":399,"context_line":"# Dell switch LLDP workaround configuration."}],"source_content_type":"application/octet-stream","patch_set":7,"id":"4de0af6f_53532dcc","line":396,"range":{"start_line":396,"start_character":17,"end_line":396,"end_character":150},"updated":"2024-01-31 10:19:52.000000000","message":"lets preserve order:\n\n\"{{ (inspector_rules_redfish if inspector_rules_redfish_enabled | bool else inspector_rules_ipmi) + inspector_rules_default + inspector_rules_extra }}\"","commit_id":"0d48eed039454445049430cc2695dfe869723780"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"294a67e63f3a076be13c7eff65a93a25f70e197c","unresolved":false,"context_lines":[{"line_number":393,"context_line":"inspector_rules_extra: []"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"# List of all ironic inspector rules."},{"line_number":396,"context_line":"inspector_rules: \"{{ inspector_rules_default + inspector_rules_extra + (inspector_rules_redfish if inspector_rules_redfish_enabled | bool else []) }}\""},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"###############################################################################"},{"line_number":399,"context_line":"# Dell switch LLDP workaround configuration."}],"source_content_type":"application/octet-stream","patch_set":7,"id":"a9c03fa0_2612f476","line":396,"range":{"start_line":396,"start_character":17,"end_line":396,"end_character":150},"in_reply_to":"2509c63a_397d8793","updated":"2024-02-06 08:44:29.000000000","message":"Closing","commit_id":"0d48eed039454445049430cc2695dfe869723780"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"c4ef6d4da85d3ce4764496c2985386dc6f6c2277","unresolved":true,"context_lines":[{"line_number":393,"context_line":"inspector_rules_extra: []"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"# List of all ironic inspector rules."},{"line_number":396,"context_line":"inspector_rules: \"{{ inspector_rules_default + inspector_rules_extra + (inspector_rules_redfish if inspector_rules_redfish_enabled | bool else []) }}\""},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"###############################################################################"},{"line_number":399,"context_line":"# Dell switch LLDP workaround configuration."}],"source_content_type":"application/octet-stream","patch_set":7,"id":"da91fbb4_f4676710","line":396,"range":{"start_line":396,"start_character":17,"end_line":396,"end_character":150},"in_reply_to":"4de0af6f_53532dcc","updated":"2024-01-31 14:32:36.000000000","message":"A propos inspector_rules_ipmi, ^ditto","commit_id":"0d48eed039454445049430cc2695dfe869723780"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"d66ac898dd1e4eff70d1d8e3ca2713a7e915d562","unresolved":true,"context_lines":[{"line_number":393,"context_line":"inspector_rules_extra: []"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"# List of all ironic inspector rules."},{"line_number":396,"context_line":"inspector_rules: \"{{ inspector_rules_default + inspector_rules_extra + (inspector_rules_redfish if inspector_rules_redfish_enabled | bool else []) }}\""},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"###############################################################################"},{"line_number":399,"context_line":"# Dell switch LLDP workaround configuration."}],"source_content_type":"application/octet-stream","patch_set":7,"id":"2509c63a_397d8793","line":396,"range":{"start_line":396,"start_character":17,"end_line":396,"end_character":150},"in_reply_to":"cbb09ad0_3647291e","updated":"2024-02-02 14:24:20.000000000","message":"As mentioned in ``redfish_username``, imo should be done after some time along with dedicated code for node discovery for redfish.","commit_id":"0d48eed039454445049430cc2695dfe869723780"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"90e63b7b6b4642b85b94ae92c006cd64a568942e","unresolved":true,"context_lines":[{"line_number":393,"context_line":"inspector_rules_extra: []"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"# List of all ironic inspector rules."},{"line_number":396,"context_line":"inspector_rules: \"{{ inspector_rules_default + inspector_rules_extra + (inspector_rules_redfish if inspector_rules_redfish_enabled | bool else []) }}\""},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"###############################################################################"},{"line_number":399,"context_line":"# Dell switch LLDP workaround configuration."}],"source_content_type":"application/octet-stream","patch_set":7,"id":"cbb09ad0_3647291e","line":396,"range":{"start_line":396,"start_character":17,"end_line":396,"end_character":150},"in_reply_to":"da91fbb4_f4676710","updated":"2024-01-31 18:13:56.000000000","message":"lets move the \u0027inspector_rule_ipmi_credentials\u0027 to the separate list as I mention, and use it here in the if case.","commit_id":"0d48eed039454445049430cc2695dfe869723780"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"90e63b7b6b4642b85b94ae92c006cd64a568942e","unresolved":true,"context_lines":[{"line_number":73,"context_line":"inspector_ipmi_password: \"{{ ipmi_password }}\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Ironic inspector Redfish username to set."},{"line_number":76,"context_line":"inspector_redfish_username: \"{{ ipmi_username }}\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Ironic inspector Redfish password to set."},{"line_number":79,"context_line":"inspector_redfish_password: \"{{ ipmi_password }}\""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"a167e974_501a4834","line":76,"range":{"start_line":76,"start_character":32,"end_line":76,"end_character":45},"updated":"2024-01-31 18:13:56.000000000","message":"redfish_username","commit_id":"96d4c3f2ce70441f1836e58f704bddb5acd85e18"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"d66ac898dd1e4eff70d1d8e3ca2713a7e915d562","unresolved":true,"context_lines":[{"line_number":73,"context_line":"inspector_ipmi_password: \"{{ ipmi_password }}\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Ironic inspector Redfish username to set."},{"line_number":76,"context_line":"inspector_redfish_username: \"{{ ipmi_username }}\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Ironic inspector Redfish password to set."},{"line_number":79,"context_line":"inspector_redfish_password: \"{{ ipmi_password }}\""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"cfb401f9_52514193","line":76,"range":{"start_line":76,"start_character":32,"end_line":76,"end_character":45},"in_reply_to":"170f4866_099123a5","updated":"2024-02-02 14:24:20.000000000","message":"^ditto","commit_id":"96d4c3f2ce70441f1836e58f704bddb5acd85e18"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"8d388748ffc39ccf4bf09c92963b9af8cb17f357","unresolved":true,"context_lines":[{"line_number":73,"context_line":"inspector_ipmi_password: \"{{ ipmi_password }}\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Ironic inspector Redfish username to set."},{"line_number":76,"context_line":"inspector_redfish_username: \"{{ ipmi_username }}\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Ironic inspector Redfish password to set."},{"line_number":79,"context_line":"inspector_redfish_password: \"{{ ipmi_password }}\""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"170f4866_099123a5","line":76,"range":{"start_line":76,"start_character":32,"end_line":76,"end_character":45},"in_reply_to":"a167e974_501a4834","updated":"2024-02-02 12:54:10.000000000","message":"Seem like a reasonable suggestion (in group_vars/all/bmc / bmc.yml). We do have a precedent of using ipmi_\u003cusername/password\u003e as the default for all BMC credentials (regardless of protocol): e.g: https://github.com/openstack/kayobe/blob/691454965fc12108db65479f4dd29ef25ac75fa8/ansible/overcloud-bios-raid.yml#L48. Possibly we could split those out in a separate change?","commit_id":"96d4c3f2ce70441f1836e58f704bddb5acd85e18"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"294a67e63f3a076be13c7eff65a93a25f70e197c","unresolved":false,"context_lines":[{"line_number":73,"context_line":"inspector_ipmi_password: \"{{ ipmi_password }}\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Ironic inspector Redfish username to set."},{"line_number":76,"context_line":"inspector_redfish_username: \"{{ ipmi_username }}\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Ironic inspector Redfish password to set."},{"line_number":79,"context_line":"inspector_redfish_password: \"{{ ipmi_password }}\""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"b9b0b982_3a6a1d4d","line":76,"range":{"start_line":76,"start_character":32,"end_line":76,"end_character":45},"in_reply_to":"cfb401f9_52514193","updated":"2024-02-06 08:44:29.000000000","message":"Closing","commit_id":"96d4c3f2ce70441f1836e58f704bddb5acd85e18"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"90e63b7b6b4642b85b94ae92c006cd64a568942e","unresolved":true,"context_lines":[{"line_number":76,"context_line":"inspector_redfish_username: \"{{ ipmi_username }}\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Ironic inspector Redfish password to set."},{"line_number":79,"context_line":"inspector_redfish_password: \"{{ ipmi_password }}\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# Ironic inspector default network interface name on which to check for an LLDP"},{"line_number":82,"context_line":"# switch port description to use as the node\u0027s name."}],"source_content_type":"application/octet-stream","patch_set":10,"id":"b910c61e_2a9de594","line":79,"range":{"start_line":79,"start_character":32,"end_line":79,"end_character":45},"updated":"2024-01-31 18:13:56.000000000","message":"redfish_password","commit_id":"96d4c3f2ce70441f1836e58f704bddb5acd85e18"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"d66ac898dd1e4eff70d1d8e3ca2713a7e915d562","unresolved":true,"context_lines":[{"line_number":76,"context_line":"inspector_redfish_username: \"{{ ipmi_username }}\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Ironic inspector Redfish password to set."},{"line_number":79,"context_line":"inspector_redfish_password: \"{{ ipmi_password }}\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# Ironic inspector default network interface name on which to check for an LLDP"},{"line_number":82,"context_line":"# switch port description to use as the node\u0027s name."}],"source_content_type":"application/octet-stream","patch_set":10,"id":"ef4702aa_96ae0710","line":79,"range":{"start_line":79,"start_character":32,"end_line":79,"end_character":45},"in_reply_to":"b910c61e_2a9de594","updated":"2024-02-02 14:24:20.000000000","message":"^ditto","commit_id":"96d4c3f2ce70441f1836e58f704bddb5acd85e18"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"294a67e63f3a076be13c7eff65a93a25f70e197c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"inspector_redfish_username: \"{{ ipmi_username }}\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Ironic inspector Redfish password to set."},{"line_number":79,"context_line":"inspector_redfish_password: \"{{ ipmi_password }}\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# Ironic inspector default network interface name on which to check for an LLDP"},{"line_number":82,"context_line":"# switch port description to use as the node\u0027s name."}],"source_content_type":"application/octet-stream","patch_set":10,"id":"6b9095ce_071add56","line":79,"range":{"start_line":79,"start_character":32,"end_line":79,"end_character":45},"in_reply_to":"ef4702aa_96ae0710","updated":"2024-02-06 08:44:29.000000000","message":"Closing","commit_id":"96d4c3f2ce70441f1836e58f704bddb5acd85e18"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2e5a3a0b130010d40e17ce65b0d6843218d12134","unresolved":true,"context_lines":[{"line_number":96,"context_line":"inspector_rule_var_ipmi_password:"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"# Enable Redfish rules"},{"line_number":99,"context_line":"inspector_rules_redfish_enabled: \"True\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"# Redfish username referenced by inspector rule."},{"line_number":102,"context_line":"inspector_rule_var_redfish_username:"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"fb908b38_055b9d2f","line":99,"range":{"start_line":99,"start_character":33,"end_line":99,"end_character":39},"updated":"2024-02-08 15:07:30.000000000","message":"why quotes?","commit_id":"37bfd155855a998582ddb4a7443216e82823e04c"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"824e628460ebe398b91b6d2cdf4c3930693f86d0","unresolved":false,"context_lines":[{"line_number":96,"context_line":"inspector_rule_var_ipmi_password:"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"# Enable Redfish rules"},{"line_number":99,"context_line":"inspector_rules_redfish_enabled: \"True\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"# Redfish username referenced by inspector rule."},{"line_number":102,"context_line":"inspector_rule_var_redfish_username:"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"3d102c30_4b8a15b1","line":99,"range":{"start_line":99,"start_character":33,"end_line":99,"end_character":39},"in_reply_to":"fb908b38_055b9d2f","updated":"2024-02-12 10:41:46.000000000","message":"Done","commit_id":"37bfd155855a998582ddb4a7443216e82823e04c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2e5a3a0b130010d40e17ce65b0d6843218d12134","unresolved":true,"context_lines":[{"line_number":105,"context_line":"inspector_rule_var_redfish_password:"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# Redfish CA setting."},{"line_number":108,"context_line":"inspector_rule_var_redfish_verify_ca: \"False\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# Redfish System ID setting."},{"line_number":111,"context_line":"inspector_rule_var_redfish_system_id: \"/redfish/v1/Systems/System.Embedded.1\""}],"source_content_type":"application/octet-stream","patch_set":12,"id":"a60192a4_5c43e6ec","line":108,"range":{"start_line":108,"start_character":38,"end_line":108,"end_character":45},"updated":"2024-02-08 15:07:30.000000000","message":"why quotes?","commit_id":"37bfd155855a998582ddb4a7443216e82823e04c"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"824e628460ebe398b91b6d2cdf4c3930693f86d0","unresolved":false,"context_lines":[{"line_number":105,"context_line":"inspector_rule_var_redfish_password:"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# Redfish CA setting."},{"line_number":108,"context_line":"inspector_rule_var_redfish_verify_ca: \"False\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# Redfish System ID setting."},{"line_number":111,"context_line":"inspector_rule_var_redfish_system_id: \"/redfish/v1/Systems/System.Embedded.1\""}],"source_content_type":"application/octet-stream","patch_set":12,"id":"50d234ea_eaa0ff2d","line":108,"range":{"start_line":108,"start_character":38,"end_line":108,"end_character":45},"in_reply_to":"a60192a4_5c43e6ec","updated":"2024-02-12 10:41:46.000000000","message":"Done","commit_id":"37bfd155855a998582ddb4a7443216e82823e04c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a9c1f64ed5b68b952046995e3e82fd794074bdf3","unresolved":true,"context_lines":[{"line_number":105,"context_line":"inspector_rule_var_redfish_password:"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# Redfish CA setting."},{"line_number":108,"context_line":"inspector_rule_var_redfish_verify_ca: False"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# Redfish System ID setting."},{"line_number":111,"context_line":"inspector_rule_var_redfish_system_id: \"/redfish/v1/Systems/System.Embedded.1\""}],"source_content_type":"application/octet-stream","patch_set":15,"id":"a866464b_0c3c8c56","line":108,"updated":"2024-03-07 12:44:39.000000000","message":"Is this a good/secure default?","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a9c1f64ed5b68b952046995e3e82fd794074bdf3","unresolved":true,"context_lines":[{"line_number":105,"context_line":"inspector_rule_var_redfish_password:"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# Redfish CA setting."},{"line_number":108,"context_line":"inspector_rule_var_redfish_verify_ca: False"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# Redfish System ID setting."},{"line_number":111,"context_line":"inspector_rule_var_redfish_system_id: \"/redfish/v1/Systems/System.Embedded.1\""}],"source_content_type":"application/octet-stream","patch_set":15,"id":"5b1a43b1_4a5eb894","line":108,"updated":"2024-03-07 12:44:39.000000000","message":"Is this a secure default?","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"537f429723686f7fd5e23d70b3a561cf7a9b9d1e","unresolved":true,"context_lines":[{"line_number":105,"context_line":"inspector_rule_var_redfish_password:"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# Redfish CA setting."},{"line_number":108,"context_line":"inspector_rule_var_redfish_verify_ca: False"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# Redfish System ID setting."},{"line_number":111,"context_line":"inspector_rule_var_redfish_system_id: \"/redfish/v1/Systems/System.Embedded.1\""}],"source_content_type":"application/octet-stream","patch_set":15,"id":"be675d7a_3dcf3061","line":108,"in_reply_to":"50749f1e_282959c3","updated":"2024-03-14 12:00:32.000000000","message":"Not removed in the latest patch","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"4e2c7dcd8b36a4d7ea93184d3431664be3a6ebf1","unresolved":false,"context_lines":[{"line_number":105,"context_line":"inspector_rule_var_redfish_password:"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# Redfish CA setting."},{"line_number":108,"context_line":"inspector_rule_var_redfish_verify_ca: False"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# Redfish System ID setting."},{"line_number":111,"context_line":"inspector_rule_var_redfish_system_id: \"/redfish/v1/Systems/System.Embedded.1\""}],"source_content_type":"application/octet-stream","patch_set":15,"id":"cf5b20f2_58f79cbe","line":108,"in_reply_to":"5399e51c_296137a4","updated":"2024-03-20 11:30:51.000000000","message":"Done","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"9a29c525222bd2e5e1a3bef29feeb80c17879783","unresolved":false,"context_lines":[{"line_number":105,"context_line":"inspector_rule_var_redfish_password:"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# Redfish CA setting."},{"line_number":108,"context_line":"inspector_rule_var_redfish_verify_ca: False"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# Redfish System ID setting."},{"line_number":111,"context_line":"inspector_rule_var_redfish_system_id: \"/redfish/v1/Systems/System.Embedded.1\""}],"source_content_type":"application/octet-stream","patch_set":15,"id":"50749f1e_282959c3","line":108,"in_reply_to":"5b1a43b1_4a5eb894","updated":"2024-03-12 08:10:13.000000000","message":"It\u0027s removed now.","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3c21ed23712f78c42dde9ed8fd71dfdc4d3aabf3","unresolved":true,"context_lines":[{"line_number":105,"context_line":"inspector_rule_var_redfish_password:"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# Redfish CA setting."},{"line_number":108,"context_line":"inspector_rule_var_redfish_verify_ca: False"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# Redfish System ID setting."},{"line_number":111,"context_line":"inspector_rule_var_redfish_system_id: \"/redfish/v1/Systems/System.Embedded.1\""}],"source_content_type":"application/octet-stream","patch_set":15,"id":"5399e51c_296137a4","line":108,"in_reply_to":"a473b970_b88127c7","updated":"2024-03-14 12:26:19.000000000","message":"I think we need to have a configuration variable to be able to disable CA verification - because in most cases the BMC will use self-signed certificate - although we should default to True.","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"9a29c525222bd2e5e1a3bef29feeb80c17879783","unresolved":false,"context_lines":[{"line_number":105,"context_line":"inspector_rule_var_redfish_password:"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# Redfish CA setting."},{"line_number":108,"context_line":"inspector_rule_var_redfish_verify_ca: False"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# Redfish System ID setting."},{"line_number":111,"context_line":"inspector_rule_var_redfish_system_id: \"/redfish/v1/Systems/System.Embedded.1\""}],"source_content_type":"application/octet-stream","patch_set":15,"id":"47cae8cb_53ac4a1c","line":108,"in_reply_to":"a866464b_0c3c8c56","updated":"2024-03-12 08:10:13.000000000","message":"It\u0027s removed now.","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"1a42470295d68afcb22453448449eacfa91f7d6a","unresolved":true,"context_lines":[{"line_number":105,"context_line":"inspector_rule_var_redfish_password:"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# Redfish CA setting."},{"line_number":108,"context_line":"inspector_rule_var_redfish_verify_ca: False"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# Redfish System ID setting."},{"line_number":111,"context_line":"inspector_rule_var_redfish_system_id: \"/redfish/v1/Systems/System.Embedded.1\""}],"source_content_type":"application/octet-stream","patch_set":15,"id":"a473b970_b88127c7","line":108,"in_reply_to":"be675d7a_3dcf3061","updated":"2024-03-14 12:21:36.000000000","message":"What are the criteria for a default to qualify as secure?","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a9c1f64ed5b68b952046995e3e82fd794074bdf3","unresolved":true,"context_lines":[{"line_number":108,"context_line":"inspector_rule_var_redfish_verify_ca: False"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# Redfish System ID setting."},{"line_number":111,"context_line":"inspector_rule_var_redfish_system_id: \"/redfish/v1/Systems/System.Embedded.1\""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"# Ironic inspector rule to set IPMI credentials."},{"line_number":114,"context_line":"inspector_rule_ipmi_credentials:"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"990e2560_f412c63d","line":111,"updated":"2024-03-07 12:44:39.000000000","message":"I\u0027m not sure whether this is a good default. Ironic claims that specifying a system_id is only necessary if the BMC manages multiple systems, which I expect is unusual. If we specify an incorrect system ID then it will prevent it from working.","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"74128ce2b90e72107e61c7fa0c81d930a14289c0","unresolved":true,"context_lines":[{"line_number":108,"context_line":"inspector_rule_var_redfish_verify_ca: False"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# Redfish System ID setting."},{"line_number":111,"context_line":"inspector_rule_var_redfish_system_id: \"/redfish/v1/Systems/System.Embedded.1\""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"# Ironic inspector rule to set IPMI credentials."},{"line_number":114,"context_line":"inspector_rule_ipmi_credentials:"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"ba6054c8_c63f4012","line":111,"in_reply_to":"01e2f239_bc3dee3f","updated":"2024-03-21 14:51:12.000000000","message":"I\u0027ll remove everything related to that then.","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f0bc25abb8ef2245def0f8ad525b434afd740fe5","unresolved":true,"context_lines":[{"line_number":108,"context_line":"inspector_rule_var_redfish_verify_ca: False"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# Redfish System ID setting."},{"line_number":111,"context_line":"inspector_rule_var_redfish_system_id: \"/redfish/v1/Systems/System.Embedded.1\""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"# Ironic inspector rule to set IPMI credentials."},{"line_number":114,"context_line":"inspector_rule_ipmi_credentials:"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"01e2f239_bc3dee3f","line":111,"in_reply_to":"2a3438e6_45c0cba4","updated":"2024-03-20 14:44:14.000000000","message":"I don\u0027t see them providing any benefit.","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d2b0d55b05676a020104bd70dcfec08d85c74dd4","unresolved":true,"context_lines":[{"line_number":108,"context_line":"inspector_rule_var_redfish_verify_ca: False"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# Redfish System ID setting."},{"line_number":111,"context_line":"inspector_rule_var_redfish_system_id: \"/redfish/v1/Systems/System.Embedded.1\""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"# Ironic inspector rule to set IPMI credentials."},{"line_number":114,"context_line":"inspector_rule_ipmi_credentials:"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"fd35742a_099378dd","line":111,"in_reply_to":"53eaa1d2_651a3575","updated":"2024-03-14 11:51:01.000000000","message":"+1 based on the docs I don\u0027t see any benefit in setting a default. If there is only one decision then it should just work with it unset. If there are multiple systems to choose from then I think the user would need to make a decision.","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"f70c906be4f8d8c7bba4acbbc2752c8ac36ea253","unresolved":false,"context_lines":[{"line_number":108,"context_line":"inspector_rule_var_redfish_verify_ca: False"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# Redfish System ID setting."},{"line_number":111,"context_line":"inspector_rule_var_redfish_system_id: \"/redfish/v1/Systems/System.Embedded.1\""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"# Ironic inspector rule to set IPMI credentials."},{"line_number":114,"context_line":"inspector_rule_ipmi_credentials:"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"53eaa1d2_651a3575","line":111,"in_reply_to":"5da76589_d6ac696b","updated":"2024-03-13 10:00:22.000000000","message":"I\u0027ve never tried this but I think Mark was referring to this passage in the docs:\n\n    The canonical path to the ComputerSystem resource\n    that the driver will interact with. It should include the root service, version and the unique resource path to the ComputerSystem. \n    This property is only required if target BMC manages more than one ComputerSystem. \n    Otherwise ironic  will pick the only available ComputerSystem automatically. For example: /redfish/v1/Systems/1.\n\nhttps://docs.openstack.org/ironic/latest/admin/drivers/redfish.html#registering-a-node-with-the-redfish-driver\n\nSo seems like we could leave it unset?","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"9a29c525222bd2e5e1a3bef29feeb80c17879783","unresolved":false,"context_lines":[{"line_number":108,"context_line":"inspector_rule_var_redfish_verify_ca: False"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# Redfish System ID setting."},{"line_number":111,"context_line":"inspector_rule_var_redfish_system_id: \"/redfish/v1/Systems/System.Embedded.1\""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"# Ironic inspector rule to set IPMI credentials."},{"line_number":114,"context_line":"inspector_rule_ipmi_credentials:"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"5da76589_d6ac696b","line":111,"in_reply_to":"990e2560_f412c63d","updated":"2024-03-12 08:10:13.000000000","message":"Good point, it\u0027s assignment vendor based now.","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"a28066551cbd99d3a9cc3f05fe74b53392891395","unresolved":false,"context_lines":[{"line_number":108,"context_line":"inspector_rule_var_redfish_verify_ca: False"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# Redfish System ID setting."},{"line_number":111,"context_line":"inspector_rule_var_redfish_system_id: \"/redfish/v1/Systems/System.Embedded.1\""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"# Ironic inspector rule to set IPMI credentials."},{"line_number":114,"context_line":"inspector_rule_ipmi_credentials:"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"4feb063a_36b9ffc2","line":111,"in_reply_to":"ba6054c8_c63f4012","updated":"2024-03-21 14:59:12.000000000","message":"Acknowledged","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"4e2c7dcd8b36a4d7ea93184d3431664be3a6ebf1","unresolved":true,"context_lines":[{"line_number":108,"context_line":"inspector_rule_var_redfish_verify_ca: False"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# Redfish System ID setting."},{"line_number":111,"context_line":"inspector_rule_var_redfish_system_id: \"/redfish/v1/Systems/System.Embedded.1\""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"# Ironic inspector rule to set IPMI credentials."},{"line_number":114,"context_line":"inspector_rule_ipmi_credentials:"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"2a3438e6_45c0cba4","line":111,"in_reply_to":"fd35742a_099378dd","updated":"2024-03-20 11:30:51.000000000","message":"So the vendor based rules are not ok?","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c1cf8a0dbd9e87cd31cc3b728058a465d8962d18","unresolved":true,"context_lines":[{"line_number":399,"context_line":"inspector_rules_extra: []"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"# List of all ironic inspector rules."},{"line_number":402,"context_line":"inspector_rules: \"{{ inspector_rules_default + inspector_rules_extra + (inspector_rules_redfish if inspector_rules_redfish_enabled | bool else []) }}\""},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"###############################################################################"},{"line_number":405,"context_line":"# Dell switch LLDP workaround configuration."}],"source_content_type":"application/octet-stream","patch_set":15,"id":"c2b18de4_d1506c48","line":402,"updated":"2024-03-05 08:26:32.000000000","message":"So, we enable redfish rules by default, so we get both ipmi and redfish rules at the same time, I don\u0027t know if that\u0027s the desired outcome - but maybe it makes sense if somebody wants to support both.\n\nCan we also get https://github.com/openstack/bifrost/blob/7a6af41a265cb641f5900afe1ab8b8abb31dc2c0/playbooks/roles/bifrost-ironic-install/defaults/main.yml#L262 configurable somewhere in Kayobe, so a user can choose if he wants nodes from discovery enrolled using ipmi or redfish?","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"b5cbc743666c35590e6b9e1b9fd9b12f0efab486","unresolved":false,"context_lines":[{"line_number":399,"context_line":"inspector_rules_extra: []"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"# List of all ironic inspector rules."},{"line_number":402,"context_line":"inspector_rules: \"{{ inspector_rules_default + inspector_rules_extra + (inspector_rules_redfish if inspector_rules_redfish_enabled | bool else []) }}\""},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"###############################################################################"},{"line_number":405,"context_line":"# Dell switch LLDP workaround configuration."}],"source_content_type":"application/octet-stream","patch_set":15,"id":"dd4d630e_1fdb1041","line":402,"in_reply_to":"06ed5999_afcc0294","updated":"2024-03-13 09:09:42.000000000","message":"Done","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6ae59ddad3b3bee0c8df072e20a1b179a34a0ce3","unresolved":true,"context_lines":[{"line_number":399,"context_line":"inspector_rules_extra: []"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"# List of all ironic inspector rules."},{"line_number":402,"context_line":"inspector_rules: \"{{ inspector_rules_default + inspector_rules_extra + (inspector_rules_redfish if inspector_rules_redfish_enabled | bool else []) }}\""},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"###############################################################################"},{"line_number":405,"context_line":"# Dell switch LLDP workaround configuration."}],"source_content_type":"application/octet-stream","patch_set":15,"id":"7d56cacd_d111b692","line":402,"in_reply_to":"629443a3_dc659431","updated":"2024-03-14 11:53:08.000000000","message":"+1 for making it more dynamic in a future patch","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"4e2c7dcd8b36a4d7ea93184d3431664be3a6ebf1","unresolved":false,"context_lines":[{"line_number":399,"context_line":"inspector_rules_extra: []"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"# List of all ironic inspector rules."},{"line_number":402,"context_line":"inspector_rules: \"{{ inspector_rules_default + inspector_rules_extra + (inspector_rules_redfish if inspector_rules_redfish_enabled | bool else []) }}\""},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"###############################################################################"},{"line_number":405,"context_line":"# Dell switch LLDP workaround configuration."}],"source_content_type":"application/octet-stream","patch_set":15,"id":"2a40a23d_326e8d69","line":402,"in_reply_to":"7d56cacd_d111b692","updated":"2024-03-20 11:30:51.000000000","message":"I\u0027ll go with manual for now, +1 for future patch automation of the process.","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"7573d94187a6108f2545710f4de3c9e4930dcdc1","unresolved":true,"context_lines":[{"line_number":399,"context_line":"inspector_rules_extra: []"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"# List of all ironic inspector rules."},{"line_number":402,"context_line":"inspector_rules: \"{{ inspector_rules_default + inspector_rules_extra + (inspector_rules_redfish if inspector_rules_redfish_enabled | bool else []) }}\""},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"###############################################################################"},{"line_number":405,"context_line":"# Dell switch LLDP workaround configuration."}],"source_content_type":"application/octet-stream","patch_set":15,"id":"06ed5999_afcc0294","line":402,"in_reply_to":"9ff5a4ac_a8962b60","updated":"2024-03-13 08:47:21.000000000","message":"I\u0027ve split ipmi away from default rules and added IPMI specific rules which are enabled by default and set Redfish. If someone wants both sets he can just do that.","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a9c1f64ed5b68b952046995e3e82fd794074bdf3","unresolved":true,"context_lines":[{"line_number":399,"context_line":"inspector_rules_extra: []"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"# List of all ironic inspector rules."},{"line_number":402,"context_line":"inspector_rules: \"{{ inspector_rules_default + inspector_rules_extra + (inspector_rules_redfish if inspector_rules_redfish_enabled | bool else []) }}\""},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"###############################################################################"},{"line_number":405,"context_line":"# Dell switch LLDP workaround configuration."}],"source_content_type":"application/octet-stream","patch_set":15,"id":"9ff5a4ac_a8962b60","line":402,"in_reply_to":"c2b18de4_d1506c48","updated":"2024-03-07 12:44:39.000000000","message":"I agree that it\u0027s not ideal to have rules that add both sets of fields. Ideally the rules would be able to detect whether the node is using redfish or IPMI using a condition. If that\u0027s too difficult I\u0027d accept adding a flag for the IPMI rule, with only one (IPMI or redfish) set of rules enabled by default.\n\nre the default enrollment driver, you can configure this via etc/kayobe/kolla/config/bifrost/bifrost.yml","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"f70c906be4f8d8c7bba4acbbc2752c8ac36ea253","unresolved":false,"context_lines":[{"line_number":399,"context_line":"inspector_rules_extra: []"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"# List of all ironic inspector rules."},{"line_number":402,"context_line":"inspector_rules: \"{{ inspector_rules_default + inspector_rules_extra + (inspector_rules_redfish if inspector_rules_redfish_enabled | bool else []) }}\""},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"###############################################################################"},{"line_number":405,"context_line":"# Dell switch LLDP workaround configuration."}],"source_content_type":"application/octet-stream","patch_set":15,"id":"629443a3_dc659431","line":402,"in_reply_to":"dd4d630e_1fdb1041","updated":"2024-03-13 10:00:22.000000000","message":"Can you grab the driver using a property set on the node? I.e a json path that starts with node://. I\u0027m also fine with landing this change with the redfish rules disabled by default i.e no functional change and adding that as an improvement in a future patch.","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"0fc8e3e163f705927b333f569e2da721de8ca65f","unresolved":true,"context_lines":[{"line_number":351,"context_line":"      value: \"{data[inventory][bmc_address]}\""},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"# Ironic inspector rule to set Redfish system ID."},{"line_number":354,"context_line":"inspector_rule_redfish_system_id:"},{"line_number":355,"context_line":"  description: \"Set Redfish system ID\""},{"line_number":356,"context_line":"  conditions:"},{"line_number":357,"context_line":"    - field: \"node://driver_info.redfish_system_id\""},{"line_number":358,"context_line":"      op: \"is-empty\""},{"line_number":359,"context_line":"    - field: \"data://inventory.system_vendor.manufacturer\""},{"line_number":360,"context_line":"      op: \"eq\""},{"line_number":361,"context_line":"      value: \"Dell Inc.\""},{"line_number":362,"context_line":"  actions:"},{"line_number":363,"context_line":"    - action: \"set-attribute\""},{"line_number":364,"context_line":"      path: \"driver_info/redfish_system_id\""},{"line_number":365,"context_line":"      value: \"/redfish/v1/Systems/System.Embedded.1\""},{"line_number":366,"context_line":"  conditions:"},{"line_number":367,"context_line":"    - field: \"node://driver_info.redfish_system_id\""},{"line_number":368,"context_line":"      op: \"is-empty\""},{"line_number":369,"context_line":"    - field: \"data://inventory.system_vendor.manufacturer\""},{"line_number":370,"context_line":"      op: \"eq\""},{"line_number":371,"context_line":"      value: \"HPE\""},{"line_number":372,"context_line":"  actions:"},{"line_number":373,"context_line":"    - action: \"set-attribute\""},{"line_number":374,"context_line":"      path: \"driver_info/redfish_system_id\""},{"line_number":375,"context_line":"      value: \"/redfish/v1/Systems/1\""},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"# Ironic inspector rule to set Redfish certificate authority."},{"line_number":378,"context_line":"inspector_rule_redfish_verify_ca:"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"3c1476a3_a8d8ec77","line":375,"range":{"start_line":354,"start_character":0,"end_line":375,"end_character":36},"updated":"2024-03-11 21:41:50.000000000","message":"You are defining a YAML dictionary with the same keys twice here. The second definition for HPE will override the first one for Dell.","commit_id":"440683f9f98e9f0ebab018dc268c3d6ee5a25e78"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"9a29c525222bd2e5e1a3bef29feeb80c17879783","unresolved":false,"context_lines":[{"line_number":351,"context_line":"      value: \"{data[inventory][bmc_address]}\""},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"# Ironic inspector rule to set Redfish system ID."},{"line_number":354,"context_line":"inspector_rule_redfish_system_id:"},{"line_number":355,"context_line":"  description: \"Set Redfish system ID\""},{"line_number":356,"context_line":"  conditions:"},{"line_number":357,"context_line":"    - field: \"node://driver_info.redfish_system_id\""},{"line_number":358,"context_line":"      op: \"is-empty\""},{"line_number":359,"context_line":"    - field: \"data://inventory.system_vendor.manufacturer\""},{"line_number":360,"context_line":"      op: \"eq\""},{"line_number":361,"context_line":"      value: \"Dell Inc.\""},{"line_number":362,"context_line":"  actions:"},{"line_number":363,"context_line":"    - action: \"set-attribute\""},{"line_number":364,"context_line":"      path: \"driver_info/redfish_system_id\""},{"line_number":365,"context_line":"      value: \"/redfish/v1/Systems/System.Embedded.1\""},{"line_number":366,"context_line":"  conditions:"},{"line_number":367,"context_line":"    - field: \"node://driver_info.redfish_system_id\""},{"line_number":368,"context_line":"      op: \"is-empty\""},{"line_number":369,"context_line":"    - field: \"data://inventory.system_vendor.manufacturer\""},{"line_number":370,"context_line":"      op: \"eq\""},{"line_number":371,"context_line":"      value: \"HPE\""},{"line_number":372,"context_line":"  actions:"},{"line_number":373,"context_line":"    - action: \"set-attribute\""},{"line_number":374,"context_line":"      path: \"driver_info/redfish_system_id\""},{"line_number":375,"context_line":"      value: \"/redfish/v1/Systems/1\""},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"# Ironic inspector rule to set Redfish certificate authority."},{"line_number":378,"context_line":"inspector_rule_redfish_verify_ca:"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"f0d004a5_60859c04","line":375,"range":{"start_line":354,"start_character":0,"end_line":375,"end_character":36},"in_reply_to":"3c1476a3_a8d8ec77","updated":"2024-03-12 08:10:13.000000000","message":"It\u0027s split into 2 separate rules now.","commit_id":"440683f9f98e9f0ebab018dc268c3d6ee5a25e78"}],"ansible/overcloud-introspection-rules.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1c4d7df66ae8b59a7aeb7e844b9c09159bb2348b","unresolved":true,"context_lines":[{"line_number":70,"context_line":"      # These variables may be referenced in the introspection rules."},{"line_number":71,"context_line":"      inspector_rule_var_ipmi_username: \"{{ inspector_ipmi_username }}\""},{"line_number":72,"context_line":"      inspector_rule_var_ipmi_password: \"{{ inspector_ipmi_password }}\""},{"line_number":73,"context_line":"      inspector_rule_var_redfish_username: \"{{ inspector_ipmi_username }}\""},{"line_number":74,"context_line":"      inspector_rule_var_redfish_password: \"{{ inspector_ipmi_password }}\""},{"line_number":75,"context_line":"      inspector_rule_var_lldp_switch_port_interface: \"{{ inspector_lldp_switch_port_interface_default }}\""},{"line_number":76,"context_line":"      inspector_rule_var_deploy_kernel: \"{{ ipa_kernel_id.stdout }}\""},{"line_number":77,"context_line":"      inspector_rule_var_deploy_ramdisk: \"{{ ipa_ramdisk_id.stdout }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"6a1151ae_dc8047f6","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":74},"updated":"2024-01-31 10:13:07.000000000","message":"lets create \u0027inspector_redfish_username\u0027 and \u0027inspector_redfish_password\u0027","commit_id":"0d48eed039454445049430cc2695dfe869723780"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"c4ef6d4da85d3ce4764496c2985386dc6f6c2277","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      # These variables may be referenced in the introspection rules."},{"line_number":71,"context_line":"      inspector_rule_var_ipmi_username: \"{{ inspector_ipmi_username }}\""},{"line_number":72,"context_line":"      inspector_rule_var_ipmi_password: \"{{ inspector_ipmi_password }}\""},{"line_number":73,"context_line":"      inspector_rule_var_redfish_username: \"{{ inspector_ipmi_username }}\""},{"line_number":74,"context_line":"      inspector_rule_var_redfish_password: \"{{ inspector_ipmi_password }}\""},{"line_number":75,"context_line":"      inspector_rule_var_lldp_switch_port_interface: \"{{ inspector_lldp_switch_port_interface_default }}\""},{"line_number":76,"context_line":"      inspector_rule_var_deploy_kernel: \"{{ ipa_kernel_id.stdout }}\""},{"line_number":77,"context_line":"      inspector_rule_var_deploy_ramdisk: \"{{ ipa_ramdisk_id.stdout }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"30ab2489_ff544f6f","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":74},"in_reply_to":"6a1151ae_dc8047f6","updated":"2024-01-31 14:32:36.000000000","message":"Done","commit_id":"0d48eed039454445049430cc2695dfe869723780"}],"ansible/seed-introspection-rules.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"489319c3dc4bd699498d35290f4d9ffb4ed7b39c","unresolved":true,"context_lines":[{"line_number":14,"context_line":"      # These variables may be referenced in the introspection rules."},{"line_number":15,"context_line":"      inspector_rule_var_ipmi_username: \"{{ kolla_bifrost_inspector_ipmi_username }}\""},{"line_number":16,"context_line":"      inspector_rule_var_ipmi_password: \"{{ kolla_bifrost_inspector_ipmi_password }}\""},{"line_number":17,"context_line":"      inspector_rule_var_redfish_username: \"{{ inspector_ipmi_username }}\""},{"line_number":18,"context_line":"      inspector_rule_var_redfish_password: \"{{ inspector_ipmi_password }}\""},{"line_number":19,"context_line":"      inspector_rule_var_lldp_switch_port_interface: \"{{ kolla_bifrost_inspector_lldp_switch_port_interface }}\""},{"line_number":20,"context_line":"      inspector_rule_var_deploy_kernel: \"{{ kolla_bifrost_inspector_deploy_kernel }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e62ca3ac_e1e09093","line":17,"range":{"start_line":17,"start_character":47,"end_line":17,"end_character":70},"updated":"2023-12-07 23:17:46.000000000","message":"kolla_bifrost_inspector_ipmi_username ?","commit_id":"40576194dd95d196e9634e17833d870d012db323"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"b0c22fd8340e224bbe52f0641297d89228ccbf09","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      # These variables may be referenced in the introspection rules."},{"line_number":15,"context_line":"      inspector_rule_var_ipmi_username: \"{{ kolla_bifrost_inspector_ipmi_username }}\""},{"line_number":16,"context_line":"      inspector_rule_var_ipmi_password: \"{{ kolla_bifrost_inspector_ipmi_password }}\""},{"line_number":17,"context_line":"      inspector_rule_var_redfish_username: \"{{ inspector_ipmi_username }}\""},{"line_number":18,"context_line":"      inspector_rule_var_redfish_password: \"{{ inspector_ipmi_password }}\""},{"line_number":19,"context_line":"      inspector_rule_var_lldp_switch_port_interface: \"{{ kolla_bifrost_inspector_lldp_switch_port_interface }}\""},{"line_number":20,"context_line":"      inspector_rule_var_deploy_kernel: \"{{ kolla_bifrost_inspector_deploy_kernel }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a1fe6b08_3dab6768","line":17,"range":{"start_line":17,"start_character":47,"end_line":17,"end_character":70},"in_reply_to":"e62ca3ac_e1e09093","updated":"2023-12-11 12:44:01.000000000","message":"Done","commit_id":"40576194dd95d196e9634e17833d870d012db323"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"489319c3dc4bd699498d35290f4d9ffb4ed7b39c","unresolved":true,"context_lines":[{"line_number":15,"context_line":"      inspector_rule_var_ipmi_username: \"{{ kolla_bifrost_inspector_ipmi_username }}\""},{"line_number":16,"context_line":"      inspector_rule_var_ipmi_password: \"{{ kolla_bifrost_inspector_ipmi_password }}\""},{"line_number":17,"context_line":"      inspector_rule_var_redfish_username: \"{{ inspector_ipmi_username }}\""},{"line_number":18,"context_line":"      inspector_rule_var_redfish_password: \"{{ inspector_ipmi_password }}\""},{"line_number":19,"context_line":"      inspector_rule_var_lldp_switch_port_interface: \"{{ kolla_bifrost_inspector_lldp_switch_port_interface }}\""},{"line_number":20,"context_line":"      inspector_rule_var_deploy_kernel: \"{{ kolla_bifrost_inspector_deploy_kernel }}\""},{"line_number":21,"context_line":"      inspector_rule_var_deploy_ramdisk: \"{{ kolla_bifrost_inspector_deploy_ramdisk }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3305bbe8_28757ebd","line":18,"range":{"start_line":18,"start_character":47,"end_line":18,"end_character":70},"updated":"2023-12-07 23:17:46.000000000","message":"kolla_bifrost_inspector_ipmi_password ?","commit_id":"40576194dd95d196e9634e17833d870d012db323"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"b0c22fd8340e224bbe52f0641297d89228ccbf09","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      inspector_rule_var_ipmi_username: \"{{ kolla_bifrost_inspector_ipmi_username }}\""},{"line_number":16,"context_line":"      inspector_rule_var_ipmi_password: \"{{ kolla_bifrost_inspector_ipmi_password }}\""},{"line_number":17,"context_line":"      inspector_rule_var_redfish_username: \"{{ inspector_ipmi_username }}\""},{"line_number":18,"context_line":"      inspector_rule_var_redfish_password: \"{{ inspector_ipmi_password }}\""},{"line_number":19,"context_line":"      inspector_rule_var_lldp_switch_port_interface: \"{{ kolla_bifrost_inspector_lldp_switch_port_interface }}\""},{"line_number":20,"context_line":"      inspector_rule_var_deploy_kernel: \"{{ kolla_bifrost_inspector_deploy_kernel }}\""},{"line_number":21,"context_line":"      inspector_rule_var_deploy_ramdisk: \"{{ kolla_bifrost_inspector_deploy_ramdisk }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"379d19a7_0ecd1d46","line":18,"range":{"start_line":18,"start_character":47,"end_line":18,"end_character":70},"in_reply_to":"3305bbe8_28757ebd","updated":"2023-12-11 12:44:01.000000000","message":"Done","commit_id":"40576194dd95d196e9634e17833d870d012db323"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1c4d7df66ae8b59a7aeb7e844b9c09159bb2348b","unresolved":true,"context_lines":[{"line_number":14,"context_line":"      # These variables may be referenced in the introspection rules."},{"line_number":15,"context_line":"      inspector_rule_var_ipmi_username: \"{{ kolla_bifrost_inspector_ipmi_username }}\""},{"line_number":16,"context_line":"      inspector_rule_var_ipmi_password: \"{{ kolla_bifrost_inspector_ipmi_password }}\""},{"line_number":17,"context_line":"      inspector_rule_var_redfish_username: \"{{ kolla_bifrost_inspector_ipmi_username }}\""},{"line_number":18,"context_line":"      inspector_rule_var_redfish_password: \"{{ kolla_bifrost_inspector_ipmi_password }}\""},{"line_number":19,"context_line":"      inspector_rule_var_lldp_switch_port_interface: \"{{ kolla_bifrost_inspector_lldp_switch_port_interface }}\""},{"line_number":20,"context_line":"      inspector_rule_var_deploy_kernel: \"{{ kolla_bifrost_inspector_deploy_kernel }}\""},{"line_number":21,"context_line":"      inspector_rule_var_deploy_ramdisk: \"{{ kolla_bifrost_inspector_deploy_ramdisk }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"33703b95_548c750e","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":88},"updated":"2024-01-31 10:13:07.000000000","message":"lets create \u0027kolla_bifrost_inspector_redfish_username\u0027 and \u0027kolla_bifrost_inspector_redish_password\u0027 too","commit_id":"0d48eed039454445049430cc2695dfe869723780"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"c4ef6d4da85d3ce4764496c2985386dc6f6c2277","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      # These variables may be referenced in the introspection rules."},{"line_number":15,"context_line":"      inspector_rule_var_ipmi_username: \"{{ kolla_bifrost_inspector_ipmi_username }}\""},{"line_number":16,"context_line":"      inspector_rule_var_ipmi_password: \"{{ kolla_bifrost_inspector_ipmi_password }}\""},{"line_number":17,"context_line":"      inspector_rule_var_redfish_username: \"{{ kolla_bifrost_inspector_ipmi_username }}\""},{"line_number":18,"context_line":"      inspector_rule_var_redfish_password: \"{{ kolla_bifrost_inspector_ipmi_password }}\""},{"line_number":19,"context_line":"      inspector_rule_var_lldp_switch_port_interface: \"{{ kolla_bifrost_inspector_lldp_switch_port_interface }}\""},{"line_number":20,"context_line":"      inspector_rule_var_deploy_kernel: \"{{ kolla_bifrost_inspector_deploy_kernel }}\""},{"line_number":21,"context_line":"      inspector_rule_var_deploy_ramdisk: \"{{ kolla_bifrost_inspector_deploy_ramdisk }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"b89339e4_bcfd2617","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":88},"in_reply_to":"33703b95_548c750e","updated":"2024-01-31 14:32:36.000000000","message":"Done","commit_id":"0d48eed039454445049430cc2695dfe869723780"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"70583e349bf4881d245758b12ae15f73b62a2a40","unresolved":true,"context_lines":[{"line_number":15,"context_line":"      inspector_rules_ipmi_enabled: \"{{ kolla_bifrost_inspector_rules_ipmi_enabled }}\""},{"line_number":16,"context_line":"      inspector_rule_var_ipmi_username: \"{{ kolla_bifrost_inspector_ipmi_username }}\""},{"line_number":17,"context_line":"      inspector_rule_var_ipmi_password: \"{{ kolla_bifrost_inspector_ipmi_password }}\""},{"line_number":18,"context_line":"      inspector_rules_redfish_enabled: \"{{ kolla_bifrost_inspector_rules_redfish_enabled }}\""},{"line_number":19,"context_line":"      inspector_rule_var_redfish_username: \"{{ kolla_bifrost_inspector_ipmi_username }}\""},{"line_number":20,"context_line":"      inspector_rule_var_redfish_password: \"{{ kolla_bifrost_inspector_ipmi_password }}\""},{"line_number":21,"context_line":"      inspector_rule_var_lldp_switch_port_interface: \"{{ kolla_bifrost_inspector_lldp_switch_port_interface }}\""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"7f081013_adeaf710","line":18,"updated":"2024-03-28 12:14:07.000000000","message":"This will result in a jinja variable loop. That\u0027s what these rule_var variables are for - they provide a layer of indirection","commit_id":"e1b59815a7ba122211a14baf630c1ca90e707c59"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"d0fe60d81e24266d5b7807b1ca4efe957c9c8049","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      inspector_rules_ipmi_enabled: \"{{ kolla_bifrost_inspector_rules_ipmi_enabled }}\""},{"line_number":16,"context_line":"      inspector_rule_var_ipmi_username: \"{{ kolla_bifrost_inspector_ipmi_username }}\""},{"line_number":17,"context_line":"      inspector_rule_var_ipmi_password: \"{{ kolla_bifrost_inspector_ipmi_password }}\""},{"line_number":18,"context_line":"      inspector_rules_redfish_enabled: \"{{ kolla_bifrost_inspector_rules_redfish_enabled }}\""},{"line_number":19,"context_line":"      inspector_rule_var_redfish_username: \"{{ kolla_bifrost_inspector_ipmi_username }}\""},{"line_number":20,"context_line":"      inspector_rule_var_redfish_password: \"{{ kolla_bifrost_inspector_ipmi_password }}\""},{"line_number":21,"context_line":"      inspector_rule_var_lldp_switch_port_interface: \"{{ kolla_bifrost_inspector_lldp_switch_port_interface }}\""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"9232fca8_7d2e3073","line":18,"in_reply_to":"7f081013_adeaf710","updated":"2024-03-29 07:46:36.000000000","message":"Done","commit_id":"e1b59815a7ba122211a14baf630c1ca90e707c59"}],"doc/source/configuration/reference/bifrost.rst":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6ecea86ad93d83527128ed1870d8d648fbbada2b","unresolved":true,"context_lines":[{"line_number":279,"context_line":"    ``${KAYOBE_CONFIG_PATH}/inspector.yml``."},{"line_number":280,"context_line":"``kolla_bifrost_inspector_redfish_username``"},{"line_number":281,"context_line":"    Ironic inspector Redfish username to set via an introspection rule. Default"},{"line_number":282,"context_line":"    is ``{{ inspector_redfish_username }}``, defined in"},{"line_number":283,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":284,"context_line":"``kolla_bifrost_inspector_redfish_password``"},{"line_number":285,"context_line":"    Ironic inspector Redfish username to set via an introspection rule. Default"},{"line_number":286,"context_line":"    is ``{{ inspector_redfish_password }}``, defined in"}],"source_content_type":"text/x-rst","patch_set":15,"id":"d69a774d_fda69a1a","line":283,"range":{"start_line":282,"start_character":45,"end_line":283,"end_character":43},"updated":"2024-03-05 08:10:57.000000000","message":"We don\u0027t normally reference locations that are internal to Kayobe. If we do, they are from kayobe-config, i.e. relative to $KAYOBE_CONFIG_PATH (see example just above).","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"d7eccd025cdfc313b0dcd953eb1abc9486a21c33","unresolved":false,"context_lines":[{"line_number":279,"context_line":"    ``${KAYOBE_CONFIG_PATH}/inspector.yml``."},{"line_number":280,"context_line":"``kolla_bifrost_inspector_redfish_username``"},{"line_number":281,"context_line":"    Ironic inspector Redfish username to set via an introspection rule. Default"},{"line_number":282,"context_line":"    is ``{{ inspector_redfish_username }}``, defined in"},{"line_number":283,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":284,"context_line":"``kolla_bifrost_inspector_redfish_password``"},{"line_number":285,"context_line":"    Ironic inspector Redfish username to set via an introspection rule. Default"},{"line_number":286,"context_line":"    is ``{{ inspector_redfish_password }}``, defined in"}],"source_content_type":"text/x-rst","patch_set":15,"id":"2559cc6c_89dda76a","line":283,"range":{"start_line":282,"start_character":45,"end_line":283,"end_character":43},"in_reply_to":"d69a774d_fda69a1a","updated":"2024-03-06 09:18:44.000000000","message":"Done","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6ecea86ad93d83527128ed1870d8d648fbbada2b","unresolved":true,"context_lines":[{"line_number":283,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":284,"context_line":"``kolla_bifrost_inspector_redfish_password``"},{"line_number":285,"context_line":"    Ironic inspector Redfish username to set via an introspection rule. Default"},{"line_number":286,"context_line":"    is ``{{ inspector_redfish_password }}``, defined in"},{"line_number":287,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":288,"context_line":"``inspector_rules_redfish_enabled``"},{"line_number":289,"context_line":"    Enables Redfish introspection rules. Default is set to ``True`` in"},{"line_number":290,"context_line":"    ``inventory/group_vars/all/inspector``."}],"source_content_type":"text/x-rst","patch_set":15,"id":"2b8558e3_ab655ed7","line":287,"range":{"start_line":286,"start_character":45,"end_line":287,"end_character":43},"updated":"2024-03-05 08:10:57.000000000","message":"Ditto.","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"d7eccd025cdfc313b0dcd953eb1abc9486a21c33","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":284,"context_line":"``kolla_bifrost_inspector_redfish_password``"},{"line_number":285,"context_line":"    Ironic inspector Redfish username to set via an introspection rule. Default"},{"line_number":286,"context_line":"    is ``{{ inspector_redfish_password }}``, defined in"},{"line_number":287,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":288,"context_line":"``inspector_rules_redfish_enabled``"},{"line_number":289,"context_line":"    Enables Redfish introspection rules. Default is set to ``True`` in"},{"line_number":290,"context_line":"    ``inventory/group_vars/all/inspector``."}],"source_content_type":"text/x-rst","patch_set":15,"id":"42360532_4c91eab5","line":287,"range":{"start_line":286,"start_character":45,"end_line":287,"end_character":43},"in_reply_to":"2b8558e3_ab655ed7","updated":"2024-03-06 09:18:44.000000000","message":"Done","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6ecea86ad93d83527128ed1870d8d648fbbada2b","unresolved":true,"context_lines":[{"line_number":286,"context_line":"    is ``{{ inspector_redfish_password }}``, defined in"},{"line_number":287,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":288,"context_line":"``inspector_rules_redfish_enabled``"},{"line_number":289,"context_line":"    Enables Redfish introspection rules. Default is set to ``True`` in"},{"line_number":290,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":291,"context_line":"``inspector_rule_var_redfish_verify_ca``"},{"line_number":292,"context_line":"    Redfish CA setting. Set to \u0027False\u0027 by default in"},{"line_number":293,"context_line":"    ``inventory/group_vars/all/inspector``."}],"source_content_type":"text/x-rst","patch_set":15,"id":"b8900ff2_2d389078","line":290,"range":{"start_line":289,"start_character":68,"end_line":290,"end_character":43},"updated":"2024-03-05 08:10:57.000000000","message":"Ditto.","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"d7eccd025cdfc313b0dcd953eb1abc9486a21c33","unresolved":false,"context_lines":[{"line_number":286,"context_line":"    is ``{{ inspector_redfish_password }}``, defined in"},{"line_number":287,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":288,"context_line":"``inspector_rules_redfish_enabled``"},{"line_number":289,"context_line":"    Enables Redfish introspection rules. Default is set to ``True`` in"},{"line_number":290,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":291,"context_line":"``inspector_rule_var_redfish_verify_ca``"},{"line_number":292,"context_line":"    Redfish CA setting. Set to \u0027False\u0027 by default in"},{"line_number":293,"context_line":"    ``inventory/group_vars/all/inspector``."}],"source_content_type":"text/x-rst","patch_set":15,"id":"88ee1137_0bf60401","line":290,"range":{"start_line":289,"start_character":68,"end_line":290,"end_character":43},"in_reply_to":"b8900ff2_2d389078","updated":"2024-03-06 09:18:44.000000000","message":"Done","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6ecea86ad93d83527128ed1870d8d648fbbada2b","unresolved":true,"context_lines":[{"line_number":289,"context_line":"    Enables Redfish introspection rules. Default is set to ``True`` in"},{"line_number":290,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":291,"context_line":"``inspector_rule_var_redfish_verify_ca``"},{"line_number":292,"context_line":"    Redfish CA setting. Set to \u0027False\u0027 by default in"},{"line_number":293,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":294,"context_line":"``inspector_rule_var_redfish_system_id``"},{"line_number":295,"context_line":"    Redfish System ID setting.  Set to ``/redfish/v1/Systems/System.Embedded.1``"},{"line_number":296,"context_line":"    by default. May differ depending on the vendor."}],"source_content_type":"text/x-rst","patch_set":15,"id":"96cd84b8_b7292ad9","line":293,"range":{"start_line":292,"start_character":42,"end_line":293,"end_character":43},"updated":"2024-03-05 08:10:57.000000000","message":"Ditto.","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"d7eccd025cdfc313b0dcd953eb1abc9486a21c33","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    Enables Redfish introspection rules. Default is set to ``True`` in"},{"line_number":290,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":291,"context_line":"``inspector_rule_var_redfish_verify_ca``"},{"line_number":292,"context_line":"    Redfish CA setting. Set to \u0027False\u0027 by default in"},{"line_number":293,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":294,"context_line":"``inspector_rule_var_redfish_system_id``"},{"line_number":295,"context_line":"    Redfish System ID setting.  Set to ``/redfish/v1/Systems/System.Embedded.1``"},{"line_number":296,"context_line":"    by default. May differ depending on the vendor."}],"source_content_type":"text/x-rst","patch_set":15,"id":"58b46642_2364517f","line":293,"range":{"start_line":292,"start_character":42,"end_line":293,"end_character":43},"in_reply_to":"96cd84b8_b7292ad9","updated":"2024-03-06 09:18:44.000000000","message":"Done","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6ecea86ad93d83527128ed1870d8d648fbbada2b","unresolved":true,"context_lines":[{"line_number":292,"context_line":"    Redfish CA setting. Set to \u0027False\u0027 by default in"},{"line_number":293,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":294,"context_line":"``inspector_rule_var_redfish_system_id``"},{"line_number":295,"context_line":"    Redfish System ID setting.  Set to ``/redfish/v1/Systems/System.Embedded.1``"},{"line_number":296,"context_line":"    by default. May differ depending on the vendor."},{"line_number":297,"context_line":"    Examples:"},{"line_number":298,"context_line":"    DELL: ``/redfish/v1/Systems/System.Embedded.1``"},{"line_number":299,"context_line":"    HPE/Lenovo: ``/redfish/v1/Systems/1``"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"Ironic Python Agent (IPA) configuration"},{"line_number":302,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":15,"id":"f82b13b4_c8064f20","line":299,"range":{"start_line":295,"start_character":0,"end_line":299,"end_character":41},"updated":"2024-03-05 08:10:57.000000000","message":"Could we set it based on a vendor field retrieved in inspection data?","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"d7eccd025cdfc313b0dcd953eb1abc9486a21c33","unresolved":false,"context_lines":[{"line_number":292,"context_line":"    Redfish CA setting. Set to \u0027False\u0027 by default in"},{"line_number":293,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":294,"context_line":"``inspector_rule_var_redfish_system_id``"},{"line_number":295,"context_line":"    Redfish System ID setting.  Set to ``/redfish/v1/Systems/System.Embedded.1``"},{"line_number":296,"context_line":"    by default. May differ depending on the vendor."},{"line_number":297,"context_line":"    Examples:"},{"line_number":298,"context_line":"    DELL: ``/redfish/v1/Systems/System.Embedded.1``"},{"line_number":299,"context_line":"    HPE/Lenovo: ``/redfish/v1/Systems/1``"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"Ironic Python Agent (IPA) configuration"},{"line_number":302,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":15,"id":"88e3efa7_df048347","line":299,"range":{"start_line":295,"start_character":0,"end_line":299,"end_character":41},"in_reply_to":"f82b13b4_c8064f20","updated":"2024-03-06 09:18:44.000000000","message":"Done","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"81cc6799f930eced32dba27e09fb2c59a82444cf","unresolved":true,"context_lines":[{"line_number":280,"context_line":"``kolla_bifrost_inspector_redfish_username``"},{"line_number":281,"context_line":"    Ironic inspector Redfish username to set via an introspection rule. Default"},{"line_number":282,"context_line":"    is ``{{ inspector_redfish_username }}``, defined in"},{"line_number":283,"context_line":"    ``${KAYOBE_CONFIG_PATH}/inventory/group_vars/all/inspector``."},{"line_number":284,"context_line":"``kolla_bifrost_inspector_redfish_password``"},{"line_number":285,"context_line":"    Ironic inspector Redfish username to set via an introspection rule. Default"},{"line_number":286,"context_line":"    is ``{{ inspector_redfish_password }}``, defined in"}],"source_content_type":"text/x-rst","patch_set":20,"id":"ecabd5e5_6d755408","line":283,"updated":"2024-03-13 09:16:26.000000000","message":"not related to Redfish and also incorrect according the multiple-environments. please revert this back.","commit_id":"bafcde83954aa63ed572c699c6df41cdd820d43a"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"deede8ecb6ea7b2b514da6b6fe228cbefc69b2d2","unresolved":false,"context_lines":[{"line_number":280,"context_line":"``kolla_bifrost_inspector_redfish_username``"},{"line_number":281,"context_line":"    Ironic inspector Redfish username to set via an introspection rule. Default"},{"line_number":282,"context_line":"    is ``{{ inspector_redfish_username }}``, defined in"},{"line_number":283,"context_line":"    ``${KAYOBE_CONFIG_PATH}/inventory/group_vars/all/inspector``."},{"line_number":284,"context_line":"``kolla_bifrost_inspector_redfish_password``"},{"line_number":285,"context_line":"    Ironic inspector Redfish username to set via an introspection rule. Default"},{"line_number":286,"context_line":"    is ``{{ inspector_redfish_password }}``, defined in"}],"source_content_type":"text/x-rst","patch_set":20,"id":"153de034_eae1ab5a","line":283,"in_reply_to":"ecabd5e5_6d755408","updated":"2024-03-13 09:30:36.000000000","message":"Done","commit_id":"bafcde83954aa63ed572c699c6df41cdd820d43a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"81cc6799f930eced32dba27e09fb2c59a82444cf","unresolved":true,"context_lines":[{"line_number":284,"context_line":"``kolla_bifrost_inspector_redfish_password``"},{"line_number":285,"context_line":"    Ironic inspector Redfish username to set via an introspection rule. Default"},{"line_number":286,"context_line":"    is ``{{ inspector_redfish_password }}``, defined in"},{"line_number":287,"context_line":"    ``${KAYOBE_CONFIG_PATH}/inventory/group_vars/all/inspector``."},{"line_number":288,"context_line":"``inspector_rules_redfish_enabled``"},{"line_number":289,"context_line":"    Enables Redfish introspection rules. Default is set to ``True`` in"},{"line_number":290,"context_line":"    ``${KAYOBE_CONFIG_PATH}/inventory/group_vars/all/inspector``."}],"source_content_type":"text/x-rst","patch_set":20,"id":"771207ea_d451a420","line":287,"updated":"2024-03-13 09:16:26.000000000","message":"ditto","commit_id":"bafcde83954aa63ed572c699c6df41cdd820d43a"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"deede8ecb6ea7b2b514da6b6fe228cbefc69b2d2","unresolved":false,"context_lines":[{"line_number":284,"context_line":"``kolla_bifrost_inspector_redfish_password``"},{"line_number":285,"context_line":"    Ironic inspector Redfish username to set via an introspection rule. Default"},{"line_number":286,"context_line":"    is ``{{ inspector_redfish_password }}``, defined in"},{"line_number":287,"context_line":"    ``${KAYOBE_CONFIG_PATH}/inventory/group_vars/all/inspector``."},{"line_number":288,"context_line":"``inspector_rules_redfish_enabled``"},{"line_number":289,"context_line":"    Enables Redfish introspection rules. Default is set to ``True`` in"},{"line_number":290,"context_line":"    ``${KAYOBE_CONFIG_PATH}/inventory/group_vars/all/inspector``."}],"source_content_type":"text/x-rst","patch_set":20,"id":"4b31142c_3f25a309","line":287,"in_reply_to":"771207ea_d451a420","updated":"2024-03-13 09:30:36.000000000","message":"Done","commit_id":"bafcde83954aa63ed572c699c6df41cdd820d43a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"81cc6799f930eced32dba27e09fb2c59a82444cf","unresolved":true,"context_lines":[{"line_number":287,"context_line":"    ``${KAYOBE_CONFIG_PATH}/inventory/group_vars/all/inspector``."},{"line_number":288,"context_line":"``inspector_rules_redfish_enabled``"},{"line_number":289,"context_line":"    Enables Redfish introspection rules. Default is set to ``True`` in"},{"line_number":290,"context_line":"    ``${KAYOBE_CONFIG_PATH}/inventory/group_vars/all/inspector``."},{"line_number":291,"context_line":"``inspector_rule_var_redfish_verify_ca``"},{"line_number":292,"context_line":"    Redfish CA setting. Set to \u0027False\u0027 by default in"},{"line_number":293,"context_line":"    ``${KAYOBE_CONFIG_PATH}/inventory/group_vars/all/inspector``."}],"source_content_type":"text/x-rst","patch_set":20,"id":"ec54f94e_3f6d86d8","line":290,"updated":"2024-03-13 09:16:26.000000000","message":"ditto","commit_id":"bafcde83954aa63ed572c699c6df41cdd820d43a"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"deede8ecb6ea7b2b514da6b6fe228cbefc69b2d2","unresolved":false,"context_lines":[{"line_number":287,"context_line":"    ``${KAYOBE_CONFIG_PATH}/inventory/group_vars/all/inspector``."},{"line_number":288,"context_line":"``inspector_rules_redfish_enabled``"},{"line_number":289,"context_line":"    Enables Redfish introspection rules. Default is set to ``True`` in"},{"line_number":290,"context_line":"    ``${KAYOBE_CONFIG_PATH}/inventory/group_vars/all/inspector``."},{"line_number":291,"context_line":"``inspector_rule_var_redfish_verify_ca``"},{"line_number":292,"context_line":"    Redfish CA setting. Set to \u0027False\u0027 by default in"},{"line_number":293,"context_line":"    ``${KAYOBE_CONFIG_PATH}/inventory/group_vars/all/inspector``."}],"source_content_type":"text/x-rst","patch_set":20,"id":"458f30e9_cfafac96","line":290,"in_reply_to":"ec54f94e_3f6d86d8","updated":"2024-03-13 09:30:36.000000000","message":"Done","commit_id":"bafcde83954aa63ed572c699c6df41cdd820d43a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"81cc6799f930eced32dba27e09fb2c59a82444cf","unresolved":true,"context_lines":[{"line_number":290,"context_line":"    ``${KAYOBE_CONFIG_PATH}/inventory/group_vars/all/inspector``."},{"line_number":291,"context_line":"``inspector_rule_var_redfish_verify_ca``"},{"line_number":292,"context_line":"    Redfish CA setting. Set to \u0027False\u0027 by default in"},{"line_number":293,"context_line":"    ``${KAYOBE_CONFIG_PATH}/inventory/group_vars/all/inspector``."},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"Ironic Python Agent (IPA) configuration"},{"line_number":296,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":20,"id":"a391f221_3e2e33c9","line":293,"updated":"2024-03-13 09:16:26.000000000","message":"ditto","commit_id":"bafcde83954aa63ed572c699c6df41cdd820d43a"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"deede8ecb6ea7b2b514da6b6fe228cbefc69b2d2","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    ``${KAYOBE_CONFIG_PATH}/inventory/group_vars/all/inspector``."},{"line_number":291,"context_line":"``inspector_rule_var_redfish_verify_ca``"},{"line_number":292,"context_line":"    Redfish CA setting. Set to \u0027False\u0027 by default in"},{"line_number":293,"context_line":"    ``${KAYOBE_CONFIG_PATH}/inventory/group_vars/all/inspector``."},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"Ironic Python Agent (IPA) configuration"},{"line_number":296,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":20,"id":"2f63b246_4a8462fc","line":293,"in_reply_to":"a391f221_3e2e33c9","updated":"2024-03-13 09:30:36.000000000","message":"Done","commit_id":"bafcde83954aa63ed572c699c6df41cdd820d43a"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"f70c906be4f8d8c7bba4acbbc2752c8ac36ea253","unresolved":true,"context_lines":[{"line_number":280,"context_line":"``kolla_bifrost_inspector_redfish_username``"},{"line_number":281,"context_line":"    Ironic inspector Redfish username to set via an introspection rule. Default"},{"line_number":282,"context_line":"    is ``{{ inspector_redfish_username }}``, defined in"},{"line_number":283,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":284,"context_line":"``kolla_bifrost_inspector_redfish_password``"},{"line_number":285,"context_line":"    Ironic inspector Redfish username to set via an introspection rule. Default"},{"line_number":286,"context_line":"    is ``{{ inspector_redfish_password }}``, defined in"}],"source_content_type":"text/x-rst","patch_set":21,"id":"7885db8a_66fecc12","line":283,"range":{"start_line":283,"start_character":6,"end_line":283,"end_character":40},"updated":"2024-03-13 10:00:22.000000000","message":"Shouldn\u0027t these be ``${KAYOBE_CONFIG_PATH}/inspector.yml`` like the one above? Then they are still correct when using multiple environments.","commit_id":"d0b39080e45b6361fbd0727ada645e762d7b2449"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"4e2c7dcd8b36a4d7ea93184d3431664be3a6ebf1","unresolved":false,"context_lines":[{"line_number":280,"context_line":"``kolla_bifrost_inspector_redfish_username``"},{"line_number":281,"context_line":"    Ironic inspector Redfish username to set via an introspection rule. Default"},{"line_number":282,"context_line":"    is ``{{ inspector_redfish_username }}``, defined in"},{"line_number":283,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":284,"context_line":"``kolla_bifrost_inspector_redfish_password``"},{"line_number":285,"context_line":"    Ironic inspector Redfish username to set via an introspection rule. Default"},{"line_number":286,"context_line":"    is ``{{ inspector_redfish_password }}``, defined in"}],"source_content_type":"text/x-rst","patch_set":21,"id":"3ecbf86e_7f1b30c7","line":283,"range":{"start_line":283,"start_character":6,"end_line":283,"end_character":40},"in_reply_to":"374bfb87_7d2625bc","updated":"2024-03-20 11:30:51.000000000","message":"Done","commit_id":"d0b39080e45b6361fbd0727ada645e762d7b2449"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b537868547f427b3ca41aafb05d383095746fa65","unresolved":false,"context_lines":[{"line_number":280,"context_line":"``kolla_bifrost_inspector_redfish_username``"},{"line_number":281,"context_line":"    Ironic inspector Redfish username to set via an introspection rule. Default"},{"line_number":282,"context_line":"    is ``{{ inspector_redfish_username }}``, defined in"},{"line_number":283,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":284,"context_line":"``kolla_bifrost_inspector_redfish_password``"},{"line_number":285,"context_line":"    Ironic inspector Redfish username to set via an introspection rule. Default"},{"line_number":286,"context_line":"    is ``{{ inspector_redfish_password }}``, defined in"}],"source_content_type":"text/x-rst","patch_set":21,"id":"9ac5837d_85027062","line":283,"range":{"start_line":283,"start_character":6,"end_line":283,"end_character":40},"in_reply_to":"7885db8a_66fecc12","updated":"2024-03-13 11:00:49.000000000","message":"no, because it nested like $KAYOBE_CONFIG_PATH/environments/ENVxxxx/...\nread: https://docs.openstack.org/kayobe/latest/multiple-environments.html","commit_id":"d0b39080e45b6361fbd0727ada645e762d7b2449"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"537f429723686f7fd5e23d70b3a561cf7a9b9d1e","unresolved":true,"context_lines":[{"line_number":280,"context_line":"``kolla_bifrost_inspector_redfish_username``"},{"line_number":281,"context_line":"    Ironic inspector Redfish username to set via an introspection rule. Default"},{"line_number":282,"context_line":"    is ``{{ inspector_redfish_username }}``, defined in"},{"line_number":283,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":284,"context_line":"``kolla_bifrost_inspector_redfish_password``"},{"line_number":285,"context_line":"    Ironic inspector Redfish username to set via an introspection rule. Default"},{"line_number":286,"context_line":"    is ``{{ inspector_redfish_password }}``, defined in"}],"source_content_type":"text/x-rst","patch_set":21,"id":"374bfb87_7d2625bc","line":283,"range":{"start_line":283,"start_character":6,"end_line":283,"end_character":40},"in_reply_to":"9ac5837d_85027062","updated":"2024-03-14 12:00:32.000000000","message":"Will is almost correct, users should modify extra vars rather than group_vars. But it should be bifrost.yml","commit_id":"d0b39080e45b6361fbd0727ada645e762d7b2449"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"537f429723686f7fd5e23d70b3a561cf7a9b9d1e","unresolved":true,"context_lines":[{"line_number":285,"context_line":"    Ironic inspector Redfish username to set via an introspection rule. Default"},{"line_number":286,"context_line":"    is ``{{ inspector_redfish_password }}``, defined in"},{"line_number":287,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":288,"context_line":"``inspector_rules_redfish_enabled``"},{"line_number":289,"context_line":"    Enables Redfish introspection rules. Default is set to ``True`` in"},{"line_number":290,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":291,"context_line":"``inspector_rule_var_redfish_verify_ca``"}],"source_content_type":"text/x-rst","patch_set":21,"id":"6fa822b3_f1c0e935","line":288,"updated":"2024-03-14 12:00:32.000000000","message":"Also mention the IPMI flag.","commit_id":"d0b39080e45b6361fbd0727ada645e762d7b2449"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"4e2c7dcd8b36a4d7ea93184d3431664be3a6ebf1","unresolved":false,"context_lines":[{"line_number":285,"context_line":"    Ironic inspector Redfish username to set via an introspection rule. Default"},{"line_number":286,"context_line":"    is ``{{ inspector_redfish_password }}``, defined in"},{"line_number":287,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":288,"context_line":"``inspector_rules_redfish_enabled``"},{"line_number":289,"context_line":"    Enables Redfish introspection rules. Default is set to ``True`` in"},{"line_number":290,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":291,"context_line":"``inspector_rule_var_redfish_verify_ca``"}],"source_content_type":"text/x-rst","patch_set":21,"id":"f2e770d1_d0765e14","line":288,"in_reply_to":"6fa822b3_f1c0e935","updated":"2024-03-20 11:30:51.000000000","message":"Done","commit_id":"d0b39080e45b6361fbd0727ada645e762d7b2449"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"537f429723686f7fd5e23d70b3a561cf7a9b9d1e","unresolved":true,"context_lines":[{"line_number":286,"context_line":"    is ``{{ inspector_redfish_password }}``, defined in"},{"line_number":287,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":288,"context_line":"``inspector_rules_redfish_enabled``"},{"line_number":289,"context_line":"    Enables Redfish introspection rules. Default is set to ``True`` in"},{"line_number":290,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":291,"context_line":"``inspector_rule_var_redfish_verify_ca``"},{"line_number":292,"context_line":"    Redfish CA setting. Set to \u0027False\u0027 by default in"}],"source_content_type":"text/x-rst","patch_set":21,"id":"6cb10c94_44b62585","line":289,"updated":"2024-03-14 12:00:32.000000000","message":"Default is False","commit_id":"d0b39080e45b6361fbd0727ada645e762d7b2449"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"4e2c7dcd8b36a4d7ea93184d3431664be3a6ebf1","unresolved":false,"context_lines":[{"line_number":286,"context_line":"    is ``{{ inspector_redfish_password }}``, defined in"},{"line_number":287,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":288,"context_line":"``inspector_rules_redfish_enabled``"},{"line_number":289,"context_line":"    Enables Redfish introspection rules. Default is set to ``True`` in"},{"line_number":290,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":291,"context_line":"``inspector_rule_var_redfish_verify_ca``"},{"line_number":292,"context_line":"    Redfish CA setting. Set to \u0027False\u0027 by default in"}],"source_content_type":"text/x-rst","patch_set":21,"id":"3cffdfe8_2c2df46f","line":289,"in_reply_to":"6cb10c94_44b62585","updated":"2024-03-20 11:30:51.000000000","message":"Done","commit_id":"d0b39080e45b6361fbd0727ada645e762d7b2449"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f0bc25abb8ef2245def0f8ad525b434afd740fe5","unresolved":true,"context_lines":[{"line_number":287,"context_line":"    ``{{ inspector_redfish_username }}``."},{"line_number":288,"context_line":"``inspector_rules_redfish_enabled``"},{"line_number":289,"context_line":"    Enables Redfish introspection rules. Default is set to ``False`` in"},{"line_number":290,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":291,"context_line":"``inspector_rule_var_redfish_verify_ca``"},{"line_number":292,"context_line":"    Redfish CA setting. Set to \u0027True\u0027 by default in"},{"line_number":293,"context_line":"    ``inventory/group_vars/all/inspector``."}],"source_content_type":"text/x-rst","patch_set":22,"id":"14421fe3_18458d0c","line":290,"range":{"start_line":290,"start_character":1,"end_line":290,"end_character":43},"updated":"2024-03-20 14:44:14.000000000","message":"Wrong file","commit_id":"f23ff547143a2bdfa65297f8a272e1b20560dcda"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"a28066551cbd99d3a9cc3f05fe74b53392891395","unresolved":false,"context_lines":[{"line_number":287,"context_line":"    ``{{ inspector_redfish_username }}``."},{"line_number":288,"context_line":"``inspector_rules_redfish_enabled``"},{"line_number":289,"context_line":"    Enables Redfish introspection rules. Default is set to ``False`` in"},{"line_number":290,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":291,"context_line":"``inspector_rule_var_redfish_verify_ca``"},{"line_number":292,"context_line":"    Redfish CA setting. Set to \u0027True\u0027 by default in"},{"line_number":293,"context_line":"    ``inventory/group_vars/all/inspector``."}],"source_content_type":"text/x-rst","patch_set":22,"id":"ffa55e48_a4958c39","line":290,"range":{"start_line":290,"start_character":1,"end_line":290,"end_character":43},"in_reply_to":"14421fe3_18458d0c","updated":"2024-03-21 14:59:12.000000000","message":"Done","commit_id":"f23ff547143a2bdfa65297f8a272e1b20560dcda"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f0bc25abb8ef2245def0f8ad525b434afd740fe5","unresolved":true,"context_lines":[{"line_number":290,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":291,"context_line":"``inspector_rule_var_redfish_verify_ca``"},{"line_number":292,"context_line":"    Redfish CA setting. Set to \u0027True\u0027 by default in"},{"line_number":293,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":294,"context_line":"``inspector_rules_ipmi_enabled``"},{"line_number":295,"context_line":"    Enables IPMI introspection rules. Default is set to ``True`` in"},{"line_number":296,"context_line":"    ``inventory/group_vars/all/inspector``."}],"source_content_type":"text/x-rst","patch_set":22,"id":"1c06d1c2_524624c7","line":293,"updated":"2024-03-20 14:44:14.000000000","message":"Wrong file","commit_id":"f23ff547143a2bdfa65297f8a272e1b20560dcda"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"a28066551cbd99d3a9cc3f05fe74b53392891395","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":291,"context_line":"``inspector_rule_var_redfish_verify_ca``"},{"line_number":292,"context_line":"    Redfish CA setting. Set to \u0027True\u0027 by default in"},{"line_number":293,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":294,"context_line":"``inspector_rules_ipmi_enabled``"},{"line_number":295,"context_line":"    Enables IPMI introspection rules. Default is set to ``True`` in"},{"line_number":296,"context_line":"    ``inventory/group_vars/all/inspector``."}],"source_content_type":"text/x-rst","patch_set":22,"id":"5bffc6b2_d27302b7","line":293,"in_reply_to":"1c06d1c2_524624c7","updated":"2024-03-21 14:59:12.000000000","message":"Done","commit_id":"f23ff547143a2bdfa65297f8a272e1b20560dcda"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f0bc25abb8ef2245def0f8ad525b434afd740fe5","unresolved":true,"context_lines":[{"line_number":293,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":294,"context_line":"``inspector_rules_ipmi_enabled``"},{"line_number":295,"context_line":"    Enables IPMI introspection rules. Default is set to ``True`` in"},{"line_number":296,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"Ironic Python Agent (IPA) configuration"},{"line_number":299,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":22,"id":"dc2e54ff_5ee6bb1d","line":296,"updated":"2024-03-20 14:44:14.000000000","message":"Wrong file","commit_id":"f23ff547143a2bdfa65297f8a272e1b20560dcda"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"a28066551cbd99d3a9cc3f05fe74b53392891395","unresolved":false,"context_lines":[{"line_number":293,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":294,"context_line":"``inspector_rules_ipmi_enabled``"},{"line_number":295,"context_line":"    Enables IPMI introspection rules. Default is set to ``True`` in"},{"line_number":296,"context_line":"    ``inventory/group_vars/all/inspector``."},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"Ironic Python Agent (IPA) configuration"},{"line_number":299,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":22,"id":"0185fae0_63ed3e2e","line":296,"in_reply_to":"dc2e54ff_5ee6bb1d","updated":"2024-03-21 14:59:12.000000000","message":"Done","commit_id":"f23ff547143a2bdfa65297f8a272e1b20560dcda"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"f2fe10cd671d4dbc04b5d8b410ec42227111575d","unresolved":true,"context_lines":[{"line_number":285,"context_line":"    Ironic inspector Redfish username to set via an introspection rule."},{"line_number":286,"context_line":"    Defined in ``${KAYOBE_CONFIG_PATH}/bifrost.yml``. Default is"},{"line_number":287,"context_line":"    ``{{ inspector_redfish_username }}``."},{"line_number":288,"context_line":"``kolla_bifrost_inspector_rules_redfish_enabled``"},{"line_number":289,"context_line":"    Enables Redfish introspection rules. Defined in"},{"line_number":290,"context_line":"    ``${KAYOBE_CONFIG_PATH}/bifrost.yml``. Default is"},{"line_number":291,"context_line":"    ``{{ inspector_rules_redfish_enabled }}``."}],"source_content_type":"text/x-rst","patch_set":24,"id":"fa1c4c2e_014a1da4","line":288,"updated":"2024-03-27 15:01:11.000000000","message":"I can\u0027t see this one being used. Don\u0027t we want to pass all these through here:\n\nhttps://review.opendev.org/c/openstack/kayobe/+/902772/24/ansible/seed-introspection-rules.yml#17\n\nI guess you could also do the same for the ones you removed in the last patch?","commit_id":"cc656e7e42e5e078da850d3b40e61058b4481b85"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"d0fe60d81e24266d5b7807b1ca4efe957c9c8049","unresolved":false,"context_lines":[{"line_number":285,"context_line":"    Ironic inspector Redfish username to set via an introspection rule."},{"line_number":286,"context_line":"    Defined in ``${KAYOBE_CONFIG_PATH}/bifrost.yml``. Default is"},{"line_number":287,"context_line":"    ``{{ inspector_redfish_username }}``."},{"line_number":288,"context_line":"``kolla_bifrost_inspector_rules_redfish_enabled``"},{"line_number":289,"context_line":"    Enables Redfish introspection rules. Defined in"},{"line_number":290,"context_line":"    ``${KAYOBE_CONFIG_PATH}/bifrost.yml``. Default is"},{"line_number":291,"context_line":"    ``{{ inspector_rules_redfish_enabled }}``."}],"source_content_type":"text/x-rst","patch_set":24,"id":"45a6c9aa_e8a60a02","line":288,"in_reply_to":"fa1c4c2e_014a1da4","updated":"2024-03-29 07:46:36.000000000","message":"Done","commit_id":"cc656e7e42e5e078da850d3b40e61058b4481b85"}],"etc/kayobe/bifrost.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"278b98fefe0365795acac57393d01c37345096c3","unresolved":true,"context_lines":[{"line_number":116,"context_line":"# {{ inspector_rules_redfish_enabled }}."},{"line_number":117,"context_line":"#kolla_bifrost_inspector_rules_redfish_enabled:"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"# Ironic inspector Redfish username to set."},{"line_number":120,"context_line":"#kolla_bifrost_inspector_redfish_username:"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# Ironic inspector Redfish password to set."},{"line_number":123,"context_line":"#kolla_bifrost_inspector_redfish_password:"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"# Redfish CA setting. Default is {{ inspector_rule_var_redfish_verify_ca }}."},{"line_number":126,"context_line":"#kolla_bifrost_inspector_rule_var_redfish_verify_ca:"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"5ccd3351_bd24faea","line":124,"range":{"start_line":119,"start_character":0,"end_line":124,"end_character":1},"updated":"2024-04-02 10:58:38.000000000","message":"Only these two should be present","commit_id":"c78ec0b4ef87dc8fb892782924bc42652202522c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c870bf02cb33ea73636cae328a9253d4fa9ce5bf","unresolved":false,"context_lines":[{"line_number":116,"context_line":"# {{ inspector_rules_redfish_enabled }}."},{"line_number":117,"context_line":"#kolla_bifrost_inspector_rules_redfish_enabled:"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"# Ironic inspector Redfish username to set."},{"line_number":120,"context_line":"#kolla_bifrost_inspector_redfish_username:"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# Ironic inspector Redfish password to set."},{"line_number":123,"context_line":"#kolla_bifrost_inspector_redfish_password:"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"# Redfish CA setting. Default is {{ inspector_rule_var_redfish_verify_ca }}."},{"line_number":126,"context_line":"#kolla_bifrost_inspector_rule_var_redfish_verify_ca:"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"0acdd30c_34276dcb","line":124,"range":{"start_line":119,"start_character":0,"end_line":124,"end_character":1},"in_reply_to":"5ccd3351_bd24faea","updated":"2024-04-03 09:29:40.000000000","message":"Done","commit_id":"c78ec0b4ef87dc8fb892782924bc42652202522c"}],"etc/kayobe/inspector.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"680ebfaac6d8f76f5aef9605dc66e8862704d57f","unresolved":true,"context_lines":[{"line_number":75,"context_line":"# Enable inspector Redfish rules"},{"line_number":76,"context_line":"#inspector_rules_redfish_enabled:"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Ironic inspector Redfish username to set."},{"line_number":79,"context_line":"#inspector_redfish_username:"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# Ironic inspector Redfish password to set."},{"line_number":82,"context_line":"#inspector_redfish_password:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"# Redfish username referenced by inspector rule."},{"line_number":85,"context_line":"#inspector_rule_var_redfish_username:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"51ca9c92_b79b02e3","line":82,"range":{"start_line":78,"start_character":0,"end_line":82,"end_character":28},"updated":"2024-01-31 11:33:30.000000000","message":"lets move this to the correct place:\n- etc/kayobe/inspector.yml\n- ansible/inventory/group_vars/all/inspector","commit_id":"df16e86eab784e9d4b0c4cd206df451d3c575eb6"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"c4ef6d4da85d3ce4764496c2985386dc6f6c2277","unresolved":false,"context_lines":[{"line_number":75,"context_line":"# Enable inspector Redfish rules"},{"line_number":76,"context_line":"#inspector_rules_redfish_enabled:"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Ironic inspector Redfish username to set."},{"line_number":79,"context_line":"#inspector_redfish_username:"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# Ironic inspector Redfish password to set."},{"line_number":82,"context_line":"#inspector_redfish_password:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"# Redfish username referenced by inspector rule."},{"line_number":85,"context_line":"#inspector_rule_var_redfish_username:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"967a7071_70069f22","line":82,"range":{"start_line":78,"start_character":0,"end_line":82,"end_character":28},"in_reply_to":"51ca9c92_b79b02e3","updated":"2024-01-31 14:32:36.000000000","message":"Done","commit_id":"df16e86eab784e9d4b0c4cd206df451d3c575eb6"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6ecea86ad93d83527128ed1870d8d648fbbada2b","unresolved":true,"context_lines":[{"line_number":72,"context_line":"# check for an LLDP switch port description to use as the node\u0027s name."},{"line_number":73,"context_line":"#inspector_lldp_switch_port_interface_map:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Ironic inspector uses IPMI by default enroll the baremetal nodes, however it is"},{"line_number":76,"context_line":"# possible to use Redfish instead, to do that enable Redfish and make sure all"},{"line_number":77,"context_line":"# of the necessary variables below have been properly set."},{"line_number":78,"context_line":"# Enable inspector Redfish rules"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"870fed43_ffa53b4f","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":81},"updated":"2024-03-05 08:10:57.000000000","message":"Line is too long.","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"d7eccd025cdfc313b0dcd953eb1abc9486a21c33","unresolved":false,"context_lines":[{"line_number":72,"context_line":"# check for an LLDP switch port description to use as the node\u0027s name."},{"line_number":73,"context_line":"#inspector_lldp_switch_port_interface_map:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Ironic inspector uses IPMI by default enroll the baremetal nodes, however it is"},{"line_number":76,"context_line":"# possible to use Redfish instead, to do that enable Redfish and make sure all"},{"line_number":77,"context_line":"# of the necessary variables below have been properly set."},{"line_number":78,"context_line":"# Enable inspector Redfish rules"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"64e8f6ae_9923c72a","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":81},"in_reply_to":"870fed43_ffa53b4f","updated":"2024-03-06 09:18:44.000000000","message":"Done","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6ecea86ad93d83527128ed1870d8d648fbbada2b","unresolved":true,"context_lines":[{"line_number":73,"context_line":"#inspector_lldp_switch_port_interface_map:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Ironic inspector uses IPMI by default enroll the baremetal nodes, however it is"},{"line_number":76,"context_line":"# possible to use Redfish instead, to do that enable Redfish and make sure all"},{"line_number":77,"context_line":"# of the necessary variables below have been properly set."},{"line_number":78,"context_line":"# Enable inspector Redfish rules"},{"line_number":79,"context_line":"#inspector_rules_redfish_enabled:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"cf11d2bf_cc8cef46","line":76,"range":{"start_line":76,"start_character":33,"end_line":76,"end_character":34},"updated":"2024-03-05 08:10:57.000000000","message":"You could break your sentence here.","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"d7eccd025cdfc313b0dcd953eb1abc9486a21c33","unresolved":false,"context_lines":[{"line_number":73,"context_line":"#inspector_lldp_switch_port_interface_map:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Ironic inspector uses IPMI by default enroll the baremetal nodes, however it is"},{"line_number":76,"context_line":"# possible to use Redfish instead, to do that enable Redfish and make sure all"},{"line_number":77,"context_line":"# of the necessary variables below have been properly set."},{"line_number":78,"context_line":"# Enable inspector Redfish rules"},{"line_number":79,"context_line":"#inspector_rules_redfish_enabled:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5e8da0d7_be032211","line":76,"range":{"start_line":76,"start_character":33,"end_line":76,"end_character":34},"in_reply_to":"cf11d2bf_cc8cef46","updated":"2024-03-06 09:18:44.000000000","message":"Done","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"278b98fefe0365795acac57393d01c37345096c3","unresolved":true,"context_lines":[{"line_number":87,"context_line":"# Ironic inspector Redfish password to set."},{"line_number":88,"context_line":"#inspector_redfish_password:"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# Redfish username referenced by inspector rule."},{"line_number":91,"context_line":"#inspector_rule_var_redfish_username:"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# Redfish password referenced by inspector rule."},{"line_number":94,"context_line":"#inspector_rule_var_redfish_password:"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"# Redfish CA setting. Set to \u0027True\u0027 by default"},{"line_number":97,"context_line":"#inspector_rule_var_redfish_verify_ca:"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"5224b0d1_24514d81","line":95,"range":{"start_line":90,"start_character":0,"end_line":95,"end_character":1},"updated":"2024-04-02 10:58:38.000000000","message":"These two should be removed","commit_id":"c78ec0b4ef87dc8fb892782924bc42652202522c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c870bf02cb33ea73636cae328a9253d4fa9ce5bf","unresolved":false,"context_lines":[{"line_number":87,"context_line":"# Ironic inspector Redfish password to set."},{"line_number":88,"context_line":"#inspector_redfish_password:"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# Redfish username referenced by inspector rule."},{"line_number":91,"context_line":"#inspector_rule_var_redfish_username:"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# Redfish password referenced by inspector rule."},{"line_number":94,"context_line":"#inspector_rule_var_redfish_password:"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"# Redfish CA setting. Set to \u0027True\u0027 by default"},{"line_number":97,"context_line":"#inspector_rule_var_redfish_verify_ca:"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"1f18bed9_4c71150d","line":95,"range":{"start_line":90,"start_character":0,"end_line":95,"end_character":1},"in_reply_to":"5224b0d1_24514d81","updated":"2024-04-03 09:29:40.000000000","message":"Done","commit_id":"c78ec0b4ef87dc8fb892782924bc42652202522c"}],"releasenotes/notes/redfish_rules-956ca7498f5f13b4.yaml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1c4d7df66ae8b59a7aeb7e844b9c09159bb2348b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fecd6e9d_042bcd76","line":6,"updated":"2024-01-31 10:13:07.000000000","message":"mention at least 3 new variables here, enable switch, redfish username and password.","commit_id":"0d48eed039454445049430cc2695dfe869723780"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"d66ac898dd1e4eff70d1d8e3ca2713a7e915d562","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"80ecfc45_20d45172","line":6,"in_reply_to":"326046c1_2b90cbe5","updated":"2024-02-02 14:24:20.000000000","message":"Done","commit_id":"0d48eed039454445049430cc2695dfe869723780"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"8d388748ffc39ccf4bf09c92963b9af8cb17f357","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"326046c1_2b90cbe5","line":6,"in_reply_to":"6488fc07_f76ef7c4","updated":"2024-02-02 12:54:10.000000000","message":"Agreed, or add a section to the docs on redfish support.","commit_id":"0d48eed039454445049430cc2695dfe869723780"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"90e63b7b6b4642b85b94ae92c006cd64a568942e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6488fc07_f76ef7c4","line":6,"in_reply_to":"c9db1adb_a268ae08","updated":"2024-01-31 18:13:56.000000000","message":"its better to mention all the new variable names, don\u0027t forget backquotes to make them bold","commit_id":"0d48eed039454445049430cc2695dfe869723780"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"c4ef6d4da85d3ce4764496c2985386dc6f6c2277","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c9db1adb_a268ae08","line":6,"in_reply_to":"fecd6e9d_042bcd76","updated":"2024-01-31 14:32:36.000000000","message":"Done","commit_id":"0d48eed039454445049430cc2695dfe869723780"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c618099266f77d66294700bf2e89eedbe942ae67","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"faf18203_29740525","line":10,"updated":"2024-02-02 15:51:24.000000000","message":"forgot to mention switch \u0027inspector_rules_redfish_enabled\u0027 here","commit_id":"3a04debd7c61a346a572379adac2622729f10e17"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"5b43df78e1fd14f8d5d8087c87d7d4f256a78503","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f3cf7bc5_0213111a","line":10,"in_reply_to":"faf18203_29740525","updated":"2024-02-05 06:43:08.000000000","message":"Done","commit_id":"3a04debd7c61a346a572379adac2622729f10e17"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6ecea86ad93d83527128ed1870d8d648fbbada2b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added new Redfish rules to Ironic and Bifrost introspection giving"},{"line_number":5,"context_line":"    users the ability to enable Redfish rules to set:"},{"line_number":6,"context_line":"    * ``inspector_rules_redfish_enabled``"},{"line_number":7,"context_line":"    * ``inspector_redfish_username``"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7e118868_c250667d","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":9},"updated":"2024-03-05 08:10:57.000000000","message":"Nit: Adds","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"d7eccd025cdfc313b0dcd953eb1abc9486a21c33","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added new Redfish rules to Ironic and Bifrost introspection giving"},{"line_number":5,"context_line":"    users the ability to enable Redfish rules to set:"},{"line_number":6,"context_line":"    * ``inspector_rules_redfish_enabled``"},{"line_number":7,"context_line":"    * ``inspector_redfish_username``"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"96929f5c_c56fa565","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":9},"in_reply_to":"7e118868_c250667d","updated":"2024-03-06 09:18:44.000000000","message":"Done","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6ecea86ad93d83527128ed1870d8d648fbbada2b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added new Redfish rules to Ironic and Bifrost introspection giving"},{"line_number":5,"context_line":"    users the ability to enable Redfish rules to set:"},{"line_number":6,"context_line":"    * ``inspector_rules_redfish_enabled``"},{"line_number":7,"context_line":"    * ``inspector_redfish_username``"},{"line_number":8,"context_line":"    * ``inspector_redfish_password``"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"14e4e4e8_b1cdb1e2","line":5,"range":{"start_line":4,"start_character":10,"end_line":5,"end_character":52},"updated":"2024-03-05 08:10:57.000000000","message":"This sentence reads strangely, can you rephrase?","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"d7eccd025cdfc313b0dcd953eb1abc9486a21c33","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added new Redfish rules to Ironic and Bifrost introspection giving"},{"line_number":5,"context_line":"    users the ability to enable Redfish rules to set:"},{"line_number":6,"context_line":"    * ``inspector_rules_redfish_enabled``"},{"line_number":7,"context_line":"    * ``inspector_redfish_username``"},{"line_number":8,"context_line":"    * ``inspector_redfish_password``"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"dffae193_144d94aa","line":5,"range":{"start_line":4,"start_character":10,"end_line":5,"end_character":52},"in_reply_to":"14e4e4e8_b1cdb1e2","updated":"2024-03-06 09:18:44.000000000","message":"Done","commit_id":"f80fada2d18e21aa9da0a56eb4a3fefaca8c3e94"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"537f429723686f7fd5e23d70b3a561cf7a9b9d1e","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds new Redfish rules to Ironic and Bifrost introspection"},{"line_number":5,"context_line":"    New variables available:"},{"line_number":6,"context_line":"    * ``inspector_rules_redfish_enabled``"},{"line_number":7,"context_line":"    * ``inspector_redfish_username``"},{"line_number":8,"context_line":"    * ``inspector_redfish_password``"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"193d5353_a088e55a","line":5,"updated":"2024-03-14 12:00:32.000000000","message":"And the IPMI flg","commit_id":"d0b39080e45b6361fbd0727ada645e762d7b2449"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"4e2c7dcd8b36a4d7ea93184d3431664be3a6ebf1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds new Redfish rules to Ironic and Bifrost introspection"},{"line_number":5,"context_line":"    New variables available:"},{"line_number":6,"context_line":"    * ``inspector_rules_redfish_enabled``"},{"line_number":7,"context_line":"    * ``inspector_redfish_username``"},{"line_number":8,"context_line":"    * ``inspector_redfish_password``"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"96bfddb8_01b6db1c","line":5,"in_reply_to":"193d5353_a088e55a","updated":"2024-03-20 11:30:51.000000000","message":"Done","commit_id":"d0b39080e45b6361fbd0727ada645e762d7b2449"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"278b98fefe0365795acac57393d01c37345096c3","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    * ``inspector_redfish_username``"},{"line_number":8,"context_line":"    * ``inspector_redfish_password``"},{"line_number":9,"context_line":"    * ``inspector_rule_var_redfish_verify_ca``"},{"line_number":10,"context_line":"    * ``inspector_rules_ipmi_enabled``"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"c0b74589_06a5290d","line":10,"updated":"2024-04-02 10:58:38.000000000","message":"kolla_bifrost_inspector_redfish_username \u0026 kolla_bifrost_inspector_redfish_password too","commit_id":"c78ec0b4ef87dc8fb892782924bc42652202522c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c870bf02cb33ea73636cae328a9253d4fa9ce5bf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    * ``inspector_redfish_username``"},{"line_number":8,"context_line":"    * ``inspector_redfish_password``"},{"line_number":9,"context_line":"    * ``inspector_rule_var_redfish_verify_ca``"},{"line_number":10,"context_line":"    * ``inspector_rules_ipmi_enabled``"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"be0a89f2_899d6e2c","line":10,"in_reply_to":"c0b74589_06a5290d","updated":"2024-04-03 09:29:40.000000000","message":"Done","commit_id":"c78ec0b4ef87dc8fb892782924bc42652202522c"}]}