)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"94de81e66d02bb0c1b480b6cb308faf732a572f6","unresolved":true,"context_lines":[{"line_number":13,"context_line":"changed to ``mountpoints``. This has now been fixed by looking at the"},{"line_number":14,"context_line":"new key as well as the old key."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-bug: 2051859"},{"line_number":17,"context_line":"Change-Id: I2a59f4eb3ae27f37fda38e05924315887cb04c41"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"580d9a91_0f8dce55","line":16,"range":{"start_line":16,"start_character":12,"end_line":16,"end_character":19},"updated":"2024-02-07 06:30:13.000000000","message":"#2051859","commit_id":"5138e2773b9a194d674c3a95792d4b5bd800eefe"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"4e28e20ac5fe7ff3fc765847431a9889af742053","unresolved":false,"context_lines":[{"line_number":13,"context_line":"changed to ``mountpoints``. This has now been fixed by looking at the"},{"line_number":14,"context_line":"new key as well as the old key."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-bug: 2051859"},{"line_number":17,"context_line":"Change-Id: I2a59f4eb3ae27f37fda38e05924315887cb04c41"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"37b11e51_9842953a","line":16,"range":{"start_line":16,"start_character":12,"end_line":16,"end_character":19},"in_reply_to":"580d9a91_0f8dce55","updated":"2024-02-07 09:22:38.000000000","message":"Done","commit_id":"5138e2773b9a194d674c3a95792d4b5bd800eefe"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"dddd23d1b19cb9d5afa1b4865b6fc4bb008e2258","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Dawud \u003cdawud@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-02-07 09:19:57 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix wipe-disks role to work on util-linux \u003e 2.37"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On newer versions of util-linux, the ``wipe_disks`` role was not"},{"line_number":10,"context_line":"properly configured due to the fact that ``lsblk -J`` returns a slightly"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1122e2a4_d3c0551b","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":43},"updated":"2024-02-07 10:01:11.000000000","message":"\u003e\u003d","commit_id":"8620117f2fee99b97c5e05762d1aeece8a77e9c6"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"ac814631b30fd737f86a0c3efd3646ff5636586f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dawud \u003cdawud@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-02-07 09:19:57 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix wipe-disks role to work on util-linux \u003e 2.37"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On newer versions of util-linux, the ``wipe_disks`` role was not"},{"line_number":10,"context_line":"properly configured due to the fact that ``lsblk -J`` returns a slightly"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ab23c689_214c8b07","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":43},"in_reply_to":"1122e2a4_d3c0551b","updated":"2024-02-14 16:20:31.000000000","message":"Done","commit_id":"8620117f2fee99b97c5e05762d1aeece8a77e9c6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"65e6d7ededd163e5e70db37eeb88e059a1627e9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"917c3e7a_3f4c51c2","updated":"2024-01-31 09:43:42.000000000","message":"Looks good to me. Any chance of a launchpad bug? Just helps others find the fix.","commit_id":"f9c265aa57bc44f290a9c96cfbf59b9cb6cdb876"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"4e28e20ac5fe7ff3fc765847431a9889af742053","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6553593e_9f30d908","updated":"2024-02-07 09:22:38.000000000","message":"Done. Thank you Pierre!","commit_id":"5138e2773b9a194d674c3a95792d4b5bd800eefe"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"94de81e66d02bb0c1b480b6cb308faf732a572f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6a0ea540_96a26c1e","updated":"2024-02-07 06:30:13.000000000","message":"The change looks good to me, some minor comments to fix.","commit_id":"5138e2773b9a194d674c3a95792d4b5bd800eefe"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"e01604f0d44fba7bb85c7d183d2e882c6339a18d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d41cffa9_087e3b0d","updated":"2024-02-02 10:37:03.000000000","message":"recheck","commit_id":"5138e2773b9a194d674c3a95792d4b5bd800eefe"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"72aa756ceb4e72ea72aad225020a3735055e6eee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2d45de90_30d82068","updated":"2024-02-06 12:37:46.000000000","message":"recheck: unrelated failure: Fail if the clock is not synchronized","commit_id":"5138e2773b9a194d674c3a95792d4b5bd800eefe"}],"ansible/roles/wipe-disks/library/blockdevice_info.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"94de81e66d02bb0c1b480b6cb308faf732a572f6","unresolved":true,"context_lines":[{"line_number":32,"context_line":"        if device[\"mountpoint\"]:"},{"line_number":33,"context_line":"            return True"},{"line_number":34,"context_line":"    except KeyError:"},{"line_number":35,"context_line":"        if device[\"mountpoints\"][0]:"},{"line_number":36,"context_line":"            return True"},{"line_number":37,"context_line":"    for child in device.get(\"children\", []):"},{"line_number":38,"context_line":"        if _has_mounts(child):"}],"source_content_type":"text/x-python","patch_set":4,"id":"830f1e31_2c7cb679","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":36},"updated":"2024-02-07 06:30:13.000000000","message":"I thought there might be an issue here, so I would add a comment:\n\nIf unmounted, the JSON output contains \"mountpoints\": [null]","commit_id":"5138e2773b9a194d674c3a95792d4b5bd800eefe"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"4e28e20ac5fe7ff3fc765847431a9889af742053","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        if device[\"mountpoint\"]:"},{"line_number":33,"context_line":"            return True"},{"line_number":34,"context_line":"    except KeyError:"},{"line_number":35,"context_line":"        if device[\"mountpoints\"][0]:"},{"line_number":36,"context_line":"            return True"},{"line_number":37,"context_line":"    for child in device.get(\"children\", []):"},{"line_number":38,"context_line":"        if _has_mounts(child):"}],"source_content_type":"text/x-python","patch_set":4,"id":"93b0b8bb_c003862d","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":36},"in_reply_to":"830f1e31_2c7cb679","updated":"2024-02-07 09:22:38.000000000","message":"Done","commit_id":"5138e2773b9a194d674c3a95792d4b5bd800eefe"}],"releasenotes/notes/wipe-disks-0e72c9c8b7bf7e18.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"bbb2653ff2bac5b413b356bb74b1c37b98a8a470","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    On Rocky Linux 9 and Ubuntu Jammy, the ``wipe_disks`` role was not properly"},{"line_number":5,"context_line":"    configured due to the fact that ``lsblk -J`` returns a slightly different"},{"line_number":6,"context_line":"    output than what was previously returned. Previously the output would"},{"line_number":7,"context_line":"    contain a key called ``mountpoint``, however this has been changed to"},{"line_number":8,"context_line":"    ``mountpoints``. This has now been fixed by looking at the new key as well"},{"line_number":9,"context_line":"    as the old key."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e20c7bcf_5ec58e26","line":9,"range":{"start_line":4,"start_character":0,"end_line":9,"end_character":19},"updated":"2024-01-29 21:36:11.000000000","message":"This is a bit too detailed for a release note. This is more useful to have in the commit message.","commit_id":"494019ac49f35221a1a182009f9548b2067bb491"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"25242ef66657fb3da52c2a6d7fdb6172e34b552c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    On Rocky Linux 9 and Ubuntu Jammy, the ``wipe_disks`` role was not properly"},{"line_number":5,"context_line":"    configured due to the fact that ``lsblk -J`` returns a slightly different"},{"line_number":6,"context_line":"    output than what was previously returned. Previously the output would"},{"line_number":7,"context_line":"    contain a key called ``mountpoint``, however this has been changed to"},{"line_number":8,"context_line":"    ``mountpoints``. This has now been fixed by looking at the new key as well"},{"line_number":9,"context_line":"    as the old key."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da135dbb_48be333e","line":9,"range":{"start_line":4,"start_character":0,"end_line":9,"end_character":19},"in_reply_to":"e20c7bcf_5ec58e26","updated":"2024-01-30 17:05:56.000000000","message":"Done\n\nMakes sense. Thank you","commit_id":"494019ac49f35221a1a182009f9548b2067bb491"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"94de81e66d02bb0c1b480b6cb308faf732a572f6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The wipe-disks role was broken on newer distros because the output of"},{"line_number":5,"context_line":"    ``lsblk -J`` changed. This has now been fixed."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1977ed8a_b0c89a68","line":4,"range":{"start_line":4,"start_character":38,"end_line":4,"end_character":51},"updated":"2024-02-07 06:30:13.000000000","message":"Without knowing more details about this bug, \"newer distros\" doesn\u0027t mean much.","commit_id":"5138e2773b9a194d674c3a95792d4b5bd800eefe"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"4e28e20ac5fe7ff3fc765847431a9889af742053","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The wipe-disks role was broken on newer distros because the output of"},{"line_number":5,"context_line":"    ``lsblk -J`` changed. This has now been fixed."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fb14b39c_9854d3aa","line":4,"range":{"start_line":4,"start_character":38,"end_line":4,"end_character":51},"in_reply_to":"1977ed8a_b0c89a68","updated":"2024-02-07 09:22:38.000000000","message":"Done","commit_id":"5138e2773b9a194d674c3a95792d4b5bd800eefe"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"94de81e66d02bb0c1b480b6cb308faf732a572f6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The wipe-disks role was broken on newer distros because the output of"},{"line_number":5,"context_line":"    ``lsblk -J`` changed. This has now been fixed."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d9f85f02_ca550b2c","line":5,"range":{"start_line":4,"start_character":1,"end_line":5,"end_character":50},"updated":"2024-02-07 06:30:13.000000000","message":"We would generally write in this style:\n\nFixes the ``wipe-disks`` role which was failing on supported host operating systems due to a change in the output format of ``lsblk -J`` in ``util-linux`` version 2.37.\n`LP#2051859 \u003chttps://bugs.launchpad.net/kayobe/+bug/2051859\u003e`__","commit_id":"5138e2773b9a194d674c3a95792d4b5bd800eefe"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"4e28e20ac5fe7ff3fc765847431a9889af742053","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The wipe-disks role was broken on newer distros because the output of"},{"line_number":5,"context_line":"    ``lsblk -J`` changed. This has now been fixed."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"77a45aec_00753e55","line":5,"range":{"start_line":4,"start_character":1,"end_line":5,"end_character":50},"in_reply_to":"d9f85f02_ca550b2c","updated":"2024-02-07 09:22:38.000000000","message":"Done","commit_id":"5138e2773b9a194d674c3a95792d4b5bd800eefe"}]}