)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"3eba2be60161aab49e041ff28ce795daac0ac360","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"924bf61e_3200edb2","updated":"2024-02-05 14:42:47.000000000","message":"Thought I\u0027d tested this behaviour, clearly not thoroughly enough.\n\nWould be good to add a release note here, as it will need to be backported so users of stable releases will need to be made aware the previous fix is not enough.","commit_id":"2a73c328d39c24772887031c6162b608a980e388"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c0093e56b41d383f59a549cb7d57960c7ca30c8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"74496613_36e2c24a","in_reply_to":"7acc0b08_10603a46","updated":"2024-02-07 06:10:42.000000000","message":"I don\u0027t agree about the release note in this case, because the initial fix was merged and backported almost two months ago (December 15), with a stable release since. People following stable branches or releases may want to know that a bug has been fixed.","commit_id":"2a73c328d39c24772887031c6162b608a980e388"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"e3598d09840a7cf2d67eb3d4c590ec57e8fef875","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7acc0b08_10603a46","in_reply_to":"924bf61e_3200edb2","updated":"2024-02-05 15:14:35.000000000","message":"previous release note still applies IMHO. and this is just a bugfix to a bugfix. I think we\u0027re good here.","commit_id":"2a73c328d39c24772887031c6162b608a980e388"}],"ansible/roles/network-redhat/tasks/main.yml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"844c8d539905537c7007166aaf70807b7aad97f4","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    name: NetworkManager"},{"line_number":28,"context_line":"    state: reloaded"},{"line_number":29,"context_line":"    daemon_reload: yes"},{"line_number":30,"context_line":"  when: dns_config_task is changed"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Configure network interfaces (RedHat)"},{"line_number":33,"context_line":"  import_role:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"abbbd2b3_e52c0d1e","line":30,"updated":"2024-02-05 15:05:29.000000000","message":"nit: I\u0027m sure ansible-lint would say that this should be a handler, but perhaps we need to reload immediately?","commit_id":"2a73c328d39c24772887031c6162b608a980e388"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"e3598d09840a7cf2d67eb3d4c590ec57e8fef875","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    name: NetworkManager"},{"line_number":28,"context_line":"    state: reloaded"},{"line_number":29,"context_line":"    daemon_reload: yes"},{"line_number":30,"context_line":"  when: dns_config_task is changed"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Configure network interfaces (RedHat)"},{"line_number":33,"context_line":"  import_role:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"23f9242c_87346aa7","line":30,"in_reply_to":"abbbd2b3_e52c0d1e","updated":"2024-02-05 15:14:35.000000000","message":"indeed, we need to run this before next task","commit_id":"2a73c328d39c24772887031c6162b608a980e388"}]}