)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0f1df850244d621d00442774bb0317778b7f97f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"00d715e2_ee1c709c","updated":"2024-02-29 11:05:45.000000000","message":"Lets add some docs in here:\n* like the other kayobe baremetal provide\n* show example inventory\n* describe how we are not really using inspector to discover nodes here, note most of the inspector rules don\u0027t activate, etc.\n* describe were other Kayobe commands take over from this one","commit_id":"9125fd7e63d45650ba3dc2821cdabe43fdcd3d95"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"dd705b29bc01c47778d24ab2aa5ab82beefa990f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"e58f5244_d07667f2","updated":"2024-03-18 18:04:03.000000000","message":"I added some minimal changes to get this working for me. Feel free to revert if necessary.","commit_id":"c5db18f007dd921dc2e5192762497b308dfc4f6e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d0ac4fd628b4fdb386c23a578a25c31d976902cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"8a9befae_e9320bf1","updated":"2024-04-03 09:47:19.000000000","message":"Please add a release note.","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a6eb560e35227918af7e2c67a8cf858940a47908","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"e2a1a71e_370ba583","updated":"2024-03-25 16:40:01.000000000","message":"Thanks for this Jake, it will be a useful feature.\n\nPlease add a release note","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"22ff9d81d6aa35ede4c48ce7070aa810828f917e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"9db2fea2_1df146a3","updated":"2024-05-15 16:20:31.000000000","message":"I\u0027ve proposed an addition to the CI to test this: https://review.opendev.org/c/openstack/kayobe/+/919754","commit_id":"6c033e3f10de8c9368817f8a92531236cf45f16e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e9146aa21aa6c983374292061f6c51877504d656","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"6ef8caa6_8c071617","updated":"2024-05-15 16:10:29.000000000","message":"Thanks Jake!","commit_id":"6c033e3f10de8c9368817f8a92531236cf45f16e"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"32a68c3d5e119e45f8f7e3daa694336aecc4f1a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"3bb22980_31a8d632","updated":"2024-05-16 11:29:01.000000000","message":"Looks good to me. CI looks like it was working apart from the validation of the BMC interface when moving to the manageable state as we using a made up IP.","commit_id":"15af6791984e2409ae6a43d0a9f936944ac3eee9"}],"ansible/baremetal-compute-register.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"7601b8e83b598f912c7203d55fc53ec8cf6f071a","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    controller_host: \"{{ groups[\u0027controllers\u0027][0] }}\""},{"line_number":28,"context_line":"  tasks:"},{"line_number":29,"context_line":"    - name: Create baremetal nodes"},{"line_number":30,"context_line":"      ansible.builtin.shell: "},{"line_number":31,"context_line":"        cmd: | "},{"line_number":32,"context_line":"          openstack baremetal node create \\"},{"line_number":33,"context_line":"          --name {{ inventory_hostname }} \\"},{"line_number":34,"context_line":"          --driver redfish --driver-info redfish_address\u003d{{ redfish_address }} \\"},{"line_number":35,"context_line":"          --driver-info redfish_system_id\u003d\u0027/redfish/v1/Systems/1\u0027 \\"},{"line_number":36,"context_line":"          --driver-info redfish_username\u003d\u0027{{ redfish_username }}\u0027 \\"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"39f75511_0e726f4c","line":33,"range":{"start_line":30,"start_character":0,"end_line":33,"end_character":0},"updated":"2024-02-21 14:36:29.000000000","message":"its better use: https://docs.ansible.com/ansible/latest/collections/openstack/cloud/baremetal_node_module.html#ansible-collections-openstack-cloud-baremetal-node-module\n\nBTW we already have openstacksdk virtualenv in \u0027post configure\u0027 step.","commit_id":"5c46b563b4b25685823e624141ebb03809dcf331"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"48695350b26eb584beb243b983c5847ccb9d7fb6","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    controller_host: \"{{ groups[\u0027controllers\u0027][0] }}\""},{"line_number":28,"context_line":"  tasks:"},{"line_number":29,"context_line":"    - name: Create baremetal nodes"},{"line_number":30,"context_line":"      ansible.builtin.shell: "},{"line_number":31,"context_line":"        cmd: | "},{"line_number":32,"context_line":"          openstack baremetal node create \\"},{"line_number":33,"context_line":"          --name {{ inventory_hostname }} \\"},{"line_number":34,"context_line":"          --driver redfish --driver-info redfish_address\u003d{{ redfish_address }} \\"},{"line_number":35,"context_line":"          --driver-info redfish_system_id\u003d\u0027/redfish/v1/Systems/1\u0027 \\"},{"line_number":36,"context_line":"          --driver-info redfish_username\u003d\u0027{{ redfish_username }}\u0027 \\"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a31c7a2_45cfe6c5","line":33,"range":{"start_line":30,"start_character":0,"end_line":33,"end_character":0},"in_reply_to":"39f75511_0e726f4c","updated":"2024-02-26 10:36:31.000000000","message":"I agree, ideally. However, the server mac address (of the PXE nic) must be known. In this case we want to find that using inspector.\n\nThis seems like the best compromise for now.","commit_id":"5c46b563b4b25685823e624141ebb03809dcf331"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"65a4799747e0886f8c8f9b0b2e875058fa4a0a79","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    controller_host: \"{{ groups[\u0027controllers\u0027][0] }}\""},{"line_number":28,"context_line":"  tasks:"},{"line_number":29,"context_line":"    - name: Create baremetal nodes"},{"line_number":30,"context_line":"      ansible.builtin.shell: "},{"line_number":31,"context_line":"        cmd: | "},{"line_number":32,"context_line":"          openstack baremetal node create \\"},{"line_number":33,"context_line":"          --name {{ inventory_hostname }} \\"},{"line_number":34,"context_line":"          --driver redfish --driver-info redfish_address\u003d{{ redfish_address }} \\"},{"line_number":35,"context_line":"          --driver-info redfish_system_id\u003d\u0027/redfish/v1/Systems/1\u0027 \\"},{"line_number":36,"context_line":"          --driver-info redfish_username\u003d\u0027{{ redfish_username }}\u0027 \\"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5095f05b_5b29d245","line":33,"range":{"start_line":30,"start_character":0,"end_line":33,"end_character":0},"in_reply_to":"5a31c7a2_45cfe6c5","updated":"2024-04-18 11:00:30.000000000","message":"Acknowledged","commit_id":"5c46b563b4b25685823e624141ebb03809dcf331"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"7601b8e83b598f912c7203d55fc53ec8cf6f071a","unresolved":true,"context_lines":[{"line_number":37,"context_line":"          --driver-info redfish_password\u003d\u0027{{ redfish_password }}\u0027 \\"},{"line_number":38,"context_line":"          --driver-info redfish_verify_ca\u003dfalse \\"},{"line_number":39,"context_line":"          --driver-info ipmi_address\u003d{{ ipmi_address }} \\"},{"line_number":40,"context_line":"          --resource-class SR645_1TB \\"},{"line_number":41,"context_line":"          --property capabilities\u003d\u0027boot_option:local,boot_mode:uefi\u0027"},{"line_number":42,"context_line":"      register: node_list"},{"line_number":43,"context_line":"      delegate_to: localhost"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3eb4c000_4fc25eaf","line":40,"range":{"start_line":40,"start_character":27,"end_line":40,"end_character":36},"updated":"2024-02-21 14:36:29.000000000","message":"this should be created in previous task and needs to be parameterized","commit_id":"5c46b563b4b25685823e624141ebb03809dcf331"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"48695350b26eb584beb243b983c5847ccb9d7fb6","unresolved":true,"context_lines":[{"line_number":37,"context_line":"          --driver-info redfish_password\u003d\u0027{{ redfish_password }}\u0027 \\"},{"line_number":38,"context_line":"          --driver-info redfish_verify_ca\u003dfalse \\"},{"line_number":39,"context_line":"          --driver-info ipmi_address\u003d{{ ipmi_address }} \\"},{"line_number":40,"context_line":"          --resource-class SR645_1TB \\"},{"line_number":41,"context_line":"          --property capabilities\u003d\u0027boot_option:local,boot_mode:uefi\u0027"},{"line_number":42,"context_line":"      register: node_list"},{"line_number":43,"context_line":"      delegate_to: localhost"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"eeb7ef7e_ad0dce08","line":40,"range":{"start_line":40,"start_character":27,"end_line":40,"end_character":36},"in_reply_to":"3eb4c000_4fc25eaf","updated":"2024-02-26 10:36:31.000000000","message":"Yes, this must come from the inventory.","commit_id":"5c46b563b4b25685823e624141ebb03809dcf331"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"65a4799747e0886f8c8f9b0b2e875058fa4a0a79","unresolved":false,"context_lines":[{"line_number":37,"context_line":"          --driver-info redfish_password\u003d\u0027{{ redfish_password }}\u0027 \\"},{"line_number":38,"context_line":"          --driver-info redfish_verify_ca\u003dfalse \\"},{"line_number":39,"context_line":"          --driver-info ipmi_address\u003d{{ ipmi_address }} \\"},{"line_number":40,"context_line":"          --resource-class SR645_1TB \\"},{"line_number":41,"context_line":"          --property capabilities\u003d\u0027boot_option:local,boot_mode:uefi\u0027"},{"line_number":42,"context_line":"      register: node_list"},{"line_number":43,"context_line":"      delegate_to: localhost"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"90ca0b5e_64b4cca2","line":40,"range":{"start_line":40,"start_character":27,"end_line":40,"end_character":36},"in_reply_to":"eeb7ef7e_ad0dce08","updated":"2024-04-18 11:00:30.000000000","message":"Done","commit_id":"5c46b563b4b25685823e624141ebb03809dcf331"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"48695350b26eb584beb243b983c5847ccb9d7fb6","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    venv: \"{{ virtualenv_path }}/openstack-cli\""},{"line_number":27,"context_line":"    controller_host: \"{{ groups[\u0027controllers\u0027][0] }}\""},{"line_number":28,"context_line":"  tasks:"},{"line_number":29,"context_line":"    - name: Create baremetal nodes"},{"line_number":30,"context_line":"      ansible.builtin.shell: "},{"line_number":31,"context_line":"        cmd: | "},{"line_number":32,"context_line":"          openstack baremetal node create \\"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0a381879_0de60396","line":29,"updated":"2024-02-26 10:36:31.000000000","message":"I think we should first check if the node has been added, then only attempt the add if the node is missing.","commit_id":"b33c6341311a3d9d70180bb9a2b5ad97d9e70c07"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"7fa25118b1e21c5c0069c9e93a4c55cb8c8e8c80","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    venv: \"{{ virtualenv_path }}/openstack-cli\""},{"line_number":27,"context_line":"    controller_host: \"{{ groups[\u0027controllers\u0027][0] }}\""},{"line_number":28,"context_line":"  tasks:"},{"line_number":29,"context_line":"    - name: Create baremetal nodes"},{"line_number":30,"context_line":"      ansible.builtin.shell: "},{"line_number":31,"context_line":"        cmd: | "},{"line_number":32,"context_line":"          openstack baremetal node create \\"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ce7fc31c_ba7e08db","line":29,"in_reply_to":"0a381879_0de60396","updated":"2024-04-18 11:07:59.000000000","message":"Done","commit_id":"b33c6341311a3d9d70180bb9a2b5ad97d9e70c07"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"48695350b26eb584beb243b983c5847ccb9d7fb6","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        cmd: | "},{"line_number":32,"context_line":"          openstack baremetal node create \\"},{"line_number":33,"context_line":"          --name {{ inventory_hostname }} \\"},{"line_number":34,"context_line":"          --driver redfish --driver-info redfish_address\u003d{{ redfish_address }} \\"},{"line_number":35,"context_line":"          --driver-info redfish_system_id\u003d\u0027/redfish/v1/Systems/1\u0027 \\"},{"line_number":36,"context_line":"          --driver-info redfish_username\u003d\u0027{{ redfish_username }}\u0027 \\"},{"line_number":37,"context_line":"          --driver-info redfish_password\u003d\u0027{{ redfish_password }}\u0027 \\"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"937fee28_92a1d69a","line":34,"updated":"2024-02-26 10:36:31.000000000","message":"I think we probably need to make this task conditional on the kayboe inventory item having driver\u003dredfish, and default to redfish if not set.","commit_id":"b33c6341311a3d9d70180bb9a2b5ad97d9e70c07"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"7fa25118b1e21c5c0069c9e93a4c55cb8c8e8c80","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        cmd: | "},{"line_number":32,"context_line":"          openstack baremetal node create \\"},{"line_number":33,"context_line":"          --name {{ inventory_hostname }} \\"},{"line_number":34,"context_line":"          --driver redfish --driver-info redfish_address\u003d{{ redfish_address }} \\"},{"line_number":35,"context_line":"          --driver-info redfish_system_id\u003d\u0027/redfish/v1/Systems/1\u0027 \\"},{"line_number":36,"context_line":"          --driver-info redfish_username\u003d\u0027{{ redfish_username }}\u0027 \\"},{"line_number":37,"context_line":"          --driver-info redfish_password\u003d\u0027{{ redfish_password }}\u0027 \\"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2c685093_b7ef45a6","line":34,"in_reply_to":"937fee28_92a1d69a","updated":"2024-04-18 11:07:59.000000000","message":"Done","commit_id":"b33c6341311a3d9d70180bb9a2b5ad97d9e70c07"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"48695350b26eb584beb243b983c5847ccb9d7fb6","unresolved":true,"context_lines":[{"line_number":32,"context_line":"          openstack baremetal node create \\"},{"line_number":33,"context_line":"          --name {{ inventory_hostname }} \\"},{"line_number":34,"context_line":"          --driver redfish --driver-info redfish_address\u003d{{ redfish_address }} \\"},{"line_number":35,"context_line":"          --driver-info redfish_system_id\u003d\u0027/redfish/v1/Systems/1\u0027 \\"},{"line_number":36,"context_line":"          --driver-info redfish_username\u003d\u0027{{ redfish_username }}\u0027 \\"},{"line_number":37,"context_line":"          --driver-info redfish_password\u003d\u0027{{ redfish_password }}\u0027 \\"},{"line_number":38,"context_line":"          --driver-info redfish_verify_ca\u003dfalse \\"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"11ec22fb_376fa8d8","line":35,"updated":"2024-02-26 10:36:31.000000000","message":"We have this in config I think, or we should have this in config. I think it might need to a group_vars.","commit_id":"b33c6341311a3d9d70180bb9a2b5ad97d9e70c07"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"7fa25118b1e21c5c0069c9e93a4c55cb8c8e8c80","unresolved":false,"context_lines":[{"line_number":32,"context_line":"          openstack baremetal node create \\"},{"line_number":33,"context_line":"          --name {{ inventory_hostname }} \\"},{"line_number":34,"context_line":"          --driver redfish --driver-info redfish_address\u003d{{ redfish_address }} \\"},{"line_number":35,"context_line":"          --driver-info redfish_system_id\u003d\u0027/redfish/v1/Systems/1\u0027 \\"},{"line_number":36,"context_line":"          --driver-info redfish_username\u003d\u0027{{ redfish_username }}\u0027 \\"},{"line_number":37,"context_line":"          --driver-info redfish_password\u003d\u0027{{ redfish_password }}\u0027 \\"},{"line_number":38,"context_line":"          --driver-info redfish_verify_ca\u003dfalse \\"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"558aace6_072a3274","line":35,"in_reply_to":"11ec22fb_376fa8d8","updated":"2024-04-18 11:07:59.000000000","message":"Done","commit_id":"b33c6341311a3d9d70180bb9a2b5ad97d9e70c07"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"48695350b26eb584beb243b983c5847ccb9d7fb6","unresolved":true,"context_lines":[{"line_number":35,"context_line":"          --driver-info redfish_system_id\u003d\u0027/redfish/v1/Systems/1\u0027 \\"},{"line_number":36,"context_line":"          --driver-info redfish_username\u003d\u0027{{ redfish_username }}\u0027 \\"},{"line_number":37,"context_line":"          --driver-info redfish_password\u003d\u0027{{ redfish_password }}\u0027 \\"},{"line_number":38,"context_line":"          --driver-info redfish_verify_ca\u003dfalse \\"},{"line_number":39,"context_line":"          --driver-info ipmi_address\u003d{{ ipmi_address }} \\"},{"line_number":40,"context_line":"          --resource-class SR645_1TB \\"},{"line_number":41,"context_line":"          --property capabilities\u003d\u0027boot_option:local,boot_mode:uefi\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"339cbf83_9dc3ba88","line":38,"updated":"2024-02-26 10:36:31.000000000","message":"It feels like we need a config option for this one.","commit_id":"b33c6341311a3d9d70180bb9a2b5ad97d9e70c07"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"7fa25118b1e21c5c0069c9e93a4c55cb8c8e8c80","unresolved":false,"context_lines":[{"line_number":35,"context_line":"          --driver-info redfish_system_id\u003d\u0027/redfish/v1/Systems/1\u0027 \\"},{"line_number":36,"context_line":"          --driver-info redfish_username\u003d\u0027{{ redfish_username }}\u0027 \\"},{"line_number":37,"context_line":"          --driver-info redfish_password\u003d\u0027{{ redfish_password }}\u0027 \\"},{"line_number":38,"context_line":"          --driver-info redfish_verify_ca\u003dfalse \\"},{"line_number":39,"context_line":"          --driver-info ipmi_address\u003d{{ ipmi_address }} \\"},{"line_number":40,"context_line":"          --resource-class SR645_1TB \\"},{"line_number":41,"context_line":"          --property capabilities\u003d\u0027boot_option:local,boot_mode:uefi\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"05157177_7a36e322","line":38,"in_reply_to":"339cbf83_9dc3ba88","updated":"2024-04-18 11:07:59.000000000","message":"Done","commit_id":"b33c6341311a3d9d70180bb9a2b5ad97d9e70c07"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"48695350b26eb584beb243b983c5847ccb9d7fb6","unresolved":true,"context_lines":[{"line_number":36,"context_line":"          --driver-info redfish_username\u003d\u0027{{ redfish_username }}\u0027 \\"},{"line_number":37,"context_line":"          --driver-info redfish_password\u003d\u0027{{ redfish_password }}\u0027 \\"},{"line_number":38,"context_line":"          --driver-info redfish_verify_ca\u003dfalse \\"},{"line_number":39,"context_line":"          --driver-info ipmi_address\u003d{{ ipmi_address }} \\"},{"line_number":40,"context_line":"          --resource-class SR645_1TB \\"},{"line_number":41,"context_line":"          --property capabilities\u003d\u0027boot_option:local,boot_mode:uefi\u0027"},{"line_number":42,"context_line":"      register: node_list"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d0afd465_f56cdb4a","line":39,"updated":"2024-02-26 10:36:31.000000000","message":"Add a comment to say this is to make inspector match correctly with pre-existing ironic nodes on inspection. There might be a config change to fix this one.","commit_id":"b33c6341311a3d9d70180bb9a2b5ad97d9e70c07"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"7fa25118b1e21c5c0069c9e93a4c55cb8c8e8c80","unresolved":false,"context_lines":[{"line_number":36,"context_line":"          --driver-info redfish_username\u003d\u0027{{ redfish_username }}\u0027 \\"},{"line_number":37,"context_line":"          --driver-info redfish_password\u003d\u0027{{ redfish_password }}\u0027 \\"},{"line_number":38,"context_line":"          --driver-info redfish_verify_ca\u003dfalse \\"},{"line_number":39,"context_line":"          --driver-info ipmi_address\u003d{{ ipmi_address }} \\"},{"line_number":40,"context_line":"          --resource-class SR645_1TB \\"},{"line_number":41,"context_line":"          --property capabilities\u003d\u0027boot_option:local,boot_mode:uefi\u0027"},{"line_number":42,"context_line":"      register: node_list"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d8b93c95_fe23909c","line":39,"in_reply_to":"d0afd465_f56cdb4a","updated":"2024-04-18 11:07:59.000000000","message":"Done","commit_id":"b33c6341311a3d9d70180bb9a2b5ad97d9e70c07"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"48695350b26eb584beb243b983c5847ccb9d7fb6","unresolved":true,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    - name: Inspect baremetal nodes"},{"line_number":52,"context_line":"      ansible.builtin.shell: "},{"line_number":53,"context_line":"        cmd: \"openstack baremetal node inspect {{ inventory_hostname }} --wait\""},{"line_number":54,"context_line":"      register: node_list"},{"line_number":55,"context_line":"      delegate_to: localhost"},{"line_number":56,"context_line":"    "}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cfa944fe_e6eda2d7","line":53,"updated":"2024-02-26 10:36:31.000000000","message":"This should probably be a separate Kayobe command.\n\nI also think we should have the option to check the machine serial matches the inventory, when set in the inventory, once inspection has completed. But for now lets remove these bits.","commit_id":"b33c6341311a3d9d70180bb9a2b5ad97d9e70c07"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"7fa25118b1e21c5c0069c9e93a4c55cb8c8e8c80","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    - name: Inspect baremetal nodes"},{"line_number":52,"context_line":"      ansible.builtin.shell: "},{"line_number":53,"context_line":"        cmd: \"openstack baremetal node inspect {{ inventory_hostname }} --wait\""},{"line_number":54,"context_line":"      register: node_list"},{"line_number":55,"context_line":"      delegate_to: localhost"},{"line_number":56,"context_line":"    "}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5b7c17ae_81caa9bc","line":53,"in_reply_to":"cfa944fe_e6eda2d7","updated":"2024-04-18 11:07:59.000000000","message":"Done","commit_id":"b33c6341311a3d9d70180bb9a2b5ad97d9e70c07"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a6eb560e35227918af7e2c67a8cf858940a47908","unresolved":true,"context_lines":[{"line_number":12,"context_line":"          - python-openstackclient"},{"line_number":13,"context_line":"          - python-ironicclient"},{"line_number":14,"context_line":"        state: latest"},{"line_number":15,"context_line":"        virtualenv_command: \"python3.{{ ansible_facts.python.version.minor }} -m venv\""},{"line_number":16,"context_line":"        extra_args: \"{% if pip_upper_constraints_file %}-c {{ pip_upper_constraints_file }}{% endif %}\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Ensure baremetal compute nodes are registered in ironic"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"d956c7f0_31a54a9a","line":15,"updated":"2024-03-25 16:40:01.000000000","message":"Why do we need this when [1] doesn\u0027t have it?\n\n[1] https://github.com/openstack/kayobe/blob/master/ansible/baremetal-compute-rename.yml#L6\n\nIdeally we should match [1] unless there is a strong reason not to. Does that need to be fixed too?","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"b3a0473277f3b4e6806e6663d24b293f7b03b59b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"          - python-openstackclient"},{"line_number":13,"context_line":"          - python-ironicclient"},{"line_number":14,"context_line":"        state: latest"},{"line_number":15,"context_line":"        virtualenv_command: \"python3.{{ ansible_facts.python.version.minor }} -m venv\""},{"line_number":16,"context_line":"        extra_args: \"{% if pip_upper_constraints_file %}-c {{ pip_upper_constraints_file }}{% endif %}\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Ensure baremetal compute nodes are registered in ironic"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"34eb7b23_457cddd9","line":15,"in_reply_to":"abac28e7_16afc2bf","updated":"2024-05-09 15:36:12.000000000","message":"Thanks for clearing that up. I\u0027m fine with leaving it in. Standardising can be considered under a separate change.","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"28a575ce26d6dc3aa0e884e02e4a7b87705a0b6a","unresolved":true,"context_lines":[{"line_number":12,"context_line":"          - python-openstackclient"},{"line_number":13,"context_line":"          - python-ironicclient"},{"line_number":14,"context_line":"        state: latest"},{"line_number":15,"context_line":"        virtualenv_command: \"python3.{{ ansible_facts.python.version.minor }} -m venv\""},{"line_number":16,"context_line":"        extra_args: \"{% if pip_upper_constraints_file %}-c {{ pip_upper_constraints_file }}{% endif %}\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Ensure baremetal compute nodes are registered in ironic"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"abac28e7_16afc2bf","line":15,"in_reply_to":"cbe0091d_b19c76ca","updated":"2024-05-03 10:32:52.000000000","message":"Can we decide what is best here, clearly we need something that works, and ideally make it consistent across all the commands, but it feels like this might block the patch.","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"2a4cd101b0d78b46e04c6d9f6a8322e62e6c7314","unresolved":false,"context_lines":[{"line_number":12,"context_line":"          - python-openstackclient"},{"line_number":13,"context_line":"          - python-ironicclient"},{"line_number":14,"context_line":"        state: latest"},{"line_number":15,"context_line":"        virtualenv_command: \"python3.{{ ansible_facts.python.version.minor }} -m venv\""},{"line_number":16,"context_line":"        extra_args: \"{% if pip_upper_constraints_file %}-c {{ pip_upper_constraints_file }}{% endif %}\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Ensure baremetal compute nodes are registered in ironic"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"50df7eb6_a32f1c02","line":15,"in_reply_to":"cbe0091d_b19c76ca","updated":"2024-05-03 10:31:24.000000000","message":"Done","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"01cdbbe3a7bc7efd15633dcbb87c7c0daff6bacb","unresolved":true,"context_lines":[{"line_number":12,"context_line":"          - python-openstackclient"},{"line_number":13,"context_line":"          - python-ironicclient"},{"line_number":14,"context_line":"        state: latest"},{"line_number":15,"context_line":"        virtualenv_command: \"python3.{{ ansible_facts.python.version.minor }} -m venv\""},{"line_number":16,"context_line":"        extra_args: \"{% if pip_upper_constraints_file %}-c {{ pip_upper_constraints_file }}{% endif %}\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Ensure baremetal compute nodes are registered in ironic"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"cbe0091d_b19c76ca","line":15,"in_reply_to":"d956c7f0_31a54a9a","updated":"2024-04-18 09:58:09.000000000","message":"This was my change. I copied it from here:\n\nhttps://github.com/openstack/kayobe/blob/ece51deb3bff2b639ceb6378204a2b9d32b2de36/ansible/kayobe-target-venv.yml#L65\n\nI guess it makes sense for more consistency here. This is the change that orginally added the minor version:\n\nhttps://github.com/openstack/kayobe/commit/15109ccb547e603c0aca2a73e43f4db523fa1bcd\n\nIt does require facts so might be nice if we didn\u0027t need it.","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a6eb560e35227918af7e2c67a8cf858940a47908","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    - block:"},{"line_number":34,"context_line":"      - name: List baremetal nodes"},{"line_number":35,"context_line":"        ansible.builtin.shell:"},{"line_number":36,"context_line":"          cmd: \"{{ venv }}/bin/openstack baremetal node show {{ inventory_hostname }}\""},{"line_number":37,"context_line":"        register: node_list"},{"line_number":38,"context_line":"        failed_when: false"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"b12443b1_ecf8ef90","line":35,"updated":"2024-03-25 16:40:01.000000000","message":"It\u0027s better to use `command`: https://ansible.readthedocs.io/projects/lint/rules/command-instead-of-shell/\n\nThe same comment for other tasks using shell","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"8013f7ddd1ee3355e87f1cb20ca450819b8810a1","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    - block:"},{"line_number":34,"context_line":"      - name: List baremetal nodes"},{"line_number":35,"context_line":"        ansible.builtin.shell:"},{"line_number":36,"context_line":"          cmd: \"{{ venv }}/bin/openstack baremetal node show {{ inventory_hostname }}\""},{"line_number":37,"context_line":"        register: node_list"},{"line_number":38,"context_line":"        failed_when: false"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"5d646db3_4689a8af","line":35,"in_reply_to":"b12443b1_ecf8ef90","updated":"2024-04-05 12:54:20.000000000","message":"Done","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a6eb560e35227918af7e2c67a8cf858940a47908","unresolved":true,"context_lines":[{"line_number":34,"context_line":"      - name: List baremetal nodes"},{"line_number":35,"context_line":"        ansible.builtin.shell:"},{"line_number":36,"context_line":"          cmd: \"{{ venv }}/bin/openstack baremetal node show {{ inventory_hostname }}\""},{"line_number":37,"context_line":"        register: node_list"},{"line_number":38,"context_line":"        failed_when: false"},{"line_number":39,"context_line":"        changed_when: false"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"79c7866f_4aa77535","line":37,"updated":"2024-03-25 16:40:01.000000000","message":"To avoid confusing this with a `baremetal node list`, use node_show?","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"8013f7ddd1ee3355e87f1cb20ca450819b8810a1","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      - name: List baremetal nodes"},{"line_number":35,"context_line":"        ansible.builtin.shell:"},{"line_number":36,"context_line":"          cmd: \"{{ venv }}/bin/openstack baremetal node show {{ inventory_hostname }}\""},{"line_number":37,"context_line":"        register: node_list"},{"line_number":38,"context_line":"        failed_when: false"},{"line_number":39,"context_line":"        changed_when: false"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"06bb6711_7dffdb54","line":37,"in_reply_to":"79c7866f_4aa77535","updated":"2024-04-05 12:54:20.000000000","message":"Done","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a6eb560e35227918af7e2c67a8cf858940a47908","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        ansible.builtin.shell:"},{"line_number":36,"context_line":"          cmd: \"{{ venv }}/bin/openstack baremetal node show {{ inventory_hostname }}\""},{"line_number":37,"context_line":"        register: node_list"},{"line_number":38,"context_line":"        failed_when: false"},{"line_number":39,"context_line":"        changed_when: false"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"      - name: Create baremetal nodes"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"578658e7_85365517","line":38,"updated":"2024-03-25 16:40:01.000000000","message":"Can this be more specific? Like it could fail because the credentials don\u0027t work, etc, in which case you want it to fail.","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ffba26a69dfebbf31b65c4434987481aa6b9d568","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        ansible.builtin.shell:"},{"line_number":36,"context_line":"          cmd: \"{{ venv }}/bin/openstack baremetal node show {{ inventory_hostname }}\""},{"line_number":37,"context_line":"        register: node_list"},{"line_number":38,"context_line":"        failed_when: false"},{"line_number":39,"context_line":"        changed_when: false"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"      - name: Create baremetal nodes"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"afafbbb1_78b19a8f","line":38,"in_reply_to":"578658e7_85365517","updated":"2024-04-12 16:26:43.000000000","message":"+1 yes, we should change this to something like this:\n\n    failed_when: node_show.rc !\u003d 0 and \"Not Found\" not in node_show.stdout","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"8d6706b65395ff86024399fe21118fec8c45c5fd","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        ansible.builtin.shell:"},{"line_number":36,"context_line":"          cmd: \"{{ venv }}/bin/openstack baremetal node show {{ inventory_hostname }}\""},{"line_number":37,"context_line":"        register: node_list"},{"line_number":38,"context_line":"        failed_when: false"},{"line_number":39,"context_line":"        changed_when: false"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"      - name: Create baremetal nodes"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"8a191c04_d420cb7d","line":38,"in_reply_to":"afafbbb1_78b19a8f","updated":"2024-04-18 09:51:13.000000000","message":"Done","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d0ac4fd628b4fdb386c23a578a25c31d976902cc","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        changed_when: false"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"      - name: Create baremetal nodes"},{"line_number":42,"context_line":"        ansible.builtin.shell:"},{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"33028e83_9af343ae","line":42,"updated":"2024-04-03 09:47:19.000000000","message":"Did you consider using the baremetal_node module?\n\nhttps://docs.ansible.com/ansible/latest/collections/openstack/cloud/baremetal_node_module.html","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"8d6706b65395ff86024399fe21118fec8c45c5fd","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        changed_when: false"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"      - name: Create baremetal nodes"},{"line_number":42,"context_line":"        ansible.builtin.shell:"},{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"992461d5_d82b7830","line":42,"in_reply_to":"2e2ea978_65888e3c","updated":"2024-04-18 09:51:13.000000000","message":"Done","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"3b58ee19b4c6c97e729ee8c33948a588b3c209ff","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        changed_when: false"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"      - name: Create baremetal nodes"},{"line_number":42,"context_line":"        ansible.builtin.shell:"},{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"c93494db_00c16388","line":42,"in_reply_to":"33028e83_9af343ae","updated":"2024-04-05 10:37:27.000000000","message":"I think that module requires a MAC address to be defined, which we want to find in inspection here.","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ffba26a69dfebbf31b65c4434987481aa6b9d568","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        changed_when: false"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"      - name: Create baremetal nodes"},{"line_number":42,"context_line":"        ansible.builtin.shell:"},{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"2e2ea978_65888e3c","line":42,"in_reply_to":"c93494db_00c16388","updated":"2024-04-12 16:26:43.000000000","message":"We need to note as a comment in this playbook... I though we did that already... odd.","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d0ac4fd628b4fdb386c23a578a25c31d976902cc","unresolved":true,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"      - name: Create baremetal nodes"},{"line_number":42,"context_line":"        ansible.builtin.shell:"},{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":46,"context_line":"            --driver redfish \\"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1328fd67_fab8de8f","line":43,"updated":"2024-04-03 09:47:19.000000000","message":"We might also want to define the various interfaces (inspect_interface, etc.)","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ffba26a69dfebbf31b65c4434987481aa6b9d568","unresolved":true,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"      - name: Create baremetal nodes"},{"line_number":42,"context_line":"        ansible.builtin.shell:"},{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":46,"context_line":"            --driver redfish \\"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a9b80f5_3195f38c","line":43,"in_reply_to":"1328fd67_fab8de8f","updated":"2024-04-12 16:26:43.000000000","message":"Kayboe already sets all the defaults for these in ironic config, so its not really needed right now. We could add those later if the need arises?","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"28a575ce26d6dc3aa0e884e02e4a7b87705a0b6a","unresolved":true,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"      - name: Create baremetal nodes"},{"line_number":42,"context_line":"        ansible.builtin.shell:"},{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":46,"context_line":"            --driver redfish \\"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"72992bd8_afaf39ea","line":43,"in_reply_to":"38befe6e_838f168e","updated":"2024-05-03 10:32:52.000000000","message":"That is a better way of putting it, lets keep it small for now.\n\nAgreed its  possible as a follow up, and probably better than the config based approach for a bunch of reasons (I would like to stop kayobe setting any default interfaces by default, it makes multi vendor such hard work.)","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a6cfb820aadb5908c10bdaeb50132c4eacfa81c5","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"      - name: Create baremetal nodes"},{"line_number":42,"context_line":"        ansible.builtin.shell:"},{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":46,"context_line":"            --driver redfish \\"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"6cf98005_9049f4da","line":43,"in_reply_to":"72992bd8_afaf39ea","updated":"2024-05-15 15:58:05.000000000","message":"Acknowledged","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8fd594bc613672afa61d205732e6bdf5bc96f5e6","unresolved":true,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"      - name: Create baremetal nodes"},{"line_number":42,"context_line":"        ansible.builtin.shell:"},{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":46,"context_line":"            --driver redfish \\"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"38befe6e_838f168e","line":43,"in_reply_to":"7a9b80f5_3195f38c","updated":"2024-04-29 13:34:47.000000000","message":"I expect it will come up at some point, since nodes might not all use the same interfaces, but if we want to keep it small for now then we can.","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d0ac4fd628b4fdb386c23a578a25c31d976902cc","unresolved":true,"context_lines":[{"line_number":41,"context_line":"      - name: Create baremetal nodes"},{"line_number":42,"context_line":"        ansible.builtin.shell:"},{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":46,"context_line":"            --driver redfish \\"},{"line_number":47,"context_line":"            --driver-info redfish_address\u003d{{ ipmi_address }} \\"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3b4c6377_3d93ffbb","line":44,"updated":"2024-04-03 09:47:19.000000000","message":"Would we ever need to define ports? (e.g. using the baremetal_port module) Possibly if we want to run in-band inspection.","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ffba26a69dfebbf31b65c4434987481aa6b9d568","unresolved":true,"context_lines":[{"line_number":41,"context_line":"      - name: Create baremetal nodes"},{"line_number":42,"context_line":"        ansible.builtin.shell:"},{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":46,"context_line":"            --driver redfish \\"},{"line_number":47,"context_line":"            --driver-info redfish_address\u003d{{ ipmi_address }} \\"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"aba7721a_79a76a78","line":44,"in_reply_to":"3b4c6377_3d93ffbb","updated":"2024-04-12 16:26:43.000000000","message":"We could, but that would be additional (optional) CLI calls. I think relying on in band inspection LLDP to populate the ports makes sense here. But we need to document in a comment in the code here that this is in intent.","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a6cfb820aadb5908c10bdaeb50132c4eacfa81c5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"      - name: Create baremetal nodes"},{"line_number":42,"context_line":"        ansible.builtin.shell:"},{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":46,"context_line":"            --driver redfish \\"},{"line_number":47,"context_line":"            --driver-info redfish_address\u003d{{ ipmi_address }} \\"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"5f7dbff5_bf225872","line":44,"in_reply_to":"950e73ca_05d8d775","updated":"2024-05-15 15:58:05.000000000","message":"Acknowledged","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"28a575ce26d6dc3aa0e884e02e4a7b87705a0b6a","unresolved":true,"context_lines":[{"line_number":41,"context_line":"      - name: Create baremetal nodes"},{"line_number":42,"context_line":"        ansible.builtin.shell:"},{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":46,"context_line":"            --driver redfish \\"},{"line_number":47,"context_line":"            --driver-info redfish_address\u003d{{ ipmi_address }} \\"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"950e73ca_05d8d775","line":44,"in_reply_to":"a9b64d92_e3a2a9e3","updated":"2024-05-03 10:32:52.000000000","message":"@Mark, I am assuming inbound inspection here, using ironic-inspector. That works just fine after adding the node first.","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8fd594bc613672afa61d205732e6bdf5bc96f5e6","unresolved":true,"context_lines":[{"line_number":41,"context_line":"      - name: Create baremetal nodes"},{"line_number":42,"context_line":"        ansible.builtin.shell:"},{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":46,"context_line":"            --driver redfish \\"},{"line_number":47,"context_line":"            --driver-info redfish_address\u003d{{ ipmi_address }} \\"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"a9b64d92_e3a2a9e3","line":44,"in_reply_to":"aba7721a_79a76a78","updated":"2024-04-29 13:34:47.000000000","message":"Presumably this relies on using Redfish out of band inspection to populate ports in ironic that can then be switched to the inspection network during inspection?","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"4c24cfd72d75e5193774eda8c4d9eff8d526ad33","unresolved":true,"context_lines":[{"line_number":49,"context_line":"            --driver-info redfish_username\u003d{{ redfish_username }} \\"},{"line_number":50,"context_line":"            --driver-info redfish_password\u003d{{ redfish_password }} \\"},{"line_number":51,"context_line":"            --driver-info redfish_verify_ca\u003d{{ redfish_verify_ca }} \\"},{"line_number":52,"context_line":"            --driver-info ipmi_address\u003d{{ ipmi_address }} \\"},{"line_number":53,"context_line":"            --resource-class {{ resource_class }} \\"},{"line_number":54,"context_line":"            --property capabilities\u003d\u0027boot_option:local,boot_mode:uefi\u0027"},{"line_number":55,"context_line":"        when: node_list.rc !\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"fe299226_fc8ebaf6","line":52,"updated":"2024-03-18 18:11:02.000000000","message":"Do we need ipmi address if using the redfish driver?","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ffba26a69dfebbf31b65c4434987481aa6b9d568","unresolved":true,"context_lines":[{"line_number":49,"context_line":"            --driver-info redfish_username\u003d{{ redfish_username }} \\"},{"line_number":50,"context_line":"            --driver-info redfish_password\u003d{{ redfish_password }} \\"},{"line_number":51,"context_line":"            --driver-info redfish_verify_ca\u003d{{ redfish_verify_ca }} \\"},{"line_number":52,"context_line":"            --driver-info ipmi_address\u003d{{ ipmi_address }} \\"},{"line_number":53,"context_line":"            --resource-class {{ resource_class }} \\"},{"line_number":54,"context_line":"            --property capabilities\u003d\u0027boot_option:local,boot_mode:uefi\u0027"},{"line_number":55,"context_line":"        when: node_list.rc !\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bcebcc54_1534ba66","line":52,"in_reply_to":"0a3cc274_3a483cb8","updated":"2024-04-12 16:26:43.000000000","message":"Jake is correct, (inspector doesn\u0027t find our node and adds a duplicate), but I think this is because the inspector config is wrong, its probably worth adding a TODO to fix this at a later date.","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"01cdbbe3a7bc7efd15633dcbb87c7c0daff6bacb","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            --driver-info redfish_username\u003d{{ redfish_username }} \\"},{"line_number":50,"context_line":"            --driver-info redfish_password\u003d{{ redfish_password }} \\"},{"line_number":51,"context_line":"            --driver-info redfish_verify_ca\u003d{{ redfish_verify_ca }} \\"},{"line_number":52,"context_line":"            --driver-info ipmi_address\u003d{{ ipmi_address }} \\"},{"line_number":53,"context_line":"            --resource-class {{ resource_class }} \\"},{"line_number":54,"context_line":"            --property capabilities\u003d\u0027boot_option:local,boot_mode:uefi\u0027"},{"line_number":55,"context_line":"        when: node_list.rc !\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"424ec517_d1df52e4","line":52,"in_reply_to":"bcebcc54_1534ba66","updated":"2024-04-18 09:58:09.000000000","message":"Acknowledged","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"c6a014de453d6a560d0b41eb84411998d609e260","unresolved":true,"context_lines":[{"line_number":49,"context_line":"            --driver-info redfish_username\u003d{{ redfish_username }} \\"},{"line_number":50,"context_line":"            --driver-info redfish_password\u003d{{ redfish_password }} \\"},{"line_number":51,"context_line":"            --driver-info redfish_verify_ca\u003d{{ redfish_verify_ca }} \\"},{"line_number":52,"context_line":"            --driver-info ipmi_address\u003d{{ ipmi_address }} \\"},{"line_number":53,"context_line":"            --resource-class {{ resource_class }} \\"},{"line_number":54,"context_line":"            --property capabilities\u003d\u0027boot_option:local,boot_mode:uefi\u0027"},{"line_number":55,"context_line":"        when: node_list.rc !\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"0a3cc274_3a483cb8","line":52,"in_reply_to":"fe299226_fc8ebaf6","updated":"2024-03-21 16:59:53.000000000","message":"I think it\u0027s so Ironic inspector will work with existing nodes.","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d0ac4fd628b4fdb386c23a578a25c31d976902cc","unresolved":true,"context_lines":[{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":46,"context_line":"            --driver redfish \\"},{"line_number":47,"context_line":"            --driver-info redfish_address\u003d{{ ipmi_address }} \\"},{"line_number":48,"context_line":"            --driver-info redfish_system_id\u003d{{ redfish_system_id }} \\"},{"line_number":49,"context_line":"            --driver-info redfish_username\u003d{{ redfish_username }} \\"},{"line_number":50,"context_line":"            --driver-info redfish_password\u003d{{ redfish_password }} \\"},{"line_number":51,"context_line":"            --driver-info redfish_verify_ca\u003d{{ redfish_verify_ca }} \\"},{"line_number":52,"context_line":"            --driver-info ipmi_address\u003d{{ ipmi_address }} \\"},{"line_number":53,"context_line":"            --resource-class {{ resource_class }} \\"},{"line_number":54,"context_line":"            --property capabilities\u003d\u0027boot_option:local,boot_mode:uefi\u0027"},{"line_number":55,"context_line":"        when: node_list.rc !\u003d 0"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"      - name: Manage baremetal nodes"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"d902a227_d5332fc5","line":54,"range":{"start_line":46,"start_character":0,"end_line":54,"end_character":70},"updated":"2024-04-03 09:47:19.000000000","message":"I\u0027m wondering if we could be a bit more flexible here. e.g. allow nodes to define higher level node attributes, e.g.\n\nironic_driver: ...\nironic_driver_info:\n  redfish_address: ...\n  redfish_username: ...\nironic_resource_class: ...\nironic_properties:\n  capabilities: ...\n  cpu: ...","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"dfc60786da490adf298a8979bc7aedd5a7f20f96","unresolved":true,"context_lines":[{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":46,"context_line":"            --driver redfish \\"},{"line_number":47,"context_line":"            --driver-info redfish_address\u003d{{ ipmi_address }} \\"},{"line_number":48,"context_line":"            --driver-info redfish_system_id\u003d{{ redfish_system_id }} \\"},{"line_number":49,"context_line":"            --driver-info redfish_username\u003d{{ redfish_username }} \\"},{"line_number":50,"context_line":"            --driver-info redfish_password\u003d{{ redfish_password }} \\"},{"line_number":51,"context_line":"            --driver-info redfish_verify_ca\u003d{{ redfish_verify_ca }} \\"},{"line_number":52,"context_line":"            --driver-info ipmi_address\u003d{{ ipmi_address }} \\"},{"line_number":53,"context_line":"            --resource-class {{ resource_class }} \\"},{"line_number":54,"context_line":"            --property capabilities\u003d\u0027boot_option:local,boot_mode:uefi\u0027"},{"line_number":55,"context_line":"        when: node_list.rc !\u003d 0"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"      - name: Manage baremetal nodes"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3b5943b3_8857b33f","line":54,"range":{"start_line":46,"start_character":0,"end_line":54,"end_character":70},"in_reply_to":"1707cafe_2bdb1aa0","updated":"2024-05-02 08:24:55.000000000","message":"Ignore my complication with adding it kayobe as this probably doesn\u0027t gain us that much. I vote for the single variable for properties and driver_info. Then the example would be something like:\n\n    [r1:vars]\n    ironic_driver\u003dredfish\n    ironic_driver_info\u003d{\"redfish_system_id\": \"{{ redfish_system_id }}\", \"redfish_username\": \"{{ redfish_username }}\", \"redfish_password\": \"{{ redfish_password }}\", \"redfish_verify_ca\": \"{{ redfish_verify_ca }}\", \"ipmi_address\": \"{{ ipmi_address }}\"}\n    ironic_properties\u003d{\"capabilities\": \"boot_option:local,boot_mode:uefi\"}\n    redfish_system_id\u003d/redfish/v1/Systems/System.Embedded.1\n    redfish_verify_ca\u003d{{ inspector_rule_var_redfish_verify_ca }}\n    redfish_username\u003d{{ inspector_redfish_username }}\n    redfish_password\u003d{{ inspector_redfish_password }}","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"01cdbbe3a7bc7efd15633dcbb87c7c0daff6bacb","unresolved":true,"context_lines":[{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":46,"context_line":"            --driver redfish \\"},{"line_number":47,"context_line":"            --driver-info redfish_address\u003d{{ ipmi_address }} \\"},{"line_number":48,"context_line":"            --driver-info redfish_system_id\u003d{{ redfish_system_id }} \\"},{"line_number":49,"context_line":"            --driver-info redfish_username\u003d{{ redfish_username }} \\"},{"line_number":50,"context_line":"            --driver-info redfish_password\u003d{{ redfish_password }} \\"},{"line_number":51,"context_line":"            --driver-info redfish_verify_ca\u003d{{ redfish_verify_ca }} \\"},{"line_number":52,"context_line":"            --driver-info ipmi_address\u003d{{ ipmi_address }} \\"},{"line_number":53,"context_line":"            --resource-class {{ resource_class }} \\"},{"line_number":54,"context_line":"            --property capabilities\u003d\u0027boot_option:local,boot_mode:uefi\u0027"},{"line_number":55,"context_line":"        when: node_list.rc !\u003d 0"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"      - name: Manage baremetal nodes"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9640561f_5ab67444","line":54,"range":{"start_line":46,"start_character":0,"end_line":54,"end_character":70},"in_reply_to":"2a57224b_fbe5cc90","updated":"2024-04-18 09:58:09.000000000","message":"I like Mark\u0027s idea of being more flexible with the selection of driver, but I guess we could always add these additional variables in a backwards compatible way. We might want to standardise on using on Mark\u0027s suggested naming scheme now though i.e using the ironic_ prefix. I think we could release it in an experimental form (with it marked as such in the release note and documentation) with just redfish support.\n\n+1 for making capabilities a variable.","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ffba26a69dfebbf31b65c4434987481aa6b9d568","unresolved":true,"context_lines":[{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":46,"context_line":"            --driver redfish \\"},{"line_number":47,"context_line":"            --driver-info redfish_address\u003d{{ ipmi_address }} \\"},{"line_number":48,"context_line":"            --driver-info redfish_system_id\u003d{{ redfish_system_id }} \\"},{"line_number":49,"context_line":"            --driver-info redfish_username\u003d{{ redfish_username }} \\"},{"line_number":50,"context_line":"            --driver-info redfish_password\u003d{{ redfish_password }} \\"},{"line_number":51,"context_line":"            --driver-info redfish_verify_ca\u003d{{ redfish_verify_ca }} \\"},{"line_number":52,"context_line":"            --driver-info ipmi_address\u003d{{ ipmi_address }} \\"},{"line_number":53,"context_line":"            --resource-class {{ resource_class }} \\"},{"line_number":54,"context_line":"            --property capabilities\u003d\u0027boot_option:local,boot_mode:uefi\u0027"},{"line_number":55,"context_line":"        when: node_list.rc !\u003d 0"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"      - name: Manage baremetal nodes"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"2a57224b_fbe5cc90","line":54,"range":{"start_line":46,"start_character":0,"end_line":54,"end_character":70},"in_reply_to":"312b7da6_6821915f","updated":"2024-04-12 16:26:43.000000000","message":"I think we should ensure capabilities is defined via some extra_var or similarly with this above value being the default.\n\nCan we not get this tested by more people in its current form, as I think this is useful for most cases already, via inventory overrides, group_vars, etc, in the usual way. At least where we are using it, all these values are defined per inventory group.","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"28a575ce26d6dc3aa0e884e02e4a7b87705a0b6a","unresolved":true,"context_lines":[{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":46,"context_line":"            --driver redfish \\"},{"line_number":47,"context_line":"            --driver-info redfish_address\u003d{{ ipmi_address }} \\"},{"line_number":48,"context_line":"            --driver-info redfish_system_id\u003d{{ redfish_system_id }} \\"},{"line_number":49,"context_line":"            --driver-info redfish_username\u003d{{ redfish_username }} \\"},{"line_number":50,"context_line":"            --driver-info redfish_password\u003d{{ redfish_password }} \\"},{"line_number":51,"context_line":"            --driver-info redfish_verify_ca\u003d{{ redfish_verify_ca }} \\"},{"line_number":52,"context_line":"            --driver-info ipmi_address\u003d{{ ipmi_address }} \\"},{"line_number":53,"context_line":"            --resource-class {{ resource_class }} \\"},{"line_number":54,"context_line":"            --property capabilities\u003d\u0027boot_option:local,boot_mode:uefi\u0027"},{"line_number":55,"context_line":"        when: node_list.rc !\u003d 0"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"      - name: Manage baremetal nodes"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"b642d0b8_14104fd7","line":54,"range":{"start_line":46,"start_character":0,"end_line":54,"end_character":70},"in_reply_to":"3b5943b3_8857b33f","updated":"2024-05-03 10:32:52.000000000","message":"FWIW, I hate that the Kayobe operator now needs to know that ipmi_address needs to be added along with redfish_address to not break ironic-inspector finding this host. And similar things.\n\nBut I get that we don\u0027t one one million different variables here.\n\nI am just keen we get something in we can iterate on, so keeping the variable footprint small to start with makes sense.","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"2a4cd101b0d78b46e04c6d9f6a8322e62e6c7314","unresolved":true,"context_lines":[{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":46,"context_line":"            --driver redfish \\"},{"line_number":47,"context_line":"            --driver-info redfish_address\u003d{{ ipmi_address }} \\"},{"line_number":48,"context_line":"            --driver-info redfish_system_id\u003d{{ redfish_system_id }} \\"},{"line_number":49,"context_line":"            --driver-info redfish_username\u003d{{ redfish_username }} \\"},{"line_number":50,"context_line":"            --driver-info redfish_password\u003d{{ redfish_password }} \\"},{"line_number":51,"context_line":"            --driver-info redfish_verify_ca\u003d{{ redfish_verify_ca }} \\"},{"line_number":52,"context_line":"            --driver-info ipmi_address\u003d{{ ipmi_address }} \\"},{"line_number":53,"context_line":"            --resource-class {{ resource_class }} \\"},{"line_number":54,"context_line":"            --property capabilities\u003d\u0027boot_option:local,boot_mode:uefi\u0027"},{"line_number":55,"context_line":"        when: node_list.rc !\u003d 0"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"      - name: Manage baremetal nodes"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"687adb3b_29751817","line":54,"range":{"start_line":46,"start_character":0,"end_line":54,"end_character":70},"in_reply_to":"3b5943b3_8857b33f","updated":"2024-05-03 10:31:24.000000000","message":"Updated with a single variable approach, an example layout is in bare-metal.rst","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8fd594bc613672afa61d205732e6bdf5bc96f5e6","unresolved":true,"context_lines":[{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":46,"context_line":"            --driver redfish \\"},{"line_number":47,"context_line":"            --driver-info redfish_address\u003d{{ ipmi_address }} \\"},{"line_number":48,"context_line":"            --driver-info redfish_system_id\u003d{{ redfish_system_id }} \\"},{"line_number":49,"context_line":"            --driver-info redfish_username\u003d{{ redfish_username }} \\"},{"line_number":50,"context_line":"            --driver-info redfish_password\u003d{{ redfish_password }} \\"},{"line_number":51,"context_line":"            --driver-info redfish_verify_ca\u003d{{ redfish_verify_ca }} \\"},{"line_number":52,"context_line":"            --driver-info ipmi_address\u003d{{ ipmi_address }} \\"},{"line_number":53,"context_line":"            --resource-class {{ resource_class }} \\"},{"line_number":54,"context_line":"            --property capabilities\u003d\u0027boot_option:local,boot_mode:uefi\u0027"},{"line_number":55,"context_line":"        when: node_list.rc !\u003d 0"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"      - name: Manage baremetal nodes"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"95d1d751_a5d344fb","line":54,"range":{"start_line":46,"start_character":0,"end_line":54,"end_character":70},"in_reply_to":"7e68d72d_8e9458a8","updated":"2024-04-29 13:34:47.000000000","message":"Reopening this one. I\u0027d like to get agreement on whether to have separate variables for each driver_info field or whether to have a single complex ironic_driver_info variable.\n\nIf we have a separate variable for every driver info field that means kayobe needs explicit support for each one. That doesn\u0027t scale well, and would be hard to maintain over time. It would be quite annoying to want to use a field and find that kayobe doesn\u0027t support it.\n\nWe could potentially do the same for properties, with capabilities being an item within the properties object.\n\nIf it\u0027s not clear what I\u0027m talking about here please get in touch 😊","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"5b2569d7076e717bcd81462cf1925fa72b585a09","unresolved":true,"context_lines":[{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":46,"context_line":"            --driver redfish \\"},{"line_number":47,"context_line":"            --driver-info redfish_address\u003d{{ ipmi_address }} \\"},{"line_number":48,"context_line":"            --driver-info redfish_system_id\u003d{{ redfish_system_id }} \\"},{"line_number":49,"context_line":"            --driver-info redfish_username\u003d{{ redfish_username }} \\"},{"line_number":50,"context_line":"            --driver-info redfish_password\u003d{{ redfish_password }} \\"},{"line_number":51,"context_line":"            --driver-info redfish_verify_ca\u003d{{ redfish_verify_ca }} \\"},{"line_number":52,"context_line":"            --driver-info ipmi_address\u003d{{ ipmi_address }} \\"},{"line_number":53,"context_line":"            --resource-class {{ resource_class }} \\"},{"line_number":54,"context_line":"            --property capabilities\u003d\u0027boot_option:local,boot_mode:uefi\u0027"},{"line_number":55,"context_line":"        when: node_list.rc !\u003d 0"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"      - name: Manage baremetal nodes"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1707cafe_2bdb1aa0","line":54,"range":{"start_line":46,"start_character":0,"end_line":54,"end_character":70},"in_reply_to":"95d1d751_a5d344fb","updated":"2024-05-01 10:13:37.000000000","message":"I suppose the single variable approach would be more flexible and would allow us to make the driver a variable now without having to test every combination. Slightly less friendly for the end user though, but they could always define something like:\n\n    redfish_driver_info:\n      redfish_system_id: \"{{ redfish_system_id }}\"\n      redfish_username: \"{{ redfish_username }}\"\n      redfish_password: \"{{ redfish_password }}\"\n      redfish_verify_ca: \"{{ redfish_verify_ca }}\"\n      ipmi_address: \"{{ ipmi_address }}\"\n\nin inventory/group_vars/all/redfish and then do:\n\n    [r1.vars]\n    ironic_driver\u003dredfish\n    ironic_driver_info: \"{{ redfish_driver_info }}\"\n    ironic_redfish_system_id\u003d/redfish/v1/Systems/System.Embedded.1\n    ironic_redfish_verify_ca\u003d{{ inspector_rule_var_redfish_verify_ca }}\n    ironic_redfish_username\u003d{{ inspector_redfish_username }}\n    ironic_redfish_password\u003d{{ inspector_redfish_password }}\n\nto use the same style configuration as before. Potentially you could even add that to kayobe and do something like:\n\n    ironic_default_driver_info:\n      redfish: \"{{ redfish_driver_info }}\"\n    \n    # Might need a way to filter unset values though\n    ironic_driver_info: \"{{ ironic_default_driver_info[driver] | default({}) }}\"\n\nIt sounds like redfish is the recommended driver these days, so it makes sense to make it convenient to use.","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"65a4799747e0886f8c8f9b0b2e875058fa4a0a79","unresolved":false,"context_lines":[{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":46,"context_line":"            --driver redfish \\"},{"line_number":47,"context_line":"            --driver-info redfish_address\u003d{{ ipmi_address }} \\"},{"line_number":48,"context_line":"            --driver-info redfish_system_id\u003d{{ redfish_system_id }} \\"},{"line_number":49,"context_line":"            --driver-info redfish_username\u003d{{ redfish_username }} \\"},{"line_number":50,"context_line":"            --driver-info redfish_password\u003d{{ redfish_password }} \\"},{"line_number":51,"context_line":"            --driver-info redfish_verify_ca\u003d{{ redfish_verify_ca }} \\"},{"line_number":52,"context_line":"            --driver-info ipmi_address\u003d{{ ipmi_address }} \\"},{"line_number":53,"context_line":"            --resource-class {{ resource_class }} \\"},{"line_number":54,"context_line":"            --property capabilities\u003d\u0027boot_option:local,boot_mode:uefi\u0027"},{"line_number":55,"context_line":"        when: node_list.rc !\u003d 0"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"      - name: Manage baremetal nodes"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7e68d72d_8e9458a8","line":54,"range":{"start_line":46,"start_character":0,"end_line":54,"end_character":70},"in_reply_to":"9640561f_5ab67444","updated":"2024-04-18 11:00:30.000000000","message":"Done","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e9146aa21aa6c983374292061f6c51877504d656","unresolved":true,"context_lines":[{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":46,"context_line":"            --driver redfish \\"},{"line_number":47,"context_line":"            --driver-info redfish_address\u003d{{ ipmi_address }} \\"},{"line_number":48,"context_line":"            --driver-info redfish_system_id\u003d{{ redfish_system_id }} \\"},{"line_number":49,"context_line":"            --driver-info redfish_username\u003d{{ redfish_username }} \\"},{"line_number":50,"context_line":"            --driver-info redfish_password\u003d{{ redfish_password }} \\"},{"line_number":51,"context_line":"            --driver-info redfish_verify_ca\u003d{{ redfish_verify_ca }} \\"},{"line_number":52,"context_line":"            --driver-info ipmi_address\u003d{{ ipmi_address }} \\"},{"line_number":53,"context_line":"            --resource-class {{ resource_class }} \\"},{"line_number":54,"context_line":"            --property capabilities\u003d\u0027boot_option:local,boot_mode:uefi\u0027"},{"line_number":55,"context_line":"        when: node_list.rc !\u003d 0"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"      - name: Manage baremetal nodes"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"02bdecf0_1e687d65","line":54,"range":{"start_line":46,"start_character":0,"end_line":54,"end_character":70},"in_reply_to":"af667d8c_1816d3f1","updated":"2024-05-15 16:10:29.000000000","message":"I\u0027m happy to accept this patch with the ipmi_address references and remove them later if we can.","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a6cfb820aadb5908c10bdaeb50132c4eacfa81c5","unresolved":true,"context_lines":[{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":46,"context_line":"            --driver redfish \\"},{"line_number":47,"context_line":"            --driver-info redfish_address\u003d{{ ipmi_address }} \\"},{"line_number":48,"context_line":"            --driver-info redfish_system_id\u003d{{ redfish_system_id }} \\"},{"line_number":49,"context_line":"            --driver-info redfish_username\u003d{{ redfish_username }} \\"},{"line_number":50,"context_line":"            --driver-info redfish_password\u003d{{ redfish_password }} \\"},{"line_number":51,"context_line":"            --driver-info redfish_verify_ca\u003d{{ redfish_verify_ca }} \\"},{"line_number":52,"context_line":"            --driver-info ipmi_address\u003d{{ ipmi_address }} \\"},{"line_number":53,"context_line":"            --resource-class {{ resource_class }} \\"},{"line_number":54,"context_line":"            --property capabilities\u003d\u0027boot_option:local,boot_mode:uefi\u0027"},{"line_number":55,"context_line":"        when: node_list.rc !\u003d 0"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"      - name: Manage baremetal nodes"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"af667d8c_1816d3f1","line":54,"range":{"start_line":46,"start_character":0,"end_line":54,"end_character":70},"in_reply_to":"b642d0b8_14104fd7","updated":"2024-05-15 15:58:05.000000000","message":"AFAICT inspector includes redfish_address in its ipmi_address_fields config since september 2020. This is used when looking up the node. Am I missing something?","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"56942b4335cdba70badf90170ba00b2bc7fe503a","unresolved":true,"context_lines":[{"line_number":43,"context_line":"          cmd: |"},{"line_number":44,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":45,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":46,"context_line":"            --driver redfish \\"},{"line_number":47,"context_line":"            --driver-info redfish_address\u003d{{ ipmi_address }} \\"},{"line_number":48,"context_line":"            --driver-info redfish_system_id\u003d{{ redfish_system_id }} \\"},{"line_number":49,"context_line":"            --driver-info redfish_username\u003d{{ redfish_username }} \\"},{"line_number":50,"context_line":"            --driver-info redfish_password\u003d{{ redfish_password }} \\"},{"line_number":51,"context_line":"            --driver-info redfish_verify_ca\u003d{{ redfish_verify_ca }} \\"},{"line_number":52,"context_line":"            --driver-info ipmi_address\u003d{{ ipmi_address }} \\"},{"line_number":53,"context_line":"            --resource-class {{ resource_class }} \\"},{"line_number":54,"context_line":"            --property capabilities\u003d\u0027boot_option:local,boot_mode:uefi\u0027"},{"line_number":55,"context_line":"        when: node_list.rc !\u003d 0"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"      - name: Manage baremetal nodes"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"312b7da6_6821915f","line":54,"range":{"start_line":46,"start_character":0,"end_line":54,"end_character":70},"in_reply_to":"d902a227_d5332fc5","updated":"2024-04-05 10:52:10.000000000","message":"Most of those variables are handled in the inventory currently, do we want to handle those globally?\n\nWe should probably have more options defined here, but I don\u0027t know if we should support other drivers outside of Redfish (atleast at the experimental stage).","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8fd594bc613672afa61d205732e6bdf5bc96f5e6","unresolved":true,"context_lines":[{"line_number":28,"context_line":"      ansible.builtin.fail:"},{"line_number":29,"context_line":"        msg: This node uses an unsupported or undefined driver, only Redfish is supported."},{"line_number":30,"context_line":"      when:"},{"line_number":31,"context_line":"        - ironic_driver | default (\u0027\u0027) not in [\u0027redfish\u0027]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    - block:"},{"line_number":34,"context_line":"      - name: List baremetal nodes"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"cc492f8a_3c174e16","line":31,"updated":"2024-04-29 13:34:47.000000000","message":"This hides a different error where ironic_driver is undefined.","commit_id":"9402278b82726b7e67e47b23cbbd037109200af4"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"f82e7053f9d429a3f0e21ffca11b19eb0c66b28b","unresolved":true,"context_lines":[{"line_number":28,"context_line":"      ansible.builtin.fail:"},{"line_number":29,"context_line":"        msg: This node uses an unsupported or undefined driver, only Redfish is supported."},{"line_number":30,"context_line":"      when:"},{"line_number":31,"context_line":"        - ironic_driver | default (\u0027\u0027) not in [\u0027redfish\u0027]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    - block:"},{"line_number":34,"context_line":"      - name: List baremetal nodes"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"fb84c291_8f9277b5","line":31,"in_reply_to":"cc492f8a_3c174e16","updated":"2024-05-03 10:32:31.000000000","message":"Done","commit_id":"9402278b82726b7e67e47b23cbbd037109200af4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a6cfb820aadb5908c10bdaeb50132c4eacfa81c5","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      ansible.builtin.fail:"},{"line_number":29,"context_line":"        msg: This node uses an unsupported or undefined driver, only Redfish is supported."},{"line_number":30,"context_line":"      when:"},{"line_number":31,"context_line":"        - ironic_driver | default (\u0027\u0027) not in [\u0027redfish\u0027]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    - block:"},{"line_number":34,"context_line":"      - name: List baremetal nodes"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"6552169e_4421cfcc","line":31,"in_reply_to":"fb84c291_8f9277b5","updated":"2024-05-15 15:58:05.000000000","message":"Done","commit_id":"9402278b82726b7e67e47b23cbbd037109200af4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8fd594bc613672afa61d205732e6bdf5bc96f5e6","unresolved":true,"context_lines":[{"line_number":49,"context_line":"          cmd: |"},{"line_number":50,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":51,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":52,"context_line":"            --driver redfish \\"},{"line_number":53,"context_line":"            --driver-info redfish_address\u003d{{ ipmi_address }} \\"},{"line_number":54,"context_line":"            --driver-info redfish_system_id\u003d{{ ironic_redfish_system_id }} \\"},{"line_number":55,"context_line":"            --driver-info redfish_username\u003d{{ ironic_redfish_username }} \\"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"7b8bb226_5619fcb7","line":52,"updated":"2024-04-29 13:34:47.000000000","message":"This seems unnecessarily limited to me. e.g. We often need to use the idrac hardware type with idrac-redfish interfaces in order to get proper BIOS and RAID support on Dell hardware. It would work with the order options used here, assuming the correct interfaces are defined in ironic.conf.","commit_id":"9402278b82726b7e67e47b23cbbd037109200af4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a6cfb820aadb5908c10bdaeb50132c4eacfa81c5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"          cmd: |"},{"line_number":50,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":51,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":52,"context_line":"            --driver redfish \\"},{"line_number":53,"context_line":"            --driver-info redfish_address\u003d{{ ipmi_address }} \\"},{"line_number":54,"context_line":"            --driver-info redfish_system_id\u003d{{ ironic_redfish_system_id }} \\"},{"line_number":55,"context_line":"            --driver-info redfish_username\u003d{{ ironic_redfish_username }} \\"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"0d8c6393_3f351c3e","line":52,"in_reply_to":"5ca8e7e7_2fce3716","updated":"2024-05-15 15:58:05.000000000","message":"Done","commit_id":"9402278b82726b7e67e47b23cbbd037109200af4"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"28a575ce26d6dc3aa0e884e02e4a7b87705a0b6a","unresolved":true,"context_lines":[{"line_number":49,"context_line":"          cmd: |"},{"line_number":50,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":51,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":52,"context_line":"            --driver redfish \\"},{"line_number":53,"context_line":"            --driver-info redfish_address\u003d{{ ipmi_address }} \\"},{"line_number":54,"context_line":"            --driver-info redfish_system_id\u003d{{ ironic_redfish_system_id }} \\"},{"line_number":55,"context_line":"            --driver-info redfish_username\u003d{{ ironic_redfish_username }} \\"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"5ca8e7e7_2fce3716","line":52,"in_reply_to":"7b8bb226_5619fcb7","updated":"2024-05-03 10:32:52.000000000","message":"The idea was to start small here, and add extra drivers as we have the ability to test the different drivers. For sure this should expand beyond just redfish.","commit_id":"9402278b82726b7e67e47b23cbbd037109200af4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8fd594bc613672afa61d205732e6bdf5bc96f5e6","unresolved":true,"context_lines":[{"line_number":51,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":52,"context_line":"            --driver redfish \\"},{"line_number":53,"context_line":"            --driver-info redfish_address\u003d{{ ipmi_address }} \\"},{"line_number":54,"context_line":"            --driver-info redfish_system_id\u003d{{ ironic_redfish_system_id }} \\"},{"line_number":55,"context_line":"            --driver-info redfish_username\u003d{{ ironic_redfish_username }} \\"},{"line_number":56,"context_line":"            --driver-info redfish_password\u003d{{ ironic_redfish_password }} \\"},{"line_number":57,"context_line":"            --driver-info redfish_verify_ca\u003d{{ ironic_redfish_verify_ca }} \\"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"43acfa5f_64f971f4","line":54,"updated":"2024-04-29 13:34:47.000000000","message":"These variables don\u0027t have defaults, so are liable to explode if undefined. It would be sensible to have an assert task before this one to check anything that doesn\u0027t have a default.\n\ne.g. assert that X is defined","commit_id":"9402278b82726b7e67e47b23cbbd037109200af4"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"f82e7053f9d429a3f0e21ffca11b19eb0c66b28b","unresolved":true,"context_lines":[{"line_number":51,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":52,"context_line":"            --driver redfish \\"},{"line_number":53,"context_line":"            --driver-info redfish_address\u003d{{ ipmi_address }} \\"},{"line_number":54,"context_line":"            --driver-info redfish_system_id\u003d{{ ironic_redfish_system_id }} \\"},{"line_number":55,"context_line":"            --driver-info redfish_username\u003d{{ ironic_redfish_username }} \\"},{"line_number":56,"context_line":"            --driver-info redfish_password\u003d{{ ironic_redfish_password }} \\"},{"line_number":57,"context_line":"            --driver-info redfish_verify_ca\u003d{{ ironic_redfish_verify_ca }} \\"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"604a969e_1962daa0","line":54,"in_reply_to":"43acfa5f_64f971f4","updated":"2024-05-03 10:32:31.000000000","message":"Added an assert task","commit_id":"9402278b82726b7e67e47b23cbbd037109200af4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a6cfb820aadb5908c10bdaeb50132c4eacfa81c5","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":52,"context_line":"            --driver redfish \\"},{"line_number":53,"context_line":"            --driver-info redfish_address\u003d{{ ipmi_address }} \\"},{"line_number":54,"context_line":"            --driver-info redfish_system_id\u003d{{ ironic_redfish_system_id }} \\"},{"line_number":55,"context_line":"            --driver-info redfish_username\u003d{{ ironic_redfish_username }} \\"},{"line_number":56,"context_line":"            --driver-info redfish_password\u003d{{ ironic_redfish_password }} \\"},{"line_number":57,"context_line":"            --driver-info redfish_verify_ca\u003d{{ ironic_redfish_verify_ca }} \\"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"ca892174_ba2f173b","line":54,"in_reply_to":"604a969e_1962daa0","updated":"2024-05-15 15:58:05.000000000","message":"Done","commit_id":"9402278b82726b7e67e47b23cbbd037109200af4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"13e143913e4dde9feb6a7b76bef11a2461560d42","unresolved":true,"context_lines":[{"line_number":37,"context_line":"      ansible.builtin.fail:"},{"line_number":38,"context_line":"        msg: This node uses an unsupported driver, only Redfish is supported."},{"line_number":39,"context_line":"      when:"},{"line_number":40,"context_line":"        - ironic_driver not in [\u0027redfish\u0027]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - block:"},{"line_number":43,"context_line":"      - name: List baremetal nodes"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"0b71de7e_b592e63e","line":40,"updated":"2024-05-13 14:49:27.000000000","message":"I don\u0027t think we need to limit it like this. Having generic high-level variables like ironic_driver_info means we should support be able to most drivers.","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"b71b9b380827befa8ec110c6fbadad4c5b7e02ec","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      ansible.builtin.fail:"},{"line_number":38,"context_line":"        msg: This node uses an unsupported driver, only Redfish is supported."},{"line_number":39,"context_line":"      when:"},{"line_number":40,"context_line":"        - ironic_driver not in [\u0027redfish\u0027]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - block:"},{"line_number":43,"context_line":"      - name: List baremetal nodes"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"d606f263_7a7544c1","line":40,"in_reply_to":"0b71de7e_b592e63e","updated":"2024-05-15 14:30:24.000000000","message":"Done","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"13e143913e4dde9feb6a7b76bef11a2461560d42","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        - ironic_driver not in [\u0027redfish\u0027]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - block:"},{"line_number":43,"context_line":"      - name: List baremetal nodes"},{"line_number":44,"context_line":"        ansible.builtin.command:"},{"line_number":45,"context_line":"          cmd: \"{{ venv }}/bin/openstack baremetal node show {{ inventory_hostname }}\""},{"line_number":46,"context_line":"        register: node_show"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"e84aad96_a58bd32d","line":43,"updated":"2024-05-13 14:49:27.000000000","message":"nit: Show baremetal node","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"41a8a5d2c016d9d9f477d0bb37dc18dfcc01d04c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        - ironic_driver not in [\u0027redfish\u0027]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - block:"},{"line_number":43,"context_line":"      - name: List baremetal nodes"},{"line_number":44,"context_line":"        ansible.builtin.command:"},{"line_number":45,"context_line":"          cmd: \"{{ venv }}/bin/openstack baremetal node show {{ inventory_hostname }}\""},{"line_number":46,"context_line":"        register: node_show"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"652deb12_b718b516","line":43,"in_reply_to":"e84aad96_a58bd32d","updated":"2024-05-15 14:01:40.000000000","message":"Done","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"13e143913e4dde9feb6a7b76bef11a2461560d42","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        ansible.builtin.command:"},{"line_number":45,"context_line":"          cmd: \"{{ venv }}/bin/openstack baremetal node show {{ inventory_hostname }}\""},{"line_number":46,"context_line":"        register: node_show"},{"line_number":47,"context_line":"        failed_when: false"},{"line_number":48,"context_line":"        changed_when: false"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"      # NOTE: The openstack.cloud.baremetal_node module cannot be used in this"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"6e4a5705_0a67f94e","line":47,"updated":"2024-05-13 14:49:27.000000000","message":"This is still hiding potential errors. How about:\n\n    failed_when:\n      - node_show.rc !\u003d 0\n      - \u0027\"Not Found\" not in node_show.stdout\u0027","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"41a8a5d2c016d9d9f477d0bb37dc18dfcc01d04c","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        ansible.builtin.command:"},{"line_number":45,"context_line":"          cmd: \"{{ venv }}/bin/openstack baremetal node show {{ inventory_hostname }}\""},{"line_number":46,"context_line":"        register: node_show"},{"line_number":47,"context_line":"        failed_when: false"},{"line_number":48,"context_line":"        changed_when: false"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"      # NOTE: The openstack.cloud.baremetal_node module cannot be used in this"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"8747e07c_b009b8b8","line":47,"in_reply_to":"6e4a5705_0a67f94e","updated":"2024-05-15 14:01:40.000000000","message":"Changed \u0027Not Found\u0027 to HTTP 404, the former didn\u0027t appear to be an exact substring in the command output when testing the error.\n\nAlso changed to using stderr, stdout was empty in testing.","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a6cfb820aadb5908c10bdaeb50132c4eacfa81c5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        ansible.builtin.command:"},{"line_number":45,"context_line":"          cmd: \"{{ venv }}/bin/openstack baremetal node show {{ inventory_hostname }}\""},{"line_number":46,"context_line":"        register: node_show"},{"line_number":47,"context_line":"        failed_when: false"},{"line_number":48,"context_line":"        changed_when: false"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"      # NOTE: The openstack.cloud.baremetal_node module cannot be used in this"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"8de5abf8_c57ac571","line":47,"in_reply_to":"8747e07c_b009b8b8","updated":"2024-05-15 15:58:05.000000000","message":"Done","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"13e143913e4dde9feb6a7b76bef11a2461560d42","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        changed_when: false"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"      # NOTE: The openstack.cloud.baremetal_node module cannot be used in this"},{"line_number":51,"context_line":"      # script due to requiring a MAC address pre-defined, instead, this should"},{"line_number":52,"context_line":"      # be discovered by inpsection following this script."},{"line_number":53,"context_line":"      #"},{"line_number":54,"context_line":"      # NOTE: IPMI address must be passed with Redfish address to ensure existing"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"5dba32ae_0e9cedeb","line":51,"updated":"2024-05-13 14:49:27.000000000","message":"FWIW, that doesn\u0027t seem to be the case AFAICT in the collection and openstacksdk. We can come back to it later though.","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"13e143913e4dde9feb6a7b76bef11a2461560d42","unresolved":true,"context_lines":[{"line_number":59,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":60,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":61,"context_line":"            --driver {{ ironic_driver }} \\"},{"line_number":62,"context_line":"            {% for driver_info in ironic_driver_info %}"},{"line_number":63,"context_line":"            --driver-info {{ driver_info.key }}\u003d{{ driver_info }} \\"},{"line_number":64,"context_line":"            {% endfor %}"},{"line_number":65,"context_line":"            {% for property in ironic_properties %}"},{"line_number":66,"context_line":"            --property {{ property.key }}\u003d{{ property }} \\"},{"line_number":67,"context_line":"            {% endfor %}"},{"line_number":68,"context_line":"            --resource-class {{ ironic_resource_class }}"},{"line_number":69,"context_line":"        when:"},{"line_number":70,"context_line":"          - node_show.rc !\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"2cbb2d50_d76b61a1","line":67,"range":{"start_line":62,"start_character":0,"end_line":67,"end_character":24},"updated":"2024-05-13 14:49:27.000000000","message":"I don\u0027t think this works. The for loop iterates over the keys of the dict, so doing .key on it will fail (confirmed in a local playbook).\n\nYou could do something like this:\n\n    {% for key, value in ironic_driver_info.items() %}\n    --driver-info {{ key }}\u003d{{  value }}\n    {% endfor %}\n    \nBut of course please test first.","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"41a8a5d2c016d9d9f477d0bb37dc18dfcc01d04c","unresolved":true,"context_lines":[{"line_number":59,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":60,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":61,"context_line":"            --driver {{ ironic_driver }} \\"},{"line_number":62,"context_line":"            {% for driver_info in ironic_driver_info %}"},{"line_number":63,"context_line":"            --driver-info {{ driver_info.key }}\u003d{{ driver_info }} \\"},{"line_number":64,"context_line":"            {% endfor %}"},{"line_number":65,"context_line":"            {% for property in ironic_properties %}"},{"line_number":66,"context_line":"            --property {{ property.key }}\u003d{{ property }} \\"},{"line_number":67,"context_line":"            {% endfor %}"},{"line_number":68,"context_line":"            --resource-class {{ ironic_resource_class }}"},{"line_number":69,"context_line":"        when:"},{"line_number":70,"context_line":"          - node_show.rc !\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"d0255add_4b18d591","line":67,"range":{"start_line":62,"start_character":0,"end_line":67,"end_character":24},"in_reply_to":"2cbb2d50_d76b61a1","updated":"2024-05-15 14:01:40.000000000","message":"Seems to work in this configuration, thanks!\n\nAlso note the create task has been changed back to the shell module. When testing the command module produced errors when passed the command block, presumably you could use \u0027argv\u0027 with the command module, but shell seems to work fine in any case.","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a6cfb820aadb5908c10bdaeb50132c4eacfa81c5","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            {{ venv }}/bin/openstack baremetal node create \\"},{"line_number":60,"context_line":"            --name {{ inventory_hostname }} \\"},{"line_number":61,"context_line":"            --driver {{ ironic_driver }} \\"},{"line_number":62,"context_line":"            {% for driver_info in ironic_driver_info %}"},{"line_number":63,"context_line":"            --driver-info {{ driver_info.key }}\u003d{{ driver_info }} \\"},{"line_number":64,"context_line":"            {% endfor %}"},{"line_number":65,"context_line":"            {% for property in ironic_properties %}"},{"line_number":66,"context_line":"            --property {{ property.key }}\u003d{{ property }} \\"},{"line_number":67,"context_line":"            {% endfor %}"},{"line_number":68,"context_line":"            --resource-class {{ ironic_resource_class }}"},{"line_number":69,"context_line":"        when:"},{"line_number":70,"context_line":"          - node_show.rc !\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"84244876_9f6a5552","line":67,"range":{"start_line":62,"start_character":0,"end_line":67,"end_character":24},"in_reply_to":"d0255add_4b18d591","updated":"2024-05-15 15:58:05.000000000","message":"I would guess this is due to the line continuation backslashes. It\u0027s not a big deal though.","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"13e143913e4dde9feb6a7b76bef11a2461560d42","unresolved":true,"context_lines":[{"line_number":67,"context_line":"            {% endfor %}"},{"line_number":68,"context_line":"            --resource-class {{ ironic_resource_class }}"},{"line_number":69,"context_line":"        when:"},{"line_number":70,"context_line":"          - node_show.rc !\u003d 0"},{"line_number":71,"context_line":"          - not \u0027\"Not Found\" in node_show.stdout\u0027"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"      - name: Manage baremetal nodes"},{"line_number":74,"context_line":"        ansible.builtin.command:"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"446f405b_5624be85","line":71,"range":{"start_line":70,"start_character":1,"end_line":71,"end_character":49},"updated":"2024-05-13 14:49:27.000000000","message":"Then this could just be\n\n        when:\n          - node_show.rc !\u003d 0","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"41a8a5d2c016d9d9f477d0bb37dc18dfcc01d04c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            {% endfor %}"},{"line_number":68,"context_line":"            --resource-class {{ ironic_resource_class }}"},{"line_number":69,"context_line":"        when:"},{"line_number":70,"context_line":"          - node_show.rc !\u003d 0"},{"line_number":71,"context_line":"          - not \u0027\"Not Found\" in node_show.stdout\u0027"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"      - name: Manage baremetal nodes"},{"line_number":74,"context_line":"        ansible.builtin.command:"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"7594dbb0_fb1616ce","line":71,"range":{"start_line":70,"start_character":1,"end_line":71,"end_character":49},"in_reply_to":"446f405b_5624be85","updated":"2024-05-15 14:01:40.000000000","message":"Done","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"13e143913e4dde9feb6a7b76bef11a2461560d42","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        ansible.builtin.command:"},{"line_number":75,"context_line":"          cmd: \"{{ venv }}/bin/openstack baremetal node manage {{ inventory_hostname }} --wait\""},{"line_number":76,"context_line":"        when:"},{"line_number":77,"context_line":"          - node_show.rc !\u003d 0"},{"line_number":78,"context_line":"          - not \u0027\"Not Found\" in node_show.stdout\u0027"},{"line_number":79,"context_line":"      delegate_to: \"{{ controller_host }}\""},{"line_number":80,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"4de51ad5_2a6d794a","line":77,"updated":"2024-05-13 14:49:27.000000000","message":"Same here.","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"41a8a5d2c016d9d9f477d0bb37dc18dfcc01d04c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        ansible.builtin.command:"},{"line_number":75,"context_line":"          cmd: \"{{ venv }}/bin/openstack baremetal node manage {{ inventory_hostname }} --wait\""},{"line_number":76,"context_line":"        when:"},{"line_number":77,"context_line":"          - node_show.rc !\u003d 0"},{"line_number":78,"context_line":"          - not \u0027\"Not Found\" in node_show.stdout\u0027"},{"line_number":79,"context_line":"      delegate_to: \"{{ controller_host }}\""},{"line_number":80,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"6a1254fd_84932036","line":77,"in_reply_to":"4de51ad5_2a6d794a","updated":"2024-05-15 14:01:40.000000000","message":"Done","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"}],"doc/source/administration/bare-metal.rst":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a6eb560e35227918af7e2c67a8cf858940a47908","unresolved":true,"context_lines":[{"line_number":17,"context_line":"--------"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Nodes can be registered in ironic via kayobe given these nodes are defined in"},{"line_number":20,"context_line":"the kayobe inventory. Only the Redfish driver is supported by this command and"},{"line_number":21,"context_line":"Redfish variables will need to be set in the inventory when preparing nodes for"},{"line_number":22,"context_line":"registration, an example baremetal-compute inventory should look something like this:"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"ca73996f_93b67cda","line":20,"updated":"2024-03-25 16:40:01.000000000","message":"nit: s/ironic/Ironic, s/kayobe/Kayobe","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"8013f7ddd1ee3355e87f1cb20ca450819b8810a1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"--------"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Nodes can be registered in ironic via kayobe given these nodes are defined in"},{"line_number":20,"context_line":"the kayobe inventory. Only the Redfish driver is supported by this command and"},{"line_number":21,"context_line":"Redfish variables will need to be set in the inventory when preparing nodes for"},{"line_number":22,"context_line":"registration, an example baremetal-compute inventory should look something like this:"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"8847bc14_b34760f9","line":20,"in_reply_to":"ca73996f_93b67cda","updated":"2024-04-05 12:54:20.000000000","message":"Done","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a6eb560e35227918af7e2c67a8cf858940a47908","unresolved":true,"context_lines":[{"line_number":21,"context_line":"Redfish variables will need to be set in the inventory when preparing nodes for"},{"line_number":22,"context_line":"registration, an example baremetal-compute inventory should look something like this:"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[r1]"},{"line_number":25,"context_line":"hv100 ipmi_address\u003d1.2.3.4"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[r1.vars]"},{"line_number":28,"context_line":"ironic_driver\u003dredfish"},{"line_number":29,"context_line":"resource_class\u003dexample_resouce_class"},{"line_number":30,"context_line":"redfish_system_id\u003d/redfish/v1/Systems/System.Embedded.1"},{"line_number":31,"context_line":"redfish_verify_ca\u003d{{ inspector_rule_var_redfish_verify_ca }}"},{"line_number":32,"context_line":"redfish_username\u003d{{ inspector_redfish_username }}"},{"line_number":33,"context_line":"redfish_password\u003d{{ inspector_redfish_password }}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"[baremetal-compute:children]"},{"line_number":36,"context_line":"r1"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"When nodes have been added to the inventory and configured correctly, you can begin"},{"line_number":39,"context_line":"enrolling them::"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3e6827a6_e5de1a44","line":36,"range":{"start_line":24,"start_character":0,"end_line":36,"end_character":2},"updated":"2024-03-25 16:40:01.000000000","message":"nit: Please indent","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"8d6706b65395ff86024399fe21118fec8c45c5fd","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Redfish variables will need to be set in the inventory when preparing nodes for"},{"line_number":22,"context_line":"registration, an example baremetal-compute inventory should look something like this:"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[r1]"},{"line_number":25,"context_line":"hv100 ipmi_address\u003d1.2.3.4"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[r1.vars]"},{"line_number":28,"context_line":"ironic_driver\u003dredfish"},{"line_number":29,"context_line":"resource_class\u003dexample_resouce_class"},{"line_number":30,"context_line":"redfish_system_id\u003d/redfish/v1/Systems/System.Embedded.1"},{"line_number":31,"context_line":"redfish_verify_ca\u003d{{ inspector_rule_var_redfish_verify_ca }}"},{"line_number":32,"context_line":"redfish_username\u003d{{ inspector_redfish_username }}"},{"line_number":33,"context_line":"redfish_password\u003d{{ inspector_redfish_password }}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"[baremetal-compute:children]"},{"line_number":36,"context_line":"r1"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"When nodes have been added to the inventory and configured correctly, you can begin"},{"line_number":39,"context_line":"enrolling them::"}],"source_content_type":"text/x-rst","patch_set":19,"id":"2a0fb277_b9004eb0","line":36,"range":{"start_line":24,"start_character":0,"end_line":36,"end_character":2},"in_reply_to":"3e6827a6_e5de1a44","updated":"2024-04-18 09:51:13.000000000","message":"Done","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a6eb560e35227918af7e2c67a8cf858940a47908","unresolved":true,"context_lines":[{"line_number":35,"context_line":"[baremetal-compute:children]"},{"line_number":36,"context_line":"r1"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"When nodes have been added to the inventory and configured correctly, you can begin"},{"line_number":39,"context_line":"enrolling them::"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    (kayobe) $ kayobe baremetal compute register"}],"source_content_type":"text/x-rst","patch_set":19,"id":"f2b0d132_e3f492b4","line":38,"updated":"2024-03-25 16:40:01.000000000","message":"It could be helpful to expand on what `configured correctly` means. Eg. switch configuration, etc","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"2a4cd101b0d78b46e04c6d9f6a8322e62e6c7314","unresolved":false,"context_lines":[{"line_number":35,"context_line":"[baremetal-compute:children]"},{"line_number":36,"context_line":"r1"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"When nodes have been added to the inventory and configured correctly, you can begin"},{"line_number":39,"context_line":"enrolling them::"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    (kayobe) $ kayobe baremetal compute register"}],"source_content_type":"text/x-rst","patch_set":19,"id":"8130a6ac_b8886a7f","line":38,"in_reply_to":"f2b0d132_e3f492b4","updated":"2024-05-03 10:31:24.000000000","message":"Reworded this a bit, let me know if its any better.","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a6eb560e35227918af7e2c67a8cf858940a47908","unresolved":true,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    (kayobe) $ kayobe baremetal compute register"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Inspector is not used to discover nodes and no node inspection will take place on"},{"line_number":44,"context_line":"enrollment, nodes will automatically be placed into ``manageable`` state. To inspect,"},{"line_number":45,"context_line":"you should use ``kayobe baremetal compute inspect`` following enrollment."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"65726492_e3839555","line":43,"updated":"2024-03-25 16:40:01.000000000","message":"It may be helpful to expand on this at the start of the section, describing it as an alternative workflow to discovering nodes via Inspection.","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"2a4cd101b0d78b46e04c6d9f6a8322e62e6c7314","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    (kayobe) $ kayobe baremetal compute register"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Inspector is not used to discover nodes and no node inspection will take place on"},{"line_number":44,"context_line":"enrollment, nodes will automatically be placed into ``manageable`` state. To inspect,"},{"line_number":45,"context_line":"you should use ``kayobe baremetal compute inspect`` following enrollment."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"71dfad47_a7900b13","line":43,"in_reply_to":"65726492_e3839555","updated":"2024-05-03 10:31:24.000000000","message":"Done","commit_id":"dbf6310135d5938449a1b126891e34ff4a83c60c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"13e143913e4dde9feb6a7b76bef11a2461560d42","unresolved":true,"context_lines":[{"line_number":20,"context_line":"through inspection where nodes can be registered in Ironic via kayobe given these"},{"line_number":21,"context_line":"nodes are defined in the Kayobe inventory."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Only the Redfish driver is supported by this command in the experimental release"},{"line_number":24,"context_line":"and Redfish variables will need to be set in the inventory when preparing nodes"},{"line_number":25,"context_line":"for registration, an example baremetal-compute inventory is below:"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"aa4b4385_e4f94590","line":23,"updated":"2024-05-13 14:49:27.000000000","message":"Let\u0027s drop this limitation.","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"b71b9b380827befa8ec110c6fbadad4c5b7e02ec","unresolved":false,"context_lines":[{"line_number":20,"context_line":"through inspection where nodes can be registered in Ironic via kayobe given these"},{"line_number":21,"context_line":"nodes are defined in the Kayobe inventory."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Only the Redfish driver is supported by this command in the experimental release"},{"line_number":24,"context_line":"and Redfish variables will need to be set in the inventory when preparing nodes"},{"line_number":25,"context_line":"for registration, an example baremetal-compute inventory is below:"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":30,"id":"711f90c9_9aaec415","line":23,"in_reply_to":"aa4b4385_e4f94590","updated":"2024-05-15 14:30:24.000000000","message":"Done","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"13e143913e4dde9feb6a7b76bef11a2461560d42","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    [r1.vars]"},{"line_number":33,"context_line":"    ironic_driver\u003dredfish"},{"line_number":34,"context_line":"    ironic_driver_info\u003d{"},{"line_number":35,"context_line":"                        \"redfish_system_id\": \"{{ redfish_system_id }}\","},{"line_number":36,"context_line":"                        \"redfish_username\": \"{{ redfish_username }}\","},{"line_number":37,"context_line":"                        \"redfish_password\": \"{{ redfish_password }}\","}],"source_content_type":"text/x-rst","patch_set":30,"id":"43477aa4_f76f2a50","line":34,"updated":"2024-05-13 14:49:27.000000000","message":"Also needs redfish address?","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"41a8a5d2c016d9d9f477d0bb37dc18dfcc01d04c","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    [r1.vars]"},{"line_number":33,"context_line":"    ironic_driver\u003dredfish"},{"line_number":34,"context_line":"    ironic_driver_info\u003d{"},{"line_number":35,"context_line":"                        \"redfish_system_id\": \"{{ redfish_system_id }}\","},{"line_number":36,"context_line":"                        \"redfish_username\": \"{{ redfish_username }}\","},{"line_number":37,"context_line":"                        \"redfish_password\": \"{{ redfish_password }}\","}],"source_content_type":"text/x-rst","patch_set":30,"id":"c935fdb8_e3340033","line":34,"in_reply_to":"43477aa4_f76f2a50","updated":"2024-05-15 14:01:40.000000000","message":"Done","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"13e143913e4dde9feb6a7b76bef11a2461560d42","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    [r1.vars]"},{"line_number":33,"context_line":"    ironic_driver\u003dredfish"},{"line_number":34,"context_line":"    ironic_driver_info\u003d{"},{"line_number":35,"context_line":"                        \"redfish_system_id\": \"{{ redfish_system_id }}\","},{"line_number":36,"context_line":"                        \"redfish_username\": \"{{ redfish_username }}\","},{"line_number":37,"context_line":"                        \"redfish_password\": \"{{ redfish_password }}\","},{"line_number":38,"context_line":"                        \"redfish_verify_ca\": \"{{ redfish_verify_ca }}\","},{"line_number":39,"context_line":"                        \"ipmi_address\": \"{{ ipmi_address }}\""},{"line_number":40,"context_line":"                        }"},{"line_number":41,"context_line":"    ironic_properties\u003d{"}],"source_content_type":"text/x-rst","patch_set":30,"id":"3034373f_fc014bac","line":38,"range":{"start_line":35,"start_character":0,"end_line":38,"end_character":71},"updated":"2024-05-13 14:49:27.000000000","message":"Do these need an ironic_ prefix?","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"41a8a5d2c016d9d9f477d0bb37dc18dfcc01d04c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    [r1.vars]"},{"line_number":33,"context_line":"    ironic_driver\u003dredfish"},{"line_number":34,"context_line":"    ironic_driver_info\u003d{"},{"line_number":35,"context_line":"                        \"redfish_system_id\": \"{{ redfish_system_id }}\","},{"line_number":36,"context_line":"                        \"redfish_username\": \"{{ redfish_username }}\","},{"line_number":37,"context_line":"                        \"redfish_password\": \"{{ redfish_password }}\","},{"line_number":38,"context_line":"                        \"redfish_verify_ca\": \"{{ redfish_verify_ca }}\","},{"line_number":39,"context_line":"                        \"ipmi_address\": \"{{ ipmi_address }}\""},{"line_number":40,"context_line":"                        }"},{"line_number":41,"context_line":"    ironic_properties\u003d{"}],"source_content_type":"text/x-rst","patch_set":30,"id":"cb4d0b5b_be5b283f","line":38,"range":{"start_line":35,"start_character":0,"end_line":38,"end_character":71},"in_reply_to":"3034373f_fc014bac","updated":"2024-05-15 14:01:40.000000000","message":"Done","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"13e143913e4dde9feb6a7b76bef11a2461560d42","unresolved":true,"context_lines":[{"line_number":39,"context_line":"                        \"ipmi_address\": \"{{ ipmi_address }}\""},{"line_number":40,"context_line":"                        }"},{"line_number":41,"context_line":"    ironic_properties\u003d{"},{"line_number":42,"context_line":"                        \"capabilities\": \"boot_option:local,boot_mode:uefi\""},{"line_number":43,"context_line":"                        }"},{"line_number":44,"context_line":"    ironic_resource_class\u003dexample_resouce_class"},{"line_number":45,"context_line":"    ironic_redfish_system_id\u003d/redfish/v1/Systems/System.Embedded.1"}],"source_content_type":"text/x-rst","patch_set":30,"id":"524948de_0f49c2fd","line":42,"updated":"2024-05-13 14:49:27.000000000","message":"Reference ironic_capabilities?","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"41a8a5d2c016d9d9f477d0bb37dc18dfcc01d04c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                        \"ipmi_address\": \"{{ ipmi_address }}\""},{"line_number":40,"context_line":"                        }"},{"line_number":41,"context_line":"    ironic_properties\u003d{"},{"line_number":42,"context_line":"                        \"capabilities\": \"boot_option:local,boot_mode:uefi\""},{"line_number":43,"context_line":"                        }"},{"line_number":44,"context_line":"    ironic_resource_class\u003dexample_resouce_class"},{"line_number":45,"context_line":"    ironic_redfish_system_id\u003d/redfish/v1/Systems/System.Embedded.1"}],"source_content_type":"text/x-rst","patch_set":30,"id":"4730997c_c82d54f9","line":42,"in_reply_to":"524948de_0f49c2fd","updated":"2024-05-15 14:01:40.000000000","message":"Done","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"13e143913e4dde9feb6a7b76bef11a2461560d42","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    [r1]"},{"line_number":30,"context_line":"    hv100 ipmi_address\u003d1.2.3.4"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    [r1.vars]"},{"line_number":33,"context_line":"    ironic_driver\u003dredfish"},{"line_number":34,"context_line":"    ironic_driver_info\u003d{"},{"line_number":35,"context_line":"                        \"redfish_system_id\": \"{{ redfish_system_id }}\","},{"line_number":36,"context_line":"                        \"redfish_username\": \"{{ redfish_username }}\","},{"line_number":37,"context_line":"                        \"redfish_password\": \"{{ redfish_password }}\","},{"line_number":38,"context_line":"                        \"redfish_verify_ca\": \"{{ redfish_verify_ca }}\","},{"line_number":39,"context_line":"                        \"ipmi_address\": \"{{ ipmi_address }}\""},{"line_number":40,"context_line":"                        }"},{"line_number":41,"context_line":"    ironic_properties\u003d{"},{"line_number":42,"context_line":"                        \"capabilities\": \"boot_option:local,boot_mode:uefi\""},{"line_number":43,"context_line":"                        }"},{"line_number":44,"context_line":"    ironic_resource_class\u003dexample_resouce_class"},{"line_number":45,"context_line":"    ironic_redfish_system_id\u003d/redfish/v1/Systems/System.Embedded.1"},{"line_number":46,"context_line":"    ironic_redfish_verify_ca\u003d{{ inspector_rule_var_redfish_verify_ca }}"},{"line_number":47,"context_line":"    ironic_redfish_username\u003d{{ inspector_redfish_username }}"},{"line_number":48,"context_line":"    ironic_redfish_password\u003d{{ inspector_redfish_password }}"},{"line_number":49,"context_line":"    ironic_capabilities\u003dboot_option:local,boot_mode:uefi"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    [baremetal-compute:children]"},{"line_number":52,"context_line":"    r1"}],"source_content_type":"text/x-rst","patch_set":30,"id":"07444eb2_ac030f0d","line":49,"range":{"start_line":32,"start_character":0,"end_line":49,"end_character":56},"updated":"2024-05-13 14:49:27.000000000","message":"It would be a lot more ergonomic to provide these using YAML group_vars or host_vars. In general only the BMC address and possibly credentials will differ between hosts, so group_vars should work.","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"41a8a5d2c016d9d9f477d0bb37dc18dfcc01d04c","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    [r1]"},{"line_number":30,"context_line":"    hv100 ipmi_address\u003d1.2.3.4"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    [r1.vars]"},{"line_number":33,"context_line":"    ironic_driver\u003dredfish"},{"line_number":34,"context_line":"    ironic_driver_info\u003d{"},{"line_number":35,"context_line":"                        \"redfish_system_id\": \"{{ redfish_system_id }}\","},{"line_number":36,"context_line":"                        \"redfish_username\": \"{{ redfish_username }}\","},{"line_number":37,"context_line":"                        \"redfish_password\": \"{{ redfish_password }}\","},{"line_number":38,"context_line":"                        \"redfish_verify_ca\": \"{{ redfish_verify_ca }}\","},{"line_number":39,"context_line":"                        \"ipmi_address\": \"{{ ipmi_address }}\""},{"line_number":40,"context_line":"                        }"},{"line_number":41,"context_line":"    ironic_properties\u003d{"},{"line_number":42,"context_line":"                        \"capabilities\": \"boot_option:local,boot_mode:uefi\""},{"line_number":43,"context_line":"                        }"},{"line_number":44,"context_line":"    ironic_resource_class\u003dexample_resouce_class"},{"line_number":45,"context_line":"    ironic_redfish_system_id\u003d/redfish/v1/Systems/System.Embedded.1"},{"line_number":46,"context_line":"    ironic_redfish_verify_ca\u003d{{ inspector_rule_var_redfish_verify_ca }}"},{"line_number":47,"context_line":"    ironic_redfish_username\u003d{{ inspector_redfish_username }}"},{"line_number":48,"context_line":"    ironic_redfish_password\u003d{{ inspector_redfish_password }}"},{"line_number":49,"context_line":"    ironic_capabilities\u003dboot_option:local,boot_mode:uefi"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    [baremetal-compute:children]"},{"line_number":52,"context_line":"    r1"}],"source_content_type":"text/x-rst","patch_set":30,"id":"2c97e46c_695bd9f1","line":49,"range":{"start_line":32,"start_character":0,"end_line":49,"end_character":56},"in_reply_to":"07444eb2_ac030f0d","updated":"2024-05-15 14:01:40.000000000","message":"The vars should now reside in group_vars/r1/ironic-vars, hopefully that\u0027s a bit better now.","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e9146aa21aa6c983374292061f6c51877504d656","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    [r1]"},{"line_number":30,"context_line":"    hv100 ipmi_address\u003d1.2.3.4"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    [r1.vars]"},{"line_number":33,"context_line":"    ironic_driver\u003dredfish"},{"line_number":34,"context_line":"    ironic_driver_info\u003d{"},{"line_number":35,"context_line":"                        \"redfish_system_id\": \"{{ redfish_system_id }}\","},{"line_number":36,"context_line":"                        \"redfish_username\": \"{{ redfish_username }}\","},{"line_number":37,"context_line":"                        \"redfish_password\": \"{{ redfish_password }}\","},{"line_number":38,"context_line":"                        \"redfish_verify_ca\": \"{{ redfish_verify_ca }}\","},{"line_number":39,"context_line":"                        \"ipmi_address\": \"{{ ipmi_address }}\""},{"line_number":40,"context_line":"                        }"},{"line_number":41,"context_line":"    ironic_properties\u003d{"},{"line_number":42,"context_line":"                        \"capabilities\": \"boot_option:local,boot_mode:uefi\""},{"line_number":43,"context_line":"                        }"},{"line_number":44,"context_line":"    ironic_resource_class\u003dexample_resouce_class"},{"line_number":45,"context_line":"    ironic_redfish_system_id\u003d/redfish/v1/Systems/System.Embedded.1"},{"line_number":46,"context_line":"    ironic_redfish_verify_ca\u003d{{ inspector_rule_var_redfish_verify_ca }}"},{"line_number":47,"context_line":"    ironic_redfish_username\u003d{{ inspector_redfish_username }}"},{"line_number":48,"context_line":"    ironic_redfish_password\u003d{{ inspector_redfish_password }}"},{"line_number":49,"context_line":"    ironic_capabilities\u003dboot_option:local,boot_mode:uefi"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    [baremetal-compute:children]"},{"line_number":52,"context_line":"    r1"}],"source_content_type":"text/x-rst","patch_set":30,"id":"75c8bb73_04bdc9f0","line":49,"range":{"start_line":32,"start_character":0,"end_line":49,"end_character":56},"in_reply_to":"2c97e46c_695bd9f1","updated":"2024-05-15 16:10:29.000000000","message":"Done","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"13e143913e4dde9feb6a7b76bef11a2461560d42","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"It\u0027s essential that the Redfish username and password match the BMC username"},{"line_number":55,"context_line":"and password for your nodes, if the username and password combination is"},{"line_number":56,"context_line":"not the same for the entire rack you will need to adjust your configuration"},{"line_number":57,"context_line":"accordingly. The IPMI address should also match the BMC address for your node."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Once this has been completed you can begin enrolling the Ironic nodes::"}],"source_content_type":"text/x-rst","patch_set":30,"id":"b75fab11_b7e8a7d0","line":56,"updated":"2024-05-13 14:49:27.000000000","message":"rack seems like the wrong word here. group?","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"41a8a5d2c016d9d9f477d0bb37dc18dfcc01d04c","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"It\u0027s essential that the Redfish username and password match the BMC username"},{"line_number":55,"context_line":"and password for your nodes, if the username and password combination is"},{"line_number":56,"context_line":"not the same for the entire rack you will need to adjust your configuration"},{"line_number":57,"context_line":"accordingly. The IPMI address should also match the BMC address for your node."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Once this has been completed you can begin enrolling the Ironic nodes::"}],"source_content_type":"text/x-rst","patch_set":30,"id":"da74685f_f364a069","line":56,"in_reply_to":"b75fab11_b7e8a7d0","updated":"2024-05-15 14:01:40.000000000","message":"Done","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a6cfb820aadb5908c10bdaeb50132c4eacfa81c5","unresolved":true,"context_lines":[{"line_number":52,"context_line":"    ironic_resource_class: \"example_resouce_class\""},{"line_number":53,"context_line":"    ironic_redfish_system_id: \"/redfish/v1/Systems/System.Embedded.1\""},{"line_number":54,"context_line":"    ironic_redfish_verify_ca: \"{{ inspector_rule_var_redfish_verify_ca }}\""},{"line_number":55,"context_line":"    ironic_redfish_address: \"{{ ipmi_address }}\""},{"line_number":56,"context_line":"    ironic_redfish_username: \"{{ inspector_redfish_username }}\""},{"line_number":57,"context_line":"    ironic_redfish_password: \"{{ inspector_redfish_password }}\""},{"line_number":58,"context_line":"    ironic_capabilities: \"boot_option:local,boot_mode:uefi\""}],"source_content_type":"text/x-rst","patch_set":33,"id":"7d7601bd_b4535ed1","line":55,"updated":"2024-05-15 15:58:05.000000000","message":"Unused","commit_id":"918791b8e6972297a3a1c03b94e4d83e0428456f"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"8e07643f3548bba8e1f043209bee9d9a17364b22","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    ironic_resource_class: \"example_resouce_class\""},{"line_number":53,"context_line":"    ironic_redfish_system_id: \"/redfish/v1/Systems/System.Embedded.1\""},{"line_number":54,"context_line":"    ironic_redfish_verify_ca: \"{{ inspector_rule_var_redfish_verify_ca }}\""},{"line_number":55,"context_line":"    ironic_redfish_address: \"{{ ipmi_address }}\""},{"line_number":56,"context_line":"    ironic_redfish_username: \"{{ inspector_redfish_username }}\""},{"line_number":57,"context_line":"    ironic_redfish_password: \"{{ inspector_redfish_password }}\""},{"line_number":58,"context_line":"    ironic_capabilities: \"boot_option:local,boot_mode:uefi\""}],"source_content_type":"text/x-rst","patch_set":33,"id":"2b4da3c6_d15089ba","line":55,"in_reply_to":"7d7601bd_b4535ed1","updated":"2024-05-15 16:09:08.000000000","message":"Done","commit_id":"918791b8e6972297a3a1c03b94e4d83e0428456f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e9146aa21aa6c983374292061f6c51877504d656","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    ironic_resource_class: \"example_resouce_class\""},{"line_number":53,"context_line":"    ironic_redfish_system_id: \"/redfish/v1/Systems/System.Embedded.1\""},{"line_number":54,"context_line":"    ironic_redfish_verify_ca: \"{{ inspector_rule_var_redfish_verify_ca }}\""},{"line_number":55,"context_line":"    ironic_redfish_address: \"{{ ipmi_address }}\""},{"line_number":56,"context_line":"    ironic_redfish_username: \"{{ inspector_redfish_username }}\""},{"line_number":57,"context_line":"    ironic_redfish_password: \"{{ inspector_redfish_password }}\""},{"line_number":58,"context_line":"    ironic_capabilities: \"boot_option:local,boot_mode:uefi\""}],"source_content_type":"text/x-rst","patch_set":33,"id":"4ff668e1_6b1d4ba3","line":55,"in_reply_to":"7d7601bd_b4535ed1","updated":"2024-05-15 16:10:29.000000000","message":"Done","commit_id":"918791b8e6972297a3a1c03b94e4d83e0428456f"}],"releasenotes/notes/baremetal-enroll-e01693210f95675c.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"13e143913e4dde9feb6a7b76bef11a2461560d42","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    This patch adds experimental functionallity to enroll baremetal nodes"},{"line_number":5,"context_line":"    into Ironic using Kayobe via a new playbook \u0027baremetal-compute-register.yml\u0027"},{"line_number":6,"context_line":"    and adds \u0027kayobe baremetal compute register\u0027 into the Kayobe CLI."},{"line_number":7,"context_line":"    Note that only baremetal nodes using the Redfish driver are supported"},{"line_number":8,"context_line":"    in the experimental release."}],"source_content_type":"text/x-yaml","patch_set":30,"id":"e89b0d11_264a087a","line":7,"updated":"2024-05-13 14:49:27.000000000","message":"Let\u0027s drop this limitation.","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"b71b9b380827befa8ec110c6fbadad4c5b7e02ec","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    This patch adds experimental functionallity to enroll baremetal nodes"},{"line_number":5,"context_line":"    into Ironic using Kayobe via a new playbook \u0027baremetal-compute-register.yml\u0027"},{"line_number":6,"context_line":"    and adds \u0027kayobe baremetal compute register\u0027 into the Kayobe CLI."},{"line_number":7,"context_line":"    Note that only baremetal nodes using the Redfish driver are supported"},{"line_number":8,"context_line":"    in the experimental release."}],"source_content_type":"text/x-yaml","patch_set":30,"id":"b591a4c2_2298e4cf","line":7,"in_reply_to":"e89b0d11_264a087a","updated":"2024-05-15 14:30:24.000000000","message":"Done","commit_id":"6c9fd855bd70092f880dc35fd2ca558827aad99c"}]}