)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"61d8db8305a909cf46bbe648dbb842a90c901281","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add podman support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds support for Podman as an alternative container engine. This builds"},{"line_number":10,"context_line":"on the support add in kolla-ansible in the 2023.2 cycle."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/c/openstack/ansible-collection-kolla/+/909692"},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/910016"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":39,"id":"37d3c36c_b4d58802","line":10,"range":{"start_line":10,"start_character":15,"end_line":10,"end_character":18},"updated":"2024-05-28 09:38:28.000000000","message":"added","commit_id":"be68fbd442955812fe1d46ad3234b785b8e7f738"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e20a5e332d12538674dafba4a1ba7c32227e329a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add podman support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds support for Podman as an alternative container engine. This builds"},{"line_number":10,"context_line":"on the support add in kolla-ansible in the 2023.2 cycle."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/c/openstack/ansible-collection-kolla/+/909692"},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/910016"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":39,"id":"a45de42e_86eae12d","line":10,"range":{"start_line":10,"start_character":15,"end_line":10,"end_character":18},"in_reply_to":"37d3c36c_b4d58802","updated":"2024-12-12 21:22:09.000000000","message":"Done","commit_id":"be68fbd442955812fe1d46ad3234b785b8e7f738"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"af6cd96503a6f76215bf3c591fed2434e72d6a03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1c8b3be9_087c31a4","updated":"2024-02-21 17:06:47.000000000","message":"TODO: Noticed we still create the docker user","commit_id":"11260b96d4edde24747a7277f17a635497f54282"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"81be8bfe9bfb22d1aeca6b7f9270ef276a605861","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"aa561345_35cfdcc3","updated":"2024-02-26 16:27:31.000000000","message":"recheck","commit_id":"427daf8d437cc7120d0e84e076992080bf2fbd05"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"ea8f7880840ab471467ed174f6dd8d40000a2ca1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"88415b0d_5258f55f","updated":"2024-02-23 17:39:20.000000000","message":"TODO:\n\n- Docs\n- Release note\n- Check all CI jobs\n- Zuul logs (There is no /var/log/kolla symlink)","commit_id":"475cb5bbae701358dd36f1505f423c38c1e9cfa7"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"19dea918e05235d187fdd76ddba97494337f9eff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"8baf738c_93b18922","updated":"2024-02-27 10:29:21.000000000","message":"recheck","commit_id":"7620ebc48459c69ec75c96785844cf20572dd0a1"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"8bee3b80353faa6081c62544896ddc7a09d0f05e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"c1dd7928_61c926fb","updated":"2024-02-27 10:34:49.000000000","message":"recheck","commit_id":"7620ebc48459c69ec75c96785844cf20572dd0a1"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"1fc9a8e530db43623bda6e0927b2759f1f3a483f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"81e244ec_5dd873ce","updated":"2024-02-27 17:12:52.000000000","message":"recheck: Can\u0027t reproduce the failure, trying a slightly different variant of the kolla-ansible patch.","commit_id":"7620ebc48459c69ec75c96785844cf20572dd0a1"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"34a977b92d98e2af522dd2342a511cfe70ed4397","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"3d95480e_447f9673","updated":"2024-03-13 10:29:19.000000000","message":"recheck","commit_id":"2088322ac219a8b4e85d33ce7fb42d9578837b09"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"c281832e22caa5b54455f6913c1b3ce83ae662f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"4bae3486_9479d83f","updated":"2024-03-08 09:27:29.000000000","message":"recheck: infra mirror issues","commit_id":"2088322ac219a8b4e85d33ce7fb42d9578837b09"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fcf35166a4cc86b9cf1d918236848cbdf9922cb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"543968e1_155cf808","updated":"2024-04-30 11:17:46.000000000","message":"Quick first pass","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"3b0b2435cf45796f40a66027d8ddb1160de2ac89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"3cbe9fe3_365fc365","updated":"2024-03-27 15:22:12.000000000","message":"recheck","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"c1619d8d19b1ddefabe9b90511e18f5ca6484c00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"08e9709e_6fabec30","updated":"2024-05-02 08:33:53.000000000","message":"Managed to lose a bunch of changes in edit mode 😞 Will revisit the comments.","commit_id":"ffa25e181d40d3e8c2ad655e3b78011fe71b2ed6"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"839c75eb5dc49496f4e6f1fef026e971a0edb5fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"af6b3253_4b1f2d4e","updated":"2024-05-30 13:22:18.000000000","message":"Lets target dalmatian.","commit_id":"1816850cd7c10ec7424be631c2c171b5da433c74"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"dc3a2d4b7072c8cb8d713a583f4e5f6ce268de61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"3d06f2db_2a014a63","updated":"2024-07-03 13:01:35.000000000","message":"recheck","commit_id":"9290528730a2b9b9a15548b9a8e467cec95641ed"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"2bc13046e826fdb8c44d84b63e9c94418b7a954c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"121156e3_2bf2c2cb","updated":"2024-12-06 09:20:40.000000000","message":"It works mostly fine, but lacks support for insecure registries. I will post an amended patch.","commit_id":"fd7aa12a03e0a2d4e4854a0ba8922bc1cf33e149"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"7137b8c2026b025fa946406566e29660eda6a1ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":47,"id":"f57aac6b_44bdf095","updated":"2024-12-10 14:53:26.000000000","message":"recheck CI is fixed","commit_id":"c1c7656b52485e2ce2e702f1b7286774c8f20cab"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"9e582ad3509d5ef4044ba74669ec2c205f6be72c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":58,"id":"c06025b7_cd5c00d2","updated":"2025-01-30 08:56:59.000000000","message":"Great stuff :)","commit_id":"988a822259a375bb404fef7b435a74511379c895"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"97e838d73b58961650d77f47c5686e344cb4bfbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":58,"id":"52183022_ea5a8aea","updated":"2025-01-29 17:04:58.000000000","message":"Let\u0027s merge this!","commit_id":"988a822259a375bb404fef7b435a74511379c895"},{"author":{"_account_id":37702,"name":"Salah Hazaa","display_name":"Salah hazaa","email":"dev.salahhazaa@gmail.com","inactive":true},"change_message_id":"2c5b0a398ef43104a5f8f52f8aea35a3613c9254","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":58,"id":"094b4402_0fe347dd","updated":"2025-02-03 03:17:04.000000000","message":"https://review.opendev.org/#/q/I2c6befbdda7e684228065103feea7250a0ea3826","commit_id":"988a822259a375bb404fef7b435a74511379c895"},{"author":{"_account_id":37702,"name":"Salah Hazaa","display_name":"Salah hazaa","email":"dev.salahhazaa@gmail.com","inactive":true},"change_message_id":"02389adabe88f5269fa0b6e2124501f4f759b892","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":58,"id":"7988eb8b_0ea4db88","updated":"2025-02-03 03:18:49.000000000","message":"https://review.opendev.org/#/q/I2c6befbdda7e684228065103feea7250a0ea3826","commit_id":"988a822259a375bb404fef7b435a74511379c895"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"678ee26c1a770b64fac37b32f91d842372864666","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":58,"id":"378c43b0_3d0c7efe","updated":"2025-01-30 13:29:01.000000000","message":"recheck\n\nneutron failed: AttributeError: \u0027NoneType\u0027 object has no attribute \u0027tags\u0027","commit_id":"988a822259a375bb404fef7b435a74511379c895"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"54b5c2b2ff0da24ecb971d61d02aca0bd5b5ff81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":58,"id":"1cf65d1a_0614ee6e","updated":"2025-02-02 13:13:53.000000000","message":"recheck there are many \u0027HTTP Error 504: Gateway Time-out\u0027 errors","commit_id":"988a822259a375bb404fef7b435a74511379c895"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"ed6892626e0b27108ebfb6e9eafbdcf47b636bc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":58,"id":"4c6ed674_1612b494","updated":"2025-02-01 19:00:28.000000000","message":"recheck various errors","commit_id":"988a822259a375bb404fef7b435a74511379c895"}],"ansible/action_plugins/kayobe_container.py":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"55f20a6543e4ffb315016b25fff4bfcd63a83776","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/python"},{"line_number":2,"context_line":"from ansible.plugins.action import ActionBase"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"_engine_to_module \u003d {"}],"source_content_type":"text/x-python","patch_set":39,"id":"93b982f7_c3d3b23b","line":1,"updated":"2024-05-02 09:00:43.000000000","message":"I like that these modules can potentially be used in custom playbooks. Makes it quite composable.","commit_id":"be68fbd442955812fe1d46ad3234b785b8e7f738"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d79058b96e7a37cd345501e0590fa4be094bd41d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/python"},{"line_number":2,"context_line":"from ansible.plugins.action import ActionBase"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"_engine_to_module \u003d {"}],"source_content_type":"text/x-python","patch_set":39,"id":"70e7809e_742d7a18","line":1,"in_reply_to":"93b982f7_c3d3b23b","updated":"2025-01-27 16:42:59.000000000","message":"Seemed to work well","commit_id":"be68fbd442955812fe1d46ad3234b785b8e7f738"}],"ansible/container-engine.yml":[{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"033488c70523992a391a57398dfc561636a203f9","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Ensure docker is configured"},{"line_number":3,"context_line":"  hosts: container-engine"},{"line_number":4,"context_line":"  tags:"},{"line_number":5,"context_line":"    - docker"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"    - import_role:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"38e720aa_f7409f83","line":4,"updated":"2024-04-04 13:30:42.000000000","message":"Might be nice to have a generic \u0027container-engine\u0027 tag on both of these as well","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"705cdd67986885d21c993de13b6df36ab9c43499","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Ensure docker is configured"},{"line_number":3,"context_line":"  hosts: container-engine"},{"line_number":4,"context_line":"  tags:"},{"line_number":5,"context_line":"    - docker"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"    - import_role:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"607cbd11_b3abde48","line":4,"in_reply_to":"38e720aa_f7409f83","updated":"2024-05-01 11:22:40.000000000","message":"Good idea","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"c1619d8d19b1ddefabe9b90511e18f5ca6484c00","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Ensure docker is configured"},{"line_number":3,"context_line":"  hosts: container-engine"},{"line_number":4,"context_line":"  tags:"},{"line_number":5,"context_line":"    - docker"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"    - import_role:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"ce519545_9d571c79","line":4,"in_reply_to":"607cbd11_b3abde48","updated":"2024-05-02 08:33:53.000000000","message":"Done","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fcf35166a4cc86b9cf1d918236848cbdf9922cb2","unresolved":true,"context_lines":[{"line_number":4,"context_line":"  tags:"},{"line_number":5,"context_line":"    - docker"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"    - import_role:"},{"line_number":8,"context_line":"        name: docker"},{"line_number":9,"context_line":"      vars:"},{"line_number":10,"context_line":"        docker_daemon_mtu: \"{{ public_net_name | net_mtu | default }}\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"db04b3dc_739473ca","line":7,"updated":"2024-04-30 11:17:46.000000000","message":"It would be better to use include_role here to avoid lots of skipped tasks.","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"705cdd67986885d21c993de13b6df36ab9c43499","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  tags:"},{"line_number":5,"context_line":"    - docker"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"    - import_role:"},{"line_number":8,"context_line":"        name: docker"},{"line_number":9,"context_line":"      vars:"},{"line_number":10,"context_line":"        docker_daemon_mtu: \"{{ public_net_name | net_mtu | default }}\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"71a31a0e_b2b8a94e","line":7,"in_reply_to":"db04b3dc_739473ca","updated":"2024-05-01 11:22:40.000000000","message":"Done","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fcf35166a4cc86b9cf1d918236848cbdf9922cb2","unresolved":true,"context_lines":[{"line_number":19,"context_line":"  tags:"},{"line_number":20,"context_line":"    - podman"},{"line_number":21,"context_line":"  tasks:"},{"line_number":22,"context_line":"    - import_role:"},{"line_number":23,"context_line":"        name: openstack.kolla.podman"},{"line_number":24,"context_line":"      when: container_engine \u003d\u003d \"podman\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"35d0342e_e3037331","line":22,"updated":"2024-04-30 11:17:46.000000000","message":"and here","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"705cdd67986885d21c993de13b6df36ab9c43499","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  tags:"},{"line_number":20,"context_line":"    - podman"},{"line_number":21,"context_line":"  tasks:"},{"line_number":22,"context_line":"    - import_role:"},{"line_number":23,"context_line":"        name: openstack.kolla.podman"},{"line_number":24,"context_line":"      when: container_engine \u003d\u003d \"podman\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"155fb6f4_e618d220","line":22,"in_reply_to":"35d0342e_e3037331","updated":"2024-05-01 11:22:40.000000000","message":"Done","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"}],"ansible/container-image-build.yml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"ea8f7880840ab471467ed174f6dd8d40000a2ca1","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        - kolla_docker_registry_username is truthy"},{"line_number":44,"context_line":"        - kolla_docker_registry_password is truthy"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    - name: Ensure Kolla container images are built"},{"line_number":47,"context_line":"      shell:"},{"line_number":48,"context_line":"        cmd: \u003e"},{"line_number":49,"context_line":"          set -o pipefail \u0026\u0026"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"35c38d54_a7bd08c4","line":46,"updated":"2024-02-23 17:39:20.000000000","message":"Pass engine here. See: https://github.com/openstack/kolla/commit/b76bd4c6efa22af43d7895a7b5e95c75806d3893","commit_id":"11260b96d4edde24747a7277f17a635497f54282"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"69892d1b0381813fd74336ea2788db27c844c98f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        - kolla_docker_registry_username is truthy"},{"line_number":44,"context_line":"        - kolla_docker_registry_password is truthy"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    - name: Ensure Kolla container images are built"},{"line_number":47,"context_line":"      shell:"},{"line_number":48,"context_line":"        cmd: \u003e"},{"line_number":49,"context_line":"          set -o pipefail \u0026\u0026"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"11a843a1_a1b2a8e2","line":46,"in_reply_to":"35c38d54_a7bd08c4","updated":"2024-03-06 11:16:35.000000000","message":"Done","commit_id":"11260b96d4edde24747a7277f17a635497f54282"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fcf35166a4cc86b9cf1d918236848cbdf9922cb2","unresolved":true,"context_lines":[{"line_number":42,"context_line":"      when:"},{"line_number":43,"context_line":"        - kolla_docker_registry_username is truthy"},{"line_number":44,"context_line":"        - kolla_docker_registry_password is truthy"},{"line_number":45,"context_line":"      become: true"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    - name: Ensure Kolla container images are built"},{"line_number":48,"context_line":"      shell:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"57b87413_1e8a4668","line":45,"updated":"2024-04-30 11:17:46.000000000","message":"So podman requires root? Seems like a bit of a shame.","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d79058b96e7a37cd345501e0590fa4be094bd41d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      when:"},{"line_number":43,"context_line":"        - kolla_docker_registry_username is truthy"},{"line_number":44,"context_line":"        - kolla_docker_registry_password is truthy"},{"line_number":45,"context_line":"      become: true"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    - name: Ensure Kolla container images are built"},{"line_number":48,"context_line":"      shell:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"f347f952_2a0d90e7","line":45,"in_reply_to":"3e56d3ff_e93969d0","updated":"2025-01-27 16:42:59.000000000","message":"Went with only running as root when deploying podman.","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d6c8de4eeef709674cf909027d1a6fb58ba2c35a","unresolved":true,"context_lines":[{"line_number":42,"context_line":"      when:"},{"line_number":43,"context_line":"        - kolla_docker_registry_username is truthy"},{"line_number":44,"context_line":"        - kolla_docker_registry_password is truthy"},{"line_number":45,"context_line":"      become: true"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    - name: Ensure Kolla container images are built"},{"line_number":48,"context_line":"      shell:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"3e56d3ff_e93969d0","line":45,"in_reply_to":"54fc5ec1_85b75b8d","updated":"2024-05-01 11:35:34.000000000","message":"Potentially we could start a rootless service with example from here:\n\nhttps://docs.podman.io/en/latest/markdown/podman-system-service.1.html#examples\n\nand set podman_base_url to unix://$XDG_RUNTIME_DIR/podman/podman.sock.\n\nThis isn\u0027t how things get configured in the kolla collection though:\n\nhttps://github.com/openstack/ansible-collection-kolla/blob/master/roles/podman/tasks/install.yml#L24-L25\n\nI\u0027m thinking it may easiest to keep using the root user for now since kolla is using rootful containers anyway. One day support may be extended in kolla-ansible to use rootless containers, but that feature doesn\u0027t exist yet. I am still investigating your other point around log file ownership to see if there are any other downsides to running the build as the root user. Potentially we could only use become for podman. Would that alleviate your concerns?","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"705cdd67986885d21c993de13b6df36ab9c43499","unresolved":true,"context_lines":[{"line_number":42,"context_line":"      when:"},{"line_number":43,"context_line":"        - kolla_docker_registry_username is truthy"},{"line_number":44,"context_line":"        - kolla_docker_registry_password is truthy"},{"line_number":45,"context_line":"      become: true"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    - name: Ensure Kolla container images are built"},{"line_number":48,"context_line":"      shell:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"54fc5ec1_85b75b8d","line":45,"in_reply_to":"57b87413_1e8a4668","updated":"2024-05-01 11:22:40.000000000","message":"You\u0027d think you could build without it. I think there are some assumptions in kolla that refer to the podman socket:\n\nhttps://github.com/openstack/kolla/blob/26d95c182c479f5ab12386289420e1688b3c7986/kolla/common/config.py#L267\n\nWhich is owned by root. Worth noting that there is no equivalent of the \"docker\" group to grant access to the socket. It may be possible to relax this requirement.","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fcf35166a4cc86b9cf1d918236848cbdf9922cb2","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        executable: /bin/bash"},{"line_number":60,"context_line":"      with_items: \"{{ container_image_sets }}\""},{"line_number":61,"context_line":"      when: item.regexes !\u003d \u0027\u0027"},{"line_number":62,"context_line":"      become: true"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"124a4cff_514d1a37","line":62,"updated":"2024-04-30 11:17:46.000000000","message":"Are there any implications of running kolla-build as root? Will we be able to read the logs etc as a non-root user?","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d21740806f3f3d55a4432c296a330a62e6704ccc","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        executable: /bin/bash"},{"line_number":60,"context_line":"      with_items: \"{{ container_image_sets }}\""},{"line_number":61,"context_line":"      when: item.regexes !\u003d \u0027\u0027"},{"line_number":62,"context_line":"      become: true"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"dd8820f4_e1ad5e99","line":62,"in_reply_to":"124a4cff_514d1a37","updated":"2024-05-01 17:06:59.000000000","message":"So I checked the build logs and they are owned by the stack user:\n\n    [root@controller0 ~]# ls -lia /var/log/kolla-build.log \n    14757597 -rw-r--r--. 1 stack stack 346 May  1 16:03 /var/log/kolla-build.log","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d79058b96e7a37cd345501e0590fa4be094bd41d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        executable: /bin/bash"},{"line_number":60,"context_line":"      with_items: \"{{ container_image_sets }}\""},{"line_number":61,"context_line":"      when: item.regexes !\u003d \u0027\u0027"},{"line_number":62,"context_line":"      become: true"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"a918c87a_de8bfb58","line":62,"in_reply_to":"7e922f5b_da51a079","updated":"2025-01-27 16:42:59.000000000","message":"Done","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"871a8245aae1a4d18b5b1c844cf2123a36096278","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        executable: /bin/bash"},{"line_number":60,"context_line":"      with_items: \"{{ container_image_sets }}\""},{"line_number":61,"context_line":"      when: item.regexes !\u003d \u0027\u0027"},{"line_number":62,"context_line":"      become: true"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"7e922f5b_da51a079","line":62,"in_reply_to":"dd8820f4_e1ad5e99","updated":"2024-05-02 08:59:22.000000000","message":"I\u0027ve now made the use of become conditional on using podman as the container engine. This should help prevent any ownership changes when using the docker engine, but I didn\u0027t notice any issues. Can anyone think of any other examples of things that could be affected?","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"}],"ansible/docker.yml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"fb75f174ce25b6aacbbac2803991a44b18e768e0","unresolved":true,"context_lines":[{"line_number":14,"context_line":"        docker_no_proxy: \"{{ kolla_no_proxy | select | join(\u0027,\u0027) }}\""},{"line_number":15,"context_line":"      when: container_engine \u003d\u003d \"docker\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Ensure podman is configured"},{"line_number":18,"context_line":"  hosts: docker"},{"line_number":19,"context_line":"  tags:"},{"line_number":20,"context_line":"    - podman"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e82bf33e_7b902f2d","line":17,"updated":"2024-02-21 15:44:08.000000000","message":"Bit of a hack to reuse docker.yml and docker group, but it is a bit cumbersome to have to move your hosts from the docker group into the podman group, but possible we could use a computed inventory to add the hosts to right group automatically (based on the container_engine variable)","commit_id":"bf6e4c845de54eaed2c907c93c3d39e651a87c14"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"69892d1b0381813fd74336ea2788db27c844c98f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        docker_no_proxy: \"{{ kolla_no_proxy | select | join(\u0027,\u0027) }}\""},{"line_number":15,"context_line":"      when: container_engine \u003d\u003d \"docker\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Ensure podman is configured"},{"line_number":18,"context_line":"  hosts: docker"},{"line_number":19,"context_line":"  tags:"},{"line_number":20,"context_line":"    - podman"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f757ced_ebc3e135","line":17,"in_reply_to":"e82bf33e_7b902f2d","updated":"2024-03-06 11:16:35.000000000","message":"Done. Renamed to container-engine.yml.","commit_id":"bf6e4c845de54eaed2c907c93c3d39e651a87c14"}],"ansible/inventory/group_vars/all/compute":[{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"033488c70523992a391a57398dfc561636a203f9","unresolved":false,"context_lines":[{"line_number":82,"context_line":"# for format."},{"line_number":83,"context_line":"compute_lvm_groups_extra: []"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"# Whether a \u0027data\u0027 LVM volume group should exist on compute hosts. By default"},{"line_number":86,"context_line":"# this contains a \u0027docker-volumes\u0027 logical volume for Docker volume storage"},{"line_number":87,"context_line":"# Default is false."},{"line_number":88,"context_line":"compute_lvm_group_data_enabled: false"}],"source_content_type":"application/octet-stream","patch_set":35,"id":"54cc7913_3f9c1bd7","line":85,"updated":"2024-04-04 13:30:42.000000000","message":"This comment is fine for now if the default remains docker but could possibly do with a reword in the future","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"705cdd67986885d21c993de13b6df36ab9c43499","unresolved":false,"context_lines":[{"line_number":82,"context_line":"# for format."},{"line_number":83,"context_line":"compute_lvm_groups_extra: []"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"# Whether a \u0027data\u0027 LVM volume group should exist on compute hosts. By default"},{"line_number":86,"context_line":"# this contains a \u0027docker-volumes\u0027 logical volume for Docker volume storage"},{"line_number":87,"context_line":"# Default is false."},{"line_number":88,"context_line":"compute_lvm_group_data_enabled: false"}],"source_content_type":"application/octet-stream","patch_set":35,"id":"56429483_1375caba","line":85,"in_reply_to":"54cc7913_3f9c1bd7","updated":"2024-05-01 11:22:40.000000000","message":"I\u0027ve tried to make it clearer","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"033488c70523992a391a57398dfc561636a203f9","unresolved":true,"context_lines":[{"line_number":111,"context_line":"# List of LVM logical volumes for the data volume group."},{"line_number":112,"context_line":"compute_lvm_group_data_lvs: \"{{ compute_lvm_group_data_podman_lvs if container_engine \u003d\u003d \u0027podman\u0027 else compute_lvm_group_data_docker_lvs }}\""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"# Docker volumes LVM backing volume."},{"line_number":115,"context_line":"compute_lvm_group_data_lv_docker_volumes:"},{"line_number":116,"context_line":"  lvname: docker-volumes"},{"line_number":117,"context_line":"  size: \"{{ compute_lvm_group_data_lv_docker_volumes_size }}\""}],"source_content_type":"application/octet-stream","patch_set":35,"id":"186836d6_ed95173e","line":114,"updated":"2024-04-04 13:30:42.000000000","message":"Either container engine or needs a second comment for the next var","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"705cdd67986885d21c993de13b6df36ab9c43499","unresolved":false,"context_lines":[{"line_number":111,"context_line":"# List of LVM logical volumes for the data volume group."},{"line_number":112,"context_line":"compute_lvm_group_data_lvs: \"{{ compute_lvm_group_data_podman_lvs if container_engine \u003d\u003d \u0027podman\u0027 else compute_lvm_group_data_docker_lvs }}\""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"# Docker volumes LVM backing volume."},{"line_number":115,"context_line":"compute_lvm_group_data_lv_docker_volumes:"},{"line_number":116,"context_line":"  lvname: docker-volumes"},{"line_number":117,"context_line":"  size: \"{{ compute_lvm_group_data_lv_docker_volumes_size }}\""}],"source_content_type":"application/octet-stream","patch_set":35,"id":"b6ab3a32_71717f35","line":114,"in_reply_to":"186836d6_ed95173e","updated":"2024-05-01 11:22:40.000000000","message":"I added a comment to next variable","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"}],"ansible/inventory/group_vars/all/container-engine":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fcf35166a4cc86b9cf1d918236848cbdf9922cb2","unresolved":true,"context_lines":[{"line_number":15,"context_line":"# Name of the docker storage driver. Default is \u0027overlay2\u0027."},{"line_number":16,"context_line":"docker_storage_driver: overlay2"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Name of the docker storage LVM volume group."},{"line_number":19,"context_line":"docker_storage_volume_group: data"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Name of the docker storage data LVM volume."},{"line_number":22,"context_line":"docker_storage_volume_thinpool: docker-thinpool"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Size of the docker storage data LVM volume (see lvol module size argument)."},{"line_number":25,"context_line":"docker_storage_volume_thinpool_size: 20%VG"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Name of the docker storage metadata LVM volume."},{"line_number":28,"context_line":"docker_storage_volume_thinpool_meta: docker-thinpoolmeta"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Size of the docker storage metadata LVM volume (see lvol module size"},{"line_number":31,"context_line":"# argument)."},{"line_number":32,"context_line":"docker_storage_volume_thinpool_meta_size: 1%VG"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# URL of docker registry"},{"line_number":35,"context_line":"docker_registry:"},{"line_number":36,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":35,"id":"a14e93f2_cdad0514","line":33,"range":{"start_line":18,"start_character":0,"end_line":33,"end_character":1},"updated":"2024-04-30 11:17:46.000000000","message":"I think these should have been removed when we removed the docker devicemapper driver support.","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d79058b96e7a37cd345501e0590fa4be094bd41d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# Name of the docker storage driver. Default is \u0027overlay2\u0027."},{"line_number":16,"context_line":"docker_storage_driver: overlay2"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Name of the docker storage LVM volume group."},{"line_number":19,"context_line":"docker_storage_volume_group: data"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Name of the docker storage data LVM volume."},{"line_number":22,"context_line":"docker_storage_volume_thinpool: docker-thinpool"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Size of the docker storage data LVM volume (see lvol module size argument)."},{"line_number":25,"context_line":"docker_storage_volume_thinpool_size: 20%VG"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Name of the docker storage metadata LVM volume."},{"line_number":28,"context_line":"docker_storage_volume_thinpool_meta: docker-thinpoolmeta"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Size of the docker storage metadata LVM volume (see lvol module size"},{"line_number":31,"context_line":"# argument)."},{"line_number":32,"context_line":"docker_storage_volume_thinpool_meta_size: 1%VG"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# URL of docker registry"},{"line_number":35,"context_line":"docker_registry:"},{"line_number":36,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":35,"id":"2e6d33b0_b88e0f41","line":33,"range":{"start_line":18,"start_character":0,"end_line":33,"end_character":1},"in_reply_to":"2b036406_e5c1655d","updated":"2025-01-27 16:42:59.000000000","message":"Fair point, but I\u0027d suggest doing this in another change. I\u0027ve made a ticket so we don\u0027t forget: https://bugs.launchpad.net/kayobe/+bug/2096784","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"705cdd67986885d21c993de13b6df36ab9c43499","unresolved":true,"context_lines":[{"line_number":15,"context_line":"# Name of the docker storage driver. Default is \u0027overlay2\u0027."},{"line_number":16,"context_line":"docker_storage_driver: overlay2"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Name of the docker storage LVM volume group."},{"line_number":19,"context_line":"docker_storage_volume_group: data"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Name of the docker storage data LVM volume."},{"line_number":22,"context_line":"docker_storage_volume_thinpool: docker-thinpool"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Size of the docker storage data LVM volume (see lvol module size argument)."},{"line_number":25,"context_line":"docker_storage_volume_thinpool_size: 20%VG"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Name of the docker storage metadata LVM volume."},{"line_number":28,"context_line":"docker_storage_volume_thinpool_meta: docker-thinpoolmeta"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Size of the docker storage metadata LVM volume (see lvol module size"},{"line_number":31,"context_line":"# argument)."},{"line_number":32,"context_line":"docker_storage_volume_thinpool_meta_size: 1%VG"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# URL of docker registry"},{"line_number":35,"context_line":"docker_registry:"},{"line_number":36,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":35,"id":"2b036406_e5c1655d","line":33,"range":{"start_line":18,"start_character":0,"end_line":33,"end_character":1},"in_reply_to":"a14e93f2_cdad0514","updated":"2024-05-01 11:22:40.000000000","message":"Do you think I just leave them unsupported when using podman then?","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"033488c70523992a391a57398dfc561636a203f9","unresolved":true,"context_lines":[{"line_number":62,"context_line":"# location: \u0027/var/lib/containers/storage\u0027."},{"line_number":63,"context_line":"podman_runtime_directory:"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# Path to docker volumes. Default is \u0027{{ podman_runtime_directory | default(\u0027/var/lib/containers/storage\u0027, true) ~ \u0027/volumes\u0027 }}\"\u0027."},{"line_number":66,"context_line":"podman_volumes_path: \"{{ podman_runtime_directory | default(\u0027/var/lib/containers/storage\u0027, true) ~ \u0027/volumes\u0027 }}\""}],"source_content_type":"application/octet-stream","patch_set":35,"id":"aafb5e4b_4e8dce3e","line":65,"updated":"2024-04-04 13:30:42.000000000","message":"podman volumes","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"705cdd67986885d21c993de13b6df36ab9c43499","unresolved":false,"context_lines":[{"line_number":62,"context_line":"# location: \u0027/var/lib/containers/storage\u0027."},{"line_number":63,"context_line":"podman_runtime_directory:"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# Path to docker volumes. Default is \u0027{{ podman_runtime_directory | default(\u0027/var/lib/containers/storage\u0027, true) ~ \u0027/volumes\u0027 }}\"\u0027."},{"line_number":66,"context_line":"podman_volumes_path: \"{{ podman_runtime_directory | default(\u0027/var/lib/containers/storage\u0027, true) ~ \u0027/volumes\u0027 }}\""}],"source_content_type":"application/octet-stream","patch_set":35,"id":"4260f9bf_e44b847a","line":65,"in_reply_to":"aafb5e4b_4e8dce3e","updated":"2024-05-01 11:22:40.000000000","message":"Done","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"b3cab00871b1c9f23817b5af91650ad114a5e081","unresolved":true,"context_lines":[{"line_number":60,"context_line":"# Podman configuration."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# URL of podman container registry"},{"line_number":63,"context_line":"#podman_registry:"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# Whether podman should be configured to use an insecure registry."},{"line_number":66,"context_line":"# Default is false, unless docker_registry_enabled is true and"}],"source_content_type":"application/octet-stream","patch_set":54,"id":"402bc304_a267b9a6","line":63,"updated":"2025-01-16 12:51:51.000000000","message":"```suggestion\npodman_registry:\n```\n\nThis needs uncommenting, otherwise we hit:\n```\nTASK [kolla-ansible : Ensure the Kolla global configuration file exists] ********************************************************************************\nfatal: [localhost]: FAILED! \u003d\u003e {\"msg\": \"{{ podman_registry if container_engine \u003d\u003d \u0027podman\u0027 else docker_registry }}: \u0027podman_registry\u0027 is undefined\"}\n```","commit_id":"a582a8d0d86a01ed56cabe5f503e8ad9e8698c39"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"997215c833546a6b9ba53a0a1dadf961600a9e94","unresolved":false,"context_lines":[{"line_number":60,"context_line":"# Podman configuration."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# URL of podman container registry"},{"line_number":63,"context_line":"#podman_registry:"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# Whether podman should be configured to use an insecure registry."},{"line_number":66,"context_line":"# Default is false, unless docker_registry_enabled is true and"}],"source_content_type":"application/octet-stream","patch_set":54,"id":"a03ac08d_c849078f","line":63,"in_reply_to":"402bc304_a267b9a6","updated":"2025-01-21 08:50:15.000000000","message":"Done","commit_id":"a582a8d0d86a01ed56cabe5f503e8ad9e8698c39"}],"ansible/inventory/group_vars/all/docker":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"fb75f174ce25b6aacbbac2803991a44b18e768e0","unresolved":true,"context_lines":[{"line_number":3,"context_line":"# Container engine configuration"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Configures the container engine. Default is \u0027docker\u0027."},{"line_number":6,"context_line":"container_engine: docker"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"###############################################################################"},{"line_number":9,"context_line":"# Docker configuration."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1bfa87cc_dde61c0a","line":6,"updated":"2024-02-21 15:44:08.000000000","message":"Abusing docker.yml a bit here. Did we want a more generic container-engine.yml config file?\n\nAlso: Needs to be propagated to etc/kayobe.","commit_id":"bf6e4c845de54eaed2c907c93c3d39e651a87c14"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"86704897533a6a8f1f79215fc9dd9e8454b95f09","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Container engine configuration"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Configures the container engine. Default is \u0027docker\u0027."},{"line_number":6,"context_line":"container_engine: docker"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"###############################################################################"},{"line_number":9,"context_line":"# Docker configuration."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"afebb731_4c5ccf8a","line":6,"in_reply_to":"1bfa87cc_dde61c0a","updated":"2024-03-13 18:04:35.000000000","message":"Done","commit_id":"bf6e4c845de54eaed2c907c93c3d39e651a87c14"}],"ansible/kayobe-target-venv.yml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"fb75f174ce25b6aacbbac2803991a44b18e768e0","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        - name: Ensure kayobe virtualenv has the podman bindings installed"},{"line_number":68,"context_line":"          pip:"},{"line_number":69,"context_line":"            name: podman"},{"line_number":70,"context_line":"            state: latest"},{"line_number":71,"context_line":"            virtualenv: \"{{ virtualenv }}\""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b7087291_acf811dc","line":69,"updated":"2024-02-21 15:44:08.000000000","message":"Possibly use openstack.kolla.podman_sdk here, but should we also use kolla constraints?","commit_id":"bf6e4c845de54eaed2c907c93c3d39e651a87c14"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"69892d1b0381813fd74336ea2788db27c844c98f","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        - name: Ensure kayobe virtualenv has the podman bindings installed"},{"line_number":68,"context_line":"          pip:"},{"line_number":69,"context_line":"            name: podman"},{"line_number":70,"context_line":"            state: latest"},{"line_number":71,"context_line":"            virtualenv: \"{{ virtualenv }}\""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"138722dd_96a43dab","line":69,"in_reply_to":"b7087291_acf811dc","updated":"2024-03-06 11:16:35.000000000","message":"Done","commit_id":"bf6e4c845de54eaed2c907c93c3d39e651a87c14"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"033488c70523992a391a57398dfc561636a203f9","unresolved":true,"context_lines":[{"line_number":69,"context_line":"             name: openstack.kolla.podman_sdk"},{"line_number":70,"context_line":"          vars:"},{"line_number":71,"context_line":"            virtualenv: \"{{ virtualenv }}\""},{"line_number":72,"context_line":"            podman_sdk_upper_constraints_file: \"{{ pip_upper_constraints_file }}\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        - name: Ensure kayobe virtualenv has SELinux bindings installed"},{"line_number":75,"context_line":"          pip:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"860931bb_ef34aafd","line":72,"updated":"2024-04-04 13:30:42.000000000","message":"when: \u0027container-engine\u0027 in group_names and container_engine \u003d\u003d \u0027podman\u0027?","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"705cdd67986885d21c993de13b6df36ab9c43499","unresolved":false,"context_lines":[{"line_number":69,"context_line":"             name: openstack.kolla.podman_sdk"},{"line_number":70,"context_line":"          vars:"},{"line_number":71,"context_line":"            virtualenv: \"{{ virtualenv }}\""},{"line_number":72,"context_line":"            podman_sdk_upper_constraints_file: \"{{ pip_upper_constraints_file }}\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        - name: Ensure kayobe virtualenv has SELinux bindings installed"},{"line_number":75,"context_line":"          pip:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"448ac7bd_8386dc66","line":72,"in_reply_to":"860931bb_ef34aafd","updated":"2024-05-01 11:22:40.000000000","message":"Done","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fcf35166a4cc86b9cf1d918236848cbdf9922cb2","unresolved":true,"context_lines":[{"line_number":107,"context_line":"            state: present"},{"line_number":108,"context_line":"          become: True"},{"line_number":109,"context_line":"      when: virtualenv is not defined"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    - name: Ensure kolla-ansible virtualenv has docker SDK for python installed"},{"line_number":112,"context_line":"      pip:"},{"line_number":113,"context_line":"        name: docker"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"0b3df371_58fc9db8","line":110,"updated":"2024-04-30 11:17:46.000000000","message":"Should podman SDK installation go here?","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"705cdd67986885d21c993de13b6df36ab9c43499","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            state: present"},{"line_number":108,"context_line":"          become: True"},{"line_number":109,"context_line":"      when: virtualenv is not defined"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    - name: Ensure kolla-ansible virtualenv has docker SDK for python installed"},{"line_number":112,"context_line":"      pip:"},{"line_number":113,"context_line":"        name: docker"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"2be84697_54b0a53b","line":110,"in_reply_to":"0b3df371_58fc9db8","updated":"2024-05-01 11:22:40.000000000","message":"Done","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"033488c70523992a391a57398dfc561636a203f9","unresolved":true,"context_lines":[{"line_number":117,"context_line":"      become: \"{{ virtualenv is not defined }}\""},{"line_number":118,"context_line":"      vars:"},{"line_number":119,"context_line":"        docker_upper_constraints_file: \"{{ pip_upper_constraints_file }}\""},{"line_number":120,"context_line":"      when: \"\u0027docker\u0027 in group_names\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"e8947b70_d384ec9c","line":120,"updated":"2024-04-04 13:30:42.000000000","message":"\u0027container-engine\u0027 in group_names and container_engine \u003d\u003d \u0027docker\u0027?","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"705cdd67986885d21c993de13b6df36ab9c43499","unresolved":false,"context_lines":[{"line_number":117,"context_line":"      become: \"{{ virtualenv is not defined }}\""},{"line_number":118,"context_line":"      vars:"},{"line_number":119,"context_line":"        docker_upper_constraints_file: \"{{ pip_upper_constraints_file }}\""},{"line_number":120,"context_line":"      when: \"\u0027docker\u0027 in group_names\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"4b2d1a57_26fe88b1","line":120,"in_reply_to":"e8947b70_d384ec9c","updated":"2024-05-01 11:22:40.000000000","message":"Done","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"}],"ansible/kolla-target-venv.yml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d24dd3ce9d820c761271f7a0a3d53f9f1a5cd2ca","unresolved":true,"context_lines":[{"line_number":61,"context_line":"            extra_args: \"{% if kolla_upper_constraints_file %}-c {{ kolla_upper_constraints_file }}{% endif %}\""},{"line_number":62,"context_line":"          become: True"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        - name: Ensure kolla-ansible virtualenv has podman SDK installed"},{"line_number":65,"context_line":"          # NOTE(wszumski): This currently has a side-effect of enabling socket"},{"line_number":66,"context_line":"          # activation for podman. See:"},{"line_number":67,"context_line":"          # https://bugs.launchpad.net/ansible-collection-kolla/+bug/2054568"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"57a9a384_8be04e23","line":64,"updated":"2024-02-21 15:45:58.000000000","message":"Switch to using this once I have moved the task mentioned in:\n\nhttps://bugs.launchpad.net/ansible-collection-kolla/+bug/2054568","commit_id":"bf6e4c845de54eaed2c907c93c3d39e651a87c14"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d79058b96e7a37cd345501e0590fa4be094bd41d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            extra_args: \"{% if kolla_upper_constraints_file %}-c {{ kolla_upper_constraints_file }}{% endif %}\""},{"line_number":62,"context_line":"          become: True"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        - name: Ensure kolla-ansible virtualenv has podman SDK installed"},{"line_number":65,"context_line":"          # NOTE(wszumski): This currently has a side-effect of enabling socket"},{"line_number":66,"context_line":"          # activation for podman. See:"},{"line_number":67,"context_line":"          # https://bugs.launchpad.net/ansible-collection-kolla/+bug/2054568"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ad208848_390328bc","line":64,"in_reply_to":"57a9a384_8be04e23","updated":"2025-01-27 16:42:59.000000000","message":"Done","commit_id":"bf6e4c845de54eaed2c907c93c3d39e651a87c14"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"69892d1b0381813fd74336ea2788db27c844c98f","unresolved":true,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        - name: Ensure kolla-ansible virtualenv has podman SDK installed"},{"line_number":67,"context_line":"          pip:"},{"line_number":68,"context_line":"            name: podman"},{"line_number":69,"context_line":"            state: latest"},{"line_number":70,"context_line":"            virtualenv: \"{{ kolla_ansible_target_venv }}\""},{"line_number":71,"context_line":"            extra_args: \"{% if kolla_upper_constraints_file %}-c {{ kolla_upper_constraints_file }}{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"14ab4267_e6bc5ab8","line":68,"updated":"2024-03-06 11:16:35.000000000","message":"Couldn\u0027t easily use podman_sdk role because of variable collision on virtualenv.","commit_id":"ecae1c5a61be757bdadcdfda0be780c1d0b5bac7"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d79058b96e7a37cd345501e0590fa4be094bd41d","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        - name: Ensure kolla-ansible virtualenv has podman SDK installed"},{"line_number":67,"context_line":"          pip:"},{"line_number":68,"context_line":"            name: podman"},{"line_number":69,"context_line":"            state: latest"},{"line_number":70,"context_line":"            virtualenv: \"{{ kolla_ansible_target_venv }}\""},{"line_number":71,"context_line":"            extra_args: \"{% if kolla_upper_constraints_file %}-c {{ kolla_upper_constraints_file }}{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"aa33a242_5da600cc","line":68,"in_reply_to":"14ab4267_e6bc5ab8","updated":"2025-01-27 16:42:59.000000000","message":"Ignoring for now. Can revisit in the future.","commit_id":"ecae1c5a61be757bdadcdfda0be780c1d0b5bac7"}],"ansible/roles/inspection-store/defaults/main.yml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"fb75f174ce25b6aacbbac2803991a44b18e768e0","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# NOTE: Namespace \u0027library\u0027 causes image task to always be changed and"},{"line_number":33,"context_line":"# container to never update to new images."},{"line_number":34,"context_line":"inspection_store_namespace: \"\""},{"line_number":35,"context_line":"inspection_store_image: \"{{ inspection_store ~ \u0027/\u0027 if inspection_store | default else \u0027\u0027 }}{{ inspection_store_namespace ~ \u0027/\u0027 if inspection_store_namespace else \u0027\u0027 }}nginx\""},{"line_number":36,"context_line":"inspection_store_tag: \"stable\""},{"line_number":37,"context_line":"inspection_store_image_full: \"{{ inspection_store_image }}:{{ inspection_store_tag }}\""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"66674df9_98238488","side":"PARENT","line":35,"range":{"start_line":35,"start_character":25,"end_line":35,"end_character":91},"updated":"2024-02-21 15:44:08.000000000","message":"Didn\u0027t understand what inspection_store was. Possibly meant docker_registry?","commit_id":"ba99ba4bede218b1e0aa588f0e56ef2238ebc113"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e20a5e332d12538674dafba4a1ba7c32227e329a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# NOTE: Namespace \u0027library\u0027 causes image task to always be changed and"},{"line_number":33,"context_line":"# container to never update to new images."},{"line_number":34,"context_line":"inspection_store_namespace: \"\""},{"line_number":35,"context_line":"inspection_store_image: \"{{ inspection_store ~ \u0027/\u0027 if inspection_store | default else \u0027\u0027 }}{{ inspection_store_namespace ~ \u0027/\u0027 if inspection_store_namespace else \u0027\u0027 }}nginx\""},{"line_number":36,"context_line":"inspection_store_tag: \"stable\""},{"line_number":37,"context_line":"inspection_store_image_full: \"{{ inspection_store_image }}:{{ inspection_store_tag }}\""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"09527da4_93ed529a","side":"PARENT","line":35,"range":{"start_line":35,"start_character":25,"end_line":35,"end_character":91},"in_reply_to":"66674df9_98238488","updated":"2024-12-12 21:22:09.000000000","message":"Given that opensm uses docker_registry, I would imagine this should be the same.","commit_id":"ba99ba4bede218b1e0aa588f0e56ef2238ebc113"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"2a06ca13007afee79573c13387763378b53b789c","unresolved":true,"context_lines":[{"line_number":30,"context_line":"# Inspection Store"},{"line_number":31,"context_line":"####################"},{"line_number":32,"context_line":"inspection_store_namespace: \"library\""},{"line_number":33,"context_line":"inspection_store_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry | default else \u0027\u0027 }}{{ inspection_store_namespace ~ \u0027/\u0027 if inspection_store_namespace else \u0027\u0027 }}nginx\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"inspection_store_tag: \"stable\""},{"line_number":36,"context_line":"inspection_store_image_full: \"{{ inspection_store_image }}:{{ inspection_store_tag }}\""}],"source_content_type":"text/x-yaml","patch_set":52,"id":"87a145ee_b86826cd","line":33,"updated":"2024-12-26 18:51:07.000000000","message":"This still needs tweaking as it needs to support podman too.","commit_id":"d0e196f7665af597329cfa8e0c950024e2de763e"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"7bf05258896abd793d77a9c4ec37fef4a1f3cfc2","unresolved":true,"context_lines":[{"line_number":30,"context_line":"# Inspection Store"},{"line_number":31,"context_line":"####################"},{"line_number":32,"context_line":"inspection_store_namespace: \"library\""},{"line_number":33,"context_line":"inspection_store_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry | default else \u0027\u0027 }}{{ inspection_store_namespace ~ \u0027/\u0027 if inspection_store_namespace else \u0027\u0027 }}nginx\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"inspection_store_tag: \"stable\""},{"line_number":36,"context_line":"inspection_store_image_full: \"{{ inspection_store_image }}:{{ inspection_store_tag }}\""}],"source_content_type":"text/x-yaml","patch_set":52,"id":"91883148_85b179d7","line":33,"in_reply_to":"69788aa6_eb8beb0e","updated":"2025-01-06 11:16:14.000000000","message":"Also, this is a change in behavior as we have always pulled these images from docker.io, so I\u0027d suggest sticking with the old behavior in this patch and potentially adding support for pulling these images to a local registry in a separate change.","commit_id":"d0e196f7665af597329cfa8e0c950024e2de763e"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"b84db12c06e48f623f98baa3af86ad24b4988212","unresolved":true,"context_lines":[{"line_number":30,"context_line":"# Inspection Store"},{"line_number":31,"context_line":"####################"},{"line_number":32,"context_line":"inspection_store_namespace: \"library\""},{"line_number":33,"context_line":"inspection_store_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry | default else \u0027\u0027 }}{{ inspection_store_namespace ~ \u0027/\u0027 if inspection_store_namespace else \u0027\u0027 }}nginx\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"inspection_store_tag: \"stable\""},{"line_number":36,"context_line":"inspection_store_image_full: \"{{ inspection_store_image }}:{{ inspection_store_tag }}\""}],"source_content_type":"text/x-yaml","patch_set":52,"id":"69788aa6_eb8beb0e","line":33,"in_reply_to":"87a145ee_b86826cd","updated":"2025-01-06 11:05:59.000000000","message":"This is more of a nit, as my main priority is get this patch merged, but I\u0027m still not convinced having a separate variable (podman_registry) is the best way to go as I don\u0027t think there is ever a use case for configuring a different registry for podman vs docker. It also doesn\u0027t match kolla-ansible which only uses docker_registry. I still think having a generic `container_registry` variable  is the cleanest, but also see arguments for just repurposing the docker_registry variable to match kolla (let them jump first).","commit_id":"d0e196f7665af597329cfa8e0c950024e2de763e"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"997215c833546a6b9ba53a0a1dadf961600a9e94","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# Inspection Store"},{"line_number":31,"context_line":"####################"},{"line_number":32,"context_line":"inspection_store_namespace: \"library\""},{"line_number":33,"context_line":"inspection_store_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry | default else \u0027\u0027 }}{{ inspection_store_namespace ~ \u0027/\u0027 if inspection_store_namespace else \u0027\u0027 }}nginx\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"inspection_store_tag: \"stable\""},{"line_number":36,"context_line":"inspection_store_image_full: \"{{ inspection_store_image }}:{{ inspection_store_tag }}\""}],"source_content_type":"text/x-yaml","patch_set":52,"id":"41a3aa4b_12b2ed89","line":33,"in_reply_to":"91883148_85b179d7","updated":"2025-01-21 08:50:15.000000000","message":"Agreed, let\u0027s keep this for another change.","commit_id":"d0e196f7665af597329cfa8e0c950024e2de763e"}],"ansible/roles/kolla/tasks/install.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fcf35166a4cc86b9cf1d918236848cbdf9922cb2","unresolved":true,"context_lines":[{"line_number":85,"context_line":"      # This can be removed once a newer version of docker is released and the version in upper"},{"line_number":86,"context_line":"      # constraints has been bumped (\u003e7.0.0)."},{"line_number":87,"context_line":"      extra_args: \"{{ omit }}\""},{"line_number":88,"context_line":"    - name: \"podman\""},{"line_number":89,"context_line":"  when: item.install | default(True) | bool"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"f49e0b70_b3037311","line":88,"updated":"2024-04-30 11:17:46.000000000","message":"install: \"{{ container_engine \u003d\u003d \u0027podman\u0027 }}\"","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d6c8de4eeef709674cf909027d1a6fb58ba2c35a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"      # This can be removed once a newer version of docker is released and the version in upper"},{"line_number":86,"context_line":"      # constraints has been bumped (\u003e7.0.0)."},{"line_number":87,"context_line":"      extra_args: \"{{ omit }}\""},{"line_number":88,"context_line":"    - name: \"podman\""},{"line_number":89,"context_line":"  when: item.install | default(True) | bool"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"d8e43972_7854210f","line":88,"in_reply_to":"f49e0b70_b3037311","updated":"2024-05-01 11:35:34.000000000","message":"Done","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"cf607dfd9e886c2d04d9a386a76797edab1ad2fa","unresolved":true,"context_lines":[{"line_number":80,"context_line":"      install: \"{{ kolla_ctl_install_type \u003d\u003d \u0027binary\u0027 }}\""},{"line_number":81,"context_line":"    # Install docker from PyPI since it was dropped from kolla requirements."},{"line_number":82,"context_line":"    # Skip 7.0.0 due to: https://github.com/docker/docker-py/issues/3195"},{"line_number":83,"context_line":"    - name: \"docker!\u003d7.0.0,\u003c8\""},{"line_number":84,"context_line":"      # NOTE(wszumski): Workaround for ERROR: ResolutionImpossible when using upper constraints."},{"line_number":85,"context_line":"      # This can be removed once a newer version of docker is released and the version in upper"},{"line_number":86,"context_line":"      # constraints has been bumped (\u003e7.0.0)."},{"line_number":87,"context_line":"      extra_args: \"{{ omit }}\""},{"line_number":88,"context_line":"    - name: \"podman\""},{"line_number":89,"context_line":"      install: \"{{ container_engine \u003d\u003d \u0027podman\u0027 }}\""},{"line_number":90,"context_line":"  when: item.install | default(True) | bool"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"d707ef23_ceb4acc4","line":87,"range":{"start_line":83,"start_character":0,"end_line":87,"end_character":30},"updated":"2025-01-27 16:19:25.000000000","message":"Install the docker library only when using docker as container engine?","commit_id":"be86554cfd6c3ce28e9fc21f09a30c135732fe74"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d79058b96e7a37cd345501e0590fa4be094bd41d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"      install: \"{{ kolla_ctl_install_type \u003d\u003d \u0027binary\u0027 }}\""},{"line_number":81,"context_line":"    # Install docker from PyPI since it was dropped from kolla requirements."},{"line_number":82,"context_line":"    # Skip 7.0.0 due to: https://github.com/docker/docker-py/issues/3195"},{"line_number":83,"context_line":"    - name: \"docker!\u003d7.0.0,\u003c8\""},{"line_number":84,"context_line":"      # NOTE(wszumski): Workaround for ERROR: ResolutionImpossible when using upper constraints."},{"line_number":85,"context_line":"      # This can be removed once a newer version of docker is released and the version in upper"},{"line_number":86,"context_line":"      # constraints has been bumped (\u003e7.0.0)."},{"line_number":87,"context_line":"      extra_args: \"{{ omit }}\""},{"line_number":88,"context_line":"    - name: \"podman\""},{"line_number":89,"context_line":"      install: \"{{ container_engine \u003d\u003d \u0027podman\u0027 }}\""},{"line_number":90,"context_line":"  when: item.install | default(True) | bool"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"bca50442_1a9115bb","line":87,"range":{"start_line":83,"start_character":0,"end_line":87,"end_character":30},"in_reply_to":"d707ef23_ceb4acc4","updated":"2025-01-27 16:42:59.000000000","message":"Done","commit_id":"be86554cfd6c3ce28e9fc21f09a30c135732fe74"}],"ansible/seed-service-upgrade-prep.yml":[{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"033488c70523992a391a57398dfc561636a203f9","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    - block:"},{"line_number":8,"context_line":"        - name: Find IPA deployment images"},{"line_number":9,"context_line":"          find:"},{"line_number":10,"context_line":"            path: /var/lib/docker/volumes/bifrost_httpboot/_data"},{"line_number":11,"context_line":"            patterns:"},{"line_number":12,"context_line":"              # Specify filenames individually to avoid movind previously moved"},{"line_number":13,"context_line":"              # images."}],"source_content_type":"text/x-yaml","patch_set":35,"id":"40e73a1d_6aadfd68","line":10,"updated":"2024-04-04 13:30:42.000000000","message":"Does this need to use the generic path?","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"705cdd67986885d21c993de13b6df36ab9c43499","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    - block:"},{"line_number":8,"context_line":"        - name: Find IPA deployment images"},{"line_number":9,"context_line":"          find:"},{"line_number":10,"context_line":"            path: /var/lib/docker/volumes/bifrost_httpboot/_data"},{"line_number":11,"context_line":"            patterns:"},{"line_number":12,"context_line":"              # Specify filenames individually to avoid movind previously moved"},{"line_number":13,"context_line":"              # images."}],"source_content_type":"text/x-yaml","patch_set":35,"id":"af55b3f6_6d2f0d37","line":10,"in_reply_to":"40e73a1d_6aadfd68","updated":"2024-05-01 11:22:40.000000000","message":"Yes, good spot.","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"}],"etc/kayobe/container-engine.yml":[{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"033488c70523992a391a57398dfc561636a203f9","unresolved":true,"context_lines":[{"line_number":58,"context_line":"# location: \u0027/var/lib/containers/storage\u0027."},{"line_number":59,"context_line":"#podman_runtime_directory:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# Path to docker volumes. Default is \u0027{{ podman_runtime_directory | default(\u0027/var/lib/containers/storage\u0027, true) ~ \u0027/volumes\u0027 }}\"\u0027."},{"line_number":62,"context_line":"#podman_volumes_path:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"###############################################################################"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"8fd423ce_62aaf8ca","line":61,"updated":"2024-04-04 13:30:42.000000000","message":"podman volumes","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"871a8245aae1a4d18b5b1c844cf2123a36096278","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# location: \u0027/var/lib/containers/storage\u0027."},{"line_number":59,"context_line":"#podman_runtime_directory:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# Path to docker volumes. Default is \u0027{{ podman_runtime_directory | default(\u0027/var/lib/containers/storage\u0027, true) ~ \u0027/volumes\u0027 }}\"\u0027."},{"line_number":62,"context_line":"#podman_volumes_path:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"###############################################################################"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9b1b99c0_c659fec7","line":61,"in_reply_to":"8fd423ce_62aaf8ca","updated":"2024-05-02 08:59:22.000000000","message":"Done","commit_id":"04c3d0c10acf74a30cd6e80ee5d7a6cc20aa6062"}],"roles/kayobe-galaxy-requirements/tasks/main.yml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"ea8f7880840ab471467ed174f6dd8d40000a2ca1","unresolved":true,"context_lines":[{"line_number":18,"context_line":"      version: \"{{ kayobe_galaxy_requirements_branch }}\""},{"line_number":19,"context_line":"    # NOTE(wszusmki): Use version checked out by Zuul so Depends-On works and only override version"},{"line_number":20,"context_line":"    # for previous release."},{"line_number":21,"context_line":"    new_requirement_with_version: \"{{ new_requirement | combine(version) if kayobe_galaxy_requirements_branch else new_requirement }}\""},{"line_number":22,"context_line":"    new_requirements:"},{"line_number":23,"context_line":"      collections: \"{{ (old_requirements.collections | rejectattr(\u0027name\u0027, \u0027search\u0027, \u0027ansible-collection-kolla\u0027) | list) + [new_requirement] }}\""},{"line_number":24,"context_line":"      roles: \"{{ old_requirements.roles | default([]) }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bd936c81_6097e5a2","line":21,"updated":"2024-02-23 17:39:20.000000000","message":"This is unrelated, but I noticed depends-on was broken.","commit_id":"1a4c0c2728d0413a23e9d4224dd9e102a2460e1f"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"7eaf1a3accbbed88c1ad971987913f0a6f07cade","unresolved":true,"context_lines":[{"line_number":18,"context_line":"      version: \"{{ kayobe_galaxy_requirements_branch }}\""},{"line_number":19,"context_line":"    # NOTE(wszusmki): Use version checked out by Zuul so Depends-On works and only override version"},{"line_number":20,"context_line":"    # for previous release."},{"line_number":21,"context_line":"    new_requirement_with_version: \"{{ new_requirement | combine(version) if kayobe_galaxy_requirements_branch else new_requirement }}\""},{"line_number":22,"context_line":"    new_requirements:"},{"line_number":23,"context_line":"      collections: \"{{ (old_requirements.collections | rejectattr(\u0027name\u0027, \u0027search\u0027, \u0027ansible-collection-kolla\u0027) | list) + [new_requirement] }}\""},{"line_number":24,"context_line":"      roles: \"{{ old_requirements.roles | default([]) }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"33906a44_7b1c5efe","line":21,"in_reply_to":"1d8deeea_1c8517ac","updated":"2025-01-22 10:57:21.000000000","message":"I agree this should be a separate commit, so we can backport it too. I\u0027ve proposed this, also with a fix because we aren\u0027t actually using ``new_requirement_with_version`` here\n\nhttps://review.opendev.org/c/openstack/kayobe/+/939780","commit_id":"1a4c0c2728d0413a23e9d4224dd9e102a2460e1f"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"f69791db1e74736d1ba5391ad6562e939469541e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      version: \"{{ kayobe_galaxy_requirements_branch }}\""},{"line_number":19,"context_line":"    # NOTE(wszusmki): Use version checked out by Zuul so Depends-On works and only override version"},{"line_number":20,"context_line":"    # for previous release."},{"line_number":21,"context_line":"    new_requirement_with_version: \"{{ new_requirement | combine(version) if kayobe_galaxy_requirements_branch else new_requirement }}\""},{"line_number":22,"context_line":"    new_requirements:"},{"line_number":23,"context_line":"      collections: \"{{ (old_requirements.collections | rejectattr(\u0027name\u0027, \u0027search\u0027, \u0027ansible-collection-kolla\u0027) | list) + [new_requirement] }}\""},{"line_number":24,"context_line":"      roles: \"{{ old_requirements.roles | default([]) }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"93de1ea6_41e05436","line":21,"in_reply_to":"33906a44_7b1c5efe","updated":"2025-01-24 09:50:57.000000000","message":"Dropped from this commit.","commit_id":"1a4c0c2728d0413a23e9d4224dd9e102a2460e1f"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e20a5e332d12538674dafba4a1ba7c32227e329a","unresolved":true,"context_lines":[{"line_number":18,"context_line":"      version: \"{{ kayobe_galaxy_requirements_branch }}\""},{"line_number":19,"context_line":"    # NOTE(wszusmki): Use version checked out by Zuul so Depends-On works and only override version"},{"line_number":20,"context_line":"    # for previous release."},{"line_number":21,"context_line":"    new_requirement_with_version: \"{{ new_requirement | combine(version) if kayobe_galaxy_requirements_branch else new_requirement }}\""},{"line_number":22,"context_line":"    new_requirements:"},{"line_number":23,"context_line":"      collections: \"{{ (old_requirements.collections | rejectattr(\u0027name\u0027, \u0027search\u0027, \u0027ansible-collection-kolla\u0027) | list) + [new_requirement] }}\""},{"line_number":24,"context_line":"      roles: \"{{ old_requirements.roles | default([]) }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1d8deeea_1c8517ac","line":21,"in_reply_to":"bd936c81_6097e5a2","updated":"2024-12-12 21:22:09.000000000","message":"Should this go in a separate commit?","commit_id":"1a4c0c2728d0413a23e9d4224dd9e102a2460e1f"}]}