)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10910,"name":"Stig Telfer","email":"stig.openstack@telfer.org","username":"stigtelfer"},"change_message_id":"fc91ae59be7017aef7c8618b90fd59b208ab0e28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f02c8ddd_76d28efb","updated":"2024-07-12 16:22:09.000000000","message":"Minor observation on approach","commit_id":"192fec32fdd89499871aaad43ecac8aca9a1de46"}],"kayobe/plugins/filter/networkd.py":[{"author":{"_account_id":10910,"name":"Stig Telfer","email":"stig.openstack@telfer.org","username":"stigtelfer"},"change_message_id":"fc91ae59be7017aef7c8618b90fd59b208ab0e28","unresolved":true,"context_lines":[{"line_number":116,"context_line":"        }"},{"line_number":117,"context_line":"    ]"},{"line_number":118,"context_line":"    if ingress_qos_maps:"},{"line_number":119,"context_line":"        config[1][\u0027VLAN\u0027].append({\u0027IngressQOSMaps\u0027: ingress_qos_maps})"},{"line_number":120,"context_line":"    if egress_qos_maps:"},{"line_number":121,"context_line":"        config[1][\u0027VLAN\u0027].append({\u0027EgressQOSMaps\u0027: egress_qos_maps})"},{"line_number":122,"context_line":"    return _filter_options(config)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df897620_a1bebb7c","line":119,"updated":"2024-07-12 16:22:09.000000000","message":"Instead of referencing config[1] it might be nicer to create a separate list variable of config for the VLAN section above, conditionally appending egress and ingress qos map settings to that list if defined, and then reference that list variable in config above.","commit_id":"192fec32fdd89499871aaad43ecac8aca9a1de46"}]}