)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"b8cf05d160b223a3b9d6911d4ae8307f4f0d71e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1f42521b_516835e7","updated":"2024-03-22 09:53:17.000000000","message":"recheck: fluentd docker issues fix is merged now: https://review.opendev.org/c/openstack/kolla-ansible/+/913868","commit_id":"461967f7cec5d93622cb75eefc2a30c49e78e633"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"a7b72007796ab323070f6ede91b588406ccc22ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1fe34e48_6fa9a30e","updated":"2024-05-23 10:36:15.000000000","message":"recheck: depends-on merged: https://review.opendev.org/c/openstack/kayobe/+/919925","commit_id":"6f89f7809fd2fc197177c4c68f1d23501e33777d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"90286f813325eb12ac7d6770d714cfe05e04f8ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"da8066e5_30066710","updated":"2024-05-24 12:10:24.000000000","message":"recheck: permissions fixed https://review.opendev.org/c/openstack/kayobe/+/920375","commit_id":"0c8479a92474932e23744e67f335942851ae90fe"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"56a4411fb477a4bb7148a695a27307dd26a8faa8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e2a13bca_c5a31f7a","updated":"2024-08-12 15:24:05.000000000","message":"-1 for now, the proper way to handle RabbitMQ SLURP in KA is still in flux. See topic: https://review.opendev.org/q/topic:%22slurp-rabbitmq%22\n\nLet\u0027s wait until the key parts of this are merged and finalise the Kayobe side then.","commit_id":"0dc7291fe86b5b7d37bfc0d143dfcaac879a208b"},{"author":{"_account_id":36781,"name":"Massimiliano Favaro-Bedford","display_name":"Max","email":"max@stackhpc.com","username":"MaxBed4d"},"change_message_id":"bbf73c3dc0bc7306dc1284787bf0413bac46fda1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8d954fc2_88aefb13","updated":"2024-08-12 12:19:48.000000000","message":"Amend things we discussed (branch, etc...), once those are done this is good to go!","commit_id":"0dc7291fe86b5b7d37bfc0d143dfcaac879a208b"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"11309a6f24f0331d341b0fff7e7acf1742837a52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"57aa245a_8e7600c1","updated":"2024-06-05 08:37:18.000000000","message":"Back to hitting: https://bugs.launchpad.net/kolla-ansible/+bug/2058512. Did you have a patch to backport the newer rabbit back to 2023.1?","commit_id":"0dc7291fe86b5b7d37bfc0d143dfcaac879a208b"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"1a4249c5ad2a0320c2dd5a2b5669022a5486ee6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c975b187_0d93addc","in_reply_to":"2e7b6dfc_568c8119","updated":"2024-06-05 09:29:05.000000000","message":"Yes we will want to do this. I\u0027d planned for this to be a follow-up patch once the KA command merges (and all the depends-on patches ofc). https://review.opendev.org/c/openstack/kolla-ansible/+/918976","commit_id":"0dc7291fe86b5b7d37bfc0d143dfcaac879a208b"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"2b218990e34b68e02915d06d7a27bc16e97d61c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a9c0640b_2ec14721","in_reply_to":"57aa245a_8e7600c1","updated":"2024-06-05 08:44:00.000000000","message":"Yes, the patch is ongoing here: https://review.opendev.org/c/openstack/kolla/+/918974\n\nHowever, I think this patch to handle feature flags differently should resolve that error: https://review.opendev.org/c/openstack/kolla-ansible/+/914535","commit_id":"0dc7291fe86b5b7d37bfc0d143dfcaac879a208b"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"7db2f123de63e99261cbebbed647ecf5fdc58994","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2e7b6dfc_568c8119","in_reply_to":"a9c0640b_2ec14721","updated":"2024-06-05 09:09:03.000000000","message":"I guess we will still want to follow the documented route and upgrade to 3.12 first? They have this example in the docs:\n\n    For example, when upgrading from 3.9.x to 3.13.x, it would be necessary to first upgrade to 3.10.x, then to 3.11.x, then to 3.12.x, and finally upgrade to 3.13.0, or consider a The Blue/Green deployment upgrade.\n\nhttps://www.rabbitmq.com/docs/upgrade#rabbitmq-version-upgradability","commit_id":"0dc7291fe86b5b7d37bfc0d143dfcaac879a208b"}],"dev/functions":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"03383c398019a4384026042557b226bfe8f7c5ed","unresolved":true,"context_lines":[{"line_number":494,"context_line":"    echo \"Control plane deployment complete\""},{"line_number":495,"context_line":"}"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"function migrate_rabbitmq_queues {"},{"line_number":498,"context_line":"    echo \"Migrating to RabbitMQ quorum queues\""},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"    environment_setup"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fd515fd_f4fe18d9","line":497,"updated":"2024-03-21 09:38:25.000000000","message":"The only oddity is that is runs with kayobe-config from the new version:\n\nhttps://github.com/openstack/kayobe/blob/master/playbooks/kayobe-overcloud-upgrade-base/run.yml#L112-L114\n\nwhich gets used here:\n\nhttps://github.com/openstack/kayobe/blob/master/dev/functions#L259\n\nWould be more correct if we ran it with the old kayobe config.","commit_id":"b812ee4a05fa98323dc5d053c4d802a2074de5d4"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"9a76e55c6d165b20806929d1b214d224ec58efa7","unresolved":false,"context_lines":[{"line_number":494,"context_line":"    echo \"Control plane deployment complete\""},{"line_number":495,"context_line":"}"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"function migrate_rabbitmq_queues {"},{"line_number":498,"context_line":"    echo \"Migrating to RabbitMQ quorum queues\""},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"    environment_setup"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"88a89407_a5c4a0cd","line":497,"in_reply_to":"1154ebc4_ce2b9545","updated":"2024-05-16 11:18:22.000000000","message":"Have made this change, still testing locally but let\u0027s run it through Zuul too","commit_id":"b812ee4a05fa98323dc5d053c4d802a2074de5d4"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"aa38637471534de54138385d421dff51f482a0bf","unresolved":true,"context_lines":[{"line_number":494,"context_line":"    echo \"Control plane deployment complete\""},{"line_number":495,"context_line":"}"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"function migrate_rabbitmq_queues {"},{"line_number":498,"context_line":"    echo \"Migrating to RabbitMQ quorum queues\""},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"    environment_setup"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1154ebc4_ce2b9545","line":497,"in_reply_to":"1b25293d_63b7a38b","updated":"2024-04-02 08:55:27.000000000","message":"It does look like it does the correct thing. I was personally thinking of a separate script in dev e.g dev/migrate-rabbit-queues.sh to avoid the need for PREVIOUS_KAYOBE_CONFIG_SOURCE_PATH.","commit_id":"b812ee4a05fa98323dc5d053c4d802a2074de5d4"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"c0af0a2fceb0d5272f5af04fedea5669dbe7445f","unresolved":true,"context_lines":[{"line_number":494,"context_line":"    echo \"Control plane deployment complete\""},{"line_number":495,"context_line":"}"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"function migrate_rabbitmq_queues {"},{"line_number":498,"context_line":"    echo \"Migrating to RabbitMQ quorum queues\""},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"    environment_setup"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"c3e5eb92_18e104d0","line":497,"in_reply_to":"3fd515fd_f4fe18d9","updated":"2024-03-21 10:25:42.000000000","message":"If I\u0027ve understood correctly, the changes I\u0027ve made should now mean it migrates with the old kayobe config.","commit_id":"b812ee4a05fa98323dc5d053c4d802a2074de5d4"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"e50fe3117f6d09851ac6442be5930098599a7878","unresolved":true,"context_lines":[{"line_number":494,"context_line":"    echo \"Control plane deployment complete\""},{"line_number":495,"context_line":"}"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"function migrate_rabbitmq_queues {"},{"line_number":498,"context_line":"    echo \"Migrating to RabbitMQ quorum queues\""},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"    environment_setup"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1b25293d_63b7a38b","line":497,"in_reply_to":"b1c72b8e_41b52aed","updated":"2024-03-21 10:46:02.000000000","message":"Rather than moving the migrations to the old block, it matches our recommended process to migrate right before the upgrade. I\u0027ve changed this to source the previous kayobe config just for the migrations. Does this seem correct to you?","commit_id":"b812ee4a05fa98323dc5d053c4d802a2074de5d4"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d7b36ede4e8eb4bd5cea622adebc0a514b0fd37c","unresolved":true,"context_lines":[{"line_number":494,"context_line":"    echo \"Control plane deployment complete\""},{"line_number":495,"context_line":"}"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"function migrate_rabbitmq_queues {"},{"line_number":498,"context_line":"    echo \"Migrating to RabbitMQ quorum queues\""},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"    environment_setup"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"b1c72b8e_41b52aed","line":497,"in_reply_to":"c3e5eb92_18e104d0","updated":"2024-03-21 10:33:13.000000000","message":"upgrade.sh would have to run in this block:\n\nhttps://github.com/openstack/kayobe/blob/master/playbooks/kayobe-overcloud-upgrade-base/run.yml#L8-L30\n\nfor that to be true. upgrade_kayobe_venv just updates kayobe. The location of kayobe-config is set by KAYOBE_CONFIG_SOURCE_PATH. At the moment, we essentially run old kayobe with the new kayobe-config (which may work, but is a bit odd).","commit_id":"b812ee4a05fa98323dc5d053c4d802a2074de5d4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"540a2ec0ba933b17481e18ee20c179d7a8776a4c","unresolved":true,"context_lines":[{"line_number":501,"context_line":"    set +u"},{"line_number":502,"context_line":"    source \"${KAYOBE_VENV_PATH}/bin/activate\""},{"line_number":503,"context_line":"    set -u"},{"line_number":504,"context_line":"    source \"${PREVIOUS_KAYOBE_CONFIG_SOURCE_PATH}/kayobe-env\""},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    sed -i -e \u0027$aom_enable_rabbitmq_quorum_queues: True\u0027 ${PREVIOUS_KAYOBE_CONFIG_SOURCE_PATH}/etc/kayobe/kolla/globals.yml"},{"line_number":507,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"30e4b5d6_54b0a66a","line":504,"updated":"2024-03-28 12:32:25.000000000","message":"Do we have the change in kayobe-config-dev that makes this unsticky?","commit_id":"f02882f5faf17ab4cd53ec59538417eb5b4f30ad"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"540a2ec0ba933b17481e18ee20c179d7a8776a4c","unresolved":true,"context_lines":[{"line_number":501,"context_line":"    set +u"},{"line_number":502,"context_line":"    source \"${KAYOBE_VENV_PATH}/bin/activate\""},{"line_number":503,"context_line":"    set -u"},{"line_number":504,"context_line":"    source \"${PREVIOUS_KAYOBE_CONFIG_SOURCE_PATH}/kayobe-env\""},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    sed -i -e \u0027$aom_enable_rabbitmq_quorum_queues: True\u0027 ${PREVIOUS_KAYOBE_CONFIG_SOURCE_PATH}/etc/kayobe/kolla/globals.yml"},{"line_number":507,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"8755b345_e33dfd34","line":504,"updated":"2024-03-28 12:32:25.000000000","message":"Ideally this would also work outside of Kayobe CI without needing to define PREVIOUS_KAYOBE_CONFIG_SOURCE_PATH. Possibly it could default to KAYOBE_CONFIG_SOURCE_PATH.","commit_id":"f02882f5faf17ab4cd53ec59538417eb5b4f30ad"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"157b326f0b9fec79d982ef57c50a36cc556cb341","unresolved":false,"context_lines":[{"line_number":501,"context_line":"    set +u"},{"line_number":502,"context_line":"    source \"${KAYOBE_VENV_PATH}/bin/activate\""},{"line_number":503,"context_line":"    set -u"},{"line_number":504,"context_line":"    source \"${PREVIOUS_KAYOBE_CONFIG_SOURCE_PATH}/kayobe-env\""},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    sed -i -e \u0027$aom_enable_rabbitmq_quorum_queues: True\u0027 ${PREVIOUS_KAYOBE_CONFIG_SOURCE_PATH}/etc/kayobe/kolla/globals.yml"},{"line_number":507,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"19b99c02_ec2f2c33","line":504,"in_reply_to":"30e4b5d6_54b0a66a","updated":"2024-05-21 14:25:15.000000000","message":"I don\u0027t know which change you mean, but moving to a separate script means we won\u0027t need the variable at all.","commit_id":"f02882f5faf17ab4cd53ec59538417eb5b4f30ad"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"157b326f0b9fec79d982ef57c50a36cc556cb341","unresolved":false,"context_lines":[{"line_number":501,"context_line":"    set +u"},{"line_number":502,"context_line":"    source \"${KAYOBE_VENV_PATH}/bin/activate\""},{"line_number":503,"context_line":"    set -u"},{"line_number":504,"context_line":"    source \"${PREVIOUS_KAYOBE_CONFIG_SOURCE_PATH}/kayobe-env\""},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    sed -i -e \u0027$aom_enable_rabbitmq_quorum_queues: True\u0027 ${PREVIOUS_KAYOBE_CONFIG_SOURCE_PATH}/etc/kayobe/kolla/globals.yml"},{"line_number":507,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"2f5160f2_a66cce0d","line":504,"in_reply_to":"8755b345_e33dfd34","updated":"2024-05-21 14:25:15.000000000","message":"Moved to a separate script in 2023.1 which will work standalone","commit_id":"f02882f5faf17ab4cd53ec59538417eb5b4f30ad"}],"playbooks/kayobe-overcloud-upgrade-base/run.yml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"7b4387502a4062f9951574ed5e0c5b5816091082","unresolved":true,"context_lines":[{"line_number":89,"context_line":"            cmd: dev/rabbitmq-migrate-queues.sh ironic,keystone,neutron,nova \u0026\u003e {{ logs_dir }}/ansible/rabbitmq-migrate-queues"},{"line_number":90,"context_line":"            chdir: \"{{ previous_kayobe_src_dir }}\""},{"line_number":91,"context_line":"            executable: /bin/bash"},{"line_number":92,"context_line":"          when: is_slurp"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        - name: Ensure overcloud is upgraded"},{"line_number":95,"context_line":"          shell:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"980c18c1_e0c607a8","line":92,"updated":"2024-05-30 09:12:30.000000000","message":"I guess you made need to set these variables:\n\n      environment:\n        KAYOBE_CONFIG_SOURCE_PATH: \"{{ kayobe_config_src_dir }}\"\n        KAYOBE_SOURCE_PATH: \"{{ kayobe_src_dir }}\"\n\nfor this task back to the previous release","commit_id":"0c8479a92474932e23744e67f335942851ae90fe"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"1d14a2d145ad4ee01e3bf9401d799a120ca82b26","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            cmd: dev/rabbitmq-migrate-queues.sh ironic,keystone,neutron,nova \u0026\u003e {{ logs_dir }}/ansible/rabbitmq-migrate-queues"},{"line_number":90,"context_line":"            chdir: \"{{ previous_kayobe_src_dir }}\""},{"line_number":91,"context_line":"            executable: /bin/bash"},{"line_number":92,"context_line":"          when: is_slurp"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        - name: Ensure overcloud is upgraded"},{"line_number":95,"context_line":"          shell:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"04d932c2_d2cb248a","line":92,"in_reply_to":"980c18c1_e0c607a8","updated":"2024-06-05 08:44:06.000000000","message":"Done","commit_id":"0c8479a92474932e23744e67f335942851ae90fe"}]}