)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36781,"name":"Massimiliano Favaro-Bedford","display_name":"Max","email":"max@stackhpc.com","username":"MaxBed4d"},"change_message_id":"7d02a5f5ab564ead5bfd1dac1d40dbe122af5362","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e17ad126_0d6ad645","updated":"2024-08-12 09:43:56.000000000","message":"Looks good and seems like a sensible and elegant solution. My only question would be whether the path definitions in the ```_get_environment``` module could be constructed as a loop over ```roles_paths```, ```collections_paths```, ```action_plugins```, ```filter_plugins``` and ```test_plugins```?\n\nOtherwise, looks good to me!","commit_id":"a5baae9c7a3599071b05ec838e28f192260d1854"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"4b1300b5d459a900726a1c63cecc1f9ac95d02c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"60ca04e9_c02f23b3","updated":"2024-05-16 09:39:50.000000000","message":"recheck:  501: Server Error for url: http://192.168.33.2:8774/v2.1/servers/39199b7f-27a2-4960-97bb-be0ea17f548c/action,","commit_id":"a5baae9c7a3599071b05ec838e28f192260d1854"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"1311b117a709f54cc56ee351d78d8b35aca8276a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"733c8177_ecf34a19","in_reply_to":"e17ad126_0d6ad645","updated":"2024-11-08 11:24:11.000000000","message":"It sounds like a decent idea, the code is pretty much duplicated between these. I\u0027d say this is outside the scope of a bugfix though, so could be a follow-up patch.","commit_id":"a5baae9c7a3599071b05ec838e28f192260d1854"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"1311b117a709f54cc56ee351d78d8b35aca8276a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"16a5d077_527a9275","updated":"2024-11-08 11:24:11.000000000","message":"Tested this and it works well","commit_id":"a2d04af60e205cf9775f83e45f9c698f4b8b4481"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2da62fa322f2fb0c62e722dd587c111110e9bc0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"82ff5205_3a22db7e","updated":"2024-11-07 11:03:08.000000000","message":"should we need a note about precedence mentioned only in the reno to the docs? anyway lgtm","commit_id":"a2d04af60e205cf9775f83e45f9c698f4b8b4481"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b168b6d455d9e1e5d02876f2ed12d00fa3678531","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"160b9670_2df416e2","updated":"2024-11-08 13:42:24.000000000","message":"Might need to ensure the ordering of role/collection path is always the same.","commit_id":"3d9c2d5b8acd3133ee06be0a5ec2d8f164949909"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"19c5be2f3644cef51b197eeebf25d3542f1a2817","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"517ad303_6354fcd5","updated":"2024-11-12 13:39:33.000000000","message":"New unit test is failing because:\n\n`first_playbook \u003d os.path.realpath(playbooks[0])` yields `/home/ubuntu/kayobe/ansible/playbook1.yml`\n\n`utils.get_data_files_path(\"ansible\")` yields `/home/ubuntu/kayobe/kayobe/../ansible`\n\nAs such, `not first_playbook.startswith(utils.get_data_files_path(\"ansible\"))` is always true, so pb1/pb2 in the unit test get treated as external.\n\nI\u0027m working on a fix","commit_id":"3d9c2d5b8acd3133ee06be0a5ec2d8f164949909"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"9ef3cfdbdf06be4756b95f034bc0a1f2caf0b408","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"331dc284_384cefe4","in_reply_to":"517ad303_6354fcd5","updated":"2024-11-12 13:48:14.000000000","message":"Done","commit_id":"3d9c2d5b8acd3133ee06be0a5ec2d8f164949909"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"9ef3cfdbdf06be4756b95f034bc0a1f2caf0b408","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a155d543_ef986062","updated":"2024-11-12 13:48:14.000000000","message":"Just +1 as I made the latest changes","commit_id":"01632fb577080105d0c0f0d2be58bc166a90b33a"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"5225a795825356049e2a1a2dbf38fe8f182edff8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9eea247e_58387420","updated":"2024-11-12 14:20:24.000000000","message":"Nice - cheers Matt. Fix looks good to me.","commit_id":"01632fb577080105d0c0f0d2be58bc166a90b33a"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"0178ac6182b4198e2ef1dd44be1b202626f68e2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6078911f_9f853487","updated":"2024-11-12 20:32:51.000000000","message":"recheck\n\nPOST_FAILURE","commit_id":"1bb33e8e418cbe075644bfe561311289c582be48"}],"releasenotes/notes/improve-namespacing-for-internal-playbooks-baed54403608c3e7.yaml":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"d607b380d071cb5eead3813c6c59ae3f0cdb6351","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    The Ansible search paths, when running Kayobe internal playbooks, have been"},{"line_number":5,"context_line":"    modified so that collections, roles and plugins internal to the Kayobe"},{"line_number":6,"context_line":"    install have precedence over those installed in Kayobe config.  This"},{"line_number":7,"context_line":"    improves the usability as it now possible to install a newer version of a"},{"line_number":8,"context_line":"    extension without affecting internal kayobe playbooks."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"20131c2f_da202c0e","line":7,"range":{"start_line":7,"start_character":76,"end_line":7,"end_character":77},"updated":"2024-05-01 09:07:40.000000000","message":"nit: ``a extension`` -\u003e ``an extension``","commit_id":"0245bbb58191d1297a813715a1bea9abd9d69b9a"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"d607b380d071cb5eead3813c6c59ae3f0cdb6351","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    The Ansible search paths, when running Kayobe internal playbooks, have been"},{"line_number":5,"context_line":"    modified so that collections, roles and plugins internal to the Kayobe"},{"line_number":6,"context_line":"    install have precedence over those installed in Kayobe config.  This"},{"line_number":7,"context_line":"    improves the usability as it now possible to install a newer version of a"},{"line_number":8,"context_line":"    extension without affecting internal kayobe playbooks."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d0458250_089fdb54","line":7,"updated":"2024-05-01 09:07:40.000000000","message":"nit: ``it now possible`` -\u003e ``it is now possible``","commit_id":"0245bbb58191d1297a813715a1bea9abd9d69b9a"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"628dcaa246af65fdb8664e62dac6becfcea7b3d4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    The Ansible search paths, when running Kayobe internal playbooks, have been"},{"line_number":5,"context_line":"    modified so that collections, roles and plugins internal to the Kayobe"},{"line_number":6,"context_line":"    install have precedence over those installed in Kayobe config.  This"},{"line_number":7,"context_line":"    improves the usability as it now possible to install a newer version of a"},{"line_number":8,"context_line":"    extension without affecting internal kayobe playbooks."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c8bafc1e_cf0f16e1","line":7,"range":{"start_line":7,"start_character":76,"end_line":7,"end_character":77},"in_reply_to":"20131c2f_da202c0e","updated":"2024-05-01 10:39:19.000000000","message":"Done","commit_id":"0245bbb58191d1297a813715a1bea9abd9d69b9a"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"13db7bb0fa62cf405a3b3f0add8ab68fd178658e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    The Ansible search paths, when running Kayobe internal playbooks, have been"},{"line_number":5,"context_line":"    modified so that collections, roles and plugins internal to the Kayobe"},{"line_number":6,"context_line":"    install have precedence over those installed in Kayobe config.  This"},{"line_number":7,"context_line":"    improves the usability as it now possible to install a newer version of a"},{"line_number":8,"context_line":"    extension without affecting internal kayobe playbooks."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2522b2ad_c7682deb","line":7,"in_reply_to":"bb146618_077cf2f5","updated":"2024-06-05 12:50:50.000000000","message":"Acknowledged","commit_id":"0245bbb58191d1297a813715a1bea9abd9d69b9a"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"628dcaa246af65fdb8664e62dac6becfcea7b3d4","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    The Ansible search paths, when running Kayobe internal playbooks, have been"},{"line_number":5,"context_line":"    modified so that collections, roles and plugins internal to the Kayobe"},{"line_number":6,"context_line":"    install have precedence over those installed in Kayobe config.  This"},{"line_number":7,"context_line":"    improves the usability as it now possible to install a newer version of a"},{"line_number":8,"context_line":"    extension without affecting internal kayobe playbooks."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bb146618_077cf2f5","line":7,"in_reply_to":"d0458250_089fdb54","updated":"2024-05-01 10:39:19.000000000","message":"Done, thanks.","commit_id":"0245bbb58191d1297a813715a1bea9abd9d69b9a"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"cfa13fe1379869a3d84b9cecb1f107648138fd0b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The Ansible search paths, when running Kayobe internal playbooks, have been"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"68705aee_22eb89b3","line":1,"updated":"2024-11-12 16:21:55.000000000","message":"Some typos which I will fix directly.","commit_id":"01632fb577080105d0c0f0d2be58bc166a90b33a"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e7adf14ac156207980892a18eac1fcc64e4f96b5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The Ansible search paths, when running Kayobe internal playbooks, have been"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"abc0cba4_a7e8eab6","line":1,"in_reply_to":"68705aee_22eb89b3","updated":"2024-11-12 16:26:44.000000000","message":"Done","commit_id":"01632fb577080105d0c0f0d2be58bc166a90b33a"}]}
