)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"6fe9557d4b4f9af540b47b36606b38b0ede1791c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8d995ba9_91135e68","updated":"2024-05-28 07:10:58.000000000","message":"recheck (kayobe-seed-images-rocky9)","commit_id":"afa42c45636068c2f6c30310c176e5c5116024e1"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"73ec16dfd0651002c9492342df80a8f71c2fc60a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"91a64d19_3a869738","updated":"2024-05-28 13:03:30.000000000","message":"recheck (kayobe-seed-images-rocky9)","commit_id":"afa42c45636068c2f6c30310c176e5c5116024e1"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"188ebe0eb2357cd0722d9d64c8df2c739bffd5b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"af432c42_1413bed6","in_reply_to":"8d995ba9_91135e68","updated":"2024-05-28 07:39:10.000000000","message":"Please don\u0027t recheck needlessly, this is a Kolla issue: https://review.opendev.org/c/openstack/kolla/+/920279","commit_id":"afa42c45636068c2f6c30310c176e5c5116024e1"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"9af01fcacc52fc0af02e4b0a345f4a5230d22458","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"158d39c7_ae01e7d3","updated":"2024-06-04 07:27:40.000000000","message":"recheck (kayobe-tox-molecule)","commit_id":"bb243d1036055a2c241d1239eff07b57312ac43b"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"f8d7023b1163f47ae33e2057b8e7b28543d01edf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6a4cb431_357f2f05","updated":"2024-06-05 08:32:16.000000000","message":"Very nice - good job :)","commit_id":"7837c9b7f8d3de78cebdfc37bcf38775b7f8c292"}],"ansible/overcloud-deprovision.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"aaad9450c4bee2235f0579328cb83e4f7a50f58f","unresolved":true,"context_lines":[{"line_number":54,"context_line":"        export OS_BAREMETAL_API_VERSION\u003d1.34 \u0026\u0026"},{"line_number":55,"context_line":"        export BIFROST_INVENTORY_SOURCE\u003dironic \u0026\u0026"},{"line_number":56,"context_line":"        export BIFROST_NODE_NAMES\u003d\"{{ inventory_hostname }}\" \u0026\u0026"},{"line_number":57,"context_line":"        openstack --os-cloud bifrost baremetal node show {{ inventory_hostname }} -f value --fields extra\u0027"},{"line_number":58,"context_line":"      register: pxe_result"},{"line_number":59,"context_line":"      delegate_to: \"{{ seed_host }}\""},{"line_number":60,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bbc404e0_eb68fac3","line":57,"range":{"start_line":57,"start_character":18,"end_line":57,"end_character":36},"updated":"2024-05-28 18:47:44.000000000","message":"export OS_CLOUD\u003dbifrost is probably enough?","commit_id":"d719e7068001cbf7cf1d52ca787c5e8c4674031b"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"a8ff2d280a2f5ee283b4ae0097d8af68aa3b1c11","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        export OS_BAREMETAL_API_VERSION\u003d1.34 \u0026\u0026"},{"line_number":55,"context_line":"        export BIFROST_INVENTORY_SOURCE\u003dironic \u0026\u0026"},{"line_number":56,"context_line":"        export BIFROST_NODE_NAMES\u003d\"{{ inventory_hostname }}\" \u0026\u0026"},{"line_number":57,"context_line":"        openstack --os-cloud bifrost baremetal node show {{ inventory_hostname }} -f value --fields extra\u0027"},{"line_number":58,"context_line":"      register: pxe_result"},{"line_number":59,"context_line":"      delegate_to: \"{{ seed_host }}\""},{"line_number":60,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1bec0cd1_b969d641","line":57,"range":{"start_line":57,"start_character":18,"end_line":57,"end_character":36},"in_reply_to":"bbc404e0_eb68fac3","updated":"2024-05-29 09:15:54.000000000","message":"Done","commit_id":"d719e7068001cbf7cf1d52ca787c5e8c4674031b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"aaad9450c4bee2235f0579328cb83e4f7a50f58f","unresolved":true,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    - name: Delete host_vars file"},{"line_number":181,"context_line":"      become: yes"},{"line_number":182,"context_line":"      command: \u003e"},{"line_number":183,"context_line":"        rm -f /etc/kolla/bifrost/inventory/host_vars/{{ inventory_hostname }}"},{"line_number":184,"context_line":"      delegate_to: \"{{ seed_host }}\""},{"line_number":185,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1efd737a_4271b821","line":182,"updated":"2024-05-28 18:47:44.000000000","message":"Any reason for not using file: with state: absent?","commit_id":"d719e7068001cbf7cf1d52ca787c5e8c4674031b"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"a8ff2d280a2f5ee283b4ae0097d8af68aa3b1c11","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    - name: Delete host_vars file"},{"line_number":181,"context_line":"      become: yes"},{"line_number":182,"context_line":"      command: \u003e"},{"line_number":183,"context_line":"        rm -f /etc/kolla/bifrost/inventory/host_vars/{{ inventory_hostname }}"},{"line_number":184,"context_line":"      delegate_to: \"{{ seed_host }}\""},{"line_number":185,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"98d9c44e_eb25caf7","line":182,"in_reply_to":"1efd737a_4271b821","updated":"2024-05-29 09:15:54.000000000","message":"It was in the beginning, but then concept changed couple of times, it\u0027s corrected now.","commit_id":"d719e7068001cbf7cf1d52ca787c5e8c4674031b"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"306408140a24718c73ec8f08f3caf015713c60ec","unresolved":true,"context_lines":[{"line_number":46,"context_line":"          Deprovision has not been confirmed. You must either type \u0027yes\u0027 when"},{"line_number":47,"context_line":"          prompted, or set ``confirm_deprovision\u003dyes``."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    - name: Check PXE MAC address"},{"line_number":50,"context_line":"      command: \u003e"},{"line_number":51,"context_line":"        docker exec bifrost_deploy"},{"line_number":52,"context_line":"        bash -c \u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a24ee58b_b1225167","line":49,"updated":"2024-05-30 09:01:12.000000000","message":"Seems like a good change.\n\nOne thing to note is that this property relies on this introspection rule:\n\nhttps://github.com/openstack/kayobe/blob/master/ansible/inventory/group_vars/all/inspector#L197\n\nA few cases to consider:\n\n- Someone has directly registered a node and not run inspection\n- Someone has removed this introspection rule\n\nI think currently those two cases would case this playbook to fail. I guess you could skip removing it if the property is not found. Would checking the baremetal ports for the pxe property be more reliable?","commit_id":"8c621c25e8b2b2f9f69c65ba743da6f87aad9428"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"bb03f62423312068d1945a5a5379964f302affc2","unresolved":false,"context_lines":[{"line_number":46,"context_line":"          Deprovision has not been confirmed. You must either type \u0027yes\u0027 when"},{"line_number":47,"context_line":"          prompted, or set ``confirm_deprovision\u003dyes``."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    - name: Check PXE MAC address"},{"line_number":50,"context_line":"      command: \u003e"},{"line_number":51,"context_line":"        docker exec bifrost_deploy"},{"line_number":52,"context_line":"        bash -c \u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8ee612df_82adba80","line":49,"in_reply_to":"510d2409_ce3d203f","updated":"2024-06-03 17:42:20.000000000","message":"Also need to account for multiple baremetal ports","commit_id":"8c621c25e8b2b2f9f69c65ba743da6f87aad9428"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"378b543c4a1b7e34ac9d47bfff2342e0c3d8c6b7","unresolved":false,"context_lines":[{"line_number":46,"context_line":"          Deprovision has not been confirmed. You must either type \u0027yes\u0027 when"},{"line_number":47,"context_line":"          prompted, or set ``confirm_deprovision\u003dyes``."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    - name: Check PXE MAC address"},{"line_number":50,"context_line":"      command: \u003e"},{"line_number":51,"context_line":"        docker exec bifrost_deploy"},{"line_number":52,"context_line":"        bash -c \u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ef3387b9_4c694b56","line":49,"in_reply_to":"8ee612df_82adba80","updated":"2024-06-04 18:15:41.000000000","message":"Done.","commit_id":"8c621c25e8b2b2f9f69c65ba743da6f87aad9428"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"eb417ed723f47b766f3a5b4945747fb9699df2fe","unresolved":false,"context_lines":[{"line_number":46,"context_line":"          Deprovision has not been confirmed. You must either type \u0027yes\u0027 when"},{"line_number":47,"context_line":"          prompted, or set ``confirm_deprovision\u003dyes``."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    - name: Check PXE MAC address"},{"line_number":50,"context_line":"      command: \u003e"},{"line_number":51,"context_line":"        docker exec bifrost_deploy"},{"line_number":52,"context_line":"        bash -c \u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"510d2409_ce3d203f","line":49,"in_reply_to":"a24ee58b_b1225167","updated":"2024-06-03 08:59:49.000000000","message":"Fair point, I\u0027ve changed the logic to work around that.","commit_id":"8c621c25e8b2b2f9f69c65ba743da6f87aad9428"}]}