)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e03d0b20640613613179e4a8837f88e48a704966","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"seed-vm/infra-vms: Add support for EFI and q35"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bump stackhpc.libvirt-vm to v1.16.0"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I88f20112ab4740fe114a6484f88f4fbfb66863e5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"fcfa61fd_792a708c","line":9,"updated":"2024-08-22 13:05:52.000000000","message":"v1.16.1","commit_id":"28b604ff2cac16d2bbb2eac2593fe299c289c291"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"ae9b38d8991c1934874675b4da29077afcb380e1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"seed-vm/infra-vms: Add support for EFI and q35"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bump stackhpc.libvirt-vm to v1.16.0"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I88f20112ab4740fe114a6484f88f4fbfb66863e5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"f9d0e803_d08dc350","line":9,"in_reply_to":"fcfa61fd_792a708c","updated":"2024-08-22 15:50:38.000000000","message":"Done","commit_id":"28b604ff2cac16d2bbb2eac2593fe299c289c291"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"f5d53b68670f9b51a1c008fe63bf57cc121a13af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2f5eb087_18fe2f64","updated":"2024-06-19 10:36:35.000000000","message":"Nice feature. Worth adding a uefi variant of the CI job: kayobe-infra-vm-rocky9? Also needs a release note.","commit_id":"d38efac002579be331f188e96b5d7bf5f1208771"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a5c1982aafde45b03178de552ae4820cfc6de96e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"befa81dc_ecdef93b","updated":"2024-06-19 11:17:39.000000000","message":"seems Ubuntu is missing ovmf package - let me draft a patch for libvirt-vm role to ensure it\u0027s installed...","commit_id":"a58cb177c4ed3fd9924a50b170b5dd989cb2d01a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d9f36d87c37d42f26877d649d02bfd5af7219971","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"58ba6998_34810de1","in_reply_to":"befa81dc_ecdef93b","updated":"2024-06-20 11:31:44.000000000","message":"Done","commit_id":"a58cb177c4ed3fd9924a50b170b5dd989cb2d01a"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"0ef2148a1455023e3248131af76066469c1a8c94","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":23,"id":"07493779_2daf9399","updated":"2024-07-09 20:27:58.000000000","message":"Given the Rocky Linux 9.4 GenericCloud image is not bootable without this, should we change the default to efi (potentially in a separate commit)?","commit_id":"28b604ff2cac16d2bbb2eac2593fe299c289c291"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"c2a76145e095ac50664933bdb8b3e29c214b3837","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"e5865e21_c0e502e3","updated":"2024-07-09 18:18:00.000000000","message":"Tested patch and works for me when setting `seed_vm_boot_firmware: efi` with RL9.4 images","commit_id":"28b604ff2cac16d2bbb2eac2593fe299c289c291"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cbb5ae49e0e555f3462503144d99dbe6789df4ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"a571f179_4f9e3854","updated":"2024-07-09 06:46:38.000000000","message":"recheck - upgrade jobs galaxy fail","commit_id":"28b604ff2cac16d2bbb2eac2593fe299c289c291"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"7e2d9b36f20c5fac2cf081f5064c6e9af97a693e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"84ae10fb_fa2d315a","in_reply_to":"07493779_2daf9399","updated":"2024-08-23 15:09:29.000000000","message":"Done in I7d71689ef9b5a8a092fe78da4ee3d2a645a1316e.","commit_id":"28b604ff2cac16d2bbb2eac2593fe299c289c291"}],"ansible/roles/infra-vms/tasks/destroy.yml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"66ce48c0c424779ffe7c057dcc2dcdc5492f451e","unresolved":true,"context_lines":[{"line_number":9,"context_line":"      pool: \"{{ hostvars[vm_hostvars.infra_vm_hypervisor].infra_vm_pool }}\""},{"line_number":10,"context_line":"    libvirt_vms:"},{"line_number":11,"context_line":"      - name: \"{{ vm_name }}\""},{"line_number":12,"context_line":"        boot_firmware: \"{{ vm_hostvars.infra_vm_boot_firmware | default(\u0027bios\u0027) }}\""},{"line_number":13,"context_line":"        memory_mb: \"{{ vm_hostvars.infra_vm_memory_mb }}\""},{"line_number":14,"context_line":"        vcpus: \"{{ vm_hostvars.infra_vm_vcpus }}\""},{"line_number":15,"context_line":"        volumes: \"{{ vm_hostvars.infra_vm_volumes + [infra_vm_configdrive_volume] }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"a443b222_c2bf0787","line":12,"updated":"2024-06-20 08:24:52.000000000","message":"I noticed machine is missing a key in this dict. I imagine it doesn\u0027t make a difference? You\u0027d think most of those parameters would be optional for destroy.","commit_id":"2931f664ed06d9bf7824e65d310990da64c5466d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"418c2c500131204dffb5095dfd4e009a1b5e897c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      pool: \"{{ hostvars[vm_hostvars.infra_vm_hypervisor].infra_vm_pool }}\""},{"line_number":10,"context_line":"    libvirt_vms:"},{"line_number":11,"context_line":"      - name: \"{{ vm_name }}\""},{"line_number":12,"context_line":"        boot_firmware: \"{{ vm_hostvars.infra_vm_boot_firmware | default(\u0027bios\u0027) }}\""},{"line_number":13,"context_line":"        memory_mb: \"{{ vm_hostvars.infra_vm_memory_mb }}\""},{"line_number":14,"context_line":"        vcpus: \"{{ vm_hostvars.infra_vm_vcpus }}\""},{"line_number":15,"context_line":"        volumes: \"{{ vm_hostvars.infra_vm_volumes + [infra_vm_configdrive_volume] }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"c75a0f30_294567c8","line":12,"in_reply_to":"6f7f6f18_94de0141","updated":"2024-07-09 07:04:26.000000000","message":"Done","commit_id":"2931f664ed06d9bf7824e65d310990da64c5466d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d9f36d87c37d42f26877d649d02bfd5af7219971","unresolved":true,"context_lines":[{"line_number":9,"context_line":"      pool: \"{{ hostvars[vm_hostvars.infra_vm_hypervisor].infra_vm_pool }}\""},{"line_number":10,"context_line":"    libvirt_vms:"},{"line_number":11,"context_line":"      - name: \"{{ vm_name }}\""},{"line_number":12,"context_line":"        boot_firmware: \"{{ vm_hostvars.infra_vm_boot_firmware | default(\u0027bios\u0027) }}\""},{"line_number":13,"context_line":"        memory_mb: \"{{ vm_hostvars.infra_vm_memory_mb }}\""},{"line_number":14,"context_line":"        vcpus: \"{{ vm_hostvars.infra_vm_vcpus }}\""},{"line_number":15,"context_line":"        volumes: \"{{ vm_hostvars.infra_vm_volumes + [infra_vm_configdrive_volume] }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"6f7f6f18_94de0141","line":12,"in_reply_to":"a443b222_c2bf0787","updated":"2024-06-20 11:31:44.000000000","message":"boot_firmware needs to be there, because we need to do virsh undefine --nvram \u003cvm_name\u003e - I can add in machine, but it\u0027s currently not used by libvirt-vm role","commit_id":"2931f664ed06d9bf7824e65d310990da64c5466d"}],"etc/kayobe/infra-vms.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"163771237012d673364bfb646b756d926aaac61f","unresolved":true,"context_lines":[{"line_number":61,"context_line":"# Boot firmware - \u0027efi\u0027 or \u0027bios\u0027 - with latter being the default"},{"line_number":62,"context_line":"#infra_vm_boot_firmware:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# Machine type"},{"line_number":65,"context_line":"#infra_vm_machine:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"###############################################################################"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"95ae8b9a_e4e9709c","line":64,"updated":"2024-07-09 19:23:55.000000000","message":"Should this go in ansible/inventory/group_vars/all/infra-vms with an explicit default, rather than rely on the role\u0027s defaults?","commit_id":"28b604ff2cac16d2bbb2eac2593fe299c289c291"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"ae9b38d8991c1934874675b4da29077afcb380e1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"# Boot firmware - \u0027efi\u0027 or \u0027bios\u0027 - with latter being the default"},{"line_number":62,"context_line":"#infra_vm_boot_firmware:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# Machine type"},{"line_number":65,"context_line":"#infra_vm_machine:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"###############################################################################"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"8b604ca3_88dc6243","line":64,"in_reply_to":"95ae8b9a_e4e9709c","updated":"2024-08-22 15:50:38.000000000","message":"Done","commit_id":"28b604ff2cac16d2bbb2eac2593fe299c289c291"}],"etc/kayobe/seed-vm.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"163771237012d673364bfb646b756d926aaac61f","unresolved":true,"context_lines":[{"line_number":61,"context_line":"#"},{"line_number":62,"context_line":"#seed_vm_interfaces:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# Boot firmware - \u0027efi\u0027 or \u0027bios\u0027 - with latter being the default"},{"line_number":65,"context_line":"#seed_vm_boot_firmware:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# Machine type"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"ec6f3212_9d20b73e","line":64,"updated":"2024-07-09 19:23:55.000000000","message":"Should this go in ansible/inventory/group_vars/all/seed-vm too with an explicit default, rather than rely on the role\u0027s defaults?","commit_id":"28b604ff2cac16d2bbb2eac2593fe299c289c291"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"ae9b38d8991c1934874675b4da29077afcb380e1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"#"},{"line_number":62,"context_line":"#seed_vm_interfaces:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# Boot firmware - \u0027efi\u0027 or \u0027bios\u0027 - with latter being the default"},{"line_number":65,"context_line":"#seed_vm_boot_firmware:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# Machine type"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"0fd0e4b2_798659e6","line":64,"in_reply_to":"ec6f3212_9d20b73e","updated":"2024-08-22 15:50:38.000000000","message":"Done","commit_id":"28b604ff2cac16d2bbb2eac2593fe299c289c291"}],"playbooks/kayobe-seed-vm-base/overrides.yml.j2":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"163771237012d673364bfb646b756d926aaac61f","unresolved":true,"context_lines":[{"line_number":34,"context_line":"seed_vm_root_image: /opt/cache/files/cirros-0.5.3-x86_64-disk.img"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% if seed_vm_boot_firmware is defined %}"},{"line_number":37,"context_line":"seed_vm_boot_firmware: efi"},{"line_number":38,"context_line":"{% endif %}"},{"line_number":39,"context_line":"{% if seed_vm_machine is defined %}"},{"line_number":40,"context_line":"seed_vm_machine: q35"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"8abc84a9_12496889","line":37,"updated":"2024-07-09 19:23:55.000000000","message":"Why not use \"{{ seed_vm_boot_firmware }}\" instead of hardcoding? It will make it easier to test bios when we make efi the default.","commit_id":"28b604ff2cac16d2bbb2eac2593fe299c289c291"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"ae9b38d8991c1934874675b4da29077afcb380e1","unresolved":false,"context_lines":[{"line_number":34,"context_line":"seed_vm_root_image: /opt/cache/files/cirros-0.5.3-x86_64-disk.img"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% if seed_vm_boot_firmware is defined %}"},{"line_number":37,"context_line":"seed_vm_boot_firmware: efi"},{"line_number":38,"context_line":"{% endif %}"},{"line_number":39,"context_line":"{% if seed_vm_machine is defined %}"},{"line_number":40,"context_line":"seed_vm_machine: q35"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"e2722fbb_9843cd8e","line":37,"in_reply_to":"8abc84a9_12496889","updated":"2024-08-22 15:50:38.000000000","message":"Done","commit_id":"28b604ff2cac16d2bbb2eac2593fe299c289c291"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"163771237012d673364bfb646b756d926aaac61f","unresolved":true,"context_lines":[{"line_number":37,"context_line":"seed_vm_boot_firmware: efi"},{"line_number":38,"context_line":"{% endif %}"},{"line_number":39,"context_line":"{% if seed_vm_machine is defined %}"},{"line_number":40,"context_line":"seed_vm_machine: q35"},{"line_number":41,"context_line":"{% endif %}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Cirros doesn\u0027t load cdom drivers by default."}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"74ba4f7c_c20b362a","line":40,"updated":"2024-07-09 19:23:55.000000000","message":"Same here","commit_id":"28b604ff2cac16d2bbb2eac2593fe299c289c291"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"ae9b38d8991c1934874675b4da29077afcb380e1","unresolved":false,"context_lines":[{"line_number":37,"context_line":"seed_vm_boot_firmware: efi"},{"line_number":38,"context_line":"{% endif %}"},{"line_number":39,"context_line":"{% if seed_vm_machine is defined %}"},{"line_number":40,"context_line":"seed_vm_machine: q35"},{"line_number":41,"context_line":"{% endif %}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Cirros doesn\u0027t load cdom drivers by default."}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"71dbd646_7c2711c7","line":40,"in_reply_to":"74ba4f7c_c20b362a","updated":"2024-08-22 15:50:38.000000000","message":"Done","commit_id":"28b604ff2cac16d2bbb2eac2593fe299c289c291"}],"releasenotes/notes/seed-infra-vm-efi-q35-8179a832c10df650.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"163771237012d673364bfb646b756d926aaac61f","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for specifying ``boot_firmware`` and ``machine``"},{"line_number":5,"context_line":"    variables to seed and infra vms."},{"line_number":6,"context_line":"    Bumps stackhpc.libvirt-vm Ansible role to ``v1.16.1``."}],"source_content_type":"text/x-yaml","patch_set":23,"id":"49f5141b_8b817b65","line":5,"updated":"2024-07-09 19:23:55.000000000","message":"Nit: VMs","commit_id":"28b604ff2cac16d2bbb2eac2593fe299c289c291"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"ae9b38d8991c1934874675b4da29077afcb380e1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for specifying ``boot_firmware`` and ``machine``"},{"line_number":5,"context_line":"    variables to seed and infra vms."},{"line_number":6,"context_line":"    Bumps stackhpc.libvirt-vm Ansible role to ``v1.16.1``."}],"source_content_type":"text/x-yaml","patch_set":23,"id":"83b1adcb_2e3d5caf","line":5,"in_reply_to":"49f5141b_8b817b65","updated":"2024-08-22 15:50:38.000000000","message":"Done","commit_id":"28b604ff2cac16d2bbb2eac2593fe299c289c291"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"163771237012d673364bfb646b756d926aaac61f","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for specifying ``boot_firmware`` and ``machine``"},{"line_number":5,"context_line":"    variables to seed and infra vms."},{"line_number":6,"context_line":"    Bumps stackhpc.libvirt-vm Ansible role to ``v1.16.1``."}],"source_content_type":"text/x-yaml","patch_set":23,"id":"19c9e350_93c239ab","line":6,"updated":"2024-07-09 19:23:55.000000000","message":"Do you want to make this a separate entry instead?","commit_id":"28b604ff2cac16d2bbb2eac2593fe299c289c291"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"ae9b38d8991c1934874675b4da29077afcb380e1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for specifying ``boot_firmware`` and ``machine``"},{"line_number":5,"context_line":"    variables to seed and infra vms."},{"line_number":6,"context_line":"    Bumps stackhpc.libvirt-vm Ansible role to ``v1.16.1``."}],"source_content_type":"text/x-yaml","patch_set":23,"id":"9a421bd9_4ad114fe","line":6,"in_reply_to":"19c9e350_93c239ab","updated":"2024-08-22 15:50:38.000000000","message":"Done","commit_id":"28b604ff2cac16d2bbb2eac2593fe299c289c291"}]}