)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"72a0bef3f5c0ca232372181913b0468dde466696","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4ee47354_a54ecf50","updated":"2024-06-21 09:15:18.000000000","message":"please also add this var to doc/source/configuration/reference/bifrost.rst","commit_id":"a5d4a4ce8fe9890451ab0894d46d63fddfdcffd4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"417ac742bf14ba8f1a52acb3a915e30240da4700","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"62d7bd87_5e30af19","in_reply_to":"4c9b3c11_5c8479af","updated":"2024-07-04 13:58:00.000000000","message":"Done","commit_id":"a5d4a4ce8fe9890451ab0894d46d63fddfdcffd4"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"51315524e3d5754a0f0746e2a53da46156f6c588","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e003faf5_6993ff76","in_reply_to":"4ee47354_a54ecf50","updated":"2024-07-04 11:20:25.000000000","message":"Patch looks good to me. Possibly you missed this comment as it was marked as resolved.","commit_id":"a5d4a4ce8fe9890451ab0894d46d63fddfdcffd4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8c63450015d69cf7ee6e6f2dc61221dca4dab6e3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4c9b3c11_5c8479af","in_reply_to":"e003faf5_6993ff76","updated":"2024-07-04 13:14:01.000000000","message":"Actually just realised it won\u0027t work for bridges and bonds - will write some filter to get physical NIC ;-)","commit_id":"a5d4a4ce8fe9890451ab0894d46d63fddfdcffd4"}],"ansible/kolla-bifrost-hostvars.yml":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"72a0bef3f5c0ca232372181913b0468dde466696","unresolved":true,"context_lines":[{"line_number":75,"context_line":"              vars:"},{"line_number":76,"context_line":"                introspection_data: \"{{ save_result.stdout_lines[1:] | join(\u0027\\n\u0027) | from_json }}\""},{"line_number":77,"context_line":"              set_fact:"},{"line_number":78,"context_line":"               ikolla_bifrost_interface_mac: \"{{ introspection_data.all_interfaces[admin_oc_net_name | net_interface].mac }}\""},{"line_number":79,"context_line":"          when: kolla_bifrost_use_introspection_mac | bool"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        - name: Ensure the Bifrost host variable files exist"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dbccf0f9_3dde7869","line":78,"updated":"2024-06-21 09:15:18.000000000","message":"typo here, I think we should follow bifrost naming, so kolla_bifrost_ipv4_interface_mac","commit_id":"a5d4a4ce8fe9890451ab0894d46d63fddfdcffd4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c4fecc401b6a03cdc284f5ae3497c42d1bc91890","unresolved":false,"context_lines":[{"line_number":75,"context_line":"              vars:"},{"line_number":76,"context_line":"                introspection_data: \"{{ save_result.stdout_lines[1:] | join(\u0027\\n\u0027) | from_json }}\""},{"line_number":77,"context_line":"              set_fact:"},{"line_number":78,"context_line":"               ikolla_bifrost_interface_mac: \"{{ introspection_data.all_interfaces[admin_oc_net_name | net_interface].mac }}\""},{"line_number":79,"context_line":"          when: kolla_bifrost_use_introspection_mac | bool"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        - name: Ensure the Bifrost host variable files exist"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a86813f6_08ccc6a9","line":78,"in_reply_to":"dbccf0f9_3dde7869","updated":"2024-07-04 10:14:44.000000000","message":"Done","commit_id":"a5d4a4ce8fe9890451ab0894d46d63fddfdcffd4"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"2227d54514b2cc10453e0c7bb89e999ba225e172","unresolved":true,"context_lines":[{"line_number":20,"context_line":"      addressing_mode: static"},{"line_number":21,"context_line":"      deploy_image_filename: \"{{ kolla_bifrost_deploy_image_filename }}\""},{"line_number":22,"context_line":"      deploy_image_rootfs: \"{{ kolla_bifrost_deploy_image_rootfs | default(omit, true) }}\""},{"line_number":23,"context_line":"      ipv4_interface_mac: \"{% if kolla_bifrost_ipv4_interface_mac is defined %}{{ kolla_bifrost_interface_mac }}{% else %}{% raw %}{{ extra.pxe_interface_mac | default }}{% endraw %}\""},{"line_number":24,"context_line":"      ipv4_address: \"{{ admin_oc_net_name | net_ip }}\""},{"line_number":25,"context_line":"      ipv4_subnet_mask: \"{{ admin_oc_net_name | net_mask }}\""},{"line_number":26,"context_line":"      # If the admin network does not have a gateway defined and seed SNAT is"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"29718440_f330f073","line":23,"updated":"2024-07-04 10:20:26.000000000","message":"Variable inconsistent here:\n\n```suggestion\n      ipv4_interface_mac: \"{% if kolla_bifrost_ipv4_interface_mac is defined %}{{ kolla_bifrost_ipv4_interface_mac }}{% else %}{% raw %}{{ extra.pxe_interface_mac | default }}{% endraw %}\"\n```\nor use the ``kolla_bifrost_use_introspection_mac`` flag","commit_id":"b9e0801e60f97f88be7967bd0e08f6d974449c0d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7c933a91ea9da17c00cb52211556d7d8f6117d63","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      addressing_mode: static"},{"line_number":21,"context_line":"      deploy_image_filename: \"{{ kolla_bifrost_deploy_image_filename }}\""},{"line_number":22,"context_line":"      deploy_image_rootfs: \"{{ kolla_bifrost_deploy_image_rootfs | default(omit, true) }}\""},{"line_number":23,"context_line":"      ipv4_interface_mac: \"{% if kolla_bifrost_ipv4_interface_mac is defined %}{{ kolla_bifrost_interface_mac }}{% else %}{% raw %}{{ extra.pxe_interface_mac | default }}{% endraw %}\""},{"line_number":24,"context_line":"      ipv4_address: \"{{ admin_oc_net_name | net_ip }}\""},{"line_number":25,"context_line":"      ipv4_subnet_mask: \"{{ admin_oc_net_name | net_mask }}\""},{"line_number":26,"context_line":"      # If the admin network does not have a gateway defined and seed SNAT is"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1e25e291_2b16716f","line":23,"in_reply_to":"29718440_f330f073","updated":"2024-07-04 10:25:02.000000000","message":"Done","commit_id":"b9e0801e60f97f88be7967bd0e08f6d974449c0d"}]}