)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dcc31045307861ba303d21c54f75715a9e27d936","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5bac4b10_d928ac4b","updated":"2024-08-19 11:38:28.000000000","message":"Fixed molecule tests.","commit_id":"1179a10add950203bc9a953694297cd8b9b3e76d"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"dcc0bef604b81bedb295093449ab72fad2eec5e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"be21356f_0a0c935b","updated":"2024-06-21 12:27:04.000000000","message":"Isn\u0027t there a more general issue of sharing /opt/kayobe? Could we not change the default value of base_path to somewhere in kayobe-config?","commit_id":"1179a10add950203bc9a953694297cd8b9b3e76d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"12d76e526a241c118258241ed34beac35d662a3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dc4747e9_e0713dc9","updated":"2024-08-16 08:02:40.000000000","message":"recheck\n\nrefresh results","commit_id":"1179a10add950203bc9a953694297cd8b9b3e76d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3df1c41ac60332f6f146f0a0a626d4fdbfdcfd9d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f7674248_a83cd0c6","in_reply_to":"be21356f_0a0c935b","updated":"2024-06-21 12:34:21.000000000","message":"Yes, IFAICT it mostly affects the kayobe virtualenv. I did try that briefly. It ended up pointing ansible_python_interpreter at the new location in kolla globals.yml, which obviously didn\u0027t work for other hosts. Possibly we could fix that using host_vars or something, but I thought I\u0027d focus on this issue for now.","commit_id":"1179a10add950203bc9a953694297cd8b9b3e76d"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d4d8987f8bf915662a4c6136fc4f94fb4430f8c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"351bf770_c43a1320","in_reply_to":"f7674248_a83cd0c6","updated":"2024-06-21 13:57:29.000000000","message":"Fair enough if it wasn\u0027t that simple. I was imagining a control host override of base_path. Ties in with https://review.opendev.org/c/openstack/kayobe/+/922401 or I guess localhost as it stands.","commit_id":"1179a10add950203bc9a953694297cd8b9b3e76d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8b31fffa25098b780ec21ad89ba17efb2be153d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"145d34de_fc7500f8","updated":"2024-08-21 11:35:58.000000000","message":"recheck\n\nCI fixed","commit_id":"8de02b82b4fb9cd4912d31fa3c9359820545b384"}],"ansible/kolla-openstack.yml":[{"author":{"_account_id":35010,"name":"Jack Hodgkiss","display_name":"jackhodgkiss","email":"jack@stackhpc.com","username":"jackhodgkiss"},"change_message_id":"5464d39aae0d610f56afd5da1fc4141d19772cb7","unresolved":true,"context_lines":[{"line_number":116,"context_line":"                kolla_inspector_ipa_ramdisk_checksum_algorithm: \"{{ inspector_ipa_ramdisk_checksum_algorithm }}\""},{"line_number":117,"context_line":"              when: not ipa_build_images | bool"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"            - name: Set facts containing IPA kernel and ramdisk paths"},{"line_number":120,"context_line":"              set_fact:"},{"line_number":121,"context_line":"                kolla_inspector_ipa_kernel_path: \"{{ hostvars[kolla_inspector_ipa_host].image_cache_path }}/{{ ipa_image_name }}/{{ ipa_images_kernel_name }}\""},{"line_number":122,"context_line":"                kolla_inspector_ipa_ramdisk_path: \"{{ hostvars[kolla_inspector_ipa_host].image_cache_path }}/{{ ipa_image_name }}/{{ ipa_images_ramdisk_name }}\""},{"line_number":123,"context_line":"                kolla_inspector_ipa_host: \"{{ groups[\u0027controllers_with_ironic_enabled_True\u0027][0] }}\""},{"line_number":124,"context_line":"              when: ipa_build_images | bool"},{"line_number":125,"context_line":"          when: kolla_enable_ironic | bool"},{"line_number":126,"context_line":"      tags:"},{"line_number":127,"context_line":"        - config"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e73e6014_df4ae015","line":124,"range":{"start_line":119,"start_character":0,"end_line":124,"end_character":43},"updated":"2024-06-20 19:41:47.000000000","message":"It appears we cannot set facts using facts to be set within the same task.\n```suggestion\n            - name: Set fact regarding IPA host\n              set_fact:\n                kolla_inspector_ipa_host: \"{{ groups[\u0027controllers_with_ironic_enabled_True\u0027][0] }}\"\n              when: ipa_build_images | bool\n\n            - name: Set facts containing IPA kernel and ramdisk paths\n              set_fact:\n                kolla_inspector_ipa_kernel_path: \"{{ hostvars[kolla_inspector_ipa_host].image_cache_path }}/{{ ipa_image_name }}/{{ ipa_images_kernel_name }}\"\n                kolla_inspector_ipa_ramdisk_path: \"{{ hostvars[kolla_inspector_ipa_host].image_cache_path }}/{{ ipa_image_name }}/{{ ipa_images_ramdisk_name }}\"\n              when: ipa_build_images | bool\n```","commit_id":"d35b89801f5ca35c7ac0da6534d18ec6d053ca59"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2003e0cd7f4499649cf5613c63e1ab0b3d26cfcc","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                kolla_inspector_ipa_ramdisk_checksum_algorithm: \"{{ inspector_ipa_ramdisk_checksum_algorithm }}\""},{"line_number":117,"context_line":"              when: not ipa_build_images | bool"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"            - name: Set facts containing IPA kernel and ramdisk paths"},{"line_number":120,"context_line":"              set_fact:"},{"line_number":121,"context_line":"                kolla_inspector_ipa_kernel_path: \"{{ hostvars[kolla_inspector_ipa_host].image_cache_path }}/{{ ipa_image_name }}/{{ ipa_images_kernel_name }}\""},{"line_number":122,"context_line":"                kolla_inspector_ipa_ramdisk_path: \"{{ hostvars[kolla_inspector_ipa_host].image_cache_path }}/{{ ipa_image_name }}/{{ ipa_images_ramdisk_name }}\""},{"line_number":123,"context_line":"                kolla_inspector_ipa_host: \"{{ groups[\u0027controllers_with_ironic_enabled_True\u0027][0] }}\""},{"line_number":124,"context_line":"              when: ipa_build_images | bool"},{"line_number":125,"context_line":"          when: kolla_enable_ironic | bool"},{"line_number":126,"context_line":"      tags:"},{"line_number":127,"context_line":"        - config"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6a9ae425_75e0981c","line":124,"range":{"start_line":119,"start_character":0,"end_line":124,"end_character":43},"in_reply_to":"e73e6014_df4ae015","updated":"2024-06-21 09:46:23.000000000","message":"Oops, looks like I didn\u0027t test the final refactor. The latest patchset should work.","commit_id":"d35b89801f5ca35c7ac0da6534d18ec6d053ca59"}],"ansible/roles/image-download/tasks/main.yml":[{"author":{"_account_id":35010,"name":"Jack Hodgkiss","display_name":"jackhodgkiss","email":"jack@stackhpc.com","username":"jackhodgkiss"},"change_message_id":"1ed3b73fb6b0b0ca7b38842966b3ea96d1cbb4e8","unresolved":true,"context_lines":[{"line_number":52,"context_line":"      when:"},{"line_number":53,"context_line":"        - image_download_host is falsy"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    - name: Ensure the remote image is fetched"},{"line_number":56,"context_line":"      fetch:"},{"line_number":57,"context_line":"        src: \"{{ image_download_path }}\""},{"line_number":58,"context_line":"        dest: \"{{ image_download_dest }}\""},{"line_number":59,"context_line":"        mode: 0640"},{"line_number":60,"context_line":"        flat: true"},{"line_number":61,"context_line":"      when:"},{"line_number":62,"context_line":"        - image_download_host is truthy"},{"line_number":63,"context_line":"      delegate_to: \"{{ image_download_host }}\""},{"line_number":64,"context_line":"      vars:"},{"line_number":65,"context_line":"        # NOTE: Without this, the hosts\u0027s ansible_host variable will not be"},{"line_number":66,"context_line":"        # respected when using delegate_to."},{"line_number":67,"context_line":"        ansible_host: \"{{ hostvars[image_download_host].ansible_host | default(image_download_host) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0a38561e_7db08c34","line":67,"range":{"start_line":55,"start_character":0,"end_line":67,"end_character":103},"updated":"2024-06-21 09:06:19.000000000","message":"This task fails as `image_download_host` is set to none at this point. The value `image_download_host` is assigned to `kolla_inspector_ipa_host` but is appears that this value is none as well.\n\n```\n  file: /opt/kayobe/images/ipa/ipa.kernel\n  msg: |-\n    Data could not be sent to remote host \"{{ hostvars[image_download_host].ansible_host | default(image_download_host) }}\". Make sure this host can be reached over ssh: hostname contains invalid characters\n```\n\nCan work around this issue with `kayobe overcloud service deploy -e image_download_host\u003dos-ctrl-01`","commit_id":"d35b89801f5ca35c7ac0da6534d18ec6d053ca59"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2003e0cd7f4499649cf5613c63e1ab0b3d26cfcc","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      when:"},{"line_number":53,"context_line":"        - image_download_host is falsy"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    - name: Ensure the remote image is fetched"},{"line_number":56,"context_line":"      fetch:"},{"line_number":57,"context_line":"        src: \"{{ image_download_path }}\""},{"line_number":58,"context_line":"        dest: \"{{ image_download_dest }}\""},{"line_number":59,"context_line":"        mode: 0640"},{"line_number":60,"context_line":"        flat: true"},{"line_number":61,"context_line":"      when:"},{"line_number":62,"context_line":"        - image_download_host is truthy"},{"line_number":63,"context_line":"      delegate_to: \"{{ image_download_host }}\""},{"line_number":64,"context_line":"      vars:"},{"line_number":65,"context_line":"        # NOTE: Without this, the hosts\u0027s ansible_host variable will not be"},{"line_number":66,"context_line":"        # respected when using delegate_to."},{"line_number":67,"context_line":"        ansible_host: \"{{ hostvars[image_download_host].ansible_host | default(image_download_host) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"853c7a54_6404289c","line":67,"range":{"start_line":55,"start_character":0,"end_line":67,"end_character":103},"in_reply_to":"0a38561e_7db08c34","updated":"2024-06-21 09:46:23.000000000","message":"Done","commit_id":"d35b89801f5ca35c7ac0da6534d18ec6d053ca59"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"d45697a0cb6a5d84e517046d7b0155766ab08a54","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        flat: true"},{"line_number":61,"context_line":"      when:"},{"line_number":62,"context_line":"        - image_download_host is truthy"},{"line_number":63,"context_line":"      delegate_to: \"{{ image_download_host | default(\u0027localhost\u0027, true) }}\""},{"line_number":64,"context_line":"      vars:"},{"line_number":65,"context_line":"        # NOTE: Without this, the hosts\u0027s ansible_host variable will not be"},{"line_number":66,"context_line":"        # respected when using delegate_to."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"32ec5267_b33e8ccb","line":63,"range":{"start_line":63,"start_character":23,"end_line":63,"end_character":71},"updated":"2024-08-30 16:44:12.000000000","message":"a bit confused.\nin the\nhttps://review.opendev.org/c/openstack/kayobe/+/922371/4/ansible/roles/image-download/defaults/main.yml#23\nthere is the default - {{ inventory_hostname }}","commit_id":"8de02b82b4fb9cd4912d31fa3c9359820545b384"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2c07723508710b87815ba006c0a1b5ed69cf1a64","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        flat: true"},{"line_number":61,"context_line":"      when:"},{"line_number":62,"context_line":"        - image_download_host is truthy"},{"line_number":63,"context_line":"      delegate_to: \"{{ image_download_host | default(\u0027localhost\u0027, true) }}\""},{"line_number":64,"context_line":"      vars:"},{"line_number":65,"context_line":"        # NOTE: Without this, the hosts\u0027s ansible_host variable will not be"},{"line_number":66,"context_line":"        # respected when using delegate_to."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a73c1b29_582300e6","line":63,"range":{"start_line":63,"start_character":23,"end_line":63,"end_character":71},"in_reply_to":"32ec5267_b33e8ccb","updated":"2024-09-10 09:36:44.000000000","message":"I needed this to make the kayobe-tox-ansible job pass. It might be because the role defaults aren\u0027t defined for the delegate host.","commit_id":"8de02b82b4fb9cd4912d31fa3c9359820545b384"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"64d2d6572a8ed1ca1ab5773ba231940c8773318b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        flat: true"},{"line_number":61,"context_line":"      when:"},{"line_number":62,"context_line":"        - image_download_host is truthy"},{"line_number":63,"context_line":"      delegate_to: \"{{ image_download_host | default(\u0027localhost\u0027, true) }}\""},{"line_number":64,"context_line":"      vars:"},{"line_number":65,"context_line":"        # NOTE: Without this, the hosts\u0027s ansible_host variable will not be"},{"line_number":66,"context_line":"        # respected when using delegate_to."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"85384692_d4c479fb","line":63,"range":{"start_line":63,"start_character":23,"end_line":63,"end_character":71},"in_reply_to":"a73c1b29_582300e6","updated":"2024-09-10 09:47:12.000000000","message":"Acknowledged","commit_id":"8de02b82b4fb9cd4912d31fa3c9359820545b384"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"d45697a0cb6a5d84e517046d7b0155766ab08a54","unresolved":true,"context_lines":[{"line_number":64,"context_line":"      vars:"},{"line_number":65,"context_line":"        # NOTE: Without this, the hosts\u0027s ansible_host variable will not be"},{"line_number":66,"context_line":"        # respected when using delegate_to."},{"line_number":67,"context_line":"        ansible_host: \"{{ hostvars[image_download_host].ansible_host | default(image_download_host) }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"94b41cdb_09559e70","line":67,"range":{"start_line":67,"start_character":26,"end_line":67,"end_character":98},"updated":"2024-08-30 16:44:12.000000000","message":"ditto","commit_id":"8de02b82b4fb9cd4912d31fa3c9359820545b384"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"55056413646269b28992215d4cc995b783fc5c46","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      vars:"},{"line_number":65,"context_line":"        # NOTE: Without this, the hosts\u0027s ansible_host variable will not be"},{"line_number":66,"context_line":"        # respected when using delegate_to."},{"line_number":67,"context_line":"        ansible_host: \"{{ hostvars[image_download_host].ansible_host | default(image_download_host) }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a02f104c_105453d4","line":67,"range":{"start_line":67,"start_character":26,"end_line":67,"end_character":98},"in_reply_to":"94b41cdb_09559e70","updated":"2024-09-10 09:47:21.000000000","message":"Acknowledged","commit_id":"8de02b82b4fb9cd4912d31fa3c9359820545b384"}]}