)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"dd972305edc926c37769442459ec1e26c84f8516","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Will Szumski \u003cwill@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-09-13 17:15:05 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add internal vip address to no_proxy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7a9aa9abf611cdaa47cc91f40a6753f23a7f187e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"752307d5_fa6ea46b","line":7,"updated":"2024-10-31 09:47:16.000000000","message":"Nit: VIP","commit_id":"4cf5814c1dab5ccc380586fccf928ea4e78aba27"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"0c13e17501c04b5961b7ab82b4db3635aee9daf3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Will Szumski \u003cwill@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-09-13 17:15:05 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add internal vip address to no_proxy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7a9aa9abf611cdaa47cc91f40a6753f23a7f187e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ea8707d8_86d351aa","line":7,"in_reply_to":"752307d5_fa6ea46b","updated":"2024-11-07 11:46:16.000000000","message":"Done","commit_id":"4cf5814c1dab5ccc380586fccf928ea4e78aba27"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"9422953ba7ab0d932ed65b2056c114258d5330a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4967d683_40d105e0","updated":"2024-06-27 14:19:38.000000000","message":"Could this include a release note, so people know they can drop this from any custom config?","commit_id":"ef8a50fe09140fa61caa6a211838241350217d7d"},{"author":{"_account_id":36781,"name":"Massimiliano Favaro-Bedford","display_name":"Max","email":"max@stackhpc.com","username":"MaxBed4d"},"change_message_id":"ffa4086566814fc680da5a83bdf886b211823187","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3e28dc91_e0f4965d","updated":"2024-08-12 10:17:37.000000000","message":"Seems like a sensible change, just a small change to the bit of text beforehand, otherwise, looks good to me.\n\nCould also be backported because this, in my opinion, could be considered to increase the overall level of security of a deployment.","commit_id":"ef8a50fe09140fa61caa6a211838241350217d7d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"a63d95b31faaa34c59aeff19eae55f23416d8655","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f2a422fb_503a5b3a","updated":"2024-11-08 10:33:12.000000000","message":"recheck: job had POST_FAILURE","commit_id":"bab85b3754c70d79c62f56a6c6c25ec960047437"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"64e1aa93a88111b11b08a8ab6f42b6eb820cc09a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a538a80f_f592011d","updated":"2024-11-07 14:43:01.000000000","message":"recheck: rocky job failed with: `\"msg\": \"failed to fetch key at https://download.docker.com/linux/centos/gpg , error was: Request failed: \u003curlopen error [Errno 104] Connection reset by peer\u003e\"`","commit_id":"bab85b3754c70d79c62f56a6c6c25ec960047437"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"dc8a745e3819006befd18f42d6f47838875ae277","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f7974a4d_24825441","updated":"2024-11-08 18:12:38.000000000","message":"recheck\n\novercloud-test-baremetal failed on ubuntu-noble","commit_id":"6fb47e2193d912f85c977923ba0e06aea9d6c689"}],"ansible/inventory/group_vars/all/proxy":[{"author":{"_account_id":36781,"name":"Massimiliano Favaro-Bedford","display_name":"Max","email":"max@stackhpc.com","username":"MaxBed4d"},"change_message_id":"ffa4086566814fc680da5a83bdf886b211823187","unresolved":true,"context_lines":[{"line_number":10,"context_line":"# default no proxy is used."},{"line_number":11,"context_line":"https_proxy: \"\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# List of domains, hostnames, IP addresses and networks for which no proxy is"},{"line_number":14,"context_line":"# used. Defaults to [\"127.0.0.1\", \"localhost\", \"{{ (\u0027http://\u0027 ~"},{"line_number":15,"context_line":"# docker_registry) | urlsplit(\u0027hostname\u0027) }}\"] if docker_registry is set, or"},{"line_number":16,"context_line":"# [\"127.0.0.1\", \"localhost\"] otherwise. This is configured only if either"},{"line_number":17,"context_line":"# http_proxy or https_proxy is set."},{"line_number":18,"context_line":"no_proxy:"},{"line_number":19,"context_line":"  - \"127.0.0.1\""},{"line_number":20,"context_line":"  - \"localhost\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"0539124e_cd0c5a72","line":17,"range":{"start_line":13,"start_character":0,"end_line":17,"end_character":35},"updated":"2024-08-12 10:17:37.000000000","message":"Nit: Update comment to include the addition of ```kolla_internal_vip_address```.\n\n```suggestion\n# List of domains, hostnames, IP addresses and networks for which no proxy is\n# used. Defaults to [\"127.0.0.1\", \"localhost\", \"{{ (\u0027http://\u0027 ~\n# docker_registry) | urlsplit(\u0027hostname\u0027) }}\",\"{{ kolla_internal_vip_address }}\"] if docker_registry is set, or\n# [\"127.0.0.1\", \"localhost\",\"{{ kolla_internal_vip_address }}\"] otherwise. This is configured only if either\n# http_proxy or https_proxy is set.\n```","commit_id":"ef8a50fe09140fa61caa6a211838241350217d7d"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"ab2387c8ad37e2da074349fee2c3627b38b8a0ec","unresolved":true,"context_lines":[{"line_number":10,"context_line":"# default no proxy is used."},{"line_number":11,"context_line":"https_proxy: \"\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# List of domains, hostnames, IP addresses and networks for which no proxy is"},{"line_number":14,"context_line":"# used. Defaults to [\"127.0.0.1\", \"localhost\", \"{{ (\u0027http://\u0027 ~"},{"line_number":15,"context_line":"# docker_registry) | urlsplit(\u0027hostname\u0027) }}\"] if docker_registry is set, or"},{"line_number":16,"context_line":"# [\"127.0.0.1\", \"localhost\"] otherwise. This is configured only if either"},{"line_number":17,"context_line":"# http_proxy or https_proxy is set."},{"line_number":18,"context_line":"no_proxy:"},{"line_number":19,"context_line":"  - \"127.0.0.1\""},{"line_number":20,"context_line":"  - \"localhost\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"c95dc883_78d57fc0","line":17,"range":{"start_line":13,"start_character":0,"end_line":17,"end_character":35},"in_reply_to":"0539124e_cd0c5a72","updated":"2024-09-13 15:46:24.000000000","message":"Good call. Also needs updating in etc/kayobe.","commit_id":"ef8a50fe09140fa61caa6a211838241350217d7d"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"4f30745dc06e12327d1f3435c60cee00732eb6c4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# default no proxy is used."},{"line_number":11,"context_line":"https_proxy: \"\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# List of domains, hostnames, IP addresses and networks for which no proxy is"},{"line_number":14,"context_line":"# used. Defaults to [\"127.0.0.1\", \"localhost\", \"{{ (\u0027http://\u0027 ~"},{"line_number":15,"context_line":"# docker_registry) | urlsplit(\u0027hostname\u0027) }}\"] if docker_registry is set, or"},{"line_number":16,"context_line":"# [\"127.0.0.1\", \"localhost\"] otherwise. This is configured only if either"},{"line_number":17,"context_line":"# http_proxy or https_proxy is set."},{"line_number":18,"context_line":"no_proxy:"},{"line_number":19,"context_line":"  - \"127.0.0.1\""},{"line_number":20,"context_line":"  - \"localhost\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"b36b9ea2_a18c1a65","line":17,"range":{"start_line":13,"start_character":0,"end_line":17,"end_character":35},"in_reply_to":"c95dc883_78d57fc0","updated":"2024-09-13 16:18:04.000000000","message":"Fix applied.","commit_id":"ef8a50fe09140fa61caa6a211838241350217d7d"}],"releasenotes/notes/adds-internal-vip-to-no-proxy-cbb4db4ea3909185.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"dd972305edc926c37769442459ec1e26c84f8516","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Adds the internal VIP to the NOPROXY/noproxy environment variables."},{"line_number":5,"context_line":"security:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    When running API requests from a kayobe configured host, traffic destined"},{"line_number":8,"context_line":"    for the the internal VIP is sent via the default proxy. This can be a"},{"line_number":9,"context_line":"    security issue if not using TLS as the proxy will be able to intercept the"},{"line_number":10,"context_line":"    traffic. If using an untrusted proxy, with TLS disabled on the internal"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7a768d5b_01d2d4b7","line":7,"updated":"2024-10-31 09:47:16.000000000","message":"host configured with Kayobe","commit_id":"4cf5814c1dab5ccc380586fccf928ea4e78aba27"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"0c13e17501c04b5961b7ab82b4db3635aee9daf3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds the internal VIP to the NOPROXY/noproxy environment variables."},{"line_number":5,"context_line":"security:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    When running API requests from a kayobe configured host, traffic destined"},{"line_number":8,"context_line":"    for the the internal VIP is sent via the default proxy. This can be a"},{"line_number":9,"context_line":"    security issue if not using TLS as the proxy will be able to intercept the"},{"line_number":10,"context_line":"    traffic. If using an untrusted proxy, with TLS disabled on the internal"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9826b75b_b5704148","line":7,"in_reply_to":"7a768d5b_01d2d4b7","updated":"2024-11-07 11:46:16.000000000","message":"Done","commit_id":"4cf5814c1dab5ccc380586fccf928ea4e78aba27"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"dd972305edc926c37769442459ec1e26c84f8516","unresolved":true,"context_lines":[{"line_number":5,"context_line":"security:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    When running API requests from a kayobe configured host, traffic destined"},{"line_number":8,"context_line":"    for the the internal VIP is sent via the default proxy. This can be a"},{"line_number":9,"context_line":"    security issue if not using TLS as the proxy will be able to intercept the"},{"line_number":10,"context_line":"    traffic. If using an untrusted proxy, with TLS disabled on the internal"},{"line_number":11,"context_line":"    VIP, it is recommended that you run ``kayobe overcloud host configure -t"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f190baad_e2fd8db9","line":8,"updated":"2024-10-31 09:47:16.000000000","message":"a/the the/the/","commit_id":"4cf5814c1dab5ccc380586fccf928ea4e78aba27"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"0c13e17501c04b5961b7ab82b4db3635aee9daf3","unresolved":false,"context_lines":[{"line_number":5,"context_line":"security:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    When running API requests from a kayobe configured host, traffic destined"},{"line_number":8,"context_line":"    for the the internal VIP is sent via the default proxy. This can be a"},{"line_number":9,"context_line":"    security issue if not using TLS as the proxy will be able to intercept the"},{"line_number":10,"context_line":"    traffic. If using an untrusted proxy, with TLS disabled on the internal"},{"line_number":11,"context_line":"    VIP, it is recommended that you run ``kayobe overcloud host configure -t"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"56a87012_1daaf000","line":8,"in_reply_to":"f190baad_e2fd8db9","updated":"2024-11-07 11:46:16.000000000","message":"Done","commit_id":"4cf5814c1dab5ccc380586fccf928ea4e78aba27"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"dd972305edc926c37769442459ec1e26c84f8516","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    security issue if not using TLS as the proxy will be able to intercept the"},{"line_number":10,"context_line":"    traffic. If using an untrusted proxy, with TLS disabled on the internal"},{"line_number":11,"context_line":"    VIP, it is recommended that you run ``kayobe overcloud host configure -t"},{"line_number":12,"context_line":"    proxy``, ``kayobe seed hypervisor host configure -t proxy`` ``kayobe seed"},{"line_number":13,"context_line":"    host configure -t proxy`` and ``kayobe infra vm host configure -t proxy``,"},{"line_number":14,"context_line":"    to add the internal VIP to the no proxy configuration. This is considered"},{"line_number":15,"context_line":"    a minor issue as traffic between containers will not use the proxy by"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"84c563e4_4e9fa5f4","line":12,"updated":"2024-10-31 09:47:16.000000000","message":"Missing comma","commit_id":"4cf5814c1dab5ccc380586fccf928ea4e78aba27"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"0c13e17501c04b5961b7ab82b4db3635aee9daf3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    security issue if not using TLS as the proxy will be able to intercept the"},{"line_number":10,"context_line":"    traffic. If using an untrusted proxy, with TLS disabled on the internal"},{"line_number":11,"context_line":"    VIP, it is recommended that you run ``kayobe overcloud host configure -t"},{"line_number":12,"context_line":"    proxy``, ``kayobe seed hypervisor host configure -t proxy`` ``kayobe seed"},{"line_number":13,"context_line":"    host configure -t proxy`` and ``kayobe infra vm host configure -t proxy``,"},{"line_number":14,"context_line":"    to add the internal VIP to the no proxy configuration. This is considered"},{"line_number":15,"context_line":"    a minor issue as traffic between containers will not use the proxy by"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"574a3ed3_afa86c76","line":12,"in_reply_to":"84c563e4_4e9fa5f4","updated":"2024-11-07 11:46:16.000000000","message":"Done","commit_id":"4cf5814c1dab5ccc380586fccf928ea4e78aba27"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"936f5b256bd1bf3530feb09c80ec691ab67ca119","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Adds the internal VIP to the NOPROXY/noproxy environment variables."},{"line_number":5,"context_line":"security:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    When running API requests from a kayobe configured host, traffic destined"},{"line_number":8,"context_line":"    for the the internal VIP is sent via the default proxy. This can be a"},{"line_number":9,"context_line":"    security issue if not using TLS as the proxy will be able to intercept the"},{"line_number":10,"context_line":"    traffic. If using an untrusted proxy, with TLS disabled on the internal"},{"line_number":11,"context_line":"    VIP, it is recommended that you run ``kayobe overcloud host configure -t"},{"line_number":12,"context_line":"    proxy``, ``kayobe seed hypervisor host configure -t proxy`` ``kayobe seed"},{"line_number":13,"context_line":"    host configure -t proxy`` and ``kayobe infra vm host configure -t proxy``,"},{"line_number":14,"context_line":"    to add the internal VIP to the no proxy configuration. This is considered"},{"line_number":15,"context_line":"    a minor issue as traffic between containers will not use the proxy by"},{"line_number":16,"context_line":"    default."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"24a3d5ef_eec7e86f","line":16,"range":{"start_line":7,"start_character":4,"end_line":16,"end_character":12},"updated":"2024-09-13 23:08:17.000000000","message":"may be it would be good to create an issue on launchpad and backport this change to all releases?","commit_id":"4cf5814c1dab5ccc380586fccf928ea4e78aba27"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"5d6b3b58c52495b2f5c67c0f6d29f8e7430d39c2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds the internal VIP to the NOPROXY/noproxy environment variables."},{"line_number":5,"context_line":"security:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    When running API requests from a kayobe configured host, traffic destined"},{"line_number":8,"context_line":"    for the the internal VIP is sent via the default proxy. This can be a"},{"line_number":9,"context_line":"    security issue if not using TLS as the proxy will be able to intercept the"},{"line_number":10,"context_line":"    traffic. If using an untrusted proxy, with TLS disabled on the internal"},{"line_number":11,"context_line":"    VIP, it is recommended that you run ``kayobe overcloud host configure -t"},{"line_number":12,"context_line":"    proxy``, ``kayobe seed hypervisor host configure -t proxy`` ``kayobe seed"},{"line_number":13,"context_line":"    host configure -t proxy`` and ``kayobe infra vm host configure -t proxy``,"},{"line_number":14,"context_line":"    to add the internal VIP to the no proxy configuration. This is considered"},{"line_number":15,"context_line":"    a minor issue as traffic between containers will not use the proxy by"},{"line_number":16,"context_line":"    default."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"68a438a5_b1980f0e","line":16,"range":{"start_line":7,"start_character":4,"end_line":16,"end_character":12},"in_reply_to":"24a3d5ef_eec7e86f","updated":"2024-11-08 14:19:18.000000000","message":"Done","commit_id":"4cf5814c1dab5ccc380586fccf928ea4e78aba27"}]}
