)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d010757e766cf5f325fed2847685179febed3384","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6a096a0e_ebc949b2","updated":"2024-10-30 16:55:16.000000000","message":"This is an improvement, but still prone to leaking secrets on failure","commit_id":"2af9fd0938affb95235e9fe351992b9ffffb490d"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"f8b273455fe16992b58f8f9cf7c58362139555f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4802914f_68cfd124","updated":"2024-10-31 09:44:43.000000000","message":"Is this something we would like to backport? If so, should we add a release note?","commit_id":"802421beda88f57f9f049b247cd0c3c4c12f2a0e"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"e6e209e374b4f186cd1a6ddeb37de45486ab86cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"73341d38_73b302a5","updated":"2024-10-31 10:30:14.000000000","message":"imho we need, because this is security fix","commit_id":"802421beda88f57f9f049b247cd0c3c4c12f2a0e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e2ec9ef1c5f950fe19ac2f770c5b2a738e6bd387","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fedccef6_6e2d948e","updated":"2024-11-07 10:45:04.000000000","message":"there should be a bug attached to allow back porting to stable branches and as Maksim pointed out - fixes: category in reno (unless you raise it as a sec bug - then security:)","commit_id":"fa74518bebd449de10d4b95766931f7ec346aa52"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"09023a74ac131c0edaf156049863bc6d1a00fc97","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1e93992f_e599bde3","updated":"2024-11-07 11:19:00.000000000","message":"I mean item values, not module_args sorry)","commit_id":"3935b17b29399a3ff759b5885bc346a9f3223d74"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"9536707384d5e6771f43ba83c899ef698ec3c678","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"81046cf8_c7a3302f","updated":"2024-11-07 11:09:49.000000000","message":"Jake, it could be better to create a bugreport to propose backports too","commit_id":"3935b17b29399a3ff759b5885bc346a9f3223d74"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"694f1b378bae5b065b94b8e281c6e5a860ad7916","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6f0ced85_fea607f0","updated":"2024-11-08 16:12:34.000000000","message":"Now that we have a release note and are proposing a bug report, we may as well fix the task failure case too. See the pattern in: https://github.com/stackhpc/ansible-collection-pulp/pull/53. Its worth noting that there are probably other instances where we loop over lists with credentials and fixing all cases is probably no small task. Happy for them to be fixed one by one or in one big patch.","commit_id":"3935b17b29399a3ff759b5885bc346a9f3223d74"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"085ce0401f37b990d4c872443d98f3de311c5cc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3f8d8d5d_9618dff3","updated":"2024-11-07 11:23:50.000000000","message":"an example of logs from CI without this change for example: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_89f/829743/4/check/kayobe-overcloud-host-configure-centos9s/89fc885/primary/ansible/overcloud-deploy","commit_id":"3935b17b29399a3ff759b5885bc346a9f3223d74"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b60560d26f22cc830adf16c98f679f8cc8d6fdef","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1cd28691_b4ad28f2","updated":"2024-11-07 11:15:50.000000000","message":"even they doesn\u0027t contain credentials... but we can see all the module_args","commit_id":"3935b17b29399a3ff759b5885bc346a9f3223d74"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4b91675ea3d1644f3d02525615be7ec5b14da9f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"59c72e18_fc7e29bb","updated":"2024-11-07 11:14:03.000000000","message":"logs for a bugreport can be taken for example from CI: https://02aee0beb3ed367cb07e-804f3f4695b3063292bbb3235f424ae0.ssl.cf2.rackcdn.com/933761/3/check/kayobe-overcloud-host-configure-rocky9/686aa61/primary/ansible/overcloud-deploy","commit_id":"3935b17b29399a3ff759b5885bc346a9f3223d74"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"cb41c8b7630ddf549f9f45976d032510dd1e4ae6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c48bf0c5_26170999","in_reply_to":"1cd28691_b4ad28f2","updated":"2024-11-08 13:51:05.000000000","message":"It is worth nothing that password and proxy_password have no_log set to True, so they will be hidden from the output: https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/yum_repository.py#L575","commit_id":"3935b17b29399a3ff759b5885bc346a9f3223d74"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"f6fff8e185ba08241ec0f6666e9bc4252d6aab26","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8d94369f_0fedc7cb","in_reply_to":"6f0ced85_fea607f0","updated":"2024-11-08 17:05:36.000000000","message":"I personally would prefer to have the patches land ASAP instead of having one big one sitting around forever, and for this reason would nudge towards fixing them individually as we encounter them. In the mean time we could add a note warning that the logs may contain sensitive information and to keep them in a secure location (do this is separate patch so we can backport).","commit_id":"3935b17b29399a3ff759b5885bc346a9f3223d74"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8a20206df433c5c895828ca85f582ac1aa55e424","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2bf85fb8_3b4df77c","in_reply_to":"c48bf0c5_26170999","updated":"2024-11-08 14:24:46.000000000","message":"Hidden from the module output but not from the play when it shows the item.","commit_id":"3935b17b29399a3ff759b5885bc346a9f3223d74"}],"releasenotes/notes/dnf-loop-control-6e2c8ba1915d2631.yaml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"6de14a0a13d41351960ffe72007a75ca5e9d8c0d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add loop control to custom DNF repos to print only the repository key"},{"line_number":5,"context_line":"    to ensure repository username/password credentials are not leaked to"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f33e1a7_91b15d66","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"updated":"2024-10-31 22:48:31.000000000","message":"fixes?","commit_id":"fa74518bebd449de10d4b95766931f7ec346aa52"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"88f0a11c14f98b023bd22ebb5ece4dc562ef1ce8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add loop control to custom DNF repos to print only the repository key"},{"line_number":5,"context_line":"    to ensure repository username/password credentials are not leaked to"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fd3c91bc_03ac11e0","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"in_reply_to":"1f33e1a7_91b15d66","updated":"2024-10-31 22:49:12.000000000","message":"or even security?","commit_id":"fa74518bebd449de10d4b95766931f7ec346aa52"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"5dfaaf293197e2dd250a24cc55b333f376c8a077","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add loop control to custom DNF repos to print only the repository key"},{"line_number":5,"context_line":"    to ensure repository username/password credentials are not leaked to"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9ea8109b_80537f11","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"in_reply_to":"fd3c91bc_03ac11e0","updated":"2024-11-12 10:06:28.000000000","message":"Done","commit_id":"fa74518bebd449de10d4b95766931f7ec346aa52"}]}