)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"2d1e305067b6001fa77a637e25d51240ab0fd924","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4501ffb6_068f84d2","updated":"2025-01-24 09:39:41.000000000","message":"We\u0027ll want to backport this","commit_id":"0b7d8015251d5f5dc7cba584a8e2ca86a46f758a"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b635726cac529307ae14255d6987a99385ee7f34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ff853b84_f69848d2","updated":"2025-01-24 15:24:32.000000000","message":"recheck upgrade timeout","commit_id":"0b7d8015251d5f5dc7cba584a8e2ca86a46f758a"}],"roles/kayobe-galaxy-requirements/tasks/main.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"fcd9b02e34143effe41b7c5ca48da8b7e009c589","unresolved":true,"context_lines":[{"line_number":18,"context_line":"      version: \"{{ kayobe_galaxy_requirements_branch }}\""},{"line_number":19,"context_line":"    # NOTE(wszusmki): Use version checked out by Zuul so Depends-On works and only override version"},{"line_number":20,"context_line":"    # for previous release."},{"line_number":21,"context_line":"    new_requirement_with_version: \"{{ new_requirement | combine(version) if kayobe_galaxy_requirements_branch else new_requirement }}\""},{"line_number":22,"context_line":"    new_requirements:"},{"line_number":23,"context_line":"      collections: \"{{ (old_requirements.collections | rejectattr(\u0027name\u0027, \u0027search\u0027, \u0027ansible-collection-kolla\u0027) | list) + [new_requirement_with_version] }}\""},{"line_number":24,"context_line":"      roles: \"{{ old_requirements.roles | default([]) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4ee7c1c4_3aafb4d4","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":134},"updated":"2025-01-24 08:39:33.000000000","message":"Isn\u0027t kayobe_galaxy_requirements_branch always set? It defaults to \"{{ zuul.branch }}\".","commit_id":"8cb8f116341477150d6288c1e1458fe4da1bd253"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"6092eb0f19f8409055a5bb990fc2a8670954e53c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      version: \"{{ kayobe_galaxy_requirements_branch }}\""},{"line_number":19,"context_line":"    # NOTE(wszusmki): Use version checked out by Zuul so Depends-On works and only override version"},{"line_number":20,"context_line":"    # for previous release."},{"line_number":21,"context_line":"    new_requirement_with_version: \"{{ new_requirement | combine(version) if kayobe_galaxy_requirements_branch else new_requirement }}\""},{"line_number":22,"context_line":"    new_requirements:"},{"line_number":23,"context_line":"      collections: \"{{ (old_requirements.collections | rejectattr(\u0027name\u0027, \u0027search\u0027, \u0027ansible-collection-kolla\u0027) | list) + [new_requirement_with_version] }}\""},{"line_number":24,"context_line":"      roles: \"{{ old_requirements.roles | default([]) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8f55c84c_d8917012","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":134},"in_reply_to":"4ee7c1c4_3aafb4d4","updated":"2025-01-24 09:31:42.000000000","message":"Good spot. I missed from the podman patch that it had been unset too. https://review.opendev.org/c/openstack/kayobe/+/909686/55/roles/kayobe-galaxy-requirements/defaults/main.yml\nDone now","commit_id":"8cb8f116341477150d6288c1e1458fe4da1bd253"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"fcd9b02e34143effe41b7c5ca48da8b7e009c589","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    new_requirement_with_version: \"{{ new_requirement | combine(version) if kayobe_galaxy_requirements_branch else new_requirement }}\""},{"line_number":22,"context_line":"    new_requirements:"},{"line_number":23,"context_line":"      collections: \"{{ (old_requirements.collections | rejectattr(\u0027name\u0027, \u0027search\u0027, \u0027ansible-collection-kolla\u0027) | list) + [new_requirement_with_version] }}\""},{"line_number":24,"context_line":"      roles: \"{{ old_requirements.roles | default([]) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3417fe9a_51f38159","line":24,"updated":"2025-01-24 08:39:33.000000000","message":"Missing new line at end of file","commit_id":"8cb8f116341477150d6288c1e1458fe4da1bd253"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"6092eb0f19f8409055a5bb990fc2a8670954e53c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    new_requirement_with_version: \"{{ new_requirement | combine(version) if kayobe_galaxy_requirements_branch else new_requirement }}\""},{"line_number":22,"context_line":"    new_requirements:"},{"line_number":23,"context_line":"      collections: \"{{ (old_requirements.collections | rejectattr(\u0027name\u0027, \u0027search\u0027, \u0027ansible-collection-kolla\u0027) | list) + [new_requirement_with_version] }}\""},{"line_number":24,"context_line":"      roles: \"{{ old_requirements.roles | default([]) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c4159c29_aeb894bc","line":24,"in_reply_to":"3417fe9a_51f38159","updated":"2025-01-24 09:31:42.000000000","message":"Done","commit_id":"8cb8f116341477150d6288c1e1458fe4da1bd253"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"fd8cad3252a3323cc919e5d56f9f1eb1aef8a9f7","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    new_requirement:"},{"line_number":15,"context_line":"      name: \"file://{{ ansible_collection_kolla_src_dir }}\""},{"line_number":16,"context_line":"      type: git"},{"line_number":17,"context_line":"    version:"},{"line_number":18,"context_line":"      version: \"{{ kayobe_galaxy_requirements_branch }}\""},{"line_number":19,"context_line":"    # NOTE(wszusmki): Use version checked out by Zuul so Depends-On works and only override version"},{"line_number":20,"context_line":"    # for previous release."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f9cbe012_e2cf5c56","line":17,"range":{"start_line":17,"start_character":4,"end_line":17,"end_character":11},"updated":"2025-01-24 09:35:16.000000000","message":"What do you think of renaming this `version` to `override_version` (or something else) to avoid the two nested `version` keys?","commit_id":"47e985a27d54af372c1bd5600b123fda523cd8d6"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"2d1e305067b6001fa77a637e25d51240ab0fd924","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    new_requirement:"},{"line_number":15,"context_line":"      name: \"file://{{ ansible_collection_kolla_src_dir }}\""},{"line_number":16,"context_line":"      type: git"},{"line_number":17,"context_line":"    version:"},{"line_number":18,"context_line":"      version: \"{{ kayobe_galaxy_requirements_branch }}\""},{"line_number":19,"context_line":"    # NOTE(wszusmki): Use version checked out by Zuul so Depends-On works and only override version"},{"line_number":20,"context_line":"    # for previous release."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bb3a04fa_a20e9ce7","line":17,"range":{"start_line":17,"start_character":4,"end_line":17,"end_character":11},"in_reply_to":"f9cbe012_e2cf5c56","updated":"2025-01-24 09:39:41.000000000","message":"Sounds like a good idea to me 👍","commit_id":"47e985a27d54af372c1bd5600b123fda523cd8d6"}]}