)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"97fafaae0a442e19d6434dd53fa27992b22254e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"be50b697_112afbbc","updated":"2025-06-25 14:12:40.000000000","message":"I think this is the first time I\u0027ve tried to add a test so let me know if I\u0027ve done something wrong","commit_id":"f4bac9320de8036a22e86dba54d5678bddbaa1fe"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3fef7181fee4e923517be5cedfec80d441159114","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8d2a25a4_de14cd52","updated":"2025-06-26 08:07:18.000000000","message":"Why not add that functionality to ansible-collection-kolla so non-Kayobe users can also benefit from that? (-1 for posterity)","commit_id":"a50f467fd3ff68914497f05cf417187747097921"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"ea68b25476461e4c4e73b5c624759a9d90517b50","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"73b9eca2_b8427061","in_reply_to":"4e2059ea_73adae94","updated":"2025-06-26 10:39:02.000000000","message":"The original commit that splits it out says:\n\n\u003eetc-hosts: it proved difficult to generalise this, so we have some\n  almost duplicated the code from kolla-ansible here. [1]\n\nSo I guess it\u0027s just duplicated. I mean I tested this and it works so kayobe isn\u0027t using a-c-k for this evidently. We should probably reconcile them but that\u0027s way out of scope for this.\n\nI\u0027ll make the same change for a-c-k so they get the same feature.\n\n[1] https://review.opendev.org/c/openstack/kayobe/+/824998","commit_id":"a50f467fd3ff68914497f05cf417187747097921"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"3f4f75576c2ff63cd6d8484cdfe99d99c2927a27","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9e12d59b_443bb329","in_reply_to":"73b9eca2_b8427061","updated":"2025-08-14 16:48:32.000000000","message":"Agree, that it would be better to unify the roles. Personally, I would not block the change on this though as this has been written. The other ack role does make assumptions about inventory groups, perhaps you could abstract the template:\n\nhttps://github.com/openstack/ansible-collection-kolla/blob/master/roles/etc_hosts/tasks/etc-hosts.yml#L25-L41\n\nand the when conditions as variables.","commit_id":"a50f467fd3ff68914497f05cf417187747097921"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"f39b7501e97df4a238577a244339607cb14162d4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e899f64d_a7b06b47","in_reply_to":"8d2a25a4_de14cd52","updated":"2025-06-26 08:41:17.000000000","message":"I\u0027ve just had a look at ansible-collection-kolla and it\u0027s basically identical to kayobe for /etc/hosts. I\u0027m missing some history so I don\u0027t know how they fit together. Are you suggesting I add this feature to both?","commit_id":"a50f467fd3ff68914497f05cf417187747097921"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"feaabcdc6c9ca0b4788eaa8792d5a038189474c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9d6145b9_f99f803c","in_reply_to":"9e12d59b_443bb329","updated":"2026-04-07 11:00:53.000000000","message":"Lets consider this in a follow up.","commit_id":"a50f467fd3ff68914497f05cf417187747097921"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f75c179e72e71c43f0f8515cca7f8e46e234aeb6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4e2059ea_73adae94","in_reply_to":"e899f64d_a7b06b47","updated":"2025-06-26 08:59:17.000000000","message":"a-c-k was created so the same functionality could be used by kayobe and kolla-ansible - so I would assume we could use the a-c-k role in Kayobe and adapt the role so it suits our needs? Don\u0027t understand why there\u0027s a local copy in Kayobe...","commit_id":"a50f467fd3ff68914497f05cf417187747097921"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"3f4f75576c2ff63cd6d8484cdfe99d99c2927a27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"edb2f007_2de7b266","updated":"2025-08-14 16:48:32.000000000","message":"Its odd that the configuration variables aren\u0027t exposed as group_vars and in etc/kayobe/etc-hosts.yml which is the usual pattern.","commit_id":"d547b715d2c7ce1f7174c8be9656058f2ad51f2b"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"4ba30f54605ed39184088746870a6c93aceb6bed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"072bbfc7_992c5817","updated":"2025-11-17 12:04:12.000000000","message":"This is pretty useful. Lets get this in as it is not trivial to merge the a-c-k role and this one.","commit_id":"d547b715d2c7ce1f7174c8be9656058f2ad51f2b"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"c83733607e0234e189319933697fe53c5bda66f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"109d70f3_95d08eff","updated":"2026-04-08 08:14:06.000000000","message":"recheck","commit_id":"6fb103fd5dec1a7782af2a440c47df3b3c110fdc"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"c9a8069e8676f53c874467a0b11993ce3828cdaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"22ed8c26_fb12df43","updated":"2026-04-08 14:23:51.000000000","message":"recheck","commit_id":"6fb103fd5dec1a7782af2a440c47df3b3c110fdc"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"1ec15a3cc5b9c21df5ebc70ce80bff6c6d8736b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3444c813_38b1c704","updated":"2026-04-09 08:36:15.000000000","message":"recheck","commit_id":"6fb103fd5dec1a7782af2a440c47df3b3c110fdc"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"37017ec1dace20f5ab1c73327837d79fd760b5fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"69d6d509_82efd75e","updated":"2026-04-08 16:46:25.000000000","message":"recheck","commit_id":"6fb103fd5dec1a7782af2a440c47df3b3c110fdc"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"e7e280d4ec28ca7c6e6f589ec775bf351d80acf0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"aaca7a07_4809670b","updated":"2026-04-08 11:47:08.000000000","message":"recheck: download issue","commit_id":"6fb103fd5dec1a7782af2a440c47df3b3c110fdc"}],"playbooks/kayobe-overcloud-host-configure-base/overrides.yml.j2":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"7434d1a3b94e9162f29c31bd2b318f2dde9e56f0","unresolved":true,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"# Add a custom entry to /etc/hosts."},{"line_number":229,"context_line":"custom_etc_hosts_entries:"},{"line_number":230,"context_line":"  foo.example.com: 127.0.0.1"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"b4f7c8b1_f7dbdf86","line":230,"range":{"start_line":230,"start_character":2,"end_line":230,"end_character":28},"updated":"2025-06-25 14:14:05.000000000","message":"I think it\u0027s a bad idea to override the localhost during testing. It could break something.","commit_id":"f4bac9320de8036a22e86dba54d5678bddbaa1fe"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4c3749c12ca590bbad8381d2f1e2221fd3fed6f4","unresolved":true,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"# Add a custom entry to /etc/hosts."},{"line_number":229,"context_line":"custom_etc_hosts_entries:"},{"line_number":230,"context_line":"  foo.example.com: 127.0.0.1"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9d1cdb43_0b69bcd8","line":230,"range":{"start_line":230,"start_character":2,"end_line":230,"end_character":28},"in_reply_to":"3d7cb820_86c93c43","updated":"2025-06-25 15:20:28.000000000","message":"Nevermind. It\u0027s better to use an external IP, for example.","commit_id":"f4bac9320de8036a22e86dba54d5678bddbaa1fe"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"85a49184782c36a5117d91422a8691368749970e","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"# Add a custom entry to /etc/hosts."},{"line_number":229,"context_line":"custom_etc_hosts_entries:"},{"line_number":230,"context_line":"  foo.example.com: 127.0.0.1"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1c3547ee_921d5d82","line":230,"range":{"start_line":230,"start_character":2,"end_line":230,"end_character":28},"in_reply_to":"9d1cdb43_0b69bcd8","updated":"2025-11-17 12:28:56.000000000","message":"Done","commit_id":"f4bac9320de8036a22e86dba54d5678bddbaa1fe"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"953371f37842e593853df05e6bbfda79dc247aec","unresolved":true,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"# Add a custom entry to /etc/hosts."},{"line_number":229,"context_line":"custom_etc_hosts_entries:"},{"line_number":230,"context_line":"  foo.example.com: 127.0.0.1"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3d7cb820_86c93c43","line":230,"range":{"start_line":230,"start_character":2,"end_line":230,"end_character":28},"in_reply_to":"b4f7c8b1_f7dbdf86","updated":"2025-06-25 14:26:41.000000000","message":"It should only work one way i.e. foo.example.com now resolves to localhost. The only way I can see this causing a problem is if the fqdn, foo.example.com, is used elsewhere","commit_id":"f4bac9320de8036a22e86dba54d5678bddbaa1fe"}]}