)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"bddd39bebdd0837b8cdb287a736169c7616d56b0","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Jake Hutchinson \u003cjake@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-08-08 16:27:09 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Skip external connectivity check for walled garden hosts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Network connectivity check fails on hosts which have no"},{"line_number":10,"context_line":"external networking, this patch changes the external"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"d4447e4b_01c479f8","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":56},"updated":"2025-08-08 17:13:54.000000000","message":"Skip external connectivity check behind a proxy","commit_id":"12eeb3fba73d01b057f43b3e18ccaa13dba0cb4d"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"1c2388102a2834f4102fd40321bb5056c49ce8ab","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jake Hutchinson \u003cjake@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-08-08 16:27:09 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Skip external connectivity check for walled garden hosts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Network connectivity check fails on hosts which have no"},{"line_number":10,"context_line":"external networking, this patch changes the external"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"4ef2e6c5_deac3b55","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":56},"in_reply_to":"d4447e4b_01c479f8","updated":"2026-03-13 17:30:29.000000000","message":"Done","commit_id":"12eeb3fba73d01b057f43b3e18ccaa13dba0cb4d"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"bddd39bebdd0837b8cdb287a736169c7616d56b0","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Skip external connectivity check for walled garden hosts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Network connectivity check fails on hosts which have no"},{"line_number":10,"context_line":"external networking, this patch changes the external"},{"line_number":11,"context_line":"connectivity check to only run on hosts which don\u0027t"},{"line_number":12,"context_line":"have `http_proxy` defined."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ib6f815c319a7e92e675382cfe9d4011598e72aba"},{"line_number":15,"context_line":"Signed-off-by: Jake Hutchinson \u003cjake@stackhpc.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"96cd0b25_4d74e985","line":12,"range":{"start_line":9,"start_character":1,"end_line":12,"end_character":26},"updated":"2025-08-08 17:13:54.000000000","message":"Network connectivity check fails for hosts that have\nno external network, so this check is now skipped if\n`http_proxy` is defined.","commit_id":"12eeb3fba73d01b057f43b3e18ccaa13dba0cb4d"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"1c2388102a2834f4102fd40321bb5056c49ce8ab","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Skip external connectivity check for walled garden hosts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Network connectivity check fails on hosts which have no"},{"line_number":10,"context_line":"external networking, this patch changes the external"},{"line_number":11,"context_line":"connectivity check to only run on hosts which don\u0027t"},{"line_number":12,"context_line":"have `http_proxy` defined."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ib6f815c319a7e92e675382cfe9d4011598e72aba"},{"line_number":15,"context_line":"Signed-off-by: Jake Hutchinson \u003cjake@stackhpc.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ea75f179_208897cc","line":12,"range":{"start_line":9,"start_character":1,"end_line":12,"end_character":26},"in_reply_to":"96cd0b25_4d74e985","updated":"2026-03-13 17:30:29.000000000","message":"Done","commit_id":"12eeb3fba73d01b057f43b3e18ccaa13dba0cb4d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"7b254ae41edad8523e54a6537295f7b2ee806eb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d8541120_01716dd4","updated":"2025-08-14 15:58:40.000000000","message":"Nice idea. We have a network connectivity options in: https://github.com/openstack/kayobe/blob/adab3467b45102c851754405b1da7d50d42135a7/etc/kayobe/networks.yml#L107. Worth adding this here too\u003e","commit_id":"12eeb3fba73d01b057f43b3e18ccaa13dba0cb4d"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"21a5be8441601682099af9327f40c621f4104993","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c32a0f11_05e17811","updated":"2025-11-28 14:52:56.000000000","message":"please address the comments","commit_id":"ce52975288cbd9d619da11a4a8ef07bb779e2f6d"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"c2c8a9fed83caf7bdeaa6a56f36bbb1159a0544e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7eb55bb9_d16b62b0","updated":"2026-03-13 17:25:58.000000000","message":"Updated to resolve comments. Thanks all for reviewing / suggestions.","commit_id":"cb7ebba4e4059a9a0ef85b45364a4b1031acad49"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"65de7b09d4383b37a8a5d7b017cfb9c0b1c279ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"62f32eaf_f250378a","updated":"2026-03-14 20:57:43.000000000","message":"recheck","commit_id":"f4c4ebef059797f733a19b27740aa05c565fc0e3"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"cec832d2fc6e0d59880bf4287a1d6814305089ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d5a7dfcd_9b73fdb1","updated":"2026-03-16 17:40:11.000000000","message":"Merging due to previous reviews (change was trivial to fix linter)","commit_id":"8767fcc69281277139f7132f36a2a65f8a06f5e8"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"e0e61216baab3c18964a0f3ecaf3daf4b87fa2f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0850db29_d89deb36","updated":"2026-03-16 19:56:00.000000000","message":"recheck tarballs.openstack.org unreachable","commit_id":"8767fcc69281277139f7132f36a2a65f8a06f5e8"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"a6e1925c417512e71345d84627434e11fc618c39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"acf4137d_08c546f7","updated":"2026-03-18 11:25:04.000000000","message":"recheck: tarballs still broken","commit_id":"8767fcc69281277139f7132f36a2a65f8a06f5e8"}],"ansible/network-connectivity.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"bddd39bebdd0837b8cdb287a736169c7616d56b0","unresolved":true,"context_lines":[{"line_number":6,"context_line":"       default(kayobe_max_fail_percentage) |"},{"line_number":7,"context_line":"       default(100) }}"},{"line_number":8,"context_line":"  vars:"},{"line_number":9,"context_line":"    # Skip external connectivity check when using walled garden networking."},{"line_number":10,"context_line":"    nc_skip_external_net: \"{{ http_proxy | default(false) }}\""},{"line_number":11,"context_line":"    # Set this to an external IP address to check."},{"line_number":12,"context_line":"    nc_external_ip: 8.8.8.8"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2e5a6b5a_222d56f5","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":74},"updated":"2025-08-08 17:13:54.000000000","message":"```suggestion\n    # Skip external connectivity check behind a proxy.\n```","commit_id":"12eeb3fba73d01b057f43b3e18ccaa13dba0cb4d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"98e38df6044e355cbc3d5d95ba66c43c9677c562","unresolved":true,"context_lines":[{"line_number":6,"context_line":"       default(kayobe_max_fail_percentage) |"},{"line_number":7,"context_line":"       default(100) }}"},{"line_number":8,"context_line":"  vars:"},{"line_number":9,"context_line":"    # Skip external connectivity check when using walled garden networking."},{"line_number":10,"context_line":"    nc_skip_external_net: \"{{ http_proxy | default(false) }}\""},{"line_number":11,"context_line":"    # Set this to an external IP address to check."},{"line_number":12,"context_line":"    nc_external_ip: 8.8.8.8"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"08aef6df_e98a48fc","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":74},"in_reply_to":"08584c9f_77d2508b","updated":"2025-08-19 09:35:24.000000000","message":"Best to update the commit message to match this too","commit_id":"12eeb3fba73d01b057f43b3e18ccaa13dba0cb4d"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"522f0aa5bc3c62255e7d5f6d17f34587b8c11dc5","unresolved":true,"context_lines":[{"line_number":6,"context_line":"       default(kayobe_max_fail_percentage) |"},{"line_number":7,"context_line":"       default(100) }}"},{"line_number":8,"context_line":"  vars:"},{"line_number":9,"context_line":"    # Skip external connectivity check when using walled garden networking."},{"line_number":10,"context_line":"    nc_skip_external_net: \"{{ http_proxy | default(false) }}\""},{"line_number":11,"context_line":"    # Set this to an external IP address to check."},{"line_number":12,"context_line":"    nc_external_ip: 8.8.8.8"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"43debb19_3d1229c8","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":74},"in_reply_to":"08aef6df_e98a48fc","updated":"2025-08-19 11:30:28.000000000","message":"I\u0027ve proposed both suggestions. @jake@stackhpc.com can simple apply them.","commit_id":"12eeb3fba73d01b057f43b3e18ccaa13dba0cb4d"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"24265ce0130b3e93045aa246e3ffd3da26aa1018","unresolved":true,"context_lines":[{"line_number":6,"context_line":"       default(kayobe_max_fail_percentage) |"},{"line_number":7,"context_line":"       default(100) }}"},{"line_number":8,"context_line":"  vars:"},{"line_number":9,"context_line":"    # Skip external connectivity check when using walled garden networking."},{"line_number":10,"context_line":"    nc_skip_external_net: \"{{ http_proxy | default(false) }}\""},{"line_number":11,"context_line":"    # Set this to an external IP address to check."},{"line_number":12,"context_line":"    nc_external_ip: 8.8.8.8"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"08584c9f_77d2508b","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":74},"in_reply_to":"2e5a6b5a_222d56f5","updated":"2025-08-19 08:42:21.000000000","message":"Lets also go with this suggestion, but otherwise looks good to me.","commit_id":"12eeb3fba73d01b057f43b3e18ccaa13dba0cb4d"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"c2c8a9fed83caf7bdeaa6a56f36bbb1159a0544e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"       default(kayobe_max_fail_percentage) |"},{"line_number":7,"context_line":"       default(100) }}"},{"line_number":8,"context_line":"  vars:"},{"line_number":9,"context_line":"    # Skip external connectivity check when using walled garden networking."},{"line_number":10,"context_line":"    nc_skip_external_net: \"{{ http_proxy | default(false) }}\""},{"line_number":11,"context_line":"    # Set this to an external IP address to check."},{"line_number":12,"context_line":"    nc_external_ip: 8.8.8.8"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bc4dd84f_15f98e67","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":74},"in_reply_to":"43debb19_3d1229c8","updated":"2026-03-13 17:25:58.000000000","message":"Done","commit_id":"12eeb3fba73d01b057f43b3e18ccaa13dba0cb4d"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"7b254ae41edad8523e54a6537295f7b2ee806eb6","unresolved":true,"context_lines":[{"line_number":7,"context_line":"       default(100) }}"},{"line_number":8,"context_line":"  vars:"},{"line_number":9,"context_line":"    # Skip external connectivity check when using walled garden networking."},{"line_number":10,"context_line":"    nc_skip_external_net: \"{{ http_proxy | default(false) }}\""},{"line_number":11,"context_line":"    # Set this to an external IP address to check."},{"line_number":12,"context_line":"    nc_external_ip: 8.8.8.8"},{"line_number":13,"context_line":"    # Set this to an external hostname to check."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ee7ecb97_352bbc37","line":10,"updated":"2025-08-14 15:58:40.000000000","message":"Not a massive fan of mixing types. Could do:\n```suggestion\n    nc_skip_external_net: \"{{ http_proxy | truthy }}\"\n```","commit_id":"12eeb3fba73d01b057f43b3e18ccaa13dba0cb4d"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"c2c8a9fed83caf7bdeaa6a56f36bbb1159a0544e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"       default(100) }}"},{"line_number":8,"context_line":"  vars:"},{"line_number":9,"context_line":"    # Skip external connectivity check when using walled garden networking."},{"line_number":10,"context_line":"    nc_skip_external_net: \"{{ http_proxy | default(false) }}\""},{"line_number":11,"context_line":"    # Set this to an external IP address to check."},{"line_number":12,"context_line":"    nc_external_ip: 8.8.8.8"},{"line_number":13,"context_line":"    # Set this to an external hostname to check."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"174b63b2_702ef9a5","line":10,"in_reply_to":"ee7ecb97_352bbc37","updated":"2026-03-13 17:25:58.000000000","message":"Done","commit_id":"12eeb3fba73d01b057f43b3e18ccaa13dba0cb4d"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"f2b017e3bd868550b27bfb5a88197abfc6c588da","unresolved":true,"context_lines":[{"line_number":6,"context_line":"       default(kayobe_max_fail_percentage) |"},{"line_number":7,"context_line":"       default(100) }}"},{"line_number":8,"context_line":"  vars:"},{"line_number":9,"context_line":"    # Skip external connectivity check when using walled garden networking."},{"line_number":10,"context_line":"    nc_skip_external_net: \"{{ http_proxy | truthy }}\""},{"line_number":11,"context_line":"    # Set this to an external IP address to check."},{"line_number":12,"context_line":"    nc_external_ip: 8.8.8.8"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"823e1f87_fed6f279","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":75},"updated":"2025-11-27 15:55:07.000000000","message":"```suggestion\n    # Skip external connectivity check behind a proxy.\n```","commit_id":"bbc54c5d3fcbf8f376e4184f7d08a053ccdf71d9"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"c2c8a9fed83caf7bdeaa6a56f36bbb1159a0544e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"       default(kayobe_max_fail_percentage) |"},{"line_number":7,"context_line":"       default(100) }}"},{"line_number":8,"context_line":"  vars:"},{"line_number":9,"context_line":"    # Skip external connectivity check when using walled garden networking."},{"line_number":10,"context_line":"    nc_skip_external_net: \"{{ http_proxy | truthy }}\""},{"line_number":11,"context_line":"    # Set this to an external IP address to check."},{"line_number":12,"context_line":"    nc_external_ip: 8.8.8.8"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"93891e68_458758c2","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":75},"in_reply_to":"823e1f87_fed6f279","updated":"2026-03-13 17:25:58.000000000","message":"Done","commit_id":"bbc54c5d3fcbf8f376e4184f7d08a053ccdf71d9"}],"releasenotes/notes/fix-external-connectivity-check-43d232b52f43ed93.yaml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"bddd39bebdd0837b8cdb287a736169c7616d56b0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add functionality to the network connectivity check to"},{"line_number":5,"context_line":"    skip the external connectivity check on walled garden"},{"line_number":6,"context_line":"    hosts."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"463986fc_423584ba","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":10},"updated":"2025-08-08 17:13:54.000000000","message":"```suggestion\n    Skip external connectivity check behind a proxy.\n```","commit_id":"12eeb3fba73d01b057f43b3e18ccaa13dba0cb4d"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"f2b017e3bd868550b27bfb5a88197abfc6c588da","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add functionality to the network connectivity check to"},{"line_number":5,"context_line":"    skip the external connectivity check on walled garden"},{"line_number":6,"context_line":"    hosts."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ea81f391_143dcd35","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":10},"updated":"2025-11-27 15:55:07.000000000","message":"```suggestion\n    Skip external connectivity check behind a proxy.\n```","commit_id":"12eeb3fba73d01b057f43b3e18ccaa13dba0cb4d"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"c2c8a9fed83caf7bdeaa6a56f36bbb1159a0544e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add functionality to the network connectivity check to"},{"line_number":5,"context_line":"    skip the external connectivity check on walled garden"},{"line_number":6,"context_line":"    hosts."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"30ad5b03_cd40f83c","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":10},"in_reply_to":"463986fc_423584ba","updated":"2026-03-13 17:25:58.000000000","message":"Fix applied.","commit_id":"12eeb3fba73d01b057f43b3e18ccaa13dba0cb4d"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"c2c8a9fed83caf7bdeaa6a56f36bbb1159a0544e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add functionality to the network connectivity check to"},{"line_number":5,"context_line":"    skip the external connectivity check on walled garden"},{"line_number":6,"context_line":"    hosts."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9e7f9038_26e9ea04","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":10},"in_reply_to":"ea81f391_143dcd35","updated":"2026-03-13 17:25:58.000000000","message":"Done","commit_id":"12eeb3fba73d01b057f43b3e18ccaa13dba0cb4d"}]}