)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8f747db3a2dcad0255aede0162393b4a5e62591f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Claudia Watson \u003cclaudia@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-09-02 08:59:54 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Add redfish pxe args for vitrual media"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use ironic pxe variables for redfish to move from use of PXE boot to redfish"},{"line_number":10,"context_line":"Deprecated variables are:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c8edc62f_703fe4ed","line":7,"range":{"start_line":7,"start_character":30,"end_line":7,"end_character":37},"updated":"2025-09-02 09:07:24.000000000","message":"virtual","commit_id":"6b07709e2c43bb7f97e979078a5826c0a7a1b0c9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f04013ef671a3ec037829f6320be56f5b476dd27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d62eaf70_914dd929","updated":"2025-09-05 15:09:32.000000000","message":"Ah, I think there are quite a few other references to the old names that will need updating, including the docs:\nhttps://github.com/search?q\u003drepo%3Aopenstack%2Fkayobe%20kolla_ironic_pxe_append_params\u0026type\u003dcode","commit_id":"fa5b396c2f07a7bee5de273e2eaf6f44272ede27"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7bdffe72806adc197752c5b6b56249dd2c3f1d43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e2ef280f_41f5d940","updated":"2025-09-05 14:53:17.000000000","message":"I had a quick look in the logs, its complaining about \u0027kolla_ironic_append_params\u0027 is undefined:\n\n`[31mfatal: [centos-stream9]: FAILED! \u003d\u003e {\"msg\": \"The task includes an option with an undefined variable.. {\u0027content\u0027: \\\"{%- for path in item.sources -%}\\\\n{{ lookup(\u0027template\u0027, path) }}\\\\n{%- endfor -%}\\\\n\\\", \u0027dest\u0027: \u0027{{ item.dest }}\u0027, \u0027mode\u0027: 416}: \u0027kolla_ironic_append_params\u0027 is undefined\\n\\nThe error appears to be in \u0027/home/zuul/src/opendev.org/openstack/kayobe/ansible/roles/kolla-openstack/tasks/config.yml\u0027: line 117, column 3, but may\\nbe elsewhere in the file depending on the exact syntax problem.\\n\\nThe offending line appears to be:\\n\\n\\n- name: \\\"Ensure extra configuration files exist (strategy: concat)\\\"\\n  ^ here\\nThis one looks easy to fix. It seems that there is a value started\\nwith a quote, and the YAML parser is expecting to see the line ended\\nwith the same kind of quote. For instance:\\n\\n    when: \\\"ok\\\" in result.stdout\\n\\nCould be written as:\\n\\n   when: \u0027\\\"ok\\\" in result.stdout\u0027\\n\\nOr equivalently:\\n\\n   when: \\\"\u0027ok\u0027 in result.stdout\\\"\\n\"}\u001b`","commit_id":"fa5b396c2f07a7bee5de273e2eaf6f44272ede27"}],"ansible/inventory/group_vars/all/ironic":[{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"0c10c7fc7f600a05ce6f94598a4b6ddd1b439a40","unresolved":true,"context_lines":[{"line_number":123,"context_line":"kolla_ironic_append_params_extra: \"{{ kolla_ironic_pxe_append_params_extra }}\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"# List of kernel parameters to append for baremetal boot."},{"line_number":126,"context_line":"kolla_ironic_append_params: \"{{ kolla_ironic_pxe_append_params }}\""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"###############################################################################"},{"line_number":129,"context_line":"# Ironic Node Configuration"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"4a806451_a89a2308","line":126,"updated":"2025-09-05 15:02:36.000000000","message":"This will ignore the new variables as is:\n\nA potential solution that might work:\n\nkolla_ironic_append_params: \u003e\n  {{ kolla_ironic_append_params_default +\n     kolla_ironic_append_params_extra | \n     default(kolla_ironic_pxe_append_params) }}","commit_id":"fa5b396c2f07a7bee5de273e2eaf6f44272ede27"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e1a8e60db21bc056fa005d7dd2e5906eeec2f461","unresolved":true,"context_lines":[{"line_number":123,"context_line":"kolla_ironic_append_params_extra: \"{{ kolla_ironic_pxe_append_params_extra }}\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"# List of kernel parameters to append for baremetal boot."},{"line_number":126,"context_line":"kolla_ironic_append_params: \"{{ kolla_ironic_pxe_append_params }}\""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"###############################################################################"},{"line_number":129,"context_line":"# Ironic Node Configuration"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"7ea96b25_43b37a4d","line":126,"updated":"2025-09-05 15:02:46.000000000","message":"With this, if people change kolla_ironic_append_params_extra it will not get applied right now.\n\nI think Jake will add a note on a fix for this, but these don\u0027t quite work the way we need yet. Sorry, I can\u0027t quite get in my head what would work just yet.","commit_id":"fa5b396c2f07a7bee5de273e2eaf6f44272ede27"}],"ansible/roles/kolla-openstack/templates/kolla/config/ironic.conf":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a2a214f781d2bd5a59f94bf7595689cfb64701bd","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[pxe]"},{"line_number":32,"context_line":"{% if kolla_ironic_pxe_append_params %}"},{"line_number":33,"context_line":"kernel_append_params \u003d {{ kolla_ironic_pxe_append_params | join(\u0027 \u0027) }}"},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% raw %}"}],"source_content_type":"text/plain","patch_set":2,"id":"c801fe30_70f047ad","line":33,"updated":"2025-09-02 09:01:57.000000000","message":"I think we might want to use the new value kolla_ironic_append_params here too? not 100% sure.","commit_id":"6b07709e2c43bb7f97e979078a5826c0a7a1b0c9"}]}