)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"2dd58c2e196651a554251ba58b3cc88faf462c5f","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Add redfish pxe args for virtual media"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use ironic pxe variables for redfish to move from use of PXE boot to redfish"},{"line_number":10,"context_line":"Deprecated variables are:"},{"line_number":11,"context_line":"- kolla_ironic_pxe_append_params_default"},{"line_number":12,"context_line":"- kolla_ironic_pxe_append_params_extra"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"c5ce1bc4_0796e361","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":76},"updated":"2025-09-11 14:54:16.000000000","message":"I think this would be better split into two sentences, to make it easier to understand.","commit_id":"c7a91b2a1bcdaf02241c2a5e4bc5b0310150f279"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"fc160671ec19b90af5240c20efc92fabbec7c668","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Add redfish pxe args for virtual media"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use ironic pxe variables for redfish to move from use of PXE boot to redfish"},{"line_number":10,"context_line":"Deprecated variables are:"},{"line_number":11,"context_line":"- kolla_ironic_pxe_append_params_default"},{"line_number":12,"context_line":"- kolla_ironic_pxe_append_params_extra"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3065ff11_56bdc3d4","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":76},"in_reply_to":"c5ce1bc4_0796e361","updated":"2025-09-22 08:08:44.000000000","message":"Done","commit_id":"c7a91b2a1bcdaf02241c2a5e4bc5b0310150f279"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"cd374db39b37ac5db434890931d2a547d78f130d","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Use ironic pxe variables for redfish. Both Redfish"},{"line_number":10,"context_line":"and PXE boot are now supported using a common set"},{"line_number":11,"context_line":"of configuration parameters."},{"line_number":12,"context_line":"Deprecated variables are:"},{"line_number":13,"context_line":"- kolla_ironic_pxe_append_params_default"},{"line_number":14,"context_line":"- kolla_ironic_pxe_append_params_extra"},{"line_number":15,"context_line":"- kolla_ironic_pxe_append_params"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":35,"id":"d2374d83_0cb8cfee","line":12,"updated":"2025-10-14 19:11:53.000000000","message":"Please remove the deprecation notice.","commit_id":"d10de00f733329dc0c8782684fc8ce6013698d46"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"c4534bd8e839410dfdefd9aaa7daf488e23e5831","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Use ironic pxe variables for redfish. Both Redfish"},{"line_number":10,"context_line":"and PXE boot are now supported using a common set"},{"line_number":11,"context_line":"of configuration parameters."},{"line_number":12,"context_line":"Deprecated variables are:"},{"line_number":13,"context_line":"- kolla_ironic_pxe_append_params_default"},{"line_number":14,"context_line":"- kolla_ironic_pxe_append_params_extra"},{"line_number":15,"context_line":"- kolla_ironic_pxe_append_params"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":35,"id":"32cd6db1_c1f485b9","line":12,"in_reply_to":"d2374d83_0cb8cfee","updated":"2025-10-15 08:15:51.000000000","message":"Done","commit_id":"d10de00f733329dc0c8782684fc8ce6013698d46"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"2dd58c2e196651a554251ba58b3cc88faf462c5f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"22220df7_2187fda3","updated":"2025-09-11 14:54:16.000000000","message":"Thanks @claudia@stackhpc.com! Could you add a release note please, to highlight the deprecated variables.","commit_id":"c7a91b2a1bcdaf02241c2a5e4bc5b0310150f279"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"fc160671ec19b90af5240c20efc92fabbec7c668","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1dce9b66_1616cf5d","in_reply_to":"22220df7_2187fda3","updated":"2025-09-22 08:08:44.000000000","message":"Done","commit_id":"c7a91b2a1bcdaf02241c2a5e4bc5b0310150f279"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"fc160671ec19b90af5240c20efc92fabbec7c668","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"5f4d0e7a_4cb68a94","updated":"2025-09-22 08:08:44.000000000","message":"recheck: check tox-ansible failure is genuine","commit_id":"990c467daeffd9c00dbeeed05c0b1afcffc72ffb"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"46a0b5c0b3d7c71bda1f0226e1a03df0c193fec7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"8a909090_cdf05eb7","updated":"2025-09-30 04:46:27.000000000","message":"Just a few typos","commit_id":"764746566ef20ac4b4720c40c4f40a116b0ef9c1"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"bb5aa1bf93e4531bc77e4e83205fa0a34466e3d3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":26,"id":"d1837d30_35ef75fb","updated":"2025-09-29 15:29:31.000000000","message":"Looking good. One last comment, then please remove the WIP from the commit message.","commit_id":"764746566ef20ac4b4720c40c4f40a116b0ef9c1"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"d0fa017a8f85242f15c358321f06d4acab17d71a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"5e535d40_4ce169f8","in_reply_to":"d1837d30_35ef75fb","updated":"2025-10-02 07:20:43.000000000","message":"Done","commit_id":"764746566ef20ac4b4720c40c4f40a116b0ef9c1"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"3b28a61de755151b17b79340374bcd77c166e397","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"e4074a7a_a8ecc2ac","updated":"2025-10-01 20:29:13.000000000","message":"@claudia@stackhpc.com Could you please mark the comments as resolved once you have addressed them? I am lost among the comments not knowing if they are still relevant.","commit_id":"12197a2cc9babaa86b03fb0412667b416e61480a"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"508e1ad0b6db9cd4db211772e7d5458bdf686851","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"ed3bfa9b_032916e0","updated":"2025-10-03 14:46:07.000000000","message":"Nice work Claudia!","commit_id":"26b33e1076232c5474a6848aafce94733be60865"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7abb3b1ffa6f83dc7b0077c7f07bb7d87c688932","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"390293c9_2530d50f","updated":"2025-10-10 13:17:20.000000000","message":"Thanks Claudia, this looks good to me.","commit_id":"26b33e1076232c5474a6848aafce94733be60865"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"813244649cbb7bc304e0a0d66d647fd43e0f0a8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"f70a7958_55992fc3","updated":"2025-10-04 06:09:36.000000000","message":"recheck","commit_id":"26b33e1076232c5474a6848aafce94733be60865"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"83c30c90c18f2725d6a454d02ea24b352e2d74e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"056e611e_85e98936","updated":"2025-10-04 09:40:32.000000000","message":"recheck NODE_FAILUREs","commit_id":"26b33e1076232c5474a6848aafce94733be60865"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"abbfc3eb9d64a44d0d19d31dea91ac574895ea88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"21d58af7_f34793e5","updated":"2025-10-13 16:03:48.000000000","message":"I think this makes sense if we want to rename the variable. We could do something like this instead:","commit_id":"cdf498dc84faceee41f5c3c5cef1d397d98d7dca"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"af9c9098631d67e2084839a2ba5825d78b736fdd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"2706f579_cd667f07","updated":"2025-10-15 16:02:12.000000000","message":"It looks fine to me","commit_id":"3ba07b28be8a468dd263833f741fadc7e21af45a"}],"ansible/inventory/group_vars/all/ironic":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"5e4e49fd228db760d45270cbaa6eb797602c13c5","unresolved":true,"context_lines":[{"line_number":120,"context_line":"kolla_ironic_append_params_extra: \"{{ kolla_ironic_pxe_append_params_extra }}\""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# List of kernel parameters to append for baremetal boot."},{"line_number":123,"context_line":"kolla_ironic_append_params: \"{{ kolla_ironic_pxe_append_params }}\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"###############################################################################"},{"line_number":126,"context_line":"# Ironic Node Configuration"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"ec44e00c_1621bb5b","line":123,"updated":"2025-09-25 14:27:03.000000000","message":"Bit of a nit, but could use this as an opportunity to make the variable name more explicit e.g kolla_ironic_kernel_append_params. `append_params` means very little to without reading the comment. This isn\u0027t a blocker for me though if others prefer the shorter name that matches the old naming.","commit_id":"11793c6e1d4c58ebb0fb1f28e6503d4b0d60ab73"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"ed0161b10ec434438c8a2db96673b07bd4d2c056","unresolved":false,"context_lines":[{"line_number":120,"context_line":"kolla_ironic_append_params_extra: \"{{ kolla_ironic_pxe_append_params_extra }}\""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# List of kernel parameters to append for baremetal boot."},{"line_number":123,"context_line":"kolla_ironic_append_params: \"{{ kolla_ironic_pxe_append_params }}\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"###############################################################################"},{"line_number":126,"context_line":"# Ironic Node Configuration"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"ac6a675d_f4c8a925","line":123,"in_reply_to":"ec44e00c_1621bb5b","updated":"2025-09-29 15:31:15.000000000","message":"Done","commit_id":"11793c6e1d4c58ebb0fb1f28e6503d4b0d60ab73"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"0b8c5f7bdb07af5566526e9de675fae0ea31370e","unresolved":true,"context_lines":[{"line_number":116,"context_line":"  {{ kolla_ironic_pxe_append_params_default +"},{"line_number":117,"context_line":"     kolla_ironic_pxe_append_params_extra }}"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"# List of default kernel parameters to append for baremetal boot."},{"line_number":120,"context_line":"kolla_ironic_append_params_default: \"{{ kolla_ironic_pxe_append_params_default }}\""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# List of additional kernel parameters to append for baremetal boot."}],"source_content_type":"application/octet-stream","patch_set":20,"id":"c008b3ff_3d5aa259","line":119,"updated":"2025-09-29 09:59:27.000000000","message":"We can remove these old variables for clarity, and support compatibility by using the following structure:\n\n\u0027# List of default kernel parameters \nkolla_ironic_kernel_append_params_default_list:\n  - nofb\n  - nomodeset\n  - vga\u003dnormal\n  - console\u003dtty0\n  - console\u003dttyS0,115200n8\n\n\u0027# List of default kernel parameters to append for baremetal boot.\nkolla_ironic_kernel_append_params_default: \"{{ kolla_ironic_pxe_append_params_default | default(kolla_ironic_kernel_append_params_default_list) }}\"\n\n\u0027# List of additional kernel parameters to append for baremetal boot.\nkolla_ironic_kernel_append_params_extra: \"{{ kolla_ironic_pxe_append_params_extra | default(\u0027\u0027) }}\"\n\n\u0027# List of kernel parameters to append for baremetal boot.\nkolla_ironic_kernel_append_params: \u003e\n  {{ kolla_ironic_pxe_append_params | default(kolla_ironic_kernel_append_params_default + kolla_ironic_kernel_append_params_extra) }}","commit_id":"9d03dcbd6372e55ea8c140d717c59d80b28b6660"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"bb5aa1bf93e4531bc77e4e83205fa0a34466e3d3","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  {{ kolla_ironic_pxe_append_params_default +"},{"line_number":117,"context_line":"     kolla_ironic_pxe_append_params_extra }}"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"# List of default kernel parameters to append for baremetal boot."},{"line_number":120,"context_line":"kolla_ironic_append_params_default: \"{{ kolla_ironic_pxe_append_params_default }}\""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# List of additional kernel parameters to append for baremetal boot."}],"source_content_type":"application/octet-stream","patch_set":20,"id":"0b7575b4_8f0ddb7c","line":119,"in_reply_to":"10ee328c_1024d802","updated":"2025-09-29 15:29:31.000000000","message":"Done","commit_id":"9d03dcbd6372e55ea8c140d717c59d80b28b6660"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"3abc375ae0227cf20aadf19801bc5d57f99ecf67","unresolved":true,"context_lines":[{"line_number":116,"context_line":"  {{ kolla_ironic_pxe_append_params_default +"},{"line_number":117,"context_line":"     kolla_ironic_pxe_append_params_extra }}"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"# List of default kernel parameters to append for baremetal boot."},{"line_number":120,"context_line":"kolla_ironic_append_params_default: \"{{ kolla_ironic_pxe_append_params_default }}\""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# List of additional kernel parameters to append for baremetal boot."}],"source_content_type":"application/octet-stream","patch_set":20,"id":"10ee328c_1024d802","line":119,"in_reply_to":"82647835_f5468228","updated":"2025-09-29 13:23:59.000000000","message":"Its best to keep the old variables until we remove them in the H cycle. The deprecation notice in the comment helps inform operators of the change since it normally results in a merge conflict.","commit_id":"9d03dcbd6372e55ea8c140d717c59d80b28b6660"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"b8362c8b4db2a93f89f9f615377cc071ccc1d662","unresolved":true,"context_lines":[{"line_number":116,"context_line":"  {{ kolla_ironic_pxe_append_params_default +"},{"line_number":117,"context_line":"     kolla_ironic_pxe_append_params_extra }}"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"# List of default kernel parameters to append for baremetal boot."},{"line_number":120,"context_line":"kolla_ironic_append_params_default: \"{{ kolla_ironic_pxe_append_params_default }}\""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# List of additional kernel parameters to append for baremetal boot."}],"source_content_type":"application/octet-stream","patch_set":20,"id":"82647835_f5468228","line":119,"in_reply_to":"c008b3ff_3d5aa259","updated":"2025-09-29 12:42:17.000000000","message":"Just realised I think it should default to an empty list rather than a string.\n\ns/default(\u0027\u0027)/default([])/g","commit_id":"9d03dcbd6372e55ea8c140d717c59d80b28b6660"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"44ce1e77d65c4156b8e4a5df00bd16654db4b5f6","unresolved":true,"context_lines":[{"line_number":118,"context_line":"  - console\u003dttyS0,115200n8"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"# List of default kernel parameters to append for baremetal boot."},{"line_number":121,"context_line":"kolla_ironic_kernel_append_params_default: \"{{ kolla_ironic_pxe_append_params_default | default(kolla_ironic_kernel_append_params_default_list) }}\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# List of additional kernel parameters to append for baremetal boot."},{"line_number":124,"context_line":"kolla_ironic_kernel_append_params_extra: \"{{ kolla_ironic_pxe_append_params_extra | default([]) }}\""}],"source_content_type":"application/octet-stream","patch_set":32,"id":"e510efef_34f47187","line":121,"updated":"2025-10-13 14:08:06.000000000","message":"Not sure we need to introduce `kolla_ironic_kernel_append_params_default_list`. Seems to just make it more complicated for no real reason. When we drop `kolla_ironic_pxe_append_params_default` we will just move the defaults to `kolla_ironic_kernel_append_params_default`\n\n```suggestion\nkolla_ironic_kernel_append_params_default: \"{{ kolla_ironic_pxe_append_params_default }}\"\n```","commit_id":"cdf498dc84faceee41f5c3c5cef1d397d98d7dca"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"68a758c0c77dad8fd1f6d5ead25395de93eccaca","unresolved":true,"context_lines":[{"line_number":118,"context_line":"  - console\u003dttyS0,115200n8"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"# List of default kernel parameters to append for baremetal boot."},{"line_number":121,"context_line":"kolla_ironic_kernel_append_params_default: \"{{ kolla_ironic_pxe_append_params_default | default(kolla_ironic_kernel_append_params_default_list) }}\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# List of additional kernel parameters to append for baremetal boot."},{"line_number":124,"context_line":"kolla_ironic_kernel_append_params_extra: \"{{ kolla_ironic_pxe_append_params_extra | default([]) }}\""}],"source_content_type":"application/octet-stream","patch_set":32,"id":"ec44675f_5517af2e","line":121,"in_reply_to":"0953cc79_37fa5a54","updated":"2025-10-13 14:21:32.000000000","message":"Yes, exactly. kolla_ironic_kernel_append_params should then just use kolla_ironic_kernel_append_params_default + kolla_ironic_kernel_append_params_extra","commit_id":"cdf498dc84faceee41f5c3c5cef1d397d98d7dca"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"031ef295527a5385cf6909c8a64acf161cfcda1f","unresolved":false,"context_lines":[{"line_number":118,"context_line":"  - console\u003dttyS0,115200n8"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"# List of default kernel parameters to append for baremetal boot."},{"line_number":121,"context_line":"kolla_ironic_kernel_append_params_default: \"{{ kolla_ironic_pxe_append_params_default | default(kolla_ironic_kernel_append_params_default_list) }}\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# List of additional kernel parameters to append for baremetal boot."},{"line_number":124,"context_line":"kolla_ironic_kernel_append_params_extra: \"{{ kolla_ironic_pxe_append_params_extra | default([]) }}\""}],"source_content_type":"application/octet-stream","patch_set":32,"id":"d3ab61ed_e4b27ee9","line":121,"in_reply_to":"105437ac_0d00366e","updated":"2025-10-14 10:06:49.000000000","message":"done","commit_id":"cdf498dc84faceee41f5c3c5cef1d397d98d7dca"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"e1ed6ae6fcc411a789746da098b8d6e035f054b7","unresolved":false,"context_lines":[{"line_number":118,"context_line":"  - console\u003dttyS0,115200n8"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"# List of default kernel parameters to append for baremetal boot."},{"line_number":121,"context_line":"kolla_ironic_kernel_append_params_default: \"{{ kolla_ironic_pxe_append_params_default | default(kolla_ironic_kernel_append_params_default_list) }}\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# List of additional kernel parameters to append for baremetal boot."},{"line_number":124,"context_line":"kolla_ironic_kernel_append_params_extra: \"{{ kolla_ironic_pxe_append_params_extra | default([]) }}\""}],"source_content_type":"application/octet-stream","patch_set":32,"id":"46c2c204_4202f7e7","line":121,"in_reply_to":"33b9e983_7102bfaa","updated":"2025-10-13 15:11:36.000000000","message":"TBH, I\u0027m not sure if this is worth getting hung up on. I see the advantage is that you can check to see if the variable has been overriden and this isn\u0027t exposed to end users, so I\u0027ll mark this as resolved.","commit_id":"cdf498dc84faceee41f5c3c5cef1d397d98d7dca"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"abbfc3eb9d64a44d0d19d31dea91ac574895ea88","unresolved":true,"context_lines":[{"line_number":118,"context_line":"  - console\u003dttyS0,115200n8"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"# List of default kernel parameters to append for baremetal boot."},{"line_number":121,"context_line":"kolla_ironic_kernel_append_params_default: \"{{ kolla_ironic_pxe_append_params_default | default(kolla_ironic_kernel_append_params_default_list) }}\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# List of additional kernel parameters to append for baremetal boot."},{"line_number":124,"context_line":"kolla_ironic_kernel_append_params_extra: \"{{ kolla_ironic_pxe_append_params_extra | default([]) }}\""}],"source_content_type":"application/octet-stream","patch_set":32,"id":"505e752e_9822cd47","line":121,"in_reply_to":"46c2c204_4202f7e7","updated":"2025-10-13 16:03:48.000000000","message":"I was thinking... Would this not work better: \n\n`ansible/inventory/group_vars/all/ironic`\n\n    # List of default kernel parameters to append for baremetal PXE boot.\n    kolla_ironic_pxe_append_params_default: \"{{ kolla_ironic_kernel_append_params_default }}\"\n\n    # List of additional kernel parameters to append for baremetal PXE boot.\n    kolla_ironic_pxe_append_params_extra: \"{{ kolla_ironic_kernel_append_params_extra }}\"\n\n    # List of kernel parameters to append for baremetal PXE boot.\n    kolla_ironic_pxe_append_params: \"{{ kolla_ironic_pxe_append_params_default + kolla_ironic_pxe_append_params_extra }}\"\n\n    # List of default kernel parameters to append for baremetal boot.\n    kolla_ironic_kernel_append_params_default:\n      - nofb\n      - nomodeset\n      - vga\u003dnormal\n      - console\u003dtty0\n      - console\u003dttyS0,115200n8\n\n    # List of additional kernel parameters to append for baremetal boot.\n    kolla_ironic_kernel_append_params_extra: []\n\n    # List of kernel parameters to append for baremetal boot.\n    kolla_ironic_kernel_append_params: \"{{ kolla_ironic_kernel_append_params_default + kolla_ironic_kernel_append_params_extra }}\"\n\n\n`ansible/roles/kolla-openstack/templates/kolla/config/ironic.conf`\n\n    [redfish]\n    {% if kolla_ironic_kernel_append_params %}\n    kernel_append_params \u003d {{ kolla_ironic_kernel_append_params | join(\u0027 \u0027) }}\n    {% endif %}\n\n\n    [pxe]\n    {% if kolla_ironic_pxe_kernel_append_params %}\n    kernel_append_params \u003d {{ kolla_ironic_pxe_kernel_append_params | join(\u0027 \u0027) }}\n    {% endif %}\n\n\nThere is something quirky about `kolla_ironic_kernel_append_params_default` + `kolla_ironic_kernel_append_params_extra` not being used if `kolla_ironic_pxe_append_params` is set. Then we also don\u0027t have to remove the old variable.","commit_id":"cdf498dc84faceee41f5c3c5cef1d397d98d7dca"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"6d27bb82970b20270a42dce9c4cd30c0767f0ed1","unresolved":false,"context_lines":[{"line_number":118,"context_line":"  - console\u003dttyS0,115200n8"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"# List of default kernel parameters to append for baremetal boot."},{"line_number":121,"context_line":"kolla_ironic_kernel_append_params_default: \"{{ kolla_ironic_pxe_append_params_default | default(kolla_ironic_kernel_append_params_default_list) }}\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# List of additional kernel parameters to append for baremetal boot."},{"line_number":124,"context_line":"kolla_ironic_kernel_append_params_extra: \"{{ kolla_ironic_pxe_append_params_extra | default([]) }}\""}],"source_content_type":"application/octet-stream","patch_set":32,"id":"17959400_d06237dc","line":121,"in_reply_to":"46c2c204_4202f7e7","updated":"2025-10-13 15:54:48.000000000","message":"Yeah that was the intended functionality of the concatenated variable, though the functionality might still be the same if we made the PXE variable for defaults the contents of the new default list, though yeah it\u0027s not really worth being hung up on.","commit_id":"cdf498dc84faceee41f5c3c5cef1d397d98d7dca"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"5dac86d85e7dbea1cc397b6fa4e4d89823f43550","unresolved":true,"context_lines":[{"line_number":118,"context_line":"  - console\u003dttyS0,115200n8"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"# List of default kernel parameters to append for baremetal boot."},{"line_number":121,"context_line":"kolla_ironic_kernel_append_params_default: \"{{ kolla_ironic_pxe_append_params_default | default(kolla_ironic_kernel_append_params_default_list) }}\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# List of additional kernel parameters to append for baremetal boot."},{"line_number":124,"context_line":"kolla_ironic_kernel_append_params_extra: \"{{ kolla_ironic_pxe_append_params_extra | default([]) }}\""}],"source_content_type":"application/octet-stream","patch_set":32,"id":"105437ac_0d00366e","line":121,"in_reply_to":"505e752e_9822cd47","updated":"2025-10-13 20:52:31.000000000","message":"It\u0027s a little complicated having two different variables which are effectively the same but just for different boot interfaces, though I see the point that having the PXE variable specifically override the PXE kenrel args and not the Redfish one seems a little cleaner.","commit_id":"cdf498dc84faceee41f5c3c5cef1d397d98d7dca"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"09c819062d71daec734c7ee3b10594d0067e048c","unresolved":true,"context_lines":[{"line_number":118,"context_line":"  - console\u003dttyS0,115200n8"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"# List of default kernel parameters to append for baremetal boot."},{"line_number":121,"context_line":"kolla_ironic_kernel_append_params_default: \"{{ kolla_ironic_pxe_append_params_default | default(kolla_ironic_kernel_append_params_default_list) }}\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# List of additional kernel parameters to append for baremetal boot."},{"line_number":124,"context_line":"kolla_ironic_kernel_append_params_extra: \"{{ kolla_ironic_pxe_append_params_extra | default([]) }}\""}],"source_content_type":"application/octet-stream","patch_set":32,"id":"0953cc79_37fa5a54","line":121,"in_reply_to":"e510efef_34f47187","updated":"2025-10-13 14:17:21.000000000","message":"Maybe I\u0027m misunderstanding, but are you suggesting keeping the default arg list in the PXE variable for now?","commit_id":"cdf498dc84faceee41f5c3c5cef1d397d98d7dca"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"45221f29eef48f3193b6575070175901fc47a50a","unresolved":true,"context_lines":[{"line_number":118,"context_line":"  - console\u003dttyS0,115200n8"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"# List of default kernel parameters to append for baremetal boot."},{"line_number":121,"context_line":"kolla_ironic_kernel_append_params_default: \"{{ kolla_ironic_pxe_append_params_default | default(kolla_ironic_kernel_append_params_default_list) }}\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# List of additional kernel parameters to append for baremetal boot."},{"line_number":124,"context_line":"kolla_ironic_kernel_append_params_extra: \"{{ kolla_ironic_pxe_append_params_extra | default([]) }}\""}],"source_content_type":"application/octet-stream","patch_set":32,"id":"33b9e983_7102bfaa","line":121,"in_reply_to":"ec44675f_5517af2e","updated":"2025-10-13 14:24:42.000000000","message":"Actually,\n\nkolla_ironic_kernel_append_params: \"{{ kolla_ironic_pxe_append_params | default(kolla_ironic_kernel_append_params_default + kolla_ironic_kernel_append_params_extra) }}\"\n\nlooks good in case a user has overridden kolla_ironic_pxe_append_params","commit_id":"cdf498dc84faceee41f5c3c5cef1d397d98d7dca"}],"ansible/roles/kolla-openstack/defaults/main.yml":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"2dd58c2e196651a554251ba58b3cc88faf462c5f","unresolved":true,"context_lines":[{"line_number":551,"context_line":"kolla_ironic_provisioning_network:"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"# List of additional append parameters for baremetal PXE boot."},{"line_number":554,"context_line":"# DEPRECATED: Will remove in future release!"},{"line_number":555,"context_line":"kolla_ironic_pxe_append_params: []"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"# List of additional append parameters for baremetal boot"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"0bde0b9d_fdd7b7fa","line":554,"updated":"2025-09-11 14:54:16.000000000","message":"Could you add your name to this comment, and state when it should be removed please? This way it won\u0027t get forgotten.\n```suggestion\n# DEPRECATED. TODO(ClaudiaWatson): remove in H cycle\n```\n(H cycle might not be the right one to choose)","commit_id":"c7a91b2a1bcdaf02241c2a5e4bc5b0310150f279"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"fc160671ec19b90af5240c20efc92fabbec7c668","unresolved":false,"context_lines":[{"line_number":551,"context_line":"kolla_ironic_provisioning_network:"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"# List of additional append parameters for baremetal PXE boot."},{"line_number":554,"context_line":"# DEPRECATED: Will remove in future release!"},{"line_number":555,"context_line":"kolla_ironic_pxe_append_params: []"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"# List of additional append parameters for baremetal boot"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"f5d0cc2c_74a0adb1","line":554,"in_reply_to":"0bde0b9d_fdd7b7fa","updated":"2025-09-22 08:08:44.000000000","message":"Done","commit_id":"c7a91b2a1bcdaf02241c2a5e4bc5b0310150f279"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"5e4e49fd228db760d45270cbaa6eb797602c13c5","unresolved":true,"context_lines":[{"line_number":551,"context_line":"kolla_ironic_provisioning_network:"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"# List of additional append parameters for baremetal PXE boot."},{"line_number":554,"context_line":"# DEPRECATED: Will remove in future release!"},{"line_number":555,"context_line":"kolla_ironic_pxe_append_params: []"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"# List of additional append parameters for baremetal boot"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5c12892d_4012bf22","line":554,"updated":"2025-09-25 14:27:03.000000000","message":"Deprecate it in group_vars/all/ironic and etc/kayobe/ironic.yml (as that is the public interface) and just remove it from this role.","commit_id":"11793c6e1d4c58ebb0fb1f28e6503d4b0d60ab73"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"bb5aa1bf93e4531bc77e4e83205fa0a34466e3d3","unresolved":false,"context_lines":[{"line_number":551,"context_line":"kolla_ironic_provisioning_network:"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"# List of additional append parameters for baremetal PXE boot."},{"line_number":554,"context_line":"# DEPRECATED: Will remove in future release!"},{"line_number":555,"context_line":"kolla_ironic_pxe_append_params: []"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"# List of additional append parameters for baremetal boot"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1c07429d_5de6338a","line":554,"in_reply_to":"43c9c39e_38db5c64","updated":"2025-09-29 15:29:31.000000000","message":"Done","commit_id":"11793c6e1d4c58ebb0fb1f28e6503d4b0d60ab73"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"25010de4c721c69e8a45e65edfc7240942de5cb0","unresolved":true,"context_lines":[{"line_number":551,"context_line":"kolla_ironic_provisioning_network:"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"# List of additional append parameters for baremetal PXE boot."},{"line_number":554,"context_line":"# DEPRECATED: Will remove in future release!"},{"line_number":555,"context_line":"kolla_ironic_pxe_append_params: []"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"# List of additional append parameters for baremetal boot"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"43c9c39e_38db5c64","line":554,"in_reply_to":"567f4e4e_35a5ab26","updated":"2025-09-25 15:39:35.000000000","message":"What about with:\n\n\t[pxe]\n\t{% if kolla_ironic_append_params %}\n\tkernel_append_params \u003d {{ kolla_ironic_append_params | join(\u0027 \u0027) }}\n\t{% endif %}","commit_id":"11793c6e1d4c58ebb0fb1f28e6503d4b0d60ab73"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d3449bed9e858d6253a43c33827357217c647cc5","unresolved":true,"context_lines":[{"line_number":551,"context_line":"kolla_ironic_provisioning_network:"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"# List of additional append parameters for baremetal PXE boot."},{"line_number":554,"context_line":"# DEPRECATED: Will remove in future release!"},{"line_number":555,"context_line":"kolla_ironic_pxe_append_params: []"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"# List of additional append parameters for baremetal boot"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"ae60c163_abb35888","line":554,"in_reply_to":"5c12892d_4012bf22","updated":"2025-09-25 14:50:33.000000000","message":"Example of best practice: https://github.com/openstack/kayobe/commit/336d6382a62841a8c235c978a364ecd6fcceb469","commit_id":"11793c6e1d4c58ebb0fb1f28e6503d4b0d60ab73"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"9677db4b951db4f0c7d36209aa7fa3acc6d9b3c6","unresolved":true,"context_lines":[{"line_number":551,"context_line":"kolla_ironic_provisioning_network:"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"# List of additional append parameters for baremetal PXE boot."},{"line_number":554,"context_line":"# DEPRECATED: Will remove in future release!"},{"line_number":555,"context_line":"kolla_ironic_pxe_append_params: []"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"# List of additional append parameters for baremetal boot"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"567f4e4e_35a5ab26","line":554,"in_reply_to":"5c12892d_4012bf22","updated":"2025-09-25 14:57:15.000000000","message":"I think if I remove it from here the tox-molecule fails as it complains kolla_ironic_append_pxe_params is undefined as it\u0027s still being used in \n\n[pxe]\n{% if kolla_ironic_pxe_append_params %}\nkernel_append_params \u003d {{ kolla_ironic_pxe_append_params | join(\u0027 \u0027) }}\n{% endif %}","commit_id":"11793c6e1d4c58ebb0fb1f28e6503d4b0d60ab73"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"0b8c5f7bdb07af5566526e9de675fae0ea31370e","unresolved":true,"context_lines":[{"line_number":550,"context_line":"# Name or UUID of the Neutron network to use for provisioning."},{"line_number":551,"context_line":"kolla_ironic_provisioning_network:"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"# List of additional append parameters for baremetal boot"},{"line_number":554,"context_line":"kolla_ironic_append_params: []"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"# Deprecated:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"bcc7b04a_f7fec50d","line":553,"updated":"2025-09-29 09:59:27.000000000","message":"s/kolla_ironic_append_params/kolla_ironic_kernel_append_params/g","commit_id":"9d03dcbd6372e55ea8c140d717c59d80b28b6660"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"ed0161b10ec434438c8a2db96673b07bd4d2c056","unresolved":false,"context_lines":[{"line_number":550,"context_line":"# Name or UUID of the Neutron network to use for provisioning."},{"line_number":551,"context_line":"kolla_ironic_provisioning_network:"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"# List of additional append parameters for baremetal boot"},{"line_number":554,"context_line":"kolla_ironic_append_params: []"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"# Deprecated:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"e0d82f16_81ad3ba6","line":553,"in_reply_to":"bcc7b04a_f7fec50d","updated":"2025-09-29 15:31:15.000000000","message":"Done","commit_id":"9d03dcbd6372e55ea8c140d717c59d80b28b6660"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"46a0b5c0b3d7c71bda1f0226e1a03df0c193fec7","unresolved":true,"context_lines":[{"line_number":551,"context_line":"kolla_ironic_provisioning_network:"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"# List of additional append parameters for baremetal boot"},{"line_number":554,"context_line":"kolla_ironic_kernal_append_params: []"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"# Deprecated:"},{"line_number":557,"context_line":"# Free form extra configuration to append to ironic.conf."}],"source_content_type":"text/x-yaml","patch_set":26,"id":"bf1d8ffb_33c3b535","line":554,"updated":"2025-09-30 04:46:27.000000000","message":"s/kernal/kernel/g","commit_id":"764746566ef20ac4b4720c40c4f40a116b0ef9c1"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"d0fa017a8f85242f15c358321f06d4acab17d71a","unresolved":false,"context_lines":[{"line_number":551,"context_line":"kolla_ironic_provisioning_network:"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"# List of additional append parameters for baremetal boot"},{"line_number":554,"context_line":"kolla_ironic_kernal_append_params: []"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"# Deprecated:"},{"line_number":557,"context_line":"# Free form extra configuration to append to ironic.conf."}],"source_content_type":"text/x-yaml","patch_set":26,"id":"f6b61101_075549bf","line":554,"in_reply_to":"bf1d8ffb_33c3b535","updated":"2025-10-02 07:20:43.000000000","message":"Done","commit_id":"764746566ef20ac4b4720c40c4f40a116b0ef9c1"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"cd374db39b37ac5db434890931d2a547d78f130d","unresolved":true,"context_lines":[{"line_number":556,"context_line":"# List of additional append parameters for baremetal boot"},{"line_number":557,"context_line":"kolla_ironic_kernel_append_params: []"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"#List of additional append parameters for baremetal PXE"},{"line_number":560,"context_line":"kolla_ironic_pxe_append_params: []"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"# Deprecated:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"454c26f1_7ee91a09","line":559,"updated":"2025-10-14 19:11:53.000000000","message":"nit: baremetal PXE \u0027boot\u0027.","commit_id":"d10de00f733329dc0c8782684fc8ce6013698d46"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"c4534bd8e839410dfdefd9aaa7daf488e23e5831","unresolved":false,"context_lines":[{"line_number":556,"context_line":"# List of additional append parameters for baremetal boot"},{"line_number":557,"context_line":"kolla_ironic_kernel_append_params: []"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"#List of additional append parameters for baremetal PXE"},{"line_number":560,"context_line":"kolla_ironic_pxe_append_params: []"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"# Deprecated:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"2f05fc23_24dcd051","line":559,"in_reply_to":"454c26f1_7ee91a09","updated":"2025-10-15 08:15:51.000000000","message":"Done","commit_id":"d10de00f733329dc0c8782684fc8ce6013698d46"}],"ansible/roles/kolla-openstack/templates/kolla/config/ironic.conf":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"5e4e49fd228db760d45270cbaa6eb797602c13c5","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[pxe]"},{"line_number":32,"context_line":"{% if kolla_ironic_pxe_append_params %}"},{"line_number":33,"context_line":"kernel_append_params \u003d {{ kolla_ironic_pxe_append_params | join(\u0027 \u0027) }}"},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% raw %}"}],"source_content_type":"text/plain","patch_set":17,"id":"e0f4d4a8_059bd84f","line":33,"updated":"2025-09-25 14:27:03.000000000","message":"Should we not use: `kolla_ironic_append_params` here too since you have aliased them in inventory/group_vars/ironic? Then remove the `kolla_ironic_pxe_append_params` from this role.","commit_id":"11793c6e1d4c58ebb0fb1f28e6503d4b0d60ab73"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"9677db4b951db4f0c7d36209aa7fa3acc6d9b3c6","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[pxe]"},{"line_number":32,"context_line":"{% if kolla_ironic_pxe_append_params %}"},{"line_number":33,"context_line":"kernel_append_params \u003d {{ kolla_ironic_pxe_append_params | join(\u0027 \u0027) }}"},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% raw %}"}],"source_content_type":"text/plain","patch_set":17,"id":"584936b0_e598982c","line":33,"in_reply_to":"e0f4d4a8_059bd84f","updated":"2025-09-25 14:57:15.000000000","message":"Done","commit_id":"11793c6e1d4c58ebb0fb1f28e6503d4b0d60ab73"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"0b8c5f7bdb07af5566526e9de675fae0ea31370e","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[pxe]"},{"line_number":32,"context_line":"{% if kolla_ironic_append_params %}"},{"line_number":33,"context_line":"kernel_append_params \u003d {{ kolla_ironic_append_params | join(\u0027 \u0027) }}"},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% raw %}"}],"source_content_type":"text/plain","patch_set":20,"id":"42b6ef69_66c48b87","line":33,"updated":"2025-09-29 09:59:27.000000000","message":"s/kolla_ironic_append_params/kolla_ironic_kernel_append_params/g","commit_id":"9d03dcbd6372e55ea8c140d717c59d80b28b6660"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"ed0161b10ec434438c8a2db96673b07bd4d2c056","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[pxe]"},{"line_number":32,"context_line":"{% if kolla_ironic_append_params %}"},{"line_number":33,"context_line":"kernel_append_params \u003d {{ kolla_ironic_append_params | join(\u0027 \u0027) }}"},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% raw %}"}],"source_content_type":"text/plain","patch_set":20,"id":"0f41ba6b_359c5466","line":33,"in_reply_to":"42b6ef69_66c48b87","updated":"2025-09-29 15:31:15.000000000","message":"Done","commit_id":"9d03dcbd6372e55ea8c140d717c59d80b28b6660"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"46a0b5c0b3d7c71bda1f0226e1a03df0c193fec7","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[redfish]"},{"line_number":22,"context_line":"use_swift: false"},{"line_number":23,"context_line":"{% if kolla_ironic_kernal_append_params %}"},{"line_number":24,"context_line":"kernel_append_params \u003d {{ kolla_ironic_kernal_append_params | join(\u0027 \u0027) }}"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":""}],"source_content_type":"text/plain","patch_set":26,"id":"4d45bd36_1e739a42","line":23,"updated":"2025-09-30 04:46:27.000000000","message":"s/kernal/kernel/g","commit_id":"764746566ef20ac4b4720c40c4f40a116b0ef9c1"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"d0fa017a8f85242f15c358321f06d4acab17d71a","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[redfish]"},{"line_number":22,"context_line":"use_swift: false"},{"line_number":23,"context_line":"{% if kolla_ironic_kernal_append_params %}"},{"line_number":24,"context_line":"kernel_append_params \u003d {{ kolla_ironic_kernal_append_params | join(\u0027 \u0027) }}"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":""}],"source_content_type":"text/plain","patch_set":26,"id":"246f8fc1_2f30663f","line":23,"in_reply_to":"4d45bd36_1e739a42","updated":"2025-10-02 07:20:43.000000000","message":"Done","commit_id":"764746566ef20ac4b4720c40c4f40a116b0ef9c1"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"46a0b5c0b3d7c71bda1f0226e1a03df0c193fec7","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[pxe]"},{"line_number":32,"context_line":"{% if kolla_ironic_kernal_append_params %}"},{"line_number":33,"context_line":"kernel_append_params \u003d {{ kolla_ironic_kernal_append_params | join(\u0027 \u0027) }}"},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% raw %}"}],"source_content_type":"text/plain","patch_set":26,"id":"86b161e9_897ed26a","line":33,"updated":"2025-09-30 04:46:27.000000000","message":"s/kernal/kernel/g","commit_id":"764746566ef20ac4b4720c40c4f40a116b0ef9c1"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"d0fa017a8f85242f15c358321f06d4acab17d71a","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[pxe]"},{"line_number":32,"context_line":"{% if kolla_ironic_kernal_append_params %}"},{"line_number":33,"context_line":"kernel_append_params \u003d {{ kolla_ironic_kernal_append_params | join(\u0027 \u0027) }}"},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% raw %}"}],"source_content_type":"text/plain","patch_set":26,"id":"b63d0e45_a12d6841","line":33,"in_reply_to":"86b161e9_897ed26a","updated":"2025-10-02 07:20:43.000000000","message":"Done","commit_id":"764746566ef20ac4b4720c40c4f40a116b0ef9c1"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"5de7c31a8a219520ab6040c8054815a4f2c4e9af","unresolved":true,"context_lines":[{"line_number":19,"context_line":"deploy_logs_local_path \u003d /var/log/kolla/ironic/deploy"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[redfish]"},{"line_number":22,"context_line":"use_swift: false"},{"line_number":23,"context_line":"{% if kolla_ironic_kernel_append_params %}"},{"line_number":24,"context_line":"kernel_append_params \u003d {{ kolla_ironic_kernel_append_params | join(\u0027 \u0027) }}"},{"line_number":25,"context_line":"{% endif %}"}],"source_content_type":"text/plain","patch_set":31,"id":"9d9a4d97_6ba65528","line":22,"updated":"2025-10-10 10:30:58.000000000","message":"```suggestion\n```\nShould this be here?","commit_id":"26b33e1076232c5474a6848aafce94733be60865"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"63e4cc944883e28dcea4e4fef5e3da2d432706f5","unresolved":true,"context_lines":[{"line_number":19,"context_line":"deploy_logs_local_path \u003d /var/log/kolla/ironic/deploy"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[redfish]"},{"line_number":22,"context_line":"use_swift: false"},{"line_number":23,"context_line":"{% if kolla_ironic_kernel_append_params %}"},{"line_number":24,"context_line":"kernel_append_params \u003d {{ kolla_ironic_kernel_append_params | join(\u0027 \u0027) }}"},{"line_number":25,"context_line":"{% endif %}"}],"source_content_type":"text/plain","patch_set":31,"id":"aebcb7be_afe4e86f","line":22,"in_reply_to":"9d9a4d97_6ba65528","updated":"2025-10-10 12:56:19.000000000","message":"Ah, you mean it is off by default so it does nothing?\n\nhttps://docs.openstack.org/ironic/latest/configuration/config.html#redfish.use_swift\n\nI think it might be on because Claudia hit an issue with Ironic trying to talk to Swift in her dev env. I guess it might have been an older release where it didn\u0027t default to off. We should be able to remove it as you say.","commit_id":"26b33e1076232c5474a6848aafce94733be60865"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"9a1c5310e57108ee8954aa549178db12f60a98e4","unresolved":true,"context_lines":[{"line_number":19,"context_line":"deploy_logs_local_path \u003d /var/log/kolla/ironic/deploy"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[redfish]"},{"line_number":22,"context_line":"use_swift: false"},{"line_number":23,"context_line":"{% if kolla_ironic_kernel_append_params %}"},{"line_number":24,"context_line":"kernel_append_params \u003d {{ kolla_ironic_kernel_append_params | join(\u0027 \u0027) }}"},{"line_number":25,"context_line":"{% endif %}"}],"source_content_type":"text/plain","patch_set":31,"id":"dbe47839_896bae99","line":22,"in_reply_to":"aebcb7be_afe4e86f","updated":"2025-10-10 15:02:18.000000000","message":"I think it was due to a Zuul test failing. I\u0027ve removed it just to double check.","commit_id":"26b33e1076232c5474a6848aafce94733be60865"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"ed2eccc77adac3029ae4676fed523a9ef73661ea","unresolved":false,"context_lines":[{"line_number":19,"context_line":"deploy_logs_local_path \u003d /var/log/kolla/ironic/deploy"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[redfish]"},{"line_number":22,"context_line":"use_swift: false"},{"line_number":23,"context_line":"{% if kolla_ironic_kernel_append_params %}"},{"line_number":24,"context_line":"kernel_append_params \u003d {{ kolla_ironic_kernel_append_params | join(\u0027 \u0027) }}"},{"line_number":25,"context_line":"{% endif %}"}],"source_content_type":"text/plain","patch_set":31,"id":"8c378efe_655084b7","line":22,"in_reply_to":"dbe47839_896bae99","updated":"2025-10-13 09:11:52.000000000","message":"Done","commit_id":"26b33e1076232c5474a6848aafce94733be60865"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7abb3b1ffa6f83dc7b0077c7f07bb7d87c688932","unresolved":true,"context_lines":[{"line_number":21,"context_line":"[redfish]"},{"line_number":22,"context_line":"use_swift: false"},{"line_number":23,"context_line":"{% if kolla_ironic_kernel_append_params %}"},{"line_number":24,"context_line":"kernel_append_params \u003d {{ kolla_ironic_kernel_append_params | join(\u0027 \u0027) }}"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[neutron]"}],"source_content_type":"text/plain","patch_set":31,"id":"42c05fd1_9cd52724","line":24,"updated":"2025-10-10 13:17:20.000000000","message":"I was wondering if we might want the option of customising this separately from the PXE section, but I can\u0027t think of any reason. Ironic is adding options behind the scenes according to the driver, so I guess it\u0027s fine as-is.","commit_id":"26b33e1076232c5474a6848aafce94733be60865"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"ed2eccc77adac3029ae4676fed523a9ef73661ea","unresolved":false,"context_lines":[{"line_number":21,"context_line":"[redfish]"},{"line_number":22,"context_line":"use_swift: false"},{"line_number":23,"context_line":"{% if kolla_ironic_kernel_append_params %}"},{"line_number":24,"context_line":"kernel_append_params \u003d {{ kolla_ironic_kernel_append_params | join(\u0027 \u0027) }}"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[neutron]"}],"source_content_type":"text/plain","patch_set":31,"id":"4c4c15cc_928f4996","line":24,"in_reply_to":"42c05fd1_9cd52724","updated":"2025-10-13 09:11:52.000000000","message":"Done","commit_id":"26b33e1076232c5474a6848aafce94733be60865"}],"doc/source/configuration/reference/ironic-python-agent.rst":[{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"46a0b5c0b3d7c71bda1f0226e1a03df0c193fec7","unresolved":true,"context_lines":[{"line_number":162,"context_line":"The updated configuration is applied with ``kayobe seed service deploy``."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Overcloud Ironic can be configured with the"},{"line_number":165,"context_line":"``kolla_ironic_kernal_append_params_extra`` variable:"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":".. code-block:: yaml"},{"line_number":168,"context_line":"   :caption: ``ironic.yml``"}],"source_content_type":"text/x-rst","patch_set":26,"id":"d8c84197_c9727242","line":165,"updated":"2025-09-30 04:46:27.000000000","message":"s/kernal/kernel/g","commit_id":"764746566ef20ac4b4720c40c4f40a116b0ef9c1"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"d0fa017a8f85242f15c358321f06d4acab17d71a","unresolved":false,"context_lines":[{"line_number":162,"context_line":"The updated configuration is applied with ``kayobe seed service deploy``."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Overcloud Ironic can be configured with the"},{"line_number":165,"context_line":"``kolla_ironic_kernal_append_params_extra`` variable:"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":".. code-block:: yaml"},{"line_number":168,"context_line":"   :caption: ``ironic.yml``"}],"source_content_type":"text/x-rst","patch_set":26,"id":"31835494_9ed1119c","line":165,"in_reply_to":"d8c84197_c9727242","updated":"2025-10-02 07:20:43.000000000","message":"Done","commit_id":"764746566ef20ac4b4720c40c4f40a116b0ef9c1"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"46a0b5c0b3d7c71bda1f0226e1a03df0c193fec7","unresolved":true,"context_lines":[{"line_number":167,"context_line":".. code-block:: yaml"},{"line_number":168,"context_line":"   :caption: ``ironic.yml``"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"   kolla_ironic_kernal_append_params_extra:"},{"line_number":171,"context_line":"     - sshkey\u003d\"ssh-rsa BBA1...\""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"The updated configuration is applied with ``kayobe overcloud service deploy``."}],"source_content_type":"text/x-rst","patch_set":26,"id":"dba72d5c_3f9f8cfa","line":170,"updated":"2025-09-30 04:46:27.000000000","message":"s/kernal/kernel/g","commit_id":"764746566ef20ac4b4720c40c4f40a116b0ef9c1"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"d0fa017a8f85242f15c358321f06d4acab17d71a","unresolved":false,"context_lines":[{"line_number":167,"context_line":".. code-block:: yaml"},{"line_number":168,"context_line":"   :caption: ``ironic.yml``"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"   kolla_ironic_kernal_append_params_extra:"},{"line_number":171,"context_line":"     - sshkey\u003d\"ssh-rsa BBA1...\""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"The updated configuration is applied with ``kayobe overcloud service deploy``."}],"source_content_type":"text/x-rst","patch_set":26,"id":"d3939adb_a45ce0dc","line":170,"in_reply_to":"dba72d5c_3f9f8cfa","updated":"2025-10-02 07:20:43.000000000","message":"Done","commit_id":"764746566ef20ac4b4720c40c4f40a116b0ef9c1"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"c4534bd8e839410dfdefd9aaa7daf488e23e5831","unresolved":true,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Overcloud Ironic can be configured with the"},{"line_number":164,"context_line":"``kolla_ironic_kernel_append_params_extra`` variable:"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":".. code-block:: yaml"},{"line_number":167,"context_line":"   :caption: ``ironic.yml``"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-rst","patch_set":35,"id":"05d354e4_fa365f69","line":165,"updated":"2025-10-15 08:15:51.000000000","message":"If we are keeping both sets of variables, what\u0027s best to put here @jake@stackhpc.com ?","commit_id":"d10de00f733329dc0c8782684fc8ce6013698d46"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"db21e96334790aca807235a850e54fe727e67648","unresolved":true,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Overcloud Ironic can be configured with the"},{"line_number":164,"context_line":"``kolla_ironic_kernel_append_params_extra`` variable:"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":".. code-block:: yaml"},{"line_number":167,"context_line":"   :caption: ``ironic.yml``"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-rst","patch_set":35,"id":"4ab5bbe6_ffc8a85b","line":165,"in_reply_to":"05d354e4_fa365f69","updated":"2025-10-15 12:26:40.000000000","message":"The dynamic login could be useful in both types of boots, so it would be good to document both sets of variables here","commit_id":"d10de00f733329dc0c8782684fc8ce6013698d46"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"47095fbecf67314270e3f320c93a94f3fe714799","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Overcloud Ironic can be configured with the"},{"line_number":164,"context_line":"``kolla_ironic_kernel_append_params_extra`` variable:"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":".. code-block:: yaml"},{"line_number":167,"context_line":"   :caption: ``ironic.yml``"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-rst","patch_set":35,"id":"a5fa0c17_4cc74abe","line":165,"in_reply_to":"2f36c6e0_b192d974","updated":"2025-10-15 14:36:44.000000000","message":"Done","commit_id":"d10de00f733329dc0c8782684fc8ce6013698d46"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"c70fc4d2ad2ee576135cbe30c9b72f4a57a7c42e","unresolved":true,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Overcloud Ironic can be configured with the"},{"line_number":164,"context_line":"``kolla_ironic_kernel_append_params_extra`` variable:"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":".. code-block:: yaml"},{"line_number":167,"context_line":"   :caption: ``ironic.yml``"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-rst","patch_set":35,"id":"2f36c6e0_b192d974","line":165,"in_reply_to":"4ab5bbe6_ffc8a85b","updated":"2025-10-15 14:06:17.000000000","message":"Because the value of the PXE vars default to the kernel one we can probably just leave this as it is here.\n\nThe PXE variables are around in case someone has modified them specifically, new deployments can use both though can elect to use the PXE one, I don\u0027t think it\u0027s necessary to document the PXE one now since the new variable can do both PXE and Redfish.","commit_id":"d10de00f733329dc0c8782684fc8ce6013698d46"}],"etc/kayobe/ironic.yml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"5e4e49fd228db760d45270cbaa6eb797602c13c5","unresolved":true,"context_lines":[{"line_number":98,"context_line":"#kolla_ironic_provisioning_network:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# List of default kernel parameters to append for baremetal PXE boot."},{"line_number":101,"context_line":"#kolla_ironic_pxe_append_params_default:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# List of additional kernel parameters to append for baremetal PXE boot."},{"line_number":104,"context_line":"#kolla_ironic_pxe_append_params_extra:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9d3f6d9c_e3253c70","side":"PARENT","line":101,"updated":"2025-09-25 14:27:03.000000000","message":"I think we still want the old parameters, but with a comment marking them as deprecated. Add that comment in group_vars/all/ironic too.","commit_id":"9538f12e3fc9e3092d0e99817231a79f045c3ec6"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"9677db4b951db4f0c7d36209aa7fa3acc6d9b3c6","unresolved":false,"context_lines":[{"line_number":98,"context_line":"#kolla_ironic_provisioning_network:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# List of default kernel parameters to append for baremetal PXE boot."},{"line_number":101,"context_line":"#kolla_ironic_pxe_append_params_default:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# List of additional kernel parameters to append for baremetal PXE boot."},{"line_number":104,"context_line":"#kolla_ironic_pxe_append_params_extra:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"ec80eb21_99971695","side":"PARENT","line":101,"in_reply_to":"9d3f6d9c_e3253c70","updated":"2025-09-25 14:57:15.000000000","message":"Done","commit_id":"9538f12e3fc9e3092d0e99817231a79f045c3ec6"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"0b8c5f7bdb07af5566526e9de675fae0ea31370e","unresolved":true,"context_lines":[{"line_number":98,"context_line":"#kolla_ironic_provisioning_network:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# List of default kernel parameters to append for baremetal PXE boot."},{"line_number":101,"context_line":"# DEPRECATED. TODO(ClaudiaWatson): remove in H cycle"},{"line_number":102,"context_line":"#kolla_ironic_pxe_append_params_default:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"# List of additional kernel parameters to append for baremetal PXE boot."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"0e27b0e7_4e1b1444","line":101,"updated":"2025-09-29 09:59:27.000000000","message":"Remove these old ones I think","commit_id":"9d03dcbd6372e55ea8c140d717c59d80b28b6660"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"d0fa017a8f85242f15c358321f06d4acab17d71a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"#kolla_ironic_provisioning_network:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# List of default kernel parameters to append for baremetal PXE boot."},{"line_number":101,"context_line":"# DEPRECATED. TODO(ClaudiaWatson): remove in H cycle"},{"line_number":102,"context_line":"#kolla_ironic_pxe_append_params_default:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"# List of additional kernel parameters to append for baremetal PXE boot."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"639e9dde_5c8513fe","line":101,"in_reply_to":"0e27b0e7_4e1b1444","updated":"2025-10-02 07:20:43.000000000","message":"Done","commit_id":"9d03dcbd6372e55ea8c140d717c59d80b28b6660"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"0b8c5f7bdb07af5566526e9de675fae0ea31370e","unresolved":true,"context_lines":[{"line_number":109,"context_line":"# DEPRECATED. TODO(ClaudiaWatson): remove in H cycle"},{"line_number":110,"context_line":"#kolla_ironic_pxe_append_params:"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# List of default kernel parameters to append for baremetal boot."},{"line_number":113,"context_line":"#kolla_ironic_append_params_default:"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"# List of additional kernel parameters to append for baremetal boot."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"6e2b787a_2bbf0ed7","line":112,"updated":"2025-09-29 09:59:27.000000000","message":"s/kolla_ironic_append_params/kolla_ironic_kernel_append_params/g","commit_id":"9d03dcbd6372e55ea8c140d717c59d80b28b6660"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"bb5aa1bf93e4531bc77e4e83205fa0a34466e3d3","unresolved":false,"context_lines":[{"line_number":109,"context_line":"# DEPRECATED. TODO(ClaudiaWatson): remove in H cycle"},{"line_number":110,"context_line":"#kolla_ironic_pxe_append_params:"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# List of default kernel parameters to append for baremetal boot."},{"line_number":113,"context_line":"#kolla_ironic_append_params_default:"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"# List of additional kernel parameters to append for baremetal boot."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"d3e01d20_168fce1d","line":112,"in_reply_to":"6e2b787a_2bbf0ed7","updated":"2025-09-29 15:29:31.000000000","message":"Done","commit_id":"9d03dcbd6372e55ea8c140d717c59d80b28b6660"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"bb5aa1bf93e4531bc77e4e83205fa0a34466e3d3","unresolved":true,"context_lines":[{"line_number":97,"context_line":"# Name of the Neutron network to use for provisioning."},{"line_number":98,"context_line":"#kolla_ironic_provisioning_network:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# List of default kernel parameters to append for baremetal PXE boot."},{"line_number":101,"context_line":"#kolla_ironic_pxe_append_params_default:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# List of additional kernel parameters to append for baremetal PXE boot."}],"source_content_type":"text/x-yaml","patch_set":26,"id":"c2197d57_b0c2e595","side":"PARENT","line":100,"updated":"2025-09-29 15:29:31.000000000","message":"Please restore the old variables with the updated comments. Then this change is looking good.","commit_id":"9538f12e3fc9e3092d0e99817231a79f045c3ec6"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"d0fa017a8f85242f15c358321f06d4acab17d71a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"# Name of the Neutron network to use for provisioning."},{"line_number":98,"context_line":"#kolla_ironic_provisioning_network:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# List of default kernel parameters to append for baremetal PXE boot."},{"line_number":101,"context_line":"#kolla_ironic_pxe_append_params_default:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# List of additional kernel parameters to append for baremetal PXE boot."}],"source_content_type":"text/x-yaml","patch_set":26,"id":"4e578e10_9cf517c1","side":"PARENT","line":100,"in_reply_to":"c2197d57_b0c2e595","updated":"2025-10-02 07:20:43.000000000","message":"Done","commit_id":"9538f12e3fc9e3092d0e99817231a79f045c3ec6"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"46a0b5c0b3d7c71bda1f0226e1a03df0c193fec7","unresolved":true,"context_lines":[{"line_number":98,"context_line":"#kolla_ironic_provisioning_network:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# List of default kernel parameters to append for baremetal boot."},{"line_number":101,"context_line":"#kolla_ironic_kernal_append_params_default:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# List of additional kernel parameters to append for baremetal boot."},{"line_number":104,"context_line":"#kolla_ironic_kernal_append_params_extra:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"696534f8_e6c4701f","line":101,"updated":"2025-09-30 04:46:27.000000000","message":"s/kernal/kernel/g","commit_id":"764746566ef20ac4b4720c40c4f40a116b0ef9c1"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"d0fa017a8f85242f15c358321f06d4acab17d71a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"#kolla_ironic_provisioning_network:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# List of default kernel parameters to append for baremetal boot."},{"line_number":101,"context_line":"#kolla_ironic_kernal_append_params_default:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# List of additional kernel parameters to append for baremetal boot."},{"line_number":104,"context_line":"#kolla_ironic_kernal_append_params_extra:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"a98135d9_b8bf8d8a","line":101,"in_reply_to":"696534f8_e6c4701f","updated":"2025-10-02 07:20:43.000000000","message":"Done","commit_id":"764746566ef20ac4b4720c40c4f40a116b0ef9c1"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"721be0c45ff4f5b1b2027c8fb6d2d3e9bd180090","unresolved":true,"context_lines":[{"line_number":97,"context_line":"# Name of the Neutron network to use for provisioning."},{"line_number":98,"context_line":"#kolla_ironic_provisioning_network:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# List of default kernel parameters to append for baremetal PXE boot."},{"line_number":101,"context_line":"#kolla_ironic_pxe_append_params_default:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# List of additional kernel parameters to append for baremetal PXE boot."}],"source_content_type":"text/x-yaml","patch_set":29,"id":"129a7fe5_4734ec8a","line":100,"updated":"2025-10-03 13:53:26.000000000","message":"nit: We should still keep the \u0027deprecation\u0027 notices here similar to group_vars.","commit_id":"65b081ef124245ea98184bdb6504f585beae3ec8"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"fa435f4ce0d4e79ca9e1e973b8ec07a946a5f9f7","unresolved":false,"context_lines":[{"line_number":97,"context_line":"# Name of the Neutron network to use for provisioning."},{"line_number":98,"context_line":"#kolla_ironic_provisioning_network:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# List of default kernel parameters to append for baremetal PXE boot."},{"line_number":101,"context_line":"#kolla_ironic_pxe_append_params_default:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# List of additional kernel parameters to append for baremetal PXE boot."}],"source_content_type":"text/x-yaml","patch_set":29,"id":"90ba95cc_e376f3ab","line":100,"in_reply_to":"129a7fe5_4734ec8a","updated":"2025-10-03 14:37:37.000000000","message":"Done","commit_id":"65b081ef124245ea98184bdb6504f585beae3ec8"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"cd374db39b37ac5db434890931d2a547d78f130d","unresolved":true,"context_lines":[{"line_number":101,"context_line":"#kolla_ironic_provisioning_network:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# List of default kernel parameters to append for baremetal PXE boot."},{"line_number":104,"context_line":"# DEPRECATED. TODO(ClaudiaWatson): remove in H cycle"},{"line_number":105,"context_line":"#kolla_ironic_pxe_append_params_default:"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# List of additional kernel parameters to append for baremetal PXE boot."}],"source_content_type":"text/x-yaml","patch_set":35,"id":"75a312c3_0388b6da","line":104,"updated":"2025-10-14 19:11:53.000000000","message":"Same as above, we should remove the deprecation notice.","commit_id":"d10de00f733329dc0c8782684fc8ce6013698d46"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"c4534bd8e839410dfdefd9aaa7daf488e23e5831","unresolved":false,"context_lines":[{"line_number":101,"context_line":"#kolla_ironic_provisioning_network:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# List of default kernel parameters to append for baremetal PXE boot."},{"line_number":104,"context_line":"# DEPRECATED. TODO(ClaudiaWatson): remove in H cycle"},{"line_number":105,"context_line":"#kolla_ironic_pxe_append_params_default:"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# List of additional kernel parameters to append for baremetal PXE boot."}],"source_content_type":"text/x-yaml","patch_set":35,"id":"54a54125_050440ec","line":104,"in_reply_to":"75a312c3_0388b6da","updated":"2025-10-15 08:15:51.000000000","message":"Done","commit_id":"d10de00f733329dc0c8782684fc8ce6013698d46"}],"playbooks/kayobe-overcloud-base/overrides.yml.j2":[{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"0b8c5f7bdb07af5566526e9de675fae0ea31370e","unresolved":true,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"kolla_enable_tls_external: \"yes\""},{"line_number":53,"context_line":"kolla_enable_tls_internal: \"yes\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"kolla_ironic_append_params_extra:"},{"line_number":56,"context_line":"  - ipa-insecure\u003d1"},{"line_number":57,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3299d20d_4eda2d44","line":54,"updated":"2025-09-29 09:59:27.000000000","message":"s/kolla_ironic_append_params/kolla_ironic_kernel_append_params/g","commit_id":"9d03dcbd6372e55ea8c140d717c59d80b28b6660"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"bb5aa1bf93e4531bc77e4e83205fa0a34466e3d3","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"kolla_enable_tls_external: \"yes\""},{"line_number":53,"context_line":"kolla_enable_tls_internal: \"yes\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"kolla_ironic_append_params_extra:"},{"line_number":56,"context_line":"  - ipa-insecure\u003d1"},{"line_number":57,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"f5e956fc_6ab136dd","line":54,"in_reply_to":"3299d20d_4eda2d44","updated":"2025-09-29 15:29:31.000000000","message":"Done","commit_id":"9d03dcbd6372e55ea8c140d717c59d80b28b6660"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"46a0b5c0b3d7c71bda1f0226e1a03df0c193fec7","unresolved":true,"context_lines":[{"line_number":52,"context_line":"kolla_enable_tls_external: \"yes\""},{"line_number":53,"context_line":"kolla_enable_tls_internal: \"yes\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"kolla_ironic_kernal_append_params_extra:"},{"line_number":56,"context_line":"  - ipa-insecure\u003d1"},{"line_number":57,"context_line":"{% endif %}"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"37e6e36b_6e1dcfe2","line":55,"updated":"2025-09-30 04:46:27.000000000","message":"s/kernal/kernel/g","commit_id":"764746566ef20ac4b4720c40c4f40a116b0ef9c1"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"d0fa017a8f85242f15c358321f06d4acab17d71a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"kolla_enable_tls_external: \"yes\""},{"line_number":53,"context_line":"kolla_enable_tls_internal: \"yes\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"kolla_ironic_kernal_append_params_extra:"},{"line_number":56,"context_line":"  - ipa-insecure\u003d1"},{"line_number":57,"context_line":"{% endif %}"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"49ce8782_44d70f11","line":55,"in_reply_to":"37e6e36b_6e1dcfe2","updated":"2025-10-02 07:20:43.000000000","message":"Done","commit_id":"764746566ef20ac4b4720c40c4f40a116b0ef9c1"}],"releasenotes/notes/add-redfish-pxe-args-for-virtual-media-1446188235feaaac.yaml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b950da18e656be457cc79bb1b8f5525cf0ffff51","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for Redfish virtual media boot by using Ironic PXE variables. "}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3c3d51a3_9bf05c36","line":1,"updated":"2025-09-18 09:18:42.000000000","message":"nit: a lot of whitespace in the file","commit_id":"5565293c9fa57bdacea549201e5c0e21d08414cb"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"fc160671ec19b90af5240c20efc92fabbec7c668","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for Redfish virtual media boot by using Ironic PXE variables. "}],"source_content_type":"text/x-yaml","patch_set":12,"id":"eacc7401_052544ee","line":1,"in_reply_to":"3c3d51a3_9bf05c36","updated":"2025-09-22 08:08:44.000000000","message":"Done","commit_id":"5565293c9fa57bdacea549201e5c0e21d08414cb"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"91e15e09c73784207dd34603e71967c7d3716744","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    - kolla_ironic_pxe_append_params_default"},{"line_number":19,"context_line":"    - kolla_ironic_pxe_append_params_extra"},{"line_number":20,"context_line":"    - kolla_ironic_pxe_append_params"},{"line_number":21,"context_line":"    These variables are redefined to support Redfish virtual media while"},{"line_number":22,"context_line":"    maintaining backward compatibility with existing PXE configurations."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"d7a118cf_d004de1e","line":21,"updated":"2025-09-25 14:42:05.000000000","message":"Would be good to tell users to migrate to kolla_ironic_append_params instead. Also please improve the formatting - you can get the rendered output from the CI job e.g https://d8b9b15677b126862343-f95bdc68697ad6a891576997fb4a51ce.ssl.cf5.rackcdn.com/openstack/60407c2ee80a47e49a109238744c21be/docs/unreleased.html#deprecation-notes","commit_id":"11793c6e1d4c58ebb0fb1f28e6503d4b0d60ab73"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"bb5aa1bf93e4531bc77e4e83205fa0a34466e3d3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    - kolla_ironic_pxe_append_params_default"},{"line_number":19,"context_line":"    - kolla_ironic_pxe_append_params_extra"},{"line_number":20,"context_line":"    - kolla_ironic_pxe_append_params"},{"line_number":21,"context_line":"    These variables are redefined to support Redfish virtual media while"},{"line_number":22,"context_line":"    maintaining backward compatibility with existing PXE configurations."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9dca133e_37a9217c","line":21,"in_reply_to":"d7a118cf_d004de1e","updated":"2025-09-29 15:29:31.000000000","message":"Done","commit_id":"11793c6e1d4c58ebb0fb1f28e6503d4b0d60ab73"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"46a0b5c0b3d7c71bda1f0226e1a03df0c193fec7","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    Redfish-based boot. Migration to using"},{"line_number":7,"context_line":"    **kolla_ironic_kernal_append_params** is advised."},{"line_number":8,"context_line":"    Added Redfish boot variables are:"},{"line_number":9,"context_line":"    kolla_ironic_kernal_append_params,"},{"line_number":10,"context_line":"    kolla_ironic_kernal_append_params_default,"},{"line_number":11,"context_line":"    kolla_ironic_kernal_append_params_extra."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"e454237c_f449efbc","line":9,"updated":"2025-09-30 04:46:27.000000000","message":"s/kernal/kernel/g","commit_id":"764746566ef20ac4b4720c40c4f40a116b0ef9c1"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"d0fa017a8f85242f15c358321f06d4acab17d71a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    Redfish-based boot. Migration to using"},{"line_number":7,"context_line":"    **kolla_ironic_kernal_append_params** is advised."},{"line_number":8,"context_line":"    Added Redfish boot variables are:"},{"line_number":9,"context_line":"    kolla_ironic_kernal_append_params,"},{"line_number":10,"context_line":"    kolla_ironic_kernal_append_params_default,"},{"line_number":11,"context_line":"    kolla_ironic_kernal_append_params_extra."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"37bdb24d_d4296d79","line":9,"in_reply_to":"e454237c_f449efbc","updated":"2025-10-02 07:20:43.000000000","message":"Done","commit_id":"764746566ef20ac4b4720c40c4f40a116b0ef9c1"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"a64cbca97e38694fc20c8b1422835aeb2de0bb1f","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"deprecations:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    The following variables have been deprecated to"},{"line_number":16,"context_line":"    transition from PXE to Redfish-based boot:"},{"line_number":17,"context_line":"    kolla_ironic_pxe_append_params_default,"},{"line_number":18,"context_line":"    kolla_ironic_pxe_append_params_extra,"},{"line_number":19,"context_line":"    kolla_ironic_pxe_append_params."},{"line_number":20,"context_line":"    Migration to using **kolla_ironic_kernel_append_params**"},{"line_number":21,"context_line":"    is advised."}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1af5976c_1c711389","line":21,"range":{"start_line":15,"start_character":0,"end_line":21,"end_character":15},"updated":"2025-09-30 19:49:22.000000000","message":"Why can\u0027t we keep both methods?","commit_id":"12197a2cc9babaa86b03fb0412667b416e61480a"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"37195fea1304b1aec77b751e7e58d211aa0696aa","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"deprecations:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    The following variables have been deprecated to"},{"line_number":16,"context_line":"    transition from PXE to Redfish-based boot:"},{"line_number":17,"context_line":"    kolla_ironic_pxe_append_params_default,"},{"line_number":18,"context_line":"    kolla_ironic_pxe_append_params_extra,"},{"line_number":19,"context_line":"    kolla_ironic_pxe_append_params."},{"line_number":20,"context_line":"    Migration to using **kolla_ironic_kernel_append_params**"},{"line_number":21,"context_line":"    is advised."}],"source_content_type":"text/x-yaml","patch_set":28,"id":"475ea65e_6c1fa78b","line":21,"range":{"start_line":15,"start_character":0,"end_line":21,"end_character":15},"in_reply_to":"1af5976c_1c711389","updated":"2025-10-01 09:06:49.000000000","message":"Think the wording might be a bit off here, the new kernel arg variables still work for both PXE and Redfish boot.","commit_id":"12197a2cc9babaa86b03fb0412667b416e61480a"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"c0adb598daf3b292370ee1f69423648fb6e6f79d","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"deprecations:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    The following variables have been deprecated to"},{"line_number":16,"context_line":"    transition from PXE to Redfish-based boot:"},{"line_number":17,"context_line":"    kolla_ironic_pxe_append_params_default,"},{"line_number":18,"context_line":"    kolla_ironic_pxe_append_params_extra,"},{"line_number":19,"context_line":"    kolla_ironic_pxe_append_params."},{"line_number":20,"context_line":"    Migration to using **kolla_ironic_kernel_append_params**"},{"line_number":21,"context_line":"    is advised."}],"source_content_type":"text/x-yaml","patch_set":28,"id":"0eb88c93_1771befa","line":21,"range":{"start_line":15,"start_character":0,"end_line":21,"end_character":15},"in_reply_to":"475ea65e_6c1fa78b","updated":"2025-10-03 08:14:51.000000000","message":"Done","commit_id":"12197a2cc9babaa86b03fb0412667b416e61480a"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"cd374db39b37ac5db434890931d2a547d78f130d","unresolved":true,"context_lines":[{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    The following variables have been deprecated"},{"line_number":17,"context_line":"    for PXE boot:"},{"line_number":18,"context_line":"    kolla_ironic_pxe_append_params_default,"},{"line_number":19,"context_line":"    kolla_ironic_pxe_append_params_extra,"},{"line_number":20,"context_line":"    kolla_ironic_pxe_append_params."},{"line_number":21,"context_line":"    Migration to using"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9bc3e878_5bee6b6e","line":18,"updated":"2025-10-14 19:11:53.000000000","message":"Same as above, we should remove the deprecation notice.","commit_id":"d10de00f733329dc0c8782684fc8ce6013698d46"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"c4534bd8e839410dfdefd9aaa7daf488e23e5831","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    The following variables have been deprecated"},{"line_number":17,"context_line":"    for PXE boot:"},{"line_number":18,"context_line":"    kolla_ironic_pxe_append_params_default,"},{"line_number":19,"context_line":"    kolla_ironic_pxe_append_params_extra,"},{"line_number":20,"context_line":"    kolla_ironic_pxe_append_params."},{"line_number":21,"context_line":"    Migration to using"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"1c221671_225f6216","line":18,"in_reply_to":"9bc3e878_5bee6b6e","updated":"2025-10-15 08:15:51.000000000","message":"Done","commit_id":"d10de00f733329dc0c8782684fc8ce6013698d46"}]}