)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"cab7271076d4a2d5c90af99659e2e56c9dff5bf2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f207150b_d82adaa9","updated":"2025-10-03 08:30:31.000000000","message":"Seems to do the business:\n\n    [pxe]\n    kernel_append_params \u003d nofb nomodeset vga\u003dnormal console\u003dtty0 console\u003dttyS0,115200n8 ipa-ntp-server\u003d192.168.33.3\n\nPlease can you add a release note?","commit_id":"b7cc8c5fe9378e8afea2adb34f2f56d64b522ad0"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"ececa9ef525ce36427201db6862c7524afabab62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"53b4b237_bd462b57","in_reply_to":"f207150b_d82adaa9","updated":"2025-10-03 09:52:37.000000000","message":"added release note, please let me know what you think","commit_id":"b7cc8c5fe9378e8afea2adb34f2f56d64b522ad0"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"9478ffc27f47e73534ef40338fb72e9b128b155c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5e7113d2_7d333bad","updated":"2025-10-03 21:23:35.000000000","message":"Somehow this has been pulled out of the relation chain.\n\nCan you rebase on https://review.opendev.org/c/openstack/kayobe/+/960017?","commit_id":"e3d745f2801f60b6c262fb864f6f067748949953"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"36b1bf8846f613337f60db5af2915420cdc7d59a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"05983d21_ca1e3150","in_reply_to":"5e7113d2_7d333bad","updated":"2025-10-08 08:18:57.000000000","message":"Done","commit_id":"e3d745f2801f60b6c262fb864f6f067748949953"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"1a24cb6c2dd235459a8d753d4b50eb13433dadd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"28c2ac3a_bc1a867f","updated":"2025-10-10 12:49:35.000000000","message":"I can see this works, providing there is an NTP server on the controllers.\n\nI\u0027m wondering what has happened to this effort:\n\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/893031\n\nAny thoughts @jake@stackhpc.com? I think it is better off in Kolla Ansible.","commit_id":"f0ebbd5afe1b97200d04056946e5cab341deb567"},{"author":{"_account_id":36238,"name":"Hollie Hutchinson","display_name":"Hollie Hutchinson","email":"hollie@stackhpc.com","username":"assumptions"},"change_message_id":"008725b154e9d31051d94233bf3471d256e699b0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f627d212_9866d6e5","in_reply_to":"261c4c6d_8b615291","updated":"2025-10-13 13:02:32.000000000","message":"My concern is that if we push this into Kolla-Ansible we\u0027ll hit similar pushback that we had with this patch https://review.opendev.org/c/openstack/kolla-ansible/+/893031.\n\nWe have an NTP server in Kayobe, so we don\u0027t need to go through the faff of having to check if it already exists here, we can just include it in our default configuration and it seems cleaner that way.","commit_id":"f0ebbd5afe1b97200d04056946e5cab341deb567"},{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"46c3104cc39cdd05c5b17b80487e330fd15ae23b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"261c4c6d_8b615291","in_reply_to":"28c2ac3a_bc1a867f","updated":"2025-10-13 09:18:33.000000000","message":"@jake@stackhpc.com","commit_id":"f0ebbd5afe1b97200d04056946e5cab341deb567"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"f7eb573cfdafb717ef924b9f5e477e2c3489bfac","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"69a97a81_321989f2","in_reply_to":"2c3479a2_3ceb6f12","updated":"2025-10-14 10:23:50.000000000","message":"*overriden","commit_id":"f0ebbd5afe1b97200d04056946e5cab341deb567"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"9191661ba5af0eb098d170c684ae911a8dfb99ed","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2c3479a2_3ceb6f12","in_reply_to":"321a6c62_8e6557dd","updated":"2025-10-14 10:22:42.000000000","message":"It\u0027s OK that on CI nodes are able to access NTP servers on controllers, but for some production deployments, nodes may be provisioned in a separate VLAN, for example, with their own NTP server (e.g., the IP address of a gateway on the PXE VLAN). Therefore, hardcoding this into the default settings is not a good idea. Let\u0027s create a ``kolla-ironic-kernel-append-params-extra-list``, for example, which can be easily overwritten.","commit_id":"f0ebbd5afe1b97200d04056946e5cab341deb567"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"031464324dd6b61379d790a4165246ab5da17992","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7fa14056_9611abbe","in_reply_to":"69a97a81_321989f2","updated":"2025-10-15 12:13:17.000000000","message":"I agree with Maksim here, it seems a shame to hardcode this value. However, we do already have `kolla_ironic_kernel_append_params_extra` for adding more values, so I wouldn\u0027t suggest we add another list. Could we instead make the IPA NTP server itself configurable? Something like:\n\n```\n# List of default kernel parameters\nkolla_ironic_kernel_append_params_default_list:\n  - nofb\n  - nomodeset\n  - vga\u003dnormal\n  - console\u003dtty0\n  - console\u003dttyS0,115200n8\n  - ipa-ntp-server\u003d{{ kolla_ironic_kernel_append_ipa_ntp_server }}\n\nkolla_ironic_kernel_append_ipa_ntp_server: {% raw %}{{ hostvars[inventory_hostname].ansible_facts[api_interface | replace(\u0027-\u0027, \u0027_\u0027)][\u0027ipv4\u0027][\u0027address\u0027] }}{% endraw %}\n\n```\n\n(Not sure if that exact code will work fwiw)","commit_id":"f0ebbd5afe1b97200d04056946e5cab341deb567"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"d5ff0ffc5cade7d2713409e5e269ca53ff960ff9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"563aa0cd_3b522c48","in_reply_to":"7fa14056_9611abbe","updated":"2025-10-15 12:46:50.000000000","message":"Thanks @mattc @stackhpc com, this is another way to solve the issue I described above.","commit_id":"f0ebbd5afe1b97200d04056946e5cab341deb567"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"463e68651e0c533956997242f5e100605da2e7e2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"321a6c62_8e6557dd","in_reply_to":"f627d212_9866d6e5","updated":"2025-10-13 15:25:43.000000000","message":"We could always switch to the kolla variables at a later date if that patch gets merged? Using the kayobe configured timeservers does sound like a sane default for us.","commit_id":"f0ebbd5afe1b97200d04056946e5cab341deb567"}],"ansible/inventory/group_vars/all/ironic":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1fcafeabe0494b14b6e7b3687efb9851aa2f1c5d","unresolved":true,"context_lines":[{"line_number":116,"context_line":"  - vga\u003dnormal"},{"line_number":117,"context_line":"  - console\u003dtty0"},{"line_number":118,"context_line":"  - console\u003dttyS0,115200n8"},{"line_number":119,"context_line":"  - ipa-ntp-server\u003d{% raw %}{{ hostvars[inventory_hostname].ansible_facts[api_interface | replace(\u0027-\u0027, \u0027_\u0027)][\u0027ipv4\u0027][\u0027address\u0027] }}{% endraw %}"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"# List of default kernel parameters to append for baremetal boot."},{"line_number":122,"context_line":"kolla_ironic_kernel_append_params_default: \"{{ kolla_ironic_pxe_append_params_default | default(kolla_ironic_kernel_append_params_default_list) }}\""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"ead79bbd_8a95bcaf","line":119,"range":{"start_line":119,"start_character":2,"end_line":119,"end_character":142},"updated":"2025-10-10 13:15:27.000000000","message":"looks like some kind of hack and hardcode. what if I want to force use the external source? this way I need to override the all ``kolla_ironic_kernel_append_params_default_list``.","commit_id":"f0ebbd5afe1b97200d04056946e5cab341deb567"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"ec7fe46e9a5304c8b80752ce5aab699c5dcdb015","unresolved":true,"context_lines":[{"line_number":116,"context_line":"  - vga\u003dnormal"},{"line_number":117,"context_line":"  - console\u003dtty0"},{"line_number":118,"context_line":"  - console\u003dttyS0,115200n8"},{"line_number":119,"context_line":"  - ipa-ntp-server\u003d{% raw %}{{ hostvars[inventory_hostname].ansible_facts[api_interface | replace(\u0027-\u0027, \u0027_\u0027)][\u0027ipv4\u0027][\u0027address\u0027] }}{% endraw %}"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"# List of default kernel parameters to append for baremetal boot."},{"line_number":122,"context_line":"kolla_ironic_kernel_append_params_default: \"{{ kolla_ironic_pxe_append_params_default | default(kolla_ironic_kernel_append_params_default_list) }}\""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"50fc4638_2d985b9c","line":119,"range":{"start_line":119,"start_character":2,"end_line":119,"end_character":142},"in_reply_to":"38f308b8_ecb876c9","updated":"2025-11-17 16:33:21.000000000","message":"Fair enough, worth noting that we should probably set:\n\n    ironic_dnsmasq_dhcp_ranges:\n      ntp_server: \"IP of chrony\"\n\nfor auto discovery too. As we override the values kolla sets for kernel_append_params we will either still need this change or to stop templating out kernel_append_params and adopt the defaults from kolla (preferred, but do we lose anything).","commit_id":"f0ebbd5afe1b97200d04056946e5cab341deb567"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"0510c7730bf801d8949efdc46ae95b5ad9545a33","unresolved":true,"context_lines":[{"line_number":116,"context_line":"  - vga\u003dnormal"},{"line_number":117,"context_line":"  - console\u003dtty0"},{"line_number":118,"context_line":"  - console\u003dttyS0,115200n8"},{"line_number":119,"context_line":"  - ipa-ntp-server\u003d{% raw %}{{ hostvars[inventory_hostname].ansible_facts[api_interface | replace(\u0027-\u0027, \u0027_\u0027)][\u0027ipv4\u0027][\u0027address\u0027] }}{% endraw %}"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"# List of default kernel parameters to append for baremetal boot."},{"line_number":122,"context_line":"kolla_ironic_kernel_append_params_default: \"{{ kolla_ironic_pxe_append_params_default | default(kolla_ironic_kernel_append_params_default_list) }}\""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"38f308b8_ecb876c9","line":119,"range":{"start_line":119,"start_character":2,"end_line":119,"end_character":142},"in_reply_to":"46bf4042_11046e9c","updated":"2025-11-17 15:45:01.000000000","message":"I keep getting side-tracked, but I\u0027m going to push an update to Hollie\u0027s patch in KA. In KA, I will propose no default, and the default here to be chrony, but allow it be overridable.","commit_id":"f0ebbd5afe1b97200d04056946e5cab341deb567"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"2cd9cde4c277e648110b0837ce40d163e0e6d6a4","unresolved":true,"context_lines":[{"line_number":116,"context_line":"  - vga\u003dnormal"},{"line_number":117,"context_line":"  - console\u003dtty0"},{"line_number":118,"context_line":"  - console\u003dttyS0,115200n8"},{"line_number":119,"context_line":"  - ipa-ntp-server\u003d{% raw %}{{ hostvars[inventory_hostname].ansible_facts[api_interface | replace(\u0027-\u0027, \u0027_\u0027)][\u0027ipv4\u0027][\u0027address\u0027] }}{% endraw %}"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"# List of default kernel parameters to append for baremetal boot."},{"line_number":122,"context_line":"kolla_ironic_kernel_append_params_default: \"{{ kolla_ironic_pxe_append_params_default | default(kolla_ironic_kernel_append_params_default_list) }}\""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"46bf4042_11046e9c","line":119,"range":{"start_line":119,"start_character":2,"end_line":119,"end_character":142},"in_reply_to":"7d47774c_dfef7342","updated":"2025-11-17 15:12:20.000000000","message":"\u003e kind of hack \n\nThis isn\u0027t a bad default since kayobe configures chrony to listen on private IP ranges:\n\nhttps://github.com/mrlesmithjr/ansible-chrony/blob/master/defaults/main.yml#L6\n\nand you need to be able to post back data to Ironic, so that network should be routable from your provisioning/inspection/cleaning networks. \n\nIt might be slightly cleaner if we used kolla_overcloud_inventory_pass_through_host_vars and kayobe variables and filters to set it.\n\nI think adding a variable to override it would be a good idea. I\u0027m not sure ntp_server exists in K-A and whether or not this would be a good default for ironic nodes which might not be able to route to that network.","commit_id":"f0ebbd5afe1b97200d04056946e5cab341deb567"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"484571e81332d20fe08f6fb14eec0657fc49b01b","unresolved":true,"context_lines":[{"line_number":116,"context_line":"  - vga\u003dnormal"},{"line_number":117,"context_line":"  - console\u003dtty0"},{"line_number":118,"context_line":"  - console\u003dttyS0,115200n8"},{"line_number":119,"context_line":"  - ipa-ntp-server\u003d{% raw %}{{ hostvars[inventory_hostname].ansible_facts[api_interface | replace(\u0027-\u0027, \u0027_\u0027)][\u0027ipv4\u0027][\u0027address\u0027] }}{% endraw %}"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"# List of default kernel parameters to append for baremetal boot."},{"line_number":122,"context_line":"kolla_ironic_kernel_append_params_default: \"{{ kolla_ironic_pxe_append_params_default | default(kolla_ironic_kernel_append_params_default_list) }}\""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"7d47774c_dfef7342","line":119,"range":{"start_line":119,"start_character":2,"end_line":119,"end_character":142},"in_reply_to":"ead79bbd_8a95bcaf","updated":"2025-10-20 11:39:53.000000000","message":"We could simply default this to `ntp_server` from KA, and then if that\u0027s not set, use the local service?","commit_id":"f0ebbd5afe1b97200d04056946e5cab341deb567"}]}