)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4f5808e586b65cd6213e707a5aea61e6a6744a3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a722a17e_aeca8ab8","updated":"2025-11-26 19:42:51.000000000","message":"How does a seed host not have networks? Strange. Anyway, LGTM","commit_id":"e3f9d518f938c94375a922b0f549f5bb87eca22d"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"ebbc6d3eeb859652501249f411a2e950720bacda","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ca3bb081_e8b0fe73","updated":"2025-11-27 10:55:42.000000000","message":"Any chance of a reno?","commit_id":"c59e26189f8eb94c55f46aab30208204d0d5bbd0"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"3f3141956238f194a475346c948edf7881a5d4a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2ef6df01_70d3c146","in_reply_to":"2999aabb_24137024","updated":"2025-11-28 11:26:10.000000000","message":"not at the moment, but I\u0027ll take a look in SPARE MOMENT 😊","commit_id":"c59e26189f8eb94c55f46aab30208204d0d5bbd0"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"73eb4b4391a8f056a5bc59051d73f0eff7aaa448","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2454f844_a648ab44","in_reply_to":"2ef6df01_70d3c146","updated":"2025-11-28 11:49:16.000000000","message":"I think we should have release notes for important bug fixes. Maybe this one is minor enough to skip.","commit_id":"c59e26189f8eb94c55f46aab30208204d0d5bbd0"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"25960821454528bcfd38481747a0db083ec45493","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e1bfb32a_92dbc9bf","in_reply_to":"3bca6cb8_d69b5005","updated":"2025-11-28 11:02:03.000000000","message":"I guess if that is a kolla wide decision, I\u0027m happy to go with it. I think the release notes are pretty handy though.","commit_id":"c59e26189f8eb94c55f46aab30208204d0d5bbd0"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"9a6b64ef253fcff1ed9a1dac0cf8d3c3a3b114d4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3bca6cb8_d69b5005","in_reply_to":"ca3bb081_e8b0fe73","updated":"2025-11-27 11:02:16.000000000","message":"I think we agreed that when there is bug report, reno is not needed","commit_id":"c59e26189f8eb94c55f46aab30208204d0d5bbd0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1a1931742d26a0951bc616a302581fde90f3221d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2999aabb_24137024","in_reply_to":"e1bfb32a_92dbc9bf","updated":"2025-11-28 11:23:12.000000000","message":"We should update the docs - @bartosz@stackhpc.com you had something in progress?","commit_id":"c59e26189f8eb94c55f46aab30208204d0d5bbd0"}],"ansible/network-connectivity.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"07ca33384413fd41158ed0ec88f81ed912f4eb8a","unresolved":true,"context_lines":[{"line_number":69,"context_line":"        ping {{ remote_ip }} -c1 -M do {% if mtu %} -s {{ mtu | int - icmp_overhead_bytes }}{% endif %}"},{"line_number":70,"context_line":"      with_items: \"{{ network_interfaces }}\""},{"line_number":71,"context_line":"      loop_control:"},{"line_number":72,"context_line":"        label: \"{{ remote_host }} on {{ item }}\""},{"line_number":73,"context_line":"      when:"},{"line_number":74,"context_line":"        - remote_hosts | length \u003e 0"},{"line_number":75,"context_line":"        - remote_ip | length \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1ae3e17a_f242fed9","line":72,"updated":"2025-11-26 19:51:30.000000000","message":"Won’t the loop control label now look weird when remote_host is ’’?","commit_id":"e3f9d518f938c94375a922b0f549f5bb87eca22d"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"cc497a1db35c9a8a4f436ab3d48327fc7e8b3174","unresolved":true,"context_lines":[{"line_number":69,"context_line":"        ping {{ remote_ip }} -c1 -M do {% if mtu %} -s {{ mtu | int - icmp_overhead_bytes }}{% endif %}"},{"line_number":70,"context_line":"      with_items: \"{{ network_interfaces }}\""},{"line_number":71,"context_line":"      loop_control:"},{"line_number":72,"context_line":"        label: \"{{ remote_host }} on {{ item }}\""},{"line_number":73,"context_line":"      when:"},{"line_number":74,"context_line":"        - remote_hosts | length \u003e 0"},{"line_number":75,"context_line":"        - remote_ip | length \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9d2cad8c_a59d1f05","line":72,"in_reply_to":"1ae3e17a_f242fed9","updated":"2025-11-26 20:08:49.000000000","message":"it kind of does, but it is not blowing up, we can some guard to the label though, I tested it:\n\nBAD RUN WITHOUT FIX:\n\nTASK [Ensure hosts on the same network are reachable] *************************************************************************************************************************************\nWednesday 26 November 2025  20:01:50 +0000 (0:00:00.014)       0:00:04.225 ****\nok: [ctrl-02] \u003d\u003e (item\u003dos-seed on admin_oc_net)\nok: [os-seed] \u003d\u003e (item\u003dceph-01 on admin_oc_net)\nok: [ctrl-03] \u003d\u003e (item\u003dos-seed on admin_oc_net)\nok: [ctrl-01] \u003d\u003e (item\u003dos-seed on admin_oc_net)\nok: [ceph-01] \u003d\u003e (item\u003dos-seed on admin_oc_net)\nok: [ceph-02] \u003d\u003e (item\u003dos-seed on admin_oc_net)\nok: [ceph-04] \u003d\u003e (item\u003dos-seed on admin_oc_net)\nfatal: [os-seed]: FAILED! \u003d\u003e\n    msg: \u0027An unhandled exception occurred while templating \u0027\u0027{{ remote_hosts | random(seed\u003dansible_facts.date_time.iso8601)\n        }}\u0027\u0027. Error was a \u003cclass \u0027\u0027IndexError\u0027\u0027\u003e, original message: Cannot choose from\n        an empty sequence\u0027\n\n\nGOOD RUN WITH FIX:\n\nTASK [Ensure hosts on the same network are reachable] *************************************************************************************************************************************\nWednesday 26 November 2025  20:02:42 +0000 (0:00:00.013)       0:00:04.080 ****\nok: [os-seed] \u003d\u003e (item\u003dctrl-03 on admin_oc_net)\nok: [ctrl-02] \u003d\u003e (item\u003dctrl-03 on admin_oc_net)\nok: [ceph-02] \u003d\u003e (item\u003dceph-03 on admin_oc_net)\nok: [ceph-01] \u003d\u003e (item\u003dctrl-03 on admin_oc_net)\nok: [ceph-03] \u003d\u003e (item\u003dctrl-03 on admin_oc_net)\nok: [ceph-04] \u003d\u003e (item\u003dctrl-03 on admin_oc_net)\nskipping: [os-seed] \u003d\u003e (item\u003d on oob_oc_net)\nskipping: [os-seed] \u003d\u003e (item\u003d on provision_oc_net)\n\n\nGOOD RUN WITH FIX AND additional label guard:    label: \"{{ remote_host | default(\u0027none\u0027, true) }} on {{ item }}\"\n\nTASK [Ensure hosts on the same network are reachable] *************************************************************************************************************************************\nWednesday 26 November 2025  20:06:40 +0000 (0:00:00.014)       0:00:04.073 ****\nok: [os-seed] \u003d\u003e (item\u003dctrl-02 on admin_oc_net)\nok: [ctrl-01] \u003d\u003e (item\u003dctrl-02 on admin_oc_net)\nok: [ctrl-02] \u003d\u003e (item\u003dctrl-01 on admin_oc_net)\nok: [ctrl-03] \u003d\u003e (item\u003dctrl-01 on admin_oc_net)\nok: [ceph-01] \u003d\u003e (item\u003dctrl-02 on admin_oc_net)\nok: [ceph-02] \u003d\u003e (item\u003dctrl-02 on admin_oc_net)\nok: [ceph-03] \u003d\u003e (item\u003dctrl-02 on admin_oc_net)\nok: [ceph-04] \u003d\u003e (item\u003dctrl-02 on admin_oc_net)\nskipping: [os-seed] \u003d\u003e (item\u003dnone on oob_oc_net)\nskipping: [os-seed] \u003d\u003e (item\u003dnone on provision_oc_net)","commit_id":"e3f9d518f938c94375a922b0f549f5bb87eca22d"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"b55b84046601457f91f1f58fcea4f119cf2a4d1a","unresolved":true,"context_lines":[{"line_number":69,"context_line":"        ping {{ remote_ip }} -c1 -M do {% if mtu %} -s {{ mtu | int - icmp_overhead_bytes }}{% endif %}"},{"line_number":70,"context_line":"      with_items: \"{{ network_interfaces }}\""},{"line_number":71,"context_line":"      loop_control:"},{"line_number":72,"context_line":"        label: \"{{ remote_host }} on {{ item }}\""},{"line_number":73,"context_line":"      when:"},{"line_number":74,"context_line":"        - remote_hosts | length \u003e 0"},{"line_number":75,"context_line":"        - remote_ip | length \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e34dcd1b_542890c7","line":72,"in_reply_to":"9d2cad8c_a59d1f05","updated":"2025-11-26 20:11:19.000000000","message":"I guess none is better than \u0027\u0027","commit_id":"e3f9d518f938c94375a922b0f549f5bb87eca22d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1a1931742d26a0951bc616a302581fde90f3221d","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        ping {{ remote_ip }} -c1 -M do {% if mtu %} -s {{ mtu | int - icmp_overhead_bytes }}{% endif %}"},{"line_number":70,"context_line":"      with_items: \"{{ network_interfaces }}\""},{"line_number":71,"context_line":"      loop_control:"},{"line_number":72,"context_line":"        label: \"{{ remote_host }} on {{ item }}\""},{"line_number":73,"context_line":"      when:"},{"line_number":74,"context_line":"        - remote_hosts | length \u003e 0"},{"line_number":75,"context_line":"        - remote_ip | length \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a151b6e3_69d59560","line":72,"in_reply_to":"e34dcd1b_542890c7","updated":"2025-11-28 11:23:12.000000000","message":"Done","commit_id":"e3f9d518f938c94375a922b0f549f5bb87eca22d"}]}