)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36781,"name":"Massimiliano Favaro-Bedford","display_name":"Max","email":"max@stackhpc.com","username":"MaxBed4d"},"change_message_id":"dd34aa903bb15d9a048a701b770a1484d9131543","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cb5996db_897145a8","updated":"2026-01-02 13:31:45.000000000","message":"Need to add check for available memory and whether deleting swap is permitted.","commit_id":"569216be992acf75d0ca3db4e174ac386454573a"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"13b305b59f48296e1ddb7daaaa8a794cf4de4540","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"47e0dfd5_0a804349","updated":"2026-01-02 16:22:26.000000000","message":"Two points:\n\n1. Needs some docs\n\n2. Generally, I think we should take a different approach. I\u0027d rather add a field to each swap dict specifying ``state`` either ``present`` or ``absent`` (defaulting to present). That gives the operator much finer control and doesn\u0027t rely so much on having everything in kayobe-config, but still lets you remove swap files.\n\nIt\u0027s a pattern we use all thorough kayobe and for good reason.","commit_id":"569216be992acf75d0ca3db4e174ac386454573a"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"dad7aebad9fef4552d5a220b371ea53dc9bdf767","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c99b2487_8e4bb5c8","in_reply_to":"47e0dfd5_0a804349","updated":"2026-01-27 14:59:04.000000000","message":"Would be nice if it worked with dry run so you could at least check what you were removing before running it. You need to be quite careful about removing the swap as the data in the swap could be moved to ram and cause an OOM event, so you probably want to make the user explicitly allow swap removal.","commit_id":"569216be992acf75d0ca3db4e174ac386454573a"}],"ansible/roles/swap/tasks/main.yml":[{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"13b305b59f48296e1ddb7daaaa8a794cf4de4540","unresolved":true,"context_lines":[{"line_number":110,"context_line":"  set_fact:"},{"line_number":111,"context_line":"    configured_swap_paths: \"{{ swap | selectattr(\u0027path\u0027,\u0027defined\u0027) | map(attribute\u003d\u0027path\u0027) | list }}\""},{"line_number":112,"context_line":"    configured_swap_devices: \"{{ swap | selectattr(\u0027device\u0027,\u0027defined\u0027) | map(attribute\u003d\u0027device\u0027) | list }}\""},{"line_number":113,"context_line":"  when: kayobe_swap_conf_only | default(false)"},{"line_number":114,"context_line":"  changed_when: true"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"- name: Check if swap memory is being removed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0a423a77_0d6768be","line":113,"updated":"2026-01-02 16:22:26.000000000","message":"Default should be in ansible/roles/swap/defaults/main.yml\n\nWould also need a default in https://opendev.org/openstack/kayobe-config","commit_id":"569216be992acf75d0ca3db4e174ac386454573a"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"13b305b59f48296e1ddb7daaaa8a794cf4de4540","unresolved":true,"context_lines":[{"line_number":111,"context_line":"    configured_swap_paths: \"{{ swap | selectattr(\u0027path\u0027,\u0027defined\u0027) | map(attribute\u003d\u0027path\u0027) | list }}\""},{"line_number":112,"context_line":"    configured_swap_devices: \"{{ swap | selectattr(\u0027device\u0027,\u0027defined\u0027) | map(attribute\u003d\u0027device\u0027) | list }}\""},{"line_number":113,"context_line":"  when: kayobe_swap_conf_only | default(false)"},{"line_number":114,"context_line":"  changed_when: true"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"- name: Check if swap memory is being removed"},{"line_number":117,"context_line":"  ansible.builtin.debug:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ad80deee_841a12df","line":114,"updated":"2026-01-02 16:22:26.000000000","message":"Setting a fact isn\u0027t changing anything\n```suggestion\n  changed_when: false\n```","commit_id":"569216be992acf75d0ca3db4e174ac386454573a"}],"releasenotes/notes/auto-swap-mem-removal-37ee97515a4c48ef.yaml":[{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"13b305b59f48296e1ddb7daaaa8a794cf4de4540","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    necessarily reflect the actual state of the swap memory configured on"},{"line_number":6,"context_line":"    a given host."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    Addition of a boolean variable ``kayobe_swap_conf_only`` which, if"},{"line_number":9,"context_line":"    set to ``true``, will attempt to make the swap memory on the target"},{"line_number":10,"context_line":"    host reflect ONLY what is defined in the kayobe configuration, making"},{"line_number":11,"context_line":"    it the single source of truth. This means that any configured swap"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"79acb606_dad4ef5b","line":8,"updated":"2026-01-02 16:22:26.000000000","message":"```suggestion\n    Added a boolean variable ``kayobe_swap_conf_only`` which, if\n```","commit_id":"569216be992acf75d0ca3db4e174ac386454573a"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"13b305b59f48296e1ddb7daaaa8a794cf4de4540","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    a given host."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    Addition of a boolean variable ``kayobe_swap_conf_only`` which, if"},{"line_number":9,"context_line":"    set to ``true``, will attempt to make the swap memory on the target"},{"line_number":10,"context_line":"    host reflect ONLY what is defined in the kayobe configuration, making"},{"line_number":11,"context_line":"    it the single source of truth. This means that any configured swap"},{"line_number":12,"context_line":"    memory found on a target host which isn\u0027t defined in the kayobe"},{"line_number":13,"context_line":"    configuration will be removed."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d8cc5ad9_ed8f9a26","line":11,"range":{"start_line":9,"start_character":4,"end_line":11,"end_character":33},"updated":"2026-01-02 16:22:26.000000000","message":"Repeated content\n```suggestion\n    set to ``true``, will make the Kayobe configuration the\n    the single source of truth. This means that any configured swap\n```","commit_id":"569216be992acf75d0ca3db4e174ac386454573a"}]}