)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"c579929f90f10777ae9d258d4c9ae4690e58cc36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b563e104_07a65fb6","updated":"2026-04-30 17:14:35.000000000","message":"So I think:\n\n- nmstate already deals with this\n- systemd-networkd role has cleanup builtin\n- Only rigart doesn\u0027t clean up old config\n\nIt does seem like we just need to add something to the rigart role to bring it inline.","commit_id":"24bae3a4747906efe8ffed946ac28ec220c89306"}],"ansible/roles/network-debian/tasks/main.yml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"9c91a034248864b008c7a047b5a482aa77120e18","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    systemd_networkd_apply_config: true"},{"line_number":41,"context_line":"    systemd_networkd_enable_resolved: false"},{"line_number":42,"context_line":"    systemd_networkd_symlink_resolv_conf: false"},{"line_number":43,"context_line":"    systemd_networkd_cleanup: true"},{"line_number":44,"context_line":"    systemd_networkd_cleanup_patterns:"},{"line_number":45,"context_line":"      - \"{{ networkd_prefix }}*\""},{"line_number":46,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6478dcc1_04ace1f4","line":43,"updated":"2026-04-30 17:11:14.000000000","message":"Role already has cleanup: https://github.com/stackhpc/ansible-collection-linux/tree/main/roles/systemd_networkd/tasks#L13-L25","commit_id":"24bae3a4747906efe8ffed946ac28ec220c89306"}],"ansible/roles/network-redhat/tasks/main.yml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"9c91a034248864b008c7a047b5a482aa77120e18","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    daemon_reload: yes"},{"line_number":30,"context_line":"  when: dns_config_task is changed"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- block:"},{"line_number":33,"context_line":"    - name: Remove orphan network-scripts configuration if exists"},{"line_number":34,"context_line":"      file:"},{"line_number":35,"context_line":"        path: \"/etc/sysconfig/network-scripts/ifcfg-{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0f267c38_00e6e173","line":32,"updated":"2026-04-30 17:11:14.000000000","message":"Probably better done in the role:\n\nhttps://github.com/michaelrigart/ansible-role-interfaces/blob/master/defaults/main.yml#L12-L15","commit_id":"24bae3a4747906efe8ffed946ac28ec220c89306"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"9c91a034248864b008c7a047b5a482aa77120e18","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        state: absent"},{"line_number":47,"context_line":"      loop: \"{{ interfaces_cleanup }}\""},{"line_number":48,"context_line":"    - name: Remove orphan interfaces from the system"},{"line_number":49,"context_line":"      command: \"ip link delete {{ item }}\""},{"line_number":50,"context_line":"      loop: \"{{ interfaces_cleanup }}\""},{"line_number":51,"context_line":"      failed_when: false"},{"line_number":52,"context_line":"      changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d555f1e2_2850649b","line":49,"updated":"2026-04-30 17:11:14.000000000","message":"This is problematic when moving interface that we are using to connect","commit_id":"24bae3a4747906efe8ffed946ac28ec220c89306"}]}
