)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"5f9bdc07ae688cc4f30d2c43c656e49357cfd6c9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d82fbebf_d995441a","updated":"2026-06-11 08:08:10.000000000","message":"Lets harden the lookup and add reno, since we are changing a default.\nAfter that LGTM.","commit_id":"55962275355a1e2aa62a6dcf156599e3134187c3"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"8028707a19b19670248838a149e05d516a9397d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f3e3fb8_da175ecd","updated":"2026-06-08 14:45:57.000000000","message":"Thanks, your patch looks good.\n\nCI failures are unrelated, being fixed via KA here: https://review.opendev.org/c/openstack/kolla-ansible/+/992020","commit_id":"55962275355a1e2aa62a6dcf156599e3134187c3"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"677d50a794dd6c4d066c59c9b6e00ff68ba02236","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d0e9ce1d_0d4046e0","updated":"2026-06-18 08:44:33.000000000","message":"Thank you for the contribution. Any chance you could also generate a release notes for it ?\n\nThis will be helpful if you are unfamiliar with the process:\nhttps://docs.openstack.org/kayobe/latest/contributor/release-notes.html#release-notes","commit_id":"17a6ec5d9f63c7f09276c4749eae9cbb8db9247c"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"409c460361622c9432a62f39d2b340dc876f87ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8f4bb6fb_bccebeff","updated":"2026-06-18 08:42:27.000000000","message":"recheck - post failures","commit_id":"17a6ec5d9f63c7f09276c4749eae9cbb8db9247c"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"524c278748e590c0895501df879f147466f12c30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"60fdac46_49a34b86","updated":"2026-07-15 17:30:48.000000000","message":"recheck","commit_id":"d91f7e3b468becafb40868f45a59d5281722e461"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"de52819de694f8e822e36f58687cc0988b5d34dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5c754275_d2d3ab00","updated":"2026-07-10 15:43:06.000000000","message":"recheck: Failed to download collection tar from \u0027default\u0027","commit_id":"d91f7e3b468becafb40868f45a59d5281722e461"}],"ansible/inventory/group_vars/all/proxy":[{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"5f9bdc07ae688cc4f30d2c43c656e49357cfd6c9","unresolved":true,"context_lines":[{"line_number":24,"context_line":"  - \"localhost\""},{"line_number":25,"context_line":"  - \"{{ (\u0027http://\u0027 ~ docker_registry) | urlsplit(\u0027hostname\u0027) if docker_registry else \u0027\u0027 }}\""},{"line_number":26,"context_line":"  - \"{{ kolla_internal_vip_address }}\""},{"line_number":27,"context_line":"  - \"{{ lookup(\u0027vars\u0027, provision_oc_net_name ~ \u0027_ips\u0027)[groups.seed[0]] if groups.seed | default([]) | length else \u0027\u0027 }}\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"aa93d9d9_843322c1","line":27,"updated":"2026-06-11 08:08:10.000000000","message":"This will fail with AnsibleUndefinedVariable, when seed provision IP isn\u0027t allocated.\nWe already guard against it in difference places. Something like:\n\n```suggestion\n  - \"{{ lookup(\u0027vars\u0027, provision_oc_net_name ~ \u0027_ips\u0027, default\u003d{})[groups.seed[0]] | default(\u0027\u0027, true) if groups.seed | default([]) | length else \u0027\u0027 }}\"\n```","commit_id":"55962275355a1e2aa62a6dcf156599e3134187c3"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"2a659283e53d0bd98b089085091d2cb0e7a384ea","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# List of domains, hostnames, IP addresses and networks for which no proxy is"},{"line_number":14,"context_line":"# used. Defaults to [\"127.0.0.1\", \"localhost\", \"{{ (\u0027http://\u0027 ~"},{"line_number":15,"context_line":"# docker_registry) | urlsplit(\u0027hostname\u0027) }}\",\"{{ lookup(\u0027vars\u0027,"},{"line_number":16,"context_line":"# provision_oc_net_name ~ \u0027_ips\u0027)[groups.seed[0]] if groups.seed | default([])"},{"line_number":17,"context_line":"# | length else \u0027\u0027 }}\"] if docker_registry is set, or [\"127.0.0.1\","},{"line_number":18,"context_line":"# \"localhost\",\"{{ lookup(\u0027vars\u0027, provision_oc_net_name ~"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7680c964_71577481","line":15,"updated":"2026-06-22 12:27:47.000000000","message":"We also need to update etc/kayobe/proxy.yml to match if updating the comment:\n\nhttps://github.com/openstack/kayobe/blob/master/etc/kayobe/proxy.yml#L13-L18\n\nThat gets used to cut kayobe-config for a release.\n\nThanks for submitting though - looks good overall 🙂","commit_id":"17a6ec5d9f63c7f09276c4749eae9cbb8db9247c"}]}