)]}'
{"specs/juno/trusted-attributes-policy.rst":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8e7b6ab4d18fb1ef09c4ab0faafd1b415cc7aad6","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Trusted Attributes Issuing Policy"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp trusted-attributes-issuing-policy \u003chttps://blueprints.launchpad.net/keystone/+spec/trusted-attribute-issuing-policy\u003e`_"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_99184f20","line":8,"updated":"2014-06-16 18:08:57.000000000","message":"\u003d\u003d\u003d should be the same length as the title.","commit_id":"ab7266ddd44a0a759271c6b2773c88db5a3e8a55"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8e7b6ab4d18fb1ef09c4ab0faafd1b415cc7aad6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Trusted Attributes Issuing Policy"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp trusted-attributes-issuing-policy \u003chttps://blueprints.launchpad.net/keystone/+spec/trusted-attribute-issuing-policy\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"We propose that an API should be added to support control of a policy to"},{"line_number":14,"context_line":"restrict which attributes a federated Identity Provider is trusted to issue."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_59cc078b","line":11,"updated":"2014-06-16 18:08:57.000000000","message":"This is a dependency of https://blueprints.launchpad.net/openstack/?searchtext\u003dsimplified-mapping-api correct? \n\nCan we link the dependency in launchpad as well?","commit_id":"ab7266ddd44a0a759271c6b2773c88db5a3e8a55"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8e7b6ab4d18fb1ef09c4ab0faafd1b415cc7aad6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"We propose that an API should be added to support control of a policy to"},{"line_number":14,"context_line":"restrict which attributes a federated Identity Provider is trusted to issue."},{"line_number":15,"context_line":"There is currently an identity api review for this feature in progress"},{"line_number":16,"context_line":"`here \u003chttps://review.openstack.org/#/c/60489/\u003e`"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem Description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_b9c34b56","line":16,"updated":"2014-06-16 18:08:57.000000000","message":"Is this missing an underscore? \n\n    \t`here \u003chttps://review.openstack.org/#/c/60489/\u003e`_","commit_id":"ab7266ddd44a0a759271c6b2773c88db5a3e8a55"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8e7b6ab4d18fb1ef09c4ab0faafd1b415cc7aad6","unresolved":false,"context_lines":[{"line_number":71,"context_line":"have to be a full literature review, but it should demonstrate that thought has"},{"line_number":72,"context_line":"been put into why the proposed solution is an appropriate one."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"[TODO]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Data Model Impact"},{"line_number":77,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_99c20f33","line":74,"updated":"2014-06-16 18:08:57.000000000","message":"Any other ideas for alternative implementations? Could replace with None for now.","commit_id":"ab7266ddd44a0a759271c6b2773c88db5a3e8a55"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"5e2bc7e9452161b26414ea3a8c8451b58e56634f","unresolved":false,"context_lines":[{"line_number":71,"context_line":"have to be a full literature review, but it should demonstrate that thought has"},{"line_number":72,"context_line":"been put into why the proposed solution is an appropriate one."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"[TODO]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Data Model Impact"},{"line_number":77,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_4514f49e","line":74,"in_reply_to":"1ae5cdf2_99c20f33","updated":"2014-06-17 15:36:44.000000000","message":"i jumped straight to this section to see how this proposal differs from the deployer defined mapping we have today, which allows deployers to either use or ignore issued attributes. a deployer might ignore an attribute because they don\u0027t trust it, for example, which seems to solve the high level use case presented here.","commit_id":"ab7266ddd44a0a759271c6b2773c88db5a3e8a55"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8e7b6ab4d18fb1ef09c4ab0faafd1b415cc7aad6","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"The federated extension migration script should be modified to create the new"},{"line_number":85,"context_line":"data structure required."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"REST API Impact"},{"line_number":89,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_19e6ffe8","line":86,"updated":"2014-06-16 18:08:57.000000000","message":"This would be captured by adding a new table to the database right? Could a rough schema be provided?","commit_id":"ab7266ddd44a0a759271c6b2773c88db5a3e8a55"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8e7b6ab4d18fb1ef09c4ab0faafd1b415cc7aad6","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"This may affect the performance of the federated extension authentication"},{"line_number":258,"context_line":"process as it should be called whenever a user authenticates using a federated"},{"line_number":259,"context_line":"source. However, the extent should be minimal."},{"line_number":260,"context_line":""},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"Other Deployer Impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_79f3839f","line":259,"updated":"2014-06-16 18:08:57.000000000","message":"Why will it be minimal, just out of curiosity","commit_id":"ab7266ddd44a0a759271c6b2773c88db5a3e8a55"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8e7b6ab4d18fb1ef09c4ab0faafd1b415cc7aad6","unresolved":false,"context_lines":[{"line_number":278,"context_line":"-----------"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"Primary assignee:"},{"line_number":281,"context_line":"  Kristy Siu Launchpad ID: kwss@kent.ac.uk"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"Other contributors:"},{"line_number":284,"context_line":"  David Chadwick Launchpad ID: d.w.chadwick@kent.ac.uk"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_99f04f93","line":281,"updated":"2014-06-16 18:08:57.000000000","message":"IRC nicks if available","commit_id":"ab7266ddd44a0a759271c6b2773c88db5a3e8a55"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8e7b6ab4d18fb1ef09c4ab0faafd1b415cc7aad6","unresolved":false,"context_lines":[{"line_number":299,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"Unit tests for the new API as well as any necessary modification to the"},{"line_number":302,"context_line":"federated extension unit tests which already exist."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_d929f7f3","line":302,"updated":"2014-06-16 18:08:57.000000000","message":"Tempest test cases?","commit_id":"ab7266ddd44a0a759271c6b2773c88db5a3e8a55"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4ed0ceed355245af7e3921b2a57d1840be70700e","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Not only that, but because mapping rules can be based on regular expression"},{"line_number":40,"context_line":"matching, then there is no guarantee that only the attribute(s) that the"},{"line_number":41,"context_line":"administrator wanted to match, will be matched. Several others may match as"},{"line_number":42,"context_line":"well. By having a trusted attributes policy, we can ensure that only trusted"},{"line_number":43,"context_line":"attributes are mapped by the mapping rules, and that the mapping rules are"},{"line_number":44,"context_line":"considerably simplified."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_ff969b3d","line":41,"updated":"2014-06-23 20:37:32.000000000","message":"that is scary. We should have some docs around this.","commit_id":"0c80db5c63627a48c27f8db6c54d666900e0d782"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"46b4b52dcb2c215f38c9b6a5bfc1399832bb9024","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Not only that, but because mapping rules can be based on regular expression"},{"line_number":40,"context_line":"matching, then there is no guarantee that only the attribute(s) that the"},{"line_number":41,"context_line":"administrator wanted to match, will be matched. Several others may match as"},{"line_number":42,"context_line":"well. By having a trusted attributes policy, we can ensure that only trusted"},{"line_number":43,"context_line":"attributes are mapped by the mapping rules, and that the mapping rules are"},{"line_number":44,"context_line":"considerably simplified."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_7957be27","line":41,"in_reply_to":"1ae5cdf2_ff969b3d","updated":"2014-06-25 13:49:08.000000000","message":"I have a hard time seeing when/how this can happen, could you provide an example ?","commit_id":"0c80db5c63627a48c27f8db6c54d666900e0d782"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8eebc0babb3efc038e8e555d3b9baf331b42a7fd","unresolved":false,"context_lines":[{"line_number":57,"context_line":"If this feature is added then the Mapping API would change so that the above"},{"line_number":58,"context_line":"example becomes:"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"IDPA is trusted to issue the attributes required for RuleA and RuleB"},{"line_number":61,"context_line":"IDPB is trusted to issue the attributes required for RuleA and RuleC"},{"line_number":62,"context_line":"IDPC is trusted to issue the attributes required for RuleB and RuleC"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab895d6_e7c62149","line":60,"updated":"2014-06-30 06:19:13.000000000","message":"might want to start these off with a *","commit_id":"0c80db5c63627a48c27f8db6c54d666900e0d782"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4ed0ceed355245af7e3921b2a57d1840be70700e","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    class TrustedAttributesPolicy(sql.ModelBase, sql.ModelDictMixin):"},{"line_number":89,"context_line":"        __tablename__ \u003d \u0027trusted_attributes_policy\u0027"},{"line_number":90,"context_line":"        identity_provider_id \u003d sql.Column(sql.String(64), primary_key\u003dTrue)"},{"line_number":91,"context_line":"        trusted_attributes \u003d sql.Column(sql.Text, nullable\u003dFalse)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"The federated extension migration script should be modified to create the new"},{"line_number":94,"context_line":"data structure required."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_df2d5fff","line":91,"updated":"2014-06-23 20:37:32.000000000","message":"what\u0027s held in here? JSON?","commit_id":"0c80db5c63627a48c27f8db6c54d666900e0d782"},{"author":{"_account_id":5956,"name":"Kristy Siu","email":"kwss@kent.ac.uk","username":"kwss"},"change_message_id":"3fc01a8f8f855557774314f8e09d9aada743f26f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    class TrustedAttributesPolicy(sql.ModelBase, sql.ModelDictMixin):"},{"line_number":89,"context_line":"        __tablename__ \u003d \u0027trusted_attributes_policy\u0027"},{"line_number":90,"context_line":"        identity_provider_id \u003d sql.Column(sql.String(64), primary_key\u003dTrue)"},{"line_number":91,"context_line":"        trusted_attributes \u003d sql.Column(sql.Text, nullable\u003dFalse)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"The federated extension migration script should be modified to create the new"},{"line_number":94,"context_line":"data structure required."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_7494258c","line":91,"in_reply_to":"1ae5cdf2_5975a2ca","updated":"2014-06-25 13:42:46.000000000","message":"Will do in the next patch :)","commit_id":"0c80db5c63627a48c27f8db6c54d666900e0d782"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"abd4397728f4307d24d5bf022270424495eae2a8","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    class TrustedAttributesPolicy(sql.ModelBase, sql.ModelDictMixin):"},{"line_number":89,"context_line":"        __tablename__ \u003d \u0027trusted_attributes_policy\u0027"},{"line_number":90,"context_line":"        identity_provider_id \u003d sql.Column(sql.String(64), primary_key\u003dTrue)"},{"line_number":91,"context_line":"        trusted_attributes \u003d sql.Column(sql.Text, nullable\u003dFalse)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"The federated extension migration script should be modified to create the new"},{"line_number":94,"context_line":"data structure required."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_5975a2ca","line":91,"in_reply_to":"1ae5cdf2_807093db","updated":"2014-06-25 13:35:15.000000000","message":"I think it would be handy to have it documented here that this is JSON and it looks like the example given here.","commit_id":"0c80db5c63627a48c27f8db6c54d666900e0d782"},{"author":{"_account_id":5956,"name":"Kristy Siu","email":"kwss@kent.ac.uk","username":"kwss"},"change_message_id":"450ac5e877b88598568f7253ef8eec88d57c9f82","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    class TrustedAttributesPolicy(sql.ModelBase, sql.ModelDictMixin):"},{"line_number":89,"context_line":"        __tablename__ \u003d \u0027trusted_attributes_policy\u0027"},{"line_number":90,"context_line":"        identity_provider_id \u003d sql.Column(sql.String(64), primary_key\u003dTrue)"},{"line_number":91,"context_line":"        trusted_attributes \u003d sql.Column(sql.Text, nullable\u003dFalse)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"The federated extension migration script should be modified to create the new"},{"line_number":94,"context_line":"data structure required."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_807093db","line":91,"in_reply_to":"1ae5cdf2_df2d5fff","updated":"2014-06-25 12:24:56.000000000","message":"Yea so a list of attribute type/value pairs, something like:\n\n{\n    \"trusted_attributes\": [\n        {\n            \"type\": \"orgPersonType\",\n            \"values\": [\"Staff\", \"Manager\", \"Contractor\"]\n        },\n         {\n            \"type\": \"uid\",\n            \"values\": []\n        }\n    ]\n}","commit_id":"0c80db5c63627a48c27f8db6c54d666900e0d782"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"46b4b52dcb2c215f38c9b6a5bfc1399832bb9024","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"This should return a dictionary containing a list of trusted attributes, each"},{"line_number":104,"context_line":"trusted attribute should contain a type and a list of 0-* values where length 0"},{"line_number":105,"context_line":"means any value is accepted."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"`GET /OS-FEDERATED/identity_providers/{idp_id}/trusted_attributes`"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_74cfc557","line":105,"updated":"2014-06-25 13:49:08.000000000","message":"Mappings support regular expressions. Unless trusted attrs definition supports it as well, it seems it won\u0027t be useful anymore in mappings.","commit_id":"0c80db5c63627a48c27f8db6c54d666900e0d782"},{"author":{"_account_id":5956,"name":"Kristy Siu","email":"kwss@kent.ac.uk","username":"kwss"},"change_message_id":"1ac9203d59dbb6a0b6dbc86ff50258890b6ec363","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"This should return a dictionary containing a list of trusted attributes, each"},{"line_number":104,"context_line":"trusted attribute should contain a type and a list of 0-* values where length 0"},{"line_number":105,"context_line":"means any value is accepted."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"`GET /OS-FEDERATED/identity_providers/{idp_id}/trusted_attributes`"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_6a00be35","line":105,"in_reply_to":"1ae5cdf2_74cfc557","updated":"2014-06-25 14:37:20.000000000","message":"I don\u0027t think this is necessarily true, I might want to use regex in mapping to map the value of uid to the user name, and trust my idp to only issue the attribute uid with values \u0027kwss\u0027, \u0027dwc8\u0027, and \u0027foo\u0027. I think both the trusted attribute filter and the regex based mapping have value in this scenario.","commit_id":"0c80db5c63627a48c27f8db6c54d666900e0d782"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4ed0ceed355245af7e3921b2a57d1840be70700e","unresolved":false,"context_lines":[{"line_number":235,"context_line":"**Delete an Identity Provider\u0027s Trusted Attributes Policy:**"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"This should empty the policy for the specified Identity Provider, effectively"},{"line_number":238,"context_line":"deauthorizing all attributes from this provider."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"`DELETE /OS-FEDERATED/identity_providers/{idp_id}/trusted_attributes`"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_7f1d2bbe","line":238,"updated":"2014-06-23 20:37:32.000000000","message":"I\u0027m a little confused -- would all existing providers get a trusted_attributes \u003d []?\n\nWould new providers get no trusted attributes (all unauthorized) or would they get empty trusted attribues (all authorized)?","commit_id":"0c80db5c63627a48c27f8db6c54d666900e0d782"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"1648c4d3d98ee175958972d6ee63d9a29f4c6775","unresolved":false,"context_lines":[{"line_number":235,"context_line":"**Delete an Identity Provider\u0027s Trusted Attributes Policy:**"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"This should empty the policy for the specified Identity Provider, effectively"},{"line_number":238,"context_line":"deauthorizing all attributes from this provider."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"`DELETE /OS-FEDERATED/identity_providers/{idp_id}/trusted_attributes`"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_941ff1b7","line":238,"in_reply_to":"1ae5cdf2_142e8142","updated":"2014-06-25 13:51:30.000000000","message":"I think the name should be like\n\n [federation]\n default_attribute_trust_policy\u003dtrusted\n\nif set to ``untrusted`` then by default (when an IdP is created or when an IdP trusted attributes policy is deleted) no attributes are trusted.","commit_id":"0c80db5c63627a48c27f8db6c54d666900e0d782"},{"author":{"_account_id":5956,"name":"Kristy Siu","email":"kwss@kent.ac.uk","username":"kwss"},"change_message_id":"3fc01a8f8f855557774314f8e09d9aada743f26f","unresolved":false,"context_lines":[{"line_number":235,"context_line":"**Delete an Identity Provider\u0027s Trusted Attributes Policy:**"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"This should empty the policy for the specified Identity Provider, effectively"},{"line_number":238,"context_line":"deauthorizing all attributes from this provider."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"`DELETE /OS-FEDERATED/identity_providers/{idp_id}/trusted_attributes`"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_142e8142","line":238,"in_reply_to":"1ae5cdf2_3914564c","updated":"2014-06-25 13:42:46.000000000","message":"Something like use_trusted_attributes_filter\u003dtrue? Then we can create an empty (all unauthorised) list for new or existing IdPs iff this flag is set to true, and otherwise we should maintain current functionality?","commit_id":"0c80db5c63627a48c27f8db6c54d666900e0d782"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"abd4397728f4307d24d5bf022270424495eae2a8","unresolved":false,"context_lines":[{"line_number":235,"context_line":"**Delete an Identity Provider\u0027s Trusted Attributes Policy:**"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"This should empty the policy for the specified Identity Provider, effectively"},{"line_number":238,"context_line":"deauthorizing all attributes from this provider."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"`DELETE /OS-FEDERATED/identity_providers/{idp_id}/trusted_attributes`"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_3914564c","line":238,"in_reply_to":"1ae5cdf2_6370f173","updated":"2014-06-25 13:35:15.000000000","message":"I think we need to be backwards compatible. Then can provide a config option for those deployments that want to have more security.","commit_id":"0c80db5c63627a48c27f8db6c54d666900e0d782"},{"author":{"_account_id":5956,"name":"Kristy Siu","email":"kwss@kent.ac.uk","username":"kwss"},"change_message_id":"450ac5e877b88598568f7253ef8eec88d57c9f82","unresolved":false,"context_lines":[{"line_number":235,"context_line":"**Delete an Identity Provider\u0027s Trusted Attributes Policy:**"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"This should empty the policy for the specified Identity Provider, effectively"},{"line_number":238,"context_line":"deauthorizing all attributes from this provider."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"`DELETE /OS-FEDERATED/identity_providers/{idp_id}/trusted_attributes`"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_6370f173","line":238,"in_reply_to":"1ae5cdf2_7f1d2bbe","updated":"2014-06-25 12:24:56.000000000","message":"For backwards compatibility we need to consider carefully how we manage this. The \"right\" thing to do in terms of security is to trust nothing unless explicitly, but as the current federation extension has no trust mechanism on what IdPs can issue, this change could break existing deployments. I guess in this case we are saying that any identity provider which previously had a policy should require it for attributes to be issued. So until the policy has been specified for an IdP (new or existing) it will work on a trust all basis(all authorised), thereafter deleting the policy empties it (all unauthorised)\n\nI\u0027m not sure what the best way to handle this is though. Perhaps trust-none should be achieved through a patch with an empty list of attributes, allowing administrators to revert to trust-all by deleting the policy.","commit_id":"0c80db5c63627a48c27f8db6c54d666900e0d782"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8eebc0babb3efc038e8e555d3b9baf331b42a7fd","unresolved":false,"context_lines":[{"line_number":235,"context_line":"**Delete an Identity Provider\u0027s Trusted Attributes Policy:**"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"This should empty the policy for the specified Identity Provider, effectively"},{"line_number":238,"context_line":"deauthorizing all attributes from this provider."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"`DELETE /OS-FEDERATED/identity_providers/{idp_id}/trusted_attributes`"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab895d6_e778e12d","line":238,"in_reply_to":"1ae5cdf2_941ff1b7","updated":"2014-06-30 06:19:13.000000000","message":"++\n\nthis solves the backwards compatibility problem i was worried about","commit_id":"0c80db5c63627a48c27f8db6c54d666900e0d782"},{"author":{"_account_id":5956,"name":"Kristy Siu","email":"kwss@kent.ac.uk","username":"kwss"},"change_message_id":"1ac9203d59dbb6a0b6dbc86ff50258890b6ec363","unresolved":false,"context_lines":[{"line_number":235,"context_line":"**Delete an Identity Provider\u0027s Trusted Attributes Policy:**"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"This should empty the policy for the specified Identity Provider, effectively"},{"line_number":238,"context_line":"deauthorizing all attributes from this provider."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"`DELETE /OS-FEDERATED/identity_providers/{idp_id}/trusted_attributes`"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_8afb4a47","line":238,"in_reply_to":"1ae5cdf2_941ff1b7","updated":"2014-06-25 14:37:20.000000000","message":"Works for me.","commit_id":"0c80db5c63627a48c27f8db6c54d666900e0d782"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"e3178a663a2a866eaef2c4224d2d0c71b2084a56","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Trusted Attributes Issuing Policy"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp trusted-attributes-issuing-policy \u003chttps://blueprints.launchpad.net/keystone/+spec/trusted-attribute-issuing-policy\u003e`_"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_f494d845","line":9,"updated":"2014-07-09 22:02:08.000000000","message":"remove the extra equal signs (this will raise a doc build warning)- the number of equal signs should match the number of characters in the title (applies to both top and bottom)","commit_id":"864ee8698cd7c445aa00d29374eda22e9176e0a0"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"e3178a663a2a866eaef2c4224d2d0c71b2084a56","unresolved":false,"context_lines":[{"line_number":14,"context_line":"restrict which attributes a federated Identity Provider is trusted to issue."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Note. This specification should be read in conjunction with the simplified"},{"line_number":17,"context_line":"mapping specification"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Problem Description"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_74a1a8a8","line":17,"updated":"2014-07-09 22:02:08.000000000","message":"Specifications should either stand alone, be merged together, or have a clear chain of dependency - this statement implies that they must be accepted together?","commit_id":"864ee8698cd7c445aa00d29374eda22e9176e0a0"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"e3178a663a2a866eaef2c4224d2d0c71b2084a56","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Administrators of a federated system should be able to configure which"},{"line_number":23,"context_line":"attributes a federated identity provider can issue. For example, a bank may be"},{"line_number":24,"context_line":"trusted to issue a credit card number but not a driving license number."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Currently this is controlled by the Mapping API which specifies rules for each"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_b4b420f3","line":23,"updated":"2014-07-09 22:02:08.000000000","message":"keystone can\u0027t control which attributes an IdP \"can issue,\" but rather keystone can control which attributes \"are acknowledged by Keystone.\"","commit_id":"864ee8698cd7c445aa00d29374eda22e9176e0a0"}]}
