)]}'
{"specs/juno/endpoint-group-filter.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2b9860c79fe1a6a6090ba75cc8214ef88af8edd1","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Endpoint Group Filter"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Out of the box, Keystone for project scoped tokens returns all known service"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab895d6_47eeed8c","line":8,"updated":"2014-06-30 06:31:15.000000000","message":"at first i thought this had something to do with groups - the identity concept - this doesn\u0027t appear to be the case... \n\ni can\u0027t suggest an alternate name atm, but this one will likely cause confusion.","commit_id":"76f19a0af461d7d2f22193d0d72f2a472a1d6f75"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2b9860c79fe1a6a6090ba75cc8214ef88af8edd1","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Endpoint Group Filter"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Out of the box, Keystone for project scoped tokens returns all known service"},{"line_number":12,"context_line":"endpoints regardless of whether users have access to them or not. This is"},{"line_number":13,"context_line":"neither efficient nor secure. In the Havana release, an endpoint filter"},{"line_number":14,"context_line":"extension was created. Unfortunately this offers limited filtering capabilities"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab895d6_07f2359a","line":11,"updated":"2014-06-30 06:31:15.000000000","message":"first sentence sounds a bit funny ... how about:\n\nOut of the box, when Keystone issues a project scoped token , it returns all known service endpoints regardless of whether users have access to them or not.","commit_id":"76f19a0af461d7d2f22193d0d72f2a472a1d6f75"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"547f19ffcd121ca2c16cd39278afc24b04568e73","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Endpoint Group Filter"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Out of the box, Keystone for project scoped tokens returns all known service"},{"line_number":12,"context_line":"endpoints regardless of whether users have access to them or not. This is"},{"line_number":13,"context_line":"neither efficient nor secure. In the Havana release, an endpoint filter"},{"line_number":14,"context_line":"extension was created. Unfortunately this offers limited filtering capabilities"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_e26457e7","line":11,"in_reply_to":"dab895d6_07f2359a","updated":"2014-06-30 22:28:04.000000000","message":"Done","commit_id":"76f19a0af461d7d2f22193d0d72f2a472a1d6f75"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2b9860c79fe1a6a6090ba75cc8214ef88af8edd1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"At present with the Endpoint Filtering extension in Keystone, we are able to"},{"line_number":26,"context_line":"associate endpoints with projects and as a result limit what service endpoints"},{"line_number":27,"context_line":"appear in a catalog for a project scoped token. However, anyone who belongs to"},{"line_number":28,"context_line":"a given project can see all the project scoped service endpoints. From a"},{"line_number":29,"context_line":"Security perspective this clearly violates the principle of \u0027Least Privilege\u0027."}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab895d6_671771a4","line":26,"updated":"2014-06-30 06:31:15.000000000","message":"... as a result limit what service endpoints *that* appear in a ...","commit_id":"76f19a0af461d7d2f22193d0d72f2a472a1d6f75"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"547f19ffcd121ca2c16cd39278afc24b04568e73","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"At present with the Endpoint Filtering extension in Keystone, we are able to"},{"line_number":26,"context_line":"associate endpoints with projects and as a result limit what service endpoints"},{"line_number":27,"context_line":"appear in a catalog for a project scoped token. However, anyone who belongs to"},{"line_number":28,"context_line":"a given project can see all the project scoped service endpoints. From a"},{"line_number":29,"context_line":"Security perspective this clearly violates the principle of \u0027Least Privilege\u0027."}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_22e48f3a","line":26,"in_reply_to":"dab895d6_671771a4","updated":"2014-06-30 22:28:04.000000000","message":"Done","commit_id":"76f19a0af461d7d2f22193d0d72f2a472a1d6f75"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2b9860c79fe1a6a6090ba75cc8214ef88af8edd1","unresolved":false,"context_lines":[{"line_number":54,"context_line":"characteristics (e.g. service, type, region). Moreover, we have"},{"line_number":55,"context_line":"enabled fine grained grouping for users so that different users with different"},{"line_number":56,"context_line":"roles can have access to only specific subsets of the endpoints available to"},{"line_number":57,"context_line":"the project. "},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"The benefits of the Endpoint Group Filter are as follows:"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab895d6_074955d0","line":57,"updated":"2014-06-30 06:31:15.000000000","message":"white space issue","commit_id":"76f19a0af461d7d2f22193d0d72f2a472a1d6f75"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2b9860c79fe1a6a6090ba75cc8214ef88af8edd1","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"The benefits of the Endpoint Group Filter are as follows:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    * Service endpoints can be easily managed according to their"},{"line_number":62,"context_line":"      characteristics (e.g. service, type, region)."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    * Service endpoints can belong to multiple groups which increases the level"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab895d6_a7a42958","line":61,"updated":"2014-06-30 06:31:15.000000000","message":"tip: you can probably start the * at column 0","commit_id":"76f19a0af461d7d2f22193d0d72f2a472a1d6f75"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2b9860c79fe1a6a6090ba75cc8214ef88af8edd1","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    * Service endpoints can belong to multiple groups which increases the level"},{"line_number":65,"context_line":"      of granularity. For instance, you can limit service endpoints to a"},{"line_number":66,"context_line":"      certain service (e.g. Swift) and region (e.g. US-West)."},{"line_number":67,"context_line":"      "},{"line_number":68,"context_line":"    * The Endpoint Group Filter can enforce the relationship between Projects"},{"line_number":69,"context_line":"      and Users, whereby users only see the service endpoints associated with a"},{"line_number":70,"context_line":"      given project they are associated with."}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab895d6_679a1116","line":67,"updated":"2014-06-30 06:31:15.000000000","message":"whitespace issue","commit_id":"76f19a0af461d7d2f22193d0d72f2a472a1d6f75"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2b9860c79fe1a6a6090ba75cc8214ef88af8edd1","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"With the proposed solution we introduce the ability to also filter based on"},{"line_number":82,"context_line":"user. Ideally this filtering should be driven via user-roles, in particular,"},{"line_number":83,"context_line":"the ability to scope roles on a project. Unfortunately, user roles are "},{"line_number":84,"context_line":"currently global in nature and therefore cannot be applied to individual "},{"line_number":85,"context_line":"service endpoints."},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab895d6_c7883dc9","line":83,"updated":"2014-06-30 06:31:15.000000000","message":"whitespace issue","commit_id":"76f19a0af461d7d2f22193d0d72f2a472a1d6f75"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2b9860c79fe1a6a6090ba75cc8214ef88af8edd1","unresolved":false,"context_lines":[{"line_number":81,"context_line":"With the proposed solution we introduce the ability to also filter based on"},{"line_number":82,"context_line":"user. Ideally this filtering should be driven via user-roles, in particular,"},{"line_number":83,"context_line":"the ability to scope roles on a project. Unfortunately, user roles are "},{"line_number":84,"context_line":"currently global in nature and therefore cannot be applied to individual "},{"line_number":85,"context_line":"service endpoints."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Data Model Impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab895d6_e78541ae","line":84,"updated":"2014-06-30 06:31:15.000000000","message":"whitespace issue","commit_id":"76f19a0af461d7d2f22193d0d72f2a472a1d6f75"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2b9860c79fe1a6a6090ba75cc8214ef88af8edd1","unresolved":false,"context_lines":[{"line_number":144,"context_line":"## Endpoint Group Filter API"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"If a valid X-Auth-Token token in not present in the HTTP header and/or the user"},{"line_number":147,"context_line":"does not have the right authorization a HTTP 401 Unauthorized is returned."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"### Endpoint Group Filter CRUD"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab895d6_c7af5d2a","line":147,"updated":"2014-06-30 06:31:15.000000000","message":"isn\u0027t this always the case, and therefore redundant?","commit_id":"76f19a0af461d7d2f22193d0d72f2a472a1d6f75"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2b9860c79fe1a6a6090ba75cc8214ef88af8edd1","unresolved":false,"context_lines":[{"line_number":176,"context_line":"      \"filters\": {"},{"line_number":177,"context_line":"        \"id\": \"cbf9a1e3990d4059ae339c7495dcf183\""},{"line_number":178,"context_line":"      },"},{"line_number":179,"context_line":"      \"name\": \"Endpoint filter test\""},{"line_number":180,"context_line":"    }"},{"line_number":181,"context_line":"  }"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab895d6_0781558f","line":179,"updated":"2014-06-30 06:31:15.000000000","message":"the name and description here don\u0027t match with the ones in the request","commit_id":"76f19a0af461d7d2f22193d0d72f2a472a1d6f75"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"547f19ffcd121ca2c16cd39278afc24b04568e73","unresolved":false,"context_lines":[{"line_number":176,"context_line":"      \"filters\": {"},{"line_number":177,"context_line":"        \"id\": \"cbf9a1e3990d4059ae339c7495dcf183\""},{"line_number":178,"context_line":"      },"},{"line_number":179,"context_line":"      \"name\": \"Endpoint filter test\""},{"line_number":180,"context_line":"    }"},{"line_number":181,"context_line":"  }"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_8a172da3","line":179,"in_reply_to":"dab895d6_0781558f","updated":"2014-06-30 22:28:04.000000000","message":"Done","commit_id":"76f19a0af461d7d2f22193d0d72f2a472a1d6f75"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2b9860c79fe1a6a6090ba75cc8214ef88af8edd1","unresolved":false,"context_lines":[{"line_number":217,"context_line":"}"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"Response:"},{"line_number":220,"context_line":"  Status: 204 No Content"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"#### Remove Endpoint Group: ‘DELETE /OS-EP-GROUPING/endpoint_groups/{endpoint_group_id}’"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab895d6_674f7193","line":220,"updated":"2014-06-30 06:31:15.000000000","message":"why 204 on an update?","commit_id":"76f19a0af461d7d2f22193d0d72f2a472a1d6f75"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"547f19ffcd121ca2c16cd39278afc24b04568e73","unresolved":false,"context_lines":[{"line_number":217,"context_line":"}"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"Response:"},{"line_number":220,"context_line":"  Status: 204 No Content"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"#### Remove Endpoint Group: ‘DELETE /OS-EP-GROUPING/endpoint_groups/{endpoint_group_id}’"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_ea25090b","line":220,"in_reply_to":"dab895d6_674f7193","updated":"2014-06-30 22:28:04.000000000","message":"Good spot. Should be 200 OK.","commit_id":"76f19a0af461d7d2f22193d0d72f2a472a1d6f75"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"da1d3fef66216c9c9ee593b26effbbe6e4c4f01b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        id \u003d sql.Column(sql.String(64), primary_key\u003dTrue)"},{"line_number":99,"context_line":"        name \u003d sql.Column(sql.String(255), nullable\u003dFalse)"},{"line_number":100,"context_line":"        description \u003d name \u003d sql.Column(sql.String(255))"},{"line_number":101,"context_line":"        filters \u003d sql.Column(sql.JsonBlob(), nullable\u003dFalse)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"We also need to store the mapping between Endpoint Group Filters and Projects:"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_0638589f","line":101,"updated":"2014-07-01 15:22:51.000000000","message":"for future reference, specs shouldn\u0027t include actual code. describe the impact in prose or diagrams.","commit_id":"a5f52b97d621e0a6d1120110e4fee7369810e425"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"569272092a4e1f7855f819b353ba0cf61f59c006","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        id \u003d sql.Column(sql.String(64), primary_key\u003dTrue)"},{"line_number":99,"context_line":"        name \u003d sql.Column(sql.String(255), nullable\u003dFalse)"},{"line_number":100,"context_line":"        description \u003d name \u003d sql.Column(sql.String(255))"},{"line_number":101,"context_line":"        filters \u003d sql.Column(sql.JsonBlob(), nullable\u003dFalse)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"We also need to store the mapping between Endpoint Group Filters and Projects:"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_6302db3f","line":101,"in_reply_to":"baada198_0638589f","updated":"2014-07-01 19:43:54.000000000","message":"Understood. I was using:\n\nhttp://docs-draft.openstack.org/23/102023/3/check/gate-keystone-specs-docs/3c84490/doc/build/html/specs/juno/multi-backend-uuids.html\n\nas a guide - which uses a similar approach for outlining the Data Model Impact.","commit_id":"a5f52b97d621e0a6d1120110e4fee7369810e425"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"da1d3fef66216c9c9ee593b26effbbe6e4c4f01b","unresolved":false,"context_lines":[{"line_number":137,"context_line":"REST API Impact"},{"line_number":138,"context_line":"---------------"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"# Create Endpoint Group Filter: ‘POST /OS-EP-FILTER/endpoint_group_filters’"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Create an Endpoint Group Filter."},{"line_number":143,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_66abd4d8","line":140,"updated":"2014-07-01 15:22:51.000000000","message":"the hashtags don\u0027t render as headings, and i can\u0027t tell quite what character you\u0027re using to escape literals, but they\u0027re not ``backticks``, which is what restructured text uses.\n\nlook at the rendered result in the doc build before leaving things up for review:\n\n  http://docs-draft.openstack.org/23/102023/3/check/gate-keystone-specs-docs/3c84490/doc/build/html/specs/juno/endpoint-group-filter.html","commit_id":"a5f52b97d621e0a6d1120110e4fee7369810e425"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"569272092a4e1f7855f819b353ba0cf61f59c006","unresolved":false,"context_lines":[{"line_number":137,"context_line":"REST API Impact"},{"line_number":138,"context_line":"---------------"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"# Create Endpoint Group Filter: ‘POST /OS-EP-FILTER/endpoint_group_filters’"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Create an Endpoint Group Filter."},{"line_number":143,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_63265b18","line":140,"in_reply_to":"baada198_66abd4d8","updated":"2014-07-01 19:43:54.000000000","message":"Thanks Dolph. I ran tox locally and fixed up Jenkins and at which point I thought all was good. Thanks for the tip. I am now also using restview (https://github.com/mgedmin/restview) which seems a nice tool for checking the restructured text.","commit_id":"a5f52b97d621e0a6d1120110e4fee7369810e425"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f2441ec00f096b7e0f89e01578ac7f3b0fc98126","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Multi-Attribute Endpoint Filter"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Out of the box, when Keystone issues a project scoped token, it returns all"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_18d681f1","line":8,"updated":"2014-07-04 06:14:37.000000000","message":"++ this new name is much better","commit_id":"9fd34547edd30ca425030e89c5d4ca594fbf185b"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f2441ec00f096b7e0f89e01578ac7f3b0fc98126","unresolved":false,"context_lines":[{"line_number":59,"context_line":"The benefits of the Multi-Attribute Endpoint Filter are as follows:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* Service endpoints can be easily managed according to their characteristics"},{"line_number":62,"context_line":"  (e.g. service, type, region)."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* Service endpoints can belong to multiple groups which increases the level of"},{"line_number":65,"context_line":"  granularity. For instance, you can limit service endpoints to a certain"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_fe5ff50c","line":62,"updated":"2014-07-04 06:14:37.000000000","message":"\"characteristics, which can act as filters. A list of filters would be: service_id, type, region.\"\n\nI\u0027d prefer a definitive list of filters that would be supported.","commit_id":"9fd34547edd30ca425030e89c5d4ca594fbf185b"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"d3bc92475c0f6bf172d5183d054069c380a5ec11","unresolved":false,"context_lines":[{"line_number":59,"context_line":"The benefits of the Multi-Attribute Endpoint Filter are as follows:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* Service endpoints can be easily managed according to their characteristics"},{"line_number":62,"context_line":"  (e.g. service, type, region)."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* Service endpoints can belong to multiple groups which increases the level of"},{"line_number":65,"context_line":"  granularity. For instance, you can limit service endpoints to a certain"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_d9cc0b8c","line":62,"in_reply_to":"baada198_fe5ff50c","updated":"2014-07-04 07:43:02.000000000","message":"Agreed. Done.","commit_id":"9fd34547edd30ca425030e89c5d4ca594fbf185b"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f2441ec00f096b7e0f89e01578ac7f3b0fc98126","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  Projects and Users, whereby users only see the service endpoints associated"},{"line_number":70,"context_line":"  with a given project they are associated with."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* The Multi-Attribute Endpoint Filter provides a superset of the Endpoint"},{"line_number":73,"context_line":"  Filter functionality that was added to Keystone as an extension in Havana."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_334c469e","line":72,"updated":"2014-07-04 06:14:37.000000000","message":"since it\u0027s a superset, can we deprecate endpoint filtering? (your wording makes it seem that way)","commit_id":"9fd34547edd30ca425030e89c5d4ca594fbf185b"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"d3bc92475c0f6bf172d5183d054069c380a5ec11","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  Projects and Users, whereby users only see the service endpoints associated"},{"line_number":70,"context_line":"  with a given project they are associated with."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* The Multi-Attribute Endpoint Filter provides a superset of the Endpoint"},{"line_number":73,"context_line":"  Filter functionality that was added to Keystone as an extension in Havana."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_79ae9f82","line":72,"in_reply_to":"baada198_334c469e","updated":"2014-07-04 07:43:02.000000000","message":"Yes. The current Endpoint Filter functionality can be obtained by simply creating a Multi-Attribute Endpoint Filter with an empty list of attributes.","commit_id":"9fd34547edd30ca425030e89c5d4ca594fbf185b"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f2441ec00f096b7e0f89e01578ac7f3b0fc98126","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":".. code-block:: python"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    class ProjectEndpointGroupFilterMembership(sql.ModelBase, sql.DictBase):"},{"line_number":112,"context_line":"        \"\"\"project endpoint group filter relationship table.\"\"\""},{"line_number":113,"context_line":"        __tablename__ \u003d \u0027project_endpoint_group\u0027"},{"line_number":114,"context_line":"        attributes \u003d [\u0027endpoint_group_filter_id\u0027, \u0027project_id\u0027]"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_b30db640","line":111,"updated":"2014-07-04 06:14:37.000000000","message":"At first glance, this table seems pointless given the UserProjectEndpointGroupFilterMembership table.\n\nFor a project-\u003eendpoint_group, just use the table that has user and set the user_id value to None?","commit_id":"9fd34547edd30ca425030e89c5d4ca594fbf185b"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"d3bc92475c0f6bf172d5183d054069c380a5ec11","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":".. code-block:: python"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    class ProjectEndpointGroupFilterMembership(sql.ModelBase, sql.DictBase):"},{"line_number":112,"context_line":"        \"\"\"project endpoint group filter relationship table.\"\"\""},{"line_number":113,"context_line":"        __tablename__ \u003d \u0027project_endpoint_group\u0027"},{"line_number":114,"context_line":"        attributes \u003d [\u0027endpoint_group_filter_id\u0027, \u0027project_id\u0027]"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_2bda0e4c","line":111,"in_reply_to":"baada198_b30db640","updated":"2014-07-04 07:43:02.000000000","message":"Done","commit_id":"9fd34547edd30ca425030e89c5d4ca594fbf185b"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f2441ec00f096b7e0f89e01578ac7f3b0fc98126","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        {"},{"line_number":170,"context_line":"            \"endpoint_group_filter\": {"},{"line_number":171,"context_line":"                \"description\": \"Example Endpoint Group Filter\","},{"line_number":172,"context_line":"                \"links\": {"},{"line_number":173,"context_line":"                    \"self\": \"http://localhost:35357/v3/OS-EP-FILTER/endpoint_group_filter/c8fcf2a34c8440b9894356e42bab11ca\""},{"line_number":174,"context_line":"                },"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_beb01d44","line":171,"updated":"2014-07-04 06:14:37.000000000","message":"nit: all the request and response blocks should be alphabetized. \n\ndescription/filters/id/links/name","commit_id":"9fd34547edd30ca425030e89c5d4ca594fbf185b"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"d3bc92475c0f6bf172d5183d054069c380a5ec11","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        {"},{"line_number":170,"context_line":"            \"endpoint_group_filter\": {"},{"line_number":171,"context_line":"                \"description\": \"Example Endpoint Group Filter\","},{"line_number":172,"context_line":"                \"links\": {"},{"line_number":173,"context_line":"                    \"self\": \"http://localhost:35357/v3/OS-EP-FILTER/endpoint_group_filter/c8fcf2a34c8440b9894356e42bab11ca\""},{"line_number":174,"context_line":"                },"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_79e5bfda","line":171,"in_reply_to":"baada198_beb01d44","updated":"2014-07-04 07:43:02.000000000","message":"Done","commit_id":"9fd34547edd30ca425030e89c5d4ca594fbf185b"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f2441ec00f096b7e0f89e01578ac7f3b0fc98126","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    Status: 204 No Content"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"- Check Project to Group Association:"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    ``HEAD /OS-EP-FILTER/projects/{project_id}/endpoint_groups/``"},{"line_number":311,"context_line":"    ``{endpoint_group_id}``"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_1e8bc968","line":308,"updated":"2014-07-04 06:14:37.000000000","message":"Check Project to *Endpoint* Group Association:\n\nor Multi-Attribute Endpoint\n\nsame goes for all of these","commit_id":"9fd34547edd30ca425030e89c5d4ca594fbf185b"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"d3bc92475c0f6bf172d5183d054069c380a5ec11","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    Status: 204 No Content"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"- Check Project to Group Association:"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    ``HEAD /OS-EP-FILTER/projects/{project_id}/endpoint_groups/``"},{"line_number":311,"context_line":"    ``{endpoint_group_id}``"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_990ff387","line":308,"in_reply_to":"baada198_1e8bc968","updated":"2014-07-04 07:43:02.000000000","message":"Done","commit_id":"9fd34547edd30ca425030e89c5d4ca594fbf185b"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"ce94f70a64b5c651ba7b711b876473e5cf9a38e9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"The benefits of the Multi-Attribute Endpoint Filter are as follows:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* Service endpoints can be easily managed according to their characteristics"},{"line_number":62,"context_line":"  which can act as filters. A list of filters would be: service_id, type,"},{"line_number":63,"context_line":"  region."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"* Service endpoints can belong to multiple groups which increases the level of"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_a5339e60","line":62,"updated":"2014-07-04 15:39:39.000000000","message":"add backticks (``) to service_id, type and region.\n\nso ``service_id``, ``type``, and ``region``.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"38af58b14be0d84927f88d8b617254d24c13674c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"The benefits of the Multi-Attribute Endpoint Filter are as follows:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* Service endpoints can be easily managed according to their characteristics"},{"line_number":62,"context_line":"  which can act as filters. A list of filters would be: service_id, type,"},{"line_number":63,"context_line":"  region."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"* Service endpoints can belong to multiple groups which increases the level of"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_f63700fd","line":62,"in_reply_to":"baada198_a5339e60","updated":"2014-07-07 23:14:14.000000000","message":"Done","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b1a001e8ab15128a62d79d361f55d94df7b0f632","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  with a given project they are associated with."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* The Multi-Attribute Endpoint Filter provides a superset of the Endpoint"},{"line_number":74,"context_line":"  Filter functionality that was added to Keystone as an extension in Havana."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Alternatives"},{"line_number":77,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_d39bd115","line":74,"updated":"2014-07-07 15:17:21.000000000","message":"Is this just an extension of the current code or is this proposing making it default behavior?","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"38af58b14be0d84927f88d8b617254d24c13674c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  with a given project they are associated with."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* The Multi-Attribute Endpoint Filter provides a superset of the Endpoint"},{"line_number":74,"context_line":"  Filter functionality that was added to Keystone as an extension in Havana."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Alternatives"},{"line_number":77,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_0f66fdec","line":74,"in_reply_to":"baada198_d39bd115","updated":"2014-07-07 23:14:14.000000000","message":"The former. The original idea of the Multi-Attribute Endpoint Filter was to have a new distinct extension completely separate to the existing endpoint filter. However, I feel it doesn\u0027t make sense to have two endpoint filter related extensions and so the proposal is to extend/enhance the current endpoint filter extension.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b1a001e8ab15128a62d79d361f55d94df7b0f632","unresolved":false,"context_lines":[{"line_number":80,"context_line":"define fine grained rules in the policy file that dictate which service"},{"line_number":81,"context_line":"endpoints be included in the catalog for a given project scoped token and be"},{"line_number":82,"context_line":"able to dynamically add new service endpoints to a policy. At the moment, such"},{"line_number":83,"context_line":"fine grained dynamic rules are not feasible."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"With the proposed solution we introduce the ability to also filter based on"},{"line_number":86,"context_line":"user. Ideally this filtering should be driven via user-roles, in particular,"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_537501c9","line":83,"updated":"2014-07-07 15:17:21.000000000","message":"Is the reason these are not feasible because the policy language is insufficient? Keystone\u0027s interpretation is insufficient? Middleware can\u0027t support it?","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"38af58b14be0d84927f88d8b617254d24c13674c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"define fine grained rules in the policy file that dictate which service"},{"line_number":81,"context_line":"endpoints be included in the catalog for a given project scoped token and be"},{"line_number":82,"context_line":"able to dynamically add new service endpoints to a policy. At the moment, such"},{"line_number":83,"context_line":"fine grained dynamic rules are not feasible."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"With the proposed solution we introduce the ability to also filter based on"},{"line_number":86,"context_line":"user. Ideally this filtering should be driven via user-roles, in particular,"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_4f70f53f","line":83,"in_reply_to":"baada198_537501c9","updated":"2014-07-07 23:14:14.000000000","message":"The policy language and Keystone\u0027s interpretation is insufficient. Also using a policy approach would lead to a static solution whereby you could not dynamically add new service endpoints.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b1a001e8ab15128a62d79d361f55d94df7b0f632","unresolved":false,"context_lines":[{"line_number":92,"context_line":"-----------------"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"The data model changes involve the creation of a new table that represents an"},{"line_number":95,"context_line":"Endpoint Group Filter:"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":".. code-block:: python"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_f33a95e5","line":95,"updated":"2014-07-07 15:17:21.000000000","message":"Is this something we can model in the LDAP assignment backend? Please elaborate on how that will be handled (if possible)","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"38af58b14be0d84927f88d8b617254d24c13674c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"-----------------"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"The data model changes involve the creation of a new table that represents an"},{"line_number":95,"context_line":"Endpoint Group Filter:"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":".. code-block:: python"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_efcc696c","line":95,"in_reply_to":"baada198_f33a95e5","updated":"2014-07-07 23:14:14.000000000","message":"At the moment, the existing endpoint filter functionality is focused 100% on SQL backend and this proposal does not extend that functionality into LDAP territory. Possible future work if there is demand.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b1a001e8ab15128a62d79d361f55d94df7b0f632","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"- Update Endpoint Group:"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    ``PUT /OS-EP-FILTER/endpoint_groups/{endpoint_group_id}``"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"  Request:"},{"line_number":200,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_2eb2e64b","line":197,"updated":"2014-07-07 15:17:21.000000000","message":"Use PATCH instead of PUT for update.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"38af58b14be0d84927f88d8b617254d24c13674c","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"- Update Endpoint Group:"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    ``PUT /OS-EP-FILTER/endpoint_groups/{endpoint_group_id}``"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"  Request:"},{"line_number":200,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_15ae0a2e","line":197,"in_reply_to":"baada198_2eb2e64b","updated":"2014-07-07 23:14:14.000000000","message":"Done.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"ce94f70a64b5c651ba7b711b876473e5cf9a38e9","unresolved":false,"context_lines":[{"line_number":243,"context_line":"- List All Endpoint Groups:"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    ``GET /OS-EP-FILTER/endpoint_groups``"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"  Response:"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    Status: 200 OK"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_b0803af8","line":246,"updated":"2014-07-04 15:39:39.000000000","message":"Is there anyway you could leverage query parameters here for project_id and user_id and remove a bunch of the APIs below?\n\nif project_id is there, filter by project_id (line 339)\nif user_id is there, filter by user_id?\nif both, filter by both?\nif none, return this list?","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"38af58b14be0d84927f88d8b617254d24c13674c","unresolved":false,"context_lines":[{"line_number":243,"context_line":"- List All Endpoint Groups:"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    ``GET /OS-EP-FILTER/endpoint_groups``"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"  Response:"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    Status: 200 OK"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_d8dd9ee1","line":246,"in_reply_to":"baada198_0e7fe266","updated":"2014-07-07 23:14:14.000000000","message":"Done.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b1a001e8ab15128a62d79d361f55d94df7b0f632","unresolved":false,"context_lines":[{"line_number":243,"context_line":"- List All Endpoint Groups:"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    ``GET /OS-EP-FILTER/endpoint_groups``"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"  Response:"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    Status: 200 OK"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_0e7fe266","line":246,"in_reply_to":"baada198_b0803af8","updated":"2014-07-07 15:17:21.000000000","message":"++","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b1a001e8ab15128a62d79d361f55d94df7b0f632","unresolved":false,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"  Response:"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    Status: 204 No Content"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"- Delete Endpoint Group to Project Association:"},{"line_number":304,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_0e444219","line":301,"updated":"2014-07-07 15:17:21.000000000","message":"With a HEAD request there must be an associated GET request (apache + mod_wsgi requirement). Would the GET request return 204 as well? Suggest making GET return the filter data and change this to 200 as well.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"38af58b14be0d84927f88d8b617254d24c13674c","unresolved":false,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"  Response:"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    Status: 204 No Content"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"- Delete Endpoint Group to Project Association:"},{"line_number":304,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_352eaea5","line":301,"in_reply_to":"baada198_0e444219","updated":"2014-07-07 23:14:14.000000000","message":"Done.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b1a001e8ab15128a62d79d361f55d94df7b0f632","unresolved":false,"context_lines":[{"line_number":325,"context_line":""},{"line_number":326,"context_line":"  Response:"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    Status: 204 No Content"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"- Delete Endpoint Group in Project to User Association:"},{"line_number":331,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_4e49da2f","line":328,"updated":"2014-07-07 15:17:21.000000000","message":"See comment on line 301","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"38af58b14be0d84927f88d8b617254d24c13674c","unresolved":false,"context_lines":[{"line_number":325,"context_line":""},{"line_number":326,"context_line":"  Response:"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    Status: 204 No Content"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"- Delete Endpoint Group in Project to User Association:"},{"line_number":331,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_d514924e","line":328,"in_reply_to":"baada198_4e49da2f","updated":"2014-07-07 23:14:14.000000000","message":"Done.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"ce94f70a64b5c651ba7b711b876473e5cf9a38e9","unresolved":false,"context_lines":[{"line_number":391,"context_line":"                \"endpoint_group_id\": \"b4f31c9de61a46e5bfa53a83e4b02ce7\","},{"line_number":392,"context_line":"                \"projects\": ["},{"line_number":393,"context_line":"                    {"},{"line_number":394,"context_line":"                        \"project_id\": \"c2a6276042e841c2a3a201990e5a0499\""},{"line_number":395,"context_line":"                    }"},{"line_number":396,"context_line":"                ]"},{"line_number":397,"context_line":"            }"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_306a6a81","line":394,"updated":"2014-07-04 15:39:39.000000000","message":"shouldn\u0027t this have:\n\ndomain_id, enabled, id, name, of the actual project? not just project_id","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b1a001e8ab15128a62d79d361f55d94df7b0f632","unresolved":false,"context_lines":[{"line_number":391,"context_line":"                \"endpoint_group_id\": \"b4f31c9de61a46e5bfa53a83e4b02ce7\","},{"line_number":392,"context_line":"                \"projects\": ["},{"line_number":393,"context_line":"                    {"},{"line_number":394,"context_line":"                        \"project_id\": \"c2a6276042e841c2a3a201990e5a0499\""},{"line_number":395,"context_line":"                    }"},{"line_number":396,"context_line":"                ]"},{"line_number":397,"context_line":"            }"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_ce640abb","line":394,"in_reply_to":"baada198_306a6a81","updated":"2014-07-07 15:17:21.000000000","message":"++","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"38af58b14be0d84927f88d8b617254d24c13674c","unresolved":false,"context_lines":[{"line_number":391,"context_line":"                \"endpoint_group_id\": \"b4f31c9de61a46e5bfa53a83e4b02ce7\","},{"line_number":392,"context_line":"                \"projects\": ["},{"line_number":393,"context_line":"                    {"},{"line_number":394,"context_line":"                        \"project_id\": \"c2a6276042e841c2a3a201990e5a0499\""},{"line_number":395,"context_line":"                    }"},{"line_number":396,"context_line":"                ]"},{"line_number":397,"context_line":"            }"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_7705a744","line":394,"in_reply_to":"baada198_306a6a81","updated":"2014-07-07 23:14:14.000000000","message":"We are returning a list of project ids associated with a given endpoint group. We only store project_id in the UserProjectEndpointGroupFilterMembership table. We can certainly query and recover the additional project information if required.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"ce94f70a64b5c651ba7b711b876473e5cf9a38e9","unresolved":false,"context_lines":[{"line_number":397,"context_line":"            }"},{"line_number":398,"context_line":"        }"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"- List Endpoint Groups Associated with Project For User:"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    ``GET /OS-EP-FILTER/projects/{project_id}/endpoint_groups/users/``"},{"line_number":403,"context_line":"    ``{user_id}``"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_70df820d","line":400,"updated":"2014-07-04 15:39:39.000000000","message":"I think this should be:\n\nList Projects Associated with an Endpoint Group For User:\n\n?","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"38af58b14be0d84927f88d8b617254d24c13674c","unresolved":false,"context_lines":[{"line_number":397,"context_line":"            }"},{"line_number":398,"context_line":"        }"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"- List Endpoint Groups Associated with Project For User:"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    ``GET /OS-EP-FILTER/projects/{project_id}/endpoint_groups/users/``"},{"line_number":403,"context_line":"    ``{user_id}``"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_37b08fdc","line":400,"in_reply_to":"baada198_70df820d","updated":"2014-07-07 23:14:14.000000000","message":"With this particular API we are supplying a project_id and user_id and we want in the response, a list of endpoint groups that are in a project granted to a particular user. I\u0027ve added an additional API to return the list of projects associated with an endpoint group and user.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"ce94f70a64b5c651ba7b711b876473e5cf9a38e9","unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"- List Service Endpoints Associated with Project:"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    ``GET /OS-EP-FILTER/projects/{project_id}/endpoints``"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"  Response:"},{"line_number":433,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_e55f563f","line":430,"updated":"2014-07-04 15:39:39.000000000","message":"how does this differ from:\n\nhttps://github.com/openstack/identity-api/blob/master/v3/src/markdown/identity-api-v3-os-ep-filter-ext.md#list-associations-for-project-get-os-ep-filterprojectsproject_idendpoints\n\nList Associations for Project: GET /OS-EP-FILTER/projects/{project_id}/endpoints\n\nCan you group the API calls, or mark is a bit more clearly,  New ones vs ones you plan to Enhance","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b1a001e8ab15128a62d79d361f55d94df7b0f632","unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"- List Service Endpoints Associated with Project:"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    ``GET /OS-EP-FILTER/projects/{project_id}/endpoints``"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"  Response:"},{"line_number":433,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_ae2fd63d","line":430,"in_reply_to":"baada198_e55f563f","updated":"2014-07-07 15:17:21.000000000","message":"++","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"38af58b14be0d84927f88d8b617254d24c13674c","unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":"- List Service Endpoints Associated with Project:"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    ``GET /OS-EP-FILTER/projects/{project_id}/endpoints``"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"  Response:"},{"line_number":433,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_5738a33c","line":430,"in_reply_to":"baada198_e55f563f","updated":"2014-07-07 23:14:14.000000000","message":"Done. This API overwrites the existing API noted above and I\u0027ve highlighted this as suggested with a different section for modified/updated APIs.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b1a001e8ab15128a62d79d361f55d94df7b0f632","unresolved":false,"context_lines":[{"line_number":550,"context_line":""},{"line_number":551,"context_line":"The benefit of this proposal is that we offer more fine grained control over"},{"line_number":552,"context_line":"what service endpoints are returned to the user in the underlying service"},{"line_number":553,"context_line":"catalog."},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"Notifications Impact"},{"line_number":556,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_6eda1e18","line":553,"updated":"2014-07-07 15:17:21.000000000","message":"Is this just changing the catalog? If so, this does not provide the security you are expecting. It provides a very thin veil that means a user just deosn\u0027t know the endpoint but does not provide enforcement on the use of the endpoint.\n\nIt looks like there is no associated work to be done with the middleware, so this is security through obscurity not real enforcement. I\u0027m convinced that the ability to enforce only interacting with the endpoints in the catalog is a important part of this functionality.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"38af58b14be0d84927f88d8b617254d24c13674c","unresolved":false,"context_lines":[{"line_number":550,"context_line":""},{"line_number":551,"context_line":"The benefit of this proposal is that we offer more fine grained control over"},{"line_number":552,"context_line":"what service endpoints are returned to the user in the underlying service"},{"line_number":553,"context_line":"catalog."},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"Notifications Impact"},{"line_number":556,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_f2dfec66","line":553,"in_reply_to":"baada198_6eda1e18","updated":"2014-07-07 23:14:14.000000000","message":"Agreed, the optimal, end-to-end solution is to also enforce the use of the endpoint at run-time. This proposal focuses on filtering the service endpoints made visible in the catalog. The next step is to enforce at run-time, the underlying access to the endpoint.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b1a001e8ab15128a62d79d361f55d94df7b0f632","unresolved":false,"context_lines":[{"line_number":568,"context_line":"Generally speaking this change should reduce the size of the service catalog"},{"line_number":569,"context_line":"included in a project scoped tokens since we are filtering service endpoints."},{"line_number":570,"context_line":"The performance impact of the filtering itself should be minimal and by default"},{"line_number":571,"context_line":"filtering is not enabled."},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"Other Deployer Impact"},{"line_number":574,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_ce316a5b","line":571,"updated":"2014-07-07 15:17:21.000000000","message":"Keep in mind there is a push to get the catalog out of the token. But that doesn\u0027t change anything here statement wise.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b1a001e8ab15128a62d79d361f55d94df7b0f632","unresolved":false,"context_lines":[{"line_number":573,"context_line":"Other Deployer Impact"},{"line_number":574,"context_line":"---------------------"},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"None"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"Developer Impact"},{"line_number":579,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_4e3d5a2a","line":576,"updated":"2014-07-07 15:17:21.000000000","message":"Deployers would need to configure the new filtering, right?","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"38af58b14be0d84927f88d8b617254d24c13674c","unresolved":false,"context_lines":[{"line_number":573,"context_line":"Other Deployer Impact"},{"line_number":574,"context_line":"---------------------"},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"None"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"Developer Impact"},{"line_number":579,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_72d3dc5f","line":576,"in_reply_to":"baada198_4e3d5a2a","updated":"2014-07-07 23:14:14.000000000","message":"Done.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b1a001e8ab15128a62d79d361f55d94df7b0f632","unresolved":false,"context_lines":[{"line_number":597,"context_line":""},{"line_number":598,"context_line":"* Implement a new extension including:"},{"line_number":599,"context_line":"    * Create Backend Catalog and SQL"},{"line_number":600,"context_line":"    * Create Router"},{"line_number":601,"context_line":"    * Create Controller"},{"line_number":602,"context_line":"    * Create Core"},{"line_number":603,"context_line":"    * Update identity driver with new extension"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_4e247a0c","line":600,"updated":"2014-07-07 15:17:21.000000000","message":"Please be specific on what is being created. I assume: keystone.contrib.xxx.xxx.xxx ?","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"38af58b14be0d84927f88d8b617254d24c13674c","unresolved":false,"context_lines":[{"line_number":597,"context_line":""},{"line_number":598,"context_line":"* Implement a new extension including:"},{"line_number":599,"context_line":"    * Create Backend Catalog and SQL"},{"line_number":600,"context_line":"    * Create Router"},{"line_number":601,"context_line":"    * Create Controller"},{"line_number":602,"context_line":"    * Create Core"},{"line_number":603,"context_line":"    * Update identity driver with new extension"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_381a1ac6","line":600,"in_reply_to":"baada198_4e247a0c","updated":"2014-07-07 23:14:14.000000000","message":"Done. I\u0027ve added more details to the tasks.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b1a001e8ab15128a62d79d361f55d94df7b0f632","unresolved":false,"context_lines":[{"line_number":598,"context_line":"* Implement a new extension including:"},{"line_number":599,"context_line":"    * Create Backend Catalog and SQL"},{"line_number":600,"context_line":"    * Create Router"},{"line_number":601,"context_line":"    * Create Controller"},{"line_number":602,"context_line":"    * Create Core"},{"line_number":603,"context_line":"    * Update identity driver with new extension"},{"line_number":604,"context_line":"    * Update keystone/common/config.py"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_ae7c36ed","line":601,"updated":"2014-07-07 15:17:21.000000000","message":"Same as line 600","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b1a001e8ab15128a62d79d361f55d94df7b0f632","unresolved":false,"context_lines":[{"line_number":599,"context_line":"    * Create Backend Catalog and SQL"},{"line_number":600,"context_line":"    * Create Router"},{"line_number":601,"context_line":"    * Create Controller"},{"line_number":602,"context_line":"    * Create Core"},{"line_number":603,"context_line":"    * Update identity driver with new extension"},{"line_number":604,"context_line":"    * Update keystone/common/config.py"},{"line_number":605,"context_line":"    * Update policy.json"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_ce7faade","line":602,"updated":"2014-07-07 15:17:21.000000000","message":"same as line 600","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"ce94f70a64b5c651ba7b711b876473e5cf9a38e9","unresolved":false,"context_lines":[{"line_number":600,"context_line":"    * Create Router"},{"line_number":601,"context_line":"    * Create Controller"},{"line_number":602,"context_line":"    * Create Core"},{"line_number":603,"context_line":"    * Update identity driver with new extension"},{"line_number":604,"context_line":"    * Update keystone/common/config.py"},{"line_number":605,"context_line":"    * Update policy.json"},{"line_number":606,"context_line":"    * Update keystone.conf.sample"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_c59c1260","line":603,"updated":"2014-07-04 15:39:39.000000000","message":"Why does the identity driver need to be updated?","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b1a001e8ab15128a62d79d361f55d94df7b0f632","unresolved":false,"context_lines":[{"line_number":600,"context_line":"    * Create Router"},{"line_number":601,"context_line":"    * Create Controller"},{"line_number":602,"context_line":"    * Create Core"},{"line_number":603,"context_line":"    * Update identity driver with new extension"},{"line_number":604,"context_line":"    * Update keystone/common/config.py"},{"line_number":605,"context_line":"    * Update policy.json"},{"line_number":606,"context_line":"    * Update keystone.conf.sample"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_ee82aec6","line":603,"in_reply_to":"baada198_c59c1260","updated":"2014-07-07 15:17:21.000000000","message":"++ This isn\u0027t clear to me.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"38af58b14be0d84927f88d8b617254d24c13674c","unresolved":false,"context_lines":[{"line_number":600,"context_line":"    * Create Router"},{"line_number":601,"context_line":"    * Create Controller"},{"line_number":602,"context_line":"    * Create Core"},{"line_number":603,"context_line":"    * Update identity driver with new extension"},{"line_number":604,"context_line":"    * Update keystone/common/config.py"},{"line_number":605,"context_line":"    * Update policy.json"},{"line_number":606,"context_line":"    * Update keystone.conf.sample"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_777a07be","line":603,"in_reply_to":"baada198_c59c1260","updated":"2014-07-07 23:14:14.000000000","message":"I\u0027ve removed this task completely.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"ce94f70a64b5c651ba7b711b876473e5cf9a38e9","unresolved":false,"context_lines":[{"line_number":601,"context_line":"    * Create Controller"},{"line_number":602,"context_line":"    * Create Core"},{"line_number":603,"context_line":"    * Update identity driver with new extension"},{"line_number":604,"context_line":"    * Update keystone/common/config.py"},{"line_number":605,"context_line":"    * Update policy.json"},{"line_number":606,"context_line":"    * Update keystone.conf.sample"},{"line_number":607,"context_line":"* Create Documentation including setup and configuration"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_a581dec4","line":604,"updated":"2014-07-04 15:39:39.000000000","message":"Are you creating a new section or extending an old one?\nWhat options are you going to provide for configuration?","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b1a001e8ab15128a62d79d361f55d94df7b0f632","unresolved":false,"context_lines":[{"line_number":601,"context_line":"    * Create Controller"},{"line_number":602,"context_line":"    * Create Core"},{"line_number":603,"context_line":"    * Update identity driver with new extension"},{"line_number":604,"context_line":"    * Update keystone/common/config.py"},{"line_number":605,"context_line":"    * Update policy.json"},{"line_number":606,"context_line":"    * Update keystone.conf.sample"},{"line_number":607,"context_line":"* Create Documentation including setup and configuration"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_ce66ca50","line":604,"in_reply_to":"baada198_a581dec4","updated":"2014-07-07 15:17:21.000000000","message":"Please be specific to the configuration options being changed added. This should be documented in the proposed change or the deployer impact.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"38af58b14be0d84927f88d8b617254d24c13674c","unresolved":false,"context_lines":[{"line_number":601,"context_line":"    * Create Controller"},{"line_number":602,"context_line":"    * Create Core"},{"line_number":603,"context_line":"    * Update identity driver with new extension"},{"line_number":604,"context_line":"    * Update keystone/common/config.py"},{"line_number":605,"context_line":"    * Update policy.json"},{"line_number":606,"context_line":"    * Update keystone.conf.sample"},{"line_number":607,"context_line":"* Create Documentation including setup and configuration"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_d86f5e29","line":604,"in_reply_to":"baada198_a581dec4","updated":"2014-07-07 23:14:14.000000000","message":"The existing endpoint filtering configuration would remain as is.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"38af58b14be0d84927f88d8b617254d24c13674c","unresolved":false,"context_lines":[{"line_number":601,"context_line":"    * Create Controller"},{"line_number":602,"context_line":"    * Create Core"},{"line_number":603,"context_line":"    * Update identity driver with new extension"},{"line_number":604,"context_line":"    * Update keystone/common/config.py"},{"line_number":605,"context_line":"    * Update policy.json"},{"line_number":606,"context_line":"    * Update keystone.conf.sample"},{"line_number":607,"context_line":"* Create Documentation including setup and configuration"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_78957231","line":604,"in_reply_to":"baada198_ce66ca50","updated":"2014-07-07 23:14:14.000000000","message":"I\u0027ve re-worded this section and hopefully this addresses this concern.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b1a001e8ab15128a62d79d361f55d94df7b0f632","unresolved":false,"context_lines":[{"line_number":602,"context_line":"    * Create Core"},{"line_number":603,"context_line":"    * Update identity driver with new extension"},{"line_number":604,"context_line":"    * Update keystone/common/config.py"},{"line_number":605,"context_line":"    * Update policy.json"},{"line_number":606,"context_line":"    * Update keystone.conf.sample"},{"line_number":607,"context_line":"* Create Documentation including setup and configuration"},{"line_number":608,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_eed0eeca","line":605,"updated":"2014-07-07 15:17:21.000000000","message":"Please elaborate what is being updated.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"ce94f70a64b5c651ba7b711b876473e5cf9a38e9","unresolved":false,"context_lines":[{"line_number":603,"context_line":"    * Update identity driver with new extension"},{"line_number":604,"context_line":"    * Update keystone/common/config.py"},{"line_number":605,"context_line":"    * Update policy.json"},{"line_number":606,"context_line":"    * Update keystone.conf.sample"},{"line_number":607,"context_line":"* Create Documentation including setup and configuration"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_e5f91681","line":606,"updated":"2014-07-04 15:39:39.000000000","message":"so would this new extension be another \"driver\" option for this group: \n\nhttps://github.com/openstack/keystone/blob/d96d5466776494cd364e54a42448ef650117a94a/etc/keystone.conf.sample#L733\n\nCan someone be running both the old endpoint filter and the new one? Would there be any conflict from using both?","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"38af58b14be0d84927f88d8b617254d24c13674c","unresolved":false,"context_lines":[{"line_number":603,"context_line":"    * Update identity driver with new extension"},{"line_number":604,"context_line":"    * Update keystone/common/config.py"},{"line_number":605,"context_line":"    * Update policy.json"},{"line_number":606,"context_line":"    * Update keystone.conf.sample"},{"line_number":607,"context_line":"* Create Documentation including setup and configuration"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_38d5bae4","line":606,"in_reply_to":"baada198_e5f91681","updated":"2014-07-07 23:14:14.000000000","message":"No, the proposal is to expand the functionality of the existing endpoint filter extension. The existing functionality can be addressed with and the APIs honored with the multi-attribute endpoint filtering.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b1a001e8ab15128a62d79d361f55d94df7b0f632","unresolved":false,"context_lines":[{"line_number":614,"context_line":"Testing"},{"line_number":615,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"* Unit tests will be required to exercise the Endpoint Group Filter"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"Documentation Impact"},{"line_number":620,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_6ee4deab","line":617,"updated":"2014-07-07 15:17:21.000000000","message":"Tempest test development plans? would it even be possible?","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"38af58b14be0d84927f88d8b617254d24c13674c","unresolved":false,"context_lines":[{"line_number":614,"context_line":"Testing"},{"line_number":615,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"* Unit tests will be required to exercise the Endpoint Group Filter"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"Documentation Impact"},{"line_number":620,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_fe1b2b70","line":617,"in_reply_to":"baada198_6ee4deab","updated":"2014-07-07 23:14:14.000000000","message":"I am researching if this is possible and will respond accordingly. I\u0027m assuming it is possible to create a test scenario that enables a keystone extension, creates the extension tables and runs through some endpoint filter tests. However, I need to confirm if indeed it is.","commit_id":"fcb37542f5b9aa2864a5e21edfcf1d09603ef35f"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"18ee8cb60a93910042fb981009a861875d52ce0d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Security perspective this clearly violates the principle of \u0027Least Privilege\u0027."},{"line_number":30,"context_line":"For instance, a Glance Administrator on the US West Coast should not see Glance"},{"line_number":31,"context_line":"or for that matter any other service endpoints on the US East Coast or any"},{"line_number":32,"context_line":"other region for that matter. Therefore there is a strong need to be able to"},{"line_number":33,"context_line":"offer more fine grained capabilities for filtering service endpoints. In"},{"line_number":34,"context_line":"particular, we should be able to filter service endpoints according to service"},{"line_number":35,"context_line":"(e.g. Nova, Swift, etc) or interface type (e.g. admin, internal, etc) or region"}],"source_content_type":"text/x-rst","patch_set":11,"id":"baada198_e5ab9372","line":32,"updated":"2014-07-08 07:15:16.000000000","message":"There is currently at least nothing about policy that means that allows us to enforce anything via region. AFAIK region has always been just a grouping mechanism.","commit_id":"78a10d78471ec7a26d082d7e9e5416cd71b109f4"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"a22fe9f52114db16349faf7f60b90a6e6d2821ce","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Security perspective this clearly violates the principle of \u0027Least Privilege\u0027."},{"line_number":30,"context_line":"For instance, a Glance Administrator on the US West Coast should not see Glance"},{"line_number":31,"context_line":"or for that matter any other service endpoints on the US East Coast or any"},{"line_number":32,"context_line":"other region for that matter. Therefore there is a strong need to be able to"},{"line_number":33,"context_line":"offer more fine grained capabilities for filtering service endpoints. In"},{"line_number":34,"context_line":"particular, we should be able to filter service endpoints according to service"},{"line_number":35,"context_line":"(e.g. Nova, Swift, etc) or interface type (e.g. admin, internal, etc) or region"}],"source_content_type":"text/x-rst","patch_set":11,"id":"baada198_8a51ed10","line":32,"in_reply_to":"baada198_e5ab9372","updated":"2014-07-08 18:24:10.000000000","message":"Region is an important attribute when it comes to filtering endpoints in the service catalog (and in the future enforcing endpoints). There are use cases whereby you want to be able to restrict endpoints based on a given region.","commit_id":"78a10d78471ec7a26d082d7e9e5416cd71b109f4"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"18ee8cb60a93910042fb981009a861875d52ce0d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"other region for that matter. Therefore there is a strong need to be able to"},{"line_number":33,"context_line":"offer more fine grained capabilities for filtering service endpoints. In"},{"line_number":34,"context_line":"particular, we should be able to filter service endpoints according to service"},{"line_number":35,"context_line":"(e.g. Nova, Swift, etc) or interface type (e.g. admin, internal, etc) or region"},{"line_number":36,"context_line":"or any combination thereof."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"In addition, with the present Endpoint Filtering extension, managing service"}],"source_content_type":"text/x-rst","patch_set":11,"id":"baada198_a5fa7b72","line":35,"updated":"2014-07-08 07:15:16.000000000","message":"ditto interface. I realize admin is different but hopefully with keystone v3 no-one is using the admin interface any more. \n\npublic and internal have always been defined as the same service just different ways to route to it so limiting someones access to it seems unnecessary.","commit_id":"78a10d78471ec7a26d082d7e9e5416cd71b109f4"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"18ee8cb60a93910042fb981009a861875d52ce0d","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"* The Multi-Attribute Endpoint Filter can enforce the relationship between"},{"line_number":70,"context_line":"  Projects and Users, whereby users only see the service endpoints associated"},{"line_number":71,"context_line":"  with a given project they are associated with."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* The Multi-Attribute Endpoint Filter provides a superset of the Endpoint"},{"line_number":74,"context_line":"  Filter functionality that was added to Keystone as an extension in Havana."}],"source_content_type":"text/x-rst","patch_set":11,"id":"baada198_c523ef02","line":71,"updated":"2014-07-08 07:15:16.000000000","message":"isn\u0027t this the existing endpoint filter?","commit_id":"78a10d78471ec7a26d082d7e9e5416cd71b109f4"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"a22fe9f52114db16349faf7f60b90a6e6d2821ce","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"* The Multi-Attribute Endpoint Filter can enforce the relationship between"},{"line_number":70,"context_line":"  Projects and Users, whereby users only see the service endpoints associated"},{"line_number":71,"context_line":"  with a given project they are associated with."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* The Multi-Attribute Endpoint Filter provides a superset of the Endpoint"},{"line_number":74,"context_line":"  Filter functionality that was added to Keystone as an extension in Havana."}],"source_content_type":"text/x-rst","patch_set":11,"id":"baada198_f3d6e7c2","line":71,"in_reply_to":"baada198_c523ef02","updated":"2014-07-08 18:24:10.000000000","message":"The existing endpoint filter only creates relationships/associations between projects and endpoints. In other words, with the existing implementation you can only filter at the level of the project.","commit_id":"78a10d78471ec7a26d082d7e9e5416cd71b109f4"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"18ee8cb60a93910042fb981009a861875d52ce0d","unresolved":false,"context_lines":[{"line_number":88,"context_line":"user. Ideally this filtering should be driven via user-roles, in particular,"},{"line_number":89,"context_line":"the ability to scope roles on a project. Unfortunately, user roles are"},{"line_number":90,"context_line":"currently global in nature and therefore cannot be applied to individual"},{"line_number":91,"context_line":"service endpoints."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Data Model Impact"},{"line_number":94,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"baada198_2563cb42","line":91,"updated":"2014-07-08 07:15:16.000000000","message":"The concept of a role is global, but the role is only given to a user within a project or a domain. I don\u0027t think user-role-project make sense here but role-project might be useful.","commit_id":"78a10d78471ec7a26d082d7e9e5416cd71b109f4"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"c360fa5568ecaff481e3347db7d7b793a4b08802","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"- Update Endpoint Group:"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    ``PATCH /OS-EP-FILTER/endpoint_groups/{endpoint_group_id}``"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"  Request:"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"baada198_bbc1ba81","line":201,"updated":"2014-07-08 07:39:43.000000000","message":"the other CRUD functions have the URI at /endpoint_group_filters and then list goes back to /endpoint_groups.\n\nI like /endpoint_groups better but they should be consistent.","commit_id":"78a10d78471ec7a26d082d7e9e5416cd71b109f4"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"a22fe9f52114db16349faf7f60b90a6e6d2821ce","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"- Update Endpoint Group:"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    ``PATCH /OS-EP-FILTER/endpoint_groups/{endpoint_group_id}``"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"  Request:"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"baada198_8da587b7","line":201,"in_reply_to":"baada198_bbc1ba81","updated":"2014-07-08 18:24:10.000000000","message":"Done","commit_id":"78a10d78471ec7a26d082d7e9e5416cd71b109f4"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"18ee8cb60a93910042fb981009a861875d52ce0d","unresolved":false,"context_lines":[{"line_number":301,"context_line":"- Create Project to Endpoint Group Association:"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    ``PUT /OS-EP-FILTER/projects/{project_id}/endpoint_groups/``"},{"line_number":304,"context_line":"    ``{endpoint_group_id}``"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"  Response:"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"baada198_48c0d64f","line":304,"updated":"2014-07-08 07:15:16.000000000","message":"this seems backwards - when you get down to listing endpoints on a group the /endpoint_group/ is the root element.  Also above the listing is based on group.\n\nI think that makes sense all through here to have /endpoint_group/{id}/project/{id}","commit_id":"78a10d78471ec7a26d082d7e9e5416cd71b109f4"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"c360fa5568ecaff481e3347db7d7b793a4b08802","unresolved":false,"context_lines":[{"line_number":301,"context_line":"- Create Project to Endpoint Group Association:"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    ``PUT /OS-EP-FILTER/projects/{project_id}/endpoint_groups/``"},{"line_number":304,"context_line":"    ``{endpoint_group_id}``"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"  Response:"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"baada198_bb48da2d","line":304,"in_reply_to":"baada198_48c0d64f","updated":"2014-07-08 07:39:43.000000000","message":"I\u0027m going back and forwards on this because the /projects/{id}/endpoints is the existing URL but the list operation looks like: ``GET /OS-EP-FILTER/endpoint_groups/{endpoint_group_id}/projects`` and the create and delete operations should be structured the same.","commit_id":"78a10d78471ec7a26d082d7e9e5416cd71b109f4"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"a22fe9f52114db16349faf7f60b90a6e6d2821ce","unresolved":false,"context_lines":[{"line_number":301,"context_line":"- Create Project to Endpoint Group Association:"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    ``PUT /OS-EP-FILTER/projects/{project_id}/endpoint_groups/``"},{"line_number":304,"context_line":"    ``{endpoint_group_id}``"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"  Response:"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"baada198_f0497633","line":304,"in_reply_to":"baada198_bb48da2d","updated":"2014-07-08 18:24:10.000000000","message":"Done","commit_id":"78a10d78471ec7a26d082d7e9e5416cd71b109f4"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"18ee8cb60a93910042fb981009a861875d52ce0d","unresolved":false,"context_lines":[{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    Status: 204 No Content"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"- Get Project to Endpoint Group Association:"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    ``GET /OS-EP-FILTER/projects/{project_id}/endpoint_groups/``"},{"line_number":313,"context_line":"    ``{endpoint_group_id}``"}],"source_content_type":"text/x-rst","patch_set":11,"id":"baada198_48e376d8","line":310,"updated":"2014-07-08 07:15:16.000000000","message":"I assume this is going to ignore anything with a user specific association?","commit_id":"78a10d78471ec7a26d082d7e9e5416cd71b109f4"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"a22fe9f52114db16349faf7f60b90a6e6d2821ce","unresolved":false,"context_lines":[{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    Status: 204 No Content"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"- Get Project to Endpoint Group Association:"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    ``GET /OS-EP-FILTER/projects/{project_id}/endpoint_groups/``"},{"line_number":313,"context_line":"    ``{endpoint_group_id}``"}],"source_content_type":"text/x-rst","patch_set":11,"id":"baada198_8dcbc71d","line":310,"in_reply_to":"baada198_48e376d8","updated":"2014-07-08 18:24:10.000000000","message":"Yes","commit_id":"78a10d78471ec7a26d082d7e9e5416cd71b109f4"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"18ee8cb60a93910042fb981009a861875d52ce0d","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    .. code-block:: javascript"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"        {"},{"line_number":399,"context_line":"            \"endpoint_group_id\": \"b4f31c9de61a46e5bfa53a83e4b02ce7\","},{"line_number":400,"context_line":"            \"projects\": ["},{"line_number":401,"context_line":"                {"},{"line_number":402,"context_line":"                    \"project_id\": \"c2a6276042e841c2a3a201990e5a0499\""}],"source_content_type":"text/x-rst","patch_set":11,"id":"baada198_c5092f32","line":399,"updated":"2014-07-08 07:15:16.000000000","message":"this value would not typically be returned here, you should know what it is already because you provided it.","commit_id":"78a10d78471ec7a26d082d7e9e5416cd71b109f4"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"a22fe9f52114db16349faf7f60b90a6e6d2821ce","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    .. code-block:: javascript"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"        {"},{"line_number":399,"context_line":"            \"endpoint_group_id\": \"b4f31c9de61a46e5bfa53a83e4b02ce7\","},{"line_number":400,"context_line":"            \"projects\": ["},{"line_number":401,"context_line":"                {"},{"line_number":402,"context_line":"                    \"project_id\": \"c2a6276042e841c2a3a201990e5a0499\""}],"source_content_type":"text/x-rst","patch_set":11,"id":"baada198_edd9a3f5","line":399,"in_reply_to":"baada198_c5092f32","updated":"2014-07-08 18:24:10.000000000","message":"Done","commit_id":"78a10d78471ec7a26d082d7e9e5416cd71b109f4"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"18ee8cb60a93910042fb981009a861875d52ce0d","unresolved":false,"context_lines":[{"line_number":406,"context_line":""},{"line_number":407,"context_line":"- List Projects Associated with an Endpoint Group for User:"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    ``GET /OS-EP-FILTER/endpoint_groups/{endpoint_group_id}/users/{user_id}/project``"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"  Response:"},{"line_number":412,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"baada198_251bcb81","line":409,"updated":"2014-07-08 07:15:16.000000000","message":"/endpoint_groups/{endpoint_group_id}/projects?user_id\u003d{user_id} ?","commit_id":"78a10d78471ec7a26d082d7e9e5416cd71b109f4"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"a22fe9f52114db16349faf7f60b90a6e6d2821ce","unresolved":false,"context_lines":[{"line_number":406,"context_line":""},{"line_number":407,"context_line":"- List Projects Associated with an Endpoint Group for User:"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    ``GET /OS-EP-FILTER/endpoint_groups/{endpoint_group_id}/users/{user_id}/project``"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"  Response:"},{"line_number":412,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"baada198_adb5eb7f","line":409,"in_reply_to":"baada198_251bcb81","updated":"2014-07-08 18:24:10.000000000","message":"Done","commit_id":"78a10d78471ec7a26d082d7e9e5416cd71b109f4"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"18ee8cb60a93910042fb981009a861875d52ce0d","unresolved":false,"context_lines":[{"line_number":415,"context_line":"    .. code-block:: javascript"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        {"},{"line_number":418,"context_line":"            \"endpoint_group_id\": \"b4f31c9de61a46e5bfa53a83e4b02ce7\","},{"line_number":419,"context_line":"            \"projects\": ["},{"line_number":420,"context_line":"                {"},{"line_number":421,"context_line":"                    \"enabled\": True,"}],"source_content_type":"text/x-rst","patch_set":11,"id":"baada198_e5047319","line":418,"updated":"2014-07-08 07:15:16.000000000","message":"remove","commit_id":"78a10d78471ec7a26d082d7e9e5416cd71b109f4"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"a22fe9f52114db16349faf7f60b90a6e6d2821ce","unresolved":false,"context_lines":[{"line_number":415,"context_line":"    .. code-block:: javascript"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        {"},{"line_number":418,"context_line":"            \"endpoint_group_id\": \"b4f31c9de61a46e5bfa53a83e4b02ce7\","},{"line_number":419,"context_line":"            \"projects\": ["},{"line_number":420,"context_line":"                {"},{"line_number":421,"context_line":"                    \"enabled\": True,"}],"source_content_type":"text/x-rst","patch_set":11,"id":"baada198_cdba1f6e","line":418,"in_reply_to":"baada198_e5047319","updated":"2014-07-08 18:24:10.000000000","message":"Done","commit_id":"78a10d78471ec7a26d082d7e9e5416cd71b109f4"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"18ee8cb60a93910042fb981009a861875d52ce0d","unresolved":false,"context_lines":[{"line_number":424,"context_line":"                    \"name\": \"EPG-PROJECT-1\""},{"line_number":425,"context_line":"                }"},{"line_number":426,"context_line":"            ],"},{"line_number":427,"context_line":"            \"user_id\": \"cdb24f07c76e4ab49f89c87798e45eb2\""},{"line_number":428,"context_line":"        }"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"- List Service Endpoints Associated with Project:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"baada198_05008700","line":427,"updated":"2014-07-08 07:15:16.000000000","message":"remove","commit_id":"78a10d78471ec7a26d082d7e9e5416cd71b109f4"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"a22fe9f52114db16349faf7f60b90a6e6d2821ce","unresolved":false,"context_lines":[{"line_number":424,"context_line":"                    \"name\": \"EPG-PROJECT-1\""},{"line_number":425,"context_line":"                }"},{"line_number":426,"context_line":"            ],"},{"line_number":427,"context_line":"            \"user_id\": \"cdb24f07c76e4ab49f89c87798e45eb2\""},{"line_number":428,"context_line":"        }"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"- List Service Endpoints Associated with Project:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"baada198_0dac1735","line":427,"in_reply_to":"baada198_05008700","updated":"2014-07-08 18:24:10.000000000","message":"Done","commit_id":"78a10d78471ec7a26d082d7e9e5416cd71b109f4"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"18ee8cb60a93910042fb981009a861875d52ce0d","unresolved":false,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"- List Service Endpoints Associated with Project For User:"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    ``GET /OS-EP-FILTER/projects/{project_id}/users/{user_id}/endpoints``"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"  Response:"},{"line_number":515,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"baada198_48537616","line":512,"updated":"2014-07-08 07:15:16.000000000","message":"/projects/{project_id}/endpoints?user_id\u003d{user_id}","commit_id":"78a10d78471ec7a26d082d7e9e5416cd71b109f4"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"a22fe9f52114db16349faf7f60b90a6e6d2821ce","unresolved":false,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"- List Service Endpoints Associated with Project For User:"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    ``GET /OS-EP-FILTER/projects/{project_id}/users/{user_id}/endpoints``"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"  Response:"},{"line_number":515,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"baada198_30612ed4","line":512,"in_reply_to":"baada198_48537616","updated":"2014-07-08 18:24:10.000000000","message":"Done","commit_id":"78a10d78471ec7a26d082d7e9e5416cd71b109f4"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"700d95737c45c56158e0caab3522f009c99ed0bb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"offer more fine grained capabilities for filtering service endpoints. In"},{"line_number":34,"context_line":"particular, we should be able to filter service endpoints according to service"},{"line_number":35,"context_line":"(e.g. Nova, Swift, etc) or interface type (e.g. admin, internal, etc) or region"},{"line_number":36,"context_line":"or any combination thereof."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"In addition, with the present Endpoint Filtering extension, managing service"},{"line_number":39,"context_line":"endpoints is a challenge due to the static nature of the relationship between a"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baada198_97e1029d","line":36,"updated":"2014-07-09 05:04:10.000000000","message":"I think you might need to re-look at the wording here now that you\u0027ve pulled out users.","commit_id":"d5dde97e117417952ace7dcae19f1e93e0ae7226"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"6d43b8af29c2f38fce91ed09f05a7f052dbdd614","unresolved":false,"context_lines":[{"line_number":33,"context_line":"offer more fine grained capabilities for filtering service endpoints. In"},{"line_number":34,"context_line":"particular, we should be able to filter service endpoints according to service"},{"line_number":35,"context_line":"(e.g. Nova, Swift, etc) or interface type (e.g. admin, internal, etc) or region"},{"line_number":36,"context_line":"or any combination thereof."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"In addition, with the present Endpoint Filtering extension, managing service"},{"line_number":39,"context_line":"endpoints is a challenge due to the static nature of the relationship between a"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baada198_c8175b53","line":36,"in_reply_to":"baada198_97e1029d","updated":"2014-07-09 08:36:50.000000000","message":"It\u0027s entering the wee hours on the West Coast of the US and I may have missed something here but I don\u0027t believe the above paragraph mentions anything other than filtering based on endpoint specific attributes.","commit_id":"d5dde97e117417952ace7dcae19f1e93e0ae7226"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"700d95737c45c56158e0caab3522f009c99ed0bb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  service (e.g. Swift) and region (e.g. US-West)."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* The Multi-Attribute Endpoint Filter provides a superset of the Endpoint"},{"line_number":67,"context_line":"  Filter functionality that was added to Keystone as an extension in Havana."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Alternatives"},{"line_number":70,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baada198_17d6d2c5","line":67,"updated":"2014-07-09 05:04:10.000000000","message":"benefit?","commit_id":"d5dde97e117417952ace7dcae19f1e93e0ae7226"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"6d43b8af29c2f38fce91ed09f05a7f052dbdd614","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  service (e.g. Swift) and region (e.g. US-West)."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* The Multi-Attribute Endpoint Filter provides a superset of the Endpoint"},{"line_number":67,"context_line":"  Filter functionality that was added to Keystone as an extension in Havana."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Alternatives"},{"line_number":70,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baada198_68856fac","line":67,"in_reply_to":"baada198_17d6d2c5","updated":"2014-07-09 08:36:50.000000000","message":"The benefit is that the multi-attribute endpoint grouping approach can be used to match the existing endpoint filter functionality and thus make it redundant.","commit_id":"d5dde97e117417952ace7dcae19f1e93e0ae7226"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"700d95737c45c56158e0caab3522f009c99ed0bb","unresolved":false,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":"- List Service Endpoints Associated with Project:"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    ``GET /OS-EP-FILTER/projects/{project_id}/endpoints``"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"  Response:"},{"line_number":345,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"baada198_b778c6f9","line":342,"updated":"2014-07-09 05:04:10.000000000","message":"This URL is the same....","commit_id":"d5dde97e117417952ace7dcae19f1e93e0ae7226"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"700d95737c45c56158e0caab3522f009c99ed0bb","unresolved":false,"context_lines":[{"line_number":422,"context_line":""},{"line_number":423,"context_line":"- List Service Endpoints Associated with Project:"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    ``GET /OS-EP-FILTER/projects/{project_id}/endpoints``"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"  Response:"},{"line_number":428,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"baada198_d77d3ae9","line":425,"updated":"2014-07-09 05:04:10.000000000","message":"... as this URL. Do the sections need to be combined?","commit_id":"d5dde97e117417952ace7dcae19f1e93e0ae7226"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"6d43b8af29c2f38fce91ed09f05a7f052dbdd614","unresolved":false,"context_lines":[{"line_number":422,"context_line":""},{"line_number":423,"context_line":"- List Service Endpoints Associated with Project:"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    ``GET /OS-EP-FILTER/projects/{project_id}/endpoints``"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"  Response:"},{"line_number":428,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"baada198_88056316","line":425,"in_reply_to":"baada198_d77d3ae9","updated":"2014-07-09 08:36:50.000000000","message":"Good catch. Done.","commit_id":"d5dde97e117417952ace7dcae19f1e93e0ae7226"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"700d95737c45c56158e0caab3522f009c99ed0bb","unresolved":false,"context_lines":[{"line_number":483,"context_line":"Generally speaking this change should reduce the size of the service catalog"},{"line_number":484,"context_line":"included in a project scoped tokens since we are filtering service endpoints."},{"line_number":485,"context_line":"The performance impact of the filtering itself should be minimal and by default"},{"line_number":486,"context_line":"filtering is not enabled."},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"Other Deployer Impact"},{"line_number":489,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baada198_774d4ec4","line":486,"updated":"2014-07-09 05:04:10.000000000","message":"Probably minimal, If i\u0027m thinking about this correctly a filter maps almost directly to a query on the endpoint table and you shouldn\u0027t need to do any python side filtering. \n\nSo each auth will grow by one SQL query to find all the groups associated with the project, and then one SQL query per associated group. I don\u0027t expect there is a good way to index the group lookup either because it can contain any number of filter options.\n\nThat\u0027s not unreasonable, but it\u0027s probably worth mentioning.","commit_id":"d5dde97e117417952ace7dcae19f1e93e0ae7226"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"6d43b8af29c2f38fce91ed09f05a7f052dbdd614","unresolved":false,"context_lines":[{"line_number":483,"context_line":"Generally speaking this change should reduce the size of the service catalog"},{"line_number":484,"context_line":"included in a project scoped tokens since we are filtering service endpoints."},{"line_number":485,"context_line":"The performance impact of the filtering itself should be minimal and by default"},{"line_number":486,"context_line":"filtering is not enabled."},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"Other Deployer Impact"},{"line_number":489,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baada198_c3fe5c05","line":486,"in_reply_to":"baada198_774d4ec4","updated":"2014-07-09 08:36:50.000000000","message":"Good point. I\u0027ve added this information.","commit_id":"d5dde97e117417952ace7dcae19f1e93e0ae7226"}]}
