)]}'
{"specs/juno/del-tokens-when-del-ec2-credential.rst":[{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"9f47b40d476114d5339e2297d6b27bd050123ba6","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Example Spec - The title of your blueprint"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/keystone/+spec/del-tokens-when-del-ec2-creden"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_029f8b60","line":8,"updated":"2014-06-30 18:56:54.000000000","message":"Missing title","commit_id":"520820b84e497837453da335e8d8defc93de1c48"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"9f47b40d476114d5339e2297d6b27bd050123ba6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"tial"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Currently, the associated tokens are not deleted when deleting ec2 credential."},{"line_number":16,"context_line":"So, the tokens got before can still be used. This may be a security hole."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_e221b7b5","line":15,"updated":"2014-06-30 18:56:54.000000000","message":"s/deleted/revoked\n\ns/ec2/\"an EC2\"","commit_id":"520820b84e497837453da335e8d8defc93de1c48"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"9f47b40d476114d5339e2297d6b27bd050123ba6","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Currently, the associated tokens are not deleted when deleting ec2 credential."},{"line_number":16,"context_line":"So, the tokens got before can still be used. This may be a security hole."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem Description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_d5362be7","line":16,"updated":"2014-06-30 18:56:54.000000000","message":"Re-phrase:\n\nAs a result, any existing tokens associated with the deleted EC2 credential are still valid. This is a security hole.","commit_id":"520820b84e497837453da335e8d8defc93de1c48"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"9f47b40d476114d5339e2297d6b27bd050123ba6","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Currently, the user can create a EC2 credential, and then get tokens via the"},{"line_number":22,"context_line":"EC2 credential. However, after deleting the credential, the associated tokens"},{"line_number":23,"context_line":"got before can still be used."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Proposed Change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_b51ff708","line":23,"updated":"2014-06-30 18:56:54.000000000","message":"Re-phrase the last sentence to:\n\nHowever, after deleting the EC2 credential, any associated tokens still valid, can still be used.","commit_id":"520820b84e497837453da335e8d8defc93de1c48"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"d75c66e29023bbf830f42e61265eedadba69e8de","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"When get token via EC2 credential, store the credential_id into token metadata."},{"line_number":29,"context_line":"Extend credential_id parameter for the token_api.list_tokens and"},{"line_number":30,"context_line":"token_api.delete_tokens method."},{"line_number":31,"context_line":"When delete EC2 credential, call token_api.delete_tokens to delete the tokens"},{"line_number":32,"context_line":"by credential_id."}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_d38803c9","line":29,"updated":"2014-06-30 19:53:22.000000000","message":"list_tokens is deprecated in Juno release:\n\nhttps://review.openstack.org/#/c/103417/","commit_id":"520820b84e497837453da335e8d8defc93de1c48"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"9f47b40d476114d5339e2297d6b27bd050123ba6","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Extend credential_id parameter for the token_api.list_tokens and"},{"line_number":30,"context_line":"token_api.delete_tokens method."},{"line_number":31,"context_line":"When delete EC2 credential, call token_api.delete_tokens to delete the tokens"},{"line_number":32,"context_line":"by credential_id."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Alternatives"},{"line_number":35,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_351207b5","line":32,"updated":"2014-06-30 18:56:54.000000000","message":"Can you re-phrase the proposed change better? Essentially the proposal is for the credential_id to be stored into the token metadata and then you are tightly coupling the actions of deleting an EC2 credential and removing the associated tokens. It\u0027s not clear from what is written why you are adding credential_id parameter to different functions.","commit_id":"520820b84e497837453da335e8d8defc93de1c48"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"9f47b40d476114d5339e2297d6b27bd050123ba6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Alternatives"},{"line_number":35,"context_line":"------------"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"None"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Data Model Impact"},{"line_number":40,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_421263b5","line":37,"updated":"2014-06-30 18:56:54.000000000","message":"Are there no other ways of implementing this? For instance, could you use the notification API that listens out for ec2 delete events and then have a token cleanup service? Also Steve Martinelli\tgave a proposed solution in https://review.openstack.org/#/c/87450 that should be detailed here and discussed.","commit_id":"520820b84e497837453da335e8d8defc93de1c48"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"9f47b40d476114d5339e2297d6b27bd050123ba6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"REST API Impact"},{"line_number":45,"context_line":"---------------"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"None"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Security Impact"},{"line_number":50,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_75447f74","line":47,"updated":"2014-06-30 18:56:54.000000000","message":"Is there no REST API Impact?","commit_id":"520820b84e497837453da335e8d8defc93de1c48"},{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"454e764038ed1100a2dc2f716939487871f2c91a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"REST API Impact"},{"line_number":45,"context_line":"---------------"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"None"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Security Impact"},{"line_number":50,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_d43c5896","line":47,"in_reply_to":"baada198_75447f74","updated":"2014-07-01 09:23:00.000000000","message":"Yes.","commit_id":"520820b84e497837453da335e8d8defc93de1c48"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"9f47b40d476114d5339e2297d6b27bd050123ba6","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Security Impact"},{"line_number":50,"context_line":"---------------"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Store the credential_id into token metadata, but the users can not get it."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Notifications Impact"},{"line_number":55,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_82355b48","line":52,"updated":"2014-06-30 18:56:54.000000000","message":"Why can the users not get it? More explanation please.","commit_id":"520820b84e497837453da335e8d8defc93de1c48"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"9f47b40d476114d5339e2297d6b27bd050123ba6","unresolved":false,"context_lines":[{"line_number":87,"context_line":"Work Items"},{"line_number":88,"context_line":"----------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"This has been implemented already:https://review.openstack.org/#/c/87450/"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Dependencies"},{"line_number":93,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_826d5b07","line":90,"updated":"2014-06-30 18:56:54.000000000","message":"Can you specify explicitly here the tasks involved?","commit_id":"520820b84e497837453da335e8d8defc93de1c48"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"9f47b40d476114d5339e2297d6b27bd050123ba6","unresolved":false,"context_lines":[{"line_number":105,"context_line":"Documentation Impact"},{"line_number":106,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"None"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"References"},{"line_number":111,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_b55d374b","line":108,"updated":"2014-06-30 18:56:54.000000000","message":"Is there no documentation impact?","commit_id":"520820b84e497837453da335e8d8defc93de1c48"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"9f47b40d476114d5339e2297d6b27bd050123ba6","unresolved":false,"context_lines":[{"line_number":110,"context_line":"References"},{"line_number":111,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_753b9feb","line":113,"updated":"2014-06-30 18:56:54.000000000","message":"Add the reference to the blueprint \thttps://blueprints.launchpad.net/keystone/+spec/del-tokens-when-del-ec2-credential","commit_id":"520820b84e497837453da335e8d8defc93de1c48"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"08a0e50ff06f2f15004da3de9c7e1fd500c44be8","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Currently, the tokens associated with an EC2 credential are not revoked when"},{"line_number":14,"context_line":"deleting that EC2 credential. As a result, any existing tokens associated with"},{"line_number":15,"context_line":"the deleted EC2 credential are still valid. This is security hardening."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem Description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_ec0c0896","line":15,"updated":"2014-07-30 18:15:40.000000000","message":"This should make an interesting debate. What about tokens that are issued via external authentication, such as Apache REMOTE_USER and Federation? There\u0027s no way Keystone can keep track of those credential as they are external. Then there\u0027s a consistency issue. Why are we only revoking tokens for Keystone-managed credentials?","commit_id":"dab7fa00fa179d5b1a4ed0a5607be94dc38c12cc"},{"author":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"change_message_id":"067177b2212fc1f166adec76e701d2271cf513ea","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem Description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Currently, the user can create an EC2 credential, and then get tokens via the"},{"line_number":21,"context_line":"EC2 credential. However, after deleting the EC2 credential, any associated"},{"line_number":22,"context_line":"tokens are still valid, and can still be used."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_00b9187c","line":20,"updated":"2014-07-30 06:51:35.000000000","message":"Suggest: Currently, an user can create an EC2 credential and tokens can be issued via the EC2 credential. However, the associated tokens are still valid even the EC2 credential has been deleted.","commit_id":"dab7fa00fa179d5b1a4ed0a5607be94dc38c12cc"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"08a0e50ff06f2f15004da3de9c7e1fd500c44be8","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Alternatives"},{"line_number":35,"context_line":"------------"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"1. Also need to store the ``credential_id`` into token metadata When creating a"},{"line_number":38,"context_line":"   token via EC2 credential. Then in token controller, register the event"},{"line_number":39,"context_line":"   callback for delete credential, and revoke the associated tokens in the"},{"line_number":40,"context_line":"   event callback. I think there is no difference between deleting credential"}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_8c92acfa","line":37,"updated":"2014-07-30 18:15:40.000000000","message":"Don\u0027t use metadata. Add an new indexable column for this. Doing linear search for credential-tokens will definitely hurt performance.","commit_id":"dab7fa00fa179d5b1a4ed0a5607be94dc38c12cc"},{"author":{"_account_id":11717,"name":"Ryan Oshima","email":"ryan.oshima@hp.com","username":"RyanOshima"},"change_message_id":"93615c9845530b78a2d649fb372bd6c9c4fea45d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"2. Similar to https://bugs.launchpad.net/python-keystoneclient/+bug/1291157,"},{"line_number":45,"context_line":"   ``keystoneclient.middleware.auth_token`` can track valid credential_ids on"},{"line_number":46,"context_line":"   GET /v3/users/{user_id}/credentials/OS-EC2 and compare them to tokens to"},{"line_number":47,"context_line":"   test for validity. Currently the credential data does not contain in the"},{"line_number":48,"context_line":"   token data, so we can not consider whether a token is associated with a"},{"line_number":49,"context_line":"   deleted credential_id. And even we can do this, keystone itself does not use"},{"line_number":50,"context_line":"   keystoneclient to authenticate token. As a result, the tokens associated"}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_ab84335e","line":47,"updated":"2014-07-14 17:07:00.000000000","message":"\"does\" -\u003e\"is\" \"contain\"-\u003e\"contained\"","commit_id":"dab7fa00fa179d5b1a4ed0a5607be94dc38c12cc"},{"author":{"_account_id":11717,"name":"Ryan Oshima","email":"ryan.oshima@hp.com","username":"RyanOshima"},"change_message_id":"93615c9845530b78a2d649fb372bd6c9c4fea45d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"   GET /v3/users/{user_id}/credentials/OS-EC2 and compare them to tokens to"},{"line_number":47,"context_line":"   test for validity. Currently the credential data does not contain in the"},{"line_number":48,"context_line":"   token data, so we can not consider whether a token is associated with a"},{"line_number":49,"context_line":"   deleted credential_id. And even we can do this, keystone itself does not use"},{"line_number":50,"context_line":"   keystoneclient to authenticate token. As a result, the tokens associated"},{"line_number":51,"context_line":"   with the deleted credential_id can still be used in keystone project."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_2bdf436a","line":49,"updated":"2014-07-14 17:07:00.000000000","message":"\"even if we\"","commit_id":"dab7fa00fa179d5b1a4ed0a5607be94dc38c12cc"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"f83a6ff572871ec8314379b52cf5580d3514b255","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Notifications Impact"},{"line_number":70,"context_line":"--------------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"None"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Other End User Impact"},{"line_number":75,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_0698bb1a","line":72,"updated":"2014-07-14 15:08:00.000000000","message":"It\u0027s mentioned that a revocation event is generated. Should information about this be mentioned here?","commit_id":"dab7fa00fa179d5b1a4ed0a5607be94dc38c12cc"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"f83a6ff572871ec8314379b52cf5580d3514b255","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Modify token provider common code to populate credential data into token"},{"line_number":108,"context_line":"metadata."},{"line_number":109,"context_line":"Modify token backends code to implement delete tokens by credential_id method."},{"line_number":110,"context_line":"Add test code."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Dependencies"},{"line_number":113,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_460e33e6","line":110,"updated":"2014-07-14 15:08:00.000000000","message":"Can we itemize the work items?","commit_id":"dab7fa00fa179d5b1a4ed0a5607be94dc38c12cc"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"f83a6ff572871ec8314379b52cf5580d3514b255","unresolved":false,"context_lines":[{"line_number":126,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"If uses delete a EC2 credential, any existing tokens associated with the"},{"line_number":129,"context_line":"deleted EC2 credential will automatically be revoked. "},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"References"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_66cc17bc","line":129,"updated":"2014-07-14 15:08:00.000000000","message":"white space at end of line","commit_id":"dab7fa00fa179d5b1a4ed0a5607be94dc38c12cc"}]}
