)]}'
{"specs/juno/generic-mapping-federation.rst":[{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"0542cebe8e35e049f96b54c6633ed3deb88cc3a6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Standardizing the federation process"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp generic-mapping-federation \u003chttps://blueprints.launchpad.net/keystone/+spec/reengineered-federation\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"We propose that the federated authentication process be reengineered so that"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_60e2dba1","line":11,"updated":"2014-07-22 22:11:00.000000000","message":"sorry about being so picky, but i think there should be https://blueprints.launchpad.net/keystone/+spec/generic-mapping-federation","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":5956,"name":"Kristy Siu","email":"kwss@kent.ac.uk","username":"kwss"},"change_message_id":"78f3c919006d44d8359c7770b1ccc89a46792c34","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Standardizing the federation process"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp generic-mapping-federation \u003chttps://blueprints.launchpad.net/keystone/+spec/reengineered-federation\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"We propose that the federated authentication process be reengineered so that"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_db429c67","line":11,"in_reply_to":"baada198_60e2dba1","updated":"2014-07-23 10:48:50.000000000","message":"I don\u0027t know if I can rename a blueprint, or if I should create a new one with the new name, if anyone knows please let me know :)","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"650b8c67a9a4a08539cc160eb79bdcfb87978ce8","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Standardizing the federation process"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp generic-mapping-federation \u003chttps://blueprints.launchpad.net/keystone/+spec/reengineered-federation\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"We propose that the federated authentication process be reengineered so that"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_d8045b1b","line":11,"in_reply_to":"baada198_db429c67","updated":"2014-07-23 13:47:45.000000000","message":"Did it for ya: \n\nhttps://blueprints.launchpad.net/keystone/+spec/generic-mapping-federation","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"0082efea5d0a9ebf9d97e2ff5931a7d0006899b0","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"We propose that the federated authentication process be reengineered so that"},{"line_number":15,"context_line":"a user_id is returned alongside the identity attributes. In addition, the"},{"line_number":16,"context_line":"saml2.py authentication module should be renamed as mapped.py to denote that it"},{"line_number":17,"context_line":"applies to all authentication methods which require the asserted identity"},{"line_number":18,"context_line":"attributes to be mapped into local attributes."}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_e57fdd15","line":15,"updated":"2014-07-22 23:40:48.000000000","message":"user_id is already returned with the existing design right?\n\nhttps://github.com/openstack/keystone/blob/master/keystone/auth/plugins/saml2.py#L80\n\nAlso, no big deal but mapped.py doesn\u0027t sound very intuitive. How about just federated.py, or external_identity.py?","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":5956,"name":"Kristy Siu","email":"kwss@kent.ac.uk","username":"kwss"},"change_message_id":"78f3c919006d44d8359c7770b1ccc89a46792c34","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"We propose that the federated authentication process be reengineered so that"},{"line_number":15,"context_line":"a user_id is returned alongside the identity attributes. In addition, the"},{"line_number":16,"context_line":"saml2.py authentication module should be renamed as mapped.py to denote that it"},{"line_number":17,"context_line":"applies to all authentication methods which require the asserted identity"},{"line_number":18,"context_line":"attributes to be mapped into local attributes."}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_5bfa0c44","line":15,"in_reply_to":"baada198_e57fdd15","updated":"2014-07-23 10:48:50.000000000","message":"gyee, take this up with ayoung, I\u0027m not fussed about naming as long as the end result works the same.","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"0082efea5d0a9ebf9d97e2ff5931a7d0006899b0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Problem Description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Currently, the federation code uses a named saml2 module for token creation"},{"line_number":25,"context_line":"and for managing the mapping and attribute extraction of external authentication"},{"line_number":26,"context_line":"data. While this is sufficient for the current release where only saml2 is"},{"line_number":27,"context_line":"supported as an authentication protocol, the upcoming changes for adding"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_8cc1e983","line":24,"updated":"2014-07-22 23:40:48.000000000","message":"The existing federation logic uses `saml2` auth plugin to establish a local Keystone identity, by mapping trusted external identity attributes to local identity attributes.","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"250fcc01227959da1b8cab758c621c512dfd0b0c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Problem Description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Currently, the federation code uses a named saml2 module for token creation"},{"line_number":25,"context_line":"and for managing the mapping and attribute extraction of external authentication"},{"line_number":26,"context_line":"data. While this is sufficient for the current release where only saml2 is"},{"line_number":27,"context_line":"supported as an authentication protocol, the upcoming changes for adding"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_7a236306","line":24,"in_reply_to":"baada198_8cc1e983","updated":"2014-07-23 02:08:12.000000000","message":"++","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"250fcc01227959da1b8cab758c621c512dfd0b0c","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Currently, the federation code uses a named saml2 module for token creation"},{"line_number":25,"context_line":"and for managing the mapping and attribute extraction of external authentication"},{"line_number":26,"context_line":"data. While this is sufficient for the current release where only saml2 is"},{"line_number":27,"context_line":"supported as an authentication protocol, the upcoming changes for adding"},{"line_number":28,"context_line":"`keystone-to-keystone federation \u003chttps://review.openstack.org/#/c/100023/20\u003e`_"},{"line_number":29,"context_line":"as well as any further additions mean that the saml2 naming is incorrect."}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_da71cf0d","line":26,"updated":"2014-07-23 02:08:12.000000000","message":"agree with David Hu, just state the problem, it won\u0027t work for adding new protocol support. Done.\n\nthe k2k stuff and the guaranteed user id isn\u0027t a problem that exists today (IMO)","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"0542cebe8e35e049f96b54c6633ed3deb88cc3a6","unresolved":false,"context_lines":[{"line_number":25,"context_line":"and for managing the mapping and attribute extraction of external authentication"},{"line_number":26,"context_line":"data. While this is sufficient for the current release where only saml2 is"},{"line_number":27,"context_line":"supported as an authentication protocol, the upcoming changes for adding"},{"line_number":28,"context_line":"`keystone-to-keystone federation \u003chttps://review.openstack.org/#/c/100023/20\u003e`_"},{"line_number":29,"context_line":"as well as any further additions mean that the saml2 naming is incorrect."},{"line_number":30,"context_line":"Additionally, we should require that the extraction of asserted attributes"},{"line_number":31,"context_line":"guarantees that we will receive a user ID amongst the extracted data."}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_06fdb808","line":28,"updated":"2014-07-22 22:11:00.000000000","message":"From the SP perspective everything stays, from the Keystone-IdP (new features) there is some indication that the openstack token will be traded for the SAML assertion, but it\u0027s doesn\u0027t necesarilly involve saml/mapped keystone auth methods..\nI mean, I don\u0027t see link between those two bps.","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"0082efea5d0a9ebf9d97e2ff5931a7d0006899b0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"data. While this is sufficient for the current release where only saml2 is"},{"line_number":27,"context_line":"supported as an authentication protocol, the upcoming changes for adding"},{"line_number":28,"context_line":"`keystone-to-keystone federation \u003chttps://review.openstack.org/#/c/100023/20\u003e`_"},{"line_number":29,"context_line":"as well as any further additions mean that the saml2 naming is incorrect."},{"line_number":30,"context_line":"Additionally, we should require that the extraction of asserted attributes"},{"line_number":31,"context_line":"guarantees that we will receive a user ID amongst the extracted data."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_6c44951b","line":29,"updated":"2014-07-22 23:40:48.000000000","message":"means that federation is not limited to saml2","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"250fcc01227959da1b8cab758c621c512dfd0b0c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"data. While this is sufficient for the current release where only saml2 is"},{"line_number":27,"context_line":"supported as an authentication protocol, the upcoming changes for adding"},{"line_number":28,"context_line":"`keystone-to-keystone federation \u003chttps://review.openstack.org/#/c/100023/20\u003e`_"},{"line_number":29,"context_line":"as well as any further additions mean that the saml2 naming is incorrect."},{"line_number":30,"context_line":"Additionally, we should require that the extraction of asserted attributes"},{"line_number":31,"context_line":"guarantees that we will receive a user ID amongst the extracted data."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_9a391742","line":29,"in_reply_to":"baada198_6c44951b","updated":"2014-07-23 02:08:12.000000000","message":"++","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"dc3a2e7843529a1b487943270d1f3b1d174d285d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"`keystone-to-keystone federation \u003chttps://review.openstack.org/#/c/100023/20\u003e`_"},{"line_number":29,"context_line":"as well as any further additions mean that the saml2 naming is incorrect."},{"line_number":30,"context_line":"Additionally, we should require that the extraction of asserted attributes"},{"line_number":31,"context_line":"guarantees that we will receive a user ID amongst the extracted data."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed Change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_bae41b3d","line":31,"updated":"2014-07-23 01:44:13.000000000","message":"Please consider stating the problem today without the return or without the guarantee of the return of user_id.","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"250fcc01227959da1b8cab758c621c512dfd0b0c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"`keystone-to-keystone federation \u003chttps://review.openstack.org/#/c/100023/20\u003e`_"},{"line_number":29,"context_line":"as well as any further additions mean that the saml2 naming is incorrect."},{"line_number":30,"context_line":"Additionally, we should require that the extraction of asserted attributes"},{"line_number":31,"context_line":"guarantees that we will receive a user ID amongst the extracted data."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed Change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_5a0f7f88","line":31,"updated":"2014-07-23 02:08:12.000000000","message":"the mapping engine today will raise an exception if no user if is generated, so i\u0027m not sure what the issue is? unless you\u0027re talking about the pre-mapped values.","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"0082efea5d0a9ebf9d97e2ff5931a7d0006899b0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"`keystone-to-keystone federation \u003chttps://review.openstack.org/#/c/100023/20\u003e`_"},{"line_number":29,"context_line":"as well as any further additions mean that the saml2 naming is incorrect."},{"line_number":30,"context_line":"Additionally, we should require that the extraction of asserted attributes"},{"line_number":31,"context_line":"guarantees that we will receive a user ID amongst the extracted data."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed Change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_ac1a2d16","line":31,"updated":"2014-07-22 23:40:48.000000000","message":"we also need the map to be generic. Not just limited to user_id and group_ids.","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":5956,"name":"Kristy Siu","email":"kwss@kent.ac.uk","username":"kwss"},"change_message_id":"78f3c919006d44d8359c7770b1ccc89a46792c34","unresolved":false,"context_lines":[{"line_number":28,"context_line":"`keystone-to-keystone federation \u003chttps://review.openstack.org/#/c/100023/20\u003e`_"},{"line_number":29,"context_line":"as well as any further additions mean that the saml2 naming is incorrect."},{"line_number":30,"context_line":"Additionally, we should require that the extraction of asserted attributes"},{"line_number":31,"context_line":"guarantees that we will receive a user ID amongst the extracted data."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed Change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_bb640822","line":31,"in_reply_to":"baada198_5a0f7f88","updated":"2014-07-23 10:48:50.000000000","message":"It should be possible to map on user_id, which we can\u0027t do as we don\u0027t have it until after mapping has taken place. The user ID should be taken directly from the premapped values and then it can be used as a value in mapping.","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"0082efea5d0a9ebf9d97e2ff5931a7d0006899b0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"In order to resolve the problem the following changes should be made:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"#. The saml2.py file should be renamed as mapped.py"},{"line_number":39,"context_line":"#. The method name \"saml2\" should be removed from mapped.py"},{"line_number":40,"context_line":"#. The function for extracting attributes should return a user_id among the asserted attributes."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_4cdb514f","line":39,"updated":"2014-07-22 23:40:48.000000000","message":"I presume the new method name is \"mapped\"?","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"250fcc01227959da1b8cab758c621c512dfd0b0c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"In order to resolve the problem the following changes should be made:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"#. The saml2.py file should be renamed as mapped.py"},{"line_number":39,"context_line":"#. The method name \"saml2\" should be removed from mapped.py"},{"line_number":40,"context_line":"#. The function for extracting attributes should return a user_id among the asserted attributes."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_5a5dbf78","line":39,"in_reply_to":"baada198_4cdb514f","updated":"2014-07-23 02:08:12.000000000","message":"yes, I think most are in agreement that \u0027mapped\u0027 is weird.","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":5956,"name":"Kristy Siu","email":"kwss@kent.ac.uk","username":"kwss"},"change_message_id":"78f3c919006d44d8359c7770b1ccc89a46792c34","unresolved":false,"context_lines":[{"line_number":36,"context_line":"In order to resolve the problem the following changes should be made:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"#. The saml2.py file should be renamed as mapped.py"},{"line_number":39,"context_line":"#. The method name \"saml2\" should be removed from mapped.py"},{"line_number":40,"context_line":"#. The function for extracting attributes should return a user_id among the asserted attributes."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_dbfc5c75","line":39,"in_reply_to":"baada198_5a5dbf78","updated":"2014-07-23 10:48:50.000000000","message":"Ok so after a long chat with ayoung last night, the conclusion is that saml2, openidc, x509 etc will be the method name, and they will share use of the Mapped plugin. If a protocol requires special handling then a subclass of the Mapped plugin can be created. The functionality for mapping and assertion data extraction should be split so that the protocol independent mapping (and later trusted attribute policy filtering) can be reused, while the extraction of assertion data can be overridden. I will update the spec shortly to reflect this.","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"0542cebe8e35e049f96b54c6633ed3deb88cc3a6","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#. The saml2.py file should be renamed as mapped.py"},{"line_number":39,"context_line":"#. The method name \"saml2\" should be removed from mapped.py"},{"line_number":40,"context_line":"#. The function for extracting attributes should return a user_id among the asserted attributes."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_408317a9","line":41,"updated":"2014-07-22 22:11:00.000000000","message":"why not enumerate the changes?\nAlso, what about loading some underlying protocol-specific plugins?","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"250fcc01227959da1b8cab758c621c512dfd0b0c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#. The saml2.py file should be renamed as mapped.py"},{"line_number":39,"context_line":"#. The method name \"saml2\" should be removed from mapped.py"},{"line_number":40,"context_line":"#. The function for extracting attributes should return a user_id among the asserted attributes."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_fa2853f0","line":41,"in_reply_to":"baada198_408317a9","updated":"2014-07-23 02:08:12.000000000","message":"the changes will be enumerated in the generated html.","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"dc3a2e7843529a1b487943270d1f3b1d174d285d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"------------"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Alternatively no changes could be made but this is undesirable as it makes no"},{"line_number":47,"context_line":"sense for non SAML assertion data to be processed by a module named saml2.py."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Security Impact"},{"line_number":50,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_9a6cb79f","line":47,"updated":"2014-07-23 01:44:13.000000000","message":"Any alternatives if the return of user_id is not gauranteed?","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"ebed9b0a03fd825a0abadbfb5eb16ac3cfb60122","unresolved":false,"context_lines":[{"line_number":44,"context_line":"------------"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Alternatively no changes could be made but this is undesirable as it makes no"},{"line_number":47,"context_line":"sense for non SAML assertion data to be processed by a module named saml2.py."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Security Impact"},{"line_number":50,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_0334bff9","line":47,"in_reply_to":"baada198_9a4e77c1","updated":"2014-07-23 05:16:47.000000000","message":"My understanding based on the problem described at line 30, 31 and proposed change at line line 40 was that we needed a way to \"guarantee\" that an user_id is generated.  Maybe I am not understanding this correctly, but perhaps someone can elaborate on the proposed change at line 40.","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"250fcc01227959da1b8cab758c621c512dfd0b0c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"------------"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Alternatively no changes could be made but this is undesirable as it makes no"},{"line_number":47,"context_line":"sense for non SAML assertion data to be processed by a module named saml2.py."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Security Impact"},{"line_number":50,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_9a4e77c1","line":47,"in_reply_to":"baada198_9a6cb79f","updated":"2014-07-23 02:08:12.000000000","message":"why is the user_id coming up now?","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"250fcc01227959da1b8cab758c621c512dfd0b0c","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"This would force developers to implement new federated protocols in a"},{"line_number":78,"context_line":"standardized way by requiring the attribute extraction / retrieval process to"},{"line_number":79,"context_line":"return a user_id among the asserted attributes."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_faebf378","line":79,"updated":"2014-07-23 02:08:12.000000000","message":"Not really an impact as we are not changing anything that exists.\n\nIt\u0027s just a note that future protocols should adhere to the new federation architecture.","commit_id":"49e81bcd54f943d366b1ac5a87d2084cb20a8ef1"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"96db8c0eef686adf620fd6db27c944d30e6dbe60","unresolved":false,"context_lines":[{"line_number":24,"context_line":"The existing federation logic uses `saml2` auth plugin to establish a local"},{"line_number":25,"context_line":"Keystone identity, by mapping trusted external identity attributes to local"},{"line_number":26,"context_line":"identity attributes. Now that other federation protocols will be supported by"},{"line_number":27,"context_line":"Keystone, it makes no sense to apply mapping via a saml2 plugin.Additionally,"},{"line_number":28,"context_line":"it is not currently possible to perform mapping on the user ID as this is"},{"line_number":29,"context_line":"determined by the mapping layer. Federated authentication protocols already"},{"line_number":30,"context_line":"have existing ways to determine the ID of the user, and this should be"}],"source_content_type":"text/x-rst","patch_set":10,"id":"baada198_9b59fdff","line":27,"updated":"2014-07-23 13:47:53.000000000","message":"add a space between the period here.","commit_id":"67cdbde53bb15b305fc7044fc3e8f36101de9945"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"96db8c0eef686adf620fd6db27c944d30e6dbe60","unresolved":false,"context_lines":[{"line_number":26,"context_line":"identity attributes. Now that other federation protocols will be supported by"},{"line_number":27,"context_line":"Keystone, it makes no sense to apply mapping via a saml2 plugin.Additionally,"},{"line_number":28,"context_line":"it is not currently possible to perform mapping on the user ID as this is"},{"line_number":29,"context_line":"determined by the mapping layer. Federated authentication protocols already"},{"line_number":30,"context_line":"have existing ways to determine the ID of the user, and this should be"},{"line_number":31,"context_line":"leveraged by the protocol specific attribute extraction code."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"baada198_bb796132","line":29,"updated":"2014-07-23 13:47:53.000000000","message":"This sentence sounds very contradictory: \n\n\"It is not currently possible to perform mapping on the user ID as this is determined by the mapping layer.\"\n\nHow about a re-write of the last 2 sentences to:\n\n\"Some federation authentication protocols already determine the ID of the user, this should be leveraged by the protocol specific sub modules and not the mapping engine.\"","commit_id":"67cdbde53bb15b305fc7044fc3e8f36101de9945"}],"specs/juno/reengineered-federation.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"3ee46829b650c1389a71a83e0c55d86add348dc3","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Re-engineering Federation to standardize mapping and token creation"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp reengineered-federation \u003chttps://blueprints.launchpad.net/keystone/+spec/example\u003e`_"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_03ad629c","line":8,"updated":"2014-07-03 05:48:20.000000000","message":"this is a mouthful! anything shorter?","commit_id":"5f286ea7ce883b007241415c547d4c8fd7caefa6"},{"author":{"_account_id":5956,"name":"Kristy Siu","email":"kwss@kent.ac.uk","username":"kwss"},"change_message_id":"be8fb5701c949f5266e449d544e438b3f776af82","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Re-engineering Federation to standardize mapping and token creation"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp reengineered-federation \u003chttps://blueprints.launchpad.net/keystone/+spec/example\u003e`_"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_69c51c3b","line":8,"in_reply_to":"baada198_03ad629c","updated":"2014-07-03 08:54:16.000000000","message":"Hmm I\u0027m sure there is a shorter way to word it.\n\nHow about: Standardizing the Federation process?","commit_id":"5f286ea7ce883b007241415c547d4c8fd7caefa6"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"3ee46829b650c1389a71a83e0c55d86add348dc3","unresolved":false,"context_lines":[{"line_number":51,"context_line":"* The data should be passed to the appropriate protocol module based on the"},{"line_number":52,"context_line":"  specified protocol_id. The data should be processed according to the needs of"},{"line_number":53,"context_line":"  the protocol and the following data extracted:"},{"line_number":54,"context_line":"  "},{"line_number":55,"context_line":"    * unique user ID (user_id)"},{"line_number":56,"context_line":"    * authenticating IdP (idp_id)"},{"line_number":57,"context_line":"    * list of dictionaries containing:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_23b0a6f3","line":54,"updated":"2014-07-03 05:48:20.000000000","message":"whitespace","commit_id":"5f286ea7ce883b007241415c547d4c8fd7caefa6"},{"author":{"_account_id":136,"name":"Tim Bell","email":"tim.bell@cern.ch","username":"tim-bell"},"change_message_id":"967dd3e6804522aefd1f6a8a678ca44edb6ae88d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"---------------------"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"This will not affect existing client operation, but ideally, clients should be"},{"line_number":107,"context_line":"updated to work with any avilable protocols."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Performance Impact"},{"line_number":110,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_430d9a3d","line":107,"updated":"2014-07-03 06:17:45.000000000","message":"To clarify, the proposal would have no impact on end users.\n\nWhat would be the impact for those operating clouds ?","commit_id":"5f286ea7ce883b007241415c547d4c8fd7caefa6"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"3ee46829b650c1389a71a83e0c55d86add348dc3","unresolved":false,"context_lines":[{"line_number":126,"context_line":"-----------"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Primary assignee:"},{"line_number":129,"context_line":"  None"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Other contributors:"},{"line_number":132,"context_line":"  None"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_e38cee37","line":129,"updated":"2014-07-03 05:48:20.000000000","message":"assignees would be nice","commit_id":"5f286ea7ce883b007241415c547d4c8fd7caefa6"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c02e2a0e17a6e386c4ceff8c0300206f8bf5ea50","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Standardizing the federation process"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp reengineered-federation \u003chttps://blueprints.launchpad.net/keystone/+spec/example\u003e`_"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_cdae0d2e","line":8,"updated":"2014-07-04 04:35:01.000000000","message":"much better :)","commit_id":"0cb7b3eef29189e88c76676d0769945eddf67173"},{"author":{"_account_id":5956,"name":"Kristy Siu","email":"kwss@kent.ac.uk","username":"kwss"},"change_message_id":"ad6edbe77002f3ebb1c25b6d7b824cfd154aa45b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"of authentication / authorization processes for all protocols"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"In order to achieve this, incoming authentication requests from federated"},{"line_number":37,"context_line":"sources should following a common flow, using the same protocol independent"},{"line_number":38,"context_line":"modules to manage any common functions, and delegating any protocol dependent"},{"line_number":39,"context_line":"logic to protocol specific modules."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_1db12f47","line":37,"updated":"2014-07-03 13:15:48.000000000","message":"follow*","commit_id":"0cb7b3eef29189e88c76676d0769945eddf67173"},{"author":{"_account_id":5956,"name":"Kristy Siu","email":"kwss@kent.ac.uk","username":"kwss"},"change_message_id":"ad6edbe77002f3ebb1c25b6d7b824cfd154aa45b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"  but should be renamed federated token creation)."},{"line_number":67,"context_line":"* Optionally, it should be allowed for deployments to choose to package the"},{"line_number":68,"context_line":"  original attribute assertions in the final token alongside the mapped groups"},{"line_number":69,"context_line":"  and attributes. Those implimentation concerned about token size would only"},{"line_number":70,"context_line":"  hold the mapped data, those that want full provenance information would add the"},{"line_number":71,"context_line":"  mapped data to the list of identity attributes/IdP issuer"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_5db7273a","line":69,"updated":"2014-07-03 13:15:48.000000000","message":"implementations*","commit_id":"0cb7b3eef29189e88c76676d0769945eddf67173"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c02e2a0e17a6e386c4ceff8c0300206f8bf5ea50","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        }"},{"line_number":99,"context_line":"    }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"keystone/auth/plugins/saml2.py should become keystone/auth/plugins/federation.py"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"And inside this: ::"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_f8c54d5c","line":101,"updated":"2014-07-04 04:35:01.000000000","message":"rather than rename it, we should probably mark the saml2 one as deprecated and just re-route the functionality to federation.py","commit_id":"0cb7b3eef29189e88c76676d0769945eddf67173"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c02e2a0e17a6e386c4ceff8c0300206f8bf5ea50","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _handle_unscoped_token(self, context, auth_payload):"},{"line_number":129,"context_line":"            assertion \u003d utils.get_assertion_data(context, auth_payload)"},{"line_number":130,"context_line":"            # Should contain user_id, authenticating_idp and attributes"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"            identity_provider \u003d auth_payload[\u0027identity_provider\u0027]"},{"line_number":133,"context_line":"            protocol \u003d auth_payload[\u0027protocol\u0027]"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_8d7095dd","line":130,"updated":"2014-07-04 04:35:01.000000000","message":"why not just get the authenticating idp should from auth_payload?\n\notherwise, i agree that user_id and attributes should definitely be coming back from \u0027get_assertion_data\u0027.\n\nCan we agree that a user_id must be present?","commit_id":"0cb7b3eef29189e88c76676d0769945eddf67173"},{"author":{"_account_id":5956,"name":"Kristy Siu","email":"kwss@kent.ac.uk","username":"kwss"},"change_message_id":"4b66d55048c43c44a937995ce2c22a9149d7e351","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _handle_unscoped_token(self, context, auth_payload):"},{"line_number":129,"context_line":"            assertion \u003d utils.get_assertion_data(context, auth_payload)"},{"line_number":130,"context_line":"            # Should contain user_id, authenticating_idp and attributes"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"            identity_provider \u003d auth_payload[\u0027identity_provider\u0027]"},{"line_number":133,"context_line":"            protocol \u003d auth_payload[\u0027protocol\u0027]"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_8214b4e9","line":130,"in_reply_to":"baada198_2bce8e2e","updated":"2014-07-07 08:21:08.000000000","message":"Agreed!","commit_id":"0cb7b3eef29189e88c76676d0769945eddf67173"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"2458991c06d9bd23d28267e9a5b845ebc7db8329","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _handle_unscoped_token(self, context, auth_payload):"},{"line_number":129,"context_line":"            assertion \u003d utils.get_assertion_data(context, auth_payload)"},{"line_number":130,"context_line":"            # Should contain user_id, authenticating_idp and attributes"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"            identity_provider \u003d auth_payload[\u0027identity_provider\u0027]"},{"line_number":133,"context_line":"            protocol \u003d auth_payload[\u0027protocol\u0027]"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_2bce8e2e","line":130,"in_reply_to":"baada198_8d7095dd","updated":"2014-07-04 07:41:40.000000000","message":"++ on user_id","commit_id":"0cb7b3eef29189e88c76676d0769945eddf67173"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c02e2a0e17a6e386c4ceff8c0300206f8bf5ea50","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            if k.startswith(prefix):"},{"line_number":161,"context_line":"                yield (k, v)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"(The logic of this now being in the saml2.py module.)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"And this function added: ::"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_58f0f9fd","line":163,"updated":"2014-07-04 04:35:01.000000000","message":"I\u0027d drop the ()\u0027s","commit_id":"0cb7b3eef29189e88c76676d0769945eddf67173"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c02e2a0e17a6e386c4ceff8c0300206f8bf5ea50","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"And this function added: ::"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def get_assertion_data(self, context, auth_payload):"},{"line_number":168,"context_line":"        protocol_module \u003d #load the correct protocol module from the protocol"},{"line_number":169,"context_line":"                           the auth_payload"},{"line_number":170,"context_line":"        return protocol_module.get_assertion_data(context, auth_payload)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_b873d57e","line":167,"updated":"2014-07-04 04:35:01.000000000","message":"What you could do in utils.py:\n\n  get_assertion_data(context, auth_payload):\n    protocol \u003d auth_payload[\u0027protocol\u0027]\n    if protocol \u003d\u003d \u0027saml2\u0027\n      saml2.get_assertion_data(context)\n    else if protocol \u003d\u003d \u0027moonshot\u0027\n      ....\n    else if protocol \u003d\u003d \u0027keystone\u0027\n      ....","commit_id":"0cb7b3eef29189e88c76676d0769945eddf67173"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"04eb0af02b1e2c259ebe3c8a47d30a829ebbad29","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"And this function added: ::"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def get_assertion_data(self, context, auth_payload):"},{"line_number":168,"context_line":"        protocol_module \u003d #load the correct protocol module from the protocol"},{"line_number":169,"context_line":"                           the auth_payload"},{"line_number":170,"context_line":"        return protocol_module.get_assertion_data(context, auth_payload)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_cba8a3dd","line":167,"in_reply_to":"baada198_2b384eee","updated":"2014-07-04 15:53:27.000000000","message":"++","commit_id":"0cb7b3eef29189e88c76676d0769945eddf67173"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"2458991c06d9bd23d28267e9a5b845ebc7db8329","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"And this function added: ::"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def get_assertion_data(self, context, auth_payload):"},{"line_number":168,"context_line":"        protocol_module \u003d #load the correct protocol module from the protocol"},{"line_number":169,"context_line":"                           the auth_payload"},{"line_number":170,"context_line":"        return protocol_module.get_assertion_data(context, auth_payload)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_2b384eee","line":167,"in_reply_to":"baada198_b873d57e","updated":"2014-07-04 07:41:40.000000000","message":"I\u0027d rather do some dynamic module loading (stevedore?), maybe limited to possible plugins names (list of available plugins still configurable via keystone.conf)\nThis will be a much cleaner solution rather that if elif elif elif elif else blocks.","commit_id":"0cb7b3eef29189e88c76676d0769945eddf67173"},{"author":{"_account_id":5956,"name":"Kristy Siu","email":"kwss@kent.ac.uk","username":"kwss"},"change_message_id":"4b66d55048c43c44a937995ce2c22a9149d7e351","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"And this function added: ::"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def get_assertion_data(self, context, auth_payload):"},{"line_number":168,"context_line":"        protocol_module \u003d #load the correct protocol module from the protocol"},{"line_number":169,"context_line":"                           the auth_payload"},{"line_number":170,"context_line":"        return protocol_module.get_assertion_data(context, auth_payload)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_22ea08db","line":167,"in_reply_to":"baada198_cba8a3dd","updated":"2014-07-07 08:21:08.000000000","message":"I was definitely thinking something dynamic, configured via keystone.conf.","commit_id":"0cb7b3eef29189e88c76676d0769945eddf67173"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c02e2a0e17a6e386c4ceff8c0300206f8bf5ea50","unresolved":false,"context_lines":[{"line_number":260,"context_line":""},{"line_number":261,"context_line":"Work Items"},{"line_number":262,"context_line":"----------"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"* Reengineer the current federation process"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_18ecc1f2","line":263,"updated":"2014-07-04 04:35:01.000000000","message":"another work item would be to update sample config to add \u0027federation\u0027 as an auth method, and more importantly deprecate the saml2 one.\n\nI think we should give it the usual 2 releases before we take it away completely.","commit_id":"0cb7b3eef29189e88c76676d0769945eddf67173"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c02e2a0e17a6e386c4ceff8c0300206f8bf5ea50","unresolved":false,"context_lines":[{"line_number":262,"context_line":"----------"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"* Reengineer the current federation process"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"Dependencies"},{"line_number":268,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_185da115","line":265,"updated":"2014-07-04 04:35:01.000000000","message":"It sounds like we\u0027re making the \u0027protocol\u0027 piece of the URL trigger the federation specific module right?\n\nIt would be a good idea to probably add a work item to update the documentation to reflect this, and stating giving a list of hard-coded / acceptable \u0027protocol\u0027 values.","commit_id":"0cb7b3eef29189e88c76676d0769945eddf67173"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c35d925e247a28a9951e64218370921a6925288d","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            identity_provider \u003d auth_payload[\u0027identity_provider\u0027]"},{"line_number":133,"context_line":"            protocol \u003d auth_payload[\u0027protocol\u0027]"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"            aggregated_mapped_properties \u003d None"},{"line_number":136,"context_line":"            # Loop through assertion data to handle aggregation"},{"line_number":137,"context_line":"            for attribute_set in assertion.get(\"attributes\"):"},{"line_number":138,"context_line":"                idp \u003d attribute_set.get(\"issuing_idp\")"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_7d4ad655","line":135,"updated":"2014-07-07 13:50:38.000000000","message":"you had me until this part, why introduce a new concept in the code and not mention it elsewhere? \n\nI don\u0027t fully understand what it is, since there are no comments or explanation. \n\nIs this a bug that we can resolve independently of re-engineering?","commit_id":"dc036b21bc1164ae6c559807dd852dfcc4f3ad8d"},{"author":{"_account_id":5956,"name":"Kristy Siu","email":"kwss@kent.ac.uk","username":"kwss"},"change_message_id":"68e1e6e442e8f6f6eae2350bc8b06473a8f1aec8","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            identity_provider \u003d auth_payload[\u0027identity_provider\u0027]"},{"line_number":133,"context_line":"            protocol \u003d auth_payload[\u0027protocol\u0027]"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"            aggregated_mapped_properties \u003d None"},{"line_number":136,"context_line":"            # Loop through assertion data to handle aggregation"},{"line_number":137,"context_line":"            for attribute_set in assertion.get(\"attributes\"):"},{"line_number":138,"context_line":"                idp \u003d attribute_set.get(\"issuing_idp\")"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_52c25853","line":135,"in_reply_to":"baada198_7d4ad655","updated":"2014-07-07 16:10:26.000000000","message":"Actually, the return data for protocol modules is specified around line 55, but handling for attribute aggregation could be added separately, and maybe there is a better way to do it. I\u0027ll put up a new patch without attribute aggregation and we can come back to it later.","commit_id":"dc036b21bc1164ae6c559807dd852dfcc4f3ad8d"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c35d925e247a28a9951e64218370921a6925288d","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"            aggregated_mapped_properties \u003d None"},{"line_number":136,"context_line":"            # Loop through assertion data to handle aggregation"},{"line_number":137,"context_line":"            for attribute_set in assertion.get(\"attributes\"):"},{"line_number":138,"context_line":"                idp \u003d attribute_set.get(\"issuing_idp\")"},{"line_number":139,"context_line":"                mapping \u003d self.federation_api.get_mapping_from_idp_and_protocol("},{"line_number":140,"context_line":"                    idp, protocol)"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_ddef621c","line":137,"updated":"2014-07-07 13:50:38.000000000","message":"there is no guarantee that assertion will have \u0027attributes\u0027. \nPreviously ``assertion`` from get_assertion_data was just a dict\n\n  {ADFS_AUTHLEVEL: Normal, ADFS_BUILDING: XYZ. ADFS_DEPARTMENT: IT,\n  ADFS_EMAIL: marek.denis@example.com, ADFS_FEDERATION: CERN,\n  ADFS_FIRSTNAME: Marek}","commit_id":"dc036b21bc1164ae6c559807dd852dfcc4f3ad8d"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c35d925e247a28a9951e64218370921a6925288d","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                rules \u003d jsonutils.loads(mapping[\u0027rules\u0027])"},{"line_number":142,"context_line":"                rule_processor \u003d utils.RuleProcessor(rules)"},{"line_number":143,"context_line":"                attributes \u003d attribute_set.get(\"attributes\")"},{"line_number":144,"context_line":"                mapped_properties \u003d rule_processor.process(attributes)"},{"line_number":145,"context_line":"                if aggregated_mapped_properties is None:"},{"line_number":146,"context_line":"                    aggregated_mapped_properties \u003d mapped_properties.copy()"},{"line_number":147,"context_line":"                else:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_7db8162a","line":144,"updated":"2014-07-07 13:50:38.000000000","message":"This is a time-consuming function on even a small data set. I would really advise against looping over it.","commit_id":"dc036b21bc1164ae6c559807dd852dfcc4f3ad8d"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"7b9221a5661adba3ff23117786a39e30ff9bc5b6","unresolved":false,"context_lines":[{"line_number":25,"context_line":"supported as an authentication protocol, the upcoming changes for adding"},{"line_number":26,"context_line":"keystone-to-keystone federation as well as any further additions mean that"},{"line_number":27,"context_line":"processing other protocols will involve rewriting the logic for these"},{"line_number":28,"context_line":"operations."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Proposed Change"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_0fbf79fd","line":28,"updated":"2014-07-09 22:26:45.000000000","message":"\"will involve rewriting the logic for these operations\"","commit_id":"fe8d0623991dc22186415d138d2fd3244f614414"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"7b9221a5661adba3ff23117786a39e30ff9bc5b6","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    auth \u003d {"},{"line_number":90,"context_line":"        \u0027identity\u0027: {"},{"line_number":91,"context_line":"            \u0027methods\u0027: [\u0027federation\u0027],"},{"line_number":92,"context_line":"            \u0027federation\u0027: {"},{"line_number":93,"context_line":"                \u0027identity_provider\u0027: identity_provider,"},{"line_number":94,"context_line":"                \u0027protocol\u0027: protocol"},{"line_number":95,"context_line":"            }"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_2f551dc6","line":92,"updated":"2014-07-09 22:26:45.000000000","message":"\u0027OS-FEDERATION\u0027 ?","commit_id":"fe8d0623991dc22186415d138d2fd3244f614414"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"fa79cc708786885197bee4ef1466adabacb99497","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            }"},{"line_number":96,"context_line":"        }"},{"line_number":97,"context_line":"    }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"keystone/auth/plugins/saml2.py should be deprecated and to replace it"},{"line_number":100,"context_line":"keystone/auth/plugins/federation.py should be added."},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_804c6178","line":98,"updated":"2014-07-09 20:17:39.000000000","message":"+1","commit_id":"fe8d0623991dc22186415d138d2fd3244f614414"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"7b9221a5661adba3ff23117786a39e30ff9bc5b6","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            mapped_properties \u003d rule_processor.process(assertion)"},{"line_number":115,"context_line":"            utils.validate_groups(mapped_properties[\u0027group_ids\u0027],"},{"line_number":116,"context_line":"                                  mapping[\u0027id\u0027], self.identity_api)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"            return {"},{"line_number":119,"context_line":"                \u0027user_id\u0027: parse.quote(mapped_properties[\u0027name\u0027]),"},{"line_number":120,"context_line":"                \u0027group_ids\u0027: mapped_properties[\u0027group_ids\u0027],"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_0f77793c","line":117,"updated":"2014-07-09 22:26:45.000000000","message":"there is whitespace here","commit_id":"fe8d0623991dc22186415d138d2fd3244f614414"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"7b9221a5661adba3ff23117786a39e30ff9bc5b6","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                federation.PROTOCOL: protocol"},{"line_number":123,"context_line":"            }"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Should become something like: ::"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def _handle_unscoped_token(self, context, auth_payload):"},{"line_number":128,"context_line":"            assertion \u003d utils.get_assertion_data(context, auth_payload)"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_6f8f1524","line":125,"updated":"2014-07-09 22:26:45.000000000","message":"please don\u0027t write code in specs, much less try to illustrate a diff. save the implementation for a patch to the code","commit_id":"fe8d0623991dc22186415d138d2fd3244f614414"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"7b9221a5661adba3ff23117786a39e30ff9bc5b6","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            mapped_properties \u003d rule_processor.process(assertion)"},{"line_number":139,"context_line":"            utils.validate_groups(mapped_properties[\u0027group_ids\u0027],"},{"line_number":140,"context_line":"                                  mapping[\u0027id\u0027], self.identity_api)"},{"line_number":141,"context_line":"            return {"},{"line_number":142,"context_line":"                \u0027user_id\u0027: assertion.get(\"user_id\")"},{"line_number":143,"context_line":"                \u0027group_ids\u0027: aggregated_mapped_properties[\u0027group_ids\u0027],"},{"line_number":144,"context_line":"                federation.IDENTITY_PROVIDER: identity_provider,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_ef7b2527","line":141,"updated":"2014-07-09 22:26:45.000000000","message":"whitespace inexplicably removed before the return statement","commit_id":"fe8d0623991dc22186415d138d2fd3244f614414"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"fa79cc708786885197bee4ef1466adabacb99497","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                                  mapping[\u0027id\u0027], self.identity_api)"},{"line_number":141,"context_line":"            return {"},{"line_number":142,"context_line":"                \u0027user_id\u0027: assertion.get(\"user_id\")"},{"line_number":143,"context_line":"                \u0027group_ids\u0027: aggregated_mapped_properties[\u0027group_ids\u0027],"},{"line_number":144,"context_line":"                federation.IDENTITY_PROVIDER: identity_provider,"},{"line_number":145,"context_line":"                federation.PROTOCOL: protocol"},{"line_number":146,"context_line":"            }"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_1725f2aa","line":143,"updated":"2014-07-09 20:17:39.000000000","message":"mapped_properties","commit_id":"fe8d0623991dc22186415d138d2fd3244f614414"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"d29fa6a31fd646bc1b5a1afaaa8892703d11b460","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"We propose that the federated authentication process be reengineered so that"},{"line_number":15,"context_line":"a user_id is returned alongside the identity attributes. In addition the"},{"line_number":16,"context_line":"saml2.py authentication module should be renamed as mapped.py to denote that it"},{"line_number":17,"context_line":"applies to all authentication methods which require the asserted identity"},{"line_number":18,"context_line":"attributes to be mapped into local attributes."}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_5ca61fac","line":15,"updated":"2014-07-20 13:19:18.000000000","message":"comma after \"In addition\"","commit_id":"8c8773ccd7c4a27040d83d21bdc450f9402fdbd7"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"d29fa6a31fd646bc1b5a1afaaa8892703d11b460","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Currently, the federation code uses a named saml2 module for token creation"},{"line_number":25,"context_line":"and for managing the mapping and attribute extraction of external authentication"},{"line_number":26,"context_line":"data. While this is sufficient for the current release where only saml2 is"},{"line_number":27,"context_line":"supported as an authentication protocol, the upcoming changes for adding"},{"line_number":28,"context_line":"keystone-to-keystone federation as well as any further additions mean that"},{"line_number":29,"context_line":"the saml2 naming is incorrect. Additionally, we should require that the"},{"line_number":30,"context_line":"extraction of asserted attributes guarantees that we will receive a user ID"}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_5c98df74","line":27,"updated":"2014-07-20 13:19:18.000000000","message":"We should reference the \"upcoming changes\" explicitly via a reference to the relevant specifications.","commit_id":"8c8773ccd7c4a27040d83d21bdc450f9402fdbd7"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"d29fa6a31fd646bc1b5a1afaaa8892703d11b460","unresolved":false,"context_lines":[{"line_number":47,"context_line":"sense for non SAML assertion data to be processed by a module named saml2.py."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Data Model Impact"},{"line_number":50,"context_line":"-----------------"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"None"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_9c943738","line":50,"updated":"2014-07-20 13:19:18.000000000","message":"Remove this section","commit_id":"8c8773ccd7c4a27040d83d21bdc450f9402fdbd7"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"d29fa6a31fd646bc1b5a1afaaa8892703d11b460","unresolved":false,"context_lines":[{"line_number":52,"context_line":"None"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"REST API Impact"},{"line_number":55,"context_line":"---------------"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"None"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_bc957b33","line":55,"updated":"2014-07-20 13:19:18.000000000","message":"Remove this section","commit_id":"8c8773ccd7c4a27040d83d21bdc450f9402fdbd7"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"d29fa6a31fd646bc1b5a1afaaa8892703d11b460","unresolved":false,"context_lines":[{"line_number":111,"context_line":"Dependencies"},{"line_number":112,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"None but would complement the trusted attribute policy spec."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Testing"},{"line_number":117,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_dc9a2f61","line":114,"updated":"2014-07-20 13:19:18.000000000","message":"I would vote on removing \"but would complement …\"","commit_id":"8c8773ccd7c4a27040d83d21bdc450f9402fdbd7"}]}
