)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8f5c6fa7a48d6a7f6c958e6de65638a825aa693c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Adam Young \u003cayoung@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-06 12:49:38 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implied  Roles"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When assigned a role, the user will also"},{"line_number":10,"context_line":"be assigned all roles implied by any prior roles"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"da85f559_97e01f98","line":7,"updated":"2015-11-15 00:03:27.000000000","message":"two spaces here","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"}],"api/v3/identity-api-v3.rst":[{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"3c2c17366897f27d6988ef01065db59fe1cfb8d2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"identity management, project management, and a centralized repository for"},{"line_number":10,"context_line":"policy engine rule sets."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"What\u0027s New in Version 3.6"},{"line_number":13,"context_line":"-------------------------"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- Listing role assignments for a tree of projects."}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a26ad4f_1ca75050","line":12,"updated":"2015-10-30 08:16:51.000000000","message":"Add a note here","commit_id":"a9fec91259571928111fd411aaa78b2bc355ee94"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"76765bf75d18b602c00daf11ff2979772af9b39d","unresolved":false,"context_lines":[{"line_number":4933,"context_line":"^^^^^^^^^^^"},{"line_number":4934,"context_line":""},{"line_number":4935,"context_line":"Deleting a role also deletes all role inference rules where that role is"},{"line_number":4936,"context_line":"either the prior or implied role."},{"line_number":4937,"context_line":""},{"line_number":4938,"context_line":"::"},{"line_number":4939,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a26ad4f_69f8c8c3","line":4936,"updated":"2015-11-02 18:22:06.000000000","message":"what happen if a role inference rule no longer contain any implied roles? Do they automatically get cleaned up?","commit_id":"a9fec91259571928111fd411aaa78b2bc355ee94"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"3f4dbb90a0888eab03053ca97dc3571ae1f8e735","unresolved":false,"context_lines":[{"line_number":4968,"context_line":""},{"line_number":4969,"context_line":"    {"},{"line_number":4970,"context_line":"        \"role\": {"},{"line_number":4971,"context_line":"            \"id\": \"--prior-role-id--\","},{"line_number":4972,"context_line":"            \"links\": {"},{"line_number":4973,"context_line":"                \"self\": \"http://identity:35357/v3/roles/--role-id--\""},{"line_number":4974,"context_line":"            },"}],"source_content_type":"text/x-rst","patch_set":17,"id":"fa80f949_de580dfd","line":4971,"updated":"2015-11-04 17:17:43.000000000","message":"i\u0027d remove the use of \"--prior\" in these examples and just use --role-id-- and --implied-role-id--","commit_id":"a9fec91259571928111fd411aaa78b2bc355ee94"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"76765bf75d18b602c00daf11ff2979772af9b39d","unresolved":false,"context_lines":[{"line_number":4974,"context_line":"            },"},{"line_number":4975,"context_line":"            \"implies\": {"},{"line_number":4976,"context_line":"                        \"id\": \"--implied_role-id--\","},{"line_number":4977,"context_line":"                        \"name\": \"implied role name\""},{"line_number":4978,"context_line":"            }"},{"line_number":4979,"context_line":"            \"name\": \"prior role name\""},{"line_number":4980,"context_line":"        }"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a26ad4f_897f6416","line":4977,"updated":"2015-11-02 18:22:06.000000000","message":"this needs to be a complete role ref, including \"links\".","commit_id":"a9fec91259571928111fd411aaa78b2bc355ee94"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"76765bf75d18b602c00daf11ff2979772af9b39d","unresolved":false,"context_lines":[{"line_number":5004,"context_line":"            },"},{"line_number":5005,"context_line":"            \"implies\": [{"},{"line_number":5006,"context_line":"                        \"id\": \"--implied-role1-id--\","},{"line_number":5007,"context_line":"                        \"name\": \"implied role1 name\""},{"line_number":5008,"context_line":"            },{"},{"line_number":5009,"context_line":"                        \"id\": \"--implied-role2-id--\","},{"line_number":5010,"context_line":"                        \"name\": \"implied role2 name\""}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a26ad4f_697be828","line":5007,"updated":"2015-11-02 18:22:06.000000000","message":"These need to be complete role refs, including \"links\". Also, I presume this is a one-level list instead of the entire tree?","commit_id":"a9fec91259571928111fd411aaa78b2bc355ee94"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"76765bf75d18b602c00daf11ff2979772af9b39d","unresolved":false,"context_lines":[{"line_number":5023,"context_line":""},{"line_number":5024,"context_line":"::"},{"line_number":5025,"context_line":""},{"line_number":5026,"context_line":"    GET /roles/{prior_role_id}/implies/{implied_role_id}"},{"line_number":5027,"context_line":""},{"line_number":5028,"context_line":"Relationship:"},{"line_number":5029,"context_line":"``http://docs.openstack.org/api/openstack-identity/3/rel/role``"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a26ad4f_c9b79cd6","line":5026,"updated":"2015-11-02 18:22:06.000000000","message":"I don\u0027t see any usefulness of this API. If anything, we may need HEAD for checking.","commit_id":"a9fec91259571928111fd411aaa78b2bc355ee94"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"3f4dbb90a0888eab03053ca97dc3571ae1f8e735","unresolved":false,"context_lines":[{"line_number":5036,"context_line":""},{"line_number":5037,"context_line":"    {"},{"line_number":5038,"context_line":"        \"role\": {"},{"line_number":5039,"context_line":"            \"id\": \"--prior-role-id--\","},{"line_number":5040,"context_line":"            \"links\": {"},{"line_number":5041,"context_line":"                \"self\": \"http://identity:35357/v3/roles/--prior-role-id--/implies/--implied-role-id\""},{"line_number":5042,"context_line":"            },"}],"source_content_type":"text/x-rst","patch_set":17,"id":"fa80f949_1ed4551e","line":5039,"updated":"2015-11-04 17:17:43.000000000","message":"shuoldn\u0027t this return the implied role?","commit_id":"a9fec91259571928111fd411aaa78b2bc355ee94"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"c22c3e942c24103ea7926248b705f1d533ab6e41","unresolved":false,"context_lines":[{"line_number":5036,"context_line":""},{"line_number":5037,"context_line":"    {"},{"line_number":5038,"context_line":"        \"role\": {"},{"line_number":5039,"context_line":"            \"id\": \"--prior-role-id--\","},{"line_number":5040,"context_line":"            \"links\": {"},{"line_number":5041,"context_line":"                \"self\": \"http://identity:35357/v3/roles/--prior-role-id--/implies/--implied-role-id\""},{"line_number":5042,"context_line":"            },"}],"source_content_type":"text/x-rst","patch_set":17,"id":"da85f559_82c57a5c","line":5039,"in_reply_to":"fa80f949_1ed4551e","updated":"2015-11-08 03:47:44.000000000","message":"nope, prior.  \"prior role implies the implied role.\"","commit_id":"a9fec91259571928111fd411aaa78b2bc355ee94"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"3f4dbb90a0888eab03053ca97dc3571ae1f8e735","unresolved":false,"context_lines":[{"line_number":5040,"context_line":"            \"links\": {"},{"line_number":5041,"context_line":"                \"self\": \"http://identity:35357/v3/roles/--prior-role-id--/implies/--implied-role-id\""},{"line_number":5042,"context_line":"            },"},{"line_number":5043,"context_line":"            \"implies\": {"},{"line_number":5044,"context_line":"                        \"id\": \"--implied-role-id--\","},{"line_number":5045,"context_line":"                        \"name\": \"implied role name\""},{"line_number":5046,"context_line":"            }"}],"source_content_type":"text/x-rst","patch_set":17,"id":"fa80f949_fe12b108","line":5043,"updated":"2015-11-04 17:17:43.000000000","message":"shouldn\u0027t this block not be included as we\u0027re already getting the implied role?","commit_id":"a9fec91259571928111fd411aaa78b2bc355ee94"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"c22c3e942c24103ea7926248b705f1d533ab6e41","unresolved":false,"context_lines":[{"line_number":5040,"context_line":"            \"links\": {"},{"line_number":5041,"context_line":"                \"self\": \"http://identity:35357/v3/roles/--prior-role-id--/implies/--implied-role-id\""},{"line_number":5042,"context_line":"            },"},{"line_number":5043,"context_line":"            \"implies\": {"},{"line_number":5044,"context_line":"                        \"id\": \"--implied-role-id--\","},{"line_number":5045,"context_line":"                        \"name\": \"implied role name\""},{"line_number":5046,"context_line":"            }"}],"source_content_type":"text/x-rst","patch_set":17,"id":"da85f559_a2951e41","line":5043,"in_reply_to":"fa80f949_fe12b108","updated":"2015-11-08 03:47:44.000000000","message":"without having the prior role in the response is is going to be hard to correlate the response with the prior-role.  You;ll have to remember what id you passed in on the call.  This way is easier to work with.","commit_id":"a9fec91259571928111fd411aaa78b2bc355ee94"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"76765bf75d18b602c00daf11ff2979772af9b39d","unresolved":false,"context_lines":[{"line_number":5042,"context_line":"            },"},{"line_number":5043,"context_line":"            \"implies\": {"},{"line_number":5044,"context_line":"                        \"id\": \"--implied-role-id--\","},{"line_number":5045,"context_line":"                        \"name\": \"implied role name\""},{"line_number":5046,"context_line":"            }"},{"line_number":5047,"context_line":"            \"name\": \"prior role name\""},{"line_number":5048,"context_line":"        }"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a26ad4f_a99b4065","line":5045,"updated":"2015-11-02 18:22:06.000000000","message":"same as above, should be a complete role ref","commit_id":"a9fec91259571928111fd411aaa78b2bc355ee94"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"c22c3e942c24103ea7926248b705f1d533ab6e41","unresolved":false,"context_lines":[{"line_number":5042,"context_line":"            },"},{"line_number":5043,"context_line":"            \"implies\": {"},{"line_number":5044,"context_line":"                        \"id\": \"--implied-role-id--\","},{"line_number":5045,"context_line":"                        \"name\": \"implied role name\""},{"line_number":5046,"context_line":"            }"},{"line_number":5047,"context_line":"            \"name\": \"prior role name\""},{"line_number":5048,"context_line":"        }"}],"source_content_type":"text/x-rst","patch_set":17,"id":"da85f559_42a6b2c2","line":5045,"in_reply_to":"1a26ad4f_a99b4065","updated":"2015-11-08 03:47:44.000000000","message":"this is going to be a list.  We don\u0027t tend to return the full object in lists.","commit_id":"a9fec91259571928111fd411aaa78b2bc355ee94"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"5645bc8dd8db73570cd743b248f3ef22dab1045c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  project to behave as a domain."},{"line_number":18,"context_line":"- Addition of the ``is_domain`` field to project scoped token response that"},{"line_number":19,"context_line":"  represents whether a project is acting as a domain."},{"line_number":20,"context_line":"- Enable or disable a subtree in the project hierarchy."},{"line_number":21,"context_line":"- Delete a subtree in the project hierarchy."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"What\u0027s New in Version 3.5"}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_6cc072e1","line":20,"updated":"2015-11-13 14:30:08.000000000","message":"Need to add something here (as well as sync up to latest master)","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"83d542f9ed382f36c2cf83ba3659518c13f9821e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  project to behave as a domain."},{"line_number":18,"context_line":"- Addition of the ``is_domain`` field to project scoped token response that"},{"line_number":19,"context_line":"  represents whether a project is acting as a domain."},{"line_number":20,"context_line":"- Enable or disable a subtree in the project hierarchy."},{"line_number":21,"context_line":"- Delete a subtree in the project hierarchy."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"What\u0027s New in Version 3.5"}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba8a016a_29a49e55","line":20,"in_reply_to":"da85f559_6cc072e1","updated":"2015-11-17 01:50:42.000000000","message":"Done","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"5645bc8dd8db73570cd743b248f3ef22dab1045c","unresolved":false,"context_lines":[{"line_number":4979,"context_line":"            \"name\": \"prior role name\""},{"line_number":4980,"context_line":"        }"},{"line_number":4981,"context_line":"    }"},{"line_number":4982,"context_line":""},{"line_number":4983,"context_line":"List implied roles for role"},{"line_number":4984,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":4985,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_8f6108d6","line":4982,"updated":"2015-11-13 14:30:08.000000000","message":"So is the above a \"standard\" role entity?  I.e. if I of get_role() would I see the implies?  If not, then we should not name this a \"role\" dict - it\u0027s something else.  This was my issue at the summit when we were discussing whether we are overloading the role entity. The way you are using it here - you mean a different sort of entity (e.g. \"role_inference\").","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e01d071e943e967db6abfcfa1de91bc3bfebf026","unresolved":false,"context_lines":[{"line_number":4979,"context_line":"            \"name\": \"prior role name\""},{"line_number":4980,"context_line":"        }"},{"line_number":4981,"context_line":"    }"},{"line_number":4982,"context_line":""},{"line_number":4983,"context_line":"List implied roles for role"},{"line_number":4984,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":4985,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_371293b5","line":4982,"in_reply_to":"da85f559_8f6108d6","updated":"2015-11-14 23:59:38.000000000","message":"++++++\n\ni think that would clear up a bunch of this, or at a minimum make it clearer for the rest of us","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"83d542f9ed382f36c2cf83ba3659518c13f9821e","unresolved":false,"context_lines":[{"line_number":4979,"context_line":"            \"name\": \"prior role name\""},{"line_number":4980,"context_line":"        }"},{"line_number":4981,"context_line":"    }"},{"line_number":4982,"context_line":""},{"line_number":4983,"context_line":"List implied roles for role"},{"line_number":4984,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":4985,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba8a016a_095afa83","line":4982,"in_reply_to":"da85f559_8f6108d6","updated":"2015-11-17 01:50:42.000000000","message":"Done:  role_inference is clearer","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e01d071e943e967db6abfcfa1de91bc3bfebf026","unresolved":false,"context_lines":[{"line_number":5000,"context_line":"    {"},{"line_number":5001,"context_line":"        \"role\": {"},{"line_number":5002,"context_line":"            \"id\": \"--prior-role-id--\","},{"line_number":5003,"context_line":"            \"links\": {"},{"line_number":5004,"context_line":"            },"},{"line_number":5005,"context_line":"            \"implies\": [{"},{"line_number":5006,"context_line":"                        \"id\": \"--implied-role1-id--\","}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_774edbc2","line":5003,"updated":"2015-11-14 23:59:38.000000000","message":"this should link back to the prior role","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"83d542f9ed382f36c2cf83ba3659518c13f9821e","unresolved":false,"context_lines":[{"line_number":5000,"context_line":"    {"},{"line_number":5001,"context_line":"        \"role\": {"},{"line_number":5002,"context_line":"            \"id\": \"--prior-role-id--\","},{"line_number":5003,"context_line":"            \"links\": {"},{"line_number":5004,"context_line":"            },"},{"line_number":5005,"context_line":"            \"implies\": [{"},{"line_number":5006,"context_line":"                        \"id\": \"--implied-role1-id--\","}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba8a016a_c9db92ec","line":5003,"in_reply_to":"da85f559_774edbc2","updated":"2015-11-17 01:50:42.000000000","message":"Done","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e01d071e943e967db6abfcfa1de91bc3bfebf026","unresolved":false,"context_lines":[{"line_number":5004,"context_line":"            },"},{"line_number":5005,"context_line":"            \"implies\": [{"},{"line_number":5006,"context_line":"                        \"id\": \"--implied-role1-id--\","},{"line_number":5007,"context_line":"                        \"name\": \"implied role1 name\""},{"line_number":5008,"context_line":"            },{"},{"line_number":5009,"context_line":"                        \"id\": \"--implied-role2-id--\","},{"line_number":5010,"context_line":"                        \"name\": \"implied role2 name\""}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_9749ffb9","line":5007,"updated":"2015-11-14 23:59:38.000000000","message":"there should be links in here that link to the implied roles","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"83d542f9ed382f36c2cf83ba3659518c13f9821e","unresolved":false,"context_lines":[{"line_number":5004,"context_line":"            },"},{"line_number":5005,"context_line":"            \"implies\": [{"},{"line_number":5006,"context_line":"                        \"id\": \"--implied-role1-id--\","},{"line_number":5007,"context_line":"                        \"name\": \"implied role1 name\""},{"line_number":5008,"context_line":"            },{"},{"line_number":5009,"context_line":"                        \"id\": \"--implied-role2-id--\","},{"line_number":5010,"context_line":"                        \"name\": \"implied role2 name\""}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba8a016a_29d6dec5","line":5007,"in_reply_to":"da85f559_9749ffb9","updated":"2015-11-17 01:50:42.000000000","message":"Done","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e01d071e943e967db6abfcfa1de91bc3bfebf026","unresolved":false,"context_lines":[{"line_number":5049,"context_line":"    }"},{"line_number":5050,"context_line":""},{"line_number":5051,"context_line":""},{"line_number":5052,"context_line":"Delete role inference rule"},{"line_number":5053,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":5054,"context_line":""},{"line_number":5055,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_17d42fbb","line":5052,"updated":"2015-11-14 23:59:38.000000000","message":"Question: Inference rules do not cascade right? \n\nif A implies B and B implies C, and I remove the inference rule between A and B, then there\u0027s still a rule between B and C, right?","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"731a75f52071df80b826e437b45ebfaaec555ca5","unresolved":false,"context_lines":[{"line_number":4974,"context_line":""},{"line_number":4975,"context_line":"::"},{"line_number":4976,"context_line":""},{"line_number":4977,"context_line":"    PUT /roles/{prior_role_id}/implies/{implied_role_id}"},{"line_number":4978,"context_line":""},{"line_number":4979,"context_line":"Relationship:"},{"line_number":4980,"context_line":"``http://docs.openstack.org/api/openstack-identity/3/rel/roles``"}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba8a016a_596d1e03","line":4977,"updated":"2015-11-17 09:14:02.000000000","message":"if the GET \u0026 DELETE uses /implied_roles/ shouldn\u0027t the PUT as well (or at least they should be consistent)","commit_id":"4c8732b016d6538c8279445300e3a58c9c407ee1"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"370d28908badd5f938f786136a06941357235063","unresolved":false,"context_lines":[{"line_number":4974,"context_line":""},{"line_number":4975,"context_line":"::"},{"line_number":4976,"context_line":""},{"line_number":4977,"context_line":"    PUT /roles/{prior_role_id}/implies/{implied_role_id}"},{"line_number":4978,"context_line":""},{"line_number":4979,"context_line":"Relationship:"},{"line_number":4980,"context_line":"``http://docs.openstack.org/api/openstack-identity/3/rel/roles``"}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba8a016a_7d08f92d","line":4977,"in_reply_to":"ba8a016a_596d1e03","updated":"2015-11-17 15:24:39.000000000","message":"Done","commit_id":"4c8732b016d6538c8279445300e3a58c9c407ee1"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"731a75f52071df80b826e437b45ebfaaec555ca5","unresolved":false,"context_lines":[{"line_number":4977,"context_line":"    PUT /roles/{prior_role_id}/implies/{implied_role_id}"},{"line_number":4978,"context_line":""},{"line_number":4979,"context_line":"Relationship:"},{"line_number":4980,"context_line":"``http://docs.openstack.org/api/openstack-identity/3/rel/roles``"},{"line_number":4981,"context_line":""},{"line_number":4982,"context_line":""},{"line_number":4983,"context_line":"Response:"}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba8a016a_144c3b41","line":4980,"updated":"2015-11-17 09:14:02.000000000","message":"Apparently the new form of these is of the form:\nhttp://developer.openstack.org/api-ref-identity-v3.html#createRoleInference","commit_id":"4c8732b016d6538c8279445300e3a58c9c407ee1"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"370d28908badd5f938f786136a06941357235063","unresolved":false,"context_lines":[{"line_number":4977,"context_line":"    PUT /roles/{prior_role_id}/implies/{implied_role_id}"},{"line_number":4978,"context_line":""},{"line_number":4979,"context_line":"Relationship:"},{"line_number":4980,"context_line":"``http://docs.openstack.org/api/openstack-identity/3/rel/roles``"},{"line_number":4981,"context_line":""},{"line_number":4982,"context_line":""},{"line_number":4983,"context_line":"Response:"}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba8a016a_3d02710c","line":4980,"in_reply_to":"ba8a016a_144c3b41","updated":"2015-11-17 15:24:39.000000000","message":"Done","commit_id":"4c8732b016d6538c8279445300e3a58c9c407ee1"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"d11662f53ee3257a44fe916368a848df9dd62aae","unresolved":false,"context_lines":[{"line_number":21,"context_line":"- Delete a subtree in the project hierarchy."},{"line_number":22,"context_line":"- Additional identifier for tokens scoped to the designated ``admin project``."},{"line_number":23,"context_line":"- Addition of ``domain_id`` filter to list user projects"},{"line_number":24,"context_line":"- One Role can imply an other via role_inference rules."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"What\u0027s New in Version 3.5"},{"line_number":27,"context_line":"-------------------------"}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba8a016a_0115b13e","line":24,"updated":"2015-11-17 22:50:35.000000000","message":"should be \u0027another\u0027 right?","commit_id":"d48aab174f9a7316a79f67011f24cff059a901df"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"e24670d947b74d2d739b2b846fd6749a5a639d94","unresolved":false,"context_lines":[{"line_number":5023,"context_line":"::"},{"line_number":5024,"context_line":""},{"line_number":5025,"context_line":"    Status: 200 OK"},{"line_number":5026,"context_line":"    {"},{"line_number":5027,"context_line":"        \"role_inference\": {"},{"line_number":5028,"context_line":"            \"prior_role\": {"},{"line_number":5029,"context_line":"                \"id\": \"--prior-role-id--\","}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba8a016a_e1c0ad2c","line":5026,"updated":"2015-11-17 23:19:57.000000000","message":"I think we just need a role list here. No need for prior role ref. But no biggie, not a deal breaker. I am fine if others don\u0027t object ot it.","commit_id":"d48aab174f9a7316a79f67011f24cff059a901df"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"f30b01a5666d8ea65a78be9d4389532499ae138c","unresolved":false,"context_lines":[{"line_number":5023,"context_line":"::"},{"line_number":5024,"context_line":""},{"line_number":5025,"context_line":"    Status: 200 OK"},{"line_number":5026,"context_line":"    {"},{"line_number":5027,"context_line":"        \"role_inference\": {"},{"line_number":5028,"context_line":"            \"prior_role\": {"},{"line_number":5029,"context_line":"                \"id\": \"--prior-role-id--\","}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba8a016a_7586b314","line":5026,"in_reply_to":"ba8a016a_e1c0ad2c","updated":"2015-11-18 00:44:12.000000000","message":"I\u0027d rather leave it, as it has the link to the original role","commit_id":"d48aab174f9a7316a79f67011f24cff059a901df"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"d11662f53ee3257a44fe916368a848df9dd62aae","unresolved":false,"context_lines":[{"line_number":5639,"context_line":"If the query parameter ``effective`` is specified, rather than simply returning"},{"line_number":5640,"context_line":"a list of role assignments that have been made, the API returns a list of"},{"line_number":5641,"context_line":"effective assignments at the user, project and domain level, having allowed for"},{"line_number":5642,"context_line":"the effects of group membership and role inference rules.. Since the"},{"line_number":5643,"context_line":"effects of group membership have already been allowed for, the group"},{"line_number":5644,"context_line":"role assignment entities themselves will not be returned in the"},{"line_number":5645,"context_line":"collection. This represents the effective roleassignments that would"}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba8a016a_615b5d2f","line":5642,"updated":"2015-11-17 22:50:35.000000000","message":"Double period.","commit_id":"d48aab174f9a7316a79f67011f24cff059a901df"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"d11662f53ee3257a44fe916368a848df9dd62aae","unresolved":false,"context_lines":[{"line_number":5642,"context_line":"the effects of group membership and role inference rules.. Since the"},{"line_number":5643,"context_line":"effects of group membership have already been allowed for, the group"},{"line_number":5644,"context_line":"role assignment entities themselves will not be returned in the"},{"line_number":5645,"context_line":"collection. This represents the effective roleassignments that would"},{"line_number":5646,"context_line":"be included in a scoped token. The same set of query parameters can"},{"line_number":5647,"context_line":"also be used in combination with the ``effective`` parameter."},{"line_number":5648,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba8a016a_016a91b3","line":5645,"updated":"2015-11-17 22:50:35.000000000","message":"s/roleassignments/role assignments/","commit_id":"d48aab174f9a7316a79f67011f24cff059a901df"}],"specs/backlog/hierarchical-roles.rst":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"ce8af3d25d8ad56b77ff2a1a0b411ba893c4afe2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"without providing a way to distinguish between administration for two different"},{"line_number":24,"context_line":"functions.  For example, both Cinder and Neutron have admin only tasks, but"},{"line_number":25,"context_line":"different users should be performing them:  in most organizations, there is"},{"line_number":26,"context_line":"as distinction betwen storage admins and network admins."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed Change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9aa53dc9_a6881dc6","line":26,"updated":"2015-04-10 09:52:23.000000000","message":"This is certainly one problem, but if that was the only problem you were trying fix here, the solution would be much simpler (e.g. tag role+service_type together) - e.g. that has Editor/Observer got to do with the problem you state above?\n\nYour proposed change goes much further than this...so you probably need to expand on the other problems you are trying to resolve. I appreciate this is an complicated picture you are trying to simplify in the spec.","commit_id":"5746fd4197b5741d41f3248ed988718f6a878d67"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"3882b8a395a1449f4d994674c7e738fea43b0e47","unresolved":false,"context_lines":[{"line_number":108,"context_line":"| all_admin       | swift_admin          |"},{"line_number":109,"context_line":"+-----------------+----------------------+"},{"line_number":110,"context_line":"| all_admin       | cinder_admin         |"},{"line_number":111,"context_line":"+-----------------+----------------------+"},{"line_number":112,"context_line":"| storage_admin   | swift_admin          |"},{"line_number":113,"context_line":"+-----------------+----------------------+"},{"line_number":114,"context_line":"| storage_admin   | cinder_admin         |"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab921fb_48976048","line":111,"updated":"2015-04-24 14:31:41.000000000","message":"all_admin                                                 |          storage_admin","commit_id":"5746fd4197b5741d41f3248ed988718f6a878d67"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"3882b8a395a1449f4d994674c7e738fea43b0e47","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    \"compute:v3:servers:start\": \"rule:ROLE_MEMBER\","},{"line_number":161,"context_line":"    \"compute:v3:servers:stop\": \"rule:ROLE_MEMBER\""},{"line_number":162,"context_line":"    \"compute_extension:admin_actions\": \"rule:ROLE_ADMIN\","},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"In the future, if a deploye wishes to split a role, they may do so."},{"line_number":165,"context_line":"For example,  \"compute_extension:admin_actions:createBackup\" uses the"},{"line_number":166,"context_line":"rule:admin_or_owner.  If this was a commonly delegated task, and a user wished"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab921fb_c8325010","line":163,"updated":"2015-04-24 14:31:41.000000000","message":"rule:ROLE_PROJECT_ADMIN","commit_id":"5746fd4197b5741d41f3248ed988718f6a878d67"},{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"1754954d93a4f18da809f964aa0efa6a49f45145","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    \"compute:v3:servers:stop\": \"rule:ROLE_MEMBER\""},{"line_number":162,"context_line":"    \"compute_extension:admin_actions\": \"rule:ROLE_ADMIN\","},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"In the future, if a deploye wishes to split a role, they may do so."},{"line_number":165,"context_line":"For example,  \"compute_extension:admin_actions:createBackup\" uses the"},{"line_number":166,"context_line":"rule:admin_or_owner.  If this was a commonly delegated task, and a user wished"},{"line_number":167,"context_line":"to be able to delegate just the \"BACKUP\" role,  member could inherit backup."}],"source_content_type":"text/x-rst","patch_set":9,"id":"dac4157f_370a8627","line":164,"updated":"2015-04-20 22:49:37.000000000","message":"s/deploye/deployer","commit_id":"5746fd4197b5741d41f3248ed988718f6a878d67"},{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"1754954d93a4f18da809f964aa0efa6a49f45145","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    ROLE_BACKUP:"},{"line_number":173,"context_line":"    \"(role:admin or role:member or role:backup) and project_id:%(project_id)s\""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Alternatives"},{"line_number":177,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"dac4157f_92dde044","line":174,"updated":"2015-04-20 22:49:37.000000000","message":"In addition of having the infrastructure to do all this, one thing that would help deployer is having a default hierarchy put in place or a way to have a default hierarchy setup through a utility.  Deployer can tweak the hierarchy if need to afterwards or tweak the utility.","commit_id":"5746fd4197b5741d41f3248ed988718f6a878d67"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"ce8af3d25d8ad56b77ff2a1a0b411ba893c4afe2","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Dispense with role hierarchies by simply assigning a user to the superior roles"},{"line_number":180,"context_line":"and all the subordinate roles. Then he inherits all the privileges assigned to"},{"line_number":181,"context_line":"all the roles. The advantage of role hierarchies is that the user does not need"},{"line_number":182,"context_line":"to carry all the subordinate roles around with himself as the system knows the"},{"line_number":183,"context_line":"role hierarchy."},{"line_number":184,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9aa53dc9_e66f45fa","line":181,"updated":"2015-04-10 09:52:23.000000000","message":"nit: maybe say \"The disadvantage of this approach is that the user needs to carry...\".","commit_id":"5746fd4197b5741d41f3248ed988718f6a878d67"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"ce8af3d25d8ad56b77ff2a1a0b411ba893c4afe2","unresolved":false,"context_lines":[{"line_number":187,"context_line":"rules, minimizing the effectiveness of hierarchical roles."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"Security Impact"},{"line_number":193,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9aa53dc9_497602a5","line":190,"updated":"2015-04-10 09:52:23.000000000","message":"Fundamentally this is about where we store and process a more complex set of roles.  Do we do this by making roles themselves more structured....or do we do we use the existing mechanisms and solve the problem with token bloat.  This a hard comparison because the former requires the user to understand role hierarchies, the later is invisible to them, but we still need to fix it! Will the admin be able to handle this? I still worry about another hierarchy structure an admin must visualise and worry about.....and the risk of unintended consequences of something getting a bunch of subordinate roles.","commit_id":"5746fd4197b5741d41f3248ed988718f6a878d67"}],"specs/backlog/implied-roles.rst":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"38d2d912e36d80ee41d11dab90d3a6c95fa4bb20","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Problem Description"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Roles in OpenStack are very static. For many operations, we specify \"admin\""},{"line_number":23,"context_line":"without providing a way to distinguish between administration for two different"},{"line_number":24,"context_line":"functions.  For example, both Cinder and Neutron have admin only tasks, but"},{"line_number":25,"context_line":"different users should be performing them:  in most organizations, there is"}],"source_content_type":"text/x-rst","patch_set":14,"id":"9a1a9d01_ea3b9ccf","line":22,"updated":"2015-09-28 19:27:03.000000000","message":"This ain\u0027t gonna change unless we also change the service\u0027s policy files to be more fine-grained. More than just \"admin\" or \"owner\".","commit_id":"972c8c52290da8184b633e859afd162aa1535ac7"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"38d2d912e36d80ee41d11dab90d3a6c95fa4bb20","unresolved":false,"context_lines":[{"line_number":23,"context_line":"without providing a way to distinguish between administration for two different"},{"line_number":24,"context_line":"functions.  For example, both Cinder and Neutron have admin only tasks, but"},{"line_number":25,"context_line":"different users should be performing them:  in most organizations, there is"},{"line_number":26,"context_line":"as distinction betwen storage admins and network admins."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed Change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":14,"id":"9a1a9d01_2f45266f","line":26,"updated":"2015-09-28 19:27:03.000000000","message":"Simply, what we have today failed to meet separation-of-duties requirement\n\nhttps://en.wikipedia.org/wiki/Separation_of_duties","commit_id":"972c8c52290da8184b633e859afd162aa1535ac7"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"38d2d912e36d80ee41d11dab90d3a6c95fa4bb20","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"In a persisted store, define a set of rules that state one prior role"},{"line_number":32,"context_line":"assignment implies additional role assignments."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"First implementation is the SQL backend.  Other"},{"line_number":35,"context_line":"backends will follow if requested. Add an additional implied_role"}],"source_content_type":"text/x-rst","patch_set":14,"id":"9a1a9d01_ea42bc3d","line":32,"updated":"2015-09-28 19:27:03.000000000","message":"Would be nice to give an example here to illustrate what token data looks like.","commit_id":"972c8c52290da8184b633e859afd162aa1535ac7"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"38d2d912e36d80ee41d11dab90d3a6c95fa4bb20","unresolved":false,"context_lines":[{"line_number":40,"context_line":"This is often termed hierarchical roles, but this implementation avoids a"},{"line_number":41,"context_line":"strict hierearchy in favor of generating a directed-acyclic-graph (DAG): the"},{"line_number":42,"context_line":"same role may be implied by multiple prior roles.  At enforcement time"},{"line_number":43,"context_line":"the required abstraction is a set of role assignements, not a tree or a graph."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"An example set of implied roles:"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"9a1a9d01_aa6364db","line":43,"updated":"2015-09-28 19:27:03.000000000","message":"And watch out for circular reference. :)","commit_id":"972c8c52290da8184b633e859afd162aa1535ac7"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"38d2d912e36d80ee41d11dab90d3a6c95fa4bb20","unresolved":false,"context_lines":[{"line_number":45,"context_line":"An example set of implied roles:"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The `reader` role is for people that need to be able to inspect the values"},{"line_number":48,"context_line":"of resources in a project, but not make any changes to those resources."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The `editor` role is for people that need to make standard changes, such as"},{"line_number":51,"context_line":"creating new virtual machines and  allocating floating IP addreses.  All"}],"source_content_type":"text/x-rst","patch_set":14,"id":"9a1a9d01_0aacd0eb","line":48,"updated":"2015-09-28 19:27:03.000000000","message":"Again, this requires service policy changes. Can\u0027t do this in Keystone alone. Same goes with the rest.","commit_id":"972c8c52290da8184b633e859afd162aa1535ac7"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"38d2d912e36d80ee41d11dab90d3a6c95fa4bb20","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Each of the services has their own admin roles defined.  In addition, the two"},{"line_number":56,"context_line":"storage focused services have a joint role called `storage_admin` that implies"},{"line_number":57,"context_line":"both `swift_admin` and `cinder_admin`."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"If a user is assigned `all_admin`  in a project and request a token for that"},{"line_number":60,"context_line":"project, the token will have all of the implied roles enumerated in it:"}],"source_content_type":"text/x-rst","patch_set":14,"id":"9a1a9d01_ea971c8e","line":57,"updated":"2015-09-28 19:27:03.000000000","message":"Require service policy changes.","commit_id":"972c8c52290da8184b633e859afd162aa1535ac7"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"60d44c9e613eeacd4ede453f04e176f12a53a98e","unresolved":false,"context_lines":[{"line_number":127,"context_line":"+-----------------+----------------------+"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Role inferecne could be performed via three distinct mechanisms."},{"line_number":131,"context_line":"First, implied roles can be expanded in the token.  This will work for"},{"line_number":132,"context_line":"a small set of implied roles, and is the easiest to implement."},{"line_number":133,"context_line":"Second, role implcation rules  can be fetched separately from the"}],"source_content_type":"text/x-rst","patch_set":14,"id":"9a1a9d01_d77e5869","line":130,"updated":"2015-09-29 15:13:30.000000000","message":"s/inferecne/inference/","commit_id":"972c8c52290da8184b633e859afd162aa1535ac7"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"60d44c9e613eeacd4ede453f04e176f12a53a98e","unresolved":false,"context_lines":[{"line_number":130,"context_line":"Role inferecne could be performed via three distinct mechanisms."},{"line_number":131,"context_line":"First, implied roles can be expanded in the token.  This will work for"},{"line_number":132,"context_line":"a small set of implied roles, and is the easiest to implement."},{"line_number":133,"context_line":"Second, role implcation rules  can be fetched separately from the"},{"line_number":134,"context_line":"token and cached in auth-token middlware, and then infer roles from"},{"line_number":135,"context_line":"the token prior to policy enforcement.  This will be implemented if"},{"line_number":136,"context_line":"required.  The final and preferred way is to use the implied roles to"}],"source_content_type":"text/x-rst","patch_set":14,"id":"9a1a9d01_5771e842","line":133,"updated":"2015-09-29 15:13:30.000000000","message":"do you mean s/implcation/implication/ ?  Could you please add a sentence to describe this mechanism more clearly, and how you\u0027d use the pre-existing cache if it\u0027s available?","commit_id":"972c8c52290da8184b633e859afd162aa1535ac7"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"38d2d912e36d80ee41d11dab90d3a6c95fa4bb20","unresolved":false,"context_lines":[{"line_number":131,"context_line":"First, implied roles can be expanded in the token.  This will work for"},{"line_number":132,"context_line":"a small set of implied roles, and is the easiest to implement."},{"line_number":133,"context_line":"Second, role implcation rules  can be fetched separately from the"},{"line_number":134,"context_line":"token and cached in auth-token middlware, and then infer roles from"},{"line_number":135,"context_line":"the token prior to policy enforcement.  This will be implemented if"},{"line_number":136,"context_line":"required.  The final and preferred way is to use the implied roles to"},{"line_number":137,"context_line":"generate a section of the policy files themselves.  Only the first"}],"source_content_type":"text/x-rst","patch_set":14,"id":"9a1a9d01_ca51f8d9","line":134,"updated":"2015-09-28 19:27:03.000000000","message":"Nah, we are already caching token data in middleware. No need to additional complexity.","commit_id":"972c8c52290da8184b633e859afd162aa1535ac7"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"38d2d912e36d80ee41d11dab90d3a6c95fa4bb20","unresolved":false,"context_lines":[{"line_number":134,"context_line":"token and cached in auth-token middlware, and then infer roles from"},{"line_number":135,"context_line":"the token prior to policy enforcement.  This will be implemented if"},{"line_number":136,"context_line":"required.  The final and preferred way is to use the implied roles to"},{"line_number":137,"context_line":"generate a section of the policy files themselves.  Only the first"},{"line_number":138,"context_line":"mechanims will be implemented with this specification.  A config"},{"line_number":139,"context_line":"option will allow the option to be enabled or disabled."},{"line_number":140,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"9a1a9d01_2a10b400","line":137,"updated":"2015-09-28 19:27:03.000000000","message":"This option implies centralized policy management?","commit_id":"972c8c52290da8184b633e859afd162aa1535ac7"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"38d2d912e36d80ee41d11dab90d3a6c95fa4bb20","unresolved":false,"context_lines":[{"line_number":149,"context_line":"role hierarchy."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Security Impact"},{"line_number":153,"context_line":"---------------"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Describe any potential security impact on the system.  Some of the items to"}],"source_content_type":"text/x-rst","patch_set":14,"id":"9a1a9d01_8abea0d2","line":152,"updated":"2015-09-28 19:27:03.000000000","message":"Not related. But I really like the STRIKE model to assess security impacts.\n\nhttps://msdn.microsoft.com/en-us/library/ee823878(v\u003dcs.20).aspx","commit_id":"972c8c52290da8184b633e859afd162aa1535ac7"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"38d2d912e36d80ee41d11dab90d3a6c95fa4bb20","unresolved":false,"context_lines":[{"line_number":199,"context_line":"------------------"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"Policy files will be larger.  If the role set  gets too large, enforcing policy"},{"line_number":202,"context_line":"may take marginally longer."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Other Deployer Impact"}],"source_content_type":"text/x-rst","patch_set":14,"id":"9a1a9d01_6a90ec43","line":202,"updated":"2015-09-28 19:27:03.000000000","message":"Anything hierarchical will have impact on performance because as we need to resolve to the lowest common denominator.","commit_id":"972c8c52290da8184b633e859afd162aa1535ac7"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"38d2d912e36d80ee41d11dab90d3a6c95fa4bb20","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"* No Config option changes."},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"* Change takes effect Immediately, but no hierarchical roles will be defined"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"Developer Impact"}],"source_content_type":"text/x-rst","patch_set":14,"id":"9a1a9d01_aaae0483","line":213,"updated":"2015-09-28 19:27:03.000000000","message":"This have cross-project implications as it will require service policy changes.","commit_id":"972c8c52290da8184b633e859afd162aa1535ac7"},{"author":{"_account_id":2506,"name":"devdatta-kulkarni","email":"kulkarni.devdatta@gmail.com","username":"devdatta-kulkarni"},"change_message_id":"6eccc3a89ef79fb163eda5a14d5728de9a9c7614","unresolved":false,"context_lines":[{"line_number":23,"context_line":"without providing a way to distinguish between administration for two different"},{"line_number":24,"context_line":"functions.  For example, both Cinder and Neutron have admin only tasks, but"},{"line_number":25,"context_line":"different users should be performing them:  in most organizations, there is"},{"line_number":26,"context_line":"as distinction betwen storage admins and network admins."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed Change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9a1a9d01_513d388d","line":26,"updated":"2015-09-30 18:17:44.000000000","message":"The way this example is used here is bit misleading imo. While reading this, I was forming an impression in my mind that the solution being described will be some sort of \u0027chinese wall\u0027 security mechanism to prevent a user from gaining two conflicting roles (for instance, a person who has storage admin role cannot also have network admin role).","commit_id":"ee2608cefb1edbb2a55e7384d1b5477f6f258361"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"2fa768fe93fec6092012c39ac8183882120b3b56","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed Change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"In a persisted store, define a set of rules that state one prior role"},{"line_number":32,"context_line":"assignment implies additional role assignments."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"First implementation is the SQL backend.  Other"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7a2fa921_54f38f0a","line":31,"updated":"2015-10-06 17:58:15.000000000","message":"You need to expand on this and really explain what you mean by define a set of rules that state one prior role assignment implies additional role assignments.  Perhaps give a simple example right here","commit_id":"ee2608cefb1edbb2a55e7384d1b5477f6f258361"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"a216fb2b230bf7ec3befb32643b8702c8159b5e5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"backends will follow if requested. Add an additional implied_role"},{"line_number":36,"context_line":"table with two columns:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"prior_role_id,  implied_role_id"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"This is often termed hierarchical roles, but this implementation avoids a"},{"line_number":41,"context_line":"strict hierarchy in favor of generating a directed-acyclic-graph (DAG): the"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9a1a9d01_3a50990a","line":38,"updated":"2015-09-30 19:19:48.000000000","message":"Is adjacency list is the only way to store DAG?","commit_id":"ee2608cefb1edbb2a55e7384d1b5477f6f258361"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"2fa768fe93fec6092012c39ac8183882120b3b56","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"prior_role_id,  implied_role_id"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"This is often termed hierarchical roles, but this implementation avoids a"},{"line_number":41,"context_line":"strict hierarchy in favor of generating a directed-acyclic-graph (DAG): the"},{"line_number":42,"context_line":"same role may be implied by multiple prior roles.  At enforcement time"},{"line_number":43,"context_line":"the required abstraction is a set of role assignements, not a tree or"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7a2fa921_94dda716","line":40,"updated":"2015-10-06 17:58:15.000000000","message":"So if its not exactly hiearchical then what is it?  you define it by describing how its implemented which isnt optimal.  Ideally please explain your absraction and how it differs from hierarchical and why","commit_id":"ee2608cefb1edbb2a55e7384d1b5477f6f258361"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"a216fb2b230bf7ec3befb32643b8702c8159b5e5","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                              editor"},{"line_number":92,"context_line":"                                 |"},{"line_number":93,"context_line":"                              reader"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Note it is not a strict hierarchy.  For example,  both the `neutron_admin` and"},{"line_number":97,"context_line":"the `glance_admin` roles imply the member role.  As such, the hierarchy is a"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9a1a9d01_5f321fa8","line":94,"updated":"2015-09-30 19:19:48.000000000","message":"This looks like classical multiple inheritance model:\n\nreader is a base class, editor is derived from it, *_admin is derived from editor and so on.","commit_id":"ee2608cefb1edbb2a55e7384d1b5477f6f258361"},{"author":{"_account_id":2506,"name":"devdatta-kulkarni","email":"kulkarni.devdatta@gmail.com","username":"devdatta-kulkarni"},"change_message_id":"6eccc3a89ef79fb163eda5a14d5728de9a9c7614","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Note it is not a strict hierarchy.  For example,  both the `neutron_admin` and"},{"line_number":97,"context_line":"the `glance_admin` roles imply the member role.  As such, the hierarchy is a"},{"line_number":98,"context_line":"DAG."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"9a1a9d01_8e8defd4","line":97,"updated":"2015-09-30 18:17:44.000000000","message":"Is \u0027member\u0027 correct here? Should this be \u0027editor\u0027 or \u0027reader\u0027?","commit_id":"ee2608cefb1edbb2a55e7384d1b5477f6f258361"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"a216fb2b230bf7ec3befb32643b8702c8159b5e5","unresolved":false,"context_lines":[{"line_number":129,"context_line":"+-----------------+----------------------+"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Role inference could be performed via three distinct mechanisms."},{"line_number":133,"context_line":"First, implied roles can be expanded in the token.  This will work for"},{"line_number":134,"context_line":"a small set of implied roles, and is the easiest to implement."},{"line_number":135,"context_line":"Second, role implication rules can be fetched separately from the"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9a1a9d01_5f953f30","line":132,"updated":"2015-09-30 19:19:48.000000000","message":"Please format this paragraph as a list - it\u0027s hard to read it as it is.","commit_id":"ee2608cefb1edbb2a55e7384d1b5477f6f258361"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"a216fb2b230bf7ec3befb32643b8702c8159b5e5","unresolved":false,"context_lines":[{"line_number":132,"context_line":"Role inference could be performed via three distinct mechanisms."},{"line_number":133,"context_line":"First, implied roles can be expanded in the token.  This will work for"},{"line_number":134,"context_line":"a small set of implied roles, and is the easiest to implement."},{"line_number":135,"context_line":"Second, role implication rules can be fetched separately from the"},{"line_number":136,"context_line":"token and cached in auth-token middlware, and then infer roles from"},{"line_number":137,"context_line":"the token prior to policy enforcement.  This will be implemented if"},{"line_number":138,"context_line":"required.  The final and preferred way is to use the implied roles to"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9a1a9d01_dfae2f2d","line":135,"updated":"2015-09-30 19:19:48.000000000","message":"So token should contain role implication rules?","commit_id":"ee2608cefb1edbb2a55e7384d1b5477f6f258361"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"614548273a79ef846527fc275d9ce8970bd134f2","unresolved":false,"context_lines":[{"line_number":132,"context_line":"Role inference could be performed via three distinct mechanisms."},{"line_number":133,"context_line":"First, implied roles can be expanded in the token.  This will work for"},{"line_number":134,"context_line":"a small set of implied roles, and is the easiest to implement."},{"line_number":135,"context_line":"Second, role implication rules can be fetched separately from the"},{"line_number":136,"context_line":"token and cached in auth-token middlware, and then infer roles from"},{"line_number":137,"context_line":"the token prior to policy enforcement.  This will be implemented if"},{"line_number":138,"context_line":"required.  The final and preferred way is to use the implied roles to"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7a2fa921_37aa6e71","line":135,"in_reply_to":"9a1a9d01_dfae2f2d","updated":"2015-10-07 14:04:46.000000000","message":"Yes, on the last patch I asked for clarification on this same thing.  It seems you\u0027re making an underlying assumption here that\u0027s not obvious.  Could you please point to a reference?  Thanks.","commit_id":"ee2608cefb1edbb2a55e7384d1b5477f6f258361"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"a216fb2b230bf7ec3befb32643b8702c8159b5e5","unresolved":false,"context_lines":[{"line_number":133,"context_line":"First, implied roles can be expanded in the token.  This will work for"},{"line_number":134,"context_line":"a small set of implied roles, and is the easiest to implement."},{"line_number":135,"context_line":"Second, role implication rules can be fetched separately from the"},{"line_number":136,"context_line":"token and cached in auth-token middlware, and then infer roles from"},{"line_number":137,"context_line":"the token prior to policy enforcement.  This will be implemented if"},{"line_number":138,"context_line":"required.  The final and preferred way is to use the implied roles to"},{"line_number":139,"context_line":"generate a section of the policy files themselves.  Only the first"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9a1a9d01_1f3d87dc","line":136,"updated":"2015-09-30 19:19:48.000000000","message":"How will it infer roles? Should middleware cache entire role DAG to do that or implication rules should be enough for that?","commit_id":"ee2608cefb1edbb2a55e7384d1b5477f6f258361"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"a216fb2b230bf7ec3befb32643b8702c8159b5e5","unresolved":false,"context_lines":[{"line_number":136,"context_line":"token and cached in auth-token middlware, and then infer roles from"},{"line_number":137,"context_line":"the token prior to policy enforcement.  This will be implemented if"},{"line_number":138,"context_line":"required.  The final and preferred way is to use the implied roles to"},{"line_number":139,"context_line":"generate a section of the policy files themselves.  Only the first"},{"line_number":140,"context_line":"mechanims will be implemented with this specification.  A config"},{"line_number":141,"context_line":"option will allow the option to be enabled or disabled."},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"9a1a9d01_da115d53","line":139,"updated":"2015-09-30 19:19:48.000000000","message":"I fear invalidation of these policies can be a pain...","commit_id":"ee2608cefb1edbb2a55e7384d1b5477f6f258361"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"a216fb2b230bf7ec3befb32643b8702c8159b5e5","unresolved":false,"context_lines":[{"line_number":137,"context_line":"the token prior to policy enforcement.  This will be implemented if"},{"line_number":138,"context_line":"required.  The final and preferred way is to use the implied roles to"},{"line_number":139,"context_line":"generate a section of the policy files themselves.  Only the first"},{"line_number":140,"context_line":"mechanims will be implemented with this specification.  A config"},{"line_number":141,"context_line":"option will allow the option to be enabled or disabled."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"9a1a9d01_1f002765","line":140,"updated":"2015-09-30 19:19:48.000000000","message":"s/mechanims/mechanisms/","commit_id":"ee2608cefb1edbb2a55e7384d1b5477f6f258361"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"a216fb2b230bf7ec3befb32643b8702c8159b5e5","unresolved":false,"context_lines":[{"line_number":138,"context_line":"required.  The final and preferred way is to use the implied roles to"},{"line_number":139,"context_line":"generate a section of the policy files themselves.  Only the first"},{"line_number":140,"context_line":"mechanims will be implemented with this specification.  A config"},{"line_number":141,"context_line":"option will allow the option to be enabled or disabled."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9a1a9d01_7f4da3c2","line":141,"updated":"2015-09-30 19:19:48.000000000","message":"what option will be enabled/disabled?","commit_id":"ee2608cefb1edbb2a55e7384d1b5477f6f258361"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"371610e6dd8a55c376069fad16ffd7993c1d7e80","unresolved":false,"context_lines":[{"line_number":11,"context_line":"`bp hierarchical-roles \u003chttps://blueprints.launchpad.net/keystone/+spec/implied-roles\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Allow role definitions to imply other role defintions, so that, with one"},{"line_number":15,"context_line":"superior role assignment, the user will inherit all subordinate roles."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a26ad4f_190f1d89","line":14,"updated":"2015-11-02 21:52:59.000000000","message":"nit:typo defintions should be definitions","commit_id":"a9fec91259571928111fd411aaa78b2bc355ee94"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"371610e6dd8a55c376069fad16ffd7993c1d7e80","unresolved":false,"context_lines":[{"line_number":58,"context_line":"`editors`  should be have access to the resources specifed by the `reader`"},{"line_number":59,"context_line":"role."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Each of the services has their own admin roles defined.  In addition, the two"},{"line_number":62,"context_line":"storage focused services have a joint role called `storage_admin` that implies"},{"line_number":63,"context_line":"both `swift_admin` and `cinder_admin`."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a26ad4f_3c28c785","line":61,"updated":"2015-11-02 21:52:59.000000000","message":"I really like this example.  It quickly captures the essence and value of implied roles","commit_id":"a9fec91259571928111fd411aaa78b2bc355ee94"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"371610e6dd8a55c376069fad16ffd7993c1d7e80","unresolved":false,"context_lines":[{"line_number":71,"context_line":"data from any of the systems, but cannot affect any change.   The `editor`"},{"line_number":72,"context_line":"role is superior to `reader`:  there would be no reason to assign someone the"},{"line_number":73,"context_line":"`editor` role without assigning the `reader` role as well.  We often want to"},{"line_number":74,"context_line":"assign the `reader` role without the `editor` role for audit and monitoring."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"The following DAG describes the roles.  Prior roles are above implied,"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a26ad4f_3c7687a4","line":74,"updated":"2015-11-02 21:52:59.000000000","message":"This is a very good example as well","commit_id":"a9fec91259571928111fd411aaa78b2bc355ee94"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"371610e6dd8a55c376069fad16ffd7993c1d7e80","unresolved":false,"context_lines":[{"line_number":74,"context_line":"assign the `reader` role without the `editor` role for audit and monitoring."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"The following DAG describes the roles.  Prior roles are above implied,"},{"line_number":78,"context_line":"with a vertical line showing implication."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a26ad4f_3c0767cb","line":77,"updated":"2015-11-02 21:52:59.000000000","message":"Prior roles are above implied is a litle strangely phrased. Perhaps say, In a DAG, implied role relationships are illustrated by having the implied roles as edges underneath the role that inherits the implied roles","commit_id":"a9fec91259571928111fd411aaa78b2bc355ee94"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"188c55e78a2da9fe33b5f4a96a93a8a497ff3919","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"* The final and preferred way is to use the implied roles to"},{"line_number":147,"context_line":"  generate a section of the policy files themselves.  Only the first"},{"line_number":148,"context_line":"  mechanism will be implemented with this specification."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"A config option will allow which option is used, or to disable all"},{"line_number":151,"context_line":"role implication expansion."}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a26ad4f_0cb2ab06","line":148,"updated":"2015-10-31 03:00:26.000000000","message":"this last line is in conflict with the 2nd paragraph above where we say we might implement caching them auth token.  For now, I recommend we make it clear that we are only doing the first one, and the others are potential future options.","commit_id":"a9fec91259571928111fd411aaa78b2bc355ee94"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"371610e6dd8a55c376069fad16ffd7993c1d7e80","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"* The final and preferred way is to use the implied roles to"},{"line_number":147,"context_line":"  generate a section of the policy files themselves.  Only the first"},{"line_number":148,"context_line":"  mechanism will be implemented with this specification."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"A config option will allow which option is used, or to disable all"},{"line_number":151,"context_line":"role implication expansion."}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a26ad4f_7c187f1e","line":148,"in_reply_to":"1a26ad4f_0cb2ab06","updated":"2015-11-02 21:52:59.000000000","message":"I agree. I think the generate a section of the policy file would require more discussion arounds complexit, serviceability, etc.","commit_id":"a9fec91259571928111fd411aaa78b2bc355ee94"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"9499f4de475ab3c25fe25dbb5434522902feafc7","unresolved":false,"context_lines":[{"line_number":148,"context_line":"  mechanism will be implemented with this specification."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"A config option will allow which option is used, or to disable all"},{"line_number":151,"context_line":"role implication expansion."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":17,"id":"fa80f949_4daa6a1b","line":151,"updated":"2015-11-03 14:51:10.000000000","message":"The previous paragraph says that only the first mechanism will be implemented with this spec, so the sentence above should state something like \"Role inference is optional, and a config option will allow it to be disabled.  When multiple role inference mechanisms become available in the future, a config option will allow the method to be selected.\"","commit_id":"a9fec91259571928111fd411aaa78b2bc355ee94"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"c22c3e942c24103ea7926248b705f1d533ab6e41","unresolved":false,"context_lines":[{"line_number":148,"context_line":"  mechanism will be implemented with this specification."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"A config option will allow which option is used, or to disable all"},{"line_number":151,"context_line":"role implication expansion."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":17,"id":"fa80f949_0596dd3e","line":151,"in_reply_to":"fa80f949_4daa6a1b","updated":"2015-11-08 03:47:44.000000000","message":"Done","commit_id":"a9fec91259571928111fd411aaa78b2bc355ee94"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"188c55e78a2da9fe33b5f4a96a93a8a497ff3919","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"Policy files will be larger.  If the role set gets too large, enforcing policy"},{"line_number":214,"context_line":"may take marginally longer.  Querying the roles from the backend will"},{"line_number":215,"context_line":"take slightly longer, but should be cached after the first query."},{"line_number":216,"context_line":""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a26ad4f_8cc6bb66","line":215,"updated":"2015-10-31 03:00:26.000000000","message":"Will policy files be larger due to this change? Surely they\u0027ll be the same size - we\u0027re just saying the admin from having to make all the assignments manually.","commit_id":"a9fec91259571928111fd411aaa78b2bc355ee94"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"188c55e78a2da9fe33b5f4a96a93a8a497ff3919","unresolved":false,"context_lines":[{"line_number":225,"context_line":"* No Config option changes."},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"* Change takes effect Immediately, but no implied roles will be"},{"line_number":228,"context_line":"  defined"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"* Other project policy files will; be able to take advantage of the"},{"line_number":231,"context_line":"  changes but will not be required to change to still be valid."}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a26ad4f_acc37756","line":228,"updated":"2015-10-31 03:00:26.000000000","message":"not sure I understand this sentence","commit_id":"a9fec91259571928111fd411aaa78b2bc355ee94"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"371610e6dd8a55c376069fad16ffd7993c1d7e80","unresolved":false,"context_lines":[{"line_number":225,"context_line":"* No Config option changes."},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"* Change takes effect Immediately, but no implied roles will be"},{"line_number":228,"context_line":"  defined"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"* Other project policy files will; be able to take advantage of the"},{"line_number":231,"context_line":"  changes but will not be required to change to still be valid."}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a26ad4f_9cec7bf4","line":228,"in_reply_to":"1a26ad4f_acc37756","updated":"2015-11-02 21:52:59.000000000","message":"I don\u0027t either","commit_id":"a9fec91259571928111fd411aaa78b2bc355ee94"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"83d542f9ed382f36c2cf83ba3659518c13f9821e","unresolved":false,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":" This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":3,"context_line":" License."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba8a016a_3d2b7432","line":1,"updated":"2015-11-17 01:50:42.000000000","message":"hica","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"68572f04a81bc185ce2dd7974a474f9ebf7e22dd","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Implied Roles - Assign one Role, get many"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp hierarchical-roles \u003chttps://blueprints.launchpad.net/keystone/+spec/implied-roles\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Allow role definitions to imply other role definitions, so that, with one"}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_97e25f2e","line":11,"updated":"2015-11-14 22:38:53.000000000","message":"change the name of the blueprint to \u0027implied roles\u0027 since that\u0027s the term we\u0027re using","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"83d542f9ed382f36c2cf83ba3659518c13f9821e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Implied Roles - Assign one Role, get many"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp hierarchical-roles \u003chttps://blueprints.launchpad.net/keystone/+spec/implied-roles\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Allow role definitions to imply other role definitions, so that, with one"}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba8a016a_a2e7433f","line":11,"in_reply_to":"da85f559_97e25f2e","updated":"2015-11-17 01:50:42.000000000","message":"Done","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"d63cc1db03934edaac33fdca49956fde5b862b28","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Problem Description"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Roles in OpenStack are very static. For many operations, we specify \"admin\""},{"line_number":23,"context_line":"without providing a way to distinguish between administration for two different"},{"line_number":24,"context_line":"functions.  For example, both Cinder and Neutron have admin only tasks, but"},{"line_number":25,"context_line":"different users should be performing them:  in most organizations, there is"}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_7d59d95a","line":22,"updated":"2015-11-15 08:44:55.000000000","message":"This first sentence seems unconnected with this spec.  We\u0027re not make rules any more or less dynamic here.","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"83d542f9ed382f36c2cf83ba3659518c13f9821e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Problem Description"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Roles in OpenStack are very static. For many operations, we specify \"admin\""},{"line_number":23,"context_line":"without providing a way to distinguish between administration for two different"},{"line_number":24,"context_line":"functions.  For example, both Cinder and Neutron have admin only tasks, but"},{"line_number":25,"context_line":"different users should be performing them:  in most organizations, there is"}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba8a016a_fef163ce","line":22,"in_reply_to":"da85f559_7d59d95a","updated":"2015-11-17 01:50:42.000000000","message":"Rewrote this whole section","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"0c7ff7f1face50ad447dfc5116477752983362cb","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Roles in OpenStack are very static. For many operations, we specify \"admin\""},{"line_number":23,"context_line":"without providing a way to distinguish between administration for two different"},{"line_number":24,"context_line":"functions.  For example, both Cinder and Neutron have admin only tasks, but"},{"line_number":25,"context_line":"different users should be performing them:  in most organizations, there is"},{"line_number":26,"context_line":"as distinction betwen storage admins and network admins."}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba8a016a_93595e91","line":23,"updated":"2015-11-16 09:32:56.000000000","message":"Also, there is a danger that people think this is just about admin roles..I\u0027d make it clear that the admin example is just that, an example.","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"d63cc1db03934edaac33fdca49956fde5b862b28","unresolved":false,"context_lines":[{"line_number":23,"context_line":"without providing a way to distinguish between administration for two different"},{"line_number":24,"context_line":"functions.  For example, both Cinder and Neutron have admin only tasks, but"},{"line_number":25,"context_line":"different users should be performing them:  in most organizations, there is"},{"line_number":26,"context_line":"as distinction betwen storage admins and network admins."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed Change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_fd1aa97b","line":26,"updated":"2015-11-15 08:44:55.000000000","message":"This doesn\u0027t sufficiently define the problem you are trying to solve. If that was all there was, developers could just define different admin roles (and they can do that today). This spec is trying to do something different  - i.e. simplify the issuing of assignments and the writing of policy files to reflect that fact that here is often a relationship between roles (i.e. if you are admin then you are also nova_admin).","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"b13e06b9063ace01399eea86d7a4a98f75501891","unresolved":false,"context_lines":[{"line_number":24,"context_line":"functions.  For example, both Cinder and Neutron have admin only tasks, but"},{"line_number":25,"context_line":"different users should be performing them:  in most organizations, there is"},{"line_number":26,"context_line":"as distinction betwen storage admins and network admins."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed Change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_dc1b2c1b","line":27,"updated":"2015-11-14 20:12:57.000000000","message":"a distinction","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"68572f04a81bc185ce2dd7974a474f9ebf7e22dd","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"The `editor` role is for people that need to make standard changes, such as"},{"line_number":57,"context_line":"creating new virtual machines and  allocating floating IP addreses.  All"},{"line_number":58,"context_line":"`editors`  should be have access to the resources specifed by the `reader`"},{"line_number":59,"context_line":"role."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Each of the services has their own admin roles defined.  In addition, the two"}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_3705b3c1","line":58,"updated":"2015-11-14 22:38:53.000000000","message":"\"should be have access\"?","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"83d542f9ed382f36c2cf83ba3659518c13f9821e","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"The `editor` role is for people that need to make standard changes, such as"},{"line_number":57,"context_line":"creating new virtual machines and  allocating floating IP addreses.  All"},{"line_number":58,"context_line":"`editors`  should be have access to the resources specifed by the `reader`"},{"line_number":59,"context_line":"role."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Each of the services has their own admin roles defined.  In addition, the two"}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba8a016a_5ecc2f89","line":58,"in_reply_to":"da85f559_3705b3c1","updated":"2015-11-17 01:50:42.000000000","message":"Done","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"b13e06b9063ace01399eea86d7a4a98f75501891","unresolved":false,"context_lines":[{"line_number":62,"context_line":"storage focused services have a joint role called `storage_admin` that implies"},{"line_number":63,"context_line":"both `swift_admin` and `cinder_admin`."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"If a user is assigned `all_admin`  in a project and request a token for that"},{"line_number":66,"context_line":"project, the token will have all of the implied roles enumerated in it:"},{"line_number":67,"context_line":"`cinder_admin`, `neutron_admin`, `glance_admin`, `swift_admin`, `editor`, and"},{"line_number":68,"context_line":"`browser`."}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_1ce0d4f9","line":65,"updated":"2015-11-14 20:12:57.000000000","message":"and requests","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"b13e06b9063ace01399eea86d7a4a98f75501891","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"If a user is assigned `all_admin`  in a project and request a token for that"},{"line_number":66,"context_line":"project, the token will have all of the implied roles enumerated in it:"},{"line_number":67,"context_line":"`cinder_admin`, `neutron_admin`, `glance_admin`, `swift_admin`, `editor`, and"},{"line_number":68,"context_line":"`browser`."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Any form of admin is implicitly an `editor`. A `reader` can view standard"}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_7cf1e0cc","line":67,"updated":"2015-11-14 20:12:57.000000000","message":"Add storage_admin","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"b13e06b9063ace01399eea86d7a4a98f75501891","unresolved":false,"context_lines":[{"line_number":65,"context_line":"If a user is assigned `all_admin`  in a project and request a token for that"},{"line_number":66,"context_line":"project, the token will have all of the implied roles enumerated in it:"},{"line_number":67,"context_line":"`cinder_admin`, `neutron_admin`, `glance_admin`, `swift_admin`, `editor`, and"},{"line_number":68,"context_line":"`browser`."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Any form of admin is implicitly an `editor`. A `reader` can view standard"},{"line_number":71,"context_line":"data from any of the systems, but cannot affect any change.   The `editor`"}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_9cecc4f4","line":68,"updated":"2015-11-14 20:12:57.000000000","message":"browser -\u003e reader","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"0700461d10609818ff2dcd7cf24141d391d9b40d","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"The role relationships are illustrated in this directed acyclic graph"},{"line_number":78,"context_line":"(DAG) diagram.  The prior roles are above implied roles, with the"},{"line_number":79,"context_line":"arrows showing the direction of implication."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":".. code-block:: javascript"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_060f23e2","line":79,"updated":"2015-11-14 16:49:13.000000000","message":"For those less familiar with this, it might be helpful to have a bit more description such as the following:  \ns/The prior roles are above implied roles, with the arrows showing the direction of implication./The prior roles are shown above the implied subordinate roles, and the arrows show the direction of implication.  The example implementation table below also explicitly shows these relationships./","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"83d542f9ed382f36c2cf83ba3659518c13f9821e","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"The role relationships are illustrated in this directed acyclic graph"},{"line_number":78,"context_line":"(DAG) diagram.  The prior roles are above implied roles, with the"},{"line_number":79,"context_line":"arrows showing the direction of implication."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":".. code-block:: javascript"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba8a016a_fedba319","line":79,"in_reply_to":"da85f559_060f23e2","updated":"2015-11-17 01:50:42.000000000","message":"Done","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"68572f04a81bc185ce2dd7974a474f9ebf7e22dd","unresolved":false,"context_lines":[{"line_number":78,"context_line":"(DAG) diagram.  The prior roles are above implied roles, with the"},{"line_number":79,"context_line":"arrows showing the direction of implication."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":".. code-block:: javascript"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"                   all_admin"},{"line_number":84,"context_line":"                         |"}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_f70e4be4","line":81,"updated":"2015-11-14 22:38:53.000000000","message":"this is not javascript, just use double colons here. ::","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"83d542f9ed382f36c2cf83ba3659518c13f9821e","unresolved":false,"context_lines":[{"line_number":78,"context_line":"(DAG) diagram.  The prior roles are above implied roles, with the"},{"line_number":79,"context_line":"arrows showing the direction of implication."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":".. code-block:: javascript"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"                   all_admin"},{"line_number":84,"context_line":"                         |"}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba8a016a_5ecf4f56","line":81,"in_reply_to":"da85f559_f70e4be4","updated":"2015-11-17 01:50:42.000000000","message":"Done","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"68572f04a81bc185ce2dd7974a474f9ebf7e22dd","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"+-----------------+----------------------+"},{"line_number":111,"context_line":"| prior_role_id   |  implied_role_id     |"},{"line_number":112,"context_line":"+-----------------+----------------------+"},{"line_number":113,"context_line":"| all_admin       | neutron_admin        |"},{"line_number":114,"context_line":"+-----------------+----------------------+"},{"line_number":115,"context_line":"| all_admin       | glance_admin         |"}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_77033bb9","line":112,"updated":"2015-11-14 22:38:53.000000000","message":"use \u003d\u003d\u003d\u0027s instead of ----\u0027s to separate out the column headers\n\nhttp://stackoverflow.com/questions/5507359/vertical-headers-in-restructuredtext-tables","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"83d542f9ed382f36c2cf83ba3659518c13f9821e","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"+-----------------+----------------------+"},{"line_number":111,"context_line":"| prior_role_id   |  implied_role_id     |"},{"line_number":112,"context_line":"+-----------------+----------------------+"},{"line_number":113,"context_line":"| all_admin       | neutron_admin        |"},{"line_number":114,"context_line":"+-----------------+----------------------+"},{"line_number":115,"context_line":"| all_admin       | glance_admin         |"}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba8a016a_3ed28b01","line":112,"in_reply_to":"da85f559_77033bb9","updated":"2015-11-17 01:50:42.000000000","message":"Done","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"b13e06b9063ace01399eea86d7a4a98f75501891","unresolved":false,"context_lines":[{"line_number":116,"context_line":"+-----------------+----------------------+"},{"line_number":117,"context_line":"| all_admin       | swift_admin          |"},{"line_number":118,"context_line":"+-----------------+----------------------+"},{"line_number":119,"context_line":"| all_admin       | cinder_admin         |"},{"line_number":120,"context_line":"+-----------------+----------------------+"},{"line_number":121,"context_line":"| storage_admin   | swift_admin          |"},{"line_number":122,"context_line":"+-----------------+----------------------+"}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_9c9a846d","line":119,"updated":"2015-11-14 20:12:57.000000000","message":"all_admin       storage_admin","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"83d542f9ed382f36c2cf83ba3659518c13f9821e","unresolved":false,"context_lines":[{"line_number":116,"context_line":"+-----------------+----------------------+"},{"line_number":117,"context_line":"| all_admin       | swift_admin          |"},{"line_number":118,"context_line":"+-----------------+----------------------+"},{"line_number":119,"context_line":"| all_admin       | cinder_admin         |"},{"line_number":120,"context_line":"+-----------------+----------------------+"},{"line_number":121,"context_line":"| storage_admin   | swift_admin          |"},{"line_number":122,"context_line":"+-----------------+----------------------+"}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba8a016a_9e037773","line":119,"in_reply_to":"da85f559_9c9a846d","updated":"2015-11-17 01:50:42.000000000","message":"Done","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"b13e06b9063ace01399eea86d7a4a98f75501891","unresolved":false,"context_lines":[{"line_number":131,"context_line":"| cinder_admin    | editor               |"},{"line_number":132,"context_line":"+-----------------+----------------------+"},{"line_number":133,"context_line":"| swift_admin     | editor               |"},{"line_number":134,"context_line":"+-----------------+----------------------+"},{"line_number":135,"context_line":"| editor          | reader               |"},{"line_number":136,"context_line":"+-----------------+----------------------+"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_5c8bbc1e","line":134,"updated":"2015-11-14 20:12:57.000000000","message":"delete, duplication","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"83d542f9ed382f36c2cf83ba3659518c13f9821e","unresolved":false,"context_lines":[{"line_number":131,"context_line":"| cinder_admin    | editor               |"},{"line_number":132,"context_line":"+-----------------+----------------------+"},{"line_number":133,"context_line":"| swift_admin     | editor               |"},{"line_number":134,"context_line":"+-----------------+----------------------+"},{"line_number":135,"context_line":"| editor          | reader               |"},{"line_number":136,"context_line":"+-----------------+----------------------+"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba8a016a_3ef92b81","line":134,"in_reply_to":"da85f559_5c8bbc1e","updated":"2015-11-17 01:50:42.000000000","message":"Done","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"d63cc1db03934edaac33fdca49956fde5b862b28","unresolved":false,"context_lines":[{"line_number":136,"context_line":"+-----------------+----------------------+"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Implied roles will be added to the token validation response.  With"},{"line_number":140,"context_line":"the above example, if a user was explicitly assigned the role `editor`"},{"line_number":141,"context_line":"on a project, the validation of a token for that user and scoped to"},{"line_number":142,"context_line":"the project would have the roles:  `editor` and `reader` included in"}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_0002a209","line":139,"updated":"2015-11-15 08:44:55.000000000","message":"would a better word than \"added\" be \"expanded\"?","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"83d542f9ed382f36c2cf83ba3659518c13f9821e","unresolved":false,"context_lines":[{"line_number":136,"context_line":"+-----------------+----------------------+"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Implied roles will be added to the token validation response.  With"},{"line_number":140,"context_line":"the above example, if a user was explicitly assigned the role `editor`"},{"line_number":141,"context_line":"on a project, the validation of a token for that user and scoped to"},{"line_number":142,"context_line":"the project would have the roles:  `editor` and `reader` included in"}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba8a016a_de7edfe3","line":139,"in_reply_to":"da85f559_0002a209","updated":"2015-11-17 01:50:42.000000000","message":"Both explicitly assigned and implied roles will be included in the token validation response.","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"68572f04a81bc185ce2dd7974a474f9ebf7e22dd","unresolved":false,"context_lines":[{"line_number":143,"context_line":"the response."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"An initial configuration option of \u0027infer_roles\u0027 in the [token]"},{"line_number":147,"context_line":"section of the config file will control whether to expand roles in"},{"line_number":148,"context_line":"when issuing tokens."},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_97fedfac","line":146,"updated":"2015-11-14 22:38:53.000000000","message":"in the [token] section? why not [assignment]?","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"83d542f9ed382f36c2cf83ba3659518c13f9821e","unresolved":false,"context_lines":[{"line_number":143,"context_line":"the response."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"An initial configuration option of \u0027infer_roles\u0027 in the [token]"},{"line_number":147,"context_line":"section of the config file will control whether to expand roles in"},{"line_number":148,"context_line":"when issuing tokens."},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba8a016a_9e5ff771","line":146,"in_reply_to":"da85f559_97fedfac","updated":"2015-11-17 01:50:42.000000000","message":"Its a token configuration option.  A different value could/should go in the [policy] section to indicate if implication should be expanded there as well.","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"5645bc8dd8db73570cd743b248f3ef22dab1045c","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"An initial configuration option of \u0027infer_roles\u0027 in the [token]"},{"line_number":147,"context_line":"section of the config file will control whether to expand roles in"},{"line_number":148,"context_line":"when issuing tokens."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_ac45fab3","line":147,"updated":"2015-11-13 14:30:08.000000000","message":"nit - remove \"in\"","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"83d542f9ed382f36c2cf83ba3659518c13f9821e","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"An initial configuration option of \u0027infer_roles\u0027 in the [token]"},{"line_number":147,"context_line":"section of the config file will control whether to expand roles in"},{"line_number":148,"context_line":"when issuing tokens."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba8a016a_5e52ef68","line":147,"in_reply_to":"da85f559_ac45fab3","updated":"2015-11-17 01:50:42.000000000","message":"Done","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"68572f04a81bc185ce2dd7974a474f9ebf7e22dd","unresolved":false,"context_lines":[{"line_number":169,"context_line":"Security Impact"},{"line_number":170,"context_line":"---------------"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Describe any potential security impact on the system.  Some of the items to"},{"line_number":173,"context_line":"consider include:"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_d71b071b","line":172,"updated":"2015-11-14 22:38:53.000000000","message":"remove boilerplate","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"83d542f9ed382f36c2cf83ba3659518c13f9821e","unresolved":false,"context_lines":[{"line_number":169,"context_line":"Security Impact"},{"line_number":170,"context_line":"---------------"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Describe any potential security impact on the system.  Some of the items to"},{"line_number":173,"context_line":"consider include:"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba8a016a_7ed1f3cc","line":172,"in_reply_to":"da85f559_d71b071b","updated":"2015-11-17 01:50:42.000000000","message":"Done","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"68572f04a81bc185ce2dd7974a474f9ebf7e22dd","unresolved":false,"context_lines":[{"line_number":181,"context_line":"  a new way to access sensitive information or a new way to login?"},{"line_number":182,"context_line":"* Yes.  Role assignments now may have associated implicit assignments."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"* Does this change involve cryptography or hashing?"},{"line_number":185,"context_line":"* No."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"* Does this change require the use of sudo or any elevated privileges?"}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_f725eb5b","line":184,"updated":"2015-11-14 22:38:53.000000000","message":"remove the ones that say no","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"83d542f9ed382f36c2cf83ba3659518c13f9821e","unresolved":false,"context_lines":[{"line_number":181,"context_line":"  a new way to access sensitive information or a new way to login?"},{"line_number":182,"context_line":"* Yes.  Role assignments now may have associated implicit assignments."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"* Does this change involve cryptography or hashing?"},{"line_number":185,"context_line":"* No."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"* Does this change require the use of sudo or any elevated privileges?"}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba8a016a_3edccbe3","line":184,"in_reply_to":"da85f559_f725eb5b","updated":"2015-11-17 01:50:42.000000000","message":"Done","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"68572f04a81bc185ce2dd7974a474f9ebf7e22dd","unresolved":false,"context_lines":[{"line_number":202,"context_line":"Notifications Impact"},{"line_number":203,"context_line":"--------------------"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"One notification will be sent out with all of the roles assigned and inherited."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"Other End User Impact"}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_97157fe6","line":205,"updated":"2015-11-14 22:38:53.000000000","message":"what causes this notification to be emitted?","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"83d542f9ed382f36c2cf83ba3659518c13f9821e","unresolved":false,"context_lines":[{"line_number":202,"context_line":"Notifications Impact"},{"line_number":203,"context_line":"--------------------"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"One notification will be sent out with all of the roles assigned and inherited."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"Other End User Impact"}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba8a016a_7e9fb303","line":205,"in_reply_to":"da85f559_97157fe6","updated":"2015-11-17 01:50:42.000000000","message":"changed to \"One notification will be sent out on each change of the implied roles rules.\"","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"5645bc8dd8db73570cd743b248f3ef22dab1045c","unresolved":false,"context_lines":[{"line_number":228,"context_line":"that have not already been mentioned, such as:"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"* Change takes effect Immediately, but no implied roles will be"},{"line_number":231,"context_line":"  defined without a configuration option change."},{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"Developer Impact"}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_ac4adaaa","line":231,"updated":"2015-11-13 14:30:08.000000000","message":"I\u0027m not sure the configuration option controls whether the implied roles are define....just whether they are placed in the token.","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"83d542f9ed382f36c2cf83ba3659518c13f9821e","unresolved":false,"context_lines":[{"line_number":228,"context_line":"that have not already been mentioned, such as:"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"* Change takes effect Immediately, but no implied roles will be"},{"line_number":231,"context_line":"  defined without a configuration option change."},{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"Developer Impact"}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba8a016a_9e7297e4","line":231,"in_reply_to":"da85f559_ac4adaaa","updated":"2015-11-17 01:50:42.000000000","message":"Done","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"68572f04a81bc185ce2dd7974a474f9ebf7e22dd","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"All code changes must be in the Assignments backend."},{"line_number":257,"context_line":"*  Add parent field to entities"},{"line_number":258,"context_line":"*  Expand the create and edit APIs"},{"line_number":259,"context_line":"*  Account for hierarchy on listing role assignments"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":18,"id":"da85f559_57d63728","line":258,"updated":"2015-11-14 22:38:53.000000000","message":"role APIs*","commit_id":"5deabe4b7ffea1e91bb6babd6bcef41ec81fc885"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"731a75f52071df80b826e437b45ebfaaec555ca5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"OpenStack is attempting to solve problems of scale.  The RBAC model"},{"line_number":22,"context_line":"needs to support improvde delegation in order to scale."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Keystone roles map to a set of permissions to perform operations on"},{"line_number":25,"context_line":"resources. Today, there are relatively few roles defined, with each"}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba8a016a_b979aa95","line":22,"updated":"2015-11-17 09:14:02.000000000","message":"nit: s/improvde/improved/","commit_id":"4c8732b016d6538c8279445300e3a58c9c407ee1"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"731a75f52071df80b826e437b45ebfaaec555ca5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"being mapped to a large number of APIs.  This is very coarse grained"},{"line_number":27,"context_line":"access control.  If deployers are going to provide a finer-grained"},{"line_number":28,"context_line":"model, the number of roles will quickly escalate.  To minimize the"},{"line_number":29,"context_line":"burden on the  adminstators, users role assignments be limited to one"},{"line_number":30,"context_line":"or a small number of roles per user per project.  This is not possible"},{"line_number":31,"context_line":"with the current role assignment mechanism."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba8a016a_39adbae9","line":29,"updated":"2015-11-17 09:14:02.000000000","message":"nit s/users roles assignments be/user role assignments would ideally be/","commit_id":"4c8732b016d6538c8279445300e3a58c9c407ee1"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"370d28908badd5f938f786136a06941357235063","unresolved":false,"context_lines":[{"line_number":26,"context_line":"being mapped to a large number of APIs.  This is very coarse grained"},{"line_number":27,"context_line":"access control.  If deployers are going to provide a finer-grained"},{"line_number":28,"context_line":"model, the number of roles will quickly escalate.  To minimize the"},{"line_number":29,"context_line":"burden on the  adminstators, users role assignments be limited to one"},{"line_number":30,"context_line":"or a small number of roles per user per project.  This is not possible"},{"line_number":31,"context_line":"with the current role assignment mechanism."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba8a016a_003b849d","line":29,"in_reply_to":"ba8a016a_39adbae9","updated":"2015-11-17 15:24:39.000000000","message":"Went further and said \"To minimize the burden on the  adminstators, users\u0027 explicit  role assignments must be\nlimitable to one role per user per project.  This is not possible with the current role assignment mechanism.\"\n\nIt does not have to be \"one\" but it will be, by far the norm.","commit_id":"4c8732b016d6538c8279445300e3a58c9c407ee1"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"731a75f52071df80b826e437b45ebfaaec555ca5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"with the current role assignment mechanism."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"As an organization increases in size, the amount of hierarchy must"},{"line_number":34,"context_line":"increas accordingly, or managers quickly become overwhelmed by the"},{"line_number":35,"context_line":"sheer number of requests by subordinates.  A manager has power over"},{"line_number":36,"context_line":"all of the operations performed by a subordinate, even if they never"},{"line_number":37,"context_line":"chose to perform those operations directly.  The authority to perform"}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba8a016a_d9db4e1a","line":34,"updated":"2015-11-17 09:14:02.000000000","message":"s/increas/increase/","commit_id":"4c8732b016d6538c8279445300e3a58c9c407ee1"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"731a75f52071df80b826e437b45ebfaaec555ca5","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"As an organization increases in size, the amount of hierarchy must"},{"line_number":34,"context_line":"increas accordingly, or managers quickly become overwhelmed by the"},{"line_number":35,"context_line":"sheer number of requests by subordinates.  A manager has power over"},{"line_number":36,"context_line":"all of the operations performed by a subordinate, even if they never"},{"line_number":37,"context_line":"chose to perform those operations directly.  The authority to perform"},{"line_number":38,"context_line":"those operations comes from the superior to the subordinate.   If a"}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba8a016a_14e8bbe1","line":35,"updated":"2015-11-17 09:14:02.000000000","message":"Maybe start this sentence \"Typically a manager has the authority to perform all of....\"","commit_id":"4c8732b016d6538c8279445300e3a58c9c407ee1"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"370d28908badd5f938f786136a06941357235063","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"As an organization increases in size, the amount of hierarchy must"},{"line_number":34,"context_line":"increas accordingly, or managers quickly become overwhelmed by the"},{"line_number":35,"context_line":"sheer number of requests by subordinates.  A manager has power over"},{"line_number":36,"context_line":"all of the operations performed by a subordinate, even if they never"},{"line_number":37,"context_line":"chose to perform those operations directly.  The authority to perform"},{"line_number":38,"context_line":"those operations comes from the superior to the subordinate.   If a"}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba8a016a_40518cd7","line":35,"in_reply_to":"ba8a016a_14e8bbe1","updated":"2015-11-17 15:24:39.000000000","message":"\" A manager has responsibility for all....\"","commit_id":"4c8732b016d6538c8279445300e3a58c9c407ee1"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"731a75f52071df80b826e437b45ebfaaec555ca5","unresolved":false,"context_lines":[{"line_number":36,"context_line":"all of the operations performed by a subordinate, even if they never"},{"line_number":37,"context_line":"chose to perform those operations directly.  The authority to perform"},{"line_number":38,"context_line":"those operations comes from the superior to the subordinate.   If a"},{"line_number":39,"context_line":"superior cannot delegate appropriately, an organization cannot function."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"A user should be able to delegate a subset of their power.  If a user"},{"line_number":42,"context_line":"is a system administrator, they are irresponsible delegating full"}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba8a016a_74b907e9","line":39,"updated":"2015-11-17 09:14:02.000000000","message":"This last sentence is perhaps a bit over the top in terms of teaching our readers how to run three business!","commit_id":"4c8732b016d6538c8279445300e3a58c9c407ee1"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"370d28908badd5f938f786136a06941357235063","unresolved":false,"context_lines":[{"line_number":36,"context_line":"all of the operations performed by a subordinate, even if they never"},{"line_number":37,"context_line":"chose to perform those operations directly.  The authority to perform"},{"line_number":38,"context_line":"those operations comes from the superior to the subordinate.   If a"},{"line_number":39,"context_line":"superior cannot delegate appropriately, an organization cannot function."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"A user should be able to delegate a subset of their power.  If a user"},{"line_number":42,"context_line":"is a system administrator, they are irresponsible delegating full"}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba8a016a_206d6898","line":39,"in_reply_to":"ba8a016a_74b907e9","updated":"2015-11-17 15:24:39.000000000","message":"It is pointing out a limitation in our software that will make it tough for them to use it to run their business.  Scale requires delegation.","commit_id":"4c8732b016d6538c8279445300e3a58c9c407ee1"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"731a75f52071df80b826e437b45ebfaaec555ca5","unresolved":false,"context_lines":[{"line_number":38,"context_line":"those operations comes from the superior to the subordinate.   If a"},{"line_number":39,"context_line":"superior cannot delegate appropriately, an organization cannot function."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"A user should be able to delegate a subset of their power.  If a user"},{"line_number":42,"context_line":"is a system administrator, they are irresponsible delegating full"},{"line_number":43,"context_line":"administration to a user when the required operation is not a"},{"line_number":44,"context_line":"priveledged operation.  Even casual users should be able to provide"}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba8a016a_94058bc3","line":41,"updated":"2015-11-17 09:14:02.000000000","message":"To link this to the last paragraph, maybe start with:\n\n\"In OpenStack terms, a user should be....\"","commit_id":"4c8732b016d6538c8279445300e3a58c9c407ee1"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"370d28908badd5f938f786136a06941357235063","unresolved":false,"context_lines":[{"line_number":38,"context_line":"those operations comes from the superior to the subordinate.   If a"},{"line_number":39,"context_line":"superior cannot delegate appropriately, an organization cannot function."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"A user should be able to delegate a subset of their power.  If a user"},{"line_number":42,"context_line":"is a system administrator, they are irresponsible delegating full"},{"line_number":43,"context_line":"administration to a user when the required operation is not a"},{"line_number":44,"context_line":"priveledged operation.  Even casual users should be able to provide"}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba8a016a_0030649d","line":41,"in_reply_to":"ba8a016a_94058bc3","updated":"2015-11-17 15:24:39.000000000","message":"Done:  replaced power with capabilites.","commit_id":"4c8732b016d6538c8279445300e3a58c9c407ee1"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"731a75f52071df80b826e437b45ebfaaec555ca5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"A user should be able to delegate a subset of their power.  If a user"},{"line_number":42,"context_line":"is a system administrator, they are irresponsible delegating full"},{"line_number":43,"context_line":"administration to a user when the required operation is not a"},{"line_number":44,"context_line":"priveledged operation.  Even casual users should be able to provide"},{"line_number":45,"context_line":"access to a subset of their resources without providing full access to"},{"line_number":46,"context_line":"all of them.  In order to split apart permissions this way, the roles"},{"line_number":47,"context_line":"need to provide sufficient information to deduce that a larger and more"}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba8a016a_347a9f25","line":44,"updated":"2015-11-17 09:14:02.000000000","message":"maybe change end of sentence to:\n\n\"...is not a privileged operation (or perhaps only effects a subset of resources).\"","commit_id":"4c8732b016d6538c8279445300e3a58c9c407ee1"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"370d28908badd5f938f786136a06941357235063","unresolved":false,"context_lines":[{"line_number":41,"context_line":"A user should be able to delegate a subset of their power.  If a user"},{"line_number":42,"context_line":"is a system administrator, they are irresponsible delegating full"},{"line_number":43,"context_line":"administration to a user when the required operation is not a"},{"line_number":44,"context_line":"priveledged operation.  Even casual users should be able to provide"},{"line_number":45,"context_line":"access to a subset of their resources without providing full access to"},{"line_number":46,"context_line":"all of them.  In order to split apart permissions this way, the roles"},{"line_number":47,"context_line":"need to provide sufficient information to deduce that a larger and more"}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba8a016a_a0ab9888","line":44,"in_reply_to":"ba8a016a_347a9f25","updated":"2015-11-17 15:24:39.000000000","message":"Done","commit_id":"4c8732b016d6538c8279445300e3a58c9c407ee1"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"731a75f52071df80b826e437b45ebfaaec555ca5","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Users are assigned to roles within a project to perform"},{"line_number":56,"context_line":"operations. Often, those operations must be performed by users with"},{"line_number":57,"context_line":"different roles.  As such, the roles can be viewed as a hierarchym,"},{"line_number":58,"context_line":"with larger roles inheriting the permissions assigned to the smaller"},{"line_number":59,"context_line":"roles.  In order to implement this hierarchy, the relationship between"},{"line_number":60,"context_line":"the roles must clearly indicate when a prior role implies another"}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba8a016a_14f99b80","line":57,"updated":"2015-11-17 09:14:02.000000000","message":"This second sentence doesn\u0027t really make sense...in fact maybe we swap this whole para to something more simple, e.g.:\n\n\"In order to better model the typical hierarchical authority model of an enterprise, it is proposed that we allow relationships between roles to be defined, where one (larger more powerful role) can imply that the user also obtains a set of smaller (less powerful) roles.\"\n\nI wouldn\u0027t mention hierarchym\u0027s (is that a real word?) yet....you show this nicely in the example below","commit_id":"4c8732b016d6538c8279445300e3a58c9c407ee1"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"370d28908badd5f938f786136a06941357235063","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Users are assigned to roles within a project to perform"},{"line_number":56,"context_line":"operations. Often, those operations must be performed by users with"},{"line_number":57,"context_line":"different roles.  As such, the roles can be viewed as a hierarchym,"},{"line_number":58,"context_line":"with larger roles inheriting the permissions assigned to the smaller"},{"line_number":59,"context_line":"roles.  In order to implement this hierarchy, the relationship between"},{"line_number":60,"context_line":"the roles must clearly indicate when a prior role implies another"}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba8a016a_20aec885","line":57,"in_reply_to":"ba8a016a_14f99b80","updated":"2015-11-17 15:24:39.000000000","message":"Done","commit_id":"4c8732b016d6538c8279445300e3a58c9c407ee1"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"731a75f52071df80b826e437b45ebfaaec555ca5","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Users are assigned to roles within a project to perform"},{"line_number":56,"context_line":"operations. Often, those operations must be performed by users with"},{"line_number":57,"context_line":"different roles.  As such, the roles can be viewed as a hierarchym,"},{"line_number":58,"context_line":"with larger roles inheriting the permissions assigned to the smaller"},{"line_number":59,"context_line":"roles.  In order to implement this hierarchy, the relationship between"},{"line_number":60,"context_line":"the roles must clearly indicate when a prior role implies another"},{"line_number":61,"context_line":"role."}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba8a016a_94126bb3","line":58,"updated":"2015-11-17 09:14:02.000000000","message":"larger roles inherit the permissions assigned to the smaller role?","commit_id":"4c8732b016d6538c8279445300e3a58c9c407ee1"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"370d28908badd5f938f786136a06941357235063","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Users are assigned to roles within a project to perform"},{"line_number":56,"context_line":"operations. Often, those operations must be performed by users with"},{"line_number":57,"context_line":"different roles.  As such, the roles can be viewed as a hierarchym,"},{"line_number":58,"context_line":"with larger roles inheriting the permissions assigned to the smaller"},{"line_number":59,"context_line":"roles.  In order to implement this hierarchy, the relationship between"},{"line_number":60,"context_line":"the roles must clearly indicate when a prior role implies another"},{"line_number":61,"context_line":"role."}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba8a016a_e0dd2015","line":58,"in_reply_to":"ba8a016a_94126bb3","updated":"2015-11-17 15:24:39.000000000","message":"Done","commit_id":"4c8732b016d6538c8279445300e3a58c9c407ee1"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"731a75f52071df80b826e437b45ebfaaec555ca5","unresolved":false,"context_lines":[{"line_number":225,"context_line":"Other End User Impact"},{"line_number":226,"context_line":"---------------------"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"We will need to expand the create role and modify role apis to allow for"},{"line_number":229,"context_line":"adding/removing parents to roles."},{"line_number":230,"context_line":""},{"line_number":231,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba8a016a_0fb0a842","line":228,"updated":"2015-11-17 09:14:02.000000000","message":"maybe just call them the \"role APIs\" here, rathe than create/modify role since we are not actually changing these I think","commit_id":"4c8732b016d6538c8279445300e3a58c9c407ee1"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"370d28908badd5f938f786136a06941357235063","unresolved":false,"context_lines":[{"line_number":225,"context_line":"Other End User Impact"},{"line_number":226,"context_line":"---------------------"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"We will need to expand the create role and modify role apis to allow for"},{"line_number":229,"context_line":"adding/removing parents to roles."},{"line_number":230,"context_line":""},{"line_number":231,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba8a016a_0099441f","line":228,"in_reply_to":"ba8a016a_0fb0a842","updated":"2015-11-17 15:24:39.000000000","message":"Rewrote this.  I think it reflects an obsolete version of the spec","commit_id":"4c8732b016d6538c8279445300e3a58c9c407ee1"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"db155dc7d93b65b0f98e3629d1b76ba7f6539a28","unresolved":false,"context_lines":[{"line_number":27,"context_line":"access control.  If deployers are going to provide a finer-grained"},{"line_number":28,"context_line":"model, the number of roles will quickly escalate.  To minimize the"},{"line_number":29,"context_line":"burden on the  adminstators, users\u0027 explicit  role assignments must be"},{"line_number":30,"context_line":"limitable to one role per user per project.  This is not possible with"},{"line_number":31,"context_line":"the current role assignment mechanism."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba8a016a_35c91d79","line":30,"updated":"2015-11-17 17:59:30.000000000","message":"hmm...this sounds overly restrictive, less is better for sure, but the way this is written it sounds as if you have more than one and  we have failed...","commit_id":"d48aab174f9a7316a79f67011f24cff059a901df"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"e24670d947b74d2d739b2b846fd6749a5a639d94","unresolved":false,"context_lines":[{"line_number":27,"context_line":"access control.  If deployers are going to provide a finer-grained"},{"line_number":28,"context_line":"model, the number of roles will quickly escalate.  To minimize the"},{"line_number":29,"context_line":"burden on the  adminstators, users\u0027 explicit  role assignments must be"},{"line_number":30,"context_line":"limitable to one role per user per project.  This is not possible with"},{"line_number":31,"context_line":"the current role assignment mechanism."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba8a016a_4458a732","line":30,"in_reply_to":"ba8a016a_35c91d79","updated":"2015-11-17 23:19:57.000000000","message":"But there\u0027s a difference between \"limitable\" and \"limited\" though.","commit_id":"d48aab174f9a7316a79f67011f24cff059a901df"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"d11662f53ee3257a44fe916368a848df9dd62aae","unresolved":false,"context_lines":[{"line_number":35,"context_line":"increase accordingly, or managers quickly become overwhelmed by the"},{"line_number":36,"context_line":"sheer number of requests by subordinates.  A manager has"},{"line_number":37,"context_line":"responsibility for all of the operations performed by a subordinate,"},{"line_number":38,"context_line":"even if they never chose to perform those operations directly.  The"},{"line_number":39,"context_line":"authority to perform those operations comes from the superior to the"},{"line_number":40,"context_line":"subordinate.   If a superior cannot delegate appropriately, an"},{"line_number":41,"context_line":"organization cannot function."}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba8a016a_21c1d580","line":38,"updated":"2015-11-17 22:50:35.000000000","message":"That should be \u0027choose\u0027 right?","commit_id":"d48aab174f9a7316a79f67011f24cff059a901df"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"e24670d947b74d2d739b2b846fd6749a5a639d94","unresolved":false,"context_lines":[{"line_number":41,"context_line":"organization cannot function."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"When interacting with automated systems, a user should be able to"},{"line_number":44,"context_line":"delegate a subset of their capabilities.  If a user is a system"},{"line_number":45,"context_line":"administrator, they are irresponsible delegating full administration"},{"line_number":46,"context_line":"to a user when the required operation is not a priveledged operation"},{"line_number":47,"context_line":"or even if it effects only a subset of resources.  Even casual users"}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba8a016a_24cb2374","line":44,"updated":"2015-11-17 23:19:57.000000000","message":"That\u0027s an interesting use case. Say we have \n\n A implies B imples C implies D\n\nand user is assigned A for a given project, user should be able to view and delegate A, B, C, or D right? I think yes. But the implementation could be cumbersome though.","commit_id":"d48aab174f9a7316a79f67011f24cff059a901df"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"f5e8664175a44cbc9b41a63078f4a55a4a38bfeb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"organization cannot function."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"When interacting with automated systems, a user should be able to"},{"line_number":44,"context_line":"delegate a subset of their capabilities.  If a user is a system"},{"line_number":45,"context_line":"administrator, they are irresponsible delegating full administration"},{"line_number":46,"context_line":"to a user when the required operation is not a priveledged operation"},{"line_number":47,"context_line":"or even if it effects only a subset of resources.  Even casual users"}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba8a016a_3a101a4e","line":44,"in_reply_to":"ba8a016a_24cb2374","updated":"2015-11-17 23:47:34.000000000","message":"Nevermind, the answer is in line 186.","commit_id":"d48aab174f9a7316a79f67011f24cff059a901df"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"d11662f53ee3257a44fe916368a848df9dd62aae","unresolved":false,"context_lines":[{"line_number":43,"context_line":"When interacting with automated systems, a user should be able to"},{"line_number":44,"context_line":"delegate a subset of their capabilities.  If a user is a system"},{"line_number":45,"context_line":"administrator, they are irresponsible delegating full administration"},{"line_number":46,"context_line":"to a user when the required operation is not a priveledged operation"},{"line_number":47,"context_line":"or even if it effects only a subset of resources.  Even casual users"},{"line_number":48,"context_line":"should be able to provide access to a subset of their resources"},{"line_number":49,"context_line":"without providing full access to all of them.  In order to split apart"}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba8a016a_a10945df","line":46,"updated":"2015-11-17 22:50:35.000000000","message":"no \u0027d\u0027 in \u0027privileged\u0027.","commit_id":"d48aab174f9a7316a79f67011f24cff059a901df"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"d11662f53ee3257a44fe916368a848df9dd62aae","unresolved":false,"context_lines":[{"line_number":44,"context_line":"delegate a subset of their capabilities.  If a user is a system"},{"line_number":45,"context_line":"administrator, they are irresponsible delegating full administration"},{"line_number":46,"context_line":"to a user when the required operation is not a priveledged operation"},{"line_number":47,"context_line":"or even if it effects only a subset of resources.  Even casual users"},{"line_number":48,"context_line":"should be able to provide access to a subset of their resources"},{"line_number":49,"context_line":"without providing full access to all of them.  In order to split apart"},{"line_number":50,"context_line":"permissions this way, the roles need to provide sufficient information"}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba8a016a_c10489c1","line":47,"updated":"2015-11-17 22:50:35.000000000","message":"affects, no effects.","commit_id":"d48aab174f9a7316a79f67011f24cff059a901df"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"d11662f53ee3257a44fe916368a848df9dd62aae","unresolved":false,"context_lines":[{"line_number":60,"context_line":"Users are assigned to roles within a project to perform"},{"line_number":61,"context_line":"operations.  In order to better model the typical hierarchical"},{"line_number":62,"context_line":"authority model of a large organization, we will allow relationships between"},{"line_number":63,"context_line":"roles to be defined, where one (larger more powerful role) can imply"},{"line_number":64,"context_line":"that the user also obtains a set of smaller (less powerful) roles."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Often, those operations must be performed by users with"}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba8a016a_01e931e6","line":63,"updated":"2015-11-17 22:50:35.000000000","message":"why the comma?","commit_id":"d48aab174f9a7316a79f67011f24cff059a901df"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"d11662f53ee3257a44fe916368a848df9dd62aae","unresolved":false,"context_lines":[{"line_number":99,"context_line":"`editors`  should have access to the resources specifed by the `reader`"},{"line_number":100,"context_line":"role."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Each of the services has their own admin roles defined.  In addition, the two"},{"line_number":103,"context_line":"storage focused services have a joint role called `storage_admin` that implies"},{"line_number":104,"context_line":"both `swift_admin` and `cinder_admin`."},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba8a016a_c177a938","line":102,"updated":"2015-11-17 22:50:35.000000000","message":"s/has/have/","commit_id":"d48aab174f9a7316a79f67011f24cff059a901df"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"e24670d947b74d2d739b2b846fd6749a5a639d94","unresolved":false,"context_lines":[{"line_number":183,"context_line":"validation response.  With the above example, if a user was explicitly"},{"line_number":184,"context_line":"assigned the role `editor` on a project, the validation of a token for"},{"line_number":185,"context_line":"that user and scoped to the project would have the roles:  `editor`"},{"line_number":186,"context_line":"and `reader` included in the response."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"An initial configuration option of \u0027infer_roles\u0027 in the [token]"}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba8a016a_4445076e","line":186,"updated":"2015-11-17 23:19:57.000000000","message":"how do token revocation looks like if one of the implied roles in the chain has changed?","commit_id":"d48aab174f9a7316a79f67011f24cff059a901df"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"f5e8664175a44cbc9b41a63078f4a55a4a38bfeb","unresolved":false,"context_lines":[{"line_number":183,"context_line":"validation response.  With the above example, if a user was explicitly"},{"line_number":184,"context_line":"assigned the role `editor` on a project, the validation of a token for"},{"line_number":185,"context_line":"that user and scoped to the project would have the roles:  `editor`"},{"line_number":186,"context_line":"and `reader` included in the response."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"An initial configuration option of \u0027infer_roles\u0027 in the [token]"}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba8a016a_1a3c36c7","line":186,"in_reply_to":"ba8a016a_4445076e","updated":"2015-11-17 23:47:34.000000000","message":"with Fernet tokens, we don\u0027t have to worry about revoking tokens when role assignment changes","commit_id":"d48aab174f9a7316a79f67011f24cff059a901df"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"db155dc7d93b65b0f98e3629d1b76ba7f6539a28","unresolved":false,"context_lines":[{"line_number":186,"context_line":"and `reader` included in the response."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"An initial configuration option of \u0027infer_roles\u0027 in the [token]"},{"line_number":190,"context_line":"section of the config file will control whether to expand roles when"},{"line_number":191,"context_line":"issuing tokens."},{"line_number":192,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba8a016a_953b2938","line":189,"updated":"2015-11-17 17:59:30.000000000","message":"(although the exact name is probably outside the scope of this spec) maybe \u0027expand_infer_roles\u0027 or \u0027expand_inferred_roles\u0027 ?","commit_id":"d48aab174f9a7316a79f67011f24cff059a901df"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"e24670d947b74d2d739b2b846fd6749a5a639d94","unresolved":false,"context_lines":[{"line_number":186,"context_line":"and `reader` included in the response."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"An initial configuration option of \u0027infer_roles\u0027 in the [token]"},{"line_number":190,"context_line":"section of the config file will control whether to expand roles when"},{"line_number":191,"context_line":"issuing tokens."},{"line_number":192,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba8a016a_c4825794","line":189,"in_reply_to":"ba8a016a_953b2938","updated":"2015-11-17 23:19:57.000000000","message":"why is the configuration option needed?","commit_id":"d48aab174f9a7316a79f67011f24cff059a901df"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"f30b01a5666d8ea65a78be9d4389532499ae138c","unresolved":false,"context_lines":[{"line_number":186,"context_line":"and `reader` included in the response."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"An initial configuration option of \u0027infer_roles\u0027 in the [token]"},{"line_number":190,"context_line":"section of the config file will control whether to expand roles when"},{"line_number":191,"context_line":"issuing tokens."},{"line_number":192,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba8a016a_15b16747","line":189,"in_reply_to":"ba8a016a_c4825794","updated":"2015-11-18 00:44:12.000000000","message":"expansion can be done a couple ways.  THis is the most reasonable, buyt not the only.  It could also be done in policy.  Having the config option lets be 1. Opt in, and 2. disable-able","commit_id":"d48aab174f9a7316a79f67011f24cff059a901df"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"d11662f53ee3257a44fe916368a848df9dd62aae","unresolved":false,"context_lines":[{"line_number":200,"context_line":"to carry all the subordinate roles around with himself as the system knows the"},{"line_number":201,"context_line":"role hierarchy."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"Role implication rules can be fetched separately from the token and"},{"line_number":204,"context_line":"cached in auth-token middlware, and then infer roles from the token"},{"line_number":205,"context_line":"prior to policy enforcement.  This will be implemented if required."},{"line_number":206,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba8a016a_213c752e","line":203,"updated":"2015-11-17 22:50:35.000000000","message":"replace the \u0027and\u0027 with a comma.","commit_id":"d48aab174f9a7316a79f67011f24cff059a901df"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"db155dc7d93b65b0f98e3629d1b76ba7f6539a28","unresolved":false,"context_lines":[{"line_number":261,"context_line":"----------------"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"In the future, policy files can take advantage of the hierarchical nature of"},{"line_number":264,"context_line":"roles and avoid rules like domain_admin_or_project_admin."},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"Implementation"},{"line_number":267,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba8a016a_55e14199","line":264,"updated":"2015-11-17 17:59:30.000000000","message":"I\u0027m still not sure if saying this here is more confusing than not...since this section is something that developers must do....maybe just add this to the bottom of the main Proposed change section","commit_id":"d48aab174f9a7316a79f67011f24cff059a901df"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"f30b01a5666d8ea65a78be9d4389532499ae138c","unresolved":false,"context_lines":[{"line_number":261,"context_line":"----------------"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"In the future, policy files can take advantage of the hierarchical nature of"},{"line_number":264,"context_line":"roles and avoid rules like domain_admin_or_project_admin."},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"Implementation"},{"line_number":267,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba8a016a_95d1d759","line":264,"in_reply_to":"ba8a016a_55e14199","updated":"2015-11-18 00:44:12.000000000","message":"Done","commit_id":"d48aab174f9a7316a79f67011f24cff059a901df"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"e24670d947b74d2d739b2b846fd6749a5a639d94","unresolved":false,"context_lines":[{"line_number":261,"context_line":"----------------"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"In the future, policy files can take advantage of the hierarchical nature of"},{"line_number":264,"context_line":"roles and avoid rules like domain_admin_or_project_admin."},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"Implementation"},{"line_number":267,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":20,"id":"ba8a016a_5f6f10c5","line":264,"in_reply_to":"ba8a016a_55e14199","updated":"2015-11-17 23:19:57.000000000","message":"yeah, shouldn\u0027t be any developer impact here","commit_id":"d48aab174f9a7316a79f67011f24cff059a901df"}],"specs/kilo/hierarchical-roles.rst":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"3e1a18904946ea7dd12f29a12273727dcb4219f5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"`bp hierarchical-roles \u003chttps://blueprints.launchpad.net/keystone/+spec/hierarchical-roles\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Allow role definitions to imply other role defintions, so that, with one role"},{"line_number":15,"context_line":"assignment, the user will inherit a user multiple roles."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_b6035c72","line":14,"updated":"2014-10-20 11:55:24.000000000","message":"nit: role defintions","commit_id":"ff9ca21a33a15693b3805aa06f9d90ac8d5689a5"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"f27d4416d394831c99d2a67716f550097c9031c3","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Allow role definitions to imply other role defintions, so that, with one role"},{"line_number":15,"context_line":"assignment, the user will inherit a user multiple roles."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_1d1a8e6e","line":16,"updated":"2014-10-20 05:12:28.000000000","message":"change \"a user multiple roles\" to \"all subordinate roles\"","commit_id":"ff9ca21a33a15693b3805aa06f9d90ac8d5689a5"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"f27d4416d394831c99d2a67716f550097c9031c3","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"In a persisted store, define a set of rules that state one role-assignment"},{"line_number":32,"context_line":"impy additional role assignments."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"First implementation is the SQL backend.  Other"},{"line_number":35,"context_line":"backends will follow if requested. Add an additional implied_role"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_3d2672bb","line":32,"updated":"2014-10-20 05:12:28.000000000","message":"one superior role-assignment implies additional subordinate role assignments.","commit_id":"ff9ca21a33a15693b3805aa06f9d90ac8d5689a5"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"3e1a18904946ea7dd12f29a12273727dcb4219f5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"backends will follow if requested. Add an additional implied_role"},{"line_number":36,"context_line":"table with two columns:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"superior_role_id,  subordinate_role_id"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"When issuing a token, all roles that can be inferred from the explicit roles"},{"line_number":41,"context_line":"will be added to the token."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_761734a4","line":38,"updated":"2014-10-20 11:55:24.000000000","message":"why do we need 2 pointers? Having a subordinate_role_id we also restrict one \"child\" for each role.","commit_id":"ff9ca21a33a15693b3805aa06f9d90ac8d5689a5"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"89f5ec9404571e6dbb32522b39a65fc1bb9cbe22","unresolved":false,"context_lines":[{"line_number":35,"context_line":"backends will follow if requested. Add an additional implied_role"},{"line_number":36,"context_line":"table with two columns:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"superior_role_id,  subordinate_role_id"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"When issuing a token, all roles that can be inferred from the explicit roles"},{"line_number":41,"context_line":"will be added to the token."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_831297b2","line":38,"in_reply_to":"9aa7fdbe_761734a4","updated":"2014-10-20 13:53:16.000000000","message":"No,  with a many to many relationship, you need a pointer to each.","commit_id":"ff9ca21a33a15693b3805aa06f9d90ac8d5689a5"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"f27d4416d394831c99d2a67716f550097c9031c3","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"When issuing a token, all roles that can be inferred from the explicit roles"},{"line_number":41,"context_line":"will be added to the token."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"This is often termed hierarchical roles, but this implementation avoids a"},{"line_number":44,"context_line":"strict hierearchy in favor of generating a directed-acyclic-graph (DAG): the"},{"line_number":45,"context_line":"same role may be inferred my multiple other roles.  At enforcement time"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_bd3982da","line":42,"updated":"2014-10-20 05:12:28.000000000","message":"change explicit to superior","commit_id":"ff9ca21a33a15693b3805aa06f9d90ac8d5689a5"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"f27d4416d394831c99d2a67716f550097c9031c3","unresolved":false,"context_lines":[{"line_number":43,"context_line":"This is often termed hierarchical roles, but this implementation avoids a"},{"line_number":44,"context_line":"strict hierearchy in favor of generating a directed-acyclic-graph (DAG): the"},{"line_number":45,"context_line":"same role may be inferred my multiple other roles.  At enforcement time"},{"line_number":46,"context_line":"the required abstraction is a set of role assignements, not a tree or a graph."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"An example hierarchy would split the admin for each service from a global admin"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_5d525614","line":46,"updated":"2014-10-20 05:12:28.000000000","message":"same role may be subordinate to multiple superior roles.","commit_id":"ff9ca21a33a15693b3805aa06f9d90ac8d5689a5"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"f27d4416d394831c99d2a67716f550097c9031c3","unresolved":false,"context_lines":[{"line_number":60,"context_line":"      +-glance_admin"},{"line_number":61,"context_line":"           |"},{"line_number":62,"context_line":"           +-member"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Note it is not a strict hierarchy as, both the `neutron_admin` and the"},{"line_number":66,"context_line":"`glance_admin` roles imply the member role.  As such, the hierarchy is a DAG."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_9d5cbe27","line":63,"updated":"2014-10-20 05:12:28.000000000","message":"It would be better to draw this diagram showing that the same member  role was subordinate to both glanc and neutron admin\n\nall admin\n\n|     .................. \\\n\nneutron admin                       glance admin\n\n|     .... ................    /\n\nmember","commit_id":"ff9ca21a33a15693b3805aa06f9d90ac8d5689a5"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"3e1a18904946ea7dd12f29a12273727dcb4219f5","unresolved":false,"context_lines":[{"line_number":60,"context_line":"      +-glance_admin"},{"line_number":61,"context_line":"           |"},{"line_number":62,"context_line":"           +-member"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Note it is not a strict hierarchy as, both the `neutron_admin` and the"},{"line_number":66,"context_line":"`glance_admin` roles imply the member role.  As such, the hierarchy is a DAG."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_b6d6fcc3","line":63,"in_reply_to":"9aa7fdbe_9d5cbe27","updated":"2014-10-20 11:55:24.000000000","message":"We have two or more *different* member roles?","commit_id":"ff9ca21a33a15693b3805aa06f9d90ac8d5689a5"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"89f5ec9404571e6dbb32522b39a65fc1bb9cbe22","unresolved":false,"context_lines":[{"line_number":60,"context_line":"      +-glance_admin"},{"line_number":61,"context_line":"           |"},{"line_number":62,"context_line":"           +-member"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Note it is not a strict hierarchy as, both the `neutron_admin` and the"},{"line_number":66,"context_line":"`glance_admin` roles imply the member role.  As such, the hierarchy is a DAG."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_03f8677b","line":63,"in_reply_to":"9aa7fdbe_b6d6fcc3","updated":"2014-10-20 13:53:16.000000000","message":"Should be clearer now.","commit_id":"ff9ca21a33a15693b3805aa06f9d90ac8d5689a5"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"f27d4416d394831c99d2a67716f550097c9031c3","unresolved":false,"context_lines":[{"line_number":95,"context_line":"+-----------------+------------------+"},{"line_number":96,"context_line":"| editor          | reader           |"},{"line_number":97,"context_line":"+-----------------+------------------+"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"The `reader` role is for people that need to be able to inspect the values"},{"line_number":101,"context_line":"of resources in a project, but not make any changes to those resources."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_3d74b29b","line":98,"updated":"2014-10-20 05:12:28.000000000","message":"It would be much better if the diagram and the table were consistent ie. the table showed how to represent the diagram","commit_id":"ff9ca21a33a15693b3805aa06f9d90ac8d5689a5"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"89f5ec9404571e6dbb32522b39a65fc1bb9cbe22","unresolved":false,"context_lines":[{"line_number":95,"context_line":"+-----------------+------------------+"},{"line_number":96,"context_line":"| editor          | reader           |"},{"line_number":97,"context_line":"+-----------------+------------------+"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"The `reader` role is for people that need to be able to inspect the values"},{"line_number":101,"context_line":"of resources in a project, but not make any changes to those resources."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_8304577f","line":98,"in_reply_to":"9aa7fdbe_3d74b29b","updated":"2014-10-20 13:53:16.000000000","message":"Done","commit_id":"ff9ca21a33a15693b3805aa06f9d90ac8d5689a5"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"f27d4416d394831c99d2a67716f550097c9031c3","unresolved":false,"context_lines":[{"line_number":113,"context_line":"project, the token will have all of the implies roles enumerated in it:"},{"line_number":114,"context_line":"`cinder_admin`, `neutron_admin`, `glance_admin`, `swift_admin`, `editor`, and"},{"line_number":115,"context_line":"`browser`."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_9d73deb0","line":116,"updated":"2014-10-20 05:12:28.000000000","message":"what about storage admin? the table shows this is not subordinate to all-admin","commit_id":"ff9ca21a33a15693b3805aa06f9d90ac8d5689a5"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"89f5ec9404571e6dbb32522b39a65fc1bb9cbe22","unresolved":false,"context_lines":[{"line_number":113,"context_line":"project, the token will have all of the implies roles enumerated in it:"},{"line_number":114,"context_line":"`cinder_admin`, `neutron_admin`, `glance_admin`, `swift_admin`, `editor`, and"},{"line_number":115,"context_line":"`browser`."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_43db4f1b","line":116,"in_reply_to":"9aa7fdbe_9d73deb0","updated":"2014-10-20 13:53:16.000000000","message":"True, but I think it is important to show that not all roles are inherited.  I would not expect storage_admin to have operations associated with it directly, just that it is operational shorthand.  Since we are driving this via the token body., we would want to eliminate any non-essential roles.","commit_id":"ff9ca21a33a15693b3805aa06f9d90ac8d5689a5"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1be895e9b3bfd10dcd9c34e2a7d235e8e04153e4","unresolved":false,"context_lines":[{"line_number":23,"context_line":"without providing a way to distinguish between administration for two different"},{"line_number":24,"context_line":"functions.  For example, both Cinder and Neutron have admin only tasks, but"},{"line_number":25,"context_line":"different users should be performing them:  in most organizations, there is"},{"line_number":26,"context_line":"as distinction betwen storage admins and netowrk admins."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed Change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_99a684c0","line":26,"updated":"2014-10-20 14:45:34.000000000","message":"network*","commit_id":"f18b2f6b34afc2f5e5725858bc1b1075b83b6b96"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1be895e9b3bfd10dcd9c34e2a7d235e8e04153e4","unresolved":false,"context_lines":[{"line_number":60,"context_line":"both `swift_admin` and `cinder_admin`."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"If a user is assigned `all_admin`  in a project and request a token for that"},{"line_number":63,"context_line":"project, the token will have all of the implies roles enumerated in it:"},{"line_number":64,"context_line":"`cinder_admin`, `neutron_admin`, `glance_admin`, `swift_admin`, `editor`, and"},{"line_number":65,"context_line":"`browser`."},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_798f2024","line":63,"updated":"2014-10-20 14:45:34.000000000","message":"implied*","commit_id":"f18b2f6b34afc2f5e5725858bc1b1075b83b6b96"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1be895e9b3bfd10dcd9c34e2a7d235e8e04153e4","unresolved":false,"context_lines":[{"line_number":62,"context_line":"If a user is assigned `all_admin`  in a project and request a token for that"},{"line_number":63,"context_line":"project, the token will have all of the implies roles enumerated in it:"},{"line_number":64,"context_line":"`cinder_admin`, `neutron_admin`, `glance_admin`, `swift_admin`, `editor`, and"},{"line_number":65,"context_line":"`browser`."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Any form of admin is implicitly an `editor`. A `reader` can view standard"},{"line_number":68,"context_line":"data from any of the systems, but cannot affect any change.   The `editor`"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_d99e4c56","line":65,"updated":"2014-10-20 14:45:34.000000000","message":"Should these names be OpenStack project codename specific?","commit_id":"f18b2f6b34afc2f5e5725858bc1b1075b83b6b96"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1be895e9b3bfd10dcd9c34e2a7d235e8e04153e4","unresolved":false,"context_lines":[{"line_number":143,"context_line":"role hierarchy."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"The expansion of the role hierarchy could be performed by the policy"},{"line_number":146,"context_line":"engine in the client.  Hoowever, as of now there is n guarantee that the"},{"line_number":147,"context_line":"client will fetch its policy file from Keystone.  To add implied roles as"},{"line_number":148,"context_line":"part of the policy engine will unevenly distribute the enforcement of implied"},{"line_number":149,"context_line":"roles throught the OpenStack services."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_b9e7c8e3","line":146,"updated":"2014-10-20 14:45:34.000000000","message":"However*, no*","commit_id":"f18b2f6b34afc2f5e5725858bc1b1075b83b6b96"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1be895e9b3bfd10dcd9c34e2a7d235e8e04153e4","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"Current role assignment notifications will be unchanged."},{"line_number":194,"context_line":"Role definitions are not currently part of the notifications process, but"},{"line_number":195,"context_line":"probably should be."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Other End User Impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_7979e0fb","line":195,"updated":"2014-10-20 14:45:34.000000000","message":"Looks like notifications are delivered from the Policy API in Keystone\n\nhttps://github.com/openstack/keystone/blob/917e154800562c833d7781efe090749654c72613/keystone/assignment/core.py#L492","commit_id":"f18b2f6b34afc2f5e5725858bc1b1075b83b6b96"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"dd6172a0dcdf308ed813989dfd64609fd377ed55","unresolved":false,"context_lines":[{"line_number":23,"context_line":"without providing a way to distinguish between administration for two different"},{"line_number":24,"context_line":"functions.  For example, both Cinder and Neutron have admin only tasks, but"},{"line_number":25,"context_line":"different users should be performing them:  in most organizations, there is"},{"line_number":26,"context_line":"as distinction betwen storage admins and network admins."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed Change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_2ddc4612","line":26,"updated":"2014-11-04 09:50:01.000000000","message":"The problem description does not seem to align with the solution provided below. Yes, we need to distinguish different \"admins\" (i.e. Nova admin from Swift admin) and that can be done via naming convention, namespace, or perhaps role meta data.\n\nRole hierarchy, on the other hand, may offer us flexibility in role management and role assignment. This is essentially role groups, much like user groups, except it can also be nested.","commit_id":"a20043cb5ed8f8a223859db2a6cc998190bae089"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"508b914e06c8e402603a61c7c9bbadf71136d5a4","unresolved":false,"context_lines":[{"line_number":24,"context_line":"functions.  For example, both Cinder and Neutron have admin only tasks, but"},{"line_number":25,"context_line":"different users should be performing them:  in most organizations, there is"},{"line_number":26,"context_line":"as distinction betwen storage admins and network admins."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed Change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_bafcff3f","line":27,"updated":"2014-11-01 19:46:14.000000000","message":"a distinction","commit_id":"a20043cb5ed8f8a223859db2a6cc998190bae089"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"dd6172a0dcdf308ed813989dfd64609fd377ed55","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"In a persisted store, define a set of rules that state one superior role"},{"line_number":32,"context_line":"assignment implies additional subordinate role assignments."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"First implementation is the SQL backend.  Other"},{"line_number":35,"context_line":"backends will follow if requested. Add an additional implied_role"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_ade91682","line":32,"updated":"2014-11-04 09:50:01.000000000","message":"This may have performance implications as there could be multiple roundtrips to the backend.","commit_id":"a20043cb5ed8f8a223859db2a6cc998190bae089"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"508b914e06c8e402603a61c7c9bbadf71136d5a4","unresolved":false,"context_lines":[{"line_number":38,"context_line":"superior_role_id,  subordinate_role_id"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"When issuing a token, all roles that can be inferred from the explicit superior"},{"line_number":41,"context_line":"roles will be added to the token."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"This is often termed hierarchical roles, but this implementation avoids a"},{"line_number":44,"context_line":"strict hierearchy in favor of generating a directed-acyclic-graph (DAG): the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_daf9cb4e","line":41,"updated":"2014-11-01 19:46:14.000000000","message":"What does explicit mean in this context. Is it the role specified for the user at login time, or does it also cover a subordinate role that is also the superior role of another subordinate role.\n\nIn other words, is this trying to limit role inheritance to just one level in the role hierarchy or not? If not, then I suggest remove the word explicit as it adds nothing but confusion.","commit_id":"a20043cb5ed8f8a223859db2a6cc998190bae089"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"dd6172a0dcdf308ed813989dfd64609fd377ed55","unresolved":false,"context_lines":[{"line_number":38,"context_line":"superior_role_id,  subordinate_role_id"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"When issuing a token, all roles that can be inferred from the explicit superior"},{"line_number":41,"context_line":"roles will be added to the token."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"This is often termed hierarchical roles, but this implementation avoids a"},{"line_number":44,"context_line":"strict hierearchy in favor of generating a directed-acyclic-graph (DAG): the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_957d4671","line":41,"in_reply_to":"7a8c0949_daf9cb4e","updated":"2014-11-04 09:50:01.000000000","message":"I presume we\u0027ll have to walk the tree to figure out all the roles.","commit_id":"a20043cb5ed8f8a223859db2a6cc998190bae089"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"dd6172a0dcdf308ed813989dfd64609fd377ed55","unresolved":false,"context_lines":[{"line_number":43,"context_line":"This is often termed hierarchical roles, but this implementation avoids a"},{"line_number":44,"context_line":"strict hierearchy in favor of generating a directed-acyclic-graph (DAG): the"},{"line_number":45,"context_line":"same role may be subordinate to multiple superior roles.  At enforcement time"},{"line_number":46,"context_line":"the required abstraction is a set of role assignements, not a tree or a graph."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"An example hierarchy:"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_8d99ba21","line":46,"updated":"2014-11-04 09:50:01.000000000","message":"Performance could be expensive, depending on the graph. We do have to walk the graph to figure out the effective roles on every token issuance (and possibly token validate for AE tokens).","commit_id":"a20043cb5ed8f8a223859db2a6cc998190bae089"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"508b914e06c8e402603a61c7c9bbadf71136d5a4","unresolved":false,"context_lines":[{"line_number":63,"context_line":"project, the token will have all of the implied roles enumerated in it:"},{"line_number":64,"context_line":"`cinder_admin`, `neutron_admin`, `glance_admin`, `swift_admin`, `editor`, and"},{"line_number":65,"context_line":"`browser`."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Any form of admin is implicitly an `editor`. A `reader` can view standard"},{"line_number":68,"context_line":"data from any of the systems, but cannot affect any change.   The `editor`"},{"line_number":69,"context_line":"role is superior to `reader`:  there would be no reason to assign someone the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_1a9b5319","line":66,"updated":"2014-11-01 19:46:14.000000000","message":"reader","commit_id":"a20043cb5ed8f8a223859db2a6cc998190bae089"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"dd6172a0dcdf308ed813989dfd64609fd377ed55","unresolved":false,"context_lines":[{"line_number":68,"context_line":"data from any of the systems, but cannot affect any change.   The `editor`"},{"line_number":69,"context_line":"role is superior to `reader`:  there would be no reason to assign someone the"},{"line_number":70,"context_line":"`editor` role without assigning the `reader` role as well.  We often want to"},{"line_number":71,"context_line":"assign the `reader` role without the `editor` role for audit and monitoring."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"The following DAG describes the roles.  Superior roles are above subordinate,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_4d72724a","line":71,"updated":"2014-11-04 09:50:01.000000000","message":"Do we need the entire role hierarchy? In other words, does assigning the \"reader\" role by itself means anything, or is it at the discretion of the services?","commit_id":"a20043cb5ed8f8a223859db2a6cc998190bae089"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"508b914e06c8e402603a61c7c9bbadf71136d5a4","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                              reader"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Note it is not a strict hierarchy.  For example,  both the `neutron_admin` and"},{"line_number":98,"context_line":"the `glance_admin` roles imply the member role.  As such, the hierarchy is a"},{"line_number":99,"context_line":"DAG."},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_e7826b51","line":97,"updated":"2014-11-01 19:46:14.000000000","message":"It is a general role hierarchy according to the NIST RBAC standard","commit_id":"a20043cb5ed8f8a223859db2a6cc998190bae089"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"dd6172a0dcdf308ed813989dfd64609fd377ed55","unresolved":false,"context_lines":[{"line_number":110,"context_line":"+-----------------+----------------------+"},{"line_number":111,"context_line":"| all_admin       | swift_admin          |"},{"line_number":112,"context_line":"+-----------------+----------------------+"},{"line_number":113,"context_line":"| all_admin       | cinder_admin         |"},{"line_number":114,"context_line":"+-----------------+----------------------+"},{"line_number":115,"context_line":"| storage_admin   | swift_admin          |"},{"line_number":116,"context_line":"+-----------------+----------------------+"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_0d914a52","line":113,"updated":"2014-11-04 09:50:01.000000000","message":"all_admin    storage_admin?\n\nstorage_admin is a subordinate of all_admin right?","commit_id":"a20043cb5ed8f8a223859db2a6cc998190bae089"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"508b914e06c8e402603a61c7c9bbadf71136d5a4","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"The expansion of the role hierarchy could be performed by the policy"},{"line_number":146,"context_line":"engine in the client.  However, as of now there is no guarantee that the"},{"line_number":147,"context_line":"client will fetch its policy file from Keystone.  To add implied roles as"},{"line_number":148,"context_line":"part of the policy engine will unevenly distribute the enforcement of implied"},{"line_number":149,"context_line":"roles throught the OpenStack services."},{"line_number":150,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_07885770","line":147,"updated":"2014-11-01 19:46:14.000000000","message":"subordinate roles","commit_id":"a20043cb5ed8f8a223859db2a6cc998190bae089"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"508b914e06c8e402603a61c7c9bbadf71136d5a4","unresolved":false,"context_lines":[{"line_number":145,"context_line":"The expansion of the role hierarchy could be performed by the policy"},{"line_number":146,"context_line":"engine in the client.  However, as of now there is no guarantee that the"},{"line_number":147,"context_line":"client will fetch its policy file from Keystone.  To add implied roles as"},{"line_number":148,"context_line":"part of the policy engine will unevenly distribute the enforcement of implied"},{"line_number":149,"context_line":"roles throught the OpenStack services."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Both solutions are more complex."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_47825f50","line":148,"updated":"2014-11-01 19:46:14.000000000","message":"subordinate roles","commit_id":"a20043cb5ed8f8a223859db2a6cc998190bae089"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"508b914e06c8e402603a61c7c9bbadf71136d5a4","unresolved":false,"context_lines":[{"line_number":166,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":167,"context_line":"  a new way to access sensitive information or a new way to login?"},{"line_number":168,"context_line":"* Yes.  Role assignments now may have associated implicit assignments."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"* Does this change involve cryptography or hashing?"},{"line_number":172,"context_line":"* No."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a8c0949_67967b96","line":169,"updated":"2014-11-01 19:46:14.000000000","message":"There will need to be new or modified API for defining the general role hierarchy.","commit_id":"a20043cb5ed8f8a223859db2a6cc998190bae089"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a3bcfa3ad71c88ba048ac6479c66a4d29d83b423","unresolved":false,"context_lines":[{"line_number":11,"context_line":"`bp hierarchical-roles \u003chttps://blueprints.launchpad.net/keystone/+spec/hierarchical-roles\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Allow role definitions to imply other role defintions, so that, with one"},{"line_number":15,"context_line":"superior role assignment, the user will inherit all subordinate roles."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_82f8c0c5","line":14,"updated":"2014-12-16 21:26:13.000000000","message":"the second \"definitions\" is spelled incorrectly","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a3bcfa3ad71c88ba048ac6479c66a4d29d83b423","unresolved":false,"context_lines":[{"line_number":15,"context_line":"superior role assignment, the user will inherit all subordinate roles."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Problem Description"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_6214b4f5","line":18,"updated":"2014-12-16 21:26:13.000000000","message":"random excess line breaks?","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a3bcfa3ad71c88ba048ac6479c66a4d29d83b423","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Roles in OpenStack are very static. For many operations, we specify \"admin\""},{"line_number":23,"context_line":"without providing a way to distinguish between administration for two different"},{"line_number":24,"context_line":"functions.  For example, both Cinder and Neutron have admin only tasks, but"},{"line_number":25,"context_line":"different users should be performing them:  in most organizations, there is"},{"line_number":26,"context_line":"as distinction betwen storage admins and network admins."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_a2ca1c6c","line":24,"updated":"2014-12-16 21:26:13.000000000","message":"admin-only","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a3bcfa3ad71c88ba048ac6479c66a4d29d83b423","unresolved":false,"context_lines":[{"line_number":23,"context_line":"without providing a way to distinguish between administration for two different"},{"line_number":24,"context_line":"functions.  For example, both Cinder and Neutron have admin only tasks, but"},{"line_number":25,"context_line":"different users should be performing them:  in most organizations, there is"},{"line_number":26,"context_line":"as distinction betwen storage admins and network admins."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed Change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_22a62cc2","line":26,"updated":"2014-12-16 21:26:13.000000000","message":"s/as/a/","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"dbe307d6c532506f9bf22816ecec82bef842f259","unresolved":false,"context_lines":[{"line_number":23,"context_line":"without providing a way to distinguish between administration for two different"},{"line_number":24,"context_line":"functions.  For example, both Cinder and Neutron have admin only tasks, but"},{"line_number":25,"context_line":"different users should be performing them:  in most organizations, there is"},{"line_number":26,"context_line":"as distinction betwen storage admins and network admins."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed Change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a890539_e4ba896d","line":26,"updated":"2014-11-19 09:11:55.000000000","message":"s/betwen/between","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"e62c682010eac7a3cc6affb7b493fc375ce69a9c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"functions.  For example, both Cinder and Neutron have admin only tasks, but"},{"line_number":25,"context_line":"different users should be performing them:  in most organizations, there is"},{"line_number":26,"context_line":"as distinction betwen storage admins and network admins."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed Change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a890539_637c34b6","line":27,"updated":"2014-11-15 09:35:47.000000000","message":"a distinction","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"e62c682010eac7a3cc6affb7b493fc375ce69a9c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"assignment implies additional subordinate role assignments."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"First implementation is the SQL backend.  Other"},{"line_number":35,"context_line":"backends will follow if requested. Add an additional implied_role"},{"line_number":36,"context_line":"table with two columns:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"superior_role_id,  subordinate_role_id"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a890539_a351bc37","line":35,"updated":"2014-11-15 09:35:47.000000000","message":"implied role table -\u003e role hierarchy table","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a3bcfa3ad71c88ba048ac6479c66a4d29d83b423","unresolved":false,"context_lines":[{"line_number":32,"context_line":"assignment implies additional subordinate role assignments."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"First implementation is the SQL backend.  Other"},{"line_number":35,"context_line":"backends will follow if requested. Add an additional implied_role"},{"line_number":36,"context_line":"table with two columns:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"superior_role_id,  subordinate_role_id"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_82c9a05c","line":35,"in_reply_to":"5a890539_a351bc37","updated":"2014-12-16 21:26:13.000000000","message":"you don\u0027t need to mention future work; if this spec only covers the SQL backend, that\u0027s fine.","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a3bcfa3ad71c88ba048ac6479c66a4d29d83b423","unresolved":false,"context_lines":[{"line_number":35,"context_line":"backends will follow if requested. Add an additional implied_role"},{"line_number":36,"context_line":"table with two columns:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"superior_role_id,  subordinate_role_id"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"This is often termed hierarchical roles, but this implementation avoids a"},{"line_number":41,"context_line":"strict hierearchy in favor of generating a directed-acyclic-graph (DAG): the"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_82a28098","line":38,"updated":"2014-12-16 21:26:13.000000000","message":"this is getting into implementation details that I don\u0027t think should be in specs. talk about what the table will store, but you don\u0027t need to get into literal column names, etc.","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"e62c682010eac7a3cc6affb7b493fc375ce69a9c","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"This is often termed hierarchical roles, but this implementation avoids a"},{"line_number":41,"context_line":"strict hierearchy in favor of generating a directed-acyclic-graph (DAG): the"},{"line_number":42,"context_line":"same role may be subordinate to multiple superior roles.  At enforcement time"},{"line_number":43,"context_line":"the required abstraction is a set of role assignements, not a tree or a graph."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"An example hierarchy:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a890539_230b0c2b","line":42,"updated":"2014-11-15 09:35:47.000000000","message":"This implementation avoids a strict hierarchy in favor of a general hierarchy, also termed a directed acyclic graph (DAG). The same role may have multiple superior roles and multiple subordinate roles.","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"dbe307d6c532506f9bf22816ecec82bef842f259","unresolved":false,"context_lines":[{"line_number":48,"context_line":"of resources in a project, but not make any changes to those resources."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The `editor` role is for people that need to make standard changes, such as"},{"line_number":51,"context_line":"creating new virtual machines and  allocating floating IP addreses.  All"},{"line_number":52,"context_line":"`editors`  should be have access to the resources specifed by the `reader`"},{"line_number":53,"context_line":"role."},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a890539_e43fe9d4","line":51,"updated":"2014-11-19 09:11:55.000000000","message":"s/addreses/addresses","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"dbe307d6c532506f9bf22816ecec82bef842f259","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The `editor` role is for people that need to make standard changes, such as"},{"line_number":51,"context_line":"creating new virtual machines and  allocating floating IP addreses.  All"},{"line_number":52,"context_line":"`editors`  should be have access to the resources specifed by the `reader`"},{"line_number":53,"context_line":"role."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Each of the services has their own admin roles defined.  In addition, the two"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a890539_642bf994","line":52,"updated":"2014-11-19 09:11:55.000000000","message":"s/should be have/should have ?","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a3bcfa3ad71c88ba048ac6479c66a4d29d83b423","unresolved":false,"context_lines":[{"line_number":59,"context_line":"If a user is assigned `all_admin`  in a project and request a token for that"},{"line_number":60,"context_line":"project, the token will have all of the implied roles enumerated in it:"},{"line_number":61,"context_line":"`cinder_admin`, `neutron_admin`, `glance_admin`, `swift_admin`, `editor`, and"},{"line_number":62,"context_line":"`browser`."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Any form of admin is implicitly an `editor`. A `reader` can view standard"},{"line_number":65,"context_line":"data from any of the systems, but cannot affect any change.   The `editor`"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_227e2ce5","line":62,"updated":"2014-12-16 21:26:13.000000000","message":"... that could be a *lot* of roles, and thus a *giant* token. it seems to me it should be up to the PEP to apply the hierarchy, not keystone.","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"dbe307d6c532506f9bf22816ecec82bef842f259","unresolved":false,"context_lines":[{"line_number":68,"context_line":"assign the `reader` role without the `editor` role for audit and monitoring."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"The following DAG describes the roles.  Superior roles are above subordinate,"},{"line_number":72,"context_line":"with a vertical line showing inheritance."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a890539_67477b4c","line":71,"updated":"2014-11-19 09:11:55.000000000","message":"DAG: just a reminder to put directed edges.","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a3bcfa3ad71c88ba048ac6479c66a4d29d83b423","unresolved":false,"context_lines":[{"line_number":72,"context_line":"with a vertical line showing inheritance."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. code-block:: javascript"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"                      all_admin"},{"line_number":78,"context_line":"                         |"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_edb41ed3","line":75,"range":{"start_line":75,"start_character":16,"end_line":75,"end_character":26},"updated":"2014-12-16 21:26:13.000000000","message":"you can just leave this as\n\n  ::\n\nthere\u0027s no benefit to using a particular language style, as long as it\u0027s a literal","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a3bcfa3ad71c88ba048ac6479c66a4d29d83b423","unresolved":false,"context_lines":[{"line_number":82,"context_line":"           |             |             |         +          |"},{"line_number":83,"context_line":"           |             |             |   +-----+------+   |"},{"line_number":84,"context_line":"           |             |             |   |            |   |"},{"line_number":85,"context_line":"      neutron_admin glance_admin swift_admin          cinder_admin"},{"line_number":86,"context_line":"           |             |             |                    |"},{"line_number":87,"context_line":"           +-------------+-------+-----+--------------------+"},{"line_number":88,"context_line":"                                 |"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_e2f8a44b","line":85,"updated":"2014-12-16 21:26:13.000000000","message":"what\u0027s the point of having a direct relationship between all_admin and swift_admin, and between all_admin and cinder_admin? i don\u0027t see any benefit.","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"e62c682010eac7a3cc6affb7b493fc375ce69a9c","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                              editor"},{"line_number":90,"context_line":"                                 |"},{"line_number":91,"context_line":"                              reader"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Note it is not a strict hierarchy.  For example,  both the `neutron_admin` and"},{"line_number":95,"context_line":"the `glance_admin` roles imply the member role.  As such, the hierarchy is a"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a890539_9e06d71b","line":92,"updated":"2014-11-15 09:35:47.000000000","message":"You need to remove the direct link between swift admin and all admin, and between cinder admin and all admin, since these links go via storage admin.","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"e62c682010eac7a3cc6affb7b493fc375ce69a9c","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Note it is not a strict hierarchy.  For example,  both the `neutron_admin` and"},{"line_number":95,"context_line":"the `glance_admin` roles imply the member role.  As such, the hierarchy is a"},{"line_number":96,"context_line":"DAG."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a890539_7e768ba5","line":95,"updated":"2014-11-15 09:35:47.000000000","message":"imply the editor role (and reader role).","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a3bcfa3ad71c88ba048ac6479c66a4d29d83b423","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Note it is not a strict hierarchy.  For example,  both the `neutron_admin` and"},{"line_number":95,"context_line":"the `glance_admin` roles imply the member role.  As such, the hierarchy is a"},{"line_number":96,"context_line":"DAG."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_22c1cce4","line":95,"updated":"2014-12-16 21:26:13.000000000","message":"there\u0027s no \"member\" role in the above diagram, so it might not be clear what you\u0027re referring to","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a3bcfa3ad71c88ba048ac6479c66a4d29d83b423","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Note it is not a strict hierarchy.  For example,  both the `neutron_admin` and"},{"line_number":95,"context_line":"the `glance_admin` roles imply the member role.  As such, the hierarchy is a"},{"line_number":96,"context_line":"DAG."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Here is an example implementation"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_6272f4e6","line":96,"updated":"2014-12-16 21:26:13.000000000","message":"use of a DAG is never really justified here","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"e62c682010eac7a3cc6affb7b493fc375ce69a9c","unresolved":false,"context_lines":[{"line_number":106,"context_line":"| all_admin       | glance_admin         |"},{"line_number":107,"context_line":"+-----------------+----------------------+"},{"line_number":108,"context_line":"| all_admin       | swift_admin          |"},{"line_number":109,"context_line":"+-----------------+----------------------+"},{"line_number":110,"context_line":"| all_admin       | cinder_admin         |"},{"line_number":111,"context_line":"+-----------------+----------------------+"},{"line_number":112,"context_line":"| storage_admin   | swift_admin          |"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a890539_de0cdf3d","line":109,"updated":"2014-11-15 09:35:47.000000000","message":"replace swift_admin  with  storage_admin","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"e62c682010eac7a3cc6affb7b493fc375ce69a9c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"| all_admin       | swift_admin          |"},{"line_number":109,"context_line":"+-----------------+----------------------+"},{"line_number":110,"context_line":"| all_admin       | cinder_admin         |"},{"line_number":111,"context_line":"+-----------------+----------------------+"},{"line_number":112,"context_line":"| storage_admin   | swift_admin          |"},{"line_number":113,"context_line":"+-----------------+----------------------+"},{"line_number":114,"context_line":"| storage_admin   | cinder_admin         |"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a890539_be5553fb","line":111,"updated":"2014-11-15 09:35:47.000000000","message":"Delete the above row. Not needed.","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"e62c682010eac7a3cc6affb7b493fc375ce69a9c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"| cinder_admin    | editor               |"},{"line_number":123,"context_line":"+-----------------+----------------------+"},{"line_number":124,"context_line":"| swift_admin     | editor               |"},{"line_number":125,"context_line":"+-----------------+----------------------+"},{"line_number":126,"context_line":"| editor          | reader               |"},{"line_number":127,"context_line":"+-----------------+----------------------+"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a890539_9e541700","line":125,"updated":"2014-11-15 09:35:47.000000000","message":"Delete the above row. Duplication.","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a3bcfa3ad71c88ba048ac6479c66a4d29d83b423","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"When issuing a token, only explicitly assigned roles will be added to the"},{"line_number":130,"context_line":"token.  All expansion of hierarchical roles will be done via the generation of"},{"line_number":131,"context_line":"rules into policy.json.  To simpify the rules, the hierarchy will be flattened,"},{"line_number":132,"context_line":"with one rule per path down the inheritance tree."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"An example of rules today in nova\u0027s policy file is `admin_or_owner` that looks"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_024a1083","line":131,"updated":"2014-12-16 21:26:13.000000000","message":"``policy.json``","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"e62c682010eac7a3cc6affb7b493fc375ce69a9c","unresolved":false,"context_lines":[{"line_number":130,"context_line":"token.  All expansion of hierarchical roles will be done via the generation of"},{"line_number":131,"context_line":"rules into policy.json.  To simpify the rules, the hierarchy will be flattened,"},{"line_number":132,"context_line":"with one rule per path down the inheritance tree."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"An example of rules today in nova\u0027s policy file is `admin_or_owner` that looks"},{"line_number":135,"context_line":"like this:"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a890539_de7f7f64","line":133,"updated":"2014-11-15 09:35:47.000000000","message":"I dont fully understand this. What does this mean for all_admin in the table above? It has four paths down the hierarchy, namely: \n\nall_admin-\u003eneutron_admin-\u003eeditor-\u003ereader\nditto glance_admin\nall_admin-\u003estorage_admin-\u003eswift_admin-\u003eeditor-\u003ereader\nditto cinder_admin","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a3bcfa3ad71c88ba048ac6479c66a4d29d83b423","unresolved":false,"context_lines":[{"line_number":130,"context_line":"token.  All expansion of hierarchical roles will be done via the generation of"},{"line_number":131,"context_line":"rules into policy.json.  To simpify the rules, the hierarchy will be flattened,"},{"line_number":132,"context_line":"with one rule per path down the inheritance tree."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"An example of rules today in nova\u0027s policy file is `admin_or_owner` that looks"},{"line_number":135,"context_line":"like this:"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_42441874","line":133,"in_reply_to":"5a890539_de7f7f64","updated":"2014-12-16 21:26:13.000000000","message":"++","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a3bcfa3ad71c88ba048ac6479c66a4d29d83b423","unresolved":false,"context_lines":[{"line_number":135,"context_line":"like this:"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":".. code-block:: javascript"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    \"context_is_admin\":  \"role:admin\","},{"line_number":141,"context_line":"    \"admin_or_owner\":  \"is_admin:True or project_id:%(project_id)s\","}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_a25a1c4e","line":138,"updated":"2014-12-16 21:26:13.000000000","message":"for javascript to render correctly, you need surrounding curly braces","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a3bcfa3ad71c88ba048ac6479c66a4d29d83b423","unresolved":false,"context_lines":[{"line_number":144,"context_line":"have today is \"Member\"  so these could be replaced with the following rules:"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"ROLE_MEMBER: \"(role:admin or role:member) and project_id:%(project_id)s\""},{"line_number":147,"context_line":"ROLE_PROJECT_ADMIN:\"(role:admin) and project_id:%(project_id)s\""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"APIS that current use rule:admin_or_owner or admin_api like this:"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_c2572825","line":147,"updated":"2014-12-16 21:26:13.000000000","message":"literal block?","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a3bcfa3ad71c88ba048ac6479c66a4d29d83b423","unresolved":false,"context_lines":[{"line_number":146,"context_line":"ROLE_MEMBER: \"(role:admin or role:member) and project_id:%(project_id)s\""},{"line_number":147,"context_line":"ROLE_PROJECT_ADMIN:\"(role:admin) and project_id:%(project_id)s\""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"APIS that current use rule:admin_or_owner or admin_api like this:"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":".. code-block:: javascript"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_0231300b","line":149,"updated":"2014-12-16 21:26:13.000000000","message":"- s/APIS/APIs/\n\n- s/current/currently/\n\n- ``double backticks`` on the literals","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"e62c682010eac7a3cc6affb7b493fc375ce69a9c","unresolved":false,"context_lines":[{"line_number":147,"context_line":"ROLE_PROJECT_ADMIN:\"(role:admin) and project_id:%(project_id)s\""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"APIS that current use rule:admin_or_owner or admin_api like this:"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":".. code-block:: javascript"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    \"compute:v3:servers:start\": \"rule:admin_or_owner\","}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a890539_1e958786","line":150,"updated":"2014-11-15 09:35:47.000000000","message":"that currently use rule:admin.... look like this:","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a3bcfa3ad71c88ba048ac6479c66a4d29d83b423","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"APIS that current use rule:admin_or_owner or admin_api like this:"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":".. code-block:: javascript"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    \"compute:v3:servers:start\": \"rule:admin_or_owner\","},{"line_number":154,"context_line":"    \"compute:v3:servers:stop\": \"rule:admin_or_owner\","}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_822440c7","line":151,"updated":"2014-12-16 21:26:13.000000000","message":"need braces","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a3bcfa3ad71c88ba048ac6479c66a4d29d83b423","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    \"compute:v3:servers:stop\": \"rule:admin_or_owner\","},{"line_number":155,"context_line":"    \"compute_extension:admin_actions\": \"rule:admin_api\","},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Could be rewritten as:"},{"line_number":158,"context_line":".. code-block:: javascript"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    \"compute:v3:servers:start\": \"rule:ROLE_MEMBER\","}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_c22e48a5","line":157,"updated":"2014-12-16 21:26:13.000000000","message":"add whitespace after the paragraph, and before the literal block","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a3bcfa3ad71c88ba048ac6479c66a4d29d83b423","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    \"compute_extension:admin_actions\": \"rule:admin_api\","},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Could be rewritten as:"},{"line_number":158,"context_line":".. code-block:: javascript"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    \"compute:v3:servers:start\": \"rule:ROLE_MEMBER\","},{"line_number":161,"context_line":"    \"compute:v3:servers:stop\": \"rule:ROLE_MEMBER\""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_a2213cb6","line":158,"updated":"2014-12-16 21:26:13.000000000","message":"need braces","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"e62c682010eac7a3cc6affb7b493fc375ce69a9c","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    \"compute:v3:servers:stop\": \"rule:ROLE_MEMBER\""},{"line_number":162,"context_line":"    \"compute_extension:admin_actions\": \"rule:ROLE_ADMIN\","},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"In the future, if a deploye wishes to split a role, they may do so."},{"line_number":165,"context_line":"For example,  \"compute_extension:admin_actions:createBackup\" uses the"},{"line_number":166,"context_line":"rule:admin_or_owner.  If this was a commonly delegated task, and a user wished"},{"line_number":167,"context_line":"to be able to delegate just the \"BACKUP\" role,  member could inherit backup."}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a890539_fedefb6b","line":164,"updated":"2014-11-15 09:35:47.000000000","message":"deployer","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a3bcfa3ad71c88ba048ac6479c66a4d29d83b423","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":".. code-block:: javascript"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    ROLE_BACKUP:"},{"line_number":173,"context_line":"    \"(role:admin or role:member or role:backup) and project_id:%(project_id)s\""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_02185083","line":172,"updated":"2014-12-16 21:26:13.000000000","message":"this isn\u0027t JS","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a3bcfa3ad71c88ba048ac6479c66a4d29d83b423","unresolved":false,"context_lines":[{"line_number":177,"context_line":"------------"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Dispense with role hierarchies by simply assigning a user to the superior roles"},{"line_number":180,"context_line":"and all the subordinate roles. Then he inherits all the privileges assigned to"},{"line_number":181,"context_line":"all the roles. The advantage of role hierarchies is that the user does not need"},{"line_number":182,"context_line":"to carry all the subordinate roles around with himself as the system knows the"},{"line_number":183,"context_line":"role hierarchy."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_62175452","line":180,"updated":"2014-12-16 21:26:13.000000000","message":"-- you definitely don\u0027t have to have to assign users *more* roles to get the same job done. that\u0027s not easier for anyone.","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"e62c682010eac7a3cc6affb7b493fc375ce69a9c","unresolved":false,"context_lines":[{"line_number":185,"context_line":"The expansion of the role hierarchy could be performed when issuing the token."},{"line_number":186,"context_line":"This will make tokens much larger, and will not support cleanup of the policy"},{"line_number":187,"context_line":"rules, minimizing the effectiveness of hierarchical roles."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a890539_5eb9cf13","line":188,"updated":"2014-11-15 09:35:47.000000000","message":"The last sentence about policy rules is irrelevant in this context. If you want to clean up policy then this is a separate task to role hierarchies.\n\nReplace with\n\nThe expansion of the role hierarchy could be performed when issuing the token. This will make tokens much larger, but the policy engine does not need to change.","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"e62c682010eac7a3cc6affb7b493fc375ce69a9c","unresolved":false,"context_lines":[{"line_number":198,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"},{"line_number":199,"context_line":"* Yes:  The token creation process will now be adding more roles on to a token,"},{"line_number":200,"context_line":"  especially for roles high in the hierarchy."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":204,"context_line":"  a new way to access sensitive information or a new way to login?"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a890539_9e3ed78a","line":201,"updated":"2014-11-15 09:35:47.000000000","message":"Not true if the policy engine is changed. The token will only contain the most superior role. So in fact, the impact is that tokens CAN BE SMALLER.","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"e62c682010eac7a3cc6affb7b493fc375ce69a9c","unresolved":false,"context_lines":[{"line_number":203,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":204,"context_line":"  a new way to access sensitive information or a new way to login?"},{"line_number":205,"context_line":"* Yes.  Role assignments now may have associated implicit assignments."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"* Does this change involve cryptography or hashing?"},{"line_number":209,"context_line":"* No."}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a890539_3e5323e3","line":206,"updated":"2014-11-15 09:35:47.000000000","message":"This depends upon whether support for role hierarchies is built into the policy engine or not. Note that if support is built into the policy engine, then the policies of all OpenStack services will need to know the role hierarchy.","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"e62c682010eac7a3cc6affb7b493fc375ce69a9c","unresolved":false,"context_lines":[{"line_number":282,"context_line":"*  Add parent field to entities"},{"line_number":283,"context_line":"*  Expand the create and edit APIs"},{"line_number":284,"context_line":"*  Account for hierarchy on listing role assignments"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"Dependencies"},{"line_number":287,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":288,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a890539_fe735b7d","line":285,"updated":"2014-11-15 09:35:47.000000000","message":"* add code to change policy files and push out changes when role hierarchy is modified","commit_id":"ef48e624cb6ac4ad4e72ae46cbc2dd54d28ee4fc"}],"specs/kilo/implied-roles.rst":[{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"be78752f8be34984be3e1f611ed4c6df11ba3cb3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Implied Roles - Assign one Role, get many"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp hierarchical-roles \u003chttps://blueprints.launchpad.net/keystone/+spec/ hierarchical-roles\u003e`_"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_9dd604f0","line":9,"updated":"2014-10-03 19:11:16.000000000","message":"Sounds like role hierarchies to me, so why not call it Hierarchical Roles?","commit_id":"788e99a5acbf2b7dda824c09c8be802cdced9add"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"be78752f8be34984be3e1f611ed4c6df11ba3cb3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp hierarchical-roles \u003chttps://blueprints.launchpad.net/keystone/+spec/ hierarchical-roles\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Allow role definitions to impy other role defintions, so that one "},{"line_number":15,"context_line":"role assignment willgive a user multiple roles."}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_3da518a2","line":12,"updated":"2014-10-03 19:11:16.000000000","message":"I cannot access this blueprint. Do you know why not?","commit_id":"788e99a5acbf2b7dda824c09c8be802cdced9add"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"be78752f8be34984be3e1f611ed4c6df11ba3cb3","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Allow role definitions to impy other role defintions, so that one "},{"line_number":15,"context_line":"role assignment willgive a user multiple roles."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_1d9db459","line":16,"updated":"2014-10-03 19:11:16.000000000","message":"This is role hierarchies. But you would describe it as \"inherits\" multiple roles rather than \"gives\" multiple roles","commit_id":"788e99a5acbf2b7dda824c09c8be802cdced9add"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"be78752f8be34984be3e1f611ed4c6df11ba3cb3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Add an additional implied_role table for the SQL backend with the other backends"},{"line_number":32,"context_line":"to follow if requested.  It will have two columns:"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"explicit_role_id,  implied_role_id"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"When issuing a token, all roles that can be inferred from the explicit roles"},{"line_number":37,"context_line":"will be added to the token."}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_7dab2075","line":34,"updated":"2014-10-03 19:11:16.000000000","message":"With role hierarchies this would then become\n\nSuperior-role,                        Subordinate-roles","commit_id":"788e99a5acbf2b7dda824c09c8be802cdced9add"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"be78752f8be34984be3e1f611ed4c6df11ba3cb3","unresolved":false,"context_lines":[{"line_number":34,"context_line":"explicit_role_id,  implied_role_id"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"When issuing a token, all roles that can be inferred from the explicit roles"},{"line_number":37,"context_line":"will be added to the token."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"An example hierarchy would split the admin for each service from a global admin"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_ddbdecb8","line":37,"updated":"2014-10-03 19:11:16.000000000","message":".....all roles that can be inherited.....","commit_id":"788e99a5acbf2b7dda824c09c8be802cdced9add"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"be78752f8be34984be3e1f611ed4c6df11ba3cb3","unresolved":false,"context_lines":[{"line_number":51,"context_line":"However, both the `neutron_admin` and the `glance_admin` roles  should imply "},{"line_number":52,"context_line":"that the user has the `member` role as well."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Here is an example implementation"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"+-----------------+------------------+"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_1debf4b0","line":54,"updated":"2014-10-03 19:11:16.000000000","message":"However, I dont think this is exactly the hierarchy you are imagining as neutron is not superior to glance, but glance is superior to member. So I think the hierarchy should be more like this\n\nAll-admin\n|                  \\\nneutron            glance\n|                  /\n member","commit_id":"788e99a5acbf2b7dda824c09c8be802cdced9add"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"be78752f8be34984be3e1f611ed4c6df11ba3cb3","unresolved":false,"context_lines":[{"line_number":105,"context_line":"------------"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"There could be special roles that are aggregates."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"The expansion of the role hierarchy could be performed by the client."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Both solutions are more complex."}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_bd14a8a0","line":108,"updated":"2014-10-03 19:11:16.000000000","message":"You can actually dispense with role hierarchies by simply assigning a user to the superior roles and all the subordinate roles. Then he inherits all the privileges assigned to all the roles.\n\nThe advantage of role hierarchies is that the user does not need to carry all the subordinate roles around with himself as the system knows the role hierarchy.","commit_id":"788e99a5acbf2b7dda824c09c8be802cdced9add"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"be78752f8be34984be3e1f611ed4c6df11ba3cb3","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"},{"line_number":121,"context_line":"Yes:  The token creation process will now be adding more roles on to a token,"},{"line_number":122,"context_line":"especially for roles high in the hierarchy."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"* Does this change alter the API in a way that may impact security, such as"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_fd33905f","line":122,"updated":"2014-10-03 19:11:16.000000000","message":"There should be no need to add subordinate roles to the token. Instead the policy engine should have access to the role hierarchy table, so that when a superior role is stated the policy engine knows that the subordinate roles are inherited as well.\n\nIf you add all the subordinate roles to the token you are effectively dispensing with role hierarchies because you are saying that the user has all these roles assigned to himself. With role hierarchies you simply say the user has the superior role, and all the subordinate roles are automatically inherited as the system knows what these are","commit_id":"788e99a5acbf2b7dda824c09c8be802cdced9add"}]}
