)]}'
{"specs/kilo/tests-on-rdbmses.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"60b41b17eb792a32b54abc953c356bf71ace417e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"run the tests on other database::"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"* by default SQLite doesn\u0027t enforce foreign keys"},{"line_number":24,"context_line":"* most implements will use another database like MySQL or PostgreSQL"},{"line_number":25,"context_line":"* every few months somebody asks how to make it work"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa201ad_2ba9d27b","line":24,"updated":"2014-10-09 17:28:11.000000000","message":"s/implements/deployers?","commit_id":"aa3c4d142cfb231c1d9ad2ef65639b966b5da34e"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"ef1e76fe1b26174f0c767c9e8af76e0c1c47cc73","unresolved":false,"context_lines":[{"line_number":21,"context_line":"run the tests on other database::"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"* by default SQLite doesn\u0027t enforce foreign keys"},{"line_number":24,"context_line":"* most implements will use another database like MySQL or PostgreSQL"},{"line_number":25,"context_line":"* every few months somebody asks how to make it work"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa201ad_292fd33f","line":24,"in_reply_to":"baa201ad_2ba9d27b","updated":"2014-10-13 17:03:54.000000000","message":"Done","commit_id":"aa3c4d142cfb231c1d9ad2ef65639b966b5da34e"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"2ab1513129d4e58de01b6d6f44ba3aa24b4df781","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed Change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"1. Fix the tests to respect foreign keys. We currently have tests that can\u0027t"},{"line_number":32,"context_line":"   work in a database where foreign keys are enforced."},{"line_number":33,"context_line":"2. Fix any other bugs that pop up when running on another database. This maybe"},{"line_number":34,"context_line":"   very big or very small. It\u0027s hard to tell without actually starting."}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa201ad_29ef6cea","line":31,"updated":"2014-10-07 09:33:20.000000000","message":"is it related change? We can easily turn on foreign keys on SQLite","commit_id":"aa3c4d142cfb231c1d9ad2ef65639b966b5da34e"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"6e9784454474cac32049dd5e16fc253391593c77","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed Change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"1. Fix the tests to respect foreign keys. We currently have tests that can\u0027t"},{"line_number":32,"context_line":"   work in a database where foreign keys are enforced."},{"line_number":33,"context_line":"2. Fix any other bugs that pop up when running on another database. This maybe"},{"line_number":34,"context_line":"   very big or very small. It\u0027s hard to tell without actually starting."}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa201ad_b1b2b3e2","line":31,"in_reply_to":"baa201ad_29ef6cea","updated":"2014-10-08 16:44:44.000000000","message":"This is very related. In order for the tests to work on MySQL they have to respect foreign keys. For example, if https://review.openstack.org/#/c/126029/ i fixed the tests to respect the foreign key. The test was passing incorrectly. It was deleting a record that couldn\u0027t be deleted because of a foreign key constraint.","commit_id":"aa3c4d142cfb231c1d9ad2ef65639b966b5da34e"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"60b41b17eb792a32b54abc953c356bf71ace417e","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"1. Fix the tests to respect foreign keys. We currently have tests that can\u0027t"},{"line_number":32,"context_line":"   work in a database where foreign keys are enforced."},{"line_number":33,"context_line":"2. Fix any other bugs that pop up when running on another database. This maybe"},{"line_number":34,"context_line":"   very big or very small. It\u0027s hard to tell without actually starting."},{"line_number":35,"context_line":"3. Make SQLite enforce foreign keys to prevent bugs from slipping by"},{"line_number":36,"context_line":"   developers that don\u0027t run tests against a non-SQLite database."}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa201ad_eb9eea53","line":33,"updated":"2014-10-09 17:28:11.000000000","message":"may be*","commit_id":"aa3c4d142cfb231c1d9ad2ef65639b966b5da34e"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"ef1e76fe1b26174f0c767c9e8af76e0c1c47cc73","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"1. Fix the tests to respect foreign keys. We currently have tests that can\u0027t"},{"line_number":32,"context_line":"   work in a database where foreign keys are enforced."},{"line_number":33,"context_line":"2. Fix any other bugs that pop up when running on another database. This maybe"},{"line_number":34,"context_line":"   very big or very small. It\u0027s hard to tell without actually starting."},{"line_number":35,"context_line":"3. Make SQLite enforce foreign keys to prevent bugs from slipping by"},{"line_number":36,"context_line":"   developers that don\u0027t run tests against a non-SQLite database."}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa201ad_c902c7b3","line":33,"in_reply_to":"baa201ad_eb9eea53","updated":"2014-10-13 17:03:54.000000000","message":"Done","commit_id":"aa3c4d142cfb231c1d9ad2ef65639b966b5da34e"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"cc8cd1e8c0b31fb9ab1e01e3ad8eefb741712e15","unresolved":false,"context_lines":[{"line_number":32,"context_line":"   work in a database where foreign keys are enforced."},{"line_number":33,"context_line":"2. Fix any other bugs that pop up when running on another database. This maybe"},{"line_number":34,"context_line":"   very big or very small. It\u0027s hard to tell without actually starting."},{"line_number":35,"context_line":"3. Make SQLite enforce foreign keys to prevent bugs from slipping by"},{"line_number":36,"context_line":"   developers that don\u0027t run tests against a non-SQLite database."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa201ad_b27d911e","line":35,"updated":"2014-10-06 18:59:16.000000000","message":"is such support available? Or are you proposing we write it?","commit_id":"aa3c4d142cfb231c1d9ad2ef65639b966b5da34e"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"6e9784454474cac32049dd5e16fc253391593c77","unresolved":false,"context_lines":[{"line_number":32,"context_line":"   work in a database where foreign keys are enforced."},{"line_number":33,"context_line":"2. Fix any other bugs that pop up when running on another database. This maybe"},{"line_number":34,"context_line":"   very big or very small. It\u0027s hard to tell without actually starting."},{"line_number":35,"context_line":"3. Make SQLite enforce foreign keys to prevent bugs from slipping by"},{"line_number":36,"context_line":"   developers that don\u0027t run tests against a non-SQLite database."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa201ad_f1cb5b6f","line":35,"in_reply_to":"baa201ad_b27d911e","updated":"2014-10-08 16:44:44.000000000","message":"This already exists. I have too look back to see what version it was added so that the docs can be updated, but here is the relevant review: https://review.openstack.org/#/c/126030/","commit_id":"aa3c4d142cfb231c1d9ad2ef65639b966b5da34e"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"60b41b17eb792a32b54abc953c356bf71ace417e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"2. Fix any other bugs that pop up when running on another database. This maybe"},{"line_number":34,"context_line":"   very big or very small. It\u0027s hard to tell without actually starting."},{"line_number":35,"context_line":"3. Make SQLite enforce foreign keys to prevent bugs from slipping by"},{"line_number":36,"context_line":"   developers that don\u0027t run tests against a non-SQLite database."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Alternatives"},{"line_number":39,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa201ad_2bc0f229","line":36,"updated":"2014-10-09 17:28:11.000000000","message":"this would be handy","commit_id":"aa3c4d142cfb231c1d9ad2ef65639b966b5da34e"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"2ab1513129d4e58de01b6d6f44ba3aa24b4df781","unresolved":false,"context_lines":[{"line_number":39,"context_line":"------------"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"There are really no alternatives as this primarily just fixes the broken tests."},{"line_number":42,"context_line":"At the patch level there may be alternative implementations possible, but that"},{"line_number":43,"context_line":"is out of the scope of this proposal."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Security Impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa201ad_a9a99c91","line":42,"updated":"2014-10-07 09:33:20.000000000","message":"see alternative attempt - https://review.openstack.org/#/c/33236/","commit_id":"aa3c4d142cfb231c1d9ad2ef65639b966b5da34e"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"6e9784454474cac32049dd5e16fc253391593c77","unresolved":false,"context_lines":[{"line_number":39,"context_line":"------------"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"There are really no alternatives as this primarily just fixes the broken tests."},{"line_number":42,"context_line":"At the patch level there may be alternative implementations possible, but that"},{"line_number":43,"context_line":"is out of the scope of this proposal."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Security Impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa201ad_f1927b55","line":42,"in_reply_to":"baa201ad_a9a99c91","updated":"2014-10-08 16:44:44.000000000","message":"I don\u0027t see that as an alternative. Primarily this spec is doing is fixing the issue we have now in our tests that prevent them from running on a database where foreign keys are enforced.","commit_id":"aa3c4d142cfb231c1d9ad2ef65639b966b5da34e"}]}