)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6d0912692fe2a77059029758734139e02a59e1ea","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-10-22 17:12:42 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This blueprint details the work required for"},{"line_number":8,"context_line":"Multi-factor Authentication"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Iaa278888dd7c535419a64ca59c78ba990dc74e36"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aa7fdbe_5e01f436","line":8,"updated":"2014-10-23 15:12:57.000000000","message":"Suggest changing the title to something like: \n\n    Multi-factor Authentication\n\n    Nice description here...","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"}],"specs/kilo/multi-factor-auth.rst":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"88153f9bbdf915d101aab84a5deca3d7d952b954","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Multi-factor Authentication"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp multi-factor-auth \u003chttps://blueprints.launchpad.net/keystone/+spec/multi-factor-auth\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Multi-factor Authentication provides a way to authenticate a user"},{"line_number":14,"context_line":"using two independent authentication factors, including a new Time-based"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_12f2fd05","line":11,"updated":"2014-10-23 16:07:52.000000000","message":"Note that this has also been created prior to this spec:\n\nhttps://blueprints.launchpad.net/keystone/+spec/totp\n\nAny info in that spec should probably be rolled into this one.","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"eac0d7570a67c56b5770003562bf63a503897698","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Multi-factor Authentication"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp multi-factor-auth \u003chttps://blueprints.launchpad.net/keystone/+spec/multi-factor-auth\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Multi-factor Authentication provides a way to authenticate a user"},{"line_number":14,"context_line":"using two independent authentication factors, including a new Time-based"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_5a72d7ad","line":11,"in_reply_to":"9aa7fdbe_12f2fd05","updated":"2014-10-23 19:40:48.000000000","message":"Done","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6d0912692fe2a77059029758734139e02a59e1ea","unresolved":false,"context_lines":[{"line_number":11,"context_line":"`bp multi-factor-auth \u003chttps://blueprints.launchpad.net/keystone/+spec/multi-factor-auth\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Multi-factor Authentication provides a way to authenticate a user"},{"line_number":14,"context_line":"using two independent authentication factors, including a new Time-based"},{"line_number":15,"context_line":"one-time password algorithm (TOTP or HOTP)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The algorithm proposed is already being used by Google"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_fe42a866","line":14,"updated":"2014-10-23 15:12:57.000000000","message":"time*","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"eac0d7570a67c56b5770003562bf63a503897698","unresolved":false,"context_lines":[{"line_number":11,"context_line":"`bp multi-factor-auth \u003chttps://blueprints.launchpad.net/keystone/+spec/multi-factor-auth\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Multi-factor Authentication provides a way to authenticate a user"},{"line_number":14,"context_line":"using two independent authentication factors, including a new Time-based"},{"line_number":15,"context_line":"one-time password algorithm (TOTP or HOTP)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The algorithm proposed is already being used by Google"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_7a6a3bb4","line":14,"in_reply_to":"9aa7fdbe_fe42a866","updated":"2014-10-23 19:40:48.000000000","message":"Done","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6d0912692fe2a77059029758734139e02a59e1ea","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Multi-factor Authentication provides a way to authenticate a user"},{"line_number":14,"context_line":"using two independent authentication factors, including a new Time-based"},{"line_number":15,"context_line":"one-time password algorithm (TOTP or HOTP)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The algorithm proposed is already being used by Google"},{"line_number":18,"context_line":"for their multi-factor authentication."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_de516437","line":15,"updated":"2014-10-23 15:12:57.000000000","message":"TOTP is time-based and HOTP is HMAC based right? The previous sentence makes it seem like both are time-based.","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"eac0d7570a67c56b5770003562bf63a503897698","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Multi-factor Authentication provides a way to authenticate a user"},{"line_number":14,"context_line":"using two independent authentication factors, including a new Time-based"},{"line_number":15,"context_line":"one-time password algorithm (TOTP or HOTP)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The algorithm proposed is already being used by Google"},{"line_number":18,"context_line":"for their multi-factor authentication."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_da5de716","line":15,"in_reply_to":"9aa7fdbe_de516437","updated":"2014-10-23 19:40:48.000000000","message":"Done","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6d0912692fe2a77059029758734139e02a59e1ea","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Problem Description"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The goal of MFA is to make it more difficult for an unauthorized user"},{"line_number":24,"context_line":"to gain access to an OpenStack resource. If a users password is compromised"},{"line_number":25,"context_line":"there is still another barrier before granting access."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_9e2a7c8e","line":23,"updated":"2014-10-23 15:12:57.000000000","message":"s/MFA/Multi-factor Authentication (MFA)/","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"eac0d7570a67c56b5770003562bf63a503897698","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Problem Description"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The goal of MFA is to make it more difficult for an unauthorized user"},{"line_number":24,"context_line":"to gain access to an OpenStack resource. If a users password is compromised"},{"line_number":25,"context_line":"there is still another barrier before granting access."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_fa9d4bbd","line":23,"in_reply_to":"9aa7fdbe_9e2a7c8e","updated":"2014-10-23 19:40:48.000000000","message":"Done","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6d0912692fe2a77059029758734139e02a59e1ea","unresolved":false,"context_lines":[{"line_number":31,"context_line":"authentication method."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Implemented Time-based one-time password authentication using HOTP or TOTP"},{"line_number":34,"context_line":"that is compatible with Google Authenticator."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Update the data models to store HOTP secret for a user, and whether to"},{"line_number":37,"context_line":"enforce MFA for a Domain, Project and User."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_215b352f","line":34,"updated":"2014-10-23 15:12:57.000000000","message":"Is there a link available for documentation here?","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"eac0d7570a67c56b5770003562bf63a503897698","unresolved":false,"context_lines":[{"line_number":31,"context_line":"authentication method."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Implemented Time-based one-time password authentication using HOTP or TOTP"},{"line_number":34,"context_line":"that is compatible with Google Authenticator."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Update the data models to store HOTP secret for a user, and whether to"},{"line_number":37,"context_line":"enforce MFA for a Domain, Project and User."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_d78ea2cf","line":34,"in_reply_to":"9aa7fdbe_215b352f","updated":"2014-10-23 19:40:48.000000000","message":"Link provided at the bottom.","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6d0912692fe2a77059029758734139e02a59e1ea","unresolved":false,"context_lines":[{"line_number":34,"context_line":"that is compatible with Google Authenticator."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Update the data models to store HOTP secret for a user, and whether to"},{"line_number":37,"context_line":"enforce MFA for a Domain, Project and User."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Create a new middleware filter to enforce multi-factor authentication."},{"line_number":40,"context_line":"This filter will require a user to specify both their username and password"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_e1892d76","line":37,"updated":"2014-10-23 15:12:57.000000000","message":"this will be done by an attribute on the user, right?","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"eac0d7570a67c56b5770003562bf63a503897698","unresolved":false,"context_lines":[{"line_number":34,"context_line":"that is compatible with Google Authenticator."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Update the data models to store HOTP secret for a user, and whether to"},{"line_number":37,"context_line":"enforce MFA for a Domain, Project and User."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Create a new middleware filter to enforce multi-factor authentication."},{"line_number":40,"context_line":"This filter will require a user to specify both their username and password"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_37b52e7e","line":37,"in_reply_to":"9aa7fdbe_e1892d76","updated":"2014-10-23 19:40:48.000000000","message":"I think it should be done at a Project level and control scope using tenant hierarchy","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6d0912692fe2a77059029758734139e02a59e1ea","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Create multi-factor qr code from secret.  This could be done when initially"},{"line_number":45,"context_line":"setting up multi-factor for a user."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_41c6799b","line":46,"updated":"2014-10-23 15:12:57.000000000","message":"So what happens in the following case? \n\n    1.) User authenticates against Keystone for a token\n    2.) Does fun stuff with said token\n    3.) MFA is enabled on user \n        a.) Revoke all existing tokens and force them to generate a new token with MFA?\n\nI think those details (or use case) would be helpful here.","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"eac0d7570a67c56b5770003562bf63a503897698","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Create multi-factor qr code from secret.  This could be done when initially"},{"line_number":45,"context_line":"setting up multi-factor for a user."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_faeb8b10","line":46,"in_reply_to":"9aa7fdbe_41c6799b","updated":"2014-10-23 19:40:48.000000000","message":"I think for the initial implementation the tokens could still be valid.  Services that want to limit access could look at tokens methods for \u0027password\u0027 and \u0027one-time-password\u0027","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6d0912692fe2a77059029758734139e02a59e1ea","unresolved":false,"context_lines":[{"line_number":49,"context_line":"------------"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Keeps things as they are."},{"line_number":52,"context_line":"Use an external provider for multi-factor."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Security Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_01f2b105","line":52,"updated":"2014-10-23 15:12:57.000000000","message":"By using an external provider, some middleware will still have to be added to Keystone I think","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"eac0d7570a67c56b5770003562bf63a503897698","unresolved":false,"context_lines":[{"line_number":49,"context_line":"------------"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Keeps things as they are."},{"line_number":52,"context_line":"Use an external provider for multi-factor."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Security Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_5af737f5","line":52,"in_reply_to":"9aa7fdbe_01f2b105","updated":"2014-10-23 19:40:48.000000000","message":"Done","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6d0912692fe2a77059029758734139e02a59e1ea","unresolved":false,"context_lines":[{"line_number":65,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":66,"context_line":"  a new way to access sensitive information or a new way to login?"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  It shouldn\u0027t."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"* Does this change involve cryptography or hashing?"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_2113350e","line":68,"updated":"2014-10-23 15:12:57.000000000","message":"This is a different way to log in. Different in the fact that it adds another step to the process for the user if MFA is enabled.","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"eac0d7570a67c56b5770003562bf63a503897698","unresolved":false,"context_lines":[{"line_number":65,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":66,"context_line":"  a new way to access sensitive information or a new way to login?"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  It shouldn\u0027t."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"* Does this change involve cryptography or hashing?"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_7adf9b69","line":68,"in_reply_to":"9aa7fdbe_2113350e","updated":"2014-10-23 19:40:48.000000000","message":"Done","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6d0912692fe2a77059029758734139e02a59e1ea","unresolved":false,"context_lines":[{"line_number":100,"context_line":"Performance Impact"},{"line_number":101,"context_line":"------------------"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"None"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Other Deployer Impact"},{"line_number":106,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_21b895e4","line":103,"updated":"2014-10-23 15:12:57.000000000","message":"so what happens when a user attempts to authenticate with MFA, and Keystone just sits around waiting for the MFA response from the user? Is there going to be a timeout built in for that?","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"eac0d7570a67c56b5770003562bf63a503897698","unresolved":false,"context_lines":[{"line_number":100,"context_line":"Performance Impact"},{"line_number":101,"context_line":"------------------"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"None"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Other Deployer Impact"},{"line_number":106,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_3a40b306","line":103,"in_reply_to":"9aa7fdbe_21b895e4","updated":"2014-10-23 19:40:48.000000000","message":"I was thinking that there is a new type of authentication that requires specifying a one-time password.  The user would send this along with their username and password.  This way keystone does not have to wait for the second factor.","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6d0912692fe2a77059029758734139e02a59e1ea","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  other backends would implement the feature is required."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"  This change shouldn\u0027t be specific to a driver, from a persistent storage"},{"line_number":130,"context_line":"  perspective."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_8174e136","line":130,"updated":"2014-10-23 15:12:57.000000000","message":"Most of the logic will reside in middleware correct?","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"eac0d7570a67c56b5770003562bf63a503897698","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  other backends would implement the feature is required."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"  This change shouldn\u0027t be specific to a driver, from a persistent storage"},{"line_number":130,"context_line":"  perspective."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_5a457715","line":130,"in_reply_to":"9aa7fdbe_8174e136","updated":"2014-10-23 19:40:48.000000000","message":"Done","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6d0912692fe2a77059029758734139e02a59e1ea","unresolved":false,"context_lines":[{"line_number":164,"context_line":"* `Google Authenticator"},{"line_number":165,"context_line":"  \u003chttps://code.google.com/p/google-authenticator\u003e`_"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"* `TOTP"},{"line_number":168,"context_line":"  \u003chttps://tools.ietf.org/html/rfc6238\u003e`_"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_21b415d0","line":167,"updated":"2014-10-23 15:12:57.000000000","message":"This could be added here too\n\nhttp://www.ietf.org/rfc/rfc4226.txt","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"eac0d7570a67c56b5770003562bf63a503897698","unresolved":false,"context_lines":[{"line_number":164,"context_line":"* `Google Authenticator"},{"line_number":165,"context_line":"  \u003chttps://code.google.com/p/google-authenticator\u003e`_"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"* `TOTP"},{"line_number":168,"context_line":"  \u003chttps://tools.ietf.org/html/rfc6238\u003e`_"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_ba53c3e0","line":167,"in_reply_to":"9aa7fdbe_21b415d0","updated":"2014-10-23 19:40:48.000000000","message":"Done","commit_id":"5c22fb6ba35967c344134c17deceda0bda9c2867"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ed9b88b694ef689a303dc793ffb2df3734989309","unresolved":false,"context_lines":[{"line_number":37,"context_line":"with other implementations."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Update the user data model to store OTP secret and type for a user and"},{"line_number":40,"context_line":"update Project data model to specify if MFA should be enforced."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Create a new middleware filter to enforce multi-factor authentication."},{"line_number":43,"context_line":"This filter will require a user to specify both their username and password"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_8544a94a","line":40,"updated":"2014-10-27 14:33:39.000000000","message":"so MFA will be determined per project? A user authenticating against a project without MFA doesn\u0027t need to provide a second key. The same user has access to another project that does have MFA enabled, so when asking for a token for that project the user will need to provide a second method of authentication, correct? If a project has MFA enabled then *everyone* for that project needs to provide multi-factor? Are there use cases where only certain people in a project would need multi-factor?","commit_id":"cdc4169f8695a5d1b4687d99f75573430705495f"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"d2301711897bb9564ddc1e8612a5ca89364818a3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"with other implementations."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Update the user data model to store OTP secret and type for a user and"},{"line_number":40,"context_line":"update Project data model to specify if MFA should be enforced."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Create a new middleware filter to enforce multi-factor authentication."},{"line_number":43,"context_line":"This filter will require a user to specify both their username and password"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_86b8252b","line":40,"in_reply_to":"9aa7fdbe_8544a94a","updated":"2014-10-27 21:53:54.000000000","message":"I updated the spec to take into account more use cases.\nMFA can be set as required at project, domain and user.","commit_id":"cdc4169f8695a5d1b4687d99f75573430705495f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ed9b88b694ef689a303dc793ffb2df3734989309","unresolved":false,"context_lines":[{"line_number":47,"context_line":"Create multi-factor qr code from secret.  This could be done when initially"},{"line_number":48,"context_line":"setting up multi-factor for a user."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"For the initial implementation when a user gets MFA enabled, The users"},{"line_number":51,"context_line":"previous tokens would still be valid.  Services that only want to allow"},{"line_number":52,"context_line":"MFA tokens can use the methods list to verify OTP was used."},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_a5660deb","line":50,"updated":"2014-10-27 14:33:39.000000000","message":"s/The/the/","commit_id":"cdc4169f8695a5d1b4687d99f75573430705495f"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"d2301711897bb9564ddc1e8612a5ca89364818a3","unresolved":false,"context_lines":[{"line_number":47,"context_line":"Create multi-factor qr code from secret.  This could be done when initially"},{"line_number":48,"context_line":"setting up multi-factor for a user."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"For the initial implementation when a user gets MFA enabled, The users"},{"line_number":51,"context_line":"previous tokens would still be valid.  Services that only want to allow"},{"line_number":52,"context_line":"MFA tokens can use the methods list to verify OTP was used."},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_c685cd5a","line":50,"in_reply_to":"9aa7fdbe_a5660deb","updated":"2014-10-27 21:53:54.000000000","message":"Done","commit_id":"cdc4169f8695a5d1b4687d99f75573430705495f"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"cebc6fcc8ad066d3242e03e6c201f778154a1bd4","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Alternatives"},{"line_number":56,"context_line":"------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Keeps things as they are."},{"line_number":59,"context_line":"Use an external provider for multi-factor. (This would require additional"},{"line_number":60,"context_line":"changes in Keystone)."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_c3a144f9","line":57,"updated":"2014-10-27 17:42:27.000000000","message":"How is MFA enabled?\n\nPer user  or Per Domain or Per operation or always on","commit_id":"cdc4169f8695a5d1b4687d99f75573430705495f"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"d2301711897bb9564ddc1e8612a5ca89364818a3","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Alternatives"},{"line_number":56,"context_line":"------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Keeps things as they are."},{"line_number":59,"context_line":"Use an external provider for multi-factor. (This would require additional"},{"line_number":60,"context_line":"changes in Keystone)."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_e6881173","line":57,"in_reply_to":"9aa7fdbe_c3a144f9","updated":"2014-10-27 21:53:54.000000000","message":"Per domain, project and user.","commit_id":"cdc4169f8695a5d1b4687d99f75573430705495f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ed9b88b694ef689a303dc793ffb2df3734989309","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  Yes, users secret will need to be stored."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":74,"context_line":"  a new way to access sensitive information or a new way to login?"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_65a8a5db","line":71,"updated":"2014-10-27 14:33:39.000000000","message":"by secrets, we mean the one-time password, correct?","commit_id":"cdc4169f8695a5d1b4687d99f75573430705495f"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"d2301711897bb9564ddc1e8612a5ca89364818a3","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  Yes, users secret will need to be stored."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":74,"context_line":"  a new way to access sensitive information or a new way to login?"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_267f7967","line":71,"in_reply_to":"9aa7fdbe_65a8a5db","updated":"2014-10-27 21:53:54.000000000","message":"Yes, one time password.","commit_id":"cdc4169f8695a5d1b4687d99f75573430705495f"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"cebc6fcc8ad066d3242e03e6c201f778154a1bd4","unresolved":false,"context_lines":[{"line_number":69,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  Yes, users secret will need to be stored."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":74,"context_line":"  a new way to access sensitive information or a new way to login?"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_c3530415","line":72,"updated":"2014-10-27 17:42:27.000000000","message":"How are you going to store the secrets?  Encrypted?  More details, as keystone so far doesn\u0027t store anything encrypted.","commit_id":"cdc4169f8695a5d1b4687d99f75573430705495f"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"d2301711897bb9564ddc1e8612a5ca89364818a3","unresolved":false,"context_lines":[{"line_number":69,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  Yes, users secret will need to be stored."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":74,"context_line":"  a new way to access sensitive information or a new way to login?"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9aa7fdbe_c6d6ad27","line":72,"in_reply_to":"9aa7fdbe_c3530415","updated":"2014-10-27 21:53:54.000000000","message":"I don\u0027t think one-time password seed needs to be encrypted.  Maybe store in Barbican as a followup story.","commit_id":"cdc4169f8695a5d1b4687d99f75573430705495f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"e2bb774c547c0a5b116d87e2165bccfcf7c234a3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"extensible to allow other implementations like HMAC based password (HOTP)."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The algorithm proposed is already being used by Google"},{"line_number":20,"context_line":"for their multi-factor authentication."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem Description"},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_9cecf2bc","line":20,"updated":"2014-10-28 00:17:32.000000000","message":"As long as we make this a \"pluggable\" system (so we could let someone, say, hook into RSA or \u003cinsert other vendor with differing requirements\u003e) I think this absolutely has merit. I know i\u0027ve heard this request on more than on occasion.","commit_id":"34c63679cc92dfb7e578485b6ac42f87d6f48b91"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"caf2bf387ccf0fb2b15cd8c96af7b45a2abf8904","unresolved":false,"context_lines":[{"line_number":17,"context_line":"extensible to allow other implementations like HMAC based password (HOTP)."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The algorithm proposed is already being used by Google"},{"line_number":20,"context_line":"for their multi-factor authentication."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem Description"},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_ce5b0852","line":20,"in_reply_to":"9aa7fdbe_9cecf2bc","updated":"2014-10-28 18:12:25.000000000","message":"Done","commit_id":"34c63679cc92dfb7e578485b6ac42f87d6f48b91"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"e2bb774c547c0a5b116d87e2165bccfcf7c234a3","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The goal of Multi-factor Authentication (MFA) is to make it more difficult for"},{"line_number":26,"context_line":"an unauthorized user to gain access to an OpenStack resource. If a users"},{"line_number":27,"context_line":"password is compromised there is still another barrier before granting access."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Proposed Change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_1c5d6279","line":27,"updated":"2014-10-28 00:17:32.000000000","message":"This is an \"ok\" level of description, but I suggest expanding to indication that we\u0027re advocating adding support for a \"possession factor\" (http://en.wikipedia.org/wiki/Multi-factor_authentication#Possession_factors) to what we already have (which is a \"knowledge factor\" http://en.wikipedia.org/wiki/Multi-factor_authentication#Knowledge_factors ).\n\nThis verbiage can be expanded on independent of the initial proposal.","commit_id":"34c63679cc92dfb7e578485b6ac42f87d6f48b91"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"caf2bf387ccf0fb2b15cd8c96af7b45a2abf8904","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The goal of Multi-factor Authentication (MFA) is to make it more difficult for"},{"line_number":26,"context_line":"an unauthorized user to gain access to an OpenStack resource. If a users"},{"line_number":27,"context_line":"password is compromised there is still another barrier before granting access."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Proposed Change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_6e113c5c","line":27,"in_reply_to":"9aa7fdbe_1c5d6279","updated":"2014-10-28 18:12:25.000000000","message":"Done","commit_id":"34c63679cc92dfb7e578485b6ac42f87d6f48b91"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"e2bb774c547c0a5b116d87e2165bccfcf7c234a3","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Implemented Time-based one-time password authentication driver using TOTP"},{"line_number":36,"context_line":"that is compatible with Google Authenticator.  And allow it to be exensible"},{"line_number":37,"context_line":"with other implementations."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Update the user data model to store OTP secret and type for a user and"},{"line_number":40,"context_line":"update project, domain and user data model to specify if MFA should be"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_bcca9618","line":37,"updated":"2014-10-28 00:17:32.000000000","message":"This needs to be a pluggable system, where you can have different drivers (you may even have different MFA requirements for different user sets). I\u0027m not sure how easy it would be to solve that use case (perhaps the answer will come from some of the planned hallway-track discussions at the Paris summit).","commit_id":"34c63679cc92dfb7e578485b6ac42f87d6f48b91"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"caf2bf387ccf0fb2b15cd8c96af7b45a2abf8904","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Implemented Time-based one-time password authentication driver using TOTP"},{"line_number":36,"context_line":"that is compatible with Google Authenticator.  And allow it to be exensible"},{"line_number":37,"context_line":"with other implementations."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Update the user data model to store OTP secret and type for a user and"},{"line_number":40,"context_line":"update project, domain and user data model to specify if MFA should be"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_ae0ec438","line":37,"in_reply_to":"9aa7fdbe_bcca9618","updated":"2014-10-28 18:12:25.000000000","message":"Done","commit_id":"34c63679cc92dfb7e578485b6ac42f87d6f48b91"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"e2bb774c547c0a5b116d87e2165bccfcf7c234a3","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Update the user data model to store OTP secret and type for a user and"},{"line_number":40,"context_line":"update project, domain and user data model to specify if MFA should be"},{"line_number":41,"context_line":"enforced."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"A user that requires MFA or tries to authenticate against a project or domain"},{"line_number":44,"context_line":"that requires MFA will have to specify a second OTP."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_bcf1b66c","line":41,"updated":"2014-10-28 00:17:32.000000000","message":"The system needs to be able to pull data from various backends. The OTP secret for example should not be stored *in* keystone. If it\u0027s OTP/TOTP [google implementation], likely this should end up being stored in Barbican in the long term.","commit_id":"34c63679cc92dfb7e578485b6ac42f87d6f48b91"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"caf2bf387ccf0fb2b15cd8c96af7b45a2abf8904","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Update the user data model to store OTP secret and type for a user and"},{"line_number":40,"context_line":"update project, domain and user data model to specify if MFA should be"},{"line_number":41,"context_line":"enforced."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"A user that requires MFA or tries to authenticate against a project or domain"},{"line_number":44,"context_line":"that requires MFA will have to specify a second OTP."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_3102350a","line":41,"in_reply_to":"9aa7fdbe_bcf1b66c","updated":"2014-10-28 18:12:25.000000000","message":"Done","commit_id":"34c63679cc92dfb7e578485b6ac42f87d6f48b91"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"e2bb774c547c0a5b116d87e2165bccfcf7c234a3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"Create a new middleware filter to enforce multi-factor authentication."},{"line_number":47,"context_line":"This filter will require a user to specify both their username and password"},{"line_number":48,"context_line":"along with a client generated OTP.  The filter will then verify the OTP is"},{"line_number":49,"context_line":"valid and forward the request or return unauthorized."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Create multi-factor qr code from secret.  This could be done when initially"},{"line_number":52,"context_line":"setting up multi-factor for a user."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_fc9ede05","line":49,"updated":"2014-10-28 00:17:32.000000000","message":"I\u0027m not sure if middleware is the right place for this. It is likely this is something that belongs in the authentication pipeline (a new \"password\" auth plugin that can be swapped in).","commit_id":"34c63679cc92dfb7e578485b6ac42f87d6f48b91"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"caf2bf387ccf0fb2b15cd8c96af7b45a2abf8904","unresolved":false,"context_lines":[{"line_number":46,"context_line":"Create a new middleware filter to enforce multi-factor authentication."},{"line_number":47,"context_line":"This filter will require a user to specify both their username and password"},{"line_number":48,"context_line":"along with a client generated OTP.  The filter will then verify the OTP is"},{"line_number":49,"context_line":"valid and forward the request or return unauthorized."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Create multi-factor qr code from secret.  This could be done when initially"},{"line_number":52,"context_line":"setting up multi-factor for a user."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_5105f90e","line":49,"in_reply_to":"9aa7fdbe_fc9ede05","updated":"2014-10-28 18:12:25.000000000","message":"Done","commit_id":"34c63679cc92dfb7e578485b6ac42f87d6f48b91"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"e2bb774c547c0a5b116d87e2165bccfcf7c234a3","unresolved":false,"context_lines":[{"line_number":49,"context_line":"valid and forward the request or return unauthorized."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Create multi-factor qr code from secret.  This could be done when initially"},{"line_number":52,"context_line":"setting up multi-factor for a user."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"For the initial implementation when a user gets MFA enabled, the users"},{"line_number":55,"context_line":"previous tokens would still be valid.  Services that only want to allow"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_bcbff65f","line":52,"updated":"2014-10-28 00:17:32.000000000","message":"We could provide an extension for this - however, this may not be something keystone \"needs\" to setup in all cases (see pluggability above). For the google authenticator plugin, providing the secret key would be the important part. I think the QR code is likely something that needs to be handled either by the client or the visualization (e.g. horizon). Rendering the QR code directly is somewhat out of scope for keystone unless keystone learns how to render basic HTML for interfacing with clients.","commit_id":"34c63679cc92dfb7e578485b6ac42f87d6f48b91"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"caf2bf387ccf0fb2b15cd8c96af7b45a2abf8904","unresolved":false,"context_lines":[{"line_number":49,"context_line":"valid and forward the request or return unauthorized."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Create multi-factor qr code from secret.  This could be done when initially"},{"line_number":52,"context_line":"setting up multi-factor for a user."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"For the initial implementation when a user gets MFA enabled, the users"},{"line_number":55,"context_line":"previous tokens would still be valid.  Services that only want to allow"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_f11b4d70","line":52,"in_reply_to":"9aa7fdbe_bcbff65f","updated":"2014-10-28 18:12:25.000000000","message":"Done","commit_id":"34c63679cc92dfb7e578485b6ac42f87d6f48b91"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"e2bb774c547c0a5b116d87e2165bccfcf7c234a3","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Keeps things as they are."},{"line_number":63,"context_line":"Use an external provider for multi-factor. (This would require additional"},{"line_number":64,"context_line":"changes in Keystone)."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Security Impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_5cae0a2f","line":64,"updated":"2014-10-28 00:17:32.000000000","message":"Suggest changing this to \"None\", as there are no other real options that have an impact to Keystone\u0027s codebase.\n\nWe can support non-built-in/in-tree implementations by making the system pluggable as outlined above.","commit_id":"34c63679cc92dfb7e578485b6ac42f87d6f48b91"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"bd92e29a34ffa285422a21d495cdce591a38cee5","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Keeps things as they are."},{"line_number":63,"context_line":"Use an external provider for multi-factor. (This would require additional"},{"line_number":64,"context_line":"changes in Keystone)."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Security Impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_d13e49b7","line":64,"in_reply_to":"9aa7fdbe_5cae0a2f","updated":"2014-10-28 18:13:09.000000000","message":"Done","commit_id":"34c63679cc92dfb7e578485b6ac42f87d6f48b91"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"e2bb774c547c0a5b116d87e2165bccfcf7c234a3","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  Yes, a users one time password seed will need to be stored."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":78,"context_line":"  a new way to access sensitive information or a new way to login?"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_7ca90e23","line":75,"updated":"2014-10-28 00:17:32.000000000","message":"This isn\u0027t a one-time-password, it is the secret key used to generate the OTP or TOTP.","commit_id":"34c63679cc92dfb7e578485b6ac42f87d6f48b91"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"caf2bf387ccf0fb2b15cd8c96af7b45a2abf8904","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  Yes, a users one time password seed will need to be stored."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":78,"context_line":"  a new way to access sensitive information or a new way to login?"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_512c1999","line":75,"in_reply_to":"9aa7fdbe_7ca90e23","updated":"2014-10-28 18:12:25.000000000","message":"Done","commit_id":"34c63679cc92dfb7e578485b6ac42f87d6f48b91"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"e2bb774c547c0a5b116d87e2165bccfcf7c234a3","unresolved":false,"context_lines":[{"line_number":77,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":78,"context_line":"  a new way to access sensitive information or a new way to login?"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  It adds an additional step to the login process when MFA is enabled."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"* Does this change involve cryptography or hashing?"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_fc6c1e0a","line":80,"updated":"2014-10-28 00:17:32.000000000","message":"Is this an extra step that is apparent to the end user or just a behind the scenes extra step?","commit_id":"34c63679cc92dfb7e578485b6ac42f87d6f48b91"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"caf2bf387ccf0fb2b15cd8c96af7b45a2abf8904","unresolved":false,"context_lines":[{"line_number":77,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":78,"context_line":"  a new way to access sensitive information or a new way to login?"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  It adds an additional step to the login process when MFA is enabled."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"* Does this change involve cryptography or hashing?"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_711f5d5b","line":80,"in_reply_to":"9aa7fdbe_fc6c1e0a","updated":"2014-10-28 18:12:25.000000000","message":"Done","commit_id":"34c63679cc92dfb7e578485b6ac42f87d6f48b91"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"e2bb774c547c0a5b116d87e2165bccfcf7c234a3","unresolved":false,"context_lines":[{"line_number":155,"context_line":"----------"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"* Add a new One-time password authentication driver"},{"line_number":158,"context_line":"* Add a new multi-factor middleware filter"},{"line_number":159,"context_line":"* Add resource to setup multi-factor for a user"},{"line_number":160,"context_line":"* Document the process for setting up multi-factor deployment"},{"line_number":161,"context_line":"* Document the process for setting up a users multi-factor account"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_7c574e26","line":158,"updated":"2014-10-28 00:17:32.000000000","message":"This likely shouldn\u0027t be middleware but should be an auth-plugin that replaces \"password\".","commit_id":"34c63679cc92dfb7e578485b6ac42f87d6f48b91"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"caf2bf387ccf0fb2b15cd8c96af7b45a2abf8904","unresolved":false,"context_lines":[{"line_number":155,"context_line":"----------"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"* Add a new One-time password authentication driver"},{"line_number":158,"context_line":"* Add a new multi-factor middleware filter"},{"line_number":159,"context_line":"* Add resource to setup multi-factor for a user"},{"line_number":160,"context_line":"* Document the process for setting up multi-factor deployment"},{"line_number":161,"context_line":"* Document the process for setting up a users multi-factor account"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa7fdbe_d13729e1","line":158,"in_reply_to":"9aa7fdbe_7c574e26","updated":"2014-10-28 18:12:25.000000000","message":"Done","commit_id":"34c63679cc92dfb7e578485b6ac42f87d6f48b91"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"90542a53ce3fc55eac6b2e92ff3afeaaaa90ba9b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Make one time password \"pluggable\" to allow other implementations like HMAC"},{"line_number":19,"context_line":"based password (HOTP), RSA or other vendor with different requirements."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The algorithm proposed is already being used by Google"},{"line_number":22,"context_line":"for their multi-factor authentication."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9aa7fdbe_7eeb9db0","line":21,"updated":"2014-10-29 04:55:21.000000000","message":"fill up this line to 79 characters, this also happens in a few other spots in this spec","commit_id":"00069398f0313d58a323eeb361cc8936bbb80bf5"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"9ad7bb7c585f3387b238ca1e672edac6d6036851","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Make one time password \"pluggable\" to allow other implementations like HMAC"},{"line_number":19,"context_line":"based password (HOTP), RSA or other vendor with different requirements."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The algorithm proposed is already being used by Google"},{"line_number":22,"context_line":"for their multi-factor authentication."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9aa7fdbe_90a4a009","line":21,"in_reply_to":"9aa7fdbe_7eeb9db0","updated":"2014-10-29 15:11:40.000000000","message":"Done","commit_id":"00069398f0313d58a323eeb361cc8936bbb80bf5"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"90542a53ce3fc55eac6b2e92ff3afeaaaa90ba9b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"The goal of Multi-factor Authentication (MFA) is to make it more difficult for"},{"line_number":28,"context_line":"an unauthorized user to gain access to an OpenStack resource. If a users"},{"line_number":29,"context_line":"password is compromised there is still another barrier before granting access."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Currently keystone only supports \"knowledge factor\" (something the user knows)."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9aa7fdbe_ded9e923","line":28,"updated":"2014-10-29 04:55:21.000000000","message":"If a user\u0027s*\n\n(or just drop \u0027user\u0027 and say password, as it\u0027s implied that it belongs to a user)","commit_id":"00069398f0313d58a323eeb361cc8936bbb80bf5"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"9ad7bb7c585f3387b238ca1e672edac6d6036851","unresolved":false,"context_lines":[{"line_number":25,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"The goal of Multi-factor Authentication (MFA) is to make it more difficult for"},{"line_number":28,"context_line":"an unauthorized user to gain access to an OpenStack resource. If a users"},{"line_number":29,"context_line":"password is compromised there is still another barrier before granting access."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Currently keystone only supports \"knowledge factor\" (something the user knows)."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9aa7fdbe_d0ad48ec","line":28,"in_reply_to":"9aa7fdbe_ded9e923","updated":"2014-10-29 15:11:40.000000000","message":"Done","commit_id":"00069398f0313d58a323eeb361cc8936bbb80bf5"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"90542a53ce3fc55eac6b2e92ff3afeaaaa90ba9b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"an unauthorized user to gain access to an OpenStack resource. If a users"},{"line_number":29,"context_line":"password is compromised there is still another barrier before granting access."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Currently keystone only supports \"knowledge factor\" (something the user knows)."},{"line_number":32,"context_line":"The goal of this change is to add a \"possession factor\" (something a user has)."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9aa7fdbe_fed6adf0","line":31,"updated":"2014-10-29 04:55:21.000000000","message":"Keystone*","commit_id":"00069398f0313d58a323eeb361cc8936bbb80bf5"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"9ad7bb7c585f3387b238ca1e672edac6d6036851","unresolved":false,"context_lines":[{"line_number":28,"context_line":"an unauthorized user to gain access to an OpenStack resource. If a users"},{"line_number":29,"context_line":"password is compromised there is still another barrier before granting access."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Currently keystone only supports \"knowledge factor\" (something the user knows)."},{"line_number":32,"context_line":"The goal of this change is to add a \"possession factor\" (something a user has)."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9aa7fdbe_f0aa4cd1","line":31,"in_reply_to":"9aa7fdbe_fed6adf0","updated":"2014-10-29 15:11:40.000000000","message":"Done","commit_id":"00069398f0313d58a323eeb361cc8936bbb80bf5"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"90542a53ce3fc55eac6b2e92ff3afeaaaa90ba9b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"that requires MFA will have to specify a second OTP."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Create a new \"password\" auth plugin to enforce multi-factor authentication."},{"line_number":52,"context_line":"The plugin can be swapped in by configuring the keystone paste file."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The auth plugin  will require a user to specify both their username and"},{"line_number":55,"context_line":"password along with a client generated OTP.  The plugin will then verify the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9aa7fdbe_1e037177","line":52,"updated":"2014-10-29 04:55:21.000000000","message":"Keystone*","commit_id":"00069398f0313d58a323eeb361cc8936bbb80bf5"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"9ad7bb7c585f3387b238ca1e672edac6d6036851","unresolved":false,"context_lines":[{"line_number":49,"context_line":"that requires MFA will have to specify a second OTP."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Create a new \"password\" auth plugin to enforce multi-factor authentication."},{"line_number":52,"context_line":"The plugin can be swapped in by configuring the keystone paste file."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The auth plugin  will require a user to specify both their username and"},{"line_number":55,"context_line":"password along with a client generated OTP.  The plugin will then verify the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9aa7fdbe_10b8b029","line":52,"in_reply_to":"9aa7fdbe_1e037177","updated":"2014-10-29 15:11:40.000000000","message":"Done","commit_id":"00069398f0313d58a323eeb361cc8936bbb80bf5"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"90542a53ce3fc55eac6b2e92ff3afeaaaa90ba9b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"Create a new \"password\" auth plugin to enforce multi-factor authentication."},{"line_number":52,"context_line":"The plugin can be swapped in by configuring the keystone paste file."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The auth plugin  will require a user to specify both their username and"},{"line_number":55,"context_line":"password along with a client generated OTP.  The plugin will then verify the"},{"line_number":56,"context_line":"OTP is valid along with the user credentials."},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9aa7fdbe_5efdf96d","line":54,"updated":"2014-10-29 04:55:21.000000000","message":"unnecessary double space between plugin and will","commit_id":"00069398f0313d58a323eeb361cc8936bbb80bf5"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"9ad7bb7c585f3387b238ca1e672edac6d6036851","unresolved":false,"context_lines":[{"line_number":51,"context_line":"Create a new \"password\" auth plugin to enforce multi-factor authentication."},{"line_number":52,"context_line":"The plugin can be swapped in by configuring the keystone paste file."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The auth plugin  will require a user to specify both their username and"},{"line_number":55,"context_line":"password along with a client generated OTP.  The plugin will then verify the"},{"line_number":56,"context_line":"OTP is valid along with the user credentials."},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9aa7fdbe_30b5b431","line":54,"in_reply_to":"9aa7fdbe_5efdf96d","updated":"2014-10-29 15:11:40.000000000","message":"Done","commit_id":"00069398f0313d58a323eeb361cc8936bbb80bf5"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6e8399be5df71610d5cc247498bd3c2d114e79cc","unresolved":false,"context_lines":[{"line_number":78,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":79,"context_line":"  a new way to access sensitive information or a new way to login?"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  It adds an additional step to the login process when MFA is enabled."},{"line_number":82,"context_line":"  The user needs to be aware when MFA is enabled and specify their \"possession"},{"line_number":83,"context_line":"  factor\" in the request."},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"9aa7fdbe_5bbb3975","line":81,"updated":"2014-10-29 15:59:52.000000000","message":"Is this an extra step, or is it something that\u0027s additionally supplied in the token request?","commit_id":"f0d336428e6e872a56c683f24999ace74179b2fb"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"f4a8473b63fced4966a2037a19518e40da4b55ff","unresolved":false,"context_lines":[{"line_number":78,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":79,"context_line":"  a new way to access sensitive information or a new way to login?"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  It adds an additional step to the login process when MFA is enabled."},{"line_number":82,"context_line":"  The user needs to be aware when MFA is enabled and specify their \"possession"},{"line_number":83,"context_line":"  factor\" in the request."},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a8c0949_2ce36f34","line":81,"in_reply_to":"9aa7fdbe_5bbb3975","updated":"2014-11-03 15:08:56.000000000","message":"It adds additional request data to the request.","commit_id":"f0d336428e6e872a56c683f24999ace74179b2fb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6e8399be5df71610d5cc247498bd3c2d114e79cc","unresolved":false,"context_lines":[{"line_number":128,"context_line":"  implement as well)? Are the default values ones which will work well in"},{"line_number":129,"context_line":"  real deployments?"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  The OTP driver should be specified in the Keystone configuration file."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"* Is this a change that takes immediate effect after its merged, or is it"},{"line_number":134,"context_line":"  something that has to be explicitly enabled?"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9aa7fdbe_fbab0d1c","line":131,"updated":"2014-10-29 15:59:52.000000000","message":"Line 52 says it should be configured in the paste file.","commit_id":"f0d336428e6e872a56c683f24999ace74179b2fb"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"f4a8473b63fced4966a2037a19518e40da4b55ff","unresolved":false,"context_lines":[{"line_number":128,"context_line":"  implement as well)? Are the default values ones which will work well in"},{"line_number":129,"context_line":"  real deployments?"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  The OTP driver should be specified in the Keystone configuration file."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"* Is this a change that takes immediate effect after its merged, or is it"},{"line_number":134,"context_line":"  something that has to be explicitly enabled?"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a8c0949_4c5fdbe5","line":131,"in_reply_to":"9aa7fdbe_fbab0d1c","updated":"2014-11-03 15:08:56.000000000","message":"Updated line 52.","commit_id":"f0d336428e6e872a56c683f24999ace74179b2fb"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"764275348ed206a34ab7550a4af356ffc5640426","unresolved":false,"context_lines":[{"line_number":157,"context_line":"Work Items"},{"line_number":158,"context_line":"----------"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"* Add a new One-time password authentication driver"},{"line_number":161,"context_line":"* Add a new multi-factor auth-plugin that replaces \"password\""},{"line_number":162,"context_line":"* Add resource to setup multi-factor for a user"},{"line_number":163,"context_line":"* Document the process for setting up multi-factor deployment"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7a8c0949_5a386da0","line":160,"updated":"2014-11-03 18:28:17.000000000","message":"Why should it replace password?  Isn\u0027t mfa  one more method  in auth pluggin?\n\nHow are you planning to do MFA?  Is it validated  irrespective of resource setting?.  e.g if  a user  doesn\u0027t have mfa enabled for project A,  and if the user sends MFA token for project A, will it  be validated?","commit_id":"a797037e7a28c2c2a4ece41cb77336ff45c3e7c5"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"dde446a93a56ad9fcfd2ce339c82280ab805f625","unresolved":false,"context_lines":[{"line_number":157,"context_line":"Work Items"},{"line_number":158,"context_line":"----------"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"* Add a new One-time password authentication driver"},{"line_number":161,"context_line":"* Add a new multi-factor auth-plugin that replaces \"password\""},{"line_number":162,"context_line":"* Add resource to setup multi-factor for a user"},{"line_number":163,"context_line":"* Document the process for setting up multi-factor deployment"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7a8c0949_f4fcb740","line":160,"in_reply_to":"7a8c0949_5a386da0","updated":"2014-11-05 14:52:11.000000000","message":"Updated auth-plugin description.\n\nMFA token is a superset of non MFA token.  If a user sends a token that was received by using MFA and is validated with a project that doesn\u0027t require MFA the token should still be valid.","commit_id":"a797037e7a28c2c2a4ece41cb77336ff45c3e7c5"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"764275348ed206a34ab7550a4af356ffc5640426","unresolved":false,"context_lines":[{"line_number":162,"context_line":"* Add resource to setup multi-factor for a user"},{"line_number":163,"context_line":"* Document the process for setting up multi-factor deployment"},{"line_number":164,"context_line":"* Document the process for setting up a users multi-factor account"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Dependencies"},{"line_number":167,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"7a8c0949_baceb1b2","line":165,"updated":"2014-11-03 18:28:17.000000000","message":"Is barbican a  requirement for MFA? If not what are the alternatives?","commit_id":"a797037e7a28c2c2a4ece41cb77336ff45c3e7c5"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"dde446a93a56ad9fcfd2ce339c82280ab805f625","unresolved":false,"context_lines":[{"line_number":162,"context_line":"* Add resource to setup multi-factor for a user"},{"line_number":163,"context_line":"* Document the process for setting up multi-factor deployment"},{"line_number":164,"context_line":"* Document the process for setting up a users multi-factor account"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Dependencies"},{"line_number":167,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"7a8c0949_cfaac4d1","line":165,"in_reply_to":"7a8c0949_baceb1b2","updated":"2014-11-05 14:52:11.000000000","message":"The alternative could be to store them in keystone and encrypt / decrypt the fields using a master key that is stored in keystone.conf.","commit_id":"a797037e7a28c2c2a4ece41cb77336ff45c3e7c5"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"9115427c2e2a0966afc26fc969363305c647d59f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"allow other implementations with different MFA requirements for different user"},{"line_number":43,"context_line":"sets."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Update project, domain and user data model to specify if MFA should be enforced"},{"line_number":46,"context_line":"and store OTP secret encrypted in data store.  There are two options for"},{"line_number":47,"context_line":"storing OTP secret.  Store them in Barbican or encrypt them in data store and"},{"line_number":48,"context_line":"store encryption key in keystone.conf."}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_2ee6feb4","line":45,"updated":"2014-11-12 10:22:35.000000000","message":"so, you want to allow options like:\n\n1) MFA for user trying to authenticate \n2) MFA for a user trying to scope to a domain (user already has an unscoped token for instance)\n3) MFA for a user trying to scope to a project (user already has an unscoped token for instance)\n ?","commit_id":"e4ccc969adf4aa2b68238ab456703d0d18b98506"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"4bd107a38abb7412887deca7bc205045e955d747","unresolved":false,"context_lines":[{"line_number":42,"context_line":"allow other implementations with different MFA requirements for different user"},{"line_number":43,"context_line":"sets."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Update project, domain and user data model to specify if MFA should be enforced"},{"line_number":46,"context_line":"and store OTP secret encrypted in data store.  There are two options for"},{"line_number":47,"context_line":"storing OTP secret.  Store them in Barbican or encrypt them in data store and"},{"line_number":48,"context_line":"store encryption key in keystone.conf."}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_9f7e8c17","line":45,"in_reply_to":"5a890539_2ee6feb4","updated":"2014-11-18 15:51:49.000000000","message":"Updated description.\n\nAn admin should be able to specify if a user needs to use MFA on a project or domain.  When a user authenticates against a domain that requires MFA he must authenticate using 2-step verification, otherwise he would receive an unauthorized response.","commit_id":"e4ccc969adf4aa2b68238ab456703d0d18b98506"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"9115427c2e2a0966afc26fc969363305c647d59f","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"* Add a new One-time password authentication driver"},{"line_number":164,"context_line":"* Add a new multi-factor auth-plugin"},{"line_number":165,"context_line":"* Add resource to setup multi-factor for a user"},{"line_number":166,"context_line":"* Document the process for setting up multi-factor deployment"},{"line_number":167,"context_line":"* Document the process for setting up a users multi-factor account"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_aeb74e85","line":165,"updated":"2014-11-12 10:22:35.000000000","message":"here you have only mfa for a user, and in line 45  you mentioned projects and domains as well.","commit_id":"e4ccc969adf4aa2b68238ab456703d0d18b98506"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"4bd107a38abb7412887deca7bc205045e955d747","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"* Add a new One-time password authentication driver"},{"line_number":164,"context_line":"* Add a new multi-factor auth-plugin"},{"line_number":165,"context_line":"* Add resource to setup multi-factor for a user"},{"line_number":166,"context_line":"* Document the process for setting up multi-factor deployment"},{"line_number":167,"context_line":"* Document the process for setting up a users multi-factor account"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_7f7000a4","line":165,"in_reply_to":"5a890539_aeb74e85","updated":"2014-11-18 15:51:49.000000000","message":"Updated description.","commit_id":"e4ccc969adf4aa2b68238ab456703d0d18b98506"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"dad187fe2a035e05bd48af07dd57fe37d90ee17b","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp multi-factor-auth \u003chttps://blueprints.launchpad.net/keystone/+spec/multi-factor-auth\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Multi-factor Authentication provides a way to authenticate a user using two"},{"line_number":14,"context_line":"independent authentication factors, including a new one-time password algorithm"},{"line_number":15,"context_line":"(OTP) that is time-based (TOTP) which has no service providers and can be"},{"line_number":16,"context_line":"implemented fully in the open."}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_c0a00ca8","line":13,"updated":"2014-11-19 14:36:36.000000000","message":"(nit) I think this needs a comma (or period) to break up the run-on sentence. I think the comma would go before \u0027which\u0027.","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"1287cdba5f96dd788fa2b14ad2295f8b537e946f","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp multi-factor-auth \u003chttps://blueprints.launchpad.net/keystone/+spec/multi-factor-auth\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Multi-factor Authentication provides a way to authenticate a user using two"},{"line_number":14,"context_line":"independent authentication factors, including a new one-time password algorithm"},{"line_number":15,"context_line":"(OTP) that is time-based (TOTP) which has no service providers and can be"},{"line_number":16,"context_line":"implemented fully in the open."}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_b90d43ea","line":13,"in_reply_to":"5a890539_c0a00ca8","updated":"2014-11-25 19:57:11.000000000","message":"Done","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"dad187fe2a035e05bd48af07dd57fe37d90ee17b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"implemented fully in the open."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Make one time password \"pluggable\" to allow other implementations like HMAC"},{"line_number":19,"context_line":"based password (HOTP), RSA or other vendor with different requirements."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The algorithm proposed is already being used by Google for their multi-factor"},{"line_number":22,"context_line":"authentication."}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_60911852","line":19,"updated":"2014-11-19 14:36:36.000000000","message":"(nit) s/vendor/vendor implementations/","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"1287cdba5f96dd788fa2b14ad2295f8b537e946f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"implemented fully in the open."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Make one time password \"pluggable\" to allow other implementations like HMAC"},{"line_number":19,"context_line":"based password (HOTP), RSA or other vendor with different requirements."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The algorithm proposed is already being used by Google for their multi-factor"},{"line_number":22,"context_line":"authentication."}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_b9246360","line":19,"in_reply_to":"5a890539_60911852","updated":"2014-11-25 19:57:11.000000000","message":"Done","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":1228,"name":"Joe Savak","email":"jsavak@gmail.com","username":"jsavak"},"change_message_id":"20d8cdc3cc5834e0112250c3110c3f6bd07de89c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Proposed Change"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"This implementation does not require to use a vendor for a second"},{"line_number":38,"context_line":"authentication method."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Implemented Time-based one-time password authentication driver using TOTP that"}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_a276763d","line":37,"updated":"2014-11-20 16:23:48.000000000","message":"s/use a vendor for a second authentication method/use of an external system to provide a second authentication method/","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"1287cdba5f96dd788fa2b14ad2295f8b537e946f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Proposed Change"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"This implementation does not require to use a vendor for a second"},{"line_number":38,"context_line":"authentication method."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Implemented Time-based one-time password authentication driver using TOTP that"}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_b980e3f7","line":37,"in_reply_to":"5a890539_a276763d","updated":"2014-11-25 19:57:11.000000000","message":"Done","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"dad187fe2a035e05bd48af07dd57fe37d90ee17b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"This implementation does not require to use a vendor for a second"},{"line_number":38,"context_line":"authentication method."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Implemented Time-based one-time password authentication driver using TOTP that"},{"line_number":41,"context_line":"is compatible with Google Authenticator.  Make implementation \"pluggable\" to"},{"line_number":42,"context_line":"allow other implementations with different MFA requirements for different user"},{"line_number":43,"context_line":"sets."}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_e093484d","line":40,"updated":"2014-11-19 14:36:36.000000000","message":"suggest time instead of Time","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"1287cdba5f96dd788fa2b14ad2295f8b537e946f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"This implementation does not require to use a vendor for a second"},{"line_number":38,"context_line":"authentication method."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Implemented Time-based one-time password authentication driver using TOTP that"},{"line_number":41,"context_line":"is compatible with Google Authenticator.  Make implementation \"pluggable\" to"},{"line_number":42,"context_line":"allow other implementations with different MFA requirements for different user"},{"line_number":43,"context_line":"sets."}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_f97d0b1d","line":40,"in_reply_to":"5a890539_e093484d","updated":"2014-11-25 19:57:11.000000000","message":"Done","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"dad187fe2a035e05bd48af07dd57fe37d90ee17b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"authentication method."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Implemented Time-based one-time password authentication driver using TOTP that"},{"line_number":41,"context_line":"is compatible with Google Authenticator.  Make implementation \"pluggable\" to"},{"line_number":42,"context_line":"allow other implementations with different MFA requirements for different user"},{"line_number":43,"context_line":"sets."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_a0a9407d","line":41,"updated":"2014-11-19 14:36:36.000000000","message":"I wouldn\u0027t mind seeing Google Authenticator linked to the docs.","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"1287cdba5f96dd788fa2b14ad2295f8b537e946f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"authentication method."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Implemented Time-based one-time password authentication driver using TOTP that"},{"line_number":41,"context_line":"is compatible with Google Authenticator.  Make implementation \"pluggable\" to"},{"line_number":42,"context_line":"allow other implementations with different MFA requirements for different user"},{"line_number":43,"context_line":"sets."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_9965e746","line":41,"in_reply_to":"5a890539_a0a9407d","updated":"2014-11-25 19:57:11.000000000","message":"link at the bottom of spec.","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"dad187fe2a035e05bd48af07dd57fe37d90ee17b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"allow other implementations with different MFA requirements for different user"},{"line_number":43,"context_line":"sets."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Update project, domain and user data model to specify if MFA should be enforced"},{"line_number":46,"context_line":"and store OTP secret encrypted in data store.  There are two options for"},{"line_number":47,"context_line":"storing OTP secret.  Store them in Barbican or encrypt them in data store and"},{"line_number":48,"context_line":"store encryption key in keystone.conf."}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_a0eea0b2","line":45,"updated":"2014-11-19 14:36:36.000000000","message":"From the above it sounds like each domain can use a different MFA algorithm. Is that correct and if so where does all of the metadata for that go? Metadata meaning the specific OTP secret and other things that are algorithm specific.","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"1287cdba5f96dd788fa2b14ad2295f8b537e946f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"allow other implementations with different MFA requirements for different user"},{"line_number":43,"context_line":"sets."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Update project, domain and user data model to specify if MFA should be enforced"},{"line_number":46,"context_line":"and store OTP secret encrypted in data store.  There are two options for"},{"line_number":47,"context_line":"storing OTP secret.  Store them in Barbican or encrypt them in data store and"},{"line_number":48,"context_line":"store encryption key in keystone.conf."}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_39fa3343","line":45,"in_reply_to":"5a890539_a0eea0b2","updated":"2014-11-25 19:57:11.000000000","message":"MFA uses the same algorithm for a specific deployment.  This can be augmented in the future.","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"dad187fe2a035e05bd48af07dd57fe37d90ee17b","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Update project, domain and user data model to specify if MFA should be enforced"},{"line_number":46,"context_line":"and store OTP secret encrypted in data store.  There are two options for"},{"line_number":47,"context_line":"storing OTP secret.  Store them in Barbican or encrypt them in data store and"},{"line_number":48,"context_line":"store encryption key in keystone.conf."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"An admin should be able to specify if a user needs to use MFA on a project or"}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_205f1074","line":47,"updated":"2014-11-19 14:36:36.000000000","message":"Do we actually need to change the user/domain/project models to store this data or can is be stored separately and just used by the MFA auth plugin?","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"1287cdba5f96dd788fa2b14ad2295f8b537e946f","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Update project, domain and user data model to specify if MFA should be enforced"},{"line_number":46,"context_line":"and store OTP secret encrypted in data store.  There are two options for"},{"line_number":47,"context_line":"storing OTP secret.  Store them in Barbican or encrypt them in data store and"},{"line_number":48,"context_line":"store encryption key in keystone.conf."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"An admin should be able to specify if a user needs to use MFA on a project or"}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_7c282986","line":47,"in_reply_to":"5a890539_205f1074","updated":"2014-11-25 19:57:11.000000000","message":"Updated to store in metadata.","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"dad187fe2a035e05bd48af07dd57fe37d90ee17b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"store encryption key in keystone.conf."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"An admin should be able to specify if a user needs to use MFA on a project or"},{"line_number":51,"context_line":"domain.  A user must authenticate using 2-step verification when MFA is enforced"},{"line_number":52,"context_line":"for a user, domain or project, otherwise the user will receive an unauthorized"},{"line_number":53,"context_line":"response."},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_40397cd7","line":51,"updated":"2014-11-19 14:36:36.000000000","message":"I think this line is what\u0027s causing the build failure.","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"1287cdba5f96dd788fa2b14ad2295f8b537e946f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"store encryption key in keystone.conf."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"An admin should be able to specify if a user needs to use MFA on a project or"},{"line_number":51,"context_line":"domain.  A user must authenticate using 2-step verification when MFA is enforced"},{"line_number":52,"context_line":"for a user, domain or project, otherwise the user will receive an unauthorized"},{"line_number":53,"context_line":"response."},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_1c3e45b8","line":51,"in_reply_to":"5a890539_40397cd7","updated":"2014-11-25 19:57:11.000000000","message":"Done","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":1228,"name":"Joe Savak","email":"jsavak@gmail.com","username":"jsavak"},"change_message_id":"20d8cdc3cc5834e0112250c3110c3f6bd07de89c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"An admin should be able to specify if a user needs to use MFA on a project or"},{"line_number":51,"context_line":"domain.  A user must authenticate using 2-step verification when MFA is enforced"},{"line_number":52,"context_line":"for a user, domain or project, otherwise the user will receive an unauthorized"},{"line_number":53,"context_line":"response."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"A user that requires MFA or tries to authenticate against a project or domain"},{"line_number":56,"context_line":"that requires MFA will have to specify a second OTP."}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_c22e22a5","line":53,"updated":"2014-11-20 16:23:48.000000000","message":"Suggested rewording: A user must authenticate using the 2nd factor if MFA is enabled for enforcement for the user, the domain in which the user-belongs, or the project that the user has access to.","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"1287cdba5f96dd788fa2b14ad2295f8b537e946f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"An admin should be able to specify if a user needs to use MFA on a project or"},{"line_number":51,"context_line":"domain.  A user must authenticate using 2-step verification when MFA is enforced"},{"line_number":52,"context_line":"for a user, domain or project, otherwise the user will receive an unauthorized"},{"line_number":53,"context_line":"response."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"A user that requires MFA or tries to authenticate against a project or domain"},{"line_number":56,"context_line":"that requires MFA will have to specify a second OTP."}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_bc6c51d1","line":53,"in_reply_to":"5a890539_c22e22a5","updated":"2014-11-25 19:57:11.000000000","message":"Done","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"dad187fe2a035e05bd48af07dd57fe37d90ee17b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"valid along with the user credentials."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"For the initial implementation when a user gets MFA enabled, the users previous"},{"line_number":66,"context_line":"tokens would still be valid.  Services that only want to allow MFA tokens can"},{"line_number":67,"context_line":"use the methods list to verify OTP was used."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_c049ec8f","line":66,"updated":"2014-11-19 14:36:36.000000000","message":"Is an \"MFA token\" just a bearer token that was obtained using MFA or is there something special about it?","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":1228,"name":"Joe Savak","email":"jsavak@gmail.com","username":"jsavak"},"change_message_id":"20d8cdc3cc5834e0112250c3110c3f6bd07de89c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"valid along with the user credentials."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"For the initial implementation when a user gets MFA enabled, the users previous"},{"line_number":66,"context_line":"tokens would still be valid.  Services that only want to allow MFA tokens can"},{"line_number":67,"context_line":"use the methods list to verify OTP was used."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_2d50b709","line":66,"in_reply_to":"5a890539_c049ec8f","updated":"2014-11-20 16:23:48.000000000","message":"MFA token is just another bearer token, upon validation - services should see that multiple methods were used to obtain the token (ex: password and OTP).","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"dad187fe2a035e05bd48af07dd57fe37d90ee17b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"tokens would still be valid.  Services that only want to allow MFA tokens can"},{"line_number":67,"context_line":"use the methods list to verify OTP was used."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Alternatives"},{"line_number":71,"context_line":"------------"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_c0c64c16","line":69,"updated":"2014-11-19 14:36:36.000000000","message":"Is there a way to advertise what MFA algorithms are available?","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"1287cdba5f96dd788fa2b14ad2295f8b537e946f","unresolved":false,"context_lines":[{"line_number":66,"context_line":"tokens would still be valid.  Services that only want to allow MFA tokens can"},{"line_number":67,"context_line":"use the methods list to verify OTP was used."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Alternatives"},{"line_number":71,"context_line":"------------"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_7cd2e95c","line":69,"in_reply_to":"5a890539_2d9ef7b8","updated":"2014-11-25 19:57:11.000000000","message":"Done","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":1228,"name":"Joe Savak","email":"jsavak@gmail.com","username":"jsavak"},"change_message_id":"20d8cdc3cc5834e0112250c3110c3f6bd07de89c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"tokens would still be valid.  Services that only want to allow MFA tokens can"},{"line_number":67,"context_line":"use the methods list to verify OTP was used."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Alternatives"},{"line_number":71,"context_line":"------------"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_2d9ef7b8","line":69,"in_reply_to":"5a890539_c0c64c16","updated":"2014-11-20 16:23:48.000000000","message":"+1 - this would be helpful in the case where an implementor does want to offer SMS or a push-notification factor.","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"1287cdba5f96dd788fa2b14ad2295f8b537e946f","unresolved":false,"context_lines":[{"line_number":66,"context_line":"tokens would still be valid.  Services that only want to allow MFA tokens can"},{"line_number":67,"context_line":"use the methods list to verify OTP was used."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Alternatives"},{"line_number":71,"context_line":"------------"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_3ce5c137","line":69,"in_reply_to":"5a890539_c0c64c16","updated":"2014-11-25 19:57:11.000000000","message":"Done","commit_id":"e4c1680855572da4267fcf77149ce2d82eef6fbd"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"574c6afb92cf657049d428cb29a4ff8d2a302a14","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"The goal of Multi-factor Authentication (MFA) is to make it more difficult for"},{"line_number":29,"context_line":"an unauthorized user to gain access to an OpenStack resource. If a password is"},{"line_number":30,"context_line":"compromised there is still another barrier before granting access."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Currently Keystone only supports \"knowledge factor\" (something the user knows)."},{"line_number":33,"context_line":"The goal of this change is to add a \"possession factor\" (something a user has)."}],"source_content_type":"text/x-rst","patch_set":12,"id":"5a890539_2d8669b9","line":30,"updated":"2014-11-25 22:00:11.000000000","message":"s/access/access token/","commit_id":"6c25f0afc4866ed405e914e5f32466c7528adef6"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"e0a325814245e6ddb8f97f333c4dc6f108aeb97f","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"The goal of Multi-factor Authentication (MFA) is to make it more difficult for"},{"line_number":29,"context_line":"an unauthorized user to gain access to an OpenStack resource. If a password is"},{"line_number":30,"context_line":"compromised there is still another barrier before granting access."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Currently Keystone only supports \"knowledge factor\" (something the user knows)."},{"line_number":33,"context_line":"The goal of this change is to add a \"possession factor\" (something a user has)."}],"source_content_type":"text/x-rst","patch_set":12,"id":"5a890539_888aeb18","line":30,"in_reply_to":"5a890539_2d8669b9","updated":"2014-11-25 22:16:43.000000000","message":"Done","commit_id":"6c25f0afc4866ed405e914e5f32466c7528adef6"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"574c6afb92cf657049d428cb29a4ff8d2a302a14","unresolved":false,"context_lines":[{"line_number":58,"context_line":"user has access to."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Create a new \"password\" auth plugin to enforce multi-factor authentication."},{"line_number":61,"context_line":"The plugin can be swapped in by updating Keystone configuration."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"The auth plugin will require a user to specify both their username and password"},{"line_number":64,"context_line":"along with a client generated OTP.  The plugin will then verify the OTP is"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5a890539_6da31143","line":61,"updated":"2014-11-25 22:00:11.000000000","message":"It might be nice to include an example of what the contents of a curl call would be here.","commit_id":"6c25f0afc4866ed405e914e5f32466c7528adef6"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"e0a325814245e6ddb8f97f333c4dc6f108aeb97f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"user has access to."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Create a new \"password\" auth plugin to enforce multi-factor authentication."},{"line_number":61,"context_line":"The plugin can be swapped in by updating Keystone configuration."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"The auth plugin will require a user to specify both their username and password"},{"line_number":64,"context_line":"along with a client generated OTP.  The plugin will then verify the OTP is"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5a890539_a88de732","line":61,"in_reply_to":"5a890539_6da31143","updated":"2014-11-25 22:16:43.000000000","message":"Done","commit_id":"6c25f0afc4866ed405e914e5f32466c7528adef6"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"574c6afb92cf657049d428cb29a4ff8d2a302a14","unresolved":false,"context_lines":[{"line_number":68,"context_line":"tokens would still be valid.  Services that only want to allow MFA tokens can"},{"line_number":69,"context_line":"use the methods list to verify OTP was used."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Add ability to see MFA algorithms available for a specific keystone deployment."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Alternatives"},{"line_number":74,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5a890539_8d659d1f","line":71,"updated":"2014-11-25 22:00:11.000000000","message":"s/keystone/Keystone/","commit_id":"6c25f0afc4866ed405e914e5f32466c7528adef6"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"e0a325814245e6ddb8f97f333c4dc6f108aeb97f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"tokens would still be valid.  Services that only want to allow MFA tokens can"},{"line_number":69,"context_line":"use the methods list to verify OTP was used."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Add ability to see MFA algorithms available for a specific keystone deployment."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Alternatives"},{"line_number":74,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5a890539_e8836f00","line":71,"in_reply_to":"5a890539_8d659d1f","updated":"2014-11-25 22:16:43.000000000","message":"Done","commit_id":"6c25f0afc4866ed405e914e5f32466c7528adef6"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"997a181324481adc974f169991d7f620767aa015","unresolved":false,"context_lines":[{"line_number":15,"context_line":"(OTP) that is time-based (TOTP), which has no service providers and can be"},{"line_number":16,"context_line":"implemented fully in the open."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Make one time password \"pluggable\" to allow other implementations like HMAC"},{"line_number":19,"context_line":"based password (HOTP), RSA or other vendor implementations with different"},{"line_number":20,"context_line":"requirements."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a890539_55af3b2b","line":18,"updated":"2014-12-01 22:21:47.000000000","message":"The sentence starts a little abruptly. For example, you could have said, \"In our proposed design we have made the one time password...","commit_id":"fc6dd0fa81ed58a0ac6da8de31e4138b963ba9cb"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"8fd2c9857f9e842c0d80f7399085b2ef223c032a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"(OTP) that is time-based (TOTP), which has no service providers and can be"},{"line_number":16,"context_line":"implemented fully in the open."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Make one time password \"pluggable\" to allow other implementations like HMAC"},{"line_number":19,"context_line":"based password (HOTP), RSA or other vendor implementations with different"},{"line_number":20,"context_line":"requirements."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a890539_1f57655b","line":18,"in_reply_to":"5a890539_55af3b2b","updated":"2014-12-02 22:00:19.000000000","message":"Done","commit_id":"fc6dd0fa81ed58a0ac6da8de31e4138b963ba9cb"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"997a181324481adc974f169991d7f620767aa015","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Problem Description"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"The goal of Multi-factor Authentication (MFA) is to make it more difficult for"},{"line_number":29,"context_line":"an unauthorized user to gain access to an OpenStack resource. If a password is"},{"line_number":30,"context_line":"compromised there is still another barrier before granting access token."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a890539_f565871d","line":28,"updated":"2014-12-01 22:21:47.000000000","message":"Great Description!","commit_id":"fc6dd0fa81ed58a0ac6da8de31e4138b963ba9cb"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"8fd2c9857f9e842c0d80f7399085b2ef223c032a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Problem Description"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"The goal of Multi-factor Authentication (MFA) is to make it more difficult for"},{"line_number":29,"context_line":"an unauthorized user to gain access to an OpenStack resource. If a password is"},{"line_number":30,"context_line":"compromised there is still another barrier before granting access token."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a890539_d1287699","line":28,"in_reply_to":"5a890539_f565871d","updated":"2014-12-02 22:00:19.000000000","message":"Thanks!","commit_id":"fc6dd0fa81ed58a0ac6da8de31e4138b963ba9cb"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"997a181324481adc974f169991d7f620767aa015","unresolved":false,"context_lines":[{"line_number":42,"context_line":"is compatible with Google Authenticator.  Make implementation \"pluggable\" to"},{"line_number":43,"context_line":"allow other implementations with different MFA requirements for different user"},{"line_number":44,"context_line":"sets."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Store metadata that specifies if MFA should be enforced for project, domain and"},{"line_number":47,"context_line":"users, and store OTP secret encrypted in data store.  There are two options for"},{"line_number":48,"context_line":"storing OTP secret.  Store them in Barbican or encrypt them in data store and"}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a890539_9557e325","line":45,"updated":"2014-12-01 22:21:47.000000000","message":"So its sound like you MFA is highly configurable and can be chosen to be used at the project, domain, and user level.  Are you implementing it such that is not all or nothing at the domain level? For example some domains may want to use this and others may not.  Assuming it is not all or nothing what would the per domain configuration instructions look like?  How is per domain configuration handled when multi-domain LDAP support is being utilized?","commit_id":"fc6dd0fa81ed58a0ac6da8de31e4138b963ba9cb"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"8fd2c9857f9e842c0d80f7399085b2ef223c032a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"is compatible with Google Authenticator.  Make implementation \"pluggable\" to"},{"line_number":43,"context_line":"allow other implementations with different MFA requirements for different user"},{"line_number":44,"context_line":"sets."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Store metadata that specifies if MFA should be enforced for project, domain and"},{"line_number":47,"context_line":"users, and store OTP secret encrypted in data store.  There are two options for"},{"line_number":48,"context_line":"storing OTP secret.  Store them in Barbican or encrypt them in data store and"}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a890539_51000666","line":45,"in_reply_to":"5a890539_9557e325","updated":"2014-12-02 22:00:19.000000000","message":"This spec implements only one MFA implementation (TOTP), but allows specifying other implementations by implementing a new driver.  Domains and Projects will be able to specify if a user needs to use MFA to get a token.  An admin would use the admin rest api to specify if a domain or project should enforce MFA and this would be stored in a metadata table.","commit_id":"fc6dd0fa81ed58a0ac6da8de31e4138b963ba9cb"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"25a7f49cd74e126a53b3cccb280c2d845673c3ec","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                  \"algorithm\": \"TOTP\","},{"line_number":76,"context_line":"                  \"secret\": \"12345\""},{"line_number":77,"context_line":"              }"},{"line_number":78,"context_line":"          }"},{"line_number":79,"context_line":"      }"},{"line_number":80,"context_line":"  }"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a890539_562b3881","line":78,"updated":"2014-11-26 10:30:56.000000000","message":"I think with your primary use case is a project/domain scoped token, so I suggest adding scope section here.. Otherwise, how is algorithms going to distinguis if for that entity/domain user needs OTP like you had mentioned somewhere before?","commit_id":"fc6dd0fa81ed58a0ac6da8de31e4138b963ba9cb"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"8fd2c9857f9e842c0d80f7399085b2ef223c032a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                  \"algorithm\": \"TOTP\","},{"line_number":76,"context_line":"                  \"secret\": \"12345\""},{"line_number":77,"context_line":"              }"},{"line_number":78,"context_line":"          }"},{"line_number":79,"context_line":"      }"},{"line_number":80,"context_line":"  }"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a890539_11c2fee8","line":78,"in_reply_to":"5a890539_562b3881","updated":"2014-12-02 22:00:19.000000000","message":"Done","commit_id":"fc6dd0fa81ed58a0ac6da8de31e4138b963ba9cb"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"997a181324481adc974f169991d7f620767aa015","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"For the initial implementation when a user gets MFA enabled, the users previous"},{"line_number":90,"context_line":"tokens would still be valid.  Services that only want to allow MFA tokens can"},{"line_number":91,"context_line":"use the methods list to verify OTP was used."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Add ability to see MFA algorithms available for a specific Keystone deployment."},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a890539_95052316","line":91,"updated":"2014-12-01 22:21:47.000000000","message":"Will new CADF audting records be added to denote that MFA was in use?","commit_id":"fc6dd0fa81ed58a0ac6da8de31e4138b963ba9cb"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"8fd2c9857f9e842c0d80f7399085b2ef223c032a","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"For the initial implementation when a user gets MFA enabled, the users previous"},{"line_number":90,"context_line":"tokens would still be valid.  Services that only want to allow MFA tokens can"},{"line_number":91,"context_line":"use the methods list to verify OTP was used."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Add ability to see MFA algorithms available for a specific Keystone deployment."},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a890539_b154ca22","line":91,"in_reply_to":"5a890539_95052316","updated":"2014-12-02 22:00:19.000000000","message":"I am not familiar with CADF auditing.  If the code is logging the methods used to authenticate, the changes proposed here should not break that functionality.","commit_id":"fc6dd0fa81ed58a0ac6da8de31e4138b963ba9cb"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"25a7f49cd74e126a53b3cccb280c2d845673c3ec","unresolved":false,"context_lines":[{"line_number":192,"context_line":"* Add a new One-time password authentication driver"},{"line_number":193,"context_line":"* Add a new multi-factor auth-plugin"},{"line_number":194,"context_line":"* Add resource to setup multi-factor for a user"},{"line_number":195,"context_line":"* Add/Update resource to toggle MFA enforcement for domains or projects."},{"line_number":196,"context_line":"* Document the process for setting up multi-factor deployment"},{"line_number":197,"context_line":"* Document the process for setting up a users multi-factor account"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a890539_766cb4d0","line":195,"updated":"2014-11-26 10:30:56.000000000","message":"Does it mean changing project/domain API ?","commit_id":"fc6dd0fa81ed58a0ac6da8de31e4138b963ba9cb"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"8fd2c9857f9e842c0d80f7399085b2ef223c032a","unresolved":false,"context_lines":[{"line_number":192,"context_line":"* Add a new One-time password authentication driver"},{"line_number":193,"context_line":"* Add a new multi-factor auth-plugin"},{"line_number":194,"context_line":"* Add resource to setup multi-factor for a user"},{"line_number":195,"context_line":"* Add/Update resource to toggle MFA enforcement for domains or projects."},{"line_number":196,"context_line":"* Document the process for setting up multi-factor deployment"},{"line_number":197,"context_line":"* Document the process for setting up a users multi-factor account"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a890539_7fadc930","line":195,"in_reply_to":"5a890539_766cb4d0","updated":"2014-12-02 22:00:19.000000000","message":"I was thinking of either updating existing api to add new attribute to domain and projects, or add new rest api to enable and disable this functionality.  I would prefer using the existing api, but someone had mentioned in a previously patch that it should be separate.","commit_id":"fc6dd0fa81ed58a0ac6da8de31e4138b963ba9cb"},{"author":{"_account_id":13082,"name":"Irina","email":"ipovolotskaya@mirantis.com","username":"ipovolotskaya"},"change_message_id":"bb7e9b975adab4eaed84ddbae2063ac34459b266","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp multi-factor-auth \u003chttps://blueprints.launchpad.net/keystone/+spec/multi-factor-auth\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Multi-factor Authentication provides a way to authenticate a user using two"},{"line_number":14,"context_line":"independent authentication factors, including a new one-time password algorithm"},{"line_number":15,"context_line":"(OTP) that is time-based (TOTP), which has no service providers and can be"},{"line_number":16,"context_line":"implemented fully in the open."}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_56f42f86","line":13,"updated":"2014-12-04 09:22:32.000000000","message":"I believe, it should look like Multi-Factor Authentication","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"73903f852259ba54112c1c5fcf734ee93e78fb38","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp multi-factor-auth \u003chttps://blueprints.launchpad.net/keystone/+spec/multi-factor-auth\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Multi-factor Authentication provides a way to authenticate a user using two"},{"line_number":14,"context_line":"independent authentication factors, including a new one-time password algorithm"},{"line_number":15,"context_line":"(OTP) that is time-based (TOTP), which has no service providers and can be"},{"line_number":16,"context_line":"implemented fully in the open."}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_36906c42","line":13,"in_reply_to":"5a890539_56f42f86","updated":"2014-12-04 20:37:44.000000000","message":"Done","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":13082,"name":"Irina","email":"ipovolotskaya@mirantis.com","username":"ipovolotskaya"},"change_message_id":"bb7e9b975adab4eaed84ddbae2063ac34459b266","unresolved":false,"context_lines":[{"line_number":15,"context_line":"(OTP) that is time-based (TOTP), which has no service providers and can be"},{"line_number":16,"context_line":"implemented fully in the open."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"In our design we propose to make one time password \"pluggable\" to allow other"},{"line_number":19,"context_line":"implementations like HMAC based password (HOTP), RSA or other vendor"},{"line_number":20,"context_line":"implementations with different requirements."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_56ca6f6e","line":18,"updated":"2014-12-04 09:22:32.000000000","message":"one-time\n\nallow-\u003e enable?","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"73903f852259ba54112c1c5fcf734ee93e78fb38","unresolved":false,"context_lines":[{"line_number":15,"context_line":"(OTP) that is time-based (TOTP), which has no service providers and can be"},{"line_number":16,"context_line":"implemented fully in the open."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"In our design we propose to make one time password \"pluggable\" to allow other"},{"line_number":19,"context_line":"implementations like HMAC based password (HOTP), RSA or other vendor"},{"line_number":20,"context_line":"implementations with different requirements."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_9699206f","line":18,"in_reply_to":"5a890539_56ca6f6e","updated":"2014-12-04 20:37:44.000000000","message":"Done","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":13082,"name":"Irina","email":"ipovolotskaya@mirantis.com","username":"ipovolotskaya"},"change_message_id":"bb7e9b975adab4eaed84ddbae2063ac34459b266","unresolved":false,"context_lines":[{"line_number":16,"context_line":"implemented fully in the open."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"In our design we propose to make one time password \"pluggable\" to allow other"},{"line_number":19,"context_line":"implementations like HMAC based password (HOTP), RSA or other vendor"},{"line_number":20,"context_line":"implementations with different requirements."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"The algorithm proposed is already being used by Google for their multi-factor"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_96c0574b","line":19,"updated":"2014-12-04 09:22:32.000000000","message":"HMAC-based","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"73903f852259ba54112c1c5fcf734ee93e78fb38","unresolved":false,"context_lines":[{"line_number":16,"context_line":"implemented fully in the open."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"In our design we propose to make one time password \"pluggable\" to allow other"},{"line_number":19,"context_line":"implementations like HMAC based password (HOTP), RSA or other vendor"},{"line_number":20,"context_line":"implementations with different requirements."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"The algorithm proposed is already being used by Google for their multi-factor"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_b6a37c9c","line":19,"in_reply_to":"5a890539_96c0574b","updated":"2014-12-04 20:37:44.000000000","message":"Done","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":13082,"name":"Irina","email":"ipovolotskaya@mirantis.com","username":"ipovolotskaya"},"change_message_id":"bb7e9b975adab4eaed84ddbae2063ac34459b266","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"The goal of Multi-factor Authentication (MFA) is to make it more difficult for"},{"line_number":29,"context_line":"an unauthorized user to gain access to an OpenStack resource. If a password is"},{"line_number":30,"context_line":"compromised there is still another barrier before granting access token."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Currently Keystone only supports \"knowledge factor\" (something the user knows)."}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_d62f3ff4","line":29,"updated":"2014-12-04 09:22:32.000000000","message":"the password (\u003da specific known password)","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"73903f852259ba54112c1c5fcf734ee93e78fb38","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"The goal of Multi-factor Authentication (MFA) is to make it more difficult for"},{"line_number":29,"context_line":"an unauthorized user to gain access to an OpenStack resource. If a password is"},{"line_number":30,"context_line":"compromised there is still another barrier before granting access token."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Currently Keystone only supports \"knowledge factor\" (something the user knows)."}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_36deac11","line":29,"in_reply_to":"5a890539_d62f3ff4","updated":"2014-12-04 20:37:44.000000000","message":"Done","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":13082,"name":"Irina","email":"ipovolotskaya@mirantis.com","username":"ipovolotskaya"},"change_message_id":"bb7e9b975adab4eaed84ddbae2063ac34459b266","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Proposed Change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"This implementation does not require use of an external system to provide a"},{"line_number":39,"context_line":"second authentication method."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Implemented time-based one-time password authentication driver using TOTP that"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_d6165fa6","line":38,"updated":"2014-12-04 09:22:32.000000000","message":"to use an external system\n\nthe second authentication method","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"73903f852259ba54112c1c5fcf734ee93e78fb38","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Proposed Change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"This implementation does not require use of an external system to provide a"},{"line_number":39,"context_line":"second authentication method."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Implemented time-based one-time password authentication driver using TOTP that"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_d6f3a89c","line":38,"in_reply_to":"5a890539_d6165fa6","updated":"2014-12-04 20:37:44.000000000","message":"Done","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":13082,"name":"Irina","email":"ipovolotskaya@mirantis.com","username":"ipovolotskaya"},"change_message_id":"bb7e9b975adab4eaed84ddbae2063ac34459b266","unresolved":false,"context_lines":[{"line_number":38,"context_line":"This implementation does not require use of an external system to provide a"},{"line_number":39,"context_line":"second authentication method."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Implemented time-based one-time password authentication driver using TOTP that"},{"line_number":42,"context_line":"is compatible with Google Authenticator.  Make implementation \"pluggable\" to"},{"line_number":43,"context_line":"allow other implementations with different MFA requirements for different user"},{"line_number":44,"context_line":"sets."}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_76e20ba1","line":41,"updated":"2014-12-04 09:22:32.000000000","message":"too difficult to get through these 4 words relating to authentication driver..rewording is strongly required","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"73903f852259ba54112c1c5fcf734ee93e78fb38","unresolved":false,"context_lines":[{"line_number":38,"context_line":"This implementation does not require use of an external system to provide a"},{"line_number":39,"context_line":"second authentication method."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Implemented time-based one-time password authentication driver using TOTP that"},{"line_number":42,"context_line":"is compatible with Google Authenticator.  Make implementation \"pluggable\" to"},{"line_number":43,"context_line":"allow other implementations with different MFA requirements for different user"},{"line_number":44,"context_line":"sets."}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_f6e1849b","line":41,"in_reply_to":"5a890539_76e20ba1","updated":"2014-12-04 20:37:44.000000000","message":"Done","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":13082,"name":"Irina","email":"ipovolotskaya@mirantis.com","username":"ipovolotskaya"},"change_message_id":"bb7e9b975adab4eaed84ddbae2063ac34459b266","unresolved":false,"context_lines":[{"line_number":46,"context_line":"Store metadata that specifies if MFA should be enforced for project, domain and"},{"line_number":47,"context_line":"users, and store OTP secret encrypted in data store.  There are two options for"},{"line_number":48,"context_line":"storing OTP secret.  Store them in Barbican or encrypt them in data store and"},{"line_number":49,"context_line":"store encryption key in keystone.conf."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"An admin should be able to specify if a user needs to use MFA on a project or"},{"line_number":52,"context_line":"domain.  A user must authenticate using 2-step verification when MFA is"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_b6bd536a","line":49,"updated":"2014-12-04 09:22:32.000000000","message":"storing-\u003e keeping?\n\nOTP secret: store them in Barbican or encrypt in data store with filing encryption key in ...","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"73903f852259ba54112c1c5fcf734ee93e78fb38","unresolved":false,"context_lines":[{"line_number":46,"context_line":"Store metadata that specifies if MFA should be enforced for project, domain and"},{"line_number":47,"context_line":"users, and store OTP secret encrypted in data store.  There are two options for"},{"line_number":48,"context_line":"storing OTP secret.  Store them in Barbican or encrypt them in data store and"},{"line_number":49,"context_line":"store encryption key in keystone.conf."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"An admin should be able to specify if a user needs to use MFA on a project or"},{"line_number":52,"context_line":"domain.  A user must authenticate using 2-step verification when MFA is"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_815478fe","line":49,"in_reply_to":"5a890539_b6bd536a","updated":"2014-12-04 20:37:44.000000000","message":"Done","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":13082,"name":"Irina","email":"ipovolotskaya@mirantis.com","username":"ipovolotskaya"},"change_message_id":"bb7e9b975adab4eaed84ddbae2063ac34459b266","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"An admin should be able to specify if a user needs to use MFA on a project or"},{"line_number":52,"context_line":"domain.  A user must authenticate using 2-step verification when MFA is"},{"line_number":53,"context_line":"enforced for a user, domain or project, otherwise the user will receive an"},{"line_number":54,"context_line":"unauthorized response."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"A user must authenticate using the 2nd factor if MFA is enabled for enforcement"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_b6647322","line":53,"updated":"2014-12-04 09:22:32.000000000","message":"; otherwise,","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"73903f852259ba54112c1c5fcf734ee93e78fb38","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"An admin should be able to specify if a user needs to use MFA on a project or"},{"line_number":52,"context_line":"domain.  A user must authenticate using 2-step verification when MFA is"},{"line_number":53,"context_line":"enforced for a user, domain or project, otherwise the user will receive an"},{"line_number":54,"context_line":"unauthorized response."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"A user must authenticate using the 2nd factor if MFA is enabled for enforcement"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_96e8407c","line":53,"in_reply_to":"5a890539_b6647322","updated":"2014-12-04 20:37:44.000000000","message":"Done","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":13082,"name":"Irina","email":"ipovolotskaya@mirantis.com","username":"ipovolotskaya"},"change_message_id":"bb7e9b975adab4eaed84ddbae2063ac34459b266","unresolved":false,"context_lines":[{"line_number":88,"context_line":"The plugin can be swapped in by updating Keystone configuration."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"The auth plugin will require a user to specify both their username and password"},{"line_number":91,"context_line":"along with a client generated OTP.  The plugin will then verify the OTP is"},{"line_number":92,"context_line":"valid along with the user credentials."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"For the initial implementation when a user gets MFA enabled, the users previous"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_967937c7","line":91,"updated":"2014-12-04 09:22:32.000000000","message":"client-generated","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"73903f852259ba54112c1c5fcf734ee93e78fb38","unresolved":false,"context_lines":[{"line_number":88,"context_line":"The plugin can be swapped in by updating Keystone configuration."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"The auth plugin will require a user to specify both their username and password"},{"line_number":91,"context_line":"along with a client generated OTP.  The plugin will then verify the OTP is"},{"line_number":92,"context_line":"valid along with the user credentials."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"For the initial implementation when a user gets MFA enabled, the users previous"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_5699781d","line":91,"in_reply_to":"5a890539_967937c7","updated":"2014-12-04 20:37:44.000000000","message":"Done","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":13082,"name":"Irina","email":"ipovolotskaya@mirantis.com","username":"ipovolotskaya"},"change_message_id":"bb7e9b975adab4eaed84ddbae2063ac34459b266","unresolved":false,"context_lines":[{"line_number":91,"context_line":"along with a client generated OTP.  The plugin will then verify the OTP is"},{"line_number":92,"context_line":"valid along with the user credentials."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"For the initial implementation when a user gets MFA enabled, the users previous"},{"line_number":95,"context_line":"tokens would still be valid.  Services that only want to allow MFA tokens can"},{"line_number":96,"context_line":"use the methods list to verify OTP was used."},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_f6419b63","line":94,"updated":"2014-12-04 09:22:32.000000000","message":", when a user ...","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"73903f852259ba54112c1c5fcf734ee93e78fb38","unresolved":false,"context_lines":[{"line_number":91,"context_line":"along with a client generated OTP.  The plugin will then verify the OTP is"},{"line_number":92,"context_line":"valid along with the user credentials."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"For the initial implementation when a user gets MFA enabled, the users previous"},{"line_number":95,"context_line":"tokens would still be valid.  Services that only want to allow MFA tokens can"},{"line_number":96,"context_line":"use the methods list to verify OTP was used."},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_b689bccb","line":94,"in_reply_to":"5a890539_f6419b63","updated":"2014-12-04 20:37:44.000000000","message":"Done","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":13082,"name":"Irina","email":"ipovolotskaya@mirantis.com","username":"ipovolotskaya"},"change_message_id":"bb7e9b975adab4eaed84ddbae2063ac34459b266","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"  Yes, a users secret key to generate one time password will need to be stored."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":116,"context_line":"  a new way to access sensitive information or a new way to login?"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_d61c9f79","line":113,"updated":"2014-12-04 09:22:32.000000000","message":"one-time","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"73903f852259ba54112c1c5fcf734ee93e78fb38","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"  Yes, a users secret key to generate one time password will need to be stored."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":116,"context_line":"  a new way to access sensitive information or a new way to login?"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_d68488b2","line":113,"in_reply_to":"5a890539_d61c9f79","updated":"2014-12-04 20:37:44.000000000","message":"Done","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":13082,"name":"Irina","email":"ipovolotskaya@mirantis.com","username":"ipovolotskaya"},"change_message_id":"bb7e9b975adab4eaed84ddbae2063ac34459b266","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  a new way to access sensitive information or a new way to login?"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"  It adds additional request data to the login process when MFA is enabled."},{"line_number":119,"context_line":"  The user needs to be aware when MFA is enabled and specify their \"possession"},{"line_number":120,"context_line":"  factor\" in the request."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"* Does this change involve cryptography or hashing?"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_9115c13e","line":119,"updated":"2014-12-04 09:22:32.000000000","message":"change \u0027user\u0027 to \u0027users\u0027 since you write up \u0027their\u0027 in the second part of the sentence.","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"73903f852259ba54112c1c5fcf734ee93e78fb38","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  a new way to access sensitive information or a new way to login?"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"  It adds additional request data to the login process when MFA is enabled."},{"line_number":119,"context_line":"  The user needs to be aware when MFA is enabled and specify their \"possession"},{"line_number":120,"context_line":"  factor\" in the request."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"* Does this change involve cryptography or hashing?"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_96b68087","line":119,"in_reply_to":"5a890539_9115c13e","updated":"2014-12-04 20:37:44.000000000","message":"Done","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":13082,"name":"Irina","email":"ipovolotskaya@mirantis.com","username":"ipovolotskaya"},"change_message_id":"bb7e9b975adab4eaed84ddbae2063ac34459b266","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"* Does this change involve cryptography or hashing?"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"  Yes, the algorithms proposed use cryptography."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"* Does this change require the use of sudo or any elevated privileges?"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_d12ae97c","line":124,"updated":"2014-12-04 09:22:32.000000000","message":"the proposed algorithms","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"73903f852259ba54112c1c5fcf734ee93e78fb38","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"* Does this change involve cryptography or hashing?"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"  Yes, the algorithms proposed use cryptography."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"* Does this change require the use of sudo or any elevated privileges?"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_16a2903e","line":124,"in_reply_to":"5a890539_d12ae97c","updated":"2014-12-04 20:37:44.000000000","message":"Done","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":13082,"name":"Irina","email":"ipovolotskaya@mirantis.com","username":"ipovolotskaya"},"change_message_id":"bb7e9b975adab4eaed84ddbae2063ac34459b266","unresolved":false,"context_lines":[{"line_number":157,"context_line":"Other Deployer Impact"},{"line_number":158,"context_line":"---------------------"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Discuss things that will affect how you deploy and configure OpenStack"},{"line_number":161,"context_line":"that have not already been mentioned, such as:"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"* What config options are being added? Should they be more generic than"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_31424d3e","line":160,"updated":"2014-12-04 09:22:32.000000000","message":"maybe: that will affect deploying and configuring OpenStack","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"73903f852259ba54112c1c5fcf734ee93e78fb38","unresolved":false,"context_lines":[{"line_number":157,"context_line":"Other Deployer Impact"},{"line_number":158,"context_line":"---------------------"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Discuss things that will affect how you deploy and configure OpenStack"},{"line_number":161,"context_line":"that have not already been mentioned, such as:"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"* What config options are being added? Should they be more generic than"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_76411462","line":160,"in_reply_to":"5a890539_31424d3e","updated":"2014-12-04 20:37:44.000000000","message":"This was taken from template.","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":13082,"name":"Irina","email":"ipovolotskaya@mirantis.com","username":"ipovolotskaya"},"change_message_id":"bb7e9b975adab4eaed84ddbae2063ac34459b266","unresolved":false,"context_lines":[{"line_number":161,"context_line":"that have not already been mentioned, such as:"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"* What config options are being added? Should they be more generic than"},{"line_number":164,"context_line":"  proposed (for example a flag that other hypervisor drivers might want to"},{"line_number":165,"context_line":"  implement as well)? Are the default values ones which will work well in"},{"line_number":166,"context_line":"  real deployments?"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_7148555c","line":164,"updated":"2014-12-04 09:22:32.000000000","message":"for example,","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"73903f852259ba54112c1c5fcf734ee93e78fb38","unresolved":false,"context_lines":[{"line_number":161,"context_line":"that have not already been mentioned, such as:"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"* What config options are being added? Should they be more generic than"},{"line_number":164,"context_line":"  proposed (for example a flag that other hypervisor drivers might want to"},{"line_number":165,"context_line":"  implement as well)? Are the default values ones which will work well in"},{"line_number":166,"context_line":"  real deployments?"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_1650d02a","line":164,"in_reply_to":"5a890539_7148555c","updated":"2014-12-04 20:37:44.000000000","message":"Done","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":13082,"name":"Irina","email":"ipovolotskaya@mirantis.com","username":"ipovolotskaya"},"change_message_id":"bb7e9b975adab4eaed84ddbae2063ac34459b266","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"* What config options are being added? Should they be more generic than"},{"line_number":164,"context_line":"  proposed (for example a flag that other hypervisor drivers might want to"},{"line_number":165,"context_line":"  implement as well)? Are the default values ones which will work well in"},{"line_number":166,"context_line":"  real deployments?"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"  The OTP driver should be specified in the Keystone configuration file."}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_d1782991","line":165,"updated":"2014-12-04 09:22:32.000000000","message":"what do you mean by \u0027ones\u0027 here? are the default values the only ones that will work well in real deployments?","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"73903f852259ba54112c1c5fcf734ee93e78fb38","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"* What config options are being added? Should they be more generic than"},{"line_number":164,"context_line":"  proposed (for example a flag that other hypervisor drivers might want to"},{"line_number":165,"context_line":"  implement as well)? Are the default values ones which will work well in"},{"line_number":166,"context_line":"  real deployments?"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"  The OTP driver should be specified in the Keystone configuration file."}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_5635f8f4","line":165,"in_reply_to":"5a890539_d1782991","updated":"2014-12-04 20:37:44.000000000","message":"This was taken from template.","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":13082,"name":"Irina","email":"ipovolotskaya@mirantis.com","username":"ipovolotskaya"},"change_message_id":"bb7e9b975adab4eaed84ddbae2063ac34459b266","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"  The OTP driver should be specified in the Keystone configuration file."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"* Is this a change that takes immediate effect after its merged, or is it"},{"line_number":171,"context_line":"  something that has to be explicitly enabled?"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"  This would be an opt-in feature and not enabled by default."}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_915a211c","line":170,"updated":"2014-12-04 09:22:32.000000000","message":"after it is merged","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"73903f852259ba54112c1c5fcf734ee93e78fb38","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"  The OTP driver should be specified in the Keystone configuration file."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"* Is this a change that takes immediate effect after its merged, or is it"},{"line_number":171,"context_line":"  something that has to be explicitly enabled?"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"  This would be an opt-in feature and not enabled by default."}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_963be0e8","line":170,"in_reply_to":"5a890539_915a211c","updated":"2014-12-04 20:37:44.000000000","message":"This was taken from template","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"c0712693613e5007648de707f27249e3fabb1ad7","unresolved":false,"context_lines":[{"line_number":197,"context_line":"* Add a new One-time password authentication driver"},{"line_number":198,"context_line":"* Add a new multi-factor auth-plugin"},{"line_number":199,"context_line":"* Add resource to setup multi-factor for a user"},{"line_number":200,"context_line":"* Add/Update resource to toggle MFA enforcement for domains or projects."},{"line_number":201,"context_line":"* Document the process for setting up multi-factor deployment"},{"line_number":202,"context_line":"* Document the process for setting up a users multi-factor account"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_ea0623cd","line":200,"updated":"2014-12-03 21:05:24.000000000","message":"Need to be clear that you won\u0027t break backward compatibility in an API when you implement this. Please make this more clear in the spec","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"73903f852259ba54112c1c5fcf734ee93e78fb38","unresolved":false,"context_lines":[{"line_number":197,"context_line":"* Add a new One-time password authentication driver"},{"line_number":198,"context_line":"* Add a new multi-factor auth-plugin"},{"line_number":199,"context_line":"* Add resource to setup multi-factor for a user"},{"line_number":200,"context_line":"* Add/Update resource to toggle MFA enforcement for domains or projects."},{"line_number":201,"context_line":"* Document the process for setting up multi-factor deployment"},{"line_number":202,"context_line":"* Document the process for setting up a users multi-factor account"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_f6726448","line":200,"in_reply_to":"5a890539_ea0623cd","updated":"2014-12-04 20:37:44.000000000","message":"Done","commit_id":"966710dafcfed819053acfec50a76ac52a26a057"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"da375b715778f0171c77a4c3e018c60c168cacff","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Proposed Change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"This implementation does not require to use of an external system to provide"},{"line_number":40,"context_line":"the second authentication method."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Implemented OTP driver using TOTP that is compatible with Google Authenticator."}],"source_content_type":"text/x-rst","patch_set":15,"id":"5a890539_d5d7febe","line":39,"updated":"2014-12-05 15:26:37.000000000","message":"s/to/the/","commit_id":"d2a151d2c7862d6b641933480ad579233b7e38a1"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"cb9c5e0560c7ec3b7788e46f204230deb5a84504","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Proposed Change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"This implementation does not require to use of an external system to provide"},{"line_number":40,"context_line":"the second authentication method."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Implemented OTP driver using TOTP that is compatible with Google Authenticator."}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_10d7c8c2","line":39,"in_reply_to":"5a890539_d5d7febe","updated":"2014-12-08 16:27:48.000000000","message":"Done","commit_id":"d2a151d2c7862d6b641933480ad579233b7e38a1"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"129babadebe3bf51563d5dbe7a7843df1b606750","unresolved":false,"context_lines":[{"line_number":39,"context_line":"This implementation does not require to use of an external system to provide"},{"line_number":40,"context_line":"the second authentication method."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Implemented OTP driver using TOTP that is compatible with Google Authenticator."},{"line_number":43,"context_line":"Make implementation \"pluggable\" to allow other implementations with different"},{"line_number":44,"context_line":"MFA requirements for different user sets."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_3674d59b","line":42,"updated":"2014-12-07 19:12:53.000000000","message":"(nit) \"Implemented\" -\u003e \"Implement\"","commit_id":"d2a151d2c7862d6b641933480ad579233b7e38a1"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"cb9c5e0560c7ec3b7788e46f204230deb5a84504","unresolved":false,"context_lines":[{"line_number":39,"context_line":"This implementation does not require to use of an external system to provide"},{"line_number":40,"context_line":"the second authentication method."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Implemented OTP driver using TOTP that is compatible with Google Authenticator."},{"line_number":43,"context_line":"Make implementation \"pluggable\" to allow other implementations with different"},{"line_number":44,"context_line":"MFA requirements for different user sets."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_90e2d89d","line":42,"in_reply_to":"3a961159_3674d59b","updated":"2014-12-08 16:27:48.000000000","message":"Done","commit_id":"d2a151d2c7862d6b641933480ad579233b7e38a1"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"129babadebe3bf51563d5dbe7a7843df1b606750","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Implemented OTP driver using TOTP that is compatible with Google Authenticator."},{"line_number":43,"context_line":"Make implementation \"pluggable\" to allow other implementations with different"},{"line_number":44,"context_line":"MFA requirements for different user sets."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Store metadata that specifies if MFA should be enforced for project, domain and"},{"line_number":47,"context_line":"users, and store OTP secret: store them in Barbican or encrypt in data store"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_b667e5e9","line":44,"updated":"2014-12-07 19:12:53.000000000","message":"Is this providing a template for alternative MFA auth plugins or a config provided by the auth plugin or something in Keystone server itself?","commit_id":"d2a151d2c7862d6b641933480ad579233b7e38a1"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"cb9c5e0560c7ec3b7788e46f204230deb5a84504","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Implemented OTP driver using TOTP that is compatible with Google Authenticator."},{"line_number":43,"context_line":"Make implementation \"pluggable\" to allow other implementations with different"},{"line_number":44,"context_line":"MFA requirements for different user sets."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Store metadata that specifies if MFA should be enforced for project, domain and"},{"line_number":47,"context_line":"users, and store OTP secret: store them in Barbican or encrypt in data store"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_b34d1e75","line":44,"in_reply_to":"3a961159_b667e5e9","updated":"2014-12-08 16:27:48.000000000","message":"Idea is to provide an interface(driver) that a deployer can override to implement MFA with their own requirements and a configuration to specify the driver to use.","commit_id":"d2a151d2c7862d6b641933480ad579233b7e38a1"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"129babadebe3bf51563d5dbe7a7843df1b606750","unresolved":false,"context_lines":[{"line_number":50,"context_line":"An admin should be able to specify if a user needs to use MFA on a project or"},{"line_number":51,"context_line":"domain.  A user must authenticate using 2-step verification when MFA is"},{"line_number":52,"context_line":"enforced for a user, domain or project; otherwise, the user will receive an"},{"line_number":53,"context_line":"unauthorized response."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"A user must authenticate using the 2nd factor if MFA is enabled for enforcement"},{"line_number":56,"context_line":"for the user, the domain in which the user-belongs, or the project that the"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_1648b95a","line":53,"updated":"2014-12-07 19:12:53.000000000","message":"Is this handled by the plugin or by Keystone proper?","commit_id":"d2a151d2c7862d6b641933480ad579233b7e38a1"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"cb9c5e0560c7ec3b7788e46f204230deb5a84504","unresolved":false,"context_lines":[{"line_number":50,"context_line":"An admin should be able to specify if a user needs to use MFA on a project or"},{"line_number":51,"context_line":"domain.  A user must authenticate using 2-step verification when MFA is"},{"line_number":52,"context_line":"enforced for a user, domain or project; otherwise, the user will receive an"},{"line_number":53,"context_line":"unauthorized response."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"A user must authenticate using the 2nd factor if MFA is enabled for enforcement"},{"line_number":56,"context_line":"for the user, the domain in which the user-belongs, or the project that the"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_d3a0eaf6","line":53,"in_reply_to":"3a961159_1648b95a","updated":"2014-12-08 16:27:48.000000000","message":"It could handled by either one.  Maybe store in plugin to allow someone to override the behavior.","commit_id":"d2a151d2c7862d6b641933480ad579233b7e38a1"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"129babadebe3bf51563d5dbe7a7843df1b606750","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"A user must authenticate using the 2nd factor if MFA is enabled for enforcement"},{"line_number":56,"context_line":"for the user, the domain in which the user-belongs, or the project that the"},{"line_number":57,"context_line":"user has access to."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Example request::"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_b6ae05e6","line":57,"updated":"2014-12-07 19:12:53.000000000","message":"Is this something that will need to be stored as a first-class attribute on the user, project, or domain? \n\nThis is an implementation question and doesn\u0027t need to be in the spec itself, but please do not rely on the \"Extra\" fields.","commit_id":"d2a151d2c7862d6b641933480ad579233b7e38a1"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"cb9c5e0560c7ec3b7788e46f204230deb5a84504","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"A user must authenticate using the 2nd factor if MFA is enabled for enforcement"},{"line_number":56,"context_line":"for the user, the domain in which the user-belongs, or the project that the"},{"line_number":57,"context_line":"user has access to."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Example request::"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_33c4ce91","line":57,"in_reply_to":"3a961159_b6ae05e6","updated":"2014-12-08 16:27:48.000000000","message":"I would prefer to store it as a first-class attribute.  I was planning on storing it on its own table based on previous feedback I got from this spec.","commit_id":"d2a151d2c7862d6b641933480ad579233b7e38a1"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"129babadebe3bf51563d5dbe7a7843df1b606750","unresolved":false,"context_lines":[{"line_number":81,"context_line":"              }"},{"line_number":82,"context_line":"          }"},{"line_number":83,"context_line":"      }"},{"line_number":84,"context_line":"  }"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Create a new \"password\" auth plugin to enforce multi-factor authentication."},{"line_number":87,"context_line":"The plugin can be swapped in by updating Keystone configuration."}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_96f829e7","line":84,"updated":"2014-12-07 19:12:53.000000000","message":"This could also be done in the same manner as IPA does it (this is based on a conversation with nathan kinder I had):\n\nPassword (where OTP is required/enabled) is simply a concatenated string of \"\u003cOTP Code\u003e\u003cPassword\u003e\". Since the OTP codes are a fixed length they can be split off and validated independently from the password. \n\nThis has the added benefit of allowing for the same UX when utilizing FreeIPA (or similar) system to the backend where it expects the OTP value/password to be concatenated.\n\nIf a backend requires OTP to be managed separately, the auth plugin can handle the split and validation.","commit_id":"d2a151d2c7862d6b641933480ad579233b7e38a1"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"cb9c5e0560c7ec3b7788e46f204230deb5a84504","unresolved":false,"context_lines":[{"line_number":81,"context_line":"              }"},{"line_number":82,"context_line":"          }"},{"line_number":83,"context_line":"      }"},{"line_number":84,"context_line":"  }"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Create a new \"password\" auth plugin to enforce multi-factor authentication."},{"line_number":87,"context_line":"The plugin can be swapped in by updating Keystone configuration."}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_b34a7e81","line":84,"in_reply_to":"3a961159_96f829e7","updated":"2014-12-08 16:27:48.000000000","message":"I don\u0027t think this would work for MFA.  For this spec there is only a single MFA implementation, but that wouldn\u0027t necessarily be the case in the future.\n\nIf a cloud provider has multiple MFA options available: TOTP, SMS, backup codes, how would keystone know what the user intent is?\n\nThe size of OTP code isn\u0027t guaranteed to be the same for all implementations.","commit_id":"d2a151d2c7862d6b641933480ad579233b7e38a1"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"129babadebe3bf51563d5dbe7a7843df1b606750","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"For the initial implementation, when a user gets MFA enabled, the users"},{"line_number":94,"context_line":"previous tokens would still be valid.  Services that only want to allow MFA"},{"line_number":95,"context_line":"tokens can use the methods list to verify OTP was used."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Add ability to see MFA algorithms available for a specific Keystone deployment."},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_f64a4d54","line":95,"updated":"2014-12-07 19:12:53.000000000","message":"Is this a change to the token data itself to indicate OTP was used? Does this require a corresponding change to either OpenStack policy.py (enforcement engine) or keystone middleware?","commit_id":"d2a151d2c7862d6b641933480ad579233b7e38a1"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"cb9c5e0560c7ec3b7788e46f204230deb5a84504","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"For the initial implementation, when a user gets MFA enabled, the users"},{"line_number":94,"context_line":"previous tokens would still be valid.  Services that only want to allow MFA"},{"line_number":95,"context_line":"tokens can use the methods list to verify OTP was used."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Add ability to see MFA algorithms available for a specific Keystone deployment."},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_f6f31408","line":95,"in_reply_to":"3a961159_f64a4d54","updated":"2014-12-08 16:27:48.000000000","message":"Other services could chose to only allow access to a user that authenticated using MFA.  This would be a change in the policy.json file, and maybe policy engine if capability is not there yet.","commit_id":"d2a151d2c7862d6b641933480ad579233b7e38a1"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"129babadebe3bf51563d5dbe7a7843df1b606750","unresolved":false,"context_lines":[{"line_number":146,"context_line":"Other End User Impact"},{"line_number":147,"context_line":"---------------------"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"It may be more difficult for users to do automation."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Performance Impact"},{"line_number":152,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_362695bb","line":149,"updated":"2014-12-07 19:12:53.000000000","message":"Generally speaking this is what a service user with a limited delegation of trust should be used for, not a OTP enabled user-account.","commit_id":"d2a151d2c7862d6b641933480ad579233b7e38a1"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"cb9c5e0560c7ec3b7788e46f204230deb5a84504","unresolved":false,"context_lines":[{"line_number":146,"context_line":"Other End User Impact"},{"line_number":147,"context_line":"---------------------"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"It may be more difficult for users to do automation."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Performance Impact"},{"line_number":152,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_735576c5","line":149,"in_reply_to":"3a961159_362695bb","updated":"2014-12-08 16:27:48.000000000","message":"Correct,  someone using keystone, that was using username/password for automation would now have to use delegation instead.","commit_id":"d2a151d2c7862d6b641933480ad579233b7e38a1"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"129babadebe3bf51563d5dbe7a7843df1b606750","unresolved":false,"context_lines":[{"line_number":164,"context_line":"  implement as well)? Are the default values ones which will work well in"},{"line_number":165,"context_line":"  real deployments?"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"  The OTP driver should be specified in the Keystone configuration file."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"* Is this a change that takes immediate effect after its merged, or is it"},{"line_number":170,"context_line":"  something that has to be explicitly enabled?"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_b639a5da","line":167,"updated":"2014-12-07 19:12:53.000000000","message":"Is this a new config section? is this part of the auth plugin [provided by the plugin]? There is a way to dynamically create config groups (e.g. specific to that plugin) with oslo.config.","commit_id":"d2a151d2c7862d6b641933480ad579233b7e38a1"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"cb9c5e0560c7ec3b7788e46f204230deb5a84504","unresolved":false,"context_lines":[{"line_number":164,"context_line":"  implement as well)? Are the default values ones which will work well in"},{"line_number":165,"context_line":"  real deployments?"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"  The OTP driver should be specified in the Keystone configuration file."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"* Is this a change that takes immediate effect after its merged, or is it"},{"line_number":170,"context_line":"  something that has to be explicitly enabled?"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a961159_d3a62ac1","line":167,"in_reply_to":"3a961159_b639a5da","updated":"2014-12-08 16:27:48.000000000","message":"This could be additional config options under the auth section.","commit_id":"d2a151d2c7862d6b641933480ad579233b7e38a1"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"76ea1fc2bc40c7b679f7295d29fb7f67c0bf9d88","unresolved":false,"context_lines":[{"line_number":62,"context_line":"      \"auth\": {"},{"line_number":63,"context_line":"          \"identity\": {"},{"line_number":64,"context_line":"              \"methods\": ["},{"line_number":65,"context_line":"                  \"password\", \"passcode\""},{"line_number":66,"context_line":"              ],"},{"line_number":67,"context_line":"              \"password\": {"},{"line_number":68,"context_line":"                  \"user\": {"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3a961159_5c010dae","line":65,"updated":"2014-12-10 21:16:48.000000000","message":"i\u0027m not sure what the difference is between password and passcode, but \"password\", \"otp\" would be much more clear. or even be more verbose \"one-time-password\"","commit_id":"02b97876aa926629a76392ac75ce87ccee87bde9"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"e6ed494595ad63737a10a9df9e79fb586a5b33e0","unresolved":false,"context_lines":[{"line_number":62,"context_line":"      \"auth\": {"},{"line_number":63,"context_line":"          \"identity\": {"},{"line_number":64,"context_line":"              \"methods\": ["},{"line_number":65,"context_line":"                  \"password\", \"passcode\""},{"line_number":66,"context_line":"              ],"},{"line_number":67,"context_line":"              \"password\": {"},{"line_number":68,"context_line":"                  \"user\": {"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3a961159_b8672b4c","line":65,"in_reply_to":"3a961159_5c010dae","updated":"2014-12-12 02:39:57.000000000","message":"Done","commit_id":"02b97876aa926629a76392ac75ce87ccee87bde9"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"76ea1fc2bc40c7b679f7295d29fb7f67c0bf9d88","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                      \"password\": \"password\""},{"line_number":71,"context_line":"                  }"},{"line_number":72,"context_line":"              },"},{"line_number":73,"context_line":"              \"passcode\": {"},{"line_number":74,"context_line":"                  \"type\": \"TOTP\","},{"line_number":75,"context_line":"                  \"secret\": \"12345\""},{"line_number":76,"context_line":"              }"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3a961159_bc8f5129","line":73,"updated":"2014-12-10 21:16:48.000000000","message":"same issue: \"otp\" etc","commit_id":"02b97876aa926629a76392ac75ce87ccee87bde9"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"e6ed494595ad63737a10a9df9e79fb586a5b33e0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                      \"password\": \"password\""},{"line_number":71,"context_line":"                  }"},{"line_number":72,"context_line":"              },"},{"line_number":73,"context_line":"              \"passcode\": {"},{"line_number":74,"context_line":"                  \"type\": \"TOTP\","},{"line_number":75,"context_line":"                  \"secret\": \"12345\""},{"line_number":76,"context_line":"              }"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3a961159_f85d337a","line":73,"in_reply_to":"3a961159_bc8f5129","updated":"2014-12-12 02:39:57.000000000","message":"Done","commit_id":"02b97876aa926629a76392ac75ce87ccee87bde9"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"76ea1fc2bc40c7b679f7295d29fb7f67c0bf9d88","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The auth plugin will require a user to specify both their username and password"},{"line_number":90,"context_line":"along with a client-generated OTP.  The plugin will then verify the OTP is"},{"line_number":91,"context_line":"valid along with the user credentials."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"For the initial implementation, when a user gets MFA enabled, the users"},{"line_number":94,"context_line":"previous tokens would still be valid.  Services that only want to allow MFA"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3a961159_1c74e566","line":91,"updated":"2014-12-10 21:16:48.000000000","message":"morgan disagrees with this point - that one plugin is responsible for handling both methods together. instead, the two methods would be combined in the API and handled by a single (new) auth plugin.\n\ni didn\u0027t want to, but i agree with morgan.","commit_id":"02b97876aa926629a76392ac75ce87ccee87bde9"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"e6ed494595ad63737a10a9df9e79fb586a5b33e0","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The auth plugin will require a user to specify both their username and password"},{"line_number":90,"context_line":"along with a client-generated OTP.  The plugin will then verify the OTP is"},{"line_number":91,"context_line":"valid along with the user credentials."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"For the initial implementation, when a user gets MFA enabled, the users"},{"line_number":94,"context_line":"previous tokens would still be valid.  Services that only want to allow MFA"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3a961159_f83e13d9","line":91,"in_reply_to":"3a961159_1c74e566","updated":"2014-12-12 02:39:57.000000000","message":"Done","commit_id":"02b97876aa926629a76392ac75ce87ccee87bde9"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"76ea1fc2bc40c7b679f7295d29fb7f67c0bf9d88","unresolved":false,"context_lines":[{"line_number":199,"context_line":"* Add/Update resource to toggle MFA enforcement for domains or projects without"},{"line_number":200,"context_line":"  breaking backwards compatibilty."},{"line_number":201,"context_line":"* Document the process for setting up multi-factor deployment"},{"line_number":202,"context_line":"* Document the process for setting up a users multi-factor account"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"Dependencies"},{"line_number":205,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3a961159_df55effa","line":202,"updated":"2014-12-10 21:16:48.000000000","message":"add a work item that we need to address the funky configuration required to implement a plugin that handles multiple authentication methods:\n\n  [auth]\n  methods \u003d password, otp\n  password \u003d pkg.path.Plugin\n  otp \u003d pkg.path.Plugin\n  otp_name \u003d ?!","commit_id":"02b97876aa926629a76392ac75ce87ccee87bde9"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"e6ed494595ad63737a10a9df9e79fb586a5b33e0","unresolved":false,"context_lines":[{"line_number":199,"context_line":"* Add/Update resource to toggle MFA enforcement for domains or projects without"},{"line_number":200,"context_line":"  breaking backwards compatibilty."},{"line_number":201,"context_line":"* Document the process for setting up multi-factor deployment"},{"line_number":202,"context_line":"* Document the process for setting up a users multi-factor account"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"Dependencies"},{"line_number":205,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3a961159_d8e6b7af","line":202,"in_reply_to":"3a961159_df55effa","updated":"2014-12-12 02:39:57.000000000","message":"Done","commit_id":"02b97876aa926629a76392ac75ce87ccee87bde9"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"e79541636cd400450230b3571ebaeb539db87ae6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"(OTP) that is time-based (TOTP), which has no service providers and can be"},{"line_number":16,"context_line":"implemented fully in the open."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"In our design we propose to make one time password \"pluggable\" to enable other"},{"line_number":19,"context_line":"implementations like HMAC-based password (HOTP), RSA or other vendor"},{"line_number":20,"context_line":"implementations with different requirements."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_5115fd98","line":18,"updated":"2015-01-19 06:08:49.000000000","message":"Currently, Keystone auth framework is \"pluggable\". Do we have a legitimate reason to introduce another one?","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"af3c5129251d97054f8735aea1bee58d3da0d82e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"(OTP) that is time-based (TOTP), which has no service providers and can be"},{"line_number":16,"context_line":"implemented fully in the open."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"In our design we propose to make one time password \"pluggable\" to enable other"},{"line_number":19,"context_line":"implementations like HMAC-based password (HOTP), RSA or other vendor"},{"line_number":20,"context_line":"implementations with different requirements."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"9a8ffd7b_8584240b","line":18,"in_reply_to":"3a961159_5115fd98","updated":"2015-12-02 17:03:41.000000000","message":"Done","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"e79541636cd400450230b3571ebaeb539db87ae6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"implementations with different requirements."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"The algorithm proposed is already being used by Google for their multi-factor"},{"line_number":23,"context_line":"authentication."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Problem Description"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_910be57a","line":23,"updated":"2015-01-19 06:08:49.000000000","message":"I presume you mean Google Authenticator?","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"af3c5129251d97054f8735aea1bee58d3da0d82e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"implementations with different requirements."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"The algorithm proposed is already being used by Google for their multi-factor"},{"line_number":23,"context_line":"authentication."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Problem Description"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9a8ffd7b_c5e30cd8","line":23,"in_reply_to":"3a961159_910be57a","updated":"2015-12-02 17:03:41.000000000","message":"Correct","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"7144679755368f20c7db1b4185858e12fdee95bd","unresolved":false,"context_lines":[{"line_number":40,"context_line":"the second authentication method."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Implement OTP driver using TOTP that is compatible with Google Authenticator."},{"line_number":43,"context_line":"Make implementation \"pluggable\" to allow other implementations with different"},{"line_number":44,"context_line":"MFA requirements for different user sets."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Store metadata that specifies if MFA should be enforced for project, domain and"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_0eef071f","line":43,"updated":"2014-12-22 17:11:53.000000000","message":"So, no 3rd party libraries are going to be used, right?","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"6ea7381fe2d3293c22114c77534fe7de497336da","unresolved":false,"context_lines":[{"line_number":40,"context_line":"the second authentication method."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Implement OTP driver using TOTP that is compatible with Google Authenticator."},{"line_number":43,"context_line":"Make implementation \"pluggable\" to allow other implementations with different"},{"line_number":44,"context_line":"MFA requirements for different user sets."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Store metadata that specifies if MFA should be enforced for project, domain and"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_42e4c60c","line":43,"in_reply_to":"3a961159_0eef071f","updated":"2015-01-05 19:37:26.000000000","message":"I do not have plans to use a third party library.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"e79541636cd400450230b3571ebaeb539db87ae6","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Make implementation \"pluggable\" to allow other implementations with different"},{"line_number":44,"context_line":"MFA requirements for different user sets."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Store metadata that specifies if MFA should be enforced for project, domain and"},{"line_number":47,"context_line":"users, and store OTP secret: store them in Barbican or encrypt in data store"},{"line_number":48,"context_line":"with filing encryption key in keystone.conf."},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_918205c5","line":46,"updated":"2015-01-19 06:08:49.000000000","message":"Wow, that would require a spec in itself as this fundamentally change how we manage these resources.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"af3c5129251d97054f8735aea1bee58d3da0d82e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Make implementation \"pluggable\" to allow other implementations with different"},{"line_number":44,"context_line":"MFA requirements for different user sets."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Store metadata that specifies if MFA should be enforced for project, domain and"},{"line_number":47,"context_line":"users, and store OTP secret: store them in Barbican or encrypt in data store"},{"line_number":48,"context_line":"with filing encryption key in keystone.conf."},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"9a8ffd7b_45f71c8b","line":46,"in_reply_to":"3a961159_918205c5","updated":"2015-12-02 17:03:41.000000000","message":"This should only affect the password auth plugin when authenticating.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"e79541636cd400450230b3571ebaeb539db87ae6","unresolved":false,"context_lines":[{"line_number":47,"context_line":"users, and store OTP secret: store them in Barbican or encrypt in data store"},{"line_number":48,"context_line":"with filing encryption key in keystone.conf."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"An admin should be able to specify if a user needs to use MFA on a project or"},{"line_number":51,"context_line":"domain.  A user must authenticate using 2-step verification when MFA is"},{"line_number":52,"context_line":"enforced for a user, domain or project; otherwise, the user will receive an"},{"line_number":53,"context_line":"unauthorized response."}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_b16c6137","line":50,"updated":"2015-01-19 06:08:49.000000000","message":"Have you consider how clients like Horizon will make use of this?","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"af3c5129251d97054f8735aea1bee58d3da0d82e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"users, and store OTP secret: store them in Barbican or encrypt in data store"},{"line_number":48,"context_line":"with filing encryption key in keystone.conf."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"An admin should be able to specify if a user needs to use MFA on a project or"},{"line_number":51,"context_line":"domain.  A user must authenticate using 2-step verification when MFA is"},{"line_number":52,"context_line":"enforced for a user, domain or project; otherwise, the user will receive an"},{"line_number":53,"context_line":"unauthorized response."}],"source_content_type":"text/x-rst","patch_set":19,"id":"9a8ffd7b_ab757798","line":50,"in_reply_to":"3a961159_b16c6137","updated":"2015-12-02 17:03:41.000000000","message":"The api should support calls that help horizon setup mfa.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"e79541636cd400450230b3571ebaeb539db87ae6","unresolved":false,"context_lines":[{"line_number":72,"context_line":"              },"},{"line_number":73,"context_line":"              \"one-time-password\": {"},{"line_number":74,"context_line":"                  \"type\": \"TOTP\","},{"line_number":75,"context_line":"                  \"secret\": \"12345\""},{"line_number":76,"context_line":"              }"},{"line_number":77,"context_line":"          },"},{"line_number":78,"context_line":"          \"scope\": {"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_f1726910","line":75,"updated":"2015-01-19 06:08:49.000000000","message":"This is weird. Password, in this case, is usually consist of pin and token code. What is \"secret\"?","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"af3c5129251d97054f8735aea1bee58d3da0d82e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"              },"},{"line_number":73,"context_line":"              \"one-time-password\": {"},{"line_number":74,"context_line":"                  \"type\": \"TOTP\","},{"line_number":75,"context_line":"                  \"secret\": \"12345\""},{"line_number":76,"context_line":"              }"},{"line_number":77,"context_line":"          },"},{"line_number":78,"context_line":"          \"scope\": {"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9a8ffd7b_eb5fff0c","line":75,"in_reply_to":"3a961159_f1726910","updated":"2015-12-02 17:03:41.000000000","message":"I updated this to passcode.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"7144679755368f20c7db1b4185858e12fdee95bd","unresolved":false,"context_lines":[{"line_number":82,"context_line":"          }"},{"line_number":83,"context_line":"      }"},{"line_number":84,"context_line":"  }"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Create a new \"password\" auth plugin to enforce multi-factor authentication."},{"line_number":87,"context_line":"The plugin can be swapped in by updating Keystone configuration."},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_0e3d478f","line":85,"updated":"2014-12-22 17:11:53.000000000","message":"Even with MFA client would simply call Keystone only once with HTTP request like showed above, right?","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"6ea7381fe2d3293c22114c77534fe7de497336da","unresolved":false,"context_lines":[{"line_number":82,"context_line":"          }"},{"line_number":83,"context_line":"      }"},{"line_number":84,"context_line":"  }"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Create a new \"password\" auth plugin to enforce multi-factor authentication."},{"line_number":87,"context_line":"The plugin can be swapped in by updating Keystone configuration."},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_629b8273","line":85,"in_reply_to":"3a961159_0e3d478f","updated":"2015-01-05 19:37:26.000000000","message":"The client would make the call like above or make two separate calls: once without a scope to get a token without a scope and another with the scopeless token and one-time-password.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"325f7ee3e36ace479c459b55a9fb614fe61133d6","unresolved":false,"context_lines":[{"line_number":83,"context_line":"      }"},{"line_number":84,"context_line":"  }"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Create a new \"password\" auth plugin to enforce multi-factor authentication."},{"line_number":87,"context_line":"The plugin can be swapped in by updating Keystone configuration."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The auth plugin will require a user to specify both their username and password"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_0edb607c","line":86,"updated":"2014-12-15 07:37:34.000000000","message":"But you are not going to call it \u0027password\u0027 in keystone.conf, are you (like you did in linke 65 for instance).","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"234670c558536884c20c40850bfbc49b819e5ac5","unresolved":false,"context_lines":[{"line_number":83,"context_line":"      }"},{"line_number":84,"context_line":"  }"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Create a new \"password\" auth plugin to enforce multi-factor authentication."},{"line_number":87,"context_line":"The plugin can be swapped in by updating Keystone configuration."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The auth plugin will require a user to specify both their username and password"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_9643d340","line":86,"in_reply_to":"3a961159_0edb607c","updated":"2014-12-15 16:24:23.000000000","message":"password plugin can still be the default one.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"e79541636cd400450230b3571ebaeb539db87ae6","unresolved":false,"context_lines":[{"line_number":86,"context_line":"Create a new \"password\" auth plugin to enforce multi-factor authentication."},{"line_number":87,"context_line":"The plugin can be swapped in by updating Keystone configuration."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The auth plugin will require a user to specify both their username and password"},{"line_number":90,"context_line":"along with a client-generated OTP.  The plugin will then verify the OTP is"},{"line_number":91,"context_line":"valid along with the user credentials.  The two authentication methods would be"},{"line_number":92,"context_line":"combined in the API and handled by a single new auth plugin."}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_ea4992b8","line":89,"updated":"2015-01-19 06:08:49.000000000","message":"to be clear, this is NOT a password. This is really a PIN. Passwords are stored as one-way hash in Keystone backend DB. Not sure if you want to hash the PIN.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"af3c5129251d97054f8735aea1bee58d3da0d82e","unresolved":false,"context_lines":[{"line_number":86,"context_line":"Create a new \"password\" auth plugin to enforce multi-factor authentication."},{"line_number":87,"context_line":"The plugin can be swapped in by updating Keystone configuration."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The auth plugin will require a user to specify both their username and password"},{"line_number":90,"context_line":"along with a client-generated OTP.  The plugin will then verify the OTP is"},{"line_number":91,"context_line":"valid along with the user credentials.  The two authentication methods would be"},{"line_number":92,"context_line":"combined in the API and handled by a single new auth plugin."}],"source_content_type":"text/x-rst","patch_set":19,"id":"9a8ffd7b_6b79cf81","line":89,"in_reply_to":"3a961159_ea4992b8","updated":"2015-12-02 17:03:41.000000000","message":"Yes, this is a new auth plugin that supports passcode.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"86fecd6e8af09580711f8effc0a503485b4cf2ae","unresolved":false,"context_lines":[{"line_number":91,"context_line":"valid along with the user credentials.  The two authentication methods would be"},{"line_number":92,"context_line":"combined in the API and handled by a single new auth plugin."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"For the initial implementation, when a user gets MFA enabled, the users"},{"line_number":95,"context_line":"previous tokens would still be valid.  Services that only want to allow MFA"},{"line_number":96,"context_line":"tokens can use the methods list to verify OTP was used."},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_5df7358c","line":94,"updated":"2015-01-14 23:35:52.000000000","message":"change \"users\" to \"user\u0027s\"","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"af3c5129251d97054f8735aea1bee58d3da0d82e","unresolved":false,"context_lines":[{"line_number":91,"context_line":"valid along with the user credentials.  The two authentication methods would be"},{"line_number":92,"context_line":"combined in the API and handled by a single new auth plugin."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"For the initial implementation, when a user gets MFA enabled, the users"},{"line_number":95,"context_line":"previous tokens would still be valid.  Services that only want to allow MFA"},{"line_number":96,"context_line":"tokens can use the methods list to verify OTP was used."},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"9a8ffd7b_8b7e7368","line":94,"in_reply_to":"3a961159_5df7358c","updated":"2015-12-02 17:03:41.000000000","message":"Done","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"e79541636cd400450230b3571ebaeb539db87ae6","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Add ability to see MFA algorithms available for a specific Keystone deployment."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Authentication ceremony when MFA is required:"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"* User authenticates with valid password and receives unauthorized response"},{"line_number":103,"context_line":"  with unscoped token in header."}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_e59aa36d","line":100,"updated":"2015-01-19 06:08:49.000000000","message":"Depending on the type of MFA you are implementing, you may have to implement other functionalities. For example, some (i.e. SecurID) supports next token code mode.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"af3c5129251d97054f8735aea1bee58d3da0d82e","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Add ability to see MFA algorithms available for a specific Keystone deployment."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Authentication ceremony when MFA is required:"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"* User authenticates with valid password and receives unauthorized response"},{"line_number":103,"context_line":"  with unscoped token in header."}],"source_content_type":"text/x-rst","patch_set":19,"id":"9a8ffd7b_eb529fdd","line":100,"in_reply_to":"3a961159_e59aa36d","updated":"2015-12-02 17:03:41.000000000","message":"This spec is specific to totp and hotp.  Could you elaborate what functionality is missing to alow secureID?","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"86fecd6e8af09580711f8effc0a503485b4cf2ae","unresolved":false,"context_lines":[{"line_number":112,"context_line":"Alternatives"},{"line_number":113,"context_line":"------------"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"None"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Security Impact"},{"line_number":118,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_3d36e951","line":115,"updated":"2015-01-14 23:35:52.000000000","message":"An alternative is to use federation instead.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"af3c5129251d97054f8735aea1bee58d3da0d82e","unresolved":false,"context_lines":[{"line_number":112,"context_line":"Alternatives"},{"line_number":113,"context_line":"------------"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"None"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Security Impact"},{"line_number":118,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":19,"id":"9a8ffd7b_4b3e4b29","line":115,"in_reply_to":"3a961159_3d36e951","updated":"2015-12-02 17:03:41.000000000","message":"This spec is to require a user to have a physical device to verify his credentials using a time based algorithm.  I don\u0027t see how federation is an alternative.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"86fecd6e8af09580711f8effc0a503485b4cf2ae","unresolved":false,"context_lines":[{"line_number":120,"context_line":"Describe any potential security impact on the system.  Some of the items to"},{"line_number":121,"context_line":"consider include:"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"  Yes, a users secret key to generate one-time password will need to be stored."},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_bd41f9a7","line":123,"updated":"2015-01-14 23:35:52.000000000","message":"get rid of the questions since these are examples and put the answers here, along with other security considerations.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"af3c5129251d97054f8735aea1bee58d3da0d82e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"Describe any potential security impact on the system.  Some of the items to"},{"line_number":121,"context_line":"consider include:"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"  Yes, a users secret key to generate one-time password will need to be stored."},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"9a8ffd7b_4b240bc4","line":123,"in_reply_to":"3a961159_bd41f9a7","updated":"2015-12-02 17:03:41.000000000","message":"Done","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"86fecd6e8af09580711f8effc0a503485b4cf2ae","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"* Does this change involve cryptography or hashing?"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"  Yes, the proposed algorithms use cryptography."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"* Does this change require the use of sudo or any elevated privileges?"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_bd6f3927","line":136,"updated":"2015-01-14 23:35:52.000000000","message":"what crypto does it use? Is a crypto library going to be used or is new crypto required?","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"af3c5129251d97054f8735aea1bee58d3da0d82e","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"* Does this change involve cryptography or hashing?"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"  Yes, the proposed algorithms use cryptography."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"* Does this change require the use of sudo or any elevated privileges?"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"9a8ffd7b_263c5ec7","line":136,"in_reply_to":"3a961159_bd6f3927","updated":"2015-12-02 17:03:41.000000000","message":"It uses HMAC to generate a one time password.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"86fecd6e8af09580711f8effc0a503485b4cf2ae","unresolved":false,"context_lines":[{"line_number":175,"context_line":"* What config options are being added? Should they be more generic than"},{"line_number":176,"context_line":"  proposed (for example, a flag that other hypervisor drivers might want to"},{"line_number":177,"context_line":"  implement as well)? Are the default values ones which will work well in"},{"line_number":178,"context_line":"  real deployments?"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"  The OTP driver should be specified in the Keystone configuration file."},{"line_number":181,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_9df7dd59","line":178,"updated":"2015-01-14 23:35:52.000000000","message":"Remove the questions and just put the explanation here.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"af3c5129251d97054f8735aea1bee58d3da0d82e","unresolved":false,"context_lines":[{"line_number":175,"context_line":"* What config options are being added? Should they be more generic than"},{"line_number":176,"context_line":"  proposed (for example, a flag that other hypervisor drivers might want to"},{"line_number":177,"context_line":"  implement as well)? Are the default values ones which will work well in"},{"line_number":178,"context_line":"  real deployments?"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"  The OTP driver should be specified in the Keystone configuration file."},{"line_number":181,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"9a8ffd7b_a69ccec0","line":178,"in_reply_to":"3a961159_9df7dd59","updated":"2015-12-02 17:03:41.000000000","message":"Done","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"86fecd6e8af09580711f8effc0a503485b4cf2ae","unresolved":false,"context_lines":[{"line_number":188,"context_line":"----------------"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"* If the blueprint proposes a change to the driver API, discussion of how"},{"line_number":191,"context_line":"  other backends would implement the feature is required."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"  This change would add a new driver for one time password.  This could be"},{"line_number":194,"context_line":"  updated by other backends that want to use a different implementation."}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_1d9bed17","line":191,"updated":"2015-01-14 23:35:52.000000000","message":"Remove the questions and just put the explanation here.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"af3c5129251d97054f8735aea1bee58d3da0d82e","unresolved":false,"context_lines":[{"line_number":188,"context_line":"----------------"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"* If the blueprint proposes a change to the driver API, discussion of how"},{"line_number":191,"context_line":"  other backends would implement the feature is required."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"  This change would add a new driver for one time password.  This could be"},{"line_number":194,"context_line":"  updated by other backends that want to use a different implementation."}],"source_content_type":"text/x-rst","patch_set":19,"id":"9a8ffd7b_26c69e9a","line":191,"in_reply_to":"3a961159_1d9bed17","updated":"2015-12-02 17:03:41.000000000","message":"Done","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"325f7ee3e36ace479c459b55a9fb614fe61133d6","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"  [auth]"},{"line_number":204,"context_line":"  methods \u003d password, one-time-password"},{"line_number":205,"context_line":"  password \u003d pkg.path.Plugin"},{"line_number":206,"context_line":"  one-time-password \u003d pkg.path.Plugin"},{"line_number":207,"context_line":"  otp_name \u003d ?!"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_ae408c07","line":205,"updated":"2014-12-15 07:37:34.000000000","message":"this would stop others from using \u0027standard\u0027 password authentication.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"f7b06541dac184a999dc9dd4a5dc54aa49ffb2ac","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"  [auth]"},{"line_number":204,"context_line":"  methods \u003d password, one-time-password"},{"line_number":205,"context_line":"  password \u003d pkg.path.Plugin"},{"line_number":206,"context_line":"  one-time-password \u003d pkg.path.Plugin"},{"line_number":207,"context_line":"  otp_name \u003d ?!"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_37f95d80","line":205,"in_reply_to":"3a961159_061c0ec1","updated":"2015-01-08 11:13:49.000000000","message":"Why would you think adding itp-password (new plugin) should be backwards compatible?","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"a24371ac179b12d519f7f38708e50de3fe4d3b85","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"  [auth]"},{"line_number":204,"context_line":"  methods \u003d password, one-time-password"},{"line_number":205,"context_line":"  password \u003d pkg.path.Plugin"},{"line_number":206,"context_line":"  one-time-password \u003d pkg.path.Plugin"},{"line_number":207,"context_line":"  otp_name \u003d ?!"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_4caabf86","line":205,"in_reply_to":"3a961159_1629a389","updated":"2014-12-15 16:53:51.000000000","message":"So, why not define new plugin, say \u0027otp-password\u0027 that would accept password, but at the same time expect user to provide passcode in a reasonable time, say 5 minutes. \nUser would then indicate by specifying methods: [\u0027otp-password\u0027, \u0027otp-passcode\u0027] that he wants to use MFA. Other users would specify methods: [\u0027password\u0027] and we would keep separate authN flows.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"816f1bcf0321b3c416f4a0e4fc0590b93b2fbb7d","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"  [auth]"},{"line_number":204,"context_line":"  methods \u003d password, one-time-password"},{"line_number":205,"context_line":"  password \u003d pkg.path.Plugin"},{"line_number":206,"context_line":"  one-time-password \u003d pkg.path.Plugin"},{"line_number":207,"context_line":"  otp_name \u003d ?!"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_f2443c74","line":205,"in_reply_to":"3a961159_37f95d80","updated":"2015-01-08 16:27:11.000000000","message":"The way you described using \u0027otp-password\u0027 would not work for existing clients since they do not know \u0027otp-password\u0027 exists.\n\nYou would also not be able to force users to use MFA since the \u0027password\u0027 plugin would always give the user a token.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"e6e886286bd7d9dbc363d19fd9d2cde430204141","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"  [auth]"},{"line_number":204,"context_line":"  methods \u003d password, one-time-password"},{"line_number":205,"context_line":"  password \u003d pkg.path.Plugin"},{"line_number":206,"context_line":"  one-time-password \u003d pkg.path.Plugin"},{"line_number":207,"context_line":"  otp_name \u003d ?!"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_061c0ec1","line":205,"in_reply_to":"3a961159_4caabf86","updated":"2014-12-15 20:50:19.000000000","message":"I think adding otp-password would not be backwards compatible, and you would not be able to force users to use MFA when they only provide \u0027password\u0027.\n\nI think a better approach is to implemented MFA with two plugins:\n- password plugin that inherits from current password plugin but adds additional MFA logic.\n- one-time-password plugin that implements TOTP.\n\nUpdated Example:\n\n  [auth]\n  methods \u003d password, one-time-password\n  password \u003d auth.plugins.otp.Password\n  one-time-password \u003d auth.plugins.otp.OneTimePassword\n\n  base_password \u003d keystone.auth.plugins.password.Password #base class for otp.Password\n  otp_name \u003d one-time-password #name of required otp method in addition to password","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"81df6db69b6eaead2905266fd43fac5b4e6df100","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"  [auth]"},{"line_number":204,"context_line":"  methods \u003d password, one-time-password"},{"line_number":205,"context_line":"  password \u003d pkg.path.Plugin"},{"line_number":206,"context_line":"  one-time-password \u003d pkg.path.Plugin"},{"line_number":207,"context_line":"  otp_name \u003d ?!"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_134620c0","line":205,"in_reply_to":"3a961159_502dfe44","updated":"2015-01-08 23:32:11.000000000","message":"Someone had mentioned earlier that I should not modify the password plugin.\nI think your approach of updating the password to handle MFA enforcement is better.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"234670c558536884c20c40850bfbc49b819e5ac5","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"  [auth]"},{"line_number":204,"context_line":"  methods \u003d password, one-time-password"},{"line_number":205,"context_line":"  password \u003d pkg.path.Plugin"},{"line_number":206,"context_line":"  one-time-password \u003d pkg.path.Plugin"},{"line_number":207,"context_line":"  otp_name \u003d ?!"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_1629a389","line":205,"in_reply_to":"3a961159_ae408c07","updated":"2014-12-15 16:24:23.000000000","message":"I had a discussion of this with Morgan and there is some complexity in configuring keystone with two plugins.\nI added the configuration snippet to illustrate this.\n\nIf a user should be using MFA and authenticates only with password, it is not possible to for the current password plugin to require MFA.\nMorgan suggested to have the MFA plugin handle both password and one-time-password.\nThere will be additional options that might have to be set for the plugin to work, and the snippet illustrates that this needs to be addressed.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"b4e17b3195bd13b5762d48b5ea737efd74b1d54d","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"  [auth]"},{"line_number":204,"context_line":"  methods \u003d password, one-time-password"},{"line_number":205,"context_line":"  password \u003d pkg.path.Plugin"},{"line_number":206,"context_line":"  one-time-password \u003d pkg.path.Plugin"},{"line_number":207,"context_line":"  otp_name \u003d ?!"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_502dfe44","line":205,"in_reply_to":"3a961159_f2443c74","updated":"2015-01-08 22:41:20.000000000","message":"Around line 50 you describe that adming would specify who and on what resource needs MFA. To me, this means that password plugin (and similar) would check if user is required MFA on a certain resource such as project, domain etc.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"f7b06541dac184a999dc9dd4a5dc54aa49ffb2ac","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"* Add a new One-time password authentication driver"},{"line_number":222,"context_line":"* Add a new multi-factor auth-plugin"},{"line_number":223,"context_line":"* Add resource to setup multi-factor for a user"},{"line_number":224,"context_line":"* Add/Update resource to toggle MFA enforcement for domains or projects without"},{"line_number":225,"context_line":"  breaking backwards compatibilty."},{"line_number":226,"context_line":"* Document the process for setting up multi-factor deployment"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_b7138db6","line":223,"updated":"2015-01-08 11:13:49.000000000","message":"I think this will be a new API and this is where user wil receive some data for synchronizing his client with Keystone, right? \n\nFrom the spec i didn\u0027t fully understand - this secret would be kept in Barbican, right? \n\nAn API doc would be nice here.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"816f1bcf0321b3c416f4a0e4fc0590b93b2fbb7d","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"* Add a new One-time password authentication driver"},{"line_number":222,"context_line":"* Add a new multi-factor auth-plugin"},{"line_number":223,"context_line":"* Add resource to setup multi-factor for a user"},{"line_number":224,"context_line":"* Add/Update resource to toggle MFA enforcement for domains or projects without"},{"line_number":225,"context_line":"  breaking backwards compatibilty."},{"line_number":226,"context_line":"* Document the process for setting up multi-factor deployment"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_cd06c51b","line":223,"in_reply_to":"3a961159_b7138db6","updated":"2015-01-08 16:27:11.000000000","message":"I think the secret should be stored in Barbican, but there should also be an option to store it in Keystone instead.\n\nI\u0027ll submit a separate pull request for the identity-api once this spec is approved.","commit_id":"da84808cde684e30cfcd0e7f94f6f0c760a61b21"}],"specs/mitaka/multi-factor-auth.rst":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fc1bffcd1f88b11937d5debc2dd4c9d4ff26255a","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The goal of Multi-factor Authentication (MFA) is to make it more difficult for"},{"line_number":25,"context_line":"an unauthorized user to gain access to an OpenStack resource. If a specific"},{"line_number":26,"context_line":"known password is compromised there is still another barrier before granting"},{"line_number":27,"context_line":"access token."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Currently Keystone only supports \"knowledge factor\" (something the user knows)."}],"source_content_type":"text/x-rst","patch_set":21,"id":"9a8ffd7b_758afc65","line":26,"updated":"2015-12-02 21:29:00.000000000","message":"nit: an access token.","commit_id":"54d6f46a7e4516c92c1651f98c8bc1c66d15ffdb"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"d0e6c28290e1c6e39c528026394a2e4db56c4e12","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The goal of Multi-factor Authentication (MFA) is to make it more difficult for"},{"line_number":25,"context_line":"an unauthorized user to gain access to an OpenStack resource. If a specific"},{"line_number":26,"context_line":"known password is compromised there is still another barrier before granting"},{"line_number":27,"context_line":"access token."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Currently Keystone only supports \"knowledge factor\" (something the user knows)."}],"source_content_type":"text/x-rst","patch_set":21,"id":"7a740942_4d3552f5","line":26,"in_reply_to":"9a8ffd7b_758afc65","updated":"2015-12-04 20:15:14.000000000","message":"Done","commit_id":"54d6f46a7e4516c92c1651f98c8bc1c66d15ffdb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fc1bffcd1f88b11937d5debc2dd4c9d4ff26255a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"encrypt in data store with filing encryption key in keystone.conf."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"An admin should be able to specify if a user needs to use MFA on a project or"},{"line_number":47,"context_line":"domain.  A user must authenticate using 2-step verification when MFA is"},{"line_number":48,"context_line":"enforced for a user, domain or project; otherwise, the user will receive an"},{"line_number":49,"context_line":"unauthorized response."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"9a8ffd7b_55eed8ed","line":47,"updated":"2015-12-02 21:29:00.000000000","message":"Is project  and domain going to be the lowest levels of granularity here? That would require everyone in a project to use 2FA, or everyone in a domain to use 2FA. Can we think of cases where it should be user-by-user?","commit_id":"54d6f46a7e4516c92c1651f98c8bc1c66d15ffdb"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"d0e6c28290e1c6e39c528026394a2e4db56c4e12","unresolved":false,"context_lines":[{"line_number":44,"context_line":"encrypt in data store with filing encryption key in keystone.conf."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"An admin should be able to specify if a user needs to use MFA on a project or"},{"line_number":47,"context_line":"domain.  A user must authenticate using 2-step verification when MFA is"},{"line_number":48,"context_line":"enforced for a user, domain or project; otherwise, the user will receive an"},{"line_number":49,"context_line":"unauthorized response."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"7a740942_704ca570","line":47,"in_reply_to":"9a8ffd7b_55eed8ed","updated":"2015-12-04 20:15:14.000000000","message":"A user should be able to specify if he wants to use mfa.  For an admin to require a user to use mfa would mean the user could not enable / disable it himself and would require an admin to do it.","commit_id":"54d6f46a7e4516c92c1651f98c8bc1c66d15ffdb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fc1bffcd1f88b11937d5debc2dd4c9d4ff26255a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"              ],"},{"line_number":63,"context_line":"              \"password\": {"},{"line_number":64,"context_line":"                  \"user\": {"},{"line_number":65,"context_line":"                      \"id\": \"B95B78B6-7FA0-45B3-8104-C12FB2729CD0\","},{"line_number":66,"context_line":"                      \"password\": \"password\""},{"line_number":67,"context_line":"                  }"},{"line_number":68,"context_line":"              },"}],"source_content_type":"text/x-rst","patch_set":21,"id":"9a8ffd7b_b593845a","line":65,"updated":"2015-12-02 21:29:00.000000000","message":"nit: this could be changed to it\u0027s hex format, just for the sake of consistency.","commit_id":"54d6f46a7e4516c92c1651f98c8bc1c66d15ffdb"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"d0e6c28290e1c6e39c528026394a2e4db56c4e12","unresolved":false,"context_lines":[{"line_number":62,"context_line":"              ],"},{"line_number":63,"context_line":"              \"password\": {"},{"line_number":64,"context_line":"                  \"user\": {"},{"line_number":65,"context_line":"                      \"id\": \"B95B78B6-7FA0-45B3-8104-C12FB2729CD0\","},{"line_number":66,"context_line":"                      \"password\": \"password\""},{"line_number":67,"context_line":"                  }"},{"line_number":68,"context_line":"              },"}],"source_content_type":"text/x-rst","patch_set":21,"id":"7a740942_f041750c","line":65,"in_reply_to":"9a8ffd7b_b593845a","updated":"2015-12-04 20:15:14.000000000","message":"Done","commit_id":"54d6f46a7e4516c92c1651f98c8bc1c66d15ffdb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fc1bffcd1f88b11937d5debc2dd4c9d4ff26255a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  }"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Create a new \"password\" auth plugin to enforce multi-factor authentication."},{"line_number":83,"context_line":"The plugin can be swapped in by updating Keystone configuration."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"The auth plugin will require a user to specify both their username and password"},{"line_number":86,"context_line":"along with a client-generated OTP.  The plugin will then verify the OTP is"}],"source_content_type":"text/x-rst","patch_set":21,"id":"9a8ffd7b_957d201e","line":83,"updated":"2015-12-02 21:29:00.000000000","message":"I assume this would be opt in? If the 2FA password plugin is used then it would *require* 2FA. The default password plugin would still be the one that is used today.","commit_id":"54d6f46a7e4516c92c1651f98c8bc1c66d15ffdb"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"d0e6c28290e1c6e39c528026394a2e4db56c4e12","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  }"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Create a new \"password\" auth plugin to enforce multi-factor authentication."},{"line_number":83,"context_line":"The plugin can be swapped in by updating Keystone configuration."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"The auth plugin will require a user to specify both their username and password"},{"line_number":86,"context_line":"along with a client-generated OTP.  The plugin will then verify the OTP is"}],"source_content_type":"text/x-rst","patch_set":21,"id":"7a740942_30061dcf","line":83,"in_reply_to":"9a8ffd7b_957d201e","updated":"2015-12-04 20:15:14.000000000","message":"The 2FA password plugin would *require* mfa when enabled on the user, required on a project or domain.\n\nWhen required or enabled then it would only require password.","commit_id":"54d6f46a7e4516c92c1651f98c8bc1c66d15ffdb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fc1bffcd1f88b11937d5debc2dd4c9d4ff26255a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"previous tokens would still be valid.  Services that only want to allow MFA"},{"line_number":92,"context_line":"tokens can use the methods list to verify OTP was used."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Add ability to see MFA algorithms available for a specific Keystone deployment."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Authentication ceremony when MFA is required:"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"9a8ffd7b_55c1f82d","line":94,"updated":"2015-12-02 21:29:00.000000000","message":"So, a separate API call?","commit_id":"54d6f46a7e4516c92c1651f98c8bc1c66d15ffdb"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"d0e6c28290e1c6e39c528026394a2e4db56c4e12","unresolved":false,"context_lines":[{"line_number":91,"context_line":"previous tokens would still be valid.  Services that only want to allow MFA"},{"line_number":92,"context_line":"tokens can use the methods list to verify OTP was used."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Add ability to see MFA algorithms available for a specific Keystone deployment."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Authentication ceremony when MFA is required:"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"7a740942_f0abb587","line":94,"in_reply_to":"9a8ffd7b_55c1f82d","updated":"2015-12-04 20:15:14.000000000","message":"Yes","commit_id":"54d6f46a7e4516c92c1651f98c8bc1c66d15ffdb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fc1bffcd1f88b11937d5debc2dd4c9d4ff26255a","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Authentication ceremony when MFA is required:"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* User authenticates with valid password and receives unauthorized response"},{"line_number":99,"context_line":"  with unscoped token in header."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"* User sends second auth request with unscoped token and OTP and receives"}],"source_content_type":"text/x-rst","patch_set":21,"id":"9a8ffd7b_1505b078","line":98,"updated":"2015-12-02 21:29:00.000000000","message":"unscoped?","commit_id":"54d6f46a7e4516c92c1651f98c8bc1c66d15ffdb"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"d0e6c28290e1c6e39c528026394a2e4db56c4e12","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Authentication ceremony when MFA is required:"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* User authenticates with valid password and receives unauthorized response"},{"line_number":99,"context_line":"  with unscoped token in header."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"* User sends second auth request with unscoped token and OTP and receives"}],"source_content_type":"text/x-rst","patch_set":21,"id":"7a740942_f25895fc","line":98,"in_reply_to":"9a8ffd7b_1505b078","updated":"2015-12-04 20:15:14.000000000","message":"Yes, the user would receive an unscoped token when mfa is required, but with an unauthorized response.","commit_id":"54d6f46a7e4516c92c1651f98c8bc1c66d15ffdb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fc1bffcd1f88b11937d5debc2dd4c9d4ff26255a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"Authentication ceremony when MFA is required:"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* User authenticates with valid password and receives unauthorized response"},{"line_number":99,"context_line":"  with unscoped token in header."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"* User sends second auth request with unscoped token and OTP and receives"},{"line_number":102,"context_line":"  scoped token."}],"source_content_type":"text/x-rst","patch_set":21,"id":"9a8ffd7b_f5458c6e","line":99,"updated":"2015-12-02 21:29:00.000000000","message":"The new password plugin will have to recognize this case, allowing the issuance of unscoped tokens. We will have to eliminate a user getting information from unscoped tokens [0].\n\nFor example, if we have MFA enabled and we allow users to get unscoped tokens to use them as a way to do multi-factor. We shouldn\u0027t allow the user to list the projects they can scope to without having an MFA token. I think that would be exposing information without ensuring the user is who they are. If an attacker were able to figure out a user\u0027s password, they would be able to find out what projects they have role assignments on even though MFA is enabled.\n\nJust an edge case we\u0027ll have to keep in mind.\n\n[0] https://github.com/openstack/keystone-specs/blob/master/api/v3/identity-api-v3.rst#get-available-project-scopes","commit_id":"54d6f46a7e4516c92c1651f98c8bc1c66d15ffdb"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"d0e6c28290e1c6e39c528026394a2e4db56c4e12","unresolved":false,"context_lines":[{"line_number":96,"context_line":"Authentication ceremony when MFA is required:"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* User authenticates with valid password and receives unauthorized response"},{"line_number":99,"context_line":"  with unscoped token in header."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"* User sends second auth request with unscoped token and OTP and receives"},{"line_number":102,"context_line":"  scoped token."}],"source_content_type":"text/x-rst","patch_set":21,"id":"7a740942_f27c1574","line":99,"in_reply_to":"9a8ffd7b_f5458c6e","updated":"2015-12-04 20:15:14.000000000","message":"Done","commit_id":"54d6f46a7e4516c92c1651f98c8bc1c66d15ffdb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fc1bffcd1f88b11937d5debc2dd4c9d4ff26255a","unresolved":false,"context_lines":[{"line_number":156,"context_line":"* Deployer would have to specify OTP keystone configuration.  This may be more"},{"line_number":157,"context_line":"  difficult given the current keystone implementation, since the password"},{"line_number":158,"context_line":"  would have to be aware of required OTP methods to reply with an unauthorized"},{"line_number":159,"context_line":"  response."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Example::"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"9a8ffd7b_d01c1668","line":159,"updated":"2015-12-02 21:29:00.000000000","message":"Would either of these impact the developers? These seem more like deployer impacts.","commit_id":"54d6f46a7e4516c92c1651f98c8bc1c66d15ffdb"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"d0e6c28290e1c6e39c528026394a2e4db56c4e12","unresolved":false,"context_lines":[{"line_number":156,"context_line":"* Deployer would have to specify OTP keystone configuration.  This may be more"},{"line_number":157,"context_line":"  difficult given the current keystone implementation, since the password"},{"line_number":158,"context_line":"  would have to be aware of required OTP methods to reply with an unauthorized"},{"line_number":159,"context_line":"  response."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Example::"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"7a740942_92ba7109","line":159,"in_reply_to":"9a8ffd7b_d01c1668","updated":"2015-12-04 20:15:14.000000000","message":"Done","commit_id":"54d6f46a7e4516c92c1651f98c8bc1c66d15ffdb"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"14923bc4dbf69ae880d64288126a660f94c93f05","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Multi-factor Authentication"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp multi-factor-auth \u003chttps://blueprints.launchpad.net/keystone/+spec/multi-factor-auth\u003e`_"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_d724cf60","line":8,"updated":"2015-12-09 01:48:05.000000000","message":"May want to be specific, like\n\nSupport Google Authenticator TOTP Authentication\n\nMFA is a concept, not a specific protocol/technology.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"c75a58e70e90aa755e6225e9ceeebc2962547f11","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Multi-factor Authentication"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp multi-factor-auth \u003chttps://blueprints.launchpad.net/keystone/+spec/multi-factor-auth\u003e`_"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_1810114e","line":8,"in_reply_to":"7a740942_d724cf60","updated":"2015-12-14 19:41:53.000000000","message":"Done","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"14923bc4dbf69ae880d64288126a660f94c93f05","unresolved":false,"context_lines":[{"line_number":11,"context_line":"`bp multi-factor-auth \u003chttps://blueprints.launchpad.net/keystone/+spec/multi-factor-auth\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Multi-Factor Authentication provides a way to authenticate a user using two"},{"line_number":14,"context_line":"independent authentication factors, including a new one-time password algorithm"},{"line_number":15,"context_line":"(OTP) that is time-based (TOTP), which has no service providers and can be"},{"line_number":16,"context_line":"implemented fully in the open."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_37c0b34f","line":14,"updated":"2015-12-09 01:48:05.000000000","message":"s/including .../such as password (something you know) and one time passcode from a physical key fob (something you have)./","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"c75a58e70e90aa755e6225e9ceeebc2962547f11","unresolved":false,"context_lines":[{"line_number":11,"context_line":"`bp multi-factor-auth \u003chttps://blueprints.launchpad.net/keystone/+spec/multi-factor-auth\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Multi-Factor Authentication provides a way to authenticate a user using two"},{"line_number":14,"context_line":"independent authentication factors, including a new one-time password algorithm"},{"line_number":15,"context_line":"(OTP) that is time-based (TOTP), which has no service providers and can be"},{"line_number":16,"context_line":"implemented fully in the open."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_98d40148","line":14,"in_reply_to":"7a740942_37c0b34f","updated":"2015-12-14 19:41:53.000000000","message":"Done","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"14923bc4dbf69ae880d64288126a660f94c93f05","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Multi-Factor Authentication provides a way to authenticate a user using two"},{"line_number":14,"context_line":"independent authentication factors, including a new one-time password algorithm"},{"line_number":15,"context_line":"(OTP) that is time-based (TOTP), which has no service providers and can be"},{"line_number":16,"context_line":"implemented fully in the open."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The algorithm proposed is already being used by Google for their multi-factor"},{"line_number":19,"context_line":"authentication (Google Authenticator)."}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_57c77f63","line":16,"updated":"2015-12-09 01:48:05.000000000","message":"It depends, for example, if you are implementing MFA using RSA SecurID, you need to deal with their provider.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"c75a58e70e90aa755e6225e9ceeebc2962547f11","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Multi-Factor Authentication provides a way to authenticate a user using two"},{"line_number":14,"context_line":"independent authentication factors, including a new one-time password algorithm"},{"line_number":15,"context_line":"(OTP) that is time-based (TOTP), which has no service providers and can be"},{"line_number":16,"context_line":"implemented fully in the open."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The algorithm proposed is already being used by Google for their multi-factor"},{"line_number":19,"context_line":"authentication (Google Authenticator)."}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_18c1f180","line":16,"in_reply_to":"7a740942_57c77f63","updated":"2015-12-14 19:41:53.000000000","message":"This is specific for this implementation, that does not require a service provider.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"14923bc4dbf69ae880d64288126a660f94c93f05","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Problem Description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The goal of Multi-factor Authentication (MFA) is to make it more difficult for"},{"line_number":25,"context_line":"an unauthorized user to gain access to an OpenStack resource. If a specific"},{"line_number":26,"context_line":"known password is compromised there is still another barrier before granting"},{"line_number":27,"context_line":"an access token."}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_17a497b7","line":24,"updated":"2015-12-09 01:48:05.000000000","message":"Multi-Factor Authentication","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"c75a58e70e90aa755e6225e9ceeebc2962547f11","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Problem Description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The goal of Multi-factor Authentication (MFA) is to make it more difficult for"},{"line_number":25,"context_line":"an unauthorized user to gain access to an OpenStack resource. If a specific"},{"line_number":26,"context_line":"known password is compromised there is still another barrier before granting"},{"line_number":27,"context_line":"an access token."}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_983ba19c","line":24,"in_reply_to":"7a740942_17a497b7","updated":"2015-12-14 19:41:53.000000000","message":"Done","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"14923bc4dbf69ae880d64288126a660f94c93f05","unresolved":false,"context_lines":[{"line_number":26,"context_line":"known password is compromised there is still another barrier before granting"},{"line_number":27,"context_line":"an access token."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Currently Keystone only supports \"knowledge factor\" (something the user knows)."},{"line_number":30,"context_line":"The goal of this change is to add a \"possession factor\" (something a user has)."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_d797ef37","line":29,"updated":"2015-12-09 01:48:05.000000000","message":"This is not true. You can absolutely do MFA via 3rd identity providers. For example,\n\n username\n passcode + password","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"c75a58e70e90aa755e6225e9ceeebc2962547f11","unresolved":false,"context_lines":[{"line_number":26,"context_line":"known password is compromised there is still another barrier before granting"},{"line_number":27,"context_line":"an access token."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Currently Keystone only supports \"knowledge factor\" (something the user knows)."},{"line_number":30,"context_line":"The goal of this change is to add a \"possession factor\" (something a user has)."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_18f6d1d7","line":29,"in_reply_to":"7a740942_d797ef37","updated":"2015-12-14 19:41:53.000000000","message":"Done","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1a1a77382f0dd8c4457055d725f4a29771b5b85f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"known password is compromised there is still another barrier before granting"},{"line_number":27,"context_line":"an access token."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Currently Keystone only supports \"knowledge factor\" (something the user knows)."},{"line_number":30,"context_line":"The goal of this change is to add a \"possession factor\" (something a user has)."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_7f3910d8","line":29,"in_reply_to":"7a740942_d797ef37","updated":"2015-12-09 15:16:42.000000000","message":"You could say that this is possible if you have federation setup with an idp, and then enforce MFA through the idp.\n\nWe could say this is solving MFA for keystone without requiring federation.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"14923bc4dbf69ae880d64288126a660f94c93f05","unresolved":false,"context_lines":[{"line_number":27,"context_line":"an access token."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Currently Keystone only supports \"knowledge factor\" (something the user knows)."},{"line_number":30,"context_line":"The goal of this change is to add a \"possession factor\" (something a user has)."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposed Change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_57c3ff37","line":30,"updated":"2015-12-09 01:48:05.000000000","message":"The goal is to support TOTP for locally managed users.\n\nI thought Yahoo also have anther requirement, which is to restrict the auth method a given user, project, or domain can use, no? At least that was how I understood it from Lin at the Keystone meeting.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"c75a58e70e90aa755e6225e9ceeebc2962547f11","unresolved":false,"context_lines":[{"line_number":27,"context_line":"an access token."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Currently Keystone only supports \"knowledge factor\" (something the user knows)."},{"line_number":30,"context_line":"The goal of this change is to add a \"possession factor\" (something a user has)."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposed Change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":22,"id":"5a710552_7cffe534","line":30,"in_reply_to":"7a740942_57c3ff37","updated":"2015-12-14 19:41:53.000000000","message":"Done","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"f6242a9e3d337dccabbc776071e4b0cc59ed93e7","unresolved":false,"context_lines":[{"line_number":27,"context_line":"an access token."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Currently Keystone only supports \"knowledge factor\" (something the user knows)."},{"line_number":30,"context_line":"The goal of this change is to add a \"possession factor\" (something a user has)."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposed Change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_1aa57ab4","line":30,"in_reply_to":"7a740942_57c3ff37","updated":"2015-12-09 23:08:25.000000000","message":"Yes.  Another use case would be securing projects that have access to high security zone by adding another layer of authentication (MFA).\n\nThe proposed solution (line 46) do describe the solution we need.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"14923bc4dbf69ae880d64288126a660f94c93f05","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"This implementation does not require the use of an external system to provide"},{"line_number":36,"context_line":"the second authentication method."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Implement OTP driver using TOTP that is compatible with Google Authenticator."},{"line_number":39,"context_line":"Make implementation \"pluggable\" to allow other implementations with different"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_57da1f18","line":36,"updated":"2015-12-09 01:48:05.000000000","message":"No Barbican integration to manage the shared secret? If we want to manage them locally via the v3 credential APIs, we may not be in compliant as we don\u0027t encrypt them. i.e. no data-at-rest encryption.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"c75a58e70e90aa755e6225e9ceeebc2962547f11","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"This implementation does not require the use of an external system to provide"},{"line_number":36,"context_line":"the second authentication method."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Implement OTP driver using TOTP that is compatible with Google Authenticator."},{"line_number":39,"context_line":"Make implementation \"pluggable\" to allow other implementations with different"}],"source_content_type":"text/x-rst","patch_set":22,"id":"5a710552_5c5ea946","line":36,"in_reply_to":"7a740942_57da1f18","updated":"2015-12-14 19:41:53.000000000","message":"Done","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"14923bc4dbf69ae880d64288126a660f94c93f05","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Implement OTP driver using TOTP that is compatible with Google Authenticator."},{"line_number":39,"context_line":"Make implementation \"pluggable\" to allow other implementations with different"},{"line_number":40,"context_line":"MFA requirements for different user sets."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Store metadata that specifies if MFA should be enforced when authenticating for"},{"line_number":43,"context_line":"project, domain and users, and store OTP secret: store them in Barbican or"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_172ed7fa","line":40,"updated":"2015-12-09 01:48:05.000000000","message":"That a statement or proposed change?","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"c75a58e70e90aa755e6225e9ceeebc2962547f11","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Implement OTP driver using TOTP that is compatible with Google Authenticator."},{"line_number":39,"context_line":"Make implementation \"pluggable\" to allow other implementations with different"},{"line_number":40,"context_line":"MFA requirements for different user sets."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Store metadata that specifies if MFA should be enforced when authenticating for"},{"line_number":43,"context_line":"project, domain and users, and store OTP secret: store them in Barbican or"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_7887d512","line":40,"in_reply_to":"7a740942_172ed7fa","updated":"2015-12-14 19:41:53.000000000","message":"Done","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"14923bc4dbf69ae880d64288126a660f94c93f05","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Make implementation \"pluggable\" to allow other implementations with different"},{"line_number":40,"context_line":"MFA requirements for different user sets."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Store metadata that specifies if MFA should be enforced when authenticating for"},{"line_number":43,"context_line":"project, domain and users, and store OTP secret: store them in Barbican or"},{"line_number":44,"context_line":"encrypt in data store with filing encryption key in keystone.conf."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_fa58d232","line":42,"updated":"2015-12-09 01:48:05.000000000","message":"metadata? Can you please elaborate? Does it require schema changes?","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"c75a58e70e90aa755e6225e9ceeebc2962547f11","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Make implementation \"pluggable\" to allow other implementations with different"},{"line_number":40,"context_line":"MFA requirements for different user sets."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Store metadata that specifies if MFA should be enforced when authenticating for"},{"line_number":43,"context_line":"project, domain and users, and store OTP secret: store them in Barbican or"},{"line_number":44,"context_line":"encrypt in data store with filing encryption key in keystone.conf."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"5a710552_07a0caf3","line":42,"in_reply_to":"7a740942_fa58d232","updated":"2015-12-14 19:41:53.000000000","message":"Done","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"14923bc4dbf69ae880d64288126a660f94c93f05","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Store metadata that specifies if MFA should be enforced when authenticating for"},{"line_number":43,"context_line":"project, domain and users, and store OTP secret: store them in Barbican or"},{"line_number":44,"context_line":"encrypt in data store with filing encryption key in keystone.conf."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"An admin should be able to specify if a user needs to use MFA on a project or"},{"line_number":47,"context_line":"domain.  A user must authenticate using 2-step verification when MFA is"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_1a291e8a","line":44,"updated":"2015-12-09 01:48:05.000000000","message":"Can you please elaborate here? Also, that contradicts with the statement in line 35.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"c75a58e70e90aa755e6225e9ceeebc2962547f11","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Store metadata that specifies if MFA should be enforced when authenticating for"},{"line_number":43,"context_line":"project, domain and users, and store OTP secret: store them in Barbican or"},{"line_number":44,"context_line":"encrypt in data store with filing encryption key in keystone.conf."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"An admin should be able to specify if a user needs to use MFA on a project or"},{"line_number":47,"context_line":"domain.  A user must authenticate using 2-step verification when MFA is"}],"source_content_type":"text/x-rst","patch_set":22,"id":"5a710552_27b9462f","line":44,"in_reply_to":"7a740942_1a291e8a","updated":"2015-12-14 19:41:53.000000000","message":"Done","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"14923bc4dbf69ae880d64288126a660f94c93f05","unresolved":false,"context_lines":[{"line_number":43,"context_line":"project, domain and users, and store OTP secret: store them in Barbican or"},{"line_number":44,"context_line":"encrypt in data store with filing encryption key in keystone.conf."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"An admin should be able to specify if a user needs to use MFA on a project or"},{"line_number":47,"context_line":"domain.  A user must authenticate using 2-step verification when MFA is"},{"line_number":48,"context_line":"enforced for a user, domain or project; otherwise, the user will receive an"},{"line_number":49,"context_line":"unauthorized response."}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_3aa17af8","line":46,"updated":"2015-12-09 01:48:05.000000000","message":"An admin should be able to specify the auth method, not use MFA or not. Like I said, MFA is a concept.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"c75a58e70e90aa755e6225e9ceeebc2962547f11","unresolved":false,"context_lines":[{"line_number":43,"context_line":"project, domain and users, and store OTP secret: store them in Barbican or"},{"line_number":44,"context_line":"encrypt in data store with filing encryption key in keystone.conf."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"An admin should be able to specify if a user needs to use MFA on a project or"},{"line_number":47,"context_line":"domain.  A user must authenticate using 2-step verification when MFA is"},{"line_number":48,"context_line":"enforced for a user, domain or project; otherwise, the user will receive an"},{"line_number":49,"context_line":"unauthorized response."}],"source_content_type":"text/x-rst","patch_set":22,"id":"5a710552_276ce69b","line":46,"in_reply_to":"7a740942_3aa17af8","updated":"2015-12-14 19:41:53.000000000","message":"Done","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"14923bc4dbf69ae880d64288126a660f94c93f05","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      \"auth\": {"},{"line_number":59,"context_line":"          \"identity\": {"},{"line_number":60,"context_line":"              \"methods\": ["},{"line_number":61,"context_line":"                  \"password\", \"passcode\""},{"line_number":62,"context_line":"              ],"},{"line_number":63,"context_line":"              \"password\": {"},{"line_number":64,"context_line":"                  \"user\": {"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_faf452f1","line":61,"updated":"2015-12-09 01:48:05.000000000","message":"s/\"passcode\"/\"totp\"/\n\nWe need to be specific about the mechanism.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"c75a58e70e90aa755e6225e9ceeebc2962547f11","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      \"auth\": {"},{"line_number":59,"context_line":"          \"identity\": {"},{"line_number":60,"context_line":"              \"methods\": ["},{"line_number":61,"context_line":"                  \"password\", \"passcode\""},{"line_number":62,"context_line":"              ],"},{"line_number":63,"context_line":"              \"password\": {"},{"line_number":64,"context_line":"                  \"user\": {"}],"source_content_type":"text/x-rst","patch_set":22,"id":"5a710552_47eed2ed","line":61,"in_reply_to":"7a740942_faf452f1","updated":"2015-12-14 19:41:53.000000000","message":"Done","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"14923bc4dbf69ae880d64288126a660f94c93f05","unresolved":false,"context_lines":[{"line_number":68,"context_line":"              },"},{"line_number":69,"context_line":"              \"passcode\": {"},{"line_number":70,"context_line":"                  \"type\": \"TOTP\","},{"line_number":71,"context_line":"                  \"passcode\": \"12345\""},{"line_number":72,"context_line":"              }"},{"line_number":73,"context_line":"          },"},{"line_number":74,"context_line":"          \"scope\": {"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_3a889a70","line":71,"updated":"2015-12-09 01:48:05.000000000","message":"that enough? What if the user have multiple secrets?","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1a1a77382f0dd8c4457055d725f4a29771b5b85f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"              },"},{"line_number":69,"context_line":"              \"passcode\": {"},{"line_number":70,"context_line":"                  \"type\": \"TOTP\","},{"line_number":71,"context_line":"                  \"passcode\": \"12345\""},{"line_number":72,"context_line":"              }"},{"line_number":73,"context_line":"          },"},{"line_number":74,"context_line":"          \"scope\": {"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_ffce60b6","line":71,"in_reply_to":"7a740942_3a889a70","updated":"2015-12-09 15:16:42.000000000","message":"Are we going to support multiple secrets off the bat?","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"c75a58e70e90aa755e6225e9ceeebc2962547f11","unresolved":false,"context_lines":[{"line_number":68,"context_line":"              },"},{"line_number":69,"context_line":"              \"passcode\": {"},{"line_number":70,"context_line":"                  \"type\": \"TOTP\","},{"line_number":71,"context_line":"                  \"passcode\": \"12345\""},{"line_number":72,"context_line":"              }"},{"line_number":73,"context_line":"          },"},{"line_number":74,"context_line":"          \"scope\": {"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_35b3960c","line":71,"in_reply_to":"7a740942_ffce60b6","updated":"2015-12-14 19:41:53.000000000","message":"This was changed.  It was mentioned in the keystone meeting to only support totp.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"14923bc4dbf69ae880d64288126a660f94c93f05","unresolved":false,"context_lines":[{"line_number":79,"context_line":"      }"},{"line_number":80,"context_line":"  }"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Create a new \"password\" auth plugin to enforce multi-factor authentication."},{"line_number":83,"context_line":"The plugin can be swapped in by updating Keystone configuration.  The password"},{"line_number":84,"context_line":"plugin will only enforce MFA for authentication when enabled for a user, domain"},{"line_number":85,"context_line":"or project."}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_5a8fa674","line":82,"updated":"2015-12-09 01:48:05.000000000","message":"s/\"password\"/\"totp\"/","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"14923bc4dbf69ae880d64288126a660f94c93f05","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  }"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Create a new \"password\" auth plugin to enforce multi-factor authentication."},{"line_number":83,"context_line":"The plugin can be swapped in by updating Keystone configuration.  The password"},{"line_number":84,"context_line":"plugin will only enforce MFA for authentication when enabled for a user, domain"},{"line_number":85,"context_line":"or project."},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_5ae6c644","line":83,"updated":"2015-12-09 01:48:05.000000000","message":"Why do we need to swap? It\u0027s an addition auth method we need to support.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"c75a58e70e90aa755e6225e9ceeebc2962547f11","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  }"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Create a new \"password\" auth plugin to enforce multi-factor authentication."},{"line_number":83,"context_line":"The plugin can be swapped in by updating Keystone configuration.  The password"},{"line_number":84,"context_line":"plugin will only enforce MFA for authentication when enabled for a user, domain"},{"line_number":85,"context_line":"or project."},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_758efe28","line":83,"in_reply_to":"7a740942_5ae6c644","updated":"2015-12-14 19:41:53.000000000","message":"The password plugin does not require mfa.  I can update the exsiting plugin to enforce mfa or create a new one.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1a1a77382f0dd8c4457055d725f4a29771b5b85f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  }"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Create a new \"password\" auth plugin to enforce multi-factor authentication."},{"line_number":83,"context_line":"The plugin can be swapped in by updating Keystone configuration.  The password"},{"line_number":84,"context_line":"plugin will only enforce MFA for authentication when enabled for a user, domain"},{"line_number":85,"context_line":"or project."},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_1f624cae","line":83,"in_reply_to":"7a740942_5ae6c644","updated":"2015-12-09 15:16:42.000000000","message":"nit: it can be swapped or added to the current list of authentication methods provided in keystone\u0027s configuration file.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"14923bc4dbf69ae880d64288126a660f94c93f05","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"For the initial implementation, when a user gets MFA enabled, the user\u0027s"},{"line_number":93,"context_line":"previous tokens would still be valid.  Services that only want to allow MFA"},{"line_number":94,"context_line":"tokens can use the methods list to verify OTP was used."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Add ability to see MFA algorithms available for a specific Keystone deployment."},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_3a3dfa8e","line":94,"updated":"2015-12-09 01:48:05.000000000","message":"Service will need to change their policy.json file if they want to authorize on the auth method. Also, we\u0027ll need to update auth_token middleware to convey the auth methods.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"c75a58e70e90aa755e6225e9ceeebc2962547f11","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"For the initial implementation, when a user gets MFA enabled, the user\u0027s"},{"line_number":93,"context_line":"previous tokens would still be valid.  Services that only want to allow MFA"},{"line_number":94,"context_line":"tokens can use the methods list to verify OTP was used."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Add ability to see MFA algorithms available for a specific Keystone deployment."},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"5a710552_a7e696e6","line":94,"in_reply_to":"7a740942_3a3dfa8e","updated":"2015-12-14 19:41:53.000000000","message":"Done","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"14923bc4dbf69ae880d64288126a660f94c93f05","unresolved":false,"context_lines":[{"line_number":93,"context_line":"previous tokens would still be valid.  Services that only want to allow MFA"},{"line_number":94,"context_line":"tokens can use the methods list to verify OTP was used."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Add ability to see MFA algorithms available for a specific Keystone deployment."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Authentication ceremony when MFA is required:"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_ba49ea32","line":96,"updated":"2015-12-09 01:48:05.000000000","message":"Not sure if I understand this statement. Can you please elaborate?","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1a1a77382f0dd8c4457055d725f4a29771b5b85f","unresolved":false,"context_lines":[{"line_number":93,"context_line":"previous tokens would still be valid.  Services that only want to allow MFA"},{"line_number":94,"context_line":"tokens can use the methods list to verify OTP was used."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Add ability to see MFA algorithms available for a specific Keystone deployment."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Authentication ceremony when MFA is required:"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_1fd7ac24","line":96,"in_reply_to":"7a740942_286b6286","updated":"2015-12-09 15:16:42.000000000","message":"I don\u0027t think it should be removed. I think it provides value but maybe just needs to be reworded. If we\u0027re not going to support it initially we can rephrase the statement eluding to future work. Better yet, we can provide a link to a second blueprint if needed.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"766a36664886b8fea5c382c8939d11b302f56ce0","unresolved":false,"context_lines":[{"line_number":93,"context_line":"previous tokens would still be valid.  Services that only want to allow MFA"},{"line_number":94,"context_line":"tokens can use the methods list to verify OTP was used."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Add ability to see MFA algorithms available for a specific Keystone deployment."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Authentication ceremony when MFA is required:"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_286b6286","line":96,"in_reply_to":"7a740942_ba49ea32","updated":"2015-12-09 09:43:49.000000000","message":"I think that the spec is written generally for MFA. But, as we decided, we\u0027re going to support only totp, so this statement should be removed.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"c75a58e70e90aa755e6225e9ceeebc2962547f11","unresolved":false,"context_lines":[{"line_number":93,"context_line":"previous tokens would still be valid.  Services that only want to allow MFA"},{"line_number":94,"context_line":"tokens can use the methods list to verify OTP was used."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Add ability to see MFA algorithms available for a specific Keystone deployment."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Authentication ceremony when MFA is required:"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_35af167f","line":96,"in_reply_to":"7a740942_ba49ea32","updated":"2015-12-14 19:41:53.000000000","message":"This was removed.  Spec is now only for TOTP.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"14923bc4dbf69ae880d64288126a660f94c93f05","unresolved":false,"context_lines":[{"line_number":98,"context_line":"Authentication ceremony when MFA is required:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"* User authenticates with valid password and receives unauthorized response"},{"line_number":101,"context_line":"  with an unscoped token in header."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"* User sends second auth request with unscoped token and OTP and receives"},{"line_number":104,"context_line":"  scoped token."}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_da0dd6e8","line":101,"updated":"2015-12-09 01:48:05.000000000","message":"That\u0027ll violate the Keystone V3 API contract. Token is issued only after all the authentication methods are successful.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"c75a58e70e90aa755e6225e9ceeebc2962547f11","unresolved":false,"context_lines":[{"line_number":98,"context_line":"Authentication ceremony when MFA is required:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"* User authenticates with valid password and receives unauthorized response"},{"line_number":101,"context_line":"  with an unscoped token in header."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"* User sends second auth request with unscoped token and OTP and receives"},{"line_number":104,"context_line":"  scoped token."}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_95e12ad3","line":101,"in_reply_to":"7a740942_da0dd6e8","updated":"2015-12-14 19:41:53.000000000","message":"This can be a new token type that is only used for 2-factor auth.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"14923bc4dbf69ae880d64288126a660f94c93f05","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  with an unscoped token in header."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"* User sends second auth request with unscoped token and OTP and receives"},{"line_number":104,"context_line":"  scoped token."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Single request:"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_7ac2a254","line":104,"updated":"2015-12-09 01:48:05.000000000","message":"What\u0027s the use case for this?","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"766a36664886b8fea5c382c8939d11b302f56ce0","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  with an unscoped token in header."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"* User sends second auth request with unscoped token and OTP and receives"},{"line_number":104,"context_line":"  scoped token."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Single request:"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_a8b2f203","line":104,"in_reply_to":"7a740942_7ac2a254","updated":"2015-12-09 09:43:49.000000000","message":"I think this might has something to do with your comment to line 30. Lets wait for the author\u0027s reply though.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"c75a58e70e90aa755e6225e9ceeebc2962547f11","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  with an unscoped token in header."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"* User sends second auth request with unscoped token and OTP and receives"},{"line_number":104,"context_line":"  scoped token."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Single request:"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_f5250e0a","line":104,"in_reply_to":"7a740942_7ac2a254","updated":"2015-12-14 19:41:53.000000000","message":"When mfa is not enforced:\nA user authenticates and gets a token (200).\n\nWhen mfa is enforced:\nA user authenticates and unauthorized response and receives a token that is only good to authenticate with passcode.\nUser then authenticates again using both the provided token and the totp passcode.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"14923bc4dbf69ae880d64288126a660f94c93f05","unresolved":false,"context_lines":[{"line_number":118,"context_line":"Describe any potential security impact on the system.  Some of the items to"},{"line_number":119,"context_line":"consider include:"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"* A users secret key to generate one-time password will need to be stored."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* This change adds additional request data to the login process when MFA is"},{"line_number":124,"context_line":"  enabled.  The users need to be aware when MFA is enabled and specify their"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_7a994278","line":121,"updated":"2015-12-09 01:48:05.000000000","message":"Stored and encrypted.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"c75a58e70e90aa755e6225e9ceeebc2962547f11","unresolved":false,"context_lines":[{"line_number":118,"context_line":"Describe any potential security impact on the system.  Some of the items to"},{"line_number":119,"context_line":"consider include:"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"* A users secret key to generate one-time password will need to be stored."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* This change adds additional request data to the login process when MFA is"},{"line_number":124,"context_line":"  enabled.  The users need to be aware when MFA is enabled and specify their"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_f56c2e38","line":121,"in_reply_to":"7a740942_7a994278","updated":"2015-12-14 19:41:53.000000000","message":"Done","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"14923bc4dbf69ae880d64288126a660f94c93f05","unresolved":false,"context_lines":[{"line_number":130,"context_line":"Notifications Impact"},{"line_number":131,"context_line":"--------------------"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"None"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Other End User Impact"},{"line_number":136,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_ba7a4a22","line":133,"updated":"2015-12-09 01:48:05.000000000","message":"All auths are CADFied.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"c75a58e70e90aa755e6225e9ceeebc2962547f11","unresolved":false,"context_lines":[{"line_number":130,"context_line":"Notifications Impact"},{"line_number":131,"context_line":"--------------------"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"None"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Other End User Impact"},{"line_number":136,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":22,"id":"5a710552_27f2a69b","line":133,"in_reply_to":"7a740942_ba7a4a22","updated":"2015-12-14 19:41:53.000000000","message":"Done","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"14923bc4dbf69ae880d64288126a660f94c93f05","unresolved":false,"context_lines":[{"line_number":135,"context_line":"Other End User Impact"},{"line_number":136,"context_line":"---------------------"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"It may be more difficult for users to do automation."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Performance Impact"},{"line_number":141,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_1a927e4c","line":138,"updated":"2015-12-09 01:48:05.000000000","message":"MFAs are not meant for automation.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"c75a58e70e90aa755e6225e9ceeebc2962547f11","unresolved":false,"context_lines":[{"line_number":135,"context_line":"Other End User Impact"},{"line_number":136,"context_line":"---------------------"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"It may be more difficult for users to do automation."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Performance Impact"},{"line_number":141,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":22,"id":"5a710552_e711feb0","line":138,"in_reply_to":"7a740942_1a927e4c","updated":"2015-12-14 19:41:53.000000000","message":"Done","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1a1a77382f0dd8c4457055d725f4a29771b5b85f","unresolved":false,"context_lines":[{"line_number":165,"context_line":"Example::"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"  [auth]"},{"line_number":168,"context_line":"  methods \u003d password, passcode"},{"line_number":169,"context_line":"  password \u003d pkg.path.mfa.Password"},{"line_number":170,"context_line":"  passcode \u003d pkg.path.mfa.Passcode"},{"line_number":171,"context_line":"  otp_name \u003d ?!"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_1fe1ecd0","line":168,"updated":"2015-12-09 15:16:42.000000000","message":"should this be: \n\n    methods \u003d password, passcode, otp_name\n\n?","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"c75a58e70e90aa755e6225e9ceeebc2962547f11","unresolved":false,"context_lines":[{"line_number":165,"context_line":"Example::"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"  [auth]"},{"line_number":168,"context_line":"  methods \u003d password, passcode"},{"line_number":169,"context_line":"  password \u003d pkg.path.mfa.Password"},{"line_number":170,"context_line":"  passcode \u003d pkg.path.mfa.Passcode"},{"line_number":171,"context_line":"  otp_name \u003d ?!"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_d5a6d252","line":168,"in_reply_to":"7a740942_1fe1ecd0","updated":"2015-12-14 19:41:53.000000000","message":"Done","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"766a36664886b8fea5c382c8939d11b302f56ce0","unresolved":false,"context_lines":[{"line_number":168,"context_line":"  methods \u003d password, passcode"},{"line_number":169,"context_line":"  password \u003d pkg.path.mfa.Password"},{"line_number":170,"context_line":"  passcode \u003d pkg.path.mfa.Passcode"},{"line_number":171,"context_line":"  otp_name \u003d ?!"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Implementation"},{"line_number":174,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_c883be01","line":171,"updated":"2015-12-09 09:43:49.000000000","message":"what should be here?","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"c75a58e70e90aa755e6225e9ceeebc2962547f11","unresolved":false,"context_lines":[{"line_number":168,"context_line":"  methods \u003d password, passcode"},{"line_number":169,"context_line":"  password \u003d pkg.path.mfa.Password"},{"line_number":170,"context_line":"  passcode \u003d pkg.path.mfa.Passcode"},{"line_number":171,"context_line":"  otp_name \u003d ?!"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Implementation"},{"line_number":174,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a740942_15745acd","line":171,"in_reply_to":"7a740942_c883be01","updated":"2015-12-14 19:41:53.000000000","message":"This can be ignored.","commit_id":"ff509e835a85a5e66353f773b07d60c6a12e1ccf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c99e10cf8f21c57836838bdeb4defcab6830b9e9","unresolved":false,"context_lines":[{"line_number":45,"context_line":"domain.  A user must authenticate using 2-step verification when MFA is"},{"line_number":46,"context_line":"enforced for a user, domain or project; otherwise, the user will receive an"},{"line_number":47,"context_line":"unauthorized response.  The MFA changes proposed are only for SQL and LDAP"},{"line_number":48,"context_line":"users."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"A user must authenticate using the 2nd factor if MFA is enabled for enforcement"},{"line_number":51,"context_line":"for the user, the domain in which the user-belongs, or the project that the"}],"source_content_type":"text/x-rst","patch_set":24,"id":"7a740942_15377ae4","line":48,"updated":"2015-12-09 21:23:38.000000000","message":"Local LDAP and SQL users. This doesn\u0027t include MFA for federated users of any kind, that should be done through the federation identity provider.","commit_id":"9de52e22de46d90f4de1222d4f20f9027b537014"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"d1a5594e9314c96bb09e34adfc0048c7b6532379","unresolved":false,"context_lines":[{"line_number":45,"context_line":"domain.  A user must authenticate using 2-step verification when MFA is"},{"line_number":46,"context_line":"enforced for a user, domain or project; otherwise, the user will receive an"},{"line_number":47,"context_line":"unauthorized response.  The MFA changes proposed are only for SQL and LDAP"},{"line_number":48,"context_line":"users."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"A user must authenticate using the 2nd factor if MFA is enabled for enforcement"},{"line_number":51,"context_line":"for the user, the domain in which the user-belongs, or the project that the"}],"source_content_type":"text/x-rst","patch_set":24,"id":"5a710552_825b4854","line":48,"in_reply_to":"7a740942_15377ae4","updated":"2015-12-14 19:42:06.000000000","message":"Done","commit_id":"9de52e22de46d90f4de1222d4f20f9027b537014"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c99e10cf8f21c57836838bdeb4defcab6830b9e9","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    DELETE /v3/users/{user_id}/passcode"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"* Enable / Disable MFA for a user::"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    PATCH /v3/users/{user_id}/enforce-mfa"},{"line_number":127,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":24,"id":"7a740942_5580a246","line":124,"updated":"2015-12-09 21:23:38.000000000","message":"This will enforce the user to use MFA regardless of the project they want to interact with, right?","commit_id":"9de52e22de46d90f4de1222d4f20f9027b537014"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"d1a5594e9314c96bb09e34adfc0048c7b6532379","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    DELETE /v3/users/{user_id}/passcode"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"* Enable / Disable MFA for a user::"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    PATCH /v3/users/{user_id}/enforce-mfa"},{"line_number":127,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":24,"id":"5a710552_22aa941a","line":124,"in_reply_to":"7a740942_5580a246","updated":"2015-12-14 19:42:06.000000000","message":"Done","commit_id":"9de52e22de46d90f4de1222d4f20f9027b537014"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c99e10cf8f21c57836838bdeb4defcab6830b9e9","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        }"},{"line_number":131,"context_line":"    }"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"* Enable / Disable MFA for a domain::"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    PATCH /v3/domain/{domain_id}/enforce-mfa"},{"line_number":136,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":24,"id":"7a740942_b58f8674","line":133,"updated":"2015-12-09 21:23:38.000000000","message":"This will enforce all users of a given domain to use MFA.","commit_id":"9de52e22de46d90f4de1222d4f20f9027b537014"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"d1a5594e9314c96bb09e34adfc0048c7b6532379","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        }"},{"line_number":131,"context_line":"    }"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"* Enable / Disable MFA for a domain::"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    PATCH /v3/domain/{domain_id}/enforce-mfa"},{"line_number":136,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":24,"id":"5a710552_e2624c16","line":133,"in_reply_to":"7a740942_b58f8674","updated":"2015-12-14 19:42:06.000000000","message":"Done","commit_id":"9de52e22de46d90f4de1222d4f20f9027b537014"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c99e10cf8f21c57836838bdeb4defcab6830b9e9","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        }"},{"line_number":140,"context_line":"    }"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"* Enable / Disable MFA for a project::"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    PATCH /v3/project/{project_id}/enforce-mfa"},{"line_number":145,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":24,"id":"7a740942_7536feb5","line":142,"updated":"2015-12-09 21:23:38.000000000","message":"Ditto, but for projects.","commit_id":"9de52e22de46d90f4de1222d4f20f9027b537014"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"d1a5594e9314c96bb09e34adfc0048c7b6532379","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        }"},{"line_number":140,"context_line":"    }"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"* Enable / Disable MFA for a project::"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    PATCH /v3/project/{project_id}/enforce-mfa"},{"line_number":145,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":24,"id":"5a710552_c27150e2","line":142,"in_reply_to":"7a740942_7536feb5","updated":"2015-12-14 19:42:06.000000000","message":"Done","commit_id":"9de52e22de46d90f4de1222d4f20f9027b537014"},{"author":{"_account_id":18981,"name":"Fangzhou Xu","email":"fangxu@ebaysf.com","username":"fangxu"},"change_message_id":"7079ee904cad38e02720a9125b4c2a83467bb72a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Support Google Authenticator TOTP Authentication"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp multi-factor-auth \u003chttps://blueprints.launchpad.net/keystone/+spec/multi-factor-auth\u003e`_"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_bef53784","line":9,"updated":"2015-12-14 23:12:07.000000000","message":"What about the other TOTP authentication. Do we want another BP for that? e.g. radius.","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"5701744f3f36d589e054950456f40da41d26732b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Support Google Authenticator TOTP Authentication"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp multi-factor-auth \u003chttps://blueprints.launchpad.net/keystone/+spec/multi-factor-auth\u003e`_"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_93c0372c","line":9,"in_reply_to":"5a710552_8f7cc321","updated":"2016-01-04 19:45:16.000000000","message":"Done","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"cbbe33b5858db0157075068bb2137e194d8bc8c8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Support Google Authenticator TOTP Authentication"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp multi-factor-auth \u003chttps://blueprints.launchpad.net/keystone/+spec/multi-factor-auth\u003e`_"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_8f7cc321","line":9,"in_reply_to":"5a710552_bef53784","updated":"2015-12-15 01:12:57.000000000","message":"sure, it would be a different BP. That\u0027s why I suggested to be specific earlier. MFA is a concept, its implementations and technologies are very much vendor-specific.","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"cbbe33b5858db0157075068bb2137e194d8bc8c8","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Support Google Authenticator TOTP Authentication"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp multi-factor-auth \u003chttps://blueprints.launchpad.net/keystone/+spec/multi-factor-auth\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Support Google Authenticator TOTP Authentication for Multi-Factor"},{"line_number":14,"context_line":"Authentication.  MFA provides a way to authenticate a user using two"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_2fe26fd6","line":11,"updated":"2015-12-15 01:12:57.000000000","message":"this needs to be changed to reflect the new name\n\n support-google-authenticator-totp-authentication","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"5701744f3f36d589e054950456f40da41d26732b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Support Google Authenticator TOTP Authentication"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp multi-factor-auth \u003chttps://blueprints.launchpad.net/keystone/+spec/multi-factor-auth\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Support Google Authenticator TOTP Authentication for Multi-Factor"},{"line_number":14,"context_line":"Authentication.  MFA provides a way to authenticate a user using two"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_53e16fcf","line":11,"in_reply_to":"5a710552_2fe26fd6","updated":"2016-01-04 19:45:16.000000000","message":"Done","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"cbbe33b5858db0157075068bb2137e194d8bc8c8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Support Google Authenticator TOTP Authentication for Multi-Factor"},{"line_number":14,"context_line":"Authentication.  MFA provides a way to authenticate a user using two"},{"line_number":15,"context_line":"independent authentication factors, such a password (something you know) and"},{"line_number":16,"context_line":"one time passcode from a physical key fob (something you have), which has no"},{"line_number":17,"context_line":"service providers and can be implemented fully in the open."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The algorithm proposed is already being used by Google for their multi-factor"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_cffdeb6f","line":16,"updated":"2015-12-15 01:12:57.000000000","message":"key fob or android app :-)","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"5701744f3f36d589e054950456f40da41d26732b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Support Google Authenticator TOTP Authentication for Multi-Factor"},{"line_number":14,"context_line":"Authentication.  MFA provides a way to authenticate a user using two"},{"line_number":15,"context_line":"independent authentication factors, such a password (something you know) and"},{"line_number":16,"context_line":"one time passcode from a physical key fob (something you have), which has no"},{"line_number":17,"context_line":"service providers and can be implemented fully in the open."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The algorithm proposed is already being used by Google for their multi-factor"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_b3f9b382","line":16,"in_reply_to":"5a710552_cffdeb6f","updated":"2016-01-04 19:45:16.000000000","message":"Done","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b3f4acc40ec133433881e3566aa6af760a65f4af","unresolved":false,"context_lines":[{"line_number":31,"context_line":"without having to use a 3rd identity provider."},{"line_number":32,"context_line":"The goal of this change is to add a \"possession factor\" (something a user has)"},{"line_number":33,"context_line":"and restrict the auth method of a given user, project or domain."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Proposed Change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_a548c92e","line":34,"updated":"2015-12-14 21:51:16.000000000","message":"There\u0027s no explanation for why you need to do this per-project, per-domain, or per-user. I\u0027d expect it for the entire deployment, or *perhaps* per user/identity domain (not authorization/scope domain).","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"cbbe33b5858db0157075068bb2137e194d8bc8c8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"without having to use a 3rd identity provider."},{"line_number":32,"context_line":"The goal of this change is to add a \"possession factor\" (something a user has)"},{"line_number":33,"context_line":"and restrict the auth method of a given user, project or domain."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Proposed Change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_2f658f44","line":34,"in_reply_to":"5a710552_a548c92e","updated":"2015-12-15 01:12:57.000000000","message":"So there are two ways one can enforce access.\n\n 1. At authentication. If user doesn\u0027t meet certain criteria, it is considered unauthenticated\n 2. At the policy enforcement point. If the user\u0027s authentication methods does not meet the access requirement, user is not authorized to access.\n\nBoth have their pros and cons. We already have 2), the author is now proposing 1) to give deployers more flexibility.","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b3f4acc40ec133433881e3566aa6af760a65f4af","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Proposed Change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"This implementation does not require the use of an external system to provide"},{"line_number":39,"context_line":"the second authentication method.  Optionally Barbican can be used to manage"},{"line_number":40,"context_line":"the shared secret."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_252b7984","line":38,"updated":"2015-12-14 21:51:16.000000000","message":"Except a proprietary implementation of a proprietary algorithm?","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"cbbe33b5858db0157075068bb2137e194d8bc8c8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Proposed Change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"This implementation does not require the use of an external system to provide"},{"line_number":39,"context_line":"the second authentication method.  Optionally Barbican can be used to manage"},{"line_number":40,"context_line":"the shared secret."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_cfe72bab","line":38,"in_reply_to":"5a710552_252b7984","updated":"2015-12-15 01:12:57.000000000","message":"TOTP is well know. Even Fernet supports it I think.\n\nhttp://cryptography.readthedocs.org/en/latest/hazmat/primitives/twofactor/?highlight\u003dtotp#cryptography.hazmat.primitives.twofactor.totp.TOTP","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b3f4acc40ec133433881e3566aa6af760a65f4af","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"This implementation does not require the use of an external system to provide"},{"line_number":39,"context_line":"the second authentication method.  Optionally Barbican can be used to manage"},{"line_number":40,"context_line":"the shared secret."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Implement OTP driver using TOTP that is compatible with Google Authenticator."}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_0a18ca83","line":39,"updated":"2015-12-14 21:51:16.000000000","message":"(nit) \"Optionally,\"","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"5701744f3f36d589e054950456f40da41d26732b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"This implementation does not require the use of an external system to provide"},{"line_number":39,"context_line":"the second authentication method.  Optionally Barbican can be used to manage"},{"line_number":40,"context_line":"the shared secret."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Implement OTP driver using TOTP that is compatible with Google Authenticator."}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_f383bbca","line":39,"in_reply_to":"5a710552_0a18ca83","updated":"2016-01-04 19:45:16.000000000","message":"Done","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"cbbe33b5858db0157075068bb2137e194d8bc8c8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"An admin should be able to specify the auth method a user needs to use on a"},{"line_number":50,"context_line":"project or domain.  A user must authenticate using 2-step verification when MFA"},{"line_number":51,"context_line":"is enforced for a user, domain or project; otherwise, the user will receive an"},{"line_number":52,"context_line":"unauthorized response.  The MFA changes proposed are only for SQL and LDAP"},{"line_number":53,"context_line":"users.  This doesn\u0027t include MFA for federated users of any kind, that should"},{"line_number":54,"context_line":"be done through the federation identity provider."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_cf43ab6b","line":52,"updated":"2015-12-15 01:12:57.000000000","message":"s/SQL and LDAP/Keystone-managed/","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"5701744f3f36d589e054950456f40da41d26732b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"An admin should be able to specify the auth method a user needs to use on a"},{"line_number":50,"context_line":"project or domain.  A user must authenticate using 2-step verification when MFA"},{"line_number":51,"context_line":"is enforced for a user, domain or project; otherwise, the user will receive an"},{"line_number":52,"context_line":"unauthorized response.  The MFA changes proposed are only for SQL and LDAP"},{"line_number":53,"context_line":"users.  This doesn\u0027t include MFA for federated users of any kind, that should"},{"line_number":54,"context_line":"be done through the federation identity provider."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_73782bf3","line":52,"in_reply_to":"5a710552_cf43ab6b","updated":"2016-01-04 19:45:16.000000000","message":"Done","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b3f4acc40ec133433881e3566aa6af760a65f4af","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"A user must authenticate using the 2nd factor if MFA is enabled for enforcement"},{"line_number":57,"context_line":"for the user, the domain in which the user-belongs, or the project that the"},{"line_number":58,"context_line":"user has access to."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Example request::"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_a593e9a2","line":58,"updated":"2015-12-14 21:51:16.000000000","message":"Until now, we\u0027ve left MFA-enforcement up to policy (where a particular call might require a second factor), but no one has implemented that. We pass authentication methods all the way to keystonemiddleware.auth_token; all that\u0027s left is to pass them to oslo policy and introduce new policy language to interpret/enforce secondary/tertiary factors. As in:\n\n  \"identity:create_user\" : \"role:admin and factors:2\"\n\nWhere \"totp\" could be identifies as a something-you-have (1st factor) in addition to \"password\", something-you-know (2nd factor).","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"cbbe33b5858db0157075068bb2137e194d8bc8c8","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"A user must authenticate using the 2nd factor if MFA is enabled for enforcement"},{"line_number":57,"context_line":"for the user, the domain in which the user-belongs, or the project that the"},{"line_number":58,"context_line":"user has access to."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Example request::"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_efa3074e","line":58,"in_reply_to":"5a710552_a593e9a2","updated":"2015-12-15 01:12:57.000000000","message":"right, that\u0027s one way to enforce access","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b3f4acc40ec133433881e3566aa6af760a65f4af","unresolved":false,"context_lines":[{"line_number":63,"context_line":"      \"auth\": {"},{"line_number":64,"context_line":"          \"identity\": {"},{"line_number":65,"context_line":"              \"methods\": ["},{"line_number":66,"context_line":"                  \"password\", \"totp\""},{"line_number":67,"context_line":"              ],"},{"line_number":68,"context_line":"              \"password\": {"},{"line_number":69,"context_line":"                  \"user\": {"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_254ff993","line":66,"updated":"2015-12-14 21:51:16.000000000","message":"Does the method need to be tied to Google?","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"cbbe33b5858db0157075068bb2137e194d8bc8c8","unresolved":false,"context_lines":[{"line_number":63,"context_line":"      \"auth\": {"},{"line_number":64,"context_line":"          \"identity\": {"},{"line_number":65,"context_line":"              \"methods\": ["},{"line_number":66,"context_line":"                  \"password\", \"totp\""},{"line_number":67,"context_line":"              ],"},{"line_number":68,"context_line":"              \"password\": {"},{"line_number":69,"context_line":"                  \"user\": {"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_8f25a3c3","line":66,"in_reply_to":"5a710552_254ff993","updated":"2015-12-15 01:12:57.000000000","message":"Not really. But I agree. We need to be more specific.","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b3f4acc40ec133433881e3566aa6af760a65f4af","unresolved":false,"context_lines":[{"line_number":74,"context_line":"              \"totp\": {"},{"line_number":75,"context_line":"                  \"user\": {"},{"line_number":76,"context_line":"                      \"id\": \"b95b78b67fa045b38104c12fb2729cd0\","},{"line_number":77,"context_line":"                      \"totp\": \"01234567890123456\""},{"line_number":78,"context_line":"                  }"},{"line_number":79,"context_line":"              }"},{"line_number":80,"context_line":"          },"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_8526ed14","line":77,"updated":"2015-12-14 21:51:16.000000000","message":"A 6-ish digit example would be more realistic :)","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"5701744f3f36d589e054950456f40da41d26732b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"              \"totp\": {"},{"line_number":75,"context_line":"                  \"user\": {"},{"line_number":76,"context_line":"                      \"id\": \"b95b78b67fa045b38104c12fb2729cd0\","},{"line_number":77,"context_line":"                      \"totp\": \"01234567890123456\""},{"line_number":78,"context_line":"                  }"},{"line_number":79,"context_line":"              }"},{"line_number":80,"context_line":"          },"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_b38a13be","line":77,"in_reply_to":"5a710552_2f1d8f73","updated":"2016-01-04 19:45:16.000000000","message":"Done","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"cbbe33b5858db0157075068bb2137e194d8bc8c8","unresolved":false,"context_lines":[{"line_number":74,"context_line":"              \"totp\": {"},{"line_number":75,"context_line":"                  \"user\": {"},{"line_number":76,"context_line":"                      \"id\": \"b95b78b67fa045b38104c12fb2729cd0\","},{"line_number":77,"context_line":"                      \"totp\": \"01234567890123456\""},{"line_number":78,"context_line":"                  }"},{"line_number":79,"context_line":"              }"},{"line_number":80,"context_line":"          },"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_2f1d8f73","line":77,"in_reply_to":"5a710552_8526ed14","updated":"2015-12-15 01:12:57.000000000","message":"++\n\nAlso, \u0027totp\u0027 should be \u0027passcode\u0027","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b3f4acc40ec133433881e3566aa6af760a65f4af","unresolved":false,"context_lines":[{"line_number":94,"context_line":"The auth plugin will require a user to specify both their username and password"},{"line_number":95,"context_line":"along with a client-generated OTP.  The plugin will then verify the OTP is"},{"line_number":96,"context_line":"valid along with the user credentials.  The two authentication methods would be"},{"line_number":97,"context_line":"combined in the API and handled by a single new auth plugin."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"For the initial implementation, when a user gets MFA enabled, the user\u0027s"},{"line_number":100,"context_line":"previous tokens would still be valid.  Services will need to change their"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_45fc853e","line":97,"updated":"2015-12-14 21:51:16.000000000","message":"We already support exchanging an existing token (username+password\u003dtoken) for a new token with an additional auth method. The new auth plugin does not need to handle both at once - which is what this statement seems to suggest.","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"cbbe33b5858db0157075068bb2137e194d8bc8c8","unresolved":false,"context_lines":[{"line_number":94,"context_line":"The auth plugin will require a user to specify both their username and password"},{"line_number":95,"context_line":"along with a client-generated OTP.  The plugin will then verify the OTP is"},{"line_number":96,"context_line":"valid along with the user credentials.  The two authentication methods would be"},{"line_number":97,"context_line":"combined in the API and handled by a single new auth plugin."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"For the initial implementation, when a user gets MFA enabled, the user\u0027s"},{"line_number":100,"context_line":"previous tokens would still be valid.  Services will need to change their"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_8f0cc343","line":97,"in_reply_to":"5a710552_45fc853e","updated":"2015-12-15 01:12:57.000000000","message":"It would be two different plugins.","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b3f4acc40ec133433881e3566aa6af760a65f4af","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"For the initial implementation, when a user gets MFA enabled, the user\u0027s"},{"line_number":100,"context_line":"previous tokens would still be valid.  Services will need to change their"},{"line_number":101,"context_line":"policy.json file if they want to authorize on the auth method. Also, we\u0027ll need"},{"line_number":102,"context_line":"to update auth_token middleware to convey the auth methods."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Authentication ceremony when MFA is required:"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_e5a3314e","line":101,"updated":"2015-12-14 21:51:16.000000000","message":"``policy.json``","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"5701744f3f36d589e054950456f40da41d26732b","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"For the initial implementation, when a user gets MFA enabled, the user\u0027s"},{"line_number":100,"context_line":"previous tokens would still be valid.  Services will need to change their"},{"line_number":101,"context_line":"policy.json file if they want to authorize on the auth method. Also, we\u0027ll need"},{"line_number":102,"context_line":"to update auth_token middleware to convey the auth methods."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Authentication ceremony when MFA is required:"}],"source_content_type":"text/x-rst","patch_set":25,"id":"fa69d971_c3ff97a8","line":101,"in_reply_to":"5a710552_e5a3314e","updated":"2016-01-04 19:45:16.000000000","message":"Done","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":18981,"name":"Fangzhou Xu","email":"fangxu@ebaysf.com","username":"fangxu"},"change_message_id":"7079ee904cad38e02720a9125b4c2a83467bb72a","unresolved":false,"context_lines":[{"line_number":99,"context_line":"For the initial implementation, when a user gets MFA enabled, the user\u0027s"},{"line_number":100,"context_line":"previous tokens would still be valid.  Services will need to change their"},{"line_number":101,"context_line":"policy.json file if they want to authorize on the auth method. Also, we\u0027ll need"},{"line_number":102,"context_line":"to update auth_token middleware to convey the auth methods."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Authentication ceremony when MFA is required:"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_3badda88","line":102,"updated":"2015-12-14 23:12:07.000000000","message":"Based on the TOTP spec, it is required to support \u0027Resynchronization\u0027. Not sure it is necessary to a specific one like google authenticator, but it is required for .e.g hardware tokens.","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":18981,"name":"Fangzhou Xu","email":"fangxu@ebaysf.com","username":"fangxu"},"change_message_id":"61e7b6ac58353c0988a7a74491d05ea497a92e0e","unresolved":false,"context_lines":[{"line_number":99,"context_line":"For the initial implementation, when a user gets MFA enabled, the user\u0027s"},{"line_number":100,"context_line":"previous tokens would still be valid.  Services will need to change their"},{"line_number":101,"context_line":"policy.json file if they want to authorize on the auth method. Also, we\u0027ll need"},{"line_number":102,"context_line":"to update auth_token middleware to convey the auth methods."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Authentication ceremony when MFA is required:"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_77d04454","line":102,"in_reply_to":"5a710552_0a4d2172","updated":"2015-12-15 08:01:35.000000000","message":"I just checked: https://tools.ietf.org/html/rfc6238#page-7","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"cbbe33b5858db0157075068bb2137e194d8bc8c8","unresolved":false,"context_lines":[{"line_number":99,"context_line":"For the initial implementation, when a user gets MFA enabled, the user\u0027s"},{"line_number":100,"context_line":"previous tokens would still be valid.  Services will need to change their"},{"line_number":101,"context_line":"policy.json file if they want to authorize on the auth method. Also, we\u0027ll need"},{"line_number":102,"context_line":"to update auth_token middleware to convey the auth methods."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Authentication ceremony when MFA is required:"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_0a4d2172","line":102,"in_reply_to":"5a710552_3badda88","updated":"2015-12-15 01:12:57.000000000","message":"TOTP does not need resync. If you we are doing HOTP, then we\u0027ll need to resync the counter/sequence from time to time.","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"29394834389d2396ed3365244bdeba96de41f54d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"For the initial implementation, when a user gets MFA enabled, the user\u0027s"},{"line_number":100,"context_line":"previous tokens would still be valid.  Services will need to change their"},{"line_number":101,"context_line":"policy.json file if they want to authorize on the auth method. Also, we\u0027ll need"},{"line_number":102,"context_line":"to update auth_token middleware to convey the auth methods."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Authentication ceremony when MFA is required:"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_b96e7f94","line":102,"in_reply_to":"5a710552_77d04454","updated":"2015-12-15 17:27:43.000000000","message":"No, I don\u0027t think we need that kind of complexity. Servers should always be running with NTP enabled. If client device is having a habit of time drift, the device likely need to be replaced anyway.\n\nbtw, we don\u0027t even have a mechanism to lockup the user account on consecutive auth failures. Nor do we have a mechanism to force shared secret rotation. Lets get the basics done, then think about improving it. Baby steps. :)","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"cbbe33b5858db0157075068bb2137e194d8bc8c8","unresolved":false,"context_lines":[{"line_number":101,"context_line":"policy.json file if they want to authorize on the auth method. Also, we\u0027ll need"},{"line_number":102,"context_line":"to update auth_token middleware to convey the auth methods."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Authentication ceremony when MFA is required:"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"* User authenticates with valid password and receives unauthorized response"},{"line_number":107,"context_line":"  with an unscoped token in header."}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_4a6249da","line":104,"updated":"2015-12-15 01:12:57.000000000","message":"I don\u0027t understand this use case all. Why issue an unscoped token at all? User is either completely authenticated or not. Why is there necessary to issue an unscoped token in between?","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"5701744f3f36d589e054950456f40da41d26732b","unresolved":false,"context_lines":[{"line_number":101,"context_line":"policy.json file if they want to authorize on the auth method. Also, we\u0027ll need"},{"line_number":102,"context_line":"to update auth_token middleware to convey the auth methods."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Authentication ceremony when MFA is required:"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"* User authenticates with valid password and receives unauthorized response"},{"line_number":107,"context_line":"  with an unscoped token in header."}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_d3d0fe55","line":104,"in_reply_to":"5a710552_4a6249da","updated":"2016-01-04 19:45:16.000000000","message":"This is to allow the use of keystone via the ui.\nIf we do not allow this the ui would have to store the credentials of the user to be able to authenticate when multiple mfa methods are required.","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b3f4acc40ec133433881e3566aa6af760a65f4af","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  with an unscoped token in header."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"* User sends second auth request with unscoped token and OTP and receives"},{"line_number":110,"context_line":"  scoped token."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Single request:"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_c53ab5e7","line":110,"updated":"2015-12-14 21:51:16.000000000","message":"++","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"cbbe33b5858db0157075068bb2137e194d8bc8c8","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  with an unscoped token in header."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"* User sends second auth request with unscoped token and OTP and receives"},{"line_number":110,"context_line":"  scoped token."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Single request:"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_2aa01df4","line":110,"in_reply_to":"5a710552_c53ab5e7","updated":"2015-12-15 01:12:57.000000000","message":"There\u0027s no example of this.","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b3f4acc40ec133433881e3566aa6af760a65f4af","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Single request:"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"* User authenticates with both password and OTP and receives scoped token."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Proposed new api calls:"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_e53fb1d4","line":114,"updated":"2015-12-14 21:51:16.000000000","message":"++","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b3f4acc40ec133433881e3566aa6af760a65f4af","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"* User authenticates with both password and OTP and receives scoped token."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Proposed new api calls:"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* Create user TOTP::"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_452fa5a1","line":116,"updated":"2015-12-14 21:51:16.000000000","message":"Move the API documentation into it\u0027s own file in https://github.com/openstack/keystone-specs/tree/master/api/v3","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"cbbe33b5858db0157075068bb2137e194d8bc8c8","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Proposed new api calls:"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* Create user TOTP::"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    POST /v3/users/{user_id}/totp"},{"line_number":121,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_aaac0dee","line":118,"updated":"2015-12-15 01:12:57.000000000","message":"No need for the new APIs. Just add a PUT API to /v3/credentials and pick a new key type for the TOTP shared secret.","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":18981,"name":"Fangzhou Xu","email":"fangxu@ebaysf.com","username":"fangxu"},"change_message_id":"7079ee904cad38e02720a9125b4c2a83467bb72a","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* Create user TOTP::"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    POST /v3/users/{user_id}/totp"},{"line_number":121,"context_line":"    {"},{"line_number":122,"context_line":"        \u0027user\u0027: {"},{"line_number":123,"context_line":"            \u0027totp\u0027: \u002701234567890123456\u0027"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_0ca6aac1","line":120,"updated":"2015-12-14 23:12:07.000000000","message":"Could you describe the use case for this API?","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b3f4acc40ec133433881e3566aa6af760a65f4af","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    POST /v3/users/{user_id}/totp"},{"line_number":121,"context_line":"    {"},{"line_number":122,"context_line":"        \u0027user\u0027: {"},{"line_number":123,"context_line":"            \u0027totp\u0027: \u002701234567890123456\u0027"},{"line_number":124,"context_line":"        }"},{"line_number":125,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_6503c110","line":122,"updated":"2015-12-14 21:51:16.000000000","message":"Based on the /totp, I would expect this to be called a \"totp\"","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b3f4acc40ec133433881e3566aa6af760a65f4af","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    POST /v3/users/{user_id}/totp"},{"line_number":121,"context_line":"    {"},{"line_number":122,"context_line":"        \u0027user\u0027: {"},{"line_number":123,"context_line":"            \u0027totp\u0027: \u002701234567890123456\u0027"},{"line_number":124,"context_line":"        }"},{"line_number":125,"context_line":"    }"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_a509a933","line":123,"updated":"2015-12-14 21:51:16.000000000","message":"is this a key or something?","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b3f4acc40ec133433881e3566aa6af760a65f4af","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        \u0027user\u0027: {"},{"line_number":123,"context_line":"            \u0027totp\u0027: \u002701234567890123456\u0027"},{"line_number":124,"context_line":"        }"},{"line_number":125,"context_line":"    }"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* Delete user totp::"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_00ff4b02","line":125,"updated":"2015-12-14 21:51:16.000000000","message":"This example is not valid JSON - validate all the examples!","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b3f4acc40ec133433881e3566aa6af760a65f4af","unresolved":false,"context_lines":[{"line_number":151,"context_line":"* Specify MFA for a domain.  This will force all users of a given domain to use"},{"line_number":152,"context_line":"  MFA methods::"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    PATCH /v3/domain/{domain_id}/auth-methods"},{"line_number":155,"context_line":"    {"},{"line_number":156,"context_line":"        \"user\": {"},{"line_number":157,"context_line":"            \"auth-methods\": ["}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_803a5bcc","line":154,"updated":"2015-12-14 21:51:16.000000000","message":"I feel like this should be a separate spec - as mentioned above, there\u0027s no use case presented for any of these /auth-methods calls.","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"edd524b8c919e143328e9496ee7a6bd876757207","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    }"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"* Enable / Disable MFA for a project::"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    PATCH /v3/project/{project_id}/auth-methods"},{"line_number":174,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_b67b297b","line":171,"updated":"2015-12-14 19:43:59.000000000","message":"Specify MFA for a project.  This will force all users of a given project to use MFA methods.","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":18981,"name":"Fangzhou Xu","email":"fangxu@ebaysf.com","username":"fangxu"},"change_message_id":"7079ee904cad38e02720a9125b4c2a83467bb72a","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"* Enable / Disable MFA for a project::"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    PATCH /v3/project/{project_id}/auth-methods"},{"line_number":174,"context_line":"    {"},{"line_number":175,"context_line":"        \"user\": {"},{"line_number":176,"context_line":"            \"auth-methods\": ["}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_fb0432c7","line":173,"updated":"2015-12-14 23:12:07.000000000","message":"I assume it should work with hierarchical project, is that right?","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b3f4acc40ec133433881e3566aa6af760a65f4af","unresolved":false,"context_lines":[{"line_number":198,"context_line":"Describe any potential security impact on the system.  Some of the items to"},{"line_number":199,"context_line":"consider include:"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"* A users secret key to generate one-time password will need to be stored and"},{"line_number":202,"context_line":"  encrypted."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"* This change adds additional request data to the login process when MFA is"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_20528714","line":201,"updated":"2015-12-14 21:51:16.000000000","message":"user\u0027s","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"5701744f3f36d589e054950456f40da41d26732b","unresolved":false,"context_lines":[{"line_number":198,"context_line":"Describe any potential security impact on the system.  Some of the items to"},{"line_number":199,"context_line":"consider include:"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"* A users secret key to generate one-time password will need to be stored and"},{"line_number":202,"context_line":"  encrypted."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"* This change adds additional request data to the login process when MFA is"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_731caa13","line":201,"in_reply_to":"5a710552_20528714","updated":"2016-01-04 19:45:16.000000000","message":"Done","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b3f4acc40ec133433881e3566aa6af760a65f4af","unresolved":false,"context_lines":[{"line_number":231,"context_line":"* This would be an opt-in feature and not enabled by default."},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"* This change would add a new driver for one time password.  This could be"},{"line_number":234,"context_line":"  updated by other backends that want to use a different implementation."},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"* Deployer would have to specify OTP keystone configuration.  This may be more"},{"line_number":237,"context_line":"  difficult given the current keystone implementation, since the password"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_0082eb52","line":234,"updated":"2015-12-14 21:51:16.000000000","message":"Which strongly suggests that this should be done in it\u0027s own repo!","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"5701744f3f36d589e054950456f40da41d26732b","unresolved":false,"context_lines":[{"line_number":231,"context_line":"* This would be an opt-in feature and not enabled by default."},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"* This change would add a new driver for one time password.  This could be"},{"line_number":234,"context_line":"  updated by other backends that want to use a different implementation."},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"* Deployer would have to specify OTP keystone configuration.  This may be more"},{"line_number":237,"context_line":"  difficult given the current keystone implementation, since the password"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_b3e0d2fb","line":234,"in_reply_to":"5a710552_0082eb52","updated":"2016-01-04 19:45:16.000000000","message":"Done","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b3f4acc40ec133433881e3566aa6af760a65f4af","unresolved":false,"context_lines":[{"line_number":236,"context_line":"* Deployer would have to specify OTP keystone configuration.  This may be more"},{"line_number":237,"context_line":"  difficult given the current keystone implementation, since the password"},{"line_number":238,"context_line":"  would have to be aware of required OTP methods to reply with an unauthorized"},{"line_number":239,"context_line":"  response."},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"Developer Impact"},{"line_number":242,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_c0a4e309","line":239,"updated":"2015-12-14 21:51:16.000000000","message":"This is an interesting one, and I\u0027m not sure I follow. Can you elaborate in the spec?","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"5701744f3f36d589e054950456f40da41d26732b","unresolved":false,"context_lines":[{"line_number":236,"context_line":"* Deployer would have to specify OTP keystone configuration.  This may be more"},{"line_number":237,"context_line":"  difficult given the current keystone implementation, since the password"},{"line_number":238,"context_line":"  would have to be aware of required OTP methods to reply with an unauthorized"},{"line_number":239,"context_line":"  response."},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"Developer Impact"},{"line_number":242,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_93b4b6f2","line":239,"in_reply_to":"5a710552_c0a4e309","updated":"2016-01-04 19:45:16.000000000","message":"No longer valid, since the spec is now totp specific.","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":18981,"name":"Fangzhou Xu","email":"fangxu@ebaysf.com","username":"fangxu"},"change_message_id":"7079ee904cad38e02720a9125b4c2a83467bb72a","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"* Add a new One-time password authentication driver"},{"line_number":266,"context_line":"* Add a new multi-factor auth-plugin"},{"line_number":267,"context_line":"* Add resource to setup multi-factor for a user"},{"line_number":268,"context_line":"* Add/Update resource to toggle MFA enforcement for domains or projects without"},{"line_number":269,"context_line":"  breaking backwards compatibility."},{"line_number":270,"context_line":"* Document the process for setting up multi-factor deployment"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_4cd8321e","line":267,"updated":"2015-12-14 23:12:07.000000000","message":"I recommend to add workflow for this, as long as the related APIs. e.g. how to add a TOTP authenticator \u0026 share the secret key, unregister the TOTP authenticator, secret key storage etc.\n\nIt sounds like better to be another BP.","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"5701744f3f36d589e054950456f40da41d26732b","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"* Add a new One-time password authentication driver"},{"line_number":266,"context_line":"* Add a new multi-factor auth-plugin"},{"line_number":267,"context_line":"* Add resource to setup multi-factor for a user"},{"line_number":268,"context_line":"* Add/Update resource to toggle MFA enforcement for domains or projects without"},{"line_number":269,"context_line":"  breaking backwards compatibility."},{"line_number":270,"context_line":"* Document the process for setting up multi-factor deployment"}],"source_content_type":"text/x-rst","patch_set":25,"id":"5a710552_33c4e25d","line":267,"in_reply_to":"5a710552_4cd8321e","updated":"2016-01-04 19:45:16.000000000","message":"Done","commit_id":"0306720ca6290c5a86e42defb493b82ac7796303"}],"specs/mitaka/totp-auth.rst":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"4b6c3b06dac419b7332bc18e126364b41ce5633c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Currently Keystone only supports \"knowledge factor\" (something the user knows)"},{"line_number":31,"context_line":"without having to use a 3rd identity provider."},{"line_number":32,"context_line":"The goal of this change is to add a \"possession factor\" (something a user has)"},{"line_number":33,"context_line":"and restrict the auth method of a given user, project or domain."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Proposed Change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":26,"id":"fa69d971_a0012eb1","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":63},"updated":"2016-01-04 22:47:19.000000000","message":"This is part of the second spec. We are not doing auth method(s) per user/project/domain with this spec. Please take it out. How about this instead?\n\nThe goal of this change is to support \"possession factor\" (something a user has) for the keystone-managed users.","commit_id":"723ae7c5dc3105c059032d6eb3724301e1ed11f2"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"406c8e5b48b2c2372de32380ef63a8faa76fbcd1","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Currently Keystone only supports \"knowledge factor\" (something the user knows)"},{"line_number":31,"context_line":"without having to use a 3rd identity provider."},{"line_number":32,"context_line":"The goal of this change is to add a \"possession factor\" (something a user has)"},{"line_number":33,"context_line":"and restrict the auth method of a given user, project or domain."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Proposed Change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":26,"id":"fa69d971_70e0c496","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":63},"in_reply_to":"fa69d971_a0012eb1","updated":"2016-01-05 16:25:54.000000000","message":"Done","commit_id":"723ae7c5dc3105c059032d6eb3724301e1ed11f2"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"4b6c3b06dac419b7332bc18e126364b41ce5633c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"This implementation does not require the use of an external system to provide"},{"line_number":39,"context_line":"the second authentication method.  Optionally, Barbican can be used to manage"},{"line_number":40,"context_line":"the shared secret."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Implement OTP driver using TOTP that is compatible with Google Authenticator."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":26,"id":"fa69d971_a0c60e66","line":40,"range":{"start_line":39,"start_character":35,"end_line":40,"end_character":17},"updated":"2016-01-04 22:47:19.000000000","message":"We are not doing Barbican backend in this spec either. Please remove this sentence. That again should be a different spec.","commit_id":"723ae7c5dc3105c059032d6eb3724301e1ed11f2"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"406c8e5b48b2c2372de32380ef63a8faa76fbcd1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"This implementation does not require the use of an external system to provide"},{"line_number":39,"context_line":"the second authentication method.  Optionally, Barbican can be used to manage"},{"line_number":40,"context_line":"the shared secret."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Implement OTP driver using TOTP that is compatible with Google Authenticator."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":26,"id":"fa69d971_10f06866","line":40,"range":{"start_line":39,"start_character":35,"end_line":40,"end_character":17},"in_reply_to":"fa69d971_a0c60e66","updated":"2016-01-05 16:25:54.000000000","message":"Done","commit_id":"723ae7c5dc3105c059032d6eb3724301e1ed11f2"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"4b6c3b06dac419b7332bc18e126364b41ce5633c","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Implement OTP driver using TOTP that is compatible with Google Authenticator."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Store OTP secret: use the keystone credentials api to store totp passcode."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Example request::"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":26,"id":"fa69d971_a0ab6e74","line":44,"range":{"start_line":44,"start_character":73,"end_line":44,"end_character":74},"updated":"2016-01-04 22:47:19.000000000","message":"++. We\u0027ll need to pick a key type for the TOTP secrets. May even want to make it configurable, but I am OK either way.","commit_id":"723ae7c5dc3105c059032d6eb3724301e1ed11f2"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"406c8e5b48b2c2372de32380ef63a8faa76fbcd1","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Implement OTP driver using TOTP that is compatible with Google Authenticator."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Store OTP secret: use the keystone credentials api to store totp passcode."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Example request::"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":26,"id":"fa69d971_3051ec36","line":44,"range":{"start_line":44,"start_character":73,"end_line":44,"end_character":74},"in_reply_to":"fa69d971_a0ab6e74","updated":"2016-01-05 16:25:54.000000000","message":"Done","commit_id":"723ae7c5dc3105c059032d6eb3724301e1ed11f2"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"4b6c3b06dac419b7332bc18e126364b41ce5633c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      \"auth\": {"},{"line_number":50,"context_line":"          \"identity\": {"},{"line_number":51,"context_line":"              \"methods\": ["},{"line_number":52,"context_line":"                  \"totp\""},{"line_number":53,"context_line":"              ],"},{"line_number":54,"context_line":"              \"totp\": {"},{"line_number":55,"context_line":"                  \"user\": {"}],"source_content_type":"text/x-rst","patch_set":26,"id":"fa69d971_c01b02c9","line":52,"range":{"start_line":52,"start_character":23,"end_line":52,"end_character":24},"updated":"2016-01-04 22:47:19.000000000","message":"totp by itself wouldn\u0027t be MFA. Shouldn\u0027t it be used in conjunction with something else, like \"password\" or \"token\"? May want to provide a more realistic example.","commit_id":"723ae7c5dc3105c059032d6eb3724301e1ed11f2"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"406c8e5b48b2c2372de32380ef63a8faa76fbcd1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      \"auth\": {"},{"line_number":50,"context_line":"          \"identity\": {"},{"line_number":51,"context_line":"              \"methods\": ["},{"line_number":52,"context_line":"                  \"totp\""},{"line_number":53,"context_line":"              ],"},{"line_number":54,"context_line":"              \"totp\": {"},{"line_number":55,"context_line":"                  \"user\": {"}],"source_content_type":"text/x-rst","patch_set":26,"id":"fa69d971_f03d94dd","line":52,"range":{"start_line":52,"start_character":23,"end_line":52,"end_character":24},"in_reply_to":"fa69d971_c01b02c9","updated":"2016-01-05 16:25:54.000000000","message":"Done","commit_id":"723ae7c5dc3105c059032d6eb3724301e1ed11f2"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"4b6c3b06dac419b7332bc18e126364b41ce5633c","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"The auth plugin will require a user to specify both their username along with a"},{"line_number":73,"context_line":"client-generated OTP.  The plugin will then verify the OTP is valid for the"},{"line_number":74,"context_line":"user."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":26,"id":"fa69d971_a0912ef3","line":74,"range":{"start_line":74,"start_character":4,"end_line":74,"end_character":5},"updated":"2016-01-04 22:47:19.000000000","message":"May want to state how the TOTP secret key lookup/validation is going to go down. Like,\n\n 1. Keystone will lookup all the enabled credentials with credential type \"TOTP\" for the give user and use them to validate the HMAC.\n 2. If one matches, the authentication is considered successful.\n 3. If none match, authentication is considered unsuccessful.","commit_id":"723ae7c5dc3105c059032d6eb3724301e1ed11f2"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"406c8e5b48b2c2372de32380ef63a8faa76fbcd1","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"The auth plugin will require a user to specify both their username along with a"},{"line_number":73,"context_line":"client-generated OTP.  The plugin will then verify the OTP is valid for the"},{"line_number":74,"context_line":"user."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":26,"id":"fa69d971_6b6775b7","line":74,"range":{"start_line":74,"start_character":4,"end_line":74,"end_character":5},"in_reply_to":"fa69d971_a0912ef3","updated":"2016-01-05 16:25:54.000000000","message":"Done","commit_id":"723ae7c5dc3105c059032d6eb3724301e1ed11f2"},{"author":{"_account_id":13729,"name":"Bob Jacoby","email":"jacorob@gmail.com"},"change_message_id":"a437e6782090c0ce5d5e981cb0e20647720bd79f","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Add a `totp` auth method."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Example request that uses both totp and exising password pluguin::"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  {"},{"line_number":40,"context_line":"      \"auth\": {"}],"source_content_type":"text/x-rst","patch_set":31,"id":"9a68dd71_078757d8","line":37,"updated":"2016-01-26 16:12:44.000000000","message":"These examples both show using TOTP auth in combination with another form (password or token). \n\nCan TOTP be used as the sole means for auth as well (e.g. - standalone)?","commit_id":"29eb310de1d791f0b0856ac2c97948908942f5a9"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"557f621c275b0cf54024750ecb9624ea5049adab","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Add a `totp` auth method."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Example request that uses both totp and exising password pluguin::"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  {"},{"line_number":40,"context_line":"      \"auth\": {"}],"source_content_type":"text/x-rst","patch_set":31,"id":"9a68dd71_de800e8e","line":37,"in_reply_to":"9a68dd71_078757d8","updated":"2016-01-27 02:47:10.000000000","message":"Good question - I added another example with only totp as the authentication method.","commit_id":"29eb310de1d791f0b0856ac2c97948908942f5a9"},{"author":{"_account_id":13729,"name":"Bob Jacoby","email":"jacorob@gmail.com"},"change_message_id":"a437e6782090c0ce5d5e981cb0e20647720bd79f","unresolved":false,"context_lines":[{"line_number":94,"context_line":"will be multiple implementations of the TOTP plugin based on the backend used"},{"line_number":95,"context_line":"to validate."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"The auth plugin will require a user to specify their username, their (static)"},{"line_number":98,"context_line":"passcode and a client-generated one time password.  The plugin will then verify"},{"line_number":99,"context_line":"the OTP is valid for the user."},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":31,"id":"9a68dd71_8c2b6c94","line":97,"updated":"2016-01-26 16:12:44.000000000","message":"I\u0027m not sure of the exact context of this statement. It states the user must provide:\n1. username\n2. (static) passcode\n3. client-generated one time password.\n\nHowever, the union of information provided in the example (for password + totp auth) is:\n1. user Id\n2. password\n3. client-generated one time password","commit_id":"29eb310de1d791f0b0856ac2c97948908942f5a9"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"557f621c275b0cf54024750ecb9624ea5049adab","unresolved":false,"context_lines":[{"line_number":94,"context_line":"will be multiple implementations of the TOTP plugin based on the backend used"},{"line_number":95,"context_line":"to validate."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"The auth plugin will require a user to specify their username, their (static)"},{"line_number":98,"context_line":"passcode and a client-generated one time password.  The plugin will then verify"},{"line_number":99,"context_line":"the OTP is valid for the user."},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":31,"id":"9a68dd71_9e493691","line":97,"in_reply_to":"9a68dd71_8c2b6c94","updated":"2016-01-27 02:47:10.000000000","message":"I cleared this up - a new patch is on the way.","commit_id":"29eb310de1d791f0b0856ac2c97948908942f5a9"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"c8d8aae681e36cd98abac8498a4aa45c071369ef","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Support TOTP Authentication"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp totp-auth \u003chttps://blueprints.launchpad.net/keystone/+spec/totp-auth\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Support Time-Based One-Time Password (TOTP) Authentication as a distinct"},{"line_number":14,"context_line":"authentication mechanism."}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_e6b765f3","line":11,"range":{"start_line":11,"start_character":15,"end_line":11,"end_character":72},"updated":"2016-01-28 17:49:02.000000000","message":"link gives 404","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"809fc5a0b772c650636dac12c30bf20e3e7b3818","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Support TOTP Authentication"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp totp-auth \u003chttps://blueprints.launchpad.net/keystone/+spec/totp-auth\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Support Time-Based One-Time Password (TOTP) Authentication as a distinct"},{"line_number":14,"context_line":"authentication mechanism."}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_dc7f9c64","line":11,"in_reply_to":"7a5de9d1_e6b765f3","updated":"2016-02-01 17:34:46.000000000","message":"This link isn\u0027t usually created until after the spec merges.","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"05dff553d1339a8fb481096ac9ba7d051c69c122","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Support Time-Based One-Time Password (TOTP) Authentication as a distinct"},{"line_number":14,"context_line":"authentication mechanism."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"Time-based One-time Password Algorithm (TOTP) is an algorithm that computes"},{"line_number":17,"context_line":"a one-time password from a shared secret key and the current time. It has been"},{"line_number":18,"context_line":"adopted as Internet Engineering Task Force standard RFC 6238, is the"},{"line_number":19,"context_line":"cornerstone of Initiative For Open Authentication (OATH), and is used in a"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_83554351","line":16,"updated":"2016-01-28 17:37:58.000000000","message":"nit: You can create a block quote by indenting this, just don\u0027t use a double colon:: in the previous paragraph (so it won\u0027t be treated as a literal code block)","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2a4c3c068154d25035ab9ac7e675cca621d377e4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Support Time-Based One-Time Password (TOTP) Authentication as a distinct"},{"line_number":14,"context_line":"authentication mechanism."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"Time-based One-time Password Algorithm (TOTP) is an algorithm that computes"},{"line_number":17,"context_line":"a one-time password from a shared secret key and the current time. It has been"},{"line_number":18,"context_line":"adopted as Internet Engineering Task Force standard RFC 6238, is the"},{"line_number":19,"context_line":"cornerstone of Initiative For Open Authentication (OATH), and is used in a"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_86731180","line":16,"in_reply_to":"7a5de9d1_83554351","updated":"2016-01-28 17:50:01.000000000","message":"Done","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"c8d8aae681e36cd98abac8498a4aa45c071369ef","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"Time-based One-time Password Algorithm (TOTP) is an algorithm that computes"},{"line_number":17,"context_line":"a one-time password from a shared secret key and the current time. It has been"},{"line_number":18,"context_line":"adopted as Internet Engineering Task Force standard RFC 6238, is the"},{"line_number":19,"context_line":"cornerstone of Initiative For Open Authentication (OATH), and is used in a"},{"line_number":20,"context_line":"number of two-factor authentication systems.\""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_06896126","line":18,"range":{"start_line":18,"start_character":52,"end_line":18,"end_character":60},"updated":"2016-01-28 17:49:02.000000000","message":"Would be worth it to have a link to it","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"809fc5a0b772c650636dac12c30bf20e3e7b3818","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"Time-based One-time Password Algorithm (TOTP) is an algorithm that computes"},{"line_number":17,"context_line":"a one-time password from a shared secret key and the current time. It has been"},{"line_number":18,"context_line":"adopted as Internet Engineering Task Force standard RFC 6238, is the"},{"line_number":19,"context_line":"cornerstone of Initiative For Open Authentication (OATH), and is used in a"},{"line_number":20,"context_line":"number of two-factor authentication systems.\""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_5ce3ac33","line":18,"in_reply_to":"7a5de9d1_06896126","updated":"2016-02-01 17:34:46.000000000","message":"This is included in the references below.","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"c8d8aae681e36cd98abac8498a4aa45c071369ef","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Proposed Change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Add a `totp` auth method."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Example request that uses both totp and exising password plugin::"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_a6788d2c","line":35,"range":{"start_line":35,"start_character":7,"end_line":35,"end_character":11},"updated":"2016-01-28 17:49:02.000000000","message":"(nit) TOTP","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"809fc5a0b772c650636dac12c30bf20e3e7b3818","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Proposed Change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Add a `totp` auth method."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Example request that uses both totp and exising password plugin::"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_d70f7586","line":35,"in_reply_to":"7a5de9d1_a6788d2c","updated":"2016-02-01 17:34:46.000000000","message":"Done","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"c8d8aae681e36cd98abac8498a4aa45c071369ef","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      }"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Example request that uses both totp and exising password plugin::"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  {"},{"line_number":63,"context_line":"      \"auth\": {"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_06908142","line":60,"range":{"start_line":60,"start_character":40,"end_line":60,"end_character":47},"updated":"2016-01-28 17:49:02.000000000","message":"(nit) existing","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"05dff553d1339a8fb481096ac9ba7d051c69c122","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      }"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Example request that uses both totp and exising password plugin::"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  {"},{"line_number":63,"context_line":"      \"auth\": {"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_63e1279a","line":60,"updated":"2016-01-28 17:37:58.000000000","message":"nit: TOTP","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"809fc5a0b772c650636dac12c30bf20e3e7b3818","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      }"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Example request that uses both totp and exising password plugin::"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  {"},{"line_number":63,"context_line":"      \"auth\": {"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_9c47e41c","line":60,"in_reply_to":"7a5de9d1_06908142","updated":"2016-02-01 17:34:46.000000000","message":"Done","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2a4c3c068154d25035ab9ac7e675cca621d377e4","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      }"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Example request that uses both totp and exising password plugin::"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  {"},{"line_number":63,"context_line":"      \"auth\": {"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_26301d9e","line":60,"in_reply_to":"7a5de9d1_63e1279a","updated":"2016-01-28 17:50:01.000000000","message":"Done","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"05dff553d1339a8fb481096ac9ba7d051c69c122","unresolved":false,"context_lines":[{"line_number":86,"context_line":"      }"},{"line_number":87,"context_line":"  }"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Example request that uses both token and totp::"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  {"},{"line_number":92,"context_line":"      \"auth\": {"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_a3fe3f36","line":89,"updated":"2016-01-28 17:37:58.000000000","message":"nit: TOTP","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2a4c3c068154d25035ab9ac7e675cca621d377e4","unresolved":false,"context_lines":[{"line_number":86,"context_line":"      }"},{"line_number":87,"context_line":"  }"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Example request that uses both token and totp::"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  {"},{"line_number":92,"context_line":"      \"auth\": {"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_661615f3","line":89,"in_reply_to":"7a5de9d1_a3fe3f36","updated":"2016-01-28 17:50:01.000000000","message":"Done","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"05dff553d1339a8fb481096ac9ba7d051c69c122","unresolved":false,"context_lines":[{"line_number":113,"context_line":"  }"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"The totp plugin can be swapped in by updating Keystone configuration. There"},{"line_number":117,"context_line":"will be multiple implementations of the TOTP plugin based on the backend used"},{"line_number":118,"context_line":"to validate."},{"line_number":119,"context_line":""}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_43fd0b39","line":116,"updated":"2016-01-28 17:37:58.000000000","message":"nit: TOTP","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2a4c3c068154d25035ab9ac7e675cca621d377e4","unresolved":false,"context_lines":[{"line_number":113,"context_line":"  }"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"The totp plugin can be swapped in by updating Keystone configuration. There"},{"line_number":117,"context_line":"will be multiple implementations of the TOTP plugin based on the backend used"},{"line_number":118,"context_line":"to validate."},{"line_number":119,"context_line":""}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_26d7bd24","line":116,"in_reply_to":"7a5de9d1_43fd0b39","updated":"2016-01-28 17:50:01.000000000","message":"Done","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"05dff553d1339a8fb481096ac9ba7d051c69c122","unresolved":false,"context_lines":[{"line_number":117,"context_line":"will be multiple implementations of the TOTP plugin based on the backend used"},{"line_number":118,"context_line":"to validate."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"The auth plugin will require a user to specify their username and a"},{"line_number":121,"context_line":"client-generated one time password. The plugin will then verify that the one"},{"line_number":122,"context_line":"time password is valid for the user."},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_83b1c391","line":120,"updated":"2016-01-28 17:37:58.000000000","message":"user ID, not name (or make it clear it is supposed to support both domain ID / domain name + user name, or a globally unique user ID as the examples show.","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2a4c3c068154d25035ab9ac7e675cca621d377e4","unresolved":false,"context_lines":[{"line_number":117,"context_line":"will be multiple implementations of the TOTP plugin based on the backend used"},{"line_number":118,"context_line":"to validate."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"The auth plugin will require a user to specify their username and a"},{"line_number":121,"context_line":"client-generated one time password. The plugin will then verify that the one"},{"line_number":122,"context_line":"time password is valid for the user."},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_a6cacd6c","line":120,"in_reply_to":"7a5de9d1_83b1c391","updated":"2016-01-28 17:50:01.000000000","message":"Done","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"8f87f15bd73a7ec65b1dab5db069759b2ecf0edb","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"* If none match, authentication is considered unsuccessful."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Once Keystone supports different authentication factors, subsequent"},{"line_number":132,"context_line":"specifications can be proposed that implement true multi-factor authentication"},{"line_number":133,"context_line":"in Keystone. This work is a precursor to multi-factor because it introduces a"},{"line_number":134,"context_line":"new authentication factor outside of what Keystone currently supports."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Alternatives"},{"line_number":137,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_2686dd65","line":134,"range":{"start_line":131,"start_character":0,"end_line":134,"end_character":70},"updated":"2016-01-28 17:45:00.000000000","message":"This could be eliminated (NIT) it doesn\u0027t matter for the spec.","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2a4c3c068154d25035ab9ac7e675cca621d377e4","unresolved":false,"context_lines":[{"line_number":131,"context_line":"Once Keystone supports different authentication factors, subsequent"},{"line_number":132,"context_line":"specifications can be proposed that implement true multi-factor authentication"},{"line_number":133,"context_line":"in Keystone. This work is a precursor to multi-factor because it introduces a"},{"line_number":134,"context_line":"new authentication factor outside of what Keystone currently supports."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Alternatives"},{"line_number":137,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_06bba1e6","line":134,"in_reply_to":"7a5de9d1_2686dd65","updated":"2016-01-28 17:50:01.000000000","message":"Done","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"1f66c859119dd8502879cacb81bb12bbf2ba2660","unresolved":false,"context_lines":[{"line_number":132,"context_line":"specifications can be proposed that implement true multi-factor authentication"},{"line_number":133,"context_line":"in Keystone. This work is a precursor to multi-factor because it introduces a"},{"line_number":134,"context_line":"new authentication factor outside of what Keystone currently supports."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Alternatives"},{"line_number":137,"context_line":"------------"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_a6c64d47","line":135,"updated":"2016-01-28 17:49:05.000000000","message":"Please add a note here.\n\nWe do not support time sync compensation as we are expecting the client-server time drift is fairly minimum.","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"809fc5a0b772c650636dac12c30bf20e3e7b3818","unresolved":false,"context_lines":[{"line_number":132,"context_line":"specifications can be proposed that implement true multi-factor authentication"},{"line_number":133,"context_line":"in Keystone. This work is a precursor to multi-factor because it introduces a"},{"line_number":134,"context_line":"new authentication factor outside of what Keystone currently supports."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Alternatives"},{"line_number":137,"context_line":"------------"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_fcd37836","line":135,"in_reply_to":"7a5de9d1_a6c64d47","updated":"2016-02-01 17:34:46.000000000","message":"Done","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"8f87f15bd73a7ec65b1dab5db069759b2ecf0edb","unresolved":false,"context_lines":[{"line_number":144,"context_line":"Describe any potential security impact on the system.  Some of the items to"},{"line_number":145,"context_line":"consider include:"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"* A user\u0027s secret key to generate one-time passwords will need to be stored and"},{"line_number":148,"context_line":"  encrypted."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"* This change adds additional request data to the login process when MFA is"},{"line_number":151,"context_line":"  enabled. Users need to be aware when MFA is enabled and specify their"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_a6d96d85","line":148,"range":{"start_line":147,"start_character":0,"end_line":148,"end_character":12},"updated":"2016-01-28 17:45:00.000000000","message":"What is the encryption? please expand [followup] ROT13?","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"809fc5a0b772c650636dac12c30bf20e3e7b3818","unresolved":false,"context_lines":[{"line_number":145,"context_line":"consider include:"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"* A user\u0027s secret key to generate one-time passwords will need to be stored and"},{"line_number":148,"context_line":"  encrypted."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"* This change adds additional request data to the login process when MFA is"},{"line_number":151,"context_line":"  enabled. Users need to be aware when MFA is enabled and specify their"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_7727a112","line":148,"in_reply_to":"7a5de9d1_66ee15b6","updated":"2016-02-01 17:34:46.000000000","message":"Done","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2a4c3c068154d25035ab9ac7e675cca621d377e4","unresolved":false,"context_lines":[{"line_number":145,"context_line":"consider include:"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"* A user\u0027s secret key to generate one-time passwords will need to be stored and"},{"line_number":148,"context_line":"  encrypted."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"* This change adds additional request data to the login process when MFA is"},{"line_number":151,"context_line":"  enabled. Users need to be aware when MFA is enabled and specify their"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_66ee15b6","line":148,"in_reply_to":"7a5de9d1_a6d96d85","updated":"2016-01-28 17:50:01.000000000","message":"I\u0027ll do this in a follow up.","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"8f87f15bd73a7ec65b1dab5db069759b2ecf0edb","unresolved":false,"context_lines":[{"line_number":147,"context_line":"* A user\u0027s secret key to generate one-time passwords will need to be stored and"},{"line_number":148,"context_line":"  encrypted."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"* This change adds additional request data to the login process when MFA is"},{"line_number":151,"context_line":"  enabled. Users need to be aware when MFA is enabled and specify their"},{"line_number":152,"context_line":"  \"possession factor\" in the request."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"* The proposed algorithms involve the use of cryptography (HMAC)."},{"line_number":155,"context_line":""}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_465679d3","line":152,"range":{"start_line":150,"start_character":0,"end_line":152,"end_character":37},"updated":"2016-01-28 17:45:00.000000000","message":"Remove this.","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2a4c3c068154d25035ab9ac7e675cca621d377e4","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"* This change adds additional request data to the login process when MFA is"},{"line_number":151,"context_line":"  enabled. Users need to be aware when MFA is enabled and specify their"},{"line_number":152,"context_line":"  \"possession factor\" in the request."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"* The proposed algorithms involve the use of cryptography (HMAC)."},{"line_number":155,"context_line":""}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_a6cded5e","line":152,"in_reply_to":"7a5de9d1_465679d3","updated":"2016-01-28 17:50:01.000000000","message":"Done","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"8f87f15bd73a7ec65b1dab5db069759b2ecf0edb","unresolved":false,"context_lines":[{"line_number":151,"context_line":"  enabled. Users need to be aware when MFA is enabled and specify their"},{"line_number":152,"context_line":"  \"possession factor\" in the request."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"* The proposed algorithms involve the use of cryptography (HMAC)."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Notifications Impact"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_c60fc9df","line":154,"range":{"start_line":154,"start_character":0,"end_line":154,"end_character":65},"updated":"2016-01-28 17:45:00.000000000","message":"Is this for the encryption? or for TOTP calc?","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2a4c3c068154d25035ab9ac7e675cca621d377e4","unresolved":false,"context_lines":[{"line_number":151,"context_line":"  enabled. Users need to be aware when MFA is enabled and specify their"},{"line_number":152,"context_line":"  \"possession factor\" in the request."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"* The proposed algorithms involve the use of cryptography (HMAC)."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Notifications Impact"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_66a9357b","line":154,"in_reply_to":"7a5de9d1_c60fc9df","updated":"2016-01-28 17:50:01.000000000","message":"Done","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"8f87f15bd73a7ec65b1dab5db069759b2ecf0edb","unresolved":false,"context_lines":[{"line_number":157,"context_line":"Notifications Impact"},{"line_number":158,"context_line":"--------------------"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"* All auths are CADFied"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Other End User Impact"},{"line_number":163,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_e6120509","line":160,"range":{"start_line":160,"start_character":1,"end_line":160,"end_character":23},"updated":"2016-01-28 17:45:00.000000000","message":"This can be dropped. this is already the case.","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2a4c3c068154d25035ab9ac7e675cca621d377e4","unresolved":false,"context_lines":[{"line_number":157,"context_line":"Notifications Impact"},{"line_number":158,"context_line":"--------------------"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"* All auths are CADFied"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Other End User Impact"},{"line_number":163,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_a6916d54","line":160,"in_reply_to":"7a5de9d1_e6120509","updated":"2016-01-28 17:50:01.000000000","message":"Done","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"05dff553d1339a8fb481096ac9ba7d051c69c122","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"  [auth]"},{"line_number":189,"context_line":"  methods \u003d password, totp"},{"line_number":190,"context_line":"  totp \u003d pkg.path.mfa.Totp"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"Implementation"},{"line_number":193,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_8326a3cc","line":190,"updated":"2016-01-28 17:37:58.000000000","message":"++","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"05dff553d1339a8fb481096ac9ba7d051c69c122","unresolved":false,"context_lines":[{"line_number":220,"context_line":"  \u003chttps://code.google.com/p/google-authenticator\u003e`_"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"* `TOTP"},{"line_number":223,"context_line":"  \u003chttps://tools.ietf.org/html/rfc6238\u003e`_"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"* `Knowledge factor"},{"line_number":226,"context_line":"  \u003chttp://en.wikipedia.org/wiki/Multi-factor_authentication#Knowledge_factors\u003e`_"}],"source_content_type":"text/x-rst","patch_set":32,"id":"7a5de9d1_e3151749","line":223,"updated":"2016-01-28 17:37:58.000000000","message":"Thanks!","commit_id":"bc18a9471c1e79e22c1a9389c72f4995ccbd6ad0"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4bc7925618f32418a785e00a01896cccf5471bf2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Support Time-Based One-Time Password (TOTP) Authentication as a distinct"},{"line_number":14,"context_line":"authentication mechanism."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  Time-based One-time Password Algorithm (TOTP) is an algorithm that computes a"},{"line_number":17,"context_line":"  one-time password from a shared secret key and the current time. It has been"},{"line_number":18,"context_line":"  adopted as Internet Engineering Task Force standard RFC 6238, is the"},{"line_number":19,"context_line":"  cornerstone of Initiative For Open Authentication (OATH), and is used in a"},{"line_number":20,"context_line":"  number of two-factor authentication systems."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"The algorithm proposed is already being used by Google for their multi-factor"},{"line_number":23,"context_line":"authentication (Gmail, Google Authenticator)."}],"source_content_type":"text/x-rst","patch_set":34,"id":"7a5de9d1_6f056f78","line":20,"range":{"start_line":16,"start_character":2,"end_line":20,"end_character":46},"updated":"2016-01-31 14:13:24.000000000","message":"why is this paragraph indented?","commit_id":"77934d270e89902a6049ca35cf80b03121423e4f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"f883bf94457eae2a0c5a6b9805e5e2a367b8d255","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  one-time password from a shared secret key and the current time. It has been"},{"line_number":18,"context_line":"  adopted as Internet Engineering Task Force standard RFC 6238, is the"},{"line_number":19,"context_line":"  cornerstone of Initiative For Open Authentication (OATH), and is used in a"},{"line_number":20,"context_line":"  number of two-factor authentication systems."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"The algorithm proposed is already being used by Google for their multi-factor"},{"line_number":23,"context_line":"authentication (Gmail, Google Authenticator)."}],"source_content_type":"text/x-rst","patch_set":34,"id":"7a5de9d1_8cf1726d","line":20,"in_reply_to":"7a5de9d1_6f056f78","updated":"2016-02-01 16:22:58.000000000","message":"It\u0027s an uncited block quote from wikipedia [needs citation]","commit_id":"77934d270e89902a6049ca35cf80b03121423e4f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4bc7925618f32418a785e00a01896cccf5471bf2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Proposed Change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Add a `TOTP` auth method."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Example request that uses both TOTP and exising password plugin::"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":34,"id":"7a5de9d1_9718c476","line":35,"range":{"start_line":35,"start_character":7,"end_line":35,"end_character":11},"updated":"2016-01-31 14:13:24.000000000","message":"this refers to the keystone plugin, not the acronym, so use ``totp``*","commit_id":"77934d270e89902a6049ca35cf80b03121423e4f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4bc7925618f32418a785e00a01896cccf5471bf2","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Add a `TOTP` auth method."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Example request that uses both TOTP and exising password plugin::"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  {"},{"line_number":40,"context_line":"      \"auth\": {"}],"source_content_type":"text/x-rst","patch_set":34,"id":"7a5de9d1_7732e8f3","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":65},"updated":"2016-01-31 14:13:24.000000000","message":"this is copy \u0026 paste of line 60. it does not use the existing password plugin. it uses no other plugins but TOTP.\n\nis there a point to just using the single TOTP plugin?","commit_id":"77934d270e89902a6049ca35cf80b03121423e4f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"f883bf94457eae2a0c5a6b9805e5e2a367b8d255","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Add a `TOTP` auth method."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Example request that uses both TOTP and exising password plugin::"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  {"},{"line_number":40,"context_line":"      \"auth\": {"}],"source_content_type":"text/x-rst","patch_set":34,"id":"7a5de9d1_8c4df29b","line":37,"in_reply_to":"7a5de9d1_7732e8f3","updated":"2016-02-01 16:22:58.000000000","message":"Just like any other authentication method, it should work in isolation to produce a token with corresponding methods (password, totp, token, etc) and, in newton, corresponding factors (know/have/are).\n\nIt should not be special.","commit_id":"77934d270e89902a6049ca35cf80b03121423e4f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4bc7925618f32418a785e00a01896cccf5471bf2","unresolved":false,"context_lines":[{"line_number":117,"context_line":"will be multiple implementations of the TOTP plugin based on the backend used"},{"line_number":118,"context_line":"to validate."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"The auth plugin will require a user to specify their user ID and a"},{"line_number":121,"context_line":"client-generated one time password. The plugin will then verify that the one"},{"line_number":122,"context_line":"time password is valid for the user."},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":34,"id":"7a5de9d1_172374a8","line":120,"range":{"start_line":120,"start_character":53,"end_line":120,"end_character":60},"updated":"2016-01-31 14:13:24.000000000","message":"there are a lot of instances of user ID, will specifying name + domain not work?\n\nsame question for project","commit_id":"77934d270e89902a6049ca35cf80b03121423e4f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"f883bf94457eae2a0c5a6b9805e5e2a367b8d255","unresolved":false,"context_lines":[{"line_number":117,"context_line":"will be multiple implementations of the TOTP plugin based on the backend used"},{"line_number":118,"context_line":"to validate."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"The auth plugin will require a user to specify their user ID and a"},{"line_number":121,"context_line":"client-generated one time password. The plugin will then verify that the one"},{"line_number":122,"context_line":"time password is valid for the user."},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":34,"id":"7a5de9d1_4c3a9ae8","line":120,"in_reply_to":"7a5de9d1_172374a8","updated":"2016-02-01 16:22:58.000000000","message":"I don\u0027t see a strong use case for bothering with name + domain support, considering most users will already have a token with their user ID. *shrug*","commit_id":"77934d270e89902a6049ca35cf80b03121423e4f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4bc7925618f32418a785e00a01896cccf5471bf2","unresolved":false,"context_lines":[{"line_number":121,"context_line":"client-generated one time password. The plugin will then verify that the one"},{"line_number":122,"context_line":"time password is valid for the user."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"* Keystone will lookup all the enabled credentials with credential type \"totp\""},{"line_number":125,"context_line":"  for the given user and use them to validate the HMAC."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* If one matches, the authentication is considered successful."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":34,"id":"7a5de9d1_b7438041","line":125,"range":{"start_line":124,"start_character":0,"end_line":125,"end_character":55},"updated":"2016-01-31 14:13:24.000000000","message":"where are the credentials stored? are these the same as the passcode? if so, use consistent terminology","commit_id":"77934d270e89902a6049ca35cf80b03121423e4f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"f883bf94457eae2a0c5a6b9805e5e2a367b8d255","unresolved":false,"context_lines":[{"line_number":122,"context_line":"time password is valid for the user."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"* Keystone will lookup all the enabled credentials with credential type \"totp\""},{"line_number":125,"context_line":"  for the given user and use them to validate the HMAC."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* If one matches, the authentication is considered successful."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":34,"id":"7a5de9d1_6c14364c","line":125,"in_reply_to":"7a5de9d1_b7438041","updated":"2016-02-01 16:22:58.000000000","message":"Where credentials are stored is an implementation detail that does not belong in the spec.","commit_id":"77934d270e89902a6049ca35cf80b03121423e4f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4bc7925618f32418a785e00a01896cccf5471bf2","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"None"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Example::"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"  [auth]"},{"line_number":186,"context_line":"  methods \u003d password, totp"},{"line_number":187,"context_line":"  totp \u003d pkg.path.mfa.Totp"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Implementation"},{"line_number":190,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":34,"id":"7a5de9d1_7749885f","line":187,"range":{"start_line":183,"start_character":0,"end_line":187,"end_character":26},"updated":"2016-01-31 14:13:24.000000000","message":"this is not developer impact","commit_id":"77934d270e89902a6049ca35cf80b03121423e4f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"f883bf94457eae2a0c5a6b9805e5e2a367b8d255","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"  [auth]"},{"line_number":186,"context_line":"  methods \u003d password, totp"},{"line_number":187,"context_line":"  totp \u003d pkg.path.mfa.Totp"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Implementation"},{"line_number":190,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":34,"id":"7a5de9d1_a72c8799","line":187,"in_reply_to":"7a5de9d1_7749885f","updated":"2016-02-01 16:22:58.000000000","message":"move to deployer impact?","commit_id":"77934d270e89902a6049ca35cf80b03121423e4f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5efd55e2398791e0fc79c6d0f5ef83c3c6aedc1d","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"  [auth]"},{"line_number":186,"context_line":"  methods \u003d password, totp"},{"line_number":187,"context_line":"  totp \u003d pkg.path.mfa.Totp"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Implementation"},{"line_number":190,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":34,"id":"7a5de9d1_c27f2e13","line":187,"in_reply_to":"7a5de9d1_a72c8799","updated":"2016-02-01 17:34:34.000000000","message":"++","commit_id":"77934d270e89902a6049ca35cf80b03121423e4f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4bc7925618f32418a785e00a01896cccf5471bf2","unresolved":false,"context_lines":[{"line_number":195,"context_line":"Primary assignee:"},{"line_number":196,"context_line":"  werner.mendizabal (Werner Mendizabal \u003cnonameentername@gmail.com\u003e)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Work Items"},{"line_number":199,"context_line":"----------"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"* Add a new one-time password authentication driver"}],"source_content_type":"text/x-rst","patch_set":34,"id":"7a5de9d1_3776b0a4","line":198,"range":{"start_line":198,"start_character":0,"end_line":198,"end_character":10},"updated":"2016-01-31 14:13:24.000000000","message":"not done just dropping in a new driver.\n\n* Add example APIs\n\n* Add the new auth plugin to keystoneauth\n\n* Add documentation that explains how to enable the feature, and any additional setup\n\n* Add any client library support that may be necessary","commit_id":"77934d270e89902a6049ca35cf80b03121423e4f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"f883bf94457eae2a0c5a6b9805e5e2a367b8d255","unresolved":false,"context_lines":[{"line_number":195,"context_line":"Primary assignee:"},{"line_number":196,"context_line":"  werner.mendizabal (Werner Mendizabal \u003cnonameentername@gmail.com\u003e)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Work Items"},{"line_number":199,"context_line":"----------"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"* Add a new one-time password authentication driver"}],"source_content_type":"text/x-rst","patch_set":34,"id":"7a5de9d1_67220fa5","line":198,"in_reply_to":"7a5de9d1_3776b0a4","updated":"2016-02-01 16:22:58.000000000","message":"++ although I\u0027m super confused by all the different spec directories myself.","commit_id":"77934d270e89902a6049ca35cf80b03121423e4f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b95ec767404befab32c85f19de763ca02cfd12a0","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"* Document the API and auth plugin examples using keystoneauth."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"* Add documentation that explains how to enable and configure the plugin in keystone."},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Dependencies"},{"line_number":226,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":35,"id":"7a5de9d1_4207be81","line":223,"updated":"2016-02-01 17:35:58.000000000","message":"This line is too long.","commit_id":"30fbbf859080c7d64c6270b1906eda639a5ba14f"}]}
