)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"7f96822794897f1d63d02e7ff725d52a10e22669","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-12-22 11:48:42 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enforce policy from keystoneclient"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic1001b3710d91c9ddf49a45f752a0e57c1f62e69"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3a961159_ef3c20c3","line":8,"updated":"2015-01-20 03:59:24.000000000","message":"Please consider adding a description and a link to the bp here.","commit_id":"3d2a57ece117738c1bb98559c5ba88f5eaa46762"}],"doc/source/index.rst":[{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"7f96822794897f1d63d02e7ff725d52a10e22669","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"   specs/kilo/*"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Keystone client approved specs:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":".. toctree::"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_6f491066","line":47,"updated":"2015-01-20 03:59:24.000000000","message":"The change on this file looks to be unrelated.","commit_id":"3d2a57ece117738c1bb98559c5ba88f5eaa46762"}],"specs/keystoneclient/policy-enforce.rst":[{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"b70c1f11bd94287ad437a9ac4ec2db68034f37f0","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp example \u003chttps://blueprints.launchpad.net/keystone/+spec/policy-kc\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"All of the projects in OpenStack is implement policy enfrocement themselves."},{"line_number":14,"context_line":"This leads to both cut and past code, divergent mechanisms, and the inability"},{"line_number":15,"context_line":"to synchronize policy enforcement.  The same policy rules can actually have"},{"line_number":16,"context_line":"different meansing depending on which server is implementing the policy check."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_ad559e1e","line":13,"updated":"2014-11-12 01:24:01.000000000","message":"implement policy enforcement","commit_id":"685ee5898a63566479767bc1f3bc043d9dec4645"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"b70c1f11bd94287ad437a9ac4ec2db68034f37f0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"This leads to both cut and past code, divergent mechanisms, and the inability"},{"line_number":15,"context_line":"to synchronize policy enforcement.  The same policy rules can actually have"},{"line_number":16,"context_line":"different meansing depending on which server is implementing the policy check."},{"line_number":17,"context_line":"Determining how to enforce policy against actual entities involes a scheme to"},{"line_number":18,"context_line":"flatten the object name from the dictionary, but this is not implemented"},{"line_number":19,"context_line":"across all of the services."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_2d41ae5a","line":17,"updated":"2014-11-12 01:24:01.000000000","message":"involves","commit_id":"685ee5898a63566479767bc1f3bc043d9dec4645"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"b70c1f11bd94287ad437a9ac4ec2db68034f37f0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Problem Description"},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"All of the projects in OpenStack is implement policy enfrocement themselves."},{"line_number":26,"context_line":"This leads to both cut and past code, divergent mechanisms, and the inability"},{"line_number":27,"context_line":"to synchronize policy enforcement.  The same policy rules can actually have"},{"line_number":28,"context_line":"different meansing depending on which server is implementing the policy check."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_6d22d6ba","line":25,"updated":"2014-11-12 01:24:01.000000000","message":"I think we have a copy and paste here :)","commit_id":"685ee5898a63566479767bc1f3bc043d9dec4645"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"b70c1f11bd94287ad437a9ac4ec2db68034f37f0","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The oslo policy mosulde will remain the heart of the engine.  Instad, what will"},{"line_number":42,"context_line":"change is how the parameters passed to the engine are extracted from the"},{"line_number":43,"context_line":"environemnt."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_c513a25a","line":43,"updated":"2014-11-12 01:24:01.000000000","message":"how is it done today? how will it be?","commit_id":"685ee5898a63566479767bc1f3bc043d9dec4645"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"ee114e4676c779ee69e13ccef0732c34e99c5ef1","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Move the Keystone policy enforcement to Keystoneclient. Integrate in the"},{"line_number":32,"context_line":"mechanisms that are different from Nova policy enforcement. Make sure that"},{"line_number":33,"context_line":"both Nova and Keystone use the common library."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"The Oslo policy module will remain the heart of the engine. Instead, what will"},{"line_number":36,"context_line":"change is how the parameters passed to the engine are extracted from the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_fe8a7bbd","line":33,"updated":"2014-11-15 11:12:36.000000000","message":"Why is only Nova and Keystone being cited here? If they are going to be the first ones to be targeted by this change, this should be explained somewhere?","commit_id":"885661f3ad1473c80368d7fbbee052fd116a417e"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"cbbcf3c3268916245ed1974291689d0c67bd281a","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Move the Keystone policy enforcement to Keystoneclient. Integrate in the"},{"line_number":32,"context_line":"mechanisms that are different from Nova policy enforcement. Make sure that"},{"line_number":33,"context_line":"both Nova and Keystone use the common library."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"The Oslo policy module will remain the heart of the engine. Instead, what will"},{"line_number":36,"context_line":"change is how the parameters passed to the engine are extracted from the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_bd471076","line":33,"in_reply_to":"5a890539_fe8a7bbd","updated":"2014-11-16 20:25:43.000000000","message":"+1","commit_id":"885661f3ad1473c80368d7fbbee052fd116a417e"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"cbbcf3c3268916245ed1974291689d0c67bd281a","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"The Oslo policy module will remain the heart of the engine. Instead, what will"},{"line_number":36,"context_line":"change is how the parameters passed to the engine are extracted from the"},{"line_number":37,"context_line":"environment, and that the call will be passed to Keystoneclient to process the"},{"line_number":38,"context_line":"policy. This allows further work, such as fetching the policy file from the"},{"line_number":39,"context_line":"Keystone server."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_9d3974f4","line":37,"updated":"2014-11-16 20:25:43.000000000","message":"Shouldn\u0027t we quickly mention where the policy files will be kept?","commit_id":"885661f3ad1473c80368d7fbbee052fd116a417e"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"701ec7c4c2cd13db99eb17c8e1e085962c1e2c6b","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"The Oslo policy module will remain the heart of the engine. Instead, what will"},{"line_number":36,"context_line":"change is how the parameters passed to the engine are extracted from the"},{"line_number":37,"context_line":"environment, and that the call will be passed to Keystoneclient to process the"},{"line_number":38,"context_line":"policy. This allows further work, such as fetching the policy file from the"},{"line_number":39,"context_line":"Keystone server."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_0c353c45","line":37,"in_reply_to":"5a890539_9d3974f4","updated":"2014-11-17 17:43:34.000000000","message":"+1","commit_id":"885661f3ad1473c80368d7fbbee052fd116a417e"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"ee114e4676c779ee69e13ccef0732c34e99c5ef1","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Work items or tasks -- break the feature up into the things that need to be"},{"line_number":136,"context_line":"done to implement it. Those parts might end up being done by different people,"},{"line_number":137,"context_line":"but we\u0027re mostly trying to understand the timeline for implementation."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_7ebe8b66","line":137,"updated":"2014-11-15 11:12:36.000000000","message":"Is the oslo.policy graduation a first step?","commit_id":"885661f3ad1473c80368d7fbbee052fd116a417e"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"cbbcf3c3268916245ed1974291689d0c67bd281a","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"* Links to mailing list or IRC discussions"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"* Links to notes from a summit session"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"* Links to relevant research, if appropriate"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_fd2358ba","line":171,"updated":"2014-11-16 20:25:43.000000000","message":"https://etherpad.openstack.org/p/kilo-keystone-policy-model-token-capabilities","commit_id":"885661f3ad1473c80368d7fbbee052fd116a417e"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4199e8fdbc2eed4aaaf658ab083b7a0e016d3bfa","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"All of the projects in OpenStack implement policy enforcement themselves."},{"line_number":21,"context_line":"This leads to both cut and past code, divergent mechanisms, and the inability"},{"line_number":22,"context_line":"to synchronize policy enforcement. The same policy rules can actually have"},{"line_number":23,"context_line":"different meanings depending on which server is implementing the policy check."},{"line_number":24,"context_line":"Determining how to enforce policy against actual entities involves a scheme to"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a890539_7d942344","line":21,"updated":"2014-12-01 19:30:10.000000000","message":"paste*","commit_id":"e04791ca3ac4d985c72cd0d24ae03f8d23dd4bf0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"9a70036c04e9d4b3da3900c62411c4714a83098e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"All of the projects in OpenStack implement policy enforcement themselves."},{"line_number":21,"context_line":"This leads to both cut and past code, divergent mechanisms, and the inability"},{"line_number":22,"context_line":"to synchronize policy enforcement. The same policy rules can actually have"},{"line_number":23,"context_line":"different meanings depending on which server is implementing the policy check."},{"line_number":24,"context_line":"Determining how to enforce policy against actual entities involves a scheme to"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a890539_4e5c541a","line":21,"in_reply_to":"5a890539_7d942344","updated":"2014-12-09 16:51:21.000000000","message":"Done","commit_id":"e04791ca3ac4d985c72cd0d24ae03f8d23dd4bf0"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"f6feacf342456c963f3a36c62f11121ef0d5cb7a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  patch security issues by releasing a new library instead of patching"},{"line_number":64,"context_line":"  individual services."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* Does this change involve cryptography or hashing?"},{"line_number":67,"context_line":"* No"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"* Does this change require the use of sudo or any elevated privileges?"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a890539_fa44d41c","line":66,"updated":"2014-11-27 19:00:36.000000000","message":"If the answers are No, I think that you don\u0027t need explain this here.","commit_id":"e04791ca3ac4d985c72cd0d24ae03f8d23dd4bf0"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"548299b22de93a5a8be926464375bd743ffbfad7","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  patch security issues by releasing a new library instead of patching"},{"line_number":64,"context_line":"  individual services."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* Does this change involve cryptography or hashing?"},{"line_number":67,"context_line":"* No"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"* Does this change require the use of sudo or any elevated privileges?"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a890539_ba1b2c7f","line":66,"in_reply_to":"5a890539_3a72dce3","updated":"2014-11-27 20:08:33.000000000","message":"Yes.","commit_id":"e04791ca3ac4d985c72cd0d24ae03f8d23dd4bf0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"978a991712ce17f077e1097deef8fd94c0e4d724","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  patch security issues by releasing a new library instead of patching"},{"line_number":64,"context_line":"  individual services."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* Does this change involve cryptography or hashing?"},{"line_number":67,"context_line":"* No"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"* Does this change require the use of sudo or any elevated privileges?"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a890539_dd7ab276","line":66,"in_reply_to":"5a890539_ba1b2c7f","updated":"2014-11-27 20:10:36.000000000","message":"Yeah, just think that leaving the bullet point there will make clear the scope from the spec.","commit_id":"e04791ca3ac4d985c72cd0d24ae03f8d23dd4bf0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"7ca5a460fc9577c3ff2811333d8a4763147c6bb1","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  patch security issues by releasing a new library instead of patching"},{"line_number":64,"context_line":"  individual services."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* Does this change involve cryptography or hashing?"},{"line_number":67,"context_line":"* No"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"* Does this change require the use of sudo or any elevated privileges?"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a890539_3a72dce3","line":66,"in_reply_to":"5a890539_fa44d41c","updated":"2014-11-27 19:49:58.000000000","message":"you mean, just remove the bullet point?","commit_id":"e04791ca3ac4d985c72cd0d24ae03f8d23dd4bf0"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4199e8fdbc2eed4aaaf658ab083b7a0e016d3bfa","unresolved":false,"context_lines":[{"line_number":100,"context_line":"Performance profiles should be completely unchanged by this change."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Other Deployed Impact"},{"line_number":104,"context_line":"---------------------"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Once the Oslo Policy library is graduated and the changes in Keystoneclient"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a890539_9d670f51","line":103,"updated":"2014-12-01 19:30:10.000000000","message":"Deployer*","commit_id":"e04791ca3ac4d985c72cd0d24ae03f8d23dd4bf0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"9a70036c04e9d4b3da3900c62411c4714a83098e","unresolved":false,"context_lines":[{"line_number":100,"context_line":"Performance profiles should be completely unchanged by this change."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Other Deployed Impact"},{"line_number":104,"context_line":"---------------------"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Once the Oslo Policy library is graduated and the changes in Keystoneclient"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a890539_aea218fa","line":103,"in_reply_to":"5a890539_9d670f51","updated":"2014-12-09 16:51:21.000000000","message":"Done","commit_id":"e04791ca3ac4d985c72cd0d24ae03f8d23dd4bf0"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4199e8fdbc2eed4aaaf658ab083b7a0e016d3bfa","unresolved":false,"context_lines":[{"line_number":110,"context_line":"Developer Impact"},{"line_number":111,"context_line":"----------------"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Change should be invisible to developers."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Implementation"},{"line_number":116,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a890539_3d0c5b94","line":113,"updated":"2014-12-01 19:30:10.000000000","message":"will there be a change to the way we handle policy at the keystone server level? currently we use a decorator to get policy.","commit_id":"e04791ca3ac4d985c72cd0d24ae03f8d23dd4bf0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"9a70036c04e9d4b3da3900c62411c4714a83098e","unresolved":false,"context_lines":[{"line_number":110,"context_line":"Developer Impact"},{"line_number":111,"context_line":"----------------"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Change should be invisible to developers."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Implementation"},{"line_number":116,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_1a225a01","line":113,"in_reply_to":"5a890539_3d0c5b94","updated":"2014-12-09 16:51:21.000000000","message":"added in work items","commit_id":"e04791ca3ac4d985c72cd0d24ae03f8d23dd4bf0"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"f6feacf342456c963f3a36c62f11121ef0d5cb7a","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"* Oslo Policy module graduation. All incubated modules required by the library"},{"line_number":137,"context_line":"  (like oslo.fileutils) will be included in the project until their graduation."},{"line_number":138,"context_line":"* Enforcement code and tests in Keystoneclient."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a890539_5abc0807","line":138,"updated":"2014-11-27 19:00:36.000000000","message":"Today, the Policy API in Keystone are not implemented. So, Do you think in use this calls to make the enforcement?","commit_id":"e04791ca3ac4d985c72cd0d24ae03f8d23dd4bf0"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4199e8fdbc2eed4aaaf658ab083b7a0e016d3bfa","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"* Oslo Policy module graduation. All incubated modules required by the library"},{"line_number":137,"context_line":"  (like oslo.fileutils) will be included in the project until their graduation."},{"line_number":138,"context_line":"* Enforcement code and tests in Keystoneclient."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a890539_5da2074c","line":138,"updated":"2014-12-01 19:30:10.000000000","message":"can you expand on this a bit more, are you saying that the code here: https://github.com/openstack/keystone/blob/master/keystone/policy/backends/rules.py will be moved to keystoneclient?\n\nCan you describe the flow of how an API request will enforce the policy if it\u0027s in keystoneclient? What if I perform a cURL to and endpoint directly?","commit_id":"e04791ca3ac4d985c72cd0d24ae03f8d23dd4bf0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"7ca5a460fc9577c3ff2811333d8a4763147c6bb1","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"* Oslo Policy module graduation. All incubated modules required by the library"},{"line_number":137,"context_line":"  (like oslo.fileutils) will be included in the project until their graduation."},{"line_number":138,"context_line":"* Enforcement code and tests in Keystoneclient."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a890539_9a2f50a7","line":138,"in_reply_to":"5a890539_5abc0807","updated":"2014-11-27 19:49:58.000000000","message":"No, the enforcement will be made completely in keystoneclient, the policy API is detailed in the follow up specs.","commit_id":"e04791ca3ac4d985c72cd0d24ae03f8d23dd4bf0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"9a70036c04e9d4b3da3900c62411c4714a83098e","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"* Oslo Policy module graduation. All incubated modules required by the library"},{"line_number":137,"context_line":"  (like oslo.fileutils) will be included in the project until their graduation."},{"line_number":138,"context_line":"* Enforcement code and tests in Keystoneclient."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_7a7a7ef2","line":138,"in_reply_to":"5a890539_5da2074c","updated":"2014-12-09 16:51:21.000000000","message":"++ used some examples here, like how Nova and Glace handle the enforcement.","commit_id":"e04791ca3ac4d985c72cd0d24ae03f8d23dd4bf0"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"548299b22de93a5a8be926464375bd743ffbfad7","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"* Oslo Policy module graduation. All incubated modules required by the library"},{"line_number":137,"context_line":"  (like oslo.fileutils) will be included in the project until their graduation."},{"line_number":138,"context_line":"* Enforcement code and tests in Keystoneclient."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a890539_da10f85b","line":138,"in_reply_to":"5a890539_9a2f50a7","updated":"2014-11-27 20:08:33.000000000","message":"Ok.","commit_id":"e04791ca3ac4d985c72cd0d24ae03f8d23dd4bf0"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"f6feacf342456c963f3a36c62f11121ef0d5cb7a","unresolved":false,"context_lines":[{"line_number":136,"context_line":"* Oslo Policy module graduation. All incubated modules required by the library"},{"line_number":137,"context_line":"  (like oslo.fileutils) will be included in the project until their graduation."},{"line_number":138,"context_line":"* Enforcement code and tests in Keystoneclient."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Dependencies"},{"line_number":142,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a890539_3a6d7c9a","line":139,"updated":"2014-11-27 19:00:36.000000000","message":"I don\u0027t need change anything in the other services? Today, the all services already use the oslo policy?","commit_id":"e04791ca3ac4d985c72cd0d24ae03f8d23dd4bf0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"7ca5a460fc9577c3ff2811333d8a4763147c6bb1","unresolved":false,"context_lines":[{"line_number":136,"context_line":"* Oslo Policy module graduation. All incubated modules required by the library"},{"line_number":137,"context_line":"  (like oslo.fileutils) will be included in the project until their graduation."},{"line_number":138,"context_line":"* Enforcement code and tests in Keystoneclient."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Dependencies"},{"line_number":142,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a890539_da42b867","line":139,"in_reply_to":"5a890539_3a6d7c9a","updated":"2014-11-27 19:49:58.000000000","message":"yes, but in the scope from this spec we are just talking about the development of this enforcement in keystoneclient. Other services adoption is the next step and is described in the Other Deployed Impact session.","commit_id":"e04791ca3ac4d985c72cd0d24ae03f8d23dd4bf0"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"548299b22de93a5a8be926464375bd743ffbfad7","unresolved":false,"context_lines":[{"line_number":136,"context_line":"* Oslo Policy module graduation. All incubated modules required by the library"},{"line_number":137,"context_line":"  (like oslo.fileutils) will be included in the project until their graduation."},{"line_number":138,"context_line":"* Enforcement code and tests in Keystoneclient."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Dependencies"},{"line_number":142,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a890539_fa15b449","line":139,"in_reply_to":"5a890539_da42b867","updated":"2014-11-27 20:08:33.000000000","message":"Ok. Thanks for the answers. :)","commit_id":"e04791ca3ac4d985c72cd0d24ae03f8d23dd4bf0"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"3d1c30c6fdcc73bca406f29303fbbd8ea74c139e","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp policy-enforcement-library \u003chttps://blueprints.launchpad.net/keystone/+spec/policy-enforcement-library\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Unify the enforcement of policy for services by graduating oslo.policy and"},{"line_number":14,"context_line":"using Keystoneclient to perform it."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_32cf21b2","line":13,"updated":"2014-12-10 10:59:20.000000000","message":"At [1] ayoung called the library oslo-policy, instead of oslo.policy. Which one should be correct?\n\n[1] https://review.openstack.org/#/c/140161/2/specs/kilo/graduate-policy.rst","commit_id":"53048e995cf47f3b113c12445cbb1b9ed4d46266"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"873336d4f3dfaab13b3bb31528fe35e62d9553a3","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp policy-enforcement-library \u003chttps://blueprints.launchpad.net/keystone/+spec/policy-enforcement-library\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Unify the enforcement of policy for services by graduating oslo.policy and"},{"line_number":14,"context_line":"using Keystoneclient to perform it."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_487880c4","line":13,"in_reply_to":"3a961159_32cf21b2","updated":"2014-12-10 12:43:32.000000000","message":"oslo.policy is how we identify the policy lib currently being incubated by oslo. The graduated lib though, will be named oslo_policy.","commit_id":"53048e995cf47f3b113c12445cbb1b9ed4d46266"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"3d1c30c6fdcc73bca406f29303fbbd8ea74c139e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"change is how the parameters passed to the engine are extracted from the"},{"line_number":38,"context_line":"environment, and that the call will be passed to Keystoneclient to process the"},{"line_number":39,"context_line":"policy. This allows further work, such as fetching the policy file from the"},{"line_number":40,"context_line":"Keystone server."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Alternatives"},{"line_number":43,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_129b0568","line":40,"updated":"2014-12-10 10:59:20.000000000","message":"I find this paragraph quite confusing. I think you could rewrite it. I would do this to something like:\n\nThe new policy engine has two modules: Oslo Policy and Keystoneclient.\nThe first one will be the heart of the engine. The second one, in turn, will receive the parameters passed to the engine and then make calls to the first.\n\nHow those parameters are extracted from the environment is exactly what changes from each one of the projects using the new engine.\n\nThis allows further work, such as fetching the policy file from the Keystone server.","commit_id":"53048e995cf47f3b113c12445cbb1b9ed4d46266"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"873336d4f3dfaab13b3bb31528fe35e62d9553a3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"change is how the parameters passed to the engine are extracted from the"},{"line_number":38,"context_line":"environment, and that the call will be passed to Keystoneclient to process the"},{"line_number":39,"context_line":"policy. This allows further work, such as fetching the policy file from the"},{"line_number":40,"context_line":"Keystone server."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Alternatives"},{"line_number":43,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_28409455","line":40,"in_reply_to":"3a961159_129b0568","updated":"2014-12-10 12:43:32.000000000","message":"Will rewrite some sentences, but I think the general idea is being passed there. We won\u0027t have two modules per se, but Keystoneclient will encapsulate the policy library.","commit_id":"53048e995cf47f3b113c12445cbb1b9ed4d46266"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"3d1c30c6fdcc73bca406f29303fbbd8ea74c139e","unresolved":false,"context_lines":[{"line_number":140,"context_line":"  minor differences among the services, here is an example list of how it is"},{"line_number":141,"context_line":"  handled:"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"  * Keystone: https://github.com/openstack/keystone/blob/master/keystone/policy/backends/rules.py"},{"line_number":144,"context_line":"  * Nova: https://github.com/openstack/nova/blob/master/nova/policy.py"},{"line_number":145,"context_line":"  * Glance: https://github.com/openstack/glance/blob/master/glance/api/policy.py"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_8faef283","line":143,"updated":"2014-12-10 10:59:20.000000000","message":"I think you should define links with alias instead of naked ones.\nYou could even put this together with the next paragraph, thus it could be something like: \n\n* `Keystone \u003chttps://github.com/openstack/keystone/blob/master/keystone/policy/backends/rules.py\u003e`_ uses a decorator to perform the enforcement;\n* `Nova \u003chttps://github.com/openstack/nova/blob/master/nova/policy.py\u003e`_ calls the [...] ;\n* `Glance \u003chttps://github.com/openstack/glance/blob/master/glance/api/policy.py\u003e`_ has another [...].","commit_id":"53048e995cf47f3b113c12445cbb1b9ed4d46266"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"873336d4f3dfaab13b3bb31528fe35e62d9553a3","unresolved":false,"context_lines":[{"line_number":140,"context_line":"  minor differences among the services, here is an example list of how it is"},{"line_number":141,"context_line":"  handled:"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"  * Keystone: https://github.com/openstack/keystone/blob/master/keystone/policy/backends/rules.py"},{"line_number":144,"context_line":"  * Nova: https://github.com/openstack/nova/blob/master/nova/policy.py"},{"line_number":145,"context_line":"  * Glance: https://github.com/openstack/glance/blob/master/glance/api/policy.py"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_4826c0cf","line":143,"in_reply_to":"3a961159_8faef283","updated":"2014-12-10 12:43:32.000000000","message":"Done","commit_id":"53048e995cf47f3b113c12445cbb1b9ed4d46266"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"3d1c30c6fdcc73bca406f29303fbbd8ea74c139e","unresolved":false,"context_lines":[{"line_number":156,"context_line":"Dependencies"},{"line_number":157,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"* The oslo.policy lib (graduated): https://review.openstack.org/#/c/140161/"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_d205fd7a","line":159,"updated":"2014-12-10 10:59:20.000000000","message":"Replace naked link.","commit_id":"53048e995cf47f3b113c12445cbb1b9ed4d46266"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"873336d4f3dfaab13b3bb31528fe35e62d9553a3","unresolved":false,"context_lines":[{"line_number":156,"context_line":"Dependencies"},{"line_number":157,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"* The oslo.policy lib (graduated): https://review.openstack.org/#/c/140161/"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_6821bcb3","line":159,"in_reply_to":"3a961159_d205fd7a","updated":"2014-12-10 12:43:32.000000000","message":"Done","commit_id":"53048e995cf47f3b113c12445cbb1b9ed4d46266"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"62c3eae148b43ec3f9c0ca858e3a1968ce3d4255","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Enforce Policy In Keystoneclient"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_0022c8a3","line":7,"updated":"2014-12-10 15:08:19.000000000","message":"(nit) The number of characters in the header delimiter should match the size of the header.","commit_id":"24371cad201afda4a13cd19888d75823bb36c7f9"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"b7be8b8ab67b3d85071aa7ecf1a4844cb1057273","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Enforce Policy In Keystoneclient"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_244c3142","line":7,"in_reply_to":"3a961159_0022c8a3","updated":"2014-12-18 14:42:49.000000000","message":"Done","commit_id":"24371cad201afda4a13cd19888d75823bb36c7f9"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"62c3eae148b43ec3f9c0ca858e3a1968ce3d4255","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"All of the projects in OpenStack implement policy enforcement themselves."},{"line_number":21,"context_line":"This leads to both cut and paste code, divergent mechanisms, and the inability"},{"line_number":22,"context_line":"to synchronize policy enforcement. The same policy rules can actually have"},{"line_number":23,"context_line":"different meanings depending on which server is implementing the policy check."},{"line_number":24,"context_line":"Determining how to enforce policy against actual entities involves a scheme to"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_c0752099","line":21,"updated":"2014-12-10 15:08:19.000000000","message":"I think \u0027both\u0027 should be removed since you list three issues.","commit_id":"24371cad201afda4a13cd19888d75823bb36c7f9"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"b7be8b8ab67b3d85071aa7ecf1a4844cb1057273","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"All of the projects in OpenStack implement policy enforcement themselves."},{"line_number":21,"context_line":"This leads to both cut and paste code, divergent mechanisms, and the inability"},{"line_number":22,"context_line":"to synchronize policy enforcement. The same policy rules can actually have"},{"line_number":23,"context_line":"different meanings depending on which server is implementing the policy check."},{"line_number":24,"context_line":"Determining how to enforce policy against actual entities involves a scheme to"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_ae9645ee","line":21,"in_reply_to":"3a961159_c0752099","updated":"2014-12-18 14:42:49.000000000","message":"Done","commit_id":"24371cad201afda4a13cd19888d75823bb36c7f9"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"62c3eae148b43ec3f9c0ca858e3a1968ce3d4255","unresolved":false,"context_lines":[{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Move the Keystone policy enforcement to Keystoneclient. Some services already"},{"line_number":33,"context_line":"have a robust mechanism: Keystone, Nova and Glance. Make sure all of them use"},{"line_number":34,"context_line":"the common library."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"The Oslo Policy module will remain the heart of the engine. Instead, what will"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_20aa64d4","line":33,"updated":"2014-12-10 15:08:19.000000000","message":"I don\u0027t see a work item for fixing the other projects or filing bugs. Is that a part of the work to be done for this spec?","commit_id":"24371cad201afda4a13cd19888d75823bb36c7f9"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"b7be8b8ab67b3d85071aa7ecf1a4844cb1057273","unresolved":false,"context_lines":[{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Move the Keystone policy enforcement to Keystoneclient. Some services already"},{"line_number":33,"context_line":"have a robust mechanism: Keystone, Nova and Glance. Make sure all of them use"},{"line_number":34,"context_line":"the common library."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"The Oslo Policy module will remain the heart of the engine. Instead, what will"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_2e8a55bf","line":33,"in_reply_to":"3a961159_20aa64d4","updated":"2014-12-18 14:42:49.000000000","message":"Done","commit_id":"24371cad201afda4a13cd19888d75823bb36c7f9"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"62c3eae148b43ec3f9c0ca858e3a1968ce3d4255","unresolved":false,"context_lines":[{"line_number":33,"context_line":"have a robust mechanism: Keystone, Nova and Glance. Make sure all of them use"},{"line_number":34,"context_line":"the common library."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"The Oslo Policy module will remain the heart of the engine. Instead, what will"},{"line_number":37,"context_line":"change is how the parameters passed to the engine are extracted from the"},{"line_number":38,"context_line":"environment. The call should be made via Keystoneclient, which will need to"},{"line_number":39,"context_line":"include a generic and robust mechanism to process the policy. This also allows"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_c0ea800e","line":36,"updated":"2014-12-10 15:08:19.000000000","message":"\u0027Instead\u0027 sounds a little clunky here, but I have no simple suggestions. Just food for thought.","commit_id":"24371cad201afda4a13cd19888d75823bb36c7f9"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"b7be8b8ab67b3d85071aa7ecf1a4844cb1057273","unresolved":false,"context_lines":[{"line_number":33,"context_line":"have a robust mechanism: Keystone, Nova and Glance. Make sure all of them use"},{"line_number":34,"context_line":"the common library."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"The Oslo Policy module will remain the heart of the engine. Instead, what will"},{"line_number":37,"context_line":"change is how the parameters passed to the engine are extracted from the"},{"line_number":38,"context_line":"environment. The call should be made via Keystoneclient, which will need to"},{"line_number":39,"context_line":"include a generic and robust mechanism to process the policy. This also allows"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_e4e869b6","line":36,"in_reply_to":"3a961159_c0ea800e","updated":"2014-12-18 14:42:49.000000000","message":"Removed \"Instead\", the sentence remains with the same meaning, IMHO.","commit_id":"24371cad201afda4a13cd19888d75823bb36c7f9"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"62c3eae148b43ec3f9c0ca858e3a1968ce3d4255","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"The Oslo Policy module will remain the heart of the engine. Instead, what will"},{"line_number":37,"context_line":"change is how the parameters passed to the engine are extracted from the"},{"line_number":38,"context_line":"environment. The call should be made via Keystoneclient, which will need to"},{"line_number":39,"context_line":"include a generic and robust mechanism to process the policy. This also allows"},{"line_number":40,"context_line":"further work, such as fetching the policy file from the Keystone server."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_c05fe0e3","line":38,"updated":"2014-12-10 15:08:19.000000000","message":"Is there any more detail known about the change? How will the params and env vars be different?","commit_id":"24371cad201afda4a13cd19888d75823bb36c7f9"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"b7be8b8ab67b3d85071aa7ecf1a4844cb1057273","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"The Oslo Policy module will remain the heart of the engine. Instead, what will"},{"line_number":37,"context_line":"change is how the parameters passed to the engine are extracted from the"},{"line_number":38,"context_line":"environment. The call should be made via Keystoneclient, which will need to"},{"line_number":39,"context_line":"include a generic and robust mechanism to process the policy. This also allows"},{"line_number":40,"context_line":"further work, such as fetching the policy file from the Keystone server."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_84d7a5ec","line":38,"in_reply_to":"3a961159_c05fe0e3","updated":"2014-12-18 14:42:49.000000000","message":"Thanks, including some details about keystonemiddleware, auth_context, etc.","commit_id":"24371cad201afda4a13cd19888d75823bb36c7f9"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"62c3eae148b43ec3f9c0ca858e3a1968ce3d4255","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Alternatives"},{"line_number":43,"context_line":"------------"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"None. The alternative is to leave as it is today: each of the services"},{"line_number":46,"context_line":"implement their own means to enforce policy and fetch the policy files"},{"line_number":47,"context_line":"themselves. This is code duplication and leads to errors."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_a0ff34a9","line":45,"updated":"2014-12-10 15:08:19.000000000","message":"I see adding this shared logic (the stuff being added to ksc) to the oslo.policy as an alternative. Is it not and if not why?","commit_id":"24371cad201afda4a13cd19888d75823bb36c7f9"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"b7be8b8ab67b3d85071aa7ecf1a4844cb1057273","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Alternatives"},{"line_number":43,"context_line":"------------"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"None. The alternative is to leave as it is today: each of the services"},{"line_number":46,"context_line":"implement their own means to enforce policy and fetch the policy files"},{"line_number":47,"context_line":"themselves. This is code duplication and leads to errors."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_24f99180","line":45,"in_reply_to":"3a961159_a0ff34a9","updated":"2014-12-18 14:42:49.000000000","message":"I don\u0027t think so, looking at the big picture: fetch policies from Keystone, unified policies, ... This is in the scope of Keystoneclient/Keystone.","commit_id":"24371cad201afda4a13cd19888d75823bb36c7f9"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"62c3eae148b43ec3f9c0ca858e3a1968ce3d4255","unresolved":false,"context_lines":[{"line_number":51,"context_line":"---------------"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Describe any potential security impact on the system.  Some of the items to"},{"line_number":54,"context_line":"consider include:"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"},{"line_number":57,"context_line":"* Yes. The policy files are data used in security enforcement. Access to them"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_c0bb60e3","line":54,"updated":"2014-12-10 15:08:19.000000000","message":"The rendering of this section makes it very confusing. The spaces are removed. So it looks like a list there 25% of the items are just \u0027No\u0027. Maybe indent the answer or come up with a different way to show the info.","commit_id":"24371cad201afda4a13cd19888d75823bb36c7f9"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"62c3eae148b43ec3f9c0ca858e3a1968ce3d4255","unresolved":false,"context_lines":[{"line_number":54,"context_line":"consider include:"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"},{"line_number":57,"context_line":"* Yes. The policy files are data used in security enforcement. Access to them"},{"line_number":58,"context_line":"  is highly sensitive."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* Does this change alter the API in a way that may impact security, such as"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_a0ee54b2","line":57,"updated":"2014-12-10 15:08:19.000000000","message":"Is the policy file itself considered a secret? How does this change the access patterns for this data?","commit_id":"24371cad201afda4a13cd19888d75823bb36c7f9"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"b7be8b8ab67b3d85071aa7ecf1a4844cb1057273","unresolved":false,"context_lines":[{"line_number":54,"context_line":"consider include:"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"},{"line_number":57,"context_line":"* Yes. The policy files are data used in security enforcement. Access to them"},{"line_number":58,"context_line":"  is highly sensitive."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* Does this change alter the API in a way that may impact security, such as"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_24b0b142","line":57,"in_reply_to":"3a961159_a0ee54b2","updated":"2014-12-18 14:42:49.000000000","message":"Done","commit_id":"24371cad201afda4a13cd19888d75823bb36c7f9"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"62c3eae148b43ec3f9c0ca858e3a1968ce3d4255","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":61,"context_line":"  a new way to access sensitive information or a new way to login?"},{"line_number":62,"context_line":"* Yes. The APIs will now use a common library for policy enforcement. This"},{"line_number":63,"context_line":"  should have a net positive effect on security, as it will be possible to"},{"line_number":64,"context_line":"  patch security issues by releasing a new library instead of patching"},{"line_number":65,"context_line":"  individual services."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_4003f041","line":62,"updated":"2014-12-10 15:08:19.000000000","message":"Maybe call out this this is a Python API change and not a REST API change.","commit_id":"24371cad201afda4a13cd19888d75823bb36c7f9"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"b7be8b8ab67b3d85071aa7ecf1a4844cb1057273","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":61,"context_line":"  a new way to access sensitive information or a new way to login?"},{"line_number":62,"context_line":"* Yes. The APIs will now use a common library for policy enforcement. This"},{"line_number":63,"context_line":"  should have a net positive effect on security, as it will be possible to"},{"line_number":64,"context_line":"  patch security issues by releasing a new library instead of patching"},{"line_number":65,"context_line":"  individual services."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_44abfdd5","line":62,"in_reply_to":"3a961159_4003f041","updated":"2014-12-18 14:42:49.000000000","message":"Done","commit_id":"24371cad201afda4a13cd19888d75823bb36c7f9"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"62c3eae148b43ec3f9c0ca858e3a1968ce3d4255","unresolved":false,"context_lines":[{"line_number":112,"context_line":"----------------"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Change should be invisible to developers."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Implementation"},{"line_number":117,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_2040a455","line":115,"updated":"2014-12-10 15:08:19.000000000","message":"I think this change is actually invisible to deployers. I think your statement about deployer impact is developer impact since they will have to know/consume new APIs and know not to do things in unsafe ways.","commit_id":"24371cad201afda4a13cd19888d75823bb36c7f9"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"b7be8b8ab67b3d85071aa7ecf1a4844cb1057273","unresolved":false,"context_lines":[{"line_number":112,"context_line":"----------------"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Change should be invisible to developers."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Implementation"},{"line_number":117,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_a4eae10c","line":115,"in_reply_to":"3a961159_2040a455","updated":"2014-12-18 14:42:49.000000000","message":"Done","commit_id":"24371cad201afda4a13cd19888d75823bb36c7f9"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"f7a2f2ec4acf25b1ee70a094705651ca275dba23","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Enforce Policy In Client"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp example \u003chttps://blueprints.launchpad.net/keystone/+spec/policy-kc\u003e`_"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_2ca3b3b2","line":9,"updated":"2015-01-19 11:39:33.000000000","message":"\u0027\u003d\u0027 lines too long","commit_id":"3d2a57ece117738c1bb98559c5ba88f5eaa46762"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"f7a2f2ec4acf25b1ee70a094705651ca275dba23","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Enforce Policy In Client"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp example \u003chttps://blueprints.launchpad.net/keystone/+spec/policy-kc\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Unify the enforcement of policy for services in Keystoneclient"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_6cadbb9b","line":11,"updated":"2015-01-19 11:39:33.000000000","message":"wrong bp link.","commit_id":"3d2a57ece117738c1bb98559c5ba88f5eaa46762"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"7f96822794897f1d63d02e7ff725d52a10e22669","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem Description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"All of the projects in OpenStack is implement policy enforcement themselves."},{"line_number":20,"context_line":"This leads to both cut and past code, divergent mechanisms, and the inability"},{"line_number":21,"context_line":"to synchronize policy enforcement.  The same policy rules can actually have"},{"line_number":22,"context_line":"different meanings depending on which server is implementing the policy check."}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_4f445447","line":19,"updated":"2015-01-20 03:59:24.000000000","message":"Remove \u0027is \u0027?","commit_id":"3d2a57ece117738c1bb98559c5ba88f5eaa46762"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"7f96822794897f1d63d02e7ff725d52a10e22669","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"All of the projects in OpenStack is implement policy enforcement themselves."},{"line_number":20,"context_line":"This leads to both cut and past code, divergent mechanisms, and the inability"},{"line_number":21,"context_line":"to synchronize policy enforcement.  The same policy rules can actually have"},{"line_number":22,"context_line":"different meanings depending on which server is implementing the policy check."},{"line_number":23,"context_line":"Determining how to enforce policy against actual entities involves a scheme to"},{"line_number":24,"context_line":"flatten the object name from the dictionary, but this is not implemented"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_8f755c99","line":21,"updated":"2015-01-20 03:59:24.000000000","message":"nit: double space \u0027  The same\u0027","commit_id":"3d2a57ece117738c1bb98559c5ba88f5eaa46762"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"f7a2f2ec4acf25b1ee70a094705651ca275dba23","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed Change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Move the Keystone policy enforcement to Keystone client.  Integrate in the"},{"line_number":32,"context_line":"mechanisms that are different from Nova policy enforcement.  Make sure that"},{"line_number":33,"context_line":"both Nova and Keystone use the common library."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_15c35607","line":31,"updated":"2015-01-19 11:39:33.000000000","message":"Copy, or duplicate, not move?","commit_id":"3d2a57ece117738c1bb98559c5ba88f5eaa46762"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"7f96822794897f1d63d02e7ff725d52a10e22669","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed Change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Move the Keystone policy enforcement to Keystone client.  Integrate in the"},{"line_number":32,"context_line":"mechanisms that are different from Nova policy enforcement.  Make sure that"},{"line_number":33,"context_line":"both Nova and Keystone use the common library."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_cf6f64c3","line":31,"in_reply_to":"3a961159_15c35607","updated":"2015-01-20 03:59:24.000000000","message":"nit: double space \u0027  Integrate\u0027","commit_id":"3d2a57ece117738c1bb98559c5ba88f5eaa46762"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"7f96822794897f1d63d02e7ff725d52a10e22669","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Move the Keystone policy enforcement to Keystone client.  Integrate in the"},{"line_number":32,"context_line":"mechanisms that are different from Nova policy enforcement.  Make sure that"},{"line_number":33,"context_line":"both Nova and Keystone use the common library."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"The Oslo policy module will remain the heart of the engine.  Instead, what will"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_ef6340dc","line":32,"updated":"2015-01-20 03:59:24.000000000","message":"nit: dobule space \u0027  Make\u0027","commit_id":"3d2a57ece117738c1bb98559c5ba88f5eaa46762"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"7f96822794897f1d63d02e7ff725d52a10e22669","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"The Oslo policy module will remain the heart of the engine.  Instead, what will"},{"line_number":36,"context_line":"change is how the parameters passed to the engine are extracted from the"},{"line_number":37,"context_line":"environment, and that the call will be passed to Keystoneclient to process the"},{"line_number":38,"context_line":"policy.  This allows further work, such as fetching the policy file from the"},{"line_number":39,"context_line":"keystone server."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_efaa60d2","line":37,"updated":"2015-01-20 03:59:24.000000000","message":"s/ that/how","commit_id":"3d2a57ece117738c1bb98559c5ba88f5eaa46762"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"7f96822794897f1d63d02e7ff725d52a10e22669","unresolved":false,"context_lines":[{"line_number":52,"context_line":"consider include:"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"},{"line_number":55,"context_line":"* Yes.  The policy files are data used in security enforcement.  Access to them"},{"line_number":56,"context_line":"  is highly sensitive."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* Does this change alter the API in a way that may impact security, such as"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_6f7e706f","line":55,"updated":"2015-01-20 03:59:24.000000000","message":"nit: double spaces everywhere","commit_id":"3d2a57ece117738c1bb98559c5ba88f5eaa46762"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"7f96822794897f1d63d02e7ff725d52a10e22669","unresolved":false,"context_lines":[{"line_number":135,"context_line":"Work items or tasks -- break the feature up into the things that need to be"},{"line_number":136,"context_line":"done to implement it. Those parts might end up being done by different people,"},{"line_number":137,"context_line":"but we\u0027re mostly trying to understand the timeline for implementation."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Dependencies"},{"line_number":141,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_cfcbe4a2","line":138,"updated":"2015-01-20 03:59:24.000000000","message":"Well, this spec needs further work.\nThe work items were removed from previous patch sets.\n\nThe othe next sections were removed as well.","commit_id":"3d2a57ece117738c1bb98559c5ba88f5eaa46762"}],"specs/keystonemiddleware/policy-enforce.rst":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"1f0d6cbd7f2c13656b0bd2a16db568f0c235cfda","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Enforce Policy In Client"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp example \u003chttps://blueprints.launchpad.net/keystone/+spec/policy-kc\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Unify the enforcement of policy for services in Keystoneclient"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"da9b358b_83446374","line":11,"updated":"2015-03-30 22:46:20.000000000","message":"s/bp example/...more descriptive title.../","commit_id":"923574075b58869c9fdf58533ad7421f6b517a1f"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"1f0d6cbd7f2c13656b0bd2a16db568f0c235cfda","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem Description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"All of the projects in OpenStack is implement policy enforcement themselves."},{"line_number":20,"context_line":"This leads to both cut and past code, divergent mechanisms, and the inability"},{"line_number":21,"context_line":"to synchronize policy enforcement.  The same policy rules can actually have"},{"line_number":22,"context_line":"different meanings depending on which server is implementing the policy check."}],"source_content_type":"text/x-rst","patch_set":11,"id":"da9b358b_435f7b41","line":19,"updated":"2015-03-30 22:46:20.000000000","message":"s/is //","commit_id":"923574075b58869c9fdf58533ad7421f6b517a1f"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"1f0d6cbd7f2c13656b0bd2a16db568f0c235cfda","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"All of the projects in OpenStack is implement policy enforcement themselves."},{"line_number":20,"context_line":"This leads to both cut and past code, divergent mechanisms, and the inability"},{"line_number":21,"context_line":"to synchronize policy enforcement.  The same policy rules can actually have"},{"line_number":22,"context_line":"different meanings depending on which server is implementing the policy check."},{"line_number":23,"context_line":"Determining how to enforce policy against actual entities involves a scheme to"}],"source_content_type":"text/x-rst","patch_set":11,"id":"da9b358b_235c774a","line":20,"updated":"2015-03-30 22:46:20.000000000","message":"paste","commit_id":"923574075b58869c9fdf58533ad7421f6b517a1f"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"1f0d6cbd7f2c13656b0bd2a16db568f0c235cfda","unresolved":false,"context_lines":[{"line_number":19,"context_line":"All of the projects in OpenStack is implement policy enforcement themselves."},{"line_number":20,"context_line":"This leads to both cut and past code, divergent mechanisms, and the inability"},{"line_number":21,"context_line":"to synchronize policy enforcement.  The same policy rules can actually have"},{"line_number":22,"context_line":"different meanings depending on which server is implementing the policy check."},{"line_number":23,"context_line":"Determining how to enforce policy against actual entities involves a scheme to"},{"line_number":24,"context_line":"flatten the object name from the dictionary, but this is not implemented"},{"line_number":25,"context_line":"across all of the services."}],"source_content_type":"text/x-rst","patch_set":11,"id":"da9b358b_0359735a","line":22,"updated":"2015-03-30 22:46:20.000000000","message":"s/server/service/","commit_id":"923574075b58869c9fdf58533ad7421f6b517a1f"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"1f0d6cbd7f2c13656b0bd2a16db568f0c235cfda","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed Change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Move the Keystone policy enforcement to Keystone client.  Integrate in the"},{"line_number":32,"context_line":"mechanisms that are different from Nova policy enforcement.  Make sure that"},{"line_number":33,"context_line":"both Nova and Keystone use the common library."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"da9b358b_e32c4fad","line":31,"updated":"2015-03-30 22:46:20.000000000","message":"s/in //\n\nalso should this be in keystonemiddleware?","commit_id":"923574075b58869c9fdf58533ad7421f6b517a1f"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"1f0d6cbd7f2c13656b0bd2a16db568f0c235cfda","unresolved":false,"context_lines":[{"line_number":36,"context_line":"change is how the parameters passed to the engine are extracted from the"},{"line_number":37,"context_line":"environment, and that the call will be passed to Keystoneclient to process the"},{"line_number":38,"context_line":"policy.  This allows further work, such as fetching the policy file from the"},{"line_number":39,"context_line":"keystone server."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Alternatives"},{"line_number":42,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"da9b358b_0307331d","line":39,"updated":"2015-03-30 22:46:20.000000000","message":"Keystone","commit_id":"923574075b58869c9fdf58533ad7421f6b517a1f"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"1f0d6cbd7f2c13656b0bd2a16db568f0c235cfda","unresolved":false,"context_lines":[{"line_number":89,"context_line":"Other End User Impact"},{"line_number":90,"context_line":"---------------------"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"This Patch will provide an additional API for Keystone client.  It is not"},{"line_number":93,"context_line":"expected to be used except by other remote services, but it means that any"},{"line_number":94,"context_line":"privileged user can evaluate policy."},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"da9b358b_7e09f62b","line":92,"updated":"2015-03-30 22:46:20.000000000","message":"patch","commit_id":"923574075b58869c9fdf58533ad7421f6b517a1f"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"a53a5453c64d68b8faa974db89b11cc943353d9d","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"1. Nova makes call to enforce policy.  API is identical to the"},{"line_number":67,"context_line":"   oslo.policy API, but will be implemented by middleware."},{"line_number":68,"context_line":"2. Middleware checks the cache to see if there is a current"},{"line_number":69,"context_line":"   policy file."},{"line_number":70,"context_line":"3. If the file is missing or out of date, middleware calls the"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3acd31a7_4ea66254","line":67,"updated":"2015-05-02 00:52:07.000000000","message":"why middleware? this does not seem like a middleware job? \n\nif nova is calling to it surely it\u0027s a client job?\n\nThe only way i can see this being middleware is if middleware constructs a policy dict and passes it down to nova which then passes it to oslo.policy. Which i like but we already have an object with all this information we are passing to nova: https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/_user_plugin.py which we could just generate policy from instead.","commit_id":"fd8aab9c0848e3bc7ad0db8679869df24912e189"},{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"b9c4d2e5df85072fc216b66cccfc8b6a3fe773ad","unresolved":false,"context_lines":[{"line_number":68,"context_line":"2. Middleware checks the cache to see if there is a current"},{"line_number":69,"context_line":"   policy file."},{"line_number":70,"context_line":"3. If the file is missing or out of date, middleware calls the"},{"line_number":71,"context_line":"   identity API to get policy for endpoint from the Keystone server."},{"line_number":72,"context_line":"4. Middleware stores the policy file in the cache."},{"line_number":73,"context_line":"5. Middleware forwards the call to enforce policy on to the"},{"line_number":74,"context_line":"   oslo.policy library."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3acd31a7_17052479","line":71,"updated":"2015-05-01 18:20:10.000000000","message":"We need to take into consideration that Nova and Keystone might not be on the same server.  We either need to make it a requirement that all policy files reside on the keystone server, or have a way for middleware to figure out that the policy file can possibly be local.\n\nFurther, if middleware can\u0027t communicate with keystone for any reason, can the policy in the cache still be consider current?","commit_id":"fd8aab9c0848e3bc7ad0db8679869df24912e189"},{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"b9c4d2e5df85072fc216b66cccfc8b6a3fe773ad","unresolved":false,"context_lines":[{"line_number":127,"context_line":"Other End User Impact"},{"line_number":128,"context_line":"---------------------"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"This Patch will provide an additional API for Keystone client.  It is not"},{"line_number":131,"context_line":"expected to be used except by other remote services, but it means that any"},{"line_number":132,"context_line":"privileged user can evaluate policy."},{"line_number":133,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3acd31a7_7421f6b3","line":130,"updated":"2015-05-01 18:20:10.000000000","message":"You mean keystone middleware?","commit_id":"fd8aab9c0848e3bc7ad0db8679869df24912e189"},{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"b9c4d2e5df85072fc216b66cccfc8b6a3fe773ad","unresolved":false,"context_lines":[{"line_number":140,"context_line":"Other Deployed Impact"},{"line_number":141,"context_line":"---------------------"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Once the change is made to Keystone client, each of the remote services will"},{"line_number":144,"context_line":"need to be modified to use the unified policy enforcement.  This will possibly"},{"line_number":145,"context_line":"require a spec for each service."},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3acd31a7_b43e6ed8","line":143,"updated":"2015-05-01 18:20:10.000000000","message":"s/client/middleware","commit_id":"fd8aab9c0848e3bc7ad0db8679869df24912e189"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7f9d015e666751bf1980d8a377dd1acdd9112c17","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Enforce Policy From Middleware"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp Enforce policy from Keystonemiddleware"}],"source_content_type":"text/x-rst","patch_set":13,"id":"1aca2d91_9a2db648","line":8,"updated":"2015-05-08 15:05:53.000000000","message":"Keystonemiddleware","commit_id":"ef28cf76280bb3d628fc9793a7f7d636e9cdc709"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7c8607dc0875a0fb8025d292f72635aaabc8131c","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Enforce Policy From Middleware"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp Enforce policy from Keystonemiddleware"},{"line_number":12,"context_line":"` \u003chttps://blueprints.launchpad.net/keystone/+spec/policy-enforcement-library\u003e`_"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Unify the enforcement of policy for services in Keystone Middleware"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a016987_36711da9","line":11,"updated":"2015-05-19 12:55:26.000000000","message":"change \"Enforce policy from Keystonemiddleware\" to \"policy-enforcement-library\"","commit_id":"ef28cf76280bb3d628fc9793a7f7d636e9cdc709"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"4b14ab7d6cf3fe97393e149697597f0177b58e5e","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem Description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"All of the projects in OpenStack implement policy enforcement"},{"line_number":21,"context_line":"themselves. This leads to cut and paste code, divergent mechanisms,"},{"line_number":22,"context_line":"and the inability to synchronize policy enforcement.  The same policy"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3acd31a7_684d443d","line":19,"updated":"2015-05-05 22:35:54.000000000","message":"How does the middleware know which policy file to fetch?  \n   Are we going to have predefined policy_id? If so we need additional configuration information that needs to be documented\n\n\n\nWhat is the security implication on policy file update? \nA line which states  that only  cloud_admin can update the policy file in keystone will be better.","commit_id":"ef28cf76280bb3d628fc9793a7f7d636e9cdc709"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"311934834b7cf8f85266a7d7bb4c06ac78c180e1","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem Description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"All of the projects in OpenStack implement policy enforcement"},{"line_number":21,"context_line":"themselves. This leads to cut and paste code, divergent mechanisms,"},{"line_number":22,"context_line":"and the inability to synchronize policy enforcement.  The same policy"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7ad8896b_714bb22c","line":19,"in_reply_to":"3acd31a7_684d443d","updated":"2015-05-11 16:46:45.000000000","message":"policy files are configurable, from service\u0027s global conf file. See the [oslo_policy] section in,\n\nhttps://github.com/openstack/keystone/blob/master/etc/keystone.conf.sample#L1510\n\nThis section is the same for all the services that uses oslo.policy.","commit_id":"ef28cf76280bb3d628fc9793a7f7d636e9cdc709"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"aff45dc73b9e880a17fd51d5db2578e00107a853","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem Description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"All of the projects in OpenStack implement policy enforcement"},{"line_number":21,"context_line":"themselves. This leads to cut and paste code, divergent mechanisms,"},{"line_number":22,"context_line":"and the inability to synchronize policy enforcement.  The same policy"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a016987_abb6a2f6","line":19,"in_reply_to":"7ad8896b_714bb22c","updated":"2015-05-20 19:00:55.000000000","message":"The question is more about how does nova know which policy to fetch from keystone ?  If we store policies in keystone, , each policy has has policy id which is uuid. How does nova know  its policies uuid?","commit_id":"ef28cf76280bb3d628fc9793a7f7d636e9cdc709"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"311934834b7cf8f85266a7d7bb4c06ac78c180e1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"is implementing the policy check. Determining how to enforce policy"},{"line_number":25,"context_line":"against actual entities involves a scheme to flatten the object name"},{"line_number":26,"context_line":"from the dictionary, but this is not implemented across all of the"},{"line_number":27,"context_line":"services."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7ad8896b_319f6a61","line":27,"updated":"2015-05-11 16:46:45.000000000","message":"The other problem is Horizon need to maintain a copy of the policy files from each services in order to properly setup the UI. They do tend to get out-of-sync if we are not careful.","commit_id":"ef28cf76280bb3d628fc9793a7f7d636e9cdc709"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7f9d015e666751bf1980d8a377dd1acdd9112c17","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Proposed Change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Move the access control policy enforcement to python-keystonemiddleware."},{"line_number":35,"context_line":"Integrate in the mechanisms that are different from Nova policy"},{"line_number":36,"context_line":"enforcement. Make sure that both Nova and Keystone use the common library."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"1aca2d91_9abb76e5","line":34,"updated":"2015-05-08 15:05:53.000000000","message":"s/python-keystonemiddleware/keystonemiddleware/","commit_id":"ef28cf76280bb3d628fc9793a7f7d636e9cdc709"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7c8607dc0875a0fb8025d292f72635aaabc8131c","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Move the access control policy enforcement to python-keystonemiddleware."},{"line_number":35,"context_line":"Integrate in the mechanisms that are different from Nova policy"},{"line_number":36,"context_line":"enforcement. Make sure that both Nova and Keystone use the common library."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The Oslo policy module will remain the heart of the engine.  Instead,"},{"line_number":39,"context_line":"what will change is how the parameters passed to the engine are"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a016987_934c639f","line":36,"updated":"2015-05-19 12:55:26.000000000","message":"What about all the other projects? Also, we can\u0027t decide what Nova is going to do in a Keystone spec, so this needs to be proposed to Nova (of if this is going to be cross-project, propose it as a cross-project spec).","commit_id":"ef28cf76280bb3d628fc9793a7f7d636e9cdc709"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7c8607dc0875a0fb8025d292f72635aaabc8131c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"The Oslo policy module will remain the heart of the engine.  Instead,"},{"line_number":39,"context_line":"what will change is how the parameters passed to the engine are"},{"line_number":40,"context_line":"extracted from the environment, and that the call will be passed to"},{"line_number":41,"context_line":"Oslo.Policy to process the policy.  This allows further work, such as"},{"line_number":42,"context_line":"fetching the policy file from the Keystone server."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Workflow::"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a016987_53394bf1","line":41,"updated":"2015-05-19 12:55:26.000000000","message":"change \"Oslo.Policy\" to \"oslo.policy\"","commit_id":"ef28cf76280bb3d628fc9793a7f7d636e9cdc709"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7c8607dc0875a0fb8025d292f72635aaabc8131c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"Workflow::"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":" +-----------------+    +----------------------+ 1. +--------------------+"},{"line_number":47,"context_line":" |                 |   3|                      \u003c----+ Nova,-Neutron, Etc.|"},{"line_number":48,"context_line":" |  Keystone       \u003c----+        Middleware    |    |                    |"},{"line_number":49,"context_line":" |                 |    |                      |    +--------------------+"},{"line_number":50,"context_line":" +-----------------+    |                      |"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a016987_13287399","line":47,"updated":"2015-05-19 12:55:26.000000000","message":"This looks like nova is calling the middleware.","commit_id":"ef28cf76280bb3d628fc9793a7f7d636e9cdc709"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"be6ada39a5dc921acd346f95292d1bb096c27e5f","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"1. Nova makes call to enforce policy.  API is identical to the"},{"line_number":67,"context_line":"   oslo.policy API, but will be implemented by middleware."},{"line_number":68,"context_line":"2. Middleware checks the cache to see if there is a current"},{"line_number":69,"context_line":"   policy file."},{"line_number":70,"context_line":"3. If the file is missing or out of date, middleware calls the"}],"source_content_type":"text/x-rst","patch_set":13,"id":"1aca2d91_fd375be1","line":67,"updated":"2015-05-06 16:26:36.000000000","message":"How are we going to deal with the stuff where the role depends on the request content/body?  ( e.g something like request.domain_id is same as tokens_domain_id etc).\n\nIsn\u0027t that project specific logic?","commit_id":"ef28cf76280bb3d628fc9793a7f7d636e9cdc709"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7c8607dc0875a0fb8025d292f72635aaabc8131c","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"1. Nova makes call to enforce policy.  API is identical to the"},{"line_number":67,"context_line":"   oslo.policy API, but will be implemented by middleware."},{"line_number":68,"context_line":"2. Middleware checks the cache to see if there is a current"},{"line_number":69,"context_line":"   policy file."},{"line_number":70,"context_line":"3. If the file is missing or out of date, middleware calls the"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a016987_b32abf8e","line":67,"updated":"2015-05-19 12:55:26.000000000","message":"Middleware is in the paste pipeline, but this looks like it\u0027s just a library call, which isn\u0027t middleware. This should be a separate library and not keystonemiddleware.","commit_id":"ef28cf76280bb3d628fc9793a7f7d636e9cdc709"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"311934834b7cf8f85266a7d7bb4c06ac78c180e1","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"1. Nova makes call to enforce policy.  API is identical to the"},{"line_number":67,"context_line":"   oslo.policy API, but will be implemented by middleware."},{"line_number":68,"context_line":"2. Middleware checks the cache to see if there is a current"},{"line_number":69,"context_line":"   policy file."},{"line_number":70,"context_line":"3. If the file is missing or out of date, middleware calls the"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7ad8896b_1146aebf","line":67,"in_reply_to":"1aca2d91_fd375be1","updated":"2015-05-11 16:46:45.000000000","message":"yes, we\u0027ll need to provide a callback mechanism to allow services to fetch/lookup resources for the enforcement. Similar to how we does it in Keystone today. See\n\nhttps://github.com/openstack/keystone/blob/master/keystone/common/controller.py#L121","commit_id":"ef28cf76280bb3d628fc9793a7f7d636e9cdc709"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"aff45dc73b9e880a17fd51d5db2578e00107a853","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"1. Nova makes call to enforce policy.  API is identical to the"},{"line_number":67,"context_line":"   oslo.policy API, but will be implemented by middleware."},{"line_number":68,"context_line":"2. Middleware checks the cache to see if there is a current"},{"line_number":69,"context_line":"   policy file."},{"line_number":70,"context_line":"3. If the file is missing or out of date, middleware calls the"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a016987_eb8eda2c","line":67,"in_reply_to":"7a016987_b32abf8e","updated":"2015-05-20 19:00:55.000000000","message":"Yes Brant is correct. \nYou nee one more middleware to put the request specific details in context for the policy middleware to interpret it, which I don\u0027t think makes sens","commit_id":"ef28cf76280bb3d628fc9793a7f7d636e9cdc709"},{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"5582edcc705f54e6059a7acd219e9fe2a813d6bb","unresolved":false,"context_lines":[{"line_number":68,"context_line":"2. Middleware checks the cache to see if there is a current"},{"line_number":69,"context_line":"   policy file."},{"line_number":70,"context_line":"3. If the file is missing or out of date, middleware calls the"},{"line_number":71,"context_line":"   identity API to get policy for endpoint from the Keystone server."},{"line_number":72,"context_line":"4. Middleware stores the policy file in the cache."},{"line_number":73,"context_line":"5. Middleware forwards the call to enforce policy on to the"},{"line_number":74,"context_line":"   oslo.policy library."}],"source_content_type":"text/x-rst","patch_set":13,"id":"1aca2d91_af4cd242","line":71,"updated":"2015-05-07 20:02:36.000000000","message":"I recalled TRL was mentioned at some point.  Can someone give more detail?","commit_id":"ef28cf76280bb3d628fc9793a7f7d636e9cdc709"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7c8607dc0875a0fb8025d292f72635aaabc8131c","unresolved":false,"context_lines":[{"line_number":89,"context_line":"Describe any potential security impact on the system.  Some of the items to"},{"line_number":90,"context_line":"consider include:"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"},{"line_number":93,"context_line":"* Yes.  The policy files are data used in security enforcement.  Access to them"},{"line_number":94,"context_line":"  is highly sensitive."},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a016987_7606751e","line":92,"updated":"2015-05-19 12:55:26.000000000","message":"Remove the questions.","commit_id":"ef28cf76280bb3d628fc9793a7f7d636e9cdc709"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7c8607dc0875a0fb8025d292f72635aaabc8131c","unresolved":false,"context_lines":[{"line_number":155,"context_line":"Assigner(s)"},{"line_number":156,"context_line":"-----------"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Who is leading the writing of the code? Or is this a blueprint where you\u0027re"},{"line_number":159,"context_line":"throwing it out there to see who picks it up?"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"If more than one person is working on the implementation, please designate the"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a016987_f6402536","line":158,"updated":"2015-05-19 12:55:26.000000000","message":"Remove the boilerplate.","commit_id":"ef28cf76280bb3d628fc9793a7f7d636e9cdc709"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7c8607dc0875a0fb8025d292f72635aaabc8131c","unresolved":false,"context_lines":[{"line_number":170,"context_line":"Work Items"},{"line_number":171,"context_line":"----------"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Work items or tasks -- break the feature up into the things that need to be"},{"line_number":174,"context_line":"done to implement it. Those parts might end up being done by different people,"},{"line_number":175,"context_line":"but we\u0027re mostly trying to understand the timeline for implementation."},{"line_number":176,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a016987_561ed95f","line":173,"updated":"2015-05-19 12:55:26.000000000","message":"Fill out this section.","commit_id":"ef28cf76280bb3d628fc9793a7f7d636e9cdc709"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7c8607dc0875a0fb8025d292f72635aaabc8131c","unresolved":false,"context_lines":[{"line_number":178,"context_line":"Dependencies"},{"line_number":179,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"* Include specific references to specs and/or blueprints in keystone, or in"},{"line_number":182,"context_line":"  other projects, that this one either depends on or is related to."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"* If this requires functionality of another project that is not currently used"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a016987_d61be971","line":181,"updated":"2015-05-19 12:55:26.000000000","message":"Fill out this section.","commit_id":"ef28cf76280bb3d628fc9793a7f7d636e9cdc709"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7c8607dc0875a0fb8025d292f72635aaabc8131c","unresolved":false,"context_lines":[{"line_number":192,"context_line":"Documentation Impact"},{"line_number":193,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"What is the impact on the docs team of this change? Some changes might require"},{"line_number":196,"context_line":"donating resources to the docs team to have the documentation updated. Don\u0027t"},{"line_number":197,"context_line":"repeat details discussed above, but please reference them here."},{"line_number":198,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a016987_f6126556","line":195,"updated":"2015-05-19 12:55:26.000000000","message":"Fill out this section.","commit_id":"ef28cf76280bb3d628fc9793a7f7d636e9cdc709"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7c8607dc0875a0fb8025d292f72635aaabc8131c","unresolved":false,"context_lines":[{"line_number":200,"context_line":"References"},{"line_number":201,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"Please add any useful references here. You are not required to have any"},{"line_number":204,"context_line":"reference. Moreover, this specification should still make sense when your"},{"line_number":205,"context_line":"references are unavailable. Examples of what you could include are:"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a016987_1616214c","line":203,"updated":"2015-05-19 12:55:26.000000000","message":"remove the default text here and post links to references.","commit_id":"ef28cf76280bb3d628fc9793a7f7d636e9cdc709"}],"specs/kilo/policy-unified.rst":[{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"b70c1f11bd94287ad437a9ac4ec2db68034f37f0","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Unify all of the policy files from the known set of services into a single"},{"line_number":15,"context_line":"file.  Use common definitions for what is meant by admin at the global, domain,"},{"line_number":16,"context_line":"and service level.  Defconmlfit between endpoints by the api-name"},{"line_number":17,"context_line":"(identity, compute) for each of the policy enforcement points."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_8d76223d","line":16,"updated":"2014-11-12 01:24:01.000000000","message":"Deconflict?","commit_id":"685ee5898a63566479767bc1f3bc043d9dec4645"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"b70c1f11bd94287ad437a9ac4ec2db68034f37f0","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Each service maintains its own policy rules file.  That means that common terms"},{"line_number":25,"context_line":"like \"is_admin\" are redefined between endpoints, with subtle differences"},{"line_number":26,"context_line":"between them.  Instead, they should all share a common definition."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_4da35a9e","line":26,"updated":"2014-11-12 01:24:01.000000000","message":"We could also mention that it has a huge impact on Horizon, since it only has a copy of the default policy files.","commit_id":"685ee5898a63566479767bc1f3bc043d9dec4645"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"b70c1f11bd94287ad437a9ac4ec2db68034f37f0","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Leave it as is."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Build a mechanism to compose individual policy filkes out of component parts."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Security Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_6da01691","line":48,"updated":"2014-11-12 01:24:01.000000000","message":"files","commit_id":"685ee5898a63566479767bc1f3bc043d9dec4645"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"b70c1f11bd94287ad437a9ac4ec2db68034f37f0","unresolved":false,"context_lines":[{"line_number":96,"context_line":"Aside from the API, are there other ways a user will interact with this"},{"line_number":97,"context_line":"feature?"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"* Does this change have an impact on python-keystoneclient? What does the user"},{"line_number":100,"context_line":"  interface there look like?"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_ed096696","line":99,"updated":"2014-11-12 01:24:01.000000000","message":"In a quick thinking, I don\u0027t think there will have impact on python-keystoneclient","commit_id":"685ee5898a63566479767bc1f3bc043d9dec4645"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"b70c1f11bd94287ad437a9ac4ec2db68034f37f0","unresolved":false,"context_lines":[{"line_number":103,"context_line":"------------------"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Slightly larger rules file might have a miniscule performance penalty on first"},{"line_number":106,"context_line":"parse.  Additional rule evaluations might benfit from tuning the  way rules"},{"line_number":107,"context_line":"matches are performed."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Other Deployer Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_4dca7a50","line":106,"updated":"2014-11-12 01:24:01.000000000","message":"benefit","commit_id":"685ee5898a63566479767bc1f3bc043d9dec4645"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"b70c1f11bd94287ad437a9ac4ec2db68034f37f0","unresolved":false,"context_lines":[{"line_number":115,"context_line":"Developer Impact"},{"line_number":116,"context_line":"----------------"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Minimal.  The definitnion of terms like \"cloud\"admin\" will change, but the"},{"line_number":119,"context_line":"impact should be constrained to the other policy rules."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_2ded2ec4","line":118,"updated":"2014-11-12 01:24:01.000000000","message":"definition, cloud_admin?","commit_id":"685ee5898a63566479767bc1f3bc043d9dec4645"}]}
