)]}'
{"specs/kilo/token-provider-cleanup.rst":[{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"e3a9837017c566c8b5b6a01658c63154b4c7eec7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  current token data model introduced in Juno) and allows for extracting the"},{"line_number":39,"context_line":"  data in a way that can be used to generate a Token ID. The most extreme case"},{"line_number":40,"context_line":"  of this would be the PKI token where all of the data is encoded into the ID"},{"line_number":41,"context_line":"  itself as ASN1 format."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  The issue token method would also make decisions such as persisting the token"},{"line_number":44,"context_line":"  data to some sort of stable storage and/or pre-seeding caches."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_c1b09645","line":41,"updated":"2014-11-14 16:20:43.000000000","message":"I don\u0027t think we even need the ASN1 reference.  Converting from a PKIZ token to the data model should be outside the scope of the token provider.  That should be done by middleware in Keystone prior to any call to the token provider.  Thanks for thinking of the complexity there, but I agree with your main point that this should be simple.","commit_id":"01db24972764de832370f60ae77e7abbf25b07cf"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"ec7f2c6df639985f33b6290effc23d7c3a130cf5","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  current token data model introduced in Juno) and allows for extracting the"},{"line_number":39,"context_line":"  data in a way that can be used to generate a Token ID. The most extreme case"},{"line_number":40,"context_line":"  of this would be the PKI token where all of the data is encoded into the ID"},{"line_number":41,"context_line":"  itself as ASN1 format."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  The issue token method would also make decisions such as persisting the token"},{"line_number":44,"context_line":"  data to some sort of stable storage and/or pre-seeding caches."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_f6f712d1","line":41,"in_reply_to":"5a890539_c1b09645","updated":"2014-11-14 16:51:50.000000000","message":"Will drop ASN1, but the rest of the verbiage will stay.","commit_id":"01db24972764de832370f60ae77e7abbf25b07cf"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"e3a9837017c566c8b5b6a01658c63154b4c7eec7","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  types) allowing Keystone and Middleware to load the correct provider(s) to"},{"line_number":48,"context_line":"  handle validating the token. Longer term this allows us to support multiple"},{"line_number":49,"context_line":"  ID types (seamless conversion). Initially only one provider will be allowed"},{"line_number":50,"context_line":"  at a time."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* **Validate Token**: A method that performs the validation and either utilizes"},{"line_number":53,"context_line":"  Keystone\u0027s managers/etc to regenerate the token data or to extract the data"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_219a3a6e","line":50,"updated":"2014-11-14 16:20:43.000000000","message":"What if we remove this restriction?  While there can and should only be one default, having multiple potential providers might actually simplify the solution.  Each could be registered with a token format identifier:  If (PKIZ) -\u003e use the PKIZ validator, if UUID etc.  The selector could then be base level component.  We already have multiple types supported, so only allowing a single validation type will regress current behavior.","commit_id":"01db24972764de832370f60ae77e7abbf25b07cf"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"ec7f2c6df639985f33b6290effc23d7c3a130cf5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  types) allowing Keystone and Middleware to load the correct provider(s) to"},{"line_number":48,"context_line":"  handle validating the token. Longer term this allows us to support multiple"},{"line_number":49,"context_line":"  ID types (seamless conversion). Initially only one provider will be allowed"},{"line_number":50,"context_line":"  at a time."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* **Validate Token**: A method that performs the validation and either utilizes"},{"line_number":53,"context_line":"  Keystone\u0027s managers/etc to regenerate the token data or to extract the data"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_96c88ea9","line":50,"in_reply_to":"5a890539_219a3a6e","updated":"2014-11-14 16:51:50.000000000","message":"I\u0027ll add that the spec cannot be complete without lifting the restriction. but the base implementation (pass 1) will be the same as today.\n\nFair point across the board.","commit_id":"01db24972764de832370f60ae77e7abbf25b07cf"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"9e89536dde6228d79eac30f8ae8f4c7c921d861b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  implement this. An example provider that will re-implement this will be the"},{"line_number":64,"context_line":"  PKI token provider."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"  Middleware Plugin will rely on some common logic (in the case of not needing"},{"line_number":67,"context_line":"  to ask Keystone for the token data) as the `Validate Token` method."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"A token data formatter class will also need to be developed. This class will"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_e5df680b","line":66,"updated":"2014-11-14 09:32:52.000000000","message":"...did you mean \"...will rely on the same common logic\"...or there a different point here?","commit_id":"01db24972764de832370f60ae77e7abbf25b07cf"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"ec7f2c6df639985f33b6290effc23d7c3a130cf5","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  implement this. An example provider that will re-implement this will be the"},{"line_number":64,"context_line":"  PKI token provider."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"  Middleware Plugin will rely on some common logic (in the case of not needing"},{"line_number":67,"context_line":"  to ask Keystone for the token data) as the `Validate Token` method."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"A token data formatter class will also need to be developed. This class will"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_760c02ee","line":66,"in_reply_to":"5a890539_a10f0a87","updated":"2014-11-14 16:51:50.000000000","message":"Better. ++","commit_id":"01db24972764de832370f60ae77e7abbf25b07cf"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"e3a9837017c566c8b5b6a01658c63154b4c7eec7","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  implement this. An example provider that will re-implement this will be the"},{"line_number":64,"context_line":"  PKI token provider."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"  Middleware Plugin will rely on some common logic (in the case of not needing"},{"line_number":67,"context_line":"  to ask Keystone for the token data) as the `Validate Token` method."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"A token data formatter class will also need to be developed. This class will"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_a10f0a87","line":66,"in_reply_to":"5a890539_e5df680b","updated":"2014-11-14 16:20:43.000000000","message":"Perhaps:   Middleware Plugin will use a method in common with `Validate Token` to avoid retrieving the token data from the persisted store more than once.","commit_id":"01db24972764de832370f60ae77e7abbf25b07cf"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"e3a9837017c566c8b5b6a01658c63154b4c7eec7","unresolved":false,"context_lines":[{"line_number":66,"context_line":"  Middleware Plugin will rely on some common logic (in the case of not needing"},{"line_number":67,"context_line":"  to ask Keystone for the token data) as the `Validate Token` method."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"A token data formatter class will also need to be developed. This class will"},{"line_number":70,"context_line":"take the token model and emit the documented token data format. The token data"},{"line_number":71,"context_line":"formats will be documented for developers and formatter classes for each"},{"line_number":72,"context_line":"version will be provided (currently V2 and V3)."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_01e37ea4","line":69,"updated":"2014-11-14 16:20:43.000000000","message":"instead of \"developed\" I would say \"The V2 and V3 token helper classes will be refactored to take the token model and emit the documented token data format. The token data\nformats will be documented for developers and formatter classes for each\nversion will be provided (currently V2 and V3).\"","commit_id":"01db24972764de832370f60ae77e7abbf25b07cf"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"ec7f2c6df639985f33b6290effc23d7c3a130cf5","unresolved":false,"context_lines":[{"line_number":66,"context_line":"  Middleware Plugin will rely on some common logic (in the case of not needing"},{"line_number":67,"context_line":"  to ask Keystone for the token data) as the `Validate Token` method."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"A token data formatter class will also need to be developed. This class will"},{"line_number":70,"context_line":"take the token model and emit the documented token data format. The token data"},{"line_number":71,"context_line":"formats will be documented for developers and formatter classes for each"},{"line_number":72,"context_line":"version will be provided (currently V2 and V3)."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_f6c2b283","line":69,"in_reply_to":"5a890539_01e37ea4","updated":"2014-11-14 16:51:50.000000000","message":"++","commit_id":"01db24972764de832370f60ae77e7abbf25b07cf"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"9e89536dde6228d79eac30f8ae8f4c7c921d861b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"Notifications Impact"},{"line_number":95,"context_line":"--------------------"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"None"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Other End User Impact"},{"line_number":100,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_8525c40a","line":97,"updated":"2014-11-14 09:32:52.000000000","message":"Might it be worth stating whether it is the responsibility of the `Issue Token` method to generate a notification that a token has been issued (if we do indeed notify on that event)..or whether the framework will do that one `Issue Token` has done its job?","commit_id":"01db24972764de832370f60ae77e7abbf25b07cf"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"f669027fd31b68804b44f957d99d1f89b6d60037","unresolved":false,"context_lines":[{"line_number":94,"context_line":"Notifications Impact"},{"line_number":95,"context_line":"--------------------"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"None"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Other End User Impact"},{"line_number":100,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_d696964b","line":97,"in_reply_to":"5a890539_8525c40a","updated":"2014-11-14 16:53:56.000000000","message":"I\u0027ll include this. The new provider will *not* be responsible for issuing the notifications.","commit_id":"01db24972764de832370f60ae77e7abbf25b07cf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"faf83fb0a1e03b7a8337a43b0cad90f3d82031f1","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Performance should have no direct impact from this change. This will, however,"},{"line_number":110,"context_line":"allow deployers to select the best token provider for their deployments."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Other Deployer Impact"},{"line_number":113,"context_line":"---------------------"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_3001a206","line":111,"updated":"2014-11-14 16:20:59.000000000","message":"If you *really* wanted to be specific you could say the developer performance increases because it will be easier for them to implemented new token providers! \u003d)","commit_id":"01db24972764de832370f60ae77e7abbf25b07cf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"faf83fb0a1e03b7a8337a43b0cad90f3d82031f1","unresolved":false,"context_lines":[{"line_number":135,"context_line":"----------"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"* Develop enhanced ABCMeta type class for enforcing the contract on token"},{"line_number":138,"context_line":"  providers. This will include method signatures on required methods."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"* Develop token formatter classes that can convert token data to token model"},{"line_number":141,"context_line":"  and vice-versa for V2 Token and V3 Token Formats"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_9b5517fc","line":138,"updated":"2014-11-14 16:20:59.000000000","message":"Is there an example of this somewhere?","commit_id":"01db24972764de832370f60ae77e7abbf25b07cf"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"ec7f2c6df639985f33b6290effc23d7c3a130cf5","unresolved":false,"context_lines":[{"line_number":135,"context_line":"----------"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"* Develop enhanced ABCMeta type class for enforcing the contract on token"},{"line_number":138,"context_line":"  providers. This will include method signatures on required methods."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"* Develop token formatter classes that can convert token data to token model"},{"line_number":141,"context_line":"  and vice-versa for V2 Token and V3 Token Formats"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_d64cd644","line":138,"in_reply_to":"5a890539_9b5517fc","updated":"2014-11-14 16:51:50.000000000","message":"Nope. But it is basically going to use inspect and the same way ABCMeta works today.\n\nI\u0027ll 2x check but largely this is not something I\u0027ve seen in python yet.","commit_id":"01db24972764de832370f60ae77e7abbf25b07cf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"faf83fb0a1e03b7a8337a43b0cad90f3d82031f1","unresolved":false,"context_lines":[{"line_number":138,"context_line":"  providers. This will include method signatures on required methods."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"* Develop token formatter classes that can convert token data to token model"},{"line_number":141,"context_line":"  and vice-versa for V2 Token and V3 Token Formats"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"* Consolidate token issuance pipeline to not be version-specific."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_3b46e34f","line":141,"updated":"2014-11-14 16:20:59.000000000","message":"Where will these live? This will be the token providers responsibility, correct?","commit_id":"01db24972764de832370f60ae77e7abbf25b07cf"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"ec7f2c6df639985f33b6290effc23d7c3a130cf5","unresolved":false,"context_lines":[{"line_number":138,"context_line":"  providers. This will include method signatures on required methods."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"* Develop token formatter classes that can convert token data to token model"},{"line_number":141,"context_line":"  and vice-versa for V2 Token and V3 Token Formats"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"* Consolidate token issuance pipeline to not be version-specific."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_166ade80","line":141,"in_reply_to":"5a890539_3b46e34f","updated":"2014-11-14 16:51:50.000000000","message":"The formatters will be part of Keystone. The formatter will take the token data model (not formatted) and create the known format (current v2/v3 data blobs).\n\nThe validators will [if they need to format] pass the token data to the formatter.","commit_id":"01db24972764de832370f60ae77e7abbf25b07cf"}]}
