)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13140,"name":"Victor Silva","email":"victor@lsd.ufcg.edu.br","username":"victsou"},"change_message_id":"0ce0e5876ca283aa7910363c077f07a2cf41d097","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This specification proposes changes in the mapping engine logic,"},{"line_number":10,"context_line":"allowing for direct groups mapping passed in a assertion/claim."},{"line_number":11,"context_line":"Part of the change would also require change in a role assignments logic"},{"line_number":12,"context_line":"allowing for creating assignments pointing to a non existing groups."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ibe1e838abd050c30cf38478dfcf1580c65bcc344"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3a961159_ebe78a10","line":12,"updated":"2014-12-09 14:48:03.000000000","message":"This no longer applies, right?","commit_id":"a67917148429f1797d4854bc4835d5fa1849775b"}],"specs/kilo/mapping-enhancements.rst":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"424b7834a014890bf6f723031d9ec1e02e927851","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp mapping-enhancements"},{"line_number":12,"context_line":"\u003chttps://blueprints.launchpad.net/keystone/+spec/mapping-enhancements\u003e`_"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Federated authentication and authorization was shipped with OpenStack Icehouse"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_fcd4a7ea","line":12,"updated":"2014-12-01 13:48:05.000000000","message":"Is it ok that there are no bps by that link? :)","commit_id":"13fcc1208e8961bb80a8094c716ad5ff995e36c7"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"6b8a820eb3b7d52f832f3d1ab6a4250b5d043164","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp mapping-enhancements"},{"line_number":12,"context_line":"\u003chttps://blueprints.launchpad.net/keystone/+spec/mapping-enhancements\u003e`_"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Federated authentication and authorization was shipped with OpenStack Icehouse"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_a87015db","line":12,"in_reply_to":"5a890539_fcd4a7ea","updated":"2014-12-01 14:25:06.000000000","message":"i suspect this would not be available until this spec is merged. Anyway, I followed the patter from other merged specs.","commit_id":"13fcc1208e8961bb80a8094c716ad5ff995e36c7"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"89764f8e0087b6ee281b4693854c1fee6fe6d7be","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Federated authentication and authorization was shipped with OpenStack Icehouse"},{"line_number":16,"context_line":"release.  One of the core features is the ``mapping engine`` that translates"},{"line_number":17,"context_line":"``SAML2/OpenId Connect`` assertions into Keystone specific parameters"},{"line_number":18,"context_line":"(``user_id``, ``groups``). Mapping engine operates on top of ``mapping rules``"},{"line_number":19,"context_line":"configured for every registered ``Identity Provider``. Mapping rules specify"},{"line_number":20,"context_line":"how the assertions should be interpreted to grant ephemeral user access to"},{"line_number":21,"context_line":"certain resources. However, lots of discussions arose around enhancing mapping"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_e7989077","line":18,"updated":"2014-12-01 12:04:01.000000000","message":"The mapping engine operates*","commit_id":"13fcc1208e8961bb80a8094c716ad5ff995e36c7"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"5369d5b419eb1f64e71f5f00d050bbf8dcf4c7b3","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Federated authentication and authorization was shipped with OpenStack Icehouse"},{"line_number":16,"context_line":"release.  One of the core features is the ``mapping engine`` that translates"},{"line_number":17,"context_line":"``SAML2/OpenId Connect`` assertions into Keystone specific parameters"},{"line_number":18,"context_line":"(``user_id``, ``groups``). Mapping engine operates on top of ``mapping rules``"},{"line_number":19,"context_line":"configured for every registered ``Identity Provider``. Mapping rules specify"},{"line_number":20,"context_line":"how the assertions should be interpreted to grant ephemeral user access to"},{"line_number":21,"context_line":"certain resources. However, lots of discussions arose around enhancing mapping"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_a2d67651","line":18,"in_reply_to":"5a890539_e7989077","updated":"2014-12-01 12:28:32.000000000","message":"Done","commit_id":"13fcc1208e8961bb80a8094c716ad5ff995e36c7"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"424b7834a014890bf6f723031d9ec1e02e927851","unresolved":false,"context_lines":[{"line_number":19,"context_line":"configured for every registered ``Identity Provider``. Mapping rules specify"},{"line_number":20,"context_line":"how the assertions should be interpreted to grant ephemeral user access to"},{"line_number":21,"context_line":"certain resources. However, lots of discussions arose around enhancing mapping"},{"line_number":22,"context_line":"engine and mapping rules \u0027language\u0027 for the easier and more powerfull"},{"line_number":23,"context_line":"configuraton capabilities. It is also extremely important to allow cloud"},{"line_number":24,"context_line":"administrators be in power to control authorization grants assigned to"},{"line_number":25,"context_line":"ephemeral (federated) users.  This specification focuses on ability to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_9cf6438f","line":22,"updated":"2014-12-01 13:48:05.000000000","message":"s/powerfull/powerful/","commit_id":"13fcc1208e8961bb80a8094c716ad5ff995e36c7"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"6b8a820eb3b7d52f832f3d1ab6a4250b5d043164","unresolved":false,"context_lines":[{"line_number":19,"context_line":"configured for every registered ``Identity Provider``. Mapping rules specify"},{"line_number":20,"context_line":"how the assertions should be interpreted to grant ephemeral user access to"},{"line_number":21,"context_line":"certain resources. However, lots of discussions arose around enhancing mapping"},{"line_number":22,"context_line":"engine and mapping rules \u0027language\u0027 for the easier and more powerfull"},{"line_number":23,"context_line":"configuraton capabilities. It is also extremely important to allow cloud"},{"line_number":24,"context_line":"administrators be in power to control authorization grants assigned to"},{"line_number":25,"context_line":"ephemeral (federated) users.  This specification focuses on ability to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_287b45f5","line":22,"in_reply_to":"5a890539_9cf6438f","updated":"2014-12-01 14:25:06.000000000","message":"Done","commit_id":"13fcc1208e8961bb80a8094c716ad5ff995e36c7"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"89764f8e0087b6ee281b4693854c1fee6fe6d7be","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Currently, part of the infrastructure preparation is configuration of"},{"line_number":34,"context_line":"``projects``, ``domains``, ``role assignments`` and ``groups`` for ephemeral"},{"line_number":35,"context_line":"users. This approach is good enough, however for some specific use-cases it"},{"line_number":36,"context_line":"could be made more transparent and automatized. What is more, a users managed"},{"line_number":37,"context_line":"by Identity Providers administrators without changing the mapping rules at the"},{"line_number":38,"context_line":"``Service Provider`` level."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_27dff80d","line":36,"updated":"2014-12-01 12:04:01.000000000","message":"\"a user managed\" or \"users managed\"","commit_id":"13fcc1208e8961bb80a8094c716ad5ff995e36c7"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"5369d5b419eb1f64e71f5f00d050bbf8dcf4c7b3","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Currently, part of the infrastructure preparation is configuration of"},{"line_number":34,"context_line":"``projects``, ``domains``, ``role assignments`` and ``groups`` for ephemeral"},{"line_number":35,"context_line":"users. This approach is good enough, however for some specific use-cases it"},{"line_number":36,"context_line":"could be made more transparent and automatized. What is more, a users managed"},{"line_number":37,"context_line":"by Identity Providers administrators without changing the mapping rules at the"},{"line_number":38,"context_line":"``Service Provider`` level."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_02cf4ab4","line":36,"in_reply_to":"5a890539_27dff80d","updated":"2014-12-01 12:28:32.000000000","message":"Done","commit_id":"13fcc1208e8961bb80a8094c716ad5ff995e36c7"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"89764f8e0087b6ee281b4693854c1fee6fe6d7be","unresolved":false,"context_lines":[{"line_number":54,"context_line":"to control users access. Current mapping engine capabilities, like specifying"},{"line_number":55,"context_line":"effective groups should stay, so the proposed change is additive and backward"},{"line_number":56,"context_line":"compatible.  Also, cloud administrator (or whoever builds mapping rules) should"},{"line_number":57,"context_line":"be able to specify effective domains. This is required, as group will be"},{"line_number":58,"context_line":"usually specified by names, and domain name must be present to precisely"},{"line_number":59,"context_line":"identify the group entity in the system. Role assignments should be able to"},{"line_number":60,"context_line":"\u0027point\u0027 to groups that currently do not exist in the system."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_c7f0f493","line":57,"updated":"2014-12-01 12:04:01.000000000","message":"what \"effective domains\" means? Can you elaborate more this setence?","commit_id":"13fcc1208e8961bb80a8094c716ad5ff995e36c7"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"5369d5b419eb1f64e71f5f00d050bbf8dcf4c7b3","unresolved":false,"context_lines":[{"line_number":54,"context_line":"to control users access. Current mapping engine capabilities, like specifying"},{"line_number":55,"context_line":"effective groups should stay, so the proposed change is additive and backward"},{"line_number":56,"context_line":"compatible.  Also, cloud administrator (or whoever builds mapping rules) should"},{"line_number":57,"context_line":"be able to specify effective domains. This is required, as group will be"},{"line_number":58,"context_line":"usually specified by names, and domain name must be present to precisely"},{"line_number":59,"context_line":"identify the group entity in the system. Role assignments should be able to"},{"line_number":60,"context_line":"\u0027point\u0027 to groups that currently do not exist in the system."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_e2b79e1f","line":57,"in_reply_to":"5a890539_c7f0f493","updated":"2014-12-01 12:28:32.000000000","message":"looking at your comment below i think it\u0027s no longer required?","commit_id":"13fcc1208e8961bb80a8094c716ad5ff995e36c7"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"89764f8e0087b6ee281b4693854c1fee6fe6d7be","unresolved":false,"context_lines":[{"line_number":62,"context_line":"Proposed change include:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* Change ``local`` entities, so the effective groups can be identified by"},{"line_number":65,"context_line":"  ``name`` and ``domain``, instead of ``id`` only. An example would look like:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. code-block:: javascript"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_4734044a","line":65,"updated":"2014-12-01 12:04:01.000000000","message":"here its clear what you meant about effective domains above","commit_id":"13fcc1208e8961bb80a8094c716ad5ff995e36c7"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"5369d5b419eb1f64e71f5f00d050bbf8dcf4c7b3","unresolved":false,"context_lines":[{"line_number":62,"context_line":"Proposed change include:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* Change ``local`` entities, so the effective groups can be identified by"},{"line_number":65,"context_line":"  ``name`` and ``domain``, instead of ``id`` only. An example would look like:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. code-block:: javascript"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_02366ab4","line":65,"in_reply_to":"5a890539_4734044a","updated":"2014-12-01 12:28:32.000000000","message":"good.","commit_id":"13fcc1208e8961bb80a8094c716ad5ff995e36c7"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"89764f8e0087b6ee281b4693854c1fee6fe6d7be","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    {"},{"line_number":70,"context_line":"        \"group\" {"},{"line_number":71,"context_line":"            \"name\": \"developers\","},{"line_number":72,"context_line":"            \"domain\": \"clients\","},{"line_number":73,"context_line":"        }"},{"line_number":74,"context_line":"    },"},{"line_number":75,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_2714589e","line":72,"updated":"2014-12-01 12:04:01.000000000","message":"extra comma","commit_id":"13fcc1208e8961bb80a8094c716ad5ff995e36c7"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"5369d5b419eb1f64e71f5f00d050bbf8dcf4c7b3","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    {"},{"line_number":70,"context_line":"        \"group\" {"},{"line_number":71,"context_line":"            \"name\": \"developers\","},{"line_number":72,"context_line":"            \"domain\": \"clients\","},{"line_number":73,"context_line":"        }"},{"line_number":74,"context_line":"    },"},{"line_number":75,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_2239a6a3","line":72,"in_reply_to":"5a890539_2714589e","updated":"2014-12-01 12:28:32.000000000","message":"Done","commit_id":"13fcc1208e8961bb80a8094c716ad5ff995e36c7"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"89764f8e0087b6ee281b4693854c1fee6fe6d7be","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    Marek Denis \u003cmarek-denis\u003e"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"Other contributors:"},{"line_number":201,"context_line":"    Nathan Kinder \u003cnkinder\u003e"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"Work Items"},{"line_number":204,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_e747b0a1","line":201,"updated":"2014-12-01 12:04:01.000000000","message":"we\u0027d appreciate to help too:\n- rodrigodsousa\n- vsilva","commit_id":"13fcc1208e8961bb80a8094c716ad5ff995e36c7"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"5369d5b419eb1f64e71f5f00d050bbf8dcf4c7b3","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    Marek Denis \u003cmarek-denis\u003e"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"Other contributors:"},{"line_number":201,"context_line":"    Nathan Kinder \u003cnkinder\u003e"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"Work Items"},{"line_number":204,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_42407207","line":201,"in_reply_to":"5a890539_e747b0a1","updated":"2014-12-01 12:28:32.000000000","message":"from now on you are responsible too :-)","commit_id":"13fcc1208e8961bb80a8094c716ad5ff995e36c7"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"89764f8e0087b6ee281b4693854c1fee6fe6d7be","unresolved":false,"context_lines":[{"line_number":204,"context_line":"----------"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"* Change ``role assignments`` engine so they can map existing roles with non"},{"line_number":207,"context_line":"  existing groups."},{"line_number":208,"context_line":"* Enhance mapping engine so the ``local`` can map local ``domain``."},{"line_number":209,"context_line":"* Enhance mapping engine so"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_876b4c1e","line":207,"updated":"2014-12-01 12:04:01.000000000","message":"maybe you need to add some more detail about this change in the spec.","commit_id":"13fcc1208e8961bb80a8094c716ad5ff995e36c7"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"5369d5b419eb1f64e71f5f00d050bbf8dcf4c7b3","unresolved":false,"context_lines":[{"line_number":204,"context_line":"----------"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"* Change ``role assignments`` engine so they can map existing roles with non"},{"line_number":207,"context_line":"  existing groups."},{"line_number":208,"context_line":"* Enhance mapping engine so the ``local`` can map local ``domain``."},{"line_number":209,"context_line":"* Enhance mapping engine so"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_e265deaf","line":207,"in_reply_to":"5a890539_876b4c1e","updated":"2014-12-01 12:28:32.000000000","message":"hm, for example what?","commit_id":"13fcc1208e8961bb80a8094c716ad5ff995e36c7"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"89764f8e0087b6ee281b4693854c1fee6fe6d7be","unresolved":false,"context_lines":[{"line_number":206,"context_line":"* Change ``role assignments`` engine so they can map existing roles with non"},{"line_number":207,"context_line":"  existing groups."},{"line_number":208,"context_line":"* Enhance mapping engine so the ``local`` can map local ``domain``."},{"line_number":209,"context_line":"* Enhance mapping engine so"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Dependencies"},{"line_number":212,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_a7668853","line":209,"updated":"2014-12-01 12:04:01.000000000","message":"so?","commit_id":"13fcc1208e8961bb80a8094c716ad5ff995e36c7"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"5369d5b419eb1f64e71f5f00d050bbf8dcf4c7b3","unresolved":false,"context_lines":[{"line_number":206,"context_line":"* Change ``role assignments`` engine so they can map existing roles with non"},{"line_number":207,"context_line":"  existing groups."},{"line_number":208,"context_line":"* Enhance mapping engine so the ``local`` can map local ``domain``."},{"line_number":209,"context_line":"* Enhance mapping engine so"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Dependencies"},{"line_number":212,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a890539_2207e6ca","line":209,"in_reply_to":"5a890539_a7668853","updated":"2014-12-01 12:28:32.000000000","message":"hehe, forgot about that....","commit_id":"13fcc1208e8961bb80a8094c716ad5ff995e36c7"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"de156dbcf13dfc9eab50d2c0b1efb261cbc5ccbf","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Enhance Federation mapping algorithms"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp mapping-enhancements"},{"line_number":12,"context_line":"\u003chttps://blueprints.launchpad.net/keystone/+spec/mapping-enhancements\u003e`_"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_3db61b8b","line":9,"updated":"2014-12-01 19:43:42.000000000","message":"\u003d\u003d\u003d\u003d and title length should match","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"85cde6011d1475dece9742609d66cfca950f89d9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Enhance Federation mapping algorithms"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp mapping-enhancements"},{"line_number":12,"context_line":"\u003chttps://blueprints.launchpad.net/keystone/+spec/mapping-enhancements\u003e`_"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_20c33d8b","line":9,"in_reply_to":"5a890539_23299a89","updated":"2014-12-02 09:21:01.000000000","message":"Done","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"51b3935d9d7e88efa48dfd3cb6635ef2e98f173a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Enhance Federation mapping algorithms"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp mapping-enhancements"},{"line_number":12,"context_line":"\u003chttps://blueprints.launchpad.net/keystone/+spec/mapping-enhancements\u003e`_"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_23299a89","line":9,"in_reply_to":"5a890539_3db61b8b","updated":"2014-12-01 20:05:37.000000000","message":"always forget about it :(","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"889c481dec220bbc3981cb59300338fdf3ab1c3b","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Federated authentication and authorization was shipped with OpenStack Icehouse"},{"line_number":16,"context_line":"release.  One of the core features is the ``mapping engine`` that translates"},{"line_number":17,"context_line":"``SAML2/OpenId Connect`` assertions into Keystone specific parameters"},{"line_number":18,"context_line":"(``user_id``, ``groups``). The mapping engine operates on top of ``mapping"},{"line_number":19,"context_line":"rules`` configured for every registered ``Identity Provider``. Mapping rules"},{"line_number":20,"context_line":"specify how the assertions should be interpreted to grant ephemeral user access"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_1e507509","line":17,"updated":"2014-12-01 20:48:13.000000000","message":"not quite true. It actually maps identity attributes. Try\n\nthat translates identity attributes from federation (e.g. SAML2, OpenID) assertions into","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"85cde6011d1475dece9742609d66cfca950f89d9","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Federated authentication and authorization was shipped with OpenStack Icehouse"},{"line_number":16,"context_line":"release.  One of the core features is the ``mapping engine`` that translates"},{"line_number":17,"context_line":"``SAML2/OpenId Connect`` assertions into Keystone specific parameters"},{"line_number":18,"context_line":"(``user_id``, ``groups``). The mapping engine operates on top of ``mapping"},{"line_number":19,"context_line":"rules`` configured for every registered ``Identity Provider``. Mapping rules"},{"line_number":20,"context_line":"specify how the assertions should be interpreted to grant ephemeral user access"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_80b87112","line":17,"in_reply_to":"5a890539_1e507509","updated":"2014-12-02 09:21:01.000000000","message":"Done","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"889c481dec220bbc3981cb59300338fdf3ab1c3b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"rules`` configured for every registered ``Identity Provider``. Mapping rules"},{"line_number":20,"context_line":"specify how the assertions should be interpreted to grant ephemeral user access"},{"line_number":21,"context_line":"to certain resources. However, lots of discussions arose around enhancing"},{"line_number":22,"context_line":"mapping engine and mapping rules \u0027language\u0027 for the easier and more powerful"},{"line_number":23,"context_line":"configuration capabilities. It is also extremely important to allow cloud"},{"line_number":24,"context_line":"administrators be in power to control authorization grants assigned to"},{"line_number":25,"context_line":"ephemeral (federated) users.  This specification focuses on ability to"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_7e67b9ea","line":22,"updated":"2014-12-01 20:48:13.000000000","message":"the mapping","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"85cde6011d1475dece9742609d66cfca950f89d9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"rules`` configured for every registered ``Identity Provider``. Mapping rules"},{"line_number":20,"context_line":"specify how the assertions should be interpreted to grant ephemeral user access"},{"line_number":21,"context_line":"to certain resources. However, lots of discussions arose around enhancing"},{"line_number":22,"context_line":"mapping engine and mapping rules \u0027language\u0027 for the easier and more powerful"},{"line_number":23,"context_line":"configuration capabilities. It is also extremely important to allow cloud"},{"line_number":24,"context_line":"administrators be in power to control authorization grants assigned to"},{"line_number":25,"context_line":"ephemeral (federated) users.  This specification focuses on ability to"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_e0405509","line":22,"in_reply_to":"5a890539_7e67b9ea","updated":"2014-12-02 09:21:01.000000000","message":"Done","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"de156dbcf13dfc9eab50d2c0b1efb261cbc5ccbf","unresolved":false,"context_lines":[{"line_number":23,"context_line":"configuration capabilities. It is also extremely important to allow cloud"},{"line_number":24,"context_line":"administrators be in power to control authorization grants assigned to"},{"line_number":25,"context_line":"ephemeral (federated) users.  This specification focuses on ability to"},{"line_number":26,"context_line":"automatically assign groups a user is already a member according to his home"},{"line_number":27,"context_line":"institute/company configuration."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_18024d09","line":26,"updated":"2014-12-01 19:43:42.000000000","message":"This last sentence reads a bit weird. I\u0027m not sure what you\u0027re trying to say here.","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"85cde6011d1475dece9742609d66cfca950f89d9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"configuration capabilities. It is also extremely important to allow cloud"},{"line_number":24,"context_line":"administrators be in power to control authorization grants assigned to"},{"line_number":25,"context_line":"ephemeral (federated) users.  This specification focuses on ability to"},{"line_number":26,"context_line":"automatically assign groups a user is already a member according to his home"},{"line_number":27,"context_line":"institute/company configuration."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_20717d77","line":26,"in_reply_to":"5a890539_03265eba","updated":"2014-12-02 09:21:01.000000000","message":"removing since I think I am repeating myself.","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"51b3935d9d7e88efa48dfd3cb6635ef2e98f173a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"configuration capabilities. It is also extremely important to allow cloud"},{"line_number":24,"context_line":"administrators be in power to control authorization grants assigned to"},{"line_number":25,"context_line":"ephemeral (federated) users.  This specification focuses on ability to"},{"line_number":26,"context_line":"automatically assign groups a user is already a member according to his home"},{"line_number":27,"context_line":"institute/company configuration."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_03265eba","line":26,"in_reply_to":"5a890539_18024d09","updated":"2014-12-01 20:05:37.000000000","message":"i will try to rephrase it in the following patch.","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"889c481dec220bbc3981cb59300338fdf3ab1c3b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Currently, part of the infrastructure preparation is configuration of"},{"line_number":34,"context_line":"``projects``, ``domains``, ``role assignments`` and ``groups`` for ephemeral"},{"line_number":35,"context_line":"users. This approach is good enough, however for some specific use-cases it"},{"line_number":36,"context_line":"could be made more transparent and automatized. What is more, users managed"},{"line_number":37,"context_line":"by Identity Providers administrators without changing the mapping rules at the"},{"line_number":38,"context_line":"``Service Provider`` level."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_7eaed9e8","line":36,"updated":"2014-12-01 20:48:13.000000000","message":"automated","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"85cde6011d1475dece9742609d66cfca950f89d9","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Currently, part of the infrastructure preparation is configuration of"},{"line_number":34,"context_line":"``projects``, ``domains``, ``role assignments`` and ``groups`` for ephemeral"},{"line_number":35,"context_line":"users. This approach is good enough, however for some specific use-cases it"},{"line_number":36,"context_line":"could be made more transparent and automatized. What is more, users managed"},{"line_number":37,"context_line":"by Identity Providers administrators without changing the mapping rules at the"},{"line_number":38,"context_line":"``Service Provider`` level."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_406cc99d","line":36,"in_reply_to":"5a890539_7eaed9e8","updated":"2014-12-02 09:21:01.000000000","message":"Done","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"889c481dec220bbc3981cb59300338fdf3ab1c3b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"could be made more transparent and automatized. What is more, users managed"},{"line_number":37,"context_line":"by Identity Providers administrators without changing the mapping rules at the"},{"line_number":38,"context_line":"``Service Provider`` level."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Proposed Change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_de8a6d63","line":39,"updated":"2014-12-01 20:48:13.000000000","message":"this last sentence is not complete. Please rephrase","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"85cde6011d1475dece9742609d66cfca950f89d9","unresolved":false,"context_lines":[{"line_number":36,"context_line":"could be made more transparent and automatized. What is more, users managed"},{"line_number":37,"context_line":"by Identity Providers administrators without changing the mapping rules at the"},{"line_number":38,"context_line":"``Service Provider`` level."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Proposed Change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_00e001f9","line":39,"in_reply_to":"5a890539_de8a6d63","updated":"2014-12-02 09:21:01.000000000","message":"Done","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"de156dbcf13dfc9eab50d2c0b1efb261cbc5ccbf","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            \"name\": \"developers\","},{"line_number":72,"context_line":"            \"domain\": \"clients\""},{"line_number":73,"context_line":"        }"},{"line_number":74,"context_line":"    },"},{"line_number":75,"context_line":"    {"},{"line_number":76,"context_line":"        \"groups\": {"},{"line_number":77,"context_line":"            \"id\": \"89678b\""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_58cdb5b6","line":74,"updated":"2014-12-01 19:43:42.000000000","message":"can you add a sentence between the two code-blocks and say something like:\n\n\" instead of the example seen below\"\n\nAnd then close it out by saying that *both* should work.","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"85cde6011d1475dece9742609d66cfca950f89d9","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            \"name\": \"developers\","},{"line_number":72,"context_line":"            \"domain\": \"clients\""},{"line_number":73,"context_line":"        }"},{"line_number":74,"context_line":"    },"},{"line_number":75,"context_line":"    {"},{"line_number":76,"context_line":"        \"groups\": {"},{"line_number":77,"context_line":"            \"id\": \"89678b\""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_00856106","line":74,"in_reply_to":"5a890539_58cdb5b6","updated":"2014-12-02 09:21:01.000000000","message":"added an explanation above.","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"de156dbcf13dfc9eab50d2c0b1efb261cbc5ccbf","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        }"},{"line_number":74,"context_line":"    },"},{"line_number":75,"context_line":"    {"},{"line_number":76,"context_line":"        \"groups\": {"},{"line_number":77,"context_line":"            \"id\": \"89678b\""},{"line_number":78,"context_line":"        }"},{"line_number":79,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_f83661b3","line":76,"updated":"2014-12-01 19:43:42.000000000","message":"i think you have an extra \u0027s\u0027 in groups here","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"51b3935d9d7e88efa48dfd3cb6635ef2e98f173a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        }"},{"line_number":74,"context_line":"    },"},{"line_number":75,"context_line":"    {"},{"line_number":76,"context_line":"        \"groups\": {"},{"line_number":77,"context_line":"            \"id\": \"89678b\""},{"line_number":78,"context_line":"        }"},{"line_number":79,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_83124e56","line":76,"in_reply_to":"5a890539_f83661b3","updated":"2014-12-01 20:05:37.000000000","message":"yes, thanks.","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"de156dbcf13dfc9eab50d2c0b1efb261cbc5ccbf","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        \"remote\": ["},{"line_number":91,"context_line":"            {"},{"line_number":92,"context_line":"                \"type\": \"ADFS_GROUPS\","},{"line_number":93,"context_line":"                \"whitelist\": ["},{"line_number":94,"context_line":"                    \"g1\", \"g2\", \"g3\", \"g4\""},{"line_number":95,"context_line":"                ]"},{"line_number":96,"context_line":"            },"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_585bf5f5","line":93,"updated":"2014-12-01 19:43:42.000000000","message":"isn\u0027t whitelist and blacklist the same as the existing \u0027any_one_of\u0027 and \u0027not_any_of\u0027 ?","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"51b3935d9d7e88efa48dfd3cb6635ef2e98f173a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        \"remote\": ["},{"line_number":91,"context_line":"            {"},{"line_number":92,"context_line":"                \"type\": \"ADFS_GROUPS\","},{"line_number":93,"context_line":"                \"whitelist\": ["},{"line_number":94,"context_line":"                    \"g1\", \"g2\", \"g3\", \"g4\""},{"line_number":95,"context_line":"                ]"},{"line_number":96,"context_line":"            },"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_981f1d70","line":93,"in_reply_to":"5a890539_585bf5f5","updated":"2014-12-01 20:05:37.000000000","message":"any_one_of\u0027 and not_any_of are equivalent to:\n\nif a in b:\n   return True\nelse:\n   return False\n\nand its negative counterpart, whereas whitelist and blacklist are equal to:\n\nreturn a.intersect(b) and \nreturn a.difference(b) respectively.","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"dec6143fffd9cd001db4a12c38c63a0bc8643534","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        \"remote\": ["},{"line_number":91,"context_line":"            {"},{"line_number":92,"context_line":"                \"type\": \"ADFS_GROUPS\","},{"line_number":93,"context_line":"                \"whitelist\": ["},{"line_number":94,"context_line":"                    \"g1\", \"g2\", \"g3\", \"g4\""},{"line_number":95,"context_line":"                ]"},{"line_number":96,"context_line":"            },"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_d74c0b79","line":93,"in_reply_to":"5a890539_981f1d70","updated":"2014-12-02 01:39:52.000000000","message":"oh, so ADFS_GROUPS is a list? \n\nAssuming ADFS_GROUPS was [\u0027developers\u0027, \u0027admins\u0027, \u0027testers\u0027] and you could create a rule that was ...\n\n  remote:\n    type: ADFS_GROUPS\n    whitelist: [\u0027testers\u0027, developers]\n  local:\n    group:\n      name  {0}\n      domain: domainX\n\nHow can you do this using the existing mapping engine?","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"943fa2487dde320e49cc64f873101ca141e68245","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        \"remote\": ["},{"line_number":91,"context_line":"            {"},{"line_number":92,"context_line":"                \"type\": \"ADFS_GROUPS\","},{"line_number":93,"context_line":"                \"whitelist\": ["},{"line_number":94,"context_line":"                    \"g1\", \"g2\", \"g3\", \"g4\""},{"line_number":95,"context_line":"                ]"},{"line_number":96,"context_line":"            },"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_911a8ac4","line":93,"in_reply_to":"5a890539_d74c0b79","updated":"2014-12-02 09:07:54.000000000","message":"I can\u0027t and being able to do this is essentially the purpose of this spec.\nWith the rule you desribed user should have assigned groups \u0027testsers\u0027 and \u0027developers\u0027 in domain \u0027domainX\u0027 .Now, if, for some reason IdP admin removes him from the group \u0027testers\u0027 next time such user logs in, he will be a member of group \u0027developers\u0027 only. Essentually this could also be achieved with the old mapping syntax, but then you would need to make separater rule for each possible group, while this syntax is slightly easier.","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"de156dbcf13dfc9eab50d2c0b1efb261cbc5ccbf","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            {"},{"line_number":92,"context_line":"                \"type\": \"ADFS_GROUPS\","},{"line_number":93,"context_line":"                \"whitelist\": ["},{"line_number":94,"context_line":"                    \"g1\", \"g2\", \"g3\", \"g4\""},{"line_number":95,"context_line":"                ]"},{"line_number":96,"context_line":"            },"},{"line_number":97,"context_line":"            {"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_182fad3f","line":94,"updated":"2014-12-01 19:43:42.000000000","message":"i don\u0027t know about other idps, but my groups normally come back as CNs, so just a heads up to watch for commas.","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"51b3935d9d7e88efa48dfd3cb6635ef2e98f173a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            {"},{"line_number":92,"context_line":"                \"type\": \"ADFS_GROUPS\","},{"line_number":93,"context_line":"                \"whitelist\": ["},{"line_number":94,"context_line":"                    \"g1\", \"g2\", \"g3\", \"g4\""},{"line_number":95,"context_line":"                ]"},{"line_number":96,"context_line":"            },"},{"line_number":97,"context_line":"            {"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_98839da8","line":94,"in_reply_to":"5a890539_182fad3f","updated":"2014-12-01 20:05:37.000000000","message":"what are CNs? Could you say more about it?","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"dec6143fffd9cd001db4a12c38c63a0bc8643534","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            {"},{"line_number":92,"context_line":"                \"type\": \"ADFS_GROUPS\","},{"line_number":93,"context_line":"                \"whitelist\": ["},{"line_number":94,"context_line":"                    \"g1\", \"g2\", \"g3\", \"g4\""},{"line_number":95,"context_line":"                ]"},{"line_number":96,"context_line":"            },"},{"line_number":97,"context_line":"            {"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_a8a722a6","line":94,"in_reply_to":"5a890539_98839da8","updated":"2014-12-02 01:39:52.000000000","message":"I just meant that most of my group names come back as:\n\n  \u0027cn\u003dsomeInternalGroupName,ou\u003dgroups,o\u003dexample.com\u0027","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"943fa2487dde320e49cc64f873101ca141e68245","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            {"},{"line_number":92,"context_line":"                \"type\": \"ADFS_GROUPS\","},{"line_number":93,"context_line":"                \"whitelist\": ["},{"line_number":94,"context_line":"                    \"g1\", \"g2\", \"g3\", \"g4\""},{"line_number":95,"context_line":"                ]"},{"line_number":96,"context_line":"            },"},{"line_number":97,"context_line":"            {"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_9170ca41","line":94,"in_reply_to":"5a890539_a8a722a6","updated":"2014-12-02 09:07:54.000000000","message":"do you have some examples of the assertions?  No need to mention that what we are interested here is the kvs set of parameters stored in the process environment, so after the assertion/claim is validated and parsed.","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"de156dbcf13dfc9eab50d2c0b1efb261cbc5ccbf","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    {"},{"line_number":106,"context_line":"        \"local\": ["},{"line_number":107,"context_line":"            {"},{"line_number":108,"context_line":"                \"groups\": {0},"},{"line_number":109,"context_line":"                \"domain\": \"domain_name\""},{"line_number":110,"context_line":"            },"},{"line_number":111,"context_line":"            {"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_b86bf983","line":108,"updated":"2014-12-01 19:43:42.000000000","message":"oh this is neat","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"dec6143fffd9cd001db4a12c38c63a0bc8643534","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    {"},{"line_number":106,"context_line":"        \"local\": ["},{"line_number":107,"context_line":"            {"},{"line_number":108,"context_line":"                \"groups\": {0},"},{"line_number":109,"context_line":"                \"domain\": \"domain_name\""},{"line_number":110,"context_line":"            },"},{"line_number":111,"context_line":"            {"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_b78a1f62","line":108,"updated":"2014-12-02 01:39:52.000000000","message":"so if ADFS_GROUPS is a list, and is intersects with g1 and g2, then how does a single positional argument help? \n\nwould the engine create a role for g1 and g2 on that domain?","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"943fa2487dde320e49cc64f873101ca141e68245","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    {"},{"line_number":106,"context_line":"        \"local\": ["},{"line_number":107,"context_line":"            {"},{"line_number":108,"context_line":"                \"groups\": {0},"},{"line_number":109,"context_line":"                \"domain\": \"domain_name\""},{"line_number":110,"context_line":"            },"},{"line_number":111,"context_line":"            {"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_51766240","line":108,"in_reply_to":"5a890539_b78a1f62","updated":"2014-12-02 09:07:54.000000000","message":"ADFS_GROUPS is a \u0027;\u0027 delimited string, which is later parsed to a Python list: https://github.com/openstack/keystone/blob/master/keystone/contrib/federation/utils.py#L202-L203","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"dec6143fffd9cd001db4a12c38c63a0bc8643534","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            },"},{"line_number":111,"context_line":"            {"},{"line_number":112,"context_line":"                \"groups\": {1},"},{"line_number":113,"context_line":"                \"domain\": \"domain_name_2\""},{"line_number":114,"context_line":"            }"},{"line_number":115,"context_line":"        ]"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_d7816b4e","line":113,"updated":"2014-12-02 01:39:52.000000000","message":"this should probably be something like\n\n  local:\n    group:\n      name: {1}      (or id)\n    domain:\n      name: some name       (or id)","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"85cde6011d1475dece9742609d66cfca950f89d9","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            },"},{"line_number":111,"context_line":"            {"},{"line_number":112,"context_line":"                \"groups\": {1},"},{"line_number":113,"context_line":"                \"domain\": \"domain_name_2\""},{"line_number":114,"context_line":"            }"},{"line_number":115,"context_line":"        ]"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_00b721f6","line":113,"in_reply_to":"5a890539_d7816b4e","updated":"2014-12-02 09:21:01.000000000","message":"it basically is the same thing...?","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"de156dbcf13dfc9eab50d2c0b1efb261cbc5ccbf","unresolved":false,"context_lines":[{"line_number":129,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  Kind of. It adds a generic way to assign user certain roles, hence grant or"},{"line_number":132,"context_line":"  deny access to cloud resources."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":135,"context_line":"  a new way to access sensitive information or a new way to login?"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_18088dd8","line":132,"updated":"2014-12-01 19:43:42.000000000","message":"I would argue that this is no more or less secure than the existing mapping, so it\u0027s not needed to mention it.","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"51b3935d9d7e88efa48dfd3cb6635ef2e98f173a","unresolved":false,"context_lines":[{"line_number":129,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  Kind of. It adds a generic way to assign user certain roles, hence grant or"},{"line_number":132,"context_line":"  deny access to cloud resources."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":135,"context_line":"  a new way to access sensitive information or a new way to login?"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_780b512b","line":132,"in_reply_to":"5a890539_18088dd8","updated":"2014-12-01 20:05:37.000000000","message":"right, will add it.","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"56aaa129ebea3a31b7354ba2b64f2a051a83a26a","unresolved":false,"context_lines":[{"line_number":206,"context_line":"----------"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"* Change ``role assignments`` engine so they can map existing roles with non"},{"line_number":209,"context_line":"  existing groups."},{"line_number":210,"context_line":"* Enhance mapping engine so the group can be identified by"},{"line_number":211,"context_line":"  ``name`` and its ``domain``"},{"line_number":212,"context_line":"* Add keywords ``whitelist``, ``blacklist`` as"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_9ccc7ebd","line":209,"updated":"2014-12-01 14:13:56.000000000","message":"There is an extra restriction here: this type of assignment will require the \"target\" to be a domain, right?","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"51b3935d9d7e88efa48dfd3cb6635ef2e98f173a","unresolved":false,"context_lines":[{"line_number":206,"context_line":"----------"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"* Change ``role assignments`` engine so they can map existing roles with non"},{"line_number":209,"context_line":"  existing groups."},{"line_number":210,"context_line":"* Enhance mapping engine so the group can be identified by"},{"line_number":211,"context_line":"  ``name`` and its ``domain``"},{"line_number":212,"context_line":"* Add keywords ``whitelist``, ``blacklist`` as"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_2611b1af","line":209,"in_reply_to":"5a890539_30d2cb34","updated":"2014-12-01 20:05:37.000000000","message":"yeah, true.","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"def8536b07ab4c5767ba587ecafa77120fbbd9db","unresolved":false,"context_lines":[{"line_number":206,"context_line":"----------"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"* Change ``role assignments`` engine so they can map existing roles with non"},{"line_number":209,"context_line":"  existing groups."},{"line_number":210,"context_line":"* Enhance mapping engine so the group can be identified by"},{"line_number":211,"context_line":"  ``name`` and its ``domain``"},{"line_number":212,"context_line":"* Add keywords ``whitelist``, ``blacklist`` as"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_72437b6c","line":209,"in_reply_to":"5a890539_5c65b61b","updated":"2014-12-01 15:16:27.000000000","message":"oh, misunderstanding. i thought you asked about requirement for putting domain while specifying a group name. Then yes (and that\u0027s why i said it\u0027s a current case today).\nAnswering you initial question: an admin will be able to assign to non existing groups (resolved by matching with assertion later) and both projects and domains.","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"a81167e656cbd7c6b9b616c3544e099fd95745d3","unresolved":false,"context_lines":[{"line_number":206,"context_line":"----------"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"* Change ``role assignments`` engine so they can map existing roles with non"},{"line_number":209,"context_line":"  existing groups."},{"line_number":210,"context_line":"* Enhance mapping engine so the group can be identified by"},{"line_number":211,"context_line":"  ``name`` and its ``domain``"},{"line_number":212,"context_line":"* Add keywords ``whitelist``, ``blacklist`` as"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_b51ead0b","line":209,"in_reply_to":"5a890539_72437b6c","updated":"2014-12-01 15:26:16.000000000","message":"The other issue here is that today there is no support for creating an assignment with a project/domain name...you have to specify an ID.  So this is not as simple as just \"allowing\" an assignment to be created without checking that the project/domain exists.","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"982780abebb036cdacfc89a949c13dcc8a74d406","unresolved":false,"context_lines":[{"line_number":206,"context_line":"----------"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"* Change ``role assignments`` engine so they can map existing roles with non"},{"line_number":209,"context_line":"  existing groups."},{"line_number":210,"context_line":"* Enhance mapping engine so the group can be identified by"},{"line_number":211,"context_line":"  ``name`` and its ``domain``"},{"line_number":212,"context_line":"* Add keywords ``whitelist``, ``blacklist`` as"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_dc38c63d","line":209,"in_reply_to":"5a890539_9ccc7ebd","updated":"2014-12-01 14:22:46.000000000","message":"yes, but i AFAIK this is exactly same thing today?","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"c18caf3323a8b5f2729d262434ea7a471f2db35e","unresolved":false,"context_lines":[{"line_number":206,"context_line":"----------"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"* Change ``role assignments`` engine so they can map existing roles with non"},{"line_number":209,"context_line":"  existing groups."},{"line_number":210,"context_line":"* Enhance mapping engine so the group can be identified by"},{"line_number":211,"context_line":"  ``name`` and its ``domain``"},{"line_number":212,"context_line":"* Add keywords ``whitelist``, ``blacklist`` as"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_d0bd0705","line":209,"in_reply_to":"5a890539_b51ead0b","updated":"2014-12-01 15:46:53.000000000","message":"Projects and domains would need to exist as they need  to today. Groups wouldn\u0027t. And as long as we are good with configuring role assignments that bind existing project/domain (identified either by ID or name/domain_name) and a name/domain_name group that don\u0027t need to exist we are good to go.","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"028030d622414207cec6b9ddb69c6e3d7e541142","unresolved":false,"context_lines":[{"line_number":206,"context_line":"----------"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"* Change ``role assignments`` engine so they can map existing roles with non"},{"line_number":209,"context_line":"  existing groups."},{"line_number":210,"context_line":"* Enhance mapping engine so the group can be identified by"},{"line_number":211,"context_line":"  ``name`` and its ``domain``"},{"line_number":212,"context_line":"* Add keywords ``whitelist``, ``blacklist`` as"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_30d2cb34","line":209,"in_reply_to":"5a890539_d0bd0705","updated":"2014-12-01 15:48:48.000000000","message":"Sorry I mis-typed, I menat to say that there is no api that lets you use a group name to create an assignment, it is only group ID.","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"07752b4d360c2693888618ad88e3eaaa88d01975","unresolved":false,"context_lines":[{"line_number":206,"context_line":"----------"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"* Change ``role assignments`` engine so they can map existing roles with non"},{"line_number":209,"context_line":"  existing groups."},{"line_number":210,"context_line":"* Enhance mapping engine so the group can be identified by"},{"line_number":211,"context_line":"  ``name`` and its ``domain``"},{"line_number":212,"context_line":"* Add keywords ``whitelist``, ``blacklist`` as"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_5c65b61b","line":209,"in_reply_to":"5a890539_dc38c63d","updated":"2014-12-01 14:25:35.000000000","message":"can\u0027t I add a group role_assignment to a project? Looks like it is a possible case: https://github.com/openstack/keystone/blob/master/keystone/assignment/backends/sql.py#L126","commit_id":"2638efd84b4a7c8ff015c24f5cb5068006c083b3"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"7a7da4e2f5f633b6b66ce120a0aa8e00e94c7962","unresolved":false,"context_lines":[{"line_number":54,"context_line":"is required, as group will be usually specified by names, and domain name must"},{"line_number":55,"context_line":"be present to precisely identify the group entity in the system. Role"},{"line_number":56,"context_line":"assignments should be able to \u0027point\u0027 to groups that currently do not exist in"},{"line_number":57,"context_line":"the system."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Proposed change include:"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a890539_71ba700c","line":57,"updated":"2014-12-02 15:16:28.000000000","message":"...is that last sentence still correct?  Surely the groups will exist in Keystone in this latest proposal","commit_id":"e328d4e4150db458087c403eba90ee5ef0fc2888"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"88e62dfa0077353dcaf4459b3e495d9cd9c3c0af","unresolved":false,"context_lines":[{"line_number":54,"context_line":"is required, as group will be usually specified by names, and domain name must"},{"line_number":55,"context_line":"be present to precisely identify the group entity in the system. Role"},{"line_number":56,"context_line":"assignments should be able to \u0027point\u0027 to groups that currently do not exist in"},{"line_number":57,"context_line":"the system."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Proposed change include:"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a890539_7102700d","line":57,"in_reply_to":"5a890539_71ba700c","updated":"2014-12-02 15:39:41.000000000","message":"no, removed it.","commit_id":"e328d4e4150db458087c403eba90ee5ef0fc2888"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"7a7da4e2f5f633b6b66ce120a0aa8e00e94c7962","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* Indicate parameter as a list of groups that should be mapped directly and add"},{"line_number":80,"context_line":"  another ``keywords`` for white and black listing effective list of groups."},{"line_number":81,"context_line":"  In a following example effectively only intersection of \u0027;\u0027 delimited set of"},{"line_number":82,"context_line":"  groups from ``ADFS_GROUPS`` and ``whitelist`` as well as difference between"},{"line_number":83,"context_line":"  ``ADFS_GROUPS_2`` and ``blacklist`` would be passed. Example:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a890539_51e4940c","line":80,"updated":"2014-12-02 15:16:28.000000000","message":"for clarity, what does white/black list mean in this context? Is it that whitelist means \"just allow this set of groups\", and blacklist means \"all groups except this list\"?","commit_id":"e328d4e4150db458087c403eba90ee5ef0fc2888"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"88e62dfa0077353dcaf4459b3e495d9cd9c3c0af","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* Indicate parameter as a list of groups that should be mapped directly and add"},{"line_number":80,"context_line":"  another ``keywords`` for white and black listing effective list of groups."},{"line_number":81,"context_line":"  In a following example effectively only intersection of \u0027;\u0027 delimited set of"},{"line_number":82,"context_line":"  groups from ``ADFS_GROUPS`` and ``whitelist`` as well as difference between"},{"line_number":83,"context_line":"  ``ADFS_GROUPS_2`` and ``blacklist`` would be passed. Example:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a890539_cc2b8780","line":80,"in_reply_to":"5a890539_51e4940c","updated":"2014-12-02 15:39:41.000000000","message":"yes.\nI will add such explanation in next patch.","commit_id":"e328d4e4150db458087c403eba90ee5ef0fc2888"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"7a7da4e2f5f633b6b66ce120a0aa8e00e94c7962","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* Indicate parameter as a list of groups that should be mapped directly and add"},{"line_number":80,"context_line":"  another ``keywords`` for white and black listing effective list of groups."},{"line_number":81,"context_line":"  In a following example effectively only intersection of \u0027;\u0027 delimited set of"},{"line_number":82,"context_line":"  groups from ``ADFS_GROUPS`` and ``whitelist`` as well as difference between"},{"line_number":83,"context_line":"  ``ADFS_GROUPS_2`` and ``blacklist`` would be passed. Example:"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a890539_31f9c8c8","line":81,"updated":"2014-12-02 15:16:28.000000000","message":"don\u0027t quite understand the \u0027;\u0027 bit....","commit_id":"e328d4e4150db458087c403eba90ee5ef0fc2888"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"88e62dfa0077353dcaf4459b3e495d9cd9c3c0af","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* Indicate parameter as a list of groups that should be mapped directly and add"},{"line_number":80,"context_line":"  another ``keywords`` for white and black listing effective list of groups."},{"line_number":81,"context_line":"  In a following example effectively only intersection of \u0027;\u0027 delimited set of"},{"line_number":82,"context_line":"  groups from ``ADFS_GROUPS`` and ``whitelist`` as well as difference between"},{"line_number":83,"context_line":"  ``ADFS_GROUPS_2`` and ``blacklist`` would be passed. Example:"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a890539_cc79c794","line":81,"in_reply_to":"5a890539_31f9c8c8","updated":"2014-12-02 15:39:41.000000000","message":"some parameters may be passed as \u0027;\u0027 deparated string, like\nADFS_GROUPS \u003d \"group1;group2;group3;group4\", and this should be treated as [\u0027group1\u0027, \u0027group2\u0027,\u0027group3\u0027, \u0027group4\u0027]\nThis is how we proceed today: https://github.com/openstack/keystone/blob/master/keystone/contrib/federation/utils.py#L201-L203","commit_id":"e328d4e4150db458087c403eba90ee5ef0fc2888"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"7a7da4e2f5f633b6b66ce120a0aa8e00e94c7962","unresolved":false,"context_lines":[{"line_number":122,"context_line":"configuration, only role ``assignments`` pointing to ``groups`` identified by"},{"line_number":123,"context_line":"name and domain. This however would need ``role assignments`` API completely"},{"line_number":124,"context_line":"reworked, as they would need to identify groups by their names and domains, not"},{"line_number":125,"context_line":"ids only."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Security Impact"},{"line_number":128,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a890539_11adac9b","line":125,"updated":"2014-12-02 15:16:28.000000000","message":"This doesn\u0027t sound like an alternative, but more an extension of the ideas expressed in this spec.","commit_id":"e328d4e4150db458087c403eba90ee5ef0fc2888"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"88e62dfa0077353dcaf4459b3e495d9cd9c3c0af","unresolved":false,"context_lines":[{"line_number":122,"context_line":"configuration, only role ``assignments`` pointing to ``groups`` identified by"},{"line_number":123,"context_line":"name and domain. This however would need ``role assignments`` API completely"},{"line_number":124,"context_line":"reworked, as they would need to identify groups by their names and domains, not"},{"line_number":125,"context_line":"ids only."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Security Impact"},{"line_number":128,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a890539_6ce1b39a","line":125,"in_reply_to":"5a890539_11adac9b","updated":"2014-12-02 15:39:41.000000000","message":"hm, i don\u0027t want to put it to a proposed changes as it may make the basic proposal unclear. Maybe we could leave it here for now?","commit_id":"e328d4e4150db458087c403eba90ee5ef0fc2888"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"7a7da4e2f5f633b6b66ce120a0aa8e00e94c7962","unresolved":false,"context_lines":[{"line_number":178,"context_line":"---------------------"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Deployers need to prepare role assignments that from now on point to nonexistng"},{"line_number":181,"context_line":"groups in Keystone (those assignments will be later used to result with roles"},{"line_number":182,"context_line":"for ephemeral users).  If using direct groups mapping, deployers should"},{"line_number":183,"context_line":"carefully specify white and blacklists so no privilege escalation is possible."},{"line_number":184,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a890539_916fdc5f","line":181,"updated":"2014-12-02 15:16:28.000000000","message":"again, is this still true?","commit_id":"e328d4e4150db458087c403eba90ee5ef0fc2888"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"88e62dfa0077353dcaf4459b3e495d9cd9c3c0af","unresolved":false,"context_lines":[{"line_number":178,"context_line":"---------------------"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Deployers need to prepare role assignments that from now on point to nonexistng"},{"line_number":181,"context_line":"groups in Keystone (those assignments will be later used to result with roles"},{"line_number":182,"context_line":"for ephemeral users).  If using direct groups mapping, deployers should"},{"line_number":183,"context_line":"carefully specify white and blacklists so no privilege escalation is possible."},{"line_number":184,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a890539_8c897f71","line":181,"in_reply_to":"5a890539_916fdc5f","updated":"2014-12-02 15:39:41.000000000","message":"no, for sure no.","commit_id":"e328d4e4150db458087c403eba90ee5ef0fc2888"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"7a7da4e2f5f633b6b66ce120a0aa8e00e94c7962","unresolved":false,"context_lines":[{"line_number":207,"context_line":"----------"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"* Change ``role assignments`` engine so they can map existing roles with non"},{"line_number":210,"context_line":"  existing groups."},{"line_number":211,"context_line":"* Enhance mapping engine so the group can be identified by"},{"line_number":212,"context_line":"  ``name`` and its ``domain``"},{"line_number":213,"context_line":"* Add keywords ``whitelist``, ``blacklist`` as"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a890539_d1940439","line":210,"updated":"2014-12-02 15:16:28.000000000","message":"ditto","commit_id":"e328d4e4150db458087c403eba90ee5ef0fc2888"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"88e62dfa0077353dcaf4459b3e495d9cd9c3c0af","unresolved":false,"context_lines":[{"line_number":207,"context_line":"----------"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"* Change ``role assignments`` engine so they can map existing roles with non"},{"line_number":210,"context_line":"  existing groups."},{"line_number":211,"context_line":"* Enhance mapping engine so the group can be identified by"},{"line_number":212,"context_line":"  ``name`` and its ``domain``"},{"line_number":213,"context_line":"* Add keywords ``whitelist``, ``blacklist`` as"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a890539_6cba930c","line":210,"in_reply_to":"5a890539_d1940439","updated":"2014-12-02 15:39:41.000000000","message":"removed!","commit_id":"e328d4e4150db458087c403eba90ee5ef0fc2888"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c505626ca4e54e1937c685ba1b0f87e1a8f71b24","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    {"},{"line_number":65,"context_line":"        \"group\" {"},{"line_number":66,"context_line":"            \"name\": \"developers\","},{"line_number":67,"context_line":"            \"domain\": \"clients\""},{"line_number":68,"context_line":"        }"},{"line_number":69,"context_line":"    },"},{"line_number":70,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a890539_f2057e10","line":67,"updated":"2014-12-02 16:02:33.000000000","message":"this should be:\n\n  \"group\" {\n    \"name\": \"developers\",\n    \"domain\": {\n      \"name\": \"clients\"\n    }\n  }\n\nor\n\n  \"group\" {\n    \"name\": \"developers\",\n    \"domain\": {\n      \"id\": \"some_id\"\n    }\n  }\n\notherwise you don\u0027t know enough about the domain.","commit_id":"6da3f0d3dbe326412afbf3c8729f04440ac89d0c"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"1d14f6cedb5a1e49480136ae04aae65f5bc4d140","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    {"},{"line_number":65,"context_line":"        \"group\" {"},{"line_number":66,"context_line":"            \"name\": \"developers\","},{"line_number":67,"context_line":"            \"domain\": \"clients\""},{"line_number":68,"context_line":"        }"},{"line_number":69,"context_line":"    },"},{"line_number":70,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a890539_bcbae8de","line":67,"in_reply_to":"5a890539_f2057e10","updated":"2014-12-02 17:19:55.000000000","message":"right, fixed.","commit_id":"6da3f0d3dbe326412afbf3c8729f04440ac89d0c"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"433bb428d3075f0eaac4524b60205a5a47a8676d","unresolved":false,"context_lines":[{"line_number":83,"context_line":"  groups.  In the following example, effectively only the intersection of \u0027;\u0027"},{"line_number":84,"context_line":"  delimited set of groups from ``ADFS_GROUPS`` and ``whitelist`` (allow this"},{"line_number":85,"context_line":"  set of groups) as well as difference between ``ADFS_GROUPS_2`` and"},{"line_number":86,"context_line":"  ``blacklist`` (allow all except this list) would be passed. Example:"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. code-block:: javascript"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"5a890539_6d70baa4","line":86,"updated":"2014-12-03 01:56:58.000000000","message":"Are the new \u0027whitelist\u0027 and \u0027blacklist\u0027 keywords able to be used simultaneously in the same rule?  If so, we should describe the behavior even though there is little sense in defining a rule in this way.  For the record, I would expect the blacklist to over-ride the whitelist in the case of conflicting list values.  It\u0027s probably worth spelling this out here in the spec.","commit_id":"d0baf18d3720c40f78da3f834a4c979c533c607e"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"433bb428d3075f0eaac4524b60205a5a47a8676d","unresolved":false,"context_lines":[{"line_number":129,"context_line":"configuration, only role ``assignments`` pointing to ``groups`` identified by"},{"line_number":130,"context_line":"name and domain. This however would need ``role assignments`` API completely"},{"line_number":131,"context_line":"reworked, as they would need to identify groups by their names and domains, not"},{"line_number":132,"context_line":"ids only."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Security Impact"},{"line_number":135,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5a890539_ede02a28","line":132,"updated":"2014-12-03 01:56:58.000000000","message":"This isn\u0027t really an alternative.  It\u0027s an additional functionality that would work along with the changes proposed in this spec.  I like the idea this additional functionality, but it can be evaluated and implemented separately.  I don\u0027t think we should give the impression that is a competing approach since I think that it is complementary to your proposed changes.","commit_id":"d0baf18d3720c40f78da3f834a4c979c533c607e"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"b4fa29e344187032ec320a8595770d6c97dbde00","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Federated authentication and authorization was shipped with OpenStack Icehouse"},{"line_number":16,"context_line":"release.  One of the core features is the ``mapping engine`` that maps"},{"line_number":17,"context_line":"``SAML2/OpenId Connect`` assertions into Keystone specific parameters"},{"line_number":18,"context_line":"(``user_id``, ``groups``). The mapping engine operates on top of ``mapping"},{"line_number":19,"context_line":"rules`` configured for every registered ``Identity Provider``. Mapping rules"},{"line_number":20,"context_line":"specify how the assertions should be interpreted to grant ephemeral users"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_84184685","line":17,"updated":"2014-12-03 16:32:46.000000000","message":"You missed the change promised for here","commit_id":"9707a141b1b6a326a195c0d9721aed09c40e8295"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"b4fa29e344187032ec320a8595770d6c97dbde00","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Currently, part of the infrastructure preparation is configuration of"},{"line_number":31,"context_line":"``projects``, ``domains``, ``role assignments`` and ``groups`` for ephemeral"},{"line_number":32,"context_line":"users. This approach is good enough, however for some specific use-cases it"},{"line_number":33,"context_line":"could be made more transparent and automated. In order to cover all possible"},{"line_number":34,"context_line":"combinations, lots of rules need to be created. For instance, there is a need"},{"line_number":35,"context_line":"to create separate rules for mapping members of remote group ``devs`` into"},{"line_number":36,"context_line":"local group ``devs``, members of remote group ``admins`` into local group"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_584e4239","line":33,"updated":"2014-12-03 16:32:46.000000000","message":"There is a new proposal \"self management of domain scoped roles\" that proposes to automatically create mapping rules for federated users. see \nhttps://review.openstack.org/#/c/138728","commit_id":"9707a141b1b6a326a195c0d9721aed09c40e8295"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"7c4a1bec18c1a161868f952a0f2dc72bf7493e29","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Currently, part of the infrastructure preparation is configuration of"},{"line_number":31,"context_line":"``projects``, ``domains``, ``role assignments`` and ``groups`` for ephemeral"},{"line_number":32,"context_line":"users. This approach is good enough, however for some specific use-cases it"},{"line_number":33,"context_line":"could be made more transparent and automated. In order to cover all possible"},{"line_number":34,"context_line":"combinations, lots of rules need to be created. For instance, there is a need"},{"line_number":35,"context_line":"to create separate rules for mapping members of remote group ``devs`` into"},{"line_number":36,"context_line":"local group ``devs``, members of remote group ``admins`` into local group"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_0d3b6dd1","line":33,"in_reply_to":"5a890539_584e4239","updated":"2014-12-04 11:55:45.000000000","message":"I\u0027m not sure that spec will work (see my separate comment on it)....we still need some way of lowering the admin overhead of setting up these rules. The other spec referenced here (Trusted Attributes) could, of course, be used...although it seems to me that is really trying to say something different...it\u0027s almost like trying to protect the mapper writers from allowing through an asserted attribute from the wrong IdP.  Seems valuable, but also solving a different problem, no? The proposal here isn\u0027t trying to solve that problem...I guess we have to decide which problem it is we are trying to solve.","commit_id":"9707a141b1b6a326a195c0d9721aed09c40e8295"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"b4fa29e344187032ec320a8595770d6c97dbde00","unresolved":false,"context_lines":[{"line_number":35,"context_line":"to create separate rules for mapping members of remote group ``devs`` into"},{"line_number":36,"context_line":"local group ``devs``, members of remote group ``admins`` into local group"},{"line_number":37,"context_line":"``admins`` and so on."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Proposed Change"},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_f8c9ae5a","line":38,"updated":"2014-12-03 16:32:46.000000000","message":"It is highly unlikely that federated users will have exactly the same identity attributes as required by Keystone. Furthermore, even if the strings match, the semantics could be very different. e.g. what does role \"manager\" mean? It means different things in different organisations and would give the holders different privileges. The only way you can do what you are proposing, is to have an internationally defined set of attributes that IdPs may be willing to issue. The academic community has done this - they are defined in the eduPerson object class.\nAnother problem you will have, is that the vast majority of IdPs will not let you tamper with the attributes that they will issue, so it wont even be possible to get them to store the admin and group attributes that you require for Keystone.","commit_id":"9707a141b1b6a326a195c0d9721aed09c40e8295"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"82fa1bfdde949296be9569e30415ad04c2d8c865","unresolved":false,"context_lines":[{"line_number":35,"context_line":"to create separate rules for mapping members of remote group ``devs`` into"},{"line_number":36,"context_line":"local group ``devs``, members of remote group ``admins`` into local group"},{"line_number":37,"context_line":"``admins`` and so on."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Proposed Change"},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_3e3cf5e0","line":38,"in_reply_to":"5a890539_f8c9ae5a","updated":"2014-12-03 20:09:23.000000000","message":"It\u0027s not passing roles through.  It\u0027s passing group names through.  If I\u0027m running a private cloud and I want SSO by using my internal SAML IdP, I can control what attributes are in the assertion.  The proposed changes would be very useful in this use-case, and there are SAML IdPs like Ipsilon that are being designed to allow attributes from LDAP to be easily included in the assertion (even on a SP specific basis).\n\nI understand that the academic community has a different use case, and the flexibility of attributes that an IdP issues is not there, but that doesn\u0027t mean we should assume that all use cases have this lack of flexibility.","commit_id":"9707a141b1b6a326a195c0d9721aed09c40e8295"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"b4fa29e344187032ec320a8595770d6c97dbde00","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Extend the mapping engine to allow passing groups shipped in an assertion/claim"},{"line_number":43,"context_line":"to be subset of effective local Keystone Groups.  That is, by being a member of"},{"line_number":44,"context_line":"groups ``group1``, ``group2`` and ``group3`` in user\u0027s home company/institute,"},{"line_number":45,"context_line":"a user would effectively become a member of such groups as an ephemeral user in"},{"line_number":46,"context_line":"a cloud he is bursting into. Note that cloud administrators would still need to"},{"line_number":47,"context_line":"add such groups a priori. It is extremely important to be able to whitelist and"},{"line_number":48,"context_line":"blacklist the effective list of groups.  Otherwise, by assigning a group"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_58a3a242","line":45,"updated":"2014-12-03 16:32:46.000000000","message":"It is highly questionable whether you can even get this to work in practice given the reluctance of IDPs to add any attributes to their LDAP directories.\n\nA better solution is to: \n\na) have a trusted attributes policy for each IDP (see https://review.openstack.org/#/c/138693/1). This filters out untrusted attributes and only allows good ones through (the equivalent of your proposed whitelist), and\n\nb) allow there to be a null mapping rule by default i.e. whatever trusted attributes come from an IDP can be copied over unchanged into the attributes that Keystone sees.","commit_id":"9707a141b1b6a326a195c0d9721aed09c40e8295"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"badf88a5221bf53d684bc42166c65d0319cb9819","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Extend the mapping engine to allow passing groups shipped in an assertion/claim"},{"line_number":43,"context_line":"to be subset of effective local Keystone Groups.  That is, by being a member of"},{"line_number":44,"context_line":"groups ``group1``, ``group2`` and ``group3`` in user\u0027s home company/institute,"},{"line_number":45,"context_line":"a user would effectively become a member of such groups as an ephemeral user in"},{"line_number":46,"context_line":"a cloud he is bursting into. Note that cloud administrators would still need to"},{"line_number":47,"context_line":"add such groups a priori. It is extremely important to be able to whitelist and"},{"line_number":48,"context_line":"blacklist the effective list of groups.  Otherwise, by assigning a group"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_2fb2fd05","line":45,"in_reply_to":"5a890539_58a3a242","updated":"2014-12-03 20:51:39.000000000","message":"David, I am talking about treating usually one attribute (after parsing the assertion) as a list of white/blacklisted group. Instead of adding multiple rules \"if the user has group \u0027a\u0027 make him member of local group \u0027a\u0027, if \u0027b\u0027, make him a member of group \u0027b\u0027 etc.\" add a logic that allows for \"take all parameter ADFS_GROUPS (admin;dev;testers), make it a list [admin,dev, testers] and pass this (constrained to a white or blacklist) list as a set of groups this users is a member of.\n\nI don\u0027t think Trusted Attributes Policy replaces this spec. It may at least somehow replace whitelist and blacklist.","commit_id":"9707a141b1b6a326a195c0d9721aed09c40e8295"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"82fa1bfdde949296be9569e30415ad04c2d8c865","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Extend the mapping engine to allow passing groups shipped in an assertion/claim"},{"line_number":43,"context_line":"to be subset of effective local Keystone Groups.  That is, by being a member of"},{"line_number":44,"context_line":"groups ``group1``, ``group2`` and ``group3`` in user\u0027s home company/institute,"},{"line_number":45,"context_line":"a user would effectively become a member of such groups as an ephemeral user in"},{"line_number":46,"context_line":"a cloud he is bursting into. Note that cloud administrators would still need to"},{"line_number":47,"context_line":"add such groups a priori. It is extremely important to be able to whitelist and"},{"line_number":48,"context_line":"blacklist the effective list of groups.  Otherwise, by assigning a group"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_1e81f9c2","line":45,"in_reply_to":"5a890539_58a3a242","updated":"2014-12-03 20:09:23.000000000","message":"Mapping isn\u0027t only used for \u0027federation\u0027 such as SAML.  We\u0027re talking about using mapping for LDAP via mod_lookup_identity.  Deployments vary, and it is quite possible that the group information is provided, particularly in the case of a private cloud where the IdP is used internally for SSO.  We can only work with what the IdP provides, but we shouldn\u0027t make assumptions around limitations on the contents of those attributes.","commit_id":"9707a141b1b6a326a195c0d9721aed09c40e8295"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"b4fa29e344187032ec320a8595770d6c97dbde00","unresolved":false,"context_lines":[{"line_number":47,"context_line":"add such groups a priori. It is extremely important to be able to whitelist and"},{"line_number":48,"context_line":"blacklist the effective list of groups.  Otherwise, by assigning a group"},{"line_number":49,"context_line":"``admin`` in user\u0027s home configuration, he would become a group ``admin``"},{"line_number":50,"context_line":"member in the cloud.  By having whitelisting and blacklisting functions, cloud"},{"line_number":51,"context_line":"administrators would still keep power to control users access. Current mapping"},{"line_number":52,"context_line":"engine capabilities, like specifying effective groups should stay, so the"},{"line_number":53,"context_line":"proposed change is additive and backward compatible.  Also, the cloud"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_981d0a76","line":50,"updated":"2014-12-03 16:32:46.000000000","message":"Blacklisting is usually a bad idea from a security perspective, since there is an infinite set of bad things that can happen (in this case attributes), and you cannot list infinity. It is much better to have only a whitelist and to throw everything else away. This is what the trusted attributes policy does.","commit_id":"9707a141b1b6a326a195c0d9721aed09c40e8295"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"82fa1bfdde949296be9569e30415ad04c2d8c865","unresolved":false,"context_lines":[{"line_number":47,"context_line":"add such groups a priori. It is extremely important to be able to whitelist and"},{"line_number":48,"context_line":"blacklist the effective list of groups.  Otherwise, by assigning a group"},{"line_number":49,"context_line":"``admin`` in user\u0027s home configuration, he would become a group ``admin``"},{"line_number":50,"context_line":"member in the cloud.  By having whitelisting and blacklisting functions, cloud"},{"line_number":51,"context_line":"administrators would still keep power to control users access. Current mapping"},{"line_number":52,"context_line":"engine capabilities, like specifying effective groups should stay, so the"},{"line_number":53,"context_line":"proposed change is additive and backward compatible.  Also, the cloud"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_1e33b962","line":50,"in_reply_to":"5a890539_981d0a76","updated":"2014-12-03 20:09:23.000000000","message":"Forcing the whitelist to be updated for every single new group that shows up is not desirable in deployments that just want to pass all (or most) groups through.  A blacklist allows them to have a few exceptions, such as the \u0027admin\u0027 group example that Marek points out.\n\nNothing forces the use of a blacklist.  It\u0027s a tool that may or may not make sense for a particular deployment.  It\u0027s certainly possible to only use a whitelist as you suggest with the changes that are proposed in this spec.","commit_id":"9707a141b1b6a326a195c0d9721aed09c40e8295"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"b4fa29e344187032ec320a8595770d6c97dbde00","unresolved":false,"context_lines":[{"line_number":151,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"  No."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":156,"context_line":"  a new way to access sensitive information or a new way to login?"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_5b2d5c8e","line":154,"updated":"2014-12-03 16:32:46.000000000","message":"Yes it does. It allows user identity attributes to come unfiltered into Keystone","commit_id":"9707a141b1b6a326a195c0d9721aed09c40e8295"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"b4fa29e344187032ec320a8595770d6c97dbde00","unresolved":false,"context_lines":[{"line_number":156,"context_line":"  a new way to access sensitive information or a new way to login?"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"  No."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"* Does this change involve cryptography or hashing?"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"  No."}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_1b3e74b8","line":159,"updated":"2014-12-03 16:32:46.000000000","message":"Yes it does. It potentially increases the attack surface","commit_id":"9707a141b1b6a326a195c0d9721aed09c40e8295"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"82fa1bfdde949296be9569e30415ad04c2d8c865","unresolved":false,"context_lines":[{"line_number":156,"context_line":"  a new way to access sensitive information or a new way to login?"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"  No."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"* Does this change involve cryptography or hashing?"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"  No."}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_29b2fd05","line":159,"in_reply_to":"5a890539_1b3e74b8","updated":"2014-12-03 20:09:23.000000000","message":"Not at the API level though.  My next comment talks about the increase in attack surface.","commit_id":"9707a141b1b6a326a195c0d9721aed09c40e8295"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"b4fa29e344187032ec320a8595770d6c97dbde00","unresolved":false,"context_lines":[{"line_number":169,"context_line":"  be directly at the API level or indirectly such as changes to a cache layer."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"  It adds new functionalities to a mechanism that is already in Keystone."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"* Can this change enable a resource exhaustion attack, such as allowing a"},{"line_number":174,"context_line":"  single API interaction to consume significant server resources? Some examples"},{"line_number":175,"context_line":"  of this include launching subprocesses for each connection, or entity"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_9b87c460","line":172,"updated":"2014-12-03 16:32:46.000000000","message":"And introduces the potential for unforseen attacks to happen, in the shape of not thought about attributes getting through","commit_id":"9707a141b1b6a326a195c0d9721aed09c40e8295"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"82fa1bfdde949296be9569e30415ad04c2d8c865","unresolved":false,"context_lines":[{"line_number":169,"context_line":"  be directly at the API level or indirectly such as changes to a cache layer."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"  It adds new functionalities to a mechanism that is already in Keystone."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"* Can this change enable a resource exhaustion attack, such as allowing a"},{"line_number":174,"context_line":"  single API interaction to consume significant server resources? Some examples"},{"line_number":175,"context_line":"  of this include launching subprocesses for each connection, or entity"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_09d8e151","line":172,"in_reply_to":"5a890539_9b87c460","updated":"2014-12-03 20:09:23.000000000","message":"The attributes that are allowed through are still fixed.  It\u0027s the values that are passed through.  In the case of an internal IdP, all values would be trusted.  You are correct that there are cases where you would not want to pass through the values as-is, which is likely true with exteral IdPs that the cloud admin does not control.  The proposed changes do not force you to pass values through though, so I think this change adds flexibility that is desirable in certain scenarios.","commit_id":"9707a141b1b6a326a195c0d9721aed09c40e8295"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"b65ff90beb5159eab6f5877309a5d0859bd590e7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Federated authentication and authorization was shipped with OpenStack Icehouse"},{"line_number":16,"context_line":"release.  One of the core features is the ``mapping engine`` that translates"},{"line_number":17,"context_line":"identity attributes from federation (e.g. ``SAML2/OpenId Connect``) assertions"},{"line_number":18,"context_line":"into ``SAML2/OpenId Connect`` assertions into Keystone specific parameters"},{"line_number":19,"context_line":"(``user_id``, ``groups``). The mapping engine operates on top of ``mapping"},{"line_number":20,"context_line":"rules`` configured for every registered ``Identity Provider``. Mapping rules"},{"line_number":21,"context_line":"specify how the assertions should be interpreted to grant ephemeral users"}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a890539_5b8c4135","line":18,"updated":"2014-12-04 19:43:27.000000000","message":"You left a part of this sentence in that should be removed.  I\u0027ve cleaned it up in patch set 12.","commit_id":"bfdb7ab955c21802a4e8423d2cfadab6bd016464"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"b2f40b407a88ab8f8144628f875d85cd2f3e980f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"to create separate rules for mapping members of remote group ``devs`` into"},{"line_number":36,"context_line":"local group ``devs``, members of remote group ``admins`` into local group"},{"line_number":37,"context_line":"``admins`` and so on."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Proposed Change"},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"5a890539_c0aca339","line":38,"updated":"2014-12-05 11:58:11.000000000","message":"Making this more efficient is a good thing, providing you do not introduce security vulnerabilities at the same time.","commit_id":"faa4c823bb3b03c1d341c53c41d2746ac6345976"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"b0f7d9d9a58082a337192935384e3e4a84f633fd","unresolved":false,"context_lines":[{"line_number":35,"context_line":"to create separate rules for mapping members of remote group ``devs`` into"},{"line_number":36,"context_line":"local group ``devs``, members of remote group ``admins`` into local group"},{"line_number":37,"context_line":"``admins`` and so on."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Proposed Change"},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"5a890539_1d452815","line":38,"in_reply_to":"5a890539_c0aca339","updated":"2014-12-05 17:26:36.000000000","message":"Agreed.  This is the reason for the whitelist/blacklist capability.","commit_id":"faa4c823bb3b03c1d341c53c41d2746ac6345976"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"b2f40b407a88ab8f8144628f875d85cd2f3e980f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"groups ``group1``, ``group2`` and ``group3`` in user\u0027s home company/institute,"},{"line_number":45,"context_line":"a user would effectively become a member of such groups as an ephemeral user in"},{"line_number":46,"context_line":"a cloud he is bursting into. Note that cloud administrators would still need to"},{"line_number":47,"context_line":"add such groups a priori. It is extremely important to be able to whitelist and"},{"line_number":48,"context_line":"blacklist the effective list of groups.  Otherwise, by assigning a group"},{"line_number":49,"context_line":"``admin`` in user\u0027s home configuration, he would become a group ``admin``"},{"line_number":50,"context_line":"member in the cloud.  By having whitelisting and blacklisting functions, cloud"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5a890539_20a4874a","line":47,"updated":"2014-12-05 11:58:11.000000000","message":"Surely all that is needed is the ability to say that all values from the assertion attribute type X are mapped in the same value of a keystone group. I thought this functionality already existed in the current mapping rules?","commit_id":"faa4c823bb3b03c1d341c53c41d2746ac6345976"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"b0f7d9d9a58082a337192935384e3e4a84f633fd","unresolved":false,"context_lines":[{"line_number":44,"context_line":"groups ``group1``, ``group2`` and ``group3`` in user\u0027s home company/institute,"},{"line_number":45,"context_line":"a user would effectively become a member of such groups as an ephemeral user in"},{"line_number":46,"context_line":"a cloud he is bursting into. Note that cloud administrators would still need to"},{"line_number":47,"context_line":"add such groups a priori. It is extremely important to be able to whitelist and"},{"line_number":48,"context_line":"blacklist the effective list of groups.  Otherwise, by assigning a group"},{"line_number":49,"context_line":"``admin`` in user\u0027s home configuration, he would become a group ``admin``"},{"line_number":50,"context_line":"member in the cloud.  By having whitelisting and blacklisting functions, cloud"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5a890539_3dbbc410","line":47,"in_reply_to":"5a890539_20a4874a","updated":"2014-12-05 17:26:36.000000000","message":"Yes, but with the wrinkle that you can only currently define the keystone group by ID, which is not something that we would expect to see in an assertion attribute value.  Really, the change here is just the ability to specify a group by name and domain plus the addition of whitelist/blacklist capability to prevent mapping all values of the assertion attribute through to Keystone in wholesale.","commit_id":"faa4c823bb3b03c1d341c53c41d2746ac6345976"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"b2f40b407a88ab8f8144628f875d85cd2f3e980f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"* Change ``local`` entities, so the effective groups can be identified by"},{"line_number":62,"context_line":"  ``name`` and ``domain``, instead of ``id`` only. An example with old and new"},{"line_number":63,"context_line":"  sytax of local ``groups`` identification would look like:"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":".. code-block:: javascript"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5a890539_c073c3e6","line":64,"updated":"2014-12-05 11:58:11.000000000","message":"This is a positive change","commit_id":"faa4c823bb3b03c1d341c53c41d2746ac6345976"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"b2f40b407a88ab8f8144628f875d85cd2f3e980f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  ``blacklist`` (allow all except this list) would be passed."},{"line_number":87,"context_line":"  Both keywords, ``whitelist`` and ``blacklist`` can be combined in one rule."},{"line_number":88,"context_line":"  Example:"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":".. code-block:: javascript"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5a890539_60620f3f","line":89,"updated":"2014-12-05 11:58:11.000000000","message":"It does not make sense to combine both whitelist and blacklist in one rule, because whitelist already specifies that ONLY these whitelisted values are allowed. So what is the purpose of specifying that something that is not allowed by the whitelist, is doubly not allowed by putting it in a blacklist as well? This is simply confusing to an administrator, because he is then sure to ask, what is the difference between a whitelist on its own, and a whitelist coupled with a blacklist? Since there is none, then the latter should not be allowed","commit_id":"faa4c823bb3b03c1d341c53c41d2746ac6345976"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"0df706f3416a87bfa5b964b3a3bfdfbb4598d115","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  ``blacklist`` (allow all except this list) would be passed."},{"line_number":87,"context_line":"  Both keywords, ``whitelist`` and ``blacklist`` can be combined in one rule."},{"line_number":88,"context_line":"  Example:"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":".. code-block:: javascript"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3a961159_ddd0de55","line":89,"in_reply_to":"3a961159_3331470c","updated":"2014-12-09 08:42:07.000000000","message":"changed  corresponding sentence.","commit_id":"faa4c823bb3b03c1d341c53c41d2746ac6345976"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"b0f7d9d9a58082a337192935384e3e4a84f633fd","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  ``blacklist`` (allow all except this list) would be passed."},{"line_number":87,"context_line":"  Both keywords, ``whitelist`` and ``blacklist`` can be combined in one rule."},{"line_number":88,"context_line":"  Example:"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":".. code-block:: javascript"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5a890539_3d9ca46a","line":89,"in_reply_to":"5a890539_35a762a9","updated":"2014-12-05 17:26:36.000000000","message":"Yes, I commented on this before.  There is no value in allowing both, and doing so has the additional problem of making the predicted behavior confusing.  There are two options:\n\n- Don\u0027t allow the \u0027whitelist\u0027 and \u0027blacklist\u0027 to be simultaneously used in a mapping rule (preferred).\n\n- Clearly document the behavior when both keywords are specified.\n\nI think we should just use the first option and reject any attempt to set a mapping rule that contains both keywords, as allowing both provides no benefit or additional capability that I can think of.","commit_id":"faa4c823bb3b03c1d341c53c41d2746ac6345976"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"06bc7ab5bb51afe0c23274e66d17c8226bc0460d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  ``blacklist`` (allow all except this list) would be passed."},{"line_number":87,"context_line":"  Both keywords, ``whitelist`` and ``blacklist`` can be combined in one rule."},{"line_number":88,"context_line":"  Example:"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":".. code-block:: javascript"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3a961159_3331470c","line":89,"in_reply_to":"5a890539_3d9ca46a","updated":"2014-12-07 18:56:16.000000000","message":"I am adamantly against allowing both a whitelist and blacklist in a single rule.\n\nI agree we should simply reject an attempt to set both keywords. Rules should be straightforward and predictable, this change makes it *very* hard to reliably know what a rule will end up doing.","commit_id":"faa4c823bb3b03c1d341c53c41d2746ac6345976"},{"author":{"_account_id":13140,"name":"Victor Silva","email":"victor@lsd.ufcg.edu.br","username":"victsou"},"change_message_id":"8d4ea9b1bb61def107c630c6f73c1c99baf4a2d0","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  ``blacklist`` (allow all except this list) would be passed."},{"line_number":87,"context_line":"  Both keywords, ``whitelist`` and ``blacklist`` can be combined in one rule."},{"line_number":88,"context_line":"  Example:"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":".. code-block:: javascript"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    {"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5a890539_35a762a9","line":89,"in_reply_to":"5a890539_60620f3f","updated":"2014-12-05 15:17:14.000000000","message":"The idea was to spell out this specific issue here in the spec, but that comment (from nkinder, IIRC) ended up not getting noticed.\n\nThere is little sense in defining a rule that uses both and I would also say that the \u0027whitelist\u0027 and \u0027blacklist\u0027 keywords should not be used simultaneously.","commit_id":"faa4c823bb3b03c1d341c53c41d2746ac6345976"}]}
