)]}'
{"specs/kilo/read-write-ldap-drivers.rst":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"463a8c2384a31190065c58c0498c27c5d69b5092","unresolved":false,"context_lines":[{"line_number":11,"context_line":"`bp read-write-ldap-drivers"},{"line_number":12,"context_line":"\u003chttps://blueprints.launchpad.net/keystone/+spec/read-write-ldap-drivers\u003e`_"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implement new LDAP R/W drivers with keystone managed schema, in an effort"},{"line_number":15,"context_line":"to have two separate implementations: R/O LDAP with mappings of existing LDAP"},{"line_number":16,"context_line":"instances, and R/W LDAP for only a single schema. The R/W LDAP driver"},{"line_number":17,"context_line":"will be treated similarly to the SQL backends; that supports migration between"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_f6b6a2db","line":14,"updated":"2014-12-09 02:09:16.000000000","message":"nit: Keystone","commit_id":"cef239116e288b4bc66c7fd1b3eef0fa23e6cb8a"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"463a8c2384a31190065c58c0498c27c5d69b5092","unresolved":false,"context_lines":[{"line_number":66,"context_line":"general due to the configuration needed."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"With separate R/O and R/W LDAP implementations, we allow the flexibility to use"},{"line_number":69,"context_line":"what is *needed* without all the configuration required today."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Security Impact"},{"line_number":72,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_96ce3e59","line":69,"updated":"2014-12-09 02:09:16.000000000","message":"nit: We could probably remove these two lines as the point is covered pretty well in the \"Problem Description\" and \"Proposed Change\"","commit_id":"cef239116e288b4bc66c7fd1b3eef0fa23e6cb8a"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"463a8c2384a31190065c58c0498c27c5d69b5092","unresolved":false,"context_lines":[{"line_number":129,"context_line":"Other Deployer Impact"},{"line_number":130,"context_line":"---------------------"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Provide deployer a straightforward implementation of the R/W LDAP drivers with"},{"line_number":133,"context_line":"Keystone\u0027s schema."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Developer Impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_b6f25a98","line":132,"updated":"2014-12-09 02:09:16.000000000","message":"deployers*?","commit_id":"cef239116e288b4bc66c7fd1b3eef0fa23e6cb8a"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"463a8c2384a31190065c58c0498c27c5d69b5092","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Additional documentation will be added that details the process for setting up"},{"line_number":173,"context_line":"the LDAP R/W drivers for Keystone. The documentation will explain the LDAP R/W"},{"line_number":174,"context_line":"configuration options and the upgrade paths for LDAP."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"References"},{"line_number":177,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_d64606bf","line":174,"updated":"2014-12-09 02:09:16.000000000","message":"++ \n\nThis documentation should also consist of the differences between the R/W implementation and the R/O implementation. Users would probably find it helpful to hear to differences between the two so that they understand what will work best for their deployment.","commit_id":"cef239116e288b4bc66c7fd1b3eef0fa23e6cb8a"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"463a8c2384a31190065c58c0498c27c5d69b5092","unresolved":false,"context_lines":[{"line_number":176,"context_line":"References"},{"line_number":177,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"* [1] `\u003chttp://docs.openstack.org/admin-guide-cloud/content/configuring-keystone-for-ldap-backend.html\u003e`_"},{"line_number":180,"context_line":"* [2] `\u003chttps://github.com/openstack/keystone/blob/3cddc459736260c3952eeede17aa84ec2f25a044/etc/keystone.conf.sample#L1098\u003e`_"},{"line_number":181,"context_line":"* [3] `\u003chttps://github.com/openstack/keystone/blob/3cddc459736260c3952eeede17aa84ec2f25a044/etc/keystone.conf.sample#L1139\u003e`_"},{"line_number":182,"context_line":"* [4] `\u003chttps://github.com/openstack/keystone/blob/3cddc459736260c3952eeede17aa84ec2f25a044/etc/keystone.conf.sample#L861-L1264\u003e`_"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_369aea63","line":179,"updated":"2014-12-09 02:09:16.000000000","message":"nit: I would suggest changing these to something like the following: \n\n    `Keystone LDAP Configuration Docs \u003chttp://docs.openstack.org/admin-guide-cloud/content/configuring-keystone-for-ldap-backend.html\u003e`_\n\nThat way it\u0027s a little more descriptive for people reviewing the spec and referencing it later on.","commit_id":"cef239116e288b4bc66c7fd1b3eef0fa23e6cb8a"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"678a9e5bd651688af8d16915cb862be40405d4a3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Implement new LDAP R/W drivers with Keystone managed schema, in an effort"},{"line_number":15,"context_line":"to have two separate implementations: R/O LDAP with mappings of existing LDAP"},{"line_number":16,"context_line":"instances, and R/W LDAP for only a single schema. The R/W LDAP driver"},{"line_number":17,"context_line":"will be treated similarly to the SQL backends; that supports migration between"},{"line_number":18,"context_line":"releases."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_ff446b1c","line":17,"updated":"2014-12-11 22:38:00.000000000","message":"data migrations?","commit_id":"e089beda7b4745b73ec3f454024e12a704b79387"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"4b42fa7598aa7bc886fdc10697522d58b7c15395","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Implement new LDAP R/W drivers with Keystone managed schema, in an effort"},{"line_number":15,"context_line":"to have two separate implementations: R/O LDAP with mappings of existing LDAP"},{"line_number":16,"context_line":"instances, and R/W LDAP for only a single schema. The R/W LDAP driver"},{"line_number":17,"context_line":"will be treated similarly to the SQL backends; that supports migration between"},{"line_number":18,"context_line":"releases."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_91124f07","line":17,"in_reply_to":"3a961159_ff446b1c","updated":"2014-12-11 23:33:48.000000000","message":"Done","commit_id":"e089beda7b4745b73ec3f454024e12a704b79387"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"678a9e5bd651688af8d16915cb862be40405d4a3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Problem Description"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The current Keystone LDAP backends support both R/O and R/W implementations. It"},{"line_number":24,"context_line":"is recommended that a R/O LDAP implementation be used with Keystone [1], but"},{"line_number":25,"context_line":"there are ways to allow writes to an LDAP server using a Keystone LDAP backend"},{"line_number":26,"context_line":"[2] [3]. The LDAP backend configuration through the Keystone configuration"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_9f60c7a6","line":23,"updated":"2014-12-11 22:38:00.000000000","message":"it\u0027s one implementation with two configurable behaviors","commit_id":"e089beda7b4745b73ec3f454024e12a704b79387"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"4b42fa7598aa7bc886fdc10697522d58b7c15395","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Problem Description"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The current Keystone LDAP backends support both R/O and R/W implementations. It"},{"line_number":24,"context_line":"is recommended that a R/O LDAP implementation be used with Keystone [1], but"},{"line_number":25,"context_line":"there are ways to allow writes to an LDAP server using a Keystone LDAP backend"},{"line_number":26,"context_line":"[2] [3]. The LDAP backend configuration through the Keystone configuration"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_b1faebba","line":23,"in_reply_to":"3a961159_9f60c7a6","updated":"2014-12-11 23:33:48.000000000","message":"Done","commit_id":"e089beda7b4745b73ec3f454024e12a704b79387"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"6d305a109d34a6c4dbad947175ff2d39f176431e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The current Keystone LDAP backends support both R/O and R/W implementations. It"},{"line_number":24,"context_line":"is recommended that a R/O LDAP implementation be used with Keystone [1], but"},{"line_number":25,"context_line":"there are ways to allow writes to an LDAP server using a Keystone LDAP backend"},{"line_number":26,"context_line":"[2] [3]. The LDAP backend configuration through the Keystone configuration"},{"line_number":27,"context_line":"files is also extensive and complicated [4], including attribute/object"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_5577253a","line":24,"updated":"2014-12-10 19:01:37.000000000","message":"Please provide clickable links, reStructured format has them.","commit_id":"e089beda7b4745b73ec3f454024e12a704b79387"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"4b42fa7598aa7bc886fdc10697522d58b7c15395","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The current Keystone LDAP backends support both R/O and R/W implementations. It"},{"line_number":24,"context_line":"is recommended that a R/O LDAP implementation be used with Keystone [1], but"},{"line_number":25,"context_line":"there are ways to allow writes to an LDAP server using a Keystone LDAP backend"},{"line_number":26,"context_line":"[2] [3]. The LDAP backend configuration through the Keystone configuration"},{"line_number":27,"context_line":"files is also extensive and complicated [4], including attribute/object"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_d1f777d1","line":24,"in_reply_to":"3a961159_5577253a","updated":"2014-12-11 23:33:48.000000000","message":"Done","commit_id":"e089beda7b4745b73ec3f454024e12a704b79387"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"678a9e5bd651688af8d16915cb862be40405d4a3","unresolved":false,"context_lines":[{"line_number":27,"context_line":"files is also extensive and complicated [4], including attribute/object"},{"line_number":28,"context_line":"mappings and permissions to tell Keystone whether or not it has permission to"},{"line_number":29,"context_line":"write to the LDAP backend in certain cases. The current Keystone LDAP backends"},{"line_number":30,"context_line":"attempt to cover R/O and R/W LDAP implementations. It would be easier to"},{"line_number":31,"context_line":"configure each implementation according to what a user needs LDAP to do. For"},{"line_number":32,"context_line":"example, only providing mappings to LDAP in R/O implementations. This can be"},{"line_number":33,"context_line":"done by adding a R/W LDAP implementation that allows users to use Keystone with"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_3f719376","line":30,"updated":"2014-12-11 22:38:00.000000000","message":"++","commit_id":"e089beda7b4745b73ec3f454024e12a704b79387"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"6d305a109d34a6c4dbad947175ff2d39f176431e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Another LDAP driver implementation can be written that focuses on the use cases"},{"line_number":40,"context_line":"for R/W LDAP with Keystone. This R/W LDAP driver can still leverage much of the"},{"line_number":41,"context_line":"existing common ldap code that lives in Keystone if needed [5], but the logic"},{"line_number":42,"context_line":"within the R/W LDAP implementation should be specific to R/W Keystone LDAP use"},{"line_number":43,"context_line":"cases. It will no longer write to any schema, only the one provided by"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_300f0730","line":40,"updated":"2014-12-10 19:01:37.000000000","message":"Link to use cases would be nice here.","commit_id":"e089beda7b4745b73ec3f454024e12a704b79387"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ebff93df35d0fc14c02fd028a18a274268cbfb02","unresolved":false,"context_lines":[{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Another LDAP driver implementation can be written that focuses on the use cases"},{"line_number":40,"context_line":"for R/W LDAP with Keystone. This R/W LDAP driver can still leverage much of the"},{"line_number":41,"context_line":"existing common ldap code that lives in Keystone if needed [5], but the logic"},{"line_number":42,"context_line":"within the R/W LDAP implementation should be specific to R/W Keystone LDAP use"},{"line_number":43,"context_line":"cases. It will no longer write to any schema, only the one provided by"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_112adf8f","line":40,"in_reply_to":"3a961159_300f0730","updated":"2014-12-12 00:02:19.000000000","message":"addressed in latest patch set.","commit_id":"e089beda7b4745b73ec3f454024e12a704b79387"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ebff93df35d0fc14c02fd028a18a274268cbfb02","unresolved":false,"context_lines":[{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Another LDAP driver implementation can be written that focuses on the use cases"},{"line_number":40,"context_line":"for R/W LDAP with Keystone. This R/W LDAP driver can still leverage much of the"},{"line_number":41,"context_line":"existing common ldap code that lives in Keystone if needed [5], but the logic"},{"line_number":42,"context_line":"within the R/W LDAP implementation should be specific to R/W Keystone LDAP use"},{"line_number":43,"context_line":"cases. It will no longer write to any schema, only the one provided by"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_311a7b7d","line":40,"in_reply_to":"3a961159_300f0730","updated":"2014-12-12 00:02:19.000000000","message":"addressed in the latest patch set.","commit_id":"e089beda7b4745b73ec3f454024e12a704b79387"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"6d305a109d34a6c4dbad947175ff2d39f176431e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"Keystone."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"The drivers will be configurable much like the current existing drivers for the"},{"line_number":47,"context_line":"various Keystone backends [6]."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"For the R/W LDAP case, a Keystone object model may be enforced on the backend,"},{"line_number":50,"context_line":"versus having a mapping that translates LDAP attributes to Keystone objects."}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_155f5d42","line":47,"updated":"2014-12-10 19:01:37.000000000","message":"Proposed change is unclear to me:\nDo we want to extend R/O LDAP or some features of it will be omitted?\nWhat exactly do we want that driver to be capable of?","commit_id":"e089beda7b4745b73ec3f454024e12a704b79387"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"4b42fa7598aa7bc886fdc10697522d58b7c15395","unresolved":false,"context_lines":[{"line_number":44,"context_line":"Keystone."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"The drivers will be configurable much like the current existing drivers for the"},{"line_number":47,"context_line":"various Keystone backends [6]."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"For the R/W LDAP case, a Keystone object model may be enforced on the backend,"},{"line_number":50,"context_line":"versus having a mapping that translates LDAP attributes to Keystone objects."}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_11157fe4","line":47,"in_reply_to":"3a961159_155f5d42","updated":"2014-12-11 23:33:48.000000000","message":"Done","commit_id":"e089beda7b4745b73ec3f454024e12a704b79387"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"678a9e5bd651688af8d16915cb862be40405d4a3","unresolved":false,"context_lines":[{"line_number":156,"context_line":"  configuration"},{"line_number":157,"context_line":"* Propose documentation that explains the R/W LDAP implementation"},{"line_number":158,"context_line":"* Propose functional testing against LDAP with the R/W backend enabled for"},{"line_number":159,"context_line":"  Keystone"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Dependencies"},{"line_number":162,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_ff12ab07","line":159,"updated":"2014-12-11 22:38:00.000000000","message":"* Implementation of the schema is dependent on getting oids from the OpenStack Foundation via Chris Hoge \u003cchris@openstack.org\u003e","commit_id":"e089beda7b4745b73ec3f454024e12a704b79387"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"4b42fa7598aa7bc886fdc10697522d58b7c15395","unresolved":false,"context_lines":[{"line_number":156,"context_line":"  configuration"},{"line_number":157,"context_line":"* Propose documentation that explains the R/W LDAP implementation"},{"line_number":158,"context_line":"* Propose functional testing against LDAP with the R/W backend enabled for"},{"line_number":159,"context_line":"  Keystone"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Dependencies"},{"line_number":162,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a961159_31d51b1c","line":159,"in_reply_to":"3a961159_ff12ab07","updated":"2014-12-11 23:33:48.000000000","message":"Done","commit_id":"e089beda7b4745b73ec3f454024e12a704b79387"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b78e0dac98279dc35a89c5bd77931ec8dc4ef37d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"for R/W LDAP with Keystone. Example use cases: Only having a LDAP backend to"},{"line_number":47,"context_line":"persist data or allowing other system, like gerrit, jenkins, etc, to bind with"},{"line_number":48,"context_line":"Keystone provided users. This R/W LDAP driver can still leverage much of the"},{"line_number":49,"context_line":"existing `common ldap`_ code that lives in Keystone if needed, but the logic"},{"line_number":50,"context_line":"within the R/W LDAP implementation should be specific to R/W Keystone LDAP use"},{"line_number":51,"context_line":"cases. It will no longer write to any schema, only the one provided by"},{"line_number":52,"context_line":"Keystone."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a961159_f12c73ae","line":49,"updated":"2014-12-12 00:02:32.000000000","message":"nice","commit_id":"f5c9b7cdf0ea09947dc284345b660765eb271797"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"2b524ed31c329006dfb523dd0f141d287c5a05bf","unresolved":false,"context_lines":[{"line_number":11,"context_line":"`bp read-write-ldap-drivers"},{"line_number":12,"context_line":"\u003chttps://blueprints.launchpad.net/keystone/+spec/read-write-ldap-drivers\u003e`_"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implement new LDAP R/W drivers with Keystone managed schema, in an effort"},{"line_number":15,"context_line":"to have two separate implementations: R/O LDAP with mappings of existing LDAP"},{"line_number":16,"context_line":"instances, and R/W LDAP for only a single schema. The R/W LDAP driver"},{"line_number":17,"context_line":"will be treated similarly to the SQL backends; that supports data migration"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_09e0d7f8","line":14,"updated":"2014-12-12 20:07:48.000000000","message":"Reword this sentence to make it clear:\n\nDefine a new keystone LDAP schema, and implement new LDAP R/W drivers that target it.","commit_id":"ab9f82ef254be643555a0852f2f8aecad99cf583"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"72cbae9a2d4799d555590192d899451bb13ae82c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"`bp read-write-ldap-drivers"},{"line_number":12,"context_line":"\u003chttps://blueprints.launchpad.net/keystone/+spec/read-write-ldap-drivers\u003e`_"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implement new LDAP R/W drivers with Keystone managed schema, in an effort"},{"line_number":15,"context_line":"to have two separate implementations: R/O LDAP with mappings of existing LDAP"},{"line_number":16,"context_line":"instances, and R/W LDAP for only a single schema. The R/W LDAP driver"},{"line_number":17,"context_line":"will be treated similarly to the SQL backends; that supports data migration"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_552eeca5","line":14,"in_reply_to":"3a961159_09e0d7f8","updated":"2014-12-12 22:30:57.000000000","message":"Done","commit_id":"ab9f82ef254be643555a0852f2f8aecad99cf583"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"640819855b6274555bd95a4a31a331251d4fd0da","unresolved":false,"context_lines":[{"line_number":51,"context_line":"cases. It will no longer write to any schema, only the one provided by"},{"line_number":52,"context_line":"Keystone."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The goal is to separate the current implementation that handles both R/W and"},{"line_number":55,"context_line":"R/O into R/W LDAP drivers with Keystone\u0027s owned schema. New driver will not"},{"line_number":56,"context_line":"affect the current implementation, but rather simplify the use of the R/W"},{"line_number":57,"context_line":"drivers without the extensive configuration changes. Initial implementation"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_5e29ba35","line":54,"updated":"2014-12-12 16:55:09.000000000","message":"What is Keystone\u0027s owned schema?  Where is it defined?  Will you be supporting multiple versions? What will you be doing to enable stakeholders to review and provide feedback on the schema before you finalize it?  The reason I ask all these questions is because we tried this a few years ago and there were definitely different schema candidates and some of the stakeholders had strong opinions on these candidates. So please make clear how you will ensure that stakeholders are able to provide input on what this schema should look like.","commit_id":"ab9f82ef254be643555a0852f2f8aecad99cf583"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"72cbae9a2d4799d555590192d899451bb13ae82c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"cases. It will no longer write to any schema, only the one provided by"},{"line_number":52,"context_line":"Keystone."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The goal is to separate the current implementation that handles both R/W and"},{"line_number":55,"context_line":"R/O into R/W LDAP drivers with Keystone\u0027s owned schema. New driver will not"},{"line_number":56,"context_line":"affect the current implementation, but rather simplify the use of the R/W"},{"line_number":57,"context_line":"drivers without the extensive configuration changes. Initial implementation"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a961159_55050c12","line":54,"in_reply_to":"3a961159_5e29ba35","updated":"2014-12-12 22:30:57.000000000","message":"Done","commit_id":"ab9f82ef254be643555a0852f2f8aecad99cf583"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"5563a108478819e07aae80b3fbf688df28cac72a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"Keystone."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The goal is to separate the current implementation that handles both R/W and"},{"line_number":55,"context_line":"R/O into R/W LDAP drivers that target the new schema. New schema will existing"},{"line_number":56,"context_line":"under the keystone project and only one version will be supported on every"},{"line_number":57,"context_line":"Keystone release. Stakeholders will be able to provide their input,"},{"line_number":58,"context_line":"suggestions, and concerns when the schema is up for review. The new driver will"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_1b2aa7e7","line":55,"updated":"2014-12-15 19:28:28.000000000","message":"typo: will existing should be \"will exist\".","commit_id":"919a8f4040f773f10f4421b4c70eae56b74d871a"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"ff329050c1cc778e39d155fec80c0b099e0c9861","unresolved":false,"context_lines":[{"line_number":52,"context_line":"Keystone."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The goal is to separate the current implementation that handles both R/W and"},{"line_number":55,"context_line":"R/O into R/W LDAP drivers that target the new schema. New schema will existing"},{"line_number":56,"context_line":"under the keystone project and only one version will be supported on every"},{"line_number":57,"context_line":"Keystone release. Stakeholders will be able to provide their input,"},{"line_number":58,"context_line":"suggestions, and concerns when the schema is up for review. The new driver will"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_b17b1d28","line":55,"in_reply_to":"3a961159_1b2aa7e7","updated":"2014-12-18 00:42:04.000000000","message":"Done","commit_id":"919a8f4040f773f10f4421b4c70eae56b74d871a"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"5563a108478819e07aae80b3fbf688df28cac72a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"For the R/W LDAP case, a Keystone object model may be enforced on the backend,"},{"line_number":67,"context_line":"versus having a mapping that translates LDAP attributes to Keystone objects."},{"line_number":68,"context_line":"This model can operate much like the existing SQL migrations and models. If"},{"line_number":69,"context_line":"data needs to change on the LDAP backend, a migration must be provided that"},{"line_number":70,"context_line":"does the proper upgrades."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Unit and functional testing can be separated from the existing LDAP testing if"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_1bdc6718","line":69,"updated":"2014-12-15 19:28:28.000000000","message":"Similar to the SQL support, you will also have to provide proper downgrade support as well correct?  And does that imply you will need to keep previous versions of the schema around should the user choose to downgrade?  And does this not also imply that you will need to have a version tracker id of some sort for your schemas similar to the SQL support?","commit_id":"919a8f4040f773f10f4421b4c70eae56b74d871a"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b0393fcbbb675adc583700aaa177165c9f6314c4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"For the R/W LDAP case, a Keystone object model may be enforced on the backend,"},{"line_number":67,"context_line":"versus having a mapping that translates LDAP attributes to Keystone objects."},{"line_number":68,"context_line":"This model can operate much like the existing SQL migrations and models. If"},{"line_number":69,"context_line":"data needs to change on the LDAP backend, a migration must be provided that"},{"line_number":70,"context_line":"does the proper upgrades."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Unit and functional testing can be separated from the existing LDAP testing if"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_29bb9a76","line":69,"in_reply_to":"3a961159_1bdc6718","updated":"2014-12-15 22:17:07.000000000","message":"This is likely going to be quite complex, but in short, yes that is correct. I expect that the LDAP schema will be managed in a way where there is no backwards incompatibilities, but that data is moved to a new oid-identifier and as the migration occurs - the only exception is a MUST object may become a MAY to support the upgrade/downgrade - but should never be removed / changed in an incompatible way.\n\nA downgrade script can expect to be lossy with regards to new-feature specific data (Same as with SQL).","commit_id":"919a8f4040f773f10f4421b4c70eae56b74d871a"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"97de0fbe88b5524244e1f58dd5e3c68f71b86754","unresolved":false,"context_lines":[{"line_number":66,"context_line":"For the R/W LDAP case, a Keystone object model may be enforced on the backend,"},{"line_number":67,"context_line":"versus having a mapping that translates LDAP attributes to Keystone objects."},{"line_number":68,"context_line":"This model can operate much like the existing SQL migrations and models. If"},{"line_number":69,"context_line":"data needs to change on the LDAP backend, a migration must be provided that"},{"line_number":70,"context_line":"does the proper upgrades."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Unit and functional testing can be separated from the existing LDAP testing if"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_b9587158","line":69,"in_reply_to":"3a961159_29bb9a76","updated":"2014-12-17 17:55:12.000000000","message":"I think it would be useful to include each option we have available for migrating LDAP data. Managing schemas for LDAP is different than managing schemas for SQL. Of the different migration types, we should list the benefits/drawbacks for the deployers.","commit_id":"919a8f4040f773f10f4421b4c70eae56b74d871a"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"8a87e46e2c705fb469e41ddab36061c59892872e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"For the R/W LDAP case, a Keystone object model may be enforced on the backend,"},{"line_number":67,"context_line":"versus having a mapping that translates LDAP attributes to Keystone objects."},{"line_number":68,"context_line":"This model can operate much like the existing SQL migrations and models. If"},{"line_number":69,"context_line":"data needs to change on the LDAP backend, a migration must be provided that"},{"line_number":70,"context_line":"does the proper upgrades."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Unit and functional testing can be separated from the existing LDAP testing if"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_71ca95a2","line":69,"in_reply_to":"3a961159_3c8b8f1f","updated":"2014-12-18 00:41:30.000000000","message":"I have added a couple of solutions for downgrade migrations. Both include some pros and cons.","commit_id":"919a8f4040f773f10f4421b4c70eae56b74d871a"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"cd4d30278ed52d6261733576a35e98599aa47ec4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"For the R/W LDAP case, a Keystone object model may be enforced on the backend,"},{"line_number":67,"context_line":"versus having a mapping that translates LDAP attributes to Keystone objects."},{"line_number":68,"context_line":"This model can operate much like the existing SQL migrations and models. If"},{"line_number":69,"context_line":"data needs to change on the LDAP backend, a migration must be provided that"},{"line_number":70,"context_line":"does the proper upgrades."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Unit and functional testing can be separated from the existing LDAP testing if"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_3c8b8f1f","line":69,"in_reply_to":"3a961159_b9587158","updated":"2014-12-17 18:19:15.000000000","message":"What if the absolute minimum schema is provided and everything in a migration is provided as an Auxiliary object class? \n\nhttps://tools.ietf.org/html/rfc4512#section-2.4.3\n\nThis might give deployers flexibility to upgrade without reloading the schema? I feel like nkinder or some of the other LDAP guys might have better feedback on this.","commit_id":"919a8f4040f773f10f4421b4c70eae56b74d871a"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"97de0fbe88b5524244e1f58dd5e3c68f71b86754","unresolved":false,"context_lines":[{"line_number":147,"context_line":"---------------------"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Provide deployers a straightforward implementation of the R/W LDAP drivers with"},{"line_number":150,"context_line":"Keystone\u0027s schema."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Developer Impact"},{"line_number":153,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_393481fa","line":150,"updated":"2014-12-17 17:55:12.000000000","message":"We should elaborate on what effect the migrations will have here.","commit_id":"919a8f4040f773f10f4421b4c70eae56b74d871a"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"8a87e46e2c705fb469e41ddab36061c59892872e","unresolved":false,"context_lines":[{"line_number":147,"context_line":"---------------------"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Provide deployers a straightforward implementation of the R/W LDAP drivers with"},{"line_number":150,"context_line":"Keystone\u0027s schema."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Developer Impact"},{"line_number":153,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a961159_31372db2","line":150,"in_reply_to":"3a961159_393481fa","updated":"2014-12-18 00:41:30.000000000","message":"Will add once I have a clear path of how migrations will work.","commit_id":"919a8f4040f773f10f4421b4c70eae56b74d871a"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"0c25e8c9fecd9347c7099dd8f1e5f5fca70ecf53","unresolved":false,"context_lines":[{"line_number":70,"context_line":"does the proper upgrades."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"For downgrade support, there are a couple of options that can achieve"},{"line_number":73,"context_line":"downgrading to a previous version of a Keystone."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Downgrade Solutions:"},{"line_number":76,"context_line":"1. Create auxiliary classes that can be added/removed from objects without"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a961159_3c2361be","line":73,"updated":"2014-12-18 20:46:20.000000000","message":"nit: \"there are a couple options for downgrading an LDAP schema to accommodate a previous version of Keystone.\"","commit_id":"03a5af68ea2085dea19b60d10fa4de33a9744165"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"7cdade3b8169f0dbee7f4c73f78b35114a359c34","unresolved":false,"context_lines":[{"line_number":70,"context_line":"does the proper upgrades."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"For downgrade support, there are a couple of options that can achieve"},{"line_number":73,"context_line":"downgrading to a previous version of a Keystone."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Downgrade Solutions:"},{"line_number":76,"context_line":"1. Create auxiliary classes that can be added/removed from objects without"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a961159_8e6a1718","line":73,"in_reply_to":"3a961159_3c2361be","updated":"2014-12-22 17:26:45.000000000","message":"Done","commit_id":"03a5af68ea2085dea19b60d10fa4de33a9744165"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"0c25e8c9fecd9347c7099dd8f1e5f5fca70ecf53","unresolved":false,"context_lines":[{"line_number":73,"context_line":"downgrading to a previous version of a Keystone."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Downgrade Solutions:"},{"line_number":76,"context_line":"1. Create auxiliary classes that can be added/removed from objects without"},{"line_number":77,"context_line":"having to change the schema."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    Pros: No downtime during migrations"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a961159_5f1adf6f","line":76,"updated":"2014-12-18 20:46:20.000000000","message":"link to auxiliary classes or an RFC? \n\n\nhttps://tools.ietf.org/html/rfc4512#section-2.4.3","commit_id":"03a5af68ea2085dea19b60d10fa4de33a9744165"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"7cdade3b8169f0dbee7f4c73f78b35114a359c34","unresolved":false,"context_lines":[{"line_number":73,"context_line":"downgrading to a previous version of a Keystone."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Downgrade Solutions:"},{"line_number":76,"context_line":"1. Create auxiliary classes that can be added/removed from objects without"},{"line_number":77,"context_line":"having to change the schema."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    Pros: No downtime during migrations"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a961159_ae7513fb","line":76,"in_reply_to":"3a961159_5f1adf6f","updated":"2014-12-22 17:26:45.000000000","message":"Done","commit_id":"03a5af68ea2085dea19b60d10fa4de33a9744165"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"0c25e8c9fecd9347c7099dd8f1e5f5fca70ecf53","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Downgrade Solutions:"},{"line_number":76,"context_line":"1. Create auxiliary classes that can be added/removed from objects without"},{"line_number":77,"context_line":"having to change the schema."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    Pros: No downtime during migrations"},{"line_number":80,"context_line":"          Avoid data corruption by not touching data directly"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a961159_7fe15b29","line":77,"updated":"2014-12-18 20:46:20.000000000","message":"So, if auxiliary classes are used, it still keeps the references in the schema? \n\nWhat would happen if we really botch defining the \u0027enabled\u0027 type? What would that look like with auxiliary classes?","commit_id":"03a5af68ea2085dea19b60d10fa4de33a9744165"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"7cdade3b8169f0dbee7f4c73f78b35114a359c34","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Downgrade Solutions:"},{"line_number":76,"context_line":"1. Create auxiliary classes that can be added/removed from objects without"},{"line_number":77,"context_line":"having to change the schema."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    Pros: No downtime during migrations"},{"line_number":80,"context_line":"          Avoid data corruption by not touching data directly"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a961159_ee62bb3c","line":77,"in_reply_to":"3a961159_7fe15b29","updated":"2014-12-22 17:26:45.000000000","message":"Done","commit_id":"03a5af68ea2085dea19b60d10fa4de33a9744165"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"0c25e8c9fecd9347c7099dd8f1e5f5fca70ecf53","unresolved":false,"context_lines":[{"line_number":81,"context_line":"          Backwards compatible schema"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    Cons: Growing schema"},{"line_number":84,"context_line":"          Orphan classes"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"2. Have a version tracker for previous version of the schema much like current"},{"line_number":87,"context_line":"SQL migrations."}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a961159_ff22aba1","line":84,"updated":"2014-12-18 20:46:20.000000000","message":"nit: could put these into an .rst formatted list\n\n    * no downtime during migrations\n    * avoid data corruption by not touching data directly\n\nsimilar to how the security impact section looks.","commit_id":"03a5af68ea2085dea19b60d10fa4de33a9744165"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"7cdade3b8169f0dbee7f4c73f78b35114a359c34","unresolved":false,"context_lines":[{"line_number":81,"context_line":"          Backwards compatible schema"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    Cons: Growing schema"},{"line_number":84,"context_line":"          Orphan classes"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"2. Have a version tracker for previous version of the schema much like current"},{"line_number":87,"context_line":"SQL migrations."}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a961159_0e662751","line":84,"in_reply_to":"3a961159_ff22aba1","updated":"2014-12-22 17:26:45.000000000","message":"Done","commit_id":"03a5af68ea2085dea19b60d10fa4de33a9744165"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"0c25e8c9fecd9347c7099dd8f1e5f5fca70ecf53","unresolved":false,"context_lines":[{"line_number":86,"context_line":"2. Have a version tracker for previous version of the schema much like current"},{"line_number":87,"context_line":"SQL migrations."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    Pros: Clean schema"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    Cons: Downtime"},{"line_number":92,"context_line":"          Removing attributes from LDAP schemas is prone to errors"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a961159_7fb31b4d","line":89,"updated":"2014-12-18 20:46:20.000000000","message":"by clean schema do you mean less attributes because we can \"force\" reload the schema?","commit_id":"03a5af68ea2085dea19b60d10fa4de33a9744165"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"7cdade3b8169f0dbee7f4c73f78b35114a359c34","unresolved":false,"context_lines":[{"line_number":86,"context_line":"2. Have a version tracker for previous version of the schema much like current"},{"line_number":87,"context_line":"SQL migrations."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    Pros: Clean schema"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    Cons: Downtime"},{"line_number":92,"context_line":"          Removing attributes from LDAP schemas is prone to errors"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a961159_4e5caf7d","line":89,"in_reply_to":"3a961159_7fb31b4d","updated":"2014-12-22 17:26:45.000000000","message":"Done","commit_id":"03a5af68ea2085dea19b60d10fa4de33a9744165"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"0c25e8c9fecd9347c7099dd8f1e5f5fca70ecf53","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    Cons: Downtime"},{"line_number":92,"context_line":"          Removing attributes from LDAP schemas is prone to errors"},{"line_number":93,"context_line":"          LDAP data dumps to remove attributes/objects to reload new schema"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Unit and functional testing can be separated from the existing LDAP testing if"},{"line_number":96,"context_line":"the tests are specific to the R/W implementation. With Keystone being the API"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a961159_bf7ae385","line":93,"updated":"2014-12-18 20:46:20.000000000","message":"same comment here","commit_id":"03a5af68ea2085dea19b60d10fa4de33a9744165"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"7cdade3b8169f0dbee7f4c73f78b35114a359c34","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    Cons: Downtime"},{"line_number":92,"context_line":"          Removing attributes from LDAP schemas is prone to errors"},{"line_number":93,"context_line":"          LDAP data dumps to remove attributes/objects to reload new schema"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Unit and functional testing can be separated from the existing LDAP testing if"},{"line_number":96,"context_line":"the tests are specific to the R/W implementation. With Keystone being the API"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a961159_6e56cb5d","line":93,"in_reply_to":"3a961159_bf7ae385","updated":"2014-12-22 17:26:45.000000000","message":"Done","commit_id":"03a5af68ea2085dea19b60d10fa4de33a9744165"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c885e9ad0a1e5416e4a8d2a0b2301da8a5447e48","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Downgrade Solutions:"},{"line_number":76,"context_line":"1. The use of `auxiliary objectclasses`_  can be used in defining versions of"},{"line_number":77,"context_line":"schema related to keystone implementation versions. The auxiliary objectclasses"},{"line_number":78,"context_line":"would be tagged onto well defined structured objectclasses according to the"},{"line_number":79,"context_line":"version of keystone that would be implemented. The structured objectclasses"},{"line_number":80,"context_line":"contain all core attributes expected for every keystone version. In this way,"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3a961159_dea3ea40","line":77,"updated":"2014-12-22 19:57:41.000000000","message":"nit: Capitalize Keystone\n\napplies throughout.","commit_id":"b82309642c09882fab3d95130b8fd96c7b9f7ece"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"9cbc841a53545028d5b42774a286062c7eef1ec1","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Define a new Keystone LDAP schema, and implement new LDAP R/W drivers that"},{"line_number":15,"context_line":"target it, in an effort to have two separate implementations: R/O LDAP with"},{"line_number":16,"context_line":"mappings of existing LDAP instances, and R/W LDAP for only a single schema. The"},{"line_number":17,"context_line":"R/W LDAP driver will be treated similarly to the SQL backends; that supports"},{"line_number":18,"context_line":"data migration between releases."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a961159_cbd0d8cb","line":16,"updated":"2015-01-05 17:36:40.000000000","message":"Why only a single schema? Does this mean it will not be backward compatible with the existing R/W LDAP backend?","commit_id":"efe20205651438ee7177e440a2a4661101c9538c"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"492099ca64bdd44445efb957a7f790d0d72b54ec","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Define a new Keystone LDAP schema, and implement new LDAP R/W drivers that"},{"line_number":15,"context_line":"target it, in an effort to have two separate implementations: R/O LDAP with"},{"line_number":16,"context_line":"mappings of existing LDAP instances, and R/W LDAP for only a single schema. The"},{"line_number":17,"context_line":"R/W LDAP driver will be treated similarly to the SQL backends; that supports"},{"line_number":18,"context_line":"data migration between releases."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a961159_cb7e11e4","line":16,"in_reply_to":"3a961159_cbd0d8cb","updated":"2015-01-06 16:19:26.000000000","message":"Correct, this will not be backward compatible with the current implementation of R/W LDAP backend. Only one schema per release because this would be managed by keystone.","commit_id":"efe20205651438ee7177e440a2a4661101c9538c"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"9cbc841a53545028d5b42774a286062c7eef1ec1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"target it, in an effort to have two separate implementations: R/O LDAP with"},{"line_number":16,"context_line":"mappings of existing LDAP instances, and R/W LDAP for only a single schema. The"},{"line_number":17,"context_line":"R/W LDAP driver will be treated similarly to the SQL backends; that supports"},{"line_number":18,"context_line":"data migration between releases."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Problem Description"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a961159_0b010039","line":18,"updated":"2015-01-05 17:36:40.000000000","message":"Follow-on to the question above, you mean we do support data migration for the *existing* R/W LDAP deployments?","commit_id":"efe20205651438ee7177e440a2a4661101c9538c"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"492099ca64bdd44445efb957a7f790d0d72b54ec","unresolved":false,"context_lines":[{"line_number":15,"context_line":"target it, in an effort to have two separate implementations: R/O LDAP with"},{"line_number":16,"context_line":"mappings of existing LDAP instances, and R/W LDAP for only a single schema. The"},{"line_number":17,"context_line":"R/W LDAP driver will be treated similarly to the SQL backends; that supports"},{"line_number":18,"context_line":"data migration between releases."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Problem Description"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a961159_ebe4ada9","line":18,"in_reply_to":"3a961159_0b010039","updated":"2015-01-06 16:19:26.000000000","message":"No, how can you migrate when you don\u0027t have the existing schema? Even if we write code it would be hard to test since keystone does not have visibility to customers mappings.","commit_id":"efe20205651438ee7177e440a2a4661101c9538c"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"9cbc841a53545028d5b42774a286062c7eef1ec1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Problem Description"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The current Keystone LDAP backends have one implementation with both R/O"},{"line_number":24,"context_line":"and R/W behaviors. It is recommended that a R/O LDAP implementation be used"},{"line_number":25,"context_line":"with Keystone when `integrating with LDAP`_, but there are ways to allow writes"},{"line_number":26,"context_line":"to an LDAP server using a Keystone LDAP backend. For example, allowing LDAP"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a961159_6b8d24d3","line":23,"updated":"2015-01-05 17:36:40.000000000","message":"My understanding is the R/O will go away in favor of Apache SSSD. It will be similar to how we support federation.","commit_id":"efe20205651438ee7177e440a2a4661101c9538c"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"492099ca64bdd44445efb957a7f790d0d72b54ec","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Problem Description"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The current Keystone LDAP backends have one implementation with both R/O"},{"line_number":24,"context_line":"and R/W behaviors. It is recommended that a R/O LDAP implementation be used"},{"line_number":25,"context_line":"with Keystone when `integrating with LDAP`_, but there are ways to allow writes"},{"line_number":26,"context_line":"to an LDAP server using a Keystone LDAP backend. For example, allowing LDAP"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a961159_23988074","line":23,"in_reply_to":"3a961159_6b8d24d3","updated":"2015-01-06 16:19:26.000000000","message":"This will not affect the current implementation.","commit_id":"efe20205651438ee7177e440a2a4661101c9538c"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"9cbc841a53545028d5b42774a286062c7eef1ec1","unresolved":false,"context_lines":[{"line_number":32,"context_line":"It would be easier to configure each implementation according to what a user"},{"line_number":33,"context_line":"needs LDAP to do. For example, only providing mappings to LDAP in R/O"},{"line_number":34,"context_line":"implementations. This can be done by adding a R/W LDAP implementation that"},{"line_number":35,"context_line":"allows users to use Keystone with an LDAP backend much like they would SQL."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":".. _`integrating with LDAP`: http://docs.openstack.org/admin-guide-cloud/content/configuring-keystone-for-ldap-backend.html"},{"line_number":38,"context_line":".. _`role`: https://github.com/openstack/keystone/blob/3cddc459736260c3952eeede17aa84ec2f25a044/etc/keystone.conf.sample#L1098"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a961159_e60b0922","line":35,"updated":"2015-01-05 17:36:40.000000000","message":"Unless we are using common LDAP schema, we are either going to ship our own embedded LDAP server, introduce a new RFC, or ask the LDAP admin to add the new schema to the existing LDAP server. So the tradeoff with enabling schema mapping is that customers can still use their own LDAP server and does not need to add new schema.","commit_id":"efe20205651438ee7177e440a2a4661101c9538c"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"492099ca64bdd44445efb957a7f790d0d72b54ec","unresolved":false,"context_lines":[{"line_number":32,"context_line":"It would be easier to configure each implementation according to what a user"},{"line_number":33,"context_line":"needs LDAP to do. For example, only providing mappings to LDAP in R/O"},{"line_number":34,"context_line":"implementations. This can be done by adding a R/W LDAP implementation that"},{"line_number":35,"context_line":"allows users to use Keystone with an LDAP backend much like they would SQL."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":".. _`integrating with LDAP`: http://docs.openstack.org/admin-guide-cloud/content/configuring-keystone-for-ldap-backend.html"},{"line_number":38,"context_line":".. _`role`: https://github.com/openstack/keystone/blob/3cddc459736260c3952eeede17aa84ec2f25a044/etc/keystone.conf.sample#L1098"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a961159_6368c8f5","line":35,"in_reply_to":"3a961159_e60b0922","updated":"2015-01-06 16:19:26.000000000","message":"If customers want to use their own schema they should use the current implementation.","commit_id":"efe20205651438ee7177e440a2a4661101c9538c"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"9cbc841a53545028d5b42774a286062c7eef1ec1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"existing `common ldap`_ code that lives in Keystone if needed, but the logic"},{"line_number":50,"context_line":"within the R/W LDAP implementation should be specific to R/W Keystone LDAP use"},{"line_number":51,"context_line":"cases. It will no longer write to any schema, only the one provided by"},{"line_number":52,"context_line":"Keystone."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The goal is to separate the current implementation that handles both R/W and"},{"line_number":55,"context_line":"R/O into R/W LDAP drivers that target the new schema. New schema will exist"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a961159_066735eb","line":52,"updated":"2015-01-05 17:36:40.000000000","message":"Not sure if I understand the above paragraph. How does gerrit, jenkins get into this picture?","commit_id":"efe20205651438ee7177e440a2a4661101c9538c"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"492099ca64bdd44445efb957a7f790d0d72b54ec","unresolved":false,"context_lines":[{"line_number":49,"context_line":"existing `common ldap`_ code that lives in Keystone if needed, but the logic"},{"line_number":50,"context_line":"within the R/W LDAP implementation should be specific to R/W Keystone LDAP use"},{"line_number":51,"context_line":"cases. It will no longer write to any schema, only the one provided by"},{"line_number":52,"context_line":"Keystone."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The goal is to separate the current implementation that handles both R/W and"},{"line_number":55,"context_line":"R/O into R/W LDAP drivers that target the new schema. New schema will exist"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a961159_8b516932","line":52,"in_reply_to":"3a961159_066735eb","updated":"2015-01-06 16:19:26.000000000","message":"They are example of systems that can bind agains a directory with a keystone user. I\u0027ll change it to make it less confusing.","commit_id":"efe20205651438ee7177e440a2a4661101c9538c"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"9cbc841a53545028d5b42774a286062c7eef1ec1","unresolved":false,"context_lines":[{"line_number":55,"context_line":"R/O into R/W LDAP drivers that target the new schema. New schema will exist"},{"line_number":56,"context_line":"under the Keystone project and only one version will be supported on every"},{"line_number":57,"context_line":"Keystone release. Stakeholders will be able to provide their input,"},{"line_number":58,"context_line":"suggestions, and concerns when the schema is up for review. The new driver will"},{"line_number":59,"context_line":"not affect the current implementation, but rather simplify the use of the R/W"},{"line_number":60,"context_line":"drivers without the extensive configuration changes. Initial implementation"},{"line_number":61,"context_line":"would only target the identity and assignment backend drivers, but allowing the"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a961159_c60e0de5","line":58,"updated":"2015-01-05 17:36:40.000000000","message":"So the \"new schema\" will be in a separate spec? It would be nice to have an example here. Like what are new suffixes, object classes, and attributes look like and how data migration works.","commit_id":"efe20205651438ee7177e440a2a4661101c9538c"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"492099ca64bdd44445efb957a7f790d0d72b54ec","unresolved":false,"context_lines":[{"line_number":55,"context_line":"R/O into R/W LDAP drivers that target the new schema. New schema will exist"},{"line_number":56,"context_line":"under the Keystone project and only one version will be supported on every"},{"line_number":57,"context_line":"Keystone release. Stakeholders will be able to provide their input,"},{"line_number":58,"context_line":"suggestions, and concerns when the schema is up for review. The new driver will"},{"line_number":59,"context_line":"not affect the current implementation, but rather simplify the use of the R/W"},{"line_number":60,"context_line":"drivers without the extensive configuration changes. Initial implementation"},{"line_number":61,"context_line":"would only target the identity and assignment backend drivers, but allowing the"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a961159_867ea219","line":58,"in_reply_to":"3a961159_c60e0de5","updated":"2015-01-06 16:19:26.000000000","message":"Review iterations on the schema can be done once it\u0027s up for review. I will bring it up on the keystone meeting to see how much of the implementation details are needed for this spec.","commit_id":"efe20205651438ee7177e440a2a4661101c9538c"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"9cbc841a53545028d5b42774a286062c7eef1ec1","unresolved":false,"context_lines":[{"line_number":70,"context_line":"does the proper upgrades."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"For downgrade support, there are a couple options for downgrading an LDAP"},{"line_number":73,"context_line":"schema to accommodate a previous version of Keystone."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Downgrade Solutions:"},{"line_number":76,"context_line":"1. The use of `auxiliary objectclasses`_  can be used in defining versions of"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a961159_86b965ee","line":73,"updated":"2015-01-05 17:36:40.000000000","message":"Even SQL does not support downgrade very well. Lets not worry about it for now.","commit_id":"efe20205651438ee7177e440a2a4661101c9538c"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"492099ca64bdd44445efb957a7f790d0d72b54ec","unresolved":false,"context_lines":[{"line_number":70,"context_line":"does the proper upgrades."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"For downgrade support, there are a couple options for downgrading an LDAP"},{"line_number":73,"context_line":"schema to accommodate a previous version of Keystone."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Downgrade Solutions:"},{"line_number":76,"context_line":"1. The use of `auxiliary objectclasses`_  can be used in defining versions of"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a961159_26a6ceab","line":73,"in_reply_to":"3a961159_86b965ee","updated":"2015-01-06 16:19:26.000000000","message":"Ok, but will the this section on the spec since its still a valid concern.","commit_id":"efe20205651438ee7177e440a2a4661101c9538c"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"9cbc841a53545028d5b42774a286062c7eef1ec1","unresolved":false,"context_lines":[{"line_number":226,"context_line":"* Propose functional testing against LDAP with the R/W backend enabled for"},{"line_number":227,"context_line":"  Keystone"},{"line_number":228,"context_line":"* Implementation of the schema is dependent on getting oids from the OpenStack"},{"line_number":229,"context_line":"  Foundation via Chris Hoge \u003cchris@openstack.org\u003e"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"Dependencies"},{"line_number":232,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a961159_a68ae117","line":229,"updated":"2015-01-05 17:36:40.000000000","message":"* Provide migrate script to migrate the exiting R/W LDAP data","commit_id":"efe20205651438ee7177e440a2a4661101c9538c"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"492099ca64bdd44445efb957a7f790d0d72b54ec","unresolved":false,"context_lines":[{"line_number":226,"context_line":"* Propose functional testing against LDAP with the R/W backend enabled for"},{"line_number":227,"context_line":"  Keystone"},{"line_number":228,"context_line":"* Implementation of the schema is dependent on getting oids from the OpenStack"},{"line_number":229,"context_line":"  Foundation via Chris Hoge \u003cchris@openstack.org\u003e"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"Dependencies"},{"line_number":232,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3a961159_0372a449","line":229,"in_reply_to":"3a961159_a68ae117","updated":"2015-01-06 16:19:26.000000000","message":"This is not part of the scope of this implementation.","commit_id":"efe20205651438ee7177e440a2a4661101c9538c"}]}
