)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"4ade6c04dbdb121aaa0ccfe2a5413c0d987fb20d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-02-06 10:01:04 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"implement timestamp for Project, Domain, Role"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"bp model-timestamps"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I8ec48a5ceff55ecd552945d7a4312aacaba7f32f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da86d52c_37aec42e","line":8,"updated":"2015-02-06 02:13:49.000000000","message":"add a description here","commit_id":"1a11109b3c4f46d7a9cfff620d140603f285b27d"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"a915b57b578764e0d5bae8aac56dacee57daf1db","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-02-06 10:01:04 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"implement timestamp for Project, Domain, Role"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"bp model-timestamps"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I8ec48a5ceff55ecd552945d7a4312aacaba7f32f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da86d52c_177aa0bc","line":8,"in_reply_to":"da86d52c_37aec42e","updated":"2015-02-06 02:15:37.000000000","message":"see: https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages\n\nDo not assume the reviewer has access to external web services/site. (by just linking the bp)","commit_id":"1a11109b3c4f46d7a9cfff620d140603f285b27d"}],"specs/kilo/model-timestamps.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"eff10f2dd20bb5c60a4e749f51d52b9936113f63","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Proposed Change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Actually, oslo_db has provided a TimestampMixin object for timestamp models."},{"line_number":37,"context_line":"The only thing we need to do is to make Project, Domain, Role inherit from"},{"line_number":38,"context_line":"TimestampMixin and then add a db migration script."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"da86d52c_3b7c18b5","line":36,"updated":"2015-02-05 07:20:22.000000000","message":"make this oslo_db reference the link below.","commit_id":"215d7131efb14c396894b850dd13a28c4b84b49c"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"601a81dd9a26f28013367a4051f0bc177b4afe01","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Actually, oslo_db has provided a TimestampMixin object for timestamp models."},{"line_number":37,"context_line":"The only thing we need to do is to make Project, Domain, Role inherit from"},{"line_number":38,"context_line":"TimestampMixin and then add a db migration script."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da86d52c_a06c55d1","line":38,"updated":"2015-02-05 05:52:32.000000000","message":"But what about the ldap assignment backend?  I think we need to at least state its excluded from this spec or reference another spec that would address it.\n\nFor LDAP, see https://bugs.launchpad.net/keystone/+bug/1156904, as I indicated there are timestamp attributes available to query.","commit_id":"215d7131efb14c396894b850dd13a28c4b84b49c"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"eff10f2dd20bb5c60a4e749f51d52b9936113f63","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Actually, oslo_db has provided a TimestampMixin object for timestamp models."},{"line_number":37,"context_line":"The only thing we need to do is to make Project, Domain, Role inherit from"},{"line_number":38,"context_line":"TimestampMixin and then add a db migration script."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da86d52c_bb3e48d8","line":38,"in_reply_to":"da86d52c_a06c55d1","updated":"2015-02-05 07:20:22.000000000","message":"I\u0027d be happy if the spec mentions that it will ONLY solve for SQL, and does not intend to solve for the ldap backend.\n\nGiven the relatively low use of ldap for the assignment backend i think this is very appropriate.","commit_id":"215d7131efb14c396894b850dd13a28c4b84b49c"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"b9613c8c313c7bbf39d75f49a9296142d64cb470","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Currently Project, Domain, Role, User, Group models don\u0027t have a timestamp."},{"line_number":15,"context_line":"There is no way to determine when these resources were created and when they"},{"line_number":16,"context_line":"were last modified. This can be a huge problem for auditing, administration,"},{"line_number":17,"context_line":"etc."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We don\u0027t want to make one spec that fixes all models. So, this spec will only"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_8a9922c6","line":16,"updated":"2015-02-05 12:40:35.000000000","message":"I\u0027m confused.  When CADF audit event records are generated a timestamp is created and added to the CADF record. So why are you saying there is not a timestamp for auditing purposes?","commit_id":"27736281070c4c7b584014b4d1b0f12f13680558"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a3999efb5b252748c41a6dc361e72b6a951446a0","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We don\u0027t want to make one spec that fixes all models. So, this spec will only"},{"line_number":20,"context_line":"implement timestamp for assignment models: Project, Domain, Role. And because"},{"line_number":21,"context_line":"ldap assignment backend will be deprecated in next circle and be removed in"},{"line_number":22,"context_line":"the future, we only implement this in sql backend."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_1b2d94a8","line":21,"updated":"2015-02-05 07:20:55.000000000","message":"use cycle* not circle","commit_id":"27736281070c4c7b584014b4d1b0f12f13680558"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"ec015ccff915c16ef24e6d0ec277eb38c4206394","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Proposed Change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Actually, oslo_db has provided a TimestampMixin[1] object for timestamp models."},{"line_number":39,"context_line":"The only thing we need to do is to make Project, Domain, Role inherit from"},{"line_number":40,"context_line":"TimestampMixin and then add a db migration script."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_f7d34cd2","line":38,"updated":"2015-02-06 02:11:24.000000000","message":"nice","commit_id":"1a11109b3c4f46d7a9cfff620d140603f285b27d"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"ec015ccff915c16ef24e6d0ec277eb38c4206394","unresolved":false,"context_lines":[{"line_number":89,"context_line":"Work Items"},{"line_number":90,"context_line":"----------"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"* Update Project, Domain, Role model to inherit TimestampMixin"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"* Write db migration script"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_b766344f","line":92,"updated":"2015-02-06 02:11:24.000000000","message":"according to the Reseller spec (https://review.openstack.org/#/c/139824/), the domain model/table will be removed. So I suggest you add it in the references and update the text where it is being stated the update of the domain table.","commit_id":"1a11109b3c4f46d7a9cfff620d140603f285b27d"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"ec015ccff915c16ef24e6d0ec277eb38c4206394","unresolved":false,"context_lines":[{"line_number":105,"context_line":"Documentation Impact"},{"line_number":106,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Update the Projects, Domains, Roles sections of documentation."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_d7d008cb","line":108,"updated":"2015-02-06 02:11:24.000000000","message":"Don\u0027t remove here, domains docs are not going to be removed (just updated).","commit_id":"1a11109b3c4f46d7a9cfff620d140603f285b27d"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"08632f7d4056beb666db8fcfea7313f1d5418d46","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Proposed Change"},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Actually, oslo_db has provided a TimestampMixin[1] object for timestamp models."},{"line_number":43,"context_line":"The only thing we need to do is to make Project, Role inherit from"},{"line_number":44,"context_line":"TimestampMixin and then add a db migration script."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da86d52c_da14a84e","line":42,"updated":"2015-02-06 07:02:13.000000000","message":"oslo.db*","commit_id":"692416fc505c50d53c6ceb6385486728cdf6136d"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"08632f7d4056beb666db8fcfea7313f1d5418d46","unresolved":false,"context_lines":[{"line_number":103,"context_line":"Dependencies"},{"line_number":104,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"None"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da86d52c_da3d88de","line":106,"updated":"2015-02-06 07:02:13.000000000","message":"oslo.db is a dependency, but not a new one","commit_id":"692416fc505c50d53c6ceb6385486728cdf6136d"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"08632f7d4056beb666db8fcfea7313f1d5418d46","unresolved":false,"context_lines":[{"line_number":109,"context_line":"Documentation Impact"},{"line_number":110,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Update the Projects, Domains, Roles sections of documentation."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da86d52c_3a2ea4a5","line":112,"updated":"2015-02-06 07:02:13.000000000","message":"no need to update domains?","commit_id":"692416fc505c50d53c6ceb6385486728cdf6136d"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"5266c5c32f1d3bbbef6a25f3f7e7eff8593a8bac","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Because ldap assignment backend will be deprecated in next cycle and be removed"},{"line_number":23,"context_line":"in the future, we only implement this in sql backend."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"According to the reseller spec[2], the Domains and projects will become one"},{"line_number":26,"context_line":"resource type, so this spec only implements timestamp for Project and Role."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"da86d52c_95884372","line":25,"updated":"2015-02-06 07:13:27.000000000","message":"use proper linking for reseller\n\nalso capitalize projects","commit_id":"3f06339cc8d1838e19bfb7b0dfe6baaf5ddf1ed0"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"5266c5c32f1d3bbbef6a25f3f7e7eff8593a8bac","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Proposed Change"},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Actually, oslo.db has provided a TimestampMixin[1] object for timestamp models."},{"line_number":43,"context_line":"The only thing we need to do is to make Project, Role inherit from"},{"line_number":44,"context_line":"TimestampMixin and then add a db migration script."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"da86d52c_55b32b4c","line":42,"updated":"2015-02-06 07:13:27.000000000","message":"use proper linking for oslo.db","commit_id":"3f06339cc8d1838e19bfb7b0dfe6baaf5ddf1ed0"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"5266c5c32f1d3bbbef6a25f3f7e7eff8593a8bac","unresolved":false,"context_lines":[{"line_number":116,"context_line":"References"},{"line_number":117,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"[1] ` oslo_db TimestampMixin"},{"line_number":120,"context_line":"\u003chttps://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/models.py#L115\u003e`_"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"[2] ` reseller spec"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da86d52c_f5989fc1","line":119,"updated":"2015-02-06 07:13:27.000000000","message":"change this to oslo.db","commit_id":"3f06339cc8d1838e19bfb7b0dfe6baaf5ddf1ed0"}]}
