)]}'
{"specs/keystonemiddleware/request-helpers.rst":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"dd4af6e3d6f13d3b9f398a627701717d85ae9487","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Problem Description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Service to Service communication is a mess. There is no standard way of"},{"line_number":25,"context_line":"initiating calls and initiatives like Service tokens and Request-IDs are only"},{"line_number":26,"context_line":"as successful as different services manually implement them."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a80dd14_f3c8e023","line":24,"updated":"2015-03-20 03:24:33.000000000","message":"that\u0027s an understatement :)","commit_id":"1fb3db9de6e3b47fc484f50e9aca5a32de2f43ee"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"1c01ae28290b4f5eb0a2c673915b1ff6352c45a3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"We are already passing down an auth plugin to services. For clients that"},{"line_number":40,"context_line":"support using an auth plugin (which is now most and the number is growing)"},{"line_number":41,"context_line":"communicating with this service now simply involves taking the plugin from the"},{"line_number":42,"context_line":"ENV variable auth_token middleware sets and initiating a client with that"},{"line_number":43,"context_line":"plugin."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"I would like to initially add X-Service-Token to the get_headers method so that"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a6ced46_fe756198","line":42,"updated":"2015-03-24 19:48:46.000000000","message":"What environment variable is that?","commit_id":"1fb3db9de6e3b47fc484f50e9aca5a32de2f43ee"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"300710508f3e72dd74a99c413c7a6d28c603b822","unresolved":false,"context_lines":[{"line_number":39,"context_line":"We are already passing down an auth plugin to services. For clients that"},{"line_number":40,"context_line":"support using an auth plugin (which is now most and the number is growing)"},{"line_number":41,"context_line":"communicating with this service now simply involves taking the plugin from the"},{"line_number":42,"context_line":"ENV variable auth_token middleware sets and initiating a client with that"},{"line_number":43,"context_line":"plugin."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"I would like to initially add X-Service-Token to the get_headers method so that"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_05fc6a70","line":42,"in_reply_to":"1a6ced46_fe756198","updated":"2015-04-28 06:13:52.000000000","message":"keystone.token_auth - and i should put that into the spec.","commit_id":"1fb3db9de6e3b47fc484f50e9aca5a32de2f43ee"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"1c01ae28290b4f5eb0a2c673915b1ff6352c45a3","unresolved":false,"context_lines":[{"line_number":54,"context_line":"This would also allow us to finally fix token binding as we would enforce a"},{"line_number":55,"context_line":"token bind only upon a service token if present."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Additionally I would like to add the Openstack-Request-ID header. This header"},{"line_number":58,"context_line":"is an attempt to allow better tracing of how a request flows through OpenStack."},{"line_number":59,"context_line":"By adding it to the auth plugin new services would gain support for this"},{"line_number":60,"context_line":"request tracing with no additional effort."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a6ced46_bec5a93d","line":57,"updated":"2015-03-24 19:48:46.000000000","message":"x-openstack-request-id?","commit_id":"1fb3db9de6e3b47fc484f50e9aca5a32de2f43ee"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"300710508f3e72dd74a99c413c7a6d28c603b822","unresolved":false,"context_lines":[{"line_number":54,"context_line":"This would also allow us to finally fix token binding as we would enforce a"},{"line_number":55,"context_line":"token bind only upon a service token if present."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Additionally I would like to add the Openstack-Request-ID header. This header"},{"line_number":58,"context_line":"is an attempt to allow better tracing of how a request flows through OpenStack."},{"line_number":59,"context_line":"By adding it to the auth plugin new services would gain support for this"},{"line_number":60,"context_line":"request tracing with no additional effort."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_e5005668","line":57,"in_reply_to":"1a6ced46_bec5a93d","updated":"2015-04-28 06:13:52.000000000","message":"yes, will clarify that","commit_id":"1fb3db9de6e3b47fc484f50e9aca5a32de2f43ee"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"1c01ae28290b4f5eb0a2c673915b1ff6352c45a3","unresolved":false,"context_lines":[{"line_number":57,"context_line":"Additionally I would like to add the Openstack-Request-ID header. This header"},{"line_number":58,"context_line":"is an attempt to allow better tracing of how a request flows through OpenStack."},{"line_number":59,"context_line":"By adding it to the auth plugin new services would gain support for this"},{"line_number":60,"context_line":"request tracing with no additional effort."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Alternatives"},{"line_number":63,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a6ced46_5e3af536","line":60,"updated":"2015-03-24 19:48:46.000000000","message":"I\u0027m assuming you would allow it to be passed in by the caller?","commit_id":"1fb3db9de6e3b47fc484f50e9aca5a32de2f43ee"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"0019e4ce3ee0e77120edfee81dd12385403465fc","unresolved":false,"context_lines":[{"line_number":57,"context_line":"Additionally I would like to add the Openstack-Request-ID header. This header"},{"line_number":58,"context_line":"is an attempt to allow better tracing of how a request flows through OpenStack."},{"line_number":59,"context_line":"By adding it to the auth plugin new services would gain support for this"},{"line_number":60,"context_line":"request tracing with no additional effort."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Alternatives"},{"line_number":63,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa53dc9_a64a5d24","line":60,"updated":"2015-04-10 09:30:10.000000000","message":"very cool","commit_id":"1fb3db9de6e3b47fc484f50e9aca5a32de2f43ee"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"300710508f3e72dd74a99c413c7a6d28c603b822","unresolved":false,"context_lines":[{"line_number":57,"context_line":"Additionally I would like to add the Openstack-Request-ID header. This header"},{"line_number":58,"context_line":"is an attempt to allow better tracing of how a request flows through OpenStack."},{"line_number":59,"context_line":"By adding it to the auth plugin new services would gain support for this"},{"line_number":60,"context_line":"request tracing with no additional effort."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Alternatives"},{"line_number":63,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_c5faf274","line":60,"in_reply_to":"9aa53dc9_a64a5d24","updated":"2015-04-28 06:13:52.000000000","message":"sure - the plugin shouldn\u0027t override anything just add if not present.","commit_id":"1fb3db9de6e3b47fc484f50e9aca5a32de2f43ee"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"1c01ae28290b4f5eb0a2c673915b1ff6352c45a3","unresolved":false,"context_lines":[{"line_number":62,"context_line":"Alternatives"},{"line_number":63,"context_line":"------------"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"The alternative is to simply leave this information under the control of"},{"line_number":66,"context_line":"individual services. New OpenStack wide initiatives will continue to be done"},{"line_number":67,"context_line":"service by service."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a6ced46_de2b4592","line":65,"updated":"2015-03-24 19:48:46.000000000","message":"So far this all seems like stuff we should be doing. I worry though that we\u0027ll be doing stuff that is not really work that needs to be owned by the Identity project.","commit_id":"1fb3db9de6e3b47fc484f50e9aca5a32de2f43ee"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"300710508f3e72dd74a99c413c7a6d28c603b822","unresolved":false,"context_lines":[{"line_number":62,"context_line":"Alternatives"},{"line_number":63,"context_line":"------------"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"The alternative is to simply leave this information under the control of"},{"line_number":66,"context_line":"individual services. New OpenStack wide initiatives will continue to be done"},{"line_number":67,"context_line":"service by service."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_2532ce5f","line":65,"in_reply_to":"1a6ced46_de2b4592","updated":"2015-04-28 06:13:52.000000000","message":"I understand the concern there, however if we are talking about service to service communication then i don\u0027t see anywhere other than auth_token middleware where it could live.","commit_id":"1fb3db9de6e3b47fc484f50e9aca5a32de2f43ee"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"1c01ae28290b4f5eb0a2c673915b1ff6352c45a3","unresolved":false,"context_lines":[{"line_number":87,"context_line":"Performance Impact"},{"line_number":88,"context_line":"------------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"There is the additional cost of verify X-Service-Tokens that will be present"},{"line_number":91,"context_line":"when they otherwise would not have been."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Other Deployer Impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a6ced46_de734513","line":90,"updated":"2015-03-24 19:48:46.000000000","message":"s/of/to/","commit_id":"1fb3db9de6e3b47fc484f50e9aca5a32de2f43ee"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"dd4af6e3d6f13d3b9f398a627701717d85ae9487","unresolved":false,"context_lines":[{"line_number":88,"context_line":"------------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"There is the additional cost of verify X-Service-Tokens that will be present"},{"line_number":91,"context_line":"when they otherwise would not have been."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Other Deployer Impact"},{"line_number":94,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a80dd14_53e9ac7d","line":91,"updated":"2015-03-20 03:24:33.000000000","message":"it depends, if we are using PKI token provider, they bytes add up :)","commit_id":"1fb3db9de6e3b47fc484f50e9aca5a32de2f43ee"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"300710508f3e72dd74a99c413c7a6d28c603b822","unresolved":false,"context_lines":[{"line_number":88,"context_line":"------------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"There is the additional cost of verify X-Service-Tokens that will be present"},{"line_number":91,"context_line":"when they otherwise would not have been."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Other Deployer Impact"},{"line_number":94,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab921fb_65ed66b6","line":91,"in_reply_to":"9a80dd14_53e9ac7d","updated":"2015-04-28 06:13:52.000000000","message":"right - whether that be PKI or UUID tokens there is an additional validation step and there is always a cost to that.","commit_id":"1fb3db9de6e3b47fc484f50e9aca5a32de2f43ee"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"1c01ae28290b4f5eb0a2c673915b1ff6352c45a3","unresolved":false,"context_lines":[{"line_number":144,"context_line":"References"},{"line_number":145,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"* https://github.com/openstack/keystone-specs/blob/master/specs/keystonemiddleware/implemented/service-tokens.rst"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a6ced46_3e14594d","line":147,"updated":"2015-03-24 19:48:46.000000000","message":"(nit) break this up into two lines","commit_id":"1fb3db9de6e3b47fc484f50e9aca5a32de2f43ee"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"6aa4ae5cad3dca1e2ea490885e8516e2b5d3fbd9","unresolved":false,"context_lines":[{"line_number":124,"context_line":"----------"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"* Add X-Service-Token support to the plugin"},{"line_number":127,"context_line":"* Add X-OpenStack-Request-ID support to the plugin"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"The most notable work item is going to be the long term work of getting"},{"line_number":130,"context_line":"services to use the provided auth plugin rather than the per-service context"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a016987_bfcb39a3","line":127,"updated":"2015-05-25 04:09:39.000000000","message":"The X-OpenStack-Request-ID work should be looked at from the OSProfiler and other tools as well. This can be updated if there is a better tool for the job down the line.","commit_id":"a4cdf8882743d156b15d61840fa7f995cda86f79"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"bb4b6ad0e8aa4625bc9535506217db5e0ee1a69c","unresolved":false,"context_lines":[{"line_number":129,"context_line":"The most notable work item is going to be the long term work of getting"},{"line_number":130,"context_line":"services to use the provided auth plugin rather than the per-service context"},{"line_number":131,"context_line":"management that is done today. This is a required and ongoing task regardless"},{"line_number":132,"context_line":"of this blueprint."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Dependencies"},{"line_number":135,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a016987_6b01ca37","line":132,"updated":"2015-05-20 19:37:55.000000000","message":"For X.509 cert auth, this may have a dependency on the new auth plugin.","commit_id":"a4cdf8882743d156b15d61840fa7f995cda86f79"}]}
