)]}'
{"specs/backlog/materialize-project-hierarchy.rst":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"23fad5102ac47abcaf33d184519a3de52feb3aaf","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Given the project hierarchy as follows:"},{"line_number":22,"context_line":"A -\u003e B -\u003e C -\u003e D"},{"line_number":23,"context_line":"Disabling B project needs to disable all it\u0027s descendants: C and D"},{"line_number":24,"context_line":"So there is a need to check every D-scoped token against all parents"},{"line_number":25,"context_line":"recursively."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aaa499b_c4ec67f5","line":22,"updated":"2015-04-15 17:54:40.000000000","message":"you may use the same hierarchy used here: https://review.openstack.org/#/c/148730/20/specs/liberty/recursive-deletion.rst","commit_id":"ffc25fa539bfa283a8287c66e0cb921a653f4381"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"e03c2c4fe1e5a7e345373587bf1b26186f9144f3","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Given the project hierarchy as follows:"},{"line_number":22,"context_line":"A -\u003e B -\u003e C -\u003e D"},{"line_number":23,"context_line":"Disabling B project needs to disable all it\u0027s descendants: C and D"},{"line_number":24,"context_line":"So there is a need to check every D-scoped token against all parents"},{"line_number":25,"context_line":"recursively."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aa745d1_dd784b92","line":22,"in_reply_to":"7aaa499b_c4ec67f5","updated":"2015-04-15 18:56:21.000000000","message":"Done","commit_id":"ffc25fa539bfa283a8287c66e0cb921a653f4381"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"23fad5102ac47abcaf33d184519a3de52feb3aaf","unresolved":false,"context_lines":[{"line_number":22,"context_line":"A -\u003e B -\u003e C -\u003e D"},{"line_number":23,"context_line":"Disabling B project needs to disable all it\u0027s descendants: C and D"},{"line_number":24,"context_line":"So there is a need to check every D-scoped token against all parents"},{"line_number":25,"context_line":"recursively."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Proposed Change"},{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aaa499b_04cecf81","line":25,"updated":"2015-04-15 17:54:40.000000000","message":"I\u0027d prefer to cite another example, as for example, deleting a whole branch. It is not clear if we are going to implement the \"recursive\" disabling/enabling.","commit_id":"ffc25fa539bfa283a8287c66e0cb921a653f4381"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"e03c2c4fe1e5a7e345373587bf1b26186f9144f3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"A -\u003e B -\u003e C -\u003e D"},{"line_number":23,"context_line":"Disabling B project needs to disable all it\u0027s descendants: C and D"},{"line_number":24,"context_line":"So there is a need to check every D-scoped token against all parents"},{"line_number":25,"context_line":"recursively."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Proposed Change"},{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aa745d1_9d72c3ac","line":25,"in_reply_to":"7aaa499b_04cecf81","updated":"2015-04-15 18:56:21.000000000","message":"Done","commit_id":"ffc25fa539bfa283a8287c66e0cb921a653f4381"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"23fad5102ac47abcaf33d184519a3de52feb3aaf","unresolved":false,"context_lines":[{"line_number":30,"context_line":"It is possible to avoid recursion having entire project pedigree stored in the"},{"line_number":31,"context_line":"model instead of simple parent link."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"For example::"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  DELIMITER \u003d \u0027-\u003e\u0027"},{"line_number":36,"context_line":"  project.pedigree \u003d A.id + DELIMITER + B.id + .. + DELIMITER + D.id"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aaa499b_c49a276e","line":33,"updated":"2015-04-15 17:54:40.000000000","message":"what do you think about what is proposed here: http://dolphm.com/hierarchical-multitenancy/ (ascendant and descendant columns)\n\nif you want to propose either way, I\u0027d put the another in the Alternative session","commit_id":"ffc25fa539bfa283a8287c66e0cb921a653f4381"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"e03c2c4fe1e5a7e345373587bf1b26186f9144f3","unresolved":false,"context_lines":[{"line_number":30,"context_line":"It is possible to avoid recursion having entire project pedigree stored in the"},{"line_number":31,"context_line":"model instead of simple parent link."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"For example::"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  DELIMITER \u003d \u0027-\u003e\u0027"},{"line_number":36,"context_line":"  project.pedigree \u003d A.id + DELIMITER + B.id + .. + DELIMITER + D.id"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aa745d1_ddd4cb48","line":33,"in_reply_to":"7aaa499b_c49a276e","updated":"2015-04-15 18:56:21.000000000","message":"I think it will kill performance: a table of relations longer than resource table itself a couple of times with 2-column index... Imagine what will happen when reseller will add N+1st project :)","commit_id":"ffc25fa539bfa283a8287c66e0cb921a653f4381"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"23fad5102ac47abcaf33d184519a3de52feb3aaf","unresolved":false,"context_lines":[{"line_number":105,"context_line":"Performance Impact"},{"line_number":106,"context_line":"------------------"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Describe any potential performance impact on the system, for example"},{"line_number":109,"context_line":"how often will new code be called, and is there a major change to the calling"},{"line_number":110,"context_line":"pattern of existing code."},{"line_number":111,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aaa499b_04b00f89","line":108,"updated":"2015-04-15 17:54:40.000000000","message":"here you can describe where this approach will improve running time and also where it may have bad performance","commit_id":"ffc25fa539bfa283a8287c66e0cb921a653f4381"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"e03c2c4fe1e5a7e345373587bf1b26186f9144f3","unresolved":false,"context_lines":[{"line_number":105,"context_line":"Performance Impact"},{"line_number":106,"context_line":"------------------"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Describe any potential performance impact on the system, for example"},{"line_number":109,"context_line":"how often will new code be called, and is there a major change to the calling"},{"line_number":110,"context_line":"pattern of existing code."},{"line_number":111,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aa745d1_9db883e7","line":108,"in_reply_to":"7aaa499b_04b00f89","updated":"2015-04-15 18:56:21.000000000","message":"Done","commit_id":"ffc25fa539bfa283a8287c66e0cb921a653f4381"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"23fad5102ac47abcaf33d184519a3de52feb3aaf","unresolved":false,"context_lines":[{"line_number":129,"context_line":"* What config options are being added? Should they be more generic than"},{"line_number":130,"context_line":"  proposed (for example a flag that other hypervisor drivers might want to"},{"line_number":131,"context_line":"  implement as well)? Are the default values ones which will work well in"},{"line_number":132,"context_line":"  real deployments?"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"* Is this a change that takes immediate effect after its merged, or is it"},{"line_number":135,"context_line":"  something that has to be explicitly enabled?"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aaa499b_247aebbd","line":132,"updated":"2015-04-15 17:54:40.000000000","message":"Currently, we limit the depth of the tree to avoid possible \"performance\" issues, maybe we should drop this configuration?","commit_id":"ffc25fa539bfa283a8287c66e0cb921a653f4381"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"e03c2c4fe1e5a7e345373587bf1b26186f9144f3","unresolved":false,"context_lines":[{"line_number":129,"context_line":"* What config options are being added? Should they be more generic than"},{"line_number":130,"context_line":"  proposed (for example a flag that other hypervisor drivers might want to"},{"line_number":131,"context_line":"  implement as well)? Are the default values ones which will work well in"},{"line_number":132,"context_line":"  real deployments?"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"* Is this a change that takes immediate effect after its merged, or is it"},{"line_number":135,"context_line":"  something that has to be explicitly enabled?"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aa745d1_bdaa1f84","line":132,"in_reply_to":"7aaa499b_247aebbd","updated":"2015-04-15 18:56:21.000000000","message":"Done","commit_id":"ffc25fa539bfa283a8287c66e0cb921a653f4381"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"23fad5102ac47abcaf33d184519a3de52feb3aaf","unresolved":false,"context_lines":[{"line_number":169,"context_line":"Primary assignee:"},{"line_number":170,"context_line":"  \u003claunchpad-id or None\u003e"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Other contributors:"},{"line_number":173,"context_line":"  \u003claunchpad-id or None\u003e"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Work Items"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aaa499b_a44cbb9e","line":172,"updated":"2015-04-15 17:54:40.000000000","message":"you can add me (rodrigodsousa) and raildo","commit_id":"ffc25fa539bfa283a8287c66e0cb921a653f4381"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"e03c2c4fe1e5a7e345373587bf1b26186f9144f3","unresolved":false,"context_lines":[{"line_number":169,"context_line":"Primary assignee:"},{"line_number":170,"context_line":"  \u003claunchpad-id or None\u003e"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Other contributors:"},{"line_number":173,"context_line":"  \u003claunchpad-id or None\u003e"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Work Items"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aa745d1_9debe3b0","line":172,"in_reply_to":"7aaa499b_a44cbb9e","updated":"2015-04-15 18:56:21.000000000","message":"Done","commit_id":"ffc25fa539bfa283a8287c66e0cb921a653f4381"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"23fad5102ac47abcaf33d184519a3de52feb3aaf","unresolved":false,"context_lines":[{"line_number":175,"context_line":"Work Items"},{"line_number":176,"context_line":"----------"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Work items or tasks -- break the feature up into the things that need to be"},{"line_number":179,"context_line":"done to implement it. Those parts might end up being done by different people,"},{"line_number":180,"context_line":"but we\u0027re mostly trying to understand the timeline for implementation."},{"line_number":181,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aaa499b_44473777","line":178,"updated":"2015-04-15 17:54:40.000000000","message":"here you can describe how the DB migration will work","commit_id":"ffc25fa539bfa283a8287c66e0cb921a653f4381"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"e03c2c4fe1e5a7e345373587bf1b26186f9144f3","unresolved":false,"context_lines":[{"line_number":175,"context_line":"Work Items"},{"line_number":176,"context_line":"----------"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Work items or tasks -- break the feature up into the things that need to be"},{"line_number":179,"context_line":"done to implement it. Those parts might end up being done by different people,"},{"line_number":180,"context_line":"but we\u0027re mostly trying to understand the timeline for implementation."},{"line_number":181,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aa745d1_7dd137fb","line":178,"in_reply_to":"7aaa499b_44473777","updated":"2015-04-15 18:56:21.000000000","message":"Done","commit_id":"ffc25fa539bfa283a8287c66e0cb921a653f4381"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"c98d2feda545b151ef34ed86a7c2be6692f27dd0","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Materialized path - materialize-project-hierarchy"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp example \u003chttps://blueprints.launchpad.net/keystone/+spec/materialize-project-hierarchy\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"To manage hierarchical multitenancy data effectively the existing adjacency"},{"line_number":14,"context_line":"list paradigm is not enough: recursion is required to traverse the tree."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aa745d1_80d138fe","line":11,"updated":"2015-04-15 19:09:30.000000000","message":"need to replace \"example\" with the name of your spec","commit_id":"2aab026e11902c869249175acfa94fc8d91001d0"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"521c22b71f1cd8e431a4ffb86bcbda8aaaa11732","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Materialized path - materialize-project-hierarchy"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp example \u003chttps://blueprints.launchpad.net/keystone/+spec/materialize-project-hierarchy\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"To manage hierarchical multitenancy data effectively the existing adjacency"},{"line_number":14,"context_line":"list paradigm is not enough: recursion is required to traverse the tree."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aa745d1_e0359cf7","line":11,"in_reply_to":"5aa745d1_80d138fe","updated":"2015-04-15 19:32:00.000000000","message":"Done","commit_id":"2aab026e11902c869249175acfa94fc8d91001d0"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"c98d2feda545b151ef34ed86a7c2be6692f27dd0","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"To manage hierarchical multitenancy data effectively the existing adjacency"},{"line_number":14,"context_line":"list paradigm is not enough: recursion is required to traverse the tree."},{"line_number":15,"context_line":"Materialized path concept allows to find all ascendants, descendants,"},{"line_number":16,"context_line":"children of the node in a single request operation."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aa745d1_a002f46d","line":15,"updated":"2015-04-15 19:09:30.000000000","message":"maybe: The materialised path concept allows you to fine.....","commit_id":"2aab026e11902c869249175acfa94fc8d91001d0"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"521c22b71f1cd8e431a4ffb86bcbda8aaaa11732","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"To manage hierarchical multitenancy data effectively the existing adjacency"},{"line_number":14,"context_line":"list paradigm is not enough: recursion is required to traverse the tree."},{"line_number":15,"context_line":"Materialized path concept allows to find all ascendants, descendants,"},{"line_number":16,"context_line":"children of the node in a single request operation."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aa745d1_402fb0a1","line":15,"in_reply_to":"5aa745d1_a002f46d","updated":"2015-04-15 19:32:00.000000000","message":"Done","commit_id":"2aab026e11902c869249175acfa94fc8d91001d0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"c91b07a543313bf6876b15af05c7863d0914e2f9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Given the project hierarchy as follows:"},{"line_number":22,"context_line":"A -\u003e B -\u003e C -\u003e D"},{"line_number":23,"context_line":"Disabling B project needs to disable all it\u0027s descendants: C and D"},{"line_number":24,"context_line":"So there is a need to check every D-scoped token against all parents"},{"line_number":25,"context_line":"recursively."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aa745d1_40ad7087","line":22,"updated":"2015-04-15 19:02:00.000000000","message":"unnecessary, we can use the tree below as example","commit_id":"2aab026e11902c869249175acfa94fc8d91001d0"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"521c22b71f1cd8e431a4ffb86bcbda8aaaa11732","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Given the project hierarchy as follows:"},{"line_number":22,"context_line":"A -\u003e B -\u003e C -\u003e D"},{"line_number":23,"context_line":"Disabling B project needs to disable all it\u0027s descendants: C and D"},{"line_number":24,"context_line":"So there is a need to check every D-scoped token against all parents"},{"line_number":25,"context_line":"recursively."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aa745d1_6023cc06","line":22,"in_reply_to":"5aa745d1_40ad7087","updated":"2015-04-15 19:32:00.000000000","message":"Done","commit_id":"2aab026e11902c869249175acfa94fc8d91001d0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"c91b07a543313bf6876b15af05c7863d0914e2f9","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Given the project hierarchy as follows:"},{"line_number":22,"context_line":"A -\u003e B -\u003e C -\u003e D"},{"line_number":23,"context_line":"Disabling B project needs to disable all it\u0027s descendants: C and D"},{"line_number":24,"context_line":"So there is a need to check every D-scoped token against all parents"},{"line_number":25,"context_line":"recursively."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aa745d1_a09d545b","line":23,"updated":"2015-04-15 19:02:00.000000000","message":"as per previous patchset, we may avoid citing the disabling as example","commit_id":"2aab026e11902c869249175acfa94fc8d91001d0"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"521c22b71f1cd8e431a4ffb86bcbda8aaaa11732","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Given the project hierarchy as follows:"},{"line_number":22,"context_line":"A -\u003e B -\u003e C -\u003e D"},{"line_number":23,"context_line":"Disabling B project needs to disable all it\u0027s descendants: C and D"},{"line_number":24,"context_line":"So there is a need to check every D-scoped token against all parents"},{"line_number":25,"context_line":"recursively."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aa745d1_4020d0f7","line":23,"in_reply_to":"5aa745d1_a09d545b","updated":"2015-04-15 19:32:00.000000000","message":"Done","commit_id":"2aab026e11902c869249175acfa94fc8d91001d0"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"c98d2feda545b151ef34ed86a7c2be6692f27dd0","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    +------------------------+"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"deleting A project will cause tree traversal accompanied by leaf-by-leaf"},{"line_number":46,"context_line":"deletion."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Proposed Change"},{"line_number":49,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aa745d1_0012c8b4","line":46,"updated":"2015-04-15 19:09:30.000000000","message":"so these seem rare events....what about the normal listing of all sub projects in a list etc. which we support in the API?  I assume it would make those quicker?","commit_id":"2aab026e11902c869249175acfa94fc8d91001d0"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"521c22b71f1cd8e431a4ffb86bcbda8aaaa11732","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    +------------------------+"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"deleting A project will cause tree traversal accompanied by leaf-by-leaf"},{"line_number":46,"context_line":"deletion."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Proposed Change"},{"line_number":49,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aa745d1_03e9b21a","line":46,"in_reply_to":"5aa745d1_0012c8b4","updated":"2015-04-15 19:32:00.000000000","message":"Thanks for the point, adding it!","commit_id":"2aab026e11902c869249175acfa94fc8d91001d0"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"c98d2feda545b151ef34ed86a7c2be6692f27dd0","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"deleting A project will cause tree traversal accompanied by leaf-by-leaf"},{"line_number":46,"context_line":"deletion."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Proposed Change"},{"line_number":49,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aa745d1_204b84b2","line":47,"updated":"2015-04-15 19:09:30.000000000","message":"So I agree that this *could* become an issue.  Do we have any empirical evidence that it is actually a problem we need to solve now?  Do we have example performance stats that show either long request times or swamping of Keystone resources?","commit_id":"2aab026e11902c869249175acfa94fc8d91001d0"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"c98d2feda545b151ef34ed86a7c2be6692f27dd0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    corresponding column value of project in question"},{"line_number":71,"context_line":"  * list_project_parents: pedigree already contains all ancestry chain of id\u0027s"},{"line_number":72,"context_line":"  * is_leaf_project: check if project with pedigree starting with"},{"line_number":73,"context_line":"    corresponding column value of project in question does not exist"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Alternatives"},{"line_number":76,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aa745d1_201dc4bd","line":73,"updated":"2015-04-15 19:09:30.000000000","message":"ahh, right - to my point above..it will help these...maybe one of these would make a better example than delete/disable in the problem description paragraph.","commit_id":"2aab026e11902c869249175acfa94fc8d91001d0"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"521c22b71f1cd8e431a4ffb86bcbda8aaaa11732","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    corresponding column value of project in question"},{"line_number":71,"context_line":"  * list_project_parents: pedigree already contains all ancestry chain of id\u0027s"},{"line_number":72,"context_line":"  * is_leaf_project: check if project with pedigree starting with"},{"line_number":73,"context_line":"    corresponding column value of project in question does not exist"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Alternatives"},{"line_number":76,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aa745d1_c3f2aa06","line":73,"in_reply_to":"5aa745d1_201dc4bd","updated":"2015-04-15 19:32:00.000000000","message":"Done","commit_id":"2aab026e11902c869249175acfa94fc8d91001d0"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"c98d2feda545b151ef34ed86a7c2be6692f27dd0","unresolved":false,"context_lines":[{"line_number":88,"context_line":"`Adjacency matrix \u003chttp://en.wikipedia.org/wiki/Adjacency_matrix\u003e`_ is a"},{"line_number":89,"context_line":"perfect tool to perform a special graph theory calculations and requires"},{"line_number":90,"context_line":"special software to be effective."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Security Impact"},{"line_number":93,"context_line":"---------------"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aa745d1_a0d554ba","line":91,"updated":"2015-04-15 19:09:30.000000000","message":"What about simple caching?  I would think project hierarchies are  relatively stable things (well over the order of minutes, anyway).....could caching be an easier answer?","commit_id":"2aab026e11902c869249175acfa94fc8d91001d0"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"521c22b71f1cd8e431a4ffb86bcbda8aaaa11732","unresolved":false,"context_lines":[{"line_number":88,"context_line":"`Adjacency matrix \u003chttp://en.wikipedia.org/wiki/Adjacency_matrix\u003e`_ is a"},{"line_number":89,"context_line":"perfect tool to perform a special graph theory calculations and requires"},{"line_number":90,"context_line":"special software to be effective."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Security Impact"},{"line_number":93,"context_line":"---------------"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aa745d1_038f7224","line":91,"in_reply_to":"5aa745d1_a0d554ba","updated":"2015-04-15 19:32:00.000000000","message":"Adding as an alternative :)","commit_id":"2aab026e11902c869249175acfa94fc8d91001d0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"c91b07a543313bf6876b15af05c7863d0914e2f9","unresolved":false,"context_lines":[{"line_number":95,"context_line":"Describe any potential security impact on the system.  Some of the items to"},{"line_number":96,"context_line":"consider include:"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":101,"context_line":"  a new way to access sensitive information or a new way to login?"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aa745d1_4076903f","line":98,"updated":"2015-04-15 19:02:00.000000000","message":"you need to either put something here or erase these points","commit_id":"2aab026e11902c869249175acfa94fc8d91001d0"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"521c22b71f1cd8e431a4ffb86bcbda8aaaa11732","unresolved":false,"context_lines":[{"line_number":95,"context_line":"Describe any potential security impact on the system.  Some of the items to"},{"line_number":96,"context_line":"consider include:"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* Does this change touch sensitive data such as tokens, keys, or user data?"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"* Does this change alter the API in a way that may impact security, such as"},{"line_number":101,"context_line":"  a new way to access sensitive information or a new way to login?"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aa745d1_23002eaa","line":98,"in_reply_to":"5aa745d1_4076903f","updated":"2015-04-15 19:32:00.000000000","message":"Done","commit_id":"2aab026e11902c869249175acfa94fc8d91001d0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"c91b07a543313bf6876b15af05c7863d0914e2f9","unresolved":false,"context_lines":[{"line_number":122,"context_line":"--------------------"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Please specify any changes to notifications. Be that an extra notification,"},{"line_number":125,"context_line":"changes to an existing notification, or removing a notification."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Other End User Impact"},{"line_number":128,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aa745d1_e0ba3cc0","line":125,"updated":"2015-04-15 19:02:00.000000000","message":"here too","commit_id":"2aab026e11902c869249175acfa94fc8d91001d0"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"521c22b71f1cd8e431a4ffb86bcbda8aaaa11732","unresolved":false,"context_lines":[{"line_number":122,"context_line":"--------------------"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Please specify any changes to notifications. Be that an extra notification,"},{"line_number":125,"context_line":"changes to an existing notification, or removing a notification."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Other End User Impact"},{"line_number":128,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aa745d1_032c1249","line":125,"in_reply_to":"5aa745d1_e0ba3cc0","updated":"2015-04-15 19:32:00.000000000","message":"Done","commit_id":"2aab026e11902c869249175acfa94fc8d91001d0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"c91b07a543313bf6876b15af05c7863d0914e2f9","unresolved":false,"context_lines":[{"line_number":131,"context_line":"feature?"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"* Does this change have an impact on python-keystoneclient? What does the user"},{"line_number":134,"context_line":"  interface there look like?"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Performance Impact"},{"line_number":137,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aa745d1_c0af407c","line":134,"updated":"2015-04-15 19:02:00.000000000","message":"ditto","commit_id":"2aab026e11902c869249175acfa94fc8d91001d0"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"521c22b71f1cd8e431a4ffb86bcbda8aaaa11732","unresolved":false,"context_lines":[{"line_number":131,"context_line":"feature?"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"* Does this change have an impact on python-keystoneclient? What does the user"},{"line_number":134,"context_line":"  interface there look like?"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Performance Impact"},{"line_number":137,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aa745d1_a32afe2a","line":134,"in_reply_to":"5aa745d1_c0af407c","updated":"2015-04-15 19:32:00.000000000","message":"Done","commit_id":"2aab026e11902c869249175acfa94fc8d91001d0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"c91b07a543313bf6876b15af05c7863d0914e2f9","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"References"},{"line_number":214,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"Please add any useful references here. You are not required to have any"},{"line_number":217,"context_line":"reference. Moreover, this specification should still make sense when your"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aa745d1_e0e11cd2","line":214,"updated":"2015-04-15 19:02:00.000000000","message":"ditto\n\nyou may cite dolphm\u0027s blog post and other references about materialized paths","commit_id":"2aab026e11902c869249175acfa94fc8d91001d0"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"521c22b71f1cd8e431a4ffb86bcbda8aaaa11732","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"References"},{"line_number":214,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"Please add any useful references here. You are not required to have any"},{"line_number":217,"context_line":"reference. Moreover, this specification should still make sense when your"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aa745d1_e36246ad","line":214,"in_reply_to":"5aa745d1_e0e11cd2","updated":"2015-04-15 19:32:00.000000000","message":"Done","commit_id":"2aab026e11902c869249175acfa94fc8d91001d0"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"cee030e8e27e7c24a83a5f4b459c670cd504835a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"children of the node in a single request operation."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem Description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Given the project hierarchy as follows:"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5aa745d1_48369c04","line":19,"updated":"2015-04-16 12:43:53.000000000","message":"Does this not work now or is it inefficient?","commit_id":"5bd5b8fa4a5a148a02561eecf955d5dbd6a90270"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"a7715c459b58c23219ff4f46a487b538475c5985","unresolved":false,"context_lines":[{"line_number":16,"context_line":"children of the node in a single request operation."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem Description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Given the project hierarchy as follows:"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5aa745d1_83d8071f","line":19,"in_reply_to":"5aa745d1_48369c04","updated":"2015-04-16 14:42:36.000000000","message":"Delete operation proposal is currently in progress.","commit_id":"5bd5b8fa4a5a148a02561eecf955d5dbd6a90270"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"cee030e8e27e7c24a83a5f4b459c670cd504835a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"needed to be checked and all descendant projects will have pedigree starting"},{"line_number":58,"context_line":"with pedigree of ancestor."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"This change is proposed to Resource SQL driver as entire HMT is implemented"},{"line_number":61,"context_line":"this way:"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"* Add ``pedigree`` column to Resource model"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5aa745d1_0849b48b","line":60,"updated":"2015-04-16 12:43:53.000000000","message":"You may want to explicitly say that this approach requires a backend that support wildcard index lookups. And we should probably document that somewhere.","commit_id":"5bd5b8fa4a5a148a02561eecf955d5dbd6a90270"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"a7715c459b58c23219ff4f46a487b538475c5985","unresolved":false,"context_lines":[{"line_number":57,"context_line":"needed to be checked and all descendant projects will have pedigree starting"},{"line_number":58,"context_line":"with pedigree of ancestor."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"This change is proposed to Resource SQL driver as entire HMT is implemented"},{"line_number":61,"context_line":"this way:"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"* Add ``pedigree`` column to Resource model"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5aa745d1_ca1dfbbe","line":60,"in_reply_to":"5aa745d1_0849b48b","updated":"2015-04-16 14:42:36.000000000","message":"Done","commit_id":"5bd5b8fa4a5a148a02561eecf955d5dbd6a90270"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"3ed1d9a7b3c1d9bbaf76af0173e1d3150308e79d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"* request of entire project\u0027s \"family\" will require recursion: to get sub-tree"},{"line_number":42,"context_line":"  nodes it will be necessary to construct it from sub-sub trees an so on"},{"line_number":43,"context_line":"  recursively;"},{"line_number":44,"context_line":"* deleting A project will cause tree traversal accompanied by leaf-by-leaf"},{"line_number":45,"context_line":"  deletion: find all sub-tree levels first and then delete required nodes in"},{"line_number":46,"context_line":"  sequence from leaf to root."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3ab451fb_5d9ad015","line":44,"updated":"2015-04-17 18:41:12.000000000","message":"\"deleting a project\"? lower-case A. Or do you mean \"deleting project A\"?","commit_id":"c88a9d75db5a28f7a24192e8c1b44cc7dc36b241"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"980ffff8ea3f2b9e4dd6cf6ee510f0f45607707a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"* request of entire project\u0027s \"family\" will require recursion: to get sub-tree"},{"line_number":42,"context_line":"  nodes it will be necessary to construct it from sub-sub trees an so on"},{"line_number":43,"context_line":"  recursively;"},{"line_number":44,"context_line":"* deleting A project will cause tree traversal accompanied by leaf-by-leaf"},{"line_number":45,"context_line":"  deletion: find all sub-tree levels first and then delete required nodes in"},{"line_number":46,"context_line":"  sequence from leaf to root."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"dac4157f_f8bdffd7","line":44,"in_reply_to":"3ab451fb_5d9ad015","updated":"2015-04-21 15:04:13.000000000","message":"Done","commit_id":"c88a9d75db5a28f7a24192e8c1b44cc7dc36b241"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"3ed1d9a7b3c1d9bbaf76af0173e1d3150308e79d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  * _get_children: to be removed"},{"line_number":69,"context_line":"  * list_projects_in_subtree: all projects having pedigree starting with"},{"line_number":70,"context_line":"  corresponding column value of project in question"},{"line_number":71,"context_line":"  * list_project_parents: pedigree already contains all ancestry chain of id\u0027s"},{"line_number":72,"context_line":"  * is_leaf_project: check if project with pedigree starting with"},{"line_number":73,"context_line":"  corresponding column value of project in question does not exist"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3ab451fb_200ebb34","line":71,"updated":"2015-04-17 18:41:12.000000000","message":"we are returning the project refs of the parents right? not just the IDs. That means we still need to do the lookups. Unless we change the backend SQL to query just the IDs in the pedigree.","commit_id":"c88a9d75db5a28f7a24192e8c1b44cc7dc36b241"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"980ffff8ea3f2b9e4dd6cf6ee510f0f45607707a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  * _get_children: to be removed"},{"line_number":69,"context_line":"  * list_projects_in_subtree: all projects having pedigree starting with"},{"line_number":70,"context_line":"  corresponding column value of project in question"},{"line_number":71,"context_line":"  * list_project_parents: pedigree already contains all ancestry chain of id\u0027s"},{"line_number":72,"context_line":"  * is_leaf_project: check if project with pedigree starting with"},{"line_number":73,"context_line":"  corresponding column value of project in question does not exist"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"dac4157f_18bb13e7","line":71,"in_reply_to":"3ab451fb_200ebb34","updated":"2015-04-21 15:04:13.000000000","message":"Done","commit_id":"c88a9d75db5a28f7a24192e8c1b44cc7dc36b241"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"783804e8b7de62d4753cd5ba49f18ec6c41ea093","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"So every project has it\u0027s pedigree stored that allows to find all projects"},{"line_number":60,"context_line":"needed to be checked and all descendant projects will have pedigree starting"},{"line_number":61,"context_line":"with pedigree of ancestor."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"This change is proposed to Resource SQL driver as entire HMT is implemented"},{"line_number":64,"context_line":"this way:"}],"source_content_type":"text/x-rst","patch_set":9,"id":"dac4157f_47687f87","line":61,"updated":"2015-04-21 18:11:25.000000000","message":"suggest the following:\ns/to find all projects needed to be checked/discovery of all projects needing to be checked,/","commit_id":"afc42ca29e6489957f6ae2b9572baa7bac56dcc5"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"d735c1d9a26e7f88a666024a97226d3994ef7e61","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"So every project has it\u0027s pedigree stored that allows to find all projects"},{"line_number":60,"context_line":"needed to be checked and all descendant projects will have pedigree starting"},{"line_number":61,"context_line":"with pedigree of ancestor."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"This change is proposed to Resource SQL driver as entire HMT is implemented"},{"line_number":64,"context_line":"this way:"}],"source_content_type":"text/x-rst","patch_set":9,"id":"dac4157f_25e9ece6","line":61,"in_reply_to":"dac4157f_47687f87","updated":"2015-04-22 09:36:57.000000000","message":"Done","commit_id":"afc42ca29e6489957f6ae2b9572baa7bac56dcc5"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"783804e8b7de62d4753cd5ba49f18ec6c41ea093","unresolved":false,"context_lines":[{"line_number":84,"context_line":"`Pre-order Tree Traversal \u003chttp://en.wikipedia.org/wiki/Tree_traversal\u003e`_"},{"line_number":85,"context_line":"offers an interesting model allowing compact fields to be used alas many tree"},{"line_number":86,"context_line":"operations involve either complete tree reordering or, at least, comparison"},{"line_number":87,"context_line":"operators performed not using indexes in SQL backends."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"`Adjacency list \u003chttp://en.wikipedia.org/wiki/Adjacency_list\u003e`_ gives the most"},{"line_number":90,"context_line":"flexible way to describe any graph, though in SQL backend it will result in"}],"source_content_type":"text/x-rst","patch_set":9,"id":"dac4157f_e76e73c8","line":87,"updated":"2015-04-21 18:11:25.000000000","message":"The sentence above isn\u0027t clear.  I don\u0027t know if the following suggestion is correct:\n\n... offers an interesting model, allowing compact fields to be used with many tree\toperations.  This involves either complete tree reordering or, at least, comparison operators performed, but it doesn\u0027t use indexes in SQL backends.","commit_id":"afc42ca29e6489957f6ae2b9572baa7bac56dcc5"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"d735c1d9a26e7f88a666024a97226d3994ef7e61","unresolved":false,"context_lines":[{"line_number":84,"context_line":"`Pre-order Tree Traversal \u003chttp://en.wikipedia.org/wiki/Tree_traversal\u003e`_"},{"line_number":85,"context_line":"offers an interesting model allowing compact fields to be used alas many tree"},{"line_number":86,"context_line":"operations involve either complete tree reordering or, at least, comparison"},{"line_number":87,"context_line":"operators performed not using indexes in SQL backends."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"`Adjacency list \u003chttp://en.wikipedia.org/wiki/Adjacency_list\u003e`_ gives the most"},{"line_number":90,"context_line":"flexible way to describe any graph, though in SQL backend it will result in"}],"source_content_type":"text/x-rst","patch_set":9,"id":"dac4157f_a5bdfc69","line":87,"in_reply_to":"dac4157f_e76e73c8","updated":"2015-04-22 09:36:57.000000000","message":"Agreed. I\u0027ve clarified this paragraph a little keeping it as small as possible","commit_id":"afc42ca29e6489957f6ae2b9572baa7bac56dcc5"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"783804e8b7de62d4753cd5ba49f18ec6c41ea093","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"`Adjacency list \u003chttp://en.wikipedia.org/wiki/Adjacency_list\u003e`_ gives the most"},{"line_number":90,"context_line":"flexible way to describe any graph, though in SQL backend it will result in"},{"line_number":91,"context_line":"2-column indexed table of size up to N*(N-1)/2 what will lead to a poor"},{"line_number":92,"context_line":"performance of modification operations."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"`Adjacency matrix \u003chttp://en.wikipedia.org/wiki/Adjacency_matrix\u003e`_ is a"}],"source_content_type":"text/x-rst","patch_set":9,"id":"dac4157f_8ccd9c5f","line":91,"updated":"2015-04-21 18:11:25.000000000","message":"suggested update:\ns/what/that/","commit_id":"afc42ca29e6489957f6ae2b9572baa7bac56dcc5"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"d735c1d9a26e7f88a666024a97226d3994ef7e61","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"`Adjacency list \u003chttp://en.wikipedia.org/wiki/Adjacency_list\u003e`_ gives the most"},{"line_number":90,"context_line":"flexible way to describe any graph, though in SQL backend it will result in"},{"line_number":91,"context_line":"2-column indexed table of size up to N*(N-1)/2 what will lead to a poor"},{"line_number":92,"context_line":"performance of modification operations."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"`Adjacency matrix \u003chttp://en.wikipedia.org/wiki/Adjacency_matrix\u003e`_ is a"}],"source_content_type":"text/x-rst","patch_set":9,"id":"dac4157f_65b7e486","line":91,"in_reply_to":"dac4157f_8ccd9c5f","updated":"2015-04-22 09:36:57.000000000","message":"Done","commit_id":"afc42ca29e6489957f6ae2b9572baa7bac56dcc5"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"783804e8b7de62d4753cd5ba49f18ec6c41ea093","unresolved":false,"context_lines":[{"line_number":96,"context_line":"special software to be effective."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Caching of project structure may be an easier answer for small deployments and"},{"line_number":99,"context_line":"when scalability become an issue the caching system itself can become a complex"},{"line_number":100,"context_line":"solution with it\u0027s own issues."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Security Impact"}],"source_content_type":"text/x-rst","patch_set":9,"id":"dac4157f_0c2f4cf7","line":99,"updated":"2015-04-21 18:11:25.000000000","message":"suggested updates:\ns/become an issue/becomes an issue,/","commit_id":"afc42ca29e6489957f6ae2b9572baa7bac56dcc5"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"d735c1d9a26e7f88a666024a97226d3994ef7e61","unresolved":false,"context_lines":[{"line_number":96,"context_line":"special software to be effective."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Caching of project structure may be an easier answer for small deployments and"},{"line_number":99,"context_line":"when scalability become an issue the caching system itself can become a complex"},{"line_number":100,"context_line":"solution with it\u0027s own issues."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Security Impact"}],"source_content_type":"text/x-rst","patch_set":9,"id":"dac4157f_c5a6b052","line":99,"in_reply_to":"dac4157f_0c2f4cf7","updated":"2015-04-22 09:36:57.000000000","message":"Done","commit_id":"afc42ca29e6489957f6ae2b9572baa7bac56dcc5"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"783804e8b7de62d4753cd5ba49f18ec6c41ea093","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Example::"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"  User\u0027s U role R on project A was revoked. Client authenticated as use U has a"},{"line_number":180,"context_line":"  token scoped to project D. Request to check if token is revoked: revocation"},{"line_number":181,"context_line":"  event with user U, specified role, project in [A, B, D] exists."},{"line_number":182,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"dac4157f_ccaef497","line":179,"updated":"2015-04-21 18:11:25.000000000","message":"recommended update:\ns/use/user/","commit_id":"afc42ca29e6489957f6ae2b9572baa7bac56dcc5"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"d735c1d9a26e7f88a666024a97226d3994ef7e61","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Example::"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"  User\u0027s U role R on project A was revoked. Client authenticated as use U has a"},{"line_number":180,"context_line":"  token scoped to project D. Request to check if token is revoked: revocation"},{"line_number":181,"context_line":"  event with user U, specified role, project in [A, B, D] exists."},{"line_number":182,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"dac4157f_457180df","line":179,"in_reply_to":"dac4157f_ccaef497","updated":"2015-04-22 09:36:57.000000000","message":"Done","commit_id":"afc42ca29e6489957f6ae2b9572baa7bac56dcc5"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"5d33c9b6dce139cac23098c2f0f2a97e60e7e9d5","unresolved":false,"context_lines":[{"line_number":131,"context_line":"Algorithms comparison::"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"  Get parent chain for D using ``parent_id``:"},{"line_number":134,"context_line":"    1. Request parent for D -\u003e B"},{"line_number":135,"context_line":"    2. Request parent for B -\u003e A"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    Total: 2 requests (the deeper the tree the more requests needed)"}],"source_content_type":"text/x-rst","patch_set":11,"id":"dac4157f_9e2a398f","line":134,"updated":"2015-04-22 16:03:00.000000000","message":"if you consider that you already have the D ref here, this request is not necessary. As you are considering in the next example.\n\nBut... this is just a bad example since the request for parents will be node_depth - 1","commit_id":"8e33fb1c08088ee5b72133fc6d474ad92795adcd"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"37df8682d1d715a5ac48523bd4f7bf460f8ed69f","unresolved":false,"context_lines":[{"line_number":131,"context_line":"Algorithms comparison::"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"  Get parent chain for D using ``parent_id``:"},{"line_number":134,"context_line":"    1. Request parent for D -\u003e B"},{"line_number":135,"context_line":"    2. Request parent for B -\u003e A"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    Total: 2 requests (the deeper the tree the more requests needed)"}],"source_content_type":"text/x-rst","patch_set":11,"id":"dac4157f_e8ae16e5","line":134,"in_reply_to":"dac4157f_9e2a398f","updated":"2015-04-22 16:44:48.000000000","message":"I already have D ref - yes, while B and A refs are still to be requested.","commit_id":"8e33fb1c08088ee5b72133fc6d474ad92795adcd"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"5d33c9b6dce139cac23098c2f0f2a97e60e7e9d5","unresolved":false,"context_lines":[{"line_number":156,"context_line":"  Get sub-tree of a node using ``parent_id``:"},{"line_number":157,"context_line":"    1. For each node request all nodes with ``parent_id`` \u003d\u003d node.id"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    Total: 7 reqiests (1 for every node in sub-tree)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  Get sub-tree of a node using ``pedigree``:"},{"line_number":162,"context_line":"    1. Request all nodes with ``pedigree`` starting with node.pedigree"}],"source_content_type":"text/x-rst","patch_set":11,"id":"dac4157f_be04dd17","line":159,"updated":"2015-04-22 16:03:00.000000000","message":"(nit) s/reqiests/requests\n\nactually, this is not true. The BFS operations are done in a single query, so we have a query for each level of the tree (in your example, 2 queries to get A\u0027s subtree).","commit_id":"8e33fb1c08088ee5b72133fc6d474ad92795adcd"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"37df8682d1d715a5ac48523bd4f7bf460f8ed69f","unresolved":false,"context_lines":[{"line_number":156,"context_line":"  Get sub-tree of a node using ``parent_id``:"},{"line_number":157,"context_line":"    1. For each node request all nodes with ``parent_id`` \u003d\u003d node.id"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    Total: 7 reqiests (1 for every node in sub-tree)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  Get sub-tree of a node using ``pedigree``:"},{"line_number":162,"context_line":"    1. Request all nodes with ``pedigree`` starting with node.pedigree"}],"source_content_type":"text/x-rst","patch_set":11,"id":"dac4157f_b5019b08","line":159,"in_reply_to":"dac4157f_be04dd17","updated":"2015-04-22 16:44:48.000000000","message":"Added a note about BFS","commit_id":"8e33fb1c08088ee5b72133fc6d474ad92795adcd"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"82f18ce97ebb5a7a294eefa4105404bebc7a407c","unresolved":false,"context_lines":[{"line_number":162,"context_line":"  Get sub-tree of a node using ``pedigree``:"},{"line_number":163,"context_line":"    1. Request all nodes with ``pedigree`` starting with node.pedigree"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    Total: 1 request (independent of tree depth)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Other Deployer Impact"},{"line_number":168,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"dac4157f_08fcaab6","line":165,"updated":"2015-04-22 16:49:45.000000000","message":"you may add a comparison for delete_domain. If first traverses the tree until find the leaf projects and goes up deleting them.","commit_id":"cbdcd3839a08c372364d89296af14998e7dac2ef"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"30bb53d47e394fd11bb528781903c52650635b3e","unresolved":false,"context_lines":[{"line_number":162,"context_line":"  Get sub-tree of a node using ``pedigree``:"},{"line_number":163,"context_line":"    1. Request all nodes with ``pedigree`` starting with node.pedigree"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    Total: 1 request (independent of tree depth)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Other Deployer Impact"},{"line_number":168,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"dac4157f_28b76ef6","line":165,"in_reply_to":"dac4157f_08fcaab6","updated":"2015-04-22 16:52:11.000000000","message":"good catch, I\u0027ve missed it, thanks!","commit_id":"cbdcd3839a08c372364d89296af14998e7dac2ef"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"d9a3994cfb809f97075237469a26dacc719dff1f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"wildcard search or storing and indexing array fields. So ``pedigree`` column"},{"line_number":78,"context_line":"may either be a text field containing delimiter-separated project id\u0027s or array"},{"line_number":79,"context_line":"of them."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Alternatives"},{"line_number":82,"context_line":"------------"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"bab921fb_e6e9041c","line":80,"updated":"2015-04-23 16:25:16.000000000","message":"I think I am right in saying that we never (with today\u0027s HMT capabilities) have to update the pedigree?  I.e. it is by definition immutable?  This is a good thing, since we do\u0027t need recovery mechanisms if the pedigree could get out of date with a keystone crash at a bad moment.  If, however, we were to support \"move tree\" (i.e. move a sub-tree of projects to a different attach point - something that has been discussed in the past)...then the pedigree would no longer be immutable...and I would worry about the ability to recover from crashes.  If you agree with this analysis, I think we should list this potential complication in this spec somewhere...so we are aware of a potential future restriction.","commit_id":"63b5dc0d75eba101b3736268061ac2fa2bd2c48a"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"dd25fcbcdcf103d22d639eeedb4fe4475d239d88","unresolved":false,"context_lines":[{"line_number":77,"context_line":"wildcard search or storing and indexing array fields. So ``pedigree`` column"},{"line_number":78,"context_line":"may either be a text field containing delimiter-separated project id\u0027s or array"},{"line_number":79,"context_line":"of them."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Alternatives"},{"line_number":82,"context_line":"------------"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"bab921fb_55de106e","line":80,"in_reply_to":"bab921fb_2c947de0","updated":"2015-04-23 17:45:13.000000000","message":"Gentelmen, completely agree about your concern! In the next commit I\u0027ll describe how sub-trees are moved in this model. Of course, there is a trade-off and IMHO it does not add considerable risk.","commit_id":"63b5dc0d75eba101b3736268061ac2fa2bd2c48a"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"880a7dc31dadaeb9cb6f8353d4e4f2d62673cad3","unresolved":false,"context_lines":[{"line_number":77,"context_line":"wildcard search or storing and indexing array fields. So ``pedigree`` column"},{"line_number":78,"context_line":"may either be a text field containing delimiter-separated project id\u0027s or array"},{"line_number":79,"context_line":"of them."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Alternatives"},{"line_number":82,"context_line":"------------"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"bab921fb_2c947de0","line":80,"in_reply_to":"bab921fb_e6e9041c","updated":"2015-04-23 17:04:17.000000000","message":"Henry, yes that\u0027s essentially my concern on Apr 14, patch #2. I am fine with documenting it as a potential risk. But its pretty much a known issue since the beginning.","commit_id":"63b5dc0d75eba101b3736268061ac2fa2bd2c48a"}]}
