)]}'
{"api/v3/identity-api-v3.rst":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"4acf0f1d39e56cff5b9fbb564904c172f4589f8e","unresolved":false,"context_lines":[{"line_number":5134,"context_line":""},{"line_number":5135,"context_line":"- ``effective`` (key only, no value expected)"},{"line_number":5136,"context_line":""},{"line_number":5137,"context_line":"- ``include_subtree`` (key only, no value expected)"},{"line_number":5138,"context_line":""},{"line_number":5139,"context_line":"Get a list of role assignments."},{"line_number":5140,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_1b6d5004","line":5137,"updated":"2015-06-15 10:50:03.000000000","message":"this is somehow controversial for me. Although we have lots of examples of \"key only\" queries in Identity v3 API this does not follow the REST recommendations - as a result, default libraries like Python\u0027s urllib can\u0027t handle such types of queries and we end by using some \"hacks\" in order for it to work in the client side: https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/base.py#L348-L355\n\nI faced this issue when was implementing the query params for the GET /projects API in keystoneclient.","commit_id":"a52a8a60dc8080d9f0a33e72eb79049ffe8823c6"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"60a7994c97a7f75ab500a1e53d3b5970fdb8adf6","unresolved":false,"context_lines":[{"line_number":5134,"context_line":""},{"line_number":5135,"context_line":"- ``effective`` (key only, no value expected)"},{"line_number":5136,"context_line":""},{"line_number":5137,"context_line":"- ``include_subtree`` (key only, no value expected)"},{"line_number":5138,"context_line":""},{"line_number":5139,"context_line":"Get a list of role assignments."},{"line_number":5140,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_3e10de58","line":5137,"in_reply_to":"fa32b979_1b6d5004","updated":"2015-06-17 07:03:41.000000000","message":"interesting....so I can see only two ways round that:\n\n a) make it a boolean (i.e. ?include_subtree\u003dTrue)\n b) make it part of the main url rather than a query parameter, i.e GET /role_assignments/include_subtree?scope.....etc.\n\nimho b) starts to look odd when there are more than one such keyless values (like in this API), so if we really don\u0027t want keyless  values I would say we make them booleans.  However, as you say, we have plenty of these...so do we start now, or change them all together?","commit_id":"a52a8a60dc8080d9f0a33e72eb79049ffe8823c6"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"0e88b75ff8a42720f0330468e7a3803ebd0de374","unresolved":false,"context_lines":[{"line_number":5134,"context_line":""},{"line_number":5135,"context_line":"- ``effective`` (key only, no value expected)"},{"line_number":5136,"context_line":""},{"line_number":5137,"context_line":"- ``include_subtree`` (key only, no value expected)"},{"line_number":5138,"context_line":""},{"line_number":5139,"context_line":"Get a list of role assignments."},{"line_number":5140,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_f6560f29","line":5137,"in_reply_to":"fa32b979_3e10de58","updated":"2015-06-17 12:45:20.000000000","message":"a) is better IMO\n\nI think we can start using them correctly now and create a bug to track all the wrong ones - since the code accepts \"\u003dtrue\" it\u0027s just a documentation bug (but the keystonclient code should be updated).","commit_id":"a52a8a60dc8080d9f0a33e72eb79049ffe8823c6"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"bf3ce36bcfa930075683caa6516964fc36d09e84","unresolved":false,"context_lines":[{"line_number":5134,"context_line":""},{"line_number":5135,"context_line":"- ``effective`` (key only, no value expected)"},{"line_number":5136,"context_line":""},{"line_number":5137,"context_line":"- ``include_subtree`` (key only, no value expected)"},{"line_number":5138,"context_line":""},{"line_number":5139,"context_line":"Get a list of role assignments."},{"line_number":5140,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_3499a57c","line":5137,"in_reply_to":"fa32b979_46892d74","updated":"2015-06-18 07:47:42.000000000","message":"Done","commit_id":"a52a8a60dc8080d9f0a33e72eb79049ffe8823c6"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"13c2f8fc665d53f3cc61ef6fea6287f2ba8b6c36","unresolved":false,"context_lines":[{"line_number":5134,"context_line":""},{"line_number":5135,"context_line":"- ``effective`` (key only, no value expected)"},{"line_number":5136,"context_line":""},{"line_number":5137,"context_line":"- ``include_subtree`` (key only, no value expected)"},{"line_number":5138,"context_line":""},{"line_number":5139,"context_line":"Get a list of role assignments."},{"line_number":5140,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_46892d74","line":5137,"in_reply_to":"fa32b979_f6560f29","updated":"2015-06-17 20:53:57.000000000","message":"a) is better because b) implies a sub-resource and i don\u0027t think this would ever be treated that way. it really is just a filter where the default is to not how the subtree.","commit_id":"a52a8a60dc8080d9f0a33e72eb79049ffe8823c6"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"277e8d02278887453e36dc9b999f5d39b2d5dfcd","unresolved":false,"context_lines":[{"line_number":5135,"context_line":""},{"line_number":5136,"context_line":"- ``effective`` (key only, no value expected)"},{"line_number":5137,"context_line":""},{"line_number":5138,"context_line":"- ``include_subtree`` (boolend, defaults to false)"},{"line_number":5139,"context_line":""},{"line_number":5140,"context_line":"Get a list of role assignments."},{"line_number":5141,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_ed3fe3b1","line":5138,"updated":"2015-06-18 12:43:01.000000000","message":"s/boolend/boolean ?","commit_id":"cf13d9fe95b77c019e065bf0815272a031423172"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"2bf8b693c9a2d0cc1a7340ec18ee542e5c08285f","unresolved":false,"context_lines":[{"line_number":5135,"context_line":""},{"line_number":5136,"context_line":"- ``effective`` (key only, no value expected)"},{"line_number":5137,"context_line":""},{"line_number":5138,"context_line":"- ``include_subtree`` (boolend, defaults to false)"},{"line_number":5139,"context_line":""},{"line_number":5140,"context_line":"Get a list of role assignments."},{"line_number":5141,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_14dafd78","line":5138,"in_reply_to":"fa32b979_ed3fe3b1","updated":"2015-06-20 17:00:23.000000000","message":"Done","commit_id":"cf13d9fe95b77c019e065bf0815272a031423172"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"df8927f34cb754d9fab41cb1891dfb001ed49220","unresolved":false,"context_lines":[{"line_number":5201,"context_line":""},{"line_number":5202,"context_line":"It is also possible to list all role assignmenst within a tree of projects:"},{"line_number":5203,"context_line":""},{"line_number":5204,"context_line":"``GET /role_assignments?scope.project.id\u003d{project_id}?include_subtree\u003dtrue``"},{"line_number":5205,"context_line":"would list all role assignments involving the specified project and all"},{"line_number":5206,"context_line":"sub-projects."},{"line_number":5207,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_2fa4d5b7","line":5204,"updated":"2015-06-18 16:34:00.000000000","message":"Don\u0027t we also need\n\n  GET /role_assignments?scope.domain.id\u003d{domain_id}?include_subtree\u003dtrue\n\nto be backward compatible? Also, I think role assignment look up APIs needs to be expended to be a bit more flexible because the filtering capability is limited today. For example,\n\nLook up role assignments for a given project. This can be called by either domain/project admin.\n\n  GET /projects/{project_id}/role_assignments?include_subtree\u003dtrue\n  GET /domains/id/role_assignments?include_subtree\u003dTrue\n\nLook up role assignments for a given user, filtered by either project/domain id.\n\n  GET /users/{user_id}/role_assignments?scope.project.id\u003d{project_id}\n\nLook up role assignments for a given group, filtered by either project/domain id\n\n  GET /groups/{group_id}/role_assignments?scope.project.id\u003d{project_id}\n\n\nAlso, I think we should get rid of the \u0027effective\u0027 filter. I don\u0027t know if we have a use case where we don\u0027t want the effective role assignments.","commit_id":"cf13d9fe95b77c019e065bf0815272a031423172"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"2bf8b693c9a2d0cc1a7340ec18ee542e5c08285f","unresolved":false,"context_lines":[{"line_number":5201,"context_line":""},{"line_number":5202,"context_line":"It is also possible to list all role assignmenst within a tree of projects:"},{"line_number":5203,"context_line":""},{"line_number":5204,"context_line":"``GET /role_assignments?scope.project.id\u003d{project_id}?include_subtree\u003dtrue``"},{"line_number":5205,"context_line":"would list all role assignments involving the specified project and all"},{"line_number":5206,"context_line":"sub-projects."},{"line_number":5207,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_1448bd2c","line":5204,"in_reply_to":"fa32b979_2fa4d5b7","updated":"2015-06-20 17:00:23.000000000","message":"So assuming we go ahead with the changes for reseller, then since a domain_id will be a project_id (which has is_domain\u003dTrue), then there will be no difference between using a domain_id and a project_id.\n\nIn terms of the other filtering you mention, all those examples are supported today as filters to GET /role_assignments.  The only question is whether we also want to also support them via the urls you mention....I\u0027m open to that if there\u0027s a reason to support it both ways.\n\nIn terms of \u0027effective\u0027, I think there is a need for listing without it....it\u0027s how you can easily list the physical assignments...without supporting this via GET /role_assignments you would have to issue multiple calls to  GET /domains/id/users/id, GET /projects/users/id etc.","commit_id":"cf13d9fe95b77c019e065bf0815272a031423172"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"763f3f78b559fe581cd81431edd9fb4cbb098b09","unresolved":false,"context_lines":[{"line_number":5201,"context_line":""},{"line_number":5202,"context_line":"It is also possible to list all role assignmenst within a tree of projects:"},{"line_number":5203,"context_line":""},{"line_number":5204,"context_line":"``GET /role_assignments?scope.project.id\u003d{project_id}?include_subtree\u003dtrue``"},{"line_number":5205,"context_line":"would list all role assignments involving the specified project and all"},{"line_number":5206,"context_line":"sub-projects."},{"line_number":5207,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_f59f50b2","line":5204,"updated":"2015-06-21 13:46:37.000000000","message":"I believe that it should be documented somewhere that \"include_subtree\" is only valid with \"scope.project.id\"\n\nWhat will the return of calls like:\n\n  GET /role_assignments?include_subtree\u003dtrue\n  GET /role_assignments?user.id\u003d{user_id}\u0026include_subtree\u003dtrue","commit_id":"4db32b744c62eeead01fd349e8015f5f83a7d310"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"7d0123acfe0ad7bf3d22b1d7e3cbe3027823ae1c","unresolved":false,"context_lines":[{"line_number":5201,"context_line":""},{"line_number":5202,"context_line":"It is also possible to list all role assignmenst within a tree of projects:"},{"line_number":5203,"context_line":""},{"line_number":5204,"context_line":"``GET /role_assignments?scope.project.id\u003d{project_id}?include_subtree\u003dtrue``"},{"line_number":5205,"context_line":"would list all role assignments involving the specified project and all"},{"line_number":5206,"context_line":"sub-projects."},{"line_number":5207,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_35037811","line":5204,"in_reply_to":"fa32b979_f59f50b2","updated":"2015-06-21 16:26:13.000000000","message":"Done","commit_id":"4db32b744c62eeead01fd349e8015f5f83a7d310"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ac3201d521dff57a53ed10d27d21614b9d94de1e","unresolved":false,"context_lines":[{"line_number":5199,"context_line":"``GET /role_assignments?scope.project.id\u003d{project_id}`` would list all role"},{"line_number":5200,"context_line":"assignments involving the specified project."},{"line_number":5201,"context_line":""},{"line_number":5202,"context_line":"It is also possible to list all role assignmenst within a tree of projects:"},{"line_number":5203,"context_line":""},{"line_number":5204,"context_line":"``GET /role_assignments?scope.project.id\u003d{project_id}?include_subtree\u003dtrue``"},{"line_number":5205,"context_line":"would list all role assignments involving the specified project and all"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_2907ce82","line":5202,"updated":"2015-06-25 22:13:19.000000000","message":"change \"assignmenst\" to \"assignments\"","commit_id":"d4c7fb6b4d79006cd030000e9535121b14ec921a"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"21f241acdd9c70364594cd2f5a4436d14ad8424f","unresolved":false,"context_lines":[{"line_number":5199,"context_line":"``GET /role_assignments?scope.project.id\u003d{project_id}`` would list all role"},{"line_number":5200,"context_line":"assignments involving the specified project."},{"line_number":5201,"context_line":""},{"line_number":5202,"context_line":"It is also possible to list all role assignmenst within a tree of projects:"},{"line_number":5203,"context_line":""},{"line_number":5204,"context_line":"``GET /role_assignments?scope.project.id\u003d{project_id}?include_subtree\u003dtrue``"},{"line_number":5205,"context_line":"would list all role assignments involving the specified project and all"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_caf3a59e","line":5202,"in_reply_to":"fa32b979_2907ce82","updated":"2015-06-26 08:06:10.000000000","message":"Done","commit_id":"d4c7fb6b4d79006cd030000e9535121b14ec921a"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ac3201d521dff57a53ed10d27d21614b9d94de1e","unresolved":false,"context_lines":[{"line_number":5200,"context_line":"assignments involving the specified project."},{"line_number":5201,"context_line":""},{"line_number":5202,"context_line":"It is also possible to list all role assignmenst within a tree of projects:"},{"line_number":5203,"context_line":""},{"line_number":5204,"context_line":"``GET /role_assignments?scope.project.id\u003d{project_id}?include_subtree\u003dtrue``"},{"line_number":5205,"context_line":"would list all role assignments involving the specified project and all"},{"line_number":5206,"context_line":"sub-projects. ``include_subtree\u003dtrue`` can only be specified in conjunction"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_e9000669","line":5203,"updated":"2015-06-25 22:13:19.000000000","message":"remove the blank line. It\u0027s not clear what the intro sentence is referring to... is it only the next paragraph or all the paragraphs?","commit_id":"d4c7fb6b4d79006cd030000e9535121b14ec921a"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"21f241acdd9c70364594cd2f5a4436d14ad8424f","unresolved":false,"context_lines":[{"line_number":5200,"context_line":"assignments involving the specified project."},{"line_number":5201,"context_line":""},{"line_number":5202,"context_line":"It is also possible to list all role assignmenst within a tree of projects:"},{"line_number":5203,"context_line":""},{"line_number":5204,"context_line":"``GET /role_assignments?scope.project.id\u003d{project_id}?include_subtree\u003dtrue``"},{"line_number":5205,"context_line":"would list all role assignments involving the specified project and all"},{"line_number":5206,"context_line":"sub-projects. ``include_subtree\u003dtrue`` can only be specified in conjunction"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_ca3ac534","line":5203,"in_reply_to":"fa32b979_e9000669","updated":"2015-06-26 08:06:10.000000000","message":"Done","commit_id":"d4c7fb6b4d79006cd030000e9535121b14ec921a"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"af76b4ca8ad7c531712a52d431380a46a516e587","unresolved":false,"context_lines":[{"line_number":5204,"context_line":"``GET /role_assignments?scope.project.id\u003d{project_id}?include_subtree\u003dtrue``"},{"line_number":5205,"context_line":"would list all role assignments involving the specified project and all"},{"line_number":5206,"context_line":"sub-projects. ``include_subtree\u003dtrue`` can only be specified in conjunction"},{"line_number":5207,"context_line":"with ``project.id``, specifiying it without this will result in an HTTP 400"},{"line_number":5208,"context_line":"Bad Request being returned."},{"line_number":5209,"context_line":""},{"line_number":5210,"context_line":"Each role assignment entity in the collection contains a link to the assignment"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_4e63fb41","line":5207,"updated":"2015-06-22 11:35:15.000000000","message":"scope.project.id?","commit_id":"d4c7fb6b4d79006cd030000e9535121b14ec921a"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"21f241acdd9c70364594cd2f5a4436d14ad8424f","unresolved":false,"context_lines":[{"line_number":5204,"context_line":"``GET /role_assignments?scope.project.id\u003d{project_id}?include_subtree\u003dtrue``"},{"line_number":5205,"context_line":"would list all role assignments involving the specified project and all"},{"line_number":5206,"context_line":"sub-projects. ``include_subtree\u003dtrue`` can only be specified in conjunction"},{"line_number":5207,"context_line":"with ``project.id``, specifiying it without this will result in an HTTP 400"},{"line_number":5208,"context_line":"Bad Request being returned."},{"line_number":5209,"context_line":""},{"line_number":5210,"context_line":"Each role assignment entity in the collection contains a link to the assignment"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_6a47f9bc","line":5207,"in_reply_to":"fa32b979_29e02ecc","updated":"2015-06-26 08:06:10.000000000","message":"Done","commit_id":"d4c7fb6b4d79006cd030000e9535121b14ec921a"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ac3201d521dff57a53ed10d27d21614b9d94de1e","unresolved":false,"context_lines":[{"line_number":5204,"context_line":"``GET /role_assignments?scope.project.id\u003d{project_id}?include_subtree\u003dtrue``"},{"line_number":5205,"context_line":"would list all role assignments involving the specified project and all"},{"line_number":5206,"context_line":"sub-projects. ``include_subtree\u003dtrue`` can only be specified in conjunction"},{"line_number":5207,"context_line":"with ``project.id``, specifiying it without this will result in an HTTP 400"},{"line_number":5208,"context_line":"Bad Request being returned."},{"line_number":5209,"context_line":""},{"line_number":5210,"context_line":"Each role assignment entity in the collection contains a link to the assignment"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_29e02ecc","line":5207,"in_reply_to":"fa32b979_4e63fb41","updated":"2015-06-25 22:13:19.000000000","message":"y, it\u0027s scope.project.id above.","commit_id":"d4c7fb6b4d79006cd030000e9535121b14ec921a"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"8d3c6cdc7a22e97c40f3085055465d16f93fa21d","unresolved":false,"context_lines":[{"line_number":5135,"context_line":""},{"line_number":5136,"context_line":"- ``effective`` (key only, no value expected)"},{"line_number":5137,"context_line":""},{"line_number":5138,"context_line":"- ``include_subtree`` (boolean, defaults to false)"},{"line_number":5139,"context_line":""},{"line_number":5140,"context_line":"Get a list of role assignments."},{"line_number":5141,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_e3cfccb1","line":5138,"updated":"2015-06-28 23:39:23.000000000","message":"Add a note that this is new in 3.5","commit_id":"3e2947d0e56470acbd6a22c694e8ffcd50d590b7"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"a8ff2648f52c2022ec987fc96862475af4d3a614","unresolved":false,"context_lines":[{"line_number":5135,"context_line":""},{"line_number":5136,"context_line":"- ``effective`` (key only, no value expected)"},{"line_number":5137,"context_line":""},{"line_number":5138,"context_line":"- ``include_subtree`` (boolean, defaults to false)"},{"line_number":5139,"context_line":""},{"line_number":5140,"context_line":"Get a list of role assignments."},{"line_number":5141,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_638706b6","line":5138,"in_reply_to":"ba3cc151_e3cfccb1","updated":"2015-06-30 04:17:32.000000000","message":"Done","commit_id":"3e2947d0e56470acbd6a22c694e8ffcd50d590b7"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"8d3c6cdc7a22e97c40f3085055465d16f93fa21d","unresolved":false,"context_lines":[{"line_number":5199,"context_line":"``GET /role_assignments?scope.project.id\u003d{project_id}`` would list all role"},{"line_number":5200,"context_line":"assignments involving the specified project."},{"line_number":5201,"context_line":""},{"line_number":5202,"context_line":"It is also possible to list all role assignments within a tree of projects:"},{"line_number":5203,"context_line":"``GET /role_assignments?scope.project.id\u003d{project_id}?include_subtree\u003dtrue``"},{"line_number":5204,"context_line":"would list all role assignments involving the specified project and all"},{"line_number":5205,"context_line":"sub-projects. ``include_subtree\u003dtrue`` can only be specified in conjunction"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_a3c9c4ae","line":5202,"updated":"2015-06-28 23:39:23.000000000","message":"Add a note that this is new in 3.5","commit_id":"3e2947d0e56470acbd6a22c694e8ffcd50d590b7"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"a8ff2648f52c2022ec987fc96862475af4d3a614","unresolved":false,"context_lines":[{"line_number":5199,"context_line":"``GET /role_assignments?scope.project.id\u003d{project_id}`` would list all role"},{"line_number":5200,"context_line":"assignments involving the specified project."},{"line_number":5201,"context_line":""},{"line_number":5202,"context_line":"It is also possible to list all role assignments within a tree of projects:"},{"line_number":5203,"context_line":"``GET /role_assignments?scope.project.id\u003d{project_id}?include_subtree\u003dtrue``"},{"line_number":5204,"context_line":"would list all role assignments involving the specified project and all"},{"line_number":5205,"context_line":"sub-projects. ``include_subtree\u003dtrue`` can only be specified in conjunction"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_83b6ca88","line":5202,"in_reply_to":"ba3cc151_a3c9c4ae","updated":"2015-06-30 04:17:32.000000000","message":"Done","commit_id":"3e2947d0e56470acbd6a22c694e8ffcd50d590b7"}],"specs/liberty/list-assignment-tree.rst":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"93f73f9f9964f0ef3c44d21f341e41e5f7384992","unresolved":false,"context_lines":[{"line_number":11,"context_line":"`bp list-assignment-subtree \u003chttps://blueprints.launchpad.net/keystone/+spec/list-assignment-subtree\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Provide the ability to list assignments for all project in a given tree."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5afe65bd_fc563f05","line":14,"updated":"2015-06-02 00:27:02.000000000","message":"all projects*","commit_id":"3b8752c5e5a183494a545896fbed0dc6e6b80fd4"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"61b30445e31e535af12b55dfdd456717ed44b4a7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"`bp list-assignment-subtree \u003chttps://blueprints.launchpad.net/keystone/+spec/list-assignment-subtree\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Provide the ability to list assignments for all project in a given tree."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3afb71cf_c085d1ad","line":14,"in_reply_to":"5afe65bd_fc563f05","updated":"2015-06-11 22:09:19.000000000","message":"Done","commit_id":"3b8752c5e5a183494a545896fbed0dc6e6b80fd4"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"4bf56a124b8741bcdb2b0a2878929e66d15d4d50","unresolved":false,"context_lines":[{"line_number":34,"context_line":"assignments for those projects within the domain, it is worth first stepping"},{"line_number":35,"context_line":"back and considering this requirement in the light of the changes we are"},{"line_number":36,"context_line":"making to domains and project hierarchies. The proposals being considered"},{"line_number":37,"context_line":"for liberty (which have been discussed at length at the last two summits) is"},{"line_number":38,"context_line":"that a domain becomes a special type of project, and all projects within that"},{"line_number":39,"context_line":"domain are children within that project\u0027s hierarchy. Given this trajectory, it"},{"line_number":40,"context_line":"would seem more appropriate that we provide the ability to list assignments"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5afe65bd_99863db8","line":37,"updated":"2015-06-02 00:22:44.000000000","message":"Liberty","commit_id":"3b8752c5e5a183494a545896fbed0dc6e6b80fd4"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"93f73f9f9964f0ef3c44d21f341e41e5f7384992","unresolved":false,"context_lines":[{"line_number":34,"context_line":"assignments for those projects within the domain, it is worth first stepping"},{"line_number":35,"context_line":"back and considering this requirement in the light of the changes we are"},{"line_number":36,"context_line":"making to domains and project hierarchies. The proposals being considered"},{"line_number":37,"context_line":"for liberty (which have been discussed at length at the last two summits) is"},{"line_number":38,"context_line":"that a domain becomes a special type of project, and all projects within that"},{"line_number":39,"context_line":"domain are children within that project\u0027s hierarchy. Given this trajectory, it"},{"line_number":40,"context_line":"would seem more appropriate that we provide the ability to list assignments"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5afe65bd_3c74d79a","line":37,"updated":"2015-06-02 00:27:02.000000000","message":"s/liberty/Liberty ?","commit_id":"3b8752c5e5a183494a545896fbed0dc6e6b80fd4"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"61b30445e31e535af12b55dfdd456717ed44b4a7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"assignments for those projects within the domain, it is worth first stepping"},{"line_number":35,"context_line":"back and considering this requirement in the light of the changes we are"},{"line_number":36,"context_line":"making to domains and project hierarchies. The proposals being considered"},{"line_number":37,"context_line":"for liberty (which have been discussed at length at the last two summits) is"},{"line_number":38,"context_line":"that a domain becomes a special type of project, and all projects within that"},{"line_number":39,"context_line":"domain are children within that project\u0027s hierarchy. Given this trajectory, it"},{"line_number":40,"context_line":"would seem more appropriate that we provide the ability to list assignments"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3afb71cf_40c0c1e0","line":37,"in_reply_to":"5afe65bd_3c74d79a","updated":"2015-06-11 22:09:19.000000000","message":"Done","commit_id":"3b8752c5e5a183494a545896fbed0dc6e6b80fd4"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"93f73f9f9964f0ef3c44d21f341e41e5f7384992","unresolved":false,"context_lines":[{"line_number":45,"context_line":"a project-related API for domain operations (although we are, of course,"},{"line_number":46,"context_line":"maintaining support for the legacy domain API), as well as provides the ability"},{"line_number":47,"context_line":"for listing assignments for any arbitrary project tree, giving more options to"},{"line_number":48,"context_line":"API clients in how they present keystone objects."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5afe65bd_7c900f96","line":48,"updated":"2015-06-02 00:27:02.000000000","message":"we need to add the details on how it would work if we hit another domain in the subtree.","commit_id":"3b8752c5e5a183494a545896fbed0dc6e6b80fd4"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"61b30445e31e535af12b55dfdd456717ed44b4a7","unresolved":false,"context_lines":[{"line_number":45,"context_line":"a project-related API for domain operations (although we are, of course,"},{"line_number":46,"context_line":"maintaining support for the legacy domain API), as well as provides the ability"},{"line_number":47,"context_line":"for listing assignments for any arbitrary project tree, giving more options to"},{"line_number":48,"context_line":"API clients in how they present keystone objects."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1af86dd1_c31616a7","line":48,"in_reply_to":"5afe65bd_7c900f96","updated":"2015-06-11 22:09:19.000000000","message":"Done","commit_id":"3b8752c5e5a183494a545896fbed0dc6e6b80fd4"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"4bf56a124b8741bcdb2b0a2878929e66d15d4d50","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"We could provide something specific to domains, although other than removing"},{"line_number":55,"context_line":"the dependency on the domain-project integration work already in flight for"},{"line_number":56,"context_line":"liberty, there seems little other advantage."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Data Model Impact"},{"line_number":59,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5afe65bd_b9b0d98c","line":56,"updated":"2015-06-02 00:22:44.000000000","message":"Liberty","commit_id":"3b8752c5e5a183494a545896fbed0dc6e6b80fd4"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"93f73f9f9964f0ef3c44d21f341e41e5f7384992","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"We could provide something specific to domains, although other than removing"},{"line_number":55,"context_line":"the dependency on the domain-project integration work already in flight for"},{"line_number":56,"context_line":"liberty, there seems little other advantage."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Data Model Impact"},{"line_number":59,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5afe65bd_9c650be3","line":56,"updated":"2015-06-02 00:27:02.000000000","message":"same as above","commit_id":"3b8752c5e5a183494a545896fbed0dc6e6b80fd4"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"61b30445e31e535af12b55dfdd456717ed44b4a7","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"We could provide something specific to domains, although other than removing"},{"line_number":55,"context_line":"the dependency on the domain-project integration work already in flight for"},{"line_number":56,"context_line":"liberty, there seems little other advantage."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Data Model Impact"},{"line_number":59,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1af86dd1_83101eaa","line":56,"in_reply_to":"5afe65bd_b9b0d98c","updated":"2015-06-11 22:09:19.000000000","message":"Done","commit_id":"3b8752c5e5a183494a545896fbed0dc6e6b80fd4"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"4bf56a124b8741bcdb2b0a2878929e66d15d4d50","unresolved":false,"context_lines":[{"line_number":58,"context_line":"Data Model Impact"},{"line_number":59,"context_line":"-----------------"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"None"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"REST API Impact"},{"line_number":64,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5afe65bd_5c31d3eb","line":61,"updated":"2015-06-02 00:22:44.000000000","message":"Don\u0027t we need to store the materialized tree in the target column instead of just the domain/project ID? Otherwise, we may need multiple lookups to execute the authorization check.","commit_id":"3b8752c5e5a183494a545896fbed0dc6e6b80fd4"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"61b30445e31e535af12b55dfdd456717ed44b4a7","unresolved":false,"context_lines":[{"line_number":58,"context_line":"Data Model Impact"},{"line_number":59,"context_line":"-----------------"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"None"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"REST API Impact"},{"line_number":64,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1af86dd1_636d2232","line":61,"in_reply_to":"5afe65bd_5c31d3eb","updated":"2015-06-11 22:09:19.000000000","message":"I am proposing a very simple auth check for a first implementation.","commit_id":"3b8752c5e5a183494a545896fbed0dc6e6b80fd4"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"5a3184f2b229735b38b9fab1dd6d2784776e1188","unresolved":false,"context_lines":[{"line_number":69,"context_line":"---------------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Like other \"project tree operations\", we must consider the permissions"},{"line_number":72,"context_line":"required to execute such an API."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Notifications Impact"},{"line_number":75,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_6598bd78","line":72,"updated":"2015-05-31 11:21:04.000000000","message":"I need to think about this and specify how this is done in this spec","commit_id":"3b8752c5e5a183494a545896fbed0dc6e6b80fd4"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"61b30445e31e535af12b55dfdd456717ed44b4a7","unresolved":false,"context_lines":[{"line_number":69,"context_line":"---------------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Like other \"project tree operations\", we must consider the permissions"},{"line_number":72,"context_line":"required to execute such an API."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Notifications Impact"},{"line_number":75,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1af86dd1_467474ce","line":72,"in_reply_to":"5afe65bd_fc7bdf79","updated":"2015-06-11 22:09:19.000000000","message":"I\u0027m proposing the simple approach to start - the API will have its own policy rule.","commit_id":"3b8752c5e5a183494a545896fbed0dc6e6b80fd4"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"93f73f9f9964f0ef3c44d21f341e41e5f7384992","unresolved":false,"context_lines":[{"line_number":69,"context_line":"---------------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Like other \"project tree operations\", we must consider the permissions"},{"line_number":72,"context_line":"required to execute such an API."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Notifications Impact"},{"line_number":75,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5afe65bd_fc7bdf79","line":72,"in_reply_to":"7a016987_6598bd78","updated":"2015-06-02 00:27:02.000000000","message":"++\n\nwe need to consider the case where it is a domain and/or a project. The same approach can be used in the recursive deletion spec as well.","commit_id":"3b8752c5e5a183494a545896fbed0dc6e6b80fd4"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"4bf56a124b8741bcdb2b0a2878929e66d15d4d50","unresolved":false,"context_lines":[{"line_number":69,"context_line":"---------------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Like other \"project tree operations\", we must consider the permissions"},{"line_number":72,"context_line":"required to execute such an API."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Notifications Impact"},{"line_number":75,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5afe65bd_3cff3703","line":72,"in_reply_to":"7a016987_6598bd78","updated":"2015-06-02 00:22:44.000000000","message":"I would think whoever have the permission to assign roles should also have the permission to list the role assignments. Domain/special-project admin should have visible over the entire tree in which they manage.","commit_id":"3b8752c5e5a183494a545896fbed0dc6e6b80fd4"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7b6c905a7efcb00e1fd1d6e713c48f380992abc0","unresolved":false,"context_lines":[{"line_number":75,"context_line":"policy rule than for the regular list assignments rule. This would allow the"},{"line_number":76,"context_line":"API to be permissioned by a role on the root project of the tree upon which the"},{"line_number":77,"context_line":"API was called. This is compatible with the most common use case of this new"},{"line_number":78,"context_line":"API of a domain admin examining the assignments for all projects in a domain."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Notifications Impact"},{"line_number":81,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1af86dd1_a1d08e54","line":78,"updated":"2015-06-12 17:39:01.000000000","message":"How much operator setup would this add to deployments?","commit_id":"a52a8a60dc8080d9f0a33e72eb79049ffe8823c6"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"89ec81199a1ae13c8138ca356af6a806c9ca5670","unresolved":false,"context_lines":[{"line_number":75,"context_line":"policy rule than for the regular list assignments rule. This would allow the"},{"line_number":76,"context_line":"API to be permissioned by a role on the root project of the tree upon which the"},{"line_number":77,"context_line":"API was called. This is compatible with the most common use case of this new"},{"line_number":78,"context_line":"API of a domain admin examining the assignments for all projects in a domain."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Notifications Impact"},{"line_number":81,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_5f73e44d","line":78,"in_reply_to":"1af86dd1_a1d08e54","updated":"2015-06-13 09:26:34.000000000","message":"So by default, I would say the policy rule would say admin required (so nothing to do if that was OK). This could be changed to something like matching the project_id and a named role, or a matching domain_id and role (if you only wanted to allow it for for  whole domain trees, for instance).","commit_id":"a52a8a60dc8080d9f0a33e72eb79049ffe8823c6"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ac3201d521dff57a53ed10d27d21614b9d94de1e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"REST API Impact"},{"line_number":67,"context_line":"---------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"See the API specification modification proposal as part of this review."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Security Impact"},{"line_number":72,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_0910caaa","line":69,"updated":"2015-06-25 22:13:19.000000000","message":"put a short description here so that readers don\u0027t have to find the review.","commit_id":"d4c7fb6b4d79006cd030000e9535121b14ec921a"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"21f241acdd9c70364594cd2f5a4436d14ad8424f","unresolved":false,"context_lines":[{"line_number":66,"context_line":"REST API Impact"},{"line_number":67,"context_line":"---------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"See the API specification modification proposal as part of this review."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Security Impact"},{"line_number":72,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_ca908551","line":69,"in_reply_to":"fa32b979_0910caaa","updated":"2015-06-26 08:06:10.000000000","message":"Done","commit_id":"d4c7fb6b4d79006cd030000e9535121b14ec921a"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ac3201d521dff57a53ed10d27d21614b9d94de1e","unresolved":false,"context_lines":[{"line_number":90,"context_line":"Performance Impact"},{"line_number":91,"context_line":"------------------"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"None"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Other Deployer Impact"},{"line_number":96,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_09776a09","line":93,"updated":"2015-06-25 22:13:19.000000000","message":"really?","commit_id":"d4c7fb6b4d79006cd030000e9535121b14ec921a"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"21f241acdd9c70364594cd2f5a4436d14ad8424f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"Performance Impact"},{"line_number":91,"context_line":"------------------"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"None"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Other Deployer Impact"},{"line_number":96,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_aa93c15b","line":93,"in_reply_to":"fa32b979_09776a09","updated":"2015-06-26 08:06:10.000000000","message":"you could have a point there, guv....I will amend","commit_id":"d4c7fb6b4d79006cd030000e9535121b14ec921a"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ac3201d521dff57a53ed10d27d21614b9d94de1e","unresolved":false,"context_lines":[{"line_number":113,"context_line":"Work Items"},{"line_number":114,"context_line":"----------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"- Get agreement of API specifications"},{"line_number":117,"context_line":"- Implement the new API options"},{"line_number":118,"context_line":"- Add support to keystoneclient library"},{"line_number":119,"context_line":"- Add support to openstack client"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_896b7a1f","line":116,"updated":"2015-06-25 22:13:19.000000000","message":"remove this line","commit_id":"d4c7fb6b4d79006cd030000e9535121b14ec921a"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"21f241acdd9c70364594cd2f5a4436d14ad8424f","unresolved":false,"context_lines":[{"line_number":113,"context_line":"Work Items"},{"line_number":114,"context_line":"----------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"- Get agreement of API specifications"},{"line_number":117,"context_line":"- Implement the new API options"},{"line_number":118,"context_line":"- Add support to keystoneclient library"},{"line_number":119,"context_line":"- Add support to openstack client"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa32b979_0aae6d98","line":116,"in_reply_to":"fa32b979_896b7a1f","updated":"2015-06-26 08:06:10.000000000","message":"Done","commit_id":"d4c7fb6b4d79006cd030000e9535121b14ec921a"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"8d3c6cdc7a22e97c40f3085055465d16f93fa21d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"---------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"To provide the API, an additional query parameter will be added to the"},{"line_number":70,"context_line":"``GET /role_assignments`` call. See the API specification modification proposal"},{"line_number":71,"context_line":"as part of this review."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Security Impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_23e7f441","line":70,"updated":"2015-06-28 23:39:23.000000000","message":"Just say what the query parameter is, no need to be coy.","commit_id":"3e2947d0e56470acbd6a22c694e8ffcd50d590b7"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"a8ff2648f52c2022ec987fc96862475af4d3a614","unresolved":false,"context_lines":[{"line_number":67,"context_line":"---------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"To provide the API, an additional query parameter will be added to the"},{"line_number":70,"context_line":"``GET /role_assignments`` call. See the API specification modification proposal"},{"line_number":71,"context_line":"as part of this review."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Security Impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_0382ba94","line":70,"in_reply_to":"ba3cc151_23e7f441","updated":"2015-06-30 04:17:32.000000000","message":"Done","commit_id":"3e2947d0e56470acbd6a22c694e8ffcd50d590b7"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"8d3c6cdc7a22e97c40f3085055465d16f93fa21d","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"To provide the API, an additional query parameter will be added to the"},{"line_number":70,"context_line":"``GET /role_assignments`` call. See the API specification modification proposal"},{"line_number":71,"context_line":"as part of this review."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Security Impact"},{"line_number":74,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_c3f728f4","line":71,"updated":"2015-06-28 23:39:23.000000000","message":"remove this sentence since it\u0027s not going to make sense once this is merged.","commit_id":"3e2947d0e56470acbd6a22c694e8ffcd50d590b7"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"a8ff2648f52c2022ec987fc96862475af4d3a614","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"To provide the API, an additional query parameter will be added to the"},{"line_number":70,"context_line":"``GET /role_assignments`` call. See the API specification modification proposal"},{"line_number":71,"context_line":"as part of this review."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Security Impact"},{"line_number":74,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_c34a9283","line":71,"in_reply_to":"ba3cc151_c3f728f4","updated":"2015-06-30 04:17:32.000000000","message":"Done","commit_id":"3e2947d0e56470acbd6a22c694e8ffcd50d590b7"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"55bb6094e9de30f1a4fa9358b41818a7b8e730c4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"REST API Impact"},{"line_number":67,"context_line":"---------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"To provide the API, an additional query parameter (``include_subtree``) will"},{"line_number":70,"context_line":"be added to the ``GET /role_assignments`` call."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Security Impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba3cc151_1473a84e","line":69,"updated":"2015-06-30 19:55:01.000000000","message":"What the purpose of requesting role assignments on the parent project not including it\u0027s subtree?\nWhy not decide it on the server side?","commit_id":"5f2f480992ec763e967df045b4399d252406ad24"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"1de51889a45c318a6588f7aaac75e725fbed20ef","unresolved":false,"context_lines":[{"line_number":66,"context_line":"REST API Impact"},{"line_number":67,"context_line":"---------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"To provide the API, an additional query parameter (``include_subtree``) will"},{"line_number":70,"context_line":"be added to the ``GET /role_assignments`` call."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Security Impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba3cc151_3a4d753e","line":69,"in_reply_to":"ba3cc151_1473a84e","updated":"2015-06-30 20:24:59.000000000","message":"Well, that\u0027s what we have today. You get the role assignment that are on that specific project (only). I\u0027m not sure what you mean \"decide it on the server side\"?","commit_id":"5f2f480992ec763e967df045b4399d252406ad24"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"7300ccaad3183bea1b4769606c2df61504c6577b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"REST API Impact"},{"line_number":67,"context_line":"---------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"To provide the API, an additional query parameter (``include_subtree``) will"},{"line_number":70,"context_line":"be added to the ``GET /role_assignments`` call."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Security Impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba3cc151_dd3563f7","line":69,"in_reply_to":"ba3cc151_3a4d753e","updated":"2015-06-30 20:52:38.000000000","message":"keystone server holds the project record as well as all it\u0027s descendants, so the decision whether to include subtree or not can be made based on the information whether the project has descendants or not.\nMy question is: why not return role assignments including subtree by default? Leaf projects will still yield their own assignments as they are, while parent projects will behave as subtrees by default.\nIs there a use case, when parent project\u0027s own assignments only (without subtree) are needed?","commit_id":"5f2f480992ec763e967df045b4399d252406ad24"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"769a034aa1fec242628f7568b41e9bf50575d9b7","unresolved":false,"context_lines":[{"line_number":66,"context_line":"REST API Impact"},{"line_number":67,"context_line":"---------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"To provide the API, an additional query parameter (``include_subtree``) will"},{"line_number":70,"context_line":"be added to the ``GET /role_assignments`` call."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Security Impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba3cc151_11fbafc2","line":69,"in_reply_to":"ba3cc151_4e0e7b3c","updated":"2015-06-30 23:19:41.000000000","message":"So there actually is a use case.","commit_id":"5f2f480992ec763e967df045b4399d252406ad24"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"d4670aac4e1818dfea52162e1a10401d5e4ab57b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"REST API Impact"},{"line_number":67,"context_line":"---------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"To provide the API, an additional query parameter (``include_subtree``) will"},{"line_number":70,"context_line":"be added to the ``GET /role_assignments`` call."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Security Impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba3cc151_4e0e7b3c","line":69,"in_reply_to":"ba3cc151_dd3563f7","updated":"2015-06-30 21:52:39.000000000","message":"So yes, the current API requires exactly that - to only return the parent project\u0027s own assignments.  I\u0027m not sure why we would return all this info when most of the time people won\u0027t want it - I expect the use of this new query parameter to be the exception rather than the rule.","commit_id":"5f2f480992ec763e967df045b4399d252406ad24"}]}
