)]}'
{"specs/keystone/newton/credential-encryption.rst":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"445396fd9aaaa3c53aa81e8973161c154df7856a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"the ``credential`` table.  Given that there are viable ``secret`` providers out"},{"line_number":31,"context_line":"there (Barbican, cryptography, etc) The choice of encryption solution should be"},{"line_number":32,"context_line":"pluggable.  A single key will be used to encrypt the credentials using a"},{"line_number":33,"context_line":"different salt for each credential.  Key management will be facilitated by"},{"line_number":34,"context_line":"allowing multiple keys for decryption and a single active key for encryption."},{"line_number":35,"context_line":"All credentials will be encrypted.  Key rotation will be done side band."},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_d7397443","line":33,"updated":"2016-05-05 21:39:39.000000000","message":"Is keystone going to manage the salts, regardless of the pluggable encryption solution in use? If so, where will salts be stored and how are they used in concert with the encryption plugin? I\u0027ve never used salts outside of hashing, so this isn\u0027t a pattern I\u0027m familiar with :(","commit_id":"1c0774e8773ec6e071a5f2bbf3d2960cad910f8c"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"f41555b4731c7c7705c8900145937c994f23f91c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"the ``credential`` table.  Given that there are viable ``secret`` providers out"},{"line_number":31,"context_line":"there (Barbican, cryptography, etc) The choice of encryption solution should be"},{"line_number":32,"context_line":"pluggable.  A single key will be used to encrypt the credentials using a"},{"line_number":33,"context_line":"different salt for each credential.  Key management will be facilitated by"},{"line_number":34,"context_line":"allowing multiple keys for decryption and a single active key for encryption."},{"line_number":35,"context_line":"All credentials will be encrypted.  Key rotation will be done side band."},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_402c6f4a","line":33,"in_reply_to":"dab17558_d7397443","updated":"2016-05-06 18:47:42.000000000","message":"Done","commit_id":"1c0774e8773ec6e071a5f2bbf3d2960cad910f8c"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"445396fd9aaaa3c53aa81e8973161c154df7856a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"there (Barbican, cryptography, etc) The choice of encryption solution should be"},{"line_number":32,"context_line":"pluggable.  A single key will be used to encrypt the credentials using a"},{"line_number":33,"context_line":"different salt for each credential.  Key management will be facilitated by"},{"line_number":34,"context_line":"allowing multiple keys for decryption and a single active key for encryption."},{"line_number":35,"context_line":"All credentials will be encrypted.  Key rotation will be done side band."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_f7e758aa","line":34,"updated":"2016-05-05 21:39:39.000000000","message":"Encrypted blobs will never be exposed to end users, correct? Would you ever need more than 2 keys?","commit_id":"1c0774e8773ec6e071a5f2bbf3d2960cad910f8c"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"f41555b4731c7c7705c8900145937c994f23f91c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"there (Barbican, cryptography, etc) The choice of encryption solution should be"},{"line_number":32,"context_line":"pluggable.  A single key will be used to encrypt the credentials using a"},{"line_number":33,"context_line":"different salt for each credential.  Key management will be facilitated by"},{"line_number":34,"context_line":"allowing multiple keys for decryption and a single active key for encryption."},{"line_number":35,"context_line":"All credentials will be encrypted.  Key rotation will be done side band."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_602b7331","line":34,"in_reply_to":"dab17558_f7e758aa","updated":"2016-05-06 18:47:42.000000000","message":"Done","commit_id":"1c0774e8773ec6e071a5f2bbf3d2960cad910f8c"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"445396fd9aaaa3c53aa81e8973161c154df7856a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"pluggable.  A single key will be used to encrypt the credentials using a"},{"line_number":33,"context_line":"different salt for each credential.  Key management will be facilitated by"},{"line_number":34,"context_line":"allowing multiple keys for decryption and a single active key for encryption."},{"line_number":35,"context_line":"All credentials will be encrypted.  Key rotation will be done side band."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_977d2cea","line":35,"updated":"2016-05-05 21:39:39.000000000","message":"It might be worth mentioning that none of this is per-tenant, but explicitly mention that keys are deployment-wide.","commit_id":"1c0774e8773ec6e071a5f2bbf3d2960cad910f8c"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"f41555b4731c7c7705c8900145937c994f23f91c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"pluggable.  A single key will be used to encrypt the credentials using a"},{"line_number":33,"context_line":"different salt for each credential.  Key management will be facilitated by"},{"line_number":34,"context_line":"allowing multiple keys for decryption and a single active key for encryption."},{"line_number":35,"context_line":"All credentials will be encrypted.  Key rotation will be done side band."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_85fe6969","line":35,"in_reply_to":"dab17558_977d2cea","updated":"2016-05-06 18:47:42.000000000","message":"Done","commit_id":"1c0774e8773ec6e071a5f2bbf3d2960cad910f8c"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"445396fd9aaaa3c53aa81e8973161c154df7856a","unresolved":false,"context_lines":[{"line_number":58,"context_line":"Performance Impact"},{"line_number":59,"context_line":"------------------"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Encryption could decrease performance."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Other Deployer Impact"},{"line_number":64,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_d7e17400","line":61,"updated":"2016-05-05 21:39:39.000000000","message":"nit: s/could/will/","commit_id":"1c0774e8773ec6e071a5f2bbf3d2960cad910f8c"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"f41555b4731c7c7705c8900145937c994f23f91c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"Performance Impact"},{"line_number":59,"context_line":"------------------"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Encryption could decrease performance."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Other Deployer Impact"},{"line_number":64,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_c502313e","line":61,"in_reply_to":"dab17558_d7e17400","updated":"2016-05-06 18:47:42.000000000","message":"Done","commit_id":"1c0774e8773ec6e071a5f2bbf3d2960cad910f8c"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"445396fd9aaaa3c53aa81e8973161c154df7856a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"Other Deployer Impact"},{"line_number":64,"context_line":"---------------------"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Deployers will need to manage the keys."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Developer Impact"},{"line_number":69,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_f7b5987e","line":66,"updated":"2016-05-05 21:39:39.000000000","message":"Where will keys be managed? How much effort will it take to manage them?","commit_id":"1c0774e8773ec6e071a5f2bbf3d2960cad910f8c"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"f41555b4731c7c7705c8900145937c994f23f91c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"Other Deployer Impact"},{"line_number":64,"context_line":"---------------------"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Deployers will need to manage the keys."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Developer Impact"},{"line_number":69,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_004c276f","line":66,"in_reply_to":"dab17558_f7b5987e","updated":"2016-05-06 18:47:42.000000000","message":"Done","commit_id":"1c0774e8773ec6e071a5f2bbf3d2960cad910f8c"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"445396fd9aaaa3c53aa81e8973161c154df7856a","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"* Update credentials driver to support encryption."},{"line_number":86,"context_line":"* Document Credential driver configuration changes."},{"line_number":87,"context_line":"* Write Keystone database migration for existing credentials."},{"line_number":88,"context_line":"* Write test to verify functionality."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_37956040","line":87,"updated":"2016-05-05 21:39:39.000000000","message":"If a deployer does not configure keystone with a set of keys prior to running migrations, what will the data migration do? Nothing? Abort / fail? Does it matter if there are credentials already in the backend or not?","commit_id":"1c0774e8773ec6e071a5f2bbf3d2960cad910f8c"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"f41555b4731c7c7705c8900145937c994f23f91c","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"* Update credentials driver to support encryption."},{"line_number":86,"context_line":"* Document Credential driver configuration changes."},{"line_number":87,"context_line":"* Write Keystone database migration for existing credentials."},{"line_number":88,"context_line":"* Write test to verify functionality."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_001b871c","line":87,"in_reply_to":"dab17558_37956040","updated":"2016-05-06 18:47:42.000000000","message":"Done","commit_id":"1c0774e8773ec6e071a5f2bbf3d2960cad910f8c"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"445396fd9aaaa3c53aa81e8973161c154df7856a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"* Update credentials driver to support encryption."},{"line_number":86,"context_line":"* Document Credential driver configuration changes."},{"line_number":87,"context_line":"* Write Keystone database migration for existing credentials."},{"line_number":88,"context_line":"* Write test to verify functionality."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Dependencies"},{"line_number":91,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_d7ba146e","line":88,"updated":"2016-05-05 21:39:39.000000000","message":"Hopefully: testS!","commit_id":"1c0774e8773ec6e071a5f2bbf3d2960cad910f8c"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"f41555b4731c7c7705c8900145937c994f23f91c","unresolved":false,"context_lines":[{"line_number":85,"context_line":"* Update credentials driver to support encryption."},{"line_number":86,"context_line":"* Document Credential driver configuration changes."},{"line_number":87,"context_line":"* Write Keystone database migration for existing credentials."},{"line_number":88,"context_line":"* Write test to verify functionality."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Dependencies"},{"line_number":91,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_203ccb92","line":88,"in_reply_to":"dab17558_d7ba146e","updated":"2016-05-06 18:47:42.000000000","message":"Done","commit_id":"1c0774e8773ec6e071a5f2bbf3d2960cad910f8c"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"445396fd9aaaa3c53aa81e8973161c154df7856a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"Dependencies"},{"line_number":91,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"* cryptography library for encryption."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Documentation Impact"},{"line_number":96,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_77aa481b","line":93,"updated":"2016-05-05 21:39:39.000000000","message":"It\u0027s going to be pluggable, but I assume this means Fernet will be the default encryption plugin?","commit_id":"1c0774e8773ec6e071a5f2bbf3d2960cad910f8c"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"f41555b4731c7c7705c8900145937c994f23f91c","unresolved":false,"context_lines":[{"line_number":90,"context_line":"Dependencies"},{"line_number":91,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"* cryptography library for encryption."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Documentation Impact"},{"line_number":96,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_000427be","line":93,"in_reply_to":"dab17558_77aa481b","updated":"2016-05-06 18:47:42.000000000","message":"Done","commit_id":"1c0774e8773ec6e071a5f2bbf3d2960cad910f8c"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"54ed87d211a2c88d237ee1ae8e679e40e8f3d63c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"pluggable.  A single key will be used to encrypt the credentials."},{"line_number":33,"context_line":"Key management will be facilitated by allowing two active keys for decryption"},{"line_number":34,"context_line":"and a single active key for encryption.  All credentials will be encrypted."},{"line_number":35,"context_line":"Key rotation will be done side band.  Keys are deployment wide."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_2ebac70a","line":35,"range":{"start_line":35,"start_character":62,"end_line":35,"end_character":63},"updated":"2016-05-13 18:58:53.000000000","message":"I presume we only re-encrypt the credential upon access, after a key rotation? In other words, if the credential hasn\u0027t been access for awhile (like weeks), and the key rotation happens on a weekly basis, that credential will be useless. Perhaps we need credential TTL (i.e. expiration) which enable deployers to sync up with their key rotation strategy.","commit_id":"204f491f763df423bcf276483b78a489a53e1e9f"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"0a36c00d8d46cf30d3976ee54b80298ba6c3f0b5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"pluggable.  A single key will be used to encrypt the credentials."},{"line_number":33,"context_line":"Key management will be facilitated by allowing two active keys for decryption"},{"line_number":34,"context_line":"and a single active key for encryption.  All credentials will be encrypted."},{"line_number":35,"context_line":"Key rotation will be done side band.  Keys are deployment wide."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9abb7d3a_f075fa97","line":35,"range":{"start_line":35,"start_character":62,"end_line":35,"end_character":63},"in_reply_to":"dab17558_2ebac70a","updated":"2016-05-31 19:05:38.000000000","message":"There is a command that was added to keystone-manage that allows re-encryption of existing credentials.\n\nhttps://review.openstack.org/#/c/317169/","commit_id":"204f491f763df423bcf276483b78a489a53e1e9f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"ba618dea900fe50768c2716a2727ecd6682222ad","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Alternatives"},{"line_number":39,"context_line":"------------"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Barbican"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Security Impact"},{"line_number":44,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bab6814e_72957031","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":8},"updated":"2016-05-22 02:09:46.000000000","message":"Barbican would be better imo than this spec.","commit_id":"204f491f763df423bcf276483b78a489a53e1e9f"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"0a36c00d8d46cf30d3976ee54b80298ba6c3f0b5","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Alternatives"},{"line_number":39,"context_line":"------------"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Barbican"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Security Impact"},{"line_number":44,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9abb7d3a_b08ed276","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":8},"in_reply_to":"bab6814e_72957031","updated":"2016-05-31 19:05:38.000000000","message":"I agree, but meanwhile credentials are stored in Keystone they should not be in plain text.","commit_id":"204f491f763df423bcf276483b78a489a53e1e9f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"ba618dea900fe50768c2716a2727ecd6682222ad","unresolved":false,"context_lines":[{"line_number":86,"context_line":"* Update credentials driver to support encryption."},{"line_number":87,"context_line":"* Document Credential driver configuration changes."},{"line_number":88,"context_line":"* Write Keystone database migration for existing credentials.  If deployer has"},{"line_number":89,"context_line":"  not specified encryption keys, migration will abort."},{"line_number":90,"context_line":"* Write tests to verify functionality."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bab6814e_b29b5865","line":89,"range":{"start_line":89,"start_character":33,"end_line":89,"end_character":53},"updated":"2016-05-22 02:09:46.000000000","message":"Migration should *not* abort. Encryption should be opt in. I still view barbican as a better choice and deprecating the credential store in keystone.","commit_id":"204f491f763df423bcf276483b78a489a53e1e9f"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"0a36c00d8d46cf30d3976ee54b80298ba6c3f0b5","unresolved":false,"context_lines":[{"line_number":86,"context_line":"* Update credentials driver to support encryption."},{"line_number":87,"context_line":"* Document Credential driver configuration changes."},{"line_number":88,"context_line":"* Write Keystone database migration for existing credentials.  If deployer has"},{"line_number":89,"context_line":"  not specified encryption keys, migration will abort."},{"line_number":90,"context_line":"* Write tests to verify functionality."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9abb7d3a_50dcc672","line":89,"range":{"start_line":89,"start_character":33,"end_line":89,"end_character":53},"in_reply_to":"bab6814e_b29b5865","updated":"2016-05-31 19:05:38.000000000","message":"Done","commit_id":"204f491f763df423bcf276483b78a489a53e1e9f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"67e77871b6441f2f3d698b0d67dc6e83b3ed5a64","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"* Update credentials driver to support encryption."},{"line_number":87,"context_line":"* Document Credential driver configuration changes."},{"line_number":88,"context_line":"* Write Keystone database migration for existing credentials.  If deployer has"},{"line_number":89,"context_line":"  not specified encryption keys, migration will not re-encrypt the credentials."},{"line_number":90,"context_line":"* Write tests to verify functionality."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9abb7d3a_c344444b","line":89,"range":{"start_line":88,"start_character":2,"end_line":89,"end_character":79},"updated":"2016-06-01 14:34:48.000000000","message":"I am generally ok with this now, but I would encourage this to *not* be a migration at all. Just don\u0027t make this part of the migration path. Make it a keystone-manage only command to re-encrypt.\n\nAdding complexity into a migration is a recipe for ugly side effects.","commit_id":"08e2eff768b2e4a8c687cd92875c5f3909c37335"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"18e5f6c0ea770b9c61c4e89b7eb239fe92bc9468","unresolved":false,"context_lines":[{"line_number":86,"context_line":"* Update credentials driver to support encryption."},{"line_number":87,"context_line":"* Document Credential driver configuration changes."},{"line_number":88,"context_line":"* Write Keystone database migration for existing credentials.  If deployer has"},{"line_number":89,"context_line":"  not specified encryption keys, migration will not re-encrypt the credentials."},{"line_number":90,"context_line":"* Write tests to verify functionality."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9abb7d3a_52f6498f","line":89,"in_reply_to":"9abb7d3a_beb31397","updated":"2016-06-01 20:27:30.000000000","message":"++ you\u0027re both describing the implementation in review here: https://review.openstack.org/#/c/317169/","commit_id":"08e2eff768b2e4a8c687cd92875c5f3909c37335"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"579a067bf47b94678572bdc8da3b620f6dbc3da7","unresolved":false,"context_lines":[{"line_number":86,"context_line":"* Update credentials driver to support encryption."},{"line_number":87,"context_line":"* Document Credential driver configuration changes."},{"line_number":88,"context_line":"* Write Keystone database migration for existing credentials.  If deployer has"},{"line_number":89,"context_line":"  not specified encryption keys, migration will not re-encrypt the credentials."},{"line_number":90,"context_line":"* Write tests to verify functionality."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9abb7d3a_c8f3a571","line":89,"in_reply_to":"9abb7d3a_beb31397","updated":"2016-06-01 23:15:01.000000000","message":"Correct. You\u0027re spot on, and it looks like there is no DB migration in the CR.\n\nI am saying eliminate the implication in the spec (as a followup) that it does encryption as part of db_sync. \n\nCorrect phrasing here: Document upgrade process and how to enable encryption.","commit_id":"08e2eff768b2e4a8c687cd92875c5f3909c37335"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6a3e0854bcbf08872f2c9692f8ea8d706705d855","unresolved":false,"context_lines":[{"line_number":86,"context_line":"* Update credentials driver to support encryption."},{"line_number":87,"context_line":"* Document Credential driver configuration changes."},{"line_number":88,"context_line":"* Write Keystone database migration for existing credentials.  If deployer has"},{"line_number":89,"context_line":"  not specified encryption keys, migration will not re-encrypt the credentials."},{"line_number":90,"context_line":"* Write tests to verify functionality."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9abb7d3a_beb31397","line":89,"in_reply_to":"9abb7d3a_c344444b","updated":"2016-06-01 14:58:12.000000000","message":"So this will essentially be a two-step migration where the first part is running the database migration script and the second part is re-encrypting the credentials using keystone-manage? \n\nI don\u0027t have a problem with that, it does make the migration code simpler. We will just need to make sure it is documented really well. We could even do a comparison in the credential backend to determine if the credential is encrypted or not and if it isn\u0027t we should log a warning.","commit_id":"08e2eff768b2e4a8c687cd92875c5f3909c37335"}],"specs/ongoing/credential-encryption.rst":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"0b8a720fbfb14ba2a255abd2bd183b2624037c38","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Update the credentials driver to support encryption of the ``blob`` field in"},{"line_number":30,"context_line":"the ``credential`` table.  Support having both encrypted and unencrypted"},{"line_number":31,"context_line":"``blob`` fields for backwards compatibility.  Optionally use Barbican to store"},{"line_number":32,"context_line":"credentials or encryption key."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_4dc0cfe0","line":30,"updated":"2016-04-06 00:26:41.000000000","message":"Given that there are other viable \"secret\" providers out there (Barbican, cryptography, etc) -- the choice of encryption solution should be pluggable -- not directly integrated into the credential backend.","commit_id":"c8401e4d5c2f2c4589633b76a3ffdfa5a53f5885"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"a361c43e6ccc30ebb2584a296635b8d0551ab773","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Update the credentials driver to support encryption of the ``blob`` field in"},{"line_number":30,"context_line":"the ``credential`` table.  Support having both encrypted and unencrypted"},{"line_number":31,"context_line":"``blob`` fields for backwards compatibility.  Optionally use Barbican to store"},{"line_number":32,"context_line":"credentials or encryption key."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_772f2c88","line":30,"in_reply_to":"9a061dce_4dc0cfe0","updated":"2016-04-06 18:51:11.000000000","message":"Done","commit_id":"c8401e4d5c2f2c4589633b76a3ffdfa5a53f5885"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"0b8a720fbfb14ba2a255abd2bd183b2624037c38","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Update the credentials driver to support encryption of the ``blob`` field in"},{"line_number":30,"context_line":"the ``credential`` table.  Support having both encrypted and unencrypted"},{"line_number":31,"context_line":"``blob`` fields for backwards compatibility.  Optionally use Barbican to store"},{"line_number":32,"context_line":"credentials or encryption key."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_ad452b71","line":31,"updated":"2016-04-06 00:26:41.000000000","message":"Why do some need to remain in plain text? What are we being backwards compatible with? The credential manager should always return them in plain text, either way, right? This spec has no API impact.","commit_id":"c8401e4d5c2f2c4589633b76a3ffdfa5a53f5885"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"a361c43e6ccc30ebb2584a296635b8d0551ab773","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Update the credentials driver to support encryption of the ``blob`` field in"},{"line_number":30,"context_line":"the ``credential`` table.  Support having both encrypted and unencrypted"},{"line_number":31,"context_line":"``blob`` fields for backwards compatibility.  Optionally use Barbican to store"},{"line_number":32,"context_line":"credentials or encryption key."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_2c5d6b47","line":31,"in_reply_to":"9a061dce_ad452b71","updated":"2016-04-06 18:51:11.000000000","message":"Done","commit_id":"c8401e4d5c2f2c4589633b76a3ffdfa5a53f5885"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"3e91dc14c3ee4a5003fe76717a5b490fa05c9882","unresolved":false,"context_lines":[{"line_number":30,"context_line":"the ``credential`` table.  Support having both encrypted and unencrypted"},{"line_number":31,"context_line":"``blob`` fields for backwards compatibility.  Optionally use Barbican to store"},{"line_number":32,"context_line":"credentials or encryption key."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Alternatives"},{"line_number":35,"context_line":"------------"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_44f393d6","line":33,"updated":"2016-04-05 20:26:46.000000000","message":"What key is going to be used to encrypt?  Is it one-for-all of Keystone?","commit_id":"c8401e4d5c2f2c4589633b76a3ffdfa5a53f5885"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"a361c43e6ccc30ebb2584a296635b8d0551ab773","unresolved":false,"context_lines":[{"line_number":30,"context_line":"the ``credential`` table.  Support having both encrypted and unencrypted"},{"line_number":31,"context_line":"``blob`` fields for backwards compatibility.  Optionally use Barbican to store"},{"line_number":32,"context_line":"credentials or encryption key."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Alternatives"},{"line_number":35,"context_line":"------------"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_77b9ec14","line":33,"in_reply_to":"9a061dce_44f393d6","updated":"2016-04-06 18:51:11.000000000","message":"Done","commit_id":"c8401e4d5c2f2c4589633b76a3ffdfa5a53f5885"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"0b8a720fbfb14ba2a255abd2bd183b2624037c38","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Security Impact"},{"line_number":40,"context_line":"---------------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Improved Security of confidential information."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Notifications Impact"},{"line_number":45,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_4d672f25","line":42,"updated":"2016-04-06 00:26:41.000000000","message":"nit: security does not need to be capitalized.","commit_id":"c8401e4d5c2f2c4589633b76a3ffdfa5a53f5885"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"a361c43e6ccc30ebb2584a296635b8d0551ab773","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Security Impact"},{"line_number":40,"context_line":"---------------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Improved Security of confidential information."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Notifications Impact"},{"line_number":45,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_173fd087","line":42,"in_reply_to":"9a061dce_4d672f25","updated":"2016-04-06 18:51:11.000000000","message":"Done","commit_id":"c8401e4d5c2f2c4589633b76a3ffdfa5a53f5885"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"3e91dc14c3ee4a5003fe76717a5b490fa05c9882","unresolved":false,"context_lines":[{"line_number":44,"context_line":"Notifications Impact"},{"line_number":45,"context_line":"--------------------"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"None"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Other End User Impact"},{"line_number":50,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_04223b52","line":47,"updated":"2016-04-05 20:26:46.000000000","message":"What about Key management for the credentials?","commit_id":"c8401e4d5c2f2c4589633b76a3ffdfa5a53f5885"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"a361c43e6ccc30ebb2584a296635b8d0551ab773","unresolved":false,"context_lines":[{"line_number":44,"context_line":"Notifications Impact"},{"line_number":45,"context_line":"--------------------"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"None"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Other End User Impact"},{"line_number":50,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_77728c12","line":47,"in_reply_to":"9a061dce_04223b52","updated":"2016-04-06 18:51:11.000000000","message":"Done","commit_id":"c8401e4d5c2f2c4589633b76a3ffdfa5a53f5885"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"0b8a720fbfb14ba2a255abd2bd183b2624037c38","unresolved":false,"context_lines":[{"line_number":59,"context_line":"Other Deployer Impact"},{"line_number":60,"context_line":"---------------------"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Users should not be forced to install Barbican as a Keystone requirement."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Developer Impact"},{"line_number":65,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_2d959bdd","line":62,"updated":"2016-04-06 00:26:41.000000000","message":"Barbican should be in the Alternatives section, given that it\u0027s not one of the work items. It\u0027d be a stretch to include barbican here!","commit_id":"c8401e4d5c2f2c4589633b76a3ffdfa5a53f5885"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"a361c43e6ccc30ebb2584a296635b8d0551ab773","unresolved":false,"context_lines":[{"line_number":59,"context_line":"Other Deployer Impact"},{"line_number":60,"context_line":"---------------------"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Users should not be forced to install Barbican as a Keystone requirement."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Developer Impact"},{"line_number":65,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_5722e852","line":62,"in_reply_to":"9a061dce_2d959bdd","updated":"2016-04-06 18:51:11.000000000","message":"Done","commit_id":"c8401e4d5c2f2c4589633b76a3ffdfa5a53f5885"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"f6c708a1d77f6f10538b586b422e3adc08d68d66","unresolved":false,"context_lines":[{"line_number":31,"context_line":"there (Barbican, cryptography, etc) The choice of encryption solution should be"},{"line_number":32,"context_line":"pluggable.  A single key will be used to encrypt the credentials using a"},{"line_number":33,"context_line":"different salt for each credential.  Key management will be facilitated by"},{"line_number":34,"context_line":"allowing multiple keys for decryption and a single active key for encryption."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_315b6030","line":34,"updated":"2016-04-13 04:00:12.000000000","message":"Is this for *all* credentials or for specific types of credentials?\n\nWould re-encryption happen inline on read in the case of a key rotation? Or would it be assumed that rotation is done side band (initially)? I recommend fleshing this out somewhere so it is an answered question when implementation time comes.","commit_id":"273127f869b959915175c35539cf564719c2e82e"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"5fbf7230b741de6a7c24f1e1be21a266aab42fea","unresolved":false,"context_lines":[{"line_number":31,"context_line":"there (Barbican, cryptography, etc) The choice of encryption solution should be"},{"line_number":32,"context_line":"pluggable.  A single key will be used to encrypt the credentials using a"},{"line_number":33,"context_line":"different salt for each credential.  Key management will be facilitated by"},{"line_number":34,"context_line":"allowing multiple keys for decryption and a single active key for encryption."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_3346e923","line":34,"in_reply_to":"5a18252c_315b6030","updated":"2016-04-15 20:22:06.000000000","message":"Done","commit_id":"273127f869b959915175c35539cf564719c2e82e"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"f6c708a1d77f6f10538b586b422e3adc08d68d66","unresolved":false,"context_lines":[{"line_number":62,"context_line":"Other Deployer Impact"},{"line_number":63,"context_line":"---------------------"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"None"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Developer Impact"},{"line_number":68,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_9142343d","line":65,"updated":"2016-04-13 04:00:12.000000000","message":"Deployers will need to manage the keys.","commit_id":"273127f869b959915175c35539cf564719c2e82e"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"5fbf7230b741de6a7c24f1e1be21a266aab42fea","unresolved":false,"context_lines":[{"line_number":62,"context_line":"Other Deployer Impact"},{"line_number":63,"context_line":"---------------------"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"None"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Developer Impact"},{"line_number":68,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_7348612e","line":65,"in_reply_to":"5a18252c_9142343d","updated":"2016-04-15 20:22:06.000000000","message":"Done","commit_id":"273127f869b959915175c35539cf564719c2e82e"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"f6c708a1d77f6f10538b586b422e3adc08d68d66","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"* Update credentials driver to support encryption."},{"line_number":85,"context_line":"* Document Credential driver configuration changes."},{"line_number":86,"context_line":"* Write Keystone database migration for existing credentials."},{"line_number":87,"context_line":"* Write test to verify functionality."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_516ffcc4","line":86,"updated":"2016-04-13 04:00:12.000000000","message":"This migration would encrypt the credentials? With what key? a little more expansion here would help so there is a clear target if this is implemented.\n\nThis question would be answered as the conversation continues.","commit_id":"273127f869b959915175c35539cf564719c2e82e"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"5fbf7230b741de6a7c24f1e1be21a266aab42fea","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"* Update credentials driver to support encryption."},{"line_number":85,"context_line":"* Document Credential driver configuration changes."},{"line_number":86,"context_line":"* Write Keystone database migration for existing credentials."},{"line_number":87,"context_line":"* Write test to verify functionality."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_b369598e","line":86,"in_reply_to":"5a18252c_516ffcc4","updated":"2016-04-15 20:22:06.000000000","message":"Done","commit_id":"273127f869b959915175c35539cf564719c2e82e"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"f6c708a1d77f6f10538b586b422e3adc08d68d66","unresolved":false,"context_lines":[{"line_number":89,"context_line":"Dependencies"},{"line_number":90,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"None"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Documentation Impact"},{"line_number":95,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a18252c_916994c1","line":92,"updated":"2016-04-13 04:00:12.000000000","message":"What would the crypto library be? That seems like the dependency here.","commit_id":"273127f869b959915175c35539cf564719c2e82e"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"5fbf7230b741de6a7c24f1e1be21a266aab42fea","unresolved":false,"context_lines":[{"line_number":89,"context_line":"Dependencies"},{"line_number":90,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"None"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Documentation Impact"},{"line_number":95,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_332b8932","line":92,"in_reply_to":"5a18252c_916994c1","updated":"2016-04-15 20:22:06.000000000","message":"Done","commit_id":"273127f869b959915175c35539cf564719c2e82e"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"fe96f2608875eeb4b4b991e32ccf0694ec9a6399","unresolved":false,"context_lines":[{"line_number":85,"context_line":"* Update credentials driver to support encryption."},{"line_number":86,"context_line":"* Document Credential driver configuration changes."},{"line_number":87,"context_line":"* Write Keystone database migration for existing credentials using a"},{"line_number":88,"context_line":"  configuration specified key."},{"line_number":89,"context_line":"* Write test to verify functionality."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_c03eb8b7","line":88,"updated":"2016-04-15 22:51:32.000000000","message":"This is a bad idea. Migrations need to not be dependent on external operator configuration. This cannot be part of the spec.","commit_id":"afe4a642d6f23257576391f08bb3d28874c0e0ad"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"4e86de90c86ad60e30ccbc133bdf0b31a0107609","unresolved":false,"context_lines":[{"line_number":85,"context_line":"* Update credentials driver to support encryption."},{"line_number":86,"context_line":"* Document Credential driver configuration changes."},{"line_number":87,"context_line":"* Write Keystone database migration for existing credentials using a"},{"line_number":88,"context_line":"  configuration specified key."},{"line_number":89,"context_line":"* Write test to verify functionality."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_6f911f47","line":88,"in_reply_to":"1a122d0e_c03eb8b7","updated":"2016-04-19 17:33:08.000000000","message":"Done","commit_id":"afe4a642d6f23257576391f08bb3d28874c0e0ad"}]}
