)]}'
{"specs/keystone/ocata/pci-dss-password-requirements-api.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"39392875dccc90d02be9a3d078ebf5f662f13f36","unresolved":false,"context_lines":[{"line_number":43,"context_line":"discoverable via the identity API. This would result in a new identity API call"},{"line_number":44,"context_line":"to return password requirement specific information::"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    GET /v3/users/{user_id}/password_requirements"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    {"},{"line_number":49,"context_line":"        \"requirements\": {"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a71b18c_07d14bfa","line":46,"range":{"start_line":46,"start_character":8,"end_line":46,"end_character":49},"updated":"2016-12-05 15:46:15.000000000","message":"I\u0027m wondering if we can just re-use the existing API:\n\n  /v3/domains/{domain_id}/config/{group}/{option}\n\nhttp://developer.openstack.org/api-ref/identity/v3/index.html?expanded\u003dshow-domain-group-option-configuration-detail#show-domain-group-option-configuration\n\nThis will better align with the long term goal of having PCI on a per-domain basis. I\u0027d have to look at the code to make sure the \"default\" domain goes back to reading keystone.conf and not only domain specific files","commit_id":"65c88eebfd49fb9fb5ccc5cb7dbc18a10c49bc7f"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"a6160cef5d87b6bf1c8ce3cc384bc52d3970292f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"discoverable via the identity API. This would result in a new identity API call"},{"line_number":44,"context_line":"to return password requirement specific information::"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    GET /v3/users/{user_id}/password_requirements"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    {"},{"line_number":49,"context_line":"        \"requirements\": {"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a71b18c_02969992","line":46,"in_reply_to":"3a71b18c_07d14bfa","updated":"2016-12-05 15:55:54.000000000","message":"++","commit_id":"65c88eebfd49fb9fb5ccc5cb7dbc18a10c49bc7f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f06ab9a5c26873889027376809e96547e4bffecd","unresolved":false,"context_lines":[{"line_number":43,"context_line":"discoverable via the identity API. This would result in a new identity API call"},{"line_number":44,"context_line":"to return password requirement specific information::"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    GET /v3/users/{user_id}/password_requirements"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    {"},{"line_number":49,"context_line":"        \"requirements\": {"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a71b18c_822d4997","line":46,"in_reply_to":"3a71b18c_07d14bfa","updated":"2016-12-05 15:48:56.000000000","message":"Ah - yeah that\u0027s a good point. I\u0027ll check this out and propose a revision. Thanks, Steve.","commit_id":"65c88eebfd49fb9fb5ccc5cb7dbc18a10c49bc7f"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"a6160cef5d87b6bf1c8ce3cc384bc52d3970292f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"becuase there are no backend requirements in order to implement the API."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"If PCI-DSS password checking isn\u0027t enabled, then keystone may return an empty"},{"line_number":61,"context_line":"list, implying there are no requirements to enforce."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Alternatives"},{"line_number":64,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a71b18c_c2cd81b8","line":61,"updated":"2016-12-05 15:55:54.000000000","message":"The above example doesn\u0027t contain any lists. Did you mean empty dict?","commit_id":"65c88eebfd49fb9fb5ccc5cb7dbc18a10c49bc7f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"88466a366a94322a56da58d80dac402f128bfb37","unresolved":false,"context_lines":[{"line_number":58,"context_line":"becuase there are no backend requirements in order to implement the API."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"If PCI-DSS password checking isn\u0027t enabled, then keystone may return an empty"},{"line_number":61,"context_line":"list, implying there are no requirements to enforce."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Alternatives"},{"line_number":64,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a71b18c_02d139fa","line":61,"in_reply_to":"3a71b18c_c2cd81b8","updated":"2016-12-05 16:00:46.000000000","message":"Yeah - I\u0027ll fix.","commit_id":"65c88eebfd49fb9fb5ccc5cb7dbc18a10c49bc7f"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"64f44b14e17ff7f16ee8ae06ee6d6863fd39689a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"   a user the requirements needed, otherwise the user is left guessing random"},{"line_number":31,"context_line":"   password combinations. This is the most important use case if PCI-DSS is"},{"line_number":32,"context_line":"   going to be used effectively in an OpenStack deployment."},{"line_number":33,"context_line":"2. Horizon has no way of knowing the password requirements. The regular"},{"line_number":34,"context_line":"   expression that enforces the password requirements is only used within"},{"line_number":35,"context_line":"   keystone. By letting other services, like horizon, discover the regular"},{"line_number":36,"context_line":"   expression, they can perform quick password validation before issuing the"},{"line_number":37,"context_line":"   password request to keystone."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Proposed Change"},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a71b18c_11ea62ac","line":37,"range":{"start_line":33,"start_character":0,"end_line":37,"end_character":32},"updated":"2016-12-05 17:12:41.000000000","message":"So horizon has its own password validator regex.  How would that fit in with this?\n\nFor example, in local_settings.py\n\nHORIZON_CONFIG[\"password_validator\"] \u003d {\n            \"regex\": \"(?\u003d^.{8,16}$)(?\u003d.*\\d)(?\u003d.*[a-z])(?\u003d.*[A-Z])\"\n                \"(?\u003d.*[!@#$%^\u0026amp;*()_+}{\u0026quot;:;\u0027?/\u0026gt;.\u0026lt;,])(?!.*\\s).*$\",\n            \"help_text\": _(\"Your password does not meet the requirements.\"\n                \"It must contain at least one upper case character, one lower\"\n                \"case letter, a number, one special character, and be \"\n                \"between 8 and 16 characters in length.\")\n}","commit_id":"5e84a0486cdeaab1d67c6984c03bc4db387d79df"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"1209ff008ca631703fb29e2c3dc41dfd70a2b5ac","unresolved":false,"context_lines":[{"line_number":30,"context_line":"   a user the requirements needed, otherwise the user is left guessing random"},{"line_number":31,"context_line":"   password combinations. This is the most important use case if PCI-DSS is"},{"line_number":32,"context_line":"   going to be used effectively in an OpenStack deployment."},{"line_number":33,"context_line":"2. Horizon has no way of knowing the password requirements. The regular"},{"line_number":34,"context_line":"   expression that enforces the password requirements is only used within"},{"line_number":35,"context_line":"   keystone. By letting other services, like horizon, discover the regular"},{"line_number":36,"context_line":"   expression, they can perform quick password validation before issuing the"},{"line_number":37,"context_line":"   password request to keystone."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Proposed Change"},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a71b18c_bc5fc5e3","line":37,"range":{"start_line":33,"start_character":0,"end_line":37,"end_character":32},"in_reply_to":"3a71b18c_11ea62ac","updated":"2016-12-05 17:25:28.000000000","message":"@Eric, they want to remove that (or at least fall back to it if there is no existing config available (but i don\u0027t see they would do that because the password requirements are almost the same)) because its one less thing for them to maintain.\n\nHaving it be discoverable means that OSC (and KSC\u0027s python bindings) could use it too.","commit_id":"5e84a0486cdeaab1d67c6984c03bc4db387d79df"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"da361a8d2d556ac8302fffe2cc08885778686b91","unresolved":false,"context_lines":[{"line_number":34,"context_line":"   expression that enforces the password requirements is only used within"},{"line_number":35,"context_line":"   keystone. By letting other services, like horizon, discover the regular"},{"line_number":36,"context_line":"   expression, they can perform quick password validation before issuing the"},{"line_number":37,"context_line":"   password request to keystone."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Proposed Change"},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a71b18c_5c407134","line":37,"in_reply_to":"3a71b18c_11ea62ac","updated":"2016-12-05 17:21:20.000000000","message":"They could replace their validator with keystone\u0027s, if horizon can retrieve keystone\u0027s PCI-DSS password regex.","commit_id":"5e84a0486cdeaab1d67c6984c03bc4db387d79df"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b13687fc61219b2adef2ee001a85b8043ce450ae","unresolved":false,"context_lines":[{"line_number":49,"context_line":"of using the domain configuration API to get the password requirements::"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    GET /v3/domains/default/config/security_compliance/password_regex"},{"line_number":52,"context_line":"    GET /v3/domains/default/config/security_compliance/password_regex_description"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The regular expression and description above are the same values defined"},{"line_number":55,"context_line":"through keystone\u0027s configuration file. If PCI-DSS password checking isn\u0027t"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a71b18c_ae5f8fe3","line":52,"updated":"2016-12-05 16:48:14.000000000","message":"I want to verify with horizon developers that getting the user\u0027s domain ID won\u0027t be a problem. If they have the user\u0027s token, they should be able to take the following steps to get the password requirements from keystone:\n\n  1.) get user reference using user\u0027s token (GET /v3/users/{user_id})\n  2.) scrap domain id from response\n  3.) get password requirements\n    GET /v3/domains/{domain_from_user_ref}/config/security_compliance/password_regex\n  4.) get password requirement description\n    GET /v3/domains/{domain_from_user_ref}/config/security_compliance/password_regex_description\n\nThis will be a little more involved than a dedicated API for returning configuration values.","commit_id":"5e84a0486cdeaab1d67c6984c03bc4db387d79df"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"d487080dfcde71509b70779f14c12d8076b63299","unresolved":false,"context_lines":[{"line_number":30,"context_line":"   a user the requirements needed, otherwise the user is left guessing random"},{"line_number":31,"context_line":"   password combinations. This is the most important use case if PCI-DSS is"},{"line_number":32,"context_line":"   going to be used effectively in an OpenStack deployment."},{"line_number":33,"context_line":"2. Horizon has no way of knowing the password requirements. The regular"},{"line_number":34,"context_line":"   expression that enforces the password requirements is only used within"},{"line_number":35,"context_line":"   keystone. By letting other services, like horizon, discover the regular"},{"line_number":36,"context_line":"   expression, they can perform quick password validation before issuing the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_453251f3","line":33,"range":{"start_line":33,"start_character":3,"end_line":33,"end_character":10},"updated":"2016-12-05 19:41:44.000000000","message":"s/Horizon/Any client application, this includes Horizon, keystoneclient\u0027s python bindings, and OSC.","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d68ac3d4690aaca871096853d5d50ab415f51d6a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"   a user the requirements needed, otherwise the user is left guessing random"},{"line_number":31,"context_line":"   password combinations. This is the most important use case if PCI-DSS is"},{"line_number":32,"context_line":"   going to be used effectively in an OpenStack deployment."},{"line_number":33,"context_line":"2. Horizon has no way of knowing the password requirements. The regular"},{"line_number":34,"context_line":"   expression that enforces the password requirements is only used within"},{"line_number":35,"context_line":"   keystone. By letting other services, like horizon, discover the regular"},{"line_number":36,"context_line":"   expression, they can perform quick password validation before issuing the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_3bf1c66b","line":33,"in_reply_to":"3a71b18c_453251f3","updated":"2016-12-06 19:37:09.000000000","message":"Good point, done.","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"f55b9d55e13e104bfb59945ac644eb675e7719c5","unresolved":false,"context_lines":[{"line_number":48,"context_line":"to make the API read-only for those values. The following would be an example"},{"line_number":49,"context_line":"of using the domain configuration API to get the password requirements::"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    GET /v3/domains/default/config/security_compliance/password_regex"},{"line_number":52,"context_line":"    GET /v3/domains/default/config/security_compliance/password_regex_description"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Currently, keystone suggests that the admin role is required to interact with"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_7d8b401f","line":51,"range":{"start_line":51,"start_character":20,"end_line":51,"end_character":27},"updated":"2016-12-06 13:38:00.000000000","message":"can we put any domain ID here or are going to always use the default in this case ? (PCI-DSS config is not tied to domains yet)","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d68ac3d4690aaca871096853d5d50ab415f51d6a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"to make the API read-only for those values. The following would be an example"},{"line_number":49,"context_line":"of using the domain configuration API to get the password requirements::"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    GET /v3/domains/default/config/security_compliance/password_regex"},{"line_number":52,"context_line":"    GET /v3/domains/default/config/security_compliance/password_regex_description"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Currently, keystone suggests that the admin role is required to interact with"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_3bbf0662","line":51,"in_reply_to":"3a71b18c_7d8b401f","updated":"2016-12-06 19:37:09.000000000","message":"We could put any domain in here technically - but currently the only one that is going to matter would be the default one.","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"f55b9d55e13e104bfb59945ac644eb675e7719c5","unresolved":false,"context_lines":[{"line_number":70,"context_line":"requirements as they are known in the ``keystone.conf``. This would be a much"},{"line_number":71,"context_line":"simpler API, but it wouldn\u0027t be leveraging any of the domain configuration API"},{"line_number":72,"context_line":"at all. This might be a useful option depending on how invasive it is to"},{"line_number":73,"context_line":"whitelist PCI-DSS password configuration. If PCI-DSS support is available per"},{"line_number":74,"context_line":"domain in the future, this would have to be reworked."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"A second alternative would be to expose the variables to horizon through a"},{"line_number":77,"context_line":"copied version of keystone\u0027s configuration file. This option would require"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_fdcd9066","line":74,"range":{"start_line":73,"start_character":42,"end_line":74,"end_character":53},"updated":"2016-12-06 13:38:00.000000000","message":"good point","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"f55b9d55e13e104bfb59945ac644eb675e7719c5","unresolved":false,"context_lines":[{"line_number":84,"context_line":"---------------"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"If we implement this through the existing domain configuration API, there are"},{"line_number":87,"context_line":"some security concerns around the policy for domain configuration. This change"},{"line_number":88,"context_line":"would require keystone to loosen the policy for domain configuration so that it"},{"line_number":89,"context_line":"can be usable for all users, not just admins. If the policy isn\u0027t loosened, the"},{"line_number":90,"context_line":"implementation of the specification using domain configuration would only be"},{"line_number":91,"context_line":"useful to administrators, or users with the admin role. Another security"},{"line_number":92,"context_line":"concern we need to be aware of with this approach is making sure password"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_1d532c6c","line":89,"range":{"start_line":87,"start_character":67,"end_line":89,"end_character":45},"updated":"2016-12-06 13:38:00.000000000","message":"Does OpenStack still have service role ? If so, \"GET /domain_config: role:domain_admin or role:service\"","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d68ac3d4690aaca871096853d5d50ab415f51d6a","unresolved":false,"context_lines":[{"line_number":86,"context_line":"If we implement this through the existing domain configuration API, there are"},{"line_number":87,"context_line":"some security concerns around the policy for domain configuration. This change"},{"line_number":88,"context_line":"would require keystone to loosen the policy for domain configuration so that it"},{"line_number":89,"context_line":"can be usable for all users, not just admins. If the policy isn\u0027t loosened, the"},{"line_number":90,"context_line":"implementation of the specification using domain configuration would only be"},{"line_number":91,"context_line":"useful to administrators, or users with the admin role. Another security"},{"line_number":92,"context_line":"concern we need to be aware of with this approach is making sure password"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_1ba5ea45","line":89,"in_reply_to":"3a71b18c_1d532c6c","updated":"2016-12-06 19:37:09.000000000","message":"It does, but we can\u0027t assume all clients/UIs will have a service role. Horizon is a project that operates without a service user.","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9304bdb2a818d0bb73fc514c68ce64cf342d357f","unresolved":false,"context_lines":[{"line_number":92,"context_line":"concern we need to be aware of with this approach is making sure password"},{"line_number":93,"context_line":"requirements can\u0027t be modified through the API. Allowing password requirement"},{"line_number":94,"context_line":"changes to an entire domain, or deployment, over the API would be a security"},{"line_number":95,"context_line":"concern if not handled at the deployer or administrator level."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"If we isolate returning password requirement information to its own API, we can"},{"line_number":98,"context_line":"build a policy for it that doesn\u0027t interfere with existing policy. This would"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_a82cdc99","line":95,"updated":"2016-12-05 20:05:49.000000000","message":"This whole paragraph worries me... the security concerns here push me to the first alternative over the one that is currently proposed.","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d68ac3d4690aaca871096853d5d50ab415f51d6a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"concern we need to be aware of with this approach is making sure password"},{"line_number":93,"context_line":"requirements can\u0027t be modified through the API. Allowing password requirement"},{"line_number":94,"context_line":"changes to an entire domain, or deployment, over the API would be a security"},{"line_number":95,"context_line":"concern if not handled at the deployer or administrator level."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"If we isolate returning password requirement information to its own API, we can"},{"line_number":98,"context_line":"build a policy for it that doesn\u0027t interfere with existing policy. This would"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_7b3a5ee8","line":95,"in_reply_to":"3a71b18c_07d2fd27","updated":"2016-12-06 19:37:09.000000000","message":"Ok - so attempt to reuse the domain config code, but isolated the password requirement stuff to it\u0027s own api, right?","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"858124eca9603565af4755523e1bf2f0a5862318","unresolved":false,"context_lines":[{"line_number":92,"context_line":"concern we need to be aware of with this approach is making sure password"},{"line_number":93,"context_line":"requirements can\u0027t be modified through the API. Allowing password requirement"},{"line_number":94,"context_line":"changes to an entire domain, or deployment, over the API would be a security"},{"line_number":95,"context_line":"concern if not handled at the deployer or administrator level."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"If we isolate returning password requirement information to its own API, we can"},{"line_number":98,"context_line":"build a policy for it that doesn\u0027t interfere with existing policy. This would"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_630105af","line":95,"in_reply_to":"3a71b18c_23c62d9a","updated":"2016-12-05 20:35:42.000000000","message":"By keeping this as close to the domain-config stuff as possible, do you mean reusing the domain config code, keeping the same API conventions, or both?\n\nIt\u0027s the reusing the API path that will open up the possible policy issues. If we just want the APIs to be consistent, that shouldn\u0027t be a problem at all.","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5acc53d8c42b3ce6f7521802853edc3998465420","unresolved":false,"context_lines":[{"line_number":92,"context_line":"concern we need to be aware of with this approach is making sure password"},{"line_number":93,"context_line":"requirements can\u0027t be modified through the API. Allowing password requirement"},{"line_number":94,"context_line":"changes to an entire domain, or deployment, over the API would be a security"},{"line_number":95,"context_line":"concern if not handled at the deployer or administrator level."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"If we isolate returning password requirement information to its own API, we can"},{"line_number":98,"context_line":"build a policy for it that doesn\u0027t interfere with existing policy. This would"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_68bf24aa","line":95,"in_reply_to":"3a71b18c_28944c41","updated":"2016-12-05 20:18:53.000000000","message":"I feel like that would be the safer route unless proven otherwise. If deployers don\u0027t have a problem with all users in their domain (or deployment) being able to read configuration options for the domain, then I *think* it would be ok(?). But, at the same time, why would an average user need to know what in the configuration outside of the password help text?\n\nI\u0027m typically gun shy about giving more information than what is absolutely necessary.\n\nSteve, do you want me to propose a contrasting specification with the first alternative in parallel?","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"22a493c03ff8d4463a2ec8e6db2c5d0cc31ccf88","unresolved":false,"context_lines":[{"line_number":92,"context_line":"concern we need to be aware of with this approach is making sure password"},{"line_number":93,"context_line":"requirements can\u0027t be modified through the API. Allowing password requirement"},{"line_number":94,"context_line":"changes to an entire domain, or deployment, over the API would be a security"},{"line_number":95,"context_line":"concern if not handled at the deployer or administrator level."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"If we isolate returning password requirement information to its own API, we can"},{"line_number":98,"context_line":"build a policy for it that doesn\u0027t interfere with existing policy. This would"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_f4b86977","line":95,"in_reply_to":"3a71b18c_348821c5","updated":"2016-12-05 22:08:32.000000000","message":"we could have a \"ReadOnlyDomainConfigManager\" and maybe move all the config option reading to a common class (anyway, implementation detail)","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f7d6ea5700dfff070f2a4e36a82ccfa3015ff052","unresolved":false,"context_lines":[{"line_number":92,"context_line":"concern we need to be aware of with this approach is making sure password"},{"line_number":93,"context_line":"requirements can\u0027t be modified through the API. Allowing password requirement"},{"line_number":94,"context_line":"changes to an entire domain, or deployment, over the API would be a security"},{"line_number":95,"context_line":"concern if not handled at the deployer or administrator level."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"If we isolate returning password requirement information to its own API, we can"},{"line_number":98,"context_line":"build a policy for it that doesn\u0027t interfere with existing policy. This would"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_9e61163c","line":95,"in_reply_to":"3a71b18c_630105af","updated":"2016-12-05 21:11:09.000000000","message":"it\u0027ll be it\u0027s own route / controller / policy entry. the route i proposed isn\u0027t /config/ it\u0027s /read_only_config/","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"62c872de42c627563e62ac92353fa52d03a03c1a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"concern we need to be aware of with this approach is making sure password"},{"line_number":93,"context_line":"requirements can\u0027t be modified through the API. Allowing password requirement"},{"line_number":94,"context_line":"changes to an entire domain, or deployment, over the API would be a security"},{"line_number":95,"context_line":"concern if not handled at the deployer or administrator level."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"If we isolate returning password requirement information to its own API, we can"},{"line_number":98,"context_line":"build a policy for it that doesn\u0027t interfere with existing policy. This would"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_23c62d9a","line":95,"in_reply_to":"3a71b18c_68bf24aa","updated":"2016-12-05 20:32:21.000000000","message":"we can just reuse this one.\n\ni\u0027d like to keep this as close to the domain-config stuff as possible though, if the API was something like:\n\n  GET /v3/domains/{domain}/read_only_config/{group}/{option}\n\nor something like that?","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"0249a494ad7310673264945ffbd01159b4a02a83","unresolved":false,"context_lines":[{"line_number":92,"context_line":"concern we need to be aware of with this approach is making sure password"},{"line_number":93,"context_line":"requirements can\u0027t be modified through the API. Allowing password requirement"},{"line_number":94,"context_line":"changes to an entire domain, or deployment, over the API would be a security"},{"line_number":95,"context_line":"concern if not handled at the deployer or administrator level."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"If we isolate returning password requirement information to its own API, we can"},{"line_number":98,"context_line":"build a policy for it that doesn\u0027t interfere with existing policy. This would"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_d91d6863","line":95,"in_reply_to":"3a71b18c_9e61163c","updated":"2016-12-05 21:20:29.000000000","message":"Got it, that part makes sense. Do you still plan on it using the domain config manager?","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"59b0f761fa427b553815c6522a8fb610b262fc43","unresolved":false,"context_lines":[{"line_number":92,"context_line":"concern we need to be aware of with this approach is making sure password"},{"line_number":93,"context_line":"requirements can\u0027t be modified through the API. Allowing password requirement"},{"line_number":94,"context_line":"changes to an entire domain, or deployment, over the API would be a security"},{"line_number":95,"context_line":"concern if not handled at the deployer or administrator level."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"If we isolate returning password requirement information to its own API, we can"},{"line_number":98,"context_line":"build a policy for it that doesn\u0027t interfere with existing policy. This would"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_28944c41","line":95,"in_reply_to":"3a71b18c_a82cdc99","updated":"2016-12-05 20:16:12.000000000","message":"separate API then? with it\u0027s own policy","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"5cd8b91de77e63d128cc62710d2a2410509cb598","unresolved":false,"context_lines":[{"line_number":92,"context_line":"concern we need to be aware of with this approach is making sure password"},{"line_number":93,"context_line":"requirements can\u0027t be modified through the API. Allowing password requirement"},{"line_number":94,"context_line":"changes to an entire domain, or deployment, over the API would be a security"},{"line_number":95,"context_line":"concern if not handled at the deployer or administrator level."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"If we isolate returning password requirement information to its own API, we can"},{"line_number":98,"context_line":"build a policy for it that doesn\u0027t interfere with existing policy. This would"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_348821c5","line":95,"in_reply_to":"3a71b18c_d91d6863","updated":"2016-12-05 22:07:31.000000000","message":"don\u0027t see why we can\u0027t","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"6c6de357cec4dd4f4ca9de922ba5e7e3af451776","unresolved":false,"context_lines":[{"line_number":92,"context_line":"concern we need to be aware of with this approach is making sure password"},{"line_number":93,"context_line":"requirements can\u0027t be modified through the API. Allowing password requirement"},{"line_number":94,"context_line":"changes to an entire domain, or deployment, over the API would be a security"},{"line_number":95,"context_line":"concern if not handled at the deployer or administrator level."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"If we isolate returning password requirement information to its own API, we can"},{"line_number":98,"context_line":"build a policy for it that doesn\u0027t interfere with existing policy. This would"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_07d2fd27","line":95,"in_reply_to":"3a71b18c_f4b86977","updated":"2016-12-06 12:33:06.000000000","message":"I see no reason why we can\u0027t have different role requirements for access to differing config options (we do this for a couple of other, unrelated, APIs today). This seems a good way to avoid relaxing the security constraints on other config settings","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"f55b9d55e13e104bfb59945ac644eb675e7719c5","unresolved":false,"context_lines":[{"line_number":98,"context_line":"build a policy for it that doesn\u0027t interfere with existing policy. This would"},{"line_number":99,"context_line":"be an advantage of the first alternative listed above."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Regardless, the API for requesting password requirement information needs to be"},{"line_number":102,"context_line":"protected. If password information isn\u0027t protected, it would be easy for a"},{"line_number":103,"context_line":"potential attacker to obtain the password requirements for a deployment and"},{"line_number":104,"context_line":"tailor an attack using those requirements."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Notifications Impact"},{"line_number":107,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_fd059045","line":104,"range":{"start_line":101,"start_character":0,"end_line":104,"end_character":42},"updated":"2016-12-06 13:38:00.000000000","message":"Isn\u0027t it protected ? A user must have at least a valid token, that means it\u0027s a user of that cloud.","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d68ac3d4690aaca871096853d5d50ab415f51d6a","unresolved":false,"context_lines":[{"line_number":101,"context_line":"Regardless, the API for requesting password requirement information needs to be"},{"line_number":102,"context_line":"protected. If password information isn\u0027t protected, it would be easy for a"},{"line_number":103,"context_line":"potential attacker to obtain the password requirements for a deployment and"},{"line_number":104,"context_line":"tailor an attack using those requirements."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Notifications Impact"},{"line_number":107,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_db0a9225","line":104,"in_reply_to":"3a71b18c_fd059045","updated":"2016-12-06 19:37:09.000000000","message":"Yep, that\u0027s true. I was trying to be verbose about the security implications of not protecting this resource, which might be redundant but I decided to do it anyway. I can remove this if folks find it too basic.","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"d487080dfcde71509b70779f14c12d8076b63299","unresolved":false,"context_lines":[{"line_number":148,"context_line":"Other contributors:"},{"line_number":149,"context_line":"  None"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Work Items"},{"line_number":152,"context_line":"----------"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"* Propose patch to the domain configuration API to allow the default domain to"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_2540f533","line":151,"range":{"start_line":151,"start_character":0,"end_line":151,"end_character":10},"updated":"2016-12-05 19:41:44.000000000","message":"we may also need to update policy","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d68ac3d4690aaca871096853d5d50ab415f51d6a","unresolved":false,"context_lines":[{"line_number":148,"context_line":"Other contributors:"},{"line_number":149,"context_line":"  None"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Work Items"},{"line_number":152,"context_line":"----------"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"* Propose patch to the domain configuration API to allow the default domain to"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_1b016a06","line":151,"in_reply_to":"3a71b18c_2540f533","updated":"2016-12-06 19:37:09.000000000","message":"Done","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"d487080dfcde71509b70779f14c12d8076b63299","unresolved":false,"context_lines":[{"line_number":152,"context_line":"----------"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"* Propose patch to the domain configuration API to allow the default domain to"},{"line_number":155,"context_line":"  perform lookups using ``keystone.conf``, but only for password requirement"},{"line_number":156,"context_line":"  lookups."},{"line_number":157,"context_line":"* Propose patch to whitelist ``keystone.conf [security_compliance]"},{"line_number":158,"context_line":"  password_regex`` and ``keystone.conf [security_compliance]"},{"line_number":159,"context_line":"  password_regex_description`` retrieval using the domain configuration API."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_852709b5","line":156,"range":{"start_line":155,"start_character":43,"end_line":156,"end_character":9},"updated":"2016-12-05 19:41:44.000000000","message":"i don\u0027t think this is necessary, but i\u0027m OK with isolating it for now.","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"d487080dfcde71509b70779f14c12d8076b63299","unresolved":false,"context_lines":[{"line_number":157,"context_line":"* Propose patch to whitelist ``keystone.conf [security_compliance]"},{"line_number":158,"context_line":"  password_regex`` and ``keystone.conf [security_compliance]"},{"line_number":159,"context_line":"  password_regex_description`` retrieval using the domain configuration API."},{"line_number":160,"context_line":"* Test to make sure password requirements cannot be modified through the domain"},{"line_number":161,"context_line":"  configuration API."},{"line_number":162,"context_line":"* Add developer information to keystone `PCI-DSS documentation"},{"line_number":163,"context_line":"  \u003chttp://docs.openstack.org/developer/keystone/security_compliance.html\u003e`_"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_e5599d36","line":161,"range":{"start_line":160,"start_character":2,"end_line":161,"end_character":20},"updated":"2016-12-05 19:41:44.000000000","message":"good addition","commit_id":"5d72411ab4feb491a72234bc512ca88265815651"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a3c6baa2754b03a1bdc11759bae113920822616d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"   password combinations. This is the most important use case if PCI-DSS is"},{"line_number":32,"context_line":"   going to be used effectively in an OpenStack deployment."},{"line_number":33,"context_line":"2. Client libraries have no way of knowing the password requirements enforced"},{"line_number":34,"context_line":"   by keystone (including Horizon, OCS, python-keystoneclient bindings, etc)."},{"line_number":35,"context_line":"   The regular expression that enforces the password requirements is only used"},{"line_number":36,"context_line":"   within keystone. By letting other services, like horizon, discover the"},{"line_number":37,"context_line":"   regular expression, they can perform quick password validation before"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a71b18c_02080827","line":34,"range":{"start_line":34,"start_character":35,"end_line":34,"end_character":38},"updated":"2016-12-07 04:03:17.000000000","message":"OSC*","commit_id":"1d3a497583b452901a2166130b7fcdaa240766d0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"13c4dbd0952198794cfb62004b335cd3f66b092a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"   password combinations. This is the most important use case if PCI-DSS is"},{"line_number":32,"context_line":"   going to be used effectively in an OpenStack deployment."},{"line_number":33,"context_line":"2. Client libraries have no way of knowing the password requirements enforced"},{"line_number":34,"context_line":"   by keystone (including Horizon, OCS, python-keystoneclient bindings, etc)."},{"line_number":35,"context_line":"   The regular expression that enforces the password requirements is only used"},{"line_number":36,"context_line":"   within keystone. By letting other services, like horizon, discover the"},{"line_number":37,"context_line":"   regular expression, they can perform quick password validation before"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a71b18c_b008532f","line":34,"in_reply_to":"3a71b18c_02080827","updated":"2016-12-07 20:26:58.000000000","message":"Done","commit_id":"1d3a497583b452901a2166130b7fcdaa240766d0"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a3c6baa2754b03a1bdc11759bae113920822616d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    GET /v3/domains/default/config/security_compliance/password_regex"},{"line_number":53,"context_line":"    GET /v3/domains/default/config/security_compliance/password_regex_description"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"In order to ensure password strength requirements can be fetched by all users,"},{"line_number":56,"context_line":"it could be isolated into its own API, using its own routers, controllers, etc."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"If PCI-DSS password checking isn\u0027t"},{"line_number":59,"context_line":"enabled, then a ``404 Not Found`` will be returned, implying there are no"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a71b18c_824a5853","line":56,"range":{"start_line":55,"start_character":0,"end_line":56,"end_character":79},"updated":"2016-12-07 04:03:17.000000000","message":"so the route would be\n\n  GET /v3/domains/{domain_id}/config/security_compliance/{option}\n\nWon\u0027t that overlap with the existing:\n\n  GET /v3/domains/{domain_id}/config/{group}/{option}\n\nor does exact name matching overrule the wild card? I\u0027m not sure we\u0027ve ever had this issue in keystone before","commit_id":"1d3a497583b452901a2166130b7fcdaa240766d0"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"ba46a5267e2bdfb40effb49fe84a98650797b069","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    GET /v3/domains/default/config/security_compliance/password_regex"},{"line_number":53,"context_line":"    GET /v3/domains/default/config/security_compliance/password_regex_description"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"In order to ensure password strength requirements can be fetched by all users,"},{"line_number":56,"context_line":"it could be isolated into its own API, using its own routers, controllers, etc."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"If PCI-DSS password checking isn\u0027t"},{"line_number":59,"context_line":"enabled, then a ``404 Not Found`` will be returned, implying there are no"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a71b18c_e9103d5c","line":56,"range":{"start_line":55,"start_character":0,"end_line":56,"end_character":79},"in_reply_to":"3a71b18c_335c694a","updated":"2016-12-07 14:32:08.000000000","message":"I believe that is the goal, that we will eventually support PCI-DSS by domain.","commit_id":"1d3a497583b452901a2166130b7fcdaa240766d0"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"c7960a0f144f0262ed4a8830c30ec117fce81524","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    GET /v3/domains/default/config/security_compliance/password_regex"},{"line_number":53,"context_line":"    GET /v3/domains/default/config/security_compliance/password_regex_description"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"In order to ensure password strength requirements can be fetched by all users,"},{"line_number":56,"context_line":"it could be isolated into its own API, using its own routers, controllers, etc."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"If PCI-DSS password checking isn\u0027t"},{"line_number":59,"context_line":"enabled, then a ``404 Not Found`` will be returned, implying there are no"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a71b18c_335c694a","line":56,"range":{"start_line":55,"start_character":0,"end_line":56,"end_character":79},"in_reply_to":"3a71b18c_584824cc","updated":"2016-12-07 11:36:54.000000000","message":"So for me the point is whether we do plan to support PCI-DSS per domain or not.\n\nIf we do, I am all for doing it this way, even if we need to add a special check when looking at the specified group (if group \u003d\u003d \u0027security_compliance\u0027 then look at the config file).\n\nIf we do not, this would be a bad decision to put this under the domain config API because of 1) the security concerns as described in the security section below and 2) it won\u0027t have anything to do with domains.","commit_id":"1d3a497583b452901a2166130b7fcdaa240766d0"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"f1650fd74bf10807bf124b73634024bb47217aea","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    GET /v3/domains/default/config/security_compliance/password_regex"},{"line_number":53,"context_line":"    GET /v3/domains/default/config/security_compliance/password_regex_description"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"In order to ensure password strength requirements can be fetched by all users,"},{"line_number":56,"context_line":"it could be isolated into its own API, using its own routers, controllers, etc."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"If PCI-DSS password checking isn\u0027t"},{"line_number":59,"context_line":"enabled, then a ``404 Not Found`` will be returned, implying there are no"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a71b18c_584824cc","line":56,"range":{"start_line":55,"start_character":0,"end_line":56,"end_character":79},"in_reply_to":"3a71b18c_824a5853","updated":"2016-12-07 11:11:30.000000000","message":"Yeah, concerned that it would overlap as well and cause confusion. Instead, we could do something like this:\nGET /v3/config/security_compliance/password_regex/domain/{id}","commit_id":"1d3a497583b452901a2166130b7fcdaa240766d0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"13c4dbd0952198794cfb62004b335cd3f66b092a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    GET /v3/domains/default/config/security_compliance/password_regex_description"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"In order to ensure password strength requirements can be fetched by all users,"},{"line_number":56,"context_line":"it could be isolated into its own API, using its own routers, controllers, etc."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"If PCI-DSS password checking isn\u0027t"},{"line_number":59,"context_line":"enabled, then a ``404 Not Found`` will be returned, implying there are no"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a71b18c_2f594b8f","line":56,"in_reply_to":"3a71b18c_e9103d5c","updated":"2016-12-07 20:26:58.000000000","message":"If our plan is to support PCI-DSS on a per domain basis, then I would opt for this route. Initially, it won\u0027t really matter since we only really support it in the default domain. I would assume we would just note that somewhere and document it though?\n\nIt looks like it would conflict with an existing router - https://github.com/openstack/keystone/blob/fc93521ed1fca2e8393cf2e53e0f79a61dec7222/keystone/resource/routers.py#L74-L86\n\nSo, it looks like we have two options:\n\n 1.) Use a different route\n 2.) Make domain config re-useable for the security_compliance section\n\nOption 2 is the one I have security concerns with.","commit_id":"1d3a497583b452901a2166130b7fcdaa240766d0"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"f1650fd74bf10807bf124b73634024bb47217aea","unresolved":false,"context_lines":[{"line_number":59,"context_line":"enabled, then a ``404 Not Found`` will be returned, implying there are no"},{"line_number":60,"context_line":"requirements to enforce since it\u0027s not in configuration."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Alternatives"},{"line_number":63,"context_line":"------------"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"One alternative is to create a dedicated API for returning the password"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a71b18c_d33fb584","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":12},"updated":"2016-12-07 11:11:30.000000000","message":"Another alternative would be to make it user specific, as some of the PCI features allow certain users to be ignored. However, this is not the case for password strength requirements.","commit_id":"1d3a497583b452901a2166130b7fcdaa240766d0"}]}
