)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"575a3f2f3ecc0ebfe85263a74228b3ae8166922b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"API keys"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This specification decribes API keys as a new credential in keystone in"},{"line_number":10,"context_line":"order to improve security by limiting access and not embedding user"},{"line_number":11,"context_line":"credentials in configuration files."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"1a1ced50_69786a2c","line":9,"range":{"start_line":9,"start_character":42,"end_line":9,"end_character":56},"updated":"2017-03-20 12:03:07.000000000","message":"As (now) proposed,  this is not a new credential - it is really a new TOKEN type in all but name. In fact, isn\u0027t this really UUID tokens with no expiration and the ability to only contain a subset of the roles I have on a project?","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fa701b86bc76a5bc83a34b4dca26b3ce4ed12692","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"API keys"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This specification decribes API keys as a new credential in keystone in"},{"line_number":10,"context_line":"order to improve security by limiting access and not embedding user"},{"line_number":11,"context_line":"credentials in configuration files."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"1a1ced50_ccb4fad2","line":9,"updated":"2017-03-20 19:36:17.000000000","message":"describes*","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"}],"specs/keystone/pike/api-keys.rst":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"bac8035d78df3cc8acd9b62aec9303278dcfc55d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"* Must be immutable"},{"line_number":48,"context_line":"* Must have quota applied on a per user basis (i.e. 5 API keys per user)"},{"line_number":49,"context_line":"* Must have a role on a project that the user creating the API key has"},{"line_number":50,"context_line":"* Must only be revealed to the user once, after creation time"},{"line_number":51,"context_line":"* Must include API key Id and value at authentication time"},{"line_number":52,"context_line":"* Cannot be able to create new API keys"},{"line_number":53,"context_line":"* Cannot be able to delete API keys"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba2be162_0b5e3ae9","line":50,"range":{"start_line":50,"start_character":2,"end_line":50,"end_character":61},"updated":"2017-03-01 09:05:51.000000000","message":"what does this mean? How exposed? (I suspect you mean, a user cannot Read the value again other than is returned in the response of the create API key call)","commit_id":"b0aff0e7a5444efc54bffe85fa2807f0f4adc493"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"171aca850be4a7c2ce187aa9b6c41b1ab9e1699e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"* Must be immutable"},{"line_number":48,"context_line":"* Must have quota applied on a per user basis (i.e. 5 API keys per user)"},{"line_number":49,"context_line":"* Must have a role on a project that the user creating the API key has"},{"line_number":50,"context_line":"* Must only be revealed to the user once, after creation time"},{"line_number":51,"context_line":"* Must include API key Id and value at authentication time"},{"line_number":52,"context_line":"* Cannot be able to create new API keys"},{"line_number":53,"context_line":"* Cannot be able to delete API keys"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba2be162_377dff6e","line":50,"range":{"start_line":50,"start_character":2,"end_line":50,"end_character":61},"in_reply_to":"ba2be162_0b5e3ae9","updated":"2017-03-01 20:49:22.000000000","message":"Correct, I\u0027ll reword this to make it more clear.","commit_id":"b0aff0e7a5444efc54bffe85fa2807f0f4adc493"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"bac8035d78df3cc8acd9b62aec9303278dcfc55d","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    {"},{"line_number":78,"context_line":"        \"access_key\": {"},{"line_number":79,"context_line":"            \"id\": \"98a2cffef26a4ada91c2b55618c60bd8\","},{"line_number":80,"context_line":"            \"value\": \"bc16f9a13f62442ca596f9f371ce5fd5\","},{"line_number":81,"context_line":"            \"user_id\": \"094d9bd427104d89acd64e59b0b6adb4\","},{"line_number":82,"context_line":"            \"description\": \"Backup job...\","},{"line_number":83,"context_line":"            \"expires_at\": \"2017-11-06T15:32:17.000000\","}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba2be162_cbbee2fe","line":80,"range":{"start_line":79,"start_character":0,"end_line":80,"end_character":55},"updated":"2017-03-01 09:05:51.000000000","message":"we should explain why two things are returned here....so \"id\" makes sense, but what\u0027s the \"value\"?","commit_id":"b0aff0e7a5444efc54bffe85fa2807f0f4adc493"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"171aca850be4a7c2ce187aa9b6c41b1ab9e1699e","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    {"},{"line_number":78,"context_line":"        \"access_key\": {"},{"line_number":79,"context_line":"            \"id\": \"98a2cffef26a4ada91c2b55618c60bd8\","},{"line_number":80,"context_line":"            \"value\": \"bc16f9a13f62442ca596f9f371ce5fd5\","},{"line_number":81,"context_line":"            \"user_id\": \"094d9bd427104d89acd64e59b0b6adb4\","},{"line_number":82,"context_line":"            \"description\": \"Backup job...\","},{"line_number":83,"context_line":"            \"expires_at\": \"2017-11-06T15:32:17.000000\","}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba2be162_3a132668","line":80,"range":{"start_line":79,"start_character":0,"end_line":80,"end_character":55},"in_reply_to":"ba2be162_cbbee2fe","updated":"2017-03-01 20:49:22.000000000","message":"Done","commit_id":"b0aff0e7a5444efc54bffe85fa2807f0f4adc493"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"bac8035d78df3cc8acd9b62aec9303278dcfc55d","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"This improves security as API access keys will have limited access; can be"},{"line_number":115,"context_line":"rotated and securely stored in configuration files."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Alternatives"},{"line_number":118,"context_line":"------------"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba2be162_0bbabae1","line":116,"updated":"2017-03-01 09:05:51.000000000","message":"so we should explain what a service will do...i.e. do they just replace username/password with id/value in their config file?","commit_id":"b0aff0e7a5444efc54bffe85fa2807f0f4adc493"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"171aca850be4a7c2ce187aa9b6c41b1ab9e1699e","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"This improves security as API access keys will have limited access; can be"},{"line_number":115,"context_line":"rotated and securely stored in configuration files."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Alternatives"},{"line_number":118,"context_line":"------------"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba2be162_17939b50","line":116,"in_reply_to":"ba2be162_0bbabae1","updated":"2017-03-01 20:49:22.000000000","message":"Done","commit_id":"b0aff0e7a5444efc54bffe85fa2807f0f4adc493"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"bac8035d78df3cc8acd9b62aec9303278dcfc55d","unresolved":false,"context_lines":[{"line_number":160,"context_line":"Performance Impact"},{"line_number":161,"context_line":"------------------"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Authenticating via API key will require hashing in order to validate the API"},{"line_number":164,"context_line":"key information provided in the request against any pre-existing API keys. The"},{"line_number":165,"context_line":"performance impact of hashing should be documented in the implementation, but"},{"line_number":166,"context_line":"should be no different than what is currently done for password authentication"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba2be162_2b94de35","line":163,"range":{"start_line":163,"start_character":0,"end_line":163,"end_character":48},"updated":"2017-03-01 09:05:51.000000000","message":"this seems odd here, since we haven\u0027t explain any hashing issues before this point. I assume it is because the value of an API key is the hash of its attributes? Is the has two way? Or do we store the API key attributes in the DB and the hash is just for validation?","commit_id":"b0aff0e7a5444efc54bffe85fa2807f0f4adc493"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"171aca850be4a7c2ce187aa9b6c41b1ab9e1699e","unresolved":false,"context_lines":[{"line_number":160,"context_line":"Performance Impact"},{"line_number":161,"context_line":"------------------"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Authenticating via API key will require hashing in order to validate the API"},{"line_number":164,"context_line":"key information provided in the request against any pre-existing API keys. The"},{"line_number":165,"context_line":"performance impact of hashing should be documented in the implementation, but"},{"line_number":166,"context_line":"should be no different than what is currently done for password authentication"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba2be162_fa050ec2","line":163,"range":{"start_line":163,"start_character":0,"end_line":163,"end_character":48},"in_reply_to":"ba2be162_2b94de35","updated":"2017-03-01 20:49:22.000000000","message":"I think it\u0027s likely to be the latter, one-way hashing, just for validation. And because we are already doing this for password authentication, there really shouldn\u0027t be a performance impact. Thus, taking this out.","commit_id":"b0aff0e7a5444efc54bffe85fa2807f0f4adc493"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"70deebe0834958492679ee95ebe8f162ea4064fc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"`bp api-keys \u003chttps://blueprints.launchpad.net/keystone/+spec/api-keys\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implement API access keys as a new credential type in order to improve security"},{"line_number":14,"context_line":"by limiting access and not embedding user credentials in configuration files."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem Description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_f02c4d4c","line":14,"range":{"start_line":14,"start_character":27,"end_line":14,"end_character":76},"updated":"2017-03-01 21:24:37.000000000","message":"But you still have the API access key in the configuration file, its just a different credential.","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"478a19504765d42c22108a9c5b9b9795aa86ee95","unresolved":false,"context_lines":[{"line_number":11,"context_line":"`bp api-keys \u003chttps://blueprints.launchpad.net/keystone/+spec/api-keys\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implement API access keys as a new credential type in order to improve security"},{"line_number":14,"context_line":"by limiting access and not embedding user credentials in configuration files."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem Description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_a6d9bf85","line":14,"range":{"start_line":14,"start_character":27,"end_line":14,"end_character":76},"in_reply_to":"ba2be162_4b13ae66","updated":"2017-03-01 22:10:13.000000000","message":"Also, you can set access keys to expire.","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"8c89d016e3eebb0175930980348dd7339cdc8dee","unresolved":false,"context_lines":[{"line_number":11,"context_line":"`bp api-keys \u003chttps://blueprints.launchpad.net/keystone/+spec/api-keys\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implement API access keys as a new credential type in order to improve security"},{"line_number":14,"context_line":"by limiting access and not embedding user credentials in configuration files."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem Description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_dc45a2b3","line":14,"range":{"start_line":14,"start_character":27,"end_line":14,"end_character":76},"in_reply_to":"ba2be162_4b13ae66","updated":"2017-03-01 23:26:35.000000000","message":"But I can already today grant a role to a service user with limited access.  I think this is still being advertised wrong. I do think an API key is nice, as a convenience for scripting and services, etc, but it\u0027s not more secure than what you can do today.","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"54493bed08215a4e6d37fed627668c0d3f517872","unresolved":false,"context_lines":[{"line_number":11,"context_line":"`bp api-keys \u003chttps://blueprints.launchpad.net/keystone/+spec/api-keys\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implement API access keys as a new credential type in order to improve security"},{"line_number":14,"context_line":"by limiting access and not embedding user credentials in configuration files."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem Description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_3ffa26be","line":14,"range":{"start_line":14,"start_character":27,"end_line":14,"end_character":76},"in_reply_to":"ba2be162_dc45a2b3","updated":"2017-03-02 05:18:18.000000000","message":"It is more secure for users that cannot limit access because they don\u0027t have privileges to create users. But see your point regarding service users.","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"3ba939bc1caf33f9ec8af2fd2c9a97ce0c7d5b54","unresolved":false,"context_lines":[{"line_number":11,"context_line":"`bp api-keys \u003chttps://blueprints.launchpad.net/keystone/+spec/api-keys\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implement API access keys as a new credential type in order to improve security"},{"line_number":14,"context_line":"by limiting access and not embedding user credentials in configuration files."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem Description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_4b13ae66","line":14,"range":{"start_line":14,"start_character":27,"end_line":14,"end_character":76},"in_reply_to":"ba2be162_f02c4d4c","updated":"2017-03-01 22:08:06.000000000","message":"It is, but with limited access (only a subset of roles). And the key is a random hash value and not actually a user\u0027s password (identity theft).","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"70deebe0834958492679ee95ebe8f162ea4064fc","unresolved":false,"context_lines":[{"line_number":18,"context_line":"As an OpenStack user, I want to create routine jobs that programmatically"},{"line_number":19,"context_line":"request a token and make API calls for resources in my project. To accomplish"},{"line_number":20,"context_line":"this, one will typically store user credentials in a configuration file so that"},{"line_number":21,"context_line":"scripts can access the OpenStack API. Having user credentials in configuration"},{"line_number":22,"context_line":"files and/or embedding them into a virtual machine, creates a potential"},{"line_number":23,"context_line":"security risk. Likewise, by using a user\u0027s credentials, the jobs or services"},{"line_number":24,"context_line":"will have all of a user\u0027s access and likely, more access than needed."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Similarly, if a service in OpenStack needs to communicate to other services via"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_50e199fd","line":23,"range":{"start_line":21,"start_character":38,"end_line":23,"end_character":14},"updated":"2017-03-01 21:24:37.000000000","message":"This risk is the same, since you still have the key in the config file.","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"54493bed08215a4e6d37fed627668c0d3f517872","unresolved":false,"context_lines":[{"line_number":18,"context_line":"As an OpenStack user, I want to create routine jobs that programmatically"},{"line_number":19,"context_line":"request a token and make API calls for resources in my project. To accomplish"},{"line_number":20,"context_line":"this, one will typically store user credentials in a configuration file so that"},{"line_number":21,"context_line":"scripts can access the OpenStack API. Having user credentials in configuration"},{"line_number":22,"context_line":"files and/or embedding them into a virtual machine, creates a potential"},{"line_number":23,"context_line":"security risk. Likewise, by using a user\u0027s credentials, the jobs or services"},{"line_number":24,"context_line":"will have all of a user\u0027s access and likely, more access than needed."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Similarly, if a service in OpenStack needs to communicate to other services via"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_3fe866e2","line":23,"range":{"start_line":21,"start_character":38,"end_line":23,"end_character":14},"in_reply_to":"ba2be162_1c649a47","updated":"2017-03-02 05:18:18.000000000","message":"In this paragraph, I\u0027m not referring to service users.","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"3ba939bc1caf33f9ec8af2fd2c9a97ce0c7d5b54","unresolved":false,"context_lines":[{"line_number":18,"context_line":"As an OpenStack user, I want to create routine jobs that programmatically"},{"line_number":19,"context_line":"request a token and make API calls for resources in my project. To accomplish"},{"line_number":20,"context_line":"this, one will typically store user credentials in a configuration file so that"},{"line_number":21,"context_line":"scripts can access the OpenStack API. Having user credentials in configuration"},{"line_number":22,"context_line":"files and/or embedding them into a virtual machine, creates a potential"},{"line_number":23,"context_line":"security risk. Likewise, by using a user\u0027s credentials, the jobs or services"},{"line_number":24,"context_line":"will have all of a user\u0027s access and likely, more access than needed."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Similarly, if a service in OpenStack needs to communicate to other services via"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_6b16b256","line":23,"range":{"start_line":21,"start_character":38,"end_line":23,"end_character":14},"in_reply_to":"ba2be162_50e199fd","updated":"2017-03-01 22:08:06.000000000","message":"This risk is not the same, see comment above.","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"8c89d016e3eebb0175930980348dd7339cdc8dee","unresolved":false,"context_lines":[{"line_number":18,"context_line":"As an OpenStack user, I want to create routine jobs that programmatically"},{"line_number":19,"context_line":"request a token and make API calls for resources in my project. To accomplish"},{"line_number":20,"context_line":"this, one will typically store user credentials in a configuration file so that"},{"line_number":21,"context_line":"scripts can access the OpenStack API. Having user credentials in configuration"},{"line_number":22,"context_line":"files and/or embedding them into a virtual machine, creates a potential"},{"line_number":23,"context_line":"security risk. Likewise, by using a user\u0027s credentials, the jobs or services"},{"line_number":24,"context_line":"will have all of a user\u0027s access and likely, more access than needed."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Similarly, if a service in OpenStack needs to communicate to other services via"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_1c649a47","line":23,"range":{"start_line":21,"start_character":38,"end_line":23,"end_character":14},"in_reply_to":"ba2be162_6b16b256","updated":"2017-03-01 23:26:35.000000000","message":"I could limit role access to a service user the same way you state you would do with an API key.","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"8c89d016e3eebb0175930980348dd7339cdc8dee","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        }"},{"line_number":118,"context_line":"    }"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"This improves security as API access keys will have limited access; can be"},{"line_number":121,"context_line":"rotated and securely stored in configuration files. Services can replace"},{"line_number":122,"context_line":"username/password with access key id/value in their configuration files, so"},{"line_number":123,"context_line":"that the root account credentials are never exposed."}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_9cd7aabe","line":120,"range":{"start_line":120,"start_character":26,"end_line":120,"end_character":66},"updated":"2017-03-01 23:26:35.000000000","message":"same can be done with a service user","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"70deebe0834958492679ee95ebe8f162ea4064fc","unresolved":false,"context_lines":[{"line_number":120,"context_line":"This improves security as API access keys will have limited access; can be"},{"line_number":121,"context_line":"rotated and securely stored in configuration files. Services can replace"},{"line_number":122,"context_line":"username/password with access key id/value in their configuration files, so"},{"line_number":123,"context_line":"that the root account credentials are never exposed."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Alternatives"},{"line_number":126,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_6d788ac5","line":123,"range":{"start_line":123,"start_character":9,"end_line":123,"end_character":33},"updated":"2017-03-01 21:24:37.000000000","message":"root account? Do you mean an admin user such as nova, cinder, glance, etc?","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"3ba939bc1caf33f9ec8af2fd2c9a97ce0c7d5b54","unresolved":false,"context_lines":[{"line_number":120,"context_line":"This improves security as API access keys will have limited access; can be"},{"line_number":121,"context_line":"rotated and securely stored in configuration files. Services can replace"},{"line_number":122,"context_line":"username/password with access key id/value in their configuration files, so"},{"line_number":123,"context_line":"that the root account credentials are never exposed."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Alternatives"},{"line_number":126,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_863bdbd0","line":123,"range":{"start_line":123,"start_character":9,"end_line":123,"end_character":33},"in_reply_to":"ba2be162_6d788ac5","updated":"2017-03-01 22:08:06.000000000","message":"Yes, I mean the user\u0027s credentials.","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"70deebe0834958492679ee95ebe8f162ea4064fc","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"This would have a positive security impact:"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"* Instead of having a service user for each service, all services can use a"},{"line_number":140,"context_line":"  single service account. This decreases the attack vector of gaining access to"},{"line_number":141,"context_line":"  privileged operations by reducing the number of accounts to attack."},{"line_number":142,"context_line":"* User names and passwords are kept out of configuration files. While API keys"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_9078712d","line":139,"range":{"start_line":139,"start_character":2,"end_line":139,"end_character":51},"updated":"2017-03-01 21:24:37.000000000","message":"I think this is a good thing. Having each service with a unique user is great for debugging, auditing, etc.","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"1c5b5aaa8857d68a1f3d88df4b6d8b48ed75b033","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"This would have a positive security impact:"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"* Instead of having a service user for each service, all services can use a"},{"line_number":140,"context_line":"  single service account. This decreases the attack vector of gaining access to"},{"line_number":141,"context_line":"  privileged operations by reducing the number of accounts to attack."},{"line_number":142,"context_line":"* User names and passwords are kept out of configuration files. While API keys"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_e6bad709","line":139,"range":{"start_line":139,"start_character":2,"end_line":139,"end_character":51},"in_reply_to":"ba2be162_9078712d","updated":"2017-03-01 22:11:37.000000000","message":"You will still be able to trace an access key to a specific user.","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"8c89d016e3eebb0175930980348dd7339cdc8dee","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"This would have a positive security impact:"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"* Instead of having a service user for each service, all services can use a"},{"line_number":140,"context_line":"  single service account. This decreases the attack vector of gaining access to"},{"line_number":141,"context_line":"  privileged operations by reducing the number of accounts to attack."},{"line_number":142,"context_line":"* User names and passwords are kept out of configuration files. While API keys"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_7c7836c5","line":139,"range":{"start_line":139,"start_character":2,"end_line":139,"end_character":51},"in_reply_to":"ba2be162_e6bad709","updated":"2017-03-01 23:26:35.000000000","message":"Right, so I don\u0027t think I would prefer to use the same service account for all services. Unless the debug and auditing will always tell me what service the key is being used for.","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"70deebe0834958492679ee95ebe8f162ea4064fc","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"This would have a positive security impact:"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"* Instead of having a service user for each service, all services can use a"},{"line_number":140,"context_line":"  single service account. This decreases the attack vector of gaining access to"},{"line_number":141,"context_line":"  privileged operations by reducing the number of accounts to attack."},{"line_number":142,"context_line":"* User names and passwords are kept out of configuration files. While API keys"},{"line_number":143,"context_line":"  are still extremely sensitive, if compromised they do not allow attackers to"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_ad30c202","line":140,"range":{"start_line":139,"start_character":53,"end_line":140,"end_character":24},"updated":"2017-03-01 21:24:37.000000000","message":"If a user is limited to 5 API keys (see above), then I guess you can only use 5 services, right?","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"3ba939bc1caf33f9ec8af2fd2c9a97ce0c7d5b54","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"This would have a positive security impact:"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"* Instead of having a service user for each service, all services can use a"},{"line_number":140,"context_line":"  single service account. This decreases the attack vector of gaining access to"},{"line_number":141,"context_line":"  privileged operations by reducing the number of accounts to attack."},{"line_number":142,"context_line":"* User names and passwords are kept out of configuration files. While API keys"},{"line_number":143,"context_line":"  are still extremely sensitive, if compromised they do not allow attackers to"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_8642fb3c","line":140,"range":{"start_line":139,"start_character":53,"end_line":140,"end_character":24},"in_reply_to":"ba2be162_ad30c202","updated":"2017-03-01 22:08:06.000000000","message":"Or, create another user for the other services.","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"70deebe0834958492679ee95ebe8f162ea4064fc","unresolved":false,"context_lines":[{"line_number":139,"context_line":"* Instead of having a service user for each service, all services can use a"},{"line_number":140,"context_line":"  single service account. This decreases the attack vector of gaining access to"},{"line_number":141,"context_line":"  privileged operations by reducing the number of accounts to attack."},{"line_number":142,"context_line":"* User names and passwords are kept out of configuration files. While API keys"},{"line_number":143,"context_line":"  are still extremely sensitive, if compromised they do not allow attackers to"},{"line_number":144,"context_line":"  glean service user password conventions from configuration."},{"line_number":145,"context_line":"* API keys have limited access; only the access required to complete the job."},{"line_number":146,"context_line":"* API keys can be gracefully rotated out of use and deleted periodically,"},{"line_number":147,"context_line":"  allowing operators another way to prevent compromised service accounts in"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_9092319e","line":144,"range":{"start_line":142,"start_character":2,"end_line":144,"end_character":61},"updated":"2017-03-01 21:24:37.000000000","message":"This really doesn\u0027t seem that much better. The client certificate solution I believe was a more secure alternative to passwords in files than this.\n\nhttps://review.openstack.org/#/c/105913/","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"8c89d016e3eebb0175930980348dd7339cdc8dee","unresolved":false,"context_lines":[{"line_number":139,"context_line":"* Instead of having a service user for each service, all services can use a"},{"line_number":140,"context_line":"  single service account. This decreases the attack vector of gaining access to"},{"line_number":141,"context_line":"  privileged operations by reducing the number of accounts to attack."},{"line_number":142,"context_line":"* User names and passwords are kept out of configuration files. While API keys"},{"line_number":143,"context_line":"  are still extremely sensitive, if compromised they do not allow attackers to"},{"line_number":144,"context_line":"  glean service user password conventions from configuration."},{"line_number":145,"context_line":"* API keys have limited access; only the access required to complete the job."},{"line_number":146,"context_line":"* API keys can be gracefully rotated out of use and deleted periodically,"},{"line_number":147,"context_line":"  allowing operators another way to prevent compromised service accounts in"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_bc30ee02","line":144,"range":{"start_line":142,"start_character":2,"end_line":144,"end_character":61},"in_reply_to":"ba2be162_466f23c5","updated":"2017-03-01 23:26:35.000000000","message":"So this is why I think this is misleading.\n\n- I could give the API key admin role, thus with that key I could do all the same things as a user/pwd with admin role. That would be a bad idea, but proves its just as bad.\n\n- Conversely, I could limit the role of the user/pwd is the exact same way as this API key. This would be a good idea, and can already be done today.\n\nTherefore, I don\u0027t see any difference in security.","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"3ba939bc1caf33f9ec8af2fd2c9a97ce0c7d5b54","unresolved":false,"context_lines":[{"line_number":139,"context_line":"* Instead of having a service user for each service, all services can use a"},{"line_number":140,"context_line":"  single service account. This decreases the attack vector of gaining access to"},{"line_number":141,"context_line":"  privileged operations by reducing the number of accounts to attack."},{"line_number":142,"context_line":"* User names and passwords are kept out of configuration files. While API keys"},{"line_number":143,"context_line":"  are still extremely sensitive, if compromised they do not allow attackers to"},{"line_number":144,"context_line":"  glean service user password conventions from configuration."},{"line_number":145,"context_line":"* API keys have limited access; only the access required to complete the job."},{"line_number":146,"context_line":"* API keys can be gracefully rotated out of use and deleted periodically,"},{"line_number":147,"context_line":"  allowing operators another way to prevent compromised service accounts in"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_466f23c5","line":144,"range":{"start_line":142,"start_character":2,"end_line":144,"end_character":61},"in_reply_to":"ba2be162_9092319e","updated":"2017-03-01 22:08:06.000000000","message":"Again, with access keys you have limited access and the user\u0027s password is never exposed in config files.","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"54493bed08215a4e6d37fed627668c0d3f517872","unresolved":false,"context_lines":[{"line_number":139,"context_line":"* Instead of having a service user for each service, all services can use a"},{"line_number":140,"context_line":"  single service account. This decreases the attack vector of gaining access to"},{"line_number":141,"context_line":"  privileged operations by reducing the number of accounts to attack."},{"line_number":142,"context_line":"* User names and passwords are kept out of configuration files. While API keys"},{"line_number":143,"context_line":"  are still extremely sensitive, if compromised they do not allow attackers to"},{"line_number":144,"context_line":"  glean service user password conventions from configuration."},{"line_number":145,"context_line":"* API keys have limited access; only the access required to complete the job."},{"line_number":146,"context_line":"* API keys can be gracefully rotated out of use and deleted periodically,"},{"line_number":147,"context_line":"  allowing operators another way to prevent compromised service accounts in"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_ec4d4e9a","line":144,"range":{"start_line":142,"start_character":2,"end_line":144,"end_character":61},"in_reply_to":"ba2be162_bc30ee02","updated":"2017-03-02 05:18:18.000000000","message":"I see your point, however this statement is still accurate \"While API keys are still extremely sensitive, if compromised they do not allow attackers to glean service user password conventions from configuration.\"","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"70deebe0834958492679ee95ebe8f162ea4064fc","unresolved":false,"context_lines":[{"line_number":142,"context_line":"* User names and passwords are kept out of configuration files. While API keys"},{"line_number":143,"context_line":"  are still extremely sensitive, if compromised they do not allow attackers to"},{"line_number":144,"context_line":"  glean service user password conventions from configuration."},{"line_number":145,"context_line":"* API keys have limited access; only the access required to complete the job."},{"line_number":146,"context_line":"* API keys can be gracefully rotated out of use and deleted periodically,"},{"line_number":147,"context_line":"  allowing operators another way to prevent compromised service accounts in"},{"line_number":148,"context_line":"  combination with regular password rotation."}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_1051e10e","line":145,"range":{"start_line":145,"start_character":2,"end_line":145,"end_character":77},"updated":"2017-03-01 21:24:37.000000000","message":"Could you detail how this will work?","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"3ba939bc1caf33f9ec8af2fd2c9a97ce0c7d5b54","unresolved":false,"context_lines":[{"line_number":142,"context_line":"* User names and passwords are kept out of configuration files. While API keys"},{"line_number":143,"context_line":"  are still extremely sensitive, if compromised they do not allow attackers to"},{"line_number":144,"context_line":"  glean service user password conventions from configuration."},{"line_number":145,"context_line":"* API keys have limited access; only the access required to complete the job."},{"line_number":146,"context_line":"* API keys can be gracefully rotated out of use and deleted periodically,"},{"line_number":147,"context_line":"  allowing operators another way to prevent compromised service accounts in"},{"line_number":148,"context_line":"  combination with regular password rotation."}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_46a64311","line":145,"range":{"start_line":145,"start_character":2,"end_line":145,"end_character":77},"in_reply_to":"ba2be162_1051e10e","updated":"2017-03-01 22:08:06.000000000","message":"See the create request above, the user specifies the roles to associate with the access key. And we would add validation, so that you could only add roles that you have been assigned.","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"70deebe0834958492679ee95ebe8f162ea4064fc","unresolved":false,"context_lines":[{"line_number":143,"context_line":"  are still extremely sensitive, if compromised they do not allow attackers to"},{"line_number":144,"context_line":"  glean service user password conventions from configuration."},{"line_number":145,"context_line":"* API keys have limited access; only the access required to complete the job."},{"line_number":146,"context_line":"* API keys can be gracefully rotated out of use and deleted periodically,"},{"line_number":147,"context_line":"  allowing operators another way to prevent compromised service accounts in"},{"line_number":148,"context_line":"  combination with regular password rotation."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"That being said, there is an inherent risk with adding a new credential type"},{"line_number":151,"context_line":"and changing authentication details. One security risk would be the allowing of"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_103ba19d","line":148,"range":{"start_line":146,"start_character":2,"end_line":148,"end_character":45},"updated":"2017-03-01 21:24:37.000000000","message":"I think the nice benefit here is the ability to have several active API keys whereas with password only one is active. So should make it easier for rotation.","commit_id":"009d1fe79863f601f5c7cbef6dcaceda3539c8a4"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ecd664ff10d3e17a3c75097b4af22c9371971c14","unresolved":false,"context_lines":[{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":"Implement an API access key as a new credential type in keystone."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"API access key requirements:"},{"line_number":42,"context_line":"* Must be immutable"},{"line_number":43,"context_line":"* Allow for limits, e.g. 5 API access keys per user."},{"line_number":44,"context_line":"* Can only contain roles that the user has on a project."}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba2be162_5f80168b","line":41,"updated":"2017-03-06 16:54:46.000000000","message":"We need to have a new line in here for the list to render properly.\n\nhttp://docs-draft.openstack.org/61/438761/12/check/gate-keystone-specs-docs-ubuntu-xenial/0d9e890//doc/build/html/specs/keystone/pike/api-keys.html","commit_id":"1f1b435a1265642c45d817620f9ee5c6ce7abef4"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"7971185e2f2555c4682dd83335d5277742d7b13c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":"Implement an API access key as a new credential type in keystone."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"API access key requirements:"},{"line_number":42,"context_line":"* Must be immutable"},{"line_number":43,"context_line":"* Allow for limits, e.g. 5 API access keys per user."},{"line_number":44,"context_line":"* Can only contain roles that the user has on a project."}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba2be162_3108f22d","line":41,"in_reply_to":"ba2be162_5f80168b","updated":"2017-03-06 17:12:17.000000000","message":"Fix in a subsequent patch (minor)? And lets push this through :)","commit_id":"1f1b435a1265642c45d817620f9ee5c6ce7abef4"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ecd664ff10d3e17a3c75097b4af22c9371971c14","unresolved":false,"context_lines":[{"line_number":47,"context_line":"* Should support the ability to expire"},{"line_number":48,"context_line":"* Should have a description field"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"By default, users with a member role should be able to list, add, and delete"},{"line_number":51,"context_line":"API access keys for their account. For example, adding an API access key:"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":".. code:: javascript"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba2be162_6eb52b30","line":50,"updated":"2017-03-06 16:54:46.000000000","message":"Users with a member role or any authenticated user?","commit_id":"1f1b435a1265642c45d817620f9ee5c6ce7abef4"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"666db060383fb4e44e593e1896b2ac28eaa1c96a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"* Should support the ability to expire"},{"line_number":48,"context_line":"* Should have a description field"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"By default, users with a member role should be able to list, add, and delete"},{"line_number":51,"context_line":"API access keys for their account. For example, adding an API access key:"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":".. code:: javascript"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3a1ff146_d6e86219","line":50,"in_reply_to":"3a1ff146_39ac53ed","updated":"2017-03-14 19:46:53.000000000","message":"Only that non-admin users be able to create access keys.","commit_id":"1f1b435a1265642c45d817620f9ee5c6ce7abef4"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"304bb5e1bd3c8471076da6b809a864208ce44e09","unresolved":false,"context_lines":[{"line_number":47,"context_line":"* Should support the ability to expire"},{"line_number":48,"context_line":"* Should have a description field"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"By default, users with a member role should be able to list, add, and delete"},{"line_number":51,"context_line":"API access keys for their account. For example, adding an API access key:"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":".. code:: javascript"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3a1ff146_39ac53ed","line":50,"in_reply_to":"7a25e98e_e6a4d309","updated":"2017-03-14 19:36:18.000000000","message":"I agree, requiring a role would make this more complicated I think. What\u0027s the rationale for requiring a specific role?","commit_id":"1f1b435a1265642c45d817620f9ee5c6ce7abef4"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"58a9366c54e17d99259efbdf0010ab76d8fcda28","unresolved":false,"context_lines":[{"line_number":47,"context_line":"* Should support the ability to expire"},{"line_number":48,"context_line":"* Should have a description field"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"By default, users with a member role should be able to list, add, and delete"},{"line_number":51,"context_line":"API access keys for their account. For example, adding an API access key:"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":".. code:: javascript"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba2be162_91727eaf","line":50,"in_reply_to":"ba2be162_6eb52b30","updated":"2017-03-06 17:04:37.000000000","message":"I\u0027m thinking user with a member role on a project as a minimum.","commit_id":"1f1b435a1265642c45d817620f9ee5c6ce7abef4"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"c2b6678b163900ebd668c8b587ef3c55ab6085c5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"* Should support the ability to expire"},{"line_number":48,"context_line":"* Should have a description field"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"By default, users with a member role should be able to list, add, and delete"},{"line_number":51,"context_line":"API access keys for their account. For example, adding an API access key:"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":".. code:: javascript"}],"source_content_type":"text/x-rst","patch_set":12,"id":"7a25e98e_e6a4d309","line":50,"in_reply_to":"ba2be162_91727eaf","updated":"2017-03-13 22:27:16.000000000","message":"Whilst i don\u0027t object this may be something to talk to dolph about because we\u0027ve had problem defining a standard member role in the past.","commit_id":"1f1b435a1265642c45d817620f9ee5c6ce7abef4"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"c2b6678b163900ebd668c8b587ef3c55ab6085c5","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            },"},{"line_number":103,"context_line":"            \"scope\": {"},{"line_number":104,"context_line":"                \"project\": {"},{"line_number":105,"context_line":"                    \"id\": \"9f3d967a326d4ec28f1ae9d57e6c7bc6\""},{"line_number":106,"context_line":"                }"},{"line_number":107,"context_line":"            }"},{"line_number":108,"context_line":"        }"}],"source_content_type":"text/x-rst","patch_set":12,"id":"7a25e98e_66e70341","line":105,"updated":"2017-03-13 22:27:16.000000000","message":"We could check that id is the same as access_token project_id, but really you shouldn\u0027t need to specify this as you can ONLY get access to the project_id in the access_token.","commit_id":"1f1b435a1265642c45d817620f9ee5c6ce7abef4"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"304bb5e1bd3c8471076da6b809a864208ce44e09","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            },"},{"line_number":103,"context_line":"            \"scope\": {"},{"line_number":104,"context_line":"                \"project\": {"},{"line_number":105,"context_line":"                    \"id\": \"9f3d967a326d4ec28f1ae9d57e6c7bc6\""},{"line_number":106,"context_line":"                }"},{"line_number":107,"context_line":"            }"},{"line_number":108,"context_line":"        }"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3a1ff146_3948d32d","line":105,"in_reply_to":"7a25e98e_66e70341","updated":"2017-03-14 19:36:18.000000000","message":"Yeah - that seems like an extra validation step we have to do that isn\u0027t necessary. We could just not expect a scope and completely rely on scope being set by the API key.","commit_id":"1f1b435a1265642c45d817620f9ee5c6ce7abef4"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"1ab22cee2d3c84fb93e0849aa602c7ad93fa8097","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"This improves security as API access keys will have limited access; can be"},{"line_number":115,"context_line":"rotated and securely stored in configuration files. Especially for users that"},{"line_number":116,"context_line":"do not have privilages to create users with limited access, but do have a need"},{"line_number":117,"context_line":"to provide authentication credentials to a script or a 3rd party application."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"And as an alternative for service users, you could create a single service user"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba2be162_526f6b2a","line":116,"range":{"start_line":116,"start_character":12,"end_line":116,"end_character":22},"updated":"2017-03-03 19:02:10.000000000","message":"privileges","commit_id":"1f1b435a1265642c45d817620f9ee5c6ce7abef4"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ecd664ff10d3e17a3c75097b4af22c9371971c14","unresolved":false,"context_lines":[{"line_number":114,"context_line":"This improves security as API access keys will have limited access; can be"},{"line_number":115,"context_line":"rotated and securely stored in configuration files. Especially for users that"},{"line_number":116,"context_line":"do not have privilages to create users with limited access, but do have a need"},{"line_number":117,"context_line":"to provide authentication credentials to a script or a 3rd party application."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"And as an alternative for service users, you could create a single service user"},{"line_number":120,"context_line":"with an API access key for each service. Thus, services can then replace"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba2be162_ceb29706","line":117,"updated":"2017-03-06 16:54:46.000000000","message":"Are we going to *require* API keys to have a subset of the permissions a user has?","commit_id":"1f1b435a1265642c45d817620f9ee5c6ce7abef4"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"db968e0fa592dd0d75a16702961d7f7eaf26d2cb","unresolved":false,"context_lines":[{"line_number":114,"context_line":"This improves security as API access keys will have limited access; can be"},{"line_number":115,"context_line":"rotated and securely stored in configuration files. Especially for users that"},{"line_number":116,"context_line":"do not have privilages to create users with limited access, but do have a need"},{"line_number":117,"context_line":"to provide authentication credentials to a script or a 3rd party application."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"And as an alternative for service users, you could create a single service user"},{"line_number":120,"context_line":"with an API access key for each service. Thus, services can then replace"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3a1ff146_55799dfb","line":117,"in_reply_to":"3a1ff146_961a6a16","updated":"2017-03-15 16:56:21.000000000","message":"Oops, I see you were referring to only requiring a subset of roles. Yeah, it is different, but I\u0027m open to limiting this as well if there is good justification for doing so.","commit_id":"1f1b435a1265642c45d817620f9ee5c6ce7abef4"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"666db060383fb4e44e593e1896b2ac28eaa1c96a","unresolved":false,"context_lines":[{"line_number":114,"context_line":"This improves security as API access keys will have limited access; can be"},{"line_number":115,"context_line":"rotated and securely stored in configuration files. Especially for users that"},{"line_number":116,"context_line":"do not have privilages to create users with limited access, but do have a need"},{"line_number":117,"context_line":"to provide authentication credentials to a script or a 3rd party application."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"And as an alternative for service users, you could create a single service user"},{"line_number":120,"context_line":"with an API access key for each service. Thus, services can then replace"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3a1ff146_961a6a16","line":117,"in_reply_to":"3a1ff146_b9be83d2","updated":"2017-03-14 19:46:53.000000000","message":"It\u0027s actually pretty similar, the main difference is using the access key to request a scoped token. I think not having to request a scoped token can be future work.","commit_id":"1f1b435a1265642c45d817620f9ee5c6ce7abef4"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"304bb5e1bd3c8471076da6b809a864208ce44e09","unresolved":false,"context_lines":[{"line_number":114,"context_line":"This improves security as API access keys will have limited access; can be"},{"line_number":115,"context_line":"rotated and securely stored in configuration files. Especially for users that"},{"line_number":116,"context_line":"do not have privilages to create users with limited access, but do have a need"},{"line_number":117,"context_line":"to provide authentication credentials to a script or a 3rd party application."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"And as an alternative for service users, you could create a single service user"},{"line_number":120,"context_line":"with an API access key for each service. Thus, services can then replace"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3a1ff146_b9be83d2","line":117,"in_reply_to":"ba2be162_b1a4e2b9","updated":"2017-03-14 19:36:18.000000000","message":"This is quite a bit different from what David had in his proposal:\n\nhttps://review.openstack.org/#/c/440593/1/specs/keystone/pike/api-keys.rst","commit_id":"1f1b435a1265642c45d817620f9ee5c6ce7abef4"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"58a9366c54e17d99259efbdf0010ab76d8fcda28","unresolved":false,"context_lines":[{"line_number":114,"context_line":"This improves security as API access keys will have limited access; can be"},{"line_number":115,"context_line":"rotated and securely stored in configuration files. Especially for users that"},{"line_number":116,"context_line":"do not have privilages to create users with limited access, but do have a need"},{"line_number":117,"context_line":"to provide authentication credentials to a script or a 3rd party application."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"And as an alternative for service users, you could create a single service user"},{"line_number":120,"context_line":"with an API access key for each service. Thus, services can then replace"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba2be162_b1a4e2b9","line":117,"in_reply_to":"ba2be162_ceb29706","updated":"2017-03-06 17:04:37.000000000","message":"No, you may want to create an API key with all of your roles, but still take advantage of key expiration and not exposing your user credentials in config files.","commit_id":"1f1b435a1265642c45d817620f9ee5c6ce7abef4"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"1ab22cee2d3c84fb93e0849aa602c7ad93fa8097","unresolved":false,"context_lines":[{"line_number":119,"context_line":"And as an alternative for service users, you could create a single service user"},{"line_number":120,"context_line":"with an API access key for each service. Thus, services can then replace"},{"line_number":121,"context_line":"username/password with access key id/value in their configuration files, so"},{"line_number":122,"context_line":"that the root service account credentials are never exposed. That being said,"},{"line_number":123,"context_line":"you can already limit access for service users, so it\u0027s not the main use case"},{"line_number":124,"context_line":"here, but gives operators additional options."},{"line_number":125,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba2be162_7201cf37","line":122,"range":{"start_line":122,"start_character":9,"end_line":122,"end_character":13},"updated":"2017-03-03 19:02:10.000000000","message":"What\u0027s a root service account in the context of openstack?","commit_id":"1f1b435a1265642c45d817620f9ee5c6ce7abef4"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d2c883c226a3a33a0a50cdb5d88530247331f76c","unresolved":false,"context_lines":[{"line_number":119,"context_line":"And as an alternative for service users, you could create a single service user"},{"line_number":120,"context_line":"with an API access key for each service. Thus, services can then replace"},{"line_number":121,"context_line":"username/password with access key id/value in their configuration files, so"},{"line_number":122,"context_line":"that the root service account credentials are never exposed. That being said,"},{"line_number":123,"context_line":"you can already limit access for service users, so it\u0027s not the main use case"},{"line_number":124,"context_line":"here, but gives operators additional options."},{"line_number":125,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3a1ff146_f651de0f","line":122,"in_reply_to":"7a25e98e_4648472e","updated":"2017-03-14 19:38:01.000000000","message":"Eventually - it would be nice to have a single service user with the ability to grant specific service roles to with API keys. That way each service endpoint gets an API key that is scoped to only the operations that service needs.","commit_id":"1f1b435a1265642c45d817620f9ee5c6ce7abef4"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"0fc88b6dc1f4ead11e2f57e6d0d40c144e6d1b93","unresolved":false,"context_lines":[{"line_number":119,"context_line":"And as an alternative for service users, you could create a single service user"},{"line_number":120,"context_line":"with an API access key for each service. Thus, services can then replace"},{"line_number":121,"context_line":"username/password with access key id/value in their configuration files, so"},{"line_number":122,"context_line":"that the root service account credentials are never exposed. That being said,"},{"line_number":123,"context_line":"you can already limit access for service users, so it\u0027s not the main use case"},{"line_number":124,"context_line":"here, but gives operators additional options."},{"line_number":125,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba2be162_bae799aa","line":122,"range":{"start_line":122,"start_character":9,"end_line":122,"end_character":13},"in_reply_to":"ba2be162_7201cf37","updated":"2017-03-03 21:12:02.000000000","message":"In this context, I\u0027m just referring to the single service user account that would be used for all services.","commit_id":"1f1b435a1265642c45d817620f9ee5c6ce7abef4"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"c2b6678b163900ebd668c8b587ef3c55ab6085c5","unresolved":false,"context_lines":[{"line_number":119,"context_line":"And as an alternative for service users, you could create a single service user"},{"line_number":120,"context_line":"with an API access key for each service. Thus, services can then replace"},{"line_number":121,"context_line":"username/password with access key id/value in their configuration files, so"},{"line_number":122,"context_line":"that the root service account credentials are never exposed. That being said,"},{"line_number":123,"context_line":"you can already limit access for service users, so it\u0027s not the main use case"},{"line_number":124,"context_line":"here, but gives operators additional options."},{"line_number":125,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"7a25e98e_4648472e","line":122,"range":{"start_line":122,"start_character":9,"end_line":122,"end_character":13},"in_reply_to":"ba2be162_bae799aa","updated":"2017-03-13 22:27:16.000000000","message":"In practice i think you would create a root \"nova\" user and then give each nova instance it\u0027s own access_key, rather than lump all the service accounts together.","commit_id":"1f1b435a1265642c45d817620f9ee5c6ce7abef4"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fa701b86bc76a5bc83a34b4dca26b3ce4ed12692","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"API Access Keys"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp api-keys \u003chttps://blueprints.launchpad.net/keystone/+spec/api-keys\u003e`_"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a1ced50_6c1306b9","line":8,"updated":"2017-03-20 19:36:17.000000000","message":"API Keys to be consistent with the commit message.","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"6ef1ec3dc53c6dc213f8412ca7660411aa818f48","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"API Access Keys"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp api-keys \u003chttps://blueprints.launchpad.net/keystone/+spec/api-keys\u003e`_"}],"source_content_type":"text/x-rst","patch_set":14,"id":"ffe62b97_ab11c4ae","line":8,"in_reply_to":"1a1ced50_6c1306b9","updated":"2017-03-27 17:40:20.000000000","message":"Done","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"10bfa71b14744ac4f761fcc902de778c0ffe3824","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    POST /v3/users/{user_id}/api_keys"},{"line_number":58,"context_line":"    {"},{"line_number":59,"context_line":"        \"api_key\": {"},{"line_number":60,"context_line":"            \"user_id\": \"094d9bd427104d89acd64e59b0b6adb4\","},{"line_number":61,"context_line":"            \"description\": \"Backup job...\","},{"line_number":62,"context_line":"            \"expires_at\": \"2017-11-06T15:32:17.000000\","},{"line_number":63,"context_line":"            \"project_id\": \"9f3d967a326d4ec28f1ae9d57e6c7bc6\""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a1ced50_3cdceee3","line":60,"range":{"start_line":60,"start_character":12,"end_line":60,"end_character":58},"updated":"2017-03-20 12:47:33.000000000","message":"user_id is already in the URL, it is not needed here.","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"6ef1ec3dc53c6dc213f8412ca7660411aa818f48","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    POST /v3/users/{user_id}/api_keys"},{"line_number":58,"context_line":"    {"},{"line_number":59,"context_line":"        \"api_key\": {"},{"line_number":60,"context_line":"            \"user_id\": \"094d9bd427104d89acd64e59b0b6adb4\","},{"line_number":61,"context_line":"            \"description\": \"Backup job...\","},{"line_number":62,"context_line":"            \"expires_at\": \"2017-11-06T15:32:17.000000\","},{"line_number":63,"context_line":"            \"project_id\": \"9f3d967a326d4ec28f1ae9d57e6c7bc6\""}],"source_content_type":"text/x-rst","patch_set":14,"id":"ffe62b97_4b77d803","line":60,"range":{"start_line":60,"start_character":12,"end_line":60,"end_character":58},"in_reply_to":"1a1ced50_3cdceee3","updated":"2017-03-27 17:40:20.000000000","message":"Done","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"10bfa71b14744ac4f761fcc902de778c0ffe3824","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        }"},{"line_number":82,"context_line":"    }"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"The id in the response is the API key identifier and would be returned"},{"line_number":85,"context_line":"in get or list API calls. However, the value would be a random string and only"},{"line_number":86,"context_line":"returned via the create API call."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Once created, the API key credentials can then be used to send requests to"},{"line_number":89,"context_line":"OpenStack APIs. For example, listing projects for a user:"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a1ced50_df2f4c3c","line":86,"range":{"start_line":84,"start_character":0,"end_line":86,"end_character":33},"updated":"2017-03-20 12:47:33.000000000","message":"this is not very clear to me, it is saying the API key ID would be returned in get or list API calls, but the value would be random (is this supposed to obfuscate the value?)? Only the create API key call will return the actual value?","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fa701b86bc76a5bc83a34b4dca26b3ce4ed12692","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"The id in the response is the API key identifier and would be returned"},{"line_number":85,"context_line":"in get or list API calls. However, the value would be a random string and only"},{"line_number":86,"context_line":"returned via the create API call."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Once created, the API key credentials can then be used to send requests to"},{"line_number":89,"context_line":"OpenStack APIs. For example, listing projects for a user:"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a1ced50_a7def93c","line":86,"in_reply_to":"1a1ced50_df2f4c3c","updated":"2017-03-20 19:36:17.000000000","message":"Yep - this is kind of a way to provide asymmetric properties of API keys.","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"c1ef65c69231c47d11a382d2516d542dea62f6b5","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    curl -s \\"},{"line_number":94,"context_line":"        -H \"Authorization: API-Key {id}:{value}\" \\"},{"line_number":95,"context_line":"        http://localhost:5000/v3/users/{user_id}/projects | python -mjson.tool"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"We can validate the API key by matching a hash of the key value associated with"},{"line_number":98,"context_line":"the id using passlib, similar to how we do password authentication."}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a1ced50_8a92069e","line":95,"range":{"start_line":95,"start_character":30,"end_line":95,"end_character":32},"updated":"2017-03-20 00:03:38.000000000","message":"If we don\u0027t get a token how do we know this URL (think non-keystone calls)? The current flow is you know 1 URL, the auth_url, you get back a token with a service catalog that tells you where to call the other services. \n\nIf we go and send the api-key directly to the service how do we do service/version discovery?","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"6ef1ec3dc53c6dc213f8412ca7660411aa818f48","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    curl -s \\"},{"line_number":94,"context_line":"        -H \"Authorization: API-Key {id}:{value}\" \\"},{"line_number":95,"context_line":"        http://localhost:5000/v3/users/{user_id}/projects | python -mjson.tool"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"We can validate the API key by matching a hash of the key value associated with"},{"line_number":98,"context_line":"the id using passlib, similar to how we do password authentication."}],"source_content_type":"text/x-rst","patch_set":14,"id":"ffe62b97_ee791a93","line":95,"range":{"start_line":95,"start_character":30,"end_line":95,"end_character":32},"in_reply_to":"1a1ced50_8a92069e","updated":"2017-03-27 17:40:20.000000000","message":"The client could call the service catalog API, but not sure how we would solve version.","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fa701b86bc76a5bc83a34b4dca26b3ce4ed12692","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    curl -s \\"},{"line_number":94,"context_line":"        -H \"Authorization: API-Key {id}:{value}\" \\"},{"line_number":95,"context_line":"        http://localhost:5000/v3/users/{user_id}/projects | python -mjson.tool"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"We can validate the API key by matching a hash of the key value associated with"},{"line_number":98,"context_line":"the id using passlib, similar to how we do password authentication."}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a1ced50_e7a471a7","line":95,"in_reply_to":"1a1ced50_8a92069e","updated":"2017-03-20 19:36:17.000000000","message":"Wouldn\u0027t this mean the client would have to make assumptions about this endpoint being available in the one URL it knows about?","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"c226471f7e391e78763502e0496a96d54b8007e5","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"We can validate the API key by matching a hash of the key value associated with"},{"line_number":98,"context_line":"the id using passlib, similar to how we do password authentication."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"This improves security as API keys will have limited access; can be rotated and"},{"line_number":101,"context_line":"securely stored in configuration files. Especially for users that do not have"},{"line_number":102,"context_line":"privileges to create users with limited access, but do have a need to provide"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3a1ff146_05b7db86","line":99,"updated":"2017-03-16 09:20:13.000000000","message":"so now that we are not using the api-key to obtain a token, we need to say something about what happens if the owner of the api-key as subsequently lost the roles included within it. I assume, we check at \"use time\" of an api-key that the roles are still valid?","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"6ef1ec3dc53c6dc213f8412ca7660411aa818f48","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"We can validate the API key by matching a hash of the key value associated with"},{"line_number":98,"context_line":"the id using passlib, similar to how we do password authentication."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"This improves security as API keys will have limited access; can be rotated and"},{"line_number":101,"context_line":"securely stored in configuration files. Especially for users that do not have"},{"line_number":102,"context_line":"privileges to create users with limited access, but do have a need to provide"}],"source_content_type":"text/x-rst","patch_set":14,"id":"ffe62b97_6193dba4","line":99,"in_reply_to":"1a1ced50_e7d2b1ff","updated":"2017-03-27 17:40:20.000000000","message":"Agree, we\u0027ll do similar validation for API keys.","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"bac513d1be796ac6081f8331ff46ec3b89f03a87","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"We can validate the API key by matching a hash of the key value associated with"},{"line_number":98,"context_line":"the id using passlib, similar to how we do password authentication."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"This improves security as API keys will have limited access; can be rotated and"},{"line_number":101,"context_line":"securely stored in configuration files. Especially for users that do not have"},{"line_number":102,"context_line":"privileges to create users with limited access, but do have a need to provide"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3a1ff146_6569608b","line":99,"in_reply_to":"3a1ff146_05b7db86","updated":"2017-03-16 15:00:41.000000000","message":"Correct, in the last keystone meeting it seemed that most people were in favor of not using API keys to obtain a token. Instead mirroring how API keys work in the industry.\n\nI agree with what you are saying regarding validating the roles. I\u0027ll update the spec. Thanks Henry.","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fa701b86bc76a5bc83a34b4dca26b3ce4ed12692","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"We can validate the API key by matching a hash of the key value associated with"},{"line_number":98,"context_line":"the id using passlib, similar to how we do password authentication."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"This improves security as API keys will have limited access; can be rotated and"},{"line_number":101,"context_line":"securely stored in configuration files. Especially for users that do not have"},{"line_number":102,"context_line":"privileges to create users with limited access, but do have a need to provide"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a1ced50_e7d2b1ff","line":99,"in_reply_to":"3a1ff146_6569608b","updated":"2017-03-20 19:36:17.000000000","message":"Yeah - regardless of if we get an API-key-scoped-token or validate the API-key in the token provider, the provider should validate and reconstruct whatever it needs about the API key, just like how we do token validation.","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"10bfa71b14744ac4f761fcc902de778c0ffe3824","unresolved":false,"context_lines":[{"line_number":97,"context_line":"We can validate the API key by matching a hash of the key value associated with"},{"line_number":98,"context_line":"the id using passlib, similar to how we do password authentication."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"This improves security as API keys will have limited access; can be rotated and"},{"line_number":101,"context_line":"securely stored in configuration files. Especially for users that do not have"},{"line_number":102,"context_line":"privileges to create users with limited access, but do have a need to provide"},{"line_number":103,"context_line":"authentication credentials to a script or a 3rd party application."}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a1ced50_9fd794ec","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":59},"updated":"2017-03-20 12:47:33.000000000","message":"Maybe elaborate a bit more here, explaining the \"limited access\" part.","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"3655b78b9edb4845f5e06d6be1a444c3a98a9206","unresolved":false,"context_lines":[{"line_number":97,"context_line":"We can validate the API key by matching a hash of the key value associated with"},{"line_number":98,"context_line":"the id using passlib, similar to how we do password authentication."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"This improves security as API keys will have limited access; can be rotated and"},{"line_number":101,"context_line":"securely stored in configuration files. Especially for users that do not have"},{"line_number":102,"context_line":"privileges to create users with limited access, but do have a need to provide"},{"line_number":103,"context_line":"authentication credentials to a script or a 3rd party application."}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a1ced50_7eefd51d","line":100,"in_reply_to":"1a1ced50_47ef05b0","updated":"2017-03-22 12:22:16.000000000","message":"sure... just want it to be explained in this paragraph.","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"6ef1ec3dc53c6dc213f8412ca7660411aa818f48","unresolved":false,"context_lines":[{"line_number":97,"context_line":"We can validate the API key by matching a hash of the key value associated with"},{"line_number":98,"context_line":"the id using passlib, similar to how we do password authentication."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"This improves security as API keys will have limited access; can be rotated and"},{"line_number":101,"context_line":"securely stored in configuration files. Especially for users that do not have"},{"line_number":102,"context_line":"privileges to create users with limited access, but do have a need to provide"},{"line_number":103,"context_line":"authentication credentials to a script or a 3rd party application."}],"source_content_type":"text/x-rst","patch_set":14,"id":"ffe62b97_aeae7295","line":100,"in_reply_to":"1a1ced50_7eefd51d","updated":"2017-03-27 17:40:20.000000000","message":"Done","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fa701b86bc76a5bc83a34b4dca26b3ce4ed12692","unresolved":false,"context_lines":[{"line_number":97,"context_line":"We can validate the API key by matching a hash of the key value associated with"},{"line_number":98,"context_line":"the id using passlib, similar to how we do password authentication."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"This improves security as API keys will have limited access; can be rotated and"},{"line_number":101,"context_line":"securely stored in configuration files. Especially for users that do not have"},{"line_number":102,"context_line":"privileges to create users with limited access, but do have a need to provide"},{"line_number":103,"context_line":"authentication credentials to a script or a 3rd party application."}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a1ced50_47ef05b0","line":100,"in_reply_to":"1a1ced50_9fd794ec","updated":"2017-03-20 19:36:17.000000000","message":"Limited access in that you can create API keys that only correspond to specific roles, instead of scoped to a project (which may have multiple role assignments).","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"c226471f7e391e78763502e0496a96d54b8007e5","unresolved":false,"context_lines":[{"line_number":110,"context_line":"configuration files, so that the root service account credentials are never"},{"line_number":111,"context_line":"exposed. That being said, you can already limit access for service users, so"},{"line_number":112,"context_line":"it\u0027s not the main use case here, but gives operators additional options."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Alternatives"},{"line_number":115,"context_line":"------------"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3a1ff146_a5028709","line":113,"updated":"2017-03-16 09:20:13.000000000","message":"I do have a bit of a worry here that although throughout this spec we talk about operators and services users, there is nothing to stop me as a regular user from creating myself a (long-lived) api-key for a common regular (i.e short running) transaction and using the api-key repeatlidly as a short cut to avoid the hassle of creating and managing tokens in my app. Are we OK with this? Are there any security concerns with this?","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fa701b86bc76a5bc83a34b4dca26b3ce4ed12692","unresolved":false,"context_lines":[{"line_number":110,"context_line":"configuration files, so that the root service account credentials are never"},{"line_number":111,"context_line":"exposed. That being said, you can already limit access for service users, so"},{"line_number":112,"context_line":"it\u0027s not the main use case here, but gives operators additional options."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Alternatives"},{"line_number":115,"context_line":"------------"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a1ced50_2750495d","line":113,"in_reply_to":"1a1ced50_6a422a40","updated":"2017-03-20 19:36:17.000000000","message":"This specific comment thread makes me want to forego API-keys completely in favor of OAuth.","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"8a3f1897dcf132e89733b390446c21ec992a0667","unresolved":false,"context_lines":[{"line_number":110,"context_line":"configuration files, so that the root service account credentials are never"},{"line_number":111,"context_line":"exposed. That being said, you can already limit access for service users, so"},{"line_number":112,"context_line":"it\u0027s not the main use case here, but gives operators additional options."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Alternatives"},{"line_number":115,"context_line":"------------"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a1ced50_6a422a40","line":113,"in_reply_to":"3a1ff146_650080ab","updated":"2017-03-19 23:54:29.000000000","message":"Right, this was part of my concern. What we\u0027ve done here is invent a new type of token that doesn\u0027t need to be time bound. People have asked us for a long time for non-expiring tokens and we\u0027ve told them how much of a bad idea that is. \n\nAssuming people are lazy (always a good assumption) and don\u0027t know exactly what policy they need to perform an operation (see heat, openstack in general) you can almost guarnatee that people will by default delegate to the api_key there entire role set.\n\nNow, we\u0027ve improved security because at least you can\u0027t rescope to a different project or create a new trust or api-key. But we\u0027ve created a mechansims for all powerful, un-expiring secrets that are going to be sent directly to the service - not passed through keystone layer.\n\nI\u0027m not sure what industry standard represents here, but i would expect they have a lot more trust in the services they are sending their secrets to. This can also not be compared to anything like AWS\u0027s scheme as they are doing actual message signing.","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"bac513d1be796ac6081f8331ff46ec3b89f03a87","unresolved":false,"context_lines":[{"line_number":110,"context_line":"configuration files, so that the root service account credentials are never"},{"line_number":111,"context_line":"exposed. That being said, you can already limit access for service users, so"},{"line_number":112,"context_line":"it\u0027s not the main use case here, but gives operators additional options."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Alternatives"},{"line_number":115,"context_line":"------------"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3a1ff146_650080ab","line":113,"in_reply_to":"3a1ff146_a5028709","updated":"2017-03-16 15:00:41.000000000","message":"Me too and I believe that was Jamie\u0027s concern as well. Let me give this some thought and I\u0027ll bring this up in IRC as well.","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"8a3f1897dcf132e89733b390446c21ec992a0667","unresolved":false,"context_lines":[{"line_number":142,"context_line":"That being said, there is an inherent risk with adding a new credential type"},{"line_number":143,"context_line":"and changing authentication details. One security risk would be the allowing of"},{"line_number":144,"context_line":"many credentials for the same user account. The design and implementation"},{"line_number":145,"context_line":"should mitigate the risks."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Notifications Impact"},{"line_number":148,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a1ced50_4a72ceae","line":145,"updated":"2017-03-19 23:54:29.000000000","message":"Negative impacts - we are now sending unexpiring, cleartext secrets to services other than keystone.","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"6ef1ec3dc53c6dc213f8412ca7660411aa818f48","unresolved":false,"context_lines":[{"line_number":142,"context_line":"That being said, there is an inherent risk with adding a new credential type"},{"line_number":143,"context_line":"and changing authentication details. One security risk would be the allowing of"},{"line_number":144,"context_line":"many credentials for the same user account. The design and implementation"},{"line_number":145,"context_line":"should mitigate the risks."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Notifications Impact"},{"line_number":148,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":14,"id":"ffe62b97_c17e276a","line":145,"in_reply_to":"1a1ced50_4a72ceae","updated":"2017-03-27 17:40:20.000000000","message":"Done","commit_id":"03cf2dd3cdd4d04d3558ad1f425cd213039ff9fb"}]}
