)]}'
{"doc/source/index.rst":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"96d6c75058035ab568c91c4e2ea4c3a4eaf31802","unresolved":false,"context_lines":[{"line_number":20,"context_line":"   :glob:"},{"line_number":21,"context_line":"   :maxdepth: 1"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"   specs/keystone/stein/*"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Rocky approved specs:"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"5f7c97a3_9b8d617d","line":23,"updated":"2018-05-18 20:04:05.000000000","message":"An alternative to forcing you to create all this before development actually opens is to propose it to backlog.\n\nOnce stein opens for development, we can quickly move it to the stein directory.","commit_id":"574d209d0b4de79ebfc627620a1d61dd5bc875a1"}],"specs/keystone/backlog/patrole-keystone-gate.rst":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9803c4ecd5a193a0699292f85d629410354d3c1a","unresolved":false,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":"  This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":3,"context_line":"  License."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_8297263a","line":1,"updated":"2018-10-08 18:32:21.000000000","message":"Sorry for the churn, but this should be moved to the Stein folder since we have a directory for those specifications, now.","commit_id":"327535045af3228caff10434e922d7b3dc34ffef"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"6edac99edd13a5ccde0dcd3a4a8e657793b729c4","unresolved":false,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":"  This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":3,"context_line":"  License."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_8b80284b","line":1,"in_reply_to":"3f79a3b5_8297263a","updated":"2018-10-13 15:33:07.000000000","message":"No problem, will make change.","commit_id":"327535045af3228caff10434e922d7b3dc34ffef"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"26fe658c3a53e96073d86ea3bc40b9fa38350f44","unresolved":false,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":"  This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":3,"context_line":"  License."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_ea458a18","line":1,"in_reply_to":"3f79a3b5_8b80284b","updated":"2019-04-24 01:31:20.000000000","message":"Now needs to be moved to train/ at this point","commit_id":"327535045af3228caff10434e922d7b3dc34ffef"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"26fe658c3a53e96073d86ea3bc40b9fa38350f44","unresolved":false,"context_lines":[{"line_number":36,"context_line":".. _policy in code: https://governance.openstack.org/tc/goals/queens/policy-in-code.html"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Problem Description"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Introduction"},{"line_number":42,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_aa47921d","line":39,"updated":"2019-04-24 01:31:20.000000000","message":"This problem statement has an overview of what Patrole is and does but not specifically what problem keystone is suffering from and how Patrole fixes it. Can you elaborate on what problem this is solving?","commit_id":"327535045af3228caff10434e922d7b3dc34ffef"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"26fe658c3a53e96073d86ea3bc40b9fa38350f44","unresolved":false,"context_lines":[{"line_number":74,"context_line":"Policy verification is performed by:"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"#. Pooling together the default `in-code` policy rules."},{"line_number":77,"context_line":"#. Overriding the defaults with custom policy rules located in a policy.json,"},{"line_number":78,"context_line":"   if the policy file exists, and the custom policy definition is explicitly"},{"line_number":79,"context_line":"   defined therein."},{"line_number":80,"context_line":"#. Confirming that the policy action -- for example, \"list_users\" -- exists."},{"line_number":81,"context_line":"#. Performing a call with all necessary data (including metadata) to"},{"line_number":82,"context_line":"   ``oslo.policy``."}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_aa94728c","line":79,"range":{"start_line":77,"start_character":0,"end_line":79,"end_character":19},"updated":"2019-04-24 01:31:20.000000000","message":"I\u0027m confused about this part, what\u0027s the value of the test *to keystone* if the value is changed? What about testing the default?","commit_id":"327535045af3228caff10434e922d7b3dc34ffef"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"26fe658c3a53e96073d86ea3bc40b9fa38350f44","unresolved":false,"context_lines":[{"line_number":77,"context_line":"#. Overriding the defaults with custom policy rules located in a policy.json,"},{"line_number":78,"context_line":"   if the policy file exists, and the custom policy definition is explicitly"},{"line_number":79,"context_line":"   defined therein."},{"line_number":80,"context_line":"#. Confirming that the policy action -- for example, \"list_users\" -- exists."},{"line_number":81,"context_line":"#. Performing a call with all necessary data (including metadata) to"},{"line_number":82,"context_line":"   ``oslo.policy``."},{"line_number":83,"context_line":"#. Comparing the output from ``oslo.policy`` to the output from the"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_4a913699","line":80,"range":{"start_line":80,"start_character":69,"end_line":80,"end_character":75},"updated":"2019-04-24 01:31:20.000000000","message":"exists in what?","commit_id":"327535045af3228caff10434e922d7b3dc34ffef"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9803c4ecd5a193a0699292f85d629410354d3c1a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"   and a ``True`` result from ``oslo.policy`` or a 403 from the API call"},{"line_number":88,"context_line":"   and a ``False`` result from ``oslo.policy`` -- and vice versa for"},{"line_number":89,"context_line":"   the \"inconsistency\" definition. (There are many other combinations, but"},{"line_number":90,"context_line":"   they are not exhaustively enumerated here.)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Negative Testing"},{"line_number":93,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_023f9622","line":90,"updated":"2018-10-08 18:32:21.000000000","message":"Let\u0027s assume we have this implemented in keystone and I propose a patch to change a default policy. Will the test will always pass because it\u0027s using what\u0027s defined in-tree to build the assertion for the test?\n\nI know I\u0027ve asked this question before, but it\u0027s been about a year or so since we\u0027ve discussed it.","commit_id":"327535045af3228caff10434e922d7b3dc34ffef"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"6edac99edd13a5ccde0dcd3a4a8e657793b729c4","unresolved":false,"context_lines":[{"line_number":87,"context_line":"   and a ``True`` result from ``oslo.policy`` or a 403 from the API call"},{"line_number":88,"context_line":"   and a ``False`` result from ``oslo.policy`` -- and vice versa for"},{"line_number":89,"context_line":"   the \"inconsistency\" definition. (There are many other combinations, but"},{"line_number":90,"context_line":"   they are not exhaustively enumerated here.)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Negative Testing"},{"line_number":93,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_cbb06044","line":90,"in_reply_to":"3f79a3b5_023f9622","updated":"2018-10-13 15:33:07.000000000","message":"Yes, it will reference what\u0027s in-tree. It uses some of the logic from the oslo.policy CLI that (I think) Morgan had mentioned at the last PTG to figure out what to use.","commit_id":"327535045af3228caff10434e922d7b3dc34ffef"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"26fe658c3a53e96073d86ea3bc40b9fa38350f44","unresolved":false,"context_lines":[{"line_number":97,"context_line":"negative testing, which entails validating that unauthorized users cannot"},{"line_number":98,"context_line":"perform specific API actions. In other words, negative RBAC testing --"},{"line_number":99,"context_line":"which is arguably more important from a *security* standpoint than positive"},{"line_number":100,"context_line":"RBAC testing -- is baked into the Patrole framework."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Solution"},{"line_number":103,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_caf20607","line":100,"updated":"2019-04-24 01:31:20.000000000","message":"baked in in what way?","commit_id":"327535045af3228caff10434e922d7b3dc34ffef"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9803c4ecd5a193a0699292f85d629410354d3c1a","unresolved":false,"context_lines":[{"line_number":99,"context_line":"which is arguably more important from a *security* standpoint than positive"},{"line_number":100,"context_line":"RBAC testing -- is baked into the Patrole framework."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Solution"},{"line_number":103,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Summary"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_026d562e","line":102,"updated":"2018-10-08 18:32:21.000000000","message":"An alternative to the approach being proposed here is to do something like what\u0027s being proposed with fixes to address system-scope [0].\n\nIt might be useful to elaborate on why this approach is being proposed instead of expanding coverage.\n\n[0] https://review.openstack.org/#/c/594547/14/keystone/tests/unit/protection/v3/test_credentials.py","commit_id":"327535045af3228caff10434e922d7b3dc34ffef"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"6edac99edd13a5ccde0dcd3a4a8e657793b729c4","unresolved":false,"context_lines":[{"line_number":99,"context_line":"which is arguably more important from a *security* standpoint than positive"},{"line_number":100,"context_line":"RBAC testing -- is baked into the Patrole framework."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Solution"},{"line_number":103,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Summary"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_2ba8f4d6","line":102,"in_reply_to":"3f79a3b5_026d562e","updated":"2018-10-13 15:33:07.000000000","message":"Indeed, I will do so but will respond to here as well:\n\nAdvantages\n------------\n\n* Integration testing works better than unit tests for real workloads and validating cross-service communication\n* Holistic unit test coverage for RBAC proves that RBAC is working within a service but doesn\u0027t prove that *a specific customization of RBAC* is working and properly configured, as a specific customization is arbitrarily complex\n* It is easier/faster to implement a tool for doing this that works for any service, rather than going through every single service and tailoring a unit test validation framework for them; even if there are points of commonality, there are oddballs like Neutron for whom validation becomes trickier\n\nDisadvantages\n---------------\n\n* Black box integration testing for validating RBAC workflows has its limits, mainly because you can\u0027t glean which policy failed because that information isn\u0027t exposed to the end user; with unit tests it\u0027s trivial to ascertain that as you are testing the internals of the code itself\n* Less setup time for unit tests; for Keystone not so important. For Nova, testing every scenario for every scope type becomes more expensive (resource wise) with integration tests.\n\nThat being said, a proper unit test bed for validating RBAC informs devs on how to better write integration test bed for doing the same, as you can cross-reference assumptions.\n\nFinally, at the time of implementing Patrole virtually no one was really taking RBAC seriously except for you guys in Keystone :) So now you are right that there is overlap (with Keystone and a few other services like Octavia).\n\nBut even still, for operators like AT\u0026T, I can say that we still need a way to validate our custom overrides, and that\u0027s why we can\u0027t go with *just* the unit test approach.","commit_id":"327535045af3228caff10434e922d7b3dc34ffef"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"26fe658c3a53e96073d86ea3bc40b9fa38350f44","unresolved":false,"context_lines":[{"line_number":105,"context_line":"Summary"},{"line_number":106,"context_line":"-------"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"The solution is to add a Patrole *non-voting* gate in Keystone, responsible"},{"line_number":109,"context_line":"for testing Keystone-specific APIs or for testing all Big Tent APIs. Patrole"},{"line_number":110,"context_line":"runs gates for admin and member roles for the aforementioned OpenStack services"},{"line_number":111,"context_line":"though *any role* (including `auditor`_) can be used."}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_8ac5ee90","line":108,"range":{"start_line":108,"start_character":33,"end_line":108,"end_character":45},"updated":"2019-04-24 01:31:20.000000000","message":"what\u0027s the value if it\u0027s nonvoting?","commit_id":"327535045af3228caff10434e922d7b3dc34ffef"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"26fe658c3a53e96073d86ea3bc40b9fa38350f44","unresolved":false,"context_lines":[{"line_number":106,"context_line":"-------"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"The solution is to add a Patrole *non-voting* gate in Keystone, responsible"},{"line_number":109,"context_line":"for testing Keystone-specific APIs or for testing all Big Tent APIs. Patrole"},{"line_number":110,"context_line":"runs gates for admin and member roles for the aforementioned OpenStack services"},{"line_number":111,"context_line":"though *any role* (including `auditor`_) can be used."},{"line_number":112,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_cacbe6a2","line":109,"range":{"start_line":109,"start_character":54,"end_line":109,"end_character":62},"updated":"2019-04-24 01:31:20.000000000","message":"we don\u0027t really use this phrase any more, just say OpenStack services.","commit_id":"327535045af3228caff10434e922d7b3dc34ffef"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"26fe658c3a53e96073d86ea3bc40b9fa38350f44","unresolved":false,"context_lines":[{"line_number":106,"context_line":"-------"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"The solution is to add a Patrole *non-voting* gate in Keystone, responsible"},{"line_number":109,"context_line":"for testing Keystone-specific APIs or for testing all Big Tent APIs. Patrole"},{"line_number":110,"context_line":"runs gates for admin and member roles for the aforementioned OpenStack services"},{"line_number":111,"context_line":"though *any role* (including `auditor`_) can be used."},{"line_number":112,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_0a37beb2","line":109,"range":{"start_line":109,"start_character":35,"end_line":109,"end_character":37},"updated":"2019-04-24 01:31:20.000000000","message":"which is it, keystone or everything? Why does it need to be in the keystone gate if it\u0027s not testing keystone-specific things?","commit_id":"327535045af3228caff10434e922d7b3dc34ffef"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"26fe658c3a53e96073d86ea3bc40b9fa38350f44","unresolved":false,"context_lines":[{"line_number":108,"context_line":"The solution is to add a Patrole *non-voting* gate in Keystone, responsible"},{"line_number":109,"context_line":"for testing Keystone-specific APIs or for testing all Big Tent APIs. Patrole"},{"line_number":110,"context_line":"runs gates for admin and member roles for the aforementioned OpenStack services"},{"line_number":111,"context_line":"though *any role* (including `auditor`_) can be used."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Should the Keystone team decide to change the gate from non-voting to voting"},{"line_number":114,"context_line":"or make any other minor alterations, it is now fairly trivial to do so with"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_4abff6fa","line":111,"range":{"start_line":111,"start_character":30,"end_line":111,"end_character":37},"updated":"2019-04-24 01:31:20.000000000","message":"we\u0027re calling it `reader` now","commit_id":"327535045af3228caff10434e922d7b3dc34ffef"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9803c4ecd5a193a0699292f85d629410354d3c1a","unresolved":false,"context_lines":[{"line_number":181,"context_line":"dedicated to testing just Keystone APIs ought to be much faster, probably"},{"line_number":182,"context_line":"within the ballpark of 30-45 minutes."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":".. _auditor: https://review.openstack.org/#/c/566377"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"Conclusion"},{"line_number":187,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_421eeebc","line":184,"range":{"start_line":184,"start_character":13,"end_line":184,"end_character":52},"updated":"2018-10-08 18:32:21.000000000","message":"This was renamed in https://review.openstack.org/#/c/570990/","commit_id":"327535045af3228caff10434e922d7b3dc34ffef"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"6edac99edd13a5ccde0dcd3a4a8e657793b729c4","unresolved":false,"context_lines":[{"line_number":181,"context_line":"dedicated to testing just Keystone APIs ought to be much faster, probably"},{"line_number":182,"context_line":"within the ballpark of 30-45 minutes."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":".. _auditor: https://review.openstack.org/#/c/566377"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"Conclusion"},{"line_number":187,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_ebad1ce7","line":184,"range":{"start_line":184,"start_character":13,"end_line":184,"end_character":52},"in_reply_to":"3f79a3b5_421eeebc","updated":"2018-10-13 15:33:07.000000000","message":"Thanks, will fix.","commit_id":"327535045af3228caff10434e922d7b3dc34ffef"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"6edac99edd13a5ccde0dcd3a4a8e657793b729c4","unresolved":false,"context_lines":[{"line_number":198,"context_line":"Primary assignees:"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"  * Felipe Monteiro felipe.monteiro@att.com"},{"line_number":201,"context_line":"  * Harry Rybacki hrybacki@redhat.com"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"Other assignees:"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_8b7268af","line":201,"range":{"start_line":201,"start_character":2,"end_line":201,"end_character":37},"updated":"2018-10-13 15:33:07.000000000","message":"I believe I need to remove Harry as I haven\u0027t heard from him in some time. Please let me know if I am incorrect and will reverse this.","commit_id":"327535045af3228caff10434e922d7b3dc34ffef"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"f8a3e86c10d941afbad6d564cca6757b1a13dcfb","unresolved":false,"context_lines":[{"line_number":198,"context_line":"Primary assignees:"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"  * Felipe Monteiro felipe.monteiro@att.com"},{"line_number":201,"context_line":"  * Harry Rybacki hrybacki@redhat.com"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"Other assignees:"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_0be3b807","line":201,"range":{"start_line":201,"start_character":2,"end_line":201,"end_character":37},"in_reply_to":"3f79a3b5_8b7268af","updated":"2018-10-13 16:08:34.000000000","message":"Keep him on the hook.  He\u0027s still engaged, just in other parts of OpenStack.","commit_id":"327535045af3228caff10434e922d7b3dc34ffef"}],"specs/keystone/ongoing/patrole-keystone-gate.rst":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"832231e5ec48c7f9f942cc5d31552ed6f7bfef7d","unresolved":false,"context_lines":[{"line_number":131,"context_line":"* later, the future ``.zuul.yaml`` job definition for Patrole can be updated to"},{"line_number":132,"context_line":"  test additional \"Big Tent\" services covered by Patrole"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":".. _auditor: https://review.openstack.org/#/c/566377"},{"line_number":135,"context_line":".. _current approach: https://github.com/openstack/patrole/blob/master/.zuul.yaml"},{"line_number":136,"context_line":".. _default role changes: https://review.openstack.org/#/c/566377/"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5f7c97a3_5c752331","line":134,"range":{"start_line":134,"start_character":3,"end_line":134,"end_character":52},"updated":"2018-05-10 20:45:40.000000000","message":"This requires finalization, plus a better link after it gets published.","commit_id":"19b7b9c0d001ecbcd31c3ded5b5074b7e5867416"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"832231e5ec48c7f9f942cc5d31552ed6f7bfef7d","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":".. _auditor: https://review.openstack.org/#/c/566377"},{"line_number":135,"context_line":".. _current approach: https://github.com/openstack/patrole/blob/master/.zuul.yaml"},{"line_number":136,"context_line":".. _default role changes: https://review.openstack.org/#/c/566377/"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"\"Admin\"-ness Bug"},{"line_number":139,"context_line":"~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5f7c97a3_1c91eb47","line":136,"range":{"start_line":136,"start_character":26,"end_line":136,"end_character":66},"updated":"2018-05-10 20:45:40.000000000","message":"Ditto.","commit_id":"19b7b9c0d001ecbcd31c3ded5b5074b7e5867416"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"eb2d10f2ddcf6af0455eaaaacb7cf928446b9a86","unresolved":false,"context_lines":[{"line_number":87,"context_line":"   and a ``True`` result from ``oslo.policy`` or a 403 from the API call"},{"line_number":88,"context_line":"   and a ``False`` result from ``oslo.policy`` -- and vice versa for"},{"line_number":89,"context_line":"   the \"inconsistency\" definition. (There are many other combinations, but"},{"line_number":90,"context_line":"   they are not exhaustively enumerated here.)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Negative Testing"},{"line_number":93,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_d7d7804a","line":90,"updated":"2018-05-15 14:44:47.000000000","message":"IMO - it would be easier to read and understand the behavior of each default role if the assertion was explicit. Rather than deriving the assertion from oslo.policy.\n\nIf the value used in the assertion is derived from calling oslo.policy with the same values, how does the test fail? Couldn\u0027t I change the value of the policy and the test would pass?","commit_id":"a8a4bdadb8c6f07f82023f84734101d362c639f5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"1909f9cb581468459591375c79b41050547ae80c","unresolved":false,"context_lines":[{"line_number":87,"context_line":"   and a ``True`` result from ``oslo.policy`` or a 403 from the API call"},{"line_number":88,"context_line":"   and a ``False`` result from ``oslo.policy`` -- and vice versa for"},{"line_number":89,"context_line":"   the \"inconsistency\" definition. (There are many other combinations, but"},{"line_number":90,"context_line":"   they are not exhaustively enumerated here.)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Negative Testing"},{"line_number":93,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_75188974","line":90,"in_reply_to":"5f7c97a3_bbf7fdd4","updated":"2018-05-20 03:20:41.000000000","message":"Yeah, the general test architecture is not something I came up with (I know it\u0027s not important to stress that -- and I\u0027m not being defensive at all -- I just mean that I\u0027m sympathizing with your position as I\u0027m not biased against it).\n\nAs I\u0027ve mentioned before there are 2 competing interests, both of which deserve their day under the sun:\n\n1) Ensuring that custom policy definitions (as well as custom roles) can be validated. Using your test above doesn\u0027t help the case where a new role is added. It also doesn\u0027t help if the auditor role is radically redefined (for better or for worse) via custom policy files.\n\n2) Ensuring that the defaults are tested as holistically as possible -- your example does that very well.\n\nIn fact, the example above could live in theory in Tempest, as it\u0027s just a negative test. Tempest only ever assumes the default workflow. Note that admin-only APIs are included under admin namespaces there. (The other issue is tangentially related: if it takes admin role to create a server, then you have to create the server using admin role, then continue to use admin credentials for other things as well, because the server was created in the admin tenant, meaning that if the non-admin user tries to do something, depending on the API in question, 404s can be raised -- this is quite common.)\n\nHowever, I think we should come to a compromise here, one that tries to balance these concerns. If we can\u0027t do something like what you\u0027ve proposed in the immediate future, it should be something we investigate. Duplication isn\u0027t nice (speaking to my idea of putting explicit tests in a separate module), but wanting more explicitness is nice too.\n\nOne naive idea is to do something like this:\n\n@rbac_rule_validation.action(rule\u003d\"foo:bar\", expect_authorized\u003d[defaults.ADMIN])\ndef test_create_service_system_scope(self):\n    # We expect admin role to pass.\n    # The \"expect_unauthorized\" is calculated by using a set difference\n    # (where the other 2 roles are defaults.AUDITOR and defaults.MEMBER)\n    # Those \"expect_unauthorized should trigger a failure.\n\nThis can potentially be worked in. If we want to test custom policies we can maybe add a config option that just ignores these \"expected_authorized\" values. Just something random I just thought of, might not be the best approach.","commit_id":"a8a4bdadb8c6f07f82023f84734101d362c639f5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"9352c00af92b252b7cd5c6790090ed349fd83f4a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"   and a ``True`` result from ``oslo.policy`` or a 403 from the API call"},{"line_number":88,"context_line":"   and a ``False`` result from ``oslo.policy`` -- and vice versa for"},{"line_number":89,"context_line":"   the \"inconsistency\" definition. (There are many other combinations, but"},{"line_number":90,"context_line":"   they are not exhaustively enumerated here.)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Negative Testing"},{"line_number":93,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_e589a274","line":90,"in_reply_to":"5f7c97a3_d7d7804a","updated":"2018-05-15 15:49:48.000000000","message":"I know you had additional thoughts regarding this at the PTG, but I\u0027m struggling to remember all the details.\n\nIf Patrole should validate the default, policy in code implementation, then it must derive that implementation somehow. One way is via oslo.policy. I\u0027m not sure if there is another mechanism. In Horizon (at least in the past) they used a separate policy.json for each supported service, which leads to a lot of technical debt IMO.\n\n(Furthermore, what if, hypothetically, we want to validate different scope types in Patrole -- where would we derive that information from? I don\u0027t think that information is conveyed through the sample policy.yaml file in each project\u0027s etc subdirectory.)\n\nTo answer your first question: You are correct that the data derived from policy in code is static. What changes is the role under test. This role works similarly to Tempest\u0027s \"tempest_roles\" option: it sets the default roles for the os_primary credential. In Patrole we use ``CONF.patrole.patrole_test_role`` which essentially coerces the os_primary credential to that role, within a defined context block inside which we perform the API call using that specific role.\n\nThis means that if you try to perform, for example, list projects API call which enforces \"identity:list_projects\" with admin role, then the test will pass; if you do the same with member role the test will *pass*, but *only* if API returns a 403 for member role. (If you get a 200 with member role this results in a test *failure*.)\n\nThere is a workaround to this: You can override the default policy in a custom policy file. For example, you can set \"identity:list_projects\": \"@\" and re-run the test using member, in which case the expectation is for it to pass (I haven\u0027t confirmed).\n\nFrom the perspective of gating, there are no modifications done to the policy.yaml files so the in code defaults are always used.\n\nAs far as more explicit assertions go, depending on the implementation, I think the following may be true.\n\nPros:\n  - easier to read, less magic\nCons:\n  - can break if you modify the policy via custom policy files\n\nAlso, I would need to see an example of what you mean by more explicit because if that entails explicit assertions for admin, member and auditor per test then I think the best way to do that is to handle those more explicit tests in a separate module within Patrole, or else (if I\u0027m not mistaken) we break the use case of wanting to validate arbitrary policy changes which is one of the project\u0027s mission statements.","commit_id":"a8a4bdadb8c6f07f82023f84734101d362c639f5"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"96d6c75058035ab568c91c4e2ea4c3a4eaf31802","unresolved":false,"context_lines":[{"line_number":87,"context_line":"   and a ``True`` result from ``oslo.policy`` or a 403 from the API call"},{"line_number":88,"context_line":"   and a ``False`` result from ``oslo.policy`` -- and vice versa for"},{"line_number":89,"context_line":"   the \"inconsistency\" definition. (There are many other combinations, but"},{"line_number":90,"context_line":"   they are not exhaustively enumerated here.)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Negative Testing"},{"line_number":93,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_bbf7fdd4","line":90,"in_reply_to":"5f7c97a3_e589a274","updated":"2018-05-18 20:04:05.000000000","message":"Ok - I think I have two concerns.\n\nThe first was that there would be a way to ensure the tests fail when something bad happens (or we change a default in a way that inconsistent with the decisions we\u0027ve made). It sounds like you have a way to handle this, which is good.\n\nThe second was more a readability thing for the tests. I was envisioning something like (assuming test-specific language implementation):\n\n  def test_system_auditor_cannot_create_services(self):\n      system_auditor_token \u003d self.get_token_for_user(self.system_auditor)\n      create_service_body \u003d {\n          \u0027service\u0027: {\n              \u0027name\u0027: \u0027glance\u0027,\n              \u0027type\u0027: \u0027image\u0027,\n          }\n      }\n      self.post(\n          \u0027/v3/services\u0027,\n          body\u003dcreate_service_body,\n          token\u003dsystem_auditor_token,\n          expected_status\u003dhttp_client.FORBIDDEN\n      )\n\nI more or less just like the readability of that, but I can also imagine it\u0027s going to get pretty redundant. But I would considered the first concern more important and the second as a nice-to-have.","commit_id":"a8a4bdadb8c6f07f82023f84734101d362c639f5"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"eb2d10f2ddcf6af0455eaaaacb7cf928446b9a86","unresolved":false,"context_lines":[{"line_number":135,"context_line":".. _default role changes: https://review.openstack.org/#/c/566377/"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"\"Admin\"-ness Bug"},{"line_number":138,"context_line":"~~~~~~~~~~~~~~~~"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Realization of the above summary has one critical condition: Patrole tests must"},{"line_number":141,"context_line":"fail unless the changes for system-scoped roles are activated, mitigating the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_3776f471","line":138,"updated":"2018-05-15 14:44:47.000000000","message":"This could really be documented as a dependency, in it\u0027s own section [0].\n\n[0] http://git.openstack.org/cgit/openstack/keystone-specs/tree/specs/template.rst#n202","commit_id":"a8a4bdadb8c6f07f82023f84734101d362c639f5"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"bee9284d303a6f078fbded7f82af8e6e7a1069b7","unresolved":false,"context_lines":[{"line_number":135,"context_line":".. _default role changes: https://review.openstack.org/#/c/566377/"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"\"Admin\"-ness Bug"},{"line_number":138,"context_line":"~~~~~~~~~~~~~~~~"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Realization of the above summary has one critical condition: Patrole tests must"},{"line_number":141,"context_line":"fail unless the changes for system-scoped roles are activated, mitigating the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_7a6bf1ef","line":138,"in_reply_to":"5f7c97a3_3776f471","updated":"2018-05-15 15:37:36.000000000","message":"+1 -- though a dependency for a \u0027voting\u0027 gate should be noted. The gate shouldn\u0027t pass until LP#968696 is resolved.","commit_id":"a8a4bdadb8c6f07f82023f84734101d362c639f5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"805a4cfa8e170dcb74cf8939db3eb61192a8a321","unresolved":false,"context_lines":[{"line_number":135,"context_line":".. _default role changes: https://review.openstack.org/#/c/566377/"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"\"Admin\"-ness Bug"},{"line_number":138,"context_line":"~~~~~~~~~~~~~~~~"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Realization of the above summary has one critical condition: Patrole tests must"},{"line_number":141,"context_line":"fail unless the changes for system-scoped roles are activated, mitigating the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_f55a984e","line":138,"in_reply_to":"5f7c97a3_7a6bf1ef","updated":"2018-05-16 18:50:02.000000000","message":"Done","commit_id":"a8a4bdadb8c6f07f82023f84734101d362c639f5"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"eb2d10f2ddcf6af0455eaaaacb7cf928446b9a86","unresolved":false,"context_lines":[{"line_number":204,"context_line":"Assignee(s)"},{"line_number":205,"context_line":"-----------"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Primary assignee:"},{"line_number":208,"context_line":"  * Felipe Monteiro felipe.monteiro@att.com"},{"line_number":209,"context_line":"  * Harry Rybacki hrybacki hrybacki@redhat.com"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_d73300aa","line":207,"updated":"2018-05-15 14:44:47.000000000","message":"I think we\u0027ll need a newline here in order for the list to render properly.","commit_id":"a8a4bdadb8c6f07f82023f84734101d362c639f5"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"eb2d10f2ddcf6af0455eaaaacb7cf928446b9a86","unresolved":false,"context_lines":[{"line_number":204,"context_line":"Assignee(s)"},{"line_number":205,"context_line":"-----------"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Primary assignee:"},{"line_number":208,"context_line":"  * Felipe Monteiro felipe.monteiro@att.com"},{"line_number":209,"context_line":"  * Harry Rybacki hrybacki hrybacki@redhat.com"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_97290838","line":207,"range":{"start_line":207,"start_character":8,"end_line":207,"end_character":16},"updated":"2018-05-15 14:44:47.000000000","message":"nit: assignees","commit_id":"a8a4bdadb8c6f07f82023f84734101d362c639f5"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"805a4cfa8e170dcb74cf8939db3eb61192a8a321","unresolved":false,"context_lines":[{"line_number":204,"context_line":"Assignee(s)"},{"line_number":205,"context_line":"-----------"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Primary assignee:"},{"line_number":208,"context_line":"  * Felipe Monteiro felipe.monteiro@att.com"},{"line_number":209,"context_line":"  * Harry Rybacki hrybacki hrybacki@redhat.com"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_3549f08a","line":207,"in_reply_to":"5f7c97a3_d73300aa","updated":"2018-05-16 18:50:02.000000000","message":"Done","commit_id":"a8a4bdadb8c6f07f82023f84734101d362c639f5"}],"specs/keystone/pike/patrole-keystone-gate.rst":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"dc4133c9b7975904f1b31fd05b421d17cb95ff90","unresolved":false,"context_lines":[{"line_number":43,"context_line":"negative testing, which entails validating that unauthorized users cannot"},{"line_number":44,"context_line":"perform specific API actions. In other words, negative RBAC testing --"},{"line_number":45,"context_line":"which is arguably more important from a `security` standpoint than positive"},{"line_number":46,"context_line":"RBAC testing -- is baked into the Patrole framework."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Solution"},{"line_number":49,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f013ff3_97cb1352","line":46,"updated":"2017-05-15 22:13:21.000000000","message":"++","commit_id":"4f17e4921b6407d0cba32734a7dda6a34ec0229d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"dc4133c9b7975904f1b31fd05b421d17cb95ff90","unresolved":false,"context_lines":[{"line_number":91,"context_line":"within the ballpark of 30 minutes."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Conclusion"},{"line_number":94,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"The end result is proactive RBAC testing within Keystone, the epicenter of many"},{"line_number":97,"context_line":"proposed future policy enforcement changes."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f013ff3_37455fb4","line":94,"updated":"2017-05-15 22:13:21.000000000","message":"Several projects in OpenStack are looking to make changes to their default policies. A section on how to orchestrate those changes with Patrole would be useful.","commit_id":"4f17e4921b6407d0cba32734a7dda6a34ec0229d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"bfc330392d810ebd8d83ea433e57cabd8fadf3a7","unresolved":false,"context_lines":[{"line_number":91,"context_line":"within the ballpark of 30 minutes."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Conclusion"},{"line_number":94,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"The end result is proactive RBAC testing within Keystone, the epicenter of many"},{"line_number":97,"context_line":"proposed future policy enforcement changes."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f013ff3_a6b243e5","line":94,"in_reply_to":"1f013ff3_37455fb4","updated":"2017-05-16 20:04:21.000000000","message":"Thanks for taking the time to review this.\n\nBecause your comment seems to be implying a whole lot within a few sentences, I took your statement to mean: \"How will Patrole handle upcoming changes to policy in code\"? If that was not what you were implying, then may you please clarify?\n\nI added a section in PS2 called \"Patrole Policy Verification\" to explain how the verification process geared around policy in code works. Again: I\u0027m not 100% if that\u0027s what you were looking for though.","commit_id":"4f17e4921b6407d0cba32734a7dda6a34ec0229d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"dc4133c9b7975904f1b31fd05b421d17cb95ff90","unresolved":false,"context_lines":[{"line_number":106,"context_line":"  Felipe Monteiro \u003cfelipe.monteiro@att.com\u003e"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Other contributors:"},{"line_number":109,"context_line":"  * Samantha Blanco \u003csamantha.blanco@att.com\u003e"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"References"},{"line_number":112,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f013ff3_37f0bf90","line":109,"updated":"2017-05-15 22:13:21.000000000","message":"nit: Remove * to be consistent with line 106","commit_id":"4f17e4921b6407d0cba32734a7dda6a34ec0229d"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"bfc330392d810ebd8d83ea433e57cabd8fadf3a7","unresolved":false,"context_lines":[{"line_number":106,"context_line":"  Felipe Monteiro \u003cfelipe.monteiro@att.com\u003e"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Other contributors:"},{"line_number":109,"context_line":"  * Samantha Blanco \u003csamantha.blanco@att.com\u003e"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"References"},{"line_number":112,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f013ff3_86b507d0","line":109,"in_reply_to":"1f013ff3_37f0bf90","updated":"2017-05-16 20:04:21.000000000","message":"I added another contributor to PS2, thereby making it an actual list of people.","commit_id":"4f17e4921b6407d0cba32734a7dda6a34ec0229d"},{"author":{"_account_id":23184,"name":"DavidPurcell","email":"d.purcell222@gmail.com","username":"DavidPurcell"},"change_message_id":"9f37ef6297ca2b2aeddafe77f821f45210789cca","unresolved":false,"context_lines":[{"line_number":84,"context_line":"-------"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"The solution is to add a Patrole non-voting gate in Keystone, responsible"},{"line_number":87,"context_line":"for testing Keystone-specific APIs only, for both of Keystone\u0027s currently"},{"line_number":88,"context_line":"supported roles: admin and Member. The tests should be split into separate"},{"line_number":89,"context_line":"gates for each role to provide proper test isolation between roles, which"},{"line_number":90,"context_line":"will facilitate debugging of the gates. Note that it is nonetheless"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f013ff3_4584940c","line":87,"range":{"start_line":87,"start_character":12,"end_line":87,"end_character":39},"updated":"2017-05-16 21:31:59.000000000","message":"I dislike the idea of only testing Keystone APIs.  One key aspect of Patrole, and integration testing in general, is ensuring that a change in one project or service doesn\u0027t break others.  By only testing the Keystone APIs we leave ourselves open to the possibility that a change in Keystone RBAC enforcement might silently break other services.","commit_id":"7cd3a3d1527658aab07b0b9f2cc011aa55af28e7"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"7159bef2342dcf5ce83ffd82150392c50d081f60","unresolved":false,"context_lines":[{"line_number":84,"context_line":"-------"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"The solution is to add a Patrole non-voting gate in Keystone, responsible"},{"line_number":87,"context_line":"for testing Keystone-specific APIs only, for both of Keystone\u0027s currently"},{"line_number":88,"context_line":"supported roles: admin and Member. The tests should be split into separate"},{"line_number":89,"context_line":"gates for each role to provide proper test isolation between roles, which"},{"line_number":90,"context_line":"will facilitate debugging of the gates. Note that it is nonetheless"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f013ff3_65e0b0cd","line":87,"range":{"start_line":87,"start_character":12,"end_line":87,"end_character":39},"in_reply_to":"1f013ff3_4584940c","updated":"2017-05-16 21:36:12.000000000","message":"That\u0027s a valid point, but I guess would hinge on what the Keystone core team desires. The solution for adding gating for RBAC testing all Big Tent services (and I\u0027d like to very strongly emphasize this does *not* yet include Swift, but rather *only* Nova, Neutron, Glance, Cinder and Keystone) is even easier, because it would obviously borrow heavily from Patrole\u0027s current gating implementation.","commit_id":"7cd3a3d1527658aab07b0b9f2cc011aa55af28e7"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"9751d1080cf1d0a31d5dd6c0bb32fa057e3407c6","unresolved":false,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":"  This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":3,"context_line":"  License."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f7c97a3_5df8c647","line":1,"updated":"2018-05-10 16:27:00.000000000","message":"We should target Stein for this. Even were the spec to be approved in Rocky I doubt we have the cycles to implement all of the need changes to Patrole and get a new gate up in time.","commit_id":"e621806457c34b9be361a2739111c0076ed28880"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e1be511dd3f8457e8a20f844f81d9646657cae0d","unresolved":false,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":"  This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":3,"context_line":"  License."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f7c97a3_dc25b35d","line":1,"in_reply_to":"5f7c97a3_5df8c647","updated":"2018-05-10 20:43:42.000000000","message":"Thanks, agree. I\u0027m putting into ongoing as suggested by Adam in his patchset-level comment.","commit_id":"e621806457c34b9be361a2739111c0076ed28880"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"9751d1080cf1d0a31d5dd6c0bb32fa057e3407c6","unresolved":false,"context_lines":[{"line_number":48,"context_line":"segregates admin-level tests from non-admin-level tests, based on the"},{"line_number":49,"context_line":"`default` permissions for each API, this approach can easily be broken"},{"line_number":50,"context_line":"when the default permissions are modified. For example, if default policy"},{"line_number":51,"context_line":"actions are modified to allow admin role instead of anyone, then corresponding"},{"line_number":52,"context_line":"Tempest tests for the APIs that enforce the modified policy actions will"},{"line_number":53,"context_line":"necessarily break (or run with overly elevated permissions), because Tempest"},{"line_number":54,"context_line":"has no mechanism for dynamically *modifying* the credentials it uses to perform"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f7c97a3_7d610205","line":51,"range":{"start_line":51,"start_character":23,"end_line":51,"end_character":58},"updated":"2018-05-10 16:27:00.000000000","message":"good example but it\u0027s not clear what we are changing from -- maybe we can make it clear that we are \u0027upping\u0027 the requirements e.g.:\n\n\u0027increase restrictions by only allowing the admin role\u0027","commit_id":"e621806457c34b9be361a2739111c0076ed28880"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"9751d1080cf1d0a31d5dd6c0bb32fa057e3407c6","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"#. Pooling together the default `in-code` policy rules."},{"line_number":66,"context_line":"#. Overriding the defaults with custom policy rules located in a policy.json,"},{"line_number":67,"context_line":"   if the policy file exists and the custom policy definition is explicitly"},{"line_number":68,"context_line":"   defined therein."},{"line_number":69,"context_line":"#. Confirming that the policy action -- for example, \"list_users\" -- exists."},{"line_number":70,"context_line":"#. Performing a call with all necessary data (including metadata) to"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f7c97a3_1d380eed","line":67,"range":{"start_line":67,"start_character":28,"end_line":67,"end_character":29},"updated":"2018-05-10 16:27:00.000000000","message":"(nit) oxford commas for removal of any ambiguity","commit_id":"e621806457c34b9be361a2739111c0076ed28880"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e1be511dd3f8457e8a20f844f81d9646657cae0d","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"#. Pooling together the default `in-code` policy rules."},{"line_number":66,"context_line":"#. Overriding the defaults with custom policy rules located in a policy.json,"},{"line_number":67,"context_line":"   if the policy file exists and the custom policy definition is explicitly"},{"line_number":68,"context_line":"   defined therein."},{"line_number":69,"context_line":"#. Confirming that the policy action -- for example, \"list_users\" -- exists."},{"line_number":70,"context_line":"#. Performing a call with all necessary data (including metadata) to"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f7c97a3_1c39eba2","line":67,"range":{"start_line":67,"start_character":28,"end_line":67,"end_character":29},"in_reply_to":"5f7c97a3_1d380eed","updated":"2018-05-10 20:43:42.000000000","message":"Done","commit_id":"e621806457c34b9be361a2739111c0076ed28880"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"9751d1080cf1d0a31d5dd6c0bb32fa057e3407c6","unresolved":false,"context_lines":[{"line_number":81,"context_line":"Negative Testing"},{"line_number":82,"context_line":"----------------"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"In addition, while many tests may currently offer some semblance of RBAC"},{"line_number":85,"context_line":"testing, they usually only test the so-called \"happy path\", thereby neglecting"},{"line_number":86,"context_line":"negative testing, which entails validating that unauthorized users cannot"},{"line_number":87,"context_line":"perform specific API actions. In other words, negative RBAC testing --"},{"line_number":88,"context_line":"which is arguably more important from a `security` standpoint than positive"},{"line_number":89,"context_line":"RBAC testing -- is baked into the Patrole framework."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Solution"},{"line_number":92,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f7c97a3_bd11da5f","line":89,"range":{"start_line":84,"start_character":0,"end_line":89,"end_character":52},"updated":"2018-05-10 16:27:00.000000000","message":"Can anyone think of a time where this bit us in the past? It would be nice to add an anecdote stating as much if so.","commit_id":"e621806457c34b9be361a2739111c0076ed28880"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"9751d1080cf1d0a31d5dd6c0bb32fa057e3407c6","unresolved":false,"context_lines":[{"line_number":103,"context_line":"or make any other minor alterations, it is now fairly trivial to do so with"},{"line_number":104,"context_line":"the introduction of `Zuul V3 \u003chttps://docs.openstack.org/infra/manual/zuulv3.html\u003e`_."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"The tests should be split into separate gates for each role to provide proper"},{"line_number":107,"context_line":"test isolation between roles, which will facilitate debugging of the gates."},{"line_number":108,"context_line":"Note that it is nonetheless possible to execute tests for each role within a"},{"line_number":109,"context_line":"single gate, if required, although this approach will result in much longer"},{"line_number":110,"context_line":"net gate execution time."}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f7c97a3_5830d4e8","line":107,"range":{"start_line":106,"start_character":0,"end_line":107,"end_character":75},"updated":"2018-05-10 16:27:00.000000000","message":"(nit) I may re-order the structure here:\n\n\u0027To facilitate debugging of the gates, tests should be split into a separate gate, thereby providing isolation for, each role.\u0027","commit_id":"e621806457c34b9be361a2739111c0076ed28880"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e1be511dd3f8457e8a20f844f81d9646657cae0d","unresolved":false,"context_lines":[{"line_number":103,"context_line":"or make any other minor alterations, it is now fairly trivial to do so with"},{"line_number":104,"context_line":"the introduction of `Zuul V3 \u003chttps://docs.openstack.org/infra/manual/zuulv3.html\u003e`_."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"The tests should be split into separate gates for each role to provide proper"},{"line_number":107,"context_line":"test isolation between roles, which will facilitate debugging of the gates."},{"line_number":108,"context_line":"Note that it is nonetheless possible to execute tests for each role within a"},{"line_number":109,"context_line":"single gate, if required, although this approach will result in much longer"},{"line_number":110,"context_line":"net gate execution time."}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f7c97a3_3c0ce7eb","line":107,"range":{"start_line":106,"start_character":0,"end_line":107,"end_character":75},"in_reply_to":"5f7c97a3_5830d4e8","updated":"2018-05-10 20:43:42.000000000","message":"Done","commit_id":"e621806457c34b9be361a2739111c0076ed28880"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"ec2f7b1e244bd831d305ad1ce95abecfe6e4b45e","unresolved":false,"context_lines":[{"line_number":128,"context_line":"\"Admin\"-ness Bug"},{"line_number":129,"context_line":"~~~~~~~~~~~~~~~~"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Realization of the above summary has one critical condition: Patrole tests must"},{"line_number":132,"context_line":"fail unless the changes for system-scoped roles are activated, mitigating the"},{"line_number":133,"context_line":"so-called `adminness bug`_."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":".. _adminness bug: https://bugs.launchpad.net/keystone/+bug/968696"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f7c97a3_b3c90bad","line":133,"range":{"start_line":131,"start_character":0,"end_line":133,"end_character":27},"updated":"2018-05-10 17:12:59.000000000","message":"Thanks for adding this!","commit_id":"e621806457c34b9be361a2739111c0076ed28880"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"d198c9f9a3c715dc398c10b086fa86b980c3227f","unresolved":false,"context_lines":[{"line_number":145,"context_line":"  run the tox job with the admin role."},{"line_number":146,"context_line":"* Implement a non-voting Member gate Patrole tests in keystone infra job infra"},{"line_number":147,"context_line":"  and run the tox job with the Member role."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Current Test Coverage"},{"line_number":150,"context_line":"---------------------"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f7c97a3_31dbc91b","line":148,"updated":"2018-05-09 22:30:51.000000000","message":"Can we add a auditor role here as well (or just say we will run the default roles per the spec)","commit_id":"e621806457c34b9be361a2739111c0076ed28880"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"68f39a2f46d8ca0fa828b8c7f72e5091ccbb41f6","unresolved":false,"context_lines":[{"line_number":145,"context_line":"  run the tox job with the admin role."},{"line_number":146,"context_line":"* Implement a non-voting Member gate Patrole tests in keystone infra job infra"},{"line_number":147,"context_line":"  and run the tox job with the Member role."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Current Test Coverage"},{"line_number":150,"context_line":"---------------------"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f7c97a3_a2dd4543","line":148,"in_reply_to":"5f7c97a3_31dbc91b","updated":"2018-05-10 01:43:51.000000000","message":"Thanks, I missed this. I was trying to use intentionally vague language around which roles you can use (during my last update). I will generalize this to just say \"default roles per the spec\"","commit_id":"e621806457c34b9be361a2739111c0076ed28880"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"82658dbb74ba1f1bf583c1d2887a05a013a8c05f","unresolved":false,"context_lines":[{"line_number":145,"context_line":"  run the tox job with the admin role."},{"line_number":146,"context_line":"* Implement a non-voting Member gate Patrole tests in keystone infra job infra"},{"line_number":147,"context_line":"  and run the tox job with the Member role."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Current Test Coverage"},{"line_number":150,"context_line":"---------------------"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f7c97a3_bdb9e8e9","line":148,"in_reply_to":"5f7c97a3_a2dd4543","updated":"2018-05-10 02:13:05.000000000","message":"Lets call it \"Reader.\"  The more I think of it, Auditor implies a larger responsibility.  Going to suggest that on the standard roles spec, too.","commit_id":"e621806457c34b9be361a2739111c0076ed28880"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"87823a97410161b5bb61cce4ab0bcf2522f04fd5","unresolved":false,"context_lines":[{"line_number":145,"context_line":"  run the tox job with the admin role."},{"line_number":146,"context_line":"* Implement a non-voting Member gate Patrole tests in keystone infra job infra"},{"line_number":147,"context_line":"  and run the tox job with the Member role."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Current Test Coverage"},{"line_number":150,"context_line":"---------------------"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f7c97a3_fd63d240","line":148,"in_reply_to":"5f7c97a3_bdb9e8e9","updated":"2018-05-10 16:15:26.000000000","message":"No, let\u0027s keep with auditor. We have bikeshed on that quite a bit and full history is in that spec.","commit_id":"e621806457c34b9be361a2739111c0076ed28880"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e1be511dd3f8457e8a20f844f81d9646657cae0d","unresolved":false,"context_lines":[{"line_number":145,"context_line":"  run the tox job with the admin role."},{"line_number":146,"context_line":"* Implement a non-voting Member gate Patrole tests in keystone infra job infra"},{"line_number":147,"context_line":"  and run the tox job with the Member role."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Current Test Coverage"},{"line_number":150,"context_line":"---------------------"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f7c97a3_5c00c3ab","line":148,"in_reply_to":"5f7c97a3_fd63d240","updated":"2018-05-10 20:43:42.000000000","message":"I put down auditor. I will make the change to auditor|reader (whichever wins) once Harry\u0027s spec gets approved.","commit_id":"e621806457c34b9be361a2739111c0076ed28880"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"ec2f7b1e244bd831d305ad1ce95abecfe6e4b45e","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"Primary assignee:"},{"line_number":192,"context_line":"  Felipe Monteiro \u003cfelipe.monteiro@att.com\u003e"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"References"},{"line_number":195,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f7c97a3_93c40f93","line":193,"updated":"2018-05-10 17:12:59.000000000","message":"Please add me as a secondary assignee, Felipe.","commit_id":"e621806457c34b9be361a2739111c0076ed28880"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e1be511dd3f8457e8a20f844f81d9646657cae0d","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"Primary assignee:"},{"line_number":192,"context_line":"  Felipe Monteiro \u003cfelipe.monteiro@att.com\u003e"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"References"},{"line_number":195,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f7c97a3_1c300b9f","line":193,"in_reply_to":"5f7c97a3_93c40f93","updated":"2018-05-10 20:43:42.000000000","message":"Done","commit_id":"e621806457c34b9be361a2739111c0076ed28880"}],"specs/keystone/stein/patrole-keystone-gate.rst":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"04e35c0ae98fab0fb7f10a45706477299ed20c48","unresolved":false,"context_lines":[{"line_number":198,"context_line":"Primary assignees:"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"  * Felipe Monteiro felipe.monteiro@att.com"},{"line_number":201,"context_line":"  * Harry Rybacki hrybacki hrybacki@redhat.com"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"Dependencies"},{"line_number":204,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f7c97a3_58204b9c","line":201,"range":{"start_line":201,"start_character":18,"end_line":201,"end_character":26},"updated":"2018-05-17 16:03:11.000000000","message":"How did this get here?","commit_id":"c271f2a9e124f9623795232d86aac8438d8a2bff"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"c639aec9717fc440fbfe27a822c620fefd6fadfe","unresolved":false,"context_lines":[{"line_number":198,"context_line":"Primary assignees:"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"  * Felipe Monteiro felipe.monteiro@att.com"},{"line_number":201,"context_line":"  * Harry Rybacki hrybacki hrybacki@redhat.com"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"Dependencies"},{"line_number":204,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f7c97a3_2fe0a296","line":201,"range":{"start_line":201,"start_character":18,"end_line":201,"end_character":26},"in_reply_to":"5f7c97a3_58204b9c","updated":"2018-05-17 18:11:50.000000000","message":"I\u0027m not sure but it can be removed.","commit_id":"c271f2a9e124f9623795232d86aac8438d8a2bff"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"c639aec9717fc440fbfe27a822c620fefd6fadfe","unresolved":false,"context_lines":[{"line_number":181,"context_line":"dedicated to testing just Keystone APIs ought to be much faster, probably"},{"line_number":182,"context_line":"within the ballpark of 30-45 minutes."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":".. _auditor: https://review.openstack.org/#/c/566377"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"Conclusion"},{"line_number":187,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5f7c97a3_8f6bf6ef","line":184,"range":{"start_line":184,"start_character":0,"end_line":184,"end_character":52},"updated":"2018-05-17 18:11:50.000000000","message":"Why did we move this down here? It seems a bit out of place now.","commit_id":"574d209d0b4de79ebfc627620a1d61dd5bc875a1"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"613841c909be1d3393bc226b30c9a0fd28b70e70","unresolved":false,"context_lines":[{"line_number":181,"context_line":"dedicated to testing just Keystone APIs ought to be much faster, probably"},{"line_number":182,"context_line":"within the ballpark of 30-45 minutes."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":".. _auditor: https://review.openstack.org/#/c/566377"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"Conclusion"},{"line_number":187,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5f7c97a3_c5db0f1f","line":184,"range":{"start_line":184,"start_character":0,"end_line":184,"end_character":52},"in_reply_to":"5f7c97a3_8f6bf6ef","updated":"2018-05-17 19:23:30.000000000","message":"Thanks, nice catch, will move to bottom.","commit_id":"574d209d0b4de79ebfc627620a1d61dd5bc875a1"}]}
