)]}'
{"specs/keystone/backlog/global-roles.rst":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"182b578a14a4db265f6ab5b0964bd0d0d0c3b747","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Today, role assignments are built by giving an actor a role on a target. An"},{"line_number":20,"context_line":"actor can be a user or a group. A target is limited to a project or a domain."},{"line_number":21,"context_line":"This works great for controlling access to things that map into a project or"},{"line_number":22,"context_line":"domain (e.g. instance ownership fits naturally within projects). This starts to"},{"line_number":23,"context_line":"get confusing with operations that don\u0027t fit within that constraint. Live"},{"line_number":24,"context_line":"migrating an instance from one host to another is a good example of this."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"A global role assignment would be an assignment with the target being `global`"},{"line_number":27,"context_line":"instead of a project or a domain."}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f201791_f13b7f99","line":24,"range":{"start_line":22,"start_character":65,"end_line":24,"end_character":73},"updated":"2017-06-21 16:35:54.000000000","message":"I don\u0027t think that\u0027s really a great example. The prime example in my mind is nova\u0027s GET /v2.1/servers?all_tenants. Today, that allows an admin scoped to ANY project to see instances in  ALL projects, whereas they should only be allowed to see instances in the project where they have the admin role assignment. See bug 968696.\n\nWhen it comes to live migrate... I don\u0027t know if that should require a global role assignment or not. The fact that hypervisors are not scoped to a specific project doesn\u0027t necessarily mean that seeing them or even targeting them for deploys/migrations should require a globally-scoped token. It\u0027s perfectly valid to say some things are globally visible, i.e. visible to all users regardless of their scope, and hypervisors probably fall into that category.","commit_id":"5bfc837e312e2866cd299f27218b1d972bf3a9c6"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8f275791c3c63f2849af47d248b45e486253db73","unresolved":false,"context_lines":[{"line_number":21,"context_line":"This works great for controlling access to things that map into a project or"},{"line_number":22,"context_line":"domain (e.g. instance ownership fits naturally within projects). This starts to"},{"line_number":23,"context_line":"get confusing with operations that don\u0027t fit within that constraint. Live"},{"line_number":24,"context_line":"migrating an instance from one host to another is a good example of this."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"A global role assignment would be an assignment with the target being `global`"},{"line_number":27,"context_line":"instead of a project or a domain."}],"source_content_type":"text/x-rst","patch_set":14,"id":"5f201791_2c74fa34","line":24,"in_reply_to":"5f201791_f13b7f99","updated":"2017-06-21 17:23:49.000000000","message":"The argument for using live migration in this example was driven by the fact that it requires the end users to know the hosts their instance is hosted on and which one they want to move it to. The bit that I think made this seem like a good example at the time was the fact that host information might not be the best thing to expose to every user.\n\nRegardless, I can update this with the list servers example since I think that paints a better picture. Thanks!","commit_id":"5bfc837e312e2866cd299f27218b1d972bf3a9c6"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"b799e19666f7f703ccf2808b19fbedb0e5b66c79","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                    }"},{"line_number":292,"context_line":"                }"},{"line_number":293,"context_line":"            },"},{"line_number":294,"context_line":"            \"scope\": \"global\""},{"line_number":295,"context_line":"        }"},{"line_number":296,"context_line":"    }"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f201791_de1cde6b","line":294,"range":{"start_line":294,"start_character":12,"end_line":294,"end_character":29},"updated":"2017-06-23 01:34:27.000000000","message":"I still think this should be a dict, so it\u0027s as we represent roles in the role_assignments api and also as we represent the scope for other token requests\n\n                \"scope\": {\n                    \"global\": \"true\"\n                }\n\n                \"scope\": {\n                    \"project\": ...\n                }","commit_id":"0d23f566472328bb20628e8aa870a5140c53e69f"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"6c613de403e695b054ef586e49b9dd4dc7dfdb9f","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                    }"},{"line_number":292,"context_line":"                }"},{"line_number":293,"context_line":"            },"},{"line_number":294,"context_line":"            \"scope\": \"global\""},{"line_number":295,"context_line":"        }"},{"line_number":296,"context_line":"    }"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"7f287b81_6798451b","line":294,"range":{"start_line":294,"start_character":12,"end_line":294,"end_character":29},"in_reply_to":"3f1d235d_62eaeaac","updated":"2017-08-30 02:23:31.000000000","message":"++ this should match how project/domains tokens are scoped...","commit_id":"0d23f566472328bb20628e8aa870a5140c53e69f"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"e84e345ca304c26b2da918040ff2bae8f2483f96","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                    }"},{"line_number":292,"context_line":"                }"},{"line_number":293,"context_line":"            },"},{"line_number":294,"context_line":"            \"scope\": \"global\""},{"line_number":295,"context_line":"        }"},{"line_number":296,"context_line":"    }"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3f1d235d_62eaeaac","line":294,"range":{"start_line":294,"start_character":12,"end_line":294,"end_character":29},"in_reply_to":"5f201791_de1cde6b","updated":"2017-06-30 20:07:00.000000000","message":"++","commit_id":"0d23f566472328bb20628e8aa870a5140c53e69f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6f7ca6ed02ca876e67ddb7d29327f96ac684bc4f","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                    }"},{"line_number":292,"context_line":"                }"},{"line_number":293,"context_line":"            },"},{"line_number":294,"context_line":"            \"scope\": \"global\""},{"line_number":295,"context_line":"        }"},{"line_number":296,"context_line":"    }"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"7f287b81_79a8a2da","line":294,"in_reply_to":"7f287b81_6798451b","updated":"2017-09-01 15:19:34.000000000","message":"Done","commit_id":"0d23f566472328bb20628e8aa870a5140c53e69f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8de6e850e69a83551f5fc95e346f1138af8a976c","unresolved":false,"context_lines":[{"line_number":297,"context_line":""},{"line_number":298,"context_line":"An example response would be::"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    {                                                                                                                                                                                                                                      [2/21]"},{"line_number":301,"context_line":"        \"token\": {"},{"line_number":302,"context_line":"            \"audit_ids\": ["},{"line_number":303,"context_line":"                \"doIh18J8RyW3jXF50FV26g\""}],"source_content_type":"text/x-rst","patch_set":15,"id":"7f287b81_24b9692d","line":300,"updated":"2017-08-29 13:54:01.000000000","message":"This must be a bad copy/paste from my terminal.","commit_id":"0d23f566472328bb20628e8aa870a5140c53e69f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6f7ca6ed02ca876e67ddb7d29327f96ac684bc4f","unresolved":false,"context_lines":[{"line_number":297,"context_line":""},{"line_number":298,"context_line":"An example response would be::"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    {                                                                                                                                                                                                                                      [2/21]"},{"line_number":301,"context_line":"        \"token\": {"},{"line_number":302,"context_line":"            \"audit_ids\": ["},{"line_number":303,"context_line":"                \"doIh18J8RyW3jXF50FV26g\""}],"source_content_type":"text/x-rst","patch_set":15,"id":"7f287b81_d9e79646","line":300,"in_reply_to":"7f287b81_24b9692d","updated":"2017-09-01 15:19:34.000000000","message":"Done","commit_id":"0d23f566472328bb20628e8aa870a5140c53e69f"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"abaf30806cc43fa14fa889aa3e8abafc095c2111","unresolved":false,"context_lines":[{"line_number":346,"context_line":"ensure it handles global scope from tokens properly. The primary purpose of"},{"line_number":347,"context_line":"this specification is to allow for the scoping of roles globally and exposing"},{"line_number":348,"context_line":"that ability to end users. Work can be done in parallel to consume this"},{"line_number":349,"context_line":"information in policy files or shared libraries."},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"Alternatives"},{"line_number":352,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7f287b81_02728fad","line":349,"updated":"2017-08-30 02:40:17.000000000","message":"For clarity, somewhere we should state whether global roles can be an implied role as well as be used in an inherited role assignment. I think the former makes sense, but the later does not.","commit_id":"0d23f566472328bb20628e8aa870a5140c53e69f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6f7ca6ed02ca876e67ddb7d29327f96ac684bc4f","unresolved":false,"context_lines":[{"line_number":346,"context_line":"ensure it handles global scope from tokens properly. The primary purpose of"},{"line_number":347,"context_line":"this specification is to allow for the scoping of roles globally and exposing"},{"line_number":348,"context_line":"that ability to end users. Work can be done in parallel to consume this"},{"line_number":349,"context_line":"information in policy files or shared libraries."},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"Alternatives"},{"line_number":352,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7f287b81_39c1fa81","line":349,"in_reply_to":"7f287b81_02728fad","updated":"2017-09-01 15:19:34.000000000","message":"Excellent point. I think the former makes sense but I struggle to come up with a use case for the inherited roles. I\u0027ll add a section on it.","commit_id":"0d23f566472328bb20628e8aa870a5140c53e69f"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"86a592fd4d28fdec441c2efcc5b5ed12f40090da","unresolved":false,"context_lines":[{"line_number":346,"context_line":"ensure it handles global scope from tokens properly. The primary purpose of"},{"line_number":347,"context_line":"this specification is to allow for the scoping of roles globally and exposing"},{"line_number":348,"context_line":"that ability to end users. Work can be done in parallel to consume this"},{"line_number":349,"context_line":"information in policy files or shared libraries."},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"Alternatives"},{"line_number":352,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7f287b81_6c455770","line":349,"in_reply_to":"7f287b81_39c1fa81","updated":"2017-09-04 15:00:29.000000000","message":"Agreed, inherited roles don\u0027t really make sense, since you are not tieing the assignment to an anchor point from which inheritance can start. I think you should explicitly state that we do not support (and will fail with an error), something like:\n\n`PUT /v3/users/{user_id}/roles/{role_id}/inherited`","commit_id":"0d23f566472328bb20628e8aa870a5140c53e69f"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"6c613de403e695b054ef586e49b9dd4dc7dfdb9f","unresolved":false,"context_lines":[{"line_number":351,"context_line":"Alternatives"},{"line_number":352,"context_line":"------------"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"An alternative to this approach would be to leverage the `admin_project` in"},{"line_number":355,"context_line":"order to achieve global scoping. The `admin_project` is a special project that"},{"line_number":356,"context_line":"allows for elevated privileges if role assignments are given to that project."},{"line_number":357,"context_line":"Let\u0027s consider the following example. Let\u0027s say there is an `observer` role"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7f287b81_276c7d06","line":354,"range":{"start_line":354,"start_character":57,"end_line":354,"end_character":72},"updated":"2017-08-30 02:23:31.000000000","message":"If we have global roles, do we really need the admin_project? If so, what are the scenarios that are appropriate for this. I don\u0027t think we want to end up with different sets of \"scope widening\" capabilities, or we create too many attack vectors.","commit_id":"0d23f566472328bb20628e8aa870a5140c53e69f"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"9b7d08ac92e1bf0f39df46cd55282016af3a0bec","unresolved":false,"context_lines":[{"line_number":351,"context_line":"Alternatives"},{"line_number":352,"context_line":"------------"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"An alternative to this approach would be to leverage the `admin_project` in"},{"line_number":355,"context_line":"order to achieve global scoping. The `admin_project` is a special project that"},{"line_number":356,"context_line":"allows for elevated privileges if role assignments are given to that project."},{"line_number":357,"context_line":"Let\u0027s consider the following example. Let\u0027s say there is an `observer` role"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7f287b81_83eb1076","line":354,"range":{"start_line":354,"start_character":57,"end_line":354,"end_character":72},"in_reply_to":"7f287b81_276c7d06","updated":"2017-08-30 17:51:28.000000000","message":"I think the goal of global roles was to replace \"admin_project\" if I read this correctly?","commit_id":"0d23f566472328bb20628e8aa870a5140c53e69f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6f7ca6ed02ca876e67ddb7d29327f96ac684bc4f","unresolved":false,"context_lines":[{"line_number":351,"context_line":"Alternatives"},{"line_number":352,"context_line":"------------"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"An alternative to this approach would be to leverage the `admin_project` in"},{"line_number":355,"context_line":"order to achieve global scoping. The `admin_project` is a special project that"},{"line_number":356,"context_line":"allows for elevated privileges if role assignments are given to that project."},{"line_number":357,"context_line":"Let\u0027s consider the following example. Let\u0027s say there is an `observer` role"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7f287b81_39ad7a31","line":354,"in_reply_to":"7f287b81_83eb1076","updated":"2017-09-01 15:19:34.000000000","message":"Correct - at least based on the feedback from operators on both approaches [0].\n\n[0] http://lists.openstack.org/pipermail/openstack-dev/2017-May/117419.html","commit_id":"0d23f566472328bb20628e8aa870a5140c53e69f"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"6c613de403e695b054ef586e49b9dd4dc7dfdb9f","unresolved":false,"context_lines":[{"line_number":396,"context_line":"Security Impact"},{"line_number":397,"context_line":"---------------"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"This type of scoping will allow OpenStack services to separate global"},{"line_number":400,"context_line":"operations from project or domain scoped operations. The result will be an"},{"line_number":401,"context_line":"improved security model across OpenStack."},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"Notifications Impact"},{"line_number":404,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7f287b81_a7474dbc","line":401,"range":{"start_line":399,"start_character":0,"end_line":401,"end_character":41},"updated":"2017-08-30 02:23:31.000000000","message":"I don\u0027t think it is all good news here. Doesn\u0027t this increase the damage that stolen bearer token could cause (i.e. if that stolen token was globally scoped)?","commit_id":"0d23f566472328bb20628e8aa870a5140c53e69f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6f7ca6ed02ca876e67ddb7d29327f96ac684bc4f","unresolved":false,"context_lines":[{"line_number":398,"context_line":""},{"line_number":399,"context_line":"This type of scoping will allow OpenStack services to separate global"},{"line_number":400,"context_line":"operations from project or domain scoped operations. The result will be an"},{"line_number":401,"context_line":"improved security model across OpenStack."},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"Notifications Impact"},{"line_number":404,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7f287b81_793e62db","line":401,"in_reply_to":"7f287b81_a7474dbc","updated":"2017-09-01 15:19:34.000000000","message":"True - it does. But the same attack vector is exposed today with existing tokens and hardcoding to admin. Regardless, I think this highlights that we should consider ways to get rid of bearer tokens all together.","commit_id":"0d23f566472328bb20628e8aa870a5140c53e69f"}],"specs/keystone/ongoing/global-roles.rst":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"9337a2a47818e0a7cb7e8830825a484ebe01a7f2","unresolved":false,"context_lines":[{"line_number":106,"context_line":"In this model, global scope is determined by a specific project and the role"},{"line_number":107,"context_line":"assignments that project has. Every user that requires a global role (i.e."},{"line_number":108,"context_line":"admin, observer, support, etc) in a deployment will be required to have a role"},{"line_number":109,"context_line":"assignment on the `admin_project`."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Security Impact"},{"line_number":112,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f013ff3_9a9b3371","line":109,"updated":"2017-05-16 03:33:44.000000000","message":"I think it would be good to explain here why this alternative is not optimal - undefined behavior if the special project is deleted, for example","commit_id":"cb219c93ea003cb11c12868f30ef3af9c2c43588"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"38ad26089e7018231730637cbedce8dd765ae7cc","unresolved":false,"context_lines":[{"line_number":106,"context_line":"In this model, global scope is determined by a specific project and the role"},{"line_number":107,"context_line":"assignments that project has. Every user that requires a global role (i.e."},{"line_number":108,"context_line":"admin, observer, support, etc) in a deployment will be required to have a role"},{"line_number":109,"context_line":"assignment on the `admin_project`."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Security Impact"},{"line_number":112,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f013ff3_27463a23","line":109,"in_reply_to":"1f013ff3_9a9b3371","updated":"2017-05-16 14:48:57.000000000","message":"Great point! I can take a stab at that.","commit_id":"cb219c93ea003cb11c12868f30ef3af9c2c43588"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"5fba0705abe11560a0479a5d92f4159368de0503","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  happens to the `admin_project`"},{"line_number":123,"context_line":"* Operators may find it confusing to have a role on a super-special project in"},{"line_number":124,"context_line":"  order to have elevated privileges, which seems like an anti-pattern"},{"line_number":125,"context_line":"* All users that require a global role of some kind must have a role assignment"},{"line_number":126,"context_line":"  on the `admin_project`, this could result in a large number of role"},{"line_number":127,"context_line":"  assignments on the `admin_project`"},{"line_number":128,"context_line":"* Develop some sort of recovery plan in the event the `admin_project` is"},{"line_number":129,"context_line":"  accidentally deleted"},{"line_number":130,"context_line":"* Certain resources can\u0027t belong in global scope today (i.e. instances must be"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_f76f1790","line":127,"range":{"start_line":125,"start_character":2,"end_line":127,"end_character":36},"updated":"2017-05-17 15:38:39.000000000","message":"This isn\u0027t really a drawback. If you think of all role assignments to the admin_project as global roles, then the number of role assignments to this project is the same number of assignments that would be returned by querying the global role assignments. This is, of course, assuming that people will not use the admin project to actually deploy instances, which they shouldn\u0027t.","commit_id":"dbb5f7a766b2cc5a11ee2586a1f0bf6f4ee7c8c5"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"58cab4c2d1b98aa5172f79c4e5d6ebf923d6f334","unresolved":false,"context_lines":[{"line_number":124,"context_line":"  order to have elevated privileges, which seems like an anti-pattern"},{"line_number":125,"context_line":"* All users that require a global role of some kind must have a role assignment"},{"line_number":126,"context_line":"  on the `admin_project`, this could result in a large number of role"},{"line_number":127,"context_line":"  assignments on the `admin_project`"},{"line_number":128,"context_line":"* Develop some sort of recovery plan in the event the `admin_project` is"},{"line_number":129,"context_line":"  accidentally deleted"},{"line_number":130,"context_line":"* Certain resources can\u0027t belong in global scope today (i.e. instances must be"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_ae994120","line":127,"in_reply_to":"ff0f0b1f_4b21774d","updated":"2017-05-17 19:49:43.000000000","message":"I agree that it\u0027s not optimal and it\u0027s counterintuitive. Still, as I said in the comment below, you can just prevent anything happening to it with 403.","commit_id":"dbb5f7a766b2cc5a11ee2586a1f0bf6f4ee7c8c5"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e28ffca2ccc9dbc0d4f217ae934f65ec58b20026","unresolved":false,"context_lines":[{"line_number":124,"context_line":"  order to have elevated privileges, which seems like an anti-pattern"},{"line_number":125,"context_line":"* All users that require a global role of some kind must have a role assignment"},{"line_number":126,"context_line":"  on the `admin_project`, this could result in a large number of role"},{"line_number":127,"context_line":"  assignments on the `admin_project`"},{"line_number":128,"context_line":"* Develop some sort of recovery plan in the event the `admin_project` is"},{"line_number":129,"context_line":"  accidentally deleted"},{"line_number":130,"context_line":"* Certain resources can\u0027t belong in global scope today (i.e. instances must be"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_4b21774d","line":127,"in_reply_to":"ff0f0b1f_f76f1790","updated":"2017-05-17 18:49:27.000000000","message":"It does expose a single point of failure if anything happens to the admin_project though.\n\nI see this as a downside because we have yet another special resource in keystone (and possibly client scripts) that can\u0027t be tampered with. For example, if I\u0027m writing a script to do something with projects, I\u0027ll have to code around the admin_project for safety reasons. The admin project name and ID might also change across deployments, which means porting an application or script across deployments requires it to know the difference in admin_project.","commit_id":"dbb5f7a766b2cc5a11ee2586a1f0bf6f4ee7c8c5"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"5fba0705abe11560a0479a5d92f4159368de0503","unresolved":false,"context_lines":[{"line_number":125,"context_line":"* All users that require a global role of some kind must have a role assignment"},{"line_number":126,"context_line":"  on the `admin_project`, this could result in a large number of role"},{"line_number":127,"context_line":"  assignments on the `admin_project`"},{"line_number":128,"context_line":"* Develop some sort of recovery plan in the event the `admin_project` is"},{"line_number":129,"context_line":"  accidentally deleted"},{"line_number":130,"context_line":"* Certain resources can\u0027t belong in global scope today (i.e. instances must be"},{"line_number":131,"context_line":"  tied to a project), this approach doesn\u0027t stop users from creating resources"},{"line_number":132,"context_line":"  within the `admin_project`, which would be the equivalent to global resources"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ff0f0b1f_b773df4d","line":129,"range":{"start_line":128,"start_character":2,"end_line":129,"end_character":22},"updated":"2017-05-17 15:38:39.000000000","message":"Or straight up prevent admin_project deletion in keystone with 403.","commit_id":"dbb5f7a766b2cc5a11ee2586a1f0bf6f4ee7c8c5"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"0c50e2960a65ccf2fa3844f0008cb1d2a10d6f7f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                    }"},{"line_number":46,"context_line":"                }"},{"line_number":47,"context_line":"            },"},{"line_number":48,"context_line":"            \"scope\": \"global\""},{"line_number":49,"context_line":"        }"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"ff0f0b1f_7d3d0c2b","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":29},"updated":"2017-05-26 17:30:38.000000000","message":"No need for this. If \"scope\" is absent, it should imply \"global\". Lets save some bandwidth and typing fatigue if we can. :-)","commit_id":"dc1d371e546028dee4bb00c2770d999a29d04b10"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"42692d2ab44d64d465b4b0e3081c90cbd1281d38","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                    }"},{"line_number":46,"context_line":"                }"},{"line_number":47,"context_line":"            },"},{"line_number":48,"context_line":"            \"scope\": \"global\""},{"line_number":49,"context_line":"        }"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"df140735_f2881c20","line":48,"in_reply_to":"ff0f0b1f_7d3d0c2b","updated":"2017-05-30 16:27:08.000000000","message":"I think having it explicit is an advantage. Keystone already has a bunch of logic around the absence of scope with the `default_project` attributes of users. I also think it\u0027s important to distinguish the difference between and unscoped token and a globally scoped token.","commit_id":"dc1d371e546028dee4bb00c2770d999a29d04b10"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"0c50e2960a65ccf2fa3844f0008cb1d2a10d6f7f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                ..."},{"line_number":61,"context_line":"            ],"},{"line_number":62,"context_line":"            \"expires_at\": \"2017-05-15T21:58:29.000000Z\","},{"line_number":63,"context_line":"            \"is_domain\": false,"},{"line_number":64,"context_line":"            \"issued_at\": \"2017-05-15T20:58:29.000000Z\","},{"line_number":65,"context_line":"            \"methods\": ["},{"line_number":66,"context_line":"                \"password\""}],"source_content_type":"text/x-rst","patch_set":9,"id":"ff0f0b1f_9d5fc071","line":63,"range":{"start_line":63,"start_character":12,"end_line":63,"end_character":31},"updated":"2017-05-26 17:30:38.000000000","message":"What\u0027s this?","commit_id":"dc1d371e546028dee4bb00c2770d999a29d04b10"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"42692d2ab44d64d465b4b0e3081c90cbd1281d38","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                ..."},{"line_number":61,"context_line":"            ],"},{"line_number":62,"context_line":"            \"expires_at\": \"2017-05-15T21:58:29.000000Z\","},{"line_number":63,"context_line":"            \"is_domain\": false,"},{"line_number":64,"context_line":"            \"issued_at\": \"2017-05-15T20:58:29.000000Z\","},{"line_number":65,"context_line":"            \"methods\": ["},{"line_number":66,"context_line":"                \"password\""}],"source_content_type":"text/x-rst","patch_set":9,"id":"df140735_d27d181d","line":63,"in_reply_to":"ff0f0b1f_9d5fc071","updated":"2017-05-30 16:27:08.000000000","message":"A bad copy paste :)","commit_id":"dc1d371e546028dee4bb00c2770d999a29d04b10"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"0c50e2960a65ccf2fa3844f0008cb1d2a10d6f7f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            }"},{"line_number":88,"context_line":"        }"},{"line_number":89,"context_line":"    }"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ff0f0b1f_13b4bf34","line":90,"updated":"2017-05-26 17:30:38.000000000","message":"An example here on what the policy and work flow are going to look like would be super awesome. For example, in a service policy file, you may use something like\n\n  \"global_admin\": \"role:admin and global:True\",\n  \"global_reader\": \"role:reader and global:True\",\n  \"admin_required\": \"rule:global_admin or ...\",","commit_id":"dc1d371e546028dee4bb00c2770d999a29d04b10"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"42692d2ab44d64d465b4b0e3081c90cbd1281d38","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            }"},{"line_number":88,"context_line":"        }"},{"line_number":89,"context_line":"    }"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":9,"id":"df140735_d26cf837","line":90,"in_reply_to":"ff0f0b1f_13b4bf34","updated":"2017-05-30 16:27:08.000000000","message":"Done","commit_id":"dc1d371e546028dee4bb00c2770d999a29d04b10"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"0c50e2960a65ccf2fa3844f0008cb1d2a10d6f7f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"An alternative to this approach would be to leverage the `admin_project` in"},{"line_number":97,"context_line":"order to achieve global scoping. The `admin_project` is a special project that"},{"line_number":98,"context_line":"allows for elevated privileges if role assignment are given to that project."},{"line_number":99,"context_line":"Let\u0027s consider the following example. Let\u0027s there is an `observer` role that"},{"line_number":100,"context_line":"allows users to do non-destructive operations within a specific scope. If Bob"},{"line_number":101,"context_line":"has the `observer` role on project `foo`, he should be able to view things"},{"line_number":102,"context_line":"within that tenancy. If Alice has the `observer` role on the `admin_project`,"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ff0f0b1f_1da73052","line":99,"range":{"start_line":99,"start_character":38,"end_line":99,"end_character":43},"updated":"2017-05-26 17:30:38.000000000","message":"Let say?","commit_id":"dc1d371e546028dee4bb00c2770d999a29d04b10"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"42692d2ab44d64d465b4b0e3081c90cbd1281d38","unresolved":false,"context_lines":[{"line_number":96,"context_line":"An alternative to this approach would be to leverage the `admin_project` in"},{"line_number":97,"context_line":"order to achieve global scoping. The `admin_project` is a special project that"},{"line_number":98,"context_line":"allows for elevated privileges if role assignment are given to that project."},{"line_number":99,"context_line":"Let\u0027s consider the following example. Let\u0027s there is an `observer` role that"},{"line_number":100,"context_line":"allows users to do non-destructive operations within a specific scope. If Bob"},{"line_number":101,"context_line":"has the `observer` role on project `foo`, he should be able to view things"},{"line_number":102,"context_line":"within that tenancy. If Alice has the `observer` role on the `admin_project`,"}],"source_content_type":"text/x-rst","patch_set":9,"id":"df140735_128390ce","line":99,"in_reply_to":"ff0f0b1f_1da73052","updated":"2017-05-30 16:27:08.000000000","message":"Done","commit_id":"dc1d371e546028dee4bb00c2770d999a29d04b10"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"0c50e2960a65ccf2fa3844f0008cb1d2a10d6f7f","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Drawbacks:"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"* Automated tooling might have to handle this project separately (i.e. coding"},{"line_number":121,"context_line":"  around an implementation detail of how policy is elevated) to ensure nothing"},{"line_number":122,"context_line":"  happens to the `admin_project`"},{"line_number":123,"context_line":"* Operators may find it confusing to have a role on a super-special project in"},{"line_number":124,"context_line":"  order to have elevated privileges, which seems like an anti-pattern"},{"line_number":125,"context_line":"* All users that require a global role of some kind must have a role assignment"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ff0f0b1f_401a5b17","line":122,"range":{"start_line":120,"start_character":2,"end_line":122,"end_character":32},"updated":"2017-05-26 17:30:38.000000000","message":"Problem is we need to first bootstrap the admin project, then get the project ID and fill it into the policy.json templates, then push the policy.json files across to all the controllers. But if we are using project name, I don\u0027t know who oslo.policy is going to handle hierarchical project name.","commit_id":"dc1d371e546028dee4bb00c2770d999a29d04b10"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"42692d2ab44d64d465b4b0e3081c90cbd1281d38","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"* Automated tooling might have to handle this project separately (i.e. coding"},{"line_number":121,"context_line":"  around an implementation detail of how policy is elevated) to ensure nothing"},{"line_number":122,"context_line":"  happens to the `admin_project`"},{"line_number":123,"context_line":"* Operators may find it confusing to have a role on a super-special project in"},{"line_number":124,"context_line":"  order to have elevated privileges, which seems like an anti-pattern"},{"line_number":125,"context_line":"* All users that require a global role of some kind must have a role assignment"}],"source_content_type":"text/x-rst","patch_set":9,"id":"df140735_f2bc9c6a","line":122,"in_reply_to":"ff0f0b1f_401a5b17","updated":"2017-05-30 16:27:08.000000000","message":"This seems easier using global role assignments because \"global\" is known and doesn\u0027t change per deployment, if that\u0027s what you were getting at.","commit_id":"dc1d371e546028dee4bb00c2770d999a29d04b10"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"0c50e2960a65ccf2fa3844f0008cb1d2a10d6f7f","unresolved":false,"context_lines":[{"line_number":120,"context_line":"* Automated tooling might have to handle this project separately (i.e. coding"},{"line_number":121,"context_line":"  around an implementation detail of how policy is elevated) to ensure nothing"},{"line_number":122,"context_line":"  happens to the `admin_project`"},{"line_number":123,"context_line":"* Operators may find it confusing to have a role on a super-special project in"},{"line_number":124,"context_line":"  order to have elevated privileges, which seems like an anti-pattern"},{"line_number":125,"context_line":"* All users that require a global role of some kind must have a role assignment"},{"line_number":126,"context_line":"  on the `admin_project`, this could result in a large number of role"},{"line_number":127,"context_line":"  assignments on the `admin_project`"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ff0f0b1f_80e5130d","line":124,"range":{"start_line":123,"start_character":2,"end_line":124,"end_character":69},"updated":"2017-05-26 17:30:38.000000000","message":"Sure. But then again, \"global scope\" is really implicitly scoped to the \"root project\", if we really think about it.","commit_id":"dc1d371e546028dee4bb00c2770d999a29d04b10"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"42692d2ab44d64d465b4b0e3081c90cbd1281d38","unresolved":false,"context_lines":[{"line_number":121,"context_line":"  around an implementation detail of how policy is elevated) to ensure nothing"},{"line_number":122,"context_line":"  happens to the `admin_project`"},{"line_number":123,"context_line":"* Operators may find it confusing to have a role on a super-special project in"},{"line_number":124,"context_line":"  order to have elevated privileges, which seems like an anti-pattern"},{"line_number":125,"context_line":"* All users that require a global role of some kind must have a role assignment"},{"line_number":126,"context_line":"  on the `admin_project`, this could result in a large number of role"},{"line_number":127,"context_line":"  assignments on the `admin_project`"}],"source_content_type":"text/x-rst","patch_set":9,"id":"df140735_72e1ac9a","line":124,"in_reply_to":"ff0f0b1f_80e5130d","updated":"2017-05-30 16:27:08.000000000","message":"Well - it\u0027s scoped to a \"global\". There is no project behind the scenes backing the concept.","commit_id":"dc1d371e546028dee4bb00c2770d999a29d04b10"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"0c50e2960a65ccf2fa3844f0008cb1d2a10d6f7f","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  happens to the `admin_project`"},{"line_number":123,"context_line":"* Operators may find it confusing to have a role on a super-special project in"},{"line_number":124,"context_line":"  order to have elevated privileges, which seems like an anti-pattern"},{"line_number":125,"context_line":"* All users that require a global role of some kind must have a role assignment"},{"line_number":126,"context_line":"  on the `admin_project`, this could result in a large number of role"},{"line_number":127,"context_line":"  assignments on the `admin_project`"},{"line_number":128,"context_line":"* Develop some sort of recovery plan in the event the `admin_project` is"},{"line_number":129,"context_line":"  accidentally deleted"},{"line_number":130,"context_line":"* Certain resources can\u0027t belong in global scope today (i.e. instances must be"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ff0f0b1f_60cb1f72","line":127,"range":{"start_line":125,"start_character":2,"end_line":127,"end_character":36},"updated":"2017-05-26 17:30:38.000000000","message":"I can\u0027t imagine a deployment would have that many global roles. Don\u0027t forget we also have imply roles to perhaps make things more manageable if needed.","commit_id":"dc1d371e546028dee4bb00c2770d999a29d04b10"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"0c50e2960a65ccf2fa3844f0008cb1d2a10d6f7f","unresolved":false,"context_lines":[{"line_number":125,"context_line":"* All users that require a global role of some kind must have a role assignment"},{"line_number":126,"context_line":"  on the `admin_project`, this could result in a large number of role"},{"line_number":127,"context_line":"  assignments on the `admin_project`"},{"line_number":128,"context_line":"* Develop some sort of recovery plan in the event the `admin_project` is"},{"line_number":129,"context_line":"  accidentally deleted"},{"line_number":130,"context_line":"* Certain resources can\u0027t belong in global scope today (i.e. instances must be"},{"line_number":131,"context_line":"  tied to a project), this approach doesn\u0027t stop users from creating resources"},{"line_number":132,"context_line":"  within the `admin_project`, which would be the equivalent to global resources"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ff0f0b1f_c0a9cb90","line":129,"range":{"start_line":128,"start_character":2,"end_line":129,"end_character":22},"updated":"2017-05-26 17:30:38.000000000","message":"That\u0027s a big reason we should NOT be using the admin project hack.","commit_id":"dc1d371e546028dee4bb00c2770d999a29d04b10"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"42692d2ab44d64d465b4b0e3081c90cbd1281d38","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  on the `admin_project`, this could result in a large number of role"},{"line_number":127,"context_line":"  assignments on the `admin_project`"},{"line_number":128,"context_line":"* Develop some sort of recovery plan in the event the `admin_project` is"},{"line_number":129,"context_line":"  accidentally deleted"},{"line_number":130,"context_line":"* Certain resources can\u0027t belong in global scope today (i.e. instances must be"},{"line_number":131,"context_line":"  tied to a project), this approach doesn\u0027t stop users from creating resources"},{"line_number":132,"context_line":"  within the `admin_project`, which would be the equivalent to global resources"}],"source_content_type":"text/x-rst","patch_set":9,"id":"df140735_1246f07d","line":129,"in_reply_to":"ff0f0b1f_c0a9cb90","updated":"2017-05-30 16:27:08.000000000","message":"Yeah... I\u0027m scared to have a conversation with an operator that unfortunately had this happen.","commit_id":"dc1d371e546028dee4bb00c2770d999a29d04b10"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"0c50e2960a65ccf2fa3844f0008cb1d2a10d6f7f","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  assignments on the `admin_project`"},{"line_number":128,"context_line":"* Develop some sort of recovery plan in the event the `admin_project` is"},{"line_number":129,"context_line":"  accidentally deleted"},{"line_number":130,"context_line":"* Certain resources can\u0027t belong in global scope today (i.e. instances must be"},{"line_number":131,"context_line":"  tied to a project), this approach doesn\u0027t stop users from creating resources"},{"line_number":132,"context_line":"  within the `admin_project`, which would be the equivalent to global resources"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"ff0f0b1f_60c79f47","line":131,"range":{"start_line":130,"start_character":2,"end_line":131,"end_character":21},"updated":"2017-05-26 17:30:38.000000000","message":"That\u0027s something we\u0027ve been arguing over since the beginning of time. So as long as services continue to do enforcements in their own code, we never going to achieve global and consistent RBAC. :-)","commit_id":"dc1d371e546028dee4bb00c2770d999a29d04b10"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"42692d2ab44d64d465b4b0e3081c90cbd1281d38","unresolved":false,"context_lines":[{"line_number":128,"context_line":"* Develop some sort of recovery plan in the event the `admin_project` is"},{"line_number":129,"context_line":"  accidentally deleted"},{"line_number":130,"context_line":"* Certain resources can\u0027t belong in global scope today (i.e. instances must be"},{"line_number":131,"context_line":"  tied to a project), this approach doesn\u0027t stop users from creating resources"},{"line_number":132,"context_line":"  within the `admin_project`, which would be the equivalent to global resources"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"df140735_922e80a3","line":131,"in_reply_to":"ff0f0b1f_60c79f47","updated":"2017-05-30 16:27:08.000000000","message":"My thinking behind this was that global tokens won\u0027t be associated to or communicating a project in any way. Allowing a resource to be owned by a project would be harder in that sense.","commit_id":"dc1d371e546028dee4bb00c2770d999a29d04b10"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"0c50e2960a65ccf2fa3844f0008cb1d2a10d6f7f","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"This is highly dependent on how operators have configured their policy across"},{"line_number":152,"context_line":"OpenStack. Ideally, this will give operators more tools to provide better"},{"line_number":153,"context_line":"security in their deployments."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Performance Impact"},{"line_number":156,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ff0f0b1f_207c07b4","line":153,"range":{"start_line":153,"start_character":29,"end_line":153,"end_character":30},"updated":"2017-05-26 17:30:38.000000000","message":"We also need to be extreme careful about role naming.","commit_id":"dc1d371e546028dee4bb00c2770d999a29d04b10"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"42692d2ab44d64d465b4b0e3081c90cbd1281d38","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"This is highly dependent on how operators have configured their policy across"},{"line_number":152,"context_line":"OpenStack. Ideally, this will give operators more tools to provide better"},{"line_number":153,"context_line":"security in their deployments."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Performance Impact"},{"line_number":156,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"df140735_5231080b","line":153,"in_reply_to":"ff0f0b1f_207c07b4","updated":"2017-05-30 16:27:08.000000000","message":"Agreed - now that policy is registered in oslo.policy objects we have the ability to advertise changes across deployments much easier.","commit_id":"dc1d371e546028dee4bb00c2770d999a29d04b10"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"402e73b0371f7cf74ebb7530493f31ceb123886b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Today, role assignments are built by giving an actor a role on a target. An"},{"line_number":20,"context_line":"actor can be a user or a group. A target is limited to a project or a domain."},{"line_number":21,"context_line":"This works great for controlling access to things that map into a project or"},{"line_number":22,"context_line":"domain (i.e. instance ownership fits naturally within projects). This starts to"},{"line_number":23,"context_line":"get confusing with operations that don\u0027t fit within that constraint. Live"},{"line_number":24,"context_line":"migrating an instance from one host to another is a good example of this."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"df140735_bdd715c0","line":22,"range":{"start_line":22,"start_character":8,"end_line":22,"end_character":12},"updated":"2017-05-30 17:06:32.000000000","message":"(nit) e.g.","commit_id":"088f70ce23d9ba5db9439c49724f845e0a9a61ea"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b479a9aa9e765d767d162c80d0243625ec5d703b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Today, role assignments are built by giving an actor a role on a target. An"},{"line_number":20,"context_line":"actor can be a user or a group. A target is limited to a project or a domain."},{"line_number":21,"context_line":"This works great for controlling access to things that map into a project or"},{"line_number":22,"context_line":"domain (i.e. instance ownership fits naturally within projects). This starts to"},{"line_number":23,"context_line":"get confusing with operations that don\u0027t fit within that constraint. Live"},{"line_number":24,"context_line":"migrating an instance from one host to another is a good example of this."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"df140735_bdcc8b61","line":22,"in_reply_to":"df140735_bdd715c0","updated":"2017-05-31 20:59:12.000000000","message":"Done","commit_id":"088f70ce23d9ba5db9439c49724f845e0a9a61ea"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"402e73b0371f7cf74ebb7530493f31ceb123886b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"The attributes of a global token response can also be consumed by"},{"line_number":97,"context_line":"`oslo.context` and exposed to services for scope checks using `context.global \u003d"},{"line_number":98,"context_line":"True` or some other method. The process of relaying this information to the"},{"line_number":99,"context_line":"consuming service will contain follow on work. The primary purpose of this"},{"line_number":100,"context_line":"specification is to allow for the scoping of roles globally and exposing that"},{"line_number":101,"context_line":"ability to end users. Work can be done in parallel to consume this information"},{"line_number":102,"context_line":"in policy files or shared libraries."}],"source_content_type":"text/x-rst","patch_set":10,"id":"df140735_fda34d4e","line":99,"range":{"start_line":99,"start_character":23,"end_line":99,"end_character":45},"updated":"2017-05-30 17:06:32.000000000","message":"such as ?","commit_id":"088f70ce23d9ba5db9439c49724f845e0a9a61ea"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b479a9aa9e765d767d162c80d0243625ec5d703b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"The attributes of a global token response can also be consumed by"},{"line_number":97,"context_line":"`oslo.context` and exposed to services for scope checks using `context.global \u003d"},{"line_number":98,"context_line":"True` or some other method. The process of relaying this information to the"},{"line_number":99,"context_line":"consuming service will contain follow on work. The primary purpose of this"},{"line_number":100,"context_line":"specification is to allow for the scoping of roles globally and exposing that"},{"line_number":101,"context_line":"ability to end users. Work can be done in parallel to consume this information"},{"line_number":102,"context_line":"in policy files or shared libraries."}],"source_content_type":"text/x-rst","patch_set":10,"id":"df140735_bd3a4b31","line":99,"in_reply_to":"df140735_fda34d4e","updated":"2017-05-31 20:59:12.000000000","message":"Done","commit_id":"088f70ce23d9ba5db9439c49724f845e0a9a61ea"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"402e73b0371f7cf74ebb7530493f31ceb123886b","unresolved":false,"context_lines":[{"line_number":100,"context_line":"specification is to allow for the scoping of roles globally and exposing that"},{"line_number":101,"context_line":"ability to end users. Work can be done in parallel to consume this information"},{"line_number":102,"context_line":"in policy files or shared libraries."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Alternatives"},{"line_number":105,"context_line":"------------"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"df140735_187e0f6b","line":103,"updated":"2017-05-30 17:06:32.000000000","message":"how will global role assignments be granted? We will probably need new APIs for this, please add details to this section.\n\nLeveraging the existing APIs is an advantage of admin project. But creating new APIs is not a problem from my point of view.","commit_id":"088f70ce23d9ba5db9439c49724f845e0a9a61ea"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b479a9aa9e765d767d162c80d0243625ec5d703b","unresolved":false,"context_lines":[{"line_number":100,"context_line":"specification is to allow for the scoping of roles globally and exposing that"},{"line_number":101,"context_line":"ability to end users. Work can be done in parallel to consume this information"},{"line_number":102,"context_line":"in policy files or shared libraries."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Alternatives"},{"line_number":105,"context_line":"------------"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"df140735_e0cc986b","line":103,"in_reply_to":"df140735_187e0f6b","updated":"2017-05-31 20:59:12.000000000","message":"Done","commit_id":"088f70ce23d9ba5db9439c49724f845e0a9a61ea"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"402e73b0371f7cf74ebb7530493f31ceb123886b","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"An alternative to this approach would be to leverage the `admin_project` in"},{"line_number":108,"context_line":"order to achieve global scoping. The `admin_project` is a special project that"},{"line_number":109,"context_line":"allows for elevated privileges if role assignment are given to that project."},{"line_number":110,"context_line":"Let\u0027s consider the following example. Let\u0027s say there is an `observer` role"},{"line_number":111,"context_line":"that allows users to do non-destructive operations within a specific scope. If"},{"line_number":112,"context_line":"Bob has the `observer` role on project `foo`, he should be able to view things"}],"source_content_type":"text/x-rst","patch_set":10,"id":"df140735_9dab311c","line":109,"range":{"start_line":109,"start_character":39,"end_line":109,"end_character":49},"updated":"2017-05-30 17:06:32.000000000","message":"(nit) assignments","commit_id":"088f70ce23d9ba5db9439c49724f845e0a9a61ea"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b479a9aa9e765d767d162c80d0243625ec5d703b","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"An alternative to this approach would be to leverage the `admin_project` in"},{"line_number":108,"context_line":"order to achieve global scoping. The `admin_project` is a special project that"},{"line_number":109,"context_line":"allows for elevated privileges if role assignment are given to that project."},{"line_number":110,"context_line":"Let\u0027s consider the following example. Let\u0027s say there is an `observer` role"},{"line_number":111,"context_line":"that allows users to do non-destructive operations within a specific scope. If"},{"line_number":112,"context_line":"Bob has the `observer` role on project `foo`, he should be able to view things"}],"source_content_type":"text/x-rst","patch_set":10,"id":"df140735_60de4812","line":109,"in_reply_to":"df140735_9dab311c","updated":"2017-05-31 20:59:12.000000000","message":"Done","commit_id":"088f70ce23d9ba5db9439c49724f845e0a9a61ea"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"402e73b0371f7cf74ebb7530493f31ceb123886b","unresolved":false,"context_lines":[{"line_number":108,"context_line":"order to achieve global scoping. The `admin_project` is a special project that"},{"line_number":109,"context_line":"allows for elevated privileges if role assignment are given to that project."},{"line_number":110,"context_line":"Let\u0027s consider the following example. Let\u0027s say there is an `observer` role"},{"line_number":111,"context_line":"that allows users to do non-destructive operations within a specific scope. If"},{"line_number":112,"context_line":"Bob has the `observer` role on project `foo`, he should be able to view things"},{"line_number":113,"context_line":"within that tenancy. If Alice has the `observer` role on the `admin_project`,"},{"line_number":114,"context_line":"she should be able to view things across the deployment, like services and"}],"source_content_type":"text/x-rst","patch_set":10,"id":"df140735_7d561d2c","line":111,"range":{"start_line":111,"start_character":28,"end_line":111,"end_character":39},"updated":"2017-05-30 17:06:32.000000000","message":"Would \"writable\" be more appropriate? They could create things, in which case would be constructive?","commit_id":"088f70ce23d9ba5db9439c49724f845e0a9a61ea"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b479a9aa9e765d767d162c80d0243625ec5d703b","unresolved":false,"context_lines":[{"line_number":108,"context_line":"order to achieve global scoping. The `admin_project` is a special project that"},{"line_number":109,"context_line":"allows for elevated privileges if role assignment are given to that project."},{"line_number":110,"context_line":"Let\u0027s consider the following example. Let\u0027s say there is an `observer` role"},{"line_number":111,"context_line":"that allows users to do non-destructive operations within a specific scope. If"},{"line_number":112,"context_line":"Bob has the `observer` role on project `foo`, he should be able to view things"},{"line_number":113,"context_line":"within that tenancy. If Alice has the `observer` role on the `admin_project`,"},{"line_number":114,"context_line":"she should be able to view things across the deployment, like services and"}],"source_content_type":"text/x-rst","patch_set":10,"id":"df140735_00eb0cb0","line":111,"in_reply_to":"df140735_7d561d2c","updated":"2017-05-31 20:59:12.000000000","message":"I tried to simplify this a bit - let me know if it helps.","commit_id":"088f70ce23d9ba5db9439c49724f845e0a9a61ea"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"402e73b0371f7cf74ebb7530493f31ceb123886b","unresolved":false,"context_lines":[{"line_number":110,"context_line":"Let\u0027s consider the following example. Let\u0027s say there is an `observer` role"},{"line_number":111,"context_line":"that allows users to do non-destructive operations within a specific scope. If"},{"line_number":112,"context_line":"Bob has the `observer` role on project `foo`, he should be able to view things"},{"line_number":113,"context_line":"within that tenancy. If Alice has the `observer` role on the `admin_project`,"},{"line_number":114,"context_line":"she should be able to view things across the deployment, like services and"},{"line_number":115,"context_line":"endpoints."},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"df140735_7d2bbd93","line":113,"range":{"start_line":113,"start_character":12,"end_line":113,"end_character":19},"updated":"2017-05-30 17:06:32.000000000","message":"projects? Just to be consistent and to ease understanding for people from other projects still using the name tenant in the code.","commit_id":"088f70ce23d9ba5db9439c49724f845e0a9a61ea"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b479a9aa9e765d767d162c80d0243625ec5d703b","unresolved":false,"context_lines":[{"line_number":110,"context_line":"Let\u0027s consider the following example. Let\u0027s say there is an `observer` role"},{"line_number":111,"context_line":"that allows users to do non-destructive operations within a specific scope. If"},{"line_number":112,"context_line":"Bob has the `observer` role on project `foo`, he should be able to view things"},{"line_number":113,"context_line":"within that tenancy. If Alice has the `observer` role on the `admin_project`,"},{"line_number":114,"context_line":"she should be able to view things across the deployment, like services and"},{"line_number":115,"context_line":"endpoints."},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"df140735_80d6fcf0","line":113,"in_reply_to":"df140735_7d2bbd93","updated":"2017-05-31 20:59:12.000000000","message":"Done","commit_id":"088f70ce23d9ba5db9439c49724f845e0a9a61ea"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"402e73b0371f7cf74ebb7530493f31ceb123886b","unresolved":false,"context_lines":[{"line_number":141,"context_line":"* Certain resources can\u0027t belong in global scope today (i.e. instances must be"},{"line_number":142,"context_line":"  tied to a project), this approach doesn\u0027t stop users from creating resources"},{"line_number":143,"context_line":"  within the `admin_project`, which would be the equivalent to global resources"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Security Impact"},{"line_number":147,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"df140735_f85b5b2b","line":144,"updated":"2017-05-30 17:06:32.000000000","message":"What happens if you have a tree where the admin project is the root and you get an inherited role assignment in the admin project?\n\nI agree this approach is much clearer","commit_id":"088f70ce23d9ba5db9439c49724f845e0a9a61ea"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b479a9aa9e765d767d162c80d0243625ec5d703b","unresolved":false,"context_lines":[{"line_number":141,"context_line":"* Certain resources can\u0027t belong in global scope today (i.e. instances must be"},{"line_number":142,"context_line":"  tied to a project), this approach doesn\u0027t stop users from creating resources"},{"line_number":143,"context_line":"  within the `admin_project`, which would be the equivalent to global resources"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Security Impact"},{"line_number":147,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"df140735_a04900d1","line":144,"in_reply_to":"df140735_f85b5b2b","updated":"2017-05-31 20:59:12.000000000","message":"Done","commit_id":"088f70ce23d9ba5db9439c49724f845e0a9a61ea"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"3b35f4f93ba37e74aeed4c6dbae47bedcbdd29e1","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Global Role Assignments"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp global-roles \u003chttps://blueprints.launchpad.net/keystone/+spec/global-roles\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This document describes the necessary changes in order to implement global role"},{"line_number":14,"context_line":"assignments."}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_94faab72","line":11,"updated":"2017-06-01 14:27:22.000000000","message":"Bad link?","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f28a4f046e89e692875e37d21dea51fe1d5627b6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Global Role Assignments"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"`bp global-roles \u003chttps://blueprints.launchpad.net/keystone/+spec/global-roles\u003e`_"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This document describes the necessary changes in order to implement global role"},{"line_number":14,"context_line":"assignments."}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_2957fd28","line":11,"in_reply_to":"df140735_94faab72","updated":"2017-06-01 18:22:51.000000000","message":"Nope - this link will be officially created if/when the specification has merged. This is a process thing that attempts to link the blueprint that tracks the work to the specification that describes it.","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"08560a0b6217295fbdb7caeb8d1dffe001032c71","unresolved":false,"context_lines":[{"line_number":32,"context_line":"List global role assignments for a user"},{"line_number":33,"context_line":"---------------------------------------"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"**Request:** `GET /v3/global/users/{user_id}/roles/`"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"**Parameters**"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_e36367b0","line":35,"range":{"start_line":35,"start_character":22,"end_line":35,"end_character":28},"updated":"2017-06-01 16:25:25.000000000","message":"I don\u0027t understand the need for \"/global\" as role definitions today are already \"global\" in nature. i.e. role name must be globally unique. The existing role assignment should be able to remain unchanged.","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f28a4f046e89e692875e37d21dea51fe1d5627b6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"List global role assignments for a user"},{"line_number":33,"context_line":"---------------------------------------"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"**Request:** `GET /v3/global/users/{user_id}/roles/`"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"**Parameters**"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_e91b457e","line":35,"in_reply_to":"df140735_e36367b0","updated":"2017-06-01 18:22:51.000000000","message":"That\u0027s true for the v2.0 API. For the v3 of our API, we typically do role assignments with:\n\n  v3/projects/{project_id}/users/{user_id}/roles/{role_id}\n\nI did this because I didn\u0027t think it made sense to continue using a project in the path when we\u0027re clearly not assigning a user a role to a specific project, we\u0027re assigning it to global scope.\n\nWe could do something like:\n\n  GET /v3/users/{user_id}/roles/  # which is pretty the v3 equivalent of the v2.0 role API\n  PUT /v3/users/{user_id}/roles/{role_id}","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"257848ba83eb3699291124d6555a910f79e4ef40","unresolved":false,"context_lines":[{"line_number":68,"context_line":"Assign a global role to a user"},{"line_number":69,"context_line":"------------------------------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"**Request:** `PUT /v3/global/users/{user_id}/roles/{role_id}`"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"**Parameters**"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_45ec60f2","line":71,"updated":"2017-06-01 13:26:23.000000000","message":"I think we should put /global at the end, so that it is consistent as we do for inherited assignments\n\n    /v3/OS-INHERIT/users/{user_id}/roles/{role_id}/inherited_to_projects\n    /v3/users/{user_id}/roles/{role_id}/global\n\nWhat do you think? Would it be better?","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"08560a0b6217295fbdb7caeb8d1dffe001032c71","unresolved":false,"context_lines":[{"line_number":68,"context_line":"Assign a global role to a user"},{"line_number":69,"context_line":"------------------------------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"**Request:** `PUT /v3/global/users/{user_id}/roles/{role_id}`"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"**Parameters**"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_e3d6c727","line":71,"range":{"start_line":71,"start_character":21,"end_line":71,"end_character":27},"updated":"2017-06-01 16:25:25.000000000","message":"same as above","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f28a4f046e89e692875e37d21dea51fe1d5627b6","unresolved":false,"context_lines":[{"line_number":68,"context_line":"Assign a global role to a user"},{"line_number":69,"context_line":"------------------------------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"**Request:** `PUT /v3/global/users/{user_id}/roles/{role_id}`"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"**Parameters**"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_ec85935b","line":71,"in_reply_to":"df140735_e3d6c727","updated":"2017-06-01 18:22:51.000000000","message":"Done","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"08560a0b6217295fbdb7caeb8d1dffe001032c71","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Check if a user has a global role assignment"},{"line_number":85,"context_line":"--------------------------------------------"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"**Request:** `HEAD /v3/global/users/{user_id}/roles/{role_id}`"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"**Parameters**"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_83e70b13","line":87,"range":{"start_line":87,"start_character":22,"end_line":87,"end_character":29},"updated":"2017-06-01 16:25:25.000000000","message":"same as above","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f28a4f046e89e692875e37d21dea51fe1d5627b6","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Check if a user has a global role assignment"},{"line_number":85,"context_line":"--------------------------------------------"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"**Request:** `HEAD /v3/global/users/{user_id}/roles/{role_id}`"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"**Parameters**"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_cc8acf68","line":87,"in_reply_to":"df140735_83e70b13","updated":"2017-06-01 18:22:51.000000000","message":"Done","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"08560a0b6217295fbdb7caeb8d1dffe001032c71","unresolved":false,"context_lines":[{"line_number":100,"context_line":"Unassign a global role from a user"},{"line_number":101,"context_line":"----------------------------------"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"**Request:** `DELETE /v3/global/users/{user_id}/roles/{role_id}`"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"**Parameters**"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_23ecbff1","line":103,"range":{"start_line":103,"start_character":24,"end_line":103,"end_character":31},"updated":"2017-06-01 16:25:25.000000000","message":"same as above","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f28a4f046e89e692875e37d21dea51fe1d5627b6","unresolved":false,"context_lines":[{"line_number":100,"context_line":"Unassign a global role from a user"},{"line_number":101,"context_line":"----------------------------------"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"**Request:** `DELETE /v3/global/users/{user_id}/roles/{role_id}`"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"**Parameters**"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_ac7b1b79","line":103,"in_reply_to":"df140735_23ecbff1","updated":"2017-06-01 18:22:51.000000000","message":"Done","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"08560a0b6217295fbdb7caeb8d1dffe001032c71","unresolved":false,"context_lines":[{"line_number":116,"context_line":"List global role assignments for a group"},{"line_number":117,"context_line":"----------------------------------------"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"**Request:** `GET /v3/global/groups/{group_id}/roles/`"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"**Parameters**"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_c3b623fb","line":119,"range":{"start_line":119,"start_character":21,"end_line":119,"end_character":28},"updated":"2017-06-01 16:25:25.000000000","message":"same as above.","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f28a4f046e89e692875e37d21dea51fe1d5627b6","unresolved":false,"context_lines":[{"line_number":116,"context_line":"List global role assignments for a group"},{"line_number":117,"context_line":"----------------------------------------"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"**Request:** `GET /v3/global/groups/{group_id}/roles/`"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"**Parameters**"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_8c805748","line":119,"in_reply_to":"df140735_c3b623fb","updated":"2017-06-01 18:22:51.000000000","message":"Done","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"08560a0b6217295fbdb7caeb8d1dffe001032c71","unresolved":false,"context_lines":[{"line_number":152,"context_line":"Assign a global role to a group"},{"line_number":153,"context_line":"-------------------------------"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"**Request:** `PUT /v3/global/groups/{group_id}/roles/{role_id}`"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"**Parameters**"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_a3ae8f95","line":155,"range":{"start_line":155,"start_character":21,"end_line":155,"end_character":28},"updated":"2017-06-01 16:25:25.000000000","message":"same as above","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f28a4f046e89e692875e37d21dea51fe1d5627b6","unresolved":false,"context_lines":[{"line_number":152,"context_line":"Assign a global role to a group"},{"line_number":153,"context_line":"-------------------------------"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"**Request:** `PUT /v3/global/groups/{group_id}/roles/{role_id}`"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"**Parameters**"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_6c9983c2","line":155,"in_reply_to":"df140735_a3ae8f95","updated":"2017-06-01 18:22:51.000000000","message":"Done","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"08560a0b6217295fbdb7caeb8d1dffe001032c71","unresolved":false,"context_lines":[{"line_number":168,"context_line":"Check if a group has a global role assignment"},{"line_number":169,"context_line":"---------------------------------------------"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"**Request:** `HEAD /v3/global/group/{group_id}/roles/{role_id}`"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"**Parameters**"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_6390774f","line":171,"range":{"start_line":171,"start_character":22,"end_line":171,"end_character":29},"updated":"2017-06-01 16:25:25.000000000","message":"same as above","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f28a4f046e89e692875e37d21dea51fe1d5627b6","unresolved":false,"context_lines":[{"line_number":168,"context_line":"Check if a group has a global role assignment"},{"line_number":169,"context_line":"---------------------------------------------"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"**Request:** `HEAD /v3/global/group/{group_id}/roles/{role_id}`"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"**Parameters**"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_4c96bf95","line":171,"in_reply_to":"df140735_6390774f","updated":"2017-06-01 18:22:51.000000000","message":"Done","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"08560a0b6217295fbdb7caeb8d1dffe001032c71","unresolved":false,"context_lines":[{"line_number":184,"context_line":"Unassign a global role from a group"},{"line_number":185,"context_line":"-----------------------------------"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"**Request:** `DELETE /v3/global/groups/{group_id}/roles/{role_id}`"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"**Parameters**"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_239a7f6d","line":187,"range":{"start_line":187,"start_character":24,"end_line":187,"end_character":31},"updated":"2017-06-01 16:25:25.000000000","message":"same as above","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f28a4f046e89e692875e37d21dea51fe1d5627b6","unresolved":false,"context_lines":[{"line_number":184,"context_line":"Unassign a global role from a group"},{"line_number":185,"context_line":"-----------------------------------"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"**Request:** `DELETE /v3/global/groups/{group_id}/roles/{role_id}`"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"**Parameters**"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_2c8f0b76","line":187,"in_reply_to":"df140735_239a7f6d","updated":"2017-06-01 18:22:51.000000000","message":"Done","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"257848ba83eb3699291124d6555a910f79e4ef40","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                \"role\": {"},{"line_number":260,"context_line":"                    \"id\": \"ab29d6fff51c43478b00bb16bfb771fc\""},{"line_number":261,"context_line":"                },"},{"line_number":262,"context_line":"                \"scope\": \"global\""},{"line_number":263,"context_line":"            }"},{"line_number":264,"context_line":"        ],"},{"line_number":265,"context_line":"        \"links\": {"}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_05d66850","line":262,"updated":"2017-06-01 13:26:23.000000000","message":"I wonder if we should do \"scope\": {\"global\": True} as we do that for inherited_to_projects with \"scope\":{\"OS-INHERIT:inherited_to\": \"projects\"} (however in that case scope also contains project/domain info)\n\nthe advantage is that scope would continue to be a dict in all cases.\n\nWhat do you think about it?","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"3b35f4f93ba37e74aeed4c6dbae47bedcbdd29e1","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                \"role\": {"},{"line_number":260,"context_line":"                    \"id\": \"ab29d6fff51c43478b00bb16bfb771fc\""},{"line_number":261,"context_line":"                },"},{"line_number":262,"context_line":"                \"scope\": \"global\""},{"line_number":263,"context_line":"            }"},{"line_number":264,"context_line":"        ],"},{"line_number":265,"context_line":"        \"links\": {"}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_544bf357","line":262,"in_reply_to":"df140735_05d66850","updated":"2017-06-01 14:27:22.000000000","message":"Consistency is good (clear). Do we have any assumptions (in code) that scope is a dict which require more changes were we to break this consistency?","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f28a4f046e89e692875e37d21dea51fe1d5627b6","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                \"role\": {"},{"line_number":260,"context_line":"                    \"id\": \"ab29d6fff51c43478b00bb16bfb771fc\""},{"line_number":261,"context_line":"                },"},{"line_number":262,"context_line":"                \"scope\": \"global\""},{"line_number":263,"context_line":"            }"},{"line_number":264,"context_line":"        ],"},{"line_number":265,"context_line":"        \"links\": {"}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_0c8c477d","line":262,"in_reply_to":"df140735_544bf357","updated":"2017-06-01 18:22:51.000000000","message":"Good point - I agree. Done.","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"08560a0b6217295fbdb7caeb8d1dffe001032c71","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                    }"},{"line_number":289,"context_line":"                }"},{"line_number":290,"context_line":"            },"},{"line_number":291,"context_line":"            \"scope\": \"global\""},{"line_number":292,"context_line":"        }"},{"line_number":293,"context_line":"    }"},{"line_number":294,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_833f0b24","line":291,"range":{"start_line":291,"start_character":12,"end_line":291,"end_character":29},"updated":"2017-06-01 16:25:25.000000000","message":"I think this is problematic for UX, that we required yet another scope to just get the global roles. Can you imagine horizon, or any client implementation, will now have to joggle with 3 different tokens? Like which token should I be using to do what?!\n\nThe whole point of \"global\" roles is that you\u0027ll get them regardless of scope as the are global in nature. If we are continue on this path, we might as well go with token with subset of roles proposal which is also a major UX killer IMO.","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f28a4f046e89e692875e37d21dea51fe1d5627b6","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                    }"},{"line_number":289,"context_line":"                }"},{"line_number":290,"context_line":"            },"},{"line_number":291,"context_line":"            \"scope\": \"global\""},{"line_number":292,"context_line":"        }"},{"line_number":293,"context_line":"    }"},{"line_number":294,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_2c526bdf","line":291,"in_reply_to":"df140735_833f0b24","updated":"2017-06-01 18:22:51.000000000","message":"Agreed - I\u0027ve thought about this too. The main reason we seemed to come up with here is that the request would be very similar to how you ask for an unscoped token today. Unscoped tokens don\u0027t have a scope and they are really only useful for switching between project scopes. Tacking global roles assignment into an unscoped token, which is designed to not be able to do anything seems like a security violation with how we use them today.\n\nI understand that adding another scope isn\u0027t ideal, but it seemed like the best path forward that didn\u0027t lead to security issues.\n\nOne example that helped me wrap my head around this was thinking of unscoped tokens as the empty set of things you can do and global tokens as the full set of things you can do to global operations with in the deployment.","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"3b35f4f93ba37e74aeed4c6dbae47bedcbdd29e1","unresolved":false,"context_lines":[{"line_number":370,"context_line":"* Most of this work is already done"},{"line_number":371,"context_line":"* Not necessary to change how scope is stored"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"Drawbacks:"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"* Automated tooling might have to handle this project separately (i.e. coding"},{"line_number":376,"context_line":"  around an implementation detail of how policy is elevated) to ensure nothing"}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_34e2bf30","line":373,"updated":"2017-06-01 14:27:22.000000000","message":"Very good points. This gives some great context into the push back against the `admin_project` solution.","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f28a4f046e89e692875e37d21dea51fe1d5627b6","unresolved":false,"context_lines":[{"line_number":370,"context_line":"* Most of this work is already done"},{"line_number":371,"context_line":"* Not necessary to change how scope is stored"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"Drawbacks:"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"* Automated tooling might have to handle this project separately (i.e. coding"},{"line_number":376,"context_line":"  around an implementation detail of how policy is elevated) to ensure nothing"}],"source_content_type":"text/x-rst","patch_set":12,"id":"df140735_cc664fc2","line":373,"in_reply_to":"df140735_34e2bf30","updated":"2017-06-01 18:22:51.000000000","message":"Thanks!","commit_id":"2de9d8aeb10313435b394966f5e28835b057da3b"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"aaaba5538f5ea2ccbb2fbc1effa6dd8d34c5c6fb","unresolved":false,"context_lines":[{"line_number":204,"context_line":"global role assignment, in addition to the project and domain role assignment"},{"line_number":205,"context_line":"information it returns today."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"**Request:** `GET /v3/role_assignments`"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"**Response**"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"df140735_a3a1e648","line":207,"range":{"start_line":207,"start_character":14,"end_line":207,"end_character":38},"updated":"2017-06-01 22:15:08.000000000","message":"I think we may need to add a new filter for global role assignments.\n\nGET /v3/role_assignments?scope.global","commit_id":"e41461ef224c4766955d19bfa783b1b98274a504"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"aaaba5538f5ea2ccbb2fbc1effa6dd8d34c5c6fb","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                    }"},{"line_number":291,"context_line":"                }"},{"line_number":292,"context_line":"            },"},{"line_number":293,"context_line":"            \"scope\": \"global\""},{"line_number":294,"context_line":"        }"},{"line_number":295,"context_line":"    }"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"df140735_be321d5d","line":293,"range":{"start_line":293,"start_character":12,"end_line":293,"end_character":29},"updated":"2017-06-01 22:15:08.000000000","message":"I am still very concerned about the UX aspect. Can we please get someone from openstack-security to weight in?","commit_id":"e41461ef224c4766955d19bfa783b1b98274a504"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"8053f57c5bc592f7cc153661bbd14e3fefe1bda1","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                    }"},{"line_number":291,"context_line":"                }"},{"line_number":292,"context_line":"            },"},{"line_number":293,"context_line":"            \"scope\": \"global\""},{"line_number":294,"context_line":"        }"},{"line_number":295,"context_line":"    }"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"df140735_d54d42c4","line":293,"range":{"start_line":293,"start_character":20,"end_line":293,"end_character":29},"updated":"2017-06-06 13:02:35.000000000","message":"let\u0027s do the same here for consistency and use a dict? \"scope\": {\"global\": true}\n\nI agree with gyee we should get cross-project weight in this before approving, as I\u0027ve also suggested for the parent specs","commit_id":"e41461ef224c4766955d19bfa783b1b98274a504"}],"specs/keystone/queens/global-roles.rst":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"4acba4a5206b9ec9bc9e12f13b12250d81505b5e","unresolved":false,"context_lines":[{"line_number":371,"context_line":"to these concepts. At this time, global scope applies to implied roles, where"},{"line_number":372,"context_line":"an implied role assignment can exist globally. But since keystone doesn\u0027t have"},{"line_number":373,"context_line":"a concept of nesting global context, now or in the future, it doesn\u0027t make"},{"line_number":374,"context_line":"sense to allow inherited global role assignments. These should be prevented and"},{"line_number":375,"context_line":"can lead to security issues. Instead of bridging an inheritance between global"},{"line_number":376,"context_line":"scope and projects, make assignments to projects explicit like they are today."},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7f287b81_ec2dc7a8","line":375,"range":{"start_line":374,"start_character":50,"end_line":375,"end_character":28},"updated":"2017-09-04 15:02:19.000000000","message":"++ Maybe even state that an error will be generated if you try something like:\n\n`PUT /v3/users/{user_id}/roles/{role_id}/inherited`","commit_id":"dcadd807a921d08d5c26cd5e16d1f353c1e1c7db"}],"specs/keystone/queens/system-scope.rst":[{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"7ff1ce30420e391943f606de8e5bebcf5cfc5f0d","unresolved":false,"context_lines":[{"line_number":347,"context_line":"            \"methods\": ["},{"line_number":348,"context_line":"                \"password\""},{"line_number":349,"context_line":"            ],"},{"line_number":350,"context_line":"            \"system\": true,"},{"line_number":351,"context_line":"            \"roles\": ["},{"line_number":352,"context_line":"                {"},{"line_number":353,"context_line":"                    \"id\": \"c2145c84a802413fbac71479250c9378\","}],"source_content_type":"text/x-rst","patch_set":17,"id":"7f515b1d_7bdb0321","line":350,"updated":"2017-10-03 18:25:02.000000000","message":"This seems too limited:\n\nWhat if:  \nsystem: all\nsystem: {service: compute}\nsystem: {endpoint: 5432abcd}\n\nWe can do `all` to get started, but allow for the service and endpoint scoping in the future.","commit_id":"31bc07211967d05bf94416a142fe88fb7423aa73"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"910b709af45c1eb76bfcd92e9f6c3655872ec355","unresolved":false,"context_lines":[{"line_number":388,"context_line":"System Roles, Implied Roles, \u0026 Inherited Roles"},{"line_number":389,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"Keystone supports other types of role behaviors. An administrator can have one"},{"line_number":392,"context_line":"role imply another, or have roles be inherited according to the hierarchical"},{"line_number":393,"context_line":"structure of projects. For example, if role ``Alpha`` implies role ``Beta``, a"},{"line_number":394,"context_line":"user with role ``Alpha`` will automatically be given role ``Beta`` on the"},{"line_number":395,"context_line":"target, since it\u0027s implied.  Another example is if a role assignment is allowed"},{"line_number":396,"context_line":"to be inherited through a tree of projects. For example, if ``project C`` is"},{"line_number":397,"context_line":"the parent of ``project D`` and a user has role ``Echo`` on  ``project C``, the"},{"line_number":398,"context_line":"user also has role ``Echo`` on ``project D`` via role inheritance.  These"},{"line_number":399,"context_line":"concepts are known respectively, as implied roles and inherited roles."},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"Part of introducing a system scoping mechanism is understanding how it applies"},{"line_number":402,"context_line":"to these concepts. It is possible to apply both of these concepts to system"}],"source_content_type":"text/x-rst","patch_set":17,"id":"7f515b1d_44a8d18b","line":399,"range":{"start_line":391,"start_character":0,"end_line":399,"end_character":70},"updated":"2017-09-27 18:02:57.000000000","message":"This is accurate but super dense. Perhaps diagram (ASCII Flow instead instead of just text)","commit_id":"31bc07211967d05bf94416a142fe88fb7423aa73"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"5a2a0d89a1cd2d3445e9091f2e895c0fa26ad8ab","unresolved":false,"context_lines":[{"line_number":202,"context_line":"Check if a group has a system role assignment"},{"line_number":203,"context_line":"---------------------------------------------"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"**Request:** `HEAD /v3/system/group/{group_id}/roles/{role_id}`"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"**Request:** `GET /v3/system/group/{group_id}/roles/{role_id}`"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"3f4b6375_c5ec46f5","line":205,"range":{"start_line":205,"start_character":30,"end_line":205,"end_character":35},"updated":"2017-10-18 18:50:37.000000000","message":"s/group/groups/","commit_id":"d26ae663b0ea6e0cfbcaf9bb4e87b76b1d73f972"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ef8601b6a7c3ca5a6ffac0588d30d3db801a2bcd","unresolved":false,"context_lines":[{"line_number":202,"context_line":"Check if a group has a system role assignment"},{"line_number":203,"context_line":"---------------------------------------------"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"**Request:** `HEAD /v3/system/group/{group_id}/roles/{role_id}`"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"**Request:** `GET /v3/system/group/{group_id}/roles/{role_id}`"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"3f4b6375_9db582f1","line":205,"range":{"start_line":205,"start_character":30,"end_line":205,"end_character":35},"in_reply_to":"3f4b6375_c5ec46f5","updated":"2017-10-18 20:37:07.000000000","message":"Done","commit_id":"d26ae663b0ea6e0cfbcaf9bb4e87b76b1d73f972"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"5adcf65948e20a9a6c80bf5a051c1ad1f67afe22","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        ]"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"List system role assignments for a group"},{"line_number":101,"context_line":"----------------------------------------"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"**Request:** `GET /v3/system/groups/{group_id}/roles/`"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"**Parameters**"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* `group_id` - The group ID."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"**Response**"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"* 200 - OK"},{"line_number":112,"context_line":"* 404 - Not Found if a role or group doesn\u0027t exist"},{"line_number":113,"context_line":"* 401 - If the operation isn\u0027t permitted to the user"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"**Response Body**"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":".. code:: json"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    {"},{"line_number":120,"context_line":"        \"links\": {"},{"line_number":121,"context_line":"            \"self\": \"http://example.com/identity/v3/system/groups/c1339b5597ab4b20b5452a9d7a8b367e/roles\","},{"line_number":122,"context_line":"            \"previous\": null,"},{"line_number":123,"context_line":"            \"next\": null"},{"line_number":124,"context_line":"        },"},{"line_number":125,"context_line":"        \"roles\": ["},{"line_number":126,"context_line":"            {"},{"line_number":127,"context_line":"                \"id\": \"46b213b41e7344cc8078ac5e7d161f17\","},{"line_number":128,"context_line":"                \"links\": {"},{"line_number":129,"context_line":"                    \"self\": \"http://example.com/identity/v3/roles/46b213b41e7344cc8078ac5e7d161f17\""},{"line_number":130,"context_line":"                },"},{"line_number":131,"context_line":"                \"name\": \"admin\""},{"line_number":132,"context_line":"            }"},{"line_number":133,"context_line":"        ]"},{"line_number":134,"context_line":"    }"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Assign a system role to a user"},{"line_number":137,"context_line":"------------------------------"}],"source_content_type":"text/x-rst","patch_set":21,"id":"3f4b6375_a1ead00b","line":134,"range":{"start_line":100,"start_character":0,"end_line":134,"end_character":5},"updated":"2017-10-24 19:19:57.000000000","message":"This repeats below.","commit_id":"1d60b116e47732fcd7bd25e72eeba0f5a4acea7e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"04bb0ab1a4891ccafb647f9d5c961d87be9c47ba","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        ]"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"List system role assignments for a group"},{"line_number":101,"context_line":"----------------------------------------"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"**Request:** `GET /v3/system/groups/{group_id}/roles/`"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"**Parameters**"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* `group_id` - The group ID."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"**Response**"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"* 200 - OK"},{"line_number":112,"context_line":"* 404 - Not Found if a role or group doesn\u0027t exist"},{"line_number":113,"context_line":"* 401 - If the operation isn\u0027t permitted to the user"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"**Response Body**"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":".. code:: json"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    {"},{"line_number":120,"context_line":"        \"links\": {"},{"line_number":121,"context_line":"            \"self\": \"http://example.com/identity/v3/system/groups/c1339b5597ab4b20b5452a9d7a8b367e/roles\","},{"line_number":122,"context_line":"            \"previous\": null,"},{"line_number":123,"context_line":"            \"next\": null"},{"line_number":124,"context_line":"        },"},{"line_number":125,"context_line":"        \"roles\": ["},{"line_number":126,"context_line":"            {"},{"line_number":127,"context_line":"                \"id\": \"46b213b41e7344cc8078ac5e7d161f17\","},{"line_number":128,"context_line":"                \"links\": {"},{"line_number":129,"context_line":"                    \"self\": \"http://example.com/identity/v3/roles/46b213b41e7344cc8078ac5e7d161f17\""},{"line_number":130,"context_line":"                },"},{"line_number":131,"context_line":"                \"name\": \"admin\""},{"line_number":132,"context_line":"            }"},{"line_number":133,"context_line":"        ]"},{"line_number":134,"context_line":"    }"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Assign a system role to a user"},{"line_number":137,"context_line":"------------------------------"}],"source_content_type":"text/x-rst","patch_set":21,"id":"3f4b6375_0c02fb3d","line":134,"range":{"start_line":100,"start_character":0,"end_line":134,"end_character":5},"in_reply_to":"3f4b6375_a1ead00b","updated":"2017-10-24 20:28:48.000000000","message":"Done","commit_id":"1d60b116e47732fcd7bd25e72eeba0f5a4acea7e"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"a7dd9ac632747030f2d1bc1a83e64b2df59290b3","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"**Response**"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"* 200 - No Content"},{"line_number":131,"context_line":"* 404 - Not Found if a role or user doesn\u0027t exist"},{"line_number":132,"context_line":"* 401 - If the operation isn\u0027t permitted to the user"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f485f77_dffdec3a","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":18},"updated":"2017-11-14 11:22:19.000000000","message":"I think it should be 200 - OK for GET","commit_id":"72f59754a6857d0cffb82ad58f5f9d4e44260a0f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7d1b1259556268cb09f0a1eb2fdf8ba8f378048c","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"**Response**"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"* 200 - No Content"},{"line_number":131,"context_line":"* 404 - Not Found if a role or user doesn\u0027t exist"},{"line_number":132,"context_line":"* 401 - If the operation isn\u0027t permitted to the user"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"ff82abbf_97dc6547","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":18},"in_reply_to":"1f485f77_dffdec3a","updated":"2017-11-20 21:02:03.000000000","message":"Oh - good catch... This should be 204 - No Content to be consistent with the rest of the assignment API.","commit_id":"72f59754a6857d0cffb82ad58f5f9d4e44260a0f"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"a7dd9ac632747030f2d1bc1a83e64b2df59290b3","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"**Response**"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"* 200 - No Content"},{"line_number":217,"context_line":"* 404 - Not Found if a role or group doesn\u0027t exist"},{"line_number":218,"context_line":"* 401 - If the operation isn\u0027t permitted to the user"},{"line_number":219,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"1f485f77_7f98381a","line":216,"updated":"2017-11-14 11:22:19.000000000","message":"ditto","commit_id":"72f59754a6857d0cffb82ad58f5f9d4e44260a0f"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"99973e83b5e69efde3cdd6291907ddb7215d45f4","unresolved":false,"context_lines":[{"line_number":55,"context_line":"a single project. Multiple projects can have instances hosted on a single"},{"line_number":56,"context_line":"hypervisor due to multi-tenancy."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"After realizing this, it became apparent that *system* is a more appropriate"},{"line_number":59,"context_line":"term than *global* for isolating infrastructure and project operations."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Proposed Change"},{"line_number":62,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff82abbf_290c8aea","line":59,"range":{"start_line":58,"start_character":0,"end_line":59,"end_character":71},"updated":"2017-11-27 19:28:36.000000000","message":"nit - sort of repeats what\u0027s in line 46-48. Could clean this up in a followup.","commit_id":"758e08e291dc47eb1b7096c8e06fbce0d4349f04"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7c01ff0d1e01c24ea7052c4951b9d393af4f380c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"a single project. Multiple projects can have instances hosted on a single"},{"line_number":56,"context_line":"hypervisor due to multi-tenancy."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"After realizing this, it became apparent that *system* is a more appropriate"},{"line_number":59,"context_line":"term than *global* for isolating infrastructure and project operations."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Proposed Change"},{"line_number":62,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff82abbf_053aa9e5","line":59,"range":{"start_line":58,"start_character":0,"end_line":59,"end_character":71},"in_reply_to":"ff82abbf_290c8aea","updated":"2017-11-28 17:49:00.000000000","message":"Good call, fixed.","commit_id":"758e08e291dc47eb1b7096c8e06fbce0d4349f04"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"a4beb5b8ca1851a21fc8b74970cdcda52877eed0","unresolved":false,"context_lines":[{"line_number":73,"context_line":"**Response**"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"* 200 - OK"},{"line_number":76,"context_line":"* 404 - Not Found if a role or user doesn\u0027t exist"},{"line_number":77,"context_line":"* 401 - If the operation isn\u0027t permitted to the user"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"**Response Body**"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff82abbf_2792554d","line":76,"range":{"start_line":76,"start_character":23,"end_line":76,"end_character":30},"updated":"2017-11-28 16:21:37.000000000","message":"Remove \"role or\". The role not existing is not relevant and we should have a empty list if there are no roles.\n\n404 is only if the user doesn\u0027t exist.","commit_id":"758e08e291dc47eb1b7096c8e06fbce0d4349f04"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7c01ff0d1e01c24ea7052c4951b9d393af4f380c","unresolved":false,"context_lines":[{"line_number":73,"context_line":"**Response**"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"* 200 - OK"},{"line_number":76,"context_line":"* 404 - Not Found if a role or user doesn\u0027t exist"},{"line_number":77,"context_line":"* 401 - If the operation isn\u0027t permitted to the user"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"**Response Body**"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff82abbf_253d6ddc","line":76,"range":{"start_line":76,"start_character":23,"end_line":76,"end_character":30},"in_reply_to":"ff82abbf_2792554d","updated":"2017-11-28 17:49:00.000000000","message":"Done","commit_id":"758e08e291dc47eb1b7096c8e06fbce0d4349f04"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"a4beb5b8ca1851a21fc8b74970cdcda52877eed0","unresolved":false,"context_lines":[{"line_number":159,"context_line":"**Response**"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"* 200 - OK"},{"line_number":162,"context_line":"* 404 - Not Found if a role or user doesn\u0027t exist"},{"line_number":163,"context_line":"* 401 - If the operation isn\u0027t permitted to the user"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"**Response Body**"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff82abbf_27bb35c5","line":162,"range":{"start_line":162,"start_character":23,"end_line":162,"end_character":49},"updated":"2017-11-28 16:21:37.000000000","message":"Group doesn\u0027t exist.\n\nSame as above comment, fix \"user\" to group.","commit_id":"758e08e291dc47eb1b7096c8e06fbce0d4349f04"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7c01ff0d1e01c24ea7052c4951b9d393af4f380c","unresolved":false,"context_lines":[{"line_number":159,"context_line":"**Response**"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"* 200 - OK"},{"line_number":162,"context_line":"* 404 - Not Found if a role or user doesn\u0027t exist"},{"line_number":163,"context_line":"* 401 - If the operation isn\u0027t permitted to the user"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"**Response Body**"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff82abbf_e52225b9","line":162,"range":{"start_line":162,"start_character":23,"end_line":162,"end_character":49},"in_reply_to":"ff82abbf_27bb35c5","updated":"2017-11-28 17:49:00.000000000","message":"Done","commit_id":"758e08e291dc47eb1b7096c8e06fbce0d4349f04"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"a4beb5b8ca1851a21fc8b74970cdcda52877eed0","unresolved":false,"context_lines":[{"line_number":230,"context_line":"**Response**"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"* 204 - No Content"},{"line_number":233,"context_line":"* 404 - Not Found if a role or user doesn\u0027t exist"},{"line_number":234,"context_line":"* 401 - If the operation isn\u0027t permitted to the user"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"List role assignments"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff82abbf_47be79b4","line":233,"range":{"start_line":233,"start_character":31,"end_line":233,"end_character":36},"updated":"2017-11-28 16:21:37.000000000","message":"Group","commit_id":"758e08e291dc47eb1b7096c8e06fbce0d4349f04"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7c01ff0d1e01c24ea7052c4951b9d393af4f380c","unresolved":false,"context_lines":[{"line_number":230,"context_line":"**Response**"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"* 204 - No Content"},{"line_number":233,"context_line":"* 404 - Not Found if a role or user doesn\u0027t exist"},{"line_number":234,"context_line":"* 401 - If the operation isn\u0027t permitted to the user"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"List role assignments"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff82abbf_6005a310","line":233,"range":{"start_line":233,"start_character":31,"end_line":233,"end_character":36},"in_reply_to":"ff82abbf_47be79b4","updated":"2017-11-28 17:49:00.000000000","message":"Done","commit_id":"758e08e291dc47eb1b7096c8e06fbce0d4349f04"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"a4beb5b8ca1851a21fc8b74970cdcda52877eed0","unresolved":false,"context_lines":[{"line_number":250,"context_line":"**Response**"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"* 200 - OK"},{"line_number":253,"context_line":"* 400 - Bad Request"},{"line_number":254,"context_line":"* 404 - Not Found if a role or user doesn\u0027t exist"},{"line_number":255,"context_line":"* 401 - If the operation isn\u0027t permitted to the user"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"**Response Body**"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff82abbf_87bfa1a8","line":254,"range":{"start_line":253,"start_character":0,"end_line":254,"end_character":49},"updated":"2017-11-28 16:21:37.000000000","message":"??? These don\u0027t look relevant.","commit_id":"758e08e291dc47eb1b7096c8e06fbce0d4349f04"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7c01ff0d1e01c24ea7052c4951b9d393af4f380c","unresolved":false,"context_lines":[{"line_number":250,"context_line":"**Response**"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"* 200 - OK"},{"line_number":253,"context_line":"* 400 - Bad Request"},{"line_number":254,"context_line":"* 404 - Not Found if a role or user doesn\u0027t exist"},{"line_number":255,"context_line":"* 401 - If the operation isn\u0027t permitted to the user"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"**Response Body**"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff82abbf_402bbf81","line":254,"range":{"start_line":253,"start_character":0,"end_line":254,"end_character":49},"in_reply_to":"ff82abbf_87bfa1a8","updated":"2017-11-28 17:49:00.000000000","message":"Totally - bad copy/paste. Fixed.","commit_id":"758e08e291dc47eb1b7096c8e06fbce0d4349f04"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"99973e83b5e69efde3cdd6291907ddb7215d45f4","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                    \"id\": \"ab29d6fff51c43478b00bb16bfb771fc\""},{"line_number":304,"context_line":"                },"},{"line_number":305,"context_line":"                \"scope\": {"},{"line_number":306,"context_line":"                    \"system\": \"true\""},{"line_number":307,"context_line":"                }"},{"line_number":308,"context_line":"            }"},{"line_number":309,"context_line":"        ],"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff82abbf_7a37b200","line":306,"range":{"start_line":306,"start_character":30,"end_line":306,"end_character":36},"updated":"2017-11-27 19:28:36.000000000","message":"nit - JSON has a native boolean, so this could just be true not \"true\". In your auth example you have it using a boolean.","commit_id":"758e08e291dc47eb1b7096c8e06fbce0d4349f04"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7c01ff0d1e01c24ea7052c4951b9d393af4f380c","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                    \"id\": \"ab29d6fff51c43478b00bb16bfb771fc\""},{"line_number":304,"context_line":"                },"},{"line_number":305,"context_line":"                \"scope\": {"},{"line_number":306,"context_line":"                    \"system\": \"true\""},{"line_number":307,"context_line":"                }"},{"line_number":308,"context_line":"            }"},{"line_number":309,"context_line":"        ],"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff82abbf_0021379f","line":306,"range":{"start_line":306,"start_character":30,"end_line":306,"end_character":36},"in_reply_to":"ff82abbf_2709f594","updated":"2017-11-28 17:49:00.000000000","message":"++ good catch!","commit_id":"758e08e291dc47eb1b7096c8e06fbce0d4349f04"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"a4beb5b8ca1851a21fc8b74970cdcda52877eed0","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                    \"id\": \"ab29d6fff51c43478b00bb16bfb771fc\""},{"line_number":304,"context_line":"                },"},{"line_number":305,"context_line":"                \"scope\": {"},{"line_number":306,"context_line":"                    \"system\": \"true\""},{"line_number":307,"context_line":"                }"},{"line_number":308,"context_line":"            }"},{"line_number":309,"context_line":"        ],"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff82abbf_2709f594","line":306,"range":{"start_line":306,"start_character":30,"end_line":306,"end_character":36},"in_reply_to":"ff82abbf_7a37b200","updated":"2017-11-28 16:21:37.000000000","message":"++ please use natives. Do not use stringified versions.","commit_id":"758e08e291dc47eb1b7096c8e06fbce0d4349f04"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"99973e83b5e69efde3cdd6291907ddb7215d45f4","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                }"},{"line_number":335,"context_line":"            },"},{"line_number":336,"context_line":"            \"scope\": {"},{"line_number":337,"context_line":"                \"system\": {"},{"line_number":338,"context_line":"                    \"all\": true"},{"line_number":339,"context_line":"                }"},{"line_number":340,"context_line":"            }"},{"line_number":341,"context_line":"        }"},{"line_number":342,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff82abbf_5a32ee11","line":339,"range":{"start_line":337,"start_character":16,"end_line":339,"end_character":17},"updated":"2017-11-27 19:28:36.000000000","message":"So when we create a role assignment it\u0027s `\"scope\": { \"system\": true }` but to get a token it\u0027s `\"scope\": { \"system\": { \"all\": true } }` ? Is that intentional?","commit_id":"758e08e291dc47eb1b7096c8e06fbce0d4349f04"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"a4beb5b8ca1851a21fc8b74970cdcda52877eed0","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                }"},{"line_number":335,"context_line":"            },"},{"line_number":336,"context_line":"            \"scope\": {"},{"line_number":337,"context_line":"                \"system\": {"},{"line_number":338,"context_line":"                    \"all\": true"},{"line_number":339,"context_line":"                }"},{"line_number":340,"context_line":"            }"},{"line_number":341,"context_line":"        }"},{"line_number":342,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff82abbf_e70c6d95","line":339,"range":{"start_line":337,"start_character":16,"end_line":339,"end_character":17},"in_reply_to":"ff82abbf_5a32ee11","updated":"2017-11-28 16:21:37.000000000","message":"I\u0027m not clear on \"all: true\" here (based on this doc). Please clarify.\n\nHowever, system: true for the role makes sense, it is a system role. However, if we\u0027re holding the multiple system types (I think we discussed that), we need this type of construct.","commit_id":"758e08e291dc47eb1b7096c8e06fbce0d4349f04"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7c01ff0d1e01c24ea7052c4951b9d393af4f380c","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                }"},{"line_number":335,"context_line":"            },"},{"line_number":336,"context_line":"            \"scope\": {"},{"line_number":337,"context_line":"                \"system\": {"},{"line_number":338,"context_line":"                    \"all\": true"},{"line_number":339,"context_line":"                }"},{"line_number":340,"context_line":"            }"},{"line_number":341,"context_line":"        }"},{"line_number":342,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff82abbf_a0b2cb47","line":339,"range":{"start_line":337,"start_character":16,"end_line":339,"end_character":17},"in_reply_to":"ff82abbf_e70c6d95","updated":"2017-11-28 17:49:00.000000000","message":"Yeah - I guess my intention here was to design this so that we can expand it further in the future to cover hierarchical system cases.\n\nEventually, it would be nice to do something like:\n\n  \"scope\": {\n      \"system\": {\n          \"region\": \"\u003cregion_id\u003e\"\n      }\n  }\n\nor\n\n  \"scope\": {\n      \"system\": {\n          \"region\": \"\u003cregion_id\u003e\",\n          \"service\": \"\u003cservice_id\u003e\n      }\n  }\n\nAs far as the role assignment goes, everything is on the path. In the future we could thing about doing something like \n\n  PUT /v3/system/regions/$REGION_ID/services/$SERVICE_ID/users/$USER_ID/roles/$ROLE_ID","commit_id":"758e08e291dc47eb1b7096c8e06fbce0d4349f04"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"f74d79650ac52f3a426dacda393d173cfce9b966","unresolved":false,"context_lines":[{"line_number":430,"context_line":"order to achieve global scoping. The `admin_project` is a special project that"},{"line_number":431,"context_line":"allows for elevated privileges if role assignments are given to that project."},{"line_number":432,"context_line":"Let\u0027s consider the following example. Let\u0027s say there is an `observer` role"},{"line_number":433,"context_line":"that allows users to do perform read-only operations within a specific scope."},{"line_number":434,"context_line":"If Bob has the `observer` role on project `foo`, he should be able to view"},{"line_number":435,"context_line":"things within that project. If Alice has the `observer` role on the"},{"line_number":436,"context_line":"`admin_project`, she should be able to view things across the deployment, like"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff82abbf_f4e5fddc","line":433,"range":{"start_line":433,"start_character":18,"end_line":433,"end_character":41},"updated":"2017-11-28 15:47:13.000000000","message":"nit: /s/to do perform read-only/to perform read-only/","commit_id":"758e08e291dc47eb1b7096c8e06fbce0d4349f04"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7c01ff0d1e01c24ea7052c4951b9d393af4f380c","unresolved":false,"context_lines":[{"line_number":430,"context_line":"order to achieve global scoping. The `admin_project` is a special project that"},{"line_number":431,"context_line":"allows for elevated privileges if role assignments are given to that project."},{"line_number":432,"context_line":"Let\u0027s consider the following example. Let\u0027s say there is an `observer` role"},{"line_number":433,"context_line":"that allows users to do perform read-only operations within a specific scope."},{"line_number":434,"context_line":"If Bob has the `observer` role on project `foo`, he should be able to view"},{"line_number":435,"context_line":"things within that project. If Alice has the `observer` role on the"},{"line_number":436,"context_line":"`admin_project`, she should be able to view things across the deployment, like"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ff82abbf_805307e2","line":433,"range":{"start_line":433,"start_character":18,"end_line":433,"end_character":41},"in_reply_to":"ff82abbf_f4e5fddc","updated":"2017-11-28 17:49:00.000000000","message":"Done","commit_id":"758e08e291dc47eb1b7096c8e06fbce0d4349f04"}]}
