)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"05a24a5f2a46504740a32f164e9854caaad150c9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"organization, ultimately being more useful in the real-world."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ia6ddf64b4483a73ab79c86d5d794cce561aa19e0"},{"line_number":20,"context_line":"Co-authored-By: Lance Bragstad \u003clbagstad@gmail.com\u003e"},{"line_number":21,"context_line":"Co-Authored-By: Jamie Lennox \u003cjamielennox@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_b3e3b405","line":20,"range":{"start_line":20,"start_character":32,"end_line":20,"end_character":40},"updated":"2018-05-04 19:25:15.000000000","message":"this should be my casual nick friday name..","commit_id":"b59f0c9dc168bc542c71b01c859e17aebdf2fe4c"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"250649e315e9bac39252ab4e4da18e1bb72deffb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"organization, ultimately being more useful in the real-world."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ia6ddf64b4483a73ab79c86d5d794cce561aa19e0"},{"line_number":20,"context_line":"Co-authored-By: Lance Bragstad \u003clbagstad@gmail.com\u003e"},{"line_number":21,"context_line":"Co-Authored-By: Jamie Lennox \u003cjamielennox@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_73d75cef","line":20,"range":{"start_line":20,"start_character":32,"end_line":20,"end_character":40},"in_reply_to":"5f7c97a3_b3e3b405","updated":"2018-05-04 19:41:52.000000000","message":"Lol. Lemme fix that.","commit_id":"b59f0c9dc168bc542c71b01c859e17aebdf2fe4c"}],"specs/keystone/rocky/define-default-roles.rst":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"bdaa6e4c52596047a329fd51afcd132e0e2578a3","unresolved":false,"context_lines":[{"line_number":59,"context_line":"general purpose ‘do-er’ role. It introduces granularity between the administrator(s)"},{"line_number":60,"context_line":"and everyone else."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"**admin**: This role will be only be considered appropriate for operations deemed too"},{"line_number":63,"context_line":"sensitive for anyone with a member role."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"The desired outcome of implementing the roles above is that projects should"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_b39f344f","line":62,"updated":"2018-05-04 19:36:48.000000000","message":"So, I\u0027m supposing that `admin` role implies that he will be able to do every that a `member` can do and a few more specific actions, as the same that a `member` will perform every auditor operations with some project specific actions, is that right?","commit_id":"b59f0c9dc168bc542c71b01c859e17aebdf2fe4c"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"250649e315e9bac39252ab4e4da18e1bb72deffb","unresolved":false,"context_lines":[{"line_number":59,"context_line":"general purpose ‘do-er’ role. It introduces granularity between the administrator(s)"},{"line_number":60,"context_line":"and everyone else."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"**admin**: This role will be only be considered appropriate for operations deemed too"},{"line_number":63,"context_line":"sensitive for anyone with a member role."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"The desired outcome of implementing the roles above is that projects should"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_f304cc7d","line":62,"in_reply_to":"5f7c97a3_b39f344f","updated":"2018-05-04 19:41:52.000000000","message":"Precisely. Using implied rules admin-\u003emember-\u003eauditor","commit_id":"b59f0c9dc168bc542c71b01c859e17aebdf2fe4c"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"184a04b6778851732559b3435e1a1ac5399165ca","unresolved":false,"context_lines":[{"line_number":59,"context_line":"general purpose ‘do-er’ role. It introduces granularity between the administrator(s)"},{"line_number":60,"context_line":"and everyone else."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"**admin**: This role will be only be considered appropriate for operations deemed too"},{"line_number":63,"context_line":"sensitive for anyone with a member role."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"The desired outcome of implementing the roles above is that projects should"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_d35bd084","line":62,"in_reply_to":"5f7c97a3_f304cc7d","updated":"2018-05-04 19:52:09.000000000","message":"Awesome","commit_id":"b59f0c9dc168bc542c71b01c859e17aebdf2fe4c"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"bdaa6e4c52596047a329fd51afcd132e0e2578a3","unresolved":false,"context_lines":[{"line_number":106,"context_line":"service’s API will need to be conducted between its developers with the Keystone team to assist"},{"line_number":107,"context_line":"in the process."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"+-------------+---------------------------+-----------------------------+---------------------------------+"},{"line_number":110,"context_line":"|             | auditor                   | member                      | admin                           |"},{"line_number":111,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":112,"context_line":"| **Project** | * volume:get              | * volume:get                | * volume:get                    |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_33bd64b7","line":109,"updated":"2018-05-04 19:36:48.000000000","message":"How are we gonna define as this first moment which actions any role will be enabling to be done on each project?","commit_id":"b59f0c9dc168bc542c71b01c859e17aebdf2fe4c"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"250649e315e9bac39252ab4e4da18e1bb72deffb","unresolved":false,"context_lines":[{"line_number":106,"context_line":"service’s API will need to be conducted between its developers with the Keystone team to assist"},{"line_number":107,"context_line":"in the process."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"+-------------+---------------------------+-----------------------------+---------------------------------+"},{"line_number":110,"context_line":"|             | auditor                   | member                      | admin                           |"},{"line_number":111,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":112,"context_line":"| **Project** | * volume:get              | * volume:get                | * volume:get                    |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_b3f6548f","line":109,"in_reply_to":"5f7c97a3_33bd64b7","updated":"2018-05-04 19:41:52.000000000","message":"I don\u0027t follow what you are asking, Raildo. Can you expand please?","commit_id":"b59f0c9dc168bc542c71b01c859e17aebdf2fe4c"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"f69679c300b08a8ecdd1375b5d2a04615949842f","unresolved":false,"context_lines":[{"line_number":106,"context_line":"service’s API will need to be conducted between its developers with the Keystone team to assist"},{"line_number":107,"context_line":"in the process."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"+-------------+---------------------------+-----------------------------+---------------------------------+"},{"line_number":110,"context_line":"|             | auditor                   | member                      | admin                           |"},{"line_number":111,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":112,"context_line":"| **Project** | * volume:get              | * volume:get                | * volume:get                    |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_b30ad423","line":109,"in_reply_to":"5f7c97a3_738f5ccc","updated":"2018-05-04 20:01:53.000000000","message":"Great question! You are looking at what will amount to phase two of this work -- which should come in the form of a Community Goal. Basically, it will require the Keystone team to assist each service in auditing their APIs (initially) so that everyone is on the same page with respect to what each role encapsulates (in broad strokes).\n\nThe Keystone team obviously can\u0027t know all of the fine details for each service and and their respective APIs but we can make sure everyone is looking at their APIs through the same \u0027lens\u0027 when mapping roles to actions.","commit_id":"b59f0c9dc168bc542c71b01c859e17aebdf2fe4c"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"39e2d620d1927d3bb547df2ca72e2e02662349f8","unresolved":false,"context_lines":[{"line_number":106,"context_line":"service’s API will need to be conducted between its developers with the Keystone team to assist"},{"line_number":107,"context_line":"in the process."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"+-------------+---------------------------+-----------------------------+---------------------------------+"},{"line_number":110,"context_line":"|             | auditor                   | member                      | admin                           |"},{"line_number":111,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":112,"context_line":"| **Project** | * volume:get              | * volume:get                | * volume:get                    |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_ae3827d3","line":109,"in_reply_to":"5f7c97a3_b30ad423","updated":"2018-05-04 20:04:22.000000000","message":"++ got it, that sounds like a great plan :)","commit_id":"b59f0c9dc168bc542c71b01c859e17aebdf2fe4c"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"184a04b6778851732559b3435e1a1ac5399165ca","unresolved":false,"context_lines":[{"line_number":106,"context_line":"service’s API will need to be conducted between its developers with the Keystone team to assist"},{"line_number":107,"context_line":"in the process."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"+-------------+---------------------------+-----------------------------+---------------------------------+"},{"line_number":110,"context_line":"|             | auditor                   | member                      | admin                           |"},{"line_number":111,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":112,"context_line":"| **Project** | * volume:get              | * volume:get                | * volume:get                    |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_738f5ccc","line":109,"in_reply_to":"5f7c97a3_b3f6548f","updated":"2018-05-04 19:52:09.000000000","message":"So, based on this example, you\u0027re saying that for the Cinder policy an auditor will be able to perform the `get` and `get_all` actions, member will be able to do get, get_all, create and update and so on... \n\nSo my questions are when we change all the services policy files to have those three default roles, how we\u0027re going to define which actions each role will be able to perform? In other words, Do you intend to explain somehow why we \"choose\" a user with a member to not delete a volume, or why we choose him to be able to update a volume?","commit_id":"b59f0c9dc168bc542c71b01c859e17aebdf2fe4c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"00ae0377f31ea7e5154b93966fc31bb589037cd5","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"This specification proposes that each service interested in offering basic RBAC,"},{"line_number":50,"context_line":"incorporate the following default roles into the service\u0027s default policies."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Default Roles"},{"line_number":53,"context_line":"-------------"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_73567c2c","line":51,"updated":"2018-05-04 20:05:33.000000000","message":"All of this sounds good, but it\u0027s pretty general since it was originally written for openstack-specs.\n\nInstead of \"each service\" we could just imply keystone.","commit_id":"54ef8cfb2b05b661b138780160cf3671b6327fdf"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"fec816e78f2317d589049d0f6b3b3af1fb954f36","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"This specification proposes that each service interested in offering basic RBAC,"},{"line_number":50,"context_line":"incorporate the following default roles into the service\u0027s default policies."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Default Roles"},{"line_number":53,"context_line":"-------------"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_24d2e55d","line":51,"in_reply_to":"5f7c97a3_73567c2c","updated":"2018-05-07 15:29:34.000000000","message":"Done","commit_id":"54ef8cfb2b05b661b138780160cf3671b6327fdf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"00ae0377f31ea7e5154b93966fc31bb589037cd5","unresolved":false,"context_lines":[{"line_number":85,"context_line":"--------"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"`auditor:`"},{"line_number":88,"context_line":"An example project-scoped application of this role would be listing volumes (``volume:get``)."},{"line_number":89,"context_line":"An example system-scoped application of this role would be listing service endpoints"},{"line_number":90,"context_line":"(``identity:list_endpoints``)."},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_f33fecd3","line":88,"range":{"start_line":88,"start_character":0,"end_line":88,"end_character":93},"updated":"2018-05-04 20:05:33.000000000","message":"This might not be relevant now that we\u0027re targeting this to keystone","commit_id":"54ef8cfb2b05b661b138780160cf3671b6327fdf"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"fec816e78f2317d589049d0f6b3b3af1fb954f36","unresolved":false,"context_lines":[{"line_number":85,"context_line":"--------"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"`auditor:`"},{"line_number":88,"context_line":"An example project-scoped application of this role would be listing volumes (``volume:get``)."},{"line_number":89,"context_line":"An example system-scoped application of this role would be listing service endpoints"},{"line_number":90,"context_line":"(``identity:list_endpoints``)."},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_4494c137","line":88,"range":{"start_line":88,"start_character":0,"end_line":88,"end_character":93},"in_reply_to":"5f7c97a3_f33fecd3","updated":"2018-05-07 15:29:34.000000000","message":"Done","commit_id":"54ef8cfb2b05b661b138780160cf3671b6327fdf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"00ae0377f31ea7e5154b93966fc31bb589037cd5","unresolved":false,"context_lines":[{"line_number":90,"context_line":"(``identity:list_endpoints``)."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"`member:`"},{"line_number":93,"context_line":"An example project-scoped application of this role would be creating a volume (``volume:create``)."},{"line_number":94,"context_line":"An example system-scope application of this role would be updating an endpoint"},{"line_number":95,"context_line":"(``identity:update_endpoint``)."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_b32174b7","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":98},"updated":"2018-05-04 20:05:33.000000000","message":"Same comment here. We could replace it with a project specific operation.","commit_id":"54ef8cfb2b05b661b138780160cf3671b6327fdf"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"fec816e78f2317d589049d0f6b3b3af1fb954f36","unresolved":false,"context_lines":[{"line_number":90,"context_line":"(``identity:list_endpoints``)."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"`member:`"},{"line_number":93,"context_line":"An example project-scoped application of this role would be creating a volume (``volume:create``)."},{"line_number":94,"context_line":"An example system-scope application of this role would be updating an endpoint"},{"line_number":95,"context_line":"(``identity:update_endpoint``)."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_248f4524","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":98},"in_reply_to":"5f7c97a3_b32174b7","updated":"2018-05-07 15:29:34.000000000","message":"Done","commit_id":"54ef8cfb2b05b661b138780160cf3671b6327fdf"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"fec816e78f2317d589049d0f6b3b3af1fb954f36","unresolved":false,"context_lines":[{"line_number":119,"context_line":"|             | * identity:get_endpoint   | * identity:get_endpoint     | * identity:get_endpoint         |"},{"line_number":120,"context_line":"|             |                           | * identity:update_endpoint  | * identity:update_endpoint      |"},{"line_number":121,"context_line":"|             |                           |                             | * identity:create_endpoint      |"},{"line_number":122,"context_line":"|             |                           |                             | * os_compute_api:os-hypervisors |"},{"line_number":123,"context_line":"|             |                           |                             | * os_compute_api:os-migrations  |"},{"line_number":124,"context_line":"+-------------+---------------------------+-----------------------------+---------------------------------+"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_84741937","line":123,"range":{"start_line":122,"start_character":76,"end_line":123,"end_character":104},"updated":"2018-05-07 15:29:34.000000000","message":"I think leaving in these examples is good as it emphasizes where we want to go with system scope","commit_id":"54ef8cfb2b05b661b138780160cf3671b6327fdf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"00ae0377f31ea7e5154b93966fc31bb589037cd5","unresolved":false,"context_lines":[{"line_number":190,"context_line":"**Steve** can list volumes, create new volumes, get details about a specific volume, update a volume,"},{"line_number":191,"context_line":"and delete volumes within Project Alpha. He cannot perform any system specific policies because his"},{"line_number":192,"context_line":"authorization is on a single project."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Risk Mitigation"},{"line_number":195,"context_line":"---------------"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_331fa46d","line":193,"updated":"2018-05-04 20:05:33.000000000","message":"If we decide to re-do these examples in favor of keystone-specific ones, we should stash this away somewhere so that we can pull it out when we decide to propose this for a community goal.","commit_id":"54ef8cfb2b05b661b138780160cf3671b6327fdf"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"fec816e78f2317d589049d0f6b3b3af1fb954f36","unresolved":false,"context_lines":[{"line_number":190,"context_line":"**Steve** can list volumes, create new volumes, get details about a specific volume, update a volume,"},{"line_number":191,"context_line":"and delete volumes within Project Alpha. He cannot perform any system specific policies because his"},{"line_number":192,"context_line":"authorization is on a single project."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Risk Mitigation"},{"line_number":195,"context_line":"---------------"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_a4f91581","line":193,"in_reply_to":"5f7c97a3_331fa46d","updated":"2018-05-07 15:29:34.000000000","message":"They still reside in the openstack-specs review[1] we abandoned in lieu of. Let this serve as a proper bookmark :)\n\n[1] - https://review.openstack.org/#/c/523973/","commit_id":"54ef8cfb2b05b661b138780160cf3671b6327fdf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"00ae0377f31ea7e5154b93966fc31bb589037cd5","unresolved":false,"context_lines":[{"line_number":235,"context_line":"Work Items"},{"line_number":236,"context_line":"----------"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"* Determine if this is something that needs to be implemented using a"},{"line_number":239,"context_line":"  `community goal \u003chttps://governance.openstack.org/tc/goals/\u003e`_"},{"line_number":240,"context_line":"* Set up a way to track progress (e.g. using launchpad bugs, community goal"},{"line_number":241,"context_line":"  completion artifacts, burndown charts, etc...)"},{"line_number":242,"context_line":"* Coordinate the changes in *each* OpenStack project and assist `patrole"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_73043c18","line":239,"range":{"start_line":238,"start_character":0,"end_line":239,"end_character":64},"updated":"2018-05-04 20:05:33.000000000","message":"This is going to be done at a later time. We should totally revisit this once we get this implemented in keystone and a couple other projects.","commit_id":"54ef8cfb2b05b661b138780160cf3671b6327fdf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"00ae0377f31ea7e5154b93966fc31bb589037cd5","unresolved":false,"context_lines":[{"line_number":245,"context_line":"  policy"},{"line_number":246,"context_line":"* Create a community `tag \u003chttps://governance.openstack.org/tc/reference/tags/index.html\u003e`_"},{"line_number":247,"context_line":"  so services may assert addition of default roles, defined in this spec, to their respective"},{"line_number":248,"context_line":"  policy files."},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"Dependencies"},{"line_number":251,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_ce21e3a1","line":248,"updated":"2018-05-04 20:05:33.000000000","message":"We should redo this list. Maybe:\n\n  - Implement auditor role across policies\n  - Implement member role across policies\n  - Implement admin role across policies\n  - Implement scope_types for all policies in keystone\n  - Remove @protected decorator\n\nI think if we get that far, we\u0027ll be making things really clear for other projects to see how to do this work.","commit_id":"54ef8cfb2b05b661b138780160cf3671b6327fdf"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"fec816e78f2317d589049d0f6b3b3af1fb954f36","unresolved":false,"context_lines":[{"line_number":245,"context_line":"  policy"},{"line_number":246,"context_line":"* Create a community `tag \u003chttps://governance.openstack.org/tc/reference/tags/index.html\u003e`_"},{"line_number":247,"context_line":"  so services may assert addition of default roles, defined in this spec, to their respective"},{"line_number":248,"context_line":"  policy files."},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"Dependencies"},{"line_number":251,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_c4521168","line":248,"in_reply_to":"5f7c97a3_ce21e3a1","updated":"2018-05-07 15:29:34.000000000","message":"Done","commit_id":"54ef8cfb2b05b661b138780160cf3671b6327fdf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"00ae0377f31ea7e5154b93966fc31bb589037cd5","unresolved":false,"context_lines":[{"line_number":278,"context_line":"* Previous `attempts \u003chttps://review.openstack.org/#/c/245629\u003e`_ at providing"},{"line_number":279,"context_line":"  default roles"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"History"},{"line_number":282,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":".. list-table:: Revisions"},{"line_number":285,"context_line":"   :header-rows: 1"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"   * - Release Name"},{"line_number":288,"context_line":"     - Description"},{"line_number":289,"context_line":"   * - Queens"},{"line_number":290,"context_line":"     - Introduced"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":".. note::"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"  This work is licensed under a Creative Commons Attribution 3.0 Unported License."},{"line_number":295,"context_line":"  http://creativecommons.org/licenses/by/3.0/legalcode"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_8e3bebcf","line":292,"range":{"start_line":281,"start_character":0,"end_line":292,"end_character":9},"updated":"2018-05-04 20:05:33.000000000","message":"This might not be relevant since keystone-specs doesn\u0027t really follow this format.","commit_id":"54ef8cfb2b05b661b138780160cf3671b6327fdf"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"fec816e78f2317d589049d0f6b3b3af1fb954f36","unresolved":false,"context_lines":[{"line_number":278,"context_line":"* Previous `attempts \u003chttps://review.openstack.org/#/c/245629\u003e`_ at providing"},{"line_number":279,"context_line":"  default roles"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"History"},{"line_number":282,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":".. list-table:: Revisions"},{"line_number":285,"context_line":"   :header-rows: 1"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"   * - Release Name"},{"line_number":288,"context_line":"     - Description"},{"line_number":289,"context_line":"   * - Queens"},{"line_number":290,"context_line":"     - Introduced"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":".. note::"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"  This work is licensed under a Creative Commons Attribution 3.0 Unported License."},{"line_number":295,"context_line":"  http://creativecommons.org/licenses/by/3.0/legalcode"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_5f9ecc63","line":292,"range":{"start_line":281,"start_character":0,"end_line":292,"end_character":9},"in_reply_to":"5f7c97a3_8e3bebcf","updated":"2018-05-07 15:29:34.000000000","message":"Done","commit_id":"54ef8cfb2b05b661b138780160cf3671b6327fdf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"81f92abb703de152b8a3697b7dda27f03a88e8cb","unresolved":false,"context_lines":[{"line_number":46,"context_line":"improve default role definitions. The changing defaults can be consumed by"},{"line_number":47,"context_line":"operators in ways that are consistent with changing configuration options."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"This specification proposes that each Keystone enhance the basic RBAC experience"},{"line_number":50,"context_line":"by incorporating the following default roles into its default policies."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Default Roles"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_c572f449","line":49,"range":{"start_line":49,"start_character":33,"end_line":49,"end_character":37},"updated":"2018-05-08 17:16:50.000000000","message":"nit: s/each//","commit_id":"713968c09467fc92e84fff12f435dcf889d7ee5e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"81f92abb703de152b8a3697b7dda27f03a88e8cb","unresolved":false,"context_lines":[{"line_number":47,"context_line":"operators in ways that are consistent with changing configuration options."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"This specification proposes that each Keystone enhance the basic RBAC experience"},{"line_number":50,"context_line":"by incorporating the following default roles into its default policies."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Default Roles"},{"line_number":53,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_059eac53","line":50,"updated":"2018-05-08 17:16:50.000000000","message":"nit: We could include a statement here about building that out so that other services can use it as a template.","commit_id":"713968c09467fc92e84fff12f435dcf889d7ee5e"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"47435dda357a5eb97367336b133605ec45865e69","unresolved":false,"context_lines":[{"line_number":47,"context_line":"operators in ways that are consistent with changing configuration options."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"This specification proposes that each Keystone enhance the basic RBAC experience"},{"line_number":50,"context_line":"by incorporating the following default roles into its default policies."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Default Roles"},{"line_number":53,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_991d32bf","line":50,"in_reply_to":"5f7c97a3_059eac53","updated":"2018-05-11 16:19:18.000000000","message":"Done","commit_id":"713968c09467fc92e84fff12f435dcf889d7ee5e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"81f92abb703de152b8a3697b7dda27f03a88e8cb","unresolved":false,"context_lines":[{"line_number":85,"context_line":"--------"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"`auditor:`"},{"line_number":88,"context_line":"An example project-scoped application of this role would be listing project tags (``identity:get_project_tags``)."},{"line_number":89,"context_line":"An example system-scoped application of this role would be listing service endpoints"},{"line_number":90,"context_line":"(``identity:list_endpoints``)."},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_85d63c27","line":88,"range":{"start_line":88,"start_character":93,"end_line":88,"end_character":109},"updated":"2018-05-08 17:16:50.000000000","message":"Nice - this is about as good of an example as we\u0027re going to get with keystone-specific APIs.","commit_id":"713968c09467fc92e84fff12f435dcf889d7ee5e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"81f92abb703de152b8a3697b7dda27f03a88e8cb","unresolved":false,"context_lines":[{"line_number":230,"context_line":"Primary assignee:"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"  Lance Bragstad lbragstad lbragstad@gmail.com"},{"line_number":233,"context_line":"  Harry Rybacki hrybacki hrybacki@redhat.com"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"Work Items"},{"line_number":236,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_85a4fcba","line":233,"updated":"2018-05-08 17:16:50.000000000","message":"nit: We should have this render as a list:\n\n  Primary assignee:\n\n  * Lance Bragstad lbragstad \u003clbragstad@gmail.com\u003e\n  * Harry Rybacki hrybacki \u003chrybacki@redhat.com\u003e","commit_id":"713968c09467fc92e84fff12f435dcf889d7ee5e"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"47435dda357a5eb97367336b133605ec45865e69","unresolved":false,"context_lines":[{"line_number":230,"context_line":"Primary assignee:"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"  Lance Bragstad lbragstad lbragstad@gmail.com"},{"line_number":233,"context_line":"  Harry Rybacki hrybacki hrybacki@redhat.com"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"Work Items"},{"line_number":236,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_d9688a22","line":233,"in_reply_to":"5f7c97a3_85a4fcba","updated":"2018-05-11 16:19:18.000000000","message":"Done","commit_id":"713968c09467fc92e84fff12f435dcf889d7ee5e"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"dd61fb23e24c558fa424f8ca86ab9b21734e9aad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5f7c97a3_9165fde3","updated":"2018-05-09 22:03:40.000000000","message":"Usually there is a security impact for these specs, I think covering existing roles when implementing this covers that basis though.","commit_id":"84f38ae645987520c87b710b7832dcfb3856aa37"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"9c05e8fbfc5771a7745c1625804d336923529d5d","unresolved":false,"context_lines":[{"line_number":107,"context_line":"The following table is neither a final nor a comprehensive list of all possible rules/policies."},{"line_number":108,"context_line":"It serves merely as a snippet of existing rules to showcase how policies, scope, and the new"},{"line_number":109,"context_line":"default roles can work together to provide a richer policy experience. Reviews specific to each"},{"line_number":110,"context_line":"service’s API will need to be conducted between its developers with the Keystone team to assist"},{"line_number":111,"context_line":"in the process."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"+-------------+------------------------------+---------------------------------+---------------------------------+"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_b256d229","line":110,"range":{"start_line":110,"start_character":7,"end_line":110,"end_character":8},"updated":"2018-05-11 15:30:18.000000000","message":"nit: I\u0027ve seen patchsets dedicated to changing this to \u0027 (the \"standard\" apostrophe) due to rendering issues for some people.","commit_id":"84f38ae645987520c87b710b7832dcfb3856aa37"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"90926526ac4011be9c9057bd48ebb4f11cb18a17","unresolved":false,"context_lines":[{"line_number":107,"context_line":"The following table is neither a final nor a comprehensive list of all possible rules/policies."},{"line_number":108,"context_line":"It serves merely as a snippet of existing rules to showcase how policies, scope, and the new"},{"line_number":109,"context_line":"default roles can work together to provide a richer policy experience. Reviews specific to each"},{"line_number":110,"context_line":"service’s API will need to be conducted between its developers with the Keystone team to assist"},{"line_number":111,"context_line":"in the process."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"+-------------+------------------------------+---------------------------------+---------------------------------+"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_d8e04d29","line":110,"range":{"start_line":110,"start_character":7,"end_line":110,"end_character":8},"in_reply_to":"5f7c97a3_b256d229","updated":"2018-05-15 15:11:06.000000000","message":"Done","commit_id":"84f38ae645987520c87b710b7832dcfb3856aa37"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"12eb5d1deb900160bccf30a7251e56dacd11ba0e","unresolved":false,"context_lines":[{"line_number":137,"context_line":"  \u003chttps://docs.openstack.org/python-openstackclient/latest/cli/command-objects/implied_role.html\u003e`_."},{"line_number":138,"context_line":"  As indicated in the above table, having ``admin`` role implies a user also has the same rights as"},{"line_number":139,"context_line":"  the ``member`` role. Therefore this user will also has the same rights as the ``auditor`` role as"},{"line_number":140,"context_line":"  ``member`` implies ``auditor``."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"  This keeps policy files clean. For example:"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_328082bf","line":140,"updated":"2018-05-11 15:24:34.000000000","message":"Do you think this will impact documentation in any way? What I mean is that documenting implied roles in policy in code will likely still be required and good practice. \n\nWhat I mean is that if one were to look at https://github.com/openstack/keystone/blob/master/keystone/common/policies/base.py to determine which roles apply to which rules, it might not be clear unless one digs deeper and considers implied roles too.","commit_id":"84f38ae645987520c87b710b7832dcfb3856aa37"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"47435dda357a5eb97367336b133605ec45865e69","unresolved":false,"context_lines":[{"line_number":137,"context_line":"  \u003chttps://docs.openstack.org/python-openstackclient/latest/cli/command-objects/implied_role.html\u003e`_."},{"line_number":138,"context_line":"  As indicated in the above table, having ``admin`` role implies a user also has the same rights as"},{"line_number":139,"context_line":"  the ``member`` role. Therefore this user will also has the same rights as the ``auditor`` role as"},{"line_number":140,"context_line":"  ``member`` implies ``auditor``."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"  This keeps policy files clean. For example:"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_1896c594","line":140,"in_reply_to":"5f7c97a3_328082bf","updated":"2018-05-11 16:19:18.000000000","message":"This is an interesting point, Felipe. How we will make the fact that the roles have an implication chain apparent is not obvious to me at the moment. I\u0027ll raise this discussion and incorporate the results.","commit_id":"84f38ae645987520c87b710b7832dcfb3856aa37"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"dd61fb23e24c558fa424f8ca86ab9b21734e9aad","unresolved":false,"context_lines":[{"line_number":216,"context_line":"Alternatives"},{"line_number":217,"context_line":"------------"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"reader/writer/admin vs auditor/nember/admin. There was much debate regarding the naming"},{"line_number":220,"context_line":"conventions for these roles. We have opted to use `auditor`, `member`, and `admin` as we"},{"line_number":221,"context_line":"believe they most accurately describe their purpose when the context of OpenStack is taken"},{"line_number":222,"context_line":"into consideration."}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_4e9a606e","line":219,"range":{"start_line":219,"start_character":31,"end_line":219,"end_character":32},"updated":"2018-05-09 22:03:40.000000000","message":"m","commit_id":"84f38ae645987520c87b710b7832dcfb3856aa37"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"90926526ac4011be9c9057bd48ebb4f11cb18a17","unresolved":false,"context_lines":[{"line_number":216,"context_line":"Alternatives"},{"line_number":217,"context_line":"------------"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"reader/writer/admin vs auditor/nember/admin. There was much debate regarding the naming"},{"line_number":220,"context_line":"conventions for these roles. We have opted to use `auditor`, `member`, and `admin` as we"},{"line_number":221,"context_line":"believe they most accurately describe their purpose when the context of OpenStack is taken"},{"line_number":222,"context_line":"into consideration."}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_98d8957b","line":219,"range":{"start_line":219,"start_character":31,"end_line":219,"end_character":32},"in_reply_to":"5f7c97a3_4e9a606e","updated":"2018-05-15 15:11:06.000000000","message":"Done","commit_id":"84f38ae645987520c87b710b7832dcfb3856aa37"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8bdd7ed45e8faf3e65459b65322d257cc9371270","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"   The chain of implied roles will be documented alongside of the `policy-in-code defaults"},{"line_number":148,"context_line":"   \u003chttps://github.com/openstack/keystone/blob/master/keystone/common/policies/base.py\u003e`_ in addition to"},{"line_number":149,"context_line":"   general Keystone documentation updates noting as much."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"::"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5f7c97a3_a8497ab7","line":149,"updated":"2018-05-11 21:46:07.000000000","message":"implementation detail question: but does this mean the role implication will get rendered for every policy?","commit_id":"6461d15ba7b79edef306b458c241cf1c13313400"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"90926526ac4011be9c9057bd48ebb4f11cb18a17","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"   The chain of implied roles will be documented alongside of the `policy-in-code defaults"},{"line_number":148,"context_line":"   \u003chttps://github.com/openstack/keystone/blob/master/keystone/common/policies/base.py\u003e`_ in addition to"},{"line_number":149,"context_line":"   general Keystone documentation updates noting as much."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"::"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5f7c97a3_3ab1f947","line":149,"in_reply_to":"5f7c97a3_a8497ab7","updated":"2018-05-15 15:11:06.000000000","message":"Lance, I imagine that once this moves into the realm of \u0027community goal\u0027 it will just be centrally documented within Keystone docs where we note the roles that are already being created during the bootstrap process.","commit_id":"6461d15ba7b79edef306b458c241cf1c13313400"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7494f2ec86231c3dab1e947cb13c9dd25302d03b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"more sophisticated RBAC solution. This is a confusing and incredibly tough"},{"line_number":24,"context_line":"maintenance burden for operators who customize policy."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"It\u0027s not uncommon to see various services hardcode operations to a specific"},{"line_number":27,"context_line":"role. While the operation may require that role, the role to policy mapping"},{"line_number":28,"context_line":"should be driven by policy defaults that can be overridden by operators instead"},{"line_number":29,"context_line":"of hardcoding."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_f0ffd431","line":29,"range":{"start_line":26,"start_character":0,"end_line":29,"end_character":14},"updated":"2018-05-18 19:39:09.000000000","message":"FWIW - I don\u0027t think we do this so much with the keystone API (the trust API might)? This is probably more relevant to OpenStack as a whole, specifically other services.\n\nWe can keep it since I certainly don\u0027t think the extra context hurts.","commit_id":"0e9213051892816032f95064bd02722397ae7870"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7494f2ec86231c3dab1e947cb13c9dd25302d03b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"Scope Type (Refresher)"},{"line_number":75,"context_line":"----------------------"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"**project-scope**: Project-scope express relates to authorization for operating in a"},{"line_number":78,"context_line":"specific tenancy of the cloud."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"**system-scope**: System-scope relates to authorization for operating with APIs that"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_7099841d","line":77,"range":{"start_line":77,"start_character":33,"end_line":77,"end_character":40},"updated":"2018-05-18 19:39:09.000000000","message":"nit: s/express// ?","commit_id":"0e9213051892816032f95064bd02722397ae7870"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"5644aa4c30965f3c239da75370e28e9de948839e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"Scope Type (Refresher)"},{"line_number":75,"context_line":"----------------------"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"**project-scope**: Project-scope express relates to authorization for operating in a"},{"line_number":78,"context_line":"specific tenancy of the cloud."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"**system-scope**: System-scope relates to authorization for operating with APIs that"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_e0e5b439","line":77,"range":{"start_line":77,"start_character":33,"end_line":77,"end_character":40},"in_reply_to":"5f7c97a3_7099841d","updated":"2018-05-20 17:40:13.000000000","message":"Done","commit_id":"0e9213051892816032f95064bd02722397ae7870"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7494f2ec86231c3dab1e947cb13c9dd25302d03b","unresolved":false,"context_lines":[{"line_number":78,"context_line":"specific tenancy of the cloud."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"**system-scope**: System-scope relates to authorization for operating with APIs that"},{"line_number":81,"context_line":"do not fall nicely into concept of Project scope. It is **not** meant to cover *all*"},{"line_number":82,"context_line":"APIs across a deployment. Note that this level of scope is an effort currently being"},{"line_number":83,"context_line":"implemented in Keystone. More information about system-scope can be found in the `specification"},{"line_number":84,"context_line":"\u003chttp://specs.openstack.org/openstack/keystone-specs/specs/keystone/queens/system-scope.html\u003e`_,"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_30a30c52","line":81,"range":{"start_line":81,"start_character":3,"end_line":81,"end_character":48},"updated":"2018-05-18 19:39:09.000000000","message":"nit: do not map nicely to the concept of project-scope. ?","commit_id":"0e9213051892816032f95064bd02722397ae7870"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7494f2ec86231c3dab1e947cb13c9dd25302d03b","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"**system-scope**: System-scope relates to authorization for operating with APIs that"},{"line_number":81,"context_line":"do not fall nicely into concept of Project scope. It is **not** meant to cover *all*"},{"line_number":82,"context_line":"APIs across a deployment. Note that this level of scope is an effort currently being"},{"line_number":83,"context_line":"implemented in Keystone. More information about system-scope can be found in the `specification"},{"line_number":84,"context_line":"\u003chttp://specs.openstack.org/openstack/keystone-specs/specs/keystone/queens/system-scope.html\u003e`_,"},{"line_number":85,"context_line":"along with relevant historical context justifying the `need for system-scope"},{"line_number":86,"context_line":"\u003chttps://bugs.launchpad.net/keystone/+bug/968696\u003e`_."}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_b08e3cce","line":83,"range":{"start_line":82,"start_character":25,"end_line":83,"end_character":24},"updated":"2018-05-18 19:39:09.000000000","message":"I think this bit is implied by the fact this is a keystone spec.","commit_id":"0e9213051892816032f95064bd02722397ae7870"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"5644aa4c30965f3c239da75370e28e9de948839e","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"**system-scope**: System-scope relates to authorization for operating with APIs that"},{"line_number":81,"context_line":"do not fall nicely into concept of Project scope. It is **not** meant to cover *all*"},{"line_number":82,"context_line":"APIs across a deployment. Note that this level of scope is an effort currently being"},{"line_number":83,"context_line":"implemented in Keystone. More information about system-scope can be found in the `specification"},{"line_number":84,"context_line":"\u003chttp://specs.openstack.org/openstack/keystone-specs/specs/keystone/queens/system-scope.html\u003e`_,"},{"line_number":85,"context_line":"along with relevant historical context justifying the `need for system-scope"},{"line_number":86,"context_line":"\u003chttps://bugs.launchpad.net/keystone/+bug/968696\u003e`_."}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_40c0287d","line":83,"range":{"start_line":82,"start_character":25,"end_line":83,"end_character":24},"in_reply_to":"5f7c97a3_b08e3cce","updated":"2018-05-20 17:40:13.000000000","message":"Done","commit_id":"0e9213051892816032f95064bd02722397ae7870"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"4ee3245c446aff4f41f1a770609a7c37ee7252ab","unresolved":false,"context_lines":[{"line_number":94,"context_line":"(``identity:list_endpoints``)."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"`member:`"},{"line_number":97,"context_line":"An example project-scoped application of this role would be creating a project tag (``identity:create_project_tag``)."},{"line_number":98,"context_line":"An example system-scope application of this role would be updating an endpoint"},{"line_number":99,"context_line":"(``identity:update_endpoint``)."},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_a6e890b2","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":117},"updated":"2018-05-15 18:12:21.000000000","message":"This is in fact an admin operation.","commit_id":"0e9213051892816032f95064bd02722397ae7870"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"5644aa4c30965f3c239da75370e28e9de948839e","unresolved":false,"context_lines":[{"line_number":94,"context_line":"(``identity:list_endpoints``)."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"`member:`"},{"line_number":97,"context_line":"An example project-scoped application of this role would be creating a project tag (``identity:create_project_tag``)."},{"line_number":98,"context_line":"An example system-scope application of this role would be updating an endpoint"},{"line_number":99,"context_line":"(``identity:update_endpoint``)."},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_204acc26","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":117},"in_reply_to":"5f7c97a3_a6e890b2","updated":"2018-05-20 17:40:13.000000000","message":"Very few things seem to map to member only it would appear. I\u0027m leaving this in just to server as an example. Obviously we won\u0027t let this land as such when we audit our APIs during implementation though.","commit_id":"0e9213051892816032f95064bd02722397ae7870"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7494f2ec86231c3dab1e947cb13c9dd25302d03b","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"The following table is neither a final nor a comprehensive list of all possible rules/policies."},{"line_number":108,"context_line":"It serves merely as a snippet of existing rules to showcase how policies, scope, and the new"},{"line_number":109,"context_line":"default roles can work together to provide a richer policy experience. Reviews specific to each"},{"line_number":110,"context_line":"service\u0027s API will need to be conducted between its developers with the Keystone team to assist"},{"line_number":111,"context_line":"in the process."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"+-------------+------------------------------+---------------------------------+---------------------------------+"},{"line_number":114,"context_line":"|             | auditor                      | member                          | admin                           |"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_d0b0988e","line":111,"range":{"start_line":109,"start_character":71,"end_line":111,"end_character":15},"updated":"2018-05-18 19:39:09.000000000","message":"I think we can omit this, since this specification is keystone-specific.","commit_id":"0e9213051892816032f95064bd02722397ae7870"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"5644aa4c30965f3c239da75370e28e9de948839e","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"The following table is neither a final nor a comprehensive list of all possible rules/policies."},{"line_number":108,"context_line":"It serves merely as a snippet of existing rules to showcase how policies, scope, and the new"},{"line_number":109,"context_line":"default roles can work together to provide a richer policy experience. Reviews specific to each"},{"line_number":110,"context_line":"service\u0027s API will need to be conducted between its developers with the Keystone team to assist"},{"line_number":111,"context_line":"in the process."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"+-------------+------------------------------+---------------------------------+---------------------------------+"},{"line_number":114,"context_line":"|             | auditor                      | member                          | admin                           |"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_00ba3009","line":111,"range":{"start_line":109,"start_character":71,"end_line":111,"end_character":15},"in_reply_to":"5f7c97a3_d0b0988e","updated":"2018-05-20 17:40:13.000000000","message":"Done","commit_id":"0e9213051892816032f95064bd02722397ae7870"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7494f2ec86231c3dab1e947cb13c9dd25302d03b","unresolved":false,"context_lines":[{"line_number":210,"context_line":"This issue may be mitigated through the use of implied roles. Operators need simply to ensure that"},{"line_number":211,"context_line":"``auditor`` implies ``Role X``. Please review the documentation on `implied roles"},{"line_number":212,"context_line":"\u003chttps://docs.openstack.org/python-openstackclient/latest/cli/command-objects/implied_role.html\u003e`_. for"},{"line_number":213,"context_line":"specific instructions on how make one role imply another."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"**Scenario Two -- An existing ``auditor``, ``member``, or ``admin`` role already exists**: Let us assume"},{"line_number":216,"context_line":"that Deployment B already has a ``member`` role. Keystone will not attempt to overwrite any existing roles"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_f02034b3","line":213,"updated":"2018-05-18 19:39:09.000000000","message":"Another option:\n\nIf Role X already does what auditor does, and if a deployment already uses Role X, then all they have to do is maintain their custom policies as overrides. Instead of using what we\u0027re going to implement by default, they should be able to just maintain what they have.\n\nThe only thing they should notice is that now an \u0027auditor\u0027 role exists in their deployment that isn\u0027t used anywhere.","commit_id":"0e9213051892816032f95064bd02722397ae7870"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"5644aa4c30965f3c239da75370e28e9de948839e","unresolved":false,"context_lines":[{"line_number":210,"context_line":"This issue may be mitigated through the use of implied roles. Operators need simply to ensure that"},{"line_number":211,"context_line":"``auditor`` implies ``Role X``. Please review the documentation on `implied roles"},{"line_number":212,"context_line":"\u003chttps://docs.openstack.org/python-openstackclient/latest/cli/command-objects/implied_role.html\u003e`_. for"},{"line_number":213,"context_line":"specific instructions on how make one role imply another."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"**Scenario Two -- An existing ``auditor``, ``member``, or ``admin`` role already exists**: Let us assume"},{"line_number":216,"context_line":"that Deployment B already has a ``member`` role. Keystone will not attempt to overwrite any existing roles"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_805c00ee","line":213,"in_reply_to":"5f7c97a3_f02034b3","updated":"2018-05-20 17:40:13.000000000","message":"True. I think this is fine as is. Just because certain roles are created during deployment certainly doesn\u0027t imply they need to be kept/used.","commit_id":"0e9213051892816032f95064bd02722397ae7870"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7494f2ec86231c3dab1e947cb13c9dd25302d03b","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"Assignee(s)"},{"line_number":232,"context_line":"-----------"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"I am certainly looking for other folks who are interested in helping with this"},{"line_number":235,"context_line":"work. This will likely impact a lot of OpenStack projects, and distributing the"},{"line_number":236,"context_line":"work across a team of people who understand the change makes sense."},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"Primary assignee:"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_5019e885","line":236,"range":{"start_line":233,"start_character":0,"end_line":236,"end_character":67},"updated":"2018-05-18 19:39:09.000000000","message":"We could remove this bit since it\u0027s worded specifically to cross-project collaboration.","commit_id":"0e9213051892816032f95064bd02722397ae7870"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"5644aa4c30965f3c239da75370e28e9de948839e","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"Assignee(s)"},{"line_number":232,"context_line":"-----------"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"I am certainly looking for other folks who are interested in helping with this"},{"line_number":235,"context_line":"work. This will likely impact a lot of OpenStack projects, and distributing the"},{"line_number":236,"context_line":"work across a team of people who understand the change makes sense."},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"Primary assignee:"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_e05374e1","line":236,"range":{"start_line":233,"start_character":0,"end_line":236,"end_character":67},"in_reply_to":"5f7c97a3_5019e885","updated":"2018-05-20 17:40:13.000000000","message":"Done","commit_id":"0e9213051892816032f95064bd02722397ae7870"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"c7ec10df91588baa58aca7ee288ec871d9e5e63f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"Default Roles"},{"line_number":57,"context_line":"-------------"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"**auditor**: It should only be used for read-only APIs and operations. Alternatively"},{"line_number":60,"context_line":"referred to as ``reader``, this role fills an extremely popular need from operators."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"**member**: serves as the"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f7c97a3_0fe0f0f9","line":59,"range":{"start_line":59,"start_character":2,"end_line":59,"end_character":9},"updated":"2018-05-23 17:52:00.000000000","message":"Adding note that we should bikeshed a ton on the name.","commit_id":"acfc05ae9655702c096aa43e875c17c38339caec"}]}
